platform/upstream/libSkiaSharp.git
9 years agoPre-cache fDirection and fConvexity for recorded SkPaths too.
mtklein [Tue, 20 Jan 2015 21:47:19 +0000 (13:47 -0800)]
Pre-cache fDirection and fConvexity for recorded SkPaths too.

http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN/builds/1211/steps/dm/logs/stdio

I don't see any big perf hit locally:

desk_googlespreadsheetdashed.skp 1.68ms -> 1.74ms 1.04x
             desk_mobilenews.skp  643us ->  665us 1.04x
               desk_tigersvg.skp 51.1us -> 52.5us 1.03x
     desk_jsfiddlehumperclip.skp   37us -> 37.9us 1.02x
               desk_samoasvg.skp  373us ->  380us 1.02x
              desk_wordpress.skp  697us ->  708us 1.02x
                 desk_mapsvg.skp  698us ->  708us 1.02x
             tabl_googleblog.skp  553us ->  560us 1.01x
                desk_wowwiki.skp 1.31ms -> 1.32ms 1.01x
                tabl_mozilla.skp 1.44ms -> 1.45ms 1.01x
                 desk_sfgate.skp  156us ->  157us 1.01x
             desk_chalkboard.skp  376us ->  378us 1x
                  desk_baidu.skp  101us ->  101us 1x
            desk_gmailthread.skp  231us ->  231us 1x
                 desk_carsvg.skp  379us ->  379us 1x
             desk_googlehome.skp 38.1us -> 38.1us 1x
          desk_css3gradients.skp 89.6us -> 89.2us 1x
      desk_googlespreadsheet.skp  549us ->  546us 0.99x
            desk_pokemonwiki.skp 8.67ms -> 8.62ms 0.99x
                    tabl_mlb.skp  294us ->  291us 0.99x
            tabl_gamedeksiam.skp  700us ->  692us 0.99x
           tabl_worldjournal.skp  143us ->  142us 0.99x
                desk_blogger.skp  441us ->  436us 0.99x
                desk_twitter.skp  452us ->  446us 0.99x
                    desk_gws.skp  152us ->  150us 0.99x
                  tabl_gmail.skp 24.2us -> 23.9us 0.99x
                tabl_sahadan.skp 84.7us -> 83.5us 0.99x
                    tabl_cnn.skp 1.24ms -> 1.22ms 0.99x
                  tabl_ukwsj.skp  543us ->  535us 0.99x
           desk_yahooanswers.skp  124us ->  123us 0.99x
                desk_booking.skp  905us ->  891us 0.98x
          tabl_androidpolice.skp 1.76ms -> 1.73ms 0.98x
          desk_ugamsolutions.skp  281us ->  276us 0.98x
                desk_nytimes.skp  209us ->  204us 0.98x
               tabl_techmeme.skp 98.4us -> 96.1us 0.98x
                 tabl_nofolo.skp 59.2us -> 57.8us 0.98x
                desk_weather.skp  244us ->  238us 0.98x
               desk_facebook.skp  546us ->  531us 0.97x
               desk_linkedin.skp  321us ->  311us 0.97x
                   tabl_digg.skp  801us ->  770us 0.96x
      tabl_culturalsolutions.skp  332us ->  319us 0.96x
                 desk_amazon.skp  103us ->   99us 0.96x
               tabl_engadget.skp  610us ->  579us 0.95x
                   tabl_cnet.skp  144us ->  136us 0.95x
               desk_fontwipe.skp 36.6us -> 34.7us 0.95x
                   desk_ebay.skp  173us ->  164us 0.94x
                   tabl_hsfi.skp 5.95us -> 5.58us 0.94x
             tabl_deviantart.skp  134us ->  126us 0.94x
                   desk_espn.skp  261us ->  243us 0.93x

BUG=skia:

Review URL: https://codereview.chromium.org/861853002

9 years agoAllow pdf as a --config.
mtklein [Tue, 20 Jan 2015 21:34:39 +0000 (13:34 -0800)]
Allow pdf as a --config.

We just can't run this on the bots yet.  It's fine locally.

BUG=skia:3255

Review URL: https://codereview.chromium.org/857373002

9 years agoUpstream support for giflib >= 5.1.
mtklein [Tue, 20 Jan 2015 20:38:06 +0000 (12:38 -0800)]
Upstream support for giflib >= 5.1.

DGifCloseFile now takes two arugments.  The second argument appears to be an
optional out-param with more information on failures.

( c.f. http://giflib.sourceforge.net/gif_lib.html )

PS 1 is the original patch we received from google3.  I've updated it a bit to
be pedantically legal C++98.

BUG=skia:

Review URL: https://codereview.chromium.org/860853003

9 years agoMove SkFontMgr and SkFontStyle impls to own cpp.
bungeman [Tue, 20 Jan 2015 19:15:37 +0000 (11:15 -0800)]
Move SkFontMgr and SkFontStyle impls to own cpp.

SkFontMgr and SkFontStyle implementations are currently burried in the
old SkFontHost.cpp file. Move these implementations to their own file
so that the implementations are easier to find, and to make clearer that
SkFontHost.cpp needs to be removed.

Review URL: https://codereview.chromium.org/799533004

9 years agoAdd ability to specify gyp dir to gyp_to_android.
scroggo [Tue, 20 Jan 2015 18:39:25 +0000 (10:39 -0800)]
Add ability to specify gyp dir to gyp_to_android.

When running gyp_to_android inside a Skia tree, it uses the gyp program
in third_party/externals. Inside an Android tree, we need to use a
different location for gyp (the Android copy of Skia, in external/skia,
does not contain third_party/externals).

The bot handles this by importing gyp_to_android and running its main
function directly.

Add command line arguments so a human can directly run gyp_to_android.

Review URL: https://codereview.chromium.org/864503002

9 years agoconvert pdf design document to markdown
halcanary [Tue, 20 Jan 2015 18:39:06 +0000 (10:39 -0800)]
convert pdf design document to markdown

Review URL: https://codereview.chromium.org/849133002

9 years agoRevert "Revert "delete old things!""
bsalomon [Tue, 20 Jan 2015 18:23:01 +0000 (10:23 -0800)]
Revert "Revert "delete old things!""

This reverts commit 8b4489b6e696ce4b1abbffa9b2cbd0d3bfdeb387.
Delete gm and other unused files

TBR=mtklien@google.com

Review URL: https://codereview.chromium.org/856103002

9 years agoDo more cleanup from xp changes
egdaniel [Tue, 20 Jan 2015 18:19:22 +0000 (10:19 -0800)]
Do more cleanup from xp changes

BUG=skia:

Review URL: https://codereview.chromium.org/811903004

9 years agoImage subsets as part of the name instead of a separate source type.
mtklein [Tue, 20 Jan 2015 18:11:53 +0000 (10:11 -0800)]
Image subsets as part of the name instead of a separate source type.

This will hold us closer to the principle that the test name (and only the test
name) should correspond to expected output.  By the same reasoning, mix in the
number of subsets: if that changes, the expected output also changes.

BUG=skia:3255

Review URL: https://codereview.chromium.org/863723002

9 years agoSimplify skiatest framework.
halcanary [Tue, 20 Jan 2015 17:30:20 +0000 (09:30 -0800)]
Simplify skiatest framework.

skiatest::Test class is now a simple struct.  Some
functionalty, such as counting errors or timing is now
handled elsewhere.

skiatest:Reporter is now a simpler abstract class.  The two
implementations handle test errors.

DM and pathops_unittest updated.

Review URL: https://codereview.chromium.org/830513004

9 years agoBUG=skia:
joshualitt [Tue, 20 Jan 2015 17:08:51 +0000 (09:08 -0800)]
BUG=skia:

Review URL: https://codereview.chromium.org/815643005

9 years agoremove dead code after HQ change
reed [Tue, 20 Jan 2015 16:50:37 +0000 (08:50 -0800)]
remove dead code after HQ change

BUG=skia:

Review URL: https://codereview.chromium.org/845303005

9 years agoStop building gm in Android framework build.
scroggo [Tue, 20 Jan 2015 16:25:36 +0000 (08:25 -0800)]
Stop building gm in Android framework build.

Allows us to delete gm.

Review URL: https://codereview.chromium.org/860803004

9 years agoremove legacy flags for old image filtering
reed [Tue, 20 Jan 2015 15:41:24 +0000 (07:41 -0800)]
remove legacy flags for old image filtering

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/857193003

9 years agoforce a build with new --config flags
Mike Klein [Tue, 20 Jan 2015 15:24:19 +0000 (10:24 -0500)]
force a build with new --config flags

BUG=skia:

Review URL: https://codereview.chromium.org/798463005

9 years agoRemove willReadDst from GrFragmentProcessor.
egdaniel [Tue, 20 Jan 2015 14:34:51 +0000 (06:34 -0800)]
Remove willReadDst from GrFragmentProcessor.

Since only XP's can read dst now, there is no reason to have this query on GrFP.
This also triggered a chain reaction of cleaning up/removing unnecessary code
elsewhere.

BUG=skia:

Review URL: https://codereview.chromium.org/851143003

9 years agoRevert of remove unused SkAvoidXfermode (patchset #2 id:20001 of https://codereview...
scroggo [Tue, 20 Jan 2015 14:33:13 +0000 (06:33 -0800)]
Revert of remove unused SkAvoidXfermode (patchset #2 id:20001 of https://codereview.chromium.org/860583002/)

Reason for revert:
Breaking Android framework build, which still uses AvoidXfermode. (failure shown here: https://android-build.storage.googleapis.com/builds/git_master-skia-linux-razor-userdebug/1689202/565b76b4bd8cc2ffd5aeb37e524f6a35e9b8791995d6e8c719a3a6d83aece936/logs/build_error.log?Signature=lHYyiconR%2BoTzY9ILAKlaUm6nFnpJQPTI4XUei1ZccBRyz6PxspCNvYCDO5za92yZSoy9refHT7uh2Hxlxew1ZBePxKCp2nnwJB7a%2B403kiHMHHawjecsbPnTE9QNNO8XMoqAjujcAplorhwsIBZYOCxb%2Bo5010BCfzTd%2F8GFa8%3D&Expires=1421764644&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com)

Here is the Java class that uses it: https://cs.corp.google.com/#android/frameworks/base/graphics/java/android/graphics/AvoidXfermode.java&sq=package:android

It has been deprecated. The glue code (which actually references the Skia file) is here: https://cs.corp.google.com/#android/frameworks/base/core/jni/android/graphics/Xfermode.cpp&q=Xfermode.cpp&sq=package:android

Mike suggested we move the implementation into Android, which is fine with me.

Original issue's description:
> remove unused SkAvoidXfermode
>
> BUG=skia:
> TBR=
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/2d02df7a9a50217dac8c1d11681832a927ed79ce

TBR=bsalomon@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/822953003

9 years agoRemove unused TileGridInfo
weiliangc [Tue, 20 Jan 2015 13:57:06 +0000 (05:57 -0800)]
Remove unused TileGridInfo

Chromium no longer uses TileGridInfo as of CL 856853003 and remove this
from skia.

BUG=chromium:447662

Review URL: https://codereview.chromium.org/828503004

9 years agoRemove roll_deps and trybots_to_run.
rmistry [Tue, 20 Jan 2015 13:44:46 +0000 (05:44 -0800)]
Remove roll_deps and trybots_to_run.

BUG=skia:

Review URL: https://codereview.chromium.org/859963003

9 years agoUpdate SKP version
skia.buildbots [Tue, 20 Jan 2015 07:14:06 +0000 (23:14 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/786403004

9 years agoRemove a few unused statements.
cwallez [Mon, 19 Jan 2015 21:57:17 +0000 (13:57 -0800)]
Remove a few unused statements.

BUG=

Review URL: https://codereview.chromium.org/837643003

9 years agoBroken dm fix
sugoi [Mon, 19 Jan 2015 18:31:35 +0000 (10:31 -0800)]
Broken dm fix

BUG=skia:

Review URL: https://codereview.chromium.org/855953005

9 years agoYUV planes cache
sugoi [Mon, 19 Jan 2015 18:10:27 +0000 (10:10 -0800)]
YUV planes cache

- Added new classes to contain YUV planes of memory, along with the associated data.
- Used these classes in load_yuv_texture() to enable YUV planes caching
- Added a unit test for the new cache

BUG=450021

Review URL: https://codereview.chromium.org/851273003

9 years agoUpdate SKP version
skia.buildbots [Mon, 19 Jan 2015 06:42:54 +0000 (22:42 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/860613003

9 years agoremove dead header
reed [Mon, 19 Jan 2015 04:12:26 +0000 (20:12 -0800)]
remove dead header

BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/858813002

9 years agoremove unused SkAvoidXfermode
reed [Mon, 19 Jan 2015 04:01:30 +0000 (20:01 -0800)]
remove unused SkAvoidXfermode

BUG=skia:
TBR=
NOTRY=True

Review URL: https://codereview.chromium.org/860583002

9 years agoremove dead code for scalar type
reed [Sun, 18 Jan 2015 19:19:33 +0000 (11:19 -0800)]
remove dead code for scalar type

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/855273003

9 years agotool --help alphabetizes command line flags
halcanary [Sun, 18 Jan 2015 18:39:25 +0000 (10:39 -0800)]
tool --help alphabetizes command line flags

Review URL: https://codereview.chromium.org/854193003

9 years agoRefactor position computation to enable device space "nudge"
robertphillips [Sun, 18 Jan 2015 16:14:14 +0000 (08:14 -0800)]
Refactor position computation to enable device space "nudge"

To match raster's handling of BW geometry we want to be able to perform a device space "nudge" on all geometry. This CL sets us up to be able to do that in GrGLVertexBuilder::transformToNormalizedDeviceSpace.

BUG=423834
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/854013002

9 years agoDM: Don't hold onto data longer than needed.
mtklein [Sun, 18 Jan 2015 15:05:01 +0000 (07:05 -0800)]
DM: Don't hold onto data longer than needed.

On my laptop, this cuts peak memory usage by more than half.

BUG=skia:3255

Review URL: https://codereview.chromium.org/859623002

9 years agoUpdate SKP version
skia.buildbots [Sun, 18 Jan 2015 06:46:36 +0000 (22:46 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/836123008

9 years agofatbits for all 4 views
reed [Sun, 18 Jan 2015 03:36:08 +0000 (19:36 -0800)]
fatbits for all 4 views

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/829043005

9 years agoUpdate SKP version
skia.buildbots [Sat, 17 Jan 2015 07:04:02 +0000 (23:04 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/839673006

9 years agofix labels on image-surface gm
reed [Fri, 16 Jan 2015 22:21:40 +0000 (14:21 -0800)]
fix labels on image-surface gm

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/834903003

9 years agoRebaseline pictureshader GM after http://crrev.com/852213002
fmalita [Fri, 16 Jan 2015 22:15:27 +0000 (14:15 -0800)]
Rebaseline pictureshader GM after crrev.com/852213002

BUG=chromium:447707
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/853243002

9 years agoRevert "delete old things!"
Brian Salomon [Fri, 16 Jan 2015 21:26:32 +0000 (16:26 -0500)]
Revert "delete old things!"

This reverts commit 15b125d40122e966bd723d23e82c3224b1da4898.

NOTREECHECKS=true

original change breaks android tree

BUG=skia:

Review URL: https://codereview.chromium.org/848073005

9 years agodelete old things!
bsalomon [Fri, 16 Jan 2015 20:08:52 +0000 (12:08 -0800)]
delete old things!

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/855003006

9 years agoreorg filter quality cascade
reed [Fri, 16 Jan 2015 20:05:19 +0000 (12:05 -0800)]
reorg filter quality cascade

BUG=skia:
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/844913004

9 years ago* Add nytimes_desktop pageset.
rmistry [Fri, 16 Jan 2015 19:41:26 +0000 (11:41 -0800)]
* Add nytimes_desktop pageset.
* Delete cuteoverload, frantzen, transformice and nytimes_tabl.
* Increase wait time for forecastio.

BUG=skia:3320
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/808843004

9 years agoAdd robots.txt
jcgregorio [Fri, 16 Jan 2015 19:13:53 +0000 (11:13 -0800)]
Add robots.txt

BUG=skia:
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/851793004

9 years agoFix debugger wrt to new SkGpuDevice factory signature'
Brian Salomon [Fri, 16 Jan 2015 19:01:44 +0000 (14:01 -0500)]
Fix debugger wrt to new SkGpuDevice factory signature'

Review URL: https://codereview.chromium.org/855083003

9 years agoadd more suppressions for mipmap fix
reed [Fri, 16 Jan 2015 17:31:13 +0000 (09:31 -0800)]
add more suppressions for mipmap fix

BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/828633003

9 years agouse log2(scale) to compute mip level
reed [Fri, 16 Jan 2015 16:35:09 +0000 (08:35 -0800)]
use log2(scale) to compute mip level

now w/ expanded suppressions

This reverts commit b50ced703030dfbda4fc3ef5e6ec9a52fc0405f8.

BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/856723003

9 years agoRequire budget decision when creating a RenderTarget SkSurface.
bsalomon [Fri, 16 Jan 2015 15:32:33 +0000 (07:32 -0800)]
Require budget decision when creating a RenderTarget SkSurface.

Restructure SkGpuDevice creation:
*SkSurfaceProps are optional.
*Use SkSurfaceProps to communicate DF text rather than a flag.
*Tell SkGpuDevice::Create whether RT comes from cache or not.

Review URL: https://codereview.chromium.org/848903004

9 years agoRevert of use log2(scale) to compute mip level (patchset #7 id:120001 of https:/...
reed [Fri, 16 Jan 2015 15:27:46 +0000 (07:27 -0800)]
Revert of use log2(scale) to compute mip level (patchset #7 id:120001 of https://codereview.chromium.org/849333002/)

Reason for revert:
need more suppressions

Original issue's description:
> use log2(scale) to compute mip level
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/15fd47f8a07615a7f5d78581aee4c80ff9f17fd9

TBR=robertphillips@google.com,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/856783004

9 years agouse log2(scale) to compute mip level
reed [Fri, 16 Jan 2015 15:18:10 +0000 (07:18 -0800)]
use log2(scale) to compute mip level

BUG=skia:

Review URL: https://codereview.chromium.org/849333002

9 years agonew files for pathops geometric intersection
caryclark [Fri, 16 Jan 2015 15:04:10 +0000 (07:04 -0800)]
new files for pathops geometric intersection

There's no gyp references to these new files,
so this should only have the effect of reducing
the size of the commit that turns this code on.

TBR=

Review URL: https://codereview.chromium.org/853223002

9 years agoUpdate ignore file
egdaniel [Fri, 16 Jan 2015 14:44:18 +0000 (06:44 -0800)]
Update ignore file

NOTRY=True
TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/844813004

9 years agoAdd Xfer Processor for GrCustomXfermodes
egdaniel [Fri, 16 Jan 2015 14:29:47 +0000 (06:29 -0800)]
Add Xfer Processor for GrCustomXfermodes

BUG=skia:

Review URL: https://codereview.chromium.org/852203003

9 years agoFold alpha to the draw in savelayer-draw-restore patterns with non-opaque draw
kkinnunen [Fri, 16 Jan 2015 13:04:36 +0000 (05:04 -0800)]
Fold alpha to the draw in savelayer-draw-restore patterns with non-opaque draw

Fold alpha of a save layer call to the subsequent draw call paint, even when
the draw call paint color is already non-opaque.

Comparing the difference of the unoptimized and the optimized call pattern
with all (layer alpha, draw alpha) combinations, this produces
off-by-one pixels ~50% of the time.

Reduces layers of current desk_carsvg.skp (recorded with cross-process
picture image filters allowed) from 122 to 115.

BUG=skia:3119

Review URL: https://codereview.chromium.org/840483005

9 years agoadd gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org...
reed [Fri, 16 Jan 2015 13:01:16 +0000 (05:01 -0800)]
add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org/849173004/)"

fixed memory leak

This reverts commit 04f07fcbfddbe8ca97d29053554a01c66d44ece2.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/854163002

9 years agoUpdate SKP version
skia.buildbots [Fri, 16 Jan 2015 12:44:24 +0000 (04:44 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/855003003

9 years agoRevert of Add temporary blacklist debugging. (patchset #1 id:1 of https://codereview...
mtklein [Fri, 16 Jan 2015 03:11:55 +0000 (19:11 -0800)]
Revert of Add temporary blacklist debugging. (patchset #1 id:1 of https://codereview.chromium.org/805643004/)

Reason for revert:
fixed!

Original issue's description:
> Add temporary blacklist debugging.
>
> Not sure why blacklists don't seem to work on bots.  They look right.
>
> NOTREECHECKS=true
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f77156e1925cd5d5504070fe5533a4c456732c1b

TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/851903003

9 years agoRevert of add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromi...
mtklein [Fri, 16 Jan 2015 02:36:07 +0000 (18:36 -0800)]
Revert of add gm to show miplevels (patchset #2 id:20001 of https://codereview.chromium.org/849173004/)

Reason for revert:
==31530==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 224 byte(s) in 2 object(s) allocated from:
    #0 0x7febb223f65b in operator new(unsigned long) (/home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/dm+0x35865b)
    #1 0x7febb3483c56 in SkMipMap::Build(SkBitmap const&, SkDiscardableMemory* (*)(unsigned long)) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkMipMap.cpp:181:9
    #2 0x7febb2c37914 in ShowMipLevels::onDraw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/downsamplebitmap.cpp:228:24
    #3 0x7febb2295736 in skiagm::GM::drawContent(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:32:5
    #4 0x7febb2295019 in skiagm::GM::draw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:24:5
    #5 0x7febb226722f in DM::GMSrc::draw(SkCanvas*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:22:5
    #6 0x7febb226d929 in DM::RasterSink::draw(DM::Src const&, SkBitmap*, SkWStream*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:230:12
    #7 0x7febb224e004 in Task::Run(Task*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DM.cpp:254:25
    #8 0x7febb3805e4c in (anonymous namespace)::ThreadPool::Loop(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkTaskGroup.cpp:149:13
    #9 0x7febb460dc7c in thread_start(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/utils/SkThreadUtils_pthread.cpp:66:9
    #10 0x7febb1251f6d in start_thread /build/buildd/eglibc-2.17/nptl/pthread_create.c:311

Indirect leak of 699528 byte(s) in 2 object(s) allocated from:
    #0 0x7febb22214ab in __interceptor_malloc (/home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/dm+0x33a4ab)
    #1 0x7febb473e3c6 in sk_malloc_flags(unsigned long, unsigned int) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/ports/SkMemory_malloc.cpp:54:15
    #2 0x7febb473e19a in sk_malloc_throw(unsigned long) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/ports/SkMemory_malloc.cpp:40:12
    #3 0x7febb3483c94 in SkMipMap::Build(SkBitmap const&, SkDiscardableMemory* (*)(unsigned long)) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkMipMap.cpp:181:18
    #4 0x7febb2c37914 in ShowMipLevels::onDraw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/downsamplebitmap.cpp:228:24
    #5 0x7febb2295736 in skiagm::GM::drawContent(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:32:5
    #6 0x7febb2295019 in skiagm::GM::draw(SkCanvas*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../gm/gm.cpp:24:5
    #7 0x7febb226722f in DM::GMSrc::draw(SkCanvas*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:22:5
    #8 0x7febb226d929 in DM::RasterSink::draw(DM::Src const&, SkBitmap*, SkWStream*) const /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DMSrcSink.cpp:230:12
    #9 0x7febb224e004 in Task::Run(Task*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../dm/DM.cpp:254:25
    #10 0x7febb3805e4c in (anonymous namespace)::ThreadPool::Loop(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/core/SkTaskGroup.cpp:149:13
    #11 0x7febb460dc7c in thread_start(void*) /home/default/storage/skia-repo/buildbot/skiabot-linux-xsan-001/build/slave/Test-Ubuntu13_10-GCE-NoGPU-x86_64-Debug-ASAN/build/skia/out/Debug/../../src/utils/SkThreadUtils_pthread.cpp:66:9
    #12 0x7febb1251f6d in start_thread /build/buildd/eglibc-2.17/nptl/pthread_create.c:311

Original issue's description:
> add gm to show miplevels
>
> BUG=skia:
> TBR=
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/a598f4b773f066a939e0216a116c179b90550727

TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/854103004

9 years agoforce a build with fixed --blacklist
mtklein [Fri, 16 Jan 2015 02:28:53 +0000 (18:28 -0800)]
force a build with fixed --blacklist

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/850413003

9 years agoadd gm to show miplevels
reed [Fri, 16 Jan 2015 02:09:15 +0000 (18:09 -0800)]
add gm to show miplevels

BUG=skia:
TBR=

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/849173004

9 years agoAdd temporary blacklist debugging.
mtklein [Fri, 16 Jan 2015 00:21:24 +0000 (16:21 -0800)]
Add temporary blacklist debugging.

Not sure why blacklists don't seem to work on bots.  They look right.

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/805643004

9 years agonewlines after failures
mtklein [Thu, 15 Jan 2015 23:47:33 +0000 (15:47 -0800)]
newlines after failures

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/853123003

9 years agoTotally serialize gpu tests on Windows.
mtklein [Thu, 15 Jan 2015 22:20:41 +0000 (14:20 -0800)]
Totally serialize gpu tests on Windows.

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/845193006

9 years agoTurn back on image and subset sources now that they're blacklisted on Android.
mtklein [Thu, 15 Jan 2015 21:58:56 +0000 (13:58 -0800)]
Turn back on image and subset sources now that they're blacklisted on Android.

To land after https://codereview.chromium.org/850403002/

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/857483003

9 years agoDM: add basic --blacklist <config> <srcType> <name> functionality.
mtklein [Thu, 15 Jan 2015 21:44:22 +0000 (13:44 -0800)]
DM: add basic --blacklist <config> <srcType> <name> functionality.

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/817573005

9 years agoremove suppressions (CL was reverted)
reed [Thu, 15 Jan 2015 21:02:03 +0000 (13:02 -0800)]
remove suppressions (CL was reverted)

BUG=skia:
TBR=
NOTREECHECKS=True
NOTRY=True

Review URL: https://codereview.chromium.org/837633007

9 years agoturn back on gpu tests
mtklein [Thu, 15 Jan 2015 20:46:02 +0000 (12:46 -0800)]
turn back on gpu tests

NOTREECHECKS=true

BUG=skia:3255

Review URL: https://codereview.chromium.org/817573004

9 years agoRevert "choose better mip level"
reed [Thu, 15 Jan 2015 20:37:30 +0000 (12:37 -0800)]
Revert "choose better mip level"

This reverts commit 09544fcf9611be6efc0c38ab9d9a3f82181341fb.

BUG=skia:
TBR=
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/849173003

9 years agoRemove obsolete mac_gpu
sergiyb [Thu, 15 Jan 2015 20:33:04 +0000 (12:33 -0800)]
Remove obsolete mac_gpu

BUG=chromium:426897
R=kbr@google.com,phajdan@google.com,reed@google.com

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/812963003

9 years agoSketch DM refactor.
mtklein [Thu, 15 Jan 2015 18:56:12 +0000 (10:56 -0800)]
Sketch DM refactor.

BUG=skia:3255

I think this supports everything DM used to, but has completely refactored how
it works to fit the design in the bug.

Configs like "tiles-gpu" are automatically wired up.

I wouldn't suggest looking at this as a diff.  There's just a bunch of deleted
files, a few new files, and one new file that shares a name with a deleted file
(DM.cpp).

NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88

Review URL: https://codereview.chromium.org/788243008

9 years agoMove XferEffects class to GrCustomXfermode file
egdaniel [Thu, 15 Jan 2015 18:52:32 +0000 (10:52 -0800)]
Move XferEffects class to GrCustomXfermode file

BUG=skia:

Review URL: https://codereview.chromium.org/844913003

9 years agoSkPictureShader should handle negative scaling gracefully.
fmalita [Thu, 15 Jan 2015 18:45:56 +0000 (10:45 -0800)]
SkPictureShader should handle negative scaling gracefully.

Let's not choke on inverted tiles.

BUG=chromium:447707
R=robertphillips@google.com,reed@google.com

Review URL: https://codereview.chromium.org/852213002

9 years agoRevert of Sketch DM refactor. (patchset #45 id:850001 of https://codereview.chromium...
mtklein [Thu, 15 Jan 2015 18:15:02 +0000 (10:15 -0800)]
Revert of Sketch DM refactor. (patchset #45 id:850001 of https://codereview.chromium.org/788243008/)

Reason for revert:
plenty of data

Original issue's description:
> Sketch DM refactor.
>
> BUG=skia:3255
>
>
> I think this supports everything DM used to, but has completely refactored how
> it works to fit the design in the bug.
>
> Configs like "tiles-gpu" are automatically wired up.
>
> I wouldn't suggest looking at this as a diff.  There's just a bunch of deleted
> files, a few new files, and one new file that shares a name with a deleted file
> (DM.cpp).
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88

TBR=bsalomon@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3255

Review URL: https://codereview.chromium.org/853883004

9 years agomore GMs to rebase?
Mike Klein [Thu, 15 Jan 2015 17:17:14 +0000 (12:17 -0500)]
more GMs to rebase?

TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/789933003

9 years agoSketch DM refactor.
mtklein [Thu, 15 Jan 2015 16:30:25 +0000 (08:30 -0800)]
Sketch DM refactor.

BUG=skia:3255

I think this supports everything DM used to, but has completely refactored how
it works to fit the design in the bug.

Configs like "tiles-gpu" are automatically wired up.

I wouldn't suggest looking at this as a diff.  There's just a bunch of deleted
files, a few new files, and one new file that shares a name with a deleted file
(DM.cpp).

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/788243008

9 years agothese GM names are ridiculous
Mike Klein [Thu, 15 Jan 2015 16:24:38 +0000 (11:24 -0500)]
these GM names are ridiculous

TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/852193003

9 years agoWhy are we afraid of saveLayer() bounds?
mtklein [Thu, 15 Jan 2015 16:08:10 +0000 (08:08 -0800)]
Why are we afraid of saveLayer() bounds?

They're only hints.  We can ignore them in this optimization.
My only hesitation is that this pattern doesn't seem to happen in our .skps.

BUG=skia:

Review URL: https://codereview.chromium.org/849243002

9 years agochoose better mip level
reed [Thu, 15 Jan 2015 16:01:40 +0000 (08:01 -0800)]
choose better mip level

BUG=skia:

Review URL: https://codereview.chromium.org/845793005

9 years agoUpdate SKP version
skia.buildbots [Thu, 15 Jan 2015 15:49:25 +0000 (07:49 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/845873005

9 years agoAdd include before SK_SUPPORT_GPU in SkArithmeticMode_gpu.h to fix android build
egdaniel [Thu, 15 Jan 2015 15:05:02 +0000 (07:05 -0800)]
Add include before SK_SUPPORT_GPU in SkArithmeticMode_gpu.h to fix android build

BUG=skia:

Review URL: https://codereview.chromium.org/852193002

9 years agoUse device-space stroke width for SkDraw::drawRect() quick-reject
fmalita [Thu, 15 Jan 2015 14:01:23 +0000 (06:01 -0800)]
Use device-space stroke width for SkDraw::drawRect() quick-reject

The stroke width needs to be CTM-adjusted when applied to device space
rects.

BUG=skia:3313
R=reed@google.com

Review URL: https://codereview.chromium.org/801353008

9 years agoUpdate SKP version
skia.buildbots [Thu, 15 Jan 2015 13:40:51 +0000 (05:40 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/852163002

9 years agoUpdate SKP version
skia.buildbots [Thu, 15 Jan 2015 07:06:12 +0000 (23:06 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/855473003

9 years agoRebaseline 6 GMs after crrev.com/841763005
fmalita [Thu, 15 Jan 2015 02:11:17 +0000 (18:11 -0800)]
Rebaseline 6 GMs after crrev.com/841763005

BUG=skia:3299
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/852053004

9 years agoa few ignores for nvprmsaa4
joshualitt [Thu, 15 Jan 2015 00:05:09 +0000 (16:05 -0800)]
a few ignores for nvprmsaa4

TBR=
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/850143003

9 years agoupdate images after texture cache change
Brian Salomon [Wed, 14 Jan 2015 22:55:18 +0000 (17:55 -0500)]
update images after texture cache change

Review URL: https://codereview.chromium.org/852913002

9 years agofMaxTexCoords is unused in Release builds
mtklein [Wed, 14 Jan 2015 22:18:54 +0000 (14:18 -0800)]
fMaxTexCoords is unused in Release builds

BUG=skia:

Review URL: https://codereview.chromium.org/853643005

9 years agopossible bug fix for nvpr
joshualitt [Wed, 14 Jan 2015 21:51:18 +0000 (13:51 -0800)]
possible bug fix for nvpr

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/850953003

9 years agoadd sample for filter quality
reed [Wed, 14 Jan 2015 21:16:26 +0000 (13:16 -0800)]
add sample for filter quality

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/788163007

9 years agoAdd Arithmetic mode xp.
egdaniel [Wed, 14 Jan 2015 20:53:01 +0000 (12:53 -0800)]
Add Arithmetic mode xp.

BUG=skia:

Review URL: https://codereview.chromium.org/837633005

9 years agoseparate out the scaline-choosing to simplify chooseProcs
reed [Wed, 14 Jan 2015 20:28:22 +0000 (12:28 -0800)]
separate out the scaline-choosing to simplify chooseProcs

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/796063007

9 years agofix link reference in docs
jcgregorio [Wed, 14 Jan 2015 20:03:01 +0000 (12:03 -0800)]
fix link reference in docs

BUG=skia:
NOTRIES=1
TBR=halcanary

Review URL: https://codereview.chromium.org/853703003

9 years agoAdd reference material for the style of markdown we use.
jcgregorio [Wed, 14 Jan 2015 19:26:29 +0000 (11:26 -0800)]
Add reference material for the style of markdown we use.

Preview here: http://skiadocs.com:8000/dev/tools/markdown?cl=853493004

Note that the image won't show up, that's a known issue with the way patching in CLs works.

BUG=skia:

Review URL: https://codereview.chromium.org/853493004

9 years agoMove Gpu ArithmeticMode xfer effect to _gpu files.
egdaniel [Wed, 14 Jan 2015 18:49:18 +0000 (10:49 -0800)]
Move Gpu ArithmeticMode xfer effect to _gpu files.

BUG=skia:

Review URL: https://codereview.chromium.org/827163004

9 years agoMake uncached textures uncached from the get go.
bsalomon [Wed, 14 Jan 2015 18:42:08 +0000 (10:42 -0800)]
Make uncached textures uncached from the get go.

This avoids the problem of a newly created uncached texture causing a purge of cached resources.

BUG=chromium:445885

Review URL: https://codereview.chromium.org/846303002

9 years agoAdd repro GM for GPU clipped-AA vs. non-AA drawRect discrepancy
robertphillips [Wed, 14 Jan 2015 17:44:02 +0000 (09:44 -0800)]
Add repro GM for  GPU clipped-AA vs. non-AA drawRect discrepancy

In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies.

BUG=423834

Committed: https://skia.googlesource.com/skia/+/933a03fecb65c83f81cf65d5cf9870c69aa379ff

Review URL: https://codereview.chromium.org/839883003

9 years agoDM can see into src/gpu. No need for relative include.
mtklein [Wed, 14 Jan 2015 17:25:01 +0000 (09:25 -0800)]
DM can see into src/gpu.  No need for relative include.

BUG=skia:

Review URL: https://codereview.chromium.org/853613004

9 years agoRemove self-assignment in a test.
mtklein [Wed, 14 Jan 2015 16:49:10 +0000 (08:49 -0800)]
Remove self-assignment in a test.

BUG=skia:

Review URL: https://codereview.chromium.org/853723002

9 years agoMore changes to bring together path / geo procs
joshualitt [Wed, 14 Jan 2015 16:12:47 +0000 (08:12 -0800)]
More changes to bring together path / geo procs

BUG=skia:

Review URL: https://codereview.chromium.org/820783005

9 years agoSwitch to a more complete method of filtering hoisted layers
robertphillips [Wed, 14 Jan 2015 16:08:21 +0000 (08:08 -0800)]
Switch to a more complete method of filtering hoisted layers

Committed: https://skia.googlesource.com/skia/+/74668a8e818fd891a08c4966cc5973b04c1ad992

Review URL: https://codereview.chromium.org/842323003

9 years agoDo some minor pre cleanup work before converting all xfermodes to XPs.
egdaniel [Wed, 14 Jan 2015 16:05:11 +0000 (08:05 -0800)]
Do some minor pre cleanup work before converting all xfermodes to XPs.

BUG=skia:

Review URL: https://codereview.chromium.org/853543003

9 years agoupstream hooking into google3 crash handler for better stacktraces
mtklein [Wed, 14 Jan 2015 14:38:28 +0000 (06:38 -0800)]
upstream hooking into google3 crash handler for better stacktraces

BUG=skia:

Review URL: https://codereview.chromium.org/821643006

9 years agoUpdate SKP version
skia.buildbots [Wed, 14 Jan 2015 13:14:15 +0000 (05:14 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/812283007

9 years agoupstream google3 include paths for jsoncpp
mtklein [Wed, 14 Jan 2015 13:02:39 +0000 (05:02 -0800)]
upstream google3 include paths for jsoncpp

BUG=skia:

No public API changes
TBR=reed@google.com

Review URL: https://codereview.chromium.org/853613002