Andrew Hoefling [Wed, 6 Mar 2019 00:00:01 +0000 (19:00 -0500)]
Updated InsertItemsRange to simplify the expression and added performance improvements. If the underlying `items` is using List<T> we should use it's InsertRange method since it is optimized, othersie we use InsertItem
Commit migrated from https://github.com/dotnet/coreclr/commit/
dadee3b355c75e33d0c925b27ba3f301d100a51b
Andrew Hoefling [Tue, 5 Mar 2019 23:46:05 +0000 (18:46 -0500)]
Updated RemoveAt->RemoveItem. This change removes redundent validation checks that happen using the RemoveAt API. RemoveItem gives us direct access to invoke the command
Commit migrated from https://github.com/dotnet/coreclr/commit/
d3b9f9dac784c03e10619ff49c8f22579940192c
Andrew Hoefling [Tue, 5 Mar 2019 23:15:08 +0000 (18:15 -0500)]
Updated RemoveRange invocation of RemoveAt to use index instead of i, because the array changes with each iteration of the for loop and will cause side-effects which may include index out of range exceptions. This needs to be index because as the array shrinks the index is always at the correct position.
Commit migrated from https://github.com/dotnet/coreclr/commit/
2fb96bfe42d2b97577918c24be445cc8106ae593
Andrew Hoefling [Tue, 5 Mar 2019 23:14:01 +0000 (18:14 -0500)]
Added ArgumentOutOfRangeException exception in RemoveRange if the count is less than 0
Commit migrated from https://github.com/dotnet/coreclr/commit/
5f9e81d1577345c4f3fc4df475b8f3e7f672f0ce
Andrew Hoefling [Tue, 5 Mar 2019 05:26:08 +0000 (00:26 -0500)]
Updated RemoveItemsRange to properly remove each item and not just the index items
Commit migrated from https://github.com/dotnet/coreclr/commit/
b474a2a96d6ca31f3a093fd83b49537eee382794
Andrew Hoefling [Tue, 5 Mar 2019 04:50:36 +0000 (23:50 -0500)]
Updated RemoveItemsRange to prevent int.MaxValue overflow errors
Commit migrated from https://github.com/dotnet/coreclr/commit/
0190ab05d31de5ca020ee7a2325ff3d3625af43a
Andrew Hoefling [Tue, 5 Mar 2019 04:44:19 +0000 (23:44 -0500)]
Remove ternary operator from invocation as it is the same as inputing items.Count
Commit migrated from https://github.com/dotnet/coreclr/commit/
c32f57bdae5cd532ebb3587386db937528726ca6
Andrew Hoefling [Tue, 5 Mar 2019 03:28:05 +0000 (22:28 -0500)]
Added ReplaceItemsRange API and updated ReplaceRange to invoke the protected method
Commit migrated from https://github.com/dotnet/coreclr/commit/
96de98c1aab0b65c0dfd667bc86e6ab14794306c
Andrew Hoefling [Tue, 5 Mar 2019 02:54:41 +0000 (21:54 -0500)]
Adding braces on for loop
Commit migrated from https://github.com/dotnet/coreclr/commit/
69c3b0355df56fd47f98faf574e24f577f6d29c2
Andrew Hoefling [Tue, 5 Mar 2019 02:53:52 +0000 (21:53 -0500)]
Updated foreach to use T instead of var
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff55c32b76d8843a9be7481200c05ac0d0e2c4c4
Andrew Hoefling [Tue, 5 Mar 2019 02:53:26 +0000 (21:53 -0500)]
Updated index out of range exception check to be a single comparison
Commit migrated from https://github.com/dotnet/coreclr/commit/
3460d643fa62340b45b85ad0a57934c523ba5496
Andrew Hoefling [Tue, 5 Mar 2019 01:16:16 +0000 (20:16 -0500)]
Added new Range Manipulation APIs for Collection<T> which propogate up to ObservableCollection<T>. AddRange, InsertRange, RemoveRange and Replace Range
Commit migrated from https://github.com/dotnet/coreclr/commit/
0f5aee3560635d2c58c023578d00d7955a995163
Filip Navara [Fri, 8 Mar 2019 18:55:25 +0000 (19:55 +0100)]
Allow deserialization for ResourceManager created with non-default resource set type (dotnet/coreclr#23051)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d74fa42f811dbe28a8c12ae39122f8d110fbfa5c
Bruce Forstall [Fri, 8 Mar 2019 18:31:56 +0000 (10:31 -0800)]
Merge pull request dotnet/coreclr#23119 from BruceForstall/Arm64PrePostIndexCoalescing
Allow coalescing of SP adjustment into single register prolog STR/LDR
Commit migrated from https://github.com/dotnet/coreclr/commit/
fbaff14510fb0c1844b30a3faaf9a2c8323f294b
mikedn [Fri, 8 Mar 2019 18:29:07 +0000 (20:29 +0200)]
Improve SSA renaming memory usage (dotnet/coreclr#15000)
* Cleanup DumpStacks
It's not exactly useful to dump all the stacks after pushing to a stack. Nor is it useful to dump all the stack after popping only some, perhaps none, in PopBlockStacks.
Also dump stack from top to bottom, makes it easier to find the top, which is usually what you care about during SSA renaming.
* Stop passing null block to SsaRenameState::Push
It makes no difference if the definition is in the "block before any real blocks..." or at the start of the first block, it's just an unnecessary complication.
* Stop handling byrefStatesMatchGcHeapStates in SsaRenameState
SsaBuilder already handles that, doing it again in SsaRenameState just duplicates logic.
* Stop using "count" as a name for "SSA number"
Worst name ever.
Also use "block" consistently, instead of a mix of "bb" and "block".
* Delete "ConstructedArray", not needed
* Various cleanup
- Change SsaRenameState to a class
- Cleanup remaining function comments
- Move SsaRenameStateForBlock & SsaRenameStateLocDef inside SsaRenameState
- Make EnsureStacks private
- Reorder data members
- Use m_ prefix consistently
* Replace jitstd::list with a custom stack
std::list has a few drawbacks:
- It's a doubly linked list but a singly linked list suffices so every node wastes 8 bytes for an extra pointer.
- The list object itself is relatively large 2 head/tail pointers, node count and memory allocator. There can be hundreds of such objects (one for each local variable) so the smaller the better.
Replace with a simple singly linked, intrusive list based stack.
* Share push code between lclvar and memory
It's pretty much the same logic (the only difference is that in the memory case "top" can't ever be null so by sharing the code we get a redundant null check).
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb583867ae37e75cf9f5c4f556627283a257d67b
Egor Chesakov [Fri, 8 Mar 2019 17:56:20 +0000 (09:56 -0800)]
Add outerloop-jitstressregs, outerloop-jitstress2-jitstressregs, outerloop-gcstress0x3-gcstress0xc TestGroups (dotnet/coreclr#23047)
The following build definitions
* coreclr-ci
* coreclr-outerloop
* coreclr-outerloop-jitminopts-jitstress1-jitstress2
* coreclr-outerloop-jitstressregs
* coreclr-outerloop-jitstress2-jitstressregs
* coreclr-outerloop-gcstress0x3-gcstress0xc
can be triggered from pull requests via /azp run x command.
Commit migrated from https://github.com/dotnet/coreclr/commit/
41df61c0f570d94b962430e38b2c24181972b998
Andy Ayers [Fri, 8 Mar 2019 17:02:03 +0000 (09:02 -0800)]
JIT: rework codegen for Arm64 SIMD Extract/Insert intrinsics (dotnet/coreclr#23114)
Add an up-front bounds check during importation instead of waiting
until codegen. Mirrors what we do for similar cases on xarch.
Closes dotnet/coreclr#20260.
Commit migrated from https://github.com/dotnet/coreclr/commit/
34e83028171d6775d1020fe5dab7c4260caf16e1
Carol Eidt [Fri, 8 Mar 2019 16:35:39 +0000 (08:35 -0800)]
Merge pull request dotnet/coreclr#23052 from CarolEidt/Fix22850
Correctly type SIMD stack values
Commit migrated from https://github.com/dotnet/coreclr/commit/
42bacd6a5b0b56f5181c6ab60a9abf05174f3a41
Sung Yoon Whang [Fri, 8 Mar 2019 09:17:51 +0000 (01:17 -0800)]
disabling tracing/tracevalidation/inducedgc/inducedgc test on ARM64 (dotnet/coreclr#23125)
Commit migrated from https://github.com/dotnet/coreclr/commit/
97d979e539063aaf6c5f8b5446fe703c99e31b7a
Marek Safar [Fri, 8 Mar 2019 07:27:54 +0000 (08:27 +0100)]
Use platform specific implementation of GetCurrentProcessId (dotnet/coreclr#23084)
* Use platform specific implementation of GetCurrentProcessId
directly in shared location instead of relying on runtime export
* Move GetCurrentProcessId to Interop class
* Update ES_BUILD_STANDALONE build
Commit migrated from https://github.com/dotnet/coreclr/commit/
0fee55abb6b7c742cb487b12706dc54080e9e128
Dávid Kaya [Fri, 8 Mar 2019 05:12:31 +0000 (06:12 +0100)]
Added UserFlags field, unblocks dotnet/coreclr#34560 (dotnet/corefxdotnet/coreclr#35851)
* Added UserFlags field
* Added UserFlags
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
1fc9e9c28771863839bf54da3e17f9f2d12e84b2
Sergey Andreenko [Fri, 8 Mar 2019 03:43:37 +0000 (19:43 -0800)]
Fix a rare JitStress assert. (dotnet/coreclr#23116)
* Fix undefined behaviour when we check `this==nullptr`.
* Fix ifdef comment.
* Fix rare jit stress assert.
flowgraph.cpp: !IsUninitialized(tree) can fail if `UninitializedWord` returns a valid pointer value.
Commit migrated from https://github.com/dotnet/coreclr/commit/
24d05f5e6cb905da8d2bf84d0b1525586152c908
Sung Yoon Whang [Fri, 8 Mar 2019 02:34:17 +0000 (18:34 -0800)]
Fix how we check whether events are enabled via LTTng (dotnet/coreclr#22707)
* Fix how we check whether events are enabled via LTTng
* Add GCToEEInterface::UpdateGCEventStatus
* Fix build errors
* Finished hooking it up to post_gc
* Some comments about the event keyword/level detection logic
* Fix windows build
* Fix Prv provider keyword logic
* forgot to add one more ifdef
* Fix OSX build
* one more ifdef to fix
* Addressing PR feedback
* Update GCEventStatus at gc_heap::initialize_gc too
Commit migrated from https://github.com/dotnet/coreclr/commit/
4685a1e008ad7cf4118e8778d89e63d87ca5b7b6
Bruce Forstall [Fri, 8 Mar 2019 01:08:53 +0000 (17:08 -0800)]
Allow coalescing of SP adjustment into single register prolog STR/LDR
Commit migrated from https://github.com/dotnet/coreclr/commit/
6e6a4b26dfe914e6924d03ce91aa52f2fab05d79
Carol Eidt [Fri, 8 Mar 2019 00:40:18 +0000 (16:40 -0800)]
Merge pull request dotnet/coreclr#22708 from BrianBohe/updating_comments
Updating ScopeInfo::siUpdate comments/documentation
Commit migrated from https://github.com/dotnet/coreclr/commit/
a2865ead29cc8ef73307927976c3dbaad1298d44
Stephen Toub [Thu, 7 Mar 2019 22:28:21 +0000 (14:28 -0800)]
Add missing CopyToAsync override in FileStream.Unix.cs (dotnet/coreclr#23101)
Commit migrated from https://github.com/dotnet/coreclr/commit/
0523c2115da2b35d7f6ce028f4b128b25354078c
Jarret Shook [Thu, 7 Mar 2019 21:35:09 +0000 (13:35 -0800)]
Disable tests based on 23103 and 23096 (dotnet/coreclr#23104)
* Disable tests based on 23103 and 23096
* Remove disable for arm32 AV
Commit migrated from https://github.com/dotnet/coreclr/commit/
833e75d0e65ffa81f6baa1307efb9e6e6c526b8e
mikedn [Thu, 7 Mar 2019 21:29:09 +0000 (23:29 +0200)]
Fix ARMv8.1 atomics disassembly (dotnet/coreclr#23070)
Fixes dotnet/coreclr#20721.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f5329382ce62478789d80aefcc1e064da24287b
Aaron Robinson [Thu, 7 Mar 2019 20:19:53 +0000 (12:19 -0800)]
Update error message for when a parent is marked as COMVisible(false) (dotnet/coreclr#23092)
* Update message to include type and parent type marked as COMVisible(false)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8b3c55c36531689c337df37f15eb5a40530fa42f
Andy Ayers [Thu, 7 Mar 2019 18:52:19 +0000 (10:52 -0800)]
JIT: fix filter liveness computation (dotnet/coreclr#23044)
When a filter is finished executing, control can logically pass to the
associated handler, any enclosing handler or filter, or any finally or fault
handler nested within the associated try. This is a consequence of two-pass EH.
The jit was not propagating liveness from the nested handlers, which lead to a
live object being collected inadvertently.
This change updates `fgGetHandlerLiveVars` to find the nested handlers and
merge their live-in into the filter block live sets.
Because these implicit EH flow edges can create cycles in the liveness dataflow
equations, the jit will also now always iterate liveness when it sees there is
exception flow, to ensure livness reaches the appropriate fixed point.
Added test case.
Closes dotnet/coreclr#22820.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f6cc0134fa4bb0d2f329ebc18c4eb662a5a5d973
Juan Hoyos [Thu, 7 Mar 2019 18:35:25 +0000 (10:35 -0800)]
Fix control C trap hang in the debugger (dotnet/coreclr#23090)
Commit migrated from https://github.com/dotnet/coreclr/commit/
637900c4d1792d41b0c195904c079277cd80caf9
Bruce Forstall [Thu, 7 Mar 2019 17:25:17 +0000 (09:25 -0800)]
Clean up some arm64 prolog/epilog code (dotnet/coreclr#23080)
* Clean up some arm64 prolog/epilog code
1. For frame types which establish a frame pointer before the final
SP adjustment, there is no need to report the SP adjustment in unwind
data, as it is unused.
2. Added some comments, esp. related to frameType 1, explaining the
totalFrameSize limit.
3. Fixed frameType 3 #outsz check to > 504 versus >= 504; 504 is a legal
offset for STP/LDP.
4. Fix frameType 3 epilogs to always restore SP from FP. Should give more
prolog/epilog unwind code matching, and simplifies the code.
Closes dotnet/coreclr#22056, dotnet/coreclr#22058, dotnet/coreclr#22057, dotnet/coreclr#22476, dotnet/coreclr#22478.
* Formatting
* Update comment
Commit migrated from https://github.com/dotnet/coreclr/commit/
c5935b38947fe1c6beea1a9191e58b3048355b67
Bruce Forstall [Thu, 7 Mar 2019 16:34:29 +0000 (08:34 -0800)]
Merge pull request dotnet/coreclr#23085 from BruceForstall/FixAsmDiffScratchRoot
Fix PMI asm diffs
Commit migrated from https://github.com/dotnet/coreclr/commit/
781211ecdf96d3d9293e7623dc9e5990dd857e57
Jan Kotas [Thu, 7 Mar 2019 15:37:04 +0000 (07:37 -0800)]
Cleanup unused hosting interfaces (dotnet/coreclr#23091)
Commit migrated from https://github.com/dotnet/coreclr/commit/
70300c711b9e507d251f9a31d5c4be9653dd4c8a
Hugh Bellamy [Thu, 7 Mar 2019 14:39:23 +0000 (14:39 +0000)]
Cleanup Globalization info code (dotnet/coreclr#22591)
Commit migrated from https://github.com/dotnet/coreclr/commit/
724112354c74b67629d58d1f6b9c0007f5a13fc9
Sergey Andreenko [Thu, 7 Mar 2019 07:09:11 +0000 (23:09 -0800)]
Ignore warning in another build script. (dotnet/coreclr#23082)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8e39d114c9f9733f3337dc678cd2344631dd4742
Next Turn [Thu, 7 Mar 2019 02:26:51 +0000 (10:26 +0800)]
Fix comment (dotnet/coreclr#23058)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a8e9f22240cbd0ac75f119a05d92ccfb19342940
Mike McLaughlin [Thu, 7 Mar 2019 01:57:13 +0000 (17:57 -0800)]
Fix missing includes in coreclr/src/debug/createdump/ (dotnet/coreclr#23075)
See issue 19722.
Commit migrated from https://github.com/dotnet/coreclr/commit/
898d3f4b8f7dd9ab6bd87548e2f11a5d1618f59a
Michal Strehovský [Thu, 7 Mar 2019 00:52:36 +0000 (01:52 +0100)]
Remove legacy behavior around non-virtual interface calls (dotnet/coreclr#23032)
* Throw BadImageFormat for direct calls to abstract methods
* Remove legacy behavior around non-virtual interface calls
* Try fixing failing tests
The test we inherited from the default interface method prototype branch is doing exactly the thing it shouldn't do (rely on the bad behavior) for unexplained reasons.
Commit migrated from https://github.com/dotnet/coreclr/commit/
502de2a97b9fd26082ee8e3de46734724b2b535c
Sven Boemer [Thu, 7 Mar 2019 00:26:17 +0000 (16:26 -0800)]
Use Microsoft Container Registry for docker images (dotnet/coreclr#23061)
* Use Microsoft Container Registry for docker images
https://github.com/dotnet/dotnet-buildtools-prereqs-docker has been updated to publish docker images to the Microsoft Container Registry.
* Also update netci.groovy
Commit migrated from https://github.com/dotnet/coreclr/commit/
18542014bba5c33a776fa12c46a001fbe55dc5d1
Michal Strehovský [Mon, 4 Mar 2019 17:41:36 +0000 (18:41 +0100)]
Fix ProjectN build breaks (dotnet/corertdotnet/coreclr#7115)
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
28342adceb2995f9074a289c0b82b580f5fb1fe9
Honza Rameš [Wed, 6 Mar 2019 15:51:17 +0000 (16:51 +0100)]
Fix ValueStringBuilder.EnsureCapacity to call Grow correctly (dotnet/coreclr#35810)
* Fix ValueStringBuilder.EnsureCapacity to call Grow correctly (dotnet/coreclr#35746)
Call to EnsureCapacity may result in invalid buffer size being
allocated.
* Update ValueStringBuilder.Grow to prevent misuse (dotnet/coreclr#35746)
Updated name of the argument to make it clearer on the call-site also
added summary co clearly state the behavior of Grow.
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
042e1790a50e79cc99d63125c6281bd2f1e1d387
dotnet-maestro[bot] [Tue, 5 Mar 2019 19:17:12 +0000 (19:17 +0000)]
Update dependencies from dotnet/core-setup (dotnet/corefxdotnet/coreclr#35713)
* Update dependencies from https://github.com/dotnet/core-setup build
20190301.13
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27501-13
* Remove workaround for System.Runtime.CompilerServices.Unsafe
* Update dependencies from https://github.com/dotnet/core-setup build
20190302.8
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27502-8
* Update dependencies from https://github.com/dotnet/core-setup build
20190303.9
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27503-9
* Update dependencies from https://github.com/dotnet/core-setup build
20190304.10
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27504-10
* Don't include EventRegistrationToken on Unix
This type was accidentally duplicated between CoreLib and contracts.
Suppress that for now since we're detecting the duplication in the shared framework.
Make a fix in the shared items to restore the condition on this type.
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
afcb5e3de5cf3df6d865c284168e82c5f6c73038
Viktor Hofer [Sun, 3 Mar 2019 17:55:25 +0000 (18:55 +0100)]
Project msbuild syntax cleanup (dotnet/corefxdotnet/coreclr#35686)
* Remove license header from non-shipping files
* Remove obsolete Project attributes
* Remove xml header and remove DefaultTargets
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
864a9cc1af452d72e72b0e9db8c84a0c19f498d3
Michelle McDaniel [Thu, 7 Mar 2019 00:19:16 +0000 (16:19 -0800)]
Change IBC data path to match Arcade standard (dotnet/coreclr#23063)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a270c17c931f3bbc9f2f1cad8baa29ace5e36c14
Bruce Forstall [Wed, 6 Mar 2019 23:55:11 +0000 (15:55 -0800)]
Fix PMI asm diffs
Fix scratch_root validation
Commit migrated from https://github.com/dotnet/coreclr/commit/
2062dc2339bd05886d7230df995d84e14231727e
Jarret Shook [Wed, 6 Mar 2019 23:00:37 +0000 (15:00 -0800)]
Do not conflict publish name based on scenario (dotnet/coreclr#23041)
* Do not conflict publish name based on scenario
* Fix syntax error
Commit migrated from https://github.com/dotnet/coreclr/commit/
2f1e36058d44e458e4d76ef633463ff45db17e07
Koundinya Veluri [Wed, 6 Mar 2019 19:17:18 +0000 (11:17 -0800)]
Temporarily disable some WaitAny tests that have been failing periodically in the CI (dotnet/coreclr#22997)
Issues:
- https://github.com/dotnet/coreclr/issues/19515
- https://github.com/dotnet/coreclr/issues/19406
- https://github.com/dotnet/coreclr/issues/14249
Commit migrated from https://github.com/dotnet/coreclr/commit/
1c39a226041de19909a964889d77c0cfc908bf45
Michal Strehovský [Wed, 6 Mar 2019 18:23:44 +0000 (19:23 +0100)]
Improve resiliency of LoadIBCMethodHelper (dotnet/coreclr#23057)
The encoded slot could be bogus and we would end up asserting for this.
Commit migrated from https://github.com/dotnet/coreclr/commit/
326b25a658e87a122708d5ce1f4d997c1c1730f5
Andy Ayers [Wed, 6 Mar 2019 18:14:40 +0000 (10:14 -0800)]
JIT: fix issue with assertion prop on isinst helpers (dotnet/coreclr#23056)
For calls to isinst helpers, morph may rearrange the order of args on the late
arg list, so examine the operands to ensure the right ones are passed into the
assertion creation code.
Added simplified test case.
Closes dotnet/coreclr#23039.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ce4140ca10cdda9af170d5215ff9de295c58a30
Carol Eidt [Wed, 6 Mar 2019 18:07:07 +0000 (10:07 -0800)]
Merge pull request dotnet/coreclr#22912 from fiigii/fixBroadcast
Fix BroadcastScalarToVector128/256 codegen
Commit migrated from https://github.com/dotnet/coreclr/commit/
b7922721dc7298094da3f4c2bcf31b43fde9476b
Tanner Gooding [Wed, 6 Mar 2019 12:27:57 +0000 (04:27 -0800)]
Fixing the float/double parsing logic to handle exponents that are too large/small (dotnet/coreclr#23043)
* Fixing the float/double parsing logic to handle exponents that are too large/small
* Fixing the debug assert to use >= and <=
* Fixing the max exponents to be +1 to match what scale uses.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5a2650959268bf0a760965a2bd8cca34301cd1a1
Fei Peng [Wed, 6 Mar 2019 08:30:14 +0000 (00:30 -0800)]
fix BroadcastScalarToVector128/256 and simplify MoveMask
Commit migrated from https://github.com/dotnet/coreclr/commit/
c5da1c4c42f1f1bc3f8254bc9c50bcd431f10001
Steve MacLean [Wed, 6 Mar 2019 07:40:50 +0000 (02:40 -0500)]
Cleanup old code (dotnet/coreclr#23053)
Remove IsContinuableException declaration & fix comment
Clean up ThreadBaseRedirectingFilter
Clean up comment
Cleanup dead code
Commit migrated from https://github.com/dotnet/coreclr/commit/
cb87aaebb321edd9ed74786305953314acfefda3
Andy Ayers [Wed, 6 Mar 2019 06:49:49 +0000 (22:49 -0800)]
Reduce running time of GitHub_19361 test case (dotnet/coreclr#23048)
This is a regression test and the original issue indicated that the test
would fail reliably under GC stress. So cut down the size of the lists
being processed and remove the various exclusions.
This reduces execution time on arm64 debug from ~30 mins to 2 seconds.
Closes dotnet/coreclr#20232.
Commit migrated from https://github.com/dotnet/coreclr/commit/
76abdef2f4e1d91c97581e0d5ec63d6edf3248c0
Jeremy Koritzinsky [Wed, 6 Mar 2019 04:54:49 +0000 (20:54 -0800)]
Move HasLayoutMetadata to methodtablebuilder.cpp (dotnet/coreclr#23015)
* Move HasLayoutMetadata to methodtablebuilder.cpp
* Collapse auto case into unicode case.
* Remove ancient workaround for Managed C++ compiler bug.
Commit migrated from https://github.com/dotnet/coreclr/commit/
400b472f3333fd2a5371fcab7c34c2892b6324c6
Stephen Toub [Wed, 6 Mar 2019 03:37:33 +0000 (19:37 -0800)]
Clean up some string.Format usage (dotnet/coreclr#23025)
* Clean up some string.Format usage
Mainly changes some string.Format usage to be SR.Format when working with resource strings. Also cleans up a few asserts that were using string.Format.
* Address PR feedback and clean up src
* Address more feedback
* Update src/System.Private.CoreLib/shared/System/Type.Enum.cs
Thanks.
Co-Authored-By: stephentoub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
3662d02bb222728ebed70d6d73f89a63c9910ffb
Carol Eidt [Wed, 6 Mar 2019 01:32:13 +0000 (17:32 -0800)]
Correctly type SIMD stack values
When `impSIMDPopStack` pops a struct value, it needs to retype the `OBJ` if it exists and doesn't match.
Fix dotnet/coreclr#22850
Commit migrated from https://github.com/dotnet/coreclr/commit/
140e519ef8fe494ac794f4d050dd87c23dc85f22
Andrew Au [Tue, 5 Mar 2019 21:48:50 +0000 (13:48 -0800)]
Fix issue 23040
Commit migrated from https://github.com/dotnet/coreclr/commit/
ffcdabd7735d6860dec361d1efde20be4cf89b8f
Andrew Au [Tue, 5 Mar 2019 20:01:15 +0000 (12:01 -0800)]
Fix issue 23037
Commit migrated from https://github.com/dotnet/coreclr/commit/
a20e3d04343d47326e3c0789802890bc3f0c522c
John Salem [Tue, 5 Mar 2019 21:20:55 +0000 (13:20 -0800)]
Update delegate signature for GetSourceLineInfo and change reflection logic to find correct overload on CoreFX side (dotnet/coreclr#22960)
Commit migrated from https://github.com/dotnet/coreclr/commit/
98cd595b35ced3adb6efe0c667f5160f21067e0b
Aaron Robinson [Tue, 5 Mar 2019 20:08:01 +0000 (12:08 -0800)]
Re-enable RCW license tests (dotnet/coreclr#23023)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2add95d3f3dc6e0b54946f88ba2215560f5002a3
Maryam Ariyan [Tue, 5 Mar 2019 19:36:02 +0000 (11:36 -0800)]
Add Type Forward (dotnet/coreclr#23036)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c004dff82def0f92ca837b81fd93445ae767fd62
Marek Safar [Tue, 5 Mar 2019 19:07:15 +0000 (20:07 +0100)]
Move more Assembly methods to shared partition (dotnet/coreclr#22817)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2a295e0232aa28dd9b98a0f8bd9bd6ed12b6a4bd
Juan Hoyos [Tue, 5 Mar 2019 18:41:22 +0000 (10:41 -0800)]
Merge pull request dotnet/coreclr#23002 from optimization
[master] Update dependencies from 1 repositories
Commit migrated from https://github.com/dotnet/coreclr/commit/
4834806fa2268b73ffe23ef6ccf40e93946bc7d6
Jarret Shook [Tue, 5 Mar 2019 17:10:07 +0000 (09:10 -0800)]
Disable test correctly. Missed casing (dotnet/coreclr#23035)
Commit migrated from https://github.com/dotnet/coreclr/commit/
75cc2a038d8608501d6788c1423965e3a7280dae
Russ Keldorph [Sun, 3 Mar 2019 05:00:34 +0000 (21:00 -0800)]
Fix JIT/Directed/pinvoke/tail
Remove dependency on Windows user32 library and enable test for all platforms.
Fixes dotnet/coreclr#13048
Commit migrated from https://github.com/dotnet/coreclr/commit/
5739414d9757164ccf54cf92fd556f7ae6a16402
Andrew Au [Mon, 4 Mar 2019 23:39:41 +0000 (15:39 -0800)]
Fix issue 23009
Commit migrated from https://github.com/dotnet/coreclr/commit/
119cfe86d996aec5f81a2dae491e9c8c7f445bb5
Steve MacLean [Tue, 5 Mar 2019 11:29:18 +0000 (06:29 -0500)]
Remove dead AppDomain unload code (dotnet/coreclr#23026)
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc11162e1c36624d3cabb6e0bf6583a94ab2e30c
Sung Yoon Whang [Tue, 5 Mar 2019 11:06:40 +0000 (03:06 -0800)]
Update eventcounter spec (dotnet/coreclr#23019)
* Update EventCounter spec
* some wording fix
* some wording fix
* fix payload example
* Add DisplayRateTimeScale
Commit migrated from https://github.com/dotnet/coreclr/commit/
b54752c8869f55c82cc24b49fbb1b48a87090943
Andy Ayers [Tue, 5 Mar 2019 07:30:48 +0000 (23:30 -0800)]
JIT: remove unneeded ref count updating traversal from optimizer (dotnet/coreclr#22954)
The ref count update traversal in the optimizer is not doing anything,
so remove it. This was overlooked when we changed away from incremental
updates in dotnet/coreclr#19345.
Also: fix up comments and documentation to reflect the current approach
to local var ref counts.
Commit migrated from https://github.com/dotnet/coreclr/commit/
04fed62162092da2a824e425aa65b8fcfc70ce14
Steve MacLean [Tue, 5 Mar 2019 06:54:24 +0000 (01:54 -0500)]
Remove dead ContainToAppDomain (dotnet/coreclr#23021)
* Remove dead ContainToAppDomain
* Respond to feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d54e6130f0db16b2eaa80272076ae3bd725cf69
Sergey Andreenko [Tue, 5 Mar 2019 05:46:19 +0000 (21:46 -0800)]
Do not treat warnings as errors during corefx build in docker. (dotnet/coreclr#23014)
* Do not treat warnings as errors during corefx build in docker.
* Add a comment.
Commit migrated from https://github.com/dotnet/coreclr/commit/
14caedf474161891c09e740448f07e541e7a95b5
Aaron Robinson [Tue, 5 Mar 2019 02:58:56 +0000 (18:58 -0800)]
Remove loose dependency in runtime on System.ComponentModel. (dotnet/coreclr#23010)
Remove loose dependency in runtime on System.ComponentModel.
Disable test to sync with CoreFX
Commit migrated from https://github.com/dotnet/coreclr/commit/
88ada237f7765b7edd39967adab8ea2ba25ea16c
Steve MacLean [Tue, 5 Mar 2019 01:29:11 +0000 (20:29 -0500)]
Remove BEGIN/END_EXCEPTION_GLUE from botr
Commit migrated from https://github.com/dotnet/coreclr/commit/
77fcaf6b738941a0c5dc3c00b70b49c7d9f63b69
Egor Chesakov [Tue, 5 Mar 2019 00:42:40 +0000 (16:42 -0800)]
Pass -priority= argument directly to build-test.cmd (dotnet/coreclr#23007)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a217ea2902e26182e7f8f3f66afce1fffa1fc175
Egor Chesakov [Mon, 4 Mar 2019 23:22:56 +0000 (15:22 -0800)]
Publish logs as pipeline artifacts for build-job.yml and test-job.yml (dotnet/coreclr#22926)
Commit migrated from https://github.com/dotnet/coreclr/commit/
857567c1b7f35986bc72d7d417e8db64f4df9f72
Jarret Shook [Mon, 4 Mar 2019 22:22:44 +0000 (14:22 -0800)]
Disable tests for open issues (dotnet/coreclr#22976)
* Disable tests for open issues
* Clean pri1 run
Commit migrated from https://github.com/dotnet/coreclr/commit/
d17b66c8bbc21fc8be18d901e691ed7e9bc8d7ce
Jarret Shook [Mon, 4 Mar 2019 22:19:14 +0000 (14:19 -0800)]
Fix rid choice setup stress (dotnet/coreclr#23004)
* Correct rid choice for setting up coredistools
* Force ubuntu.14.04 as the rid choice for ubuntu
* Add better comment
* Fix typo
Commit migrated from https://github.com/dotnet/coreclr/commit/
36cf483227b1fdc3d6554ab6694cb0215b0eed26
Jeremy Koritzinsky [Mon, 4 Mar 2019 21:15:28 +0000 (13:15 -0800)]
Move EEClassLayoutInfo::CollectLayoutFieldMetadataThrowing to class.cpp (dotnet/coreclr#22932)
Move `EEClassLayoutInfo::CollectLayoutFieldMetadataThrowing` to class.cpp and out of fieldmarshaler.cpp.
This change co-locates `EEClassLayoutInfo::CollectLayoutFieldMetadataThrowing` with the rest of the implementation of `EEClassLayoutInfo`. Additionally, this PR separates out the field blittability check into a separate function instead of burying it in `CollectLayoutFieldMetadataThrowing`.
Finally, it adds a small optimization in the field marshaler implementations where if a field's native size is statically known, the code returns that value instead of calling into one of the FieldMarshaler "virtual" calls.
Originally part of dotnet/coreclr#21415, but extracted out to make that PR smaller.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1278da1f480e664b5afd1b62f2be74424dbefbb8
Carol Eidt [Mon, 4 Mar 2019 16:54:19 +0000 (08:54 -0800)]
Merge pull request dotnet/coreclr#22791 from CarolEidt/Fix19256
Fix condition for calling EvalArgsToTemps
Commit migrated from https://github.com/dotnet/coreclr/commit/
fd3afcaf0dc0ace3f84d0412c128f4e64c419105
Sinan Kaya [Mon, 4 Mar 2019 06:55:22 +0000 (01:55 -0500)]
Cleanup more GCC warnings (dotnet/coreclr#22872)
* Add parenthesis
src/vm/sha1.cpp: In function ‘void SHA1_block(SHA1_CTX*)’:
src/vm/sha1.cpp:93:29: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
#define ROUND3(B, C, D) ((C & (B | D) | (B & D)) + sha1_round3)
^
src/vm/sha1.cpp:139:32: note: in expansion of macro ‘ROUND3’
e += ROTATE32L(a, 5) + ROUND3(b, c, d) + msg80[i];
* Move declaration into same file as one was defined Extern the other one was static
* Remove hr=hr undefined assignment
* Fix mutli-line comment warning
* Convert multi-character literal
* Remove null check for stack local variables
rc/vm/invokeutil.cpp: In static member function ‘static void InvokeUtil::SetValidField(CorElementType, TypeHandle, FieldDesc*, OBJECTREF*, OBJECTREF*, TypeHandle, CLR_BOOL*)’:
src/vm/invokeutil.cpp:978:29: warning: the address of ‘Throwable’ will never be NULL [-Waddress]
EX_CATCH_THROWABLE(&Throwable);
^
src/inc/ex.h:1087:21: note: in definition of macro ‘EX_CATCH_THROWABLE’
if (NULL != ppThrowable)
^
Commit migrated from https://github.com/dotnet/coreclr/commit/
9d3f264b9ef8b4715017ec615dcb6f9d57e607cc
Dotnet-GitSync-Bot [Mon, 4 Mar 2019 05:07:25 +0000 (21:07 -0800)]
Mirror changes from dotnet/corert (dotnet/coreclr#22985)
* Move fully managed TimerQueue implementation to shared partition (dotnet/coreclr#7111)
* Update CoreCLR for changes in shared partition
Commit migrated from https://github.com/dotnet/coreclr/commit/
7da0883d9ceba31bccf36cc8cbbbf2fe77a4f3e0
Stephen Toub [Sun, 3 Mar 2019 21:33:39 +0000 (16:33 -0500)]
Merge pull request dotnet/coreclr#22981 from dotnet/darc-master-
95952865-131b-47b2-99d0-
f60a630db1b3
[master] Update dependencies from dotnet/corefx
Commit migrated from https://github.com/dotnet/coreclr/commit/
fef5785dbb0012da8ff2b53007b2684df23a729e
Jan Kotas [Sun, 3 Mar 2019 15:08:54 +0000 (07:08 -0800)]
Disable outdated tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
758823876700728fee63f7726791f35ef391d377
Jan Kotas [Sun, 3 Mar 2019 06:25:25 +0000 (22:25 -0800)]
Fix CoreCLR build break
Commit migrated from https://github.com/dotnet/coreclr/commit/
d36c51023ef0bd58301e2f0e441f4c1901981263
Jan Kotas [Sun, 3 Mar 2019 03:21:19 +0000 (19:21 -0800)]
Update CoreRT for changes in shared partition
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
f22edcb508780dc3d6442b8233c49d60ad695225
Fawad Halim [Sun, 3 Mar 2019 03:21:39 +0000 (03:21 +0000)]
Corrected some misspellings (dotnet/coreclr#22978)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3e9f456f81e215ddcd6b1fb1443fa551725a3eb1
Marek Safar [Sat, 2 Mar 2019 22:22:55 +0000 (23:22 +0100)]
Move Activator to shared partition (dotnet/coreclr#22894)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7ddd038a33977b152e856448443425cbc6b591c6
Grant [Sat, 2 Mar 2019 21:55:07 +0000 (13:55 -0800)]
Use BitOperations in more callsites (CoreCLR) (dotnet/coreclr#22630)
* Missed perf improvement in EventProvider
* Add missing methods to StubEnvironment
Commit migrated from https://github.com/dotnet/coreclr/commit/
3c0f075864df149fd477cbf07f0c606239798fc6
dotnet-maestro[bot] [Sat, 2 Mar 2019 18:55:15 +0000 (10:55 -0800)]
[master] Update dependencies from dotnet/corefx (dotnet/coreclr#22968)
* Update dependencies from https://github.com/dotnet/corefx build
20190302.1
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19152.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19152.1
* Disable outdated tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
fcfc3baa491b0ac7eb6a9cb73e3b2d46cb5929a0
Jarret Shook [Sat, 2 Mar 2019 18:54:48 +0000 (10:54 -0800)]
Revert "Revert "Improve coreclrhost.h header" (dotnet/coreclr#22955)" (dotnet/coreclr#22973)
This reverts commit dotnet/coreclr@
831cb13f1432aac09e66a8543831d3ed55b4bddf.
Commit migrated from https://github.com/dotnet/coreclr/commit/
441f049754803a0f1b40bb2cacb977df8a1425fa
Jarret Shook [Sat, 2 Mar 2019 18:51:40 +0000 (10:51 -0800)]
Revert "Improve coreclrhost.h header" (dotnet/coreclr#22955)
Commit migrated from https://github.com/dotnet/coreclr/commit/
831cb13f1432aac09e66a8543831d3ed55b4bddf
Jan Kotas [Sat, 2 Mar 2019 16:49:52 +0000 (08:49 -0800)]
Disable DOTNET_MULTILEVEL_LOOKUP in the build scripts (dotnet/coreclr#22972)
Fixes dotnet/coreclr#22971
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff53a99fb9e4c6e479a60c09a7014bfb72af4936
Marek Safar [Sat, 2 Mar 2019 13:46:27 +0000 (14:46 +0100)]
Move more Thread logic to shared partition (dotnet/coreclr#22935)
* Move more Thread logic to shared partition
* Keep the fields in runtime part for reliable layout structure
Commit migrated from https://github.com/dotnet/coreclr/commit/
ef0fde985732148eea136e90aece4ccd3d0370b5
Jan Kotas [Sat, 2 Mar 2019 04:15:28 +0000 (20:15 -0800)]
Fix CoreFX build break
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
d3e8eced36393f6c8b7e03b30acbcd33f2c284b9
Jan Kotas [Fri, 1 Mar 2019 21:59:19 +0000 (13:59 -0800)]
Fix netfx build break
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc6bba9d005edf2cc5df77795591fb2ef660055f
Aaron Robinson [Sat, 2 Mar 2019 06:53:42 +0000 (22:53 -0800)]
Support IClassFactory2 - LicenseManager use in COM activation (dotnet/coreclr#22846)
* Implement IClassFactory2
* Add test support for IClassFactory2
* Add support for testing RCW activation via IClassFactory2
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e66e140f09b32694b32b98c34d8948bdf3608a3
Steve MacLean [Sat, 2 Mar 2019 04:07:35 +0000 (23:07 -0500)]
Use arcade's version of dotnet to build (dotnet/coreclr#22755)
* Use arcade dotnet
* Add cmake_msbuild.cmd
Move msbuild.cmd to cmake_msbuild.bat
Document intent that this file is only used to resolve
Windows cmake dependency on desktop msbuild.exe
Remove one instance of msbuild.cmd
* Fix inittools.cmd
* Remove spurious setup_vs_tools.cmd calls
Commit migrated from https://github.com/dotnet/coreclr/commit/
42bc2de2c63fe0c95a582e642ff97b2fe0d4bb7e
Varun Venkatesan [Sat, 2 Mar 2019 00:41:09 +0000 (16:41 -0800)]
Revert heapcount and enable CPU Groups to fix Ubuntu FPE (dotnet/coreclr#22861)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1801e85024add717f518feb6a9caed60d54500f