Charlie Turner [Mon, 23 Jan 2023 22:30:54 +0000 (22:30 +0000)]
Resolves invalid memory writes in primitives generated tests
There were also a lot of claimed memory leaks by Valgrind, due to the
use of naked new's in testGenerator. Those have been moved to the
smart pointer classes that NULL the allocations after releasing.
dEQP-VK.transform_feedback.primitives_generated* is Valgrind clean
after this patch.
Components: Vulkan
Affects: dEQP-VK.transform_feedback.primitives_generated*
VK-GL-CTS issue: 4247
Change-Id: Ie8383525e22da95ab65040c9671ce0adaba67ed5
Piotr Byszewski [Fri, 3 Feb 2023 11:47:16 +0000 (12:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I578236cdd1975af030cd58b6d52f33eba0ba5968
Piotr Byszewski [Fri, 3 Feb 2023 09:48:41 +0000 (10:48 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I600ba4948d887c74a6adbe8a8b49715367c4fe4f
Hyunjun Ko [Mon, 30 Jan 2023 07:51:43 +0000 (16:51 +0900)]
Fix a bunch of validation errors of pipeline library tests.
Fixes:
VUID-VkGraphicsPipelineCreateInfo-flags-06608
VUID-VkGraphicsPipelineLibraryCreateInfoEXT-flags-requiredbitmask
VUID-VkGraphicsPipelineCreateInfo-renderpass-06631
VUID-vkCmdPipelineBarrier-srcAccessMask-02815
VUID-vkCmdPipelineBarrier-dstAccessMask-02816
UNASSIGNED-CoreValidation-Shader-InputNotProduced
VUID-vkCmdDraw-None-04007
VUID-vkCmdDraw-None-02721
Also removes 2 tests, trying to create a pipeline library with all
pipeline states, which violates VUID-VkGraphicsPipelineCreateInfo-flags-06608.
Affects:
dEQP-VK.pipeline.pipeline_library.graphics_library.*
Removed tests:
dEQP-VK.pipeline.pipeline_library.graphics_library.fast.0_1_1_1_1
dEQP-VK.pipeline.pipeline_library.graphics_library.optimize.0_1_1_1_1
VK-GL-CTS Issue: 4255
Components: Vulkan
Change-Id: I0ed2fa28cc5626aeee60f08527a7467428354d4a
Piotr Byszewski [Fri, 3 Feb 2023 06:14:37 +0000 (07:14 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I2f773b33feb6c9c55e4f2692c800d846280e0e90
Piotr Byszewski [Thu, 2 Feb 2023 19:26:04 +0000 (20:26 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ic7b88eb0135468ea8b013fff65e216a0bc945a6b
Piotr Byszewski [Thu, 2 Feb 2023 18:23:39 +0000 (19:23 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I4ec95db96541e01f4e47d3fe1abdd3f9e305adbb
Joe Withers [Mon, 30 Jan 2023 17:32:24 +0000 (17:32 +0000)]
Fix tolerance values when VK_COMPONENT_SWIZZLE_ONE is in use
Tolerance values were being increased unnecessarily for tests using
VK_COMPONENT_SWIZZLE_ONE.
This change overwrites any SWIZZLE_ONE with SWIZZLE_ZERO when applying
a swizzle to the threshold values, to maintain a strict tolerance.
Affects: dEQP-VK.pipeline.sampler.border_swizzle.*
Components: Vulkan
Change-Id: Ie72e4a97e502bdbb74ea412951f5a9481434d489
Charles Johnston [Thu, 19 Jan 2023 15:58:04 +0000 (10:58 -0500)]
Enable CTS log files to exceed 2GB on 32-bit Linux build
Components: Framework
VK-GL-CTS issue: 4238
Change-Id: Ie9c58364f0bb44c3b2a15a71585d4801d0b12063
Charlie Turner [Mon, 23 Jan 2023 13:35:26 +0000 (13:35 +0000)]
Prevent warnings from Amber failing the CTS build
With clang++-16, I'm seeing lots of cases like,
/home/cturner/src/vk-gl-cts/external/amber/src/src/float16_helper.cc:66:42: error: unchecked operation on raw buffer in expression [-Werror,-Wunsafe-buffer-usage]
uint32_t sign = (static_cast<uint32_t>(value[1]) & 0x80) << 24U;
Inhibit all warning messages for Clang, GCC & MSVC.
Components: Framework, Vulkan
Change-Id: I1910780048d8828a61733a5f5f36404f8a8184b0
aitor_lunarg [Fri, 20 Jan 2023 20:36:49 +0000 (21:36 +0100)]
Fix query_present_modes2_surfaceless tests
Tests expected to have same values for null surface and non-null
surfaces when retrieving present modes which is not correct.
When retrieving present modes with null surfaces, retrieved modes
can only be FIFO_KHR, SHARED_DEMAND_REFRESH_KHR and
SHARED_CONTINUOUS_REFRESH_KHR.
Affects:
dEQP-VK.wsi.*.surface.query_present_modes2_surfaceless
Components: Vulkan
VK-GL-CTS issue: 4221
Change-Id: I70cc0a73302d76379d8c9b46be69d20cb8c6b1b0
Piotr Byszewski [Sat, 28 Jan 2023 16:27:27 +0000 (17:27 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I6ca6dbc9b10c6a6ab76bae3c9f2593be1f9f811e
Piotr Byszewski [Fri, 27 Jan 2023 16:47:52 +0000 (17:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ia7e33918ec57b26ca43a9b8468bc134c15ea9915
ziga-lunarg [Tue, 17 Jan 2023 11:31:56 +0000 (12:31 +0100)]
Fix colorAttachmentCount mismatch in stencil tests
pColorBlendState::attachmentCount must match colorAttachmentCount of the
subpass used in the pipeline
Components: Vulkan
VK-GL-CTS issue: 4229
Affected tests:
dEQP-VK.pipeline.*.stencil.*
Change-Id: I1656cda0af45ae3df65c25790e360a17863273d4
Piotr Byszewski [Fri, 27 Jan 2023 11:58:28 +0000 (12:58 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Ib94de3bf6ded8ac215a706e0005631d397fce704
Piotr Byszewski [Fri, 27 Jan 2023 10:30:35 +0000 (11:30 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ic6015e95ad8e7d411948ec7ef1ccaf33081212f7
ziga-lunarg [Fri, 6 Jan 2023 17:09:46 +0000 (18:09 +0100)]
Fix rgba10x6 feature check in texture filtering tests
If VK_IMAGE_USAGE_SAMPLED_BIT is used when creating the image
VkSamplerYcbcrConversionInfo is required in the pNext chain, if format
is VK_FORMAT_R10XgG10X6B10X6A10X6_UNORM_4PACK16 and
formatRgba10x6WithoutYCbCrSampler feature is not enabled
Components: Vulkan
VK-GL-CTS issue: 4206
Affected tests:
dEQP-VK.texture.filtering.*
Change-Id: I296ac69902f87b301f4e2930d28b171e8ce02a13
ziga-lunarg [Fri, 6 Jan 2023 16:34:34 +0000 (17:34 +0100)]
Add missing support check in texture filtering with rgba10x6 format
Feature formatRgba10x6WithoutYCbCrSampler must be enabled when
VK_FORMAT_R10X6G10X6B10X6A10X6_UNORM_4PACK16 is used in these tests,
because more than 1 mip level is used and only formats which do not
require sampler YCbCR conversion can be used
Components: Vulkan
VK-GL-CTS issue: 4205
Affected tests:
dEQP-VK.texture.filtering.cube.*
Change-Id: I3bdd286af2d0f2c19443e5d64304c69e43a43095
Piotr Byszewski [Fri, 27 Jan 2023 08:48:28 +0000 (09:48 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I29ea16db0e7ddc2b374888f41ed07523b233aedb
ziga-lunarg [Sun, 15 Jan 2023 11:47:18 +0000 (12:47 +0100)]
Fix image barrier in ray tracing pipeline build tests
Use the correct combination of access mask and pipeline stage
Components: Vulkan
VK-GL-CTS issue: 4202
Affected tests:
dEQP-VK.ray_tracing_pipeline.build.*
Change-Id: I185c3787b6bfa24c79f5fbd063fc041d000ae0f4
Hyunjun Ko [Fri, 20 Jan 2023 02:11:02 +0000 (11:11 +0900)]
Do not allow to call vkSetEvent after submission, which is invalid.
The spec says:
"If a command buffer submission waits for any events to be signaled,
the application must ensure that command buffer submissions will be
able to complete without any subsequent operations by the application.
Events signaled by the host must be signaled before the command buffer
waits on those events."
This means it's not valid to signal an event on the host after submission
of a command buffer containing a wait for the event. Also it forces the
command buffer to stop for an unknown amount of time, as much as the time
needed for the host to signal the event with vkSetEvent.
However there were some CTS tests doing like this, which should be
fixed.
For vktApiExternalMemoryTests.cpp,
There was a vkSetEvent call after submission to hold a command to be
executed before signaling to get a native file descriptor, which is
not valid. So the tests should allow to get -1. Also we do an atomic calculation
to avoid singalling right after submit when trying to get a native fd.
The simple atomic calculation is evaluated to take about 10ms.
For vktApiExternalMemoryTests.cpp and vktMemoryExternalMemoryHostTests.cpp,
replace vkSetEvent with timeline semaphore to signal from the host.
Affects:
dEQP-VK.api.external.semaphore.*
dEQP-VK.api.external.fence.*
dEQP-VK.api.command_buffers.secondary_execute_twice
dEQP-VK.memory.external_memory_host.synchronization.synchronization
VK-GL-CTS Issue: 4075
Components: Vulkan
Change-Id: I5544bb15a418bbbbd6552ca04bec673a56ca3109
Sviatoslav Peleshko [Thu, 5 Jan 2023 23:40:46 +0000 (01:40 +0200)]
Add missing buffer memory flush
We do a memcpy to the buffer, but don't flush it. If we don't use
host-coherent memory for this buffer it might sometimes lead to
corruption (when we later invalidate the buffer's memory to get
results from the shader).
Components: Vulkan
Affected tests:
dEQP-VK.query_pool.statistics_query.compute_shader_invocations.*
dEQP-VK.query_pool.statistics_query.*.compute_shader_invocations.*
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Change-Id: I2f9491d6cacf39fe6a00d7624e2aa474615421ce
Connor Abbott [Tue, 29 Nov 2022 11:17:17 +0000 (12:17 +0100)]
Use correct extent for 1D compute texel_view_compatible tests
We weren't sanitizing the size in the parameters, resulting in
copyDataToImage() passing an extent with a non-1 height to when
uploading to a 1D image. Sanitize fullSize, and remove a case where
where we were workaround it not being sanitized.
Components: Vulkan
Affects: dEQP-VK.image.texel_view_compatible.compute.basic.1d_image.*
VK-GL-CTS Issue: 4143
Change-Id: Icdb50c09137a947f47b1afc7426e53e73c31f689
Piotr Byszewski [Mon, 23 Jan 2023 10:31:34 +0000 (11:31 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I45389a45424b0978ce6ac4b08108717c486e1bee
Mohd Faisal [Wed, 10 Aug 2022 14:04:04 +0000 (15:04 +0100)]
Added missing android hardware buffer formats
Android hardware buffer formats are added in image compression
control test. Also, updated the test names.
Components: Vulkan
VK-GL-CTS issue: 3883
Affects:
dEQP-VK.api.image_compression_control.android_hardware_buffer.*
Change-Id: I39643d186200d63a81cff2eb244bbdf085954a03
Alejandro Piñeiro [Thu, 12 Jan 2023 12:09:47 +0000 (13:09 +0100)]
ycbcr: Align properly offset used for BindImageMemory2
The test is using directly the requirements size, but it should be
ensure that is aligned to the requirements alignment.
Components: Vulkan
VK-GL-CTS Issue: 4223
Affects:
dEQP-VK.ycbcr.subresource_offset.*
Change-Id: I219fb38704ac3b2c0bd6d4f9afbde6d2265e1be6
Piotr Byszewski [Sat, 21 Jan 2023 16:24:32 +0000 (17:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I63428d6dfccd323392ff975aef0a1a3ace0f52da
James Fitzpatrick [Mon, 9 Jan 2023 15:22:38 +0000 (15:22 +0000)]
Allow sample mask test after sample counting
After vulkan!5640 it is now legal for sample mask test to be executed
after sample counting when Early Fragment Tests is enabled.
Update the early fragment tests with sample counting to allow for this
behaviour by reporting a Quality Warning if the sample mask is ignored
when calcuating the returned sample count.
Affects: dEQP-VK.fragment_operations.early_fragment.sample_count_early_fragment_tests_depth_*
Components: vulkan
VK-GL-CTS issue: 4218
Change-Id: I61ca28f6570e1835b19c03ae1b1d93cad0228190
Piotr Byszewski [Fri, 20 Jan 2023 16:05:14 +0000 (17:05 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Ie8b2a9e9b203ff93bd2c6f30c796bf6f560a9c40
Piotr Byszewski [Fri, 20 Jan 2023 12:48:26 +0000 (13:48 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Iaa91df30fc4231c3a428fef1c74c8d9aa72720ba
Piotr Byszewski [Fri, 20 Jan 2023 10:18:18 +0000 (11:18 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I40db0dabbedb2e8245c3597bec80832a47f1658d
Slawomir Cygan [Thu, 12 Jan 2023 15:27:44 +0000 (16:27 +0100)]
Fix merge error in FSR srlayered tests
Reapply last chunk from
853897a8722 which seems to
have been broken in a merge: layercount value was passed
instead of viewFormatCount.
This is fixes a regression introduced by 10618, which was exposed
after being promoted to vulkan-cts-1.2.8+.
Components: Vulkan
VK-GL-CTS Issue: 4224
VK-GL-CTS Issue: 4226
Affects: dEQP-VK.fragment_shading_rate.*
Change-Id: Ib8f5b180368fe9bf3c32f349c2475a4932f30fbf
Piotr Byszewski [Thu, 19 Jan 2023 17:59:29 +0000 (18:59 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Iaae2490f0ec3069759a7660dee175cfdc3668622
Aitor Camacho [Tue, 3 Jan 2023 18:25:23 +0000 (19:25 +0100)]
Update scripts for Android build
- Use d8 instead of dx due to deprecation
- Use apksigner instead of jarsigner for signature scheme v2 required by newer SDKs
- Move apk signing to be last step (required for signature scheme v2)
- Force uncompressed arsc files (required for SDK versions 30 and up)
- Add '--tool-api' argument for selecting build tools version
- Add permission for reading external storage in manifest
VK-GL-CTS Issue: 4163
Components: Framework
Change-Id: Iea4429f861148168ffe680cdf9a497cb467b8d6a
Piotr Byszewski [Tue, 17 Jan 2023 09:43:42 +0000 (10:43 +0100)]
Fix merge mistake related to android/*/*.txt files
In recent merge from 1.3.1 to 1.3.2 branch a mistake was made
that affected five android related txt files. This change
restores those files to content before the merge.
Components: Vulkan
VK-GL-CTS issue: 4228
Removed tests:
dEQP-VK.*
Change-Id: I51cb8a3869883621edd8e3af4c2863adfd8739ba
Slawomir Cygan [Tue, 6 Dec 2022 12:45:28 +0000 (13:45 +0100)]
Remove tests that use DS format in inheritance info, but have no depth attachment in vkCmdBeginRendering
Remove test cases, that target functionality that is against following spec wording:
"""
If vkCmdExecuteCommands is being called within a render pass instance begun with vkCmdBeginRendering and the
VkRenderingInfo::pDepthAttachment->imageView parameter to vkCmdBeginRendering was VK_NULL_HANDLE, the value of the >
depthAttachmentFormat member of the VkCommandBufferInheritanceRenderingInfo structure included in the pNext chain of
VkCommandBufferBeginInfo::pInheritanceInfo used to begin recording each element of pCommandBuffers must be VK_FORMAT_UNDEFINED
"""
VK-GL-CTS Issue: 4160
Components: Vulkan
Affects: dEQP-VK.dynamic_rendering.partial_secondary_cmd_buff.*.unused_clear_attachments
Change-Id: Ia67e0e7115dc69e55544c5de60b9a4ed6c17f60c
Mohd Faisal [Fri, 9 Dec 2022 15:52:28 +0000 (15:52 +0000)]
Remove OpImage*Dref* from mismatch type tests
Mismatch type group testing non-depth formats and using
OpImage*Dref* instructions with vulkan formats not having depth
component is invalid usage.
Extending the mismatch test type group to include depth/stencil
format later would require checking format features for
VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_DEPTH_COMPARISON_BIT
Components: Vulkan
Affects: dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.*
VK-GL-CTS issue: 4172
Change-Id: I2353e235295cff4609799e14298e6df7d6a66221
ziga-lunarg [Fri, 30 Dec 2022 16:04:22 +0000 (17:04 +0100)]
Fix layer count in barriers in shader_layer tests
Some barriers only transition the first layer of the image, instead of
all the layers used
Components: Vulkan
VK-GL-CTS issue: 4191
Affected tests:
dEQP-VK.draw.dynamic_rendering.*.shader_layer.*
Change-Id: I35d78b4575d450fbd7c3718ff2a639316f6113e4
ziga-lunarg [Fri, 30 Dec 2022 19:18:21 +0000 (20:18 +0100)]
Fix stencilAttachmentFormat in dynamic render clear tests
The format in VkPipelineRenderingCreateInfo::stencilAttachmentFormat
must have a stencil aspect or be VK_FORMAT_UNDEFINED
Components: Vulkan
VK-GL-CTS issue: 4192
Affected tests:
dEQP-VK.draw.dynamic_rendering.*.load_clear_draw*
Change-Id: Ib0f055dd5ce49f5a2dff797274d5a243c46e8619
ziga-lunarg [Mon, 2 Jan 2023 12:10:45 +0000 (13:10 +0100)]
Add missing flags in dynamic rendering with secondary cmd buffers tests
If vkCmdExecuteCommands is called within a dynamic render pass,
VkRenderingInfo::flags must include
VK_RENDERING_CONTENTS_SSECONDARY_COMMAND_BUFFERS_BIT
Components: Vulkan
VK-GL-CTS issue: 4194
Affected tests:
dEQP-VK.draw.dynamic_rendering.*.differing_interpolation.*
Change-Id: Ib8e3fa1e3144a6847a87dbf1542912c5c179e903
Iago Toral Quiroga [Mon, 9 Jan 2023 10:24:48 +0000 (11:24 +0100)]
Fix tests that enable depth testing on undefined depth buffer
There are tests in the load_store_op_none category set up like this:
Depth load: NONE
Depth store: NONE
Depth testing: ON
Depth op: GREATER
Depth write: OFF
This configuration is bogus because the depth buffer will be
undefined as this particular test won't initialize the render
area inside the render pass and it enabled depth testing
with a comparison function that depends on the contents of the
depth buffer.
Fix it by detecting this scenario and making the depth comparison
ALWAYS to ensure that depth testing doesn't drop any samples,
which is what the test expects.
Affects:
dEQP-VK.*.load_store_op_none.depth*
Components: Vulkan
VK-GL-CTS issue: 4209
Change-Id: Icab24dcf7f46156b7b59541ea64e5823deec53d1
Piotr Byszewski [Mon, 16 Jan 2023 08:24:19 +0000 (09:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I17cf242ff0a054151c0af294fdfb84646e743244
Amber [Tue, 3 Jan 2023 10:17:24 +0000 (11:17 +0100)]
Use tolerance for comparison in linear interpolation tests.
Components: Vulkan
VK-GL-CTS issue: 4159
Affected tests:
dEQP-VK.draw.*.linear_interpolation.*
Change-Id: I026bb0128dc78ddab75cbfdcaabab00a8d05386a
ziga-lunarg [Mon, 2 Jan 2023 17:28:59 +0000 (18:28 +0100)]
Fix memory offset in dedicated_allcation tests
When dedicated allocation is used, memory offset must be 0
Components: Vulkan
VK-GL-CTS issue: 4195
Affected tests:
dEQP-VK.api.copy_and_blit.dedicated_allocation.*
Change-Id: I3bee6c17e7de2ee8bae5f218df9d2e03dc37689d
Piotr Byszewski [Sun, 15 Jan 2023 16:59:05 +0000 (17:59 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I7cfcfe8c9e3549a509420cbe1b63d089b3ee00dc
Ricardo Garcia [Tue, 10 Jan 2023 11:01:08 +0000 (12:01 +0100)]
Fix color blend state in multisample mixed count tests
Some test variants were passing a null color blend attachment state on
pipeline creation, when the subpass was being created with one color
attachment.
Affects:
dEQP-VK.pipeline.*.multisample.mixed_count.*
VK-GL-CTS issue: 4208
Components: Vulkan
Change-Id: I9e0c7a5be907baef3c2b7bb6286d92eaa6749a66
Piotr Byszewski [Sun, 15 Jan 2023 10:43:24 +0000 (11:43 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I8ca4c0773084ff7b66bf7378ee9b610c693f15c6
Dae Kim [Fri, 16 Dec 2022 11:43:24 +0000 (11:43 +0000)]
Fix bind-transfer synchronization in sparse texture tests
The copyBufferToImage() utility function submits a command buffer with a
copy-buffer-to-image transfer operation. The caller can optionally pass
a semaphore for the transfer to wait on, but the semaphore's wait flags
are set to VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT, which does not include
transfer operations.
As a consequence of this, the transfer operation may ignore the wait
semaphore. In the affected test set this means that the transfer may
happen before sparse bind operations are completed.
Affects: dEQP-VK.texture.*sparse*
Components: Vulkan
VK-GL-CTS issue: 4183
Change-Id: Ia0f0c721e492703301440dbfcf07ed6495fddb1e
Piotr Byszewski [Fri, 13 Jan 2023 18:24:46 +0000 (19:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Icc5dc1c0cbfd798e6df0e7b88d4830e1549a4126
Piotr Byszewski [Fri, 13 Jan 2023 16:21:02 +0000 (17:21 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I2142832024febea1baee33b1df04af6921edb846
Piotr Byszewski [Fri, 13 Jan 2023 12:34:18 +0000 (13:34 +0100)]
Remove duplicated test groups
While adding support for dynamic rendering to renderpass group
a mistake was made that added 3 groups with the same tests to both
renderpass2 group and legacy renderpass group.
This mistake was fixed on 1.3.1 branch but is present on 1.2.8
and 1.3.0. There is no need to execute same tests twice - this
change removes duplicates. This fix should be propagated only to
1.3.0.
Components: Vulkan
VK-GL-CTS issue: 4225
Removed tests:
dEQP-VK.renderpass.depth_stencil_resolve.*
dEQP-VK.renderpass.fragment_density_map.*
dEQP-VK.renderpass2.multiple_subpasses_multiple_command_buffers.test
Change-Id: I571e499ead038acf1744c356b884f2be966e3c15
ziga-lunarg [Thu, 22 Dec 2022 12:52:24 +0000 (13:52 +0100)]
Fix oldLayout in image barriers in copy and blit tests
The same barriers are used twice, but the oldLayout is not updated
Components: Vulkan
VK-GL-CTS issue: 4054
Affected tests:
dEQP-VK.api.copy_and_blit.*
Change-Id: I8fd622846a2c9ce840ec6bfb5a431ae66a5af06f
Piotr Byszewski [Fri, 13 Jan 2023 10:11:20 +0000 (11:11 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I1139cfa0a1d27a08bd6d3c72b2d65fd754edc886
ziga-lunarg [Fri, 16 Dec 2022 16:31:54 +0000 (17:31 +0100)]
Remove invalid separate_layouts tests on older branches
These tests were fixed, but only on 1.3.2 newer, they should be removed
on older branches
Components: Vulkan
VK-GL-CTS issue: 3527
Removed tests:
dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.*
Change-Id: I467ea14cc5c2eb26723cc9e2453ea5a11a1556b9
Piotr Byszewski [Mon, 9 Jan 2023 08:17:58 +0000 (09:17 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: If8b58ba0befe6c8e2beb9a1867656da231a6cf87
Ricardo Garcia [Fri, 9 Dec 2022 11:57:38 +0000 (12:57 +0100)]
Require sampleRateShading in multisample linear interpolation tests
While these tests normally set sampleShadingEnable to VK_FALSE, their
shaders enable the SampleRateShading capability, which means
sampleRateShading is required to run them.
Affects:
dEQP-VK.draw.*.linear_interpolation.*
VK-GL-CTS issue: 4167
Components: Vulkan
Change-Id: I52f9f81b13186d2b152f46ecadbc73455ffbf063
Piotr Byszewski [Sat, 7 Jan 2023 15:03:55 +0000 (16:03 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I467e6a22adfe0bd549a37378b9eee8220859d0e0
Amber [Tue, 3 Jan 2023 13:58:15 +0000 (14:58 +0100)]
Make depth_bias_triangle_list_point write to PointSize
VK-GL-CTS Issue: 4197
Components: Vulkan
Affect tests:
dEQP-VK.draw.renderpass.depth_bias.depth_bias_triangle_list_point
Change-Id: I21c223ff1e986c48fc90f97d21d472cfa713abdf
Piotr Byszewski [Sat, 7 Jan 2023 13:27:45 +0000 (14:27 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I1ed2965c43158b0131f340237dbebfcf5b2aaf5f
Piotr Byszewski [Sat, 7 Jan 2023 12:15:11 +0000 (13:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ie8e4ee5b77cbea1aa87664a38a074f2381d2ea15
Piotr Byszewski [Sat, 7 Jan 2023 11:05:29 +0000 (12:05 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I7507fe1cee9b7bccdbfc4883f0ee6937c116b30a
Piotr Byszewski [Thu, 5 Jan 2023 18:12:20 +0000 (19:12 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Iea24c631e95fad0dbf694e67f141c243fda3a3d9
ziga-lunarg [Sat, 19 Nov 2022 22:46:51 +0000 (23:46 +0100)]
Fix 2d image views in fragment shading rate tests
If viewType is VK_IMAGE_VIEW_TYPE_2D then subresourceRange.layerCount
must be 1
Components: Vulkan
VK-GL-CTS issue: 4124
Affected tests:
dEQP-VK.fragment_shading_rate.*
Change-Id: I32db55ce0785a2d91c391625bfed312d5e7371f0
Sławomir Cygan [Fri, 16 Sep 2022 16:22:14 +0000 (18:22 +0200)]
Fix src stage value in pipeline barrier used to init resolve images
srcStage cannot be 0 it synchronization2 feature is not explicitely
required (enabled) by the test.
Components: Vulkan
VK-GL-CTS Issue: 3949
Change-Id: I66d3b5b55ca3732ede7284a010a68841c0a04275
Affects: dEQP-VK.pipeline.*.multisample.misc.dynamic_rendering.*
Slawomir Cygan [Tue, 22 Nov 2022 16:50:16 +0000 (17:50 +0100)]
Allow 0 creation duration for pipeline libraries without shaders
Affects: dEQP-VK.pipeline.pipeline_library.creation_feedback.graphics_tests.*
VK-GL-CTS Issue: 4130
Components: Vulkan
Change-Id: Iebdeb76d30d4144ccba83c7d3ad4de7f269552c8
Piotr Byszewski [Sun, 18 Dec 2022 16:24:48 +0000 (17:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I473fdbb6258063ddc4b07598519f9212cf4850ef
Piotr Byszewski [Fri, 16 Dec 2022 16:02:14 +0000 (17:02 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I5b755219964c807f381973f14ad15f7806eb44ab
Slawomir Cygan [Mon, 14 Nov 2022 16:28:10 +0000 (17:28 +0100)]
Add randomized constants to shaders in compare_link_times test
Add some randomization to shaders in compare_link_times test
to get reproductible compilation times.
VK-GL-CTS Issue: 4109
Components: Vulkan
Affects:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.timing.compare_link_times
Change-Id: Idbd38d611edc955916b2c756115702cccd16a7d8
ziga-lunarg [Sat, 10 Dec 2022 22:09:31 +0000 (23:09 +0100)]
Fix invalid framebuffer in compressed texture 3D tests
Framebuffer attachments must be created with viewType not equal to
VK_IMAGE_VIEW_TYPE_3D
Components: Vulkan
VK-GL-CTS issue: 4118
Affected tests:
dEQP-VK.texture.compressed_3D.*
Change-Id: I221fcc033266f8c344079f9ee9b1fa70c56d9dd9
ziga-lunarg [Mon, 5 Dec 2022 14:12:06 +0000 (15:12 +0100)]
Fix stencil op in depth bounds tests
If stencil attachment is in a read only layout and stencil test is
enabled, the stencil ops in VkPipelineDepthStencilStateCreateInfo must
be VK_STENCIL_OP_KEEP
Components: Vulkan
VK-GL-CTS issue: 4155
Affected tests:
dEQP-VK.dynamic_state.*.ds_state.depth_bounds_2*
Change-Id: Ifeb2ddca71e5cbd60afebd8d8b6dd77b5e7f2e9b
Friedrich Vock [Mon, 5 Dec 2022 08:13:06 +0000 (09:13 +0100)]
Fix result image format in RT pipeline flags test
Tests were using an rgba32i format (VK_FORMAT_R32G32B32A32_SINT) but
declaring it in the shader as r32i.
Affects:
dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*
Components: Vulkan
VK-GL-CTS issue: 4151
VK-GL-CTS public issue: 365
Change-Id: Ia9dbd97544fce8a29a4fe7270fc617981648032f
Charlie Turner [Wed, 23 Nov 2022 21:35:05 +0000 (21:35 +0000)]
Adds missing multisample state structs.
When compiling a fragment shader pipeline library, the fragment shader
state is defined by, among other state, the
VkPipelineMultisampleStateCreateInfo if sample shading is enabled.
In the affected tests, a fragment shader module was being compiled
which accessed builtins decorated with SampleId. This in turn enabled
sample shading, and in such cases, the
VkPipelineMultisampleStateCreateInfo is potentially required by
drivers for their internal logic. For this reason the spec mandates
the struct's inclusion in the fragment shader state when sample
shading is enabled.
Unfortunately it's not simple to change the GraphicsPipelineWrapper to
avoid this erroneous configuration, since in general it would require
parsing the SPIR-V to check if the fragment shader is accessing any
input builtins with the problematic decorations.
Instead a validation run was done over
dEQP-VK.pipeline.pipeline_library.* to ensure there aren't other
callsites falling into this trap, and no other cases were found.
Components: Vulkan
Affects:
dEQP-VK.pipeline.pipeline_library.multisample.*
VK-GL-CTS issue: 3975
Change-Id: I33a6b391af800eb6c23d846b70a4aac2387a74e3
Piotr Byszewski [Fri, 16 Dec 2022 14:13:57 +0000 (15:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I2d8979c34c4b9a18509e5c00ba123fa2a7520451
Andrew Fobel [Mon, 5 Dec 2022 21:16:01 +0000 (16:16 -0500)]
Fix VK_KHR_global_priority tests
Use enabledExtensions to properly enable VK_EXT_global_priority_query
along with passing the globalPriorityQueryFeatures struct.
Components: Vulkan
VK-GL-CTS issue: 4157
Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*
Change-Id: Ib024f187f835914bbcb94e42a40d60a32fed0f99
Piers Daniell [Mon, 5 Dec 2022 22:01:43 +0000 (15:01 -0700)]
Work around deArraySizeHelper deficiency with multi-dimension arrays
This fixes a compilation issue with some compilers with deArraySizeHelper
and implicitly sized multi-dimensional arrays.
Affects:
Compilation only.
Components: Framework, Vulkan
VK-GL-CTS issue: 4158
Change-Id: Ie200647f34096b54544aff7f8d82b1eefabbd586
Piotr Byszewski [Fri, 16 Dec 2022 12:35:27 +0000 (13:35 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Id3cf5e258bce8b7aec13bc44abdada774159136b
Piotr Byszewski [Fri, 16 Dec 2022 11:15:18 +0000 (12:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ifdc6f7c08ccb5f65d44e406a7dc6ea6866102ad5
Piotr Byszewski [Fri, 16 Dec 2022 08:42:48 +0000 (09:42 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ib14adccc08aa0dd8767e6dea0199e021885d292d
ziga-lunarg [Sat, 19 Nov 2022 13:02:59 +0000 (14:02 +0100)]
Fix errors in sparse resources tests
VK_EXT_shader_image_atomic_int64 extension must be enabled on the device
if used
Feature structs from non-enabled extensions must not be passed to
VkDeviceCreateInfo pNext
Checks if image formats are supported are missing
Components: Vulkan
VK-GL-CTS issue: 4122
Affected tests:
dEQP-VK.sparse_resources.shader_intrinsics.*
Change-Id: I4fcac8eae1d53826d5ef5f8a7dcc04bfe95f7360
ziga-lunarg [Fri, 18 Nov 2022 18:49:35 +0000 (19:49 +0100)]
Fix subpass dependency dstStageMask in shader_fragment_mask tests
Stage VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUT_BIT must be included if
access mask is VK_ACCESS_COLOR_ATTACHMENT_READ_BIT
Components: Vulkan
VK-GL-CTS issue: 4120
Affected tests:
dEQP-VK.pipeline.*.shader_fragment_mask.*
Change-Id: Iea2a62ff5781c50ad39d707a8eb0f1f4ce344f48
Yun Shu [Mon, 5 Dec 2022 08:20:43 +0000 (16:20 +0800)]
Set correct pipeline barrier between clear image and trace ray
The image is cleared with fixed value, then used as write destination
in ray tracing shaders. The pipeline barrier set for the image is
incorrect between clear command and trace ray command.
Affects:
dEQP-VK.ray_tracing_pipeline.large_shader_set.*
Components: Vulkan
VK-GL-CTS issue: 4137
Change-Id: I41dd55d51ea995c4c878e053f6d617b2e38ba5b1
Amber [Mon, 21 Nov 2022 10:54:07 +0000 (11:54 +0100)]
Add check for the return value of vkGetPhysicalDeviceImageFormatProperties2
Also do not attempt to create images for depth/stencil usage using color formats.
Components: Vulkan
VK-GL-CTS issue: 4125
Affected tests:
dEQP-VK.api.external.memory.dma_buf.suballocated.image.info
Change-Id: If1f41b967d03f1b862c85277d6fe30b20ab1a110
Slawomir Cygan [Tue, 22 Nov 2022 16:37:51 +0000 (17:37 +0100)]
Remove clearing of pipeline creation feedbacks while veryfying them
This re-enables verification of pipeline creation feedbacks by not
zeroing them out just before verification.
VK-GL-CTS Issue: 4129
Affects: dEQP-VK.pipeline.pipeline_library.creation_feedback.graphics_tests.*
Components: Vulkan
Change-Id: I37010973db235f993b85e9ac3c2645ae5b2db79e
Matthew Netsch [Thu, 8 Dec 2022 21:12:41 +0000 (21:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: Ieafa2f3085c673bd861f1e4ddff26897a16b43d9
Matthew Netsch [Thu, 8 Dec 2022 20:28:58 +0000 (20:28 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ie018c65908482fac3de9a6030d79029e2429d734
Hyunjun Ko [Tue, 29 Nov 2022 05:09:41 +0000 (14:09 +0900)]
Fix to get supported depth format instead of using VK_FORMAT_D32_SFLOAT
always.
Affets:
dEQP-VK.pipeline.pipeline_library.graphics_library.*
VK-GL-CTS Issue: 4142
Components: Vulkan
Change-Id: Ia8cb48061acd4813aecabb050c775a27ce1b4926
Matthew Netsch [Thu, 8 Dec 2022 19:57:31 +0000 (19:57 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I193ea9253a0d2d405e25d951ba1564f5ad805f3b
Matthew Netsch [Thu, 8 Dec 2022 18:58:13 +0000 (18:58 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Icc350abe29e7c1545a65d99884a281cd63239fc4
Matthew Netsch [Thu, 8 Dec 2022 18:30:33 +0000 (18:30 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ibfc5624676bae49d9630978494cdfdc660a0fba4
Matthew Netsch [Thu, 8 Dec 2022 18:01:39 +0000 (18:01 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: If5512ea90e2442bc7304502d78cc3b1333f53479
ziga-lunarg [Sun, 4 Dec 2022 20:48:26 +0000 (21:48 +0100)]
Write gl_PointSize in depth tests
Some depth tests use VK_PRIMITIVE_TOPOLOGY_POINT_LIST but the shaders
don't write the point size
Components: Vulkan
VK-GL-CTS issue: 4153
Affected tests:
dEQP-VK.pipeline.*.depth.*
Change-Id: Idaa9ea65f7c43ca02d7780d1825d4558b712a133
ziga-lunarg [Mon, 5 Dec 2022 15:34:50 +0000 (16:34 +0100)]
Add check if format is supported in external memory host tests
Format properties for format used for color attachment must contain
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT
Components: Vulkan
VK-GL-CTS issue: 4156
Affected tests:
dEQP-VK.memory.external_memory_host.bind_image_memory_and_render.*
Change-Id: Ib0346cbc849b94a5af67e5645cc057ca392f9b2f
ziga-lunarg [Fri, 18 Nov 2022 18:11:56 +0000 (19:11 +0100)]
Fix invalid framebuffer in compressed texture 3D tests
Framebuffer attachments must be created with viewType not equal to
VK_IMAGE_VIEW_TYPE_3D
Components: Vulkan
VK-GL-CTS issue: 4118
Affected tests:
dEQP-VK.texture.compressed_3D.*
Change-Id: I9ae036d02daa3579567bf514c70bf623a0bc9aa9
ziga-lunarg [Sat, 19 Nov 2022 19:06:44 +0000 (20:06 +0100)]
Fix flushing memory range in memory model shared tests
Each size of pMemRanges in vkFlushMappedMemoryRanges must be either a
multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or equal to the
size of memory
Components: Vulkan
VK-GL-CTS issue: 4123
Affected tests:
dEQP-VK.memory_model.shared.*
Change-Id: I0f3ea96736aa73eb92c7809c04297923d84e348c
ziga-lunarg [Sun, 13 Nov 2022 15:41:10 +0000 (16:41 +0100)]
Fix errors in dynamic rendering suballocation tests
attachmentCount in vkCmdClearAttachments must be greater than 0
depth aspect must only be cleared if depth attachment is set
stencil aspect must only be clear if stencil attachment is set
Components: Vulkan
VK-GL-CTS issue: 4102
Affected tests:
dEQP-VK.dynamic_rendering.*.suballocation.*
Change-Id: Id7cc51794883863aa9add62adee55ef30c0f6a28
Marc Alcala Prieto [Fri, 18 Nov 2022 15:24:34 +0000 (16:24 +0100)]
Fixes for VK_EXT_image_compression_control swapchain tests
Ensure VK_KHR_get_surface_capabilities2 is requested when creating
Vulkan instances for the swapchain tests. This is required by
functions:
- vkGetPhysicalDeviceSurfaceCapabilities2KHR
- vkGetPhysicalDeviceSurfaceFormats2KHR
Enable imageCompressionControlSwapchain when creating devices for the
swapchain tests.
Properly set compressionControlPlaneCount depending on compression
flags.
Components: Vulkan
VK-GL-CTS issue: 4105
Affects:
dEQP-VK.api.image_compression_control.swapchain.*
Change-Id: I6b1ac25724ac605b91824e784a018f3e4fd717b7
Matthew Netsch [Thu, 1 Dec 2022 22:00:51 +0000 (22:00 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I4d3f1c8018aa246031409d52a6aa6716a95a67c7
Marc Alcala Prieto [Fri, 18 Nov 2022 15:10:41 +0000 (16:10 +0100)]
Fixes for VK_EXT_image_compression_control tests
Fix the validation logic to check planes depending on format, not
compressionControlPlaneCount.
Properly set compressionControlPlaneCount and
pFixedRateFlags depending on compression flags.
Components: Vulkan
VK-GL-CTS issue: 4105
Affects:
dEQP-VK.api.image_compression_control.*
Change-Id: I492febb4163867ee722cd49e75cc8646aa8376f5
Matthew Netsch [Thu, 1 Dec 2022 20:14:56 +0000 (20:14 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ibbddec7b6ff3801fef7d359eb08935808a7cfe65
Slawomir Cygan [Thu, 10 Nov 2022 16:12:05 +0000 (17:12 +0100)]
Use pipeline layout alongside with fragment shader stage
In pipeline libraries, pipeline layout is requried if fragment
shader is present in the pipeline.
Affects: dEQP-VK.pipeline.pipeline_library.graphics_library.misc.bind_null_descriptor_set.*
VK-GL-CTS Issue: 4096
Components: Vulkan
Change-Id: Ia70b0f18f497e2e9102e7748c87ea5e5092098bc