Jim Meyering [Thu, 20 May 2004 11:37:11 +0000 (11:37 +0000)]
*** empty log message ***
Jim Meyering [Thu, 20 May 2004 11:37:07 +0000 (11:37 +0000)]
(sc_unmarked_diagnostics): Now that the unmarked
diagnostics in shred.c have been fixed, don't exempt shred.c from
this check.
Jim Meyering [Thu, 20 May 2004 11:35:47 +0000 (11:35 +0000)]
*** empty log message ***
Jim Meyering [Thu, 20 May 2004 11:35:40 +0000 (11:35 +0000)]
Use translatable diagnostics, e.g.
change "%s: remove" to _("%s: failed to remove") and
change "%s: close" to _("%s: failed to close").
Jim Meyering [Thu, 20 May 2004 06:49:55 +0000 (06:49 +0000)]
*** empty log message ***
Jim Meyering [Thu, 20 May 2004 06:49:52 +0000 (06:49 +0000)]
Update from gnulib.
Jim Meyering [Tue, 18 May 2004 15:28:38 +0000 (15:28 +0000)]
*** empty log message ***
Jim Meyering [Tue, 18 May 2004 15:28:27 +0000 (15:28 +0000)]
(names): Bring back lower-case letters, "_", and
".". But continue to omit +, =, %, @, #, as they're either
shell metacharacters (for some shells) or are not in some
character sets, or (in the case of '%') must be a
metacharacter somewhere.
Jim Meyering [Mon, 17 May 2004 13:39:06 +0000 (13:39 +0000)]
*** empty log message ***
Jim Meyering [Mon, 17 May 2004 13:21:40 +0000 (13:21 +0000)]
.
Jim Meyering [Mon, 17 May 2004 13:20:25 +0000 (13:20 +0000)]
Sync with gnulib.
Jim Meyering [Mon, 17 May 2004 13:18:34 +0000 (13:18 +0000)]
Sync with gnulib.
Jim Meyering [Mon, 17 May 2004 13:17:45 +0000 (13:17 +0000)]
Sync with gnulib.
Jim Meyering [Mon, 17 May 2004 13:16:53 +0000 (13:16 +0000)]
(cut_fields): Adjust to new signature of getndelim2.
Jim Meyering [Mon, 17 May 2004 12:34:36 +0000 (12:34 +0000)]
(incname): Decrement `len' only once per loop iteration.
Jim Meyering [Mon, 17 May 2004 12:29:37 +0000 (12:29 +0000)]
*** empty log message ***
Jim Meyering [Mon, 17 May 2004 12:16:16 +0000 (12:16 +0000)]
*** empty log message ***
Jim Meyering [Mon, 17 May 2004 12:15:45 +0000 (12:15 +0000)]
*** empty log message ***
Jim Meyering [Mon, 17 May 2004 12:11:54 +0000 (12:11 +0000)]
.
Jim Meyering [Mon, 17 May 2004 12:11:19 +0000 (12:11 +0000)]
.
Jim Meyering [Mon, 17 May 2004 12:10:55 +0000 (12:10 +0000)]
*** empty log message ***
Jim Meyering [Mon, 17 May 2004 12:10:43 +0000 (12:10 +0000)]
Use -h where necessary to retain semantics.
Jim Meyering [Mon, 17 May 2004 12:08:24 +0000 (12:08 +0000)]
*** empty log message ***
Jim Meyering [Mon, 17 May 2004 12:08:09 +0000 (12:08 +0000)]
chgrp and chown now dereference symlinks by default, per POSIX.
(usage): Update to reflect this.
Jim Meyering [Mon, 17 May 2004 12:07:48 +0000 (12:07 +0000)]
(chopt_init): Affect each symlink referent by default.
Jim Meyering [Mon, 17 May 2004 12:07:30 +0000 (12:07 +0000)]
*** empty log message ***
Jim Meyering [Mon, 17 May 2004 12:07:25 +0000 (12:07 +0000)]
chgrp and chown now dereference symlinks by default, per POSIX.
(chgrp invocation, chown invocation): Document it.
Jim Meyering [Sun, 16 May 2004 21:39:35 +0000 (21:39 +0000)]
chown --dereference did nothing when the owner/group of a
symlink matched the desired owner/group. Reported by David Malone.
Also reported in 1999 as http://bugs.debian.org/39642.
(change_file_owner): When --dereference has
been specified, and when processing a symlink, stat it to get the
owner and group of the referent.
Jim Meyering [Sun, 16 May 2004 19:32:37 +0000 (19:32 +0000)]
*** empty log message ***
Jim Meyering [Sun, 16 May 2004 19:32:30 +0000 (19:32 +0000)]
In shred, check for errors from fdatasync more carefully. If
fdatasync fails with errno==EINVAL, it means this implementation
does not support synchronized I/O for this file. Do not report
this as an error, as (for example) AIX 5.2 fdatasync reports it
for raw disk devices. Problem reported by Albert Chin in
<http://mail.gnu.org/archive/html/bug-gnu-utils/2004-05/msg00028.html>.
Check for write errors, though: the old code ignored them.
Improve error checking in a few other cases, too (e.g., close of a
directory).
Also, change several 'int' values to 'bool', so that the error
checking is a bit clearer. Similarly, change unsigned values
to size_t where appropriate.
* src/shred.c: Include "dirname.h".
(datasync) [!HAVE_FDATASYNC]: Remove.
(dosync): New function.
(dopass): Use it. Return 1 on write error, -1 on other error.
All callers changed. Report write error if dosync does.
(do_wipefd, wipefd, wipename, wipefile): Return bool (true/false),
not int (0/-1). All callers changed. Return false if there's a
write error.
(incname): Return bool (true/false), not int (0/1). Accept
size_t length, not unsigned. All callers changed. Do not
bother checking for non-digits; it can't happen. Replace
recursion with iteration.
(wipename): Use dir_name, base_name, etc. instead of assuming
Unix file names. Use size_t for length, not unsigned.
Report error if unlink or close fails.
(wipename, main): Use bool for booleans.
(names): Use only digits and uppercase letters, for greater
portability.
Jim Meyering [Sun, 16 May 2004 14:18:50 +0000 (14:18 +0000)]
*** empty log message ***
Jim Meyering [Sun, 16 May 2004 14:17:53 +0000 (14:17 +0000)]
*** empty log message ***
Jim Meyering [Sun, 16 May 2004 14:10:17 +0000 (14:10 +0000)]
(TESTS): Add deref.
Jim Meyering [Sun, 16 May 2004 14:10:10 +0000 (14:10 +0000)]
New test for the yesterday's change.
Jim Meyering [Sat, 15 May 2004 18:27:38 +0000 (18:27 +0000)]
*** empty log message ***
Jim Meyering [Sat, 15 May 2004 14:59:15 +0000 (14:59 +0000)]
.
Jim Meyering [Fri, 14 May 2004 15:47:53 +0000 (15:47 +0000)]
(AD_pop_and_chdir): Eliminate an unnecessary call to AC_stack_top.
Jim Meyering [Fri, 14 May 2004 09:16:23 +0000 (09:16 +0000)]
.
Jim Meyering [Fri, 14 May 2004 07:34:16 +0000 (07:34 +0000)]
*** empty log message ***
Jim Meyering [Fri, 14 May 2004 07:34:09 +0000 (07:34 +0000)]
Improve performance of `sort -m' on large files, at the cost of
making some contrived examples unsafe. POSIX allows this
optimization. Performance problem reported by Jonathan Baker in
<http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00071.html>.
(first_same_file): Do not treat input pipes
differently from other files.
Jim Meyering [Fri, 14 May 2004 07:33:48 +0000 (07:33 +0000)]
Document that "sort -m -o F" might write F before reading all the input.
Jim Meyering [Fri, 14 May 2004 07:33:23 +0000 (07:33 +0000)]
*** empty log message ***
Jim Meyering [Fri, 14 May 2004 07:32:56 +0000 (07:32 +0000)]
(sort invocation): Document that "sort -m -o F"
might write F before reading all the input.
Jim Meyering [Fri, 14 May 2004 07:29:41 +0000 (07:29 +0000)]
*** empty log message ***
Jim Meyering [Fri, 14 May 2004 07:29:04 +0000 (07:29 +0000)]
*** empty log message ***
Jim Meyering [Fri, 14 May 2004 07:28:39 +0000 (07:28 +0000)]
Fix typo: s/supercede/supersede/.
Jim Meyering [Thu, 13 May 2004 07:27:25 +0000 (07:27 +0000)]
*** empty log message ***
Jim Meyering [Thu, 13 May 2004 07:27:10 +0000 (07:27 +0000)]
(unquote, make_printable_str): Use e.g. '\a' rather than '\007',
for portability to EBCDIC hosts.
Jim Meyering [Thu, 13 May 2004 07:26:46 +0000 (07:26 +0000)]
(print_esc_char): Use e.g. '\a' rather than '\007',
for portability to EBCDIC hosts.
Jim Meyering [Thu, 13 May 2004 07:26:14 +0000 (07:26 +0000)]
(print_ascii, dump_strings): Use e.g. '\a' rather than
'\007', for portability to EBCDIC hosts.
Jim Meyering [Thu, 13 May 2004 07:05:05 +0000 (07:05 +0000)]
*** empty log message ***
Jim Meyering [Thu, 13 May 2004 07:04:58 +0000 (07:04 +0000)]
Don't assume that "make -C" works; Solaris "make" doesn't have -C.
* src/Makefile.am (all_programs.list): New rule, copied from
man/Makefile.am and tests/Makefile.am, except that we use the
system tr rather than ./tr and we don't use tr -s.
* tests/Makefile.am (all_programs): Use it.
* man/Makefile.am (all_programs): Likewise. Renamed from programs,
for consistency. All uses changed.
Jim Meyering [Thu, 13 May 2004 07:03:52 +0000 (07:03 +0000)]
Don't assume that "make -C" works; Solaris "make" doesn't have -C.
* src/Makefile.am (all_programs.list): New rule, copied from
man/Makefile.am and tests/Makefile.am, except that we use the
system tr rather than ./tr and we don't use tr -s.
* tests/Makefile.am (all_programs): Use it.
Jim Meyering [Thu, 13 May 2004 07:03:00 +0000 (07:03 +0000)]
Don't assume that "make -C" works; Solaris "make" doesn't have -C.
(all_programs.list): New rule, copied from
man/Makefile.am and tests/Makefile.am, except that we use the
system tr rather than ./tr and we don't use tr -s.
Jim Meyering [Wed, 12 May 2004 09:35:19 +0000 (09:35 +0000)]
*** empty log message ***
Jim Meyering [Wed, 12 May 2004 09:35:06 +0000 (09:35 +0000)]
(AD_pop_and_chdir): Move lstat-`.' into if-block
where the result is used. This avoids one unnecessary lstat call
per command line argument.
Jim Meyering [Tue, 11 May 2004 19:41:37 +0000 (19:41 +0000)]
*** empty log message ***
Jim Meyering [Tue, 11 May 2004 19:41:33 +0000 (19:41 +0000)]
(TESTS): Add unread3.
Jim Meyering [Tue, 11 May 2004 19:41:23 +0000 (19:41 +0000)]
New test, for the above fix and today's lib/save-cwd.c improvement.
Jim Meyering [Tue, 11 May 2004 18:34:56 +0000 (18:34 +0000)]
*** empty log message ***
Jim Meyering [Tue, 11 May 2004 18:34:38 +0000 (18:34 +0000)]
(save_cwd): If opening `.' read-only fails, try write-only.
Jim Meyering [Tue, 11 May 2004 18:25:32 +0000 (18:25 +0000)]
*** empty log message ***
Jim Meyering [Tue, 11 May 2004 16:50:25 +0000 (16:50 +0000)]
*** empty log message ***
Jim Meyering [Tue, 11 May 2004 16:48:42 +0000 (16:48 +0000)]
*** empty log message ***
Jim Meyering [Tue, 11 May 2004 16:42:17 +0000 (16:42 +0000)]
(save_cwd) [HAVE_FCHDIR]: Don't fail just
because opening `.' failed. Resort to using xgetcwd.
Jim Meyering [Tue, 11 May 2004 16:14:22 +0000 (16:14 +0000)]
*** empty log message ***
Jim Meyering [Tue, 11 May 2004 16:14:11 +0000 (16:14 +0000)]
Don't include "save-cwd.h". It's no longer used.
Jim Meyering [Mon, 10 May 2004 18:15:41 +0000 (18:15 +0000)]
.
Jim Meyering [Mon, 10 May 2004 15:13:52 +0000 (15:13 +0000)]
*** empty log message ***
Jim Meyering [Mon, 10 May 2004 15:13:45 +0000 (15:13 +0000)]
(TESTS): Add trap.
Jim Meyering [Mon, 10 May 2004 15:13:29 +0000 (15:13 +0000)]
New file. Test for bug fix of 2004-04-18.
Jim Meyering [Mon, 10 May 2004 14:27:53 +0000 (14:27 +0000)]
*** empty log message ***
Jim Meyering [Mon, 10 May 2004 14:27:45 +0000 (14:27 +0000)]
(AD_push): Don't use errno in diagnostic about `changed dev/ino'.
Jim Meyering [Mon, 10 May 2004 07:15:56 +0000 (07:15 +0000)]
*** empty log message ***
Jim Meyering [Mon, 10 May 2004 07:15:03 +0000 (07:15 +0000)]
Remove this generated file from CVS.
Jim Meyering [Mon, 10 May 2004 07:04:59 +0000 (07:04 +0000)]
.
Jim Meyering [Sun, 9 May 2004 19:44:10 +0000 (19:44 +0000)]
.
Jim Meyering [Sun, 9 May 2004 19:43:35 +0000 (19:43 +0000)]
.
Jim Meyering [Sun, 9 May 2004 19:43:27 +0000 (19:43 +0000)]
*** empty log message ***
Jim Meyering [Sun, 9 May 2004 19:43:23 +0000 (19:43 +0000)]
(check-texinfo): grep -w IO
Jim Meyering [Sun, 9 May 2004 19:42:23 +0000 (19:42 +0000)]
*** empty log message ***
Jim Meyering [Sun, 9 May 2004 19:42:19 +0000 (19:42 +0000)]
(stat invocation): Change IO to I/O.
Jim Meyering [Sun, 9 May 2004 19:29:54 +0000 (19:29 +0000)]
*** empty log message ***
Jim Meyering [Sun, 9 May 2004 19:29:42 +0000 (19:29 +0000)]
(unquote): Use xcalloc rather than xmalloc and
a loop initializing the just-allocated memory to zero.
Jim Meyering [Sat, 8 May 2004 22:24:25 +0000 (22:24 +0000)]
*** empty log message ***
Jim Meyering [Sat, 8 May 2004 12:49:57 +0000 (12:49 +0000)]
*** empty log message ***
Jim Meyering [Sat, 8 May 2004 12:49:53 +0000 (12:49 +0000)]
(TESTS): Add no-give-up.
Jim Meyering [Sat, 8 May 2004 12:49:22 +0000 (12:49 +0000)]
Fix bug where "rm" gave up too easily, reported by Dan Jacobsen in
<http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00013.html>.
(remove_entry): Check for errno values like ENOENT
that show the file cannot be directory, instead of for errno
values like EPERM that show the file might be a directory. This
is necessary because, when a single unlink() call has multiple
reasons to fail, it can set errno to any of those reasons; it's
only the rare errno value like ENOENT that excludes all the other
possible reasons to fail even when the file is a directory.
(remove_cwd_entries): Don't attempt chdir if the file is known
to not be a directory.
(remove_dir): Use the same method that remove_cwd_entries uses
(for some reason they differed). Don't assert that saved_errno
must be EPERM; it might be just about anything.
Jim Meyering [Sat, 8 May 2004 12:47:23 +0000 (12:47 +0000)]
New file; check for the above fix.
Jim Meyering [Fri, 7 May 2004 06:48:31 +0000 (06:48 +0000)]
Update from gnulib.
(obstack_finish): Rename local: s/value/__value/.
Jim Meyering [Fri, 7 May 2004 06:48:12 +0000 (06:48 +0000)]
Update from gnulib.
(_): Define only if not already defined.
Jim Meyering [Thu, 6 May 2004 15:35:13 +0000 (15:35 +0000)]
*** empty log message ***
Jim Meyering [Thu, 6 May 2004 14:51:20 +0000 (14:51 +0000)]
(main): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:50:17 +0000 (14:50 +0000)]
(main): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:49:32 +0000 (14:49 +0000)]
(list_entries_users): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:48:07 +0000 (14:48 +0000)]
(do_wipefd): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:46:00 +0000 (14:46 +0000)]
(xgetgroups): Use variable name, rather than type name in computing buffer
size for xnmalloc.
Jim Meyering [Thu, 6 May 2004 14:43:31 +0000 (14:43 +0000)]
(xgetgroups): Use xnmalloc, rather than xmalloc.
Don't add `1' to the buffer size (it was to protect against malloc
implementations that fail to allocate a buffer of size zero).
That is no longer necessary, since we use a malloc wrapper
on such systems.
Jim Meyering [Thu, 6 May 2004 14:24:50 +0000 (14:24 +0000)]
(main): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:24:16 +0000 (14:24 +0000)]
(elide_tail_bytes_pipe): Use xnmalloc, rather than xmalloc.