platform/upstream/ninja.git
11 years agorearrange handling of builtin bindings to make rules simpler
Evan Martin [Sat, 27 Oct 2012 20:09:40 +0000 (13:09 -0700)]
rearrange handling of builtin bindings to make rules simpler

Now, a 'build' block can override any special binding like 'command'
or 'description' if it needs to.

11 years agowrap some overlong lines
Evan Martin [Sat, 29 Dec 2012 20:02:16 +0000 (12:02 -0800)]
wrap some overlong lines

11 years agofix all "class" -> "struct"
Evan Martin [Sat, 29 Dec 2012 19:57:14 +0000 (11:57 -0800)]
fix all "class" -> "struct"

11 years agoadd a TODO from a pull request
Evan Martin [Sat, 29 Dec 2012 20:33:02 +0000 (12:33 -0800)]
add a TODO from a pull request

11 years agoMerge pull request #455 from azuk/master
Evan Martin [Sat, 29 Dec 2012 20:32:17 +0000 (12:32 -0800)]
Merge pull request #455 from azuk/master

Make a native Windows build possible when using Cygwin Python.

11 years agoMerge pull request #467 from ppuryear/browse-error
Evan Martin [Sat, 29 Dec 2012 20:27:00 +0000 (12:27 -0800)]
Merge pull request #467 from ppuryear/browse-error

browse: Read ninja's error text from stderr.

11 years agoninja_syntax.py: don't add trailing space when build has no inputs
Evan Martin [Sat, 29 Dec 2012 08:39:38 +0000 (00:39 -0800)]
ninja_syntax.py: don't add trailing space when build has no inputs

Seen in Ninja's configure.py where it creates an "rpmbuild" command.

11 years agofix test build under clang/system gtest
Evan Martin [Sat, 29 Dec 2012 08:35:53 +0000 (00:35 -0800)]
fix test build under clang/system gtest

Tests always need GTEST_HAS_RTTI=0 set, but the code was only
setting it in the --with-gtest branch.  Instead always use the
test-specific cflags when compiling test code.

11 years agowrap test in anon namespace
Evan Martin [Fri, 28 Dec 2012 21:47:59 +0000 (13:47 -0800)]
wrap test in anon namespace

11 years agocorrectly open /dev/null in subprocesses
Evan Martin [Fri, 21 Dec 2012 01:49:55 +0000 (17:49 -0800)]
correctly open /dev/null in subprocesses

Fixes issue #468.

11 years agoupdate a comment
Evan Martin [Tue, 27 Nov 2012 16:30:45 +0000 (08:30 -0800)]
update a comment

11 years agoMerge pull request #474 from yannicklm/master
Evan Martin [Fri, 21 Dec 2012 01:48:25 +0000 (17:48 -0800)]
Merge pull request #474 from yannicklm/master

  NINJA_STATUS: add support of `%p` for percentage

11 years agoMerge pull request #475 from nico/vim
Evan Martin [Fri, 21 Dec 2012 01:47:49 +0000 (17:47 -0800)]
Merge pull request #475 from nico/vim

Update version number in ninja.vim after recent changes.

11 years agoUpdate version number in ninja.vim after recent changes.
Nico Weber [Sat, 15 Dec 2012 05:18:31 +0000 (21:18 -0800)]
Update version number in ninja.vim after recent changes.

11 years agoNINJA_STATUS: add support of `%p` for percentage
yannicklm [Fri, 14 Dec 2012 21:25:51 +0000 (22:25 +0100)]
NINJA_STATUS: add support of `%p` for percentage

11 years agoMerge pull request #471 from riannucci/fix_vim_syntax
Evan Martin [Fri, 14 Dec 2012 19:06:03 +0000 (11:06 -0800)]
Merge pull request #471 from riannucci/fix_vim_syntax

Fix vim syntax

11 years agoMerge pull request #472 from riannucci/add_python_pool_syntax
Evan Martin [Fri, 14 Dec 2012 19:05:44 +0000 (11:05 -0800)]
Merge pull request #472 from riannucci/add_python_pool_syntax

Add python ninja_syntax.py support for pool

11 years agoMerge pull request #473 from riannucci/fix_emacs
Evan Martin [Fri, 14 Dec 2012 19:05:23 +0000 (11:05 -0800)]
Merge pull request #473 from riannucci/fix_emacs

Fix emacs ninja-mode

11 years agoAdd missing default keyword
Robert Iannucci [Fri, 14 Dec 2012 07:21:02 +0000 (23:21 -0800)]
Add missing default keyword

11 years agoAdd pool
Robert Iannucci [Fri, 14 Dec 2012 07:20:50 +0000 (23:20 -0800)]
Add pool

11 years agoAdd missing rspfile and rspfile_content
Robert Iannucci [Fri, 14 Dec 2012 07:11:12 +0000 (23:11 -0800)]
Add missing rspfile and rspfile_content

11 years agoAdd ninja.vim syntax for pool
Robert Iannucci [Fri, 14 Dec 2012 07:10:52 +0000 (23:10 -0800)]
Add ninja.vim syntax for pool

11 years agoAdd python ninja_syntax.py support for pool
Robert Iannucci [Fri, 14 Dec 2012 07:11:37 +0000 (23:11 -0800)]
Add python ninja_syntax.py support for pool

11 years agoMerge pull request #461 from riannucci/global_section
Evan Martin [Thu, 13 Dec 2012 19:55:35 +0000 (11:55 -0800)]
Merge pull request #461 from riannucci/global_section

Resource pools for ninja

11 years agobrowse: Read ninja's error text from stderr.
Philip Puryear [Sat, 8 Dec 2012 00:22:19 +0000 (18:22 -0600)]
browse: Read ninja's error text from stderr.

11 years agoRemove unnecessary parameter from ShouldDelayEdge
Robert Iannucci [Fri, 30 Nov 2012 01:53:30 +0000 (17:53 -0800)]
Remove unnecessary parameter from ShouldDelayEdge

11 years agoRename isValid
Robert Iannucci [Fri, 30 Nov 2012 01:51:30 +0000 (17:51 -0800)]
Rename isValid

11 years agoFix formatting
Robert Iannucci [Fri, 30 Nov 2012 01:47:22 +0000 (17:47 -0800)]
Fix formatting

11 years agoImprove comments for src/state.h
Robert Iannucci [Fri, 30 Nov 2012 01:07:50 +0000 (17:07 -0800)]
Improve comments for src/state.h

11 years agoDoc improvements
Robert Iannucci [Fri, 30 Nov 2012 00:49:04 +0000 (16:49 -0800)]
Doc improvements

11 years agoMake Edge->pool() a pointer like it should have been
Robert Iannucci [Fri, 30 Nov 2012 00:36:16 +0000 (16:36 -0800)]
Make Edge->pool() a pointer like it should have been

11 years agoImprove the manual documentation
Robert Iannucci [Fri, 30 Nov 2012 00:28:44 +0000 (16:28 -0800)]
Improve the manual documentation

11 years agoMerge pull request #464 from tfarina/clang-warning
Evan Martin [Tue, 27 Nov 2012 21:50:12 +0000 (13:50 -0800)]
Merge pull request #464 from tfarina/clang-warning

Fix clang warning.

11 years agoFix clang warning.
Thiago Farina [Tue, 27 Nov 2012 17:59:08 +0000 (15:59 -0200)]
Fix clang warning.

The return type of CollectTarget() is Node, so we should return NULL in the
failure case instead of false.

src/ninja.cc:188:16: warning: initialization of pointer of type 'Node *' to null from a constant boolean expression [-Wbool-conversion]
        return false;
               ^~~~~

Signed-off-by: Thiago Farina <tfarina@chromium.org>
11 years agoMerge pull request #459 from maximuska/proposed/refactor-collect-targets
Evan Martin [Mon, 12 Nov 2012 20:17:30 +0000 (12:17 -0800)]
Merge pull request #459 from maximuska/proposed/refactor-collect-targets

refactoring: decompose CollectTargetsFromArgs

11 years agoMerge pull request #443 from tfarina/disk-interface-alloc
Evan Martin [Mon, 12 Nov 2012 20:16:55 +0000 (12:16 -0800)]
Merge pull request #443 from tfarina/disk-interface-alloc

Allocate disk_interface near where it's needed.

11 years agoMerge pull request #454 from nico/tweak
Evan Martin [Mon, 12 Nov 2012 19:29:27 +0000 (11:29 -0800)]
Merge pull request #454 from nico/tweak

Fix a doxygen bug found by clang's -Wdocumentation.

11 years agoRevert "Dump state for debugging"
Robert Iannucci [Sat, 10 Nov 2012 19:58:04 +0000 (11:58 -0800)]
Revert "Dump state for debugging"

This reverts commit 9b196dc806e57cefd88bbbacd12286447dbf9ad9.

11 years agoUninitialized variable! There is always one...
Robert Iannucci [Sat, 10 Nov 2012 19:54:13 +0000 (11:54 -0800)]
Uninitialized variable! There is always one...

11 years agoDump state for debugging
Robert Iannucci [Sat, 10 Nov 2012 19:45:54 +0000 (11:45 -0800)]
Dump state for debugging

11 years agoMake edge dump pool name, and skip default pool
Robert Iannucci [Sat, 10 Nov 2012 19:35:02 +0000 (11:35 -0800)]
Make edge dump pool name, and skip default pool

11 years agocover the nulled pool case
Robert Iannucci [Sat, 10 Nov 2012 05:46:45 +0000 (21:46 -0800)]
cover the nulled pool case

11 years agoadd docs
Robert Iannucci [Sat, 10 Nov 2012 05:37:54 +0000 (21:37 -0800)]
add docs

11 years agoAdd some tests!
Robert Iannucci [Sat, 10 Nov 2012 05:12:48 +0000 (21:12 -0800)]
Add some tests!

11 years agobegin rationalizing platform for both parsers
Robert Iannucci [Mon, 1 Oct 2012 20:07:42 +0000 (13:07 -0700)]
begin rationalizing platform for both parsers

11 years agoblock parse method done
Robert Iannucci [Thu, 27 Sep 2012 23:37:37 +0000 (16:37 -0700)]
block parse method done

11 years agoall building and tests passing
Robert Iannucci [Fri, 9 Nov 2012 23:47:06 +0000 (15:47 -0800)]
all building and tests passing

11 years agoDump pools with State
Robert Iannucci [Fri, 9 Nov 2012 20:07:12 +0000 (12:07 -0800)]
Dump pools with State

11 years agoMerge pull request #458 from rgeary1/minor
Evan Martin [Fri, 9 Nov 2012 17:55:02 +0000 (09:55 -0800)]
Merge pull request #458 from rgeary1/minor

Minor improvements to ninja : Different exit code if user presses Ctrl-C, add eclipse to .gitignore, Improve an error message

11 years agorefactoring: decompose CollectTargetsFromArgs
Maxim Kalaev [Fri, 9 Nov 2012 07:20:05 +0000 (09:20 +0200)]
refactoring: decompose CollectTargetsFromArgs

11 years agoExit status = 2 if user presses ctrl-c
Richard Geary [Wed, 26 Sep 2012 08:40:33 +0000 (04:40 -0400)]
Exit status = 2 if user presses ctrl-c

Change-Id: I7be958e18eb2e434e78afb6e03b332281a651957

11 years agoImproved error message with more information
Richard Geary [Fri, 14 Sep 2012 09:02:06 +0000 (05:02 -0400)]
Improved error message with more information

Change-Id: Idb1ce67a320a9819de262d83b498ee10eb362ed2

11 years ago.gitignore Eclipse project files
Richard Geary [Fri, 14 Sep 2012 09:04:19 +0000 (05:04 -0400)]
.gitignore Eclipse project files

Change-Id: I7cfe7cee92e1800284829f099fe6a44f212b527f

11 years agoAdd --windows option to bootstrap.py
Hannu Koivisto [Wed, 10 Oct 2012 11:17:42 +0000 (14:17 +0300)]
Add --windows option to bootstrap.py

Makes it possible to make a native Windows build when using Cygwin Python.

11 years agoFix a bug... now chrome build works O_O
Robert Iannucci [Thu, 4 Oct 2012 23:50:24 +0000 (16:50 -0700)]
Fix a bug... now chrome build works O_O

11 years agoand some basic implementation
Robert Iannucci [Thu, 4 Oct 2012 00:25:23 +0000 (17:25 -0700)]
and some basic implementation

11 years agostub out an api and de-constify Pool
Robert Iannucci [Wed, 3 Oct 2012 23:27:27 +0000 (16:27 -0700)]
stub out an api and de-constify Pool

11 years agoConst ref FTW
Robert Iannucci [Mon, 1 Oct 2012 21:12:59 +0000 (14:12 -0700)]
Const ref FTW

11 years agoPull graph.cc too
Robert Iannucci [Mon, 1 Oct 2012 20:58:30 +0000 (13:58 -0700)]
Pull graph.cc too

11 years agoPull out base changes to state
Robert Iannucci [Mon, 1 Oct 2012 20:51:00 +0000 (13:51 -0700)]
Pull out base changes to state

11 years agoFix a doxygen bug found by clang's -Wdocumentation.
Nico Weber [Thu, 8 Nov 2012 18:42:28 +0000 (10:42 -0800)]
Fix a doxygen bug found by clang's -Wdocumentation.

(That found one more issue, but I think that might be a bug in
-Wdocumentation, http://llvm.org/PR14295.)

11 years agorefactor repeated code in cleaner
Evan Martin [Mon, 29 Oct 2012 16:53:30 +0000 (09:53 -0700)]
refactor repeated code in cleaner

11 years agodelete some obsolete TODOs
Evan Martin [Sat, 27 Oct 2012 19:56:31 +0000 (12:56 -0700)]
delete some obsolete TODOs

11 years agotrailing whitespace
Evan Martin [Sat, 27 Oct 2012 19:52:46 +0000 (12:52 -0700)]
trailing whitespace

11 years agoMerge pull request #453 from curinir/bash_completion
Evan Martin [Wed, 31 Oct 2012 05:01:44 +0000 (22:01 -0700)]
Merge pull request #453 from curinir/bash_completion

Add support for reading directory for bash completion.

11 years agoAdd support for reading directory for bash completion.
Tommy Nyquist [Tue, 30 Oct 2012 22:28:02 +0000 (15:28 -0700)]
Add support for reading directory for bash completion.

Currently ninja bash completion only works in the directory where the
build.ninja files is located. This adds support for using the -C
argument to ninja.

11 years agoMerge pull request #451 from ppuryear/browse-python3
Evan Martin [Sat, 27 Oct 2012 03:18:10 +0000 (20:18 -0700)]
Merge pull request #451 from ppuryear/browse-python3

browse.py: Support Python 3.

11 years agobrowse.py: Don't truncate error message if ninja -t query fails.
Philip Puryear [Fri, 26 Oct 2012 21:56:48 +0000 (16:56 -0500)]
browse.py: Don't truncate error message if ninja -t query fails.

Signed-off-by: Philip Puryear <philippuryear@gmail.com>
11 years agobrowse.py: Fix truncation with an unknown target.
Philip Puryear [Fri, 26 Oct 2012 03:43:03 +0000 (22:43 -0500)]
browse.py: Fix truncation with an unknown target.

Signed-off-by: Philip Puryear <philippuryear@gmail.com>
11 years agobrowse.py: Python 3 support.
Philip Puryear [Fri, 26 Oct 2012 03:41:20 +0000 (22:41 -0500)]
browse.py: Python 3 support.

Signed-off-by: Philip Puryear <philippuryear@gmail.com>
11 years agofix bad merge
Evan Martin [Tue, 23 Oct 2012 16:37:55 +0000 (09:37 -0700)]
fix bad merge

11 years agomingw helper: drop unused -r flag
Evan Martin [Mon, 8 Oct 2012 23:31:15 +0000 (16:31 -0700)]
mingw helper: drop unused -r flag

11 years agoupdate mingw docs for ubuntu precise
Evan Martin [Mon, 8 Oct 2012 23:30:27 +0000 (16:30 -0700)]
update mingw docs for ubuntu precise

11 years agofix whitespace
Evan Martin [Mon, 8 Oct 2012 17:09:12 +0000 (10:09 -0700)]
fix whitespace

11 years agobootstrap: fail more gracefully if gcc isn't available
Evan Martin [Fri, 28 Sep 2012 17:05:34 +0000 (10:05 -0700)]
bootstrap: fail more gracefully if gcc isn't available

11 years agoMerge pull request #450 from zchothia/zc/py3k
Evan Martin [Sun, 21 Oct 2012 19:20:33 +0000 (12:20 -0700)]
Merge pull request #450 from zchothia/zc/py3k

Add support for Python 3

11 years agoPython scripts: use built-in print function.
Zaheer Chothia [Fri, 19 Oct 2012 07:46:09 +0000 (09:46 +0200)]
Python scripts: use built-in print function.

11 years agoAdd support for Python 3
Zaheer Chothia [Thu, 18 Oct 2012 13:02:48 +0000 (15:02 +0200)]
Add support for Python 3

11 years agoMerge pull request #441 from tfarina/missing-virtual
Evan Martin [Wed, 17 Oct 2012 18:54:45 +0000 (11:54 -0700)]
Merge pull request #441 from tfarina/missing-virtual

Add missing 'virtual' annotation to ReadFile() override.

11 years agoAdd missing 'virtual' annotation to ReadFile() override.
Thiago Farina [Tue, 9 Oct 2012 02:48:11 +0000 (23:48 -0300)]
Add missing 'virtual' annotation to ReadFile() override.

Signed-off-by: Thiago Farina <tfarina@chromium.org>
11 years agoMerge pull request #448 from maximuska/proposed/buildlog-mini-refactor2
Evan Martin [Wed, 17 Oct 2012 05:28:06 +0000 (22:28 -0700)]
Merge pull request #448 from maximuska/proposed/buildlog-mini-refactor2

Proposed/buildlog mini refactor2

11 years agobuild log: fixing parameter names
Maxim Kalaev [Sun, 14 Oct 2012 18:40:46 +0000 (20:40 +0200)]
build log: fixing parameter names

11 years agoMerge pull request #446 from maximuska/proposed/start-end-edge-metrics
Evan Martin [Fri, 12 Oct 2012 17:03:21 +0000 (10:03 -0700)]
Merge pull request #446 from maximuska/proposed/start-end-edge-metrics

build metrics: StartEdge and EndEdge

11 years agobuild metrics: StartEdge and EndEdge
Maxim Kalaev [Fri, 12 Oct 2012 06:16:06 +0000 (08:16 +0200)]
build metrics: StartEdge and EndEdge

Total build time is also relevant.
The costs of StartEdge and EndEdge turned out to be quite surprising.
Especially if multiple targets are specified on edges.
 (I've tried declaring depfiles targets explicitly)

11 years agobuild log: mini-refactoring to use constructors to initialize entries
Maxim Kalaev [Fri, 12 Oct 2012 06:59:49 +0000 (08:59 +0200)]
build log: mini-refactoring to use constructors to initialize entries

11 years agobuild log: moving HashCommand() calculation out of targets loop
Maxim Kalaev [Fri, 12 Oct 2012 06:57:23 +0000 (08:57 +0200)]
build log: moving HashCommand() calculation out of targets loop

11 years agobuild log: Adding test for multiple target edges
Maxim Kalaev [Sat, 6 Oct 2012 21:16:21 +0000 (23:16 +0200)]
build log: Adding test for multiple target edges

11 years agoAllocate disk_interface near where it's needed.
Thiago Farina [Wed, 10 Oct 2012 15:51:53 +0000 (12:51 -0300)]
Allocate disk_interface near where it's needed.

This avoids allocating disk_interface unnecessarily.

Signed-off-by: Thiago Farina <tfarina@chromium.org>
11 years agoMerge pull request #439 from wolfp/metric-recompact
Evan Martin [Thu, 4 Oct 2012 22:52:47 +0000 (15:52 -0700)]
Merge pull request #439 from wolfp/metric-recompact

Add metric for log recompacting

11 years agoAdd metric for log recompacting
Petr Wolf [Thu, 4 Oct 2012 20:07:25 +0000 (16:07 -0400)]
Add metric for log recompacting

11 years agoMerge pull request #438 from wolfp/clean-efficiency
Evan Martin [Thu, 4 Oct 2012 19:53:32 +0000 (12:53 -0700)]
Merge pull request #438 from wolfp/clean-efficiency

Improve the efficiency of -t clean

11 years agoImprove the efficiency of -t clean
Petr Wolf [Thu, 4 Oct 2012 19:42:15 +0000 (15:42 -0400)]
Improve the efficiency of -t clean

Prevent each node from being examined for cleaning multiple times, if it
is used in several other nodes

11 years agoMerge pull request #437 from mo/master
Evan Martin [Wed, 3 Oct 2012 20:05:26 +0000 (13:05 -0700)]
Merge pull request #437 from mo/master

[PATCH] Fixed two spelling errors in ninja

11 years agoFix two spelling errors
Martin Olsson [Wed, 3 Oct 2012 08:10:53 +0000 (10:10 +0200)]
Fix two spelling errors

11 years agoMerge pull request #436 from tfarina/dry-run-unnamed-namespace
Evan Martin [Tue, 2 Oct 2012 19:05:29 +0000 (12:05 -0700)]
Merge pull request #436 from tfarina/dry-run-unnamed-namespace

Move DryRunCommandRunner into a unnamed namespace.

11 years agoMove DryRunCommandRunner into a unnamed namespace.
Thiago Farina [Tue, 2 Oct 2012 01:13:39 +0000 (22:13 -0300)]
Move DryRunCommandRunner into a unnamed namespace.

No functional change.

Signed-off-by: Thiago Farina <tfarina@chromium.org>
11 years agoMerge pull request #433 from polrop/fix-help-option
Evan Martin [Sun, 30 Sep 2012 17:20:51 +0000 (10:20 -0700)]
Merge pull request #433 from polrop/fix-help-option

Don't say -h is invalid whereas it is supported.

11 years agoDon't say -h is invalid whereas it is supported.
Nicolas Despres [Thu, 27 Sep 2012 18:49:22 +0000 (20:49 +0200)]
Don't say -h is invalid whereas it is supported.

getopt_long(3) was reporting "ninja: invalid option -- h" when "ninja -h" was
called.

Regression most probably introduced by 5fdb12ed5cec4e1c853c64026142d088ff5519e1

11 years agoMerge pull request #428 from maximuska/proposed/rpm-build-fixed
Evan Martin [Sun, 23 Sep 2012 16:51:39 +0000 (09:51 -0700)]
Merge pull request #428 from maximuska/proposed/rpm-build-fixed

packaging: refactored rpm building

11 years agopackaging: refactored rpm building
Maxim Kalaev [Fri, 14 Sep 2012 10:46:01 +0000 (13:46 +0300)]
packaging: refactored rpm building

Now passing through a valid SRPM, working in a standard way.