platform/upstream/freerdp.git
5 years agoMerge pull request #5227 from akallabeth/compiler_warnings_fixes
David Fort [Tue, 29 Jan 2019 23:08:55 +0000 (00:08 +0100)]
Merge pull request #5227 from akallabeth/compiler_warnings_fixes

Compiler warnings fixes

5 years agoFixed compiler warnings for TRIO_CONST and limited data type.
Armin Novak [Tue, 29 Jan 2019 16:46:47 +0000 (17:46 +0100)]
Fixed compiler warnings for TRIO_CONST and limited data type.

5 years agoFixed missing initializers
Armin Novak [Tue, 29 Jan 2019 16:48:05 +0000 (17:48 +0100)]
Fixed missing initializers

5 years agoAsserting arg->Value to silence clang analyzer NULL argument checks.
Armin Novak [Tue, 29 Jan 2019 16:24:29 +0000 (17:24 +0100)]
Asserting arg->Value to silence clang analyzer NULL argument checks.

5 years agoFixed clang analyzer false positive memory leaks.
Armin Novak [Tue, 29 Jan 2019 16:16:46 +0000 (17:16 +0100)]
Fixed clang analyzer false positive memory leaks.

Added a justification for each #ifndef __clang_analyzer__

5 years agoFixed clang scanbuild false positive memory leak.
Armin Novak [Tue, 29 Jan 2019 16:06:08 +0000 (17:06 +0100)]
Fixed clang scanbuild false positive memory leak.

The memset did confuse the analyzer. Remove it as the variable
is already initialized to zero.

5 years agoFixed uninitialized return value.
Armin Novak [Tue, 29 Jan 2019 15:53:30 +0000 (16:53 +0100)]
Fixed uninitialized return value.

5 years agoFixed compiler warnings #5210
Armin Novak [Tue, 29 Jan 2019 15:22:46 +0000 (16:22 +0100)]
Fixed compiler warnings #5210

5 years agoFixed compiler warnings #5210
Armin Novak [Tue, 29 Jan 2019 15:15:33 +0000 (16:15 +0100)]
Fixed compiler warnings #5210

5 years agoFixed compiler warnings #5210
Armin Novak [Tue, 29 Jan 2019 15:15:23 +0000 (16:15 +0100)]
Fixed compiler warnings #5210

5 years agoFixed compiler warnings #5210
Armin Novak [Tue, 29 Jan 2019 15:14:55 +0000 (16:14 +0100)]
Fixed compiler warnings #5210

5 years agoFixed compiler warnings #5210
Armin Novak [Tue, 29 Jan 2019 15:14:29 +0000 (16:14 +0100)]
Fixed compiler warnings #5210

5 years agoMerge pull request #5140 from akallabeth/print_custom_component
David Fort [Tue, 29 Jan 2019 14:18:53 +0000 (15:18 +0100)]
Merge pull request #5140 from akallabeth/print_custom_component

Added callback to handle printer custom components in printer backend.

5 years agoMerge pull request #5221 from akallabeth/wayland_mouse_cursor
David Fort [Tue, 29 Jan 2019 14:11:38 +0000 (15:11 +0100)]
Merge pull request #5221 from akallabeth/wayland_mouse_cursor

Added wayland mouse cursor

5 years agoFixed review remarks.
Armin Novak [Tue, 29 Jan 2019 13:21:58 +0000 (14:21 +0100)]
Fixed review remarks.

5 years agoRemoved debug messages.
Armin Novak [Tue, 29 Jan 2019 12:34:27 +0000 (13:34 +0100)]
Removed debug messages.

5 years agoFixed uninitialized value.
Armin Novak [Tue, 29 Jan 2019 10:07:44 +0000 (11:07 +0100)]
Fixed uninitialized value.

5 years agoMerge pull request #5224 from hardening/serverStatusInfo
akallabeth [Tue, 29 Jan 2019 09:47:36 +0000 (10:47 +0100)]
Merge pull request #5224 from hardening/serverStatusInfo

rdp: add a callback for ServerStatusInfo

5 years agoMerge pull request #5187 from astrand/mingw-part1
akallabeth [Tue, 29 Jan 2019 09:46:21 +0000 (10:46 +0100)]
Merge pull request #5187 from astrand/mingw-part1

Mingw build fixes part1

5 years agordp: add a callback for ServerStatusInfo
David Fort [Tue, 29 Jan 2019 09:33:06 +0000 (10:33 +0100)]
rdp: add a callback for ServerStatusInfo

5 years agoFixed wayland library detection.
Armin Novak [Mon, 28 Jan 2019 14:46:12 +0000 (15:46 +0100)]
Fixed wayland library detection.

5 years agoFixed pointer image update.
Armin Novak [Mon, 28 Jan 2019 14:29:30 +0000 (15:29 +0100)]
Fixed pointer image update.

5 years agoAdded O_TMPFILE support for uwac tempfile generation.
Armin Novak [Fri, 25 Jan 2019 14:46:55 +0000 (15:46 +0100)]
Added O_TMPFILE support for uwac tempfile generation.

5 years agoAdded UWAC_EVENT_OUTPUT_GEOMETRY event
Armin Novak [Fri, 25 Jan 2019 14:38:56 +0000 (15:38 +0100)]
Added UWAC_EVENT_OUTPUT_GEOMETRY event

5 years agoAdded mouse cursor callback stubs.
Armin Novak [Fri, 25 Jan 2019 12:05:51 +0000 (13:05 +0100)]
Added mouse cursor callback stubs.

5 years agoMerge pull request #5149 from akallabeth/cert_deny
David Fort [Fri, 25 Jan 2019 15:59:33 +0000 (16:59 +0100)]
Merge pull request #5149 from akallabeth/cert_deny

New option to disable user certificate dialog

5 years agoMerge pull request #5150 from akallabeth/gw_consent_callback
MartinHaimberger [Fri, 25 Jan 2019 11:33:18 +0000 (12:33 +0100)]
Merge pull request #5150 from akallabeth/gw_consent_callback

Fix #1195: Implement callback for Gateway Messages

5 years agoMerge pull request #5218 from ckelsel/master
akallabeth [Fri, 25 Jan 2019 11:19:56 +0000 (12:19 +0100)]
Merge pull request #5218 from ckelsel/master

May crash if GetCommandLineW failed

5 years agoMerge pull request #5213 from akallabeth/wayland_and_warning_fixes
David Fort [Fri, 25 Jan 2019 10:42:38 +0000 (11:42 +0100)]
Merge pull request #5213 from akallabeth/wayland_and_warning_fixes

Wayland and warning fixes

5 years agoMay crash if GetCommandLineW failed
xie.kunming [Fri, 25 Jan 2019 09:54:25 +0000 (17:54 +0800)]
May crash if GetCommandLineW failed

5 years agoFixed buffer submit and callback cleanup.
Armin Novak [Fri, 25 Jan 2019 09:50:07 +0000 (10:50 +0100)]
Fixed buffer submit and callback cleanup.

* Buffer submit now ignores duplicate buffer submit again.
* Frame callback is cleaned up in the callback function now.
* Damage region is currently ignored as there are screen artifacts otherwise.

5 years agoFixed wayland buffer updates
Armin Novak [Thu, 24 Jan 2019 14:10:08 +0000 (15:10 +0100)]
Fixed wayland buffer updates

The wayland buffer size always matches the current window size.
That might be different from the actual remote framebuffer size,
to when copying always use the correct strides to avoid distorted
screen content.

5 years agoFixed wayland clipboard registration, retry if seat is detected before.
Armin Novak [Thu, 24 Jan 2019 12:15:40 +0000 (13:15 +0100)]
Fixed wayland clipboard registration, retry if seat is detected before.

5 years agoMerge pull request #5216 from ckelsel/master
akallabeth [Fri, 25 Jan 2019 09:01:30 +0000 (10:01 +0100)]
Merge pull request #5216 from ckelsel/master

change SetTimer elapse from 10 to USER_TIMER_MINIMUM

5 years agoIf uElapse is less than USER_TIMER_MINIMUM (0x0000000A), the timeout is set to USER_T...
xie.kunming [Fri, 25 Jan 2019 08:45:52 +0000 (16:45 +0800)]
If uElapse is less than USER_TIMER_MINIMUM (0x0000000A), the timeout is set to USER_TIMER_MINIMUM.

5 years agoRemoved buffer damage tracking in client, let UWAC handle that.
Armin Novak [Thu, 24 Jan 2019 11:01:40 +0000 (12:01 +0100)]
Removed buffer damage tracking in client, let UWAC handle that.

5 years agoFixed warnings found by compiler and static analysis.
Armin Novak [Thu, 24 Jan 2019 10:19:20 +0000 (11:19 +0100)]
Fixed warnings found by compiler and static analysis.

5 years agoFixed warnings found by compiler and static analysis.
Armin Novak [Thu, 24 Jan 2019 10:14:06 +0000 (11:14 +0100)]
Fixed warnings found by compiler and static analysis.

5 years agoFixed warnings found by compiler and static analysis.
Armin Novak [Thu, 24 Jan 2019 10:03:36 +0000 (11:03 +0100)]
Fixed warnings found by compiler and static analysis.

5 years agoFixed warnings found by compiler and static analysis.
Armin Novak [Thu, 24 Jan 2019 10:00:48 +0000 (11:00 +0100)]
Fixed warnings found by compiler and static analysis.

5 years agoFixed warnings found by compiler and static analysis.
Armin Novak [Thu, 24 Jan 2019 09:33:59 +0000 (10:33 +0100)]
Fixed warnings found by compiler and static analysis.

5 years agoMerge pull request #5212 from hardening/ddm_fix
akallabeth [Thu, 24 Jan 2019 10:53:37 +0000 (11:53 +0100)]
Merge pull request #5212 from hardening/ddm_fix

uwac: fix initialization of data_device_manager

5 years agouwac: fix initialization of data_device_manager
David Fort [Thu, 24 Jan 2019 09:30:04 +0000 (10:30 +0100)]
uwac: fix initialization of data_device_manager

Depending on how global objects are announced (seats then ddm), we could fail to initialize
the data device manager of seats.

5 years agoMerge pull request #5160 from akallabeth/wayland_clipboard
David Fort [Wed, 23 Jan 2019 16:15:59 +0000 (17:15 +0100)]
Merge pull request #5160 from akallabeth/wayland_clipboard

Wayland clipboard

5 years agoRefactored client clipboard function callbacks for const data pointers.
Armin Novak [Wed, 23 Jan 2019 15:22:29 +0000 (16:22 +0100)]
Refactored client clipboard function callbacks for const data pointers.

5 years agoClipboard data pointer arguments are now const.
Armin Novak [Wed, 23 Jan 2019 15:22:04 +0000 (16:22 +0100)]
Clipboard data pointer arguments are now const.

5 years agoIgnore clipboard events if channel not loaded.
Armin Novak [Wed, 23 Jan 2019 15:01:36 +0000 (16:01 +0100)]
Ignore clipboard events if channel not loaded.

5 years agoFixed missing return.
Armin Novak [Tue, 22 Jan 2019 10:04:50 +0000 (11:04 +0100)]
Fixed missing return.

5 years agoAdded log messages for unusual error events.
Armin Novak [Tue, 22 Jan 2019 09:56:10 +0000 (10:56 +0100)]
Added log messages for unusual error events.

5 years agoAdded assert
Armin Novak [Tue, 22 Jan 2019 09:52:24 +0000 (10:52 +0100)]
Added assert

5 years agoRemoved internal checks.
Armin Novak [Tue, 22 Jan 2019 09:50:34 +0000 (10:50 +0100)]
Removed internal checks.

5 years agoFixed a log message.
Armin Novak [Tue, 22 Jan 2019 09:48:32 +0000 (10:48 +0100)]
Fixed a log message.

5 years agoFixed some log messages / missing asserts.
Armin Novak [Tue, 22 Jan 2019 09:47:26 +0000 (10:47 +0100)]
Fixed some log messages / missing asserts.

5 years agoFixed NULL dereference.
Armin Novak [Wed, 16 Jan 2019 14:01:49 +0000 (15:01 +0100)]
Fixed NULL dereference.

5 years agoImplemented wayland clipboard.
Armin Novak [Wed, 19 Dec 2018 15:18:13 +0000 (16:18 +0100)]
Implemented wayland clipboard.

5 years agoImplemented UWAC clipboard handling.
Armin Novak [Wed, 19 Dec 2018 15:17:59 +0000 (16:17 +0100)]
Implemented UWAC clipboard handling.

5 years agoMerge pull request #5159 from akallabeth/wayland_display
David Fort [Wed, 23 Jan 2019 14:41:42 +0000 (15:41 +0100)]
Merge pull request #5159 from akallabeth/wayland_display

Implemented wayland display resize channel.

5 years agoMerge pull request #5192 from akallabeth/dynamic_openh264
David Fort [Wed, 23 Jan 2019 13:30:31 +0000 (14:30 +0100)]
Merge pull request #5192 from akallabeth/dynamic_openh264

Using (optional) runtime linking for OpenH264.

5 years agoMerge pull request #5209 from akallabeth/wayland_protocol_update_and_keyboard_inhibit
David Fort [Wed, 23 Jan 2019 09:02:07 +0000 (10:02 +0100)]
Merge pull request #5209 from akallabeth/wayland_protocol_update_and_keyboard_inhibit

Wayland protocol update and keyboard inhibit support

5 years agoRemoved unused label.
Armin Novak [Tue, 22 Jan 2019 17:09:53 +0000 (18:09 +0100)]
Removed unused label.

5 years agoFixed duplicated check.
Armin Novak [Tue, 22 Jan 2019 10:06:11 +0000 (11:06 +0100)]
Fixed duplicated check.

5 years agoImplemented wayland display resize channel.
Armin Novak [Tue, 18 Dec 2018 11:30:31 +0000 (12:30 +0100)]
Implemented wayland display resize channel.

5 years agoFixed initialization of window decorations.
Armin Novak [Tue, 22 Jan 2019 16:20:19 +0000 (17:20 +0100)]
Fixed initialization of window decorations.

5 years agoAdded KDE server side window decoration interface as fallback.
Armin Novak [Tue, 22 Jan 2019 15:13:08 +0000 (16:13 +0100)]
Added KDE server side window decoration interface as fallback.

5 years agoMerge pull request #5201 from akallabeth/wayland_refresh_fix
Martin Fleisz [Tue, 22 Jan 2019 16:04:37 +0000 (17:04 +0100)]
Merge pull request #5201 from akallabeth/wayland_refresh_fix

Wayland refresh fix

5 years agoFixed comment.
Armin Novak [Tue, 22 Jan 2019 15:55:46 +0000 (16:55 +0100)]
Fixed comment.

5 years agoMerge pull request #5156 from akallabeth/flatpak_support
Martin Fleisz [Tue, 22 Jan 2019 15:43:32 +0000 (16:43 +0100)]
Merge pull request #5156 from akallabeth/flatpak_support

Flatpak support

5 years agoMerge pull request #5202 from hardening/server_side_license1
akallabeth [Tue, 22 Jan 2019 15:27:57 +0000 (16:27 +0100)]
Merge pull request #5202 from hardening/server_side_license1

license: implement server-side management

5 years agoAdded wayland server side decorations.
Armin Novak [Tue, 22 Jan 2019 14:45:15 +0000 (15:45 +0100)]
Added wayland server side decorations.

5 years agoUpdated flatpak build
Armin Novak [Tue, 22 Jan 2019 14:18:59 +0000 (15:18 +0100)]
Updated flatpak build

Added startup script checking if to run X11 or wayland.

5 years agoImplemented keyboard shortcut inhibit support.
Armin Novak [Tue, 22 Jan 2019 12:46:46 +0000 (13:46 +0100)]
Implemented keyboard shortcut inhibit support.

5 years agoUpdated fullscreen shell to current protocol level.
Armin Novak [Tue, 22 Jan 2019 12:09:59 +0000 (13:09 +0100)]
Updated fullscreen shell to current protocol level.

5 years agoUpdate to xdg-shell stable.
Armin Novak [Tue, 22 Jan 2019 12:05:46 +0000 (13:05 +0100)]
Update to xdg-shell stable.

5 years agoImplemented DesktopResize callback for wayland client.
Armin Novak [Tue, 22 Jan 2019 09:29:08 +0000 (10:29 +0100)]
Implemented DesktopResize callback for wayland client.

5 years agolicense: implement server-side management
David Fort [Thu, 1 Nov 2018 10:02:54 +0000 (11:02 +0100)]
license: implement server-side management

Add server-side management of the licensing workflow. The default
behaviour is to accept the client, but if a server wants to implement
full licensing support as in MS-RDPELE it is possible by defining a callback.

5 years agoMerge pull request #5200 from akallabeth/os2_fixes
David Fort [Fri, 18 Jan 2019 17:04:23 +0000 (18:04 +0100)]
Merge pull request #5200 from akallabeth/os2_fixes

Os2 fixes

5 years agoResubmit buffer if necessary.
Armin Novak [Fri, 18 Jan 2019 13:39:14 +0000 (14:39 +0100)]
Resubmit buffer if necessary.

5 years agoUnified buffer update and screen refresh on focus
Armin Novak [Fri, 18 Jan 2019 13:38:51 +0000 (14:38 +0100)]
Unified buffer update and screen refresh on focus

5 years agoAdded fix for OS2 paths.
Armin Novak [Fri, 18 Jan 2019 12:13:41 +0000 (13:13 +0100)]
Added fix for OS2 paths.

Reported on mailing list by Andrey Vasilkin

5 years agoFixed WINDOW_ORDER_INFO copy.
Armin Novak [Fri, 18 Jan 2019 12:04:34 +0000 (13:04 +0100)]
Fixed WINDOW_ORDER_INFO copy.

Patch by Andrey Vasilkin on mailing list

5 years agoYield in connection wait loops to reduce processor use.
Armin Novak [Fri, 18 Jan 2019 12:03:36 +0000 (13:03 +0100)]
Yield in connection wait loops to reduce processor use.

Patch by Andrey Vasilkin on mailing list.

5 years agoFixed return check in SwitchToThread
Armin Novak [Fri, 18 Jan 2019 12:02:30 +0000 (13:02 +0100)]
Fixed return check in SwitchToThread

Patch on mailing list by Andrey Vasilkin

5 years agoMerge pull request #5199 from llyzs/freerdp_rdpsnd_winmm
Martin Fleisz [Fri, 18 Jan 2019 10:18:34 +0000 (11:18 +0100)]
Merge pull request #5199 from llyzs/freerdp_rdpsnd_winmm

rdpsnd/winmm: remove an unnecessary blocking event.

5 years agordpsnd/winmm: remove an unnecessary blocking event.
Vic Lee [Fri, 18 Jan 2019 09:48:06 +0000 (17:48 +0800)]
rdpsnd/winmm: remove an unnecessary blocking event.

5 years agoMerge pull request #5197 from akallabeth/leak_fix_lodepng
Martin Fleisz [Fri, 18 Jan 2019 08:11:48 +0000 (09:11 +0100)]
Merge pull request #5197 from akallabeth/leak_fix_lodepng

Fixed memory leak in lodepng.

5 years agoMerge pull request #5191 from akallabeth/mac_mouse_support
Martin Fleisz [Thu, 17 Jan 2019 13:46:55 +0000 (14:46 +0100)]
Merge pull request #5191 from akallabeth/mac_mouse_support

Implemented full mouse support.

5 years agoUnified mouse coordinate scaling.
Armin Novak [Thu, 17 Jan 2019 12:44:04 +0000 (13:44 +0100)]
Unified mouse coordinate scaling.

5 years agoFixed memory leak in lodepng.
Armin Novak [Wed, 16 Jan 2019 14:23:12 +0000 (15:23 +0100)]
Fixed memory leak in lodepng.

5 years agoMerge pull request #5196 from bmiklautz/winprhash
akallabeth [Wed, 16 Jan 2019 13:13:27 +0000 (14:13 +0100)]
Merge pull request #5196 from bmiklautz/winprhash

fix [winpr/hash]: initialize ssl

5 years agofix [winpr/hash]: initialize ssl
Bernhard Miklautz [Wed, 16 Jan 2019 11:05:47 +0000 (12:05 +0100)]
fix [winpr/hash]: initialize ssl

winpr-crypt is used in winpr for hash generation but currently it's
still required to initialize openssl in the application itself.
winpr-hash didn't do that therefore the generated hashes were useless.

5 years agoAdded version check for dynamic OpenH264 use.
Armin Novak [Tue, 15 Jan 2019 08:49:48 +0000 (09:49 +0100)]
Added version check for dynamic OpenH264 use.

5 years agoMerge pull request #5194 from akallabeth/drive_file_size_fix2
David Fort [Mon, 14 Jan 2019 22:25:26 +0000 (23:25 +0100)]
Merge pull request #5194 from akallabeth/drive_file_size_fix2

Fixed #5185 broken file size initialization.

5 years agoFixed #5185 broken file size initialization.
Armin Novak [Mon, 14 Jan 2019 13:54:33 +0000 (14:54 +0100)]
Fixed #5185 broken file size initialization.

5 years agoUsing runtime linking for OpenH264.
Armin Novak [Fri, 11 Jan 2019 10:40:31 +0000 (11:40 +0100)]
Using runtime linking for OpenH264.

This allows removing the hard dependency on OpenH264 and use the
cisco provided binary.

5 years agoImplemented full mouse support for mac client.
Armin Novak [Thu, 10 Jan 2019 10:09:57 +0000 (11:09 +0100)]
Implemented full mouse support for mac client.

5 years agoPointer arithmetics require lvalue
Peter Åstrand (astrand) [Wed, 9 Jan 2019 10:13:38 +0000 (11:13 +0100)]
Pointer arithmetics require lvalue

(type *)x evaluates to a temporary. Fixed build with GCC.

5 years agoAvoid building POSIX clipboard if WIN32
Peter Åstrand (astrand) [Wed, 9 Jan 2019 09:04:38 +0000 (10:04 +0100)]
Avoid building POSIX clipboard if WIN32

MinGW has unistd.h.

5 years agoCheck MSVC_RUNTIME only if MSVC is defined
Peter Åstrand (astrand) [Wed, 9 Jan 2019 09:01:44 +0000 (10:01 +0100)]
Check MSVC_RUNTIME only if MSVC is defined

On MinGW, WIN32 is set but not MSVC

5 years agofreerdp_client_set_window_size should not be static
Peter Åstrand (astrand) [Wed, 9 Jan 2019 08:54:31 +0000 (09:54 +0100)]
freerdp_client_set_window_size should not be static

Avoid GCC error, since it is not static according to wf_client.h.

5 years agoAdd msimg32 library through CMake
Peter Åstrand (astrand) [Wed, 9 Jan 2019 08:52:27 +0000 (09:52 +0100)]
Add msimg32 library through CMake

MinGW does not support libs through #pragma comments.