Juha Heiskanen [Tue, 29 Mar 2022 09:02:53 +0000 (12:02 +0300)]
Fix dEQP-VK.image.sample_texture.* tests write out-of-bounds bug
Compute shader writing to the view is now made by using block size
instead of pixel count.
Components: Vulkan
VK-GL-CTS Issue: 3442
Affects: dEQP-VK.image.sample_texture.*
Change-Id: Ie351fb1d2730c5377c8110453bc34629c20b5d82
Jari Komppa [Wed, 9 Mar 2022 12:18:13 +0000 (14:18 +0200)]
Add tests for surfaceless queries
This change adds tests for the VK_GOOGLE_surfaceless_query
extension.
New tests:
dEQP-VK.wsi.*.surface.query_formats_surfaceless
dEQP-VK.wsi.*.surface.query_formats2_surfaceless
dEQP-VK.wsi.*.surface.query_present_modes_surfaceless
Components: Vulkan
VK-GL-CTS issue: 3557
Change-Id: I6febafc855b500052e8dedcba810dd80fb5c1e71
Matthew Netsch [Fri, 8 Apr 2022 17:52:41 +0000 (10:52 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I7a3dfef17070866462056327110f798dde9f119d
Matthew Netsch [Fri, 8 Apr 2022 16:14:23 +0000 (09:14 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I35b6b6a32a0ef4bb72d628f26b96a1ac8df46858
Matthew Netsch [Thu, 7 Apr 2022 20:56:53 +0000 (13:56 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I2c051a776b06d23239eb3ce501a999088cd0c1de
Piotr Byszewski [Mon, 25 Oct 2021 19:11:51 +0000 (21:11 +0200)]
Rework extensions_data and mandatory_features
Data from mandatory_features.txt was split to multiple json files
one per extension/vulkan_version. Those files now also include data
that was previously stored in extensions_data.txt .
VK-GL-CTS issue: 3197
Components: Framework, Vulkan
Affects:
dEQP-VK.*
Change-Id: I9756237829366ff4140dcf59dc7548a8f4328cb7
Matthew Netsch [Thu, 7 Apr 2022 18:47:24 +0000 (11:47 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I69f0b9b087df9c33b26ddd014fc1a291fc50dbdd
Matthew Netsch [Thu, 7 Apr 2022 17:48:16 +0000 (17:48 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I4a1b44642747f72803ff97dafd55f4ba3fabad9e
Ari Suonpaa [Tue, 29 Mar 2022 08:56:44 +0000 (11:56 +0300)]
Use associated physical device from custom instance
Some of the API feature info tests created a custom instance,
but still used the default physical device. This is fixed by
choosing a physical device using the custom instance.
Comparison of VkPhysicalDeviceMemoryProperties was also
changed to only check the active memoryTypes and memoryHeaps
array elements instead of doing one large deMemCmp.
VK-GL-CTS Issue: 3590
Affects:
dEQP-VK.api.info.*
Components: Vulkan
Change-Id: I2378bcd1e97b7f85e533d34c5b5f6ac3e4fa9b93
Ricardo Garcia [Tue, 29 Mar 2022 14:51:18 +0000 (16:51 +0200)]
Wait for deferred operations before obtaining RT pipeline handle
The ray tracing utils, when creating ray tracing pipelines and using
deferred operations, were using the VkPipeline pointer and handler
before the deferred operation had completed, which is against the spec.
Affected tests:
dEQP-VK.ray_tracing_pipeline.pipeline_library.configurations.multithreaded_compilation_dho.*
dEQP-VK.ray_tracing_pipeline.large_shader_set.cpu_ht*
Components: Vulkan
VK-GL-CTS issue: 3588
Change-Id: Ied8f443c01e99878180130963b8988852171b8a0
Mike Blumenkrantz [Thu, 31 Mar 2022 13:07:29 +0000 (15:07 +0200)]
Fix subgroup size control failure logging
One of the failure messages was missing the message terminator, which
prevented it from ever being logged.
Affects:
dEQP-VK.subgroups.size_control*
Components: Vulkan
VK-GL-CTS issue: 3596
Change-Id: If649a11e0f6cf0f5e69e438d46b385b26e57dfe4
Ricardo Garcia [Fri, 1 Apr 2022 10:01:40 +0000 (12:01 +0200)]
Parse test case result version when converting to XML
When parsing QPA files, extract the test case result version so it can
be later used to print the proper version when converting to XML files.
Components: Framework
VK-GL-CTS issue: 3573
VK-GL-CTS public issue: 287
Change-Id: I34d005621685b0ef31a7092ec7c40e6626bf20e3
Matthew Netsch [Thu, 7 Apr 2022 17:24:00 +0000 (17:24 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I25f8f2f56ab07a9c3f04e8cfa54f2efc11bfd80a
Nanley Chery [Wed, 16 Mar 2022 20:08:04 +0000 (13:08 -0700)]
Add queue ownership release in modifier tests
Queue ownership transfers require a release operation and an acquire
operation. Before this patch, this test only performed the acquire
operation.
Components: Vulkan
VK-GL-CTS issue: 3575
Affects: dEQP-VK.drm_format_modifiers.export_import.*
Change-Id: I2998d7928d1042d6a159e1173257ee551c1120a5
Nanley Chery [Wed, 16 Mar 2022 20:40:46 +0000 (13:40 -0700)]
Fix incorrect layout transition in modifier tests
The queue family ownership acquire operation specifies a layout
transition from the pre-initialized layout. The image isn't in the
pre-initialized layout however, it's in the transfer dst optimal layout.
Align with the Vulkan spec, which says:
When performing a layout transition on an image subresource, the
old layout value must either equal the current layout of the
image subresource (at the time the transition executes), or else
be VK_IMAGE_LAYOUT_UNDEFINED (implying that the contents of the
image subresource need not be preserved).
Components: Vulkan
VK-GL-CTS issue: 3575
Affects: dEQP-VK.drm_format_modifiers.export_import.*
Change-Id: I76dbb54c699ed7d34e964de17f71ef01bc9e98a5
Nanley Chery [Wed, 16 Mar 2022 20:07:07 +0000 (13:07 -0700)]
Fix lossy layout transitions in modifier tests
The test performs several layout transitions that use
VK_IMAGE_LAYOUT_UNDEFINED for the initial layout. The spec says that
these transitions cause images to become undefined. The test expects
defined data from these images however. Replace these initial layouts
with layouts that don't cause data loss.
Components: Vulkan
VK-GL-CTS issue: 3575
Affects: dEQP-VK.drm_format_modifiers.export_import.*
Change-Id: I5e57dd197d461fba800d50239803d525c5334ac4
Matthew Netsch [Fri, 1 Apr 2022 16:29:11 +0000 (16:29 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ie7c9018ebfa517b331f6e48ca68abc0cfc4d171d
Matthew Netsch [Fri, 1 Apr 2022 16:01:34 +0000 (16:01 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I31de5eca8b8354c5dbc80545d89e63be98d2509a
Matthew Netsch [Fri, 1 Apr 2022 15:35:04 +0000 (15:35 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I4713730ea2497ef56f0c939a5e73a6bdc0cdcb6e
Ricardo Garcia [Mon, 28 Mar 2022 13:40:57 +0000 (15:40 +0200)]
Fix memory leaks when creating test hierarchy
The lack of a virtual destructor in one of the classes used as part of
some test parameters made createDescriptorValveMutableTests() leak
memory whenever it was called, in the moment the test hierarchy is being
destroyed. The leak will happen not only when running mutable descriptor
test, but when the binding_model test group needs to be generated for
any reason, including running tests in adjacent groups.
Hence, the change has no specific list of affected tests. At the same
time, no test result should be affected by the change.
Components: Vulkan
VK-GL-CTS issue: 3583
Change-Id: I7e847b5927359cef27f9992cd53991dd1a7cb781
Ricardo Garcia [Thu, 17 Mar 2022 08:41:32 +0000 (09:41 +0100)]
Use proper image tiling in synchronization test support checks
Some test variants use LINEAR instead of OPTIMAL tiling and the proper
tiling mode features need to be checked.
Affected tests:
dEQP-VK.synchronization.*
Components: Vulkan
VK-GL-CTS issue: 3572
Change-Id: I16042ace7fb3a2f93b1503e539a5bbe59e03ae14
Matthew Netsch [Thu, 31 Mar 2022 19:30:35 +0000 (12:30 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I5e73a149353915a09697633abab737ee8a38fdca
Matthew Netsch [Thu, 31 Mar 2022 17:26:55 +0000 (17:26 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I4624140325b398fc901142f54425375b5ffa3d66
Matthew Netsch [Thu, 31 Mar 2022 17:02:52 +0000 (17:02 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: Ibcfcfa0cf5ad247b4c80017ad298d15a5139868f
James Jones [Fri, 27 Aug 2021 23:33:24 +0000 (16:33 -0700)]
modifiers: Use dedicated memory consistently
When a dedicated allocation device memory object
is exported, it must be imported as a dedicated
allocation created with a compatible resource as
well. This change makes the DRM format modifier
tests self-consistent in that regard.
Components: Vulkan
Affected tests: dEQP-VK.drm_format_modifiers.export_import.*
VK-GL-CTS issue: 3544
Change-Id: I93a35180b9a5a1b98e0d4fa1f2934258134cef1b
Matthew Netsch [Mon, 28 Mar 2022 14:15:10 +0000 (14:15 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I5cf16d79906b53790ceb0362d6763ed07ff6462f
Matthew Netsch [Mon, 28 Mar 2022 14:15:02 +0000 (14:15 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I7d9aa638cac5bfb8c73848b5aa1b698f12e170c6
Matthew Netsch [Mon, 28 Mar 2022 14:14:55 +0000 (14:14 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I61b2991c59749bd8fe611add1809f596035a1027
Matthew Netsch [Mon, 28 Mar 2022 14:14:48 +0000 (14:14 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Ie50f49d88d9a088bd86f6a659349557d5ad50cea
Matthew Netsch [Mon, 28 Mar 2022 14:14:33 +0000 (14:14 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: Iefb6b35452197d43db9dfc52b689476d2a81b8dd
Peter Kohaut [Mon, 28 Mar 2022 11:53:49 +0000 (13:53 +0200)]
Fix Zlib depedency
Use newer version of Zlib as older is no longer available to download from the zlib.net page
Components: Framework
Affects:
None
VK-GL-CTS Issue: 3587
Change-Id: Ie166dc897b0d1318c1ae73434bfa19687b579691
Ricardo Garcia [Thu, 17 Mar 2022 11:24:03 +0000 (12:24 +0100)]
Limit number of storage buffers in divide by zero compute test
The test is using 20 storage buffers and not checking if the
implementation supports such a large amount. The aspect being tested
does not need a particular amount of buffers, so the test can be changed
to use just one.
Affected tests:
dEQP-VK.glsl.crash_test.divbyzero_comp
Components: Vulkan
VK-GL-CTS issue: 3560
Change-Id: I4aa89a8cede8706b377563ab369577db667dabdc
Matthew Netsch [Thu, 24 Mar 2022 21:34:07 +0000 (21:34 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ia23e7721a136d2b7617317d11487192ef729d0a2
Matthew Netsch [Thu, 24 Mar 2022 21:07:12 +0000 (21:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ie917d4d8cabd5c0eedb9ca7c935d236a74308f42
Ricardo Garcia [Mon, 14 Mar 2022 16:11:04 +0000 (17:11 +0100)]
Increase tolerance in mat3 determinant compute test
The determinant operation does not have strict precision requirements
and a recent change in Mesa broke this test for RADV. A slight increase
in tolerance fixes it.
Affected tests:
dEQP-VK.glsl.builtin.precision_double.determinant.compute.mat3
VK-GL-CTS issue: 3571
Components: Vulkan
Change-Id: I5185bc4d45d848cbad11798f743ae65fbb798657
Matthew Netsch [Thu, 24 Mar 2022 20:40:15 +0000 (20:40 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ie55187998eab0ae965e731fc98511b86c842704e
Matthew Netsch [Thu, 24 Mar 2022 20:13:05 +0000 (20:13 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I81f233780e77ccfb79e9b1b9d982c9406a9ca268
Matthew Netsch [Thu, 24 Mar 2022 19:49:07 +0000 (19:49 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I8a313ea2aebdd5163a689b2cc31161e5963172a2
Michael Chock [Wed, 2 Mar 2022 17:16:34 +0000 (09:16 -0800)]
Check for visibility in external_memory_host test
The external_memory_host synchronization test uses mapMemory when
validating the contents of the external memory, but does not ensure that
the memory is host-visible. When choosing a memory type for the
host-visible memory, additionally check the HOST_VISIBLE flag.
Affects:
dEQP-VK.memory.external_memory_host.synchronization.synchronization
Components: Vulkan
VK-GL-CTS issue: 3547
Change-Id: I0cff8f42debedd01db1760881a6f5f9481ea39bf
Paul Thomson [Tue, 22 Mar 2022 15:44:32 +0000 (15:44 +0000)]
Update Android CTS files for 2022
Update Android CTS files, including android mustpass test lists.
Components: Android
Change-Id: I24f7bd64ec98877075e259e1e30aa122a0073ce4
Jason Ekstrand [Wed, 16 Mar 2022 22:33:17 +0000 (17:33 -0500)]
Fix dEQP-VK.subgroups.size_control.compute.required_subgroup_size_*_require_full_subgroups
The tests were testing full subgroups with four workgroup sizes:
- Nx1x1
- 1xNx1
- 1x1xN
- getLocalSizes() which returns a maximally large workgroup size
However, the Vulkan spec says:
"If a VkPipelineShaderStageRequiredSubgroupSizeCreateInfo structure
is included in the pNext chain, and flags has the
VK_PIPELINE_SHADER_STAGE_CREATE_REQUIRE_FULL_SUBGROUPS_BIT flag set,
the local workgroup size in the X dimension of the pipeline must be
a multiple of
VkPipelineShaderStageRequiredSubgroupSizeCreateInfo::requiredSubgroupSize
This means that the middle two subgroup sizes are invalid for use with
VK_PIPELINE_SHADER_STAGE_CREATE_REQUIRE_FULL_SUBGROUPS_BIT.
Components: Vulkan
Affects:
- dEQP-VK.subgroups.size_control.compute.required_subgroup_size_max_require_full_subgroups
- dEQP-VK.subgroups.size_control.compute.required_subgroup_size_min_require_full_subgroups
Change-Id: I46f2547e1a50f78cbed6695f96448f463ca57230
Sławomir Cygan [Mon, 7 Mar 2022 19:32:16 +0000 (20:32 +0100)]
Add support for 'alternative' image view min lod calculation
According to ''Image Level(s) Selection" in spec, the image view
minLod value can be used as-is, or floor()-ed.
This change runs verification in affected test twice, once requiring
'preferred' method, falling back to 'alternative' if 'preferred' method fails.
Components: Vulkan
VK-GL-CTS Issue: 3556
Affects: dEQP-VK.texture.*min_lod*
Change-Id: I3af08485dbd99ad8d666c6f19aac3456130c375d
Thomas Spurden [Tue, 15 Feb 2022 11:12:00 +0000 (11:12 +0000)]
Update FBO tests to handle separate depth stencil in ES3
Extends FBO blit tests as they did not have cases for separate depth
stencil at all (as they are ES3 only).
Components: OpenGL
Affects: dEQP-GLES3.functional.fbo.*
Change-Id: Icc6dcd047db3b9c29baed0c5691766fb30242e31
Ricardo Garcia [Wed, 2 Mar 2022 16:04:07 +0000 (17:04 +0100)]
Avoid triangle fans in reinterpolation consistency tests
These causes problems for portability implementations and are not needed
for the test itself. This commit replaces them with triangle strips.
Affected tests:
dEQP-VK.pipeline.multisample_interpolation.reinterpolation_consistency.interpolate_at_centroid
dEQP-VK.pipeline.multisample_interpolation.reinterpolation_consistency.interpolate_at_sample
Components: Vulkan
VK-GL-CTS issue: 3545
Change-Id: I29aae73b8a74795b5297eb546a1d150a61e82c33
Matthew Netsch [Thu, 10 Mar 2022 18:39:28 +0000 (18:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I14d7df956df08612d8b7827ee1fa9306a273af0b
Iván Briano [Tue, 8 Mar 2022 00:51:16 +0000 (16:51 -0800)]
Fix REQUIRE_FULL_SUBGROUPS_BIT tests with SPIR-V 1.6
When using Vulkan with SPIR-V 1.6 shaders, both FULL SUBGROUPS and ALLOW
VARYING flags are already implicitly set.
Components: Vulkan
VK-GL-CTS issue: 3541
Affects:
dEQP-VK.subgroups.size_control.compute.require_full_subgroups*spirv16
Change-Id: Ic8322292967101f0dbe739777625c2666a751fcb
Jason Ekstrand [Sat, 12 Feb 2022 18:24:45 +0000 (12:24 -0600)]
Use the correct resolve mode for dynamic rendering
For color attachments, you're required to use SAMPLE_ZERO for integer
and AVERAGE for non-integer.
Components: Vulkan
Affects: dEQP-VK.dynamic_rendering.suballocation.multisample_resolve.\*
Change-Id: Ia23c96f92d86283bc4094899f9473e2b35cf8490
Matthew Netsch [Thu, 10 Mar 2022 18:12:46 +0000 (18:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I7a6e172719c8bd688e642a70e26dae42731715b1
Matthew Netsch [Thu, 10 Mar 2022 17:47:08 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I2280d6ce320738b91994d4603600c38d5d1ba4ee
Matthew Netsch [Thu, 10 Mar 2022 17:20:41 +0000 (17:20 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: If390df3efc02bff47f240c62e35d23e78c537b4c
Matthew Netsch [Thu, 10 Mar 2022 16:57:32 +0000 (16:57 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I31b3e7ec830aa10aa3c06ef61972a4e9c48dffc2
Matthew Netsch [Thu, 10 Mar 2022 16:34:26 +0000 (16:34 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I010f996f4b726f1f79e9bbe9b9f3e96131021f00
Boris Zanin [Tue, 1 Mar 2022 15:16:12 +0000 (16:16 +0100)]
Disable BC7 mode 8 pattern generation
Due to BC7 is underspecified for mode 8 (LSB=0x00) tests
should avoid testing it. This commit avoids generation
mode 8 BC7 compressed blocks.
Affects tests:
* dEQP-VK.*bc7*
Components: Framework, Vulkan
VK-GL-CTS issue: 3501
Change-Id: I222046f703fbead2bf5c64376defc6481989be24
Charles Johnston [Fri, 25 Feb 2022 17:36:28 +0000 (12:36 -0500)]
Fix unsupported_features test.
The unsupported_features test will always fail when
EXT_pageable_device_local_memory is supported.
This change moves the code that disables pageableDeviceLocalMemory
into if(!enableAllFeatures) where it will function as expected.
Components: Vulkan
Affects: dEQP-VK.api.device_init.create_device_unsupported_features
VK-GL-CTS issue: 3543
Change-Id: If646473de3a3da743d706acbe5fcd2bd39973f1e
Sławomir Cygan [Fri, 25 Feb 2022 10:46:06 +0000 (11:46 +0100)]
Update glslang
Components: Vulkan
VK-GL-CTS Issue: 3536
Affects: dEQP-VK.*
Change-Id: I78e6dd5859b60d3e461e94dcdf32e760b2bc410a
Samuel Iglesias Gonsálvez [Tue, 22 Feb 2022 12:41:47 +0000 (13:41 +0100)]
Remove Cached as it is not needed on compute zero_initialize_workgroup_memory tests
Components: Vulkan
VK-GL-CTS issue: 3533
Affected tests:
dEQP-VK.compute.zero_initialize_workgroup_memory.*
Change-Id: Id966f7804cd25ac739c74f91298244dcfbc6a3e5
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Slawomir Cygan [Fri, 25 Feb 2022 15:55:50 +0000 (16:55 +0100)]
Use correct barriers in dEQP-VK.api.copy_and_blit.core.*no_cab
Use transfer read & transfer stage in barrier before using image as
source in vkCmdCopyImage & vkCmdCopyImage2
Components: Vulkan
Affects: dEQP-VK.api.copy_and_blit.*.resolve_image.*no_cab*
VK-GL-CTS Issue: 3542
Change-Id: I2c0d7971c8dcba1f1c01a902c271ce0556196fef
Matthew Netsch [Thu, 3 Mar 2022 19:53:25 +0000 (11:53 -0800)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I13e284240b66cbaf79b74d2032bb6c5bf682ea5e
Antto Mäkinen [Tue, 15 Feb 2022 14:31:19 +0000 (16:31 +0200)]
Fix checkSupport in compressed texture sampling tests
Compressed texture sampling tests didn't properly check that images
using a compressed format can be created with the extended usage
flags. This commit fixes the check.
VK-GL-CTS issue: 3225
Affected Tests:
dEQP-VK.image.sample_texture.*
Components: Vulkan
Change-Id: I5a4af6ce3d9a351933403bceddb7765ea921901c
Slawomir Cygan [Wed, 23 Feb 2022 15:52:15 +0000 (16:52 +0100)]
Fix multiview dynamic rendering tests to enable dynamicRendering feature
The test uses own, custom VkDevice which is created without enabling
'dynamicRendering' feature - while this feature is used by the test.
The fix is to add VkPhysicalDeviceDynamicRenderingFeatures to the
chain of create infos used for getting and requesting features, so
the feature would be alwyas enabled if supported.
(The support of the feature is checked elsewhere).
Components: Vulkan
VK-GL-CTS Issue 3537
Affects: dEQP-VK.multiview.dynamic_rendering,*
Change-Id: Ibcc9a27e01c5deeff1ef90baf97eee5148244603
Matthew Netsch [Thu, 3 Mar 2022 18:26:20 +0000 (18:26 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ie2d3f521cea9ab73d6646abe1d2f9c66d2c6833e
Antto Mäkinen [Wed, 23 Feb 2022 12:18:08 +0000 (14:18 +0200)]
Fix checkSupport in compressed texture sampling tests
Compressed texture sampling tests didn't properly check that images
using a compressed format can be created with the extended usage
flags. This commit fixes the check.
VK-GL-CTS issue: 3225
Affected Tests:
dEQP-VK.image.sample_texture.*
Components: Vulkan
Change-Id: I1c077d29befac3d1b22c5ac2072518296f721f47
Matthew Netsch [Thu, 3 Mar 2022 18:00:13 +0000 (18:00 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ib6194cc5034a2dada976ef494cf4c23fe997555f
Slawomir Cygan [Wed, 19 Jan 2022 11:51:01 +0000 (12:51 +0100)]
Don't adjust vertext buffer pointer in AS for indirect AS build.
Indirect build test programs offsets into the vertex buffer in the wr-asb
shader. This shader mimics vertex buffer pointer adjustment that is done in
AS build util.
Doing both adjustments (in shader and in AS) would cause out of bounds
accesses.
Authored-by: German, Leonid <leonid.german@intel.com>
Components: Vulkan
VK-GL-CTS Issue: 3540
Affects: dEQP-VK.ray_tracing_pipeline.indirect.build_structure
Change-Id: Iace6cf96d478641f412de3a3d0ec7ab001860f29
Ricardo Garcia [Thu, 17 Feb 2022 10:09:07 +0000 (11:09 +0100)]
Do not require full subgroups when requiring a work group size
Most subgroup tests that require a particular work group size use the
VK_PIPELINE_SHADER_STAGE_CREATE_REQUIRE_FULL_SUBGROUPS_BIT_EXT flag when
creating the shader stage, but that in turn forces the local size in the
X dimension to have certain values as required by the following VUID:
VUID-VkPipelineShaderStageCreateInfo-pNext-02757
There are specific tests to check full subgroups. The flag can be safely
omitted and these other tests should still work.
Affected tests:
dEQP-VK.subgroups.*compute*
Components: Vulkan
VK-GL-CTS issue: 3520
Change-Id: Ic20d07d3a875156f817066d040ddf5813aef311f
Matthew Netsch [Thu, 3 Mar 2022 17:34:09 +0000 (17:34 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I589df8409840b42f6c683dda57616b3ee8359128
Matthew Netsch [Thu, 3 Mar 2022 17:11:01 +0000 (17:11 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I3cf7433d510e0966f4f4d96971519aa849cecda0
Matthew Netsch [Thu, 3 Mar 2022 16:47:59 +0000 (16:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: I8e72cdeaa8eed150a5548dd30871eccb09f31d5c
Max Andersson [Mon, 7 Feb 2022 11:31:13 +0000 (12:31 +0100)]
Mark gl_Position as invariant in invariance tests
Always marks gl_Position as invariant. The reason
for this is that there is no guarantee that it
will be computed in an invariant way otherwise,
which may cause test failures.
Affects:
dEQP-VK.glsl.invariance.*user_defined*
VK-GL-CTS issue: 3493
Change-Id: Ia172664b454182458dbd13146c2d1688ecf4161f
Matthew Netsch [Thu, 24 Feb 2022 22:01:36 +0000 (22:01 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I71dd432beaf2983f9633000068f70a8ffba80bd0
Matthew Netsch [Thu, 24 Feb 2022 21:35:54 +0000 (21:35 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I3195f9f15bfe716204d8908062f62528fd70f580
Matthew Netsch [Thu, 24 Feb 2022 21:09:39 +0000 (21:09 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I37050cfb18cd34bd869b26531623f3b881973a3b
James Fitzpatrick [Wed, 16 Feb 2022 15:23:21 +0000 (15:23 +0000)]
Increase tolerance in multiple interpolation tests
These tests test that if a shader has multiple varyings with different
interpolation modes each varying is interpolated using the correct
interpolation mode.
The test runs a shader with multiple varyings with different
interpolation modes and expects this to be an exact match with an image
produced by a similar shader with a single varying of the same
interpolation mode.
Due to floating point inaccuracies and different rounding, allow a 1
bit tolerance when comparing the images.
Affects: dEQP-VK.draw.*multiple_interpolation.*
Components: vulkan
VK-GL-CTS issue: 3522
Change-Id: Ib4a8ab527644de5e1c36ecd3e627afe5384cc6f6
Matthew Netsch [Thu, 24 Feb 2022 20:13:47 +0000 (12:13 -0800)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: I3e993e882a340347eea3582c1ba4feb3393b58fc
Matthew Netsch [Thu, 24 Feb 2022 19:07:22 +0000 (19:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I3ae2bc92916e5c4e2b525a085ba763d4c4b124d1
Ricardo Garcia [Fri, 11 Feb 2022 09:30:05 +0000 (10:30 +0100)]
Ray tracing: avoid skipping triangles and AABBs at the same time
This is illegal according to the spec.
Removed tests:
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*pipelineskipboth*
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*rayskiptriangles.pipelineskipaabbs*
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*rayskipaabbs.pipelineskiptriangles*
dEQP-VK.ray_tracing_pipeline.builtin.incomingrayflagsext.*rayskipboth*
Components: Vulkan
VK-GL-CTS issue: 3508
Change-Id: Iebc50b4b546abc36b2607eeb7c5cbb900de35fcb
Piers Daniell [Thu, 10 Feb 2022 19:28:26 +0000 (12:28 -0700)]
Fix OOB memory copy in dEQP-VK.image.sample_cubemap.* tests
The copy was reading beyond the end of the vector.
Affects:
dEQP-VK.image.sample_cubemap.write_face_0
Components: Vulkan
VK-GL-CTS issue: 3515
Change-Id: I6629968ce96b25f413d33be99ae693ce69b77421
Samuel Iglesias Gonsálvez [Tue, 8 Feb 2022 13:58:10 +0000 (14:58 +0100)]
Only pass VkImageViewMinLodCreateInfoEXT when minLod is != 0.0f
We avoid to passing VkImageViewMinLodCreateInfoEXT when creating
the image view when the tests are actually not testing this.
Therefore, the drivers that don't support this extension won't
see errors when processing VkImageViewCreateInfo.
Components: Vulkan
VK-GL-CTS issue: 3094
Affected tests:
dEQP-VK.texture.mipmap.*
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Change-Id: I09110ef2e6ebfb6f55c084eda85359ebf5cfa742
Ricardo Garcia [Tue, 8 Feb 2022 15:20:26 +0000 (16:20 +0100)]
Fix uniform subgroup size test
The uniform subgroup size test was requiring the subgroup size to be
uniform across several vkCmdDispatch calls, which is not required by the
spec. Furthermore, both dispatch calls were using different local sizes
in the shader.
In addition, these changes add a missing barrier from compute to host.
Components: Vulkan
VK-GL-CTS issue: 3505
Affected tests:
dEQP-VK.subgroups.multiple_dispatches.uniform_subgroup_size
Change-Id: Icea2479da1793f0b24f6fb8a4dd60d477ef8a775
Piers Daniell [Mon, 14 Feb 2022 16:48:32 +0000 (09:48 -0700)]
Remove Roadmap 2022 requirement
The descriptorBindingUniformBufferUpdateAfterBind feature was
accidently required as part of the Roadmap 2022 in the Vulkan 1.3
release spec. It was subsequently fixed in the spec by
https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/5051
so also need to be removed for the next CTS release.
Affects:
dEQP-VK.api.info.profiles.roadmap_2022
Components: Vulkan
VK-GL-CTS issue: 3519
Change-Id: Id01bab7e5c48945d28b1a7fddeeecfdf7bdc36b2
Alejandro Piñeiro [Wed, 9 Feb 2022 10:54:53 +0000 (11:54 +0100)]
TimeLine semaphores tests should check for the feature
Recently new timeleine semaphores were added, but they were not
checking if time line semaphores are supported.
Affects:
dEQP-VK.api.external.semaphore.opaque_fd.info_timeline
dEQP-VK.api.external.semaphore.sync_fd.info_timeline
Components: Vulkan
VK-GL-CTS issue: 3510
Change-Id: Ic1029d82df6353fe831f0c791e08b7f4ca365b62
Matthew Netsch [Thu, 17 Feb 2022 20:27:22 +0000 (12:27 -0800)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ib56927d23f4d53fd739cd57dde59766e2dd12f5c
James Fitzpatrick [Sun, 6 Feb 2022 10:33:53 +0000 (10:33 +0000)]
Update mandatory features for Vulkan1.3
Vulkan 1.3 only requires
descriptorBindingInlineUniformBlockUpdateAfterBind to be supported if
descriptor indexing is supported.
Vulkan 1.3 also made a number of Vulkan 1.2 features mandatory, so add
these to the mandatory feature check for 1.3 implementations.
Affects:
dEQP-VK.api.info.vulkan1p3.feature_extensions_consistency
dEQP-VK.info.device_mandatory_features
Compontents: vulkan
VK-GL-CTS issue: 3496
Change-Id: I79a6df710b7770171b7a1128cdec30fa30d6a456
Matthew Netsch [Thu, 17 Feb 2022 19:48:55 +0000 (19:48 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I67ca22b6f7d5e71d139482417f8ac5f30f6a1f81
Connor Abbott [Fri, 21 Jan 2022 17:28:59 +0000 (18:28 +0100)]
Always use workaround for blitting to/from BC6H
Qualcomm's implementation of cubic filtering can give large inaccuracies
when texel values within the 4x4 grid are very big and very small,
especially if the values around the "edge" are much bigger then the
values at the center. This can happen with randomly-generated blocks for
floating-point compressed formats like BC6H. There was already a
workaround for similar issues seen blitting to e5b9g9r9, extend it to
all formats to fix this.
Components: Vulkan
VK-GL-CTS Issue: 3450
Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.color.2d.bc6h_ufloat_block.*
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.color.2d.*.bc6h_ufloat_block.*
Change-Id: I3445ecba2ebc9e4e52e26111a109eaf79f611bd8
Will Lueking [Wed, 9 Feb 2022 20:34:10 +0000 (12:34 -0800)]
Fix build error on gcc 4.8
Changes a copy initializtion to a direct initialization.
GCC 4.8 complains about the copy initialization of
const tcu::StringTemplate meshTemplate = meshTemplateStr.str();
but not the direct initialization of
const tcu::StringTemplate taskDataDecl(taskDataDeclTemplate);
Replacing the copy initialization with the direct initialization fixes
the build issue.
Components: Vulkan
Affects: dEQP-VK.mesh_shader.nv.*
VK-GL-CTS issue: 3511
Change-Id: I9de57bc28e56da8288894e32c938fea0cd165927
Ricardo Garcia [Wed, 9 Feb 2022 10:09:33 +0000 (11:09 +0100)]
Fix load_store_op_none dynamic rendering validation error
The test case below was using a multisample color attachment with
integer format and specified VK_RESOLVE_MODE_AVERAGE_BIT as the resolve
mode, which is illegal. The purpose of the test is different, and the
resolve mode is not relevant, so it can be switched to one of the legal
values.
Affected tests:
dEQP-VK.dynamic_rendering.suballocation.load_store_op_none.color_load_op_none_store_op_none_resolve
Components: Vulkan
VK-GL-CTS issue: 3509
Change-Id: I42cf959f67d80694aee37c19c966ab037609d44f
Lionel Landwerlin [Sun, 30 Jan 2022 22:29:43 +0000 (00:29 +0200)]
Fix dynamic rendering multisampling test layout transition operation
Those tests are failing on Intel/Mesa because they're not
transitioning the right mip level from COLOR_ATTACHMENT to TRANFER_DST
layouts.
Component: Vulkan
Affects: dEQP-VK.dynamic_rendering.*.multisample_resolve.*resolve_level*
VK-GL-CTS issue: 3482
Change-Id: I6dcdf6a9a72d96c559acd28f0114b308267d3cb8
Jason Ekstrand [Fri, 11 Feb 2022 00:20:08 +0000 (18:20 -0600)]
Use the correct stencilInitialLayout for unused resolve targets with separate stencil
The initial stencil layout was always being specified as UNDEFINED even
though, in the unused resolve target case, we clear it with
vkCmdClearDepthStencilImage() and need an initial layout of
TRANSFER_SRC_OPTIMAL.
Components: Vulkan
Affects: dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.*
Change-Id: Id0e0dcd2066d02758875a786c5634b23c893f7a2
Matthew Netsch [Thu, 17 Feb 2022 19:22:09 +0000 (19:22 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: If3af09eda7b56dbfa484de49f06401ff53fda906
Ricardo Garcia [Thu, 10 Feb 2022 11:22:55 +0000 (12:22 +0100)]
Avoid invalid reportIntersectionEXT hit kinds in subroup tests
Some subgroup ray tracing tests were using invalid values when calling the
reportIntersectionEXT function.
Affected tests:
dEQP-VK.subgroups.*ray_tracing*
Components: Vulkan
VK-GL-CTS issue: 3513
Change-Id: I96310c32e1e5b4fde157570f0a3131d61f5a125c
Matthew Netsch [Thu, 17 Feb 2022 18:55:27 +0000 (18:55 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Iba2783e1e1e2bcb839c075dcf4d2b1dbcfbdf43f
Mika Väinölä [Thu, 3 Feb 2022 08:15:19 +0000 (10:15 +0200)]
Replace bitwise or with logical
This fixes a Clang 14 bitwise-instead-of-logical warning.
Affects:
dEQP-VK.robustness.robustness2.*
dEQP-VK.robustness.image_robustness.*
Components: Vulkan
VK-GL-CTS issue: 3492
Change-Id: I803ed494ed218b404a2285ed891d41170d66abfe
Matthew Netsch [Thu, 17 Feb 2022 18:32:10 +0000 (18:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6
Change-Id: I4adbb2e30086c26c8ad3312a6086e267c2840d42
Ricardo Garcia [Thu, 10 Feb 2022 10:49:21 +0000 (11:49 +0100)]
Avoid invalid reportIntersectionEXT hit kinds in mem guarantee tests
Only values in the [0, 127] range are allowed with reportIntersectionEXT.
Affected tests:
dEQP-VK.ray_tracing_pipeline.memguarantee.*
Components: Vulkan
VK-GL-CTS issue: 3513
Change-Id: I54669b5b7e2c0f696bbbf3e5a477b1533e4f4488
Matthew Netsch [Thu, 17 Feb 2022 18:08:53 +0000 (18:08 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5
Change-Id: Ib8646342ae0c6c9df3c7f2fa78c24643c10d5e96
Ilkka Saarelainen [Wed, 2 Feb 2022 13:37:18 +0000 (15:37 +0200)]
Fix validation errors in compute tests
This CL fixes various validation errors in compute tests.
Affects:
dEQP-VK.compute.basic.image_barrier*
dEQP-VK.compute.cooperative_matrix.*
Components: Vulkan
VK-GL-CTS Issue: 3451
Change-Id: I33037a50d10a5cf8098c33b55ba42900f97f0019
Alejandro Piñeiro [Tue, 8 Feb 2022 10:56:32 +0000 (11:56 +0100)]
Increase error threshold for blitting non-nearest compressed formats
The error threshold for linear filtering with compressed formats is
too low, making some ASTC tests failingn with some drivers.
Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.color.2d.*.*.general_general_linear
Components: Vulkan
VK-GL-CTS issue: 3504
Change-Id: I917c3e5e6a0af26c59b004ac610378f4842cf1f7
Lionel Landwerlin [Mon, 31 Jan 2022 08:19:35 +0000 (10:19 +0200)]
Accurate reason for fragment shading rate test not supported
Components: Vulkan
Affects: dEQP-VK.fragment_shading_rate.*.attachment_rate.*
VK-GL-CTS issue: 3483
Change-Id: I9aa869f48300dbb387997998fe41f3a6d9e2c207
Piers Daniell [Mon, 9 Aug 2021 15:50:12 +0000 (09:50 -0600)]
VK_EXT_pageable_device_local_memory test coverage
This CL adds basic support for the pageableDeviceLocalMemory feature. Normally
CTS enables all known features by default, but in this case we don't
enable pageableDeviceLocalMemory by default and just to targetting
testing with a variant of the extisting dEQP-VK.memory.allocation.*
tests.
This CL also adds coverage for vkSetDeviceMemoryPriorityEXT() by
extending the existing static VK_EXT_memory_priority test with a
dynamic variant that changes the memory priority after it has
been allocated.
New tests:
dEQP-VK.memory.pageable_allocation.*
dEQP-VK.memory.binding.priority_dynamic.*
Affects:
dEQP-VK.memory.allocation.*
dEQP-VK.memory.device_group_allocation.*
dEQP-VK.memory.binding.*
Components: Vulkan
VK-GL-CTS issue: 3060
Change-Id: Idb4e63556c8807ba2f636c90dab397f4d116223d
(cherry picked from commit
f8b56ca1effc62c885bec677ba0ee55e2e43142a)