platform/upstream/freerdp.git
3 years agoAdded -DDEFINE_NO_DEPRECATED CMake option 2.3.1
akallabeth [Mon, 1 Mar 2021 09:29:33 +0000 (10:29 +0100)]
Added -DDEFINE_NO_DEPRECATED CMake option

With that option all symbols marked deprecated are no longer
compiled. This helps testing compatibility of external apps.

3 years agoAdded changelog.
akallabeth [Sat, 27 Feb 2021 07:40:16 +0000 (08:40 +0100)]
Added changelog.

3 years agoFixed a leak on mouse cursor updates
akallabeth [Sat, 27 Feb 2021 16:37:35 +0000 (17:37 +0100)]
Fixed a leak on mouse cursor updates

3 years agoReverted connectErrorCode removal
akallabeth [Sat, 27 Feb 2021 07:35:33 +0000 (08:35 +0100)]
Reverted connectErrorCode removal

Reverted changes from e4b30a5cb6100a8ea4f320b829c9c5712ed4a783
removing the symbol/define, keep the changes for the clients.
Mark as deprecated

3 years agoAdded explicit warnings for experimental/unstable features
akallabeth [Sat, 27 Feb 2021 07:30:01 +0000 (08:30 +0100)]
Added explicit warnings for experimental/unstable features

3 years agoAdded compatibility define
akallabeth [Sat, 27 Feb 2021 07:29:46 +0000 (08:29 +0100)]
Added compatibility define

3 years agoUpdated changelog 2.3.0
akallabeth [Wed, 24 Feb 2021 06:24:07 +0000 (07:24 +0100)]
Updated changelog

3 years agoCompatibility reordering of new symbols in struct
akallabeth [Wed, 24 Feb 2021 06:23:54 +0000 (07:23 +0100)]
Compatibility reordering of new symbols in struct

3 years agoForce enable wayland in ci and nightly
akallabeth [Sat, 23 Jan 2021 09:01:48 +0000 (10:01 +0100)]
Force enable wayland in ci and nightly

(cherry picked from commit ce396a9aff3b63edd76a92e71d96c64d1d237fb2)

3 years agoci [codeql]: run apt update before install
Bernhard Miklautz [Fri, 4 Dec 2020 13:21:12 +0000 (14:21 +0100)]
ci [codeql]: run apt update before install

(cherry picked from commit 7bec71a63265bd8fd50e249bc733697f469e45cd)

3 years agoCreate codeql-analysis.yml
akallabeth [Mon, 23 Nov 2020 08:36:21 +0000 (09:36 +0100)]
Create codeql-analysis.yml

(cherry picked from commit 2b676bf1e7de111cd63c7f77cbbbf1d299b3a8fd)

3 years agoFixed smartcard crash on error return (invalid length)
akallabeth [Thu, 18 Feb 2021 15:48:09 +0000 (16:48 +0100)]
Fixed smartcard crash on error return (invalid length)

3 years agoFixed #6821: _stricmp does not like NULL strings
Armin Novak [Wed, 17 Feb 2021 15:45:56 +0000 (16:45 +0100)]
Fixed #6821: _stricmp does not like NULL strings

(cherry picked from commit 7b211e525892f056c18c827b9f56ccc24d6ae5f3)

3 years agoUpdated windows time zones 2021-02-11
Armin Novak [Thu, 11 Feb 2021 16:13:28 +0000 (17:13 +0100)]
Updated windows time zones 2021-02-11

(cherry picked from commit 2e5c09f20984654b3cc9a5ec32683dcff0b25df6)

3 years ago2.0 compatibility for rdpinput flag debug function
akallabeth [Tue, 16 Feb 2021 16:05:27 +0000 (17:05 +0100)]
2.0 compatibility for rdpinput flag debug function

3 years agoFixed #6712: Use window size from settings
akallabeth [Fri, 12 Feb 2021 13:18:24 +0000 (14:18 +0100)]
Fixed #6712: Use window size from settings

The xfc->window might be NULL (remote app, ...)

(cherry picked from commit 6ecd440658eee7dbd0a07c1366946046746d0b8d)

3 years agoMinor typo fix
Fabio Fantoni [Sun, 14 Feb 2021 17:35:42 +0000 (18:35 +0100)]
Minor typo fix

From debian packages patch done by Mike Gabriel
<mike.gabriel@das-netzwerkteam.de>

(cherry picked from commit 5c408e080e66c917ec4aeaaadf324b9665ba992a)

3 years agofreerdp-client: don't enable vmconnect mode based on PCB field presence in .RDP file
Marc-André Moreau [Thu, 11 Feb 2021 20:05:53 +0000 (15:05 -0500)]
freerdp-client: don't enable vmconnect mode based on PCB field presence in .RDP file

(cherry picked from commit 4e14e7d41e10f39de9a0fafe53461e9fb5ebc765)

3 years agoFixed formatting and source/destination length use
akallabeth [Fri, 12 Feb 2021 07:30:01 +0000 (08:30 +0100)]
Fixed formatting and source/destination length use

(cherry picked from commit f0ba8d7fb9c21b1134a3089eda661852b2861c0e)

3 years agolibfreerdp: core: deep copy ServerCertificate
mingfang [Fri, 12 Feb 2021 02:27:24 +0000 (10:27 +0800)]
libfreerdp: core: deep copy ServerCertificate

(cherry picked from commit b0783771055f55dccde85f8f5e50954ffca93383)

3 years agoCompatibility commit for RDPEI API
Armin Novak [Thu, 11 Feb 2021 11:43:05 +0000 (12:43 +0100)]
Compatibility commit for RDPEI API

3 years agoFixed issue with backported websockets support
Armin Novak [Thu, 11 Feb 2021 11:31:54 +0000 (12:31 +0100)]
Fixed issue with backported websockets support

3 years agoUpdated changelog
Armin Novak [Thu, 11 Feb 2021 08:15:18 +0000 (09:15 +0100)]
Updated changelog

3 years agoclients: Use the correct wheel rotation value
Pascal Nowack [Wed, 10 Feb 2021 17:50:51 +0000 (18:50 +0100)]
clients: Use the correct wheel rotation value

For the negative scrolling direction, RDP uses the two's complement,
instead of the positive wheel value with the negative flag.
xfreerdp currently uses the positive wheel value in addition to the
negative flag, which results in a wrong wheel value on the server side
(136 instead of 120).

Fix this, by using the correct wheel rotation value, which is in the
two's complement.

(cherry picked from commit 1087a5e1a64cb591efb44b67cfa5a97a7f40aaf7)

3 years agoFixed #6801: Delay sending of resolution change
akallabeth [Wed, 10 Feb 2021 14:32:07 +0000 (15:32 +0100)]
Fixed #6801: Delay sending of resolution change

Changed the logic of the disp channel to wait for 800ms after a
ConfigureNotify before sending the new resolution.
The problem fixed with this patch is the following:
1.  Resize the window with the mouse
2.  ConfigureNotify triggers a resize notification
3.  The server resizes to the desired resolution
3a. More ConfigureNotify events are generated
4.  The local window resize to the new resolution triggers another
    ConfigureNotify

a. Depending on the timing (sending is already rate limited) the
   events from 3a and 4 will make the size of the window jump
b. Very fast resizing will pick a random resolution from the
   sequence of ConfigureNotify events as the final resolution

(cherry picked from commit d3ed42a7994975098973c5f29f1ab98f7bdac2bf)

3 years agoAdded ConnectionStateChangeEvent for clients
Armin Novak [Mon, 8 Feb 2021 09:41:34 +0000 (10:41 +0100)]
Added ConnectionStateChangeEvent for clients

Clients can now subscribe to connection state change events to
prevend data from being transmitted on sessions being redirected.

(cherry picked from commit 27f6df97783c6f18377f91c9e229cce2b7d6c694)

3 years agordg websocket support
Michael Saxl [Mon, 25 Jan 2021 15:20:18 +0000 (16:20 +0100)]
rdg websocket support

(cherry picked from commit 99489318f4832dbeca2130ae2c45f26c4e9a85bd)

3 years agoFixed a ConvertToUnicode issue and added a unit test
akallabeth [Tue, 9 Feb 2021 14:48:20 +0000 (15:48 +0100)]
Fixed a ConvertToUnicode issue and added a unit test

(cherry picked from commit e15684cb1477e2fac6170835ac9132443dc79970)

3 years agoAlways return data on SCardGetStatusChange
Armin Novak [Mon, 8 Feb 2021 15:42:40 +0000 (16:42 +0100)]
Always return data on SCardGetStatusChange

If the call fails just return empty data for each reader.

(cherry picked from commit f0317a5e0fdc31f7f5f014e90e2b349fc7824bf2)

3 years agoFixed issue with GetAttr where the result buffer was not allocated
akallabeth [Sun, 7 Feb 2021 17:48:59 +0000 (18:48 +0100)]
Fixed issue with GetAttr where the result buffer was not allocated

(cherry picked from commit 38ae006db981c5bb031d5fbd957d99d2fef5c14a)

3 years agoFixed GetAttrib return length
akallabeth [Sun, 7 Feb 2021 17:13:18 +0000 (18:13 +0100)]
Fixed GetAttrib return length

(cherry picked from commit 5342f351ea441c1c3c1b34af216d583051e84fdc)

3 years agoFixed smartcard_unpack_reader_state, allow empty names
akallabeth [Sun, 7 Feb 2021 11:21:44 +0000 (12:21 +0100)]
Fixed smartcard_unpack_reader_state, allow empty names

(cherry picked from commit 2757b5d6c08e05154d5968c2fc04f7b15a7ea3d3)

3 years agoFixed SCardTransmit return
akallabeth [Sat, 6 Feb 2021 15:59:51 +0000 (16:59 +0100)]
Fixed SCardTransmit return

(cherry picked from commit ad4694f7a02cb9295795b6c5d07fa9bdb1614d2b)

3 years agoFixed SCardState wrapper
akallabeth [Sat, 6 Feb 2021 14:55:21 +0000 (15:55 +0100)]
Fixed SCardState wrapper

(cherry picked from commit e5a1dae34f018d45049304a10a22658d853b1cc0)

3 years agoUnified smartcard call data structs
akallabeth [Sat, 6 Feb 2021 14:22:38 +0000 (15:22 +0100)]
Unified smartcard call data structs

(cherry picked from commit 2674d3b2f3700e0b4bc859d41b4506d8c28d2d95)

3 years agoUnified smartcard handle converstion
akallabeth [Sat, 6 Feb 2021 14:08:57 +0000 (15:08 +0100)]
Unified smartcard handle converstion

(cherry picked from commit 69d33da061ff15d2c016de1569b54ca68a578f05)

3 years agoFixed various return values in case of result != SCARD_S_SUCCESS
akallabeth [Sat, 6 Feb 2021 13:28:28 +0000 (14:28 +0100)]
Fixed various return values in case of result != SCARD_S_SUCCESS

(cherry picked from commit e32305dd3a09312cc04e428bb7d2cb5395be1fdd)

3 years agoFixed GetAttrib call
akallabeth [Sat, 6 Feb 2021 11:40:17 +0000 (12:40 +0100)]
Fixed GetAttrib call

(cherry picked from commit 99d228251c73c3c33bc1119ceb7d084f77d80076)

3 years agorefactored smartcard allocations
akallabeth [Sat, 6 Feb 2021 11:21:03 +0000 (12:21 +0100)]
refactored smartcard allocations

(cherry picked from commit 27ba319c89ab46431b0df1b9ad41daf68b7eae6f)

3 years agoFixed SCard debug WCHAR string lengths
akallabeth [Fri, 5 Feb 2021 16:12:52 +0000 (17:12 +0100)]
Fixed SCard debug WCHAR string lengths

(cherry picked from commit a9409221d073e8665a1f27da764d9d042f557e0f)

3 years agoFixed double free in PCSC_SCardGetAttrib_FriendlyName
akallabeth [Fri, 5 Feb 2021 16:11:58 +0000 (17:11 +0100)]
Fixed double free in PCSC_SCardGetAttrib_FriendlyName

(cherry picked from commit c1575fa99aa9fae335cf6b0f4107c0e12aa7d931)

3 years agoReordered UWAC events to keep compatibility
Armin Novak [Fri, 5 Feb 2021 12:31:46 +0000 (13:31 +0100)]
Reordered UWAC events to keep compatibility

3 years agoChangelog for 2.3.0
Armin Novak [Fri, 5 Feb 2021 08:55:50 +0000 (09:55 +0100)]
Changelog for 2.3.0

3 years agoCompatibility changes
Armin Novak [Fri, 5 Feb 2021 11:42:20 +0000 (12:42 +0100)]
Compatibility changes

Renamed symbols and added wrappers to keep API compatible with
2.0 branch.

3 years agoIncreased version to 2.3.0
Armin Novak [Fri, 5 Feb 2021 10:13:11 +0000 (11:13 +0100)]
Increased version to 2.3.0

3 years agoDo not recreate already initialized codecs
Armin Novak [Fri, 5 Feb 2021 10:06:23 +0000 (11:06 +0100)]
Do not recreate already initialized codecs

GFX and SurfaceBits commands share a common codec backend.
Recreating all codec context on GFX initialization will break
clients that are decoding SurfaceBits codec while having the GFX
channel initialized.

(cherry picked from commit 91a6ac131370c48a742b8bcc58ad188bb7ed60f8)

3 years agoFixed default return for DrawOrderInfo
akallabeth [Thu, 28 Jan 2021 13:08:35 +0000 (14:08 +0100)]
Fixed default return for DrawOrderInfo

(cherry picked from commit 4587ef976c07a06f9fe751e2857bddea2a6e9a69)

3 years agoFix length return for SCARD_ATTR_VENDOR_NAME
akallabeth [Wed, 27 Jan 2021 22:25:57 +0000 (23:25 +0100)]
Fix length return for SCARD_ATTR_VENDOR_NAME

(cherry picked from commit cf2d26dbbd7491d2039c6bb13cd4cc0130f50cd6)

3 years agoFixed PCSC_SCardGetAttrib wrapper
Armin Novak [Wed, 27 Jan 2021 14:07:44 +0000 (15:07 +0100)]
Fixed PCSC_SCardGetAttrib wrapper

(cherry picked from commit 17d8267de70719d1ac7357bc71d177bf36c6ad86)

3 years agoDereference ppbAttr as argument for SCardGetAttrib
akallabeth [Tue, 26 Jan 2021 16:22:42 +0000 (17:22 +0100)]
Dereference ppbAttr as argument for SCardGetAttrib

(cherry picked from commit 1efcd605e02bdbe54121d9f1da85d6874c26f59e)

3 years agoAdded option to remap scancodes
Armin Novak [Wed, 28 Oct 2020 11:22:48 +0000 (12:22 +0100)]
Added option to remap scancodes

(cherry picked from commit d7bf6553c558db64e5e3108b08f8ee1d394d1393)

3 years agoCompatibility commit
Armin Novak [Fri, 5 Feb 2021 08:39:07 +0000 (09:39 +0100)]
Compatibility commit

* Adds compatibility defines for 2.2.0
* Reorders some newe fields in structs to improve compatibility

3 years agoprogressive: fix multiple regions in one gfx frame.
Vic Lee [Thu, 4 Feb 2021 05:01:38 +0000 (13:01 +0800)]
progressive: fix multiple regions in one gfx frame.

(cherry picked from commit 7f94095a0670f6d0bc19021e6e1439cf934edf52)

3 years agolibuwac: Fix code format
0140454 [Thu, 4 Feb 2021 13:51:23 +0000 (21:51 +0800)]
libuwac: Fix code format

(cherry picked from commit 706b6ddbb12a22986a1a86171d4c19775f4a5d6f)

3 years agoSync numlock, capslock state in Wayland
0140454 [Thu, 4 Feb 2021 12:24:49 +0000 (20:24 +0800)]
Sync numlock, capslock state in Wayland

(cherry picked from commit b56a3691ca35a7f55e31998c55a40a9da9d0d745)

3 years agolibuwac: Add UwacKeyboardModifiersEvent
0140454 [Thu, 4 Feb 2021 12:23:02 +0000 (20:23 +0800)]
libuwac: Add UwacKeyboardModifiersEvent

(cherry picked from commit b4ffc2f8b3792f9781559ebe4a094511c3b46170)

3 years agoDont' commit surface in configure handler
0140454 [Sat, 30 Jan 2021 13:39:07 +0000 (21:39 +0800)]
Dont' commit surface in configure handler

(cherry picked from commit 256b94450cc921560dd9842fadc45edbeb85e760)

3 years agoProcess close event
0140454 [Sat, 30 Jan 2021 13:38:03 +0000 (21:38 +0800)]
Process close event

(cherry picked from commit f61744a062255eaaaaec21c9192666f55559e26e)

3 years agoAdded wayland discrete axis events for mouse wheel
akallabeth [Wed, 27 Jan 2021 18:42:32 +0000 (19:42 +0100)]
Added wayland discrete axis events for mouse wheel

the discrete axis event gives changes in steps just like the
xfreerdp version uses. This way scrolling can be implemented
consistent with the behaviour of xfreerdp

(cherry picked from commit 2cce37a82a08b0a7c24302a6819371218dea1ec6)

3 years agocore: Enable network auto detection by default
Martin Fleisz [Thu, 4 Feb 2021 12:10:58 +0000 (13:10 +0100)]
core: Enable network auto detection by default

(cherry picked from commit ce3edb00ef7471fc80b1991d126342aedc2d4c93)

3 years agocore: Remove connection type manipulation in gcc_write_client_core_data
Martin Fleisz [Thu, 4 Feb 2021 08:54:48 +0000 (09:54 +0100)]
core: Remove connection type manipulation in gcc_write_client_core_data

Removes the changes to connection type in gcc_write_client_core_data and
adds some checks if network detection is enabled when receiving network
detection requests.

(cherry picked from commit 43825e364e9580eab08cae84dfd8021d16828730)

3 years agolibfreerdp: core: add checks in gcc_write_client_data_blocks
kubistika [Thu, 21 Jan 2021 13:24:38 +0000 (15:24 +0200)]
libfreerdp: core: add checks in gcc_write_client_data_blocks

(cherry picked from commit afa213b5e572416fca6049c748cda14d38f3b262)

3 years agogateway: Fix consent/service message in legacy gateway code
Martin Fleisz [Wed, 27 Jan 2021 08:44:19 +0000 (09:44 +0100)]
gateway: Fix consent/service message in legacy gateway code

(cherry picked from commit 00d56429211c2b1275e1122450e5bb87094c9678)

3 years agoFixed drive hotplug path comparison.
Armin Novak [Wed, 27 Jan 2021 08:25:26 +0000 (09:25 +0100)]
Fixed drive hotplug path comparison.

(cherry picked from commit c7bf33aad04822eb6400459114d405031edb376a)

3 years agoAdded OrderInfo callback for primary, seconardy and altsec orders
akallabeth [Tue, 26 Jan 2021 14:25:06 +0000 (15:25 +0100)]
Added OrderInfo callback for primary, seconardy and altsec orders

This allows gathering statistics about which orders have been
received

(cherry picked from commit f45f92f7bb4b560d1fedd723a353d8c1d0c73fbd)

3 years agoFix key repeat in Wayland
0140454 [Tue, 26 Jan 2021 17:19:15 +0000 (01:19 +0800)]
Fix key repeat in Wayland

(cherry picked from commit 712c5fee97d9b007b902bee63b7b7a4971bfbe6b)

3 years agoFilter out duplicate ClientFormatList announcements
akallabeth [Thu, 26 Nov 2020 16:38:04 +0000 (17:38 +0100)]
Filter out duplicate ClientFormatList announcements

(cherry picked from commit a51f4ccaaa8d4a2232725dc555827705ea8f0429)

3 years agoCommand-line option to choose an X selection.
Simon Tatham [Wed, 18 Mar 2020 20:59:12 +0000 (20:59 +0000)]
Command-line option to choose an X selection.

I personally find it more convenient to have pasted data written to
the X11 PRIMARY selection, so that I can paste it with a fast middle-
button click, than to write to CLIPBOARD which typically needs a key
sequence or menu action.

This commit adds a command-line option to let me express that
preference: now I can say "/clipboard:use-selection:PRIMARY" on the
command line, which not only enables clipboard transfer but also says
which X selection I want it to talk to. The previous options
"+clipboard" and "-clipboard" are also still supported.

(cherry picked from commit 64948b96c4c4640078ce563b165a907251fd6f20)

3 years agowinpr/utils: allow COMMAND_LINE_VALUE_{OPTIONAL,BOOL} to coexist.
Simon Tatham [Wed, 18 Mar 2020 21:00:06 +0000 (21:00 +0000)]
winpr/utils: allow COMMAND_LINE_VALUE_{OPTIONAL,BOOL} to coexist.

Now you can give an option the combination of flags
COMMAND_LINE_VALUE_OPTIONAL and COMMAND_LINE_VALUE_BOOL. If you do,
then all three of the syntaxes +foo, -foo and /foo:value are allowed
at once, and the receiving code can tell the difference because the
Value field is set to BoolValueTrue, BoolValueFalse or a valid char
pointer.

(cherry picked from commit 22c6b375d4ae9bf9dcac74d3360d0042673f1353)

3 years agoxf_cliprdr: fill in support for TIMESTAMP requests.
Simon Tatham [Fri, 13 Mar 2020 17:59:22 +0000 (17:59 +0000)]
xf_cliprdr: fill in support for TIMESTAMP requests.

A selection owner is supposed to respond to a request for the
selection target TIMESTAMP by providing the X server time at which the
selection was written. There was a /* TODO */ comment in xf_cliprdr
where the code to do that should have been.

The absence of this can cause a problem when pasting into some X
clients. xtightvncviewer, in particular, will give up the attempt to
read from the clipboard at all if it doesn't get a satisfactory
response to the initial TIMESTAMP request - and the non-answer zero
value "CurrentTime" counts as unsatisfactory. It won't be happy with
anything short of a real X server time value.

(Checking the VNC source code, that's because it reads both PRIMARY
and CLIPBOARD and picks the one with the later timestamp. So it does
depend on the timestamps existing.)

When you're writing to the selection in response to a normal X event
like a mouse click or keyboard action, you get the selection timestamp
by copying the time field out of that X event. Here, we're doing it on
our own initiative, so we have to _request_ the X server time. There
isn't a GetServerTime request in the X protocol, so I work around it
by setting a property on our own window, and waiting for a
PropertyNotify event to come back telling me it's been done - which
will have a timestamp we can use.

(cherry picked from commit fcabbc9707e23b94d7e82021e997578fb20c9313)

3 years agoFixed #6696: Implement HandshakeEx in windows client
akallabeth [Tue, 19 Jan 2021 07:44:14 +0000 (08:44 +0100)]
Fixed #6696: Implement HandshakeEx in windows client

Special thanks to @byteboon for bisecting the issue

(cherry picked from commit fc20299c22735beb64afe33b958c41506f092c72)

3 years agoFixed call to GetKeyboardLayout
akallabeth [Tue, 15 Dec 2020 08:59:52 +0000 (09:59 +0100)]
Fixed call to GetKeyboardLayout

(cherry picked from commit 8b8016ec21509fda5dfd182cb1d1fb186d272d7a)

3 years agoFixed naming of FILEDESCRIPTORW
akallabeth [Thu, 17 Sep 2020 13:21:45 +0000 (15:21 +0200)]
Fixed naming of FILEDESCRIPTORW

(cherry picked from commit a3bf25e9239b1fb970e65901356a970531bf067a)

3 years agoFixed support for huge files in clipboard
akallabeth [Tue, 24 Nov 2020 10:00:13 +0000 (11:00 +0100)]
Fixed support for huge files in clipboard

(cherry picked from commit f3dad4106a62cf29db0685221cd90b751e3ac2b1)

3 years agoFixed NtStatus2Tag return.
Armin Novak [Fri, 23 Oct 2020 07:26:11 +0000 (09:26 +0200)]
Fixed NtStatus2Tag return.

(cherry picked from commit 11ca443aafc39ebc61c24f19577655e0ffcaa189)

3 years agoAdded backward compatibility define
Armin Novak [Wed, 14 Oct 2020 07:19:57 +0000 (09:19 +0200)]
Added backward compatibility define

(cherry picked from commit a22f264189b112ac1b334ef33cd2a2615b0b8140)

3 years agoUpdated FD_FLAGS definition.
Armin Novak [Wed, 14 Oct 2020 06:55:28 +0000 (08:55 +0200)]
Updated FD_FLAGS definition.

(cherry picked from commit ef1c8a3b506a2e039faa92b435d326ca3f29385a)

3 years agoRefactored RDG chunked data struct
akallabeth [Mon, 25 Jan 2021 07:18:19 +0000 (08:18 +0100)]
Refactored RDG chunked data struct

(cherry picked from commit eafb4b8d5f4dd081606b4e6a69d92089993aae4b)

3 years agoFixed RDP gateway types and use after free
akallabeth [Mon, 25 Jan 2021 07:07:43 +0000 (08:07 +0100)]
Fixed RDP gateway types and use after free

(cherry picked from commit 8c78e6742569936cb2bff59649888c93f3f3437f)

3 years agoImplement chunked encoding for RDG_OUT_DATA
akarl10 [Fri, 22 Jan 2021 09:53:00 +0000 (10:53 +0100)]
Implement chunked encoding for RDG_OUT_DATA

(cherry picked from commit cfb1a878a3b1c2c469c3d15e135f21f388c177b8)

3 years agofree previous value of password field from `freerdp_assistance_parse_file_buffer`
odednoam [Sat, 7 Nov 2020 21:20:56 +0000 (23:20 +0200)]
free previous value of password field from `freerdp_assistance_parse_file_buffer`

(cherry picked from commit 73dd40275fca9d009bcb07d4a734af146578f414)

3 years agoFixed bug with assistance buffer parsing: `freerdp_assistance_parse_file_buffer`...
odednoam [Thu, 5 Nov 2020 10:58:47 +0000 (12:58 +0200)]
Fixed bug with assistance buffer parsing: `freerdp_assistance_parse_file_buffer` may be called directly, not necessarily from `freerdp_assistance_parse_file`, so password should be saved to the `rdpAssistanceFile` in `freerdp_assistance_parse_file_buffer`.

(cherry picked from commit 0dc9b18cdea8dce172fdc34be067b07a846594d0)

3 years agoConservative keyboard state sync, refactored input API
akallabeth [Mon, 29 Jun 2020 06:39:09 +0000 (08:39 +0200)]
Conservative keyboard state sync, refactored input API

(cherry picked from commit b679f3a0ebbbedf039e735523087c58e3b3920e2)

3 years agoFixed display channel anounce race
akallabeth [Fri, 13 Nov 2020 17:07:35 +0000 (18:07 +0100)]
Fixed display channel anounce race

* The display resolution change message was prone to a race condition
* Check for actual fullscreen state instead of settings
* Assume 75dpi for display resolution to mm conversion

(cherry picked from commit 13c8a60b7095c141321cd2d09f3e36466d54a748)

3 years agoProperly discard xfc->appWindow on focus loss
Armin Novak [Wed, 9 Dec 2020 15:07:49 +0000 (16:07 +0100)]
Properly discard xfc->appWindow on focus loss

(cherry picked from commit 34e5504bcc1734fd767572a262dec94e551e4c30)

3 years agoFixed #6635: Use correct window handle for pointer operations
akallabeth [Thu, 3 Dec 2020 13:09:16 +0000 (14:09 +0100)]
Fixed #6635: Use correct window handle for pointer operations

(cherry picked from commit e8fe552ed4759327d63abf637f464839b2d6306a)

3 years agoFixed #6518
akallabeth [Tue, 20 Oct 2020 15:07:58 +0000 (17:07 +0200)]
Fixed #6518

(cherry picked from commit 38a79be33f429b5e556f8185eb94a73c8aa45bb9)

3 years agoCleaned up rdpei channel, updated to current spec.
Armin Novak [Wed, 11 Nov 2020 07:54:46 +0000 (08:54 +0100)]
Cleaned up rdpei channel, updated to current spec.

(cherry picked from commit bd061fc291108bad67ce94dd92e1fdb31e0c0cae)

3 years agoFixed possible out of bound access in usb channel.
akallabeth [Tue, 10 Nov 2020 08:02:35 +0000 (09:02 +0100)]
Fixed possible out of bound access in usb channel.

(cherry picked from commit 2e5280feecc3cd692f9930f9b7ed26129423a1a1)

3 years agoX11: Scale cursor when SmartSizing is on
Nathan Loewen [Tue, 8 Sep 2020 15:12:27 +0000 (10:12 -0500)]
X11: Scale cursor when SmartSizing is on

(cherry picked from commit f4f795f3233c56fe7f4cd579777115b77f49da1e)

3 years agolet freerdp_image_scale() determine step size
Nathan Loewen [Mon, 7 Sep 2020 02:14:17 +0000 (21:14 -0500)]
let freerdp_image_scale() determine step size

(cherry picked from commit cba618115471a7072902aa137af5962f0e0c4c1e)

3 years agoRespect invalidRegion in progressive_compress
akallabeth [Tue, 15 Dec 2020 15:02:34 +0000 (16:02 +0100)]
Respect invalidRegion in progressive_compress

(cherry picked from commit 4a7ec674e601e3680161a0dfbda67dc07477eb8b)

3 years agoFixed progressive decoding without subbanddiff
akallabeth [Tue, 15 Dec 2020 08:58:37 +0000 (09:58 +0100)]
Fixed progressive decoding without subbanddiff

(cherry picked from commit e3445eefab77c6666d760fa042f141c0a2d2965a)

3 years agoCleaned up rfx API
akallabeth [Mon, 14 Dec 2020 16:44:30 +0000 (17:44 +0100)]
Cleaned up rfx API

(cherry picked from commit 25a8abc4eb0a6d6a115169b5f0f762e3308b4026)

3 years agoClean up drdynvc channels porperly locked.
akallabeth [Fri, 6 Nov 2020 12:38:47 +0000 (13:38 +0100)]
Clean up drdynvc channels porperly locked.

(cherry picked from commit 7f1cca78aa9e4cf65cb38c9b741566fbf7dce2d0)

3 years agoFixed primitives test
Armin Novak [Mon, 7 Sep 2020 09:48:06 +0000 (11:48 +0200)]
Fixed primitives test

(cherry picked from commit b6f392215225a9aae9d257551505c169ac23e9ef)

3 years agoFixed _aligned_recalloc
Armin Novak [Mon, 7 Sep 2020 09:05:45 +0000 (11:05 +0200)]
Fixed _aligned_recalloc

(cherry picked from commit cad1dd39e23f45b36e4815129bdc3d99fcbd8c2b)

3 years agoFixed unit tests run under memory sanitizer
Armin Novak [Mon, 7 Sep 2020 08:42:28 +0000 (10:42 +0200)]
Fixed unit tests run under memory sanitizer

(cherry picked from commit 816e792e3f468eebf3c82416b9ef33637c9bd5cc)

3 years agoRemoved invalid check
akallabeth [Tue, 17 Nov 2020 08:04:52 +0000 (09:04 +0100)]
Removed invalid check

(cherry picked from commit e019ed65668b260542ee51b096585abb77354881)

3 years agoImplemented 2.2.1.17.1 Persistent Key List PDU Data, added checks
akallabeth [Thu, 19 Nov 2020 14:21:49 +0000 (15:21 +0100)]
Implemented 2.2.1.17.1 Persistent Key List PDU Data, added checks

* Implemented missing server side version of PDU (just skip data)
* Refactored read/write functions to properly check stream
  length/capacity and handle return values.

(cherry picked from commit ec3c333656b4d8a00ff278a70b52c11b18e2d643)