mstarzinger [Thu, 11 Jun 2015 12:17:59 +0000 (05:17 -0700)]
[turbofan] Disable failing test262 tests after
84f208949b2e.
TBR=machenbach@chromium.org
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1178123002
Cr-Commit-Position: refs/heads/master@{#28937}
machenbach [Thu, 11 Jun 2015 11:42:32 +0000 (04:42 -0700)]
[test] Add random seed stress mode to test runner.
NOTRY=true
Review URL: https://codereview.chromium.org/
1180473003
Cr-Commit-Position: refs/heads/master@{#28936}
mstarzinger [Thu, 11 Jun 2015 10:50:42 +0000 (03:50 -0700)]
[turbofan] Enable support for try-catch statements.
R=bmeurer@chromium.org
BUG=v8:4131
LOG=N
Review URL: https://codereview.chromium.org/
1177743002
Cr-Commit-Position: refs/heads/master@{#28935}
machenbach [Thu, 11 Jun 2015 10:49:35 +0000 (03:49 -0700)]
Revert of [heap] Unify the immortal immovable root detection mechanism. (patchset #3 id:40001 of https://codereview.chromium.org/
1178853002/)
Reason for revert:
[Sheriff] tsan failures:
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4240
Original issue's description:
> [heap] Unify the immortal immovable root detection mechanism.
>
> Uniformly use the Heap::GetRootListIndex() and
> Heap::RootIsImmortalImmovable() methods to detect immortal immovable
> roots in the optimizing compilers.
>
> R=jarin@chromium.org
>
> Committed: https://crrev.com/
84e83da99a72edc169367bf88588b1a2f10c2e08
> Cr-Commit-Position: refs/heads/master@{#28933}
TBR=jarin@chromium.org,bmeurer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1178083003
Cr-Commit-Position: refs/heads/master@{#28934}
bmeurer [Thu, 11 Jun 2015 10:12:33 +0000 (03:12 -0700)]
[heap] Unify the immortal immovable root detection mechanism.
Uniformly use the Heap::GetRootListIndex() and
Heap::RootIsImmortalImmovable() methods to detect immortal immovable
roots in the optimizing compilers.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1178853002
Cr-Commit-Position: refs/heads/master@{#28933}
jochen [Thu, 11 Jun 2015 09:37:32 +0000 (02:37 -0700)]
Revert of Add CHECKs to verify that we never finalize stale copies of external strings (patchset #1 id:1 of https://codereview.chromium.org/
1160253010/)
Reason for revert:
not needed anymore
Original issue's description:
> Add CHECKs to verify that we never finalize stale copies of external strings
>
> BUG=none
> R=ulan@chromium.org
> LOG=n
>
> Committed: https://crrev.com/
ca2f8d811ca08783e38ce5dd42d38a6b6a7b876f
> Cr-Commit-Position: refs/heads/master@{#28811}
TBR=ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/
1178703008
Cr-Commit-Position: refs/heads/master@{#28932}
machenbach [Thu, 11 Jun 2015 09:09:03 +0000 (02:09 -0700)]
Revert of Revert of Revert of Promise assimilation fix. (patchset #1 id:1 of https://codereview.chromium.org/
1181533006/)
Reason for revert:
[Sheriff] Changes/breaks layout tests. Please land upstream needsmanualrebaseline requests first or fix the tests.
E.g.
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/400
One test fails, one times out. See e.g. expectations changes:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/400/layout-test-results/inspector/sources/debugger-async/async-callstack-promises-diff.txt
On linux debug theses tests crash:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/346
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/346/layout-test-results/results.html
Original issue's description:
> Revert of Revert of Promise assimilation fix. (patchset #1 id:1 of https://codereview.chromium.org/
1176163004/)
>
> Reason for revert:
> Test failures are bogus. Snapshot blob and natives blob are out of sync due to build being weird.
>
> Original issue's description:
> > Revert of Promise assimilation fix. (patchset #8 id:160001 of https://codereview.chromium.org/
1098663002/)
> >
> > Reason for revert:
> > Test failures: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64/builds/3829
> >
> > Original issue's description:
> > > Promise assimilation fix.
> > >
> > > Let x be a fulfilled promise and y be another promise. |x.then(() => y)|
> > > should call |y.then|, but the current implementation calls PromiseChain.
> > > We can see the difference when we set a custom function to |y.then|.
> > >
> > > This CL fixes the spec violation, but as a result |then| is no longer
> > > a wrapper of |chain| and in some cases it does not work well with
> > > |accept| or |chain|. That is not a problem for ES6 promise users because
> > > ES6 promise doesn't have them.
> > >
> > > LOG=N
> > > BUG=477921
> > >
> > > Committed: https://crrev.com/
2f57dff3ea0c45e1a61b334fda962460f89d71bc
> > > Cr-Commit-Position: refs/heads/master@{#28926}
> >
> > TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=477921
> >
> > Committed: https://crrev.com/
5bb75f514027f79303396dba823c2d78c6add83b
> > Cr-Commit-Position: refs/heads/master@{#28927}
>
> TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=477921
>
> Committed: https://crrev.com/
6f214bdd8bcdc76d48bd85c3bd897f0e2427ff95
> Cr-Commit-Position: refs/heads/master@{#28928}
TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477921
Review URL: https://codereview.chromium.org/
1181603003
Cr-Commit-Position: refs/heads/master@{#28931}
Michael Achenbach [Thu, 11 Jun 2015 08:57:31 +0000 (10:57 +0200)]
Whitespace change to test infra change.
Cr-Commit-Position: refs/heads/master@{#28930}
vogelheim [Thu, 11 Jun 2015 08:32:22 +0000 (01:32 -0700)]
Revert of Re-land: Enable external startup by default on Linux. (patchset #3 id:40001 of https://codereview.chromium.org/
1041683002/)
Reason for revert:
Revert, due to problems with stale build artefacts uncovered by this.
Details: https://code.google.com/p/v8/issues/detail?id=4171
Original issue's description:
> Re-land: Enable external startup by default on Linux.
>
> crrev.com/
1016603004 should have fixed the issues that broke this last time.
>
> Notes:
> - The current functionality is meant to stay. If you prefer the old way,
> just set v8_use_external_startup_data=0.
> - You might notice this if you call d8 via PATH. Either explicitly tell d8
> where your external snapshot/built-ins are, or change the build options
> as above.
> - This follows Chromium practice, that mostly uses this feature these days.
> - Other platforms to follow later.
>
> BUG=
>
> Committed: https://crrev.com/
bb9c774c164c3552b67b4f1b60809852a44f2ecd
> Cr-Commit-Position: refs/heads/master@{#28858}
TBR=jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1177883003
Cr-Commit-Position: refs/heads/master@{#28929}
yangguo [Thu, 11 Jun 2015 08:15:22 +0000 (01:15 -0700)]
Revert of Revert of Promise assimilation fix. (patchset #1 id:1 of https://codereview.chromium.org/
1176163004/)
Reason for revert:
Test failures are bogus. Snapshot blob and natives blob are out of sync due to build being weird.
Original issue's description:
> Revert of Promise assimilation fix. (patchset #8 id:160001 of https://codereview.chromium.org/
1098663002/)
>
> Reason for revert:
> Test failures: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64/builds/3829
>
> Original issue's description:
> > Promise assimilation fix.
> >
> > Let x be a fulfilled promise and y be another promise. |x.then(() => y)|
> > should call |y.then|, but the current implementation calls PromiseChain.
> > We can see the difference when we set a custom function to |y.then|.
> >
> > This CL fixes the spec violation, but as a result |then| is no longer
> > a wrapper of |chain| and in some cases it does not work well with
> > |accept| or |chain|. That is not a problem for ES6 promise users because
> > ES6 promise doesn't have them.
> >
> > LOG=N
> > BUG=477921
> >
> > Committed: https://crrev.com/
2f57dff3ea0c45e1a61b334fda962460f89d71bc
> > Cr-Commit-Position: refs/heads/master@{#28926}
>
> TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=477921
>
> Committed: https://crrev.com/
5bb75f514027f79303396dba823c2d78c6add83b
> Cr-Commit-Position: refs/heads/master@{#28927}
TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477921
Review URL: https://codereview.chromium.org/
1181533006
Cr-Commit-Position: refs/heads/master@{#28928}
yangguo [Thu, 11 Jun 2015 08:01:09 +0000 (01:01 -0700)]
Revert of Promise assimilation fix. (patchset #8 id:160001 of https://codereview.chromium.org/
1098663002/)
Reason for revert:
Test failures: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64/builds/3829
Original issue's description:
> Promise assimilation fix.
>
> Let x be a fulfilled promise and y be another promise. |x.then(() => y)|
> should call |y.then|, but the current implementation calls PromiseChain.
> We can see the difference when we set a custom function to |y.then|.
>
> This CL fixes the spec violation, but as a result |then| is no longer
> a wrapper of |chain| and in some cases it does not work well with
> |accept| or |chain|. That is not a problem for ES6 promise users because
> ES6 promise doesn't have them.
>
> LOG=N
> BUG=477921
>
> Committed: https://crrev.com/
2f57dff3ea0c45e1a61b334fda962460f89d71bc
> Cr-Commit-Position: refs/heads/master@{#28926}
TBR=arv@chromium.org,caitpotter88@gmail.com,rossberg@chromium.org,yhirano@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477921
Review URL: https://codereview.chromium.org/
1176163004
Cr-Commit-Position: refs/heads/master@{#28927}
yhirano [Thu, 11 Jun 2015 07:42:37 +0000 (00:42 -0700)]
Promise assimilation fix.
Let x be a fulfilled promise and y be another promise. |x.then(() => y)|
should call |y.then|, but the current implementation calls PromiseChain.
We can see the difference when we set a custom function to |y.then|.
This CL fixes the spec violation, but as a result |then| is no longer
a wrapper of |chain| and in some cases it does not work well with
|accept| or |chain|. That is not a problem for ES6 promise users because
ES6 promise doesn't have them.
LOG=N
BUG=477921
Review URL: https://codereview.chromium.org/
1098663002
Cr-Commit-Position: refs/heads/master@{#28926}
hpayer [Thu, 11 Jun 2015 07:41:31 +0000 (00:41 -0700)]
Make sure we do not start incremental marking in idle notification when incremental marking is turned off via flags.
BUG=chromium:498315
LOG=n
Review URL: https://codereview.chromium.org/
1177953002
Cr-Commit-Position: refs/heads/master@{#28925}
mbrandy [Thu, 11 Jun 2015 07:07:37 +0000 (00:07 -0700)]
PPC64: Adjust simulator stack safety margin.
This fixes a failure in test/mjsunit/regress/regress-crbug-491062.js.
R=dstence@us.ibm.com, michael_dawson@ca.ibm.com, svenpanne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1174693002
Cr-Commit-Position: refs/heads/master@{#28924}
jarin [Thu, 11 Jun 2015 06:09:07 +0000 (23:09 -0700)]
Make writing of frame translation platform independent.
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
1175963002
Cr-Commit-Position: refs/heads/master@{#28923}
bmeurer [Thu, 11 Jun 2015 05:23:06 +0000 (22:23 -0700)]
[turbofan] Record the SharedFunctionInfo of ALL inlined functions.
Previously we only recorded the SharedFunctionInfo of inlined functions
that had at least one (lazy) deopt point left at code generation time.
R=mstarzinger@chromium.org
Committed: https://chromium.googlesource.com/v8/v8/+/
ffa0b4007cd7de0cfd6d37079ef360e3beeb5686
Review URL: https://codereview.chromium.org/
1175953002
Cr-Commit-Position: refs/heads/master@{#28922}
bmeurer [Thu, 11 Jun 2015 05:14:59 +0000 (22:14 -0700)]
[stl] Fix ZonePriorityQueue wrapper.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1179763002
Cr-Commit-Position: refs/heads/master@{#28921}
bmeurer [Thu, 11 Jun 2015 04:47:40 +0000 (21:47 -0700)]
Revert of [turbofan] Record the SharedFunctionInfo of ALL inlined functions. (patchset #2 id:20001 of https://codereview.chromium.org/
1175953002/)
Reason for revert:
Breaks Windows debug.
Original issue's description:
> [turbofan] Record the SharedFunctionInfo of ALL inlined functions.
>
> Previously we only recorded the SharedFunctionInfo of inlined functions
> that had at least one (lazy) deopt point left at code generation time.
>
> R=mstarzinger@chromium.org
>
> Committed: https://chromium.googlesource.com/v8/v8/+/
ffa0b4007cd7de0cfd6d37079ef360e3beeb5686
TBR=mstarzinger@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1178683004
Cr-Commit-Position: refs/heads/master@{#28920}
Benedikt Meurer [Thu, 11 Jun 2015 04:34:13 +0000 (06:34 +0200)]
[turbofan] Record the SharedFunctionInfo of ALL inlined functions.
Previously we only recorded the SharedFunctionInfo of inlined functions
that had at least one (lazy) deopt point left at code generation time.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
1175953002.
Cr-Commit-Position: refs/heads/master@{#28919}
mstarzinger [Thu, 11 Jun 2015 04:21:56 +0000 (21:21 -0700)]
[turbofan] Make IfException projections consume effects.
This is needed in order to allow expansion of a throwing node into a
set of nodes that produce different effects for the successful and the
exceptional continuation.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
1179543002
Cr-Commit-Position: refs/heads/master@{#28918}
v8-autoroll [Thu, 11 Jun 2015 03:28:01 +0000 (20:28 -0700)]
Update V8 DEPS.
Rolling v8/third_party/icu to
a05f412f70489b77da0ddeb8baa31c68e3eff2c6
Rolling v8/tools/clang to
69fd1b485a2b24c872bfa4759342076751c9d490
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1176273002
Cr-Commit-Position: refs/heads/master@{#28917}
machenbach [Wed, 10 Jun 2015 20:39:35 +0000 (13:39 -0700)]
[test] Skip all philip layout tests to fix OOM issue.
BUG=chromium:498689
LOG=n
NOTRY=true
TBR=sergiyb@chromium.org
Review URL: https://codereview.chromium.org/
1169813010
Cr-Commit-Position: refs/heads/master@{#28916}
machenbach [Wed, 10 Jun 2015 20:10:25 +0000 (13:10 -0700)]
[test] Speculatively skip some layout tests to fix OOM issue.
BUG=chromium:498689
LOG=n
NOTRY=true
TBR=sergiyb@chromium.org
Review URL: https://codereview.chromium.org/
1179573003
Cr-Commit-Position: refs/heads/master@{#28915}
machenbach [Wed, 10 Jun 2015 18:43:55 +0000 (11:43 -0700)]
[test] Speculatively skip layout test to fix OOM issue.
BUG=chromium:498689
LOG=n
NOTRY=true
TBR=sergiyb@chromium.org
Review URL: https://codereview.chromium.org/
1180523002
Cr-Commit-Position: refs/heads/master@{#28914}
paul.lind [Wed, 10 Jun 2015 17:47:19 +0000 (10:47 -0700)]
MIPS: Skip test-heap/TestSizeOfRegExpCode
After https://codereview.chromium.org/
1180433003 the code-size exceeeds
the limit for MIPS. We have some optimizations in place for MIPS64 that
will be ported back to MIPS, and will investigate other code-size
improvements so we can re-enable this test.
BUG=
Review URL: https://codereview.chromium.org/
1166353005
Cr-Commit-Position: refs/heads/master@{#28913}
adamk [Wed, 10 Jun 2015 17:42:01 +0000 (10:42 -0700)]
Increase the chance of printing a useful error when bootstrapping fails
Two changes:
- In ReportBootstrappingException, if all we have is a string, it seems
better to print that than nothing.
- In Factory::NewError, there's no use trying to call into the builtins if
compilation of the builtins is causing the exception (this currently
results in a cryptic segfault if we trigger, say, a ReferenceError when
executing builtins script during bootstrapping).
Review URL: https://codereview.chromium.org/
1158013003
Cr-Commit-Position: refs/heads/master@{#28912}
weiliang.lin [Wed, 10 Jun 2015 17:37:31 +0000 (10:37 -0700)]
Make RawMachineAssemblerTest emitting CFG always have a dummy End block
Frame Elider requires a sane CFG which should have such dummy end block.
BUG=
Review URL: https://codereview.chromium.org/
1166293004
Cr-Commit-Position: refs/heads/master@{#28911}
machenbach [Wed, 10 Jun 2015 17:06:53 +0000 (10:06 -0700)]
[test] Speculatively skip layout test to fix OOM issue.
BUG=chromium:498689
LOG=n
NOTRY=true
TBR=sergiyb@chromium.org
Review URL: https://codereview.chromium.org/
1173033003
Cr-Commit-Position: refs/heads/master@{#28910}
mbrandy [Wed, 10 Jun 2015 16:14:37 +0000 (09:14 -0700)]
PPC: [deoptimizer] Basic support inlining based on SharedFunctionInfo.
Port
cf21da7e485ac80b3071e477e5399a00ee2b365f
Original commit message:
Up until now we can only inline based on JSFunction, because of the way
the deoptimization works. With this change we will be able to inline
based on the SharedFunctionInfo and materialize the JSFunction from a
literal or a stack slot when necessary.
R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1174963004
Cr-Commit-Position: refs/heads/master@{#28909}
wingo [Wed, 10 Jun 2015 16:11:25 +0000 (09:11 -0700)]
Support rest parameters in arrow functions
R=dslomov@chromium.org, rossberg@chromium.org
LOG=Y
BUG=v8:2700
Review URL: https://codereview.chromium.org/
1178523002
Cr-Commit-Position: refs/heads/master@{#28908}
balazs.kilvady [Wed, 10 Jun 2015 15:45:07 +0000 (08:45 -0700)]
MIPS: Replace numeric_limits<>::lowest() in cctest-assembler*.cc
On Mac for the requested minimal version (10.5) only old stl (from gcc 4.2.1) can be used so unfortunately we can't use numeric_limits<>::lowest() which were added in
874c54e05e92e04590b1026b495108abfd6063b7
BUG=
TEST=cctest/test-assembler-mips64, cctest/test-assembler-mips
Review URL: https://codereview.chromium.org/
1175463003
Cr-Commit-Position: refs/heads/master@{#28907}
bmeurer [Wed, 10 Jun 2015 11:52:35 +0000 (04:52 -0700)]
[deoptimizer] Basic support inlining based on SharedFunctionInfo.
Up until now we can only inline based on JSFunction, because of the way
the deoptimization works. With this change we will be able to inline
based on the SharedFunctionInfo and materialize the JSFunction from a
literal or a stack slot when necessary.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1169103004
Cr-Commit-Position: refs/heads/master@{#28906}
yangguo [Wed, 10 Jun 2015 11:24:29 +0000 (04:24 -0700)]
Deserializer: flush code objects in large object space.
R=ulan@chromium.org,jacob.bramley@arm.com
Review URL: https://codereview.chromium.org/
1173013002
Cr-Commit-Position: refs/heads/master@{#28905}
machenbach [Wed, 10 Jun 2015 11:15:12 +0000 (04:15 -0700)]
[test] Use generator to accelerate test runner startup.
This saves >1s for mjsunit and >10s for test262.
Review URL: https://codereview.chromium.org/
1174923002
Cr-Commit-Position: refs/heads/master@{#28904}
machenbach [Wed, 10 Jun 2015 10:15:14 +0000 (03:15 -0700)]
Reland [test] Refactoring - Let runner handle test IDs.
Reason for revert:
All build problems had other reasons.
Original issue's description:
> Revert of [test] Refactoring - Let runner handle test IDs. (patchset #1 id:1 of https://codereview.chromium.org/
1168303007/)
>
> Reason for revert:
> [Sheriff] Revert until the tree is in a better state.
>
> Original issue's description:
> > [test] Refactoring - Let runner handle test IDs.
> >
> > This prepares for properly rerunning tests. Currently when
> > tests are rerun, the same test object is reused. This
> > will be changed in a follow up.
> >
> > Committed: https://crrev.com/
f41a81b8a513fc360c500c066b74f223bc9c0223
> > Cr-Commit-Position: refs/heads/master@{#28864}
>
> TBR=jkummerow@chromium.org,tandrii@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/
f83444a5f24381ec9ccc28b1e18e1e9370415bb2
> Cr-Commit-Position: refs/heads/master@{#28891}
TBR=jkummerow@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1179483002
Cr-Commit-Position: refs/heads/master@{#28903}
erikcorry [Wed, 10 Jun 2015 09:55:22 +0000 (02:55 -0700)]
Reland II of 'Optimize trivial regexp disjunctions' CL
1176453002
This change rewrites regexps like (ab|ac|z|ad|ae|af) into (a[b-f]|z). We can only reorder disjunctions like this for case-dependent regexps. For case-independent regexps, the disjunctions should be pre-sorted for best results.
R=yangguo@chromium.org
BUG=chromium:482998
LOG=n
Review URL: https://codereview.chromium.org/
1180433003
Cr-Commit-Position: refs/heads/master@{#28902}
machenbach [Wed, 10 Jun 2015 09:42:24 +0000 (02:42 -0700)]
Revert of Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (patchset #1 id:1 of https://codereview.chromium.org/
1163373005/)
Reason for revert:
All build problems had other causes.
Original issue's description:
> Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (patchset #3 id:40001 of https://codereview.chromium.org/
1171943002/)
>
> Reason for revert:
> might break stuff
>
> Original issue's description:
> > [test] Refactoring - Use subject/observer pattern for progress indicators.
> >
> > This should prevent bugs caused by missing super calls in
> > overridden methods. The assumption is that methods of
> > different indicators are independent.
> >
> > Committed: https://crrev.com/
fbe973ff1722a6158a5b2babce9c1a32d26a1d3b
> > Cr-Commit-Position: refs/heads/master@{#28866}
>
> TBR=jkummerow@chromium.org,tandrii@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/
2a3962d9d2a7415378811f4d56522531332d5a3e
> Cr-Commit-Position: refs/heads/master@{#28869}
TBR=jkummerow@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1176863002
Cr-Commit-Position: refs/heads/master@{#28901}
chunyang.dai [Wed, 10 Jun 2015 09:29:02 +0000 (02:29 -0700)]
X87: [es6] Super call in arrows and eval
port
4b8051a02ae9f765b7d803fc7986301abde36007 (r28769)
original commit message:
This splits the SuperReference AST node into SuperPropertyReference and
SuperCallReference. The super call reference node consists of three
unresolved vars to this, new.target and this_function. These gets
declared when the right function is entered and if it is in use. The
variables gets assigned in FullCodeGenerator::Generate.
This is a revert of the revert
88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8
BUG=
Review URL: https://codereview.chromium.org/
1163983002
Cr-Commit-Position: refs/heads/master@{#28900}
mstarzinger [Wed, 10 Jun 2015 09:16:07 +0000 (02:16 -0700)]
[turbofan] Small cleanup in VisitTryCatchStatement.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
1176513004
Cr-Commit-Position: refs/heads/master@{#28899}
chunyang.dai [Wed, 10 Jun 2015 09:15:00 +0000 (02:15 -0700)]
X87: Build ObjectLiteral constant properties in the numbering phase.
port
450002f3a105d4bb17fd3b1a9d9d54464c01d200 (r28749)
original commit message:
It's necessary to do this in order to know how many type feedback vector slots
we should allocate for the object literal.
BUG=
Review URL: https://codereview.chromium.org/
1168563003
Cr-Commit-Position: refs/heads/master@{#28898}
mstarzinger [Wed, 10 Jun 2015 09:13:54 +0000 (02:13 -0700)]
[turbofan] Deprecate NodeProperties::ReplaceWithValue.
This deprecates the aforementioned mutator in favor of a simpler
NodeProperties::ReplaceUses that doesn't perform any relaxation.
Preparation for enabling support for try-catch statements.
R=bmeurer@chromium.org
TEST=unittests/NodePropertiesTest
Review URL: https://codereview.chromium.org/
1172773003
Cr-Commit-Position: refs/heads/master@{#28897}
wingo [Wed, 10 Jun 2015 09:12:47 +0000 (02:12 -0700)]
Fix copy-pasteo in expression-classifier.h
R=dslomov@chromium.org
LOG=N
BUG=
Review URL: https://codereview.chromium.org/
1174543003
Cr-Commit-Position: refs/heads/master@{#28896}
machenbach [Wed, 10 Jun 2015 09:08:50 +0000 (02:08 -0700)]
[test] Fix test archive clobber.
The old version would always clobber.
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1177503005
Cr-Commit-Position: refs/heads/master@{#28895}
machenbach [Wed, 10 Jun 2015 08:31:20 +0000 (01:31 -0700)]
[test] Clobber unclean test262-es6 checkouts.
Review URL: https://codereview.chromium.org/
1173753004
Cr-Commit-Position: refs/heads/master@{#28894}
hpayer [Wed, 10 Jun 2015 08:12:56 +0000 (01:12 -0700)]
Bring back high promotion mode to shrink young generation size when scavenging latency is high.
BUG=
Review URL: https://codereview.chromium.org/
1175663002
Cr-Commit-Position: refs/heads/master@{#28893}
binji [Wed, 10 Jun 2015 07:33:43 +0000 (00:33 -0700)]
Fix cluster-fuzz bug introduced in refs/heads/master@{#28796}.
Don't DCHECK when neutering that the buffer is not a SharedArrayBuffer;
instead, just return early.
BUG=chromium:498142,chromium:497295
R=jarin@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
1174753002
Cr-Commit-Position: refs/heads/master@{#28892}
machenbach [Wed, 10 Jun 2015 06:46:35 +0000 (23:46 -0700)]
Revert of [test] Refactoring - Let runner handle test IDs. (patchset #1 id:1 of https://codereview.chromium.org/
1168303007/)
Reason for revert:
[Sheriff] Revert until the tree is in a better state.
Original issue's description:
> [test] Refactoring - Let runner handle test IDs.
>
> This prepares for properly rerunning tests. Currently when
> tests are rerun, the same test object is reused. This
> will be changed in a follow up.
>
> Committed: https://crrev.com/
f41a81b8a513fc360c500c066b74f223bc9c0223
> Cr-Commit-Position: refs/heads/master@{#28864}
TBR=jkummerow@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1167343003
Cr-Commit-Position: refs/heads/master@{#28891}
machenbach [Wed, 10 Jun 2015 06:36:43 +0000 (23:36 -0700)]
Revert of Update Test262 to 5/30 (patchset #4 id:60001 of https://codereview.chromium.org/
1136553008/)
Reason for revert:
[Sheriff] Still lots of breakages on some builders. E.g. http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/3313
Original issue's description:
> Update Test262 to 5/30
>
> This updates the test runner to run all tests in both sloppy
> and strict mode.
>
> It also marks the test in the status file as failing in
> sloppy mode even if all it does is marking the test as
> [PASS, FAIL]. A future CL will have to validate that the
> tests pass and fail in the correct mode.
>
> Committed: https://crrev.com/
d869f4a4801d4ef6868c266c07f9e29d2e29cba5
> Cr-Commit-Position: refs/heads/master@{#28879}
TBR=rossberg@chromium.org,arv@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1173933002
Cr-Commit-Position: refs/heads/master@{#28890}
machenbach [Wed, 10 Jun 2015 06:35:27 +0000 (23:35 -0700)]
Revert of [test262-es6] Temporary disable some tests (patchset #1 id:1 of https://codereview.chromium.org/
1176573002/)
Reason for revert:
[Sheriff] Prepares revert of https://codereview.chromium.org/
1136553008
Original issue's description:
> [test262-es6] Temporary disable some tests
>
> These tests have issues with our harness.
>
> Upstream fix: https://github.com/tc39/test262/pull/309
>
> BUG=N
> LOG=N
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/
eed7363a0da0f21c3eee6c052507299d9b707462
> Cr-Commit-Position: refs/heads/master@{#28881}
TBR=arv@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=N
Review URL: https://codereview.chromium.org/
1169903006
Cr-Commit-Position: refs/heads/master@{#28889}
mstarzinger [Wed, 10 Jun 2015 06:03:03 +0000 (23:03 -0700)]
[turbofan] Fix context chain extension for top-level code.
For top-level code the closure passed into context allocation methods
needs to be replaced with a sentinel to canonicalize is to the empty
function object.
R=bmeurer@chromium.org
TEST=mjsunit/regress/regress-4169
BUG=v8:4169
LOG=N
Review URL: https://codereview.chromium.org/
1172013002
Cr-Commit-Position: refs/heads/master@{#28888}
Benedikt Meurer [Wed, 10 Jun 2015 05:15:48 +0000 (07:15 +0200)]
[frames] No GC is allowed while using the unhandlified TranslatedState.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1174593003.
Cr-Commit-Position: refs/heads/master@{#28887}
v8-autoroll [Wed, 10 Jun 2015 04:34:16 +0000 (21:34 -0700)]
Update V8 DEPS.
Rolling v8/third_party/icu to
45a095d561334871dd8673cf8e5cca330d33f521
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1178433002
Cr-Commit-Position: refs/heads/master@{#28886}
erikcorry [Tue, 9 Jun 2015 23:10:04 +0000 (16:10 -0700)]
Revert of Reland of 'Optimize trivial regexp disjunctions' CL
1176453002 (patchset #2 id:20001 of https://codereview.chromium.org/
1174713002/)
Reason for revert:
Tree looks like a Christmas tree and this isn't helping
Original issue's description:
> Reland of 'Optimize trivial regexp disjunctions' CL
1176453002
>
> Original code review: https://codereview.chromium.org/
1176453002/
>
> TBR=yangguo@chromium.org
> BUG=chromium:482998
> LOG=n
>
> Committed: https://crrev.com/
85fab0fa092e8d979413f6a61baec3abe26e568d
> Cr-Commit-Position: refs/heads/master@{#28884}
TBR=yangguo@chromium.org,erikcorry@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:482998
Review URL: https://codereview.chromium.org/
1172893002
Cr-Commit-Position: refs/heads/master@{#28885}
erikcorry [Tue, 9 Jun 2015 21:57:12 +0000 (14:57 -0700)]
Reland of 'Optimize trivial regexp disjunctions' CL
1176453002
Original code review: https://codereview.chromium.org/
1176453002/
TBR=yangguo@chromium.org
BUG=chromium:482998
LOG=n
Review URL: https://codereview.chromium.org/
1174713002
Cr-Commit-Position: refs/heads/master@{#28884}
Erik Arvidsson [Tue, 9 Jun 2015 20:26:32 +0000 (16:26 -0400)]
Moar clobbering landmines
Bots have been really lazy today and they have not picked up the
latest versions for some obscure reason
BUG=N
LOG=M
TBR=machenbach@chromium.org, littledan@chromium.org
Review URL: https://codereview.chromium.org/
1171223002
Cr-Commit-Position: refs/heads/master@{#28883}
dehrenberg [Tue, 9 Jun 2015 19:40:44 +0000 (12:40 -0700)]
Implement %TypedArray%.prototype.slice
The initial implementation of this method takes a couple shortcuts:
- At some points in the spec, we should be making a reference to
"Table 49" and instead do property lookup on the constructor.
This is an issue with some other TypedArray methods too.
- The spec indicates that, if constructor and @@species haven't been
messed with in particular ways, then there should be a memcpy
from the old to the new. That fast path is not implemented here
in this patch, but because V8 doesn't canonicalize NaN, the result
isn't observably different.
BUG=v8:3578
LOG=Y
R=arv
Review URL: https://codereview.chromium.org/
1170023002
Cr-Commit-Position: refs/heads/master@{#28882}
Erik Arvidsson [Tue, 9 Jun 2015 19:10:15 +0000 (15:10 -0400)]
[test262-es6] Temporary disable some tests
These tests have issues with our harness.
Upstream fix: https://github.com/tc39/test262/pull/309
BUG=N
LOG=N
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1176573002
Cr-Commit-Position: refs/heads/master@{#28881}
ulan [Tue, 9 Jun 2015 17:49:41 +0000 (10:49 -0700)]
Make old generation allocation throughput stats independent from the new space allocation throughput.
BUG=
Review URL: https://codereview.chromium.org/
1167563005
Cr-Commit-Position: refs/heads/master@{#28880}
arv [Tue, 9 Jun 2015 17:27:12 +0000 (10:27 -0700)]
Update Test262 to 5/30
This updates the test runner to run all tests in both sloppy
and strict mode.
It also marks the test in the status file as failing in
sloppy mode even if all it does is marking the test as
[PASS, FAIL]. A future CL will have to validate that the
tests pass and fail in the correct mode.
Review URL: https://codereview.chromium.org/
1136553008
Cr-Commit-Position: refs/heads/master@{#28879}
erikcorry [Tue, 9 Jun 2015 17:15:54 +0000 (10:15 -0700)]
Revert of Optimize trivial regexp disjunctions (patchset #10 id:180001 of https://codereview.chromium.org/
1176453002/)
Reason for revert:
ASAN failure
Original issue's description:
> Optimize trivial regexp disjunctions
>
> R=yangguo@chromium.org
> BUG=chromium:482998
> LOG=n
>
> Committed: https://crrev.com/
5f1f7c15b3207f6c51d187692690aeb09d3e36b5
> Cr-Commit-Position: refs/heads/master@{#28871}
TBR=yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:482998
Review URL: https://codereview.chromium.org/
1174603002
Cr-Commit-Position: refs/heads/master@{#28878}
mstarzinger [Tue, 9 Jun 2015 17:14:46 +0000 (10:14 -0700)]
[turbofan] Fix one mean typo in kResolvePossiblyDirectEval.
R=titzer@chromium.org
TEST=mjsunit/regress/regress-eval-context
Review URL: https://codereview.chromium.org/
1169853006
Cr-Commit-Position: refs/heads/master@{#28877}
dslomov [Tue, 9 Jun 2015 17:13:35 +0000 (10:13 -0700)]
[destructuring] Refactor duplicate parameter name detection.
Pushed the detection logic down to ParseAndClassifyIdentifier in
preparation to having patterns in parameter positions.
R=arv@chromium.org,rossberg@chromium.org,wingo@igalia.com
BUG=v8:811
LOG=N
Review URL: https://codereview.chromium.org/
1170153003
Cr-Commit-Position: refs/heads/master@{#28876}
Erik Arvidsson [Tue, 9 Jun 2015 16:39:25 +0000 (12:39 -0400)]
Add landmine after change to messages.h
BUG=N
LOG=N
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1174523004
Cr-Commit-Position: refs/heads/master@{#28875}
mvstanton [Tue, 9 Jun 2015 16:02:27 +0000 (09:02 -0700)]
Turbofan: Make type feedback vector a Node.
This improves code generation. Before, it was a constant loaded in a register
every time.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1175503002
Cr-Commit-Position: refs/heads/master@{#28874}
mbrandy [Tue, 9 Jun 2015 16:00:11 +0000 (09:00 -0700)]
Fix issues with Arm's use of embedded constant pools
- Introduce Assembler::DataAlign for table alignment in code object
- Fix several misuses of r8 (alias of the pool pointer register, pp)
- Fix calculation of pp in OSR/handler entry invocation
- Enable missing cases in deserializer
- Fix references to ool constant pools in comments.
R=rmcilroy@chromium.org, michael_dawson@ca.ibm.com
BUG=chromium:497180
LOG=N
Review URL: https://codereview.chromium.org/
1155673005
Cr-Commit-Position: refs/heads/master@{#28873}
wingo [Tue, 9 Jun 2015 15:58:58 +0000 (08:58 -0700)]
Speed up ExpressionClassifier::Accumulate
The following changeset introduced a regression on CodeLoad of about 3%:
https://chromium.googlesource.com/v8/v8/+/
e73594c7fb3e6b5834b7ddfe78727fb994bab25f
This CL should reduce the regression to 1.5%.
R=dslomov@chromium.org
LOG=N
BUG=
Review URL: https://codereview.chromium.org/
1163323006
Cr-Commit-Position: refs/heads/master@{#28872}
erikcorry [Tue, 9 Jun 2015 15:57:50 +0000 (08:57 -0700)]
Optimize trivial regexp disjunctions
R=yangguo@chromium.org
BUG=chromium:482998
LOG=n
Review URL: https://codereview.chromium.org/
1176453002
Cr-Commit-Position: refs/heads/master@{#28871}
arv [Tue, 9 Jun 2015 15:43:07 +0000 (08:43 -0700)]
Revert of Revert of [es6] Parsing of new.target (patchset #1 id:1 of https://codereview.chromium.org/
1170263002/)
Reason for revert:
The bot needs to be clobbered.
Original issue's description:
> Revert of [es6] Parsing of new.target (patchset #2 id:20001 of https://codereview.chromium.org/
1169853002/)
>
> Reason for revert:
> [Sheriff] fails messages:
> http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/1703
>
> Original issue's description:
> > [es6] Parsing of new.target
> >
> > BUG=v8:3887
> > LOG=N
> > R=adamk@chromium.org, dslomov@chromium.org
> >
> > Committed: https://crrev.com/
ae06bdde7763d673b39948b710df414217265cce
> > Cr-Commit-Position: refs/heads/master@{#28865}
>
> TBR=adamk@chromium.org,dslomov@chromium.org,arv@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:3887
>
> Committed: https://crrev.com/
fe97cfccf3faabbeff87b9b5fbacd7ceb8219304
> Cr-Commit-Position: refs/heads/master@{#28868}
TBR=adamk@chromium.org,dslomov@chromium.org,machenbach@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3887
Review URL: https://codereview.chromium.org/
1168393008
Cr-Commit-Position: refs/heads/master@{#28870}
machenbach [Tue, 9 Jun 2015 15:32:36 +0000 (08:32 -0700)]
Revert of [test] Refactoring - Use subject/observer pattern for progress indicators. (patchset #3 id:40001 of https://codereview.chromium.org/
1171943002/)
Reason for revert:
might break stuff
Original issue's description:
> [test] Refactoring - Use subject/observer pattern for progress indicators.
>
> This should prevent bugs caused by missing super calls in
> overridden methods. The assumption is that methods of
> different indicators are independent.
>
> Committed: https://crrev.com/
fbe973ff1722a6158a5b2babce9c1a32d26a1d3b
> Cr-Commit-Position: refs/heads/master@{#28866}
TBR=jkummerow@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1163373005
Cr-Commit-Position: refs/heads/master@{#28869}
machenbach [Tue, 9 Jun 2015 15:12:09 +0000 (08:12 -0700)]
Revert of [es6] Parsing of new.target (patchset #2 id:20001 of https://codereview.chromium.org/
1169853002/)
Reason for revert:
[Sheriff] fails messages:
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/1703
Original issue's description:
> [es6] Parsing of new.target
>
> BUG=v8:3887
> LOG=N
> R=adamk@chromium.org, dslomov@chromium.org
>
> Committed: https://crrev.com/
ae06bdde7763d673b39948b710df414217265cce
> Cr-Commit-Position: refs/heads/master@{#28865}
TBR=adamk@chromium.org,dslomov@chromium.org,arv@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3887
Review URL: https://codereview.chromium.org/
1170263002
Cr-Commit-Position: refs/heads/master@{#28868}
dusan.milosavljevic [Tue, 9 Jun 2015 14:50:26 +0000 (07:50 -0700)]
MIPS64: Improve long branches utilizing code range.
Improves code size of generated regexp in TestSizeOfRegExpCode test by 33%.
Execution time of the same test improved by ~10%.
Utilizing code range for mips64 enable us to use J/JAL
instructions for long branches.
TEST=cctest/test-heap/TestSizeOfRegExpCode
BUG=
Review URL: https://codereview.chromium.org/
1147503002
Cr-Commit-Position: refs/heads/master@{#28867}
machenbach [Tue, 9 Jun 2015 14:41:11 +0000 (07:41 -0700)]
[test] Refactoring - Use subject/observer pattern for progress indicators.
This should prevent bugs caused by missing super calls in
overridden methods. The assumption is that methods of
different indicators are independent.
Review URL: https://codereview.chromium.org/
1171943002
Cr-Commit-Position: refs/heads/master@{#28866}
arv [Tue, 9 Jun 2015 14:27:59 +0000 (07:27 -0700)]
[es6] Parsing of new.target
BUG=v8:3887
LOG=N
R=adamk@chromium.org, dslomov@chromium.org
Review URL: https://codereview.chromium.org/
1169853002
Cr-Commit-Position: refs/heads/master@{#28865}
machenbach [Tue, 9 Jun 2015 14:16:59 +0000 (07:16 -0700)]
[test] Refactoring - Let runner handle test IDs.
This prepares for properly rerunning tests. Currently when
tests are rerun, the same test object is reused. This
will be changed in a follow up.
Review URL: https://codereview.chromium.org/
1168303007
Cr-Commit-Position: refs/heads/master@{#28864}
wingo [Tue, 9 Jun 2015 13:36:32 +0000 (06:36 -0700)]
Stage ES6 arrow functions
R=rossberg@chromium.org
BUG=v8:2700
LOG=Y
Review URL: https://codereview.chromium.org/
1166303004
Cr-Commit-Position: refs/heads/master@{#28863}
bmeurer [Tue, 9 Jun 2015 13:10:10 +0000 (06:10 -0700)]
[deoptimizer] Remove uses of TranslationIterator outside the deoptimizer.
Use the new TranslatedState and friends, which work at a higher level
than the TranslationIterator, which will make it easier to change the
deoptimization commands in subsequent CLs.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1166353004
Cr-Commit-Position: refs/heads/master@{#28862}
dusan.milosavljevic [Tue, 9 Jun 2015 11:53:57 +0000 (04:53 -0700)]
MIPS64: Fix bogus assert in AddI.
TEST=
BUG=
Review URL: https://codereview.chromium.org/
1170173002
Cr-Commit-Position: refs/heads/master@{#28861}
bmeurer [Tue, 9 Jun 2015 11:28:08 +0000 (04:28 -0700)]
[frames] Remove obsolete JavaScriptFrame::GetInlineCount() method.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
1176473002
Cr-Commit-Position: refs/heads/master@{#28860}
mstarzinger [Tue, 9 Jun 2015 11:11:31 +0000 (04:11 -0700)]
[turbofan] Make Runtime::kSetProperty have a frame state.
R=jarin@chromium.org
TEST=cctest/test-api/AccessCheckThrows
Review URL: https://codereview.chromium.org/
1171943003
Cr-Commit-Position: refs/heads/master@{#28859}
vogelheim [Tue, 9 Jun 2015 09:59:22 +0000 (02:59 -0700)]
Re-land: Enable external startup by default on Linux.
crrev.com/
1016603004 should have fixed the issues that broke this last time.
Notes:
- The current functionality is meant to stay. If you prefer the old way,
just set v8_use_external_startup_data=0.
- You might notice this if you call d8 via PATH. Either explicitly tell d8
where your external snapshot/built-ins are, or change the build options
as above.
- This follows Chromium practice, that mostly uses this feature these days.
- Other platforms to follow later.
BUG=
Review URL: https://codereview.chromium.org/
1041683002
Cr-Commit-Position: refs/heads/master@{#28858}
ulan [Tue, 9 Jun 2015 09:00:09 +0000 (02:00 -0700)]
Reland "Replace ad-hoc weakness in prototype transitions with WeakCell."
Added missing slots recording.
This reverts commit
fd2e3344d3116cd9ca11a14a1f4d800effba25ba.
BUG=
Review URL: https://codereview.chromium.org/
1169743002
Cr-Commit-Position: refs/heads/master@{#28857}
brettw [Tue, 9 Jun 2015 08:36:09 +0000 (01:36 -0700)]
Make v8 snapshot public in component build.
This was already public in a non-component build. This means that targets
dependent on the "v8" target can take the results of the snapshot as inputs.
This also renames the component mode checking from keying off of the
component_mode string to checking the is_component_build flag, which is now the
recommended way to do this check.
Review URL: https://codereview.chromium.org/
1167223002
Cr-Commit-Position: refs/heads/master@{#28856}
mstarzinger [Tue, 9 Jun 2015 08:16:32 +0000 (01:16 -0700)]
[turbofan] Add mjsunit tests for try-catch-finally and OSR.
This adds some basic tests of the interaction between try-catch and
try-finally statements and OSR in TurboFan. The try-osr test suite
follows the structure of try-deopt closely.
R=titzer@chromium.org
TEST=mjsunit/compiler/try-osr
Review URL: https://codereview.chromium.org/
1165103003
Cr-Commit-Position: refs/heads/master@{#28855}
yangguo [Tue, 9 Jun 2015 07:49:36 +0000 (00:49 -0700)]
Only mark checksummed memory as initialized for MSAN.
BUG=425187
LOG=N
Review URL: https://codereview.chromium.org/
1170723003
Cr-Commit-Position: refs/heads/master@{#28854}
paul.lind [Tue, 9 Jun 2015 06:12:47 +0000 (23:12 -0700)]
Fix another -Wsign-compare issue for GCC 4.9.2
BUG=
Review URL: https://codereview.chromium.org/
1151523014
Cr-Commit-Position: refs/heads/master@{#28853}
v8-autoroll [Tue, 9 Jun 2015 03:27:02 +0000 (20:27 -0700)]
Update V8 DEPS.
Rolling v8/build/gyp to
fdc7b812f99e48c00e9a487bd56751bbeae07043
Rolling v8/tools/clang to
821059eb79ba92d0ab287b2b746105af4ee10817
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1171913002
Cr-Commit-Position: refs/heads/master@{#28852}
mbrandy [Mon, 8 Jun 2015 18:55:10 +0000 (11:55 -0700)]
Fix uninitialized variable compiler errors [GCC 4.8.4]
R=svenpanne@chromium.org, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1156293003
Cr-Commit-Position: refs/heads/master@{#28851}
binji [Mon, 8 Jun 2015 18:24:18 +0000 (11:24 -0700)]
Add TypedArray constructors with SharedArrayBuffer to the external API.
BUG=chromium:497295
LOG=n
Review URL: https://codereview.chromium.org/
1168723002
Cr-Commit-Position: refs/heads/master@{#28850}
mbrandy [Mon, 8 Jun 2015 18:23:09 +0000 (11:23 -0700)]
PPC: Vector ICs: ClassLiterals need to allocate a vector slot for home objects.
Port
b27016b78a7dd58dc682eed51500ba603b3e46b0
R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1161893003
Cr-Commit-Position: refs/heads/master@{#28849}
mstarzinger [Mon, 8 Jun 2015 18:21:55 +0000 (11:21 -0700)]
[turbofan] Split --turbo-exceptions into two flags.
This allows try-catch and try-finally constructs to be separately
enabled and disabled. We plan to stage try-catch support soon.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
1157863015
Cr-Commit-Position: refs/heads/master@{#28848}
mbrandy [Mon, 8 Jun 2015 18:20:41 +0000 (11:20 -0700)]
PPC: Vector ICs: debugger should save registers for vector store ics.
Port
bd32a9f711cb14c2b7c34512d43e78bd24960124
R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1169763003
Cr-Commit-Position: refs/heads/master@{#28847}
mstarzinger [Mon, 8 Jun 2015 18:19:32 +0000 (11:19 -0700)]
Drop computed handler count and index from AST.
These values were computed by the parser and hence out of sync with any
visitor over the AST. Our AST visitor aborts visitation of statement
lists as soon as a jump statement has been reached. Now handler tables
are guaranteed to be dense and fully populated.
R=ishell@chromium.org
TEST=mjsunit/regress/regress-crbug-493290
BUG=chromium:493290
LOG=N
Review URL: https://codereview.chromium.org/
1157213004
Cr-Commit-Position: refs/heads/master@{#28846}
dusan.milosavljevic [Mon, 8 Jun 2015 18:18:14 +0000 (11:18 -0700)]
MIPS64: Implement AddE lithium instruction to separate integer and address arithmetic.
This is required to have sign-extended int32 arithmetic operations by re-landing:
https://codereview.chromium.org/
1161713003
TEST=cctest/test-api/ArrayBuffer_JSInternalToExternal
BUG=
Review URL: https://codereview.chromium.org/
1153263012
Cr-Commit-Position: refs/heads/master@{#28845}
mbrandy [Mon, 8 Jun 2015 18:17:05 +0000 (11:17 -0700)]
MIPS: Fix compile error for unitialized variable in simulator.
We see this error using GCC 4.8.2.
R=michael_dawson@ca.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1153213003
Cr-Commit-Position: refs/heads/master@{#28844}
mbrandy [Mon, 8 Jun 2015 18:15:57 +0000 (11:15 -0700)]
[grokdump] Update v8heapconst.py
R=jochen@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1165453009
Cr-Commit-Position: refs/heads/master@{#28843}
balazs.kilvady [Mon, 8 Jun 2015 14:25:53 +0000 (07:25 -0700)]
MIPS: Improve --rpath and --dynamic-linker handling in gyp.
BUG=
Review URL: https://codereview.chromium.org/
1160973006
Cr-Commit-Position: refs/heads/master@{#28842}
erikcorry [Mon, 8 Jun 2015 14:24:25 +0000 (07:24 -0700)]
Revert of Only record one in n line endings to save space. (patchset #4 id:60001 of https://codereview.chromium.org/
1137683003/)
Reason for revert:
Test failures https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/345/layout-test-results/results.html
Original issue's description:
> Only record one in n line endings to save space.
>
> R=yangguo@chromium.org
> BUG=
>
> Committed: https://crrev.com/
b3d4bce593559276e68d3d7d9168f4351e4e5090
> Cr-Commit-Position: refs/heads/master@{#28837}
TBR=yangguo@chromium.org,erik.corry@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1155683010
Cr-Commit-Position: refs/heads/master@{#28841}
yangguo [Mon, 8 Jun 2015 13:02:15 +0000 (06:02 -0700)]
Check for null and undefined when getting type name for stack trace.
R=svenpanne@chromium.org
BUG=v8:3718
LOG=N
Review URL: https://codereview.chromium.org/
1164933005
Cr-Commit-Position: refs/heads/master@{#28840}
conradw [Mon, 8 Jun 2015 12:17:58 +0000 (05:17 -0700)]
[strong] Refactor ObjectStrength into a replacement for strong boolean args
Boolean "is_strong" parameters have begun to proliferate across areas where
strong mode semantics are different. This CL repurposes the existing
ObjectStrength enum as a replacement for them.
BUG=v8:3956
LOG=N
Review URL: https://codereview.chromium.org/
1144183004
Cr-Commit-Position: refs/heads/master@{#28839}
mstarzinger [Mon, 8 Jun 2015 12:10:06 +0000 (05:10 -0700)]
[turbofan] Turn JSContextSpecializer into an AdvancedReducer.
This in turn allows usage of AdvancedReducer::ReplaceWithValue which
has access to the underlying graph reducer.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
1162903006
Cr-Commit-Position: refs/heads/master@{#28838}