Diego Novillo [Wed, 3 Jan 2018 17:38:21 +0000 (12:38 -0500)]
Do not insert Phi nodes in CCP propagator.
In CCP we should not need to insert Phi nodes because CCP never looks at
loads/stores. This required adjusting two tests that relied on Phi
instructions being inserted. I changed the tests to have the Phi
instructions pre-inserted.
I also added a new test to make sure that CCP does not try to look
through stores and loads.
Finally, given that CCP does not handle loads/stores, it's better to run
mem2reg before it. I've changed the -O/-Os schedules to run local
multi-store elimination before CCP.
Although this is just an efficiency fix for CCP, it is
also working around a bug in Phi insertion. When Phi instructions are
inserted, they are never associated a basic block. This causes a
segfault when the propagator tries to lookup CFG edges when analyzing
Phi instructions.
Andrey Tuganov [Wed, 13 Dec 2017 16:56:09 +0000 (11:56 -0500)]
Add ExtInst validation pass (GLSL only for now)
Validates all GLSL.std.450 extended instructions.
GregF [Thu, 28 Dec 2017 00:12:04 +0000 (17:12 -0700)]
Test: Fix linux/gcc defined-but-not-used warnings/errors
Leo Izen [Thu, 28 Dec 2017 16:13:06 +0000 (11:13 -0500)]
utils/generate_grammar_tables.py: use spaces for indentation
One part of this file had indented using tabs. This causes newer
versions of python to complain. This changes the indentation to
consistently use four spaces throughout the file, to be consistent
with the rest of the file and the rest of the project.
Diego Novillo [Fri, 22 Dec 2017 17:38:02 +0000 (12:38 -0500)]
Fix https://github.com/KhronosGroup/SPIRV-Tools/issues/1130
This addresses review feedback for the CCP implementation (which fixes
https://github.com/KhronosGroup/SPIRV-Tools/issues/889).
This adds more protection around the folding of instructions that would
not be supported by the folder.
Andrey Tuganov [Thu, 21 Dec 2017 20:24:27 +0000 (15:24 -0500)]
Disallow Dim=SubpassData for OpImageSparseRead
David Neto [Sun, 3 Dec 2017 17:30:08 +0000 (12:30 -0500)]
Add asm, dis support for DebugInfo extended instruction set
Add grammar file for DebugInfo extended instruction set
- Each new operand enum kind in extinst.debuginfo.grammar.json maps
to a new value in spv_operand_type_t.
- Add new concrete enum operand types for DebugInfo
Generate a C header for the DebugInfo extended instruction set
Add table lookup of DebugInfo extended instrutions
Handle the debug info operand types in binary parser,
disassembler, and assembler.
Add DebugInfo round trip tests for assembler, disassembler
Android.mk: Support DebugInfo extended instruction set
The extinst.debuginfo.grammar.json file is currently part of
SPIRV-Tools source.
It contributes operand type enums, so it has to be processed
along with the core grammar files.
We also generate a C header DebugInfo.h.
Add necessary grammar file processing to Android.mk.
David Neto [Thu, 21 Dec 2017 16:25:31 +0000 (11:25 -0500)]
CONTRIBUTING: If you fixed a bug, say so
Diego Novillo [Tue, 5 Dec 2017 16:39:25 +0000 (11:39 -0500)]
Implement SSA CCP (SSA Conditional Constant Propagation).
This implements the conditional constant propagation pass proposed in
Constant propagation with conditional branches,
Wegman and Zadeck, ACM TOPLAS 13(2):181-210.
The main logic resides in CCPPass::VisitInstruction. Instruction that
may produce a constant value are evaluated with the constant folder. If
they produce a new constant, the instruction is considered interesting.
Otherwise, it's considered varying (for unfoldable instructions) or
just not interesting (when not enough operands have a constant value).
The other main piece of logic is in CCPPass::VisitBranch. This
evaluates the selector of the branch. When it's found to be a known
value, it computes the destination basic block and sets it. This tells
the propagator which branches to follow.
The patch required extensions to the constant manager as well. Instead
of hashing the Constant pointers, this patch changes the constant pool
to hash the contents of the Constant. This allows the lookups to be
done using the actual values of the Constant, preventing duplicate
definitions.
Steven Perron [Tue, 19 Dec 2017 19:18:13 +0000 (14:18 -0500)]
Store all enabled capabilities in the feature manger.
In order to keep track of all of the implicit capabilities as well as
the explicit ones, we will add them all to the feature manager. That is
the object that needs to be queried when checking if a capability is
enabled.
The name of the "HasCapability" function in the module was changed to
make it more obvious that it does not check for implied capabilities.
Keep an spv_context and AssemblyGrammar in IRContext
David Neto [Thu, 21 Dec 2017 15:42:46 +0000 (10:42 -0500)]
Update CHANGES
Alan Baker [Mon, 18 Dec 2017 22:02:19 +0000 (17:02 -0500)]
Fixing bugs in type manager memory management
* changed the way duplicate types are removed to stop copying
instructions
* Reworked RemoveDuplicatesPass::AreTypesSame to use type manager and
type equality
* Reworked TypeManager memory management to store a pool of unique
pointers of types
* removed unique pointers from id map
* fixed instances where free'd memory could be accessed
Steven Perron [Tue, 19 Dec 2017 20:08:54 +0000 (15:08 -0500)]
Update the legalization passes.
Changes the set of optimizations done for legalization. While doing
this, I added documentation to explain why we want each optimization.
A new option "--legalize-hlsl" is added so the legalization passes can
be easily run from the command line.
The legalize option implies skip-validation.
David Neto [Tue, 19 Dec 2017 18:52:23 +0000 (13:52 -0500)]
Make a string parameter const ref
David Neto [Tue, 19 Dec 2017 23:30:10 +0000 (18:30 -0500)]
Fix CHANGES: there is no OpImageSparseWrite
David Neto [Tue, 19 Dec 2017 22:50:01 +0000 (17:50 -0500)]
Update CHANGES for recent changes
Pierre Moreau [Wed, 29 Nov 2017 23:29:34 +0000 (00:29 +0100)]
Opt: Fix implementation and comment of AreDecorationsTheSame
Target should not be ignored when comparing decorations in RemoveDuplicates
Opt: Remove unused code in RemoveDuplicateDecorations
Steven Perron [Mon, 11 Dec 2017 18:10:24 +0000 (13:10 -0500)]
Allow pointers to pointers in logical addressing mode.
A few optimizations are updates to handle code that is suppose to be
using the logical addressing mode, but still has variables that contain
pointers as long as the pointer are to opaque objects. This is called
"relaxed logical addressing".
|Instruction::GetBaseAddress| will check that pointers that are use meet
the relaxed logical addressing rules. Optimization that now handle
relaxed logical addressing instead of logical addressing are:
- aggressive dead-code elimination
- local access chain convert
- local store elimination passes.
Steven Perron [Mon, 11 Dec 2017 18:10:24 +0000 (13:10 -0500)]
Convert private variables to function scope.
When a private variable is used in a single function, it can be
converted to a function scope variable in that function. This adds a
pass that does that. The pass can be enabled using the option
`--private-to-local`.
This transformation allows other transformations to act on these
variables.
Also moved `FindPointerToType` from the inline class to the type manager.
David Neto [Fri, 15 Dec 2017 18:19:09 +0000 (13:19 -0500)]
More validation on primitive instructions
- Test validation success for OpEmitVertex OpEndPrimitive
- Test missing capabilities for primitive instructions
- Primitive instructions require Geometry execution model
Jesus Carabano [Wed, 18 Oct 2017 09:00:02 +0000 (12:00 +0300)]
validate & test of literal's upper bits
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/660
Pierre Moreau [Wed, 29 Nov 2017 23:26:20 +0000 (00:26 +0100)]
Opt: Remove commented out duplicated type_id function
This code was wrongly added by #693.
Jeremy Hayes [Mon, 18 Dec 2017 17:44:18 +0000 (10:44 -0700)]
Fix comment in primitives validation
Also refactor type query for efficiency.
Andrey Tuganov [Mon, 18 Dec 2017 16:21:38 +0000 (11:21 -0500)]
Image Operand Sample allows sparse image opcodes
@ehsannas had filed an issue against SPIR-V spec, concerning
Image Operands section (3.14):
Sample
A following operand is the sample number of the sample to use. Only
valid with OpImageFetch, OpImageRead, and OpImageWrite.
Relaxing the check to allow OpImageSparseRead and
OpImageSparseFetch to fix failing tests.
Pierre Moreau [Sat, 25 Nov 2017 17:58:50 +0000 (18:58 +0100)]
Export a config file for pkg-config
Fixes #1031
Extracts the current version from the file CHANGES
The -dev suffix maps to a minor version number of .0
No -dev suffix maps to a minor version number of .1
Uses a first class target spirv-tools-pkg-config
David Neto [Sun, 3 Dec 2017 19:26:16 +0000 (14:26 -0500)]
Remove concept of FIRST_CONCRETE_* operand types
Alan Baker [Fri, 8 Dec 2017 20:33:19 +0000 (15:33 -0500)]
Improving the usability of the type manager. The type manager hashes
types. This allows the lookup of type declaration ids from arbitrarily
constructed types. Users should be cautious when dealing with non-unique
types (structs and potentially pointers) to get the exact id if
necessary.
* Changed the spec composite constant folder to handle ambiguous composites
* Added functionality to create necessary instructions for a type
* Added ability to remove ids from the type manager
David Neto [Fri, 15 Dec 2017 23:24:41 +0000 (18:24 -0500)]
Start v2017.3-dev
David Neto [Fri, 15 Dec 2017 23:21:55 +0000 (18:21 -0500)]
Finalize v2017.2
GregF [Tue, 12 Dec 2017 21:27:46 +0000 (14:27 -0700)]
ADCE: Only mark true breaks and continues of live loops
This fixes issue #1075
- Mark continue when conditional branch with merge block.
Only mark if merge block is not continue block.
- Handle conditional branch break with preceding merge
Jeremy Hayes [Thu, 14 Dec 2017 22:29:37 +0000 (15:29 -0700)]
Add primitive instruction validation pass
Andrey Tuganov [Wed, 13 Dec 2017 22:55:00 +0000 (17:55 -0500)]
Refactor include of latest spir-v header versions
Andrey Tuganov [Thu, 30 Nov 2017 16:29:05 +0000 (11:29 -0500)]
Add validation rules for atomic instructions
Validates all OpAtomicXXX instructions.
Diego Novillo [Tue, 12 Dec 2017 20:46:09 +0000 (15:46 -0500)]
Fix uninitialized warning at -Os.
Greg Fischer [Wed, 25 Oct 2017 00:58:48 +0000 (18:58 -0600)]
ADCE: Empty Loop Elimination
This entirely eliminates loops which do not contain live code.
Steven Perron [Mon, 11 Dec 2017 18:10:24 +0000 (13:10 -0500)]
Set the parent for basic blocks during inlining.
Inlining is not setting the parent (function) for each basic block.
This can cause problems for later optimizations. The solution is to set
the parent for each new block just before it is linked into the
function.
Lei Zhang [Tue, 12 Dec 2017 15:46:39 +0000 (10:46 -0500)]
Appveyor: stop testing on VS 2013
re2 requires VS2015 or later since:
https://github.com/google/re2/commit/
97957299d1c9f7617cfe653f344536d733582d9e
Andrey Tuganov [Fri, 8 Dec 2017 22:57:12 +0000 (17:57 -0500)]
Add validator checks for sparse image opcodes
Pierre Moreau [Wed, 29 Nov 2017 23:49:23 +0000 (00:49 +0100)]
Support OpenCL 1.2 and 2.0 target environments
include: Add target environment enums for OpenCL 1.2 and 2.0
Validator: Validate OpenCL capabilities
Update validate capabilities to handle embedded profiles
Add test for OpenCL capabilities validation
Update messages to mention the OpenCL profile used
Re-format val_capability_test.cpp
David Neto [Mon, 11 Dec 2017 20:50:51 +0000 (15:50 -0500)]
AppVeyor: Put VS 2017 first
VS 2017 is the newest compiler, with the most interesting feedback.
Place it first so we get its feedback first.
David Neto [Mon, 11 Dec 2017 17:05:04 +0000 (12:05 -0500)]
Force gtest to expose ::testing::Combine
Work around faulty logic in googletest, where ::testing::Combine
is accidentally disabled for VS 2017.
See https://github.com/google/googletest/issues/1352
Andrey Tuganov [Mon, 11 Dec 2017 17:33:11 +0000 (12:33 -0500)]
Reenable OpCopyObject validation rules
Vulkan CTS fix has been submitted.
Alan Baker [Thu, 30 Nov 2017 22:03:06 +0000 (17:03 -0500)]
Add scalar replacement
Adds a scalar replacement pass. The pass considers all function scope
variables of composite type. If there are accesses to individual
elements (and it is legal) the pass replaces the variable with a
variable for each composite element and updates all the uses.
Added the pass to -O
Added NumUses and NumUsers to DefUseManager
Added some helper methods for the inst to block mapping in context
Added some helper methods for specific constant types
No longer generate duplicate pointer types.
* Now searches for an existing pointer of the appropriate type instead
of failing validation
* Fixed spec constant extracts
* Addressed changes for review
* Changed RunSinglePassAndMatch to be able to run validation
* current users do not enable it
Added handling of acceptable decorations.
* Decorations are also transfered where appropriate
Refactored extension checking into FeatureManager
* Context now owns a feature manager
* consciously NOT an analysis
* added some test
* fixed some minor issues related to decorates
* added some decorate related tests for scalar replacement
GregF [Fri, 8 Dec 2017 17:44:15 +0000 (10:44 -0700)]
MultiStore: Support OpVariable Initialization
Treat an OpVariable with initialization as if it was an OpStore.
With PR #1073, this completes work for issue #1017.
Pierre Moreau [Sat, 9 Dec 2017 20:50:38 +0000 (21:50 +0100)]
Add external/SPIRV-Headers to .gitignore
b93c066b allowed for both SPIRV-Headers and spirv-headers as valid
paths, but only the latter is being ignored by Git.
GregF [Thu, 7 Dec 2017 19:11:29 +0000 (12:11 -0700)]
SingleStore: Support OpVariable Initialization
Treat an OpVariable with initialization as if it was an OpStore.
This fixes issue #1017.
Steven Perron [Thu, 7 Dec 2017 15:55:57 +0000 (10:55 -0500)]
Add option to spirv-opt to skip the validator.
The option --skip-validation is added. When used it will skip the
validation step.
Also rearranged the help text to fix two options that are out of order.
Diego Novillo [Thu, 7 Dec 2017 21:42:27 +0000 (16:42 -0500)]
Add a new constant manager class.
This patch adds a new constant manager class to interface with
analysis::Constant. The new constant manager lives in ir::IRContext
together with the type manager (analysis::TypeManager).
The new analysis::ConstantManager is used by the spec constant folder
and the constant propagator (in progress).
Another cleanup introduced by this patch removes the ID management from
the fold spec constant pass, and ir::IRContext and moves it to
ir::Module. SSA IDs were maintained by IRContext and Module. That's
pointless and leads to mismatch IDs. Fixed by moving all the bookkeeping
to ir::Module.
Steven Perron [Mon, 4 Dec 2017 17:29:51 +0000 (12:29 -0500)]
Add global redundancy elimination
Adds a pass that looks for redundant instruction in a function, and
removes them. The algorithm is a hash table based value numbering
algorithm that traverses the dominator tree.
This pass removes completely redundant instructions, not partially
redundant ones.
Steven Perron [Thu, 7 Dec 2017 03:09:20 +0000 (22:09 -0500)]
Kill names and decoration in inlining.
Currently when inlining a call, the name and decorations for the result of the
call is not deleted. This should be changed. Added a test for this as well.
This fixes issue #622.
Victor Lomuller [Mon, 4 Dec 2017 14:36:05 +0000 (14:36 +0000)]
Add depth first iterator for trees
- Add generic depth first iterator
- Update the dominator tree to use this iterator instead of "randomly"
iterate over the nodes
Diego Novillo [Wed, 6 Dec 2017 19:56:56 +0000 (14:56 -0500)]
Revert extraneous changes from commit
8ec62deb2.
Commit
8ec62deb2 merged the code from PR #810, but it also re-introduces
code that had been removed in #885.
This patch removes the (now superfluous code).
Stephen McGroarty [Mon, 27 Nov 2017 21:21:26 +0000 (21:21 +0000)]
Dominator Tree Analysis (#3)
Support for dominator and post dominator analysis on ir::Functions. This patch contains a DominatorTree class for building the tree and DominatorAnalysis and DominatorAnalysisPass classes for interfacing and caching the built trees.
Diego Novillo [Tue, 5 Dec 2017 16:28:12 +0000 (11:28 -0500)]
Sort flags in help message - NFC.
It's slightly easier to read flags from --help if they're sorted.
Lei Zhang [Tue, 5 Dec 2017 15:55:00 +0000 (10:55 -0500)]
CMake: allow both SPIRV-Headers and spirv-headers
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/1057
Andrey Tuganov [Tue, 5 Dec 2017 15:15:51 +0000 (10:15 -0500)]
Add composite instruction validation pass
Validates instructions in the opcode range from OpVectorExtractDynamic
to OpTranspose.
Lei Zhang [Tue, 5 Dec 2017 03:43:26 +0000 (22:43 -0500)]
Do not zip and deploy for check formatting
Lei Zhang [Tue, 5 Dec 2017 00:39:00 +0000 (19:39 -0500)]
Go back to root directory
Lei Zhang [Fri, 1 Dec 2017 03:24:13 +0000 (22:24 -0500)]
Travis CI: add clang-format check
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/1029
Diego Novillo [Mon, 4 Dec 2017 20:41:41 +0000 (15:41 -0500)]
Update .appveyor.yml
Andrey Tuganov [Mon, 4 Dec 2017 17:50:47 +0000 (12:50 -0500)]
Fix some of the known issues in image validation
Applied some of the spec clarifications made in conversation with
@johnkslang.
Steven Perron [Mon, 4 Dec 2017 17:29:51 +0000 (12:29 -0500)]
DCEInst kill the same instruction twice.
In DCEInst, it is possible that the same instruction ends up in the
queue multiple times, if the same id is used multiple times in the
same instruction.
The solution is to keep the ids in a set, to ensure no duplication in
the list.
Diego Novillo [Mon, 4 Dec 2017 20:45:56 +0000 (15:45 -0500)]
Change Release builds to Release with debug info on Linux
For Linux builds, we want to add debug information on the generated binary (for timing and profiling purposes). This patch changes Release builds to RelWithDebInfo.
Diego Novillo [Mon, 4 Dec 2017 20:28:21 +0000 (15:28 -0500)]
Remove cfg_ field from SSAPropagator class - NFC.
When I moved the CFG into IRContext
(https://github.com/KhronosGroup/SPIRV-Tools/pull/1019), I forgot to
update SSAPropagator to stop requiring one.
Fixed with this patch.
Steven Perron [Tue, 21 Nov 2017 19:47:46 +0000 (14:47 -0500)]
Change IRContext::KillInst to delete instructions.
The current method of removing an instruction is to call ToNop. The
problem with this is that it leaves around an instruction that later
passes will look at. We should just delete the instruction.
In MemPass there is a utility routine called DCEInst. It can delete
essentially any instruction, which can invalidate pointers now that they
are actually deleted. The interface was changed to add a call back that
can be used to update any local data structures that contain
ir::Intruction*.
Steven Perron [Mon, 27 Nov 2017 20:07:34 +0000 (15:07 -0500)]
Compute value number when the value table is constructed.
Computing the value numbers on demand, as we do now, can lead to
different results depending on the order in which the users asks for
the value numbers. To make things more stable, we compute them ahead
of time.
Daan Wendelen [Sun, 3 Dec 2017 20:27:21 +0000 (21:27 +0100)]
Fixed typo that leaked to the binary
The typo was found by lintian when I was packaging glslang
Diego Novillo [Fri, 1 Dec 2017 18:10:34 +0000 (13:10 -0500)]
Add simplified instructions for pushing a reviewed PR.
Lei Zhang [Fri, 1 Dec 2017 04:06:55 +0000 (23:06 -0500)]
Travis: mark MacOS builds as optional
MacOS support in Travis is flakey right now. MacOS build jobs
take a long time to start.
We have extensive checks for Linux and Windows, which should give
us confidence.
Diego Novillo [Fri, 1 Dec 2017 17:17:47 +0000 (12:17 -0500)]
Re-format CONTRIBUTING.md - NFC.
I'm about to change this file. I re-formatted it for easier editing.
Lei Zhang [Thu, 30 Nov 2017 23:01:11 +0000 (18:01 -0500)]
Fix Dref type check in validator
Dref should be of 32-bit scalar floating type.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/1012
Lei Zhang [Fri, 1 Dec 2017 02:12:23 +0000 (21:12 -0500)]
Appveyor: use ninja instead of MSBuild
Pierre Moreau [Thu, 30 Nov 2017 21:32:44 +0000 (22:32 +0100)]
Opt: Remove unused lambda captures
Those are reported as errors by clang 5.0.0, due to the flags -Werror
and -Wunused-lambda-capture.
Lei Zhang [Thu, 30 Nov 2017 21:35:22 +0000 (16:35 -0500)]
Support outputting ANSI color escape sequences in library
Previously we required _PRINT to enable _COLOR, which forbids
outputting colored disassembly into a string in library.
This commit will allow library users to request enabling
ANSI color escape sequences.
David Neto [Wed, 29 Nov 2017 20:58:35 +0000 (15:58 -0500)]
Erase decorations removed from internal collections
Fixes Android arm-64-v8a build with NDK r14. That's because
we no longer ignore the result of the std::remove.
David Neto [Fri, 24 Nov 2017 19:18:17 +0000 (14:18 -0500)]
Fix validation of group ops in SPV_AMD_shader_ballot
This needs custom code since the rules from the extension
are not encoded in the grammar.
Changes are:
- The new group instructions don't require Group capability
when the extension is declared.
- The Reduce, InclusiveScan, ExclusiveScan normally require the Kernel
capability, but don't when the extension is declared.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/991
Diego Novillo [Wed, 29 Nov 2017 18:36:17 +0000 (13:36 -0500)]
Fix #1034 - Give Edge::operator<() weak ordering semantics.
This should fix #1034. It changes the predicate on operator< to use
label IDs from each block and compares them as std:pair to define a weak
ordering for std::set.
Andrey Tuganov [Wed, 22 Nov 2017 21:57:37 +0000 (16:57 -0500)]
Validate OpTypeImage and OpTypeSampleImage
Added new validation rules to the validate image pass.
Daniel Schürmann [Wed, 29 Nov 2017 13:38:27 +0000 (14:38 +0100)]
Linker: Fix incorrect exit status.
Steven Perron [Fri, 24 Nov 2017 14:33:18 +0000 (09:33 -0500)]
Create CONTRIBUTING.md
This is intended to be a document that people who want to help the project
can get a quick overview of how things are done. Please comment and suggest
any changes.
GregF [Tue, 28 Nov 2017 23:18:05 +0000 (16:18 -0700)]
AggressiveDCE: Add merge and continue branches for live loop.
This ensures that an if-break is not eliminated from a loop.
This fixes issue #989
Lei Zhang [Mon, 27 Nov 2017 22:51:18 +0000 (17:51 -0500)]
Update README about the automatic master-tot relase
Diego Novillo [Mon, 27 Nov 2017 19:20:32 +0000 (14:20 -0500)]
Convert the CFG to an on-demand analysis - NFC.
This fixes some TODOs by moving the CFG into the IRContext as an
analysis.
Diego Novillo [Tue, 28 Nov 2017 13:27:10 +0000 (08:27 -0500)]
Fix windows build. unsigned vs signed comparison in EXPECT_EQ.
Diego Novillo [Fri, 17 Nov 2017 13:59:25 +0000 (08:59 -0500)]
Generic value propagation engine.
This class implements a generic value propagation algorithm based on the
conditional constant propagation algorithm proposed in
Constant propagation with conditional branches,
Wegman and Zadeck, ACM TOPLAS 13(2):181-210.
The implementation is based on
A Propagation Engine for GCC
Diego Novillo, GCC Summit 2005
http://ols.fedoraproject.org/GCC/Reprints-2005/novillo-Reprint.pdf
The purpose of this implementation is to act as a common framework for any
transformation that needs to propagate values from statements producing new
values to statements using those values.
Diego Novillo [Mon, 27 Nov 2017 19:40:03 +0000 (14:40 -0500)]
Fix windows build.
This fixes the lack of uint32_t definition in source/val/decoration.h.
Diego Novillo [Mon, 27 Nov 2017 15:16:41 +0000 (10:16 -0500)]
Re-format source tree - NFC.
Re-formatted the source tree with the command:
$ /usr/bin/clang-format -style=file -i \
$(find include source tools test utils -name '*.cpp' -or -name '*.h')
This required a fix to source/val/decoration.h. It was not including
spirv.h, which broke builds when the #include headers were re-ordered by
clang-format.
Andrey Tuganov [Fri, 24 Nov 2017 15:29:05 +0000 (10:29 -0500)]
Derivative opcodes require Fragment exec model
Added validator check that all derivative opcodes require Fragment
execution model.
Andrey Tuganov [Fri, 24 Nov 2017 15:55:05 +0000 (10:55 -0500)]
Relaxed OpImageWrite texel type check
David Neto [Fri, 24 Nov 2017 15:17:13 +0000 (10:17 -0500)]
Update CHANGES to mention fixes for 1007 and 1009
Andrey Tuganov [Fri, 24 Nov 2017 15:05:07 +0000 (10:05 -0500)]
Relaxed OpImageRead validation rules
Removed the check that result type of OpImageRead should be a vector4.
Will reenable/adapt once the spec is clarified on what the right
dimension should be.
Alan Baker [Fri, 24 Nov 2017 04:08:58 +0000 (23:08 -0500)]
Notify the context of instructions that are being erased.
Fixes use-after-free error in RemoveDuplicatesPass
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/1004
Andrey Tuganov [Thu, 23 Nov 2017 17:11:15 +0000 (12:11 -0500)]
Add validation checks for Execution Model
Currently checks that these instructions are called from entry points
with Fragment execution model.
OpImageImplicit*
OpImageQueryLod
OpKill
David Neto [Wed, 22 Nov 2017 22:03:55 +0000 (17:03 -0500)]
Test for pollution of the global namespace
Works on Linux only for now. That's a good start.
Move ValidateBinaryUsingContextAndValidationState into anonymous
namespace in source/validate.cpp.
Steven Perron [Thu, 23 Nov 2017 17:41:10 +0000 (12:41 -0500)]
Remove derivative instructions from the list of combinators.
These instructions compute their value based the value of the immediate
neighbours of the current fragment. This means the result is not
defined purely by the operands of the instruction.
David Neto [Thu, 23 Nov 2017 23:16:41 +0000 (18:16 -0500)]
Start v2017.2-dev
David Neto [Thu, 23 Nov 2017 23:12:23 +0000 (18:12 -0500)]
Finalize 2017.1
Updated CHANGES to cover main updates since 2017.0
Lei Zhang [Fri, 17 Nov 2017 21:50:43 +0000 (16:50 -0500)]
Add RegisterLegalizationPasses() into the interface
Add note to mention the use scenario. The original list came
from Glslang.
Alan Baker [Tue, 14 Nov 2017 19:11:50 +0000 (14:11 -0500)]
Adding new def -> use mapping container
Replaced representation of uses
* Changed uses from unordered_map<uint32_t, UseList> to
set<pairInstruction*, Instruction*>>
* Replaced GetUses with ForEachUser and ForEachUse functions
* updated passes to use new functions
* partially updated tests
* lots of cleanup still todo
Adding an unique id to Instruction generated by IRContext
Each instruction is given an unique id that can be used for ordering
purposes. The ids are generated via the IRContext.
Major changes:
* Instructions now contain a uint32_t for unique id and a cached context
pointer
* Most constructors have been modified to take a context as input
* unfortunately I cannot remove the default and copy constructors, but
developers should avoid these
* Added accessors to parents of basic block and function
* Removed the copy constructors for BasicBlock and Function and replaced
them with Clone functions
* Reworked BuildModule to return an IRContext owning the built module
* Since all instructions require a context, the context now becomes the
basic unit for IR
* Added a constructor to context to create an owned module internally
* Replaced uses of Instruction's copy constructor with Clone whereever I
found them
* Reworked the linker functionality to perform clones into a different
context instead of moves
* Updated many tests to be consistent with the above changes
* Still need to add new tests to cover added functionality
* Added comparison operators to Instruction
Adding tests for Instruction, IRContext and IR loading
Fixed some header comments for BuildModule
Fixes to get tests passing again
* Reordered two linker steps to avoid use/def problems
* Fixed def/use manager uses in merge return pass
* Added early return for GetAnnotations
* Changed uses of Instruction::ToNop in passes to IRContext::KillInst
Simplifying the uses for some contexts in passes
Lei Zhang [Thu, 23 Nov 2017 20:16:48 +0000 (15:16 -0500)]
Allow derived access chain without uses in access chain conversion