David Henningsson [Mon, 2 Jul 2012 10:09:06 +0000 (12:09 +0200)]
alsa-mixer: Add "Front Headphone" jack
Many desktops have headphone on the front and line outs on the back.
Sometimes this means that the headphone is labelled "Front Headphone Jack",
but the volume controls are only "Headphone Playback Volume", i e,
without the "Front" prefix.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
David Henningsson [Thu, 28 Jun 2012 13:40:17 +0000 (15:40 +0200)]
alsa-mixer: Always turn "Inverted Internal Mic" off
Some devices have inverted right channel, so when you add left and right,
the result is silence, or very faint sound. In recent kernels (3.5,
perhaps also 3.4) these are starting to be marked with a special
"Inverted Internal Mic" capture switch.
While we might want to add some reverse summing mechanism in the
future, for now, we just turn the thing off to avoid the problem of
recording silence.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
David Henningsson [Thu, 28 Jun 2012 13:35:38 +0000 (15:35 +0200)]
alsa-mixer: Add Phantom Jack support
For kernel 3.6, "phantom jack" kctls have been added. They serve as
a marker that a particular port exist. They were made so we can detect
that there actually are speakers and internal mic on a laptop, even if
there are no other indications (volume controls etc).
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
David Henningsson [Thu, 3 May 2012 13:39:18 +0000 (15:39 +0200)]
alsa-mixer: Add special profiles for some laptops missing speaker and/or internal mic
Several laptops have speaker ports, and/or internal mic ports, but we have
no way of detecting that. So we make the port(s) always show up for these
devices.
BugLink: https://bugs.launchpad.net/bugs/946232
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
poljar (Damir Jelić) [Thu, 28 Jun 2012 13:02:27 +0000 (15:02 +0200)]
man: Add latency offset documentation to the cli syntax.
The new latency offset command is now documented in the
pulse-cli-syntax man page.
poljar (Damir Jelic) [Thu, 28 Jun 2012 13:00:46 +0000 (15:00 +0200)]
pactl: Add set-latency-offset command.
This introduces a new command to allow setting the latency offset.
Also the card list command now shows the latency offset on the ports.
poljar (Damir Jelic) [Thu, 28 Jun 2012 13:00:45 +0000 (15:00 +0200)]
introspect: Add functions to handle the latency offset.
This includes updating the native protocol and the client API.
A new command was added to allow setting the latency offset.
Also the card list command now shows the latency offset if there
are ports available.
Update protocol to 27.
Paul Menzel [Sat, 19 May 2012 08:03:01 +0000 (10:03 +0200)]
Fix spelling of separated: s, sepera, separa, g
The used command for fixing the script is the following.
$ git grep sepera | cut --delimiter=: --fields=1 | xargs sed -i s,sepera,separa,g
This patch is motivated by a patch in Debian from Martin-Éric Racine [1].
[1] http://anonscm.debian.org/gitweb/?p=pkg-pulseaudio/pulseaudio.git;a=commitdiff;h=
70e7261a615141908c0cf366fd49e0fc0f550fbf
poljar (Damir Jelić) [Thu, 28 Jun 2012 11:17:21 +0000 (13:17 +0200)]
device-port: Send a subscription event when the offset changes.
When the offset changes a subscription event should be sent to the
relevant card.
poljar (Damir Jelić) [Fri, 29 Jun 2012 21:19:52 +0000 (23:19 +0200)]
conf-parser: Initialize the state to zero immediately.
Set the state variable immediately to zero so if we fail to open the
configuration file we don't check an uninitialized pointer and free an
nonexistent proplist.
Tanu Kaskinen [Fri, 8 Jun 2012 18:49:12 +0000 (21:49 +0300)]
Assume that the ports hashmap of cards is always non-NULL.
The hashmap is created in pa_card_new_data_init().
Tanu Kaskinen [Fri, 8 Jun 2012 18:49:11 +0000 (21:49 +0300)]
Assume that the profiles hashmap of ports is always non-NULL.
It's a valid assumption nowadays, because the hashmap is
created in pa_device_port_new().
Tanu Kaskinen [Fri, 8 Jun 2012 18:49:10 +0000 (21:49 +0300)]
card: Ensure that there's always at least one profile.
In practice there is always at least one profile, and I
don't think there will ever be cards without profiles.
Therefore, I added assertions to pa_card_new() stating that
the card new data must always contain at least one profile.
Now a lot of code can be simplified, because it's guaranteed
that the profiles hashmap and the active_profile field are
always non-NULL.
Tanu Kaskinen [Fri, 8 Jun 2012 18:49:09 +0000 (21:49 +0300)]
sink, source: Always create a hashmap for ports.
Having the hashmap sometimes NULL requires a lot of checking
here and there, so ensuring that the hashmap is always
non-NULL simplifies the code.
Tanu Kaskinen [Fri, 8 Jun 2012 16:36:45 +0000 (19:36 +0300)]
card: Don't crash if someone gives NULL name to pa_card_set_profile().
In my opinion, pa_card_set_profile() should assert that name
is not NULL, and it would be the job of the client interface
to filter out NULLs from the client input, but this is done
this way also when setting sink and source ports, so for
consistency I'll do this this way for now.
Tanu Kaskinen [Fri, 13 Apr 2012 11:48:30 +0000 (14:48 +0300)]
pactl: Print card port properties with the "list" command.
Tanu Kaskinen [Fri, 13 Apr 2012 11:48:29 +0000 (14:48 +0300)]
native: Send the actual port proplists with card info.
Tanu Kaskinen [Fri, 13 Apr 2012 11:48:28 +0000 (14:48 +0300)]
alsa-mixer: Add support for defining port property lists in the path configuration files.
Tanu Kaskinen [Fri, 13 Apr 2012 11:48:27 +0000 (14:48 +0300)]
conf-parser: Add support for parsing property lists.
Tanu Kaskinen [Fri, 13 Apr 2012 11:48:26 +0000 (14:48 +0300)]
conf-parser: Pass parser state in a struct also for parse callbacks.
As suggested by Maarten Bosmans:
http://article.gmane.org/gmane.comp.audio.pulseaudio.general/12079
Tanu Kaskinen [Fri, 13 Apr 2012 11:48:25 +0000 (14:48 +0300)]
conf-parser: Pass parser state in a struct instead of function parameters.
I don't like long function parameter lists, and I plan to
add some more state data to the parser which would make the
parameter lists even longer without this refactoring.
Tanu Kaskinen [Fri, 13 Apr 2012 11:40:32 +0000 (14:40 +0300)]
tagstruct: Allow NULL proplist with pa_tagstruct_get_proplist().
module-tunnel doesn't care about the proplist contents, so
pa_tagstruct_get_proplist() is only used for removing the
data from the tagstruct buffer. In that case it's more
convenient to just pass NULL as the proplist argument.
Tanu Kaskinen [Fri, 13 Apr 2012 11:40:31 +0000 (14:40 +0300)]
proplist: Change proplist_name_valid() to be public function pa_proplist_key_valid().
I want to check the validity in pa_tagstruct_get_proplist(),
and I think also client applications might have use for this
function.
Tanu Kaskinen [Fri, 13 Apr 2012 11:32:12 +0000 (14:32 +0300)]
pulse: Use more intuitive indexing with port infos in introspect.c.
Tanu Kaskinen [Fri, 13 Apr 2012 11:31:44 +0000 (14:31 +0300)]
Fix a copy-paste error in PROTOCOL.
Arun Raghavan [Thu, 28 Jun 2012 14:01:37 +0000 (19:31 +0530)]
glib: Stop using g_source_get_current_time()
This function is now marked as deprecated. It is functionally identical
to g_get_current_time(), so we use that instead. The GLib API docs
suggest g_source_get_time(), but that does not provide wallclock time
(which is what the pa_time_event API expects), so we don't use it.
Tanu Kaskinen [Thu, 28 Jun 2012 13:34:56 +0000 (16:34 +0300)]
sink, source: Fix setting the latency offset when the sink/source is unlinked.
poljar (Damir Jelić) [Wed, 27 Jun 2012 15:38:42 +0000 (17:38 +0200)]
device-port: Change the latency offset type to a signed int.
The latency offset type should be signed (int64_t) so we can also add
a negative latency offset.
This also includes changing the type of the sink/source
offsets and updating pacmd so it handles negative numbers.
Ismo Puustinen [Fri, 15 Jun 2012 14:35:59 +0000 (17:35 +0300)]
ladspa: Added a python script for testing.
The python script uses the ladspa D-Bus interface for IPC testing.
Ismo Puustinen [Fri, 15 Jun 2012 14:35:58 +0000 (17:35 +0300)]
ladspa: D-Bus interface for setting algorithm parameters on-the-fly.
A new external D-Bus interface is registered and LADSPA algorithm
control parameters are exposed as a D-Bus property with setter and
getter support.
Deng Zhengrong [Sat, 23 Jun 2012 11:16:26 +0000 (19:16 +0800)]
xen: add the HAVE_CONFIG_H macro guard
Deng Zhengrong [Sat, 23 Jun 2012 11:15:14 +0000 (19:15 +0800)]
pacmd: add help info for 'set-log-target'
Deng Zhengrong [Sat, 23 Jun 2012 11:14:12 +0000 (19:14 +0800)]
build: Add gcov coverage support
Arun Raghavan [Thu, 28 Jun 2012 06:49:27 +0000 (12:19 +0530)]
pactl: Print sink-input/source-output corked status
Sending this out for review before committing since it changes pactl output.
poljar [Fri, 22 Jun 2012 18:55:55 +0000 (20:55 +0200)]
pacmd: Add functions to handle the latency offset
pacmd was extended so it can handle the new latency offset.
A new function was added so we can set the latency also the list
commands were extended to print the latency offset on the ports.
poljar [Fri, 22 Jun 2012 18:55:54 +0000 (20:55 +0200)]
sink, source: Add a latency offset which is inherited from the port
A latency offset variable was added to the sink/source struct.
Also a function was introduced to update the latency offset of the
sink/source and a new message type was introduced so we can send the latency
offset to the IO thread.
The latency offset is automatically populated with the latency from the
currently active port.
poljar [Fri, 22 Jun 2012 18:55:53 +0000 (20:55 +0200)]
device-port: Add a latency variable to the port struct
A latency offset variable was added to the port struct and a function to
set the latency offset.
The latency offset does nothing for now, but it will be later added to
the sink/source latency.
Mihai Moldovan [Tue, 29 May 2012 07:21:54 +0000 (09:21 +0200)]
core-util: use the generic PATH_MAX variant of pa_realpath on Mac OS X
realpath() on OS X behaves GNUish and accepts NULL for resolved_name
only on 10.6 and higher. Older versions will crash, if resolved_name is
NULL.
All versions define PATH_MAX, though. Better play it safe and use the
generic PATH_MAX version of pa_realpath on Mac OS X systems.
Signed-off-by: Mihai Moldovan <ionic@ionic.de>
Frédéric Danis [Tue, 12 Jun 2012 13:49:50 +0000 (15:49 +0200)]
bluetooth: Fix bluetooth.nrec property not updated
PropertyChanged signal of org.BlueZ.MediaTransport is processed in
pa_bluetooth_transport_parse_property() which updates t->nrec.
This is called by :
- First by filter_cb() of bluetooth-util.c
- Then by filter_cb() of module-bluetooth-device.c which retrieve value
of t->nrec before calling parse function, then it checks if t->nrec
has changed before updating bluetooth.nrec property.
As t->nrec has alreday been changed during first process, property
update is never performed.
This patch creates a new hook in pa_bluetooth_transport called
PA_BLUETOOTH_TRANSPORT_HOOK_NREC_CHANGED.
The hook is fired by bluetooth-util.c when the transport's NREC
property changes.
module-bluetooth-device.c won't listen the PropertyChanged signal of
MediaTransport anymore. Instead, it will use the hook in
pa_bluetooth_transport to get a notification when the NREC property
changes, and update the sink or source proplist accordingly.
const qualifier for returned pointer of
pa_bluetooth_discovery_get_transport() is removed.
Arun Raghavan [Mon, 11 Jun 2012 07:45:00 +0000 (13:15 +0530)]
auth: Create cookie directory if it doesn't exist
Makes sure the cookie directory exists before trying to create the
cookie. This might be the case on freshly installed headless systems.
Arun Raghavan [Mon, 11 Jun 2012 07:42:50 +0000 (13:12 +0530)]
core-util: Make pa_make_secure_dir() act like mkdir -p
This makes pa_make_secure_dir() create any missing parent directories in
the given path as well. This is useful, for example, on a pristine
system with a clean $HOME that needs ~/.config/pulse/ to be created when
~/.config does not exist.
Arun Raghavan [Wed, 13 Jun 2012 11:01:59 +0000 (16:31 +0530)]
core-util: Add a pa_split_in_place() string utility function
For specialised uses of pa_split() such as finding substrings for
comparison, this avoids the need to repeatedly allocate and deallocate
memory.
Arun Raghavan [Wed, 13 Jun 2012 10:59:35 +0000 (16:29 +0530)]
role-cork: Fix a minor leak
Tanu Kaskinen [Thu, 5 Apr 2012 13:24:48 +0000 (16:24 +0300)]
native: Don't save device, volume or mute of new streams.
Specifying the volume when creating a new stream is not an
equivalent act as setting the volume with a volume control
application. When creating a new stream, stream-restore
shouldn't save the volume, but when changing the volume,
then saving it is ok. For example, when I say
"paplay --volume=10000 somefile.wav", I mean that I want the
new stream to have volume 10000. I don't mean that also
future paplay invocations (without the --volume option)
should have that same volume.
This patch effectively reverts
546bcf3f2f9711f0d08c21c3b775994844e7e2a2.
Arti Trivedi Bora [Tue, 5 Jun 2012 19:58:16 +0000 (01:28 +0530)]
daemon: use pa_streq instead of strcmp
Arti Trivedi Bora [Tue, 5 Jun 2012 19:58:15 +0000 (01:28 +0530)]
tests: use pa_streq instead of strcmp
Arti Trivedi Bora [Tue, 5 Jun 2012 19:58:14 +0000 (01:28 +0530)]
pulsecore: Use pa_streq instead of strcmp.
Arti Trivedi Bora [Tue, 5 Jun 2012 19:58:13 +0000 (01:28 +0530)]
modules: Use pa_streq instead of strcmp.
Tanu Kaskinen [Fri, 8 Jun 2012 16:00:14 +0000 (19:00 +0300)]
device-port: Remove an out-of-date comment.
poljar [Mon, 4 Jun 2012 17:35:41 +0000 (19:35 +0200)]
bluetooth: Add ports to the bluetooth sink/source
The bluetooth device should have ports so we can attach a latency to
the ports.
Every profile (a2dp, hsp...) has his own set of ports depending on the
number of sinks and sources it provides.
Tanu Kaskinen [Mon, 4 Jun 2012 14:44:20 +0000 (17:44 +0300)]
device-port: Create the profiles hashmap at initialization.
I doesn't make sense to require all callers of
pa_device_port_new() to create the hashmap themselves. There
are and there will be no cases where a port without any
profiles would be desired.
Deng Zhengrong [Wed, 6 Jun 2012 20:16:51 +0000 (04:16 +0800)]
x11: fix the wrong parameter sequence in pax11publish
poljar [Wed, 30 May 2012 12:27:26 +0000 (14:27 +0200)]
pacmd: Add unloading modules by name.
pacmd should allow unloading modules by name.
The command_unload() function was expanded to handle names while
unloading modules.
If there are multiple modules with the same name all
of them will be unloaded.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=48289
poljar [Wed, 30 May 2012 12:27:25 +0000 (14:27 +0200)]
pactl: Add unloading modules by name.
pactl should allow unloading modules by name.
If there are multiple modules with the same name all
of them will be unloaded.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=48289
Eero Nurkkala [Thu, 31 May 2012 07:44:23 +0000 (10:44 +0300)]
alsa-source: add missing header 'signal.h'
Compilation with -DDEBUG_TIMING fails due to a missing header:
modules/alsa/alsa-source.c: In function 'check_left_to_record':
modules/alsa/alsa-source.c:426:9: warning: implicit declaration of function 'raise' [-Wimplicit-function-declaration]
modules/alsa/alsa-source.c:426:9: error: 'SIGTRAP' undeclared (first use in this function)
Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
Eero Nurkkala [Thu, 31 May 2012 07:44:22 +0000 (10:44 +0300)]
alsa-sink: add missing header 'signal.h'
Compilation with -DDEBUG_TIMING fails due to a missing header:
modules/alsa/alsa-sink.c: In function 'check_left_to_play':
modules/alsa/alsa-sink.c:453:9: warning: implicit declaration of function 'raise' [-Wimplicit-function-declaration]
modules/alsa/alsa-sink.c:453:9: error: 'SIGTRAP' undeclared (first use in this function)
Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
Harsh Prateek Bora [Tue, 29 May 2012 12:28:12 +0000 (17:58 +0530)]
pulsecore: Use PA_IDXSET_FOREACH wherever applicable.
Signed-off-by: Harsh Prateek Bora <harsh.bora@linaro.org>
Harsh Prateek Bora [Tue, 29 May 2012 12:28:11 +0000 (17:58 +0530)]
modules: Use PA_IDXSET_FOREACH wherever applicable.
Signed-off-by: Harsh Prateek Bora <harsh.bora@linaro.org>
Jarkko Suontausta [Tue, 22 May 2012 12:58:33 +0000 (15:58 +0300)]
bluetooth: Release transport when the pa_rtpoll_run loop finishes.
Based on a patch by Marko Ollonen.
Marc-Antoine Perennou [Thu, 17 May 2012 20:50:22 +0000 (22:50 +0200)]
udev: Don't use deprecated udev_get_*_path() functions
[These symbols were removed in libudev.so.1.0.0. Replace them with
hardcoded strings. -- heftig]
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Peter Meerwald [Thu, 24 May 2012 15:52:56 +0000 (17:52 +0200)]
pipe: check return value of mkfifo()
Peter Meerwald [Thu, 24 May 2012 15:52:55 +0000 (17:52 +0200)]
pipe: whitespace and log output cleanup
Deng Zhengrong [Fri, 25 May 2012 02:17:51 +0000 (10:17 +0800)]
daemon: use pa_streq instead of plain strcmp
Just noticed that in daemon-conf.c, it uses plain strcmp(),
while in PulseAudio, it should be better to use pa_streq().
Deng Zhengrong [Fri, 25 May 2012 02:16:04 +0000 (10:16 +0800)]
cli: Add set-log-target command for pacmd
David Henningsson [Fri, 18 May 2012 20:29:41 +0000 (22:29 +0200)]
once: Fix race causing pa_once to sometimes run twice
There was a race in the existing code that could cause the pa_once code
to be run twice, see:
http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-April/013354.html
Therefore the existing implementation was rewritten to instead look like
the reference implementation here:
http://www.hpl.hp.com/research/linux/atomic_ops/example.php4
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
poljar [Mon, 21 May 2012 19:42:20 +0000 (21:42 +0200)]
native: Use foreach to iterate trough modules.
The PA_IDXSET_FOREACH is easier to read than the standard for loop.
Also pa_streq() should be used for checking string equality.
Frédéric Danis [Tue, 15 May 2012 13:55:36 +0000 (15:55 +0200)]
bluetooth: Fix crash on disconnection
When a Bluetooth headset is connected only to HFP profile (not connected
to A2DP) and host streams to it, a crash occurs if host disconnects.
When HFP disconnects, audio thread will fail on POLLHUP then generate
a message to set PA profile to Off before ending.
If this message is managed before PA unload bluetooth device module,
all works fine.
But, if this message is managed during module unload, this finish by
re-entrance in release code (stop_thread) and a crash.
This fix prevents to process profile change when module is unloading.
Lennart Poettering [Tue, 15 May 2012 23:06:17 +0000 (01:06 +0200)]
gnome: start PA early in the gnome session
Lennart Poettering [Tue, 15 May 2012 21:59:33 +0000 (23:59 +0200)]
auth: move cookie file to ~/.config/pulse/cookie
In order to follow XDG basedir, read the cookie file from
~/.config/pulse/cookie if possible, but fall back to the old file.
if it doesn't exist.
Lennart Poettering [Tue, 15 May 2012 21:25:00 +0000 (23:25 +0200)]
core-util: when searching for configuration files, honour XDG basedir spec
Lennart Poettering [Tue, 15 May 2012 21:24:09 +0000 (23:24 +0200)]
man: update man pages to only refer to the new place for the configuration files
Lennart Poettering [Tue, 15 May 2012 21:13:28 +0000 (23:13 +0200)]
core-util: move configuration home directory from ~/,pulse to ~/.config/pulse to follow XDG basedir spec
If ~/.pulse/ already exists we stick to it in order not to lose
configuration and so that pulse configuration may still be shared across
the network with different PA versions.
Lennart Poettering [Tue, 15 May 2012 17:06:53 +0000 (19:06 +0200)]
util: hook up pa_get_runtime_dir() with XDG_RUNTIME_DIR
Lennart Poettering [Tue, 15 May 2012 14:24:22 +0000 (16:24 +0200)]
context: get rid of really old runtime dir logic, i.e. break compat with >4y-old PA
Lennart Poettering [Tue, 15 May 2012 14:08:40 +0000 (16:08 +0200)]
rtkit: update drop-in files
Lennart Poettering [Tue, 15 May 2012 14:06:42 +0000 (16:06 +0200)]
build-sys: remove HAL support, it's obsolete since years
Lennart Poettering [Tue, 15 May 2012 12:17:58 +0000 (14:17 +0200)]
build-sys: readd stub makefiles to subdirectories to make building with emacs easier
Lennart Poettering [Tue, 15 May 2012 12:12:38 +0000 (14:12 +0200)]
util: use the return value of gethosid() as fallback, not the address of the function
Yikes!
Lennart Poettering [Tue, 15 May 2012 12:10:34 +0000 (14:10 +0200)]
util: /etc/machine-id should be tried first, the D-Bus only as fallback for legacy systems
Lennart Poettering [Tue, 15 May 2012 12:06:46 +0000 (14:06 +0200)]
proplist: document new meaning of the session ID
Lennart Poettering [Tue, 15 May 2012 12:04:31 +0000 (14:04 +0200)]
util: XDG_SESSION_COOKIE is unsuitable as session ID
XDG_SESSION_COOKIE was supposed to be used for access control to the
session and should not be exposed to other users.
Replace usage of XDG_SESSION_COOKIE by XDG_SESSION_ID which is the right
choice here since it is actually a proper session ID that may be
published.
Arun Raghavan [Mon, 14 May 2012 06:51:45 +0000 (12:21 +0530)]
sink-input,source-output: Avoid unneccessary rate updates
This makes sure we only call sink/source update_rate() if the stream
being woken up has a sample spec that doesn't match the corresponding
device'.
https://bugs.freedesktop.org/show_bug.cgi?id=49875
poljar [Sun, 6 May 2012 14:10:51 +0000 (16:10 +0200)]
pacmd: Added --help and --version descriptions to the man page.
The pacmd man page should show the available options. A simple
description for the --version and --help option was added.
Arun Raghavan [Fri, 11 May 2012 13:20:11 +0000 (18:50 +0530)]
build-sys: Bump soname
Double-bump since v1.99.2 got a bump but the commit never landed.
Paul Menzel [Tue, 24 Apr 2012 21:31:32 +0000 (23:31 +0200)]
Correct spelling of PulseAudio
• s,Pulseaudio,PulseAudio,
• One last occurence of this “error” is in the French translation.
Arun Raghavan [Fri, 11 May 2012 12:02:20 +0000 (17:32 +0530)]
bluetooth: Fix crash due to usage of pa_bool_t instead of dbus_bool_t
pa_bool_t and dbus_bool_t cannot be used interchangably since their size
might (and do) vary. This caused a crash on some systems which was
reported and root caused by: Aidan Thornton <makosoft@googlemail.com>.
Ref: https://bugs.gentoo.org/show_bug.cgi?id=398097
Tanu Kaskinen [Tue, 1 May 2012 17:09:12 +0000 (20:09 +0300)]
alsa: Add support for sound cards with 4-channel input.
Changes in v2:
- Call the mapping a generic 4-channel input mapping
instead of a 4-channel mic array mapping. The mapping
will be used also by sound cards that have two stereo
input jacks, so in those cases talking about mic arrays
is wrong.
- Added a comment about using the "hw" device name.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=45813
Tanu Kaskinen [Thu, 10 May 2012 06:19:23 +0000 (09:19 +0300)]
resampler: Add support for resamplers that consume less data than asked.
libsamplerate_resample() assumed that src_process() would
always consume the whole input buffer. That was an invalid
assumption leading to crashes.
This patch adds a leftover memchunk for storing any
non-consumed input. When pa_resampler_run() is called next
time, the leftover is prepended to the new input.
Changes in v3:
- Make the calculations in pa_resampler_result() and
pa_resampler_max_block_size() more readable and more
correct.
- Rework the leftover storing: instead of using a dedicated
buffer for it, store it in the beginning of remap_buf.
This can avoid some memory copying. (The idea was
suggested by Wang Xingchao.)
- Use a generic save_leftover() function instead of doing
the leftover copying in the resampler implementation.
- Use the leftover logic also with the speex and ffmpeg
resamplers.
[ed: dropped the speex bit since the API guarantees that
it will consume everything -- Arun]
Changes in v2:
- If add_leftover() is called with zero-length input while
the leftover length is non-zero, we don't try to acquire
the input memblock.
- Instead of taking a reference to the original input in
libsamplerate_resample(), we copy the leftover data to a
new memblock. This is done, because otherwise, if the
input is one of the internal buffers, the data can get
overwritten before reading it in add_leftover().
- Store add_leftover_buf size in bytes instead of samples
(more convenient, but less consistent with other code).
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=47156
Tanu Kaskinen [Thu, 10 May 2012 06:19:22 +0000 (09:19 +0300)]
resampler: Use more descriptive buffer names.
Tanu Kaskinen [Thu, 10 May 2012 06:19:21 +0000 (09:19 +0300)]
resampler: Use pa_xnew0() to avoid manual zeroing.
poljar [Tue, 1 May 2012 21:17:22 +0000 (23:17 +0200)]
pacmd: Added --help and --version options.
All utilities should have the --help and --version command line options.
These two were added to pacmd, also the goto label was changed from fail
to quit like in the other utilities.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=45030
Tanu Kaskinen [Wed, 25 Apr 2012 08:25:16 +0000 (11:25 +0300)]
echo-cancel: Clarify function call contexts.
Tanu Kaskinen [Wed, 25 Apr 2012 07:51:38 +0000 (10:51 +0300)]
echo-cancel: Fix memblockq length check.
In addition to changing "plen > u->blocksize" to "plen >=
u->blocksize", I also removed one of the duplicated ifs.
Tanu Kaskinen [Wed, 25 Apr 2012 06:49:08 +0000 (09:49 +0300)]
echo-cancel: Drop the correct amount of samples when skipping.
Paul Menzel [Tue, 24 Apr 2012 21:36:07 +0000 (23:36 +0200)]
doc: Add entry for correct spelling
Due to the formatting of `README` the only occurence of PulseAudio in a
text is capitalized. People reading `README` should at least see the
correct spelling once.
In contrast to reformat just add a spelling section as an easy solution.
Since it is not that important the last place in the ordering might
suffice.
David Henningsson [Wed, 18 Apr 2012 09:41:48 +0000 (11:41 +0200)]
sink/source.h: Clarify set_port comment
State which thread calls set_port in which scenario.
Reported-by: Jyri Sasha <oku@iki.fi>
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Peter Meerwald [Fri, 6 Apr 2012 13:06:29 +0000 (15:06 +0200)]
pulse: Fix warning in introspect.h; minor rewording and punctuation.
Peter Meerwald [Fri, 6 Apr 2012 13:06:28 +0000 (15:06 +0200)]
pulse: Clarify proplist doxygen documentation.
Peter Meerwald [Fri, 6 Apr 2012 13:06:27 +0000 (15:06 +0200)]
core: Fix comments.
Peter Meerwald [Fri, 6 Apr 2012 13:06:26 +0000 (15:06 +0200)]
echo-cancel: Upper/lowercase in comment.