LLVM GN Syncbot [Tue, 2 Jun 2020 20:36:52 +0000 (20:36 +0000)]
[gn build] Port
f99d5f8c32a
Paula Toth [Tue, 2 Jun 2020 20:25:03 +0000 (13:25 -0700)]
[libc] Remove integration test target from check libc.
Summary:
This is failing on the asan build because we use `-nostdlib`.
I also took this opportunity to make the target name match the naming structure we've been using.
Reviewers: sivachandra
Reviewed By: sivachandra
Subscribers: mgorny, tschuett, ecnelises, libc-commits
Tags: #libc-project
Differential Revision: https://reviews.llvm.org/D81029
HazemAbdelhafez [Tue, 2 Jun 2020 20:22:38 +0000 (16:22 -0400)]
[mlir][spirv] Add support for matrix type
This commit adds basic matrix type support to the SPIR-V dialect
including type definition, IR assembly, parsing, printing, and
(de)serialization.
Differential Revision: https://reviews.llvm.org/D80594
Eric Christopher [Tue, 2 Jun 2020 20:23:41 +0000 (13:23 -0700)]
Fix up clang-tidy warnings around null and pointers.
Amy Kwan [Tue, 2 Jun 2020 18:01:27 +0000 (13:01 -0500)]
[DAGCombiner] Combine shifts into multiply-high
This patch implements a target independent DAG combine to produce multiply-high
instructions from shifts. This DAG combine will combine shifts for any type as
long as the MULH on the narrow type is legal.
For now, it is enabled on PowerPC as PowerPC is the only target that has an
implementation of the isMulhCheaperThanMulShift TLI hook introduced in
D78271.
Moreover, this DAG combine focuses on catching the pattern:
(shift (mul (ext <narrow_type>:$a to <wide_type>), (ext <narrow_type>:$b to <wide_type>)), <narrow_width>)
to produce mulhs when we have a sign-extend, and mulhu when we have
a zero-extend.
The patch performs the following checks:
- Operation is a right shift arithmetic (sra) or logical (srl)
- Input to the shift is a multiply
- Both operands to the shift are sext/zext nodes
- The extends into the multiply are both the same
- The narrow type is half the width of the wide type
- The shift amount is the width of the narrow type
- The respective mulh operation is legal
Differential Revision: https://reviews.llvm.org/D78272
Fangrui Song [Tue, 2 Jun 2020 20:16:44 +0000 (13:16 -0700)]
[Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition
Reviewed By: dblaikie, echristo
Differential Revision: https://reviews.llvm.org/D80883
Nathan James [Tue, 2 Jun 2020 20:20:58 +0000 (21:20 +0100)]
[NFC][ASTMatchers] StringRef-ify and Twine-ify ASTMatchers tests.
Jez Ng [Thu, 21 May 2020 22:26:35 +0000 (15:26 -0700)]
[lld-macho] Ensure reads from nlist_64 structs are aligned when necessary
My test refactoring in D80217 seems to have caused yaml2obj to emit
unaligned nlist_64 structs, causing ASAN'd lld to be unhappy. I don't
think this is an issue with yaml2obj though -- llvm-mc also seems to
emit unaligned nlist_64s. This diff makes lld able to safely do aligned
reads under ASAN builds while hopefully creating no overhead for regular
builds on architectures that support unaligned reads.
Reviewed By: thakis
Differential Revision: https://reviews.llvm.org/D80414
Jez Ng [Tue, 19 May 2020 14:57:14 +0000 (07:57 -0700)]
[lld-macho] Move all tests for erroneous inputs under invalid/
For consistency.
The no-id-dylib test was originally referencing the Inputs/ folder via a
relative path. Instead of updating that path, I decided to make the test
self-contained.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D80217
Jez Ng [Tue, 19 May 2020 03:28:50 +0000 (20:28 -0700)]
[lld-macho] Set __PAGEZERO size to 4GB
That's what ld64 uses for 64-bit targets. I figured it's best to make
this change sooner rather than later since a bunch of our tests are
relying on hardcoded addresses that depend on this value.
Reviewed By: smeenai
Differential Revision: https://reviews.llvm.org/D80177
Jez Ng [Mon, 18 May 2020 22:46:33 +0000 (15:46 -0700)]
[lld-macho] Error on encountering undefined symbols
... instead of silently emitting a reference to the zero address.
Reviewed By: smeenai
Differential Revision: https://reviews.llvm.org/D80169
Jez Ng [Fri, 15 May 2020 20:42:28 +0000 (13:42 -0700)]
[lld-macho] Add some relocation validation logic
I considered making a `Target::validate()` method, but I wasn't sure how
I felt about the overhead of doing yet another switch-dispatch on the
relocation type, so I put the validation in `relocateOne` instead...
might be a bit of a micro-optimization, but `relocateOne` does assume
certain things about the relocations it gets, and this error handling
makes that explicit, so it's not a totally unreasonable code
organization.
Reviewed By: smeenai
Differential Revision: https://reviews.llvm.org/D80049
Douglas Yung [Tue, 2 Jun 2020 20:14:09 +0000 (20:14 +0000)]
Fix test on PS4 linux bot.
Commit
301a6da8c24a09052e3bda10e90b450b7b39ffea changed the test and modified a CHECK
line that is inconsisent with similar lines elsewhere in the file and was causing failures
when run in slightly different configurations. This change makes the line more consistent
and should fix the bot failure.
link: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68593
Thomas Lively [Tue, 2 Jun 2020 20:14:27 +0000 (13:14 -0700)]
[WebAssembly] Eliminate range checks on br_tables
Summary:
Jump tables for most targets cannot handle out of range indices by
themselves, so LLVM emits range checks to guard the jump
tables. WebAssembly, on the other hand, implements jump tables using
the br_table instruction, which takes a default branch target as an
operand, making the range checks redundant. This patch introduces a
new MachineFunction pass in the WebAssembly backend to find and
eliminate the redundant range checks.
Reviewers: aheejin, dschuff
Subscribers: mgorny, sbc100, jgravelle-google, hiraditya, sunfish, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D80863
Jan Korous [Tue, 2 Jun 2020 17:17:01 +0000 (10:17 -0700)]
[Analyzer][WebKit] Check record definition is available in NoUncountedMembers checker
isRefCountable asserts that the record passed as an argument has a definition available.
Fixes: https://bugs.llvm.org/show_bug.cgi?id=46142
Differential Revision: https://reviews.llvm.org/D81017
kamlesh kumar [Tue, 2 Jun 2020 19:48:30 +0000 (20:48 +0100)]
[RISCV-V] Provide muldi3 builtin assembly implementation
Provides an assembly implementation of muldi3 for RISC-V, to solve bug 43388.
Since the implementation is the same as for mulsi3, that code was moved to
`riscv/int_mul_impl.inc` and is now reused by both `mulsi3.S` and `muldi3.S`.
Differential Revision: https://reviews.llvm.org/D80465
Thomas Lively [Tue, 2 Jun 2020 19:55:06 +0000 (12:55 -0700)]
[WebAssembly] Improve macro hygiene in wasm_simd128.h
Summary:
The shuffle intrinsic macros did not parenthesize usages of their
constant parameters, which could lead to incorrect results due to
operator precedence issues. This patch fixes the problem by adding the
missing paretheses.
Reviewers: aheejin
Subscribers: dschuff, sbc100, jgravelle-google, sunfish, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D80968
Paula Toth [Tue, 2 Jun 2020 19:13:57 +0000 (12:13 -0700)]
[libc] Add integration tests.
Summary:
This patch aims to add integration tests to check the following:
1) Header files are generated as expected.
2) Libc functions have the correct public name.
3) Libc functions have the correct return type and parameter types.
4) Symbols are exposed in the public lib.a files.
Reviewers: sivachandra, abrachet
Reviewed By: sivachandra
Subscribers: aheejin, ecnelises, dxf, mgorny, jfb, tschuett, libc-commits
Tags: #libc-project
Differential Revision: https://reviews.llvm.org/D79192
dstuttar [Tue, 2 Jun 2020 18:12:54 +0000 (19:12 +0100)]
[TableGen] Avoid generating switch with just default
Summary:
Switch with just default causes an MSVC warning (warning C4065: switch statement
contains 'default' but no 'case' labels).
Change-Id: I9ddeccdef93666256b5454b164b567b73b488461
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D81021
Alexey Bataev [Fri, 29 May 2020 21:56:07 +0000 (17:56 -0400)]
Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.
Summary:
Clang crashes when trying to finish function body. MaybeODRUseExprs is
not empty because of const static data member parsed in outer evaluation
context, upon call for isTypeIdInParens() function. It builds
annot_primary_expr, later parsed in ParseConstantExpression() in
inner constant expression evaluation context.
Reviewers: rjmccall, rsmith
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D80925
Diego Caballero [Tue, 2 Jun 2020 17:14:17 +0000 (20:14 +0300)]
Update 'git push' command in GettingStarted guide
'git push' command, without any other arguments, can do different
things depending on the local configuration of Git. This patch
updates the 'git push' command with extra arguments to be more
resilient to any local configuration.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D79964
Fangrui Song [Tue, 2 Jun 2020 18:25:03 +0000 (11:25 -0700)]
[Sema] Use isAlwaysUninit for -Wuninitialized-const-reference after D79895
Jonas Devlieghere [Tue, 2 Jun 2020 18:03:21 +0000 (11:03 -0700)]
[llvm-dwarfdump] Print [=<offset>] after --debug-* options in help output.
Some of the --debug-* options can take an optional offset. Although the
man page does a good job of making that clear, it's much harder to
discover from the help output.
Currently the only reference to this is the following sentence:
> Where applicable these parameters take an optional =<offset> argument
> to dump only the entry at the specified offset.
This patch changes the help output from to print [=<offset>] after the
options that take an offset.
--debug-info[=<offset>] - Dump the .debug_info section
rdar://problem/
63150066
Differential revision: https://reviews.llvm.org/D80959
Matt Arsenault [Tue, 2 Jun 2020 17:05:07 +0000 (13:05 -0400)]
AMDGPU: Fix a test to be more stable
The chained unconditional branches can be eliminated and it's not
relevant to the test.
Matt Arsenault [Tue, 2 Jun 2020 13:22:40 +0000 (09:22 -0400)]
AMDGPU: Don't run indexing mode switches with exec = 0
Add mode defs rather than special casing this like some of the other
instructions.
Matt Arsenault [Tue, 2 Jun 2020 01:37:13 +0000 (21:37 -0400)]
AMDGPU: Don't run mode switches with exec 0
These are scalar instructions that change vector instructions, so they
should not be executed without any active lanes.
The implementation of -amdgpu-skip-threshold also seem to be backwards
from expected, since decreasing it prevents removal.
Jacques Pienaar [Tue, 2 Jun 2020 17:47:06 +0000 (10:47 -0700)]
[mlir] Provide defaults to make enabling dumping simpler
Differential Revision: https://reviews.llvm.org/D80818
Hiroshi Yamauchi [Tue, 26 May 2020 18:02:17 +0000 (11:02 -0700)]
[PGO] Enable memcmp/bcmp size value profiling.
Summary: Following up D79751.
Reviewers: davidxl
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D80578
Sanjay Patel [Tue, 2 Jun 2020 15:06:15 +0000 (11:06 -0400)]
[InstCombine] add tests for select-of-select-shuffle; NFC
Sanjay Patel [Tue, 2 Jun 2020 14:54:33 +0000 (10:54 -0400)]
[InstCombine] regenerate complete test checks; NFC
Konrad Kleine [Tue, 2 Jun 2020 16:19:55 +0000 (12:19 -0400)]
[lldb] NFC remove DISALLOW_COPY_AND_ASSIGN
Summary:
This is how I applied my clang-tidy check (see
https://reviews.llvm.org/D80531) in order to remove
`DISALLOW_COPY_AND_ASSIGN` and have deleted copy ctors and deleted
assignment operators instead.
```
lang=bash
grep DISALLOW_COPY_AND_ASSIGN /opt/notnfs/kkleine/llvm/lldb -r -l | sort | uniq > files
for i in $(cat files);
do
clang-tidy \
--checks="-*,modernize-replace-disallow-copy-and-assign-macro" \
--format-style=LLVM \
--header-filter=.* \
--fix \
-fix-errors \
$i;
done
```
Reviewers: espindola, labath, aprantl, teemperor
Reviewed By: labath, aprantl, teemperor
Subscribers: teemperor, aprantl, labath, emaste, sbc100, aheejin, MaskRay, arphaman, usaxena95, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D80543
Zequan Wu [Tue, 2 Jun 2020 17:21:02 +0000 (10:21 -0700)]
[Clang] Add a new warning to warn when passing uninitialized variables as const reference parameters to a function
Summary:
Add a new warning -Wuninitialized-const-reference as a subgroup of -Wuninitialized to address a bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45624
This warning is controlled by -Wuninitialized and can be disabled by -Wno-uninitialized-const-reference.
The warning is diagnosed when passing uninitialized variables as const reference parameters to a function.
Differential Revision: https://reviews.llvm.org/D79895
Min-Yih Hsu [Tue, 26 May 2020 06:27:34 +0000 (06:27 +0000)]
Support ExtVectorType conditional operator
Extension vectors now can be used in element-wise conditional selector.
For example:
```
R[i] = C[i]? A[i] : B[i]
```
This feature was previously only enabled in OpenCL C. Now it's also
available in C. Not that it has different behaviors than GNU vectors
(i.e. __vector_size__). Extension vectors selects on signdness of the
vector. GNU vectors on the other hand do normal bool conversions. Also,
this feature is not available in C++.
Differential Revision: https://reviews.llvm.org/D80574
Pavel Labath [Tue, 2 Jun 2020 16:22:25 +0000 (18:22 +0200)]
[lldb] Skip tests exercising DW_OP_GNU_entry_value with dsymutil
It seems that this opcode needs explicit support in dsymutil. Disable
these tests until that is implemented.
Louis Dionne [Tue, 2 Jun 2020 16:21:01 +0000 (12:21 -0400)]
[libc++abi] Make sure we link in CrashReporterClient.a when it's present
When building the system libc++abi for Apple, we use CrashReporterClient
to provide better crash logs when calling abort(). This is exemplified by
the fact that we test for the presence of <CrashReporterClient.h> in
abort_message.cpp.
However, we must link against CrashReporterClient.a in order to get that
functionality, otherwise we get a linking error.
Simon Pilgrim [Tue, 2 Jun 2020 15:29:16 +0000 (16:29 +0100)]
TypeSymbolEmitter.h - reduce includes to forward declarations. NFC.
David Truby [Fri, 29 May 2020 13:03:21 +0000 (14:03 +0100)]
[flang] Fix release build flags.
Summary:
This patch removes the custom CMAKE_RELEASE_CXX_FLAGS variable.
This variable being set was having the effect of removing other important
Release flags, notably `-DNDEBUG`.
This patch may need to be accompanied by fixes for the macOS issues that
the removed comment mentions; I don't have a mac to test this on though so
hopefully a reviewer can help with that.
Reviewers: Andrzej, tskeith, sscalpone
Subscribers: mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D80794
Tom Weaver [Tue, 2 Jun 2020 15:19:43 +0000 (16:19 +0100)]
[Dexter] Add DexLimitSteps command and ConditionalController
* Adds DexLimitSteps Command.
* Add ConditionalController, a new DebuggerController type.
* 5 regression tests
* documentation
Reviewers: jmorse
Differential Revision: https://reviews.llvm.org/D79786
Tom Weaver [Tue, 2 Jun 2020 15:09:17 +0000 (16:09 +0100)]
[Dexter] Add os.path.normcase(...) transform to test path early.
When passing a test path, if the path points directly at a file, then
normcase would not be called on path.
This would change the expected lower case drive path, on windows, to be
uppercase. This patch simply calls normcase on the test path at the earliest
point possible to avoid this issue.
Reviewers: djtodoro, jmorse
Differential Revision: https://reviews.llvm.org/D78633
Dmitri Gribenko [Tue, 2 Jun 2020 15:01:50 +0000 (17:01 +0200)]
Reinstate the syntax tree test for 'static' in an array subscript
Reviewers: eduucaldas
Reviewed By: eduucaldas
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D81009
Alexey Bataev [Tue, 19 May 2020 20:29:36 +0000 (16:29 -0400)]
[OPENMP50]Initial codegen for 'affinity' clauses.
Summary:
Added initial codegen for 'affinity' clauses on task directives.
Emits next code:
```
kmp_task_affinity_info_t affs[<num_elems>];
void *td = __kmpc_task_alloc(..);
affs[<i>].base = &data_i;
affs[<i>].size = sizeof(data_i);
__kmpc_omp_reg_task_with_affinity(&loc, <gtid>, td, <num_elems>, affs);
```
The result returned by the call of `__kmpc_omp_reg_task_with_affinity`
function is ignored currently sincethe runtime currently ignores args
and returns 0 uncoditionally.
Reviewers: jdoerfert
Subscribers: yaxunl, guansong, sstefan1, llvm-commits, cfe-commits, caomhin
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D80240
Dmitri Gribenko [Tue, 2 Jun 2020 14:10:39 +0000 (16:10 +0200)]
Renamed Lang_C to Lang_C99, Lang_CXX to Lang_CXX03, and 2a to 20
Summary:
I think we would be better off with tests explicitly specifying the
language mode. Right now Lang_C means C99, but reads as "any C version",
or as "unspecified C version".
I also changed '-std=c++98' to '-std=c++03' because they are aliases (so
there is no difference in practice), because Clang implements C++03
rules in practice, and because 03 makes a nice sortable progression
between 03, 11, 14, 17, 20.
Reviewers: shafik, hlopko
Reviewed By: hlopko
Subscribers: jfb, martong, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D81000
Georgii Rymar [Tue, 26 May 2020 16:05:52 +0000 (19:05 +0300)]
[yaml2obj] - Allocate the file space for SHT_NOBITS sections in some cases.
This teaches yaml2obj to allocate file space for a no-bits section
when there is a non-nobits section in the same segment that follows it.
It was discussed in D78005 thread and matches GNU linkers and LLD behavior.
Differential revision: https://reviews.llvm.org/D80629
serge-sans-paille [Wed, 27 May 2020 15:42:28 +0000 (17:42 +0200)]
Use Pseudo Instruction to carry stack probing information
Instead of using a fake call and metadata to temporarily represent a probed
static alloca, use a pseudo instruction.
This is inspired by the SystemZ approach proposed in https://reviews.llvm.org/D78717.
Differential Revision: https://reviews.llvm.org/D80641
Haojian Wu [Thu, 28 May 2020 11:43:35 +0000 (13:43 +0200)]
[AST][RecoveryExpr] Build RecoveryExpr for "undef_var" cases.
Summary:
For a none-function-like unresolved expression, clang builds a TypoExpr
for it, and tries to correct it afterwards. If the typo-correction
fails, clang just drops the whole expr.
This patch improves the recovery strategy -- if the typo-correction
fails, we preserve the AST by degrading the typo exprs to recovery
exprs.
This would improve toolings for "undef_var" broken cases:
```
void foo();
void test() {
fo^o(undef_var); // go-to-def, hover still works.
}
```
TESTED=ran tests with this patch + turn-on-recovery-ast patch, it breaks
one declare_variant_messages testcase (the diagnostics are slightly
changed), I think it is acceptable.
```
Error: 'error' diagnostics seen but not expected:
 File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 16: expected 'match' clause on 'omp declare variant' directive
 File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 57: expected 'match' clause on 'omp declare variant' directive
error: 'warning' diagnostics expected but not seen:
 File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 47: the context selector 'kind' in the context set 'device' cannot have a score ('<invalid>'); score ignored
 File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 87: the context selector 'kind' in the context set 'device' cannot have a score ('<invalid>'); score ignored
error: 'warning' diagnostics seen but not expected:
 File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 47: the context selector 'kind' in the context set 'device' cannot have a score ('<recovery-expr>()'); score ignored
 File llvm-project/clang/test/OpenMP/declare_variant_messages.cpp Line 87: the context selector 'kind' in the context set 'device' cannot have a score ('<recovery-expr>()'); score ignored
6 errors generated.
```
Reviewers: sammccall, jdoerfert
Subscribers: sstefan1, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D80733
Matt Arsenault [Sat, 30 May 2020 23:37:57 +0000 (19:37 -0400)]
AMDGPU: Fix not using scalar loads for global reads in shaders
The pass which infers when it's legal to load a global address space
as SMRD was only considering amdgpu_kernel, and ignoring the shader
entry type calling conventions.
Haojian Wu [Tue, 2 Jun 2020 13:40:09 +0000 (15:40 +0200)]
Remove a comment-out llvm::errs debugging code, NFC.
Kadir Cetinkaya [Tue, 2 Jun 2020 13:22:26 +0000 (15:22 +0200)]
[lldb] Handle a new clang built-in type
Matt Arsenault [Mon, 1 Jun 2020 14:31:05 +0000 (10:31 -0400)]
AMDGPU: Fix clang side null pointer value for private
The change to fold_priv_arith looks strange to me, but this was
already the untested behavior for local.
Kadir Cetinkaya [Tue, 2 Jun 2020 09:52:55 +0000 (11:52 +0200)]
[clangd] Copy existing includes in ReplayPreamble
Summary:
ReplayPreamble was just grabbing the reference of IncludeStructure
passed to it and then replayed any includes seen so while exiting
built-in file.
This implies any include seen in built-in files being replayed as part
of preamble, even though they are not. This wasn't an issue until we've
started patching preambles, as includes from built-in files were not
mapped back to main-file.
This patch copies over existing includes at the time of
ReplayPreamble::attach and only replies those to prevent any includes
from the preamble patch getting mixed-in.
Reviewers: sammccall, jkorous
Subscribers: ilya-biryukov, MaskRay, dexonsmith, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D80988
Kadir Cetinkaya [Tue, 2 Jun 2020 12:30:52 +0000 (14:30 +0200)]
Revert "[clangd] Copy existing includes in ReplayPreamble"
This reverts commit
bff0c56ff92106afad22b54a90e1c612da4d6f99. I've
pushed the earlier version of the patch by mistake.
Nico Weber [Tue, 2 Jun 2020 12:18:42 +0000 (08:18 -0400)]
[gn build] (manually) port
44f989e7809
Igor Kudrin [Tue, 2 Jun 2020 11:50:01 +0000 (18:50 +0700)]
Fix a failing test.
Alex Zinenko [Tue, 2 Jun 2020 11:24:04 +0000 (13:24 +0200)]
[mlir] support materialization for 1-1 type conversions
Dialect conversion infrastructure supports 1->N type conversions by requiring
individual conversions to provide facilities to generate operations
retrofitting N values into 1 of the original type when N > 1. This
functionality can also be used to materialize explicit "cast"-like operations,
but it did not support 1->1 type conversions until now. Modify TypeConverter to
support materialization of cast operations for 1-1 conversions.
This also makes materialization specification more extensible following the
same pattern as type conversions. Instead of overloading a virtual function,
users or subclasses of TypeConversion can now register type-specific
materialization callbacks that will be called in order for the given type.
Differential Revision: https://reviews.llvm.org/D79729
Kadir Cetinkaya [Tue, 2 Jun 2020 09:52:55 +0000 (11:52 +0200)]
[clangd] Copy existing includes in ReplayPreamble
ReplayPreamble was just grabbing the reference of IncludeStructure
passed to it and then replayed any includes seen so while exiting
built-in file.
This implies any include seen in built-in files being replayed as part
of preamble, even though they are not. This wasn't an issue until we've
started patching preambles, as includes from built-in files were not
mapped back to main-file.
This patch copies over existing includes at the time of
ReplayPreamble::attach and only replies those to prevent any includes
from the preamble patch getting mixed-in.
Djordje Todorovic [Tue, 2 Jun 2020 09:44:32 +0000 (11:44 +0200)]
[CSInfo][NFC] Interpret loaded parameter value separately
The collectCallSiteParameters() method searches for instructions
which load values into registers used for parameters passing.
Previously, interpretation of those values, loaded by one such
instruction, was implemented inside collectCallSiteParameters() method.
This patch moves the interpretation code from collectCallSiteParameters()
method into a separate static method named interpretValue. New method is
called from collectCallSiteParameters() to process each instruction from
targeted instruction scope.
The collectCallSiteParameters() searches for loaded parameter value
among instructions which precede the call instruction, inside the same
basic block. When needed, new method (interpretValue) could be used for
searching any instruction scope.
This is preparation for search of parameter value, loaded inside call
delay slot.
Patch by Nikola Tesic
Differential revision: https://reviews.llvm.org/D78106
Alex Zinenko [Tue, 2 Jun 2020 11:01:37 +0000 (13:01 +0200)]
[mlir] SCFToGPUPass: fix macros referring to LOOPS to use SCF instead
One header guard was overlooked when renaming LoopOps to SCF, rename it.
Also drop two unused macros, one of which referred to LoopOp (not "Ops",
hence the overlook).
Pavel Labath [Mon, 20 Apr 2020 15:28:15 +0000 (17:28 +0200)]
[Support] Make DataExtractor error messages more clear
Summary:
This is a result of the discussion at D78113. Previously we would be
only giving the current offset at which the error was detected. However,
this was phrased somewhat ambiguously (as it could also mean that end of
data was at that offset). The new error message includes the current
offset as well as the extent of the data being read.
I've changed a couple of file-level static functions into private member
functions in order to avoid passing a bunch of new arguments everywhere.
Reviewers: dblaikie, jhenderson
Subscribers: hiraditya, MaskRay, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D78558
Pavel Labath [Mon, 25 May 2020 12:37:04 +0000 (14:37 +0200)]
[lldb/DWARF] Add support for pre-standard GNU call site attributes
Summary:
The code changes are very straight-forward -- just handle both DW_AT_GNU
and DW_AT_call versions of all tags and attributes. There is just one
small gotcha: in the GNU version, DW_AT_low_pc was used both for the
"return pc" and the "call pc" values, depending on whether the tag was
describing a tail call, while the official scheme uses different
attributes for the two things.
Reviewers: vsk, dblaikie
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D80519
Igor Kudrin [Tue, 2 Jun 2020 09:14:48 +0000 (16:14 +0700)]
[DebugInfo] Report the format of type units [10/10]
Differential Revision: https://reviews.llvm.org/D80523
Igor Kudrin [Tue, 2 Jun 2020 09:11:02 +0000 (16:11 +0700)]
[DebugInfo] Report the format of location and range lists [9/10]
Differential Revision: https://reviews.llvm.org/D80523
Igor Kudrin [Tue, 2 Jun 2020 09:08:16 +0000 (16:08 +0700)]
[DebugInfo] Report the format of tables in .debug_pub* sections [8/10]
Differential Revision: https://reviews.llvm.org/D80523
Igor Kudrin [Tue, 2 Jun 2020 09:05:43 +0000 (16:05 +0700)]
[DebugInfo] Report the format of line tables [7/10]
Differential Revision: https://reviews.llvm.org/D80523
Igor Kudrin [Tue, 2 Jun 2020 09:00:44 +0000 (16:00 +0700)]
[DebugInfo] Report the format of call frame information entries [6/10]
Differential Revision: https://reviews.llvm.org/D80523
Igor Kudrin [Tue, 2 Jun 2020 08:44:47 +0000 (15:44 +0700)]
[DebugInfo] Report the format of address range tables [5/10]
Differential Revision: https://reviews.llvm.org/D80523
Igor Kudrin [Tue, 2 Jun 2020 08:40:56 +0000 (15:40 +0700)]
[DebugInfo] Report the format of address tables [4/10]
Differential Revision: https://reviews.llvm.org/D80523
Igor Kudrin [Tue, 2 Jun 2020 08:37:25 +0000 (15:37 +0700)]
[DebugInfo] Report the format of compilation units [3/10]
Differential Revision: https://reviews.llvm.org/D80523
Igor Kudrin [Tue, 2 Jun 2020 05:31:02 +0000 (12:31 +0700)]
[DebugInfo] Report the format of .debug_names [2/10]
Differential Revision: https://reviews.llvm.org/D80523
Igor Kudrin [Tue, 2 Jun 2020 05:16:51 +0000 (12:16 +0700)]
[DebugInfo] Extract a helper function to return the DWARF format name, NFC [1/10]
Differential Revision: https://reviews.llvm.org/D80523
Alex Zinenko [Tue, 2 Jun 2020 10:49:45 +0000 (12:49 +0200)]
[mlir] Toy tutorial: avoid erasing and then re-creating loop terminators
The lower-to-affine-loops pass in chapters 5-7 of the Toy tutorial has
been creating affine loops, erasing their terminator and creating it
anew using a PatternRewriter instance to work around the fact that
implicit terminators were created without notifying the rewriter. Now
that has been fixed in
3ccf4a5bd109, remove the code erasing and
re-creating the terminators and rely on the default ones.
Simon Pilgrim [Tue, 2 Jun 2020 10:24:42 +0000 (11:24 +0100)]
Add missing MemoryBuffer.h include
Alex Zinenko [Tue, 2 Jun 2020 10:06:56 +0000 (12:06 +0200)]
[mlir] post-commit review fixes
This fixes several post-commit nits from D79688 and D80135, namely
typos, debug output and control flow inversion.
Simon Pilgrim [Tue, 2 Jun 2020 09:52:39 +0000 (10:52 +0100)]
TextAPIReader.h - reduce MemoryBuffer.h include to forward declaration. NFC.
Simon Pilgrim [Tue, 2 Jun 2020 09:51:50 +0000 (10:51 +0100)]
TextAPIWriter.h - reduce MemoryBuffer.h include to forward declarations. NFC.
Florian Hahn [Tue, 2 Jun 2020 09:45:30 +0000 (10:45 +0100)]
[Sema] Fix -Wunused-variable in CreateBuiltinMatrixSubscriptExpr (NFC).
Florian Hahn [Tue, 2 Jun 2020 09:33:10 +0000 (10:33 +0100)]
[LV] Make sure the MaxVF is a power-of-2 by rounding down.
LV currently only supports power of 2 vectorization factors, which has
been made explicit with the assertion added in
840450549c9199150cbdee29acef756c19660ca1.
However, if the widest type is not a power-of-2 the computed MaxVF won't
be a power-of-2 either. This patch updates computeFeasibleMaxVF to
ensure the returned value is a power-of-2 by rounding down to the
nearest power-of-2.
Fixes PR46139.
Reviewers: Ayal, gilr, rengolin
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D80870
Ehsan Toosi [Tue, 26 May 2020 13:03:45 +0000 (15:03 +0200)]
[mlir] Introduce CallOp converter for buffer placement
Add BufferAssignmentCallOpConverter as a pattern rewriter for Buffer
Placement. It matches the signature of the caller operation with the callee
after rewriting the callee with FunctionAndBlockSignatureConverter.
Differential Revision: https://reviews.llvm.org/D80785
Denis Antrushin [Fri, 22 May 2020 14:03:02 +0000 (17:03 +0300)]
[EarlyCSE] Common gc.relocate calls.
gc.relocate intrinsic is special in that its second and third operands
are not real values, but indices into relocate's parent statepoint list
of GC pointers.
To be CSE'd, they need special handling in `isEqual()` and `getHashCode()`.
Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D80445
Muhammad Omair Javaid [Tue, 2 Jun 2020 09:08:10 +0000 (14:08 +0500)]
[LLDB] Mark TestCreateDuringInstructionStep as flaky on Linux
This patch marks TestCreateDuringInstructionStep.py as flakey for Linux.
This is failing randomly on arm/aarch64. I will monitor buildbot and
skip it if it fails again.
Simon Pilgrim [Tue, 2 Jun 2020 09:03:41 +0000 (10:03 +0100)]
[VectorCombine][X86] Add loaded insert tests from D80885
Haojian Wu [Fri, 29 May 2020 21:27:05 +0000 (23:27 +0200)]
[AST] Fix a null initializer crash for InitListExpr
Summary:
The Initializer of a InitListExpr can be reset to null, which leads to
nullptr-acces crashes.
Reviewers: sammccall
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D80980
Simon Atanasyan [Fri, 24 Apr 2020 12:41:13 +0000 (15:41 +0300)]
[mips] Support 64-bit relative relocations
MIPS 64-bit ABI does not provide special PC-relative relocation like
R_MIPS_PC32 in 32-bit case. But we can use a "chain of relocation"
defined by N64 ABIs. In that case one relocation record might contain up
to three relocations which applied sequentially. Width of a final relocation
mask applied to the result of relocation depends on the last relocation
in the chain. In case of 64-bit PC-relative relocation we need the following
chain: `R_MIPS_PC32 | R_MIPS_64`. The first relocation calculates an
offset, but does not truncate the result. The second relocation just
apply calculated result as a 64-bit value.
The 64-bit PC-relative relocation might be useful in generation of
`.eh_frame` sections to escape passing `-Wl,-z,notext` flags to linker.
Differential Revision: https://reviews.llvm.org/D80390
Dmitri Gribenko [Tue, 2 Jun 2020 08:30:01 +0000 (10:30 +0200)]
Run syntax tree tests in many language modes
Reviewers: hlopko, eduucaldas
Reviewed By: hlopko, eduucaldas
Subscribers: gribozavr2, mgorny, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D80822
Kazushi (Jam) Marukawa [Tue, 2 Jun 2020 08:22:30 +0000 (10:22 +0200)]
[VE] Support I32/F32 registers in assembler parser
Summary:
Support I32/F32 registers in assembler parser and add regression tests of LD/ST
instructions.
Differential Revision: https://reviews.llvm.org/D80777
Clement Courbet [Tue, 2 Jun 2020 07:36:11 +0000 (09:36 +0200)]
[llvm-exegesis] Fix D80610.
Summary:
Using a .data() member on a StringRef was discarding the StringRef
size, breaking llvm-exegesis on machines with counter sums (e.g.
Zen2).
Reviewers: oontvoo
Subscribers: mstojanovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D80982
Sam Parker [Tue, 2 Jun 2020 08:04:20 +0000 (09:04 +0100)]
[NFC][ARM][AArch64] Test runs
Add code size tests runs for memory ops for both architectures.
Joachim Protze [Mon, 1 Jun 2020 12:49:45 +0000 (14:49 +0200)]
[OpenMP][OMPT] Fix and add event callbacks for detached tasks
The OpenMP spec has the task-fulfill event for a call to omp_fulfill_event.
If the task did not yet finish execution, ompt_task_early_fulfill is used,
otherwise ompt_task_late_fulfill.
If a task does not complete, when the execution finishes (i.e., the task goes
in detached mode), ompt_task_detach instead of ompt_task_complete must be
used, when the next task is scheduled.
A test for both cases is included, which only work with clang-11+
Reviewed By: hbae
Differential revision: https://reviews.llvm.org/D80843
Sriraman Tallam [Tue, 2 Jun 2020 06:17:29 +0000 (23:17 -0700)]
Options for Basic Block Sections, enabled in D68063 and D73674.
This patch adds clang options:
-fbasic-block-sections={all,<filename>,labels,none} and
-funique-basic-block-section-names.
LLVM Support for basic block sections is already enabled.
+ -fbasic-block-sections={all, <file>, labels, none} : Enables/Disables basic
block sections for all or a subset of basic blocks. "labels" only enables
basic block symbols.
+ -funique-basic-block-section-names: Enables unique section names for
basic block sections, disabled by default.
Differential Revision: https://reviews.llvm.org/D68049
Denis Antrushin [Thu, 28 May 2020 12:26:56 +0000 (15:26 +0300)]
[StatepointLowering] Handle UNDEF gc values.
Do not spill UNDEF GC values. Instead, replace corresponding
gc.relocate intrinsic with an (arbitrary, but recognizable) constant.
Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D80714
Dominik Montada [Thu, 7 May 2020 10:27:57 +0000 (12:27 +0200)]
[GlobalISel] Combine scalar unmerge(trunc)
Summary:
Combine unmerge(trunc) to enable other merge combines.
Without this combine, the scalar unmerge(trunc(merge))
pattern cannot be combined and easily lead to
hard-to-legalize merge/unmerge artifacts.
Reviewed By: arsenm
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D79567
Dominik Montada [Tue, 2 Jun 2020 06:49:37 +0000 (08:49 +0200)]
[NFC] Move vector unmerge(trunc) combine to function
In preparation of D79567, move arsenm's vector unmerge(trunc)
combine to a new function `tryFoldUnmergeCast`
Xing GUO [Tue, 2 Jun 2020 06:38:15 +0000 (14:38 +0800)]
[ObjectYAML][DWARF] Let `dumpPubSection` return `DWARFYAML::PubSection`.
Summary: This patch addresses comments in [D80722](https://reviews.llvm.org/D80722#inline-742353)
Reviewers: grimar, jhenderson
Reviewed By: grimar, jhenderson
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D80861
MaheshRavishankar [Tue, 2 Jun 2020 05:42:33 +0000 (22:42 -0700)]
[mlir][SCFToGPU] Remove conversions from scf.for to gpu.launch.
Keeping in the affine.for to gpu.launch conversions, which should
probably be the affine.parallel to gpu.launch conversion as well.
Differential Revision: https://reviews.llvm.org/D80747
Fangrui Song [Tue, 2 Jun 2020 05:57:43 +0000 (22:57 -0700)]
[ELF] --wrap: don't error `undefined reference to __real_foo` (--no-allow-shlib-undefined) if foo is a wrapped definition
This is a regression after D51283.
Also, export `foo` if `__real_foo` is referenced by a shared object.
Yevgeny Rouban [Tue, 2 Jun 2020 04:28:12 +0000 (11:28 +0700)]
[BrachProbablityInfo] Proportional distribution of reachable probabilities
When fixing probability of unreachable edges in
BranchProbabilityInfo::calcMetadataWeights() proportionally distribute
remainder probability over the reachable edges. The old implementation
distributes the remainder probability evenly.
See examples in the fixed tests.
Reviewers: yamauchi, ebrevnov
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D80611
Richard Smith [Tue, 2 Jun 2020 04:10:27 +0000 (21:10 -0700)]
Fix violations of [basic.class.scope]p2.
These cases all follow the same pattern:
struct A {
friend class X;
//...
class X {};
};
But 'friend class X;' injects 'X' into the surrounding namespace scope,
rather than introducing a class member. So the second 'class X {}' is a
completely different type, which changes the meaning of the earlier name
'X' from '::X' to 'A::X'.
Additionally, the friend declaration is pointless -- members of a class
don't need to be befriended to be able to access private members.
Craig Topper [Tue, 2 Jun 2020 04:53:19 +0000 (21:53 -0700)]
[X86] Fix a few recursivelyDeleteUnusedNodes calls that were trying to delete nodes before their user was really gone.
We looked through a truncate to get to the load. So we should be
deleting the truncate first.
There is a check that the node is really unused before deleting
so this didn't cause a functional issue.
Yevgeny Rouban [Tue, 2 Jun 2020 03:55:27 +0000 (10:55 +0700)]
[BrachProbablityInfo] Rename loop variables. NFC
Kostya Serebryany [Tue, 2 Jun 2020 00:40:23 +0000 (17:40 -0700)]
[asan] fix a comment typo
Kostya Serebryany [Tue, 2 Jun 2020 00:33:49 +0000 (17:33 -0700)]
add debug code to chase down a rare crash in asan/lsan https://github.com/google/sanitizers/issues/1193
Summary: add debug code to chase down a rare crash in asan/lsan https://github.com/google/sanitizers/issues/1193
Reviewers: vitalybuka
Subscribers: #sanitizers, llvm-commits
Tags: #sanitizers
Differential Revision: https://reviews.llvm.org/D80967