Christopher Michael [Tue, 12 Mar 2019 14:59:04 +0000 (10:59 -0400)]
eo: Fix missing varags cleanup
Summary:
Coverity reports that va_end is never called for p_list when we error
out of this function. This patch adds a missing va_end before we error
out of here.
Fixes Coverity CID1399080
@fix
Depends on D8315
Reviewers: raster, cedric, q66, zmike, bu5hm4n, stefan
Reviewed By: q66
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8316
Stefan Schmidt [Tue, 12 Mar 2019 13:38:11 +0000 (14:38 +0100)]
release: Update NEWS and bump version for 1.22.0-beta1 release
Mike Blumenkrantz [Tue, 12 Mar 2019 13:17:23 +0000 (14:17 +0100)]
Efl_Core.h include Efl.h unconditionally
Summary: this was added by accident in D8244
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Differential Revision: https://phab.enlightenment.org/D8304
Stefan Schmidt [Tue, 12 Mar 2019 12:27:22 +0000 (13:27 +0100)]
examples: bg_cxx: disable win.background in example
Since commit
ceb4c04d3b8f8eb94d63174b7b6f43641ea508a8 the parts block in
efl.ui.widget is disabled which leads to compile errors of the example.
Stefan Schmidt [Tue, 12 Mar 2019 11:48:33 +0000 (12:48 +0100)]
tests: eolian_cxx: make sure we add beta_class.eo to dist
Since commit
2a003420f83134331c8b404df1905cba538cfad6 we need
beta_class.eo for the eolain cxx test suite. I never was added to the
files for dist, thus breaking distcheck.
Jaehyun Cho [Tue, 12 Mar 2019 05:42:28 +0000 (14:42 +0900)]
efl_ui_navigation_layout: fix bar value to be Efl.Ui.Layout_Base
Since Efl.Ui.Layout is renamed to Efl.Ui.Layout_Base, the bar value is
fixed to be Efl.Ui.Layout_Base.
Jaehyun Cho [Tue, 12 Mar 2019 05:39:06 +0000 (14:39 +0900)]
Efl_Ui.h: move stack and navigation headers to Efl_Ui.h
The following efl ui headers move from Elementary.h to Efl_Ui.h.
efl_ui_navigation_bar.eo.h
efl_ui_navigation_bar_part.eo.h
efl_ui_navigation_bar_part_back_button.eo.h
efl_ui_navigation_layout.eo.h
efl_ui_stack.eo.h
Marcel Hollerbach [Tue, 26 Feb 2019 14:38:28 +0000 (15:38 +0100)]
efl_ui_widget: refactor sub_object handling
efl_ui_widget has a property called widget_parent. The setter for this
function is called is exactly once, and this is within the constructor,
to a value which is not even set to the actaul field parent_obj. Which
shows, that in the sitation right now, the setter of the property is a
bit disconnected and lags some real aspects.
As we are heading towards eo-api stabilization we should beat some sense
into this setter, as people using our classes might overwrite the setter
and except calls to it, whenever the widget_parent is changed, and
implementation as in elm_menu show that this might makes sense sometime.
In order to achive this, the sub_object registering code of elm is
adjusted a bit.
sub_object_add/del is now used to differenciate between evas objects and
efl.ui.widget objects as subobject. In case of a widget, the
widget_parent of this object is set, most of the widget specific code is
then executed in the actaul setter. In case of an evas object, the
parent reference is added. In the end both end up in the subobject
children list. The later is also a requirement for widget_parent_set to
be successfull.
ref T7553
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8031
Change-Id: I32ee38e867668e8fef486dc4807d42cc2c3a589c
Yeongjong Lee [Tue, 12 Mar 2019 04:15:49 +0000 (13:15 +0900)]
elm_object: Restore child_can_focus
child_can_focus is needed for legacy focus.
@tizen_fix
Change-Id: Ifa36e5065af4b0a9d7ccc9983bae0be144d4daa2
Wonki Kim [Tue, 2 Apr 2019 02:25:29 +0000 (11:25 +0900)]
meson: fix typo for elementary meson definition
there is a typo error on a meson defintion for elementary
this patch fixes it
Change-Id: Ie263b82f87da6f8d4f6b7f8298dab380b0042b5c
Wonki Kim [Wed, 27 Mar 2019 14:18:33 +0000 (10:18 -0400)]
entry: move a point to do 'auto_save' to another place
Summary:
By reworking on efl_file, logic flow for entry has been changed.
and it causes autosave making a file that is passed to elm_entry_file_set empty.
Test Plan:
1. call elm_entry_file_set for a file.
2. check the file is not empty after calling the function.
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8362
Change-Id: I96a4c9602e9a3e74c2c3cec24e4b5f3e5a1dbc13
Hermet Park [Mon, 1 Apr 2019 10:40:53 +0000 (19:40 +0900)]
Revert "entry: move a point to do 'auto_save' to another place"
This reverts commit
01225c04d2cc94feceabe317b4338c11c9ea7e45.
Official patch will be cherry-picked instead.
Change-Id: Ieead7bc19595efdb7e059e5c16e683bb0a27d5be
Wonki Kim [Mon, 1 Apr 2019 07:58:16 +0000 (16:58 +0900)]
meson: fix meson definitions for keeping compat
this patch fixes meson definitions to keep it making same output like autotools
Change-Id: I8d72d9ac1267f1ddd278d4c57159e95455739451
Radoslaw Cybulski [Fri, 29 Mar 2019 11:58:17 +0000 (12:58 +0100)]
Fix for not working atspi
Some ATSPI flags were missing in elm_states_to_atspi_state table,
which prevent HIGHLIGHTABLE and HIGHLIGHTED flags from showing up.
Which prevented screen-reader / universal switch from operating on
anything completely.
Change-Id: I8eee2cf19897d064a49b632786821110933836b7
Radoslaw Cybulski [Tue, 26 Mar 2019 13:04:16 +0000 (14:04 +0100)]
fix for crash in _sort_items function due to sorting NULL pointers
Fixes issue in TDAF-835 on fridges. Calling elm_gengrid_clear would
cause crash due to sorting atspi elements. Comparision function would
get two NULLs and trying to derefence them would issue a crash
Change-Id: Ib1771503fcc467c26f3c550188ea65eaeaf495df
Wonki Kim [Tue, 26 Mar 2019 11:02:40 +0000 (20:02 +0900)]
entry: move a point to do 'auto_save' to another place
Summary:
By reworking on efl_file, logic flow for entry has been changed.
and it causes autosave making a file that is passed to elm_entry_file_set empty.
Test Plan:
1. call elm_entry_file_set for a file.
2. check the file is not empty after calling the function.
Reviewers: zmike, bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8362
Change-Id: Ifdf7f440a3e700c9e12ccee637b9656835ad2808
Yeongjong Lee [Tue, 26 Mar 2019 10:48:30 +0000 (19:48 +0900)]
elm_win: fix correct return value on elm_win_rotation_get
Summary:
Before
b3327c761e, -1 was returned on`elm_win_rotation_get`, if `obj` is NULL.
This fixes backward compatibility.
Test Plan: make check
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8474
Marcel Hollerbach [Tue, 19 Mar 2019 13:37:57 +0000 (09:37 -0400)]
efl_ui_zoomable: fix widget
Summary:
before the efl_file_set operations have been safed, and then applied on
the internal evas_image. With the refactor
6326e18b3fb2a4757f8ffa22be5d55a75da23049, this was broken, and the
file_set was applied to the super object which is a layout here.
fix T7748
Reviewers: zmike, segfaultxavi, cedric, devilhorns
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7748
Differential Revision: https://phab.enlightenment.org/D8394
Yeongjong Lee [Tue, 26 Mar 2019 06:04:52 +0000 (15:04 +0900)]
elm_photocam: fix correct return value in elm_photocam_file_set
Test Plan: `elm_photocam_file_set(NULL, "file_name");`
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8473
Wonki Kim [Fri, 11 Jan 2019 01:49:32 +0000 (10:49 +0900)]
meson: introduce to meson build system
this patch introduce to meson build system.
but meson build is not enabled by default.
you can use meson build system
once you pass --define "buildsystem meson" at the end of gbs build command.
Change-Id: I83287465e2920908d6f4ae8155b44fd44c95d645
Yeongjong Lee [Tue, 26 Mar 2019 04:16:32 +0000 (13:16 +0900)]
elm_photocam: fix file_get,set operations
Summary: This patch fixes bug that elm_photocam_file_get always return NULL.
Test Plan: make check
Reviewers: Hermet, zmike, bu5hm4n
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8472
Yeongjong Lee [Mon, 25 Mar 2019 10:47:44 +0000 (19:47 +0900)]
efl_ui_win: prevent segfault in elm_win_keygrab_set
When obj is not EFL_UI_WIN_CLASS, just return EINA_FALSE.
ref
3277cbf48e2026aa8478eaecda7d830559328722
Change-Id: I6a9c55664ee8e7b107029a99b9524104fcf69e68
Yeongjong Lee [Mon, 25 Mar 2019 10:33:29 +0000 (10:33 +0000)]
elm_win: fix correct rot variable in elm_win_rotation_get
Remove duplicated rotation variable
Also, it fixes wrong layout class comparing.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8464
Shinwoo Kim [Mon, 25 Mar 2019 02:52:49 +0000 (11:52 +0900)]
efl_ui_win: fix incorrect change
Following commit has an incorrect line.
The parent in _elm_win_finalize_internal is always NULL if an obj is legacy.
commit
386b6b1eed0b033d38b0a95a69f03ce7eba34eed
Author: Taehyub Kim <taehyub.kim@samsung.com>
Date: Thu Mar 21 16:35:50 2019 +0900
efl_ui_win: support legacy window behavior compatibility
Change-Id: Ia63d1244b9681fa844d2a1f1185ab12510569c77
Prateek Thakur [Tue, 19 Mar 2019 19:29:23 +0000 (00:59 +0530)]
entry: select full password even if special characters like @ are present
Select whole entry in case of password mode.
Currently in case of password mode if special characters like @ are present
then on double click only the characters till @ are selected.
@tizen_fix
Change-Id: I90304780bfb13350eac3a7d078d9abae72dd21f7
Signed-off-by: Prateek Thakur <prateek.th@samsung.com>
Jaehyun Cho [Fri, 22 Mar 2019 04:55:56 +0000 (13:55 +0900)]
elm_atspi_proxy: remove all legacy usage from eo files
this takes the current generated output from eolian for legacy code in
efl and adds it to the tree, then removes legacy references from the
corresponding eo files. in the case where the entire eo file was for
a legacy object, that eo file has been removed from the tree
ref T7724
Change-Id: Id177e3e193589e8147c97ee14d5b5311e6ec6604
Jaehyun Cho [Fri, 22 Mar 2019 04:42:56 +0000 (13:42 +0900)]
elm_atspi_ewk_wrapper: remove all legacy usage from eo files
this takes the current generated output from eolian for legacy code in
efl and adds it to the tree, then removes legacy references from the
corresponding eo files. in the case where the entire eo file was for
a legacy object, that eo file has been removed from the tree
ref T7724
Change-Id: I7c4d070cf8ec121080b0534fba6c0b74314651cf
Jaehyun Cho [Thu, 21 Mar 2019 12:29:00 +0000 (21:29 +0900)]
elm_atspi_bridge: remove all legacy usage from eo files
this takes the current generated output from eolian for legacy code in
efl and adds it to the tree, then removes legacy references from the
corresponding eo files. in the case where the entire eo file was for
a legacy object, that eo file has been removed from the tree
ref T7724
Change-Id: I1913b42365336fab29b8d59aa992b26f22fe39b0
Jaehyun Cho [Thu, 21 Mar 2019 12:06:09 +0000 (21:06 +0900)]
elm_atspi_app_object: remove all legacy usage from eo files
this takes the current generated output from eolian for legacy code in
efl and adds it to the tree, then removes legacy references from the
corresponding eo files. in the case where the entire eo file was for
a legacy object, that eo file has been removed from the tree
ref T7724
Change-Id: If3f1819435d4d8dced717b8634e11d026164905f
Taehyub Kim [Fri, 22 Mar 2019 04:37:38 +0000 (13:37 +0900)]
elc_popup: fix to show popup correctly.
- fix wrong usage of popup theme apply
- use win rotation value instead of the removed orientation feature
Change-Id: Iea574fd58c0980e5f6d23505af709fda56bc64c9
Taehyub Kim [Fri, 22 Mar 2019 03:38:44 +0000 (12:38 +0900)]
efl_ui_layout: Eina_Error type has been modified to work correctly.
Summary:
fix Eina_Error type calculation in _efl_ui_layout_base_efl_ui_widget_theme_apply() to behave as before.
@fix
Test Plan: run elementary_test for all widgets
Reviewers: #reviewers, Jaehyun_Cho, Hermet
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8443
Change-Id: Icce083a8785842972ac549519128775c880e292f
SangHyeon Jade Lee [Thu, 21 Mar 2019 09:09:53 +0000 (18:09 +0900)]
elm : fix wrong layout class comparing in orientation mode disable
Summary:
automatic theme lotation is layout base class property which can be applied
layout based widget classes.
currently it only comparing EFL_UI_LAYOUT_CLASS so layout base inherited class
can not be applied this feature properly.
depends D8434
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8436
Change-Id: Iebbf1da76fc2309f16db7e7eabcca0b82e6fe3d8
SangHyeon Jade Lee [Thu, 21 Mar 2019 09:08:46 +0000 (18:08 +0900)]
elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set.
Summary:
current code set the disable EINA_TRUE when disabled,
but once it was set diabled, it never changed EINA_FALSE even we set the orientation_mode_disable as FALSE.
Test Plan: we have test suite on legacy action, and previous patch was failed to pass the test case.
Reviewers: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8434
Change-Id: I4251eb01451e61351942e2d5012188057fccba91
Jongmin Lee [Wed, 20 Mar 2019 11:41:10 +0000 (20:41 +0900)]
elm_win: bug fix - add keygrab unset code when wayland backend
add keygrab unset code and change keygrab set code to reduce function call.
@tizen_feature
Author: Ji-Youn Park <jy0703.park@samsung.com>
Commit-Id:
44014304034460784b62a40afa088f7fd8405050
Change-Id: If86adf73a4ee115a6c32463996066a4e9116c8de
Bowon Ryu [Thu, 21 Mar 2019 06:37:53 +0000 (15:37 +0900)]
elm_layout: fix elm_layout_text_set to return proper result
It fixes API breaks of upstream EFL.
* Add missing code during migration.
@tizen_fix
Change-Id: Ibda35b120576466a187e2c716ad8b100a3bacc90
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Yeongjong Lee [Wed, 20 Mar 2019 11:59:00 +0000 (20:59 +0900)]
Elementary: fix migration errors
Restore Tizen only eo.
Change-Id: Id5d01610e7af9819ccda1cab4b9821a993e4401c
Taehyub Kim [Thu, 21 Mar 2019 07:35:50 +0000 (16:35 +0900)]
efl_ui_win: support legacy window behavior compatibility
Change-Id: Iebf9d6fcc08ba37cdd0df7e6cd17abd45c16b8b9
Wonki Kim [Fri, 15 Mar 2019 14:32:55 +0000 (10:32 -0400)]
elm_entry: fix to keep api backward compatability
Summary:
if passing NULL as filename to elm_entry_file_set,
elm_entry_entry_get NULL as return value before.
and it doesn't now.
Test Plan:
1. passing a existing file to efl_entry_file_set
2. passing NULL as file to efl_entry_file_set
3. check return value of elm_entry_entry_get
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8363
Change-Id: I89fd726f7691f7105ec201b8b132fce546c38f58
Wonki Kim [Fri, 15 Mar 2019 14:27:20 +0000 (10:27 -0400)]
elm_entry: fix to return a error code if a argument is not valid
Summary:
if format is not specified, it should return some error code.
this is a kind of a patch to keep backward compatability of the api.
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8337
Change-Id: Iab09f7d4bf782e50d1cd5c17a23f71f2b1ed5609
Yeongjong Lee [Fri, 15 Mar 2019 14:35:17 +0000 (10:35 -0400)]
evas_events: prevent double event_freeze in evas_object_freeze_events_set
Summary:
This patch prevent that event_freeze_count is greater than 1 in
`evas_object_freeze_events_set`
Test Plan: make check
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8325
Change-Id: Ia8474fd064a83f7824c985269f32116954189968
Myoungwoon Roy, Kim [Tue, 19 Mar 2019 23:55:06 +0000 (08:55 +0900)]
docs: Correct wrong group names and marks internal
Change-Id: I4ab69495da52db12a4ca67041f2267af80f0ba2e
Hermet Park [Wed, 13 Mar 2019 05:16:58 +0000 (14:16 +0900)]
evas vg: remove evas_object_vg_mmap_set()
the api is not necessary, remove it before official release.
Change-Id: I80061d5d6ae5af11427954a4fb4f9e9aac287bd6
JunsuChoi [Tue, 19 Mar 2019 01:37:25 +0000 (10:37 +0900)]
Evas: Add type convert function for BIDI_Direction_Type.
Summary:
evas_object_paragraph_direction_set/get function shoud keep parameta type Evas_BiDi_Direction.
So, I add convert function.
Test Plan: N/A
Reviewers: zmike, Jaehyun_Cho, herb
Subscribers: cedric, #reviewers, Hermet, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8399
Change-Id: Ib2ec01a94df64ddaf6d3fe60cceb95fd2dd3d6c6
Taehyub Kim [Tue, 19 Mar 2019 02:35:12 +0000 (11:35 +0900)]
Ecore: fix migration build erros related to beta APIs
Change-Id: I8523a818f430d5949af71a7569226dceac42e208
Taehyub Kim [Mon, 18 Mar 2019 11:45:04 +0000 (20:45 +0900)]
Evas: fix migration build erros related to beta APIs
Change-Id: Icf7be0968a5246a3eecd41ab982e0e67684446ce
Marcel Hollerbach [Thu, 14 Mar 2019 18:26:30 +0000 (14:26 -0400)]
efl_ui: fix headers
Summary:
the function parameters is a only beta, so this function should be beta.
Depends on D8341
Reviewers: zmike, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8342
JunsuChoi [Fri, 15 Mar 2019 09:55:17 +0000 (18:55 +0900)]
Fix for migration missing code (24f32c5 ~ 64352f2) #3
Change-Id: Icc69a217376ed2f26b065d0b2a1d559f1af638a4
JunsuChoi [Thu, 14 Mar 2019 09:28:52 +0000 (18:28 +0900)]
efl_ui_widget: Remove lagacy:null keyword.
Change-Id: I4953dd9329c2da908c029424da75eb72f865a975
Lauro Moura [Mon, 11 Mar 2019 22:22:28 +0000 (19:22 -0300)]
csharp: Fix event names with underscore.
Summary:
names like `focus_geometry,changed` shoud be converted to
FocusGeometryChanged instead of Focus_geometryChanged.
Fixes T7735
Test Plan: run tests
Reviewers: vitor.sousa, felipealmeida, segfaultxavi
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7735
Differential Revision: https://phab.enlightenment.org/D8301
Cedric BAIL [Mon, 11 Mar 2019 21:52:40 +0000 (17:52 -0400)]
efl: mark render,post event as beta.
Summary:
render,post is just forwarding the legacy type which is not the best as it expose
internal structure directly. Planning to move to an accessor for after this release,
but at this time it does imply way to much change for this current release.
Depends on D8249
Reviewers: zmike, stefan_schmidt, segfaultxavi, bu5hm4n
Reviewed By: zmike, bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl_api, PHID-PROJ-55rnlag4d454jfmlmuhu
Maniphest Tasks: T7729
Differential Revision: https://phab.enlightenment.org/D8250
Cedric BAIL [Mon, 11 Mar 2019 21:52:38 +0000 (17:52 -0400)]
elementary: none of this call should have propagated any legacy call.
Summary:
Triggering legacy event call for non legacy event on a an object that is
also non legacy made little sense.
Reviewers: zmike, stefan_schmidt, segfaultxavi, bu5hm4n
Reviewed By: zmike, bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7729
Differential Revision: https://phab.enlightenment.org/D8249
Marcel Hollerbach [Mon, 11 Mar 2019 21:47:05 +0000 (17:47 -0400)]
efl_ui_focus_object: fixup properties that are used for event infos.
Summary:
those are the completly wrong properties, please be carefull with this.
There is a major difference between focus_geometry and geometry on the
entity. In a viewport for example its the viewport itself - the bars at
the side. Additionally, not every focus object is a efl.gfx.entity.
this fixes a giant amount of errors when you try to test terminology,
emixer, toolbar tests or something like this.
fixup
1d9fef8da6fb4f679113d9dc4f57f1520fd31936
Reviewers: cedric, segfaultxavi, zmike
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8300
Mike Blumenkrantz [Mon, 11 Mar 2019 20:20:09 +0000 (16:20 -0400)]
efl.ui.widget: disable parts{} block for now
the part is not stable, as the type is not stable. However, we lack the
support of declaring parts beta, so we just comment them out.
This can be reverted after the release.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8298
Mike Blumenkrantz [Mon, 11 Mar 2019 17:50:51 +0000 (13:50 -0400)]
api: mark efl.loop_timer stable
fix T7731
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8296
Mike Blumenkrantz [Mon, 11 Mar 2019 15:45:18 +0000 (11:45 -0400)]
efl_ui_focus_composition: get geometry from canvas object not adapter
the adapter has no geometry, so we must use the object from the adapter data
ref D8287
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8295
Mike Blumenkrantz [Mon, 11 Mar 2019 15:30:22 +0000 (11:30 -0400)]
efl.ui.win: merge fullscreen+maximize events to use *,changed naming
ref T7511
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8294
Change-Id: I2b63e05518a8054566e5ccbbecdb5f6eccc4a499
Mike Blumenkrantz [Mon, 11 Mar 2019 15:22:04 +0000 (11:22 -0400)]
efl.ui.win: add event info to 'rotation,changed' event and rename
be consistent with property name and '*,changed' event info convention
ref T7511
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8293
Change-Id: I6746688bde1bdc33356637b490c0216b1803da13
Mike Blumenkrantz [Mon, 11 Mar 2019 15:16:07 +0000 (11:16 -0400)]
efl: mark most generated eina.error vars as @beta
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8292
Mike Blumenkrantz [Mon, 11 Mar 2019 15:00:23 +0000 (11:00 -0400)]
autotools: add more files to EXTRA_DIST2
fixes distcheck
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8291
Mike Blumenkrantz [Mon, 11 Mar 2019 15:00:03 +0000 (11:00 -0400)]
efl.input.interface: mark seat_event_filter @beta
ref T7562
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8290
Marcel Hollerbach [Mon, 11 Mar 2019 19:52:14 +0000 (20:52 +0100)]
efl_ui_widget: mark some oversawn event as beta
this was overseen and should be refactored.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8297
Change-Id: Ie5ef2d0f471578fcabb95ebd310fabaa65ae7165
Lauro Moura [Mon, 11 Mar 2019 18:46:12 +0000 (15:46 -0300)]
efl-csharp: Respect beta for classes and other stuff.
Summary:
In order to work around an issue with Efl.App, which is stable but
inherits from Efl.Core.Command_Line, @beta interfaces/mixins in the
inheritance chain are simply skipped.
Also changed the class used int test for inheritance from C#
Efl.Loop is stable but internally it uses a @beta class as argument to
its Register() method in the constructor. When instantiating a
user-defined C# subclass, the binding calls the C# override in the
NativeInherit class and the marshalling fails as no code is generated
for the beta class.
Also moved Efl.Part test to a beta class. Efl.Part is still beta.
Regarding parts, they are skipped if its class is @beta too.
Also rejected all elm_* files in elm public eo files. They should get
back in as they are converted to Efl.Ui.* api. An exception is
elm_interface_scrollable.eo, as efl_ui_panel depends on it.
Fixes T7730
Test Plan: Run tests
Reviewers: vitor.sousa, segfaultxavi, felipealmeida, cedric, bu5hm4n, zmike
Reviewed By: vitor.sousa
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7730
Differential Revision: https://phab.enlightenment.org/D8268
Lauro Moura [Mon, 11 Mar 2019 16:02:51 +0000 (13:02 -0300)]
eolian-cxx: Add beta information to *_def
Summary: Fixes T7732
Reviewers: cedric, felipealmeida, vitor.sousa, bu5hm4n
Reviewed By: vitor.sousa
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7732
Differential Revision: https://phab.enlightenment.org/D8267
Xavi Artigas [Mon, 11 Mar 2019 16:20:59 +0000 (17:20 +0100)]
mono-examples: Adapt to latest API syntax
Lauro Moura [Mon, 11 Mar 2019 15:34:45 +0000 (11:34 -0400)]
cxx: Fix examples compilation.
Summary:
- Changed beta methods guards from CLASS_NAME_GUARD to
EFL_BETA_API_SUPPORT to use the same scheme as C.
- Removed some includes to Efl_Ui.h from the examples. These were
causing C's efl_part_get to not be generated due to EFL_PART_PROTECTED
not being yet defined (it is defined in Elementary.hh, included
afterwards). This was leading to Efl.Part.impl.hh trying to use a
non-existent method.
Fixes T7716 partially (missing stringshare issue)
Test Plan: make examples
Reviewers: stefan_schmidt, felipealmeida, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7716
Differential Revision: https://phab.enlightenment.org/D8284
Mike Blumenkrantz [Mon, 11 Mar 2019 15:28:49 +0000 (16:28 +0100)]
edje.types: mark Efl.Canvas.Layout_Part_Type beta again
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Differential Revision: https://phab.enlightenment.org/D8289
Mike Blumenkrantz [Mon, 11 Mar 2019 15:15:17 +0000 (16:15 +0100)]
efl.input.types: mark enums beta again and use legacy types in legacy code
Summary:
these types are not currently being released and eolian should not have
generated legacy code using them
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Differential Revision: https://phab.enlightenment.org/D8288
Mike Blumenkrantz [Mon, 11 Mar 2019 14:46:12 +0000 (15:46 +0100)]
efl.ui.focus.object: add geometry to focus_geometry,changed event
Summary: ref T7571
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7571
Differential Revision: https://phab.enlightenment.org/D8287
Daniel Kolesa [Mon, 11 Mar 2019 12:31:55 +0000 (13:31 +0100)]
eolian: enable checking of beta/stable contexts in all classes
Summary:
This enables all the checks unconditionally, without ignoring
classes that don't have an Efl namespace. This required a lot
of beta marking to make it build. It most likely doesn't
mark types correctly, as that is not fully enabled yet.
Reviewers: zmike, cedric, segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8266
Yeongjong Lee [Mon, 11 Mar 2019 11:17:17 +0000 (12:17 +0100)]
ui.widget: enhance documentation of sub_object_add
Reviewers: segfaultxavi, bu5hm4n
Reviewed By: segfaultxavi, bu5hm4n
Subscribers: bu5hm4n, kimcinoo, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8281
Marcel Hollerbach [Sun, 10 Mar 2019 12:47:48 +0000 (13:47 +0100)]
build: repair faulty rule
this deleted wrong files.
Carsten Haitzler (Rasterman) [Sat, 9 Mar 2019 15:50:55 +0000 (15:50 +0000)]
Revert "elementary,evas: remove obsolete legacy includes"
This reverts commit
c876ac52d91806bfc6440b10387ccb91e6a75abf.
This is not safe to remove - this breaks enlightenment. perhaps test
with the reason efl exists in the first place before delcaring it
safe? specifically this removed some function symbols in
efl_canvas_event_grabber_eo.legacy.c ...
Change-Id: I6ef1b80b3c78597b3d3240eee2326a4017460abf
Marcel Hollerbach [Sat, 9 Mar 2019 15:36:21 +0000 (16:36 +0100)]
efl: ensure legacy is only relying on stable types
Summary:
This commit changes the beta ness of a few types, those types are
looking quite stable. Edje types will likely not change. The
Efl.Gfx.Join types are actaully already stable since the last release,
since evas_vg was stable back then and those enums have been in there.
The elementary stuff looks a bit unthought, and we have the chance to
change the API in the backend, so maybe we want to not declare it
stable, but rather reintroduce the legacy types.
With this we can enable eolian generation of beta tags for types.
ref T7726
Depends on D8276
Reviewers: cedric, segfaultxavi, zmike, stefan_schmidt, q66
Reviewed By: segfaultxavi, q66
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7726
Differential Revision: https://phab.enlightenment.org/D8277
Marcel Hollerbach [Sat, 9 Mar 2019 15:37:40 +0000 (16:37 +0100)]
eolian: drop env var checking that is unneccessary
Summary: This now does work, and we can enable the full checks
Reviewers: segfaultxavi, cedric, q66, zmike
Reviewed By: q66
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8276
Carsten Haitzler (Rasterman) [Sat, 9 Mar 2019 15:19:28 +0000 (15:19 +0000)]
solve neon rotation issue by moving to the tiled rotator
the tiles rotator is faster no matter what. this will fix D8099 by
movoing to tiled rotation and nuking the neon code and we end uop
being faster anyway in all cases.
@fix
Marcel Hollerbach [Sat, 9 Mar 2019 13:27:23 +0000 (14:27 +0100)]
efl: mark types beta that have been missed before
Summary:
With this we can drop the getenv in eolian, and enable beta checking per
default.
ref T7584
Depends on D8274
Reviewers: segfaultxavi, cedric, q66, zmike
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7584
Differential Revision: https://phab.enlightenment.org/D8275
Marcel Hollerbach [Sat, 9 Mar 2019 13:17:07 +0000 (14:17 +0100)]
efl_gfx_types: pull 2 types out of beta
Summary:
those types are now used in stable API, we should mark it stable.
ref T7584
Reviewers: segfaultxavi, cedric, q66, zmike
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7584
Differential Revision: https://phab.enlightenment.org/D8274
Marcel Hollerbach [Sat, 9 Mar 2019 12:44:17 +0000 (13:44 +0100)]
efl: apply the stabilzed column of the efl api board
Summary:
The project https://phab.enlightenment.org/tag/efl_api/ has been used in
the last few weeks to figure out which classes can be stablized and
which cannot. This commit moves those dedicated classes outside beta.
And makes them stable.
ref T7601
ref T7600
ref T7599
ref T7598
ref T7597
ref T7596
ref T7594
ref T7593
ref T7591
ref T7590
ref T7589
ref T7588
ref T7583
ref T7582
ref T7581
ref T7576
ref T7570
ref T7567
ref T7564
ref T7563
ref T7560
ref T7559
ref T7672
ref T7584
ref T7577
ref T7571
ref T7558
ref T7555
ref T7554
ref T7553
ref T7512
ref T7511
Depends on D8272
Reviewers: cedric, stefan_schmidt, zmike, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7672, T7601, T7600, T7599, T7598, T7597, T7596, T7594, T7593, T7591, T7590, T7589, T7588, T7584, T7583, T7582, T7581, T7577, T7576, T7571, T7570, T7567, T7564, T7563, T7560, T7559, T7558, T7555, T7554, T7553, T7512, T7511
Differential Revision: https://phab.enlightenment.org/D8273
Change-Id: I3a759062b08e035903632360ab4ebf66e2ba37b8
Marcel Hollerbach [Sat, 9 Mar 2019 12:40:21 +0000 (13:40 +0100)]
efl_ui_focus_manager: move API into beta which is for debugging
Summary:
there is no sense to have this outside beta, noone should really use
this. It is only meant for debugging purposes.
ref T7726
Depends on D8271
Reviewers: segfaultxavi, cedric, zmike
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7726
Differential Revision: https://phab.enlightenment.org/D8272
Marcel Hollerbach [Sat, 9 Mar 2019 12:36:54 +0000 (13:36 +0100)]
efl_ui: repair a few docs
Summary:
ref T7726
Depends on D8270
Reviewers: segfaultxavi, cedric, zmike
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7726
Differential Revision: https://phab.enlightenment.org/D8271
Marcel Hollerbach [Sat, 9 Mar 2019 12:32:17 +0000 (13:32 +0100)]
efl_ui_types: rename move_prolicy field
Summary:
in was not very descriptiv, move_in was concluded to be more descriptive
ref T7726
Reviewers: segfaultxavi, cedric, zmike
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7726
Differential Revision: https://phab.enlightenment.org/D8270
Marcel Hollerbach [Wed, 27 Feb 2019 16:46:16 +0000 (17:46 +0100)]
efl_ui_widget: remove widget_parent overwritting
before the widget_parent have been only set once. The call to the set
was in the constructor and carried the efl_parent. In the next commit
widget_parent is getting a refactor, which gives it more meaning, where
it is actaully called, which means, the behaviour will change. In order
to not break every existing usage of the here changed widgets, we move
the code to the constructor, and feed it with the efl_parent, just like
before.
Differential Revision: https://phab.enlightenment.org/D8041
Change-Id: Id39fb73831c45d33b6c419316e806fafec9cbfaf
Cedric BAIL [Fri, 15 Feb 2019 21:48:59 +0000 (13:48 -0800)]
eo: make reflection getter const function.
Getter are usually not modifying there object. This is going to put a strong
limit on what a getter property for MVVM is, as it will prevent any side
effect on getting a property from a View.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D7969
Cedric BAIL [Wed, 13 Feb 2019 18:46:31 +0000 (10:46 -0800)]
efl: for consistency and effiency move Efl.Model event to send stringshare like Property_Bind event.
Reviewed-by: Vitor Sousa da Silva <vitorsousa@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D7946
Cedric BAIL [Wed, 13 Feb 2019 00:47:31 +0000 (16:47 -0800)]
efl: add an event for the View to know if someone did bound a property.
Reviewed-by: Vitor Sousa da Silva <vitorsousa@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D7945
Cedric BAIL [Tue, 12 Feb 2019 19:55:50 +0000 (11:55 -0800)]
elementary: rely on Efl.Ui.Widget to do more of property binding for MVVM in Efl.Ui.Layout.
Reviewed-by: Vitor Sousa da Silva <vitorsousa@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D7943
Change-Id: I40296ad06a11711cc914fbd178ead1ed93b6c3da
Cedric BAIL [Tue, 12 Feb 2019 18:52:43 +0000 (10:52 -0800)]
elementary: Efl.Ui.Image now rely on Efl.Ui.Widget infrastructure for View and Property_Bind.
Reviewed-by: Vitor Sousa da Silva <vitorsousa@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D7942
Cedric BAIL [Tue, 12 Feb 2019 02:28:22 +0000 (18:28 -0800)]
elementary: implemente property_bind support on all widget using property reflection.
This means that all property that are registered in the reflection table of
any Eo class will be available for binding with a model. This will increase
the amount of useful binding quickly.
Reviewed-by: Vitor Sousa da Silva <vitorsousa@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D7941
Change-Id: Ia938748ab83c9a9fc0afcff5bd65b57fb9780312
Cedric BAIL [Tue, 12 Feb 2019 18:09:43 +0000 (10:09 -0800)]
efl: add an event to notify that the View property has changed.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Reviewed-by: Lauro Neto <Lauro Moura <lauromoura@expertisesolutions.com.br>>
Differential Revision: https://phab.enlightenment.org/D7940
Mike Blumenkrantz [Fri, 8 Mar 2019 15:56:07 +0000 (10:56 -0500)]
efl.text.interactive: rename events to avoid conflicts
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8265
Mike Blumenkrantz [Fri, 8 Mar 2019 15:55:11 +0000 (10:55 -0500)]
elm.code.widget: rename events to avoid conflicts
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8264
Mike Blumenkrantz [Fri, 8 Mar 2019 15:54:00 +0000 (10:54 -0500)]
efl.access.selection: rename events to avoid conflicts
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8263
Mike Blumenkrantz [Fri, 8 Mar 2019 15:53:04 +0000 (10:53 -0500)]
efl.ui.pan: namespace events to avoid conflicts
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8262
Mike Blumenkrantz [Fri, 8 Mar 2019 15:52:03 +0000 (10:52 -0500)]
efl_ui_selectable: namespace events to avoid conflicts
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8261
Change-Id: I304ae759d4d98becf1aad2a20af2d77ed4689d98
Mike Blumenkrantz [Fri, 8 Mar 2019 15:47:32 +0000 (10:47 -0500)]
efl-net: namespace events to avoid naming conflicts
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8260
Mike Blumenkrantz [Thu, 7 Mar 2019 23:40:20 +0000 (18:40 -0500)]
evas: add a bunch of interfaces type includes and typedefs
this sucks but we've been using these types in legacy headers for years
and it's not something we can rush in a fix for
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8248
Mike Blumenkrantz [Thu, 7 Mar 2019 23:39:32 +0000 (18:39 -0500)]
edje: restore edje legacy type that was defined to eo type
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8247
Mike Blumenkrantz [Thu, 7 Mar 2019 22:42:43 +0000 (17:42 -0500)]
evas: restore legacy types which were defined to eo types
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8245
Change-Id: Icecac2cd81bf67fcd3af69444e984d05438b7841
Mike Blumenkrantz [Thu, 7 Mar 2019 22:42:01 +0000 (17:42 -0500)]
headers: ensure Efl.h is always included behind BETA define guards
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8244
Mike Blumenkrantz [Thu, 7 Mar 2019 21:06:03 +0000 (16:06 -0500)]
Revert "Emile: Move colorspaces to Efl.Gfx"
This reverts commit
0d41ad0c837a2e1655a4d41c28ec7f0ccf10639c.
stop defining legacy types to eo types!!!!
https://i.redd.it/95mmznk5wo021.gif
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8243
Change-Id: I0fc806fc83cc37648c5a99cdb465a888474647cc