N0D4N [Mon, 15 Aug 2022 00:56:07 +0000 (03:56 +0300)]
Repoint urls in docs (#73766)
dotnet-maestro[bot] [Sun, 14 Aug 2022 22:02:39 +0000 (22:02 +0000)]
Update dependencies from https://github.com/dotnet/llvm-project build
20220812.3 (#73896)
[main] Update dependencies from dotnet/llvm-project
Vladimir Sadov [Sun, 14 Aug 2022 20:38:41 +0000 (13:38 -0700)]
[NativeAOT] Fix a stress crash in thread detach at process shutdown. (#73912)
* Fix a stress crash in thread detach at process shutdown.
* release alloc context
Shay Rojansky [Sun, 14 Aug 2022 20:33:17 +0000 (23:33 +0300)]
Safer state handling in distributed transactions (#73918)
Make sure we don't accidentally set our state to initialized when
an exception occurs.
Related to #73874.
Eric Erhardt [Sun, 14 Aug 2022 20:24:54 +0000 (15:24 -0500)]
Clean up temp directory methods in System.ComponentModel.Composition tests (#73857)
onehourlate [Sun, 14 Aug 2022 16:06:45 +0000 (18:06 +0200)]
System.Net.WebProxy Bypass regex list optimization (#73803)
* System.Net.WebProxy Bypass regex list optimization
Added change tracking to BypassArrayList to avoid reconstructing the bypass regex list at every call of IsBypassed
Fix #73703
* Cosmetic changes.
DirtyTrackingArrayList => ChangeTrackingArrayList.
IsDirty => IsChanged
Inner class moved to end
Ditched weird bool CheckDirty() with side effect in favor of void ResetIsChanged()
* Address PR feedback
Co-authored-by: Blaise Lepeuple <blaise.lepeuple@xelya.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Andrew Au [Sun, 14 Aug 2022 07:08:03 +0000 (00:08 -0700)]
Copy the string instead of returning different pointers (#73795)
Adeel Mujahid [Sun, 14 Aug 2022 06:01:42 +0000 (09:01 +0300)]
Fix and simplify __has_builtin conditions (#73905)
Ankit Jain [Sun, 14 Aug 2022 01:30:30 +0000 (21:30 -0400)]
[wasm] Misc tests related fixes (#73884)
* [wasm] Stop running crypto tests with subtlecrypto
* [wasm] Add --web-server-use-cop for samples when running on helix for a threaded build
* [wasm] Makefile, honor V=1 and emit binlog
* [wasm] PInvokeTableGenerator: emit the type name also, for the warning
* [wasm] Improve build for non-default runtime packs
.. by using `MSBuild` task to build them instead of invoking
`dotnet.sh`.
- And fix incremental builds
* [wasm] Run smoke tests only for AOT
- Building, and running all the tests for EAT case will help catch
linker errors that can slip through.
* [wasm] Fix linker errors for tests
Fixes https://github.com/dotnet/runtime/issues/73901
Aleksey Kliger (λgeek) [Sun, 14 Aug 2022 01:16:42 +0000 (21:16 -0400)]
[wasm-mt] Use asset loading for dotnet.worker.js; update WasmAppBuilder (#73697)
Enables using asset loading to get the `dotnet.worker.js` file that provides the emscripten pthread worker code.
Also allows specifying the number of pre-allocated workers that will be created at startup using MSBuild properties.
Fixes https://github.com/dotnet/runtime/issues/68509 and fixes https://github.com/dotnet/runtime/issues/68397 and fixes https://github.com/dotnet/runtime/issues/72606
- Override Emscripten `PThread.allocateUnusedWorker`
We want to use our own allocateUnusedWorker because we want to load
`dotnet.worker.js` using our asset loading machinery.
Unfortunately, Emscripten first calls allocateUnusedWorker very early (from
`PThread.init`) to pre-allocate the pthread worker pool.
So we set Emscripten's own pthread worker pool to size 0 and make our own. This requires calling `loadWasmModuleToWorker` during our startup because Emscripten deletes their code that normally does it (in "receiveInstance" in "createWasm" in "emscripten/src/preamble.js") when the pthread pool size is 0.
Also added a pthreadPoolSize field to MonoConfig to allow specifying the initial pthread pool size in mono-config.json
- Add `IncludeThreadsWorker` and `PThreadPoolSize` props to WasmAppBuilder
`IncludeThreadsWorker` adds the `"js-module-threads"` asset to the `mono-config.json`
`PThreadPoolSize` can be -1 or >=0 to specify the number of workers that will be pre-allocated at startup for the pthread worker pool. -1 means use the default compiled into `dotnet.js`
- Reorganize the pthreads TS code by moving `Internals` (access API that digs through Emscripten's pthreads implementation) to its own module. And add types.
- Replace emscripten's `allocateUnusedWorker` function with our own that goes through the asset loading API.
- Update samples
- Set up console proxying for the workers.
This is done by sending a message from the main thread to the pthread workers with the current `MonoConfig` on our
dedicated channel. (This means the proxying is setup asynchronously, so if the worker is busy before it receives the message, it may not start redirecting messages right away).
---
* [wasm-mt] Override Emscripten PThread.allocateUnusedWorker
We want to use our own allocateUnusedWorker because we want to load `dotnet.worker.js` using our asset loading machinery.
Unfortunately, Emscripten first calls allocateUnusedWorker very early (from `PThread.init`) to pre-allocate the pthread worker pool.
So we set Emscripten's own pthread worker pool to size 0 and make our own. This requires calling `loadWasmModuleToWorker` during our startup because Emscripten deletes their code that normally does
it (in "receiveInstance" in "createWasm" in "emscripten/src/preamble.js") when the pthread pool size is 0.
Also added a pthreadPoolSize field to MonoConfig to allow specifying the initial pthread pool size in mono-config.json
* Add IncludeThreadsWorker and PThreadPoolSize props to WasmAppBuilder
IncludeThreadsWorker adds the js-module-threads asset to the mono-config
PThreadPoolSize can be -1 or >=0 to specify the number of workers that will be pre-allocated at startup for the pthread worker pool. -1 means use the default compiled into dotnet.js
* Move emscripten PThread internals access to a separate module
and add types
* Load js-module-threads asset in replacement allocateUnusedWorker
* Update samples to explicitly enable threading / perftracing
Makes the WasmAppBuilder include the threads worker module
* tighten up Internals types
* apply review feedback
* fix import
* Apply suggestions from code review
* proxy pthread worker messages to websocket, if enabled
use a new MonoThreadMessageApplyMonoConfig message to send the MonoConfig from the main thread to each worker when the workers set up the communication channel to the main thread.
then if the diagnosticTracing property is true, redirect the worker console logging to a websocket.
Fixes https://github.com/dotnet/runtime/issues/72606
Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
dotnet-maestro[bot] [Sun, 14 Aug 2022 00:09:39 +0000 (20:09 -0400)]
Update dependencies from https://github.com/dotnet/hotreload-utils build
20220808.2 (#73895)
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 1.1.0-alpha.0.22362.1 -> To Version 1.1.0-alpha.0.22408.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Bruce Forstall [Sat, 13 Aug 2022 21:49:23 +0000 (14:49 -0700)]
Fix arm64 scalar intrinsic use with small arguments (#73876)
The code already uses `emitActualTypeSize` in the scalar case;
this also uses `genActualType` to get the "actual" type of small
types when deciding the intrinsic base type, used in codegen.
Fixes #73804
Stephen Toub [Sat, 13 Aug 2022 20:36:04 +0000 (16:36 -0400)]
Streamline String.Substring (#73882)
- Split the one-arg Substring from the two-arg Substring to avoid unnecessary checks in the former
- Employ the same argument validation checks as Span, and then delegate to a helper that does more detailed checking to throw the right exception
- Avoid duplicative checks in the body
- Reorder checks in one-arg overload to do success paths before error paths where possible
Michal Strehovský [Sat, 13 Aug 2022 20:34:10 +0000 (05:34 +0900)]
Remove ActiveIssue for Matrix4x4CreateFromAxisAngleTest (#73870)
Fixes #72149.
Michal Strehovský [Sat, 13 Aug 2022 20:26:07 +0000 (05:26 +0900)]
Baseline failing tests (#73888)
* S,Transactions is a new test with a bunch of COM
* PasswordDeriveBytes calls into RequiresUnreferencedCode. It used to be lucky. Not anymore because we trim more.
Tomas Weinfurt [Sat, 13 Aug 2022 19:54:18 +0000 (12:54 -0700)]
ignore name mismatch when IgnoreInvalidName is set (#73745)
* ignore name mismatch when IgnoreInvalidName is set
* remove dead code
* feedback from review
* fix build
* split Configuration.Certificates
* disable win7
* update test
* skip on browser
Filip Navara [Sat, 13 Aug 2022 19:50:59 +0000 (21:50 +0200)]
Add missing NegotiateAuthentication documentation (#73890)
Aleksey Kliger (λgeek) [Sat, 13 Aug 2022 19:41:42 +0000 (15:41 -0400)]
[metadata] Do less initialization in mono_class_is_assignable (#73786)
* [metadata] Do less initialization in mono_class_is_assignable
Instead of running the full mono_class_init_internal, just initialize
the supertypes and the interface bitmap.
Add a flag to mono_class_setup_interface_offsets to only publish the
interface bitmap, not the offsets.
Also move the SRE hack (setting a field in MonoClass to null and
running mono_class_setup_interface_offsets) to a new function
mono_class_invalidate_interface_offsets.
Also change the field that the SRE hack uses as a sentinel (used to be
MonoClass:interfaces_packed, now MonoClass:interface_offsets_packed)
Fixes https://github.com/dotnet/runtime/issues/68033
* avoid assert in bitmap_only mode
* remove MonoGenericContext need_sync bit
it is never set to TRUE
* ensure gtd is inited when initing a ginst
* remove unused var
* add regression test
Adam Sitnik [Sat, 13 Aug 2022 18:13:27 +0000 (20:13 +0200)]
Port IndexOfAny(ref char, char[1-5], int) to Vector128/256 (#73469)
Eric Erhardt [Sat, 13 Aug 2022 15:46:07 +0000 (10:46 -0500)]
EnableAOTAnalyzer for Microsoft.Extensions.Hosting (#73853)
* EnableAOTAnalyzer for Microsoft.Extensions.Hosting
Fix #71654
Plus clean up the interop in GetParentProcess.
Charles Stoner [Sat, 13 Aug 2022 12:40:25 +0000 (05:40 -0700)]
More updates for recent compiler changes for ref fields (#73883)
Marek Fišera [Sat, 13 Aug 2022 08:56:21 +0000 (10:56 +0200)]
[wasm] Support parameters of type Enum with icalls (#73817)
* [wasm] Support parameters of type Enum with icalls, with tests
* [wasm] WBT: convert sdk path to full, if needed
Co-authored-by: Ankit Jain <radical@gmail.com>
Steve Molloy [Sat, 13 Aug 2022 07:28:42 +0000 (00:28 -0700)]
Allow for null XmlSerialziers when loading pre-gen from mappings. (#73827)
* Allow for null XmlSerialziers when loading pre-gen from mappings.
* Update ref signatures as well.
Steve Molloy [Sat, 13 Aug 2022 07:25:35 +0000 (00:25 -0700)]
Bring back readability lost in .Net 6, and stop emitting BOM. (#73731)
* Bring back readability lost in .Net 6, and stop emitting BOM.
* Adjust test for wasm.
Steve Molloy [Sat, 13 Aug 2022 07:24:59 +0000 (00:24 -0700)]
Implement IXmlTextWriterInitializer on the async writer wrapper. (#73730)
* Implement IXmlTextWriterInitializer on the async writer wrapper.
* Don't use generics per PR feedback.
* Use cast in SetOutput instead of typed field.
Steve Molloy [Sat, 13 Aug 2022 07:17:00 +0000 (00:17 -0700)]
66163 fatal error xml serializer immutable array (#73729)
* Fiddle the RefEmit IL for value-type arrays like ImmutableArray. Add tests for expected and non-fatal read-only failures.
* Extend fixup to cover other 'Immutable' collection types.
* Skip ROC and Immutable tests in pregenerated test suite. Those types aren't in the pregen dll.
!cake [Sat, 13 Aug 2022 07:09:01 +0000 (08:09 +0100)]
Fix `DataContractJsonSerializer`'s handling of -0.0 (#69020)
* Add serialization test for -0.0
* Fix `DataContractJsonSerializer`'s handling of -0.0
Fixes #69019.
Steve Molloy [Sat, 13 Aug 2022 07:07:25 +0000 (00:07 -0700)]
DCS alignment to 4.8 with schema support (#71752)
* Fix Private.Xml solution broken by https://github.com/dotnet/runtime/pull/70706.
* Align DCS with 4.8 implementation - minus schema import/export.
* External DCS Schema support groundwork. Before DC-tree work and other public APIs.
* Added public APIs, but not the DataContract tree yet.
* All APIs in.
* Cleanup.
* Addressed some nits and PR feedback on API.
* API nit, more PR feedback.
* Fix HasRoot hiding issue.
* Add basic schema tests. Fix DataMember bug.
* Add /// comments for new schema project.
* Fixing bad format in xml comment.
* Skip import test on Wasm.
* Obsolete old half-coded schema exporter.
* Add obsolete attribute in ref project as well.
* Removing obsolete for now, since it appears Syndication depends on old class.
* Fix the DCJS ref project.
* API cleanup.
* Project file cleanup
* Fix mono issue with reflection access to non-public private fields.
* Addressing feedback from API review.
* Port NetFx Export/Import test suites to Serializer test projects.
* Fix bugs found by newly ported tests.
* Account for different newline sizes on different platforms.
* Skip flaky test on wasm for now.
* Non-draft PR feedback.
* Change DC.Members API. Drop KVP shennanigans.
* More PR feedback.
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Steve Molloy [Sat, 13 Aug 2022 02:59:44 +0000 (19:59 -0700)]
Revert "Add annotations to System.Private.DataContractSerialization (#73337)" (#73878)
This reverts commit
c4ea2caaa63322da54e289f490ba3bb4820e9303.
Charles Stoner [Sat, 13 Aug 2022 02:44:10 +0000 (19:44 -0700)]
Update for recent compiler changes for ref fields (#73466)
* Update for recent compiler changes for ref fields
Thays Grazia [Sat, 13 Aug 2022 02:38:46 +0000 (23:38 -0300)]
[wasm][debugger] Breakpoint set in a invalid line, set it to the next available line (#73189)
* Adding more tests, including async cases. Some odd ones are broken at this time
Co-authored-by: Ankit Jain <radical@gmail.com>
dotnet-maestro[bot] [Sat, 13 Aug 2022 00:49:10 +0000 (20:49 -0400)]
Update dependencies from https://github.com/dotnet/linker build
20220812.3 (#73865)
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22411.2 -> To Version 7.0.100-1.22412.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Jeremy Koritzinsky [Sat, 13 Aug 2022 00:04:08 +0000 (17:04 -0700)]
Fix ASAN-detected alloc-dealloc mismatch (#73820)
* Fix the alloc/dealloc mismatch by using a custom parameterized new operator.
* Use custom struct wrapper type to avoid errors about placement new
Theodore Tsirpanis [Fri, 12 Aug 2022 23:48:47 +0000 (02:48 +0300)]
Optimize `AssemblyLoadContext.LoadFromStream` and fix partial reads. (#72783)
Vladimir Sadov [Fri, 12 Aug 2022 23:37:49 +0000 (16:37 -0700)]
[NativeAOT] Follow up changes for the suspension loop routine. (#73741)
* add timing
* do not hijack redirected threads
* tweak the suspend loop implementation
* remove instrumentation
Steve Harter [Fri, 12 Aug 2022 23:36:04 +0000 (18:36 -0500)]
Unblock System.Configuration CI test errors for Android,tvOS,iOS (#73852)
Disables tests to unblock CI. Will investigate further to see if there is an underlying issue.
See https://github.com/dotnet/runtime/issues/73792
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
Buyaa Namnan [Fri, 12 Aug 2022 23:07:51 +0000 (16:07 -0700)]
Support void* to UIntPtr parameter conversion for Invoked method (#73748)
* Add UIntPtr conversion
* Use existing method for UIntPtr, update nativeaot version
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Will Smith [Fri, 12 Aug 2022 22:41:54 +0000 (15:41 -0700)]
Disable more ILASM roundtrip tests (#73831)
* Disable more ilasm roundtrip tests
* Update HugeField1.csproj
* Update mainv1.csproj
* Update HugeField1.csproj
* Update mainv1.csproj
Drew Kersnar [Fri, 12 Aug 2022 22:15:56 +0000 (17:15 -0500)]
Add AllBitsSet DIM (#72961)
* Add AllBitsSet Dim
* Apply suggestion from code review
* Add unit test for DIM
* Apply suggestions from code review
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
* Apply suggestions from code review
* Fix typo causing compile errors
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Tlakaelel Axayakatl Ceja [Fri, 12 Aug 2022 21:51:20 +0000 (14:51 -0700)]
Add annotations to System.Private.DataContractSerialization (#73337)
Add annotations to System.Private.DataContractSerialization
Jakob Botsch Nielsen [Fri, 12 Aug 2022 21:33:13 +0000 (23:33 +0200)]
JIT: Fix STORE_DYN_BLK morphing (#73844)
Make sure to properly call SetIndirExceptionFlags and to properly mark defs (that will otherwise hit asserts in rationalization).
Katya Sokolova [Fri, 12 Aug 2022 21:04:34 +0000 (23:04 +0200)]
Handle web socket downgrade when HTTP/2 not enabled (#73843)
* Handle downgrade when HTTP/2 not enabled
* Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
* feedback
* Force 1.1 for non-secure web request if policy allows
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
Krzysztof Wicher [Fri, 12 Aug 2022 20:53:11 +0000 (22:53 +0200)]
Fix NRT annotations for XmlProcessingInstruction (#73687)
* Fix NRT annotations for XmlProcessingInstruction
* fix comment, replace assert with ArgumentNullException.ThrowIfNull
* add argument name to ArgumentException, fix comment
Adeel Mujahid [Fri, 12 Aug 2022 20:02:41 +0000 (23:02 +0300)]
Remove executable bits from generated shared libs (#73686)
Drew Kersnar [Fri, 12 Aug 2022 19:56:59 +0000 (14:56 -0500)]
Fix BigInteger.Parse returning incorrect values for exponents above 1000 (#73643)
* Fixing problem with invalid parse scientific form of numbers. (#17296)
* Preventing OverflowException when parsing scientific form of numbers. (#17296)
* Suggestions from review
* Added bigger test cases
* Adjusted cutoff to 9 digits
* Accidental commit
Co-authored-by: Maksim Golev <mixim33@yandex.ru>
Levi Broderick [Fri, 12 Aug 2022 19:55:05 +0000 (12:55 -0700)]
Obsolete XmlSecureResolver (#73676)
- Add XmlResolver.ThrowingResolver
- Migrate all call sites to the new API
- Improve error messages on failure
Resolves CVE-2022-34716.
Elinor Fung [Fri, 12 Aug 2022 19:39:31 +0000 (12:39 -0700)]
Only include host.native instead of all host in default clr/mono subsets (#73800)
dotnet-maestro[bot] [Fri, 12 Aug 2022 19:26:17 +0000 (21:26 +0200)]
[main] Update dependencies from dotnet/arcade (#73767)
* Update dependencies from https://github.com/dotnet/arcade build
20220810.3
Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 7.0.0-beta.22408.3 -> To Version 7.0.0-beta.22410.3
* Update dependencies from https://github.com/dotnet/arcade build
20220811.2
Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 7.0.0-beta.22408.3 -> To Version 7.0.0-beta.22411.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Fri, 12 Aug 2022 19:24:42 +0000 (21:24 +0200)]
Update dependencies from https://github.com/dotnet/xharness build
20220811.1 (#73846)
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22408.1 -> To Version 1.0.0-prerelease.22411.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Jeff Handley [Fri, 12 Aug 2022 19:20:59 +0000 (12:20 -0700)]
Rename 'up-for-grabs' label to 'help wanted' (#73810)
David Cantú [Fri, 12 Aug 2022 18:45:23 +0000 (13:45 -0500)]
COSE: Add APIs needed for countersign (#73796)
* Add APIs needed for countersign
* Use associated with instead of associated to
Lakshan Fernando [Fri, 12 Aug 2022 18:44:14 +0000 (11:44 -0700)]
Fix component model aot test (#73734)
* Partial fix for ComponentModel.TypeConverter tests
* Fix ComponentModel.TypeConverter tests
* enable the test proj
* FB
* working around a test build fail
* Update src/libraries/System.ComponentModel.TypeConverter/tests/BindableAttributeTests.cs
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
* Update src/libraries/tests.proj
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Tomas Weinfurt [Fri, 12 Aug 2022 18:42:33 +0000 (11:42 -0700)]
support InfiniteTimeSpan in Select (#73204)
* support InfiniteTimeSpan in Select
* fix test
* feedback from review
* Apply suggestions from code review
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Miha Zupan [Fri, 12 Aug 2022 18:35:06 +0000 (20:35 +0200)]
Respect the Keep-Alive response header on HTTP/1.1 as well (#73585)
* Respect the Keep-Alive response header on HTTP/1.1 as well
* Add some more comments
Tanner Gooding [Fri, 12 Aug 2022 18:31:20 +0000 (11:31 -0700)]
Mark RunGetBitLengthTestsLarge as outerloop and skipped on iOS/tvOS/Android/Browser (#73773)
Brennan [Fri, 12 Aug 2022 17:56:48 +0000 (10:56 -0700)]
[RateLimiting] Add statistics API (#72306)
Katya Sokolova [Fri, 12 Aug 2022 17:28:01 +0000 (19:28 +0200)]
No end stream on ws connect and flush every message (#73762)
* No end stream on ws connect and flush every message
* Apply suggestions from code review
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
* Await flush in web socket after write
* Flush for web socket tests should be supported
* feedback
* Refactoring write and flush tasks in WebSocket
* feedback
* Replace check for more generic extended connect
* Apply suggestions from code review
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* feedback
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
dotnet-maestro[bot] [Fri, 12 Aug 2022 17:21:44 +0000 (10:21 -0700)]
[main] Update dependencies from dotnet/linker (#73410)
* Update dependencies from https://github.com/dotnet/linker build
20220804.4
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22404.4
* Update dependencies from https://github.com/dotnet/linker build
20220804.5
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22404.5
* Update dependencies from https://github.com/dotnet/linker build
20220805.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22405.1
* Update dependencies from https://github.com/dotnet/linker build
20220808.3
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22408.3
* Update dependencies from https://github.com/dotnet/linker build
20220809.9
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22409.9
* Added and modified suppressions
* Disable IL2121 everywhere for now
* Disable IL2121 in trimming tests
* Disable IL2121 in wam samples
* Disable IL2121 in libraries tests
* Update dependencies from https://github.com/dotnet/linker build
20220811.2
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22411.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Jeremi Kurdek <jkurdek@gmail.com>
Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Jose Perez Rodriguez [Fri, 12 Aug 2022 17:21:25 +0000 (10:21 -0700)]
Adding documentation explaining case-insensitive behavior across engines (#73814)
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Alhad Deshpande [Fri, 12 Aug 2022 17:02:23 +0000 (22:32 +0530)]
[Ppc64le] Added memory patch thunking for function calls (#73616)
* [ppc64le] Added memory patch thunking for function calls
* Incorporated code review comments and changes in OP_TAILCALL for mempry patching
* [ppc64le] Fixed test failures and code refactoring
* [ppc64le] Enabled g_assert for code sequence check and removed white spaces
* [ppc64le] Fixed build issue in mini-ppc.h
* [ppc64le] Incorporated code review comments
Miha Zupan [Fri, 12 Aug 2022 16:58:43 +0000 (18:58 +0200)]
Access the User-Agent for CONNECT tunnels early (#73331)
madelson [Fri, 12 Aug 2022 16:42:45 +0000 (12:42 -0400)]
Improve NullabilityInfoContext behavior for ByRef types. (#73520)
* Improve NullabilityInfoContext behavior for ByRef types.
fix #72320
Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Thays Grazia [Fri, 12 Aug 2022 16:28:46 +0000 (13:28 -0300)]
[debugger] First draft of managed debugger on wasi (#67272)
* first version of debug wasi
* remove comment
* fixing readme
* Fix compilation error
* fix compilation error
* fix compilation
* addressing steve comment
* Stepping working
* fix debugging aspnetcore app
* wrong merge
* addressing @viniciusjarina comment
* addressing steve comments
* work for remote debugging
* make it work on windows
* Update mini-wasi-debugger.c
fix indentation
* Update mini-wasi-debugger.c
* Update mini-wasi-debugger.c
* Trying to fix compilation
* Update src/mono/mono/component/mini-wasi-debugger.c
Co-authored-by: Ankit Jain <radical@gmail.com>
* Update src/mono/mono/component/mini-wasi-debugger.c
Co-authored-by: Ankit Jain <radical@gmail.com>
* Update src/mono/mono/component/mini-wasi-debugger.c
Co-authored-by: Ankit Jain <radical@gmail.com>
* Update src/mono/mono/component/debugger-agent.c
Co-authored-by: Ankit Jain <radical@gmail.com>
* Update src/mono/mono/component/debugger-agent.c
Co-authored-by: Ankit Jain <radical@gmail.com>
* Update src/mono/mono/mini/interp/interp.c
Co-authored-by: Ankit Jain <radical@gmail.com>
* Update src/mono/mono/mini/interp/interp.c
Co-authored-by: Ankit Jain <radical@gmail.com>
* Update src/mono/wasi/Makefile
Co-authored-by: Ankit Jain <radical@gmail.com>
* Update src/mono/wasi/mono-wasi-driver/driver.c
Co-authored-by: Ankit Jain <radical@gmail.com>
* Update src/mono/mono/component/debugger-agent.c
Co-authored-by: Ankit Jain <radical@gmail.com>
* Addressing @radical comments
* fix compilation errors
* fixing readme
* debugger working again
* addressing @BrzVlad comments
* Addressing @radical comments
* Fix merge
* Fix merge
* Update diagnostics_server.c
* Treat root directory as always existing, even if WASI isn't granting filesystem access. Needed for ASP.NET Core.
* Update sample build config
* Stop trying to use JS (browser) APIs for crypto, as there is no JS in wasi
* Revert unneeded change
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
* Addressing @radical comments
* Addressing @radical comments
* fixing debugger behavior and addressing @radical comments
* Addressing @ SteveSandersonMS comments
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
* Addressing radical comments
* [wasi] Provision wasmtime as needed
* [wasi] build, and run wasi sample on CI
* [wasi] don't install wasmtime by default, but do that for CI
* [wasi] Show a useful error if wasmtime is not found
* [wasi] provision ninja
* Fix path
* Fix warnings to make CI green
* debug
* Move building wasi into a separate yml step, so it gets built after the whole wasm build is complete
* fix yml
* Enable wasi build on libtests job
* Fix yml again
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
Vlad Brezae [Fri, 12 Aug 2022 15:54:33 +0000 (18:54 +0300)]
[mono][jit] Don't inflate Mono.ValueTuple with byrefs (#73689)
Mono.ValueTuple's must have the same layout as the original vtype. Use normal IntPtr for ref fields. This also allows sharing of more signatures. Before this change the behavior was dubious when sharing valuetypes with ref fields (like Span). The value tuple class was inflated with byref types and it ended up having byref fields, even though it is not byreflike, resulting in failure during class loading.
Tanner Gooding [Fri, 12 Aug 2022 15:52:12 +0000 (08:52 -0700)]
Ensure partial Vector256 acceleration is still possible on AVX only hardware (#73720)
* Ensure that Vector256 APIs exposed in .NET Core 3.1 remain accelerated in .NET 7
* Ensure new Vector256 APIs that are trivially limited to Avx only are accelerated
Alexander Köplinger [Fri, 12 Aug 2022 15:51:13 +0000 (17:51 +0200)]
Fix build error in mini-ppc.h (#73845)
Looks like this got inadvertently broken by https://github.com/dotnet/runtime/pull/65723
Marek Fišera [Fri, 12 Aug 2022 15:39:05 +0000 (17:39 +0200)]
[wasm] Log as warning in interop generator when method signature is not supported (#71477)
Introduce WASM0001 warning code for not supported pinvoke and icall signatures.
Brennan [Fri, 12 Aug 2022 15:28:26 +0000 (08:28 -0700)]
[RateLimiting] Update TranslateKey to allow disposal of wrapped limiter (#73160)
Eric Erhardt [Fri, 12 Aug 2022 15:21:32 +0000 (10:21 -0500)]
EnableAOTAnalyzer for Microsoft.Extensions.DependencyInjection (#73829)
Using MEDI is annotated as RequiresDynamicCode because it supports enumerable and generic servcies with ValueTypes. When using DI with ValuesTypes, the array and generic code might not be available.
Contributes to #71654
Tom Deseyn [Fri, 12 Aug 2022 14:54:02 +0000 (16:54 +0200)]
Tar: restore directory permissions while extracting. (#72078)
* Tar: restore directory permissions while extracting.
* PR feedback.
* On Windows, as on Unix: don't set group/other write permission by default.
* Fix Windows compilation.
* Fix Windows compilation II.
* Update test for Windows.
* Fix test WindowsFileMode value.
* Remove branch.
* Apply suggestions from code review
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
* Add back DefaultWindowsMode.
* Fix build failure in TarWriter due to DefaultWindowsMode usage.
* Fix DefaultWindowsMode.
* Apply suggestions from code review
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
Victor Irzak [Fri, 12 Aug 2022 13:21:32 +0000 (09:21 -0400)]
Handle FileStream.Length for devices (#73708)
Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Caleb Cornett [Fri, 12 Aug 2022 12:52:54 +0000 (08:52 -0400)]
Add FEATURE_READONLY_GS_COOKIE for NativeAOT (#73744)
Michal Strehovský [Fri, 12 Aug 2022 12:50:45 +0000 (21:50 +0900)]
Prevent devirtualization into unallocated types (#73839)
If we were in a situation like in the regression test, we would devirtualize the `GrabObject` call to `SomeUnallocatedClass.GrabObject`. But because `SomeUnallocatedClass` was never allocated, the scanner didn't scan it, and bad things would happen.
Prevent devirtualizing into types that were not seen as allocated.
This is not a real issue for non-generic (non-shareable) types because the tentative instance method optimization generates throwing bodies for these. But tentative method optimization doesn't run for shared generics:
https://github.com/dotnet/runtime/blob/
4cbe6f99d23e04c56a89251d49de1b0f14000427/src/coreclr/tools/Common/Compiler/MethodExtensions.cs#L115
This was rare enough that we haven't seen it until I did #73683 and there was one useless constructor that we stopped generating and triggered this.
This also includes what is essentially a rollback of https://github.com/dotnet/runtimelab/pull/1700. This should have been rolled back with https://github.com/dotnet/runtime/pull/66145 but I forgot we had this. It was not needed.
* Update tests.proj
Ankit Jain [Fri, 12 Aug 2022 11:58:52 +0000 (07:58 -0400)]
[wasm] Disable some tests on NodeJS/Windows (#73834)
- Disable some tests on NodeJS/Windows
- Introduce NodeJS platform in PlatformDetection.
Co-authored-by: Marek Fišera <mara@neptuo.com>
Katelyn Gadd [Fri, 12 Aug 2022 11:05:27 +0000 (04:05 -0700)]
Introduce a default synchronization context for wasm (#72652)
Introduce a JSSynchronizationContext that automatically remotes function calls back to the browser thread and queues them as background jobs.
Exercise sync context in threads sample to display the complete progress indicator
Clean up an old copy-paste error in the typescript
Shay Rojansky [Fri, 12 Aug 2022 09:58:48 +0000 (12:58 +0300)]
Port distributed transaction support for Windows (#72051)
Closes #715
Michal Strehovský [Fri, 12 Aug 2022 07:53:01 +0000 (16:53 +0900)]
Fix repro project for Release builds (#73836)
dotnet-maestro[bot] [Fri, 12 Aug 2022 07:24:18 +0000 (09:24 +0200)]
[main] Update dependencies from 8 repositories (#72934)
* Update dependencies from https://github.com/dotnet/runtime-assets build
20220726.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 7.0.0-beta.22361.2 -> To Version 7.0.0-beta.22376.1
* Update dependencies from https://github.com/dotnet/emsdk build
20220726.1
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-rc.1.22368.1 -> To Version 7.0.0-rc.1.22376.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220728.2
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22373.2 -> To Version 7.0.0-preview1.22378.2
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220729.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22373.2 -> To Version 7.0.0-preview1.22379.1
* Update dependencies from https://github.com/dotnet/runtime build
20220731.5
Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 7.0.0-rc.1.22374.4 -> To Version 7.0.0-rc.1.22381.5
* Update dependencies from https://github.com/dotnet/icu build
20220802.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 7.0.0-rc.1.22375.1 -> To Version 7.0.0-rc.1.22402.1
* Update dependencies from https://github.com/dotnet/xharness build
20220801.2
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22375.5 -> To Version 1.0.0-prerelease.22401.2
* Update dependencies from https://github.com/dotnet/emsdk build
20220801.1
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-rc.1.22368.1 -> To Version 7.0.0-rc.1.22401.1
* Update dependencies from https://github.com/dotnet/runtime-assets build
20220802.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 7.0.0-beta.22361.2 -> To Version 7.0.0-beta.22402.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20220803.2
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22373.2 -> To Version 7.0.0-preview1.22403.2
* Update dependencies from https://github.com/dotnet/msquic build
20220803.1
System.Net.MsQuic.Transport
From Version 7.0.0-alpha.1.22371.1 -> To Version 7.0.0-alpha.1.22403.1
* Update dependencies from https://github.com/dotnet/llvm-project build
20220804.1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
From Version 1.0.0-alpha.1.22364.1 -> To Version 1.0.0-alpha.1.22404.1
* Update dependencies from https://github.com/dotnet/xharness build
20220805.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22375.5 -> To Version 1.0.0-prerelease.22405.1
* Update dependencies from https://github.com/dotnet/emsdk build
20220805.3
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-rc.1.22368.1 -> To Version 7.0.0-rc.1.22405.3
* Update dependencies from https://github.com/dotnet/msquic build
20220805.1
System.Net.MsQuic.Transport
From Version 7.0.0-alpha.1.22371.1 -> To Version 7.0.0-alpha.1.22405.1
* Update dependencies from https://github.com/dotnet/llvm-project build
20220806.4
runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 11.1.0-alpha.1.22376.4 -> To Version 11.1.0-alpha.1.22406.4
* Update dependencies from https://github.com/dotnet/runtime build
20220807.4
Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json
From Version 7.0.0-rc.1.22374.4 -> To Version 7.0.0-rc.1.22407.4
* Update dependencies from https://github.com/dotnet/icu build
20220808.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 7.0.0-rc.1.22375.1 -> To Version 7.0.0-rc.1.22408.1
* Update dependencies from https://github.com/dotnet/xharness build
20220808.1
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.22375.5 -> To Version 1.0.0-prerelease.22408.1
* Update dependencies from https://github.com/dotnet/emsdk build
20220808.2
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-rc.1.22368.1 -> To Version 7.0.0-rc.1.22408.2
* Update dependencies from https://github.com/dotnet/llvm-project build
20220808.2
runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
From Version 11.1.0-alpha.1.22376.4 -> To Version 11.1.0-alpha.1.22408.2
* Update dependencies from https://github.com/dotnet/runtime-assets build
20220809.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 7.0.0-beta.22361.2 -> To Version 7.0.0-beta.22409.1
* Use stable VS2022 build images
llvm-project uses that one too now so we shouldn't hit the MSVC ABI issue
* Update dependencies from https://github.com/dotnet/llvm-project build
20220811.1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
From Version 1.0.0-alpha.1.22364.1 -> To Version 1.0.0-alpha.1.22411.1
* Update dependencies from https://github.com/dotnet/emsdk build
20220811.1
Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
From Version 7.0.0-rc.1.22368.1 -> To Version 7.0.0-rc.1.22411.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Stephen Toub [Fri, 12 Aug 2022 04:09:16 +0000 (00:09 -0400)]
Avoid url string allocation in WebProxy.IsMatchInBypassList (#73807)
* Avoid url string allocation in WebProxy.IsMatchInBypassList
* Update src/libraries/System.Net.WebProxy/src/System/Net/WebProxy.cs
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Buyaa Namnan [Fri, 12 Aug 2022 02:39:19 +0000 (19:39 -0700)]
Copy default value back when Missing.Value is provided as argument (#73670)
* Copy back Missing.Value after Invoke
* Refactor to use existing copy back mechanism
Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
Theodore Tsirpanis [Fri, 12 Aug 2022 01:47:38 +0000 (04:47 +0300)]
Fix `IBinaryInteger.Read***Endian` to accept a `ReadOnlySpan<byte>`. (#73802)
Aaron Robinson [Fri, 12 Aug 2022 00:59:55 +0000 (20:59 -0400)]
Add missing interop doc (#73805)
Tarek Mahmoud Sayed [Fri, 12 Aug 2022 00:32:57 +0000 (17:32 -0700)]
Add missing doc tags to TimeOnly type. (#73801)
Hong Li [Thu, 11 Aug 2022 22:35:05 +0000 (15:35 -0700)]
fix a couple issues with Microsoft.XmlSerailizer.Generator (#73550)
* fix a couple issues with Microsoft.XmlSerailizer.Generator
* update per PR feedback
* update 2 - change default to True
* correct a mistake
Eric Erhardt [Thu, 11 Aug 2022 22:14:53 +0000 (17:14 -0500)]
EnableAOTAnalyzer for most of Microsoft.Extensions libraries (#73737)
The only libraries that aren't enabled yet are DependencyInjection and Hosting. These will come in a separate PR.
Contributes to #71654
Michal Strehovský [Thu, 11 Aug 2022 20:51:28 +0000 (05:51 +0900)]
Fix handling of no metadata type (#73759)
Turns out we do have one situation where a MethodTable would have no metadata - when it's the unconstructed MethodTable. User code doesn't see them.
Tom McDonald [Thu, 11 Aug 2022 20:00:59 +0000 (16:00 -0400)]
Update cmake endif statement (#73787)
#73769
Pavel Savara [Thu, 11 Aug 2022 19:50:20 +0000 (21:50 +0200)]
[wasm] fix error cases in assets loading (#73702)
* fix bad rename of maxParallelDownloads - throttling
* fix re-try logic
* fixed counting of loaded assets
* catching more error cases
* fix blazor detection
SingleAccretion [Thu, 11 Aug 2022 19:35:20 +0000 (22:35 +0300)]
Properly encode small structs in bitcasts (#73717)
* Encode small structs as bitcast targets
* Add a test
Radek Zikmund [Thu, 11 Aug 2022 19:35:07 +0000 (21:35 +0200)]
Temporarily remove Windows.11.Arm64.Open queue (#73780)
https://github.com/dotnet/runtime/pull/73713 added Windows.11.Arm64.Open runs to check MsQuic functionality there, but currently, there is no HW servicing the queue and the ci job timeouts. This PR temporarily suspends runs on the queue until appropriate HW is deployed to helix.
Tanner Gooding [Thu, 11 Aug 2022 17:24:35 +0000 (10:24 -0700)]
Ensure BitIncrement/BitDecrement for Half works correctly (#73631)
Layomi Akinrinade [Thu, 11 Aug 2022 16:51:46 +0000 (09:51 -0700)]
Honor naming policy for string enum deserialization (#73348)
* Honor naming policy for string enum deserialization
* Remove cache bounds in favor of correctness
* Address feedback
* Remove possibly invalid dictionary key policy cache
* Address feedback
* Address feedback
* Clean up
Peter Sollich [Thu, 11 Aug 2022 16:18:50 +0000 (18:18 +0200)]
Fix two issues: (#73761)
- verify_region_to_generation_map needs to skip read only segments as they are not represented in the region to generation map.
- move check to verify the mark queue is empty from the destructor to a normal method, and add a call to that method at the end of the mark phase.
Mitchell Hwang [Thu, 11 Aug 2022 14:50:42 +0000 (10:50 -0400)]
[libs] Remove JitInfoIsPopulated mobile activeissue (#73716)
Simon Rozsival [Thu, 11 Aug 2022 12:05:11 +0000 (14:05 +0200)]
[Android][iOS] Enable HttpClientHandler.DangerousAcceptAnyServerCertificateValidator when using native handlers (#73763)
The static `HttpClientHandler.DangerousAcceptAnyServerCertificateValidator` getter throws PNSE when the native HTTP handler is enabled because Xamarin.Android's `AndroidMessageHandler` and Xamarin.iOS `NSUrlSessionHandler` didn't use to have support for the `ServerCertificateCustomValidationCallback`.
We already implemented the Android part in .NET 6 and support in the iOS implementation is WIP and we should be able to implement it in time for .NET 7. IMO it's safe to remove the exception in the getter in .NET 7.
Closes #68898
Krzysztof Wicher [Thu, 11 Aug 2022 10:44:53 +0000 (12:44 +0200)]
Fix JSON source gen to work with public context and public types with internal properties (#73622)
Michal Strehovský [Thu, 11 Aug 2022 10:33:32 +0000 (19:33 +0900)]
Disable newly added TraceSource.Config.Tests on NativeAOT (#73742)
Likely a single file related issue. Not sure how ConfigurationManager grabs the config files, but probably Assembly.Location. Will need to look at that.
```
[FAIL] System.Diagnostics.TraceSourceConfigTests.ConfigurationTests.ConfigWithEvents_RuntimeListener
System.Configuration.ConfigurationErrorsException : Could not create System.Diagnostics.SourceSwitch.
at System.Diagnostics.TraceUtils.GetRuntimeObject(String, Type, String) + 0x5b8
at System.Diagnostics.TraceConfiguration.<InitializingTraceSource>g__CreateSwitch|3_0(String, String, TraceConfiguration.<>c__DisplayClass3_0&) + 0x44
at System.Diagnostics.TraceConfiguration.InitializingTraceSource(Object, InitializingTraceSourceEventArgs) + 0x208
at System.Diagnostics.TraceSource.Config!<BaseAddress>+0xf7b98c
at System.Diagnostics.TraceSource.OnInitializing(InitializingTraceSourceEventArgs) + 0x3c
at System.Diagnostics.TraceSource.Initialize() + 0x78
at System.Diagnostics.TraceSourceConfigTests.ConfigurationTests.ConfigWithEvents_RuntimeListener() + 0x94
at System.Diagnostics.TraceSource.Config!<BaseAddress>+0x10bcbe4
at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0xd8
```
Tomas Weinfurt [Thu, 11 Aug 2022 10:20:41 +0000 (03:20 -0700)]
consume MsQuic 2.1 for windows ARM64 builds (#73713)
* consume MsQuic 2.1 for windows ARM64 builds
* force run on Win11 arm64
Radek Zikmund [Thu, 11 Aug 2022 10:13:35 +0000 (12:13 +0200)]
[HTTP3] Correctly handle server closing a control stream (#73680)
* Handle HTTP3 server closing its controls stream
* React to server closing inbound control stream
* Update src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
Pavel Savara [Thu, 11 Aug 2022 10:02:44 +0000 (12:02 +0200)]
[wasm] crypto deadlock fix (#73537)
* more state locking and sanity
* renamed the subtle-crypto.ts file, because that's not a worker
Co-authored-by: Ankit Jain <radical@gmail.com>