senorblanco@chromium.org [Thu, 29 Nov 2012 21:50:34 +0000 (21:50 +0000)]
rebaseline.py: Allow multiple testnames on the command line.
Review URL: https://codereview.appspot.com/6856118
git-svn-id: http://skia.googlecode.com/svn/trunk@6623
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 Nov 2012 21:21:54 +0000 (21:21 +0000)]
remove 4444 support (for now) form gm -- not used (afaik) and slows us down
Review URL: https://codereview.appspot.com/6782137
git-svn-id: http://skia.googlecode.com/svn/trunk@6622
2bbb7eff-a529-9590-31e7-
b0007b416f81
jamesr@chromium.org [Thu, 29 Nov 2012 21:17:16 +0000 (21:17 +0000)]
Keep track of identity SkMatrix44s
This keeps a bool on SkMatrix44 indicating if we know for sure that the matrix
is identity, similar to the TypeMask on SkMatrix. This is useful to early-out
of potentially expensive matrix math at the cost of some memory.
Review URL: https://codereview.appspot.com/6854113
git-svn-id: http://skia.googlecode.com/svn/trunk@6620
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 21:14:59 +0000 (21:14 +0000)]
Remove SkClipStack::Iter::combinedNext.
Review URL: https://codereview.appspot.com/6844114
git-svn-id: http://skia.googlecode.com/svn/trunk@6619
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 29 Nov 2012 21:05:37 +0000 (21:05 +0000)]
Create a factory to decode an SkBitmap from an SkData.
Add a test and a GM for the factory, and a PNG file for it to decode.
The PNG file is copyright-free, obtained from
http://openclipart.org/detail/29213/paper-plane-by-ddoo
In cmykjpeg, do not attempt to decode in the constructor, since it
currently crashes on Mac (if you provide the correct resource path).
Even when we fix this crash there is no need to do it in the
constructor, since we create all of the gms in order to
get their names (to determine whether to run them).
Review URL: https://codereview.appspot.com/6847122
git-svn-id: http://skia.googlecode.com/svn/trunk@6618
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 21:05:13 +0000 (21:05 +0000)]
Make SkClipStack::Element public.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6858096
git-svn-id: http://skia.googlecode.com/svn/trunk@6617
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 Nov 2012 21:01:00 +0000 (21:01 +0000)]
use fast-pt case when radius <= 1/2, instead of just hairlines
Review URL: https://codereview.appspot.com/6854116
git-svn-id: http://skia.googlecode.com/svn/trunk@6616
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 Nov 2012 21:00:39 +0000 (21:00 +0000)]
add SkPictureUtils::GatherPixelRefs()
Review URL: https://codereview.appspot.com/6845106
git-svn-id: http://skia.googlecode.com/svn/trunk@6615
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 19:16:32 +0000 (19:16 +0000)]
Change SkClipStack::Element::State to SkClipStack::Type, rename Comine* members to combine*
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6844113
git-svn-id: http://skia.googlecode.com/svn/trunk@6607
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 19:00:22 +0000 (19:00 +0000)]
Turn on the separable blur (release the hounds!). This will require rebaselines of the following Skia tests: tilemodes, texteffects, shadows, drawlooper, drawbitmaprect, circles, blurrect_grad, blurrect, blurs, drawbitmapmatrix (max. pixel change in 8888 is 5).
NOTE: This will require adding SK_DISABLE_SEPARABLE_MASK_BLUR to skia.gyp on the next roll into Chrome, until the Chrome rebaselines are done.
Review URL: https://codereview.appspot.com/6845111
git-svn-id: http://skia.googlecode.com/svn/trunk@6606
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 18:58:19 +0000 (18:58 +0000)]
Rename SkClipStack::Rec to SkClipStack::Element
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6854115
git-svn-id: http://skia.googlecode.com/svn/trunk@6605
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 17:27:37 +0000 (17:27 +0000)]
Fix the gr/gl destruction order in Test.cpp
R=djsollen@google.com
Review URL: https://codereview.appspot.com/6851126
git-svn-id: http://skia.googlecode.com/svn/trunk@6602
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 17:09:27 +0000 (17:09 +0000)]
Modify the blur bench to add tests for high-quality blurs, and large non-integer blurs. Change the Coarse flag (which just turns on separable blurs) to an #ifdef, since separable is no longer just Coarse. (This #ifdef will hopefully be shortlived, once Chrome has switched).
The separable blur algorithm gives +45% on SampleBlur, +84% on SampleBigBlur, +31% on TheVerge, +35 to +85% on blurbench in HQ (depending on size), +8 to +35% in low quality. (All of these on 32bit MacPro).
Review URL: https://codereview.appspot.com/6851117
git-svn-id: http://skia.googlecode.com/svn/trunk@6601
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 29 Nov 2012 16:29:58 +0000 (16:29 +0000)]
Remove legacy flag for android from tests
Review URL: https://codereview.appspot.com/6782133
git-svn-id: http://skia.googlecode.com/svn/trunk@6600
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 29 Nov 2012 15:28:45 +0000 (15:28 +0000)]
Fix test app to ensure that we destroy our GPU resources.
The problem arises on devices like the Nexus 10 where we allow the
destruction of resources using the destructor of a static variable.
However, we have no guarentee that the GPU driver has not already
cleaned up it's resources prior to our static destructor.
Review URL: https://codereview.appspot.com/6851124
git-svn-id: http://skia.googlecode.com/svn/trunk@6599
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 29 Nov 2012 15:09:58 +0000 (15:09 +0000)]
Enable profiling options to be selectively enabled for a given build
Review URL: https://codereview.appspot.com/6858089
git-svn-id: http://skia.googlecode.com/svn/trunk@6598
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 29 Nov 2012 14:31:50 +0000 (14:31 +0000)]
shape ops work in progress
Complete rewrite of binary logic makes the result
work and much easier to understand.
git-svn-id: http://skia.googlecode.com/svn/trunk@6597
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 29 Nov 2012 13:49:33 +0000 (13:49 +0000)]
Add newline at end of SkRRect.h
git-svn-id: http://skia.googlecode.com/svn/trunk@6596
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 29 Nov 2012 13:24:55 +0000 (13:24 +0000)]
SkRoundRect start
https://codereview.appspot.com/6815058/
git-svn-id: http://skia.googlecode.com/svn/trunk@6595
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 29 Nov 2012 02:01:19 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6594
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 28 Nov 2012 22:13:32 +0000 (22:13 +0000)]
Remove what turns out to be a bogus assert.
Any problems with size are already handled by checking the return value of CFNumberGetValue.
git-svn-id: http://skia.googlecode.com/svn/trunk@6592
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 28 Nov 2012 21:28:57 +0000 (21:28 +0000)]
update dox
git-svn-id: http://skia.googlecode.com/svn/trunk@6591
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 28 Nov 2012 21:09:18 +0000 (21:09 +0000)]
Write correct type of sfnt file in mac coretext open stream.
https://codereview.appspot.com/6844105/
git-svn-id: http://skia.googlecode.com/svn/trunk@6590
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Wed, 28 Nov 2012 20:23:49 +0000 (20:23 +0000)]
Update bench_expectations.txt with new codes in issue 6842112.
Rev range is [6580, 6585].
Review URL: https://codereview.appspot.com/6858091
git-svn-id: http://skia.googlecode.com/svn/trunk@6589
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 28 Nov 2012 20:08:32 +0000 (20:08 +0000)]
Update gm self-test to pass again after r6585
Now depends on only "dashing2" test, not all tests whose name starts with "dashing",
so it should be more resilient in the face of further changes.
TBR=borenet,robertphillips
Review URL: https://codereview.appspot.com/6844104
git-svn-id: http://skia.googlecode.com/svn/trunk@6588
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 28 Nov 2012 17:18:11 +0000 (17:18 +0000)]
Added dashing fast path
https://codereview.appspot.com/6844067/
git-svn-id: http://skia.googlecode.com/svn/trunk@6585
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 28 Nov 2012 14:42:41 +0000 (14:42 +0000)]
Set empty/wide-open genID on clip stack in more places and fix a bug in GrReduceClipStack.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6847116
git-svn-id: http://skia.googlecode.com/svn/trunk@6579
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 28 Nov 2012 14:11:41 +0000 (14:11 +0000)]
Update gyp to allow alternative out directories
If the enviroment variable SKIA_OUT is set the output of both
gyp and make will be redirected to that directory.
Review URL: https://codereview.appspot.com/6782095
git-svn-id: http://skia.googlecode.com/svn/trunk@6578
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 28 Nov 2012 02:02:11 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6577
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 27 Nov 2012 22:57:41 +0000 (22:57 +0000)]
Implement radius interpolation for separable blur. Unroll both separable implementations, which yields up to 2X perf improvement.
Review URL: https://codereview.appspot.com/6850088
git-svn-id: http://skia.googlecode.com/svn/trunk@6576
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Tue, 27 Nov 2012 21:52:32 +0000 (21:52 +0000)]
update bench_expectations with wider range before further investigations and discussions; change precision of bench values to 0.001.
git-svn-id: http://skia.googlecode.com/svn/trunk@6575
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 21:11:05 +0000 (21:11 +0000)]
capture repro case for gradient bug (inside if-false for now)
git-svn-id: http://skia.googlecode.com/svn/trunk@6574
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 18:37:52 +0000 (18:37 +0000)]
revert prev change to reset
git-svn-id: http://skia.googlecode.com/svn/trunk@6571
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Tue, 27 Nov 2012 17:30:26 +0000 (17:30 +0000)]
add skp bench expectations and watch for alerts.
git-svn-id: http://skia.googlecode.com/svn/trunk@6570
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 17:20:39 +0000 (17:20 +0000)]
guard for self-assignment in reset()
git-svn-id: http://skia.googlecode.com/svn/trunk@6568
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 27 Nov 2012 16:50:14 +0000 (16:50 +0000)]
Temporarily disable clip stack reduce test while working on fix.
git-svn-id: http://skia.googlecode.com/svn/trunk@6567
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Tue, 27 Nov 2012 16:09:42 +0000 (16:09 +0000)]
Close pending save() calls in QT debugger to avoid saveLayer() corruption.
http://codereview.appspot.com/6856076/
git-svn-id: http://skia.googlecode.com/svn/trunk@6565
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 27 Nov 2012 16:04:42 +0000 (16:04 +0000)]
Address debugger profiling issue in tile mode
https://codereview.appspot.com/6843113/
git-svn-id: http://skia.googlecode.com/svn/trunk@6564
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 27 Nov 2012 15:43:57 +0000 (15:43 +0000)]
Make the clip stack reduction test generate inverse filled paths.
Also adds some comments to GrReduceClipStack.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6847109
git-svn-id: http://skia.googlecode.com/svn/trunk@6561
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 15:18:04 +0000 (15:18 +0000)]
don't leak *every* src mask in the ninepatch case. doh.
git-svn-id: http://skia.googlecode.com/svn/trunk@6560
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 15:15:58 +0000 (15:15 +0000)]
add onOnceBeforeDraw() virtual, so gm's can easily perform lazy initialization
git-svn-id: http://skia.googlecode.com/svn/trunk@6559
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 13:13:22 +0000 (13:13 +0000)]
don't use bit-wise test for equality when using floats.
git-svn-id: http://skia.googlecode.com/svn/trunk@6557
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 27 Nov 2012 02:01:19 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6556
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 26 Nov 2012 21:42:32 +0000 (21:42 +0000)]
Actually fix GPU-less build.
git-svn-id: http://skia.googlecode.com/svn/trunk@6555
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 26 Nov 2012 21:38:37 +0000 (21:38 +0000)]
Fix GPU-less build.
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@6554
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 26 Nov 2012 21:19:43 +0000 (21:19 +0000)]
Add a function that computes a reduced representation of the clip stack.
Also adds a unit test. The function is not yet used other than in the test.
Review URL: https://codereview.appspot.com/6855098
git-svn-id: http://skia.googlecode.com/svn/trunk@6553
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 20:26:54 +0000 (20:26 +0000)]
change SkDrawFilter::filter to return a bool, where false means don't-draw
Review URL: https://codereview.appspot.com/6851111
git-svn-id: http://skia.googlecode.com/svn/trunk@6551
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 20:18:00 +0000 (20:18 +0000)]
must always include another skia header (unless you're SkTypes.h). In this case,
we need SkScalar.h earlier so we can be sure to have int32_t defined.
inspired by https://codereview.appspot.com/6782122/
git-svn-id: http://skia.googlecode.com/svn/trunk@6548
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 18:16:27 +0000 (18:16 +0000)]
check for bad enum use when adding contours
Review URL: https://codereview.appspot.com/6849103
git-svn-id: http://skia.googlecode.com/svn/trunk@6547
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 16:47:10 +0000 (16:47 +0000)]
remove legacy build-guards, now that webkit has rebaselined these.
SK_DISABLE_FAST_AA_STROKE_RECT
SK_IGNORE_FAST_BLURRECT
SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX
SK_IGNORE_CF_OPTIMIZATION
SK_IGNORE_NEW_STROKERECT
SK_DISABLE_GPU_BLUR
SK_IGNORE_ROTATED_FREETYPE_FIX
The changes should all be:
remove code for #ifdef
remove guard for #ifndef
Review URL: https://codereview.appspot.com/6858073
git-svn-id: http://skia.googlecode.com/svn/trunk@6546
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 14:39:50 +0000 (14:39 +0000)]
choose correct blitrow proc based on global alpha
fixes https://bugs.webkit.org/show_bug.cgi?id=103062
add gm to exercise this new fix
git-svn-id: http://skia.googlecode.com/svn/trunk@6544
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 26 Nov 2012 13:09:17 +0000 (13:09 +0000)]
Visualize bitmaps in debugger
https://codereview.appspot.com/6847084/
git-svn-id: http://skia.googlecode.com/svn/trunk@6541
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 22 Nov 2012 02:02:41 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6540
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Wed, 21 Nov 2012 22:38:36 +0000 (22:38 +0000)]
Remove GrRandom API in favor of SkRandom.
TEST=tests
R=bsalomon@google.com
Review URL: https://codereview.appspot.com/6855062
git-svn-id: http://skia.googlecode.com/svn/trunk@6539
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 21 Nov 2012 21:36:34 +0000 (21:36 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6537
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 21 Nov 2012 19:04:17 +0000 (19:04 +0000)]
Add self-test that reveals SkChecksum weakness
Review URL: https://codereview.appspot.com/6845064
git-svn-id: http://skia.googlecode.com/svn/trunk@6535
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 21 Nov 2012 18:37:58 +0000 (18:37 +0000)]
Fixed some compilation problems with debugger with robertphillips
git-svn-id: http://skia.googlecode.com/svn/trunk@6534
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 21 Nov 2012 18:34:15 +0000 (18:34 +0000)]
add default: to fix warning
git-svn-id: http://skia.googlecode.com/svn/trunk@6533
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 21 Nov 2012 17:11:02 +0000 (17:11 +0000)]
Add drawing of paths to debugger
https://codereview.appspot.com/6850082/
git-svn-id: http://skia.googlecode.com/svn/trunk@6532
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 21 Nov 2012 16:44:45 +0000 (16:44 +0000)]
Simple change to remove unnecessary #define statement.
BUG=http://code.google.com/p/chromium/issues/detail?id=137924
TEST=TestDeferredCanvasBitmapSizeThreshold unit test
Review URL: https://codereview.appspot.com/6845071
git-svn-id: http://skia.googlecode.com/svn/trunk@6531
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 21 Nov 2012 16:36:34 +0000 (16:36 +0000)]
fix typo: must use modified join in case the miterlimit forces us to use bevel
git-svn-id: http://skia.googlecode.com/svn/trunk@6530
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 21 Nov 2012 15:48:20 +0000 (15:48 +0000)]
use direction from isRect in strokeRect, and only stroke if it is closed
Review URL: https://codereview.appspot.com/6846086
git-svn-id: http://skia.googlecode.com/svn/trunk@6528
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 21 Nov 2012 15:47:04 +0000 (15:47 +0000)]
Deferred canvas can now be flushed if an image is beyond a certain size to avoid a costly image copy.
BUG=http://code.google.com/p/chromium/issues/detail?id=137924
TEST=TestDeferredCanvasBitmapSizeThreshold unit test
Review URL: https://codereview.appspot.com/6852071
git-svn-id: http://skia.googlecode.com/svn/trunk@6527
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 21 Nov 2012 15:18:06 +0000 (15:18 +0000)]
Add isRect variant that returns path closure and direction.
Add path test to verify that when isRect() returns false,
output parameters are unchanged.
Review URL: https://codereview.appspot.com/6855074
git-svn-id: http://skia.googlecode.com/svn/trunk@6524
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 21 Nov 2012 14:14:10 +0000 (14:14 +0000)]
limit the rects width/height as well as its coords, when avoiding too-large
rects for blur special-case.
Review URL: https://codereview.appspot.com/6850084
git-svn-id: http://skia.googlecode.com/svn/trunk@6523
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 21 Nov 2012 13:56:20 +0000 (13:56 +0000)]
detect wrapped rect in path
Allow a rect to start in the middle of a span, and
wrap all the way around.
Initialize variable to suppress warning.
Add tests to detect rects constructed from a stroked
path.
Review URL: https://codereview.appspot.com/6847082
git-svn-id: http://skia.googlecode.com/svn/trunk@6522
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 21 Nov 2012 02:02:25 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6521
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 20 Nov 2012 23:01:35 +0000 (23:01 +0000)]
add SK_IGNORE_NEW_STROKERECT guard
temp workaround for bug in isRect when I'm stroking and the rect isn't closed.
git-svn-id: http://skia.googlecode.com/svn/trunk@6520
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 20 Nov 2012 21:33:05 +0000 (21:33 +0000)]
fix regression from 6510 -- respect kStrokeAndFill setting for stroked rects
git-svn-id: http://skia.googlecode.com/svn/trunk@6516
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 20 Nov 2012 21:32:30 +0000 (21:32 +0000)]
test for StrokeAndFill as well in this GM
git-svn-id: http://skia.googlecode.com/svn/trunk@6515
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 20 Nov 2012 19:45:16 +0000 (19:45 +0000)]
detect gigantoid matrices, and do nothing to avoid wacky overflows from float -> int
https://code.google.com/p/chromium/issues/detail?id=156231
Review URL: https://codereview.appspot.com/6842075
git-svn-id: http://skia.googlecode.com/svn/trunk@6513
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 20 Nov 2012 19:40:23 +0000 (19:40 +0000)]
Correct A8 gamma on Mac.
This fixes https://code.google.com/p/chromium/issues/detail?id=161728 .
https://codereview.appspot.com/6851086/
git-svn-id: http://skia.googlecode.com/svn/trunk@6511
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 20 Nov 2012 19:00:28 +0000 (19:00 +0000)]
add specialty strokeRect() to SkStroke, which can return much cleaner results
Review URL: https://codereview.appspot.com/6843093
git-svn-id: http://skia.googlecode.com/svn/trunk@6510
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 20 Nov 2012 18:52:23 +0000 (18:52 +0000)]
Additional OpenType tables.
https://codereview.appspot.com/6850075/
git-svn-id: http://skia.googlecode.com/svn/trunk@6509
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 20 Nov 2012 17:09:40 +0000 (17:09 +0000)]
Separable mask blurs: Add compile-time flag. Fix reversed offsets in asymmetrical blurs (this bug cancels itself out, but I thought it might be confusing for future readers). Use correct stride in asymmetrical blurs (this is a real bug).
Review URL: https://codereview.appspot.com/6782089
git-svn-id: http://skia.googlecode.com/svn/trunk@6508
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Tue, 20 Nov 2012 16:36:20 +0000 (16:36 +0000)]
Fix clang warning in GMSampleView.h
../../samplecode/GMSampleView.h:23:7: warning: field 'fGM' will be initialized after field 'fShowSize' [-Wreorder]
R=bsalomon@google.com
Review URL: https://codereview.appspot.com/6856063
git-svn-id: http://skia.googlecode.com/svn/trunk@6507
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 20 Nov 2012 15:12:21 +0000 (15:12 +0000)]
add restore() to SkAutoCanvasRestore
git-svn-id: http://skia.googlecode.com/svn/trunk@6505
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 20 Nov 2012 14:21:54 +0000 (14:21 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6503
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 20 Nov 2012 02:01:23 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6500
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 20 Nov 2012 01:40:45 +0000 (01:40 +0000)]
Reverting r6489 to fix compiler error in Chrome
143> LINK : program database E:\b\build\slave\win_layout\build\src\build\Debug\ui.dll.pdb missing; performing full link
143> Creating library ..\build\Debug\lib\ui.lib and object ..\build\Debug\lib\ui.exp
143>throb_animation.obj : error LNK2001: unresolved external symbol "private: static void (__cdecl*const * const SkMatrix::gMapXYProcs)(class SkMatrix const &,float,float,struct SkPoint *)" (?gMapXYProcs@SkMatrix@@0QBQ6AXABV1@MMPAUSkPoint@@@ZB)
etc
git-svn-id: http://skia.googlecode.com/svn/trunk@6499
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 19 Nov 2012 21:09:14 +0000 (21:09 +0000)]
skip very large rects (for now) until we can pre-clip them to avoid floating
point precision errors.
git-svn-id: http://skia.googlecode.com/svn/trunk@6497
2bbb7eff-a529-9590-31e7-
b0007b416f81
vollick@chromium.org [Mon, 19 Nov 2012 21:02:06 +0000 (21:02 +0000)]
Add SkMatrix44::setColMajord, etc.
We have accessors for efficiently getting the matirx data, and it would be nice
if we had similar methods for setting the matrix entries.
Review URL: https://codereview.appspot.com/6851063
git-svn-id: http://skia.googlecode.com/svn/trunk@6494
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 19 Nov 2012 20:44:29 +0000 (20:44 +0000)]
Breakdown profile time by command type in the overview pane
https://codereview.appspot.com/6851073/
git-svn-id: http://skia.googlecode.com/svn/trunk@6492
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 19 Nov 2012 20:43:10 +0000 (20:43 +0000)]
Add support for new glShaderSource() signature from Khronos. Disabled by default.
Review URL: https://codereview.appspot.com/6853068
git-svn-id: http://skia.googlecode.com/svn/trunk@6491
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Mon, 19 Nov 2012 19:43:18 +0000 (19:43 +0000)]
Add missing SK_API define.
For a detailed explanation of this, please refer to Nico Weber description
here: https://chromiumcodereview.appspot.com/
10386108
R=bsalomon@google.com
Review URL: https://codereview.appspot.com/6849075
git-svn-id: http://skia.googlecode.com/svn/trunk@6489
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 19 Nov 2012 19:34:23 +0000 (19:34 +0000)]
Add support for SkImageRef_ashmem.
This requires copying the ashmem utility wrapper functions from a
private android library into our source tree in order to be NDK
compliant.
Review URL: https://codereview.appspot.com/6846076
git-svn-id: http://skia.googlecode.com/svn/trunk@6488
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 19 Nov 2012 18:25:09 +0000 (18:25 +0000)]
Added Reload icon
https://codereview.appspot.com/6849079/
git-svn-id: http://skia.googlecode.com/svn/trunk@6486
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 19 Nov 2012 17:39:18 +0000 (17:39 +0000)]
Add original resources back and update code to match
https://codereview.appspot.com/6842061/
git-svn-id: http://skia.googlecode.com/svn/trunk@6484
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 19 Nov 2012 16:45:14 +0000 (16:45 +0000)]
use SkPath::isNestedRects() to apply blurred nine-patch
Review URL: https://codereview.appspot.com/6855063
git-svn-id: http://skia.googlecode.com/svn/trunk@6483
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 19 Nov 2012 16:30:08 +0000 (16:30 +0000)]
Fix a memory leak in skdiff that happens when the
directories do not contain the same files.
Only create the bitmaps when we need to use them.
Review URL: https://codereview.appspot.com/6850066
git-svn-id: http://skia.googlecode.com/svn/trunk@6481
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 19 Nov 2012 16:26:40 +0000 (16:26 +0000)]
3 minor fixes for debugger
https://codereview.appspot.com/6842062/
git-svn-id: http://skia.googlecode.com/svn/trunk@6480
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 19 Nov 2012 16:14:02 +0000 (16:14 +0000)]
modify gm to have a non-uniform donut for testing
git-svn-id: http://skia.googlecode.com/svn/trunk@6477
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 19 Nov 2012 14:36:31 +0000 (14:36 +0000)]
Protect against unref/ref of stencil buffer.
Over the shoulder review from robertphillips@google.com
git-svn-id: http://skia.googlecode.com/svn/trunk@6476
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 19 Nov 2012 13:06:06 +0000 (13:06 +0000)]
add two nested rect detector to path
Tease apart existing one rect path detector so
that a new variant can detect two nested rects as well.
Add tests to verify that both one and two rect
detectors both work and return the correct results.
Suppress other warnings in PathTest.
Review URL: https://codereview.appspot.com/6850059
git-svn-id: http://skia.googlecode.com/svn/trunk@6475
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Sat, 17 Nov 2012 15:08:29 +0000 (15:08 +0000)]
Revert r6469, "Turn on separable blur."
git-svn-id: http://skia.googlecode.com/svn/trunk@6474
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 17 Nov 2012 02:01:23 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6473
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Fri, 16 Nov 2012 22:26:33 +0000 (22:26 +0000)]
Whitespace change to trigger rebuild after network hiccup
git-svn-id: http://skia.googlecode.com/svn/trunk@6472
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 16 Nov 2012 20:34:37 +0000 (20:34 +0000)]
In SkBitmapHeap, defer adding owners for new bitmaps.
When using an SkFlatDictionary to flatten shaders, the
dictionary can try to insert a duplicate bitmap shader
that uses a bitmap which has been removed from the
bitmap heap.
This change was originally suggested by junov in
https://codereview.appspot.com/6713048/.
Add a test to verify that deferring the owners works.
Without the change to bitmap heap the test would fail
(and crash in debug mode).
Also remove an unused function from SkFlatDictionary.
BUG=http://code.google.com/p/chromium/issues/detail?id=143923
Review URL: https://codereview.appspot.com/6842051
git-svn-id: http://skia.googlecode.com/svn/trunk@6471
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 16 Nov 2012 20:16:50 +0000 (20:16 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6470
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 16 Nov 2012 19:26:22 +0000 (19:26 +0000)]
Turn on separable blur.
git-svn-id: http://skia.googlecode.com/svn/trunk@6469
2bbb7eff-a529-9590-31e7-
b0007b416f81