platform/upstream/dotnet/runtime.git
2 years ago"[QUIC] Adopted msquic generated interop (#68288)" attempt no 2 (#69009)
Marie Píchová [Wed, 11 May 2022 14:29:45 +0000 (16:29 +0200)]
"[QUIC] Adopted msquic generated interop (#68288)" attempt no 2 (#69009)

* Revert "Revert "[QUIC] Adopted msquic generated interop (#68288)" (#68940)"

This reverts commit 4820674a4471872d742c380f38e766b80dc79385.

* Exclude S.N.Quic from Mono AOT

* Fix #68954

2 years agoSupport strictly blittable type marshalling (#69100)
Aaron Robinson [Wed, 11 May 2022 14:25:16 +0000 (07:25 -0700)]
Support strictly blittable type marshalling (#69100)

* Support strictly blittable type marshalling

* Update design document.

* Add test to validate check for blittability for assembly reference

2 years agoUpdate dependencies from https://github.com/dotnet/hotreload-utils build 20220509...
dotnet-maestro[bot] [Wed, 11 May 2022 13:58:38 +0000 (09:58 -0400)]
Update dependencies from https://github.com/dotnet/hotreload-utils build 20220509.2 (#69131)

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.1.0-alpha.0.22252.2 -> To Version 1.1.0-alpha.0.22259.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years agoDon't return SslStreamBuffer when disposing during handshake (#68956)
Radek Zikmund [Wed, 11 May 2022 13:28:45 +0000 (06:28 -0700)]
Don't return SslStreamBuffer when disposing during handshake (#68956)

* Don't return SslStreamBuffer when disposing during handshake

* Update src/libraries/System.Net.Security/src/System/Net/Security/SslStream.IO.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
2 years agoError if a reference assembly is platform specific (#69116)
Viktor Hofer [Wed, 11 May 2022 11:37:12 +0000 (13:37 +0200)]
Error if a reference assembly is platform specific (#69116)

Fixes https://github.com/dotnet/runtime/issues/29154. I didn't introduce a new target to keep the validation cost as low as possible.

2 years agoCopy propagate on `LCL_FLD`s (#68592)
SingleAccretion [Wed, 11 May 2022 09:40:50 +0000 (12:40 +0300)]
Copy propagate on `LCL_FLD`s (#68592)

2 years agoCall simpler overloads of Substring and Slice (#68937)
Levi Broderick [Wed, 11 May 2022 06:23:22 +0000 (23:23 -0700)]
Call simpler overloads of Substring and Slice (#68937)

2 years agoRemoving comments so won't overwrite doc changes (#69089)
Jim Daly [Wed, 11 May 2022 03:53:15 +0000 (20:53 -0700)]
Removing comments so won't overwrite doc changes (#69089)

* Removing comments so won't overwrite doc changes

* removing comments from two more places as directed

2 years agoJIT: fix issue with assert seen in OSR+PGO tests (#69067)
Andy Ayers [Wed, 11 May 2022 01:43:54 +0000 (18:43 -0700)]
JIT: fix issue with assert seen in OSR+PGO tests (#69067)

Update `IsIconHandle` to work for all tree types.

Closes #69032.

2 years agoUpdating BigInteger to implement IBinaryInteger and ISignedNumber (#68964)
Tanner Gooding [Wed, 11 May 2022 00:35:25 +0000 (17:35 -0700)]
Updating BigInteger to implement IBinaryInteger and ISignedNumber (#68964)

* Updating BigInteger to implement the generic math interfaces

* Adding generic math tests for BigInteger

* Addressing PR feedback

2 years agoCreateSymbolicLink PInvoke retval must be marshalled as U1 (#69150)
David Cantú [Tue, 10 May 2022 23:54:57 +0000 (16:54 -0700)]
CreateSymbolicLink PInvoke retval must be marshalled as U1 (#69150)

* CreateSymbolicLink PInvoke retval must be marshalled as U1

* Fix redundant invocations of Environment.OSVersion.Version

2 years agoUpdate minimum required version of VS to 17.3 (#69162)
Viktor Hofer [Tue, 10 May 2022 23:50:22 +0000 (01:50 +0200)]
Update minimum required version of VS to 17.3 (#69162)

Fixes https://github.com/dotnet/runtime/issues/68764

The in the above issue mentioned warnings are resolved by using VS 17.3 (currently Preview1).

2 years agoFix typo in AssemblyName handling (#69157)
Jan Kotas [Tue, 10 May 2022 22:34:53 +0000 (15:34 -0700)]
Fix typo in AssemblyName handling (#69157)

Fix typo in AssemblyName handling and add test that catches the bug introduced by the typo

2 years agoTweak Rune.DecodeFromUtf8 (#68799)
Stephen Toub [Tue, 10 May 2022 21:56:24 +0000 (17:56 -0400)]
Tweak Rune.DecodeFromUtf8 (#68799)

2 years agoskip ignoring Content-Length test on NodeJs (#69109)
Badre BSAILA [Tue, 10 May 2022 21:41:48 +0000 (23:41 +0200)]
skip ignoring Content-Length test on NodeJs (#69109)

* skip test on ignoring Content-Length on browser

* exclude test only from nodejs

2 years agoAdd doc about using local build of apphost (#69097)
Elinor Fung [Tue, 10 May 2022 21:24:38 +0000 (14:24 -0700)]
Add doc about using local build of apphost (#69097)

2 years agoUpdate generators.targets (#68860)
Viktor Hofer [Tue, 10 May 2022 20:38:39 +0000 (22:38 +0200)]
Update generators.targets (#68860)

* Update generators.targets

Changes:
- Improve perf of LibraryImportGenerator condition and simplify it
- Use the same msbuild code styling as in other projects in src/libraries
- Update comments that were outdated
- Remove the item conditions for the regex source generator which doesn't
  work well with the CPS (common project system) inside VS.
- Remove unnecessary property

* Update eng/generators.targets

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update generators.targets

* Update generators.targets

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
2 years agoadd option to set TLS cache size (#69065)
Tomas Weinfurt [Tue, 10 May 2022 20:36:57 +0000 (13:36 -0700)]
add option to set TLS cache size (#69065)

2 years agoPerf fix maui dotnet running (#69148)
Parker Bibus [Tue, 10 May 2022 20:19:57 +0000 (15:19 -0500)]
Perf fix maui dotnet running (#69148)

* Echo the string into a local global.json.

* Complete some final cleanup stuff.

2 years agoStop keeping parent stacks for fgWalkTree and friends (#69120)
Jakob Botsch Nielsen [Tue, 10 May 2022 19:46:58 +0000 (21:46 +0200)]
Stop keeping parent stacks for fgWalkTree and friends (#69120)

We do not use this stack anywhere that uses the generic tree walker so
avoid computing it.

2 years agoIncrease helix job timeout for win-arm64 to 300 minutes (#69129)
Jakob Botsch Nielsen [Tue, 10 May 2022 17:59:50 +0000 (19:59 +0200)]
Increase helix job timeout for win-arm64 to 300 minutes (#69129)

2 years ago[wasm] Move `Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests` to (#69087)
Ankit Jain [Tue, 10 May 2022 17:37:40 +0000 (13:37 -0400)]
[wasm] Move `Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests` to (#69087)

the high-resource-aot build job.

2 years agoskip unnecesary ALPN processing on Windows (#69103)
Tomas Weinfurt [Tue, 10 May 2022 16:42:30 +0000 (09:42 -0700)]
skip unnecesary ALPN processing on Windows (#69103)

2 years agoAvoid byte[] allocation for IPAddressUtil.IsMulticast (#68591)
Bond-009 [Tue, 10 May 2022 16:41:41 +0000 (18:41 +0200)]
Avoid byte[] allocation for IPAddressUtil.IsMulticast (#68591)

Ping.RawSocket his its own inline implementaion of this, maybe this
should be consolidated somewhere?
src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/Ping.RawSocket.cs
L101

2 years agoHandle case to update loop tables when preheader is removed (#68803)
Kunal Pathak [Tue, 10 May 2022 16:36:53 +0000 (09:36 -0700)]
Handle case to update loop tables when preheader is removed  (#68803)

* fix preheader removal

* just check the fgBBNumMax

2 years agoFix heap corruption issue 68443. (#69106)
Peter Sollich [Tue, 10 May 2022 16:13:43 +0000 (18:13 +0200)]
Fix heap corruption issue 68443. (#69106)

This has first seen with regions, but should be an issue with segments as well.

What happened was that in revisit_written_pages, we determined the highest allocated address in a region, then obtained the dirty pages up to that high address.

In parallel, another thread allocated a new object after the high address and wrote to it.

The background GC thread saw the dirty page, but didn't explore the object because it was after its stale value for the high address. That caused some objects pointed at from the beginning of the new object to be seen as dead by background GC.

Because the allocating thread also set the card table entries, the next ephemeral GC crashed because the references from the new object were now invalid.

The fix is to refetch the high address after we have obtained the dirty pages. That way, we'll explore new objects allocated while we were getting the dirty pages. New objects allocated and written to after we obtained the dirty pages will cause more dirty pages and will thus be explored later.

My repro case that caused about a crash every two hours or so has run overnight with this fix without issues.

2 years agoAutomatically choose correct cross-compile JIT name for SPMI replay/asmdiffs (#69091)
Bruce Forstall [Tue, 10 May 2022 15:36:59 +0000 (08:36 -0700)]
Automatically choose correct cross-compile JIT name for SPMI replay/asmdiffs (#69091)

If, say, doing asm diffs with `superpmi.py asmdiffs -target_arch arm64`,
you now don't also need to specify a correct `-jit_name`; the correct name
is chosen by default.

2 years agoRevert "Add the capability to walk up the inheritance chain for GetMemberWithSameMeta...
Larry Ewing [Tue, 10 May 2022 15:26:07 +0000 (10:26 -0500)]
Revert "Add the capability to walk up the inheritance chain for GetMemberWithSameMetadataDefinitionAs (#69057)" (#69137)

This reverts commit d0d7c30bbf19bae9d70343e6bb7d641dfb4e6848.

2 years ago49936 text json failures (#68758)
Meri Khamoyan [Tue, 10 May 2022 11:18:06 +0000 (15:18 +0400)]
49936 text json failures (#68758)

* #49936 fixed text json failures and enabled System.Text.Json\tests

2 years agoUpdate testPackages.proj (#69074)
Viktor Hofer [Tue, 10 May 2022 10:10:30 +0000 (12:10 +0200)]
Update testPackages.proj (#69074)

2 years agoUpdate System.Net solution files (#69112)
Viktor Hofer [Tue, 10 May 2022 10:10:15 +0000 (12:10 +0200)]
Update System.Net solution files (#69112)

* Update System.Net solution files

https://github.com/dotnet/runtime/commit/8823eefe91f6b774961c32800dea977b687d7328 added a dependency onto the source project of System.Net.Security. Because of that, the closure of the System.Net.Quic and System.Net.Http solution files changed. Currently this is manual as we don't have a CI leg that makes sure that solution files are up-to-date.

* Update System.Net.Http.sln

2 years agofix(wasm): Discriminate satellite assemblies loading based on culture (#68195)
Jérôme Laban [Tue, 10 May 2022 09:49:22 +0000 (05:49 -0400)]
fix(wasm): Discriminate satellite assemblies loading based on culture (#68195)

* fix(wasm): Discriminate satellite assemblies loading based on culture
* add `--fetch-random-delay` test parameter
* enable emscripten ASSERTIONS=1 on SatelliteAssembliesTests.ResourcesFromMainAssembly

Co-authored-by: pavelsavara <pavel.savara@gmail.com>
2 years agoUpdate ApiCompat.proj (#69075)
Viktor Hofer [Tue, 10 May 2022 08:56:34 +0000 (10:56 +0200)]
Update ApiCompat.proj (#69075)

Fixes https://github.com/dotnet/runtime/issues/68730 but keeps the separate `ValidateBaseline` property as it might be useful to disable the baseline validation again in the future.

2 years agoImplement JsonContext and JsonTypeInfo Overloads for Binary Data (#69012)
Tarun047 [Tue, 10 May 2022 08:08:21 +0000 (13:38 +0530)]
Implement JsonContext and JsonTypeInfo Overloads for Binary Data (#69012)

2 years agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 176180...
dotnet bot [Tue, 10 May 2022 07:32:01 +0000 (00:32 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1761806 (#69088)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1761331

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1761597

2 years agoRemove Hardlink workaround under FreeBSD (#69102)
Thefrank [Tue, 10 May 2022 07:31:38 +0000 (00:31 -0700)]
Remove Hardlink workaround under FreeBSD (#69102)

No longer needed and https://github.com/dotnet/runtime/issues/3335 and https://github.com/dotnet/core-setup/issues/4742 are now closed

2 years agoReenable `System.Runtime.Serialization.Xml.Tests` (#68921)
Ankit Jain [Tue, 10 May 2022 04:53:14 +0000 (00:53 -0400)]
Reenable `System.Runtime.Serialization.Xml.Tests` (#68921)

* Reenable `System.Runtime.Serialization.Xml.Tests`

This was disabled due to https://github.com/dotnet/runtime/issues/59926,
which was then tracked by https://github.com/dotnet/runtime/issues/61061
.

The stack overflow is due to one specific test though, and the rest of
the tests can be enabled if we skip this one - `DCS_DeeplyLinkedData`.

* Disable the test with `SkipOnPlatform` instead, for wasm, as it is

.. unlikely to be fixed (- vargaz).

2 years ago[wasm][debugger][tests] Fix crash in `EvaluateOnCallFrameTests` on CI (#69073)
Ankit Jain [Tue, 10 May 2022 04:34:01 +0000 (00:34 -0400)]
[wasm][debugger][tests] Fix crash in `EvaluateOnCallFrameTests` on CI (#69073)

* Clean up debug messages

* [wasm][debugger][tests] Allow MonoProxy instances to get gc'ed

In `TestHarnessProxy`, we recently started adding proxy instances to a
static table, to enable getting the correct exit state from the client.
But the instances were not removed from the table, which prevented the
GC from collecting them.

This manifests as the test process crashing on systems with 8GB of
memory, when running `EvaluateOnCallFrameTests`. It would end up getting
to a resident size of 2.2-2.7G, and then crash after about 30 tests. With these changes, the
proxy gets collected, and the resident memory hovers around 500M.

Future work: this will change once we start using the upcoming app host
work, and thus moving the proxy to a separate process via `dotnet run
--debug`.

2 years agoAllow some lazy loops to upgrade with auto-atomicity (#68989)
Stephen Toub [Tue, 10 May 2022 03:10:46 +0000 (23:10 -0400)]
Allow some lazy loops to upgrade with auto-atomicity (#68989)

* Allow some lazy loops to upgrade with auto-atomicity

* Update RegexNode.cs

2 years ago[main] Update dependencies from dotnet/hotreload-utils (#67905)
dotnet-maestro[bot] [Tue, 10 May 2022 01:42:57 +0000 (20:42 -0500)]
[main] Update dependencies from dotnet/hotreload-utils (#67905)

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20220411.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22211.2

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20220418.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22218.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20220425.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22225.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20220426.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22226.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20220502.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.0.2-alpha.0.22178.2 -> To Version 1.1.0-alpha.0.22252.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
2 years agoRemove coverlet.collector reference from LibraryImportGenerator tests (#69078)
Elinor Fung [Tue, 10 May 2022 00:54:40 +0000 (17:54 -0700)]
Remove coverlet.collector reference from LibraryImportGenerator tests (#69078)

2 years ago[mono] Avoid an assertion when cattrs with array parameters are constructed during...
Zoltan Varga [Tue, 10 May 2022 00:40:31 +0000 (20:40 -0400)]
[mono] Avoid an assertion when cattrs with array parameters are constructed during AOT. (#69077)

Fixes https://github.com/dotnet/runtime/issues/57361.

2 years agoFix namespace in error message (#69083)
Jan Kotas [Tue, 10 May 2022 00:09:23 +0000 (17:09 -0700)]
Fix namespace in error message (#69083)

DisableRuntimeMarshallingAttribute is under System.Runtime.CompilerServices

2 years agoAdd the capability to walk up the inheritance chain for GetMemberWithSameMetadataDefi...
Lakshan Fernando [Mon, 9 May 2022 22:19:44 +0000 (15:19 -0700)]
Add the capability to walk up the inheritance chain for GetMemberWithSameMetadataDefinitionAs (#69057)

* Fix for issue 67533

* FB

2 years ago[main] Update dependencies from 7 repositories (#68126)
dotnet-maestro[bot] [Mon, 9 May 2022 19:39:40 +0000 (14:39 -0500)]
[main] Update dependencies from 7 repositories (#68126)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20220416.9

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.22215.3 -> To Version 1.0.0-prerelease.22216.9

* Update dependencies from https://github.com/dotnet/runtime build 20220417.5

runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
 From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.4.22217.5

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20220417.3

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.22215.3 -> To Version 1.0.0-prerelease.22217.3

* Update dependencies from https://github.com/dotnet/icu build 20220418.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.4.22218.1

* Update dependencies from https://github.com/dotnet/xharness build 20220419.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22219.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220418.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22218.1

* Update dependencies from https://github.com/dotnet/llvm-project build 20220418.2

runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22213.1 -> To Version 11.1.0-alpha.1.22218.2

* Update dependencies from https://github.com/dotnet/icu build 20220419.2

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.5.22219.2

* Update dependencies from https://github.com/dotnet/emsdk build 20220419.2

Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.0-preview.4.22215.1 -> To Version 7.0.0-preview.5.22219.2

* Update dependencies from https://github.com/dotnet/xharness build 20220420.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22220.1

* Update dependencies from https://github.com/dotnet/runtime build 20220424.3

runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
 From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.5.22224.3

* Update dependencies from https://github.com/dotnet/icu build 20220425.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.5.22225.1

* Update dependencies from https://github.com/dotnet/xharness build 20220425.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22225.1

* Update dependencies from https://github.com/dotnet/emsdk build 20220425.1

Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.0-preview.4.22215.1 -> To Version 7.0.0-preview.5.22225.1

* Update dependencies from https://github.com/dotnet/llvm-project build 20220425.2

runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22213.1 -> To Version 11.1.0-alpha.1.22225.2

* Update dependencies from https://github.com/dotnet/xharness build 20220426.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22226.1

* Update dependencies from https://github.com/dotnet/llvm-project build 20220426.1

runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22213.1 -> To Version 11.1.0-alpha.1.22226.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220429.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22229.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220430.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22230.1

* Update dependencies from https://github.com/dotnet/runtime build 20220501.6

runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
 From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.5.22251.6

* Update dependencies from https://github.com/dotnet/xharness build 20220502.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22252.1

* Update dependencies from https://github.com/dotnet/icu build 20220502.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 7.0.0-preview.4.22214.2 -> To Version 7.0.0-preview.5.22252.1

* Update dependencies from https://github.com/dotnet/xharness build 20220503.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22253.1

* Update dependencies from https://github.com/dotnet/emsdk build 20220502.1

Microsoft.NET.Workload.Emscripten.Manifest-7.0.100
 From Version 7.0.0-preview.4.22215.1 -> To Version 7.0.0-preview.5.22252.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20220502.2

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 7.0.0-preview1.22212.1 -> To Version 7.0.0-preview1.22252.2

* Update dependencies from https://github.com/dotnet/llvm-project build 20220502.1

runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter
 From Version 1.0.0-alpha.1.22204.1 -> To Version 1.0.0-alpha.1.22252.1

* Update dependencies from https://github.com/dotnet/xharness build 20220503.2

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22253.2

* Update dependencies from https://github.com/dotnet/xharness build 20220504.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22254.1

* Update dependencies from https://github.com/dotnet/xharness build 20220506.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22256.1

* Update dependencies from https://github.com/dotnet/xharness build 20220506.2

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.22214.2 -> To Version 1.0.0-prerelease.22256.2

* Update dependencies from https://github.com/dotnet/runtime build 20220508.4

runtime.native.System.IO.Ports , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , System.Text.Json , Microsoft.NET.Sdk.IL
 From Version 7.0.0-preview.4.22208.8 -> To Version 7.0.0-preview.5.22258.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Egor Bogatov <egorbo@gmail.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
2 years ago[mono][arm64] Save the full 128 bit simd argument registers in the trampoline code...
Zoltan Varga [Mon, 9 May 2022 19:26:51 +0000 (15:26 -0400)]
[mono][arm64] Save the full 128 bit simd argument registers in the trampoline code. (#68997)

2 years agoMark "push [mem]" candidates reg optional (#68641)
SingleAccretion [Mon, 9 May 2022 18:39:58 +0000 (21:39 +0300)]
Mark "push [mem]" candidates reg optional (#68641)

2 years agoformat correctly chuncked response with Content-Length header (#69016)
Badre BSAILA [Mon, 9 May 2022 18:38:44 +0000 (20:38 +0200)]
format correctly chuncked response with Content-Length header (#69016)

2 years agoInitialize "VNFuncApp.m_func" in "VNForBitCast" (#69051)
SingleAccretion [Mon, 9 May 2022 18:08:06 +0000 (21:08 +0300)]
Initialize "VNFuncApp.m_func" in "VNForBitCast" (#69051)

2 years agoFix formatting job on windows (#69054)
Jakob Botsch Nielsen [Mon, 9 May 2022 17:23:46 +0000 (19:23 +0200)]
Fix formatting job on windows (#69054)

2 years agoRemove an allocation during CNG RSA key generation
Kevin Jones [Mon, 9 May 2022 15:38:36 +0000 (11:38 -0400)]
Remove an allocation during CNG RSA key generation

Spanify CngProperty to remove a temporary `new byte[4]`.

Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>
2 years agoJIT: minor enhancement to jump threading (#69022)
Andy Ayers [Mon, 9 May 2022 15:10:19 +0000 (08:10 -0700)]
JIT: minor enhancement to jump threading (#69022)

Allow jump threading of branches with exceptions, provided the branch and the
dominating branch are in the same EH region.

2 years agoSpecify action permissions in cleanup task (#69014)
Adeel Mujahid [Mon, 9 May 2022 14:21:29 +0000 (17:21 +0300)]
Specify action permissions in cleanup task (#69014)

2 years agoAdd IL Emit support for MethodInfo.Invoke() and friends (#67917)
Steve Harter [Mon, 9 May 2022 14:11:28 +0000 (09:11 -0500)]
Add IL Emit support for MethodInfo.Invoke() and friends (#67917)

2 years agoFix packs.product subset build with gcc (#68998)
Adeel Mujahid [Mon, 9 May 2022 11:56:12 +0000 (14:56 +0300)]
Fix packs.product subset build with gcc (#68998)

2 years agoRemove GT_PUTARG_TYPE (#68748)
Jakob Botsch Nielsen [Mon, 9 May 2022 09:57:04 +0000 (11:57 +0200)]
Remove GT_PUTARG_TYPE (#68748)

This change removes GT_PUTARG_TYPE by storing the signature type of the argument inside CallArg right away when arguments are added, instead of only from morph and on.

2 years agoClean up specialized value num functions (#69013)
Jakob Botsch Nielsen [Mon, 9 May 2022 09:55:46 +0000 (11:55 +0200)]
Clean up specialized value num functions (#69013)

The reason the operator== implementation was not unrolled previously was
just because I used an early exit. Without the early exit it is unrolled
fine.

2 years agoMerge pull request #67771 from dotnet/darc-main-31d4c308-6782-4440-8589-61f58f239059
Andy Gocke [Mon, 9 May 2022 07:27:05 +0000 (00:27 -0700)]
Merge pull request #67771 from dotnet/darc-main-31d4c308-6782-4440-8589-61f58f239059

[main] Update dependencies from dotnet/arcade

2 years agorefactor SslStream internals (#68678)
Tomas Weinfurt [Mon, 9 May 2022 06:32:22 +0000 (23:32 -0700)]
refactor SslStream internals (#68678)

* refactor SslStream internals

* fix validation and certs

* update fakes

* feedback from review

2 years agoSimple runtime.yml change hoping it fixes rolling builds not triggering (#69029)
Jakob Botsch Nielsen [Sun, 8 May 2022 19:59:02 +0000 (21:59 +0200)]
Simple runtime.yml change hoping it fixes rolling builds not triggering (#69029)

2 years agoOverride CompleteAsync() in StreamPipeReader to call Stream.DisposeAsync (#67565)
madelson [Sun, 8 May 2022 16:51:58 +0000 (12:51 -0400)]
Override CompleteAsync() in StreamPipeReader to call Stream.DisposeAsync (#67565)

* Override CompleteAsync() in StreamPipeReader to call Stream.DisposeAsync().

fix #67050

* Apply suggestions from code review

Co-authored-by: David Fowler <davidfowl@gmail.com>
* Update StreamPipeReader.cs

Feedback from code review

Co-authored-by: David Fowler <davidfowl@gmail.com>
2 years agoOptimize bswap+mov to movbe on xarch (#66965)
Joni Aromaa [Sun, 8 May 2022 12:35:08 +0000 (15:35 +0300)]
Optimize bswap+mov to movbe on xarch (#66965)

2 years agoAdd Interlocked.{Compare}Exchange for UIntPtr (#68966)
Stephen Toub [Sat, 7 May 2022 19:00:05 +0000 (15:00 -0400)]
Add Interlocked.{Compare}Exchange for UIntPtr (#68966)

2 years agoCoreRT to NativeAOT renames (#68950)
Jan Kotas [Sat, 7 May 2022 18:59:22 +0000 (11:59 -0700)]
CoreRT to NativeAOT renames (#68950)

2 years agoFix typos (#69011)
Adeel Mujahid [Sat, 7 May 2022 18:55:53 +0000 (21:55 +0300)]
Fix typos (#69011)

2 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20220505.2
dotnet-maestro[bot] [Sat, 7 May 2022 12:22:06 +0000 (12:22 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20220505.2

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22179.1 -> To Version 2.5.1-beta.22255.2

2 years agoImplement IAsyncEnumerable source generator support (#68985)
Eirik Tsarpalis [Sat, 7 May 2022 09:43:21 +0000 (12:43 +0300)]
Implement IAsyncEnumerable source generator support (#68985)

* implement IAsyncEnumerable support for sourcegen

* address feedback

2 years ago[eventpipe] Fix environment variable parser for multiple configurations (#68552)
Stefan Schulze Frielinghaus [Sat, 7 May 2022 09:06:04 +0000 (11:06 +0200)]
[eventpipe] Fix environment variable parser for multiple configurations (#68552)

2 years agoMove away from exposing internal EventPipe wait handle to EventPipeEventDispatcher...
Johan Lorensson [Sat, 7 May 2022 09:01:00 +0000 (11:01 +0200)]
Move away from exposing internal EventPipe wait handle to EventPipeEventDispatcher. (#68320)

* Move away from exposing internal EventPipe wait handle to EventPipeEventDispatcher.

Fix for issue, #68032.

EventPipe exposed and internal wait handle to EventPipeEventDispatcher.
The wait handle is not a managed WaitableObject, but maps to runtime
specific event types:

CLREventStatic * on CoreCLR
mono_w32event_create on Mono

Overtime it appears that the underlying WaitHandle changed on none Windows
platforms, so calls like:

EventWaitHandle.Set

Assumes that IntPtr used is a WaitableObject and on Mono this will cause
a crash, but on CoreCLR, it will just be casted over to a WaitableObject
and use it, so based on memory layout this could cause issue, but looking
at the implementation, it appears it will always assume EventWaitHandle
is signaled so won't touch any of the memory (but not signal the event).

There have been an ambition in DispatchEventsToEventListeners to move
this abstraction down into native code, get away from using a handle
returned from EventPipeInternal.GetWaitHandle as a EventWaitHandle. This
PR eliminate EventPipeInternal.GetWaitHandle and adds a SignalSession and
WaitForSessionSignal icall's (Mono), qcall's (CoreCLR) and fix the
issue caused by exposing the handle to managed code.

2 years ago[mono] Fix read of image_info while raising image_unload event (#67138)
Stefan Schulze Frielinghaus [Sat, 7 May 2022 08:53:31 +0000 (10:53 +0200)]
[mono] Fix read of image_info while raising image_unload event (#67138)

2 years agoNormalize S.S.Cryptography's ref.cs file (#68993)
Jeremy Barton [Sat, 7 May 2022 05:14:33 +0000 (22:14 -0700)]
Normalize S.S.Cryptography's ref.cs file (#68993)

The order of some EditorBrowsables and Obsoletes seems to have flipped,
and the whitespace in ObsoleteAttribute DIagnosticId/UriFormat setters.

2 years agoAdd basic fake NTLM server to test NTAuthentication round-trip scenarios (#65611)
Filip Navara [Sat, 7 May 2022 03:47:08 +0000 (05:47 +0200)]
Add basic fake NTLM server to test NTAuthentication round-trip scenarios (#65611)

* Add basic NTLM fake server to test NTAuthentication round-trip scenarios

* Treat MIC as optional on Linux

* Add guard for IsNtlmInstalled

* Add comments; add protocol exchange example from NTLM specification

* Test both correct and incorrect credentials

* Check the SPN sent by client

* Replace NtlmAssert with regular Xunit Assert to get better messages

* Tweak algorithm for calculating flags in CHALLENGE_MESSAGE, add support for OEM encoding

* Set the NegotiateTargetInfo on CHALLENGE_MESSAGE; relax the check for Linux due to a bug in gss-ntlmssp

* Remove duplicate implementation of RC4.

* Fix paths.

* Rename EnableDllImportGenerator to EnableLibraryImportGenerator.

2 years agoFix wording in failure to load native library (#68995)
Brennan [Sat, 7 May 2022 00:55:56 +0000 (17:55 -0700)]
Fix wording in failure to load native library (#68995)

2 years agoUpdating Complex to implement INumberBase and ISignedNumber (#68612)
Tanner Gooding [Sat, 7 May 2022 00:19:10 +0000 (17:19 -0700)]
Updating Complex to implement INumberBase and ISignedNumber (#68612)

* Updating Complex to implement INumberBase and ISignedNumber

* Adding generic math tests for Complex

* Fixing some generic math tests for Complex to match the current behavior around -0

* Update src/libraries/System.Runtime.Numerics/src/System/Numerics/Complex.cs

Co-authored-by: Drew Kersnar <dakersnar@me.com>
Co-authored-by: Drew Kersnar <dakersnar@me.com>
2 years ago[mono][llvm] Fix support for --break + LLVM. (#68982)
Zoltan Varga [Fri, 6 May 2022 23:58:30 +0000 (19:58 -0400)]
[mono][llvm] Fix support for --break + LLVM. (#68982)

2 years agoDynamically sized stacks in EventPipe buffer manager (#68134)
John Salem [Fri, 6 May 2022 23:17:46 +0000 (16:17 -0700)]
Dynamically sized stacks in EventPipe buffer manager (#68134)

2 years agoBreak ExtensionsTests.cs into one file per type tested
Jeremy Barton [Fri, 6 May 2022 21:21:40 +0000 (14:21 -0700)]
Break ExtensionsTests.cs into one file per type tested

This change is essentially just style, no tests have been altered, added, or removed.

The tests that were about a particular extension have moved to a class named
for the type being tested (with the X509 prefix and Extension suffix omitted).
Now that the type tested is inferred from the name, the method names were
adjusted accordingly. e.g. ExtensionsTests.KeyUsageExtension_CrlSign is now
KeyUsageTests.EncodeDecode_CrlSign

The one test that wasn't about a single extension is now in the file
ExtensionsTests\ComprehensiveTests.cs, as it checks all of the extensions,
and the order of the extensions, from an existing certificate.

2 years agoRevert bad version reversions from 85d2aff4da96ac01babd461a1c76c358d4979d68
Larry Ewing [Fri, 6 May 2022 21:20:47 +0000 (16:20 -0500)]
Revert bad version reversions from 85d2aff4da96ac01babd461a1c76c358d4979d68

2 years agoUpdate dependencies from https://github.com/dotnet/linker build 20220506.1
dotnet-maestro[bot] [Fri, 6 May 2022 20:25:04 +0000 (20:25 +0000)]
Update dependencies from https://github.com/dotnet/linker build 20220506.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22255.1 -> To Version 7.0.100-1.22256.1

2 years agoUpdate libunwind to latest (#68899)
Jan Vorlicek [Fri, 6 May 2022 20:29:59 +0000 (22:29 +0200)]
Update libunwind to latest (#68899)

* Update libunwind

This change updates libunwind copy by a fix for non-4kB page sizes
that is needed e.g. for Linux arm64 with kernel set to use 64kB page
sizes (RHEL8 is one such case).

It also applies a fix for incorrect register storage in ARM64
getcontext.

* Add dummy `write` method implementation

* Update src/native/external/libunwind-version.txt

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
2 years agoAllow running System.Reflection tests on NativeAOT (#67575)
Michal Strehovský [Fri, 6 May 2022 20:05:55 +0000 (05:05 +0900)]
Allow running System.Reflection tests on NativeAOT (#67575)

Baselines/annotates anything that needs baselining/annotating.

2 years agoFix the Version.Details.xml entry for Microsoft.CodeAnalysis.NetAnalyzers (#68973)
Larry Ewing [Fri, 6 May 2022 19:54:20 +0000 (14:54 -0500)]
Fix the Version.Details.xml entry for Microsoft.CodeAnalysis.NetAnalyzers (#68973)

2 years agoSync shared code from aspnetcore (#68965)
github-actions[bot] [Fri, 6 May 2022 19:11:02 +0000 (12:11 -0700)]
Sync shared code from aspnetcore (#68965)

2 years agoThrow from MsQuicImplementationProvider if not supported. (#68833)
Radek Zikmund [Fri, 6 May 2022 19:07:09 +0000 (12:07 -0700)]
Throw from MsQuicImplementationProvider if not supported. (#68833)

* Throw from MsQuicImplementationProvider if not supported.

* Add tests

2 years agoAdd WaitAsync to prevent CI hangs (#68955)
Radek Zikmund [Fri, 6 May 2022 19:01:18 +0000 (12:01 -0700)]
Add WaitAsync to prevent CI hangs (#68955)

2 years agoDeprecate ICU ucol_safeClone and support ucol_clone (#68847)
Tarek Mahmoud Sayed [Fri, 6 May 2022 16:43:36 +0000 (09:43 -0700)]
Deprecate ICU ucol_safeClone and support ucol_clone (#68847)

2 years agoApply changes from #63356 (#68864)
John Salem [Fri, 6 May 2022 16:31:17 +0000 (09:31 -0700)]
Apply changes from #63356 (#68864)

2 years agoMerge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589...
Larry Ewing [Fri, 6 May 2022 15:25:31 +0000 (10:25 -0500)]
Merge remote-tracking branch 'upstream/main' into darc-main-31d4c308-6782-4440-8589-61f58f239059

2 years agoMake concurrent reads on HttpHeaders thread-safe (#68115)
Miha Zupan [Fri, 6 May 2022 15:04:28 +0000 (17:04 +0200)]
Make concurrent reads on HttpHeaders thread-safe (#68115)

2 years ago[main] Update dependencies from dotnet/linker (#68854)
dotnet-maestro[bot] [Fri, 6 May 2022 14:50:44 +0000 (09:50 -0500)]
[main] Update dependencies from dotnet/linker (#68854)

* Update dependencies from https://github.com/dotnet/linker build 20220503.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22252.2 -> To Version 7.0.100-1.22253.2

* Update dependencies from https://github.com/dotnet/linker build 20220505.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22252.2 -> To Version 7.0.100-1.22255.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
2 years agoAdd a cleanup job to backport workflow (#68596)
Adeel Mujahid [Fri, 6 May 2022 14:32:30 +0000 (17:32 +0300)]
Add a cleanup job to backport workflow (#68596)

* Add a cleanup job to backport workflow

* Add once a day schedule

* Pass GH token to the job

2 years agoDisabled k-nucleotide test on mono. (#68910)
Nathan Ricci [Fri, 6 May 2022 12:54:42 +0000 (08:54 -0400)]
Disabled k-nucleotide test on mono. (#68910)

2 years agoPhysical value numbering (#68712)
SingleAccretion [Fri, 6 May 2022 10:55:42 +0000 (13:55 +0300)]
Physical value numbering (#68712)

Value numbering supports precise numbering of field accesses using "maps":
where each access is modeled as a selection: "map[indices...]". It has been
the case until this change that said indices were always "precise" - VNs
of field handles.

This system has proven to be problematic for representing struct field access:

 1) The precise model effectively means that each field access represented
    by a unique handle cannot alias access to the same location, but using
    a different handle. This meant that reinterpretation of structs, reasonably
    common both in user code and in the IR compiler creates itself, was UB.
 2) The precise model for struct fields entailed supporting "zero-offset
    field sequences", which were maintained in a side map and caused a good
    number of bugs.

This change solves both of these problems by eliminating the need to use
precise selectors for struct fields, introducing a new kind of selector
(and maps to go with it): "the physical selector": offset plus load/store
size, with "VNForMapSelectWork" enhanced to look through physical store
maps, correctly detecting aliasing.

The precise selection rules are maintained for the maps indexing off of the
heap, where we don't have the same aliasing concerns. Physical maps are now
used exclusively for numbering locals.

This change seeks to preserve previous behavior to avoid diffs: many places
with now-not-needed pessimization are marked with "TODO-PhysicalVN". Similarly,
the field sequence infrastructure supporting the old precise selection scheme
is retained in its full generality. Future changes are expected to remove much
of it.

2 years agoFix double-validation in BoundedChannelOptions (#68938)
Armin Shoeibi [Fri, 6 May 2022 09:54:58 +0000 (14:24 +0430)]
Fix double-validation in BoundedChannelOptions (#68938)

2 years agoFix Regex handling of control characters (#68944)
Stephen Toub [Fri, 6 May 2022 09:54:43 +0000 (05:54 -0400)]
Fix Regex handling of control characters (#68944)

It was using the C category rather than Cc category.  And the test for this was missing the combined categories.

2 years agoRevert "Disable win-arm64 runtime tests on PRs for CoreCLR (#68627)" (#68922)
Jakob Botsch Nielsen [Fri, 6 May 2022 08:43:51 +0000 (10:43 +0200)]
Revert "Disable win-arm64 runtime tests on PRs for CoreCLR (#68627)" (#68922)

Testing capacity is back to a point where we have been told we can try
reenabling our workloads.

2 years agoImprove impPopCallArgs (#68736)
Jakob Botsch Nielsen [Fri, 6 May 2022 08:15:32 +0000 (10:15 +0200)]
Improve impPopCallArgs (#68736)

2 years agoAdd Mac ARM64 coverage to runtime-dev-innerloop (#68886)
Andy Gocke [Fri, 6 May 2022 03:13:45 +0000 (20:13 -0700)]
Add Mac ARM64 coverage to runtime-dev-innerloop (#68886)

* Add Mac ARM64 coverage to runtime-dev-innerloop

* Include global-build.yml

* Remove excludes entirely

2 years agoRevert "[QUIC] Adopted msquic generated interop (#68288)" (#68940)
Jan Kotas [Fri, 6 May 2022 02:20:52 +0000 (19:20 -0700)]
Revert "[QUIC] Adopted msquic generated interop (#68288)" (#68940)

This reverts commit 992b395a72d161bb2346258a726fb93b10f0d7e7.

2 years agoFix System.Collections.Immutable version in ILCompiler.Build.Tasks (#68935)
Logan Bussell [Fri, 6 May 2022 02:18:27 +0000 (19:18 -0700)]
Fix System.Collections.Immutable version in ILCompiler.Build.Tasks (#68935)

* Fix System.Collections.Immutable version in ILCompiler

* Add SystemCollectionsImmutableVersion to Versions.props