Florian Hahn [Wed, 11 Dec 2019 09:27:01 +0000 (09:27 +0000)]
[LiveRegUnits] Add phys_regs_and_masks iterator range (NFC).
This iterator range just includes physical registers and register masks,
which are interesting when dealing with register liveness.
Reviewers: evandro, t.p.northover, paquette, MatzeB, arsenm
Reviewed By: paquette
Differential Revision: https://reviews.llvm.org/D70562
Georgii Rymar [Tue, 10 Dec 2019 09:44:05 +0000 (12:44 +0300)]
[llvm-readelf] - Do no print an empty symbol version as "<corrupt>"
It is discussed here https://reviews.llvm.org/D71118#inline-643172
Currently when a version is empty, llvm-readelf prints:
"000: 0 (*local*) 2 (<corrupt>)"
But GNU readelf does not treat empty section as corrupt.
There is no sense in having empty versions anyways it seems, but
this change is for consistency with GNU.
Differential revision: https://reviews.llvm.org/D71243
Alexey Lapshin [Tue, 10 Dec 2019 20:41:07 +0000 (23:41 +0300)]
[DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be false.
The -fsplit-dwarf-inlining option does not conform to DWARF5 standard.
It creates children for Skeleton compilation unit. We need default behavior
to be DWARF5 compatible. Thus set default state for -fsplit-dwarf-inlining
into "false".
Differential Revision: https://reviews.llvm.org/D71304
Ilya Biryukov [Wed, 11 Dec 2019 08:38:14 +0000 (09:38 +0100)]
[CodeComplete] Fix a crash in preferred type and signature help
Summary: Null type pointers could be dereferenced in some cases.
Reviewers: kadircet, sammccall
Reviewed By: sammccall
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71329
Guillaume Chatelet [Tue, 10 Dec 2019 16:09:39 +0000 (17:09 +0100)]
[Alignment][NFC] Introduce Align in SROA
Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71277
Martin Storsjö [Mon, 25 Nov 2019 13:26:13 +0000 (15:26 +0200)]
[llvm-readobj] Fix/improve printing WinEH unwind info for linked PE images
ARMWinEHPrinter was already designed to handle linked PE images
(since
d2941b43f40d), but resolving symbols didn't consistently
take the image base into account (as linked images seldom have a
symbol table, except for in MinGW setups).
Win64EHDumper wasn't really designed to handle linked images (it would
crash if executed on such a file), but a few concepts (getSymbol,
taking a virtual address instead of a relocation, and
getSectionContaining for finding the section containing a certain
virtual address) can be borrowed from ARMWinEHPrinter.
Adjust ARMWinEHPrinter to print the address of the exception handler
routine as a VA instead of an RVA, consistently with other addresses
in the same printout, and make Win64EHDumper print addresses similarly
for image cases.
Differential Revision: https://reviews.llvm.org/D71303
QingShan Zhang [Wed, 11 Dec 2019 07:25:57 +0000 (07:25 +0000)]
[PowerPC] Exploitate the Vector Integer Average Instructions
PowerPC has instruction to do the semantics of this piece of code:
vector int foo(vector int m, vector int n) {
return (m + n + 1) >> 1;
}
This patch is adding the match rule to select it.
Differential Revision: https://reviews.llvm.org/D71002
Craig Topper [Wed, 11 Dec 2019 06:18:38 +0000 (22:18 -0800)]
[LegalizeTypes] Remove manual worklist management from SoftenFloatRes_FP_EXTEND.
I think this is no longer needed. The system should take care
of legalizing any new nodes that are added. I think this might
have been needed prior to r371709 or r307053.
Fangrui Song [Wed, 11 Dec 2019 05:37:57 +0000 (21:37 -0800)]
[ELF] Move a computeIsPreemptible() pass into ICF. NFC
Address post-commit review for D71163.
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D71326
Igor Kudrin [Tue, 10 Dec 2019 14:44:17 +0000 (21:44 +0700)]
[SanitizerCommon] Reduce wasting memory in LowLevelAllocator.
MmapOrDie allocates memory multiple to page size. LowLevelAllocator
should use all that memory for the internal buffer because there are
chances that subsequent requests may be small enough to fit in that
space.
Differential Revision: https://reviews.llvm.org/D71275
Richard Smith [Wed, 11 Dec 2019 03:56:07 +0000 (19:56 -0800)]
[cxx_status] Re-add missing cell.
Richard Smith [Wed, 11 Dec 2019 03:50:26 +0000 (19:50 -0800)]
[c++20] Implement P1946R0: allow defaulted comparisons to take their
arguments by value.
Richard Smith [Wed, 11 Dec 2019 03:20:46 +0000 (19:20 -0800)]
[c++20] Delete defaulted comparison functions if they would invoke an
inaccessible comparison function.
Jason Molenda [Wed, 11 Dec 2019 02:46:24 +0000 (18:46 -0800)]
Change the mtc Makefile to check $SDKROOT value instead
of depending on it being set in the environment. Fred's change
from October assumed that SDKROOT was set in the environment
so that 'xcrun --show-sdk-path' would print the path. If it
was passed in as a Makefile variable, it wouldn't be set in
the environment and xcrun --show-sdk-path would always show the
macOS SDK path. When running the lldb testsuite against an ios
device via lit, this seems to be the case.
Nico Weber [Wed, 11 Dec 2019 02:32:30 +0000 (21:32 -0500)]
Revert "[DebugInfo] Refactored macro related generation, added a test case for macinfo.dwo emission."
This reverts commit
307f60a1a3ff04313a75e2fc11bc14df4fc2ffb8.
DebugInfo/X86/debug-macinfo-split-dwarf.ll fails on Windows:
Command Output (stdout):
--
$ ":" "RUN: at line 1"
$ "c:\src\llvm-project\out\gn\bin\llc.exe" "-mtriple=x86_64-pc-windows-gnu" "-O0" "-split-dwarf-file=foo.dwo" "-filetype=obj"
Assertion failed: Section && "Cannot switch to a null section!", file ../../llvm/lib/MC/MCStreamer.cpp, line 1103
Stack dump:
0. Program arguments: c:\src\llvm-project\out\gn\bin\llc.exe -mtriple=x86_64-pc-windows-gnu -O0 -split-dwarf-file=foo.dwo -filetype=obj
Richard Smith [Wed, 11 Dec 2019 01:53:15 +0000 (17:53 -0800)]
Fix mishandling of invalid-but-non-empty nested name specifiers in name
classification.
We were accidentally treating invalid scope specs as being empty,
resulting in our trying to form an ADL-only call with a qualified
callee, which tripped up an assert later on.
Fangrui Song [Tue, 10 Dec 2019 21:45:02 +0000 (13:45 -0800)]
[llvm-ar] Improve tool selection heuristic
If llvm-ar is installed at arm-pokymllib32-linux-gnueabi-llvm-ar, it may
think it is llvm-lib due to the "lib" substring.
Improve the heuristic to make all the following work as intended:
llvm-ar-9 (llvm-9 package on Debian)
llvm-ranlib.exe
Lib.exe (reported by D44808)
arm-pokymllib32-linux-gnueabi-llvm-ar (reported by D71030)
Reviewed By: raj.khem, rupprecht
Differential Revision: https://reviews.llvm.org/D71302
Craig Topper [Wed, 11 Dec 2019 01:02:38 +0000 (17:02 -0800)]
[X86] Split v64i1 arguments into 2 v32i1s that will be promoted to v32i8 under min-legal-vector-width=256
This is an improvement to
88dacbd43625cf7aad8a01c0c3b92142c4dc0970
Sergej Jaskiewicz [Fri, 6 Dec 2019 14:26:35 +0000 (17:26 +0300)]
Reland "Enable `-funwind-tables` flag when building libunwind"
Summary:
Relands https://reviews.llvm.org/D70815.
The original commit set `CMAKE_TRY_COMPILE_TARGET_TYPE` to
`STATIC_LIBRARY` globally in libunwind/CMakeLists.txt, which effectively
disabled the linking step in CMake checks.
This broke some builds (see
938c70b86c7d2165f8c28d5700e9c1ac1263307e).
Here we set CMAKE_TRY_COMPILE_TARGET_TYPE to
STATIC_LIBRARY only when checking for presence of the `-funwind-tables`
flag, and then set it back to the original value so it doesn't affect
other checks.
Reviewers: mstorsjo, jfb
Subscribers: mgorny, christof, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D71117
Richard Smith [Wed, 11 Dec 2019 00:45:02 +0000 (16:45 -0800)]
[c++20] Implement P1185R2 (as modified by P2002R0).
For each defaulted operator<=> in a class that doesn't explicitly
declare any operator==, also inject a matching implicit defaulted
operator==.
Puyan Lotfi [Tue, 10 Dec 2019 09:40:36 +0000 (04:40 -0500)]
[llvm][MIRVRegNamerUtil] Adding hashing against MachineInstr flags.
Now, flags will result in differing hashes for a given MI. In effect, if
you have two instructions with everything identical except for their
flags then you should get two different hashes and fewer collisions.
Differential Revision: https://reviews.llvm.org/D70479
Erik Pilkington [Wed, 11 Dec 2019 00:43:39 +0000 (16:43 -0800)]
NFC: Get rid of an unused parameter to CGObjCMac::EmitSelectorAddr.
Gabor Horvath [Wed, 11 Dec 2019 00:42:03 +0000 (16:42 -0800)]
Revert "[analyzer] Keep track of escaped locals"
It was a step in the right direction but it is not clear how can this
fit into the checker API at this point. The pre-escape happens in the
analyzer core and the checker has no control over it. If the checker
is not interestd in a pre-escape it would need to do additional work
on each escape to check if the escaped symbol is originated from an
"uninteresting" pre-escaped memory region. In order to keep the
checker API simple we abandoned this solution for now.
We will reland this once we have a better answer for what to do on the
checker side.
This reverts commit
f3a28202ef58551db15818f8f51afd21e0f3e231.
Wang, Pengfei [Wed, 4 Dec 2019 00:39:21 +0000 (08:39 +0800)]
[FPEnv][X86] Constrained FCmp intrinsics enabling on X86
Summary: This is a follow up of D69281, it enables the X86 backend support for the FP comparision.
Reviewers: uweigand, kpn, craig.topper, RKSimon, cameron.mcinally, andrew.w.kaylor
Subscribers: hiraditya, llvm-commits, annita.zhang, LuoYuanke, LiuChen3
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70582
Louis Dionne [Tue, 10 Dec 2019 23:00:42 +0000 (18:00 -0500)]
[libc++] Hide some functions and types in <future> and <thread> as hidden
Otherwise, weak symbols leak into user programs when using `async` with
non-internal types.
Adrian Prantl [Tue, 10 Dec 2019 22:29:13 +0000 (14:29 -0800)]
Remove unsound caching in LanguageCategory
Analogous to https://reviews.llvm.org/D71233 it is not safe to cache
something that depends on the actual ValueObject in a cache then keys
only off the type name.
Differential Revision: https://reviews.llvm.org/D71297
Adrian Prantl [Tue, 10 Dec 2019 21:22:03 +0000 (13:22 -0800)]
Replace redundant code in LanguageCategory with templates (NFC)
Differential Revision: https://reviews.llvm.org/D71296
Vlad Tsyrklevich [Tue, 10 Dec 2019 23:50:10 +0000 (15:50 -0800)]
Revert "Reapply: [DebugInfo] Recover debug intrinsics when killing duplicated/empty..."
This reverts commit
f2ba93971ccc236c0eef5323704d31f48107e04f, it was
causing build timeouts on sanitizer-x86_64-linux-autoconf such as
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/44917
Adrian Prantl [Tue, 10 Dec 2019 18:58:06 +0000 (10:58 -0800)]
[FormatManager] Move Language lookup into the obviously non-cached part (NFC)
This refactoring makes the lookup caching easier to reason about. This
has no observable effect although it does slightly change what is
being cached.
- Before this patch a negative lookup in the LanguageCategory would be
cached, but a positive wouldn't.
- After this patch LanguageCategory lookups aren't cached by
FormatManager, period. (LanguageCategory has its own FormatCache for this!)
Differential Revision: https://reviews.llvm.org/D71289
Adrian Prantl [Tue, 10 Dec 2019 00:38:19 +0000 (16:38 -0800)]
Do not cache hardcoded formats in FormatManager
The cache in FormatCache uses only a type name as key. The hardcoded
formats, synthetic children, etc inspect an entire ValueObject to
determine their eligibility, which isn't modelled in the cache. This
leads to bugs such as the one in this patch (where two similarly named
types in different files have different hardcoded summary
providers). The problem is exaggerated in the Swift language plugin
due to the language's dynamic nature.
rdar://problem/
57756763
Differential Revision: https://reviews.llvm.org/D71233
Sergej Jaskiewicz [Fri, 6 Dec 2019 19:17:34 +0000 (22:17 +0300)]
[libcxx] Replace func_name with __name__ for compatibility with Python 3
Summary:
The __name__ attribute is the correct way to get a function name in
Python 3. This also works with Python 2.
Reviewers: jroelofs, EricWF
Subscribers: christof, ldionne, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D71136
Davide Italiano [Tue, 10 Dec 2019 23:20:49 +0000 (15:20 -0800)]
[DataFormatters] Change the Get() method to take a LanguageType.
Suggested by Adrian.
Jason Molenda [Tue, 10 Dec 2019 23:15:08 +0000 (15:15 -0800)]
Skip TestGuiBasic.py on ios etc device testing.
Craig Topper [Tue, 10 Dec 2019 22:44:38 +0000 (14:44 -0800)]
[X86] Go back to considering v64i1 as a legal type under min-legal-vector-width=256. Scalarize v64i1 arguments and shuffles under min-legal-vector-width=256.
This reverts
3e1aee2ba717529b651a79ed4fc7e7147358043f in favor
of a different approach.
Scalarizing isn't great codegen, but making the type illegal was
interfering with k constraint in inline assembly.
Eric Christopher [Tue, 10 Dec 2019 23:04:02 +0000 (15:04 -0800)]
Revert "Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes"
On multiple retry this issue won't duplicate - will revisit with author if
duplication works again.
This reverts commit
c9e0b354e2749ce7ab553974692cb35c8651a869.
Eric Christopher [Tue, 10 Dec 2019 23:02:29 +0000 (15:02 -0800)]
Remove debugging printf and reformat code.
Davide Italiano [Tue, 10 Dec 2019 22:44:51 +0000 (14:44 -0800)]
[TypeCategory] IsApplicable gets a LanguageType, not a ValueObject.
Reviewers: aprantl, teemperor
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71305
Jason Molenda [Tue, 10 Dec 2019 22:54:42 +0000 (14:54 -0800)]
Skip TestMultilineCompletion.py on ios testsuite runs.
Sanjay Patel [Tue, 10 Dec 2019 20:41:19 +0000 (15:41 -0500)]
[IR] allow undefined elements when checking for splat constants
This mimics the related call in SDAG. The caller is responsible
for ensuring that undef values are propagated safely.
Sanjay Patel [Tue, 10 Dec 2019 16:16:47 +0000 (11:16 -0500)]
[InstSimplify] add tests for insert constant + splat; NFC
David Blaikie [Tue, 10 Dec 2019 22:10:15 +0000 (14:10 -0800)]
DebugInfo: Clarify some more reasons v4 loc.dwo can't share much implementation with loclists.dwo
Vedant Kumar [Fri, 15 Nov 2019 23:37:29 +0000 (15:37 -0800)]
[DWARF] Allow cross-CU references of subprogram definitions
This allows a call site tag in CU A to reference a callee DIE in CU B
without resorting to creating an incomplete duplicate DIE for the callee
inside of CU A.
We already allow cross-CU references of subprogram declarations, so it
doesn't seem like definitions ought to be special.
This improves entry value evaluation and tail call frame synthesis in
the LTO setting. During LTO, it's common for cross-module inlining to
produce a call in some CU A where the callee resides in a different CU,
and there is no declaration subprogram for the callee anywhere. In this
case llvm would (unnecessarily, I think) emit an empty DW_TAG_subprogram
in order to fill in the call site tag. That empty 'definition' defeats
entry value evaluation etc., because the debugger can't figure out what
it means.
As a follow-up, maybe we could add a DWARF verifier check that a
DW_TAG_subprogram at least has a DW_AT_name attribute.
rdar://
46577651
Differential Revision: https://reviews.llvm.org/D70350
Davide Italiano [Tue, 10 Dec 2019 21:39:04 +0000 (13:39 -0800)]
[FormatManager] Add a unittest for GetCandidateLanguages()
Reviewers: teemperor, JDevlieghere, aprantl, jingham
Subscribers: mgorny, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71299
Vedant Kumar [Tue, 10 Dec 2019 21:35:50 +0000 (13:35 -0800)]
Debug Info: Strengthen the synthesized-property-cleanup.mm test, NFC
After https://reviews.llvm.org/D71084, the line locations assigned when
emitting cleanups inside of property accessors changed. Update this test
to actually check that those locations are correct.
rdar://
57796656
Louis Dionne [Tue, 10 Dec 2019 21:34:30 +0000 (16:34 -0500)]
[libcxx] [test] Query the target platform, not the host one
target_info is inferred to WindowsLocalTI on Windows hosts unless
specified otherwise. In the latter case, it doesn't make sense to use
Windows-specific settings if the target is not Windows.
This change should not break anything, because target_info is inferred
based on what platform.system() returns. self.is_windows was set based
on the same platform.system() call.
Thanks to Sergej Jaskiewicz for the patch.
Differential Revision: https://reviews.llvm.org/D68275
Alexey Bataev [Tue, 10 Dec 2019 21:12:53 +0000 (16:12 -0500)]
[OPENMP50]Do not mark the function as used if referenced only in declare
variant directive.
If the function is used only in declare variant directive as a variant
function, it should not be marked as used to prevent emission of the
target-specific functions. Build the reference in the unevaluated
context.
Francis Visoiu Mistrih [Wed, 4 Dec 2019 18:19:41 +0000 (10:19 -0800)]
[Remarks][Docs] Enhance documentation for opt-remarks driver options
Add better documentation about the naming scheme, add a few more
explicit descriptions and make the sphinx look better.
Richard Smith [Tue, 10 Dec 2019 19:33:27 +0000 (11:33 -0800)]
[c++20] Return type deduction for defaulted three-way comparisons.
Richard Smith [Tue, 10 Dec 2019 19:57:28 +0000 (11:57 -0800)]
[cxx_status] Fix table layout.
Sourabh Singh Tomar [Wed, 4 Dec 2019 13:02:39 +0000 (18:32 +0530)]
[DebugInfo] Refactored macro related generation, added a test case for macinfo.dwo emission.
Reviewers: dblaikie, aprantl, jini.susan.george
Tags: #debug-info #llvm
Differential Revision: https://reviews.llvm.org/D71008
Stephen Kelly [Sat, 7 Dec 2019 18:23:15 +0000 (18:23 +0000)]
Deprecate the hasDefaultArgument matcher
Summary:
It doesn't provide a way to match on the contents of the default
argumment. Rather than give it that capability, make it deprecated and
recomment the use of hasInitializer instead.
Reviewers: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71166
Vedant Kumar [Tue, 10 Dec 2019 20:36:40 +0000 (12:36 -0800)]
[lldb] Add #include to appease the modules build
This #include appears to be completely unnecessary, but it does fix the
following build failure:
http://green.lab.llvm.org/green/job/lldb-cmake/4565/consoleText
FAILED: tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/MainLoop.cpp.o
/Users/buildslave/jenkins/workspace/lldb-cmake/host-compiler/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLIBXML2_DEFINED -DLLDB_CONFIGURATION_RELEASE -DLLDB_USE_OS_LOG -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/lldb/source/Host -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/source/Host -Itools/lldb/source -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/include -Itools/lldb/include -Iinclude -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include -I/usr/local/Frameworks/Python.framework/Versions/3.7/include/python3.7m -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/../clang/include -Itools/lldb/../clang/include -I/usr/local/include -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/source/. -isystem /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/libxml2 -Wdocumentation -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -fmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/module.cache -fcxx-modules -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -UNDEBUG -fno-exceptions -fno-rtti -std=c++14 -MD -MT tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/MainLoop.cpp.o -MF tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/MainLoop.cpp.o.d -o tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/MainLoop.cpp.o -c /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/source/Host/common/MainLoop.cpp
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/source/Host/common/MainLoop.cpp:211:7: error: use of undeclared identifier 'ppoll'
if (ppoll(read_fds.data(), read_fds.size(), nullptr, &sigmask) == -1 &&
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/source/Host/common/MainLoop.cpp:336:25: error: use of undeclared identifier 'HAVE_SYS_EVENT_H'
ret = pthread_sigmask(HAVE_SYS_EVENT_H ? SIG_UNBLOCK : SIG_BLOCK,
^
2 errors generated.
Alexey Bataev [Tue, 10 Dec 2019 17:44:45 +0000 (12:44 -0500)]
[OPENMP50]Add if clause in target simd directive.
According to OpenMP 5.0, if clause can be used in for simd directive. If
condition in the if clause if false, the non-vectorized version of the
loop must be executed.
Eric Christopher [Tue, 10 Dec 2019 20:19:30 +0000 (12:19 -0800)]
Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes
This was causing a crash in opt+assert builds on linux and a follow-up
message was posted.
This reverts commit
e81268d03e73aef4f9c7bd8ece8ad02f5b017dcf
Haojian Wu [Tue, 10 Dec 2019 20:13:36 +0000 (21:13 +0100)]
[clangd] Fix an incorrect expectedResult usage in rename test.
expectedResult(Code, expectedResult(T, "abc")) => should be expectedResult(T, "abc")
The test was passed by coincidence.
Mark de Wever [Tue, 10 Dec 2019 17:32:30 +0000 (18:32 +0100)]
[Wdocumentation] Use C2x/C++14 deprecated attribute
This replaces the non-standard __attribute__((deprecated)) with the
standard [[deprecated]] when compiling in C2x/C++14 mode.
Discovered while looking at https://bugs.llvm.org/show_bug.cgi?id=43753
Differential Revision: https://reviews.llvm.org/D71141
Mark de Wever [Tue, 10 Dec 2019 17:32:29 +0000 (18:32 +0100)]
[Wdocumentation] Properly place deprecated attribute
It is now placed before the function:
- allows to replace __attribute__((deprecated)) with [[deprecated]].
- required for trailing returns.
Fixes bug: https://bugs.llvm.org/show_bug.cgi?id=43753
Differential Revision: https://reviews.llvm.org/D71140
Mark de Wever [Tue, 10 Dec 2019 17:32:28 +0000 (18:32 +0100)]
[Wdocumentation] Use the command marker.
Use the proper marker for -Wdocumentation-deprecated-sync instead of
hard-coded the backslash.
Discovered while looking at https://bugs.llvm.org/show_bug.cgi?id=43753
Differential Revision: https://reviews.llvm.org/D71139
Peter Collingbourne [Thu, 5 Dec 2019 01:28:45 +0000 (17:28 -0800)]
scudo: Tweak how we align UserPtr. NFCI.
Instead of testing whether the pointer is aligned, just align it
unconditionally and compare it to the original pointer.
This moves the computation of UserPtr up to before we start preparing the
header, so that the memory tagging code will be able to read the original
header containing the bounds of the previous allocation before it gets
potentially clobbered by the pointer realignment code.
Differential Revision: https://reviews.llvm.org/D71292
Peter Collingbourne [Mon, 9 Dec 2019 21:02:24 +0000 (13:02 -0800)]
scudo: Move getChunkFromBlock() allocated check into caller. NFCI.
With tag-on-free we will need to get the chunk of a deallocated block. Change
getChunkFromBlock() so that it doesn't check that the chunk is allocated,
and move the check into the caller, so that it can be reused for this purpose.
Differential Revision: https://reviews.llvm.org/D71291
Sourabh Singh Tomar [Fri, 29 Nov 2019 05:56:00 +0000 (11:26 +0530)]
Recommit "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."
Reviewers: dblaikie, aprantl, probinson
Tags: #debug-info #llvm
Differential Revision: https://reviews.llvm.org/D71185
Sourabh Singh Tomar [Tue, 10 Dec 2019 19:49:43 +0000 (01:19 +0530)]
Revert "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."
This reverts commit
6ef01588f4d75ef43da4ed2a37ba7a8b8daab259.
Missing Differetial revision.
Richard Smith [Tue, 10 Dec 2019 19:34:49 +0000 (11:34 -0800)]
Add missed #include in llvmorg-10-init-11532-g848934c67d4.
Richard Smith [Tue, 10 Dec 2019 02:01:47 +0000 (18:01 -0800)]
[cxx_status] Add missed Belfast paper affecting three-way comparisons.
Sourabh Singh Tomar [Fri, 29 Nov 2019 05:56:00 +0000 (11:26 +0530)]
[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.
Yonghong Song [Tue, 10 Dec 2019 19:05:22 +0000 (11:05 -0800)]
[BPF] put not-section-attribute externs into BTF ".extern" data section
Currently for extern variables with section attribute, those
BTF_KIND_VARs will not be placed in any DataSec. This is
inconvenient as any other generated BTF_KIND_VAR belongs to
one DataSec. This patch put these extern variables into
".extern" section so bpf loader can have a consistent
processing mechanism for all data sections and variables.
Vedant Kumar [Tue, 10 Dec 2019 19:18:45 +0000 (11:18 -0800)]
Assert launch success in run_to_breakpoint_do_run
Vedant Kumar [Tue, 10 Dec 2019 19:17:47 +0000 (11:17 -0800)]
Fix -Wincomplete-umbrella warning in the modules build
[281/3666] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/IntrinsicInst.cpp.o
/Users/vsk/src/llvm-project-master/llvm/lib/IR/IntrinsicInst.cpp:155:2: warning: missing submodule 'LLVM_IR.ConstrainedOps' [-Wincomplete-umbrella]
Eric Christopher [Tue, 10 Dec 2019 19:17:40 +0000 (11:17 -0800)]
Fix a -Wsign-compare error around wchar_t vs unsigned int.
Jonas Devlieghere [Tue, 10 Dec 2019 16:54:30 +0000 (08:54 -0800)]
[lldb/Host] Use Host/Config.h entries instead of a global define.
As suggested by Pavel in a code review:
> Can we replace this (and maybe python too, while at it) with a
> Host/Config.h entry? A global definition means that one has to
> recompile everything when these change in any way, whereas in
> practice only a handful of files need this..
Differential revision: https://reviews.llvm.org/D71280
Jonas Devlieghere [Sat, 7 Dec 2019 23:28:30 +0000 (15:28 -0800)]
[lldb/Reproducers] Support multiple GDB remotes
When running the test suite with always capture on, a handful of tests
are failing because they have multiple targets and therefore multiple
GDB remote connections. The current reproducer infrastructure is capable
of dealing with that.
This patch reworks the GDB remote provider to support multiple GDB
remote connections, similar to how the reproducers support shadowing
multiple command interpreter inputs. The provider now keeps a list of
packet recorders which deal with a single GDB remote connection. During
replay we rely on the order of creation to match the number of packets
to the GDB remote connection.
Differential revision: https://reviews.llvm.org/D71105
Yaxun (Sam) Liu [Tue, 10 Dec 2019 16:55:33 +0000 (11:55 -0500)]
Fix bug 44190 - wrong code with #pragma pack(1)
https://github.com/llvm/llvm-project/commit/
5b330e8d6122c336d81dfd11c864e6c6240a381e caused
a regression on s390:
https://bugs.llvm.org/show_bug.cgi?id=44190
we need to copy if if either the argument is non-byval or the argument is underaligned.
Differential Revision: https://reviews.llvm.org/D71282
Adrian Prantl [Tue, 10 Dec 2019 00:22:26 +0000 (16:22 -0800)]
Replace redundant code in FormatManager and FormatCache with templates (NFC)
This is a preparatory patch for an upcoming bugfix.
FormatManager and friends have four identical implementations of many
accessor functions to deal with the four types of shared pointers in
the FormatCache. This patch replaces these implementations with
templates. While this patch drastically reduces the amount of source
code and its maintainablity, it doesn't actually improve code
size. I'd argue, this is still an improvement.
rdar://problem/
57756763
Differential Revision: https://reviews.llvm.org/D71231
Hans Wennborg [Tue, 10 Dec 2019 18:09:24 +0000 (19:09 +0100)]
Revert
30e8f80fd5a4 "[DebugInfo] Don't create multiple DBG_VALUEs when sinking"
This caused non-determinism in the compiler, see command on the Phabricator
code review.
> This patch addresses a performance problem reported in PR43855, and
> present in the reapplication in in
001574938e5. It turns out that
> MachineSink will (often) move instructions to the first block that
> post-dominates the current block, and then try to sink further. This
> means if we have a lot of conditionals, we can needlessly create large
> numbers of DBG_VALUEs, one in each block the sunk instruction passes
> through.
>
> To fix this, rather than immediately sinking DBG_VALUEs, record them in
> a pass structure. When sinking is complete and instructions won't be
> sunk any further, new DBG_VALUEs are added, avoiding lots of
> intermediate DBG_VALUE $noregs being created.
>
> Differential revision: https://reviews.llvm.org/D70676
Kevin P. Neal [Mon, 11 Nov 2019 19:21:03 +0000 (14:21 -0500)]
[FPEnv] clang support for constrained FP builtins
Change the IRBuilder and clang so that constrained FP intrinsics will be
emitted for builtins when appropriate. Only non-target-specific builtins
are affected in this patch.
Differential Revision: https://reviews.llvm.org/D70256
Alexey Bataev [Tue, 10 Dec 2019 17:53:51 +0000 (12:53 -0500)]
[OPENMP]Remove extra space from error message.
Fixed emission of 2 consecutive whitespaces in the error message.
Vedant Kumar [Tue, 10 Dec 2019 17:45:04 +0000 (09:45 -0800)]
[profile] Add explanatory comments to instrprof-darwin-exports.c, NFC
Fangrui Song [Tue, 10 Dec 2019 17:34:23 +0000 (09:34 -0800)]
[VectorUtils] Fix -Wunused-private-field after D67572
Alexey Bataev [Tue, 10 Dec 2019 16:37:03 +0000 (11:37 -0500)]
[OPENMP50]Add if clause in target parallel for simd directive.
According to OpenMP 5.0, if clause can be used in for simd directive. If
condition in the if clause is false, the non-vectorized version of the
loop must be executed.
Fangrui Song [Sat, 30 Nov 2019 05:58:36 +0000 (21:58 -0800)]
[ELF] --icf: do not fold preemptible symbols
Fixes PR44124.
A preemptible symbol may refer to a different definition at runtime.
When comparing a pair of relocations, if they refer to different
symbols, and either symbol is preemptible, the two containing sections
should be considered different.
gold has a similar rule https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=
ce97fa81e0c46d216b80b143ad8c02fff6906fef
Reviewed By: grimar
Differential Revision: https://reviews.llvm.org/D71163
Fangrui Song [Sat, 7 Dec 2019 00:26:55 +0000 (16:26 -0800)]
[ELF] Refine section group --gc-sections rules to not discard .debug_types
clang/gcc -fdebug-type-sections places .debug_types and
.rela.debug_types in a section group, with a signature symbol which
represents the type signature. The section group is for deduplication
purposes.
After D70146, we will discard such section groups. Refine the rule so
that we will retain the group if no member has the SHF_ALLOC flag.
GNU ld has a similar rule to retain the group if all members have the
SEC_DEBUGGING flag. We try to be more general for future-proof purposes:
if other non-SHF_ALLOC sections have deduplication needs, they may be
placed in a section group. Don't discard them.
Reviewed By: grimar
Differential Revision: https://reviews.llvm.org/D71157
Gabor Horvath [Sat, 7 Dec 2019 01:11:37 +0000 (17:11 -0800)]
[analyzer] Keep track of escaped locals
We want to escape all symbols that are stored into escaped regions.
The problem is, we did not know which local regions were escaped. Until now.
This should fix some false positives like the one in the tests.
Differential Revision: https://reviews.llvm.org/D71152
Simon Cook [Tue, 10 Dec 2019 16:44:48 +0000 (16:44 +0000)]
[RISCV] Improve assembler missing feature warnings
This adds support for printing improved missing feature error messages
from the assembler, which now indicates which feature caused the parse
to fail.
Differential Revision: https://reviews.llvm.org/D69899
Francesco Petrogalli [Wed, 30 Oct 2019 19:08:21 +0000 (19:08 +0000)]
[VectorUtils] Introduce the Vector Function Database (VFDatabase).
This patch introduced the VFDatabase, the framework proposed in
http://lists.llvm.org/pipermail/llvm-dev/2019-June/133484.html. [*]
In this patch the VFDatabase is used to bridge the TargetLibraryInfo
(TLI) calls that were previously used to query for the availability of
vector counterparts of scalar functions.
The VFISAKind field `ISA` of VFShape have been moved into into VFInfo,
under the assumption that different vector ISAs may provide the same
vector signature. At the moment, the vectorizer accepts any of the
available ISAs as long as the signature provided by the VFDatabase
matches the one expected in the vectorization process. For example,
when targeting AVX or AVX2, which both have 256-bit registers, the IR
signature of the two vector functions associated to the two ISAs is
the same. The `getVectorizedFunction` method at the moment returns the
first available match. We will need to add more heuristics to the
search system to decide which of the available version (TLI, AVX,
AVX2, ...) the system should prefer, when multiple versions with the
same VFShape are present.
Some of the code in this patch is based on the work done by Sumedh
Arani in https://reviews.llvm.org/D66025.
[*] Notice that in the proposal the VFDatabase was called SVFS. The
name VFDatabase is more in line with LLVM recommendations for
naming classes and variables.
Differential Revision: https://reviews.llvm.org/D67572
Mikhail Maltsev [Tue, 10 Dec 2019 16:21:52 +0000 (16:21 +0000)]
[ARM][MVE] Refactor complex vector intrinsics [NFCI]
Summary:
This patch refactors instruction selection of the complex vector
addition, multiplication and multiply-add intrinsics, so that it is
now based on TableGen patterns rather than C++ code.
It also changes the first parameter (halving vs non-halving) of the
arm_mve_vcaddq IR intrinsic to match the corresponding instruction
encoding, hence it requires some changes in the tests.
The patch addresses David's comment in https://reviews.llvm.org/D71190
Reviewers: dmgreen, ostannard, simon_tatham, MarkMurrayARM
Reviewed By: dmgreen
Subscribers: merge_guards_bot, kristof.beyls, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D71245
diggerlin [Tue, 10 Dec 2019 16:14:49 +0000 (11:14 -0500)]
[BUG-FIX][XCOFF] fixed a bug of XCOFFObjectFile.cpp when there is padding at the last csect of a sections
SUMMARY:
Fixed a bug of XCOFFObjectFile.cpp when there is padding at the last csect of a sections.
when there is a tail padding of a section, but the value of CurrentAddressLocation do not be increased by the padding size. it will hit assert assert(CurrentAddressLocation == Section->Address && "We should have no padding between sections.");
Reviewers: daltenty,hubert.reinterpretcast,
Differential Revision: https://reviews.llvm.org/D70859
Yonghong Song [Fri, 22 Nov 2019 16:45:37 +0000 (08:45 -0800)]
[DebugInfo] Support to emit debugInfo for extern variables
Extern variable usage in BPF is different from traditional
pure user space application. Recent discussion in linux bpf
mailing list has two use cases where debug info types are
required to use extern variables:
- extern types are required to have a suitable interface
in libbpf (bpf loader) to provide kernel config parameters
to bpf programs.
https://lore.kernel.org/bpf/CAEf4BzYCNo5GeVGMhp3fhysQ=_axAf=23PtwaZs-yAyafmXC9g@mail.gmail.com/T/#t
- extern types are required so kernel bpf verifier can
verify program which uses external functions more precisely.
This will make later link with actual external function no
need to reverify.
https://lore.kernel.org/bpf/87eez4odqp.fsf@toke.dk/T/#m8d5c3e87ffe7f2764e02d722cb0d8cbc136880ed
This patch added clang support to emit debuginfo for extern variables
with a TargetInfo hook to enable it. The debuginfo for the
extern variable is emitted only if that extern variable is
referenced in the current compilation unit.
Currently, only BPF target enables to generate debug info for
extern variables. The emission of such debuginfo is disabled for C++
at this moment since BPF only supports a subset of C language.
Emission with C++ can be enabled later if an appropriate use case
is identified.
-fstandalone-debug permits us to see more debuginfo with the cost
of bloated binary size. This patch did not add emission of extern
variable debug info with -fstandalone-debug. This can be
re-evaluated if there is a real need.
Differential Revision: https://reviews.llvm.org/D70696
James Henderson [Tue, 10 Dec 2019 16:06:36 +0000 (16:06 +0000)]
[test][llvm-cxxfilt] Improve comment for clarity
Differential Revision: https://reviews.llvm.org/D71202
Kostya Kortchinsky [Mon, 9 Dec 2019 21:06:34 +0000 (13:06 -0800)]
[scudo][standalone] Define hasHardwareCRC32 for other archs
Summary:
The function was only defined for x86 and arm families, which ends
up being an issue for PPC in g3.
Define the function, simply returning `false` for "other"
architectures.
Reviewers: hctim, pcc, cferris, eugenis, vitalybuka
Subscribers: kristof.beyls, #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D71223
Sanjay Patel [Tue, 10 Dec 2019 15:10:05 +0000 (10:10 -0500)]
[InstCombine] replace shuffle's insertelement operand if inserted scalar is not demanded
This pattern is noted as a regression from:
D70246
...where we removed an over-aggressive shuffle simplification.
SimplifyDemandedVectorElts fails to catch this case when the insert has multiple uses,
so I'm proposing to pattern match the minimal sequence directly. This fold does not
conflict with any of our current shuffle undef/poison semantics.
Differential Revision: https://reviews.llvm.org/D71220
Sanjay Patel [Mon, 9 Dec 2019 22:07:30 +0000 (17:07 -0500)]
[Docs] Improve SLP code snippet
New C code snippet is more viable for SLP vectorization in most architectures.
Patch by: @lsandov1 (Leonardo Sandoval)
Differential Revision: https://reviews.llvm.org/D70866
Guillaume Chatelet [Mon, 9 Dec 2019 16:36:50 +0000 (17:36 +0100)]
[Alignment][NFC] CreateMemSet use MaybeAlign
Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: arsenm, jvesely, nhaehnle, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D71213
Luís Marques [Tue, 10 Dec 2019 13:59:04 +0000 (13:59 +0000)]
[DWARF][RISCV] Test resolving of RISC-V relocations
Summary: This patch adds an object file (in yaml format) with a synthetic
.debug_info section which we use to test that the supported RISC-V relocations
are properly resolved.
Reviewers: asb, lenary, MaskRay
Reviewed By: MaskRay
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70541
stozer [Thu, 5 Dec 2019 10:01:47 +0000 (10:01 +0000)]
Reapply: [DebugInfo] Recover debug intrinsics when killing duplicated/empty...
basic blocks
Originally applied in
72ce759928e6dfee6a9efa310b966c19722352ba.
Fixed a build failure caused by incorrect use of cast instead of
dyn_cast.
This reverts commit
8b0780f795eb58fca0a2456e308adaaa1a0b5013.
Raphael Isemann [Tue, 10 Dec 2019 13:17:38 +0000 (14:17 +0100)]
[lldb] Actually enable wchar support in Editline when it is defined in the host config
Summary:
Our Editline implementation in LLDB supports using the wchar interface of Editline which
should improve handling of unicode input when using Editline. At the moment we essentially
just ignore unicode input and echo the escaped unicode code point (`\U1234`) to the command line
(which we then also incorrectly treat as multiple characters, so console navigation is also broken afterwards).
This patch just adds the include to the host config file which already contains the LLDB_EDITLINE_USE_WCHAR
define to enable the Editline support (we just never included it in the file before). With this we now actually
echo back unicode characters on macOS and we no longer ignore unicode input. On Linux this doesn't
seem to improve the echoing back of characters but at least it fixes that we ignore unicode input.
Reviewers: labath
Reviewed By: labath
Subscribers: JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71251
Sam Parker [Tue, 10 Dec 2019 13:24:01 +0000 (13:24 +0000)]
add test for previous commit
Sam Parker [Tue, 10 Dec 2019 13:21:12 +0000 (13:21 +0000)]
[TypePromotion] Query target register width
TargetLoweringInfo may report that an integer should be promoted, but
it maybe provide a size that isn't natively supported by the target
register file... So check this before trying to perform a promotion.
This is to fix some chromium issues:
https://bugs.chromium.org/p/chromium/issues/detail?id=1031978
https://bugs.chromium.org/p/chromium/issues/detail?id=1031979
Differential Revision: https://reviews.llvm.org/D71200
Pavel Labath [Mon, 9 Dec 2019 15:44:26 +0000 (16:44 +0100)]
[lldb] Centralize type "desugaring" logic in ClangASTContext
Summary:
A *lot* of ClangASTContext functions contained repetitive code for
"desugaring" certain kinds of clang types. This patch creates a utility
function for performing this task.
Right now it handles four types (auto, elaborated, paren and typedef),
as these are the types that were handled everywhere. There are probably
other kinds of types that could/should be added here too (TypeOf,
decltype, ...), but I'm leaving that for a separate patch as doing that
would not be NFC (though I'm pretty sure that adding them will not hurt,
and it may in fact fix some bugs).
In another patch I'd like to add "atomic" type to this list to properly
display atomic structs.
Since sometimes one may want to handle a certain kind of type specially
(right now we have code which does that with typedefs), the Desugar
function takes a "mask" argument, which can supress desugaring of
certain kinds of types.
Reviewers: teemperor, shafik
Subscribers: jfb, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71212
Raphael Isemann [Tue, 10 Dec 2019 12:14:46 +0000 (13:14 +0100)]
[lldb][NFC] Make g_TotalSizeOfMetadata in ClangExternalASTSourceCommon.cpp static
Clang was warning that this global should be static (which makes sense).
Martin Storsjö [Fri, 6 Dec 2019 11:25:38 +0000 (13:25 +0200)]
[LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers
If not set, the address byte size was implied to be the one of the
host process.
This allows reverting the functional change from
31087b2ae9154, since
now PECOFF does the same as ELF and MachO wrt setting both byte order
and address size on m_data within ParseHeader.
Differential Revision: https://reviews.llvm.org/D71108