Boris Faure [Fri, 25 Jan 2013 22:21:37 +0000 (22:21 +0000)]
evas: make e start again…
SVN revision: 83336
Mike McCormack [Fri, 25 Jan 2013 21:30:54 +0000 (21:30 +0000)]
efl: Fix shadow warning
Signed-off-by: Mike McCormack <mike@atratus.org>
SVN revision: 83335
Mike McCormack [Fri, 25 Jan 2013 21:30:48 +0000 (21:30 +0000)]
efl: Fix unused parameter warning
Signed-off-by: Mike McCormack <mike@atratus.org>
SVN revision: 83334
Stefan Schmidt [Fri, 25 Jan 2013 16:03:47 +0000 (16:03 +0000)]
efl/eina: Fix strings to compare correctly and pass test suite.
This one is for Cedric.
SVN revision: 83332
Cedric BAIL [Fri, 25 Jan 2013 15:19:32 +0000 (15:19 +0000)]
efl/evas: prevent leak and over write.
SVN revision: 83331
Daniel Willmann [Fri, 25 Jan 2013 13:51:29 +0000 (13:51 +0000)]
efl: Actually install the ecore-audio.pc file
Seems this was lost during my rebase from ecore to the merged tree...
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
SVN revision: 83330
Jan Arne Petersen [Fri, 25 Jan 2013 12:34:10 +0000 (12:34 +0000)]
Add modules and module_arch variables to ecore_imf.pc
ecore_imf.pc should contain modules and module_arch variables (like
edje.pc, emotion.pc and ethumb.pc).
Patch by: Jan Arne Petersen <jpetersen@openismus.com>
SVN revision: 83327
Cedric BAIL [Fri, 25 Jan 2013 12:15:38 +0000 (12:15 +0000)]
efl/evas: roll in more cow, using a new macro per Eina_Cow.
SVN revision: 83325
Christopher Michael [Fri, 25 Jan 2013 07:19:48 +0000 (07:19 +0000)]
Let's do malloc the EFL way here.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83320
Cedric BAIL [Fri, 25 Jan 2013 06:16:33 +0000 (06:16 +0000)]
efl/eina: what the ?? Update text for magic test...
SVN revision: 83319
Jihoon Kim [Fri, 25 Jan 2013 05:15:46 +0000 (05:15 +0000)]
edje entry: move ecore_imf_context_cursor_position_set from mouse down event to mouse up event
SVN revision: 83318
Jihoon Kim [Fri, 25 Jan 2013 05:10:47 +0000 (05:10 +0000)]
edje entry: remove ecore_imf_context_reset, cursor update in mouse move event because it's useless.
SVN revision: 83317
Cedric BAIL [Fri, 25 Jan 2013 01:20:58 +0000 (01:20 +0000)]
eina: try to fix debug build typo.
SVN revision: 83315
U. Artie Eoff [Thu, 24 Jan 2013 22:03:22 +0000 (22:03 +0000)]
Cache wayland globals
Store the wayland registry globals in a list so that we can bind to them from a
user/test program. When a custom interface (protocol extension) is used in a
wayland compositor, this allows user/test program to use that interface. For
instance, one might provide a custom wayland test protocol that give access to
otherwise hidden/missing functionality that allows effective automated testing
(in wayland engines). See the Weston unit test suite for an example of this
concept.
Patch by: "U. Artie Eoff" <ullysses.a.eoff@intel.com>
SVN revision: 83312
Boris Faure [Thu, 24 Jan 2013 21:42:18 +0000 (21:42 +0000)]
efl: more valgrind related fixes on eina_cow
SVN revision: 83311
Eduardo de Barros Lima [Thu, 24 Jan 2013 21:35:06 +0000 (21:35 +0000)]
Move typedef enum declarations after the enum to make g++ happy.
When compiling a C++ program that includes Ecore_Wayland:
Ecore_Wayland.h:56:14: error: use of enum ‘_Ecore_Wl_Window_Type’ without previous declaration
Ecore_Wayland.h:56:56: error: invalid type in declaration before ‘;’ token
Ecore_Wayland.h:57:14: error: use of enum ‘_Ecore_Wl_Window_Buffer_Type’ without previous declaration
Ecore_Wayland.h:57:70: error: invalid type in declaration before ‘;’ token
This patch fixes ticket #2217.
SVN revision: 83310
Boris Faure [Thu, 24 Jan 2013 21:06:41 +0000 (21:06 +0000)]
efl: eina_cow: fix some valgrind instrumentation
SVN revision: 83308
Bruno Dilly [Thu, 24 Jan 2013 16:18:07 +0000 (16:18 +0000)]
efl: Support AM_PROG_AR in build sys when available
Patch by Henrique Dante de Almeida <hdante@profusion.mobi>
SVN revision: 83306
Stefan Schmidt [Thu, 24 Jan 2013 14:41:33 +0000 (14:41 +0000)]
efl/doc/images.mk: Lets not have all kind of images from .svn in here.
This breaks out of tree builds (buildbot) as well as setups without .svn
dirs (git-svn). The newly generated list should include all files but
drops all the entries from .svn.
SVN revision: 83302
Bruno Dilly [Thu, 24 Jan 2013 13:09:26 +0000 (13:09 +0000)]
edbus: implement edbus_proxy_data_{get, set, del}
The prototypes for those functions are defined in edbus_proxy.h, however
there's no implementation at all.
By Raphael Kubo <raphael.kubo.da.costa@intel.com>
SVN revision: 83299
Christopher Michael [Thu, 24 Jan 2013 12:15:11 +0000 (12:15 +0000)]
Add logging function macros
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83294
Christopher Michael [Thu, 24 Jan 2013 12:15:07 +0000 (12:15 +0000)]
Add logging functions
Remove dead commented out code
Do not call wl_surface_attach if the buffer is the same as the one
already attached.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83293
Christopher Michael [Thu, 24 Jan 2013 09:59:50 +0000 (09:59 +0000)]
Add code to delete the shm pool when we destroy the swapper.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83291
Christopher Michael [Thu, 24 Jan 2013 09:21:40 +0000 (09:21 +0000)]
Rewrite swapper code to use One shm pool and allocate buffers from
that pool.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83290
Christopher Michael [Thu, 24 Jan 2013 09:21:37 +0000 (09:21 +0000)]
Remove 'return' in idle_flush.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83289
Christopher Michael [Thu, 24 Jan 2013 09:21:34 +0000 (09:21 +0000)]
Use eina_rectangle_free
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83288
Christopher Michael [Thu, 24 Jan 2013 09:21:30 +0000 (09:21 +0000)]
Add onebuf field to Outbuf struct.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83287
Christopher Michael [Thu, 24 Jan 2013 09:21:27 +0000 (09:21 +0000)]
Reset Render_Engine onebuf if it was set previously.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83286
Christopher Michael [Thu, 24 Jan 2013 09:21:24 +0000 (09:21 +0000)]
Use eina_rectangle_free to free the rect.
Be sure to increment i here.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83285
Christopher Michael [Thu, 24 Jan 2013 09:21:21 +0000 (09:21 +0000)]
Add function prototype for swapper_idle_flush.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83284
Christopher Michael [Thu, 24 Jan 2013 09:21:18 +0000 (09:21 +0000)]
Add a swapper_buffer_idle_flush function to loop the Wl_Buffer
structures inside the swapper and release memory of any invalid ones.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83283
Christopher Michael [Thu, 24 Jan 2013 09:21:15 +0000 (09:21 +0000)]
Add code to handle idle_flush which will release memory that is unused
by invalid buffers.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83282
Christopher Michael [Thu, 24 Jan 2013 09:21:12 +0000 (09:21 +0000)]
Support an environment variable to set the number of buffers (double
buffer by default).
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83281
Christopher Michael [Thu, 24 Jan 2013 09:21:09 +0000 (09:21 +0000)]
Double buffer by default.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83280
Christopher Michael [Thu, 24 Jan 2013 09:21:06 +0000 (09:21 +0000)]
Rename the env variable that we will check for buffering support.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83279
Christopher Michael [Thu, 24 Jan 2013 09:21:04 +0000 (09:21 +0000)]
Set the engine's wl_shm reference during creation.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83278
Christopher Michael [Thu, 24 Jan 2013 09:21:01 +0000 (09:21 +0000)]
Check for valid wl_shm before trying to create the shm pool.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83277
Christopher Michael [Thu, 24 Jan 2013 09:20:58 +0000 (09:20 +0000)]
Fix typo.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83276
Christopher Michael [Thu, 24 Jan 2013 09:20:55 +0000 (09:20 +0000)]
Rename 'time' parameter in function prototype.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83275
Christopher Michael [Thu, 24 Jan 2013 09:20:45 +0000 (09:20 +0000)]
Rename 'time' parameter.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83274
Christopher Michael [Thu, 24 Jan 2013 09:20:40 +0000 (09:20 +0000)]
Remove unused variable.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83273
Christopher Michael [Thu, 24 Jan 2013 09:20:36 +0000 (09:20 +0000)]
Remove included evas_outbuf.h
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83272
Christopher Michael [Thu, 24 Jan 2013 09:20:32 +0000 (09:20 +0000)]
Change wayland shm engine to use proper macro.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83271
Christopher Michael [Thu, 24 Jan 2013 09:20:29 +0000 (09:20 +0000)]
Modify ecore_evas_wayland_shm to handle passing the wl_shm and
wl_surface to the new double-buffer engine.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83270
Christopher Michael [Thu, 24 Jan 2013 09:19:51 +0000 (09:19 +0000)]
Remove old line which did a wl buffer attach.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83269
Christopher Michael [Thu, 24 Jan 2013 09:18:34 +0000 (09:18 +0000)]
Remove all old code from ecore_evas that involved creating the wayland
buffer and shm pool.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83268
Christopher Michael [Thu, 24 Jan 2013 09:18:26 +0000 (09:18 +0000)]
Add new wayland shm engine files to Makefile.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83267
Christopher Michael [Thu, 24 Jan 2013 09:18:19 +0000 (09:18 +0000)]
Add engine output redraws next update get code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83266
Christopher Michael [Thu, 24 Jan 2013 09:18:15 +0000 (09:18 +0000)]
Add merge rectangles code (borrowed from the x11 engine).
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83265
Christopher Michael [Thu, 24 Jan 2013 09:18:09 +0000 (09:18 +0000)]
Add local function prototype for mergine rectangles.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83264
Christopher Michael [Thu, 24 Jan 2013 09:18:03 +0000 (09:18 +0000)]
Add engine idle flush code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83263
Christopher Michael [Thu, 24 Jan 2013 09:17:56 +0000 (09:17 +0000)]
Add engine output flush code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83262
Christopher Michael [Thu, 24 Jan 2013 09:17:51 +0000 (09:17 +0000)]
Add code for engine redraws push.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83261
Christopher Michael [Thu, 24 Jan 2013 09:17:47 +0000 (09:17 +0000)]
Add engine output redraws clear code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83260
Christopher Michael [Thu, 24 Jan 2013 09:17:40 +0000 (09:17 +0000)]
Add engine output redraws rectangle del code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83259
Christopher Michael [Thu, 24 Jan 2013 09:17:37 +0000 (09:17 +0000)]
Add engine output redraws rectangle add code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83258
Christopher Michael [Thu, 24 Jan 2013 09:17:34 +0000 (09:17 +0000)]
Add engine tile size set function code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83257
Christopher Michael [Thu, 24 Jan 2013 09:17:30 +0000 (09:17 +0000)]
Add eng_output_resize code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83256
Christopher Michael [Thu, 24 Jan 2013 09:17:26 +0000 (09:17 +0000)]
Add code to the eng_output_free function to do any cleanup.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83255
Christopher Michael [Thu, 24 Jan 2013 09:17:23 +0000 (09:17 +0000)]
Create engine context if missing and return success.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83254
Christopher Michael [Thu, 24 Jan 2013 09:17:19 +0000 (09:17 +0000)]
Reassign engine data output
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83253
Christopher Michael [Thu, 24 Jan 2013 09:17:15 +0000 (09:17 +0000)]
If we have an existing render engine already, then free the existing
output buffer, create a new one, and assign render engine functions.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83252
Christopher Michael [Thu, 24 Jan 2013 09:17:11 +0000 (09:17 +0000)]
Try to create the new Render_Engine on initial engine setup.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83251
Christopher Michael [Thu, 24 Jan 2013 09:17:00 +0000 (09:17 +0000)]
Add check to make sure output buffer creation worked.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83250
Christopher Michael [Thu, 24 Jan 2013 09:16:55 +0000 (09:16 +0000)]
Add code to create the output buffer of the render engine and set the
render_engine functions.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83249
Christopher Michael [Thu, 24 Jan 2013 09:16:52 +0000 (09:16 +0000)]
Add initial swapper code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83248
Christopher Michael [Thu, 24 Jan 2013 09:16:49 +0000 (09:16 +0000)]
Add initial header file for swapper.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83247
Christopher Michael [Thu, 24 Jan 2013 09:16:46 +0000 (09:16 +0000)]
Remove include for evas_outbuf.h
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83246
Christopher Michael [Thu, 24 Jan 2013 09:16:42 +0000 (09:16 +0000)]
Add initial swap buffer code.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83245
Christopher Michael [Thu, 24 Jan 2013 09:16:39 +0000 (09:16 +0000)]
Add initial swap buffer header file.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83244
Christopher Michael [Thu, 24 Jan 2013 09:16:36 +0000 (09:16 +0000)]
Set tilebuffer tile size in engine setup.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83243
Christopher Michael [Thu, 24 Jan 2013 09:16:22 +0000 (09:16 +0000)]
Try to create new tilebuffer in engine setup.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83242
Christopher Michael [Thu, 24 Jan 2013 09:16:19 +0000 (09:16 +0000)]
During engine setup, try to allocate a new Render_Engine structure.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83241
Christopher Michael [Thu, 24 Jan 2013 09:16:15 +0000 (09:16 +0000)]
Add base function for engine output setup.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83240
Christopher Michael [Thu, 24 Jan 2013 09:16:12 +0000 (09:16 +0000)]
Add local function prototype for engine output setup.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83239
Christopher Michael [Thu, 24 Jan 2013 09:16:09 +0000 (09:16 +0000)]
Add test for 'swapping' (ie: buffering).
NB: This env variable is going to change for the wayland engine(s).
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83238
Christopher Michael [Thu, 24 Jan 2013 09:16:06 +0000 (09:16 +0000)]
Add some evas_common init functions if we have not previously
initialized this engine before.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83237
Christopher Michael [Thu, 24 Jan 2013 09:16:03 +0000 (09:16 +0000)]
Test for valid engine output to see if we need to create it.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83236
Christopher Michael [Thu, 24 Jan 2013 09:15:59 +0000 (09:15 +0000)]
Try to get the Evas public data from eo.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83235
Christopher Michael [Thu, 24 Jan 2013 09:15:56 +0000 (09:15 +0000)]
Try to cast the passed in info to our engine info.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83234
Christopher Michael [Thu, 24 Jan 2013 09:15:53 +0000 (09:15 +0000)]
Try to free the allocated engine info structure.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83233
Christopher Michael [Thu, 24 Jan 2013 09:15:49 +0000 (09:15 +0000)]
Return our allocated engine info structure.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83232
Christopher Michael [Thu, 24 Jan 2013 09:15:15 +0000 (09:15 +0000)]
Fill in some default properties for our engine info.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83231
Christopher Michael [Thu, 24 Jan 2013 09:15:12 +0000 (09:15 +0000)]
Try to allocate our engine info structure.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83230
Christopher Michael [Thu, 24 Jan 2013 09:15:08 +0000 (09:15 +0000)]
Tell the Evas_Module about our functions and return success.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83229
Christopher Michael [Thu, 24 Jan 2013 09:15:05 +0000 (09:15 +0000)]
Define which functions this engine will override from the
software_generic functions.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83228
Christopher Michael [Thu, 24 Jan 2013 09:15:00 +0000 (09:15 +0000)]
Copy the inherited functions into our local variable so we can
override some functions.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83227
Christopher Michael [Thu, 24 Jan 2013 09:14:57 +0000 (09:14 +0000)]
Try to inherit functions from the software_generic engine.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83226
Christopher Michael [Thu, 24 Jan 2013 09:14:54 +0000 (09:14 +0000)]
On module open, create our log domain
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83225
Christopher Michael [Thu, 24 Jan 2013 09:14:50 +0000 (09:14 +0000)]
Unregister the module log domain on shutdown of the engine.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83224
Christopher Michael [Thu, 24 Jan 2013 09:14:46 +0000 (09:14 +0000)]
Add skeleton code for evas module open/close, etc.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83223
Christopher Michael [Thu, 24 Jan 2013 09:14:31 +0000 (09:14 +0000)]
Add skeleton code for evas engine functions.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83222
Christopher Michael [Thu, 24 Jan 2013 09:14:27 +0000 (09:14 +0000)]
Add variable(s) for engine function overrides.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83221
Christopher Michael [Thu, 24 Jan 2013 09:14:22 +0000 (09:14 +0000)]
Add prototypes for evas engine functions.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83220
Christopher Michael [Thu, 24 Jan 2013 09:14:19 +0000 (09:14 +0000)]
Add variable for log domain.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83219
Christopher Michael [Thu, 24 Jan 2013 09:14:16 +0000 (09:14 +0000)]
Add Render_Engine structure.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83218
Christopher Michael [Thu, 24 Jan 2013 09:14:13 +0000 (09:14 +0000)]
Add initial evas_engine C file.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83217
Christopher Michael [Thu, 24 Jan 2013 09:14:10 +0000 (09:14 +0000)]
Add intial Outbuf structure.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83216
Christopher Michael [Thu, 24 Jan 2013 09:14:07 +0000 (09:14 +0000)]
Add enum for render mode (double, triple, etc).
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83215
Christopher Michael [Thu, 24 Jan 2013 09:14:04 +0000 (09:14 +0000)]
Add Outbuf Depth enum.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 83214