Johann [Mon, 5 Mar 2018 22:27:04 +0000 (14:27 -0800)]
use intrinsics for 'emms'
BUG=webm:1500
Change-Id: I3235d8c2abc01dd3a35e14c5cbcfe20283ff8fb2
James Zern [Thu, 8 Mar 2018 21:13:09 +0000 (21:13 +0000)]
Merge "vpx_scale_test: add w/h output to alloc failure"
Paul Wilkins [Thu, 8 Mar 2018 13:34:15 +0000 (13:34 +0000)]
Merge "Change to KF frame boost calculation."
James Zern [Thu, 8 Mar 2018 07:07:51 +0000 (23:07 -0800)]
vpx_scale_test: add w/h output to alloc failure
Change-Id: Ib5df91d9fcd7fe973a2f7d8e73a204259beddc07
James Zern [Thu, 8 Mar 2018 03:41:27 +0000 (03:41 +0000)]
Merge changes If96fd6f1,I84b27337
* changes:
Fix a bug in vp9_iht16x16_256_add_neon()
Fix a bug in vp9_iht8x8_64_add_neon()
Johann [Tue, 6 Mar 2018 02:51:10 +0000 (18:51 -0800)]
add worst-case frame size cap
The largest frame is currently in choose_partitioning:
warning: stack frame size of 44156 bytes in function 'choose_partitioning'
but adding HBD amplifies other things:
warning: stack frame size of 51480 bytes in function 'dec_build_inter_predictors'
Add some padding for sanitizer and variances between compilers.
BUG=webm:1498
Change-Id: I0d94d4f94d25dafafca9d7484881c2ce5f8de371
Linfeng Zhang [Tue, 6 Mar 2018 00:14:35 +0000 (16:14 -0800)]
Fix a bug in vp9_iht16x16_256_add_neon()
This bug was introduced in
88c23864.
BUG=webm:1403
Change-Id: If96fd6f102be6b9bda866e55e574257287746f4a
Linfeng Zhang [Mon, 5 Mar 2018 23:16:49 +0000 (15:16 -0800)]
Fix a bug in vp9_iht8x8_64_add_neon()
This bug was introduced in
b14b616d.
BUG=webm:1403
Change-Id: I84b2733734982e52b66548850d61758c772b5494
Johann [Sun, 4 Mar 2018 20:31:04 +0000 (12:31 -0800)]
move vp8 encodeopt to block_error_sse2
The file contains sse2 implementations related to various block error
functions. Update the .mk file to include it only when sse2 is
requested.
BUG=webm:1500
Change-Id: I67b766faed425fd7a96db8541b13c69670b65fec
James Zern [Sat, 3 Mar 2018 20:47:24 +0000 (12:47 -0800)]
disable vp9_highbd_iht{4x4_16,8x8_64}_add_neon
these causes test vector failures
BUG=webm:1403
Change-Id: I08218f0bf26651eb367ece4feec6d704e0189bd8
James Zern [Sat, 3 Mar 2018 20:47:24 +0000 (12:47 -0800)]
disable vp9_iht8x8_64_add_neon
this causes test vector failures
BUG=webm:1403
Change-Id: I7d37a05fbf4641ea352c947053aa4eaeb7f5c318
James Zern [Sat, 3 Mar 2018 20:47:24 +0000 (12:47 -0800)]
disable vp9_iht16x16_256_add_neon
this causes test vector failures
BUG=webm:1403
Change-Id: Ifdb5b270c5cc70be5689e4fbda2ada3724cc65c3
Marco Paniconi [Fri, 2 Mar 2018 18:47:04 +0000 (10:47 -0800)]
vp9-svc: Disable partition_reuse unless 2x2 scale.
For SVC, if any of the layer scale ratios are not
2x2, then disable the partiton_reuse, which assumes
2x2 scaling between layers.
Change-Id: I8b3163de0826052bbb1bfe03554a074c89510558
Marco Paniconi [Thu, 1 Mar 2018 17:45:11 +0000 (09:45 -0800)]
vp9-svc: Fix to downsampling filter phase_shift.
Set phase_shift = 0 if the scale factors are
above 3/4. Removes artifact for scale factors
close to 1.
phase_shift = 8 is to get an averaging filter
(decimated pixel aligns to 8/16, midway between source pixels),
and only makes sense for scale factors multiples of
2 (1/2, 1/4,...).
Removes artifact for high scaling ratios.
Change-Id: Id0a85869d6c6156dda0032c697ded2de78fad6bd
James Zern [Thu, 1 Mar 2018 07:49:39 +0000 (23:49 -0800)]
iadst16x16_256_add_half1d: fix array size
t[] is indexed from 0..11
Change-Id: I7d0021f1795c6608354c8770843ea9dfdea66f97
paulwilkins [Wed, 21 Feb 2018 11:18:09 +0000 (11:18 +0000)]
Change to KF frame boost calculation.
This change is targeted mainly at higher resolutions where typically
the average error per MB is much smaller. hence this patch replaces
a fixed error per MB factor with a tiered value.
It also adds in a fixed offset value that acts as a minimum return score.
Note also minor fix to debug stats output.
The results are overall beneficial (-ve) on our test sets, most notably for
higher definition formats (see below - overall psnr, ssim, psnr hvs)
low res: 0.184 -0.262 -0.166
mid res: 0.094 0.075 0.049
hd res: -0.752 -0.300 -0.800
NF 2K: -0.353 1.095 -0.302
NF 4K: -1.245 -0.578 -1.205
The most notable negative case is pierseaside 2K which appears to be worse by
8-10% (which has a big impact on the overall gain for the NF 2K set). Closer
inspection reveals that the drop does not relate to the key frame boost
per se as in both cases the key frame substantially undershoots its target. Rather
this is a side effect relating to the initial Q range allowed for the key frame and
a poor initial complexity estimate. This will hopefully be improved in a later
patch.
Change-Id: I4773ebe554782f4024c047c3c392c763a3fe843b
Linfeng Zhang [Wed, 28 Feb 2018 18:26:39 +0000 (18:26 +0000)]
Merge "Add vp9_iht16x16_256_add_neon()"
James Zern [Tue, 27 Feb 2018 22:15:05 +0000 (22:15 +0000)]
Merge "datarate_test: correct last_pts_ref_ type"
Linfeng Zhang [Tue, 27 Feb 2018 01:22:36 +0000 (17:22 -0800)]
Add vp9_iht16x16_256_add_neon()
BUG=webm:1403
Change-Id: I1413cc3dfcb62143ba04fe9b0f8d8b010fdf69b6
James Zern [Tue, 27 Feb 2018 07:03:02 +0000 (23:03 -0800)]
datarate_test: correct last_pts_ref_ type
use vpx_codec_pts_t to match last_pts_; this quiets a conversion warning
under visual studio
Change-Id: I3f1c146fc13f2edfb515d76730a9ef063846bf69
Linfeng Zhang [Tue, 27 Feb 2018 01:00:10 +0000 (17:00 -0800)]
Fix a bug in create_s16x4_neon()
This bug exposes when 2nd argument is negative, and the higher 32 bits
would be all 1s.
Change-Id: I189ee8cd3753fde00a34847e7a37cde2caa4ba72
Linfeng Zhang [Sat, 24 Feb 2018 01:24:32 +0000 (01:24 +0000)]
Merge "Clean test/dct_test.cc with testing::Combine"
Linfeng Zhang [Thu, 22 Feb 2018 22:26:05 +0000 (14:26 -0800)]
Clean test/dct_test.cc with testing::Combine
Change-Id: I910fd34e4a06a73568b597ccb194c8395c2e6d08
Linfeng Zhang [Fri, 23 Feb 2018 01:42:59 +0000 (01:42 +0000)]
Merge "Add vp9_highbd_iht8x8_16_add_neon()"
Jerome Jiang [Fri, 23 Feb 2018 00:21:56 +0000 (00:21 +0000)]
Merge "VP9 SVC: Datarate test for dynamic bitrate change."
Jerome Jiang [Thu, 22 Feb 2018 00:51:12 +0000 (16:51 -0800)]
VP9 SVC: Datarate test for dynamic bitrate change.
Change-Id: Ie1cd990dcb19a4cc18de4a2e487791f399c4b3cb
Kyle Siefring [Wed, 21 Feb 2018 23:12:07 +0000 (23:12 +0000)]
Merge "Fold adds in 16->32-bit converts in SSE2/AVX2 fDCT"
Linfeng Zhang [Wed, 21 Feb 2018 01:21:31 +0000 (17:21 -0800)]
Add vp9_highbd_iht8x8_16_add_neon()
BUG=webm:1403
Change-Id: I11efb652f1aee371c71eee2d29e33793e4736832
Johann [Tue, 20 Feb 2018 22:49:02 +0000 (14:49 -0800)]
remove deprecated 'register' keyword
Will be removed in C++17:
http://en.cppreference.com/w/cpp/language/storage_duration
Change-Id: Iadce5e2b974c707799fa939f3ff1c420fb79a871
Jerome Jiang [Mon, 12 Feb 2018 23:26:07 +0000 (23:26 +0000)]
Merge "VP9 ROI test clean up regarding bool type flag."
Jerome Jiang [Mon, 12 Feb 2018 19:01:29 +0000 (11:01 -0800)]
vp9_cx_iface: Remove else when returning from the other branch.
Change-Id: I2fc15ec25cc5587cafc6621176d0a6d7c376fc7c
Jerome Jiang [Mon, 12 Feb 2018 18:36:14 +0000 (10:36 -0800)]
VP9 ROI test clean up regarding bool type flag.
Clean up code to make use_roi_ flag a bool.
Change-Id: I5b606ca19f8543840259d1cc79fe3301a2a70d30
Kyle Siefring [Mon, 5 Feb 2018 05:15:29 +0000 (00:15 -0500)]
Fold adds in 16->32-bit converts in SSE2/AVX2 fDCT
Changes in the function size in bytes (in lieu of performance metrics)
Before After Diff
vpx_fdct32x32_avx2 29564 -> 28334 -1230
vpx_fdct32x32_sse2 38053 -> 36309 -1744
Change-Id: Ie0b3e6ed7c3f2e9ea45f9d6a1ce1e27d068cee6b
Jerome Jiang [Sat, 10 Feb 2018 16:39:43 +0000 (08:39 -0800)]
VP9 ROI: reset use_roi_ in datarate test.
Change-Id: I51765ce6c3c8e8646852c4da47b12a0198892c52
Jerome Jiang [Fri, 9 Feb 2018 22:47:00 +0000 (14:47 -0800)]
VP9 ROI: Fix errors in example encoder.
Fix some errors in the vpx_temporal_svc_encoder.
Change-Id: Id93f449364dcf72c826ca931df3c8c3d3b80100f
Jerome Jiang [Fri, 9 Feb 2018 19:01:52 +0000 (19:01 +0000)]
Merge "Reland "Add ROI support for VP9.""
Jerome Jiang [Mon, 29 Jan 2018 18:14:40 +0000 (10:14 -0800)]
Reland "Add ROI support for VP9."
Extended ROI struct suitable for VP9.
ROI input from user is passed into internal struct and applied on every frame
(except key frame).
Enabled usage of all 4 VP9 segment features (delta_qp, delta_lf, skip,
ref_frame) via the ROI map input.
Made changes to nonrd_pickmode for the ref_frame feature.
Only works for realtime speed >= 5.
AQ_MODE needs to be turned off for ROI to take effect.
Change example in the sample encoder: vpx_temporal_svc_encoder.c to be suitable
for VP9.
Add datarate test.
Bump up ABI version.
BUG=webm:1470
Change-Id: I663b8c89862328646f4cc6119752b66efc5dc9ac
Jerome Jiang [Fri, 9 Feb 2018 18:54:55 +0000 (18:54 +0000)]
Merge "Revert "Add ROI support for VP9.""
Jerome Jiang [Fri, 9 Feb 2018 18:53:54 +0000 (18:53 +0000)]
Revert "Add ROI support for VP9."
This reverts commit
4e5b4b58483e1f38e37acd49b809d725b4f66c26.
Reason for revert: Commit message inaccurate.
Original change's description:
> Add ROI support for VP9.
>
> Extended ROI struct suitable for VP9.
> ROI input from user is passed into internal struct and applied on every frame
> (except key frame).
>
> Enabled usage of all 4 VP9 segment features (delta_qp, delta_lf, skip,
> ref_frame) via the ROI map input.
> Made changes to nonrd_pickmode for the ref_frame feature.
>
> Only works for realtime speed >= 5.
> AQ_MODE needs to be turned off for ROI to take effect.
>
> Change example in the sample encoder: vpx_temporal_svc_encoder.c to be suitable
> for VP9.
> Add datarate test.
>
> Bump up ABI version.
>
> BUG=webm:1470
>
> Change-Id: I7e0cf6890649adb98a5fda2efb6ae1fa511c7fc9
TBR=yaowu@google.com,jzern@google.com,marpan@google.com,builds@webmproject.org,jianj@google.com
Change-Id: I000dbd81e0c67cb8a0dcde4013ee9bf7afb038f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webm:1470
Jerome Jiang [Fri, 9 Feb 2018 16:58:55 +0000 (16:58 +0000)]
Merge "Add ROI support for VP9."
paulwilkins [Wed, 31 Jan 2018 16:42:37 +0000 (16:42 +0000)]
Improved coding on slide show content.
This patch adds in detection of slide show key frame groups.
The detection assumes extremely low or 0 motion for all frames
in the key frame group.
If this case is detected the boost level is set to a very high value
and the min Q to a lower value for the key frame itself.
Alt refs and golden frames are disabled to save bits (up to a limiting
maximum interval currently set to 240 frames).
In test samples that I created, this patch gave rise to a substantial
improvement in overall psnr and a drop in data rate. In some cases the
average psnr fell, however, with the boost and minQ values set as they are.
This is to be expected because previously a relatively poor key frame
could be followed by progressively better alt refs. For example a key
frame at q7.5 but subsequent alt refs improving it to lossless. Given that
average psnr tends to be dominated by the best frames, a ramp like this
from q7.5 to lossless may give a better average psnr than, for example,
coding the entire sequence at q2.5. Overall psnr, however, will be much
better in the latter case. The option exists to boost the key frame further
which would insure much better results for all metrics, but at the expense
of smaller bitrate savings. Given that these samples tend to have very
good quality anyway this seems like a bad trade off.
For slides displayed for several seconds, bitrate savings of >= 20% are likely
and much larger gains are possible in some cases.
Change-Id: Ib4b61e153c55d3f2f561153da13fdb56f397a52b
Marco [Mon, 29 Jan 2018 18:14:40 +0000 (10:14 -0800)]
Add ROI support for VP9.
Extended ROI struct suitable for VP9.
ROI input from user is passed into internal struct and applied on every frame
(except key frame).
Enabled usage of all 4 VP9 segment features (delta_qp, delta_lf, skip,
ref_frame) via the ROI map input.
Made changes to nonrd_pickmode for the ref_frame feature.
Only works for realtime speed >= 5.
AQ_MODE needs to be turned off for ROI to take effect.
Change example in the sample encoder: vpx_temporal_svc_encoder.c to be suitable
for VP9.
Add datarate test.
Bump up ABI version.
BUG=webm:1470
Change-Id: I7e0cf6890649adb98a5fda2efb6ae1fa511c7fc9
paulwilkins [Wed, 7 Feb 2018 15:05:20 +0000 (15:05 +0000)]
Adjust MAXRATE_1080P.
This value was originally set in response to requests from the hardware
team before levels were properly defined for VP9.
Even if a level is not specified for an encode, it imposes a maximum
frame size for videos of dimensions <= 1080P. For larger formats the
limit was set at 250 bits per MB.
This patch modifies the limit to be more in line with the requirements
specified for level 4 (max rate for a 4 frame group of 16 Mbits). If a lower
level is specified at encode time and this mandates a smaller maximum frame
size then the level requirement will still take precedence.
Increasing this value allows for some slide shows or very low motion clips
to code a better quality key frame.
Change-Id: Ic08e0e09c8a918077152190c59732b9a1c049787
Paul Wilkins [Thu, 8 Feb 2018 10:57:44 +0000 (10:57 +0000)]
Merge "Fix file input pointer bug in allocate_gf_group_bits()."
Linfeng Zhang [Wed, 7 Feb 2018 02:12:12 +0000 (18:12 -0800)]
Update iadst NEON functions
Use scalar multiply. No impact on clang, but improves gcc compiling.
BUG=webm:1403
Change-Id: I4922e7e033d9e93282c754754100850e232e1529
Linfeng Zhang [Wed, 7 Feb 2018 18:39:52 +0000 (10:39 -0800)]
Clean vp9_highbd_iht4x4_16_add_neon()
Extract common code.
Change-Id: I422150ada1c6915f0ce39b912149994eb3bb3f12
paulwilkins [Tue, 6 Feb 2018 13:54:25 +0000 (13:54 +0000)]
Fix file input pointer bug in allocate_gf_group_bits().
The stats input pointer, when passed in, already points to the
frame after the golden frame so should not be advanced here.
This fix has a small mostly positive effect on results in our test sets
(tested using corpus vbr settings) and gives a gain of almost 0.5%
in overall psnr (plus slightly smaller gains on other metrics) for the
4K set.
The bug also caused a crash in calculate_group_score() in another
patch which allows coding of slides in a slide show as a single
long KF group without ARFs or GFs.
Change-Id: I57a3a24baf442ce55dbc91fba05e056697c63a6f
Linfeng Zhang [Wed, 31 Jan 2018 00:55:22 +0000 (16:55 -0800)]
Update tx_type switch code in idct
Change-Id: Ia244bfd4b4eb9d703653792bc4f64c6f5358ae19
Linfeng Zhang [Wed, 31 Jan 2018 00:01:41 +0000 (16:01 -0800)]
Add vp9_highbd_iht4x4_16_add_neon()
BUG=webm:1403
Change-Id: Id9833e985fb70958cf4bde38f8e6303ed83c12f9
James Zern [Fri, 2 Feb 2018 18:41:46 +0000 (18:41 +0000)]
Merge "inv_txfm_vsx.c: make code c90 compatible"
Jerome Jiang [Fri, 2 Feb 2018 05:32:55 +0000 (05:32 +0000)]
Merge "Fix issue for 0 target bitrate in multi-res build."
Jerome Jiang [Thu, 25 Jan 2018 19:36:53 +0000 (11:36 -0800)]
Fix issue for 0 target bitrate in multi-res build.
For encoding with --enable-multi-res-encoding, with 1 layer, when the
target bitrate is set 0, under these conditions null pointer
will be de-referenced. Fix is to check
cpi->oxcf.mr_total_resolutions > 1. Also added NULL pointer check.
This issue causes crash for asan build in chromium clusterfuzz.
BUG=805863
Change-Id: I9cd25af631395bc9fede3a12fb68af4021eb15f8
James Zern [Fri, 2 Feb 2018 03:39:58 +0000 (19:39 -0800)]
inv_txfm_vsx.c: make code c90 compatible
move for loop declarations to function scope
Change-Id: I84d92a1a6ca6c5ac30aacb0f55d87ca3aef4c98f
James Zern [Thu, 1 Feb 2018 20:44:48 +0000 (20:44 +0000)]
Merge "vp9_scale_test: parameterize filter type"
Paul Wilkins [Thu, 1 Feb 2018 10:21:38 +0000 (10:21 +0000)]
Merge "Further change to code detecting slide transitions."
James Zern [Thu, 1 Feb 2018 07:38:47 +0000 (23:38 -0800)]
vp9_scale_test: parameterize filter type
this allows the test to be sharded more efficiently and speeds up the
run when built with slower configs, e.g., asan.
Change-Id: If6d863b76871e3934704a1079bbf17f4886932c7
Marco [Wed, 31 Jan 2018 23:15:40 +0000 (15:15 -0800)]
vp9-svc: Add condition on allocation for scaled_temp.
scaled_temp frame is used as an intermediate buffer for
2 stage down-sampling: two stages of 1/2 down-sampling
for a target of 1/4x1/4. This is used in 3 layer SVC
to avoid duplicate frame downsampling (on middle layer).
As this allocation is only needed/used when the
number_spatial_layers > 2, add this condition to avoid
unneeded allocation for 1 and 2 spatial SVC.
Change-Id: If342466644f685c1ea3ca5344b581793e5136c09
Marco [Wed, 31 Jan 2018 21:33:27 +0000 (13:33 -0800)]
vp9-svc: Fix to initialize downsampling filters.
For 3 spatial layers with 1/2 downsampling, the
downsampling filter for the middle layer was not
set for the very first frame, so it was defaulting
to the subsample filter (no averaging/phase = 0).
Its not set due to the two stage scaling that is
done for 1/4 on base layer, during which the intermediate
1/2 result is saved for the middle layer.
Fix for now is to set the default downsampling filter
to Bilinear (averaging/non-zero phase) for all layers on
init (vp9_init_layer_context):.
Change-Id: Ic7407810b34c621e7e7420682508d45478bdffcf
paulwilkins [Mon, 15 Jan 2018 12:00:01 +0000 (12:00 +0000)]
Further change to code detecting slide transitions.
Eliminate false positives in previous patch.
The previous patch did a good job of detecting slide transitions but
in discussions a number of situations were identified that might trigger
harmful false positives. This risk seems to be born out by some testing
on a wider YT set done by yclin@.
This patch adds an additional clause that requires that the best case
inter and intra error for the frame are very similar,meaning it is almost
as easy to code a key frame as an inter frame. This will certainly prevent
the false positive conditions that Jim and I discussed and even if one
does occur it should not be very damaging.
The down side is that this clause may mean that we still miss some
real slide transitions, especially if the images are small and similar. If this
proves to be the case then some further adjustment of the threshold may be
required. However, in the specific problem sample provided we do trap every
transition correctly.
Change-Id: I7e5e79e52dc09bc47917565bf00cc44e5cddd44c
Marco Paniconi [Wed, 31 Jan 2018 16:56:04 +0000 (16:56 +0000)]
vp9 svc: Make top layer non-ref: for 2 TL case
Only affects 2 temporal layer case.
Modified the flags for 2 temporal layers to make
top layer (top spatial, top temporal) a non-reference
frame, conistent with the 3 TL case.
Add mismatch check to the datarate test of changing
svc pattern on the fly, which is test for 2 temporal
layers.
This re-applies the change:
254e2f5501d,
that was reverted in:
658eb1d675.
Change-Id: Ib5fd4a7a0312c0c05329ae75baac480af34b4694
Marco Paniconi [Wed, 31 Jan 2018 16:49:42 +0000 (16:49 +0000)]
Merge "Revert "vp9 svc: fix to make top layer frame non-ref""
Marco Paniconi [Wed, 31 Jan 2018 16:49:16 +0000 (16:49 +0000)]
Revert "vp9 svc: fix to make top layer frame non-ref"
This reverts commit
254e2f5501d000ca66bc65c5f44bb6a882d4167c.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> vp9 svc: fix to make top layer frame non-ref
>
> Add mismatch check to the datarate test of changing svc pattern on the
> fly.
>
> Change-Id: I6a878736de44e6a40c077ed6430aabd7fadabdd9
TBR=marpan@google.com,builds@webmproject.org,jianj@google.com
Change-Id: Ibcb600438098f8dc380fe7e1de90cb81fc367468
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Johann Koenig [Wed, 31 Jan 2018 14:25:13 +0000 (14:25 +0000)]
Merge "Fix warning about bitwise 'not' on boolean"
Johann Koenig [Wed, 31 Jan 2018 14:23:49 +0000 (14:23 +0000)]
Merge "vp8 bool: verify buffer size"
Johann [Tue, 9 Jan 2018 20:46:45 +0000 (12:46 -0800)]
Fix warning about bitwise 'not' on boolean
cherry-picked from libaom:
commit
cf26ee5ad2b9da79fa68c33b7d22ff53c66d6509
Author: Sebastien Alaiwan <sebastien.alaiwan@allegrodvt.com>
Date: Wed, 4 Oct 2017 10:09:13 +0200
BUG=webm:1491
Change-Id: I36c6e83ed716649f3d9ee10ce3aa9bb847cac2d9
Johann [Tue, 30 Jan 2018 19:12:08 +0000 (11:12 -0800)]
vp8 bool: verify buffer size
In the process of fixing a ubsan warning:
commit
738b829b8cdf079a5fa48c74a28a177c9567d212
Fix incorrect size reading
the inferred check of start < end was removed. This causes fuzzed files
to get a little further and segfault in vp8dx_start_decode.
Change-Id: I316e23058753ba42dbcc46d27eb575f51c8a9e9a
Marco Paniconi [Tue, 30 Jan 2018 16:56:42 +0000 (16:56 +0000)]
Merge "vp9 svc: fix to make top layer frame non-ref"
Johann Koenig [Tue, 30 Jan 2018 15:32:22 +0000 (15:32 +0000)]
Merge "Fix doc comment mismatch in vpx_frame_buffer.h"
Jerome Jiang [Tue, 30 Jan 2018 00:38:28 +0000 (16:38 -0800)]
vp9 svc: fix to make top layer frame non-ref
Add mismatch check to the datarate test of changing svc pattern on the
fly.
Change-Id: I6a878736de44e6a40c077ed6430aabd7fadabdd9
Linfeng Zhang [Tue, 30 Jan 2018 01:20:41 +0000 (01:20 +0000)]
Merge "Update vp9_iht8x8_64_add_neon()"
Jerome Jiang [Tue, 30 Jan 2018 00:01:46 +0000 (00:01 +0000)]
Merge "Datarate test for usage of SVC_SET_REF_FRAME_CONFIG"
Linfeng Zhang [Mon, 29 Jan 2018 23:17:08 +0000 (15:17 -0800)]
Update vp9_iht8x8_64_add_neon()
Change-Id: Ie70ed8b9273df5e1fd06bc93cb469e80630941d2
Brion Vibber [Mon, 29 Jan 2018 23:13:09 +0000 (15:13 -0800)]
Fix doc comment mismatch in vpx_frame_buffer.h
When compiling an app using libvpx in Xcode 9.2, a warning is
thrown in vpx_frame_buffer.h:
"Parameter 'new_size' not found in the function declaration"
Switching it to 'min_size' to match the comment text and the
callback type definition prototype resolves it.
Change-Id: I7a3e4a857c2007c2d0d390e22054d7bc85068aa1
Jerome Jiang [Thu, 25 Jan 2018 18:43:00 +0000 (10:43 -0800)]
Datarate test for usage of SVC_SET_REF_FRAME_CONFIG
Change-Id: Iea7fc1b6cea84826eb45b1f01bd923323c2c9a6f
Linfeng Zhang [Mon, 29 Jan 2018 20:16:47 +0000 (20:16 +0000)]
Merge changes Ica8dbe5f,I8f4e0fc6
* changes:
Update vp9_iht4x4_16_add_neon()
Clean dct_const_round_shift() related neon code
Johann [Mon, 29 Jan 2018 19:57:00 +0000 (11:57 -0800)]
Merge remote-tracking branch 'origin/mandarinduck' into HEAD
The following changes were not carried back from the release branch:
commit
f87a4594fbd0b19071a2befebf52d3f5fabd1a9e
Revert "Add frame width & height to frame pkt. Add test."
commit
c5dc3373dbd442ea299bacf276c4258fa7ce0559
work around pic issue with gcc 6
BUG=webm:1490
Change-Id: Id3e15983d5565680c05a0c454544003a615a4d7f
Linfeng Zhang [Wed, 24 Jan 2018 21:54:55 +0000 (13:54 -0800)]
Update vp9_iht4x4_16_add_neon()
Change-Id: Ica8dbe5f8167e5d370d89d233c598b70bba123b7
Linfeng Zhang [Wed, 24 Jan 2018 21:05:39 +0000 (13:05 -0800)]
Clean dct_const_round_shift() related neon code
Change-Id: I8f4e0fc6ecb77b623519f2dd3cd2886f89218ddd
Linfeng Zhang [Mon, 29 Jan 2018 17:34:11 +0000 (17:34 +0000)]
Merge "cosmetic: clean idct neon functions"
Johann Koenig [Sat, 27 Jan 2018 01:42:58 +0000 (01:42 +0000)]
Merge "Fix incorrect size reading"
Johann [Fri, 26 Jan 2018 23:50:50 +0000 (15:50 -0800)]
Fix incorrect size reading
Cherry pick from vp9:
commit
85770264ac891505730dcd5092d1993a62c74060
Guard against incorrect size values moving *data past data_end.
Check read length against the difference of the buffers.
Change-Id: I5e8679ddd447c4d73deb80be5ec94841a92c5fcd
Jerome Jiang [Fri, 26 Jan 2018 22:45:39 +0000 (22:45 +0000)]
Merge "vp9 svc: Update temporal_layering_mode in config change."
Jerome Jiang [Fri, 26 Jan 2018 21:38:04 +0000 (13:38 -0800)]
vp9 svc: Update temporal_layering_mode in config change.
temporal_layering_mode can be changed on the fly.
BUG=webm:1488
Change-Id: I223fd4085184e41878ddf0f9244d2e3d07636ae3
Marco [Fri, 26 Jan 2018 03:00:31 +0000 (19:00 -0800)]
vp9-svc: Adjust logic on intra mode search.
For SVC, on spatial enhancement layer, intra
search was disabled unless best reference frame
is golden (i.e., spatial/inter-layer prediction),
except for some other conditions (lower layer is key
or golden is not an allowed reference).
Fix is to add the base temporal layer condition,
so intra search will not be force-disabled for base
temporal layer frames.
This improves metrics (-1-2%) for SVC 3 and 2 layer config.
Some small encode time is expected, but since condition
only affect base temporal layers (i.e., every 4 frames
for 3 layers), increase is small.
Change-Id: I10b824faef99560dfdeeb02ba8bf8e3e1eea6255
Marco [Thu, 25 Jan 2018 01:12:43 +0000 (17:12 -0800)]
vp9-svc: Add QP dependency to thresh_svc_skip_golden.
In nonrd-pickmode: the golden/spatial reference for inter-layer
prediction may be skipped in the mode testing. Add QP dependency
to reduce the threshold for skipping (i.e., check it more often)
at high QP, if the lower layer was encoded at lower QP relative
to the current layer.
At high QP, a better quality lower resolution is more likely to
provide good spatial (inter-layer) prediction.
avgPSNR/SSIM metrics up by ~1% (all clips positive gain or neutral).
Some decrease in encode time (~1-2%) expected at lower bitrates,
for 3 layer SVC.
Change-Id: I9ee0f62d4b10d4ebd30165d378ecfa4399ae5ef1
Marco Paniconi [Wed, 24 Jan 2018 23:56:48 +0000 (23:56 +0000)]
Merge "vp9: Fix to vp9_svc sample encoder for bypass mode."
Johann Koenig [Wed, 24 Jan 2018 23:44:12 +0000 (23:44 +0000)]
Merge "remove obsolete doxygen tags"
Marco [Wed, 24 Jan 2018 23:16:34 +0000 (15:16 -0800)]
vp9: Fix to vp9_svc sample encoder for bypass mode.
This fix makes it bitexact to the default SVC pattern,
for the example 2 temporal layer case.
Change-Id: I4df2063b70f7aecbfc7082f29c8439e05f6db8ac
Scott LaVarnway [Wed, 24 Jan 2018 22:54:42 +0000 (22:54 +0000)]
Merge "BUG FIX: sse2 subpel variance is not PIC compliant"
Johann [Wed, 24 Jan 2018 22:29:07 +0000 (14:29 -0800)]
remove obsolete doxygen tags
warning: Tag `XML_SCHEMA' at line 941 of file `doxyfile' has become obsolete.
warning: Tag `XML_DTD' at line 947 of file `doxyfile' has become obsolete.
Change-Id: I85e39c4fb154569b8d7f68bdf362408983e9bd4f
Johann [Thu, 4 Jan 2018 18:54:28 +0000 (10:54 -0800)]
Release 1.7.0 Mandarin Duck
Change-Id: I186440f3643a85694f45400393efb661f6d012fc
Linfeng Zhang [Wed, 24 Jan 2018 00:03:50 +0000 (16:03 -0800)]
cosmetic: clean idct neon functions
Change-Id: I9c7c52567850aded0437b13ba1260e94441bc49d
Marco Paniconi [Wed, 24 Jan 2018 20:29:10 +0000 (20:29 +0000)]
Merge "vp9-svc: Re-adjust some aq-mode=3 control parameters."
Scott LaVarnway [Sat, 13 Jan 2018 15:01:04 +0000 (07:01 -0800)]
BUG FIX: sse2 subpel variance is not PIC compliant
BUG=webm:1464
Change-Id: Ibc15bac54aaf509365bed5892a26a29972ad3540
Scott LaVarnway [Wed, 24 Jan 2018 13:58:08 +0000 (13:58 +0000)]
Merge "vp9_quantize_fp_avx2()"
Marco [Wed, 24 Jan 2018 04:03:19 +0000 (20:03 -0800)]
vp9-svc: Re-adjust some aq-mode=3 control parameters.
Remove an adjustment to two cyclic refresh (aq-mode= 3)
parameters for SVC. The adjustment was to reduce the
delta-qp on second segment, and reduce the motion threshold.
This was done early on in the SVC encoder development,
in the latest codebase removing this adjustment yields
some improvements in metrics.
The avgPSNR/SSIM metrics increase on average by ~1%
(most clip positive gain), for 3 and 2 layer SVC.
Change-Id: I7a4d5114f16b2a1df383dbe6b3fe02940e29e6cc
Johann Koenig [Wed, 24 Jan 2018 04:03:23 +0000 (04:03 +0000)]
Merge "update .clang-format for v5.0.0"
James Zern [Tue, 23 Jan 2018 21:01:23 +0000 (13:01 -0800)]
vpx_codec_enc_init_multi: fix segfault w/vp9
vp9 does not support multi-res encoding, the request should not crash.
+ encode_api_test: unconditionally expose multi-res test
vpx_codec_enc_init_multi should fail independent of
CONFIG_MULTI_RES_ENCODING if not for the same reason.
Change-Id: I44fc58ef70ee4e0e482cb6a5736885f4cb2a8517
(cherry picked from commit
004fb91416e355986dc098883791becf39ffc1f7)
Jerome Jiang [Wed, 17 Jan 2018 19:23:55 +0000 (11:23 -0800)]
Fix crash invalid params for vp8 multres. Add test.
Fix is from the patch in the issue.
Release memories allocated before early exit.
BUG=webm:1482
Change-Id: I64952af99c58241496e03fa55da09fd129a07c77
(cherry picked from commit
5b6ae020b6a972b67b59b3dbf7cf9cbd3140a80d)
James Zern [Wed, 24 Jan 2018 02:12:00 +0000 (02:12 +0000)]
Merge "vpx_codec_enc_init_multi: fix segfault w/vp9"