Jean-Philippe Andre [Wed, 10 Aug 2016 07:29:17 +0000 (16:29 +0900)]
evas: Call legacy events before new key/pointer eo events
This affects pointer & key events.
Here's the scenario: in Enventor, an elm_button object
grabs the up & down keys for the autocompletion feature.
But the entry will also listen to up & down to move the
cursor. Moreover, the scroller listens to up & down arrow
keys to scroll around.
So, when calling the new eo event first, the scroller
or the entry would catch it and do some action. In
Enventor, this triggered a hide on the magic anchor
object. Bad, bad.
I fear something will be wrong with this order as well.
Both events (legacy & eo) should be called simultaneously,
following the order & priorities that were set.
This being said, in real life most of EFL internals will
move to the new eo events (right now elm relies on the
new events, but edje doesn't, yet), so any app grabbing a
key probably wants to handle the event before elm. Same
for an app using focus manually.
Fixes T4310
Jean-Philippe Andre [Wed, 10 Aug 2016 06:30:50 +0000 (15:30 +0900)]
Revert "evas: Optimize out a function call if not required"
This reverts commit
8cb3b79a82b1769cba5a7a10f9937aa18dd65d8a.
I shouldn't have pushed this. So wrong. Sorry about the noise.
Jean-Philippe Andre [Wed, 10 Aug 2016 06:25:44 +0000 (15:25 +0900)]
evas: Optimize out a function call if not required
Same as the previous patch in elm_widget: don't call
flags_set() if the flags have not changed.
Jean-Philippe Andre [Wed, 10 Aug 2016 05:17:00 +0000 (14:17 +0900)]
widget: Optimize out one function call if not needed
Jean-Philippe Andre [Wed, 10 Aug 2016 04:52:26 +0000 (13:52 +0900)]
evas: Fix evas_objects_at_xy_get() for smart objects
Due to the way the clip geometry calculation changed
(see
25d77bc1d24d9fd539c681fa58db976c1ca65051) to be
based on the bounding box rather than the raw geometry
of smart objects, the internal function
evas_object_is_in_output_rect() now returns true if the
rectangle intersects with that bounding box, even if
it's outside the raw geometry.
This breaks the drop area in E's pager, as it relies on
evas_objects_at_xy_get() to find which objects are at
this point. What I saw on my desktop was that only the
lower 10 or 20 pixels were droppable in the pager,
as maximized windows would have shadows covering the
upper 20 pixels or so.
Arguably objects_at_xy_get could also return all objects
at (x,y) including smart objects that extend beyong their
geometry. This can be added as a flag in the EO API, but
not in the legacy API.
Carsten Haitzler (Rasterman) [Wed, 10 Aug 2016 02:12:17 +0000 (11:12 +0900)]
fix double delcaration of variable in elm_code
this fixes T4318 - thanks romain.
Stefan Schmidt [Tue, 9 Aug 2016 21:03:19 +0000 (23:03 +0200)]
tests: elm: follow up fix for _animation_disabled_ rename
This is a follow up fix for
4f840c5febe94c16627f034926cb8fdf933b465e
Due to the abbreviated use in this macro I missed this occurrence.
With this fix it passes make check as well.
Daniel Kolesa [Tue, 9 Aug 2016 16:18:59 +0000 (17:18 +0100)]
docs: add since tag writing into doctree
Carsten Haitzler (Rasterman) [Tue, 9 Aug 2016 15:30:55 +0000 (00:30 +0900)]
evas smart obj delete on shutdown - fix weird child with null parent
while removing children from a parent smart object, the destruction of
the smart obj encountered childrne with NULL parents. they were in the
child list but had no parent. This was totally odd and unexpected,
thus caused an infinite loop trying to dlete a child that won't be
removed from the list because parent is NULL thus it cna't find the
parent list to remove it from. This works around that and then
complains with an error. The workaround also seems to have encountered
what might be a compiler bug so I prepended to the layer object list
rather than appended. this at leats stops the hang.
@fix
Stefan Schmidt [Tue, 9 Aug 2016 14:17:14 +0000 (16:17 +0200)]
elm: config: fix API naming to use disabled instead of disable to unify
We use disabled across our APIs so better fix this new one to unify it before
we release. This was introduced in commit
0116e072888feeade7a15ad8e206d1e35dc3511b
Many thanks to DaveMDS for reporting this!
Daniel Kolesa [Tue, 9 Aug 2016 14:19:39 +0000 (15:19 +0100)]
docs: initial documentation tree
This will abstract away Eolian APIs to get more maintaineable code.
For now, the Eolian_Documentation structure is abstracted away.
Dave Andreoli [Tue, 9 Aug 2016 13:30:07 +0000 (15:30 +0200)]
Add a FAILING test for genlist reusable contents
shortly explained in T4319
Vyacheslav Reutskiy [Tue, 9 Aug 2016 11:26:44 +0000 (14:26 +0300)]
edje_pick:set the correct compression for sample
@fix
Fixes T4314
Vyacheslav Reutskiy [Tue, 9 Aug 2016 11:22:39 +0000 (14:22 +0300)]
edje_pick: set the correct file name for copied sample
@fix
Dave Andreoli [Tue, 9 Aug 2016 09:58:23 +0000 (11:58 +0200)]
Add a test for elm_gengrid_item_all_contents_unset()
The function is good, and the test works as expected, I have written
this because I have problems in pyefl with this function
Vyacheslav Reutskiy [Tue, 9 Aug 2016 07:17:31 +0000 (10:17 +0300)]
edje_pick: don't copy dependencies group if they in the import list
If a dependence group in the import list - don't copy it as dependence,
it make group duplicate and make a recurcive load.
@fix
Fixes T4313
Umesh Tanwar [Tue, 9 Aug 2016 06:00:41 +0000 (15:00 +0900)]
elementary_test: Search menu performance optimization.
Summary:
elementary_test search menu is created again and again
at each search query. Here the optimaization is to remember
the menu item and retain them instead of deletion and reuse them.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
Test Plan:
search item in elementary_test and measure the
performace time.
Reviewers: jpeg
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D4218
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Jean-Philippe Andre [Tue, 9 Aug 2016 05:50:36 +0000 (14:50 +0900)]
ecore_input_evas: Enable cancel events by default
After my input event changes, the propagation path has been altered
from:
ecore_x -> evas_event
to:
ecore_x -> ecore_input_evas -> evas_event
But ecore_input_evas was ignoring cancel events by default. There
should be no good reason to disable cancel events anymore,
according to @jypark. Also, this fixes an actual bug :)
Fixes T4301
Jean-Philippe Andre [Tue, 9 Aug 2016 02:19:11 +0000 (11:19 +0900)]
evas filters: Fix minor issue with print
If the call to tostring() fails, replace the string by (invalid)
rather than ignore the error.
Fixes CID 1308612
Jean-Philippe Andre [Tue, 9 Aug 2016 01:56:29 +0000 (10:56 +0900)]
edje_cc: Remove unused variable 'got_hash'
got_hash will always be zero at the point where it's read.
Fixes CID 1261439
Stefan Schmidt [Mon, 8 Aug 2016 15:46:46 +0000 (17:46 +0200)]
examples: elm: enable +evas3d_scene_on_button_example again
This was disabled at some point but works fien in my testing so enable it
again. If we no longer want it we should remove it completely.
Stefan Schmidt [Mon, 8 Aug 2016 15:20:50 +0000 (17:20 +0200)]
build: examples: make sure we build all examples in list
At some point we lost the \ after track_example_01 and in combination with the
commented out line right afterwards we lost all examples coming after this line.
This just surfaced with JPs latest commit when I did a distcheck build but was
there for a longer time. We now make sure all disabled examples are moved out of
the multi-line list.
Stefan Schmidt [Mon, 8 Aug 2016 14:02:39 +0000 (16:02 +0200)]
eina: add includes for getpid() to work on MacOSX
Without this I get errors from the clang compiler used on Travis for some OSX
builds:
../src/lib/eina/eina_inline_lock_posix.x:845:27: error: use of undeclared identifier 'getpid'
Daniel Hirt [Mon, 8 Aug 2016 13:41:06 +0000 (16:41 +0300)]
Elm.Entry: force cursor change on size_eval signal
This is a follow-up to
ba060fe93236da37e4c8bbd84c1bcf58e27979d6.
Fixes T4274.
Daniel Kolesa [Mon, 8 Aug 2016 13:38:08 +0000 (14:38 +0100)]
elua: load modules from local dirs first
This fixes cases when running scripts locally - local modules
are preferred over systemwide, avoiding possibly outdated system
scripts from being run.
Stefan Schmidt [Mon, 8 Aug 2016 12:47:46 +0000 (14:47 +0200)]
eina: safepointer: add since tags to new eina safepointer EAPI
Daniel Hirt [Mon, 8 Aug 2016 12:10:56 +0000 (15:10 +0300)]
Canvas.text: fix segfault with ellipsis cases
The specific handling for (0.0 <= ellip < 1) doesn't support multi-line cases.
One of the main reasons is that we haven't had the chance to define the wanted
behavior for multi-line.
This is a temporary hack to fix a segfault. The behavior is still undefined,
though.
Fixes T3885.
Jean-Philippe Andre [Mon, 8 Aug 2016 11:40:41 +0000 (20:40 +0900)]
examples: Fix button theme
A program was not handling the various states properly.
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 09:32:16 +0000 (18:32 +0900)]
elm filesel - handle api that might provide path too big for buffer
this addresses a path that could be too small (unlikely due to max
path generally being 4k), for a stack buffer. this should make
coverity happy. fix CID 1356634
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 09:25:32 +0000 (18:25 +0900)]
eina_module - check result of module load from an array of modules
we don't give any debug or info if a module in a list fails to load.
we should at least offer debug info. do that. this fixes coverity
issue CID 1039687
Jean-Philippe Andre [Mon, 8 Aug 2016 09:09:58 +0000 (18:09 +0900)]
examples: Fix path to edj theme files (theme examples)
A bit complex but should work in most cases (installed & not)
Jean-Philippe Andre [Mon, 8 Aug 2016 08:44:22 +0000 (17:44 +0900)]
examples: Compile edj files in elementary examples
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 08:15:22 +0000 (17:15 +0900)]
ecore gl module - dont check value that is already valid
make coverity happy with CID 1347410 - it's technically right that the
code assumes the im ptr is valid until then as it dereferences it
until then and then stores it under pd->image but then checks for
NULL.. it would have crashed already if it were, so rmemove the
pointless check.
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 08:06:40 +0000 (17:06 +0900)]
elm init - handle return value of ecore_file_init make coverity happy
this isn't an issue as init will never fail, but makes coverity happy
with CID 1353589
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 07:58:16 +0000 (16:58 +0900)]
elm dbus menu - handle return value of eldbus_message_iter_arguments_get
handle possible error return of eldbus_message_iter_arguments_get()
according to coverity CID 1353591. this should fix that.
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 07:55:19 +0000 (16:55 +0900)]
elm app client - check return of eldbus_message_iter_arguments_get
as accoding to coverity CID 1353593 chekc returns of the above
function and return/continue as apporpriate if these fail (which
generallly they shouldnt unless some end of the dbus client is broken).
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 07:50:34 +0000 (16:50 +0900)]
efl vpath - make sure we check returns of mkdir just in case for errors
so vpath has a fallback if all things bad go wrong to mkdir a homedir
in /tmp and if that fails use /tmp or use / - if $HOME isnt set ... but
$HOME alwasy should be, so this is only for "a broken system".
this should fix CID 1354286
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 06:33:18 +0000 (15:33 +0900)]
edje entry - handle insanely low lemory if list_append fails
this fixes coverity CID 1357752
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 06:18:56 +0000 (15:18 +0900)]
elm_need_efret() - improve error handling according to coverity
fix CID 1360466
we don't actually chekc if efreet inits right with elm_need_efreet()
as we just assume it inits (And there pretty much is no case where it
will not), but make coverity happy and check.
@fix
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 05:49:35 +0000 (14:49 +0900)]
emotion modules -0 check return value of eina_module_load and print err
this should inform the user via eina log errors that a module load
failed. this fixes CID 1360954
Jean-Philippe Andre [Mon, 8 Aug 2016 06:15:54 +0000 (15:15 +0900)]
evas: Mark native_surface as const
The void* argument should be considered read-only.
This doesn't change anything, really.
Sungtaek Hong [Fri, 5 Aug 2016 06:36:41 +0000 (15:36 +0900)]
elm_map: fix wrong check of source search
Summary:
When map source is set by elm_map_source_set(),
it foreaches enlisted sources, and should return
when the source cannot be found.
@fix
Test Plan:
Call elm_map_source_set(map, [any type], [Wrong source name]);
Observe ERR("source name (%s) is not found", source_name) message.
Reviewers: Hermet, cedric, jpeg
Reviewed By: jpeg
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4212
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 05:27:26 +0000 (14:27 +0900)]
efl - edje entry - dont emit changed on markup set unless text changed
if the text didnt actually change we generat a lot of noise in changed
signals for no change at all in text. shortcut this and check the new
and old text and compare ptrs, 0 length and strings etc.
this fixes T4045
@fix
Carsten Haitzler (Rasterman) [Mon, 8 Aug 2016 05:15:02 +0000 (14:15 +0900)]
evas cserve2 client - treat an invalid size header as fatal
this should make coverity CID 1361430 happy
Jean Guyomarc'h [Sun, 7 Aug 2016 22:12:49 +0000 (00:12 +0200)]
ecore_cocoa: remove pointless debug message
This message was also very annoying because systematically
printed out in the syslog when a cocoa window was closed.
Vincent Torri [Sun, 7 Aug 2016 09:40:48 +0000 (11:40 +0200)]
Edje_Edit.h: undef EAPI at the end of the header file
Fixes T4303
Carsten Haitzler (Rasterman) [Sun, 7 Aug 2016 09:27:33 +0000 (18:27 +0900)]
Revert "elementary: keep theme consistent regarding the disabling of odd/even."
Revert "elementary: disable visual hint at odd/even."
This reverts commit
c64071ae132ddc5894d5daad8a874377a176aac5.
This reverts commit
7affe8c2047a41a2945cf6c048d59f28c974aa7a.
This reverds the odd/even theme changes because this BREAKS
ENLIGHTENMENT COMPLETELY. Enlightement also uses odd/even list looks
and REMOVING this REMOVES every 2nd lost item member (it makes them
0x0 sized). This is a major break in actual FUNCTIONALITY in the name
of looks. NO. Revert.
We ship with this look. no more breaking stuff like this in the name
of cosemtics and not ACTUALLY fixing any bug at all. it creates bugs.
Daniel Hirt [Sun, 7 Aug 2016 08:13:16 +0000 (11:13 +0300)]
Evas font: fix size query again
Some wrong variables were used in the rewrite at
8c6effae8ee027a928bcee79968a0b21d8250487, basically reverting the original fix.
Carsten Haitzler (Rasterman) [Sat, 6 Aug 2016 10:10:24 +0000 (19:10 +0900)]
edje_cc - fix inheritance of programs and store channel too in copy
this fixes programs that inherit and play audio on specific channels.
i found that sound worked on single line entries but not multipline
beause single line inherit from multi but didnt copy this program
param - the channel number. this fixes this
@fix
Carsten Haitzler (Rasterman) [Sat, 6 Aug 2016 09:10:36 +0000 (18:10 +0900)]
elm config - dont rescale ui if no config that needs rescale changed
also finger size, and other thigns that could affect ui look that may
need elm rescale to work.
this fixes T4296
@fix
Carsten Haitzler (Rasterman) [Sat, 6 Aug 2016 07:16:19 +0000 (16:16 +0900)]
evas cserver client tool - handle possible < 0 sized return
this is cserver so its trusted but handle possible < 0 size msg.
address coverity CID1361243
Carsten Haitzler (Rasterman) [Sat, 6 Aug 2016 06:59:23 +0000 (15:59 +0900)]
pdf loader - check return for rmdir
fixes CID 1361218
Carsten Haitzler (Rasterman) [Sat, 6 Aug 2016 06:53:18 +0000 (15:53 +0900)]
eina log - handle possible overflow from high mem (last few bytes) or env
fixes CID 1361219
if you had an env var a few gb in size or we had stuff in the last bit
of memory address space this might be an issue, but that won't happen.
@fix
Carsten Haitzler (Rasterman) [Sat, 6 Aug 2016 06:50:17 +0000 (15:50 +0900)]
eina log - keep coverity happy with potential ptr comparison overflow
fixes CID 1361220
in theory yes end minus start could be insanely huge or end be very
high in memory thus causing an overflow. this would have to be in the
last few bytes of memory space, so it never going to happen. and the
input from the env var has to be sane anyway as its user controlled.
@fix
Carsten Haitzler (Rasterman) [Sat, 6 Aug 2016 06:41:02 +0000 (15:41 +0900)]
embryo_cc - fix coverity complaint about assert
fix assert using a strance assert syntax and go back to basic asserts.
fix coverity CID 1361224
@fix
Stephen Houston [Sat, 6 Aug 2016 01:33:27 +0000 (20:33 -0500)]
Eio: Update my email address.
Carsten Haitzler (Rasterman) [Sat, 6 Aug 2016 00:51:10 +0000 (09:51 +0900)]
eina threadqueue - for paranoia lock+ulock+free in order locks taken
so mimic order of locks taken to be paranoid ... this wouldnt be a
deadlock issue but just to be safe instead of sorry.
Stefan Schmidt [Fri, 5 Aug 2016 20:06:39 +0000 (22:06 +0200)]
edje: mark new edje_mmap_3d_has() API with since tag
Stefan Schmidt [Fri, 5 Aug 2016 20:04:55 +0000 (22:04 +0200)]
ecore_wl2: mark new events with since tag
Stefan Schmidt [Fri, 5 Aug 2016 19:57:52 +0000 (21:57 +0200)]
evas: add missing since tag for new evas_object_type_get() API
Cedric Bail [Fri, 5 Aug 2016 19:14:18 +0000 (12:14 -0700)]
ecore: properly track events in Efl.Loop.Fd object.
Thanks Gustavo.
Cedric Bail [Fri, 5 Aug 2016 17:31:49 +0000 (10:31 -0700)]
Revert "elementary/layout: attach edje object API with eo compositing"
This reverts commit
8a988717e18c4e9e6d4a0752441471a124056878.
It seems we can't actually inherit from class more than once and neither eo
nor eolian will complain about it. You will just get random weird behavior.
This patch should come back once we have made an interface of edje.
Dave Andreoli [Fri, 5 Aug 2016 17:01:39 +0000 (19:01 +0200)]
Simple test case to spot out a bad bug in elm.Entry
The bug is explained in T4296, basically the "changed" signal in elm.Entry is called randomly.
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 14:51:03 +0000 (23:51 +0900)]
eina thread queue - ensure blocks cannot be freed until lock+unlock
just in case... check blocks cannot be freed until locked and unlocked
just in case someone still is holding a lock.
Stefan Schmidt [Fri, 5 Aug 2016 13:26:02 +0000 (15:26 +0200)]
README: clarify poppler dependency
We actually need poppler-cpp which is packaged in various ways in different
distros so better give both names here.
Stefan Schmidt [Fri, 5 Aug 2016 10:27:46 +0000 (12:27 +0200)]
README: update build dependencies and build instructions
Remove part where we recommend the now merged loaders and players and update
build dependencies as well as recommended options.
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 11:34:42 +0000 (20:34 +0900)]
ecore imf test - remove unused variable
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 11:20:25 +0000 (20:20 +0900)]
ecore eina thread queue test - be anal about thread exiting cleanly
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 10:41:59 +0000 (19:41 +0900)]
ecore-con - fix complaint about null slave list due to shutdown
so ecore-con already cleared the slaves list on shutdown but an
ecore_thread may stillbe active and thus removing from a NULL slaves
list wont work, so skip if slaves is NULL.
@fix
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 09:11:42 +0000 (18:11 +0900)]
eina lock semaphores - do not use shared semaphores and fix osx names
the way eina does sempahores, they can NEVER be sensibly shared
cross-process portably. so enabling sharing is a pointless idea. in
fact some os's like openbsd check if the sempahore addres is in a
sharable mem region and deny init if it is not. on osx you dont use
shared memory but a sempahore name you share instead... and this is
not exposed thus it can't be shared either. if we did process sharable
semaphores we'd make shm segments and/or name them in a sharable way
were you can share the idenitifer of the shm segment and/or the offset
address or name from osx. but we don't, so making them
process-private is the right thing. sharable sempahores will need a
whole new api.
this also fixes osx naming to make the name pretty unguessable/private
and opened exclusive (or it fails) by using pid, sem counter, and 4
random numbers. it's not a security mechanism as the create will fail
if there is a clash. chances are low. we unlink before anyway. good
enough for osx for now.
@fix
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 08:38:02 +0000 (17:38 +0900)]
eina thread queue/semaphores - check even more unlikely errors + complain
check some really unlikely alloc errors and semaphore deadlock errors
and report if that has happened. just in case.
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 08:08:25 +0000 (17:08 +0900)]
eina thread queue - check returns fo semaphore new/lock/release to debug
so openbsd may have issues with semaphores - maybe. this would catch
them if it it. why - if sem_init/sem_wait are different... i dont know.
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 07:59:08 +0000 (16:59 +0900)]
ecore con eet test - dont use localhost port 8080
so thats a common local port to use for other things... 8080 - don't
use it, so use 12346 much like 12345 is for the other tests. far less
likely to clash. fix up tests to work better.
Shinwoo Kim [Fri, 5 Aug 2016 07:17:13 +0000 (16:17 +0900)]
atspi: toolbar - fix cannot call select callback
There is a line to check select_mode in _item_select function.
The item selected(clicked) callback is called when the select_mode is ELM_OBJECT_SELECT_MODE_NONE.
The checking select_mode should be handled at one place.
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 05:35:41 +0000 (14:35 +0900)]
ecore eina threadqueue test suite - be correct about volatile+padding
fill in the padding of mesages (10 bytes) with something so valgrinds
can be happy and use vlatiole for msgs count as the msgs num should
have been incremented already before the msg sned is done and main
thread/loop gets the msg
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 04:42:50 +0000 (13:42 +0900)]
eina_threadqueue - fix const ptr warning on spinlocks if atomic disabled
atomics SHOULDNT be disabled anyway, but if they are... fix this
warning. (no real bug)
Carsten Haitzler (Rasterman) [Fri, 5 Aug 2016 04:40:30 +0000 (13:40 +0900)]
ecore_imf - fix make check to doa "load all" check after de-sillifying it
this should make ecore_imf testable with empty env vars also meaning
no env var and the make check test will now ensuree this is set to
exactly test this.
Jean-Philippe Andre [Fri, 5 Aug 2016 02:33:01 +0000 (11:33 +0900)]
ecore_imf: Fix crash when ECORE_IMF_MODULE is set
Jean-Philippe Andre [Fri, 5 Aug 2016 01:59:48 +0000 (10:59 +0900)]
evas: Make safety check more lenient
This is to avoid ERR messages such as "object is not an image!"
that can happen when a legacy image function is called on an
eo image (proxy, 3d, ...) object.
Note: This does not fix any known issue, but it's probably a safer
solution.
Jean-Philippe Andre [Thu, 4 Aug 2016 10:37:56 +0000 (19:37 +0900)]
efl: Cleanup some code (return values)
This removes some useless code in various places, where the
switch from eo_do() to standard function call was not properly
refactored.
This changes:
type ret = 0;
ret = my_eo_function();
return ret;
To:
return my_eo_function();
Jean-Philippe Andre [Thu, 4 Aug 2016 10:16:18 +0000 (19:16 +0900)]
evas image: Lower ERR message to WRN and fix it
In elm_image, efl_file_get() was called on a legacy Evas Image
object, which generated an ERR message. This was way too much
noise for something that actually works.
It's best not to call efl_file_get/set API on a legacy
object, but it can be convenient for smooth code transitions
from legacy to pure eo.
Also, add safety to those APIs.
Test case: elm_test genlist dnd, start dragging anything.
Jean-Philippe Andre [Thu, 4 Aug 2016 10:08:24 +0000 (19:08 +0900)]
evas: Mark image fill_spread as deprecated
It was never implemented.
Jean-Philippe Andre [Thu, 4 Aug 2016 10:01:21 +0000 (19:01 +0900)]
evas: Add safety checks to evas image legacy APIs
This checks for NULL and ensures the type is evas image.
Daniel Kolesa [Thu, 4 Aug 2016 15:45:34 +0000 (16:45 +0100)]
docs: make dark theme default, add switch --graph-theme-light
Daniel Kolesa [Thu, 4 Aug 2016 15:43:02 +0000 (16:43 +0100)]
docs: add default dark theme (via --graph-theme-dark) in docgen
Marcel Hollerbach [Thu, 4 Aug 2016 15:02:46 +0000 (17:02 +0200)]
efreet: free fallback cache on shutdown
this fixes errors like:
ERR<4864>:eet lib/eet/eet_lib.c:645 eet_shutdown() File '/home/osauser/.cache/efreet/icons___efreet_fallback_localhost.localdomain.eet' is still open 1 times !
@fix
Carsten Haitzler (Rasterman) [Thu, 4 Aug 2016 14:23:30 +0000 (23:23 +0900)]
elm tooltips - fix positioning cornercases
this should fix T4277
Stefan Schmidt [Thu, 4 Aug 2016 10:43:27 +0000 (12:43 +0200)]
mailmap: update mailmap file now that we have all libs merged
Trying to unify the authors a bit here. And yes, Chris wins the price for the
ridiculous amount of variations he uses.
Daniel Hirt [Thu, 4 Aug 2016 10:13:29 +0000 (13:13 +0300)]
Elm.Entry: use proper theme_set function on edje object
Shouldn't use elm_widget_theme_object_set for handlers/anchors here.
Fixes T4091.
@fix
Carsten Haitzler (Rasterman) [Thu, 4 Aug 2016 09:28:49 +0000 (18:28 +0900)]
edje object shutdown - be far more paranoid about ptrs and order
so we didnt set everything to null after being freed and object sae
freed after some data. do the data frees after objects are deleted so
callbacks cant access null data anyway. this makes this edje shutdown
far more robust and safe. massive improvement in stability i hope.
Carsten Haitzler (Rasterman) [Thu, 4 Aug 2016 09:19:42 +0000 (18:19 +0900)]
edje - fix access to freed data struct during object shutdown
this fixes T4181
Hermet Park [Thu, 4 Aug 2016 07:44:06 +0000 (16:44 +0900)]
elementary widget: actually this is a right fix than
fa4a72d3fcb6a96f6291a0717036b28277c78413
Now rage and enventor both will be fine.
Carsten Haitzler (Rasterman) [Thu, 4 Aug 2016 07:34:40 +0000 (16:34 +0900)]
elm key events/disabling/focus - fix after another disabled widget fix
this fixes key events in rage again after
ea2b5e40485a49b5c5aadae98ed379f1c3cf5f71 broke them. this fixes T4285
Hermet Park [Thu, 4 Aug 2016 06:22:23 +0000 (15:22 +0900)]
efl: fix a neon build break.
We found a some build break problem due to a build system.
In efl configuration, our efl configure enables neon if it's available,
but neon gonna partially turned off on evas compilation if the build system
has a non neon CFLAG option (ie, mfpu=vfpv..). In the end, neon is partially enabled
and it turns out a build break.
It's non-sense but we can't allow this breakage.
There is no way to ignore build system option nor override our neon option perfectly,
so, Let efl package ruled by build system overall.
Subhransu Mohanty [Thu, 4 Aug 2016 00:34:50 +0000 (17:34 -0700)]
edje: updated the start index of vector resource from 1 to 0
Reviewers: cedric, jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4205
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Cedric Bail [Thu, 4 Aug 2016 00:29:31 +0000 (17:29 -0700)]
elementary: keep theme consistent regarding the disabling of odd/even.
This is another patch that should be reverted as soon as we start
7affe8c2047a41a2945cf6c048d59f28c974aa7a and is still a work around
T3086.
Carsten Haitzler (Rasterman) [Wed, 3 Aug 2016 23:17:18 +0000 (08:17 +0900)]
elm image - silence warnings of setting smooth if image is edje
Carsten Haitzler (Rasterman) [Wed, 3 Aug 2016 23:04:57 +0000 (08:04 +0900)]
emotion generic - vlc - make it off by default as 2 video bends is silly
as per bug. requiring by DEFAULT 2 video back ends is rather
rediculous. pick one and the others are optional. you could argue xine
now is barely worth it, but it's stable and works and has proven to be
not any real pain.
gst1 is a more optimal and far more complete/featured backend that the
vlc generic one anyway. vlc generic has the bonus of out-of-process,
but gst1 is pretty stable (unlike the 0.1 backend), so let's not make
peolpe install 2 video backends (or possibly 3 or more) just to build
efl out of the box.
this fixes T4284
Andy Williams [Wed, 3 Aug 2016 22:43:23 +0000 (23:43 +0100)]
Fix further text checks in Elm_Code T4264
An incorrect assumption in how unused memory may be initialised
@fix
Cedric Bail [Wed, 3 Aug 2016 19:01:17 +0000 (12:01 -0700)]
emotion: fix autodetection of emotion generic vlc player module.
T4273