Stephane Delcroix [Thu, 18 Oct 2018 08:54:24 +0000 (10:54 +0200)]
Merge branch '3.3.0' into 3.4.0
E.Z. Hart [Thu, 18 Oct 2018 08:23:31 +0000 (02:23 -0600)]
Bump minimum Microsoft.NETCore.UniversalWindowsPlatform version to 6.0.12 (#4106)
Stephane Delcroix [Thu, 18 Oct 2018 07:02:09 +0000 (09:02 +0200)]
[Xaml] don't swallow exceptions from converters (#4100)
Compiled converters are invoked, by reflection, at compile time. Any
exception thrown there will be wrapped in a TargetInvocationException.
When that happens, we still want to expose the inner XamlParseException
to the user.
- fixes #4099
Rui Marinho [Wed, 17 Oct 2018 12:04:39 +0000 (13:04 +0100)]
[macOS] Fix NRE on Mojave when aligning the tile (#4086) fixes #3031
ShaneN [Tue, 16 Oct 2018 16:15:48 +0000 (10:15 -0600)]
Merge branch '3.3.0'
Andrei [Tue, 16 Oct 2018 15:45:46 +0000 (18:45 +0300)]
[Sample] [Android] Fixed PagesGallery.Droid build (#3999)
* fixed PagesGallery.Droid build
* Moved Xamarin.Forms.Platform.Android (Forwarders) reference to previous place
* updated project guid to lower case
Stephane Delcroix [Tue, 16 Oct 2018 15:10:04 +0000 (17:10 +0200)]
[Xaml] fix Namescope being different than tree (#4089)
As part of #2556, the namescoping tree was assumed to be equiv to the
object tree, which is obviously wrong. This fixes it, while keeping the
old behavior as a fallback.
We might go further, but I can't come up with a reasonable scenario
failing.
- fixes #3821
Stephane Delcroix [Tue, 16 Oct 2018 07:25:17 +0000 (09:25 +0200)]
[Xaml] Allow OnPlat markup in Styles (#3995)
- fixes #3862
Andrei [Mon, 15 Oct 2018 23:03:01 +0000 (02:03 +0300)]
Prevented crash https://github.com/xamarin/Xamarin.Forms/issues/2291 (#4072)
- fixes #2291
Andrei [Mon, 15 Oct 2018 20:19:38 +0000 (23:19 +0300)]
fixed ios editor placeholder font (#4009)
WonYoung Choi [Mon, 15 Oct 2018 15:42:54 +0000 (00:42 +0900)]
[Tizen] Cleanup Code (#4080)
Andrei N [Sun, 14 Oct 2018 00:53:46 +0000 (03:53 +0300)]
Added WebView Reload (#4013) fixes #3776
* Added WebView Reload
* WebView Reload Added Tizen suport
Stuart Lang [Fri, 12 Oct 2018 19:50:37 +0000 (20:50 +0100)]
Correct minor typo (#4068)
Rui Marinho [Thu, 11 Oct 2018 15:58:46 +0000 (11:58 -0400)]
Merge branch '3.3.0'
Rui Marinho [Thu, 11 Oct 2018 15:43:18 +0000 (11:43 -0400)]
[Tizen] Fix ProjectGuid for Forwarders (#4063)
* [Tizen] Fix ProjectGuid for Forwarders
* [Tizen] Make sure not to generate dependency file
Rui Marinho [Thu, 11 Oct 2018 14:24:03 +0000 (10:24 -0400)]
[UITests] Update TestCloud.Agent (#4055)
Stephane Delcroix [Thu, 11 Oct 2018 13:22:46 +0000 (09:22 -0400)]
Merge branch '3.3.0'
Stephane Delcroix [Thu, 11 Oct 2018 13:00:33 +0000 (09:00 -0400)]
[Tasks] multitarget the build tasks (#3895)
- fixes #2690
- closes #2706
Seungkeun Lee [Wed, 10 Oct 2018 17:12:42 +0000 (02:12 +0900)]
[Tizen] Add TabIndex implement for Tizen renderer (#4046)
Ryan Robidou [Tue, 9 Oct 2018 13:18:21 +0000 (06:18 -0700)]
[UWP] Document in the README.md the steps required to run UI Tests (#4014) fixes #3984
Stephane Delcroix [Tue, 9 Oct 2018 01:59:53 +0000 (03:59 +0200)]
[Xaml[C]] resolve Extensions first (#3977)
XamlLoader should first look for type with the Extension suffix. It used
to be the case, but somehow regressed.
- fixes https://github.com/xamarin/Xamarin.Forms/issues/3606#issuecomment-
422377338
Stephane Delcroix [Tue, 9 Oct 2018 01:58:35 +0000 (03:58 +0200)]
[XamlC] don't compile bindings with Source (#3978)
Sources are usually x:reference that can't be resolved at compilation
time.
- fixes #3606
Stephane Delcroix [Mon, 8 Oct 2018 20:40:31 +0000 (16:40 -0400)]
update GitInfo
kingces95 [Mon, 8 Oct 2018 12:57:20 +0000 (02:57 -1000)]
add pdb for uap into nuget (#4015)
Stephane Delcroix [Mon, 8 Oct 2018 12:46:26 +0000 (08:46 -0400)]
Merge branch '3.3.0'
Jay Cho [Fri, 5 Oct 2018 18:10:09 +0000 (03:10 +0900)]
Fix ActivityIndicator.IsRunning state (#4007)
Andoni Morales Alastruey [Fri, 5 Oct 2018 01:24:22 +0000 (03:24 +0200)]
[GTK] Fix transparent background in visual elements (#3744)
Javier Suárez Ruiz [Thu, 4 Oct 2018 22:08:38 +0000 (00:08 +0200)]
Fixed NotImplementedException refreshing items in WPF ListView (#3962)
* Fixed NotImplementedException refreshing items in WPF ListView
* Small changes in ListView events subscription
fixes #3309
fixes #3737
fixes #3648
Samantha Houts [Thu, 4 Oct 2018 21:58:34 +0000 (14:58 -0700)]
[iOS] Add ability to turn off updates to native controls from another thread (#3774)
* [iOS] Add ability to turn off updates to native controls from another thread
* Flip evaluation order
fixes #1755
Stephane Delcroix [Thu, 4 Oct 2018 13:42:38 +0000 (15:42 +0200)]
[C] add CSS mapping for max-lines (#3991)
- fixes #3982
Andrei [Wed, 3 Oct 2018 21:56:33 +0000 (00:56 +0300)]
Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842)
* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840
- fixes #3840
* fixe formatting
* [UITest] added UI Test
* [Controls] adjusted UI Test button positions
* [UITEST] simplify UI tests
Samantha Houts [Wed, 3 Oct 2018 16:54:46 +0000 (09:54 -0700)]
Add CODEOWNERS
Viridovics [Wed, 3 Oct 2018 16:05:52 +0000 (19:05 +0300)]
Fix Issue2597 Needs UI Test (#3966)
* Add test for issue 2597
* Fix space
lewcianci [Wed, 3 Oct 2018 07:25:30 +0000 (17:25 +1000)]
Fix typos (mainly 'toogle' becoming 'toggle') (#3975)
Stephane Delcroix [Wed, 3 Oct 2018 00:05:09 +0000 (02:05 +0200)]
[XamlC] avoid multiple subscription (#3969)
Avoid multiple subscription to PropertyChanged on TypedBindings
- fixes #3613
- fixes #3650
Rui Marinho [Tue, 2 Oct 2018 22:37:51 +0000 (23:37 +0100)]
Merge branch '3.3.0' to master
Rui Marinho [Tue, 2 Oct 2018 22:34:32 +0000 (23:34 +0100)]
Merge branch '3.2.0' into 3.3.0
Viridovics [Tue, 2 Oct 2018 21:56:51 +0000 (00:56 +0300)]
Fix UI test B43941 (#3889)
* Add all platforms and remove non-deterministic behaviour
* Return back correct check of counter
* Endline fix
* remove childPages list
ShaneN [Tue, 2 Oct 2018 19:09:27 +0000 (13:09 -0600)]
Merge branch '3.3.0'
E.Z. Hart [Tue, 2 Oct 2018 19:04:48 +0000 (13:04 -0600)]
[Android] If MaxLines is not explicitly set, let LineBreakMode handle it (#3936)
* [Android] If MaxLines is not explicitly set, all LineBreakMode to set it;
if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable
default for native MaxLines when handling it via LineBreakMode. Consolidate
MaxLines handling code between legacy and fast renderers. Remove unnecessary
setting of SingleLine (which only applies to input).
- fixes #3772
* Remove unnecessary maxLines setting
* Handle resetting MaxLines to -1/default
* Reinstate workaround for array bounds exception in older Android APIs
Andoni Morales Alastruey [Tue, 2 Oct 2018 18:45:16 +0000 (20:45 +0200)]
[GTK] Fix visibility of hidden pages in the stack (#3904)
When navigating to a new page, we should hide the previous
content and show the new one so that the previous page
renderer is not taken in account for redraws and resizes
Jeremy Marcus [Tue, 2 Oct 2018 18:04:51 +0000 (14:04 -0400)]
Make GetIconDrawable virtual (#3967)
By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs.
adrianknight89 [Tue, 2 Oct 2018 17:34:12 +0000 (12:34 -0500)]
Automate UI test 35127 (#3927)
* automate test
- fixes #2262
* indentation fix
* indentation fix 2
Javier Suárez Ruiz [Tue, 2 Oct 2018 10:57:40 +0000 (12:57 +0200)]
Added logic to allow set the ListView SelectedIndex (#3948) fixes #3766
Shane Neuville [Tue, 2 Oct 2018 07:43:53 +0000 (01:43 -0600)]
Only set the Page Padding via SafeAreaInset on iOS (#3811)
* only set the Page Padding via SafeAreaInset on iOS
-fixes #3809
* [Controls] add waits for clicks in ui tests
* [Controls] remove wrong category
* [iOS] Move inset logic down into ios renderer
Javier Suárez Ruiz [Tue, 2 Oct 2018 06:58:50 +0000 (08:58 +0200)]
Changes in TableView GTK Control to allow refresh the content (#3941)
- fixes #3725
ShaneN [Tue, 2 Oct 2018 01:14:48 +0000 (19:14 -0600)]
Merge 3.2.0 into 3.3.0
Shane Neuville [Mon, 1 Oct 2018 17:53:47 +0000 (11:53 -0600)]
[iOS] fix full width issues for TitleView (#3939)
* [iOS] fix full width issues for TitleView
* [iOS] simplified iOS 10
fixes #3881
fixes #3679
Viridovics [Mon, 1 Oct 2018 17:47:34 +0000 (20:47 +0300)]
Fix UI test B41424 needs instructions (#3942)
* Add manual test steps and checks for ui test
* step4Label text fix
Pavel Yakovlev [Mon, 1 Oct 2018 17:23:37 +0000 (20:23 +0300)]
[UWP] fixes flyout menu on cell item (#3682)
adrianknight89 [Mon, 1 Oct 2018 17:19:51 +0000 (12:19 -0500)]
added instructions (#3926)
Adam Barath [Mon, 1 Oct 2018 17:19:22 +0000 (19:19 +0200)]
Fix bugzilla60787 (#3933)
* [Android]Fix for frame renderer's bug (bugzilla 60787).
#3902
https://bugzilla.xamarin.com/show_bug.cgi?id=60787
https://github.com/xamarin/Xamarin.Forms/issues/3902
* Add control to repro
* PR fix
* Build fix
* Build fix for Xamarin.Forms.Core.Android.UITests
Stephane Delcroix [Mon, 1 Oct 2018 07:00:49 +0000 (09:00 +0200)]
Merge branch '3.3.0'
adrianknight89 [Sat, 29 Sep 2018 11:36:25 +0000 (06:36 -0500)]
Automate UI test B45702 (#3914) fixes #2389
* automate 45702
* fix indentation
Stephane Delcroix [Fri, 28 Sep 2018 20:25:32 +0000 (22:25 +0200)]
[C] catch AmbiguousMatchException on GetProps (#3915)
- fixes #3870
E.Z. Hart [Fri, 28 Sep 2018 18:31:16 +0000 (12:31 -0600)]
Update ClipBounds when View bounds changes (#3909)
fixes #3717
adrianknight89 [Fri, 28 Sep 2018 18:28:05 +0000 (13:28 -0500)]
Fix UI test 39378 (#3928)
fixes #2305
Mohamed CHOUCHANE [Fri, 28 Sep 2018 18:24:54 +0000 (18:24 +0000)]
WPF - Fix TimePicker with short time pattern shows verbose time (#3924)
Rui Marinho [Fri, 28 Sep 2018 16:43:40 +0000 (17:43 +0100)]
[Android] Convert corner radius with correct pixel density (#3893) fixes #3884
* [Controls] Add Issue #3884 repo
* [Android] Convert corner radius with correct pixel density fixes #3884
* [Controls] Update test message
adrianknight89 [Fri, 28 Sep 2018 16:40:40 +0000 (11:40 -0500)]
added instructions (#3891)
- fixes #2361
Mohamed CHOUCHANE [Fri, 28 Sep 2018 16:39:29 +0000 (16:39 +0000)]
Apply font fix for button and span (#3907)
Viridovics [Fri, 28 Sep 2018 16:38:22 +0000 (19:38 +0300)]
Fix StartTimer and Ticker for UWP (#3911)
- fixes #1937
Mohamed CHOUCHANE [Fri, 28 Sep 2018 15:00:39 +0000 (15:00 +0000)]
[WPF] Fix Height of items not consistent (#3925) fixes #3913
Mohamed CHOUCHANE [Fri, 28 Sep 2018 07:06:38 +0000 (07:06 +0000)]
WPF - Ctrl+A does not select all in WPF password Entry (#3908)
Pavel Yakovlev [Fri, 28 Sep 2018 02:16:11 +0000 (05:16 +0300)]
[UWP] For the Slider default value of step is set to 1000 to match Android. (#3141)
Pavel Yakovlev [Thu, 27 Sep 2018 20:36:44 +0000 (23:36 +0300)]
[UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (#3896)
* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper
* common code moved to VisualElementRenderer
* rename interface
fixes #3872
adammeaney [Thu, 27 Sep 2018 18:13:30 +0000 (13:13 -0500)]
Added a disabled look to Android Toolbar Item images. (#3773)
* Added a disabled look to Android Toolbar Item images.
* Update NavigationPageRenderer.cs
Refactored DisabledToolbarAlpha into a constant as requested.
E.Z. Hart [Thu, 27 Sep 2018 18:11:33 +0000 (12:11 -0600)]
[Android] Make native Android Platforms accessible via Context (#3364)
* Make native Android Platforms accessible via Context
* Add null checks
adrianknight89 [Thu, 27 Sep 2018 16:21:24 +0000 (11:21 -0500)]
[Android] Fix UI test 1851 (#3882)
* add preserve attribute
- fixes #2255
* added using System
* fixed spacing
* use TestContentPage
* fixed scope issues
Stephane Delcroix [Thu, 27 Sep 2018 14:50:50 +0000 (16:50 +0200)]
[C] fix css mapping (#3919)
Viridovics [Wed, 26 Sep 2018 17:19:08 +0000 (20:19 +0300)]
Fix Bugzilla38723 (#3812)
fixes #2302
Mohamed CHOUCHANE [Wed, 26 Sep 2018 13:13:04 +0000 (13:13 +0000)]
WPF - Fix Unable to intercept back button (#3762)
* WPF - Fix Unable to intercept back button
* WPF - Improve OnBackButtonPressed
-fixes #3689
Rui Marinho [Wed, 26 Sep 2018 12:06:14 +0000 (13:06 +0100)]
[Controls] Fix merge remove duplciated issue 3788
Rui Marinho [Wed, 26 Sep 2018 11:19:50 +0000 (12:19 +0100)]
Merge branch '3.3.0'
E.Z. Hart [Wed, 26 Sep 2018 11:16:21 +0000 (05:16 -0600)]
Prevent double time/date picker dialogs on Android when setting focus (#3899)
E.Z. Hart [Wed, 26 Sep 2018 11:16:21 +0000 (05:16 -0600)]
Prevent double time/date picker dialogs on Android when setting focus (#3899)
Stephane Delcroix [Wed, 26 Sep 2018 09:22:45 +0000 (11:22 +0200)]
[CSS] accept 'oblique' for 'font-style' (#3815) fixes #3808
- fixes #3808
Rui Marinho [Wed, 26 Sep 2018 09:21:05 +0000 (10:21 +0100)]
[Core] Moving Command's CanExecuteChanged to use the WeakEventManager (#3852) fixes #3656
* [Core] Use WeakEventManager on CanExecuteChanged
* [Core]Add unit test for remove event handler with WeakEventManager
* [Core] Fix remove the correct handler
adrianknight89 [Wed, 26 Sep 2018 09:09:21 +0000 (04:09 -0500)]
added preserve attribute (#3876) fixes #2306
Chris King [Wed, 26 Sep 2018 01:29:17 +0000 (15:29 -1000)]
add comments to .create-nuget.bat
adrianknight89 [Tue, 25 Sep 2018 20:36:50 +0000 (15:36 -0500)]
[Enhancement] Create a bindable property for AutomationId (#3879)
* create a bindable property for automationId
* make ClassId and AutomationId properties of Element
adrianknight89 [Mon, 24 Sep 2018 20:26:07 +0000 (15:26 -0500)]
[Android] Enable MaxLines and TextDecorations on fast renderers (#3878)
* enable MaxLines on fast renderers
* added text decoration functionality
* include test in project
Rui Marinho [Mon, 24 Sep 2018 16:32:34 +0000 (17:32 +0100)]
Merge branch '3.3.0'
Rui Marinho [Mon, 24 Sep 2018 11:48:11 +0000 (12:48 +0100)]
Merge branch '3.2.0' into 3.3.0
E.Z. Hart [Mon, 24 Sep 2018 11:46:32 +0000 (05:46 -0600)]
Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603
* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it
* Remove `RemoveAllViews` from `Dispose`
Stephane Delcroix [Mon, 24 Sep 2018 07:03:49 +0000 (09:03 +0200)]
Merge branch '3.3.0'
Stephane Delcroix [Mon, 24 Sep 2018 07:03:08 +0000 (09:03 +0200)]
Merge branch '3.2.0' into 3.3.0
Matthew Richardson [Wed, 27 Jun 2018 10:30:27 +0000 (11:30 +0100)]
Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097
Rui Marinho [Fri, 21 Sep 2018 16:11:11 +0000 (17:11 +0100)]
[Build] Fix merge
Rui Marinho [Fri, 21 Sep 2018 15:26:39 +0000 (16:26 +0100)]
Merge branch '3.3.0'
Andoni Morales Alastruey [Thu, 20 Sep 2018 19:11:20 +0000 (21:11 +0200)]
Fix spaces to tabs indentation to match the coding style (#3745)
jcmanke [Thu, 20 Sep 2018 17:06:39 +0000 (12:06 -0500)]
[Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)
* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted
* Changed _webViewClient and GetWebViewClient() method to return base class
* Changed public things to protected internal
Stephane Delcroix [Thu, 20 Sep 2018 17:05:33 +0000 (19:05 +0200)]
[A] do not draw gradient for empty CornerRadius (#3786)
Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.
This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25
- fixes #3781
Rui Marinho [Thu, 20 Sep 2018 15:08:21 +0000 (16:08 +0100)]
Merge branch '3.2.0' into 3.3.0
Shane Neuville [Thu, 20 Sep 2018 04:07:05 +0000 (22:07 -0600)]
[Core] Propagate BindingContext changes to TitleView (#3823)
* [Core] Propagate BindingContext changes to TitleView
* [Tests] Move UI test to Core Unit Test
Shane Neuville [Thu, 20 Sep 2018 04:06:51 +0000 (22:06 -0600)]
[UITests] replace awaits with more reliable WaitForElement (#3835)
Rui Marinho [Wed, 19 Sep 2018 21:06:37 +0000 (22:06 +0100)]
[iOS] Use UIApperance default color for UISwitch (#3819)
* [Controls] Set default color of UISwitch to Red
* [iOS] Use default color from Apperance API
Shane Neuville [Wed, 19 Sep 2018 18:46:38 +0000 (12:46 -0600)]
[UWP] implement Replace without reloading ListView (#3792)
-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace
Rui Marinho [Wed, 19 Sep 2018 16:55:33 +0000 (17:55 +0100)]
[UITest] Update Xamarin UITest packages
Rui Marinho [Wed, 19 Sep 2018 11:08:21 +0000 (12:08 +0100)]
[UITests] Isolate test 3408