Jonas Ådahl [Wed, 12 Mar 2014 21:08:41 +0000 (22:08 +0100)]
udev-seat: Make udev_input own its own udev object reference
No functional changes; API simplification in preparation for multiple
input backends.
Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
Jonas Ådahl [Wed, 12 Mar 2014 21:08:40 +0000 (22:08 +0100)]
udev-seat: Make udev_seat_get_named take struct udev_input pointer
No functional changes; API generalization in preparation for multiple
input backends.
Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
Neil Roberts [Fri, 7 Mar 2014 18:05:50 +0000 (18:05 +0000)]
Add support for having different GBM formats for different outputs
The gbm-format configuration option can now be specified per-output as
well as in the core config section. If it is not specified it will
default to the format specified in the core section. The
EGL_MESA_configless_context extension is required for this to work. If
this extension is available it will create a context without an
EGLConfig and then it will potentially use a different EGLConfig for
each output.
The gl-renderer interface has been changed so that it takes the EGL
attributes and visual ID in the create_output function as well as in
the create function.
Neil Roberts [Fri, 7 Mar 2014 18:05:49 +0000 (18:05 +0000)]
Split gl_renderer_setup into two functions
Part of the gl_renderer_setup function only deals with checking EGL
extensions and doesn't need to have a current context. This patch
moves these checks so that they are done during gl_renderer_create
instead of waiting until we have an output. We will need this in a
later patch because some of the EGL extensions will affect how we
create the EGLSurface.
Kristian Høgsberg [Mon, 10 Mar 2014 20:41:35 +0000 (13:41 -0700)]
x11-backend: Override scale from weston.ini if --scale is passed
This matches our behavior for width and height, and is useful for launching
weston with a different scale factor without editing the .ini file.
Jason Ekstrand [Fri, 7 Mar 2014 21:29:14 +0000 (15:29 -0600)]
x11-backend: Add a --scale option
Jason Ekstrand [Wed, 26 Feb 2014 03:54:59 +0000 (21:54 -0600)]
Fix the pixman renderer with respect to output transforms
Commit
fa1b3055 introducted a regression in the pixman renderer. In
particular, it would not draw properly with any output transform other
than normal, 180, 180-flipped, or 270-flipped. This patch fixes this
regression. The weston-scalar program appears to work normally at all
rotations with this patch. Therefore, this patch should fix the regression
while maintaining the added functionality from
fa1b3055.
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Kristian Høgsberg [Wed, 19 Feb 2014 18:24:46 +0000 (10:24 -0800)]
xdg-shell: Improve documentation for use_unstable_version request
Clarify that this is for catching protocol mismatch while the protocol
is under development.
Kristian Høgsberg [Wed, 19 Feb 2014 18:14:46 +0000 (10:14 -0800)]
xdg-shell: Bump unstable version to 3
Kristian Høgsberg [Wed, 19 Feb 2014 07:28:09 +0000 (23:28 -0800)]
shell: Consolidate state changes into xdg_surface_change_state
This makes xdg_surface_change state the canonical place for changing
surface state and moves much of the duplicated code into one place.
Jasper St. Pierre [Sat, 8 Feb 2014 23:29:49 +0000 (18:29 -0500)]
xdg-shell: Replace the set_* atrocity with a new approach
Rather than require that the client implement two methods for every state,
simply have one global request, change_state, and one global event,
request_change_state.
Jasper St. Pierre [Wed, 19 Feb 2014 00:48:12 +0000 (19:48 -0500)]
weston.ini.in: Update path to weston-flower
Ever since the autotools flattening, the launcher for weston-flower
contained an incorrect path...
Jasper St. Pierre [Sat, 8 Feb 2014 23:11:53 +0000 (18:11 -0500)]
xdg-shell: Rename focused_set / focused_unset to activated / deactivated
To try and make the distinction between this event and keyboard focus.
Jasper St. Pierre [Sat, 8 Feb 2014 23:31:10 +0000 (18:31 -0500)]
clients: Add delete handler for simple-shm / simple-egl
It seems this was forgotten in the port.
Jasper St. Pierre [Wed, 19 Feb 2014 00:18:42 +0000 (19:18 -0500)]
clients: Add support for the minimize button
Jasper St. Pierre [Sat, 1 Feb 2014 23:35:15 +0000 (18:35 -0500)]
Reorder the xdg_shell implementations to fit the spec'd order
Jasper St. Pierre [Mon, 10 Feb 2014 18:22:34 +0000 (13:22 -0500)]
window: Remove window_location enum
It's unused except for one easily-replaceable place.
Jasper St. Pierre [Mon, 10 Feb 2014 18:21:45 +0000 (13:21 -0500)]
xdg-shell: Remove "edges" from description
The parameter was dropped...
Emilio Pozuelo Monfort [Mon, 10 Feb 2014 15:52:33 +0000 (16:52 +0100)]
exposay: avoid needlessly activating the active view
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Emilio Pozuelo Monfort [Mon, 10 Feb 2014 15:52:32 +0000 (16:52 +0100)]
toytoolkit: avoid unnecessary redraws when focus changes
Clients that need to be redrawn when the focus changes do that by
listening to focus_changed and scheduling a redraw.
This was causing unnecessary redraws in the clients, as could be
easily seen by changing focus on weston-flower.
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Emilio Pozuelo Monfort [Mon, 10 Feb 2014 13:23:04 +0000 (14:23 +0100)]
exposay: don't crash if a view goes away
When a view was destroyed while we were on exposay, we didn't
remove it from the list of views, and so when leaving exposay
we were trying to animate (and sometimes activate) a
non-existent view, causing a crash.
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Emilio Pozuelo Monfort [Mon, 10 Feb 2014 12:22:32 +0000 (13:22 +0100)]
exposay: arrange views per-output
https://bugs.freedesktop.org/show_bug.cgi?id=73173
Nobuhiko Tanibata [Mon, 10 Feb 2014 03:15:11 +0000 (12:15 +0900)]
Improvement of weston.ini.man. Add key:shell and remove tablet-shell
Add description of key:shell to CORE SECTION and move a example of desktop-shell from key:modules to key:shell.
Add cms-colord.so to key:modules of CORE SECTION.
Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp>
Emilio Pozuelo Monfort [Fri, 7 Feb 2014 08:34:48 +0000 (09:34 +0100)]
tests: Properly report skipped tests
We were calling exit(0) when tests were skipped, which counted
them as passed instead of skipped. Fix this by properly exiting
with 77 (which is what automake expects for skipped tests) from
the tests themselves, then returning 77 again from weston-test-runner
if all the tests were skipped. Finally the weston-test.so module
catches weston-test-runner's exit code and uses it as an exit code,
which is what automake will see and use.
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Emilio Pozuelo Monfort [Fri, 7 Feb 2014 08:34:47 +0000 (09:34 +0100)]
tests: use the headless backend to run the test suite
Other backends can be used by passing BACKEND=some-backend.so, e.g.
$ make check BACKEND=x11-backend.so
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Emilio Pozuelo Monfort [Fri, 7 Feb 2014 08:34:46 +0000 (09:34 +0100)]
tests: Skip buffer-count if EGL initialization fails
That is the case when using the headless backend. In the future
we may be able to use the mesa null egl platform but for now let's
just skip it.
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Emilio Pozuelo Monfort [Fri, 7 Feb 2014 08:34:45 +0000 (09:34 +0100)]
noop-renderer: Read the shm buffer contents on attach
The noop-renderer doesn't read buffer contents, which means bad
buffers go undetected. Thus, read the buffer contents just for
the purpose of triggering SIGBUS (and having the client killed).
Fixes the bad-buffer test when run against the headless backend.
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Emilio Pozuelo Monfort [Fri, 7 Feb 2014 08:34:44 +0000 (09:34 +0100)]
noop-renderer: Set the buffer size on attach requests
This lets the compositor know the size of the surface as calculated
in weston_surface_set_size_from_buffer(), and fixes a couple of
tests when using the headless backend.
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Emilio Pozuelo Monfort [Fri, 7 Feb 2014 08:34:43 +0000 (09:34 +0100)]
compositor-headless: create input devices
Fixes a segfault when using compositor-headless for the test suite
as many tests assume there are input devices and try to use them
through the wl_test interface.
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Kristian Høgsberg [Thu, 6 Feb 2014 01:14:42 +0000 (17:14 -0800)]
input: Send leave and enter pair when the surface moves under the cursor
The client needs to know that the pointer is at a different position in
its surface. We can't send motion as that corresponds to the pointer
actually moving. Leaving the surface and entering at the new position
is a better semantic match and doesn't correspond to pointer motion
or user input.
https://bugs.freedesktop.org/show_bug.cgi?id=71927
Kristian Høgsberg [Wed, 12 Feb 2014 17:56:19 +0000 (09:56 -0800)]
shell: Use the per-client responsiveness tracking for wl_shell as well
Kristian Høgsberg [Wed, 12 Feb 2014 00:35:22 +0000 (16:35 -0800)]
compositor: Drop core ping_handler callout
This was always a little iffy. At least it could have been a signal,
but we now have focus signal, so lets just use that. We lose
the ability to detect unresponsive clients at key event time, but we
could add that back by adding a key_signal.
Kristian Høgsberg [Tue, 11 Feb 2014 22:23:19 +0000 (14:23 -0800)]
build: List xdg protocol files as nodist SOURCEs
Kristian Høgsberg [Tue, 11 Feb 2014 22:21:39 +0000 (14:21 -0800)]
build: Link to libshared.la instead of adding to SOURCES
libshared.la is just os-compat, the option and config parser, so let's
link to that instead of adding the os-compat files to all these targets.
Kristian Høgsberg [Tue, 11 Feb 2014 21:50:08 +0000 (13:50 -0800)]
client: Fix shell unstable version check
Use a static assert to catch mismatch between implementation and
interface version. Fix window.c to not use XDG_SHELL_VERSION_CURRENT,
which will fail to catch version mismatches. The implementation version
must updated manually when the implementation is updated to use the new
interface.
Kristian Høgsberg [Tue, 11 Feb 2014 20:22:51 +0000 (12:22 -0800)]
xdg-shell: Move "ping" and "pong" to xdg_shell, not xdg_surface
Responsivenes is a per-client thing so we move the ping/pong functionality
to xdg_shell. Having this per-window was carries over from the EWMH
protocol, where the WM has no other way to do this. In wayland, the
compositor can directly ping the client that owns the surface.
Mariusz Ceier [Sat, 8 Feb 2014 19:11:24 +0000 (20:11 +0100)]
Don't crash when eglCreateContext fails
eglCreateContext fails with every EGLConfig that
nvidia blob 334.16 provides causing NULL pointer
dereference in gl_renderer_destroy when destroying
fragment and fan bindings.
https://bugs.freedesktop.org/show_bug.cgi?id=74699
Signed-off-by: Mariusz Ceier <mceier+wayland@gmail.com>
Kristian Høgsberg [Sat, 8 Feb 2014 01:01:57 +0000 (17:01 -0800)]
clients: Port simple-shm and simple-egl to xdg-shell
Jasper St. Pierre [Thu, 6 Feb 2014 20:43:19 +0000 (15:43 -0500)]
Update .gitignore
Jasper St. Pierre [Sat, 1 Feb 2014 23:36:41 +0000 (18:36 -0500)]
xdg-shell: Add set_margin request
This is used to figure out the size of "invisible" decorations, which we'll
use to better know the visible extents of the surface, which we can use for
constraining, titlebars, and more.
Jasper St. Pierre [Sat, 1 Feb 2014 23:17:34 +0000 (18:17 -0500)]
xdg-shell: Add a "delete" event
This is equivalent to WM_DELETE_WINDOW request under X11, or equivalent
to pressing the "close" button under CSD. Weston currently doesn't have
a compositor-side way to close the window, so no new code is needed on
its side.
Kristian Høgsberg [Thu, 6 Feb 2014 06:00:59 +0000 (22:00 -0800)]
build: Add missing AM_CFLAGS to client target CFLAGS
Kristian Høgsberg [Thu, 6 Feb 2014 05:36:04 +0000 (21:36 -0800)]
xdg-shell: Drop edges arg from xdg_surface configure event
Jason Ekstrand [Thu, 6 Feb 2014 03:38:27 +0000 (21:38 -0600)]
nested-client: Fix build error
Ander Conselvan de Oliveira [Wed, 29 Jan 2014 16:47:54 +0000 (18:47 +0200)]
compositor: Move view repositioning logic into shell
Remove the listener for output destroy from weston_view and instead
iterate views owned by the shell in its own output destroy listener.
This simplifies the code a bit since keeping the view listening for the
destroy on the right output was a bit complicated. This also removes the
function pointer output_destroyed from weston_view. The only user for it
was desktop shell, but now this is all handled in shell.c.
Ander Conselvan de Oliveira [Wed, 29 Jan 2014 16:47:52 +0000 (18:47 +0200)]
compositor: Remove weston_output::move_signal
Since that signal is per output, it is necessary to track in which
output a view is in so that the signal is handled properly.
Instead, add a compositor wide output moved signal, that is handled by
the shell. The shell iterates over the layers it owns to move views
appropriately.
Emilio Pozuelo Monfort [Thu, 30 Jan 2014 12:49:39 +0000 (13:49 +0100)]
dim-layer: fix dimming for unfocused surfaces
Unfocusing a surface should dim it when dim-layer is enabled,
but this got broken in commit 83ffd9.
Emilio Pozuelo Monfort [Mon, 3 Feb 2014 15:57:27 +0000 (16:57 +0100)]
compositor-rpi: Fix input initialization
The input initialization code assumes the outputs have already
been initialized; thus create the outputs first. This fixes a
segfault upon startup. It is also what the drm and fbdev backends
do.
Bryce W. Harrington [Mon, 3 Feb 2014 21:37:06 +0000 (21:37 +0000)]
README: Fix typo; add link to testing docs
Signed-off-by: Bryce Harrington <b.harrington@samsung.com>
Jason Ekstrand [Wed, 5 Feb 2014 03:36:39 +0000 (21:36 -0600)]
gl-renderer: Use eglSwapBuffersWithDamageEXT when available
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Jason Ekstrand [Wed, 5 Feb 2014 03:36:38 +0000 (21:36 -0600)]
gl-renderer: Track border damage and only repaint borders on an as-needed basis
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Kristian Høgsberg [Thu, 6 Feb 2014 00:53:43 +0000 (16:53 -0800)]
window: Delay scheduled redraws if we start maximize or fullscreen protocol
When we set the fullscreen flag, we have to wait for the corresponding
configure event and then attach a buffer of that size to indicate
that we've successfully gone fullscreen/maximized.
Without this patch, we can schedule a redraw and go through with it after
setting maximize/fullscreen and end up attaching a buffer of the wrong size.
In practice, what happens is that pressing the maximize button triggers
setting maximized, but also triggers a redraw to paint the maxmize button.
Without this change, repainting the button triggers a repaint that attaches
the same size buffer immediately.
https://bugs.freedesktop.org/show_bug.cgi?id=71927
Kristian Høgsberg [Wed, 5 Feb 2014 22:44:04 +0000 (14:44 -0800)]
terminal: Only reset title if we put the window size there
When resizing the terminal, it shows the grid size in the titlebar.
We reset the title next time we get an enter event. This patch makes
sure we only reset the title the first time we enter after a resize.
Kristian Høgsberg [Wed, 5 Feb 2014 22:25:18 +0000 (14:25 -0800)]
input: Run touch binding before calling touch grab
We don't want to send events if the binding is going to handle the touch
event. Also, this restricts touch bindings to only trigger on touch down.
For gesture bindings we want something similar to the motion signal we
have for the pointer.
Kristian Høgsberg [Wed, 5 Feb 2014 21:43:44 +0000 (13:43 -0800)]
window: Ask xkbcommon whether or not to repeat a key
Kristian Høgsberg [Wed, 5 Feb 2014 06:12:29 +0000 (22:12 -0800)]
input: Transform to surface coordinates outside resource for loop
When we send the pointer motion event, the transform from compositor to
surface coordinates doesn't depend on the resource. Transform the
coordinates up front instead of everytime we send to a resource.
Kristian Høgsberg [Wed, 5 Feb 2014 06:44:57 +0000 (22:44 -0800)]
shell: Remove elaborate if-statement with empty body
Kristian Høgsberg [Mon, 3 Feb 2014 23:50:38 +0000 (15:50 -0800)]
shell: Handle wl_shell surfaces created by xwayland correctly
When xwayland creates a shell surface we don't have a resource. The
recently added shell_surface_is_wl_shell/xdg_surface() tests don't
handle that very well.
For now, we assume that a surface without a resource is created from
xwayland and is a wl_shell surface. We'll want to modify that to be a
xdg surface eventually, but for now this stops weston from crashing.
Kristian Høgsberg [Mon, 3 Feb 2014 19:05:41 +0000 (11:05 -0800)]
build: Pass pkg-config CFLAGS as target_CFLAGS, not CPPFLAGS
Kristian Høgsberg [Mon, 3 Feb 2014 18:55:51 +0000 (10:55 -0800)]
build: Add a rule for creating git-version.h when we don't have a git repo
For dist tarballs we ship git-version.h but if you do a git archive or
similar to check out a source tree, there's no git-version.h and no
way to make one.
https://bugs.freedesktop.org/show_bug.cgi?id=74459
Pekka Paalanen [Mon, 3 Feb 2014 11:12:34 +0000 (13:12 +0200)]
build: fix weston-info CFLAGS
CC clients/weston-info.o
clients/weston-info.c:31:28: fatal error: wayland-client.h: No such file or directory
compilation terminated.
make[1]: *** [clients/weston-info.o] Error 1
Only triggerable if libwayland is only in a custom prefix.
Fix by adding CLIENT_CFLAGS.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Pekka Paalanen [Mon, 3 Feb 2014 11:12:33 +0000 (13:12 +0200)]
build: pass client flags to test programs
Fix build failures of the kind:
CC tests/bad-buffer-test.o
In file included from tests/weston-test-client-helper.h:28:0,
from tests/bad-buffer-test.c:28:
./protocol/wayland-test-client-protocol.h:35:28: fatal error: wayland-client.h: No such file or directory
compilation terminated.
make[1]: *** [tests/bad-buffer-test.o] Error 1
These are only triggerable if libwayland has not been installed
system-wide, but only in a custom prefix.
Since the Makefile already uses AM_CPPFLAGS, simply add
TEST_CLIENT_CFLAGS to test programs instead of dropping AM_CPPFLAGS.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Kristian Høgsberg [Sun, 2 Feb 2014 06:16:43 +0000 (22:16 -0800)]
.gitignore: Add .dirstamp
Guillem Jover [Sat, 1 Feb 2014 17:48:43 +0000 (18:48 +0100)]
build: Set a default aux dir
This moves all the auxiliary build scripts into a build-aux directory,
and fixes an issue with configure being unable to find scripts because
it tries to change to an empty directory to get the absolute path,
which results in getting the path to the user's home directory instead.
,--
checking whether build environment is sane... yes
/bin/bash: /home/user/missing: No such file or directory
configure: WARNING: 'missing' script is too old or missing
`---
Signed-off-by: Guillem Jover <guillem@hadrons.org>
Kristian Høgsberg [Sun, 2 Feb 2014 05:52:17 +0000 (21:52 -0800)]
build: Don't dist generated sources
Quentin Glidic [Sat, 1 Feb 2014 20:39:12 +0000 (21:39 +0100)]
Makefile.am: Fix protocol source files usage
Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
Kristian Høgsberg [Sun, 2 Feb 2014 04:44:54 +0000 (20:44 -0800)]
xwayland: Fix typo in open flags for Xorg log file
Kristian Høgsberg [Sat, 1 Feb 2014 19:02:41 +0000 (11:02 -0800)]
build: Add -Wsign-compare to GCC flags
Jasper St. Pierre [Mon, 9 Dec 2013 20:20:16 +0000 (15:20 -0500)]
Revert "stacking: Remove transient window support"
This reverts commit
4c1a11074af2c2221d50b0c35d2d0d883647bc15.
Use the new window_set_transient_for / window_get_transient_for
and xdg-shell support for this...
Jasper St. Pierre [Mon, 9 Dec 2013 20:26:25 +0000 (15:26 -0500)]
window: Add wrappers for xdg_surface_set_transient_for
Jasper St. Pierre [Mon, 9 Dec 2013 19:58:00 +0000 (14:58 -0500)]
westoy: Port the toy toolkit over to xdg-shell
Jasper St. Pierre [Tue, 12 Nov 2013 00:16:11 +0000 (19:16 -0500)]
westoy: Remove MAXIMIZED and FULLSCREEN as separate window types
xdg_shell changes this around so that they are flags on the remote
object itself, not separate surface types. Move to a system where
we calculate the state from the flags ourselves and set the appropriate
wl_shell_surface type.
When we port to xdg_shell, we'll drop these flags and simply sync
on the client.
Jasper St. Pierre [Tue, 12 Nov 2013 00:04:29 +0000 (19:04 -0500)]
westoy: Remove fullscreen methods
These aren't supported under xdg_shell, at least not right now.
If xdg_shell ever gets support for them, we can revert this commit
and adapt it.
Jasper St. Pierre [Tue, 12 Nov 2013 00:42:23 +0000 (19:42 -0500)]
westoy: Use subsurfaces for tooltips instead of transient windows
Transient windows, at least not as they are today, don't exist in
xdg_shell. Subsurfaces allow for specially placed surfaces relative
to a window, so use these instead.
Jasper St. Pierre [Tue, 12 Nov 2013 01:07:33 +0000 (20:07 -0500)]
westoy: Schedule a full resize when we add a subsurface
If a client adds a subsurface, we need to make sure it's allocated
properly, so queue a resize and redraw on the parent window.
Jasper St. Pierre [Mon, 9 Dec 2013 19:52:33 +0000 (14:52 -0500)]
stacking: Remove transient window support
This will be replaced with xdg_surface_set_transient_for at some point...
Jasper St. Pierre [Mon, 9 Dec 2013 22:36:28 +0000 (17:36 -0500)]
weston: Send xdg_surface_send_focused_[un]set when focusing surfaces
Ander Conselvan de Oliveira [Wed, 29 Jan 2014 16:47:51 +0000 (18:47 +0200)]
input: Remove exported function weston_pointer_verify()
Instead, add a compositor signal that an output has been destroyed and
handle that case locally in input.c.
Emilio Pozuelo Monfort [Tue, 28 Jan 2014 12:54:16 +0000 (13:54 +0100)]
desktop-shell: initialize children link
Since commit 9046d2, when destroying a surface, we remove all the
links from its children. But when the child surfaces are destroyed,
those links will be removed again, but since they were not properly
initialized, weston will crash.
Call shell_surface_set_parent instead which removes the link and
sets parent while also initializing the link, thus avoiding this
crash.
Emilio Pozuelo Monfort [Wed, 29 Jan 2014 10:11:12 +0000 (11:11 +0100)]
desktop-shell: maximize the surface with the kbd focus
We don't have focus-follows-mouse, so it makes more sense to
maximize or fullscreen the surface that has the keyboard focus,
not the one behind the pointer.
Guillem Jover [Fri, 31 Jan 2014 19:41:21 +0000 (20:41 +0100)]
compositor: Clarify XDG_RUNTIME_DIR misconfiguration message
If only the mode or the owner are wrong, do not say both are wrong.
Change the text to state that there's a problem and the current
values, and let the user figure it out.
Signed-off-by: Guillem Jover <guillem@hadrons.org>
Ander Conselvan de Oliveira [Fri, 31 Jan 2014 15:35:45 +0000 (17:35 +0200)]
input: Fix weston_seat_init_keyboard() error path
The pointer seat->keyboard was set before some possible error returns.
That pointer was left unchanged in case of failure, pointing to an
uninitialized keyboard struct (that was also leaked). If a client sent
a wl_seat::get_keyboard request, that would cause Weston to crash.
Fix this by setting the seat->keyboard pointer only after the keymap
initialization is done and there is no more possibilities for failure.
Also plug the memory leaks on the error path.
https://bugs.freedesktop.org/show_bug.cgi?id=74035
Ander Conselvan de Oliveira [Fri, 31 Jan 2014 14:07:51 +0000 (16:07 +0200)]
input: Empty the current input region when configuring pointer surfaces
The input region of the cursor surface is set to empty in
pointer_cursor_surface_configure(). Since during the commit process
this function is called before the pending input region is made
current, it empties surface->pending.input instead of surface->input.
But pointer_cursor_surface_configure() is also called from
pointer_set_cursor() in order to map the cursor even if there isn't a
subsequent attach and commit to the cursor surface. In that case,
surface->input is never emptied, since the configure function emptied
only the pending input region and there wasn't a commit that made it
effective.
Fix this by emptying both pending and current input regions. The latter
shouldn't cause problems since the surface can't have a role prior to
being assigned the cursor role, so it shouldn't be mapped in the first
place.
Also change toytoolkit so that it triggers the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=73711
Kristian Høgsberg [Sat, 1 Feb 2014 08:38:15 +0000 (00:38 -0800)]
build: Stop using xmllint to validate protocol files
The scanner needs to be good enough. If it crashes or fails to report
invalid input, that needs to get fixed.
Kristian Høgsberg [Sat, 1 Feb 2014 08:33:04 +0000 (00:33 -0800)]
build: Drop wayland-scanner.mk
We now only have one Makefile.am so we don't need to keep these rules
in a separate file for sharing.
Kristian Høgsberg [Sat, 1 Feb 2014 00:33:48 +0000 (16:33 -0800)]
build: Only regenerate src/git-version.h when .git/logs/HEAD changes
We rely on .git/logs/HEAD to be a file that changes when we commit to HEAD.
The first idea is to make the makefile rule depend on .git/HEAD, but that's
a symbolic ref that points to the current ref in refs/heads. However,
.git/logs/HEAD changes whenever we commit to HEAD, so we can use that in the
makefile rule.
Kristian Høgsberg [Tue, 28 Jan 2014 06:02:41 +0000 (22:02 -0800)]
build: Move shared/Makefile.am into toplevel Makefile.am
Kristian Høgsberg [Sat, 1 Feb 2014 00:15:11 +0000 (16:15 -0800)]
build: Move clients/Makefile.am into toplevel Makefile.am
Kristian Høgsberg [Fri, 31 Jan 2014 22:03:09 +0000 (14:03 -0800)]
build: Move tests/Makefile.am into toplevel Makefile.am
Kristian Høgsberg [Tue, 28 Jan 2014 07:05:52 +0000 (23:05 -0800)]
build: Move src/Makefile.am into toplevel Makefile.am
Kristian Høgsberg [Tue, 28 Jan 2014 06:33:04 +0000 (22:33 -0800)]
build: Move man/Makefile.am into toplevel Makefile.am
Kristian Høgsberg [Tue, 28 Jan 2014 06:26:29 +0000 (22:26 -0800)]
build: Move protocol/Makefile.am into toplevel Makefile.am
Kristian Høgsberg [Tue, 28 Jan 2014 05:59:55 +0000 (21:59 -0800)]
build: Move xwayland/Makefile.am into toplevel Makefile.am
Kristian Høgsberg [Tue, 28 Jan 2014 05:56:12 +0000 (21:56 -0800)]
build: Move desktop-shell/Makefile.am into toplevel Makefile.am
Kristian Høgsberg [Tue, 28 Jan 2014 05:46:30 +0000 (21:46 -0800)]
build: Move wcap/Makefile.am into top-level Makefile.am
Kristian Høgsberg [Tue, 28 Jan 2014 05:40:28 +0000 (21:40 -0800)]
build: Move data/Makefile.am into Makefile.am
Kristian Høgsberg [Sat, 1 Feb 2014 07:49:33 +0000 (23:49 -0800)]
build: Use subdir-objects automake option
This makes automake place the object files in the same subdir as the
source file. For a recursive build system as we have now, there's
no difference, but with a non-recursive build system it means that
the object files don't all end up in the toplevel directory.
Kristian Høgsberg [Fri, 31 Jan 2014 22:39:01 +0000 (14:39 -0800)]
clients: Drop pdf viewer sample client
This doesn't really add anything over the existing sample clients
and only complicates the build system with extra checks for poppler.
Kristian Høgsberg [Tue, 28 Jan 2014 07:02:35 +0000 (23:02 -0800)]
compositor: Fix a couple of #includes to use "" instead of <>
Kristian Høgsberg [Sat, 1 Feb 2014 05:56:21 +0000 (21:56 -0800)]
build: Drop use of rsvg-convert
Just include the png in the repo.