platform/core/csapi/xsf.git
4 years agoRemove GitInfo on build (#122)
윤정현/Common Platform Lab(SR)/Staff Engineer/삼성전자 [Tue, 7 Jan 2020 05:13:51 +0000 (14:13 +0900)]
Remove GitInfo on build (#122)

4 years agoChange Label instance to type in font size for the little performance
pius.lee [Tue, 7 Jan 2020 02:36:25 +0000 (11:36 +0900)]
Change Label instance to type in font size for the little performance

4 years agoRemove the unused properties (#121)
유리나/Common Platform Lab(SR)/Staff Engineer/삼성전자 [Fri, 3 Jan 2020 04:21:22 +0000 (13:21 +0900)]
Remove the unused properties (#121)

* Remove unused property

* Remove the comment

* Change a file mode for SearchHandler

* Apply for the comment

4 years agoAdd Optional feature in InitializeOption (#120)
부정균/Common Platform Lab(SR)/Staff Engineer/삼성전자 [Fri, 27 Dec 2019 08:04:14 +0000 (17:04 +0900)]
Add Optional feature in InitializeOption (#120)

* Add Optional feature in InitializeOption

- add Optional feature of Shell/Style/Visual in InitializeOption class.
- add more static constructor type
- add OptionalFeatureValues class in TizenSpeciffic

* Fix CustomRenderer not applied issue

4 years agoAdd Forms.Init and static Ctors to Forms.Preload (#119)
이비오/Common Platform Lab(SR)/Staff Engineer/삼성전자 [Fri, 20 Dec 2019 06:50:21 +0000 (15:50 +0900)]
Add Forms.Init and static Ctors to Forms.Preload (#119)

create new FormsApplication subclass for linked to lazy lifecycle.
now user can use Interface for lifecycle to implement application
lifecycle.

4 years agoMerge remote-tracking branch 'Xamarin.Forms/master'
Jeongkyun [Thu, 12 Dec 2019 10:26:17 +0000 (19:26 +0900)]
Merge remote-tracking branch 'Xamarin.Forms/master'

4 years ago[Tizen] Provides PlatformType on Init (#338)
허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 [Wed, 11 Dec 2019 07:36:50 +0000 (16:36 +0900)]
[Tizen] Provides PlatformType on Init (#338)

* [Tizen] Provides PlatformType on Init

* Update Xamarin.Forms.Platform.Tizen/Forms.cs

Co-Authored-By: kangho-hur <kangho.hur@samsung.com>
4 years agoMerge branch '4.4.0'
Samantha Houts [Mon, 9 Dec 2019 20:56:54 +0000 (12:56 -0800)]
Merge branch '4.4.0'

4 years agoAdded Converter to simplify the use of Layouts in the CarouselView (#8665)
Javier Suárez Ruiz [Mon, 9 Dec 2019 19:57:38 +0000 (20:57 +0100)]
Added Converter to simplify the use of Layouts in the CarouselView (#8665)

fixes #7813

4 years agoRemove unnecessary Lazy loading (#8798)
Jay Cho [Mon, 9 Dec 2019 15:17:26 +0000 (00:17 +0900)]
Remove unnecessary Lazy loading (#8798)

4 years agoMerge branch '4.4.0'
Rui Marinho [Mon, 9 Dec 2019 10:55:33 +0000 (10:55 +0000)]
Merge branch '4.4.0'

4 years agoMerge branch '4.3.0' into 4.4.0
Rui Marinho [Mon, 9 Dec 2019 10:54:24 +0000 (10:54 +0000)]
Merge branch '4.3.0' into 4.4.0

4 years ago[Tizen] Enhances the Static Registrar (#8775)
Kangho Hur [Fri, 6 Dec 2019 19:58:53 +0000 (11:58 -0800)]
[Tizen] Enhances the Static Registrar (#8775)

4 years agoPrevent ObjectDisposed exception when updating binding for item ejected from recycler...
E.Z. Hart [Fri, 6 Dec 2019 19:33:44 +0000 (12:33 -0700)]
Prevent ObjectDisposed exception when updating binding for item ejected from recycler pool; (#8768) fixes #8435

4 years agoPlatform specific on iOS for setting CanBecomeFirstResponder (#8740) fixes #2136
Shane Neuville [Fri, 6 Dec 2019 19:32:02 +0000 (12:32 -0700)]
Platform specific on iOS for setting CanBecomeFirstResponder (#8740)  fixes #2136

* add ability for visual elements to become first responder

* cleanup page renderer

* added sample code

* Revert "cleanup page renderer"

This reverts commit 7429fd1debf68776a167aef117912c7a38d412e9.

* editor button becomes first responder

* remove extra declaration

* add mobile tag

* - add instructions to UI Test

4 years agoPut SwipeView behind experimental flag (#8786)
Shane Neuville [Fri, 6 Dec 2019 19:00:35 +0000 (12:00 -0700)]
Put SwipeView behind experimental flag (#8786)

* Put SwipeView behind experimental flag

* Update Xamarin.Forms.ControlGallery.Android/FormsAppCompatActivity.cs

4 years agoFixed 5749 - Issue with disabling horizontal scroll on Android (#8105)
Durgesh Khandal [Fri, 6 Dec 2019 17:23:13 +0000 (22:53 +0530)]
Fixed 5749 - Issue with disabling horizontal scroll on Android (#8105)

fixes #5749

4 years ago[iOS] CollectionView crashes on iOS 12 for repeated adds (#8761)
Javier Suárez Ruiz [Fri, 6 Dec 2019 16:58:44 +0000 (17:58 +0100)]
[iOS] CollectionView crashes on iOS 12 for repeated adds (#8761)

* Added repro sample

* Added instructions to the test

4 years agoMerge branch '4.4.0'
Samantha Houts [Fri, 6 Dec 2019 04:21:52 +0000 (20:21 -0800)]
Merge branch '4.4.0'

4 years agoMerge branch '4.3.0' into 4.4.0
Samantha Houts [Fri, 6 Dec 2019 04:21:20 +0000 (20:21 -0800)]
Merge branch '4.3.0' into 4.4.0

4 years agoAdd VSM Setter TargetName (#8144)
Gerald Versluis [Fri, 6 Dec 2019 04:10:08 +0000 (05:10 +0100)]
Add VSM Setter TargetName (#8144)

* Added the ability to Target a bindable object for Setters

Include unit and xaml unit tests
corrected naming to prevent issues
Updating xamlc is still outstanding

* Resolve xamlc compiler with new Target property

* Added ability to find target element via Name

* Remove Target for simplicity

* Additional target type for flexibility while not introducing complexity

* [Core] Remove inline comment

* Added gallery page

* Last bits

* Fixed unit tests

* Update Setter.cs
fixes #4924
closes #5034
closes #5622

4 years ago[Android] Center elements in CarouselView (#8733)
Javier Suárez Ruiz [Fri, 6 Dec 2019 04:08:09 +0000 (05:08 +0100)]
[Android] Center elements in CarouselView (#8733)

* Added repro sample and fix on Android

* Added changes to centered all the items from the CarouselView on Android

* Fixed build error in the added Issue8525

* Renamed issue file

* Fixed build error

* Renamed Issue8525 to Issue8636

* Fixed issues centering carousel items using PeekAreaInsets on Android
fixes #8225
fixes #8638

4 years ago[X] send tree changed events on parenting (#8760)
Stephane Delcroix [Fri, 6 Dec 2019 04:04:49 +0000 (05:04 +0100)]
[X] send tree changed events on parenting (#8760)

so thye will be triggered in all cases

4 years agoMerge branch '4.4.0'
Shane Neuville [Thu, 5 Dec 2019 23:03:41 +0000 (16:03 -0700)]
Merge branch '4.4.0'

4 years agoSdk Extras netcore 2 fix (#8771)
Shane Neuville [Thu, 5 Dec 2019 22:07:26 +0000 (15:07 -0700)]
Sdk Extras netcore 2 fix (#8771)

4 years agoMerge branch '4.3.0' into 4.4.0
Shane Neuville [Thu, 5 Dec 2019 20:37:01 +0000 (13:37 -0700)]
Merge branch '4.3.0' into 4.4.0

# Conflicts:
# Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj

4 years agoRevert back to VS 2017 (#8770)
Shane Neuville [Thu, 5 Dec 2019 20:35:13 +0000 (13:35 -0700)]
Revert back to VS 2017 (#8770)

4 years agoRebase from 4.3.0 branch
Javier Suárez Ruiz [Thu, 5 Dec 2019 20:32:43 +0000 (21:32 +0100)]
Rebase from 4.3.0 branch

4 years agoFix dynamic heights for iOS Flyout Item Templates (#8531) fixes #8290
Shane Neuville [Thu, 5 Dec 2019 12:00:14 +0000 (05:00 -0700)]
Fix dynamic heights for iOS Flyout Item Templates (#8531) fixes #8290

* Fix dynamic heights for iOS Flyout

* - fix default height used

* Apply suggestions from code review

4 years agoAdd name of key in INameScope.RegisterName ArgumentException (#8702)
Gerald Versluis [Thu, 5 Dec 2019 11:24:56 +0000 (12:24 +0100)]
Add name of key in INameScope.RegisterName ArgumentException (#8702)

- fixes #7540

* Update NameScope.cs

* Update Xamarin.Forms.Core/Internals/NameScope.cs

Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
4 years agoUwp thread to task fixes (#8639)
Shane Neuville [Wed, 4 Dec 2019 17:39:53 +0000 (10:39 -0700)]
Uwp thread to task fixes (#8639)

* Convert usages of thread in gallery to Task

* - swap thread for task

* - couple more thread to task fixes

* - remove call to start

4 years agoPrevent UWP NullReferenceException when calling SavePropertiesAsync method off the...
Tomáš Ondřej [Wed, 4 Dec 2019 16:56:23 +0000 (17:56 +0100)]
Prevent UWP NullReferenceException when calling SavePropertiesAsync method off the main thread (#8696)

* Fix Issue 8682

* Rename UI test method

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Return FallbackDispatcher with null-coalescing

4 years agofix #5518 | Frame Tap Gesture not working when using Visual="Material" in iOS (#7988)
Ken Nguyen [Wed, 4 Dec 2019 16:52:52 +0000 (23:52 +0700)]
fix #5518 | Frame Tap Gesture not working when using Visual="Material" in iOS (#7988)

* fix #5518

* - small changes to ui tests

* - fix automationid and ui test

* - fix null ref

4 years ago[iOS] Fixes crash in CollectionViews when using DataTemplateSelector as a DataTemplat...
Mario van Zeist [Wed, 4 Dec 2019 12:52:43 +0000 (13:52 +0100)]
[iOS] Fixes crash in CollectionViews when using DataTemplateSelector as a DataTemplate when used in GroupHeaders and or GroupFooters (#8674)

- fixes #8647

* Added repro and partial fix

* Removed some code in Templated cell to prevent an extension method being called twice.
Modified ItemsViewController to call different bind function. (Removed older one)
Added checks for Header/Footer in groupableItemsViewController.
Some code cleanup

* Removed unittest as I could not get it to run Due to missing Provisioningprofile

* Revert unintended change

* Cleanup some code

4 years ago Fix crash on iOS adding items (ObservableCollection) (#7711) fixes #7678
Javier Suárez Ruiz [Wed, 4 Dec 2019 12:44:09 +0000 (13:44 +0100)]
 Fix crash on iOS adding items (ObservableCollection) (#7711) fixes #7678

4 years agoReverse the order of assigning the Current Items on Shell (#8630)
Shane Neuville [Tue, 3 Dec 2019 21:18:03 +0000 (14:18 -0700)]
Reverse the order of assigning the Current Items on Shell (#8630)

* Failing Unit test for #8624

* - Set Current Item from the bottom up

4 years agoRemove private modifier (#8631)
Youssef Victor [Tue, 3 Dec 2019 18:16:34 +0000 (20:16 +0200)]
Remove private modifier (#8631)

* Remove private modifier

* Update SystemParameters2.cs

* Update SystemParameters2.cs

* Update NativeMethods.cs

* Update ImageCell.cs

* Update TextCell.cs

* Update EntryCell.cs

* Update DatePicker.cs

4 years ago[Tizen] Enhancement EntryRenderer (#8686)
Seungkeun Lee [Tue, 3 Dec 2019 10:37:39 +0000 (19:37 +0900)]
[Tizen] Enhancement EntryRenderer (#8686)

* Enhancement EntryRenderer on Tizen

 - Support ClearButtonVisibility
 - Support ReturnType.Next
 - Limitation No support clearButtonVisibility on TV

* Update ClearButton color

* Remove redundant line

* Remove init value on IsTextBlockFoused

4 years ago[Tizen] Add RefreshView for Tizen (#8697)
Seungkeun Lee [Tue, 3 Dec 2019 10:37:19 +0000 (19:37 +0900)]
[Tizen] Add RefreshView for Tizen (#8697)

* Add RefreshViewRenderer in Tizen

* RefreshView support ListView

* Support RefreshView on WebView

* Review updated

* Fix async method naming

* Update to handle ItemsViewRenderer

* Fix Reload window

4 years ago[Android] Add guard and add missing unsubscribe on MasterDetailPageRenderer (#8704)
Kevin Petit [Tue, 3 Dec 2019 10:36:55 +0000 (11:36 +0100)]
[Android] Add guard and add missing unsubscribe on MasterDetailPageRenderer (#8704)

4 years ago[UITests] Update Xamarin.UITests packages (#8725)
Rui Marinho [Tue, 3 Dec 2019 10:36:34 +0000 (10:36 +0000)]
[UITests] Update Xamarin.UITests packages (#8725)

4 years ago[Android] Better ListViewRenderer dispose (#8705)
Kevin Petit [Tue, 3 Dec 2019 09:56:54 +0000 (10:56 +0100)]
[Android] Better ListViewRenderer dispose (#8705)

4 years agoMerge branch '4.4.0'
Samantha Houts [Tue, 3 Dec 2019 02:20:34 +0000 (18:20 -0800)]
Merge branch '4.4.0'

4 years agoMerge branch '4.3.0' into 4.4.0
Samantha Houts [Tue, 3 Dec 2019 02:17:59 +0000 (18:17 -0800)]
Merge branch '4.3.0' into 4.4.0

4 years agoUpdate MacDeviceInfo.cs (#8561) fixes #8559
Gerald Versluis [Tue, 19 Nov 2019 11:05:18 +0000 (12:05 +0100)]
Update MacDeviceInfo.cs (#8561) fixes #8559

4 years agoWPF GTK Set flags (#8446)
VladislavAntonyuk [Mon, 2 Dec 2019 21:09:43 +0000 (23:09 +0200)]
WPF GTK Set flags (#8446)

* WPF GTK Set flags

* Remove collection view flag

4 years agoMerge branch '4.3.0' into 4.4.0
Rui Marinho [Mon, 2 Dec 2019 19:58:50 +0000 (19:58 +0000)]
Merge branch '4.3.0' into 4.4.0

4 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Mon, 2 Dec 2019 19:20:47 +0000 (19:20 +0000)]
Merge branch '4.2.0' into 4.3.0

4 years agoUpdate nuget release number (#8726)
Rui Marinho [Mon, 2 Dec 2019 19:17:09 +0000 (19:17 +0000)]
Update nuget release number (#8726)

4 years agoFix issue 6878 | [Bug] ShellItem.Items.Clear() crashes when the ShellItem has bottom...
Felipe Baltazar [Mon, 2 Dec 2019 17:35:11 +0000 (14:35 -0300)]
Fix issue 6878 | [Bug] ShellItem.Items.Clear() crashes when the ShellItem has bottom tabs (#8215)

* Fix issue 6878

* Code review ♻

4 years ago[Android] Fix crash adding items to the CollectionView (#7670)
Javier Suárez Ruiz [Mon, 2 Dec 2019 16:20:03 +0000 (17:20 +0100)]
[Android] Fix crash adding items to the CollectionView (#7670)

* Fixed 7510 - Crash adding items to the CollectionView on Android

* Removed code used for testing

4 years ago[Bug] FontImageSourse doesn't work on macOS (#8590) fixes #8469
VladislavAntonyuk [Mon, 2 Dec 2019 10:38:05 +0000 (12:38 +0200)]
[Bug] FontImageSourse doesn't work on macOS (#8590) fixes #8469

* [Bug] FontImageSourse doesn't work on macOS

* revert VS changes

* ExportImageSourceHandler

* Revert info.plist

4 years agoMerge branch '4.4.0'
Stephane Delcroix [Mon, 2 Dec 2019 10:25:47 +0000 (11:25 +0100)]
Merge branch '4.4.0'

4 years agoMerge branch '4.3.0' into 4.4.0
Stephane Delcroix [Mon, 2 Dec 2019 10:24:02 +0000 (11:24 +0100)]
Merge branch '4.3.0' into 4.4.0

4 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 2 Dec 2019 10:22:59 +0000 (11:22 +0100)]
Merge branch '4.2.0' into 4.3.0

4 years ago[iOS] Additional Preserve Attributes (#8721)
Shane Neuville [Sun, 1 Dec 2019 18:37:40 +0000 (11:37 -0700)]
[iOS] Additional Preserve Attributes (#8721)

4 years agoIOS Linker fixes inside Xamarin.Forms (#8001)
Shane Neuville [Sun, 1 Dec 2019 01:55:09 +0000 (18:55 -0700)]
IOS Linker fixes inside Xamarin.Forms (#8001)

* Mark iOS platform as linker safe
- remove UIWebView references

* - move linker safe to platform

* Update Xamarin.Forms.ControlGallery.iOS/Xamarin.Forms.ControlGallery.iOS.csproj

* - preserve constructors

* - gallery updates

4 years agoCall the application OnResume, on Android Resume instead of Restart. (#7477) Fixes...
Kevin Petit [Thu, 28 Nov 2019 11:53:41 +0000 (12:53 +0100)]
Call the application OnResume, on Android Resume instead of Restart. (#7477) Fixes #7400

4 years agoAdded defensive code (#8666)
Gerald Versluis [Thu, 28 Nov 2019 10:15:00 +0000 (11:15 +0100)]
Added defensive code (#8666)

4 years agoFix-7167-UWP-ListViewRenderer-ScrollToTop-when-NotifyCollectionChangedAction.Reset...
Brayan Khosravian [Thu, 28 Nov 2019 08:12:23 +0000 (09:12 +0100)]
Fix-7167-UWP-ListViewRenderer-ScrollToTop-when-NotifyCollectionChangedAction.Reset (#7279)

* - created test view in control gallery for issue 7167
- wrote view, vm, and "ImprovedObservableCollection" for testing purpose
- reproduced the bug without using any external nugets like "System.Reactive"
- added onitemselected of listview to test itemselections
- fixed by changing the implementation of Xamarin.Forms.Platform.UWP.ListViewRenderer.ReloadData
- single commit which is useful for cherry picks
- if itemsource and collectionviewsource.source (_collection) are the same the collectionviewsource is not being reinstantioated again
- wrote ui test.

* - changed controlgalery.projitems manually after cherrypick

* - made testcase uitestable

* - fixed uitesting exception

* - made view, vm ui-testable
- (TODO) modified uitest. (assert is missing)

* - created test view in control gallery for issue 7167
- wrote view, vm, and "ImprovedObservableCollection" for testing purpose
- reproduced the bug without using any external nugets like "System.Reactive"
- added onitemselected of listview to test itemselections
- fixed by changing the implementation of Xamarin.Forms.Platform.UWP.ListViewRenderer.ReloadData
- single commit which is useful for cherry picks
- if itemsource and collectionviewsource.source (_collection) are the same the collectionviewsource is not being reinstantioated again
- wrote ui test.

* - changed controlgalery.projitems manually after cherrypick

* - made testcase uitestable

* - fixed uitesting exception

* - made view, vm ui-testable
- (TODO) modified uitest. (assert is missing)

* - wrote uitest, formetted

* - updated comments

* - uitest are only being executed for UWP

* - removed comments (PR feedback)

4 years ago[macOS] Implement slider min/max/thumb color (#8098)
Konrad Müller [Wed, 27 Nov 2019 19:04:48 +0000 (20:04 +0100)]
[macOS] Implement slider min/max/thumb color (#8098)

* Add slider min/max/thumb color to macOS

* Use forms slider; make custom cell internal

* Remove private modifier

4 years ago[Core,iOS,Android] Remove NumberOfSideItems (#8614)
Rui Marinho [Wed, 27 Nov 2019 17:52:46 +0000 (17:52 +0000)]
[Core,iOS,Android] Remove NumberOfSideItems (#8614)

* [Core,iOS,Android] Remove number of side items

* [Controls] Fix IndicadorCodeGallery

4 years ago[Tizen] Use pre-created window at initailzation time (#8685)
Kangho Hur [Wed, 27 Nov 2019 16:54:42 +0000 (08:54 -0800)]
[Tizen] Use pre-created window at initailzation time (#8685)

4 years ago[Tizen] Add SwipeViewRenderer on Tizen (#8542)
Seungkeun Lee [Wed, 27 Nov 2019 15:04:13 +0000 (00:04 +0900)]
[Tizen] Add SwipeViewRenderer on Tizen (#8542)

* Add SwipeViewRenderer on Tizen

* Update SwipeItemWidth and Height to PX

* Rebase to 4.4.0

 - Fix build error
 - Fix async method naming

* Update StaticRegistrar

4 years ago[Tizen] Provides Static Registrar (#331)
허강호/Common Platform Lab(SR)/Principal Engineer/삼성전자 [Wed, 27 Nov 2019 05:11:09 +0000 (14:11 +0900)]
[Tizen] Provides Static Registrar (#331)

* [Tizen] Provides Static Registrar

* Adds Lookup handler instead of fallback mechanism

4 years agoChange build type on Android CG (#7909)
Shane Neuville [Tue, 26 Nov 2019 19:27:50 +0000 (12:27 -0700)]
Change build type on Android CG (#7909)

4 years ago[Tizen]Update StaticRegistrar (#8676)
Rui Marinho [Tue, 26 Nov 2019 18:29:04 +0000 (18:29 +0000)]
[Tizen]Update StaticRegistrar (#8676)

4 years ago[Tizen] Provides Static Registrar (#8642)
Kangho Hur [Tue, 26 Nov 2019 16:21:04 +0000 (08:21 -0800)]
[Tizen] Provides Static Registrar (#8642)

* [Tizen] Provides Static Registrar

* Adds Lookup handler instead of fallback mechanism

4 years ago[Tizen] Add CarouselViewRenderer (#8081)
sung-su.kim [Tue, 26 Nov 2019 15:54:42 +0000 (00:54 +0900)]
[Tizen] Add CarouselViewRenderer (#8081)

* [Tizen] Add CarouselViewRenderer

* [Tizen] Fix item size

* Move ItemSizingStrategy property to StructuredItemsView

4 years agofix generating nugets (#8660)
Shane Neuville [Tue, 26 Nov 2019 15:26:39 +0000 (08:26 -0700)]
fix generating nugets (#8660)

4 years agoImplement CollectionView Scrolled event on UWP (#8549)
Javier Suárez Ruiz [Tue, 26 Nov 2019 09:13:21 +0000 (10:13 +0100)]
Implement CollectionView Scrolled event on UWP (#8549)

fixes #8508

4 years ago[X] RegisterSourceInfo for XamlC (#8579)
Stephane Delcroix [Tue, 26 Nov 2019 00:29:40 +0000 (01:29 +0100)]
[X] RegisterSourceInfo for XamlC (#8579)

When compiling in DEBUG, Register sourceInfo even for compiled code

4 years agofix reflection call uwp (#8636)
Shane Neuville [Sun, 24 Nov 2019 18:16:20 +0000 (11:16 -0700)]
fix reflection call uwp (#8636)

4 years agoMerge branch '4.4.0'
shane [Sun, 24 Nov 2019 00:19:34 +0000 (17:19 -0700)]
Merge branch '4.4.0'

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs
# Xamarin.Forms.Core/Button.cs
# Xamarin.Forms.Core/IImageElement.cs
# Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootHeader.cs

4 years agoMerge branch '4.3.0' into 4.4.0
shane [Sat, 23 Nov 2019 04:05:36 +0000 (21:05 -0700)]
Merge branch '4.3.0' into 4.4.0

# Conflicts:
# Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootHeader.cs

4 years agoAdded IndicatorsView (#7465)
Andrei [Sat, 23 Nov 2019 01:09:32 +0000 (04:09 +0300)]
Added IndicatorsView  (#7465)

* Added IndicatorsView

* removed static ctor

* refused plural in naming

* opened ItemsSource property

* followed code convention

* renamed IndicatorView (removed plural)

* made Color.Default as initial value

* updated IndicatorSize initial value

* Added IndicatorViewExtensions

* naming changes

* fix build

* small cleanup

* refactored control to templatedView

* added UIPageControl renderer for iOS

* moved extensions class to separate file

* removed useless private methods

* local vars name refactoring

* tapGesture naming update

* avoided linq

* code styling

* fixed default indicator colors for iOS

* added experimental flag

* [Core]Update api naming for IndicatorView

* Update IndicatorView.cs

* [Core] Add forms visual

* Revert "[Core] Add forms visual"

This reverts commit 380f36684ebf1d90ce8df074c13f70f8549ba8db.

* Revert "Revert "[Core] Add forms visual""

This reverts commit 6619e9e758970de3c11672ed2fb181dc37fe6ad0.

* [Gallery]Revert changes to gallery

* [Android] Export default renderer for FormsVisual

* [iOS] Handle FormsVisual for IndicatorView

* [iOS] Update Position from native renderer

* [iOS] IndicatorVIewRendederer updates and dispose

* [Controls] Fix merge

* Added IndicatorView Core Gallery sample

* Add  IndicatorSample

* Update Xamarin.Forms.Controls.csproj

* [Core] Fix FormsVisual check

* [iOS] Fix FormsVisual check

* [Controls] Fix Indicator Gallery sample

* [Core] Cleanup IndicatorView

* [Core]Fix toogle between template and shapes on FormsVisual

* [Controls] Fix indicators samples

* [Controls] Fix IndicatorTemplate

* [Core] Add ItemsSourceBy xaml option

* [iOS,Android,Core] Add IndicatorStacklayout

* [Android] Remove extra renderer for FormsVisual

* [Controls] Remove Visual from Indicator sample

* [Core, iOS, Android] Fix bug on IndcatorView

* - remove forms visual

* - remove extra shared

* - remove forms visual

* - remove disposable

* - remove renderer from tizen

4 years agoSwipeView (#7603)
Javier Suárez Ruiz [Sat, 23 Nov 2019 00:47:01 +0000 (01:47 +0100)]
SwipeView (#7603)

* Implemented SwipeView Spec

* Fixed close SwipeView when scrolling ScrollView in iOS

* Removed unnecessary SwipeItemInvokedEventArgs

* Separate ISwipeItem in a new file

* Changed BaseSwipeEventArgs to be abstract

* Changed SwipeView SwipeItems properties to use OneWay BindingMode

* SwipeDirectionHelpers is now no EditorBrowsable

* Removed unnecessary ContextItem

* Changed SwipeItems base type from BO to Element

* Added defaultValueCreator for SwipeItems (and new sample)

* Changes in UWP SwipeViewRenderer to change some SwipeItems validations

* Renamed CustomSwipeItem to SwipeItemView
Added Close method
Added new SwipeView sample in Core Gallery
Propagate BindingContext from SwipeView to SwipeItems
Fixed bug in Android where occasionally was not rendering the SwipeItem (BindableLayout)

* Moved command execution from the renderers to the abstraction

* Implemented Close method on UWP
Fixed issue to notify SwipeItems changes (add/remove) on UWP
Implemented Uri IconSource (fix SwipeItem using an Url on UWP)

* Updated CustomSwipeItem samples

* Fixed issue on Android (not rendering SwipeItem occasionally)

* Avoid use MessagingCenter to close the SwipeView when scrolling

* Added new Core Gallery sample using custom size SwipeItems
Fixed icon position on Android with big SwipeItems
Fixed custom SwipeItem size issue

* Fixed vertical swipe threshold calc

* Created ISwipeViewController
Moved SwipeItemView to a new class
Moved SwipeEventArgs to a new class
Changes in touch events in Android to have the same behavior as in Android

* Unsubscribe CollectionChanged from the OldElement on UWP renderer

* Allow open the swipeView if the width of the SwipeItems exceeds the width of the SwipeView
Fixed Android SwipeItem icon position calc issue

* Updated SwipeItems to use ISwipeViewController

* Fixed typo

* Fixed typo

* - remove EditorBrowsable

* Changed SwipeTransitionMode enum values

* - fix samsung fussiness

* - fix compile error for UAP

4 years agofix threadpool when compiling for 14393 (#8628)
Shane Neuville [Fri, 22 Nov 2019 21:06:14 +0000 (14:06 -0700)]
fix threadpool when compiling for 14393 (#8628)

4 years agoFix 6693 - [Bug] [WPF] ViewRenderer does not work properly with FrameworkElement...
Chase Marsh [Fri, 22 Nov 2019 19:20:23 +0000 (13:20 -0600)]
Fix 6693 - [Bug] [WPF] ViewRenderer does not work properly with FrameworkElement derived native controls (#8357)

* Resolved merge conflict

* Added if APP compiler directive around InitializeComponent

* Removed LangVersion from WPF csproj so that build server will use the appropriate C# version.
Fixes #6693

4 years ago#3533 Bring back uap10.0/netstandard1.4 support (#7079) fixes #3533
Jiarui Guo [Fri, 22 Nov 2019 16:57:21 +0000 (08:57 -0800)]
#3533 Bring back uap10.0/netstandard1.4 support (#7079) fixes #3533

* target netstandard 1.4 for supporting rs2

* multi targeting

* initial tests

* - set a couple libraries to NS1.0

* - ns1.4

* - fix gallery project

* - fix min targets

* - fix target

* - remove sdk

* - buildControlsPath

* - nuget restore

* - controls path

* - uwp version

* - add generic

* - fix xbf

* - add tuple nuget

* - set max target to 16299

* - proj fixes

4 years agoUpdate LabelRenderer.cs (#8571) fixes #7019
Gerald Versluis [Fri, 22 Nov 2019 14:51:22 +0000 (15:51 +0100)]
Update LabelRenderer.cs (#8571) fixes #7019

4 years ago[UWP] Fix MDP Button "Padding" issue (#8610)
Gerald Versluis [Fri, 22 Nov 2019 03:04:10 +0000 (04:04 +0100)]
[UWP] Fix MDP Button "Padding" issue (#8610)

* Update MasterDetailControlStyle.xaml

* Added comments

* Update MasterDetailControlStyle.xaml

4 years ago[C] avoid calling ChangeVisualState twice (#8381)
Stephane Delcroix [Fri, 22 Nov 2019 00:25:32 +0000 (01:25 +0100)]
[C] avoid calling ChangeVisualState twice (#8381)

4 years agoFix to double escaping. (#8473)
Todd [Fri, 22 Nov 2019 00:22:09 +0000 (18:22 -0600)]
Fix to double escaping. (#8473)

fixes #4880

4 years agoWPF Implement editor placeholder (#8504)
melimion [Fri, 22 Nov 2019 00:21:51 +0000 (03:21 +0300)]
WPF Implement editor placeholder (#8504)

* Placeholder implemented

* PlaceholderColor added to EditorCoreGalleryPage

4 years agoRelativeSource Binding Bug Fixes (Gh8450) (#8541)
Peter Moore [Fri, 22 Nov 2019 00:21:33 +0000 (18:21 -0600)]
RelativeSource Binding Bug Fixes (Gh8450) (#8541)

* RelativeSource Binding Bug FIxes

(1) Fix RelativeSource-FindAncestorBindingContext bindings not re-applying on ancestor BindingContext or ancestry changes;
(2) fix incorrect interpretation of AncestorLevel;
(3) much more robust unit tests for RelativeSource ancestor-type binding (#4)

* Update Xamarin.Forms.Core.UnitTests/RelativeSourceBindingTests.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Fixes #8450

4 years ago[iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command p… (#8544)
Brian Runck [Thu, 21 Nov 2019 23:49:05 +0000 (18:49 -0500)]
[iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command p… (#8544)

* iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command property binding on non-Xamarin.Forms.Command ICommand implementations

* Changes after code review

* - add ui test to android

4 years agoRemove ItemSizingStrategy from CarouselView (#8588)
E.Z. Hart [Thu, 21 Nov 2019 15:53:39 +0000 (08:53 -0700)]
Remove ItemSizingStrategy from CarouselView (#8588)

* Move ItemSizingStrategy

* Fix tests

* Fix Android

* Fix Tizen

* Fix iOS

4 years ago[iOS] Fix top tab highlighting (#8599)
Shane Neuville [Thu, 21 Nov 2019 15:33:05 +0000 (08:33 -0700)]
[iOS] Fix top tab highlighting (#8599)

* Let UICollectionViewCell handle state itself (#7884)

Fixes #7416

* [iOS] Fix top tab highlighting

4 years agoFix [Android] Can not set Entry cursor position by tapping if ClearButtonVisibility...
melimion [Thu, 21 Nov 2019 15:22:40 +0000 (18:22 +0300)]
Fix [Android] Can not set Entry cursor position by tapping if ClearButtonVisibility=WhenEditing (#8429)

* repro

* fix

* set _clearBtn to null in Dispose

* comment removed

4 years agoslow down gesture scroll for ui test and let it retry (#8591)
Shane Neuville [Thu, 21 Nov 2019 06:02:30 +0000 (23:02 -0700)]
slow down gesture scroll for ui test and let it retry (#8591)

4 years agoGif Animation Support (#7330)
Shane Neuville [Thu, 21 Nov 2019 05:52:52 +0000 (22:52 -0700)]
Gif Animation Support (#7330)

* Add image animation API.

* Add animated image tests.

* Add animated image UWP implementation.

* Add animated image IOS implementation.

* Add animated image Android implementation.

Also include GIF image parser base class + android parser sub class.

* Add animation finished playing event to Android/IOS for image.

* Add fallback when loading none GIF as animation image.

* Adding a couple of additional tests for animated images.

* Adjusting image animation support based on PR feedback.

* Add support to reload as animated image on StartAnimation call.

* Add UITest and activity indicator when loading from source for Issue1704.

* Reduce number of temporary bitmaps when scaling.

* Implemented review feedback.

* Animation problems related to Android API level 19 and earlier
due to a couple of bugs and changed behavior in AnimationDrawable class.
Implemented a couple of fixes and workaround related to these bugs, fixing
the animation issues on devices before Android Lollipop.

* Moved a couple of methods implemented in FormsAnimationDrawable into an
interface that is used to hide implementation details. Enables possibility
to factor different implementations of animation support going forward.

* Fixed review feedback and comments.

* Notify IOS to redraw control when changing animation layer.

* - android rebase fixes

* - first set of iOS changes for gifs

* - uwp Gif changes

* - clean up android gif code and enable gif for ImageButtons

* - cleanup iOS gif implementation

* - fix imagebutton and other sources

* - add imagebutton to tests

* - getting rid of start/stop and just using IsAnimationPlaying

* - image button

* - adding animation handler for android

* - replace gifs

* - fix rebase issues

* Added gif samples in Core Gallery

* Updated gif Core Gallery sample

* Fixed UWP gif samples path

* - remove auto play
- fix uwp so it plays correctly on load

* Added support to Url gifs on Android

* - fix rebase

* - fix NRE and iOS repeat

* - fix android loop counter

* - fix animation stopped on ios

* - fix removed ImageHandler interface Android

* - add top margin so ui tests can click button

4 years agoShell Navigation Bar Has Shadow property (#8408)
Shane Neuville [Wed, 20 Nov 2019 11:51:30 +0000 (04:51 -0700)]
Shell Navigation Bar Has Shadow property (#8408)

* add shadow api for shell nav bar

* - ios fixes

* - ios fixes

* - name fix android and simplify types on ios

* - change to listener

* - cleanup

* - remove toolbar

* - fix ios to propagate nav bar on page push

* - fix android crash

4 years agoFix NRE on iOS 10 when navigating away from a page with a grouped CollectionView...
E.Z. Hart [Tue, 19 Nov 2019 19:19:14 +0000 (12:19 -0700)]
Fix NRE on iOS 10 when navigating away from a page with a grouped CollectionView (#8496)

4 years agoExpose top tab creation methods (#8441) fixes #7808 fixes #8428
Shane Neuville [Tue, 19 Nov 2019 14:19:57 +0000 (07:19 -0700)]
Expose top tab creation methods (#8441) fixes #7808 fixes #8428

4 years agoUpdate MacDeviceInfo.cs (#8561) fixes #8559
Gerald Versluis [Tue, 19 Nov 2019 11:05:18 +0000 (12:05 +0100)]
Update MacDeviceInfo.cs (#8561) fixes #8559

4 years agoFix crash using the CarouselView and EmptyView (#8430)
Javier Suárez Ruiz [Tue, 19 Nov 2019 10:24:53 +0000 (11:24 +0100)]
Fix crash using the CarouselView and EmptyView (#8430)

4 years agoFix Bug 7823 - Frame corner radius (#8032)
Felipe Baltazar [Tue, 19 Nov 2019 10:09:16 +0000 (07:09 -0300)]
Fix Bug 7823 - Frame corner radius (#8032)

* Fix Bug 7823

* Code review

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Code review ♻

* Code review ♻

* revert 7f93346a3d1d3261d05843084d1934d5201b0c75

* Revert d9ad8f31507e8373a2db1f4b9eb737b256dcf6ad

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* rebase 4.4.0 fixes

* fix rebase 4.4.0

* fix rebase 4.4.0

* Fix test 7823

* Fixes api 19 test

4 years agoMerge branch '4.4.0'
Shane Neuville [Tue, 19 Nov 2019 01:32:14 +0000 (18:32 -0700)]
Merge branch '4.4.0'

4 years agoMerge branch '4.3.0' into 4.4.0
Shane Neuville [Tue, 19 Nov 2019 01:31:25 +0000 (18:31 -0700)]
Merge branch '4.3.0' into 4.4.0

# Conflicts:
# Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
# build.cake