brucedawson [Sat, 27 Feb 2016 00:31:12 +0000 (16:31 -0800)]
Revert of Add non-inline SkRTreeFactory constructor to fix clang-cl (patchset #2 id:20001 of https://codereview.chromium.org/
1676833002/ )
Reason for revert:
This workaround should no longer be needed, per comment#16 from
thakis@ on the original CL.
Original issue's description:
> Add non-inline SkRTreeFactory constructor to fix clang-cl
>
> When Chromium is switched to build with VS 2015 that switches clang-cl
> to build in -fmsc-version=1900 mode. This causes some changes in
> importing of constructors and vftables which leads to link errors in
> blink_platform.dll. Adding a non-inline constructor makes 1900 mode
> behave consistently with 1800 mode and avoids the link error.
>
> The root cause needs investigation but this will unblock the VS 2015
> switch.
>
> BUG=440500,498544
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1676833002
>
> Committed: https://skia.googlesource.com/skia/+/
964eec67760196585954203ba625e440607f7e92
TBR=reed@google.com,bsalomon@google.com,mtklein@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=440500,498544
Review URL: https://codereview.chromium.org/
1739363002
mtklein [Fri, 26 Feb 2016 23:53:06 +0000 (15:53 -0800)]
DM: dm.json can be missing some final results
We called JsonWriter::DumpJson() every once in a while,
but this did not necssarily wait for offloaded PNG encoding to finish.
This means we might have been dropping some DM results for a while now.
Fix by one more JsonWriter::DumpJson() call after joining back to the
main thread.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1744723002
Review URL: https://codereview.chromium.org/
1744723002
mtklein [Fri, 26 Feb 2016 22:43:21 +0000 (14:43 -0800)]
DM: support --config {f16,srgb}
Will need to follow up with enabling f16 and srgb configs.
They're still assert-y.
The GMs 'gamma' and 'gradients' look reassuringly good on f16 and srgb backends.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1711143002
Review URL: https://codereview.chromium.org/
1711143002
jvanverth [Fri, 26 Feb 2016 21:58:40 +0000 (13:58 -0800)]
Switch float arrays to vecs for conical gradients
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1745613002
Review URL: https://codereview.chromium.org/
1745613002
cblume [Fri, 26 Feb 2016 21:20:48 +0000 (13:20 -0800)]
Creating functions for uploading a mipmapped texture.
BUG=476416
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1249543003
Review URL: https://codereview.chromium.org/
1249543003
egdaniel [Fri, 26 Feb 2016 21:12:00 +0000 (13:12 -0800)]
Make GrVkStencilAttachment derive form GrVkImage
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1735283004
Review URL: https://codereview.chromium.org/
1735283004
egdaniel [Fri, 26 Feb 2016 21:06:55 +0000 (13:06 -0800)]
Fix memory crash in vulakn writeUniformBuffers
BUG=skia:5021
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1737593005
Review URL: https://codereview.chromium.org/
1737593005
cdalton [Fri, 26 Feb 2016 20:22:02 +0000 (12:22 -0800)]
Replace fWillReadFragmentPosition with a bitfield
Replaces fWillReadFragmentPosition on GrProcessor with a
"RequiredFeatures" bitfield. This will allow us to add additional
built-in features. Completely removes information about reading the
fragment position from GrPipeline and GrProcOptInfo.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734163002
Review URL: https://codereview.chromium.org/
1734163002
brianosman [Fri, 26 Feb 2016 19:57:23 +0000 (11:57 -0800)]
New GM that exercises gamma-correctness in various parts of the pipeline.
Attempts to render 50% grey through many different techniques. Only the first one (black/white dither) is guaranteed to be correct. This serves as ground-truth for all the others (independent of whatever your display may or may not be doing when viewing the output of the GM).
Current tests:
- Texture bilerp
- Texture scale (ie mipmaps)
- Simple paint color
- Gradient
- A handful of Xfer modes
- 50% grey bitmaps, both linear and sRGB
- Bitmaps wrapped in shaders, which hits a different raster code path
TODO:
- Test coverage (rather than alpha)?
- Text, Blur, etc...?
Re-landing this without the blitter selection change, which may have caused a regression. Also updated the text color so it's legible against both black (SampleApp) and white (gold).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1740213003
Review URL: https://codereview.chromium.org/
1740213003
cdalton [Fri, 26 Feb 2016 18:39:34 +0000 (10:39 -0800)]
Include glGetMultisamplefv API
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1720963002
Committed: https://skia.googlesource.com/skia/+/
69c1b24bcaa7cffd59753a75a7f3d155696fcac4
Review URL: https://codereview.chromium.org/
1720963002
bsalomon [Fri, 26 Feb 2016 18:37:26 +0000 (10:37 -0800)]
When a surface is backed by an external render target force a copy on image snap
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1694943002
Review URL: https://codereview.chromium.org/
1694943002
jvanverth [Fri, 26 Feb 2016 17:21:02 +0000 (09:21 -0800)]
Add back Vk files with LF endings
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1745433002
Review URL: https://codereview.chromium.org/
1745433002
brianosman [Fri, 26 Feb 2016 17:19:02 +0000 (09:19 -0800)]
Revert of New GM that exercises gamma-correctness in various parts of the pipeline. (patchset #4 id:60001 of https://codereview.chromium.org/
1734983003/ )
Reason for revert:
Testing revert to fix MacMini?
Original issue's description:
> New GM that exercises gamma-correctness in various parts of the pipeline.
>
> Attempts to render 50% grey through many different techniques. Only the first one (black/white dither) is guaranteed to be correct. This serves as ground-truth for all the others (independent of whatever your display may or may not be doing when viewing the output of the GM).
>
> Current tests:
> - Texture bilerp
> - Texture scale (ie mipmaps)
> - Simple paint color
> - Gradient
> - A handful of Xfer modes
> - 50% grey bitmaps, both linear and sRGB
>
> Also includes a bug-fix for sRGB -> Linear bitmap case
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734983003
>
> Committed: https://skia.googlesource.com/skia/+/
9f73a71eec0eb54783f2dcad009aae6aafbe38d5
TBR=bsalomon@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1744533002
jvanverth [Fri, 26 Feb 2016 17:05:27 +0000 (09:05 -0800)]
Remove Vk files with spurious CRLFs
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1726403007
Review URL: https://codereview.chromium.org/
1726403007
robertphillips [Fri, 26 Feb 2016 16:51:25 +0000 (08:51 -0800)]
Make GrRRectBlurEffect::onIsEqual include the roundrect's rect
BUG=skia:5014
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1743553003
Review URL: https://codereview.chromium.org/
1743553003
joshualitt [Fri, 26 Feb 2016 16:36:25 +0000 (08:36 -0800)]
Get SkiaServe Request started off with a little privacy
This CL moves the surface stuff into the request object so it
can maintain its internal state consistently
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1741823002
Review URL: https://codereview.chromium.org/
1741823002
egdaniel [Fri, 26 Feb 2016 16:32:20 +0000 (08:32 -0800)]
Fix oval rendering in vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1739063002
Review URL: https://codereview.chromium.org/
1739063002
halcanary [Fri, 26 Feb 2016 16:29:25 +0000 (08:29 -0800)]
SkPDF/Test: detailed error messages in PDFDeflateWStreamTest
BUG=skia:5009
TBR=
Review URL: https://codereview.chromium.org/
1727153005
joshualitt [Fri, 26 Feb 2016 16:22:49 +0000 (08:22 -0800)]
Wire up /batches in skiaserve
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1737323002
Review URL: https://codereview.chromium.org/
1737323002
egdaniel [Fri, 26 Feb 2016 16:18:49 +0000 (08:18 -0800)]
Fix uniform buffer layout in vulkan
TBR=jvanverth@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734403002
Review URL: https://codereview.chromium.org/
1734403002
joshualitt [Fri, 26 Feb 2016 16:07:50 +0000 (08:07 -0800)]
Add batchlist managment to GrAuditTrail
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1724243004
Review URL: https://codereview.chromium.org/
1724243004
egdaniel [Fri, 26 Feb 2016 16:02:55 +0000 (08:02 -0800)]
Add VkProgramDataManager back into to repo
Confirmed that this is concidered a plain ASCII file with no CR
TBR=jvanverth@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1743593002
Review URL: https://codereview.chromium.org/
1743593002
brianosman [Fri, 26 Feb 2016 15:59:33 +0000 (07:59 -0800)]
New GM that exercises gamma-correctness in various parts of the pipeline.
Attempts to render 50% grey through many different techniques. Only the first one (black/white dither) is guaranteed to be correct. This serves as ground-truth for all the others (independent of whatever your display may or may not be doing when viewing the output of the GM).
Current tests:
- Texture bilerp
- Texture scale (ie mipmaps)
- Simple paint color
- Gradient
- A handful of Xfer modes
- 50% grey bitmaps, both linear and sRGB
Also includes a bug-fix for sRGB -> Linear bitmap case
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734983003
Review URL: https://codereview.chromium.org/
1734983003
egdaniel [Fri, 26 Feb 2016 15:40:52 +0000 (07:40 -0800)]
Try to fix broken file by just deleting it.
Will try re uploading fixed version after.
TBR=jvanverth@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1737763003
Review URL: https://codereview.chromium.org/
1737763003
yujieqin [Fri, 26 Feb 2016 14:18:20 +0000 (06:18 -0800)]
Enable RAW codec for Windows
* Fix the exception catching
* Set preprocessor differently for MSVC
BUG=skia:4889(b/
26958348)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1738913002
Review URL: https://codereview.chromium.org/
1738913002
caryclark [Fri, 26 Feb 2016 13:59:40 +0000 (05:59 -0800)]
add gm to illustrate bug
TBR=reed@google.com
BUG=skia:517
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734343004
Review URL: https://codereview.chromium.org/
1734343004
caryclark [Fri, 26 Feb 2016 13:01:42 +0000 (05:01 -0800)]
fix undefined signed shifts
The expression (1 << 31) is technically undefined.
Fixed the undefined shift referenced by this bug and
a few friends.
R=reed@google.com
BUG=skia:2285
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1737363002
Review URL: https://codereview.chromium.org/
1737363002
ericrk [Fri, 26 Feb 2016 06:15:29 +0000 (22:15 -0800)]
Revert of Skia Filter Quality and Scaling Metrics (patchset #3 id:60001 of https://codereview.chromium.org/
1686203002/ )
Reason for revert:
reverting this to address Ilya's comments.
Original issue's description:
> Skia Filter Quality and Scaling Metrics
>
> Adds histogram metrics to log the filter quality and scale factor of
> each image draw. To make the data easier to consume, this is broken
> down into a number of individual histograms:
> - Filter quality across all draw calls
> - Scale amount across all draw calls
> - Scale amount per filter quality (4 histograms total)
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1686203002
>
> Committed: https://skia.googlesource.com/skia/+/
f57b3a6e4a002caf01378832cbd756c6c163a783
TBR=bsalomon@google.com,isherman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1735423002
halcanary [Fri, 26 Feb 2016 01:21:40 +0000 (17:21 -0800)]
SkPDF: Let client re-encode JPGs if they want to
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734223003
Review URL: https://codereview.chromium.org/
1734223003
egdaniel [Thu, 25 Feb 2016 21:47:45 +0000 (13:47 -0800)]
Fix createTexture calls in vk tests
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1737343002
Review URL: https://codereview.chromium.org/
1737343002
ethannicholas [Thu, 25 Feb 2016 21:43:16 +0000 (13:43 -0800)]
Revert of Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder (patchset #3 id:40001 of https://codereview.chromium.org/
1730903007/ )
Reason for revert:
Got a GL-related crash in nanobench:
https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release/builds/3815/steps/nanobench/logs/stdio
Given we're about to branch and this is the only GL-related change in the blamelist, I'm going to assume this is responsible and revert.
Original issue's description:
> Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder
>
> Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext.
>
> TBR=bsalomon@google.com
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1730903007
>
> Committed: https://skia.googlesource.com/skia/+/
00fddebe56fabea67dcc08762805c1294eebf5bf
TBR=joshualitt@chromium.org,bsalomon@google.com,robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1737373002
brianosman [Thu, 25 Feb 2016 21:40:42 +0000 (13:40 -0800)]
Fix copy-paste typo in comment.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734613005
Review URL: https://codereview.chromium.org/
1734613005
fmalita [Thu, 25 Feb 2016 21:37:28 +0000 (13:37 -0800)]
4f gradient negative-dx interval fixup for kMirror_TileMode
4f intervals are meant to be monotonically increasing in X. This means
we invert the point order when dx < 0:
[0...1) -> (1...0]
For kMirror_TileMode, we also append a duplicate/flipped interval
sequence and expand the range to 2:
[0...1) -> [0...1)[1...2)
When dx < 0, the current logic yields
(1...0] -> (1...0](2...1]
which violates the interval monotonicity.
To achieve the proper order, we need to swap the two halves:
(1...0] -> (1...0](2...1] -> (2...1](1...0]
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1735773003
Review URL: https://codereview.chromium.org/
1735773003
robertphillips [Thu, 25 Feb 2016 20:56:50 +0000 (12:56 -0800)]
Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder
Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext.
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1730903007
Review URL: https://codereview.chromium.org/
1730903007
benjaminwagner [Thu, 25 Feb 2016 20:20:40 +0000 (12:20 -0800)]
Check scalar to fixed conversions with axes.
In SkTypeface_FreeType::Scanner::computeAxisValues, check for
out-of-range values before converting to SkFixed.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1709403003
Review URL: https://codereview.chromium.org/
1709403003
bungeman [Thu, 25 Feb 2016 19:34:10 +0000 (11:34 -0800)]
Fully check basis vectors for extent degeneracy.
The test for 'nearly singular matrix' in SkScalerContext::computeMatrices
is actually a check to see if anything will draw. Unfortunately, the
current test only checks when the a skew causes nothing to draw. This
adds the check for when the scale causes nothing to draw.
BUG=skia:4998
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1735613002
Review URL: https://codereview.chromium.org/
1735613002
joshualitt [Thu, 25 Feb 2016 19:28:18 +0000 (11:28 -0800)]
Move urlhandlers out of skiaserve.cpp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1737643003
Review URL: https://codereview.chromium.org/
1737643003
ericrk [Thu, 25 Feb 2016 19:21:57 +0000 (11:21 -0800)]
Skia Filter Quality and Scaling Metrics
Adds histogram metrics to log the filter quality and scale factor of
each image draw. To make the data easier to consume, this is broken
down into a number of individual histograms:
- Filter quality across all draw calls
- Scale amount across all draw calls
- Scale amount per filter quality (4 histograms total)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1686203002
Review URL: https://codereview.chromium.org/
1686203002
bungeman [Thu, 25 Feb 2016 19:20:01 +0000 (11:20 -0800)]
Deduplicate axis value resolving code.
The code was originally written for Android, but is now implemented
more generally by the FreeType scanner to be shared between all
FreeType backed typefaces. This removes the now duplicate code in the
Android font manager and uses the shared code instead.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1726213004
Review URL: https://codereview.chromium.org/
1726213004
joshualitt [Thu, 25 Feb 2016 19:09:36 +0000 (11:09 -0800)]
Create Response namespace for skiaserve response functions
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1739763002
Review URL: https://codereview.chromium.org/
1739763002
robertphillips [Thu, 25 Feb 2016 19:03:52 +0000 (11:03 -0800)]
Hide GrPipelineBuilder from GrOvalRenderer
Limiting the reach of GrPipelineBuilder is always good.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1726223008
Review URL: https://codereview.chromium.org/
1726223008
scroggo [Thu, 25 Feb 2016 19:03:47 +0000 (11:03 -0800)]
Add a DM flag to limit the types of Codec decodes
When the flag "simpleCodec" is set to true, we will only decode
to the canvas colortype and to a scale of 1. No SkAndroidCodec or
BRDCodec tests are run. This makes it easier to find the simple
case when running locally.
Clean up some SkImageDecoder references along the way.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1735743003
Review URL: https://codereview.chromium.org/
1735743003
robertphillips [Thu, 25 Feb 2016 18:58:49 +0000 (10:58 -0800)]
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1732263003
BUG=skia:4691
Review URL: https://codereview.chromium.org/
1732263003
joshualitt [Thu, 25 Feb 2016 18:50:28 +0000 (10:50 -0800)]
Move some methods to SkiaServe's Request, this is still very leaky
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1733813004
Review URL: https://codereview.chromium.org/
1733813004
benjaminwagner [Thu, 25 Feb 2016 18:28:11 +0000 (10:28 -0800)]
Cleanups related to SkFixed.
This CL relands https://codereview.chromium.org/
1683743005/ with two fixes:
- Removing the test for vertical text. Vertical text doesn't work on Windows and breakText isn't supported for non-trivial text.
- Omit PaintBreakTextTest in Google3 because we don't have the correct font setup yet.
Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1683743005
Committed: https://skia.googlesource.com/skia/+/
7ea5cb18389db11a94175de95c9db2b44972630c
patch from issue
1683743005 at patchset 120001 (http://crrev.com/
1683743005#ps120001)
Review URL: https://codereview.chromium.org/
1739453002
robertphillips [Thu, 25 Feb 2016 17:28:08 +0000 (09:28 -0800)]
Mv DRRect drawing code from GrDrawContext into SkGpuDevice
This is a TODO left over from https://codereview.chromium.org/
1731413002/ (Hide GrDrawTarget from GrOvalRenderer). It is desireable since the GrDrawContext doesn't, in general, manipulate GrFragmentProcessors.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1733993003
Review URL: https://codereview.chromium.org/
1733993003
joshualitt [Thu, 25 Feb 2016 16:37:54 +0000 (08:37 -0800)]
Move Request to its own file in preparation for numerous cleanups
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1738483003
Review URL: https://codereview.chromium.org/
1738483003
bsalomon [Thu, 25 Feb 2016 16:33:02 +0000 (08:33 -0800)]
Move Budgeted enum out of SkSurface, use in GrTextureProvider
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1728093005
DOCS_PREVIEW= https://skia.org/?cl=
1728093005
Committed: https://skia.googlesource.com/skia/+/
57599fe6c0336feaeeeb9b1996e77b70219b483c
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1728093005
jvanverth [Thu, 25 Feb 2016 15:59:45 +0000 (07:59 -0800)]
Add stub for new method to GrVkGpu
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1736983003
Review URL: https://codereview.chromium.org/
1736983003
bungeman [Thu, 25 Feb 2016 15:07:32 +0000 (07:07 -0800)]
Use kSubpixelRounding in one missed location.
The kSubpixelRounding macro was created to clarify a block of code,
but one simplification was missed.
Review URL: https://codereview.chromium.org/
1733843002
jcgregorio [Thu, 25 Feb 2016 15:02:13 +0000 (07:02 -0800)]
use the favicon on debugger.skia.org
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734913002
Review URL: https://codereview.chromium.org/
1734913002
mtklein [Thu, 25 Feb 2016 14:52:18 +0000 (06:52 -0800)]
10.9 is no more
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1732353002
Review URL: https://codereview.chromium.org/
1732353002
bsalomon [Thu, 25 Feb 2016 14:52:12 +0000 (06:52 -0800)]
Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (patchset #6 id:100001 of https://codereview.chromium.org/
1728093005/ )
Reason for revert:
Need workaround for chrome to build
Original issue's description:
> Move Budgeted enum out of SkSurface, use in GrTextureProvider
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1728093005
> DOCS_PREVIEW= https://skia.org/?cl=
1728093005
>
> Committed: https://skia.googlesource.com/skia/+/
57599fe6c0336feaeeeb9b1996e77b70219b483c
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1734043002
Greg Daniel [Thu, 25 Feb 2016 14:47:33 +0000 (09:47 -0500)]
Update shaderc lib and use single combined lib
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1737653002
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/
1737653002
bsalomon [Thu, 25 Feb 2016 14:33:26 +0000 (06:33 -0800)]
Move Budgeted enum out of SkSurface, use in GrTextureProvider
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1728093005
DOCS_PREVIEW= https://skia.org/?cl=
1728093005
Review URL: https://codereview.chromium.org/
1728093005
yujieqin [Thu, 25 Feb 2016 13:42:30 +0000 (05:42 -0800)]
Add -lrt flag for ChromeOS to enable the usage of clock_gettime. Enable RawCodec for ChromeOS
BUG=b/
26813410
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1733223002
Review URL: https://codereview.chromium.org/
1733223002
kkinnunen [Thu, 25 Feb 2016 10:03:43 +0000 (02:03 -0800)]
Implement support for using GL ES 3.0 with command buffer
Adds a new 'api': --config gpu(api=commandbuffer3) for dm/nanobench.
BUG=skia:4943
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1684413003
Review URL: https://codereview.chromium.org/
1684413003
mtklein [Thu, 25 Feb 2016 03:07:07 +0000 (19:07 -0800)]
trim DM fat
- cuts out a few fringe features like logs and notes tallies
- moves vetos and blacklisting earlier so they're never really seen
- many string strength reductions, either to const SkString& or const char*
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1727363004
Review URL: https://codereview.chromium.org/
1727363004
Brian Salomon [Thu, 25 Feb 2016 02:55:47 +0000 (21:55 -0500)]
Fix ~,! typo when clearing kRenderTarget flag
TBR=brucedawson@chromium.org,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1727413004
Review URL: https://codereview.chromium.org/
1727413004 .
mtklein [Thu, 25 Feb 2016 02:00:23 +0000 (18:00 -0800)]
DM: assert we ran as many tasks as we thought we would
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1731783003
Review URL: https://codereview.chromium.org/
1731783003
halcanary [Thu, 25 Feb 2016 01:59:16 +0000 (17:59 -0800)]
Unit Tests: eliminate stray SkDebugf()s.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1733113002
Review URL: https://codereview.chromium.org/
1733113002
halcanary [Wed, 24 Feb 2016 23:46:46 +0000 (15:46 -0800)]
SkPDF: fix scalar serialization
BUG=skia:4868
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1720863003
Review URL: https://codereview.chromium.org/
1720863003
brianosman [Wed, 24 Feb 2016 23:38:48 +0000 (15:38 -0800)]
Add skia.conf (configuration file that supports printShaders, etc...) to .gitignore
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734563003
Review URL: https://codereview.chromium.org/
1734563003
fmalita [Wed, 24 Feb 2016 23:32:57 +0000 (15:32 -0800)]
Add 4f linear gradient benches
Plus some more regular tiling mode variations and random cleanups.
R=reed@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1728283003
Review URL: https://codereview.chromium.org/
1728283003
halcanary [Wed, 24 Feb 2016 23:17:19 +0000 (15:17 -0800)]
SkPDF/Bench: add bench for SkPDFSharedStream (deflate)
Also, simplify gyp.
BUG=skia:5009
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1730833003
Review URL: https://codereview.chromium.org/
1730833003
ericrk [Wed, 24 Feb 2016 22:49:51 +0000 (14:49 -0800)]
Add wrapBackendTextureAsRenderTarget API
Skia's GrTextureProvider currently exposes two APIs for wrapping backend
objects:
* wrapBackendTexture - wraps a texture into a GrTexture. Depending on
flags, this GrTexture can be converted to a GrRenderTarget. Skia
manages the render target objects it may create to provide a render
target for the texture. This allows Skia to create stencil buffers
if needed and manager MSAA resolves.
* wrapBackendRenderTarget - wraps a FBO into a GrRenderTarget. This
object cannot be converted to a GrTexture. Skia does not manage
the render target objects for such a GrRenderTarget, and as such
cannot attach stencil buffers or perform MSAA resolves on the
created GrRenderTarget.
Given these two options, wrapBackendTexture provides more versatility
and allows Skia more room for optimization. Chrome currently uses
wrapBackendTexture for this reason.
While these two functions cover most cases, they do not provide a way
for Skia to wrap a texture into a render target (and gain the MSAA and
stencil buffer management), without also creating a GrTexture. This is
problematic in cases where a texture can be bound to a render target,
but cannot be textured from, as is the case in Chrome's limited support
for GL_TEXTURE_RECTANGLE.
To address this, a new function is created:
* wrapBackendTextureAsRenderTarget - wraps a texture into a
GrRenderTarget. As with wrapBackendTexture, the created render
target objects are fully managed by Skia. Unlike wrapBackendTexture
no GrTexture is created, and the created object will never be
textured from.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1709163003
Review URL: https://codereview.chromium.org/
1709163003
robertphillips [Wed, 24 Feb 2016 21:36:56 +0000 (13:36 -0800)]
Hide GrDrawTarget from GrOvalRenderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1731413002
Review URL: https://codereview.chromium.org/
1731413002
mtklein [Wed, 24 Feb 2016 20:28:32 +0000 (12:28 -0800)]
Rethink DM output
Instead of printing out each task as it finishes, or as it starts and as it finishes, periodically print out what we're up to.
Example output:
https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/6436/steps/dm/logs/stdio
BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1730943003
Review URL: https://codereview.chromium.org/
1730943003
brianosman [Wed, 24 Feb 2016 19:47:47 +0000 (11:47 -0800)]
Added a flag that forces SampleApp to continuously redraw, even in non-animated tests. Helpful when profiling or debugging.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1731853003
Review URL: https://codereview.chromium.org/
1731853003
benjaminwagner [Wed, 24 Feb 2016 18:57:47 +0000 (10:57 -0800)]
Round to nearest in ScalarTo256.
This is a followup to https://codereview.chromium.org/
1693683002 per discussion on https://codereview.chromium.org/
1691403002.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1723483004
Review URL: https://codereview.chromium.org/
1723483004
halcanary [Wed, 24 Feb 2016 18:50:35 +0000 (10:50 -0800)]
Documentation: sync-and-gyp design document
NOTRY=true
DOCS_PREVIEW= https://skia.org/dev/design/sync-and-gyp?cl=
1736483002
Review URL: https://codereview.chromium.org/
1736483002
benjaminwagner [Wed, 24 Feb 2016 18:07:52 +0000 (10:07 -0800)]
Change SkUnitScalarClampToByte to more accurate implementation.
The previous implementation was likely more efficient when SkScalar was SkFixed.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1691403002
Review URL: https://codereview.chromium.org/
1691403002
reed [Wed, 24 Feb 2016 17:32:40 +0000 (09:32 -0800)]
remove debugging printf
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1725173003
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/
1725173003
halcanary [Wed, 24 Feb 2016 17:25:58 +0000 (09:25 -0800)]
SkPDF/Bench: add bench for SkPDFCreateBitmapObject
BUG=skia:5009
Review URL: https://codereview.chromium.org/
1729943003
joshualitt [Wed, 24 Feb 2016 17:23:03 +0000 (09:23 -0800)]
fixup GLPrograms textblob todo
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1730253002
Review URL: https://codereview.chromium.org/
1730253002
caryclark [Wed, 24 Feb 2016 17:03:07 +0000 (09:03 -0800)]
fix path ops fuzz bug
If one path is empty and the other has extreme values, the
intermediate coincident paths cannot be resolved, but triggers
an assert that a data structure unexpectedly has zero-length.
Tunnel this failure back up to the top and return that the
entire path op fails.
A future optimization could detect the empty path and avoid
this, allowing the op to succeed -- not sure that it's worth
the additional logic though.
TBR=reed@google.com
BUG=535151
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1730293002
Review URL: https://codereview.chromium.org/
1730293002
mtklein [Wed, 24 Feb 2016 16:58:27 +0000 (08:58 -0800)]
Turn off DM --pre_log on the bots. Too spammy.
BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1734703002
Review URL: https://codereview.chromium.org/
1734703002
jvanverth [Wed, 24 Feb 2016 16:33:10 +0000 (08:33 -0800)]
Use ARM fixes for SDF encoding.
This pulls out the encoding fixes by Joel Liang from
https://codereview.chromium.org/
1643143002/
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1726763002
Review URL: https://codereview.chromium.org/
1726763002
benjaminwagner [Wed, 24 Feb 2016 16:29:11 +0000 (08:29 -0800)]
Revert of Simple cleanups related to SkFixed. (patchset #4 id:120001 of https://codereview.chromium.org/
1683743005/ )
Reason for revert:
New test is failing on Windows.
Original issue's description:
> Cleanups related to SkFixed.
>
> Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
>
> Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
>
> Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
>
> BUG=skia:4632
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1683743005
>
> Committed: https://skia.googlesource.com/skia/+/
7ea5cb18389db11a94175de95c9db2b44972630c
TBR=mtklein@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4632
Review URL: https://codereview.chromium.org/
1724283003
ethannicholas [Wed, 24 Feb 2016 16:19:04 +0000 (08:19 -0800)]
Revert of Include glGetMultisamplefv API (patchset #1 id:1 of https://codereview.chromium.org/
1720963002/ )
Reason for revert:
This is in the blamelist for Visualbench failures:
https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-VisualBench/builds/1035
and seems the most likely candidate for the failure, so I am tentatively reverting.
Original issue's description:
> Include glGetMultisamplefv API
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1720963002
>
> Committed: https://skia.googlesource.com/skia/+/
69c1b24bcaa7cffd59753a75a7f3d155696fcac4
TBR=bsalomon@google.com,joshualitt@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1731333002
reed [Wed, 24 Feb 2016 16:18:42 +0000 (08:18 -0800)]
extend xfermodes gm to include 3 custom modes
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1736523002
Review URL: https://codereview.chromium.org/
1736523002
benjaminwagner [Wed, 24 Feb 2016 15:51:33 +0000 (07:51 -0800)]
Ensure the Gaussian tail of circle blurs goes to zero.
Compare blurcircle GM masked so that values <255 are white and =255 are black:
https://x20web.corp.google.com/~benjaminwagner/review/
1723383002/blurcircles-lt255-before.png
https://x20web.corp.google.com/~benjaminwagner/review/
1723383002/blurcircles-lt255-after.png
This is a spinoff of https://codereview.chromium.org/
1691403002, which was previously causing more "rectangles" in this GM.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1723383002
Review URL: https://codereview.chromium.org/
1723383002
benjaminwagner [Wed, 24 Feb 2016 14:51:52 +0000 (06:51 -0800)]
Cleanups related to SkFixed.
Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float.
Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3.
Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1683743005
Review URL: https://codereview.chromium.org/
1683743005
reed [Wed, 24 Feb 2016 14:21:36 +0000 (06:21 -0800)]
simplify/unify xferproc api
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1721223002
Review URL: https://codereview.chromium.org/
1721223002
joshualitt [Wed, 24 Feb 2016 13:49:55 +0000 (05:49 -0800)]
Create new GM to target translations problems in GrAtlasTextContext
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1721833005
Review URL: https://codereview.chromium.org/
1721833005
fmalita [Wed, 24 Feb 2016 03:02:20 +0000 (19:02 -0800)]
Retire SkShader::kSupports4f_Flag
No longer used except in one test.
Introduce kPrefers4f_Flag instead.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1726983002
Review URL: https://codereview.chromium.org/
1726983002
hcm [Wed, 24 Feb 2016 00:26:03 +0000 (16:26 -0800)]
Skia schedule on skia.org
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1726253002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1726253002
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1726253002
cdalton [Tue, 23 Feb 2016 21:38:47 +0000 (13:38 -0800)]
Include glGetMultisamplefv API
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1720963002
Review URL: https://codereview.chromium.org/
1720963002
fmalita [Tue, 23 Feb 2016 21:26:28 +0000 (13:26 -0800)]
Update 4f linear gradient selection heuristic
Use the 4f context when
* dest type is 4f
* there's no perpective
Keeping the define and testing flag overrides for now.
R=reed@google.com,herb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1725793003
Review URL: https://codereview.chromium.org/
1725793003
bungeman [Tue, 23 Feb 2016 20:55:20 +0000 (12:55 -0800)]
Move SkPackBits to src/effects.
Prior to this change SkPackBits.h was in include/core and SkPackBits.cpp
in src/core. However, SkPackBits appears to have been written
specifically as an implementation detail of the SkTableColorFilter
effect. This change moves SkPackBits out of core and into effects, which
is the only current user.
Review URL: https://codereview.chromium.org/
1722173003
benjaminwagner [Tue, 23 Feb 2016 18:44:31 +0000 (10:44 -0800)]
Simplify and combine SkDrawCacheProc and SkMeasureCacheProc to SkPaint::GlyphCacheProc.
All callers of (the result of) SkPaint::getDrawCacheProc were passing zero as the last two arguments. This is the same as (the result of) SkPaint::getMeasureCacheProc(true).
Per bungeman, make this typedef a member of SkPaint.
Although the typedef is technically public, the only uses are private, so this is not really an API change.
TBR=reed
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1718423002
Review URL: https://codereview.chromium.org/
1718423002
mtklein [Tue, 23 Feb 2016 18:39:36 +0000 (10:39 -0800)]
Add a handler to DM to print out what was running when we crash.
This is an experiment to see if we can use something like this
rather than today's extremely verbose logging.
Now, hopefully something crashes.
BUG=skia:4978
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1725543002
Review URL: https://codereview.chromium.org/
1725543002
caryclark [Tue, 23 Feb 2016 18:32:40 +0000 (10:32 -0800)]
make transformed rrect radii fit rectangle
one more case caught by 1M skps
R=herb@google.com,reed@google.com
BUG=skia:4413
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1722483003
Review URL: https://codereview.chromium.org/
1722483003
msarett [Tue, 23 Feb 2016 16:21:21 +0000 (08:21 -0800)]
Remove unnecessary GOOGLE3 ifdefs from SkRawCodec
These should be fine now that SkJpegCodec is building in GOOGLE3.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1718343002
Review URL: https://codereview.chromium.org/
1718343002
msarett [Tue, 23 Feb 2016 16:14:19 +0000 (08:14 -0800)]
Update SK_IMAGE_VERSION to 3
This includes two new test wbmps (that came from clients of BitmapFactory).
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1722263002
Review URL: https://codereview.chromium.org/
1722263002
bungeman [Tue, 23 Feb 2016 15:34:25 +0000 (07:34 -0800)]
Move SkUtils.h to src/core.
Review URL: https://codereview.chromium.org/
1722703003
ethannicholas [Tue, 23 Feb 2016 14:53:37 +0000 (06:53 -0800)]
added 'visible' attribute to skiaserve JSON
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1726663002
Review URL: https://codereview.chromium.org/
1726663002
yujieqin [Tue, 23 Feb 2016 14:49:38 +0000 (06:49 -0800)]
Use new API instead of the deprecated ones.
This change will allow us to remove the old API in follow up clean up.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1728553002
Review URL: https://codereview.chromium.org/
1728553002
yujieqin [Tue, 23 Feb 2016 14:18:14 +0000 (06:18 -0800)]
Update PIEX: Prepares support for uncompressed thumbnails
The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate.
BUG=b/
26894354
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1723123002
Review URL: https://codereview.chromium.org/
1723123002
msarett [Tue, 23 Feb 2016 13:48:01 +0000 (05:48 -0800)]
Turn on TURBO_HAS_CROP for Android framework
https://buganizer.corp.google.com/u/0/issues/
27290496
BUG=skia:4256
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1721953002
Review URL: https://codereview.chromium.org/
1721953002