Armin Novak [Tue, 11 Dec 2018 08:32:11 +0000 (09:32 +0100)]
Modified flag checks to avoid invalid flag sets.
Armin Novak [Mon, 10 Dec 2018 13:25:07 +0000 (14:25 +0100)]
X11 extended button remapping support.
Up until now X11 mouse button remapping was only possible for the
default buttons 1 to 3.
With this pull any X11 mouse button can be mapped to any RDP mouse
event and all X11 remappings are respected.
Martin Fleisz [Mon, 10 Dec 2018 13:45:10 +0000 (14:45 +0100)]
Merge pull request #5020 from akallabeth/floatbar_fixes
Floatbar fixes and windows support
Armin Novak [Mon, 10 Dec 2018 13:31:38 +0000 (14:31 +0100)]
Fixed variable hiding by not redeclaring it in subscope.
David Fort [Mon, 10 Dec 2018 12:41:06 +0000 (13:41 +0100)]
Merge pull request #5123 from akallabeth/rail_hash_function
Fixed rail window key hash function to work with UINT32
Bernhard Miklautz [Mon, 10 Dec 2018 12:23:13 +0000 (12:23 +0000)]
Merge pull request #5124 from akallabeth/cert_accept_fix
Fixed certificate accept
Armin Novak [Mon, 10 Dec 2018 11:03:55 +0000 (12:03 +0100)]
Fixed certificate accept
certificate_data_replace can only replace an existing entry,
use certificate_data_print for new ones.
Martin Fleisz [Mon, 10 Dec 2018 10:58:43 +0000 (11:58 +0100)]
Merge pull request #5096 from akallabeth/dsp_channel_mix
Fix #5019: Added channel up/downmixing code for mono/stereo.
Armin Novak [Mon, 10 Dec 2018 10:16:43 +0000 (11:16 +0100)]
Fixed rail window key hash function to work with UINT32
akallabeth [Mon, 10 Dec 2018 09:26:52 +0000 (10:26 +0100)]
Merge pull request #5117 from hardening/rail_hash
rails: allow a window with id == 0
David Fort [Fri, 7 Dec 2018 09:33:07 +0000 (10:33 +0100)]
rails: allow a window with id == 0
Armin Novak [Fri, 7 Dec 2018 14:45:05 +0000 (15:45 +0100)]
Fixed windows floatbar title.
Martin Fleisz [Fri, 7 Dec 2018 14:45:59 +0000 (15:45 +0100)]
Merge pull request #5109 from akallabeth/gw_logging
Added additional gateway error logging.
Armin Novak [Wed, 21 Nov 2018 08:54:09 +0000 (09:54 +0100)]
Unified windows client window title settings.
Armin Novak [Wed, 21 Nov 2018 08:49:50 +0000 (09:49 +0100)]
Fixed #5040: Unified xfreerdp window title setting.
Armin Novak [Fri, 16 Nov 2018 09:33:29 +0000 (10:33 +0100)]
Refactored floatbar, extended command line settings.
Don Caton [Wed, 22 Jun 2016 18:58:39 +0000 (14:58 -0400)]
Windows client: Suppress minimize and restore buttons in float bar when toggle-fullscreen is false, added window title to float bar, improved overall appearance with gradients, shadow and transparent icons.
# Conflicts:
# client/Windows/wf_client.c
# client/Windows/wf_event.c
# client/Windows/wf_floatbar.c
Don Caton [Tue, 14 Jun 2016 18:15:08 +0000 (14:15 -0400)]
Updated .gitignore to exclude Visual Studio 2015 db files
Armin Novak [Thu, 15 Nov 2018 16:58:00 +0000 (17:58 +0100)]
Updated settings.h
Armin Novak [Thu, 15 Nov 2018 16:53:28 +0000 (17:53 +0100)]
Fixed a compiler warning for iterator type
Armin Novak [Thu, 15 Nov 2018 16:35:52 +0000 (17:35 +0100)]
Fixed monitor width and height checks.
Armin Novak [Thu, 15 Nov 2018 13:42:31 +0000 (14:42 +0100)]
Floatbar self contained.
Armin Novak [Thu, 6 Dec 2018 09:07:15 +0000 (10:07 +0100)]
Added additional gateway error logging.
Bernhard Miklautz [Fri, 7 Dec 2018 13:03:46 +0000 (13:03 +0000)]
Merge pull request #5099 from akallabeth/floatbar_close_window
Fixed #5098: Abort connection and let the application clean up resour…
Bernhard Miklautz [Fri, 7 Dec 2018 12:30:55 +0000 (12:30 +0000)]
Merge pull request #5118 from akallabeth/pem_warn_fix
Fix #5115: Cast PEM data from BYTE* to char* to silence warnings.
Armin Novak [Fri, 7 Dec 2018 11:36:18 +0000 (12:36 +0100)]
Fix #5115: Cast PEM data from BYTE* to char* to silence warnings.
David Fort [Fri, 7 Dec 2018 10:30:58 +0000 (11:30 +0100)]
Merge pull request #5116 from akallabeth/drive_ts_fix
Fixed #5113: The timestamps for FileFullDirectoryInformation were inverted
Martin Fleisz [Fri, 7 Dec 2018 10:28:22 +0000 (11:28 +0100)]
Merge pull request #5102 from akallabeth/rail_cleanups
Cleaned up xf_rail_server_handshake
Armin Novak [Fri, 7 Dec 2018 09:59:52 +0000 (10:59 +0100)]
Fixed #5113: The timestamps for FileFullDirectoryInformation were inverted.
Martin Fleisz [Thu, 6 Dec 2018 09:08:17 +0000 (10:08 +0100)]
Merge pull request #5085 from akallabeth/cert_callbacks_update
Refactored Certificate callbacks (but keep compatible)
Armin Novak [Thu, 6 Dec 2018 08:39:50 +0000 (09:39 +0100)]
Fixe accidental removal of certificate_data_replace
Martin Fleisz [Wed, 5 Dec 2018 15:27:05 +0000 (16:27 +0100)]
Merge pull request #5106 from hardening/wayland_seat7
Wayland seat version 7 and useful script
David Fort [Wed, 5 Dec 2018 14:21:00 +0000 (15:21 +0100)]
uwac: handle wl_seat with version >= 7
Starting at version 7, the wayland client is supposed to mmap the keymap as MAP_PRIVATE
to prevent accidental or intentional modifications.
David Fort [Wed, 5 Dec 2018 14:20:11 +0000 (15:20 +0100)]
script: add a usefull script to create code snippets from specification blobs
akallabeth [Wed, 5 Dec 2018 10:24:51 +0000 (11:24 +0100)]
Merge pull request #5104 from hardening/license_2k3
license: fix licencing against windows 2003 server
Martin Fleisz [Wed, 5 Dec 2018 10:20:34 +0000 (11:20 +0100)]
Merge pull request #5036 from akallabeth/auth_fixes
Refactor NEGO NLA and redirection to use opaque handles
Martin Fleisz [Wed, 5 Dec 2018 10:19:53 +0000 (11:19 +0100)]
Merge pull request #5103 from akallabeth/android_timezone
Fixed #5093: Try to read timezone from java TimeZone first
Martin Fleisz [Wed, 5 Dec 2018 09:57:43 +0000 (10:57 +0100)]
Merge pull request #5062 from akallabeth/init_freerdp_image_copy_from_pointer_data
Fix #5061: Initialize output buffer transparent.
Armin Novak [Tue, 20 Nov 2018 17:01:13 +0000 (18:01 +0100)]
Updated error info from spec.
Armin Novak [Tue, 20 Nov 2018 16:27:47 +0000 (17:27 +0100)]
Fixed requested protocol define names according to spec.
Armin Novak [Tue, 20 Nov 2018 16:03:50 +0000 (17:03 +0100)]
Fixed warnings in nego.
Armin Novak [Tue, 20 Nov 2018 15:48:59 +0000 (16:48 +0100)]
Refactored NLA to be self contained.
Armin Novak [Tue, 20 Nov 2018 15:40:42 +0000 (16:40 +0100)]
Hide redirection implementation details.
Armin Novak [Tue, 20 Nov 2018 15:38:06 +0000 (16:38 +0100)]
Made nego self contained.
David Fort [Wed, 5 Dec 2018 09:50:47 +0000 (10:50 +0100)]
license: fix licencing against windows 2003 server
The spec says:
"For Windows Server 2008, Windows Server 2008 R2, and Windows Server
2012, the EncryptedLicenseInfo variable (part of the Server Upgrade License PDU) sent by the server
to the client has the wBlobType parameter set to value BB_ENCRYPTED_DATA_BLOB (0x0009). For
Windows Server 2003, the value of wBlobType is not defined."
So don't enforce the message type.
Armin Novak [Wed, 5 Dec 2018 09:20:21 +0000 (10:20 +0100)]
Fixed #5093: Try to read timezone from java TimeZone first
persist.sys.timezone property might not exist, try to get the
timezone identifier from the java class first.
Armin Novak [Wed, 5 Dec 2018 08:13:04 +0000 (09:13 +0100)]
Cleaned up xf_rail_server_handshake
akallabeth [Wed, 5 Dec 2018 07:58:08 +0000 (08:58 +0100)]
Merge pull request #5100 from wintersandroid/master
Add jni interface for get_last_error_string
David Fort [Tue, 4 Dec 2018 21:42:25 +0000 (22:42 +0100)]
Merge pull request #5097 from hualet/master
Fixed RAIL window can't show again once hidden
Mathew Winters [Tue, 4 Dec 2018 18:56:05 +0000 (07:56 +1300)]
Add jni interface for get_last_error_string
Armin Novak [Tue, 4 Dec 2018 15:56:22 +0000 (16:56 +0100)]
Follow up to #4959: Lock gdi_UpdateSurfaces like xf_UpdateSurfaces
Armin Novak [Tue, 4 Dec 2018 15:42:28 +0000 (16:42 +0100)]
Fixed #5098: Abort connection and let the application clean up resources before exit.
Martin Fleisz [Tue, 4 Dec 2018 15:40:44 +0000 (16:40 +0100)]
Merge pull request #5087 from hardening/remotefx_chunks
remotefx: don't require data messages to come all in one chunk
David Fort [Tue, 4 Dec 2018 13:38:11 +0000 (14:38 +0100)]
Merge pull request #5094 from akallabeth/suppress_output_setting
Make "suppress output" setting available on command line
Martin Fleisz [Tue, 4 Dec 2018 13:29:59 +0000 (14:29 +0100)]
Merge pull request #4959 from akallabeth/gfx_lock_fix
Implemented GFX mutex locking and enforce return value checks.
Hualet Wang [Tue, 4 Dec 2018 12:28:32 +0000 (20:28 +0800)]
Fixed RAIL window can't show again once hidden
The cause is very simple: we didn't map the xwindow on receiving
WINDOW_SHOW. but doing that causes another problem that you can't
hide a window anymore, and that is because whlie window hiding, the
_NET_WM_STATE and WM_STATE properies of the xwindow may change, in
the function `xf_event_PropertyNotify` we just assume that windows
not maximized, not minimized, yet not showing normally should be
corrected to be shown, we just need to consider the situation that
the window is hidden here.
fix: #5078
Armin Novak [Tue, 4 Dec 2018 10:38:02 +0000 (11:38 +0100)]
Fix #5019: Added channel up/downmixing code for mono/stereo.
David Fort [Fri, 30 Nov 2018 10:37:23 +0000 (11:37 +0100)]
remotefx: don't require data messages to come all in one chunk
The spec doesn't require that FRAME_BEGIN, REGION, TILESET, and FRAME_END come all in one
chunk. This patch adds the necessary state saving.
A unitary test is also added.
Martin Fleisz [Tue, 4 Dec 2018 09:31:01 +0000 (10:31 +0100)]
Merge pull request #5077 from akallabeth/win_client_fixes
Win client fixes
Armin Novak [Fri, 30 Nov 2018 10:41:51 +0000 (11:41 +0100)]
Duplicate PEM when accepted.
Armin Novak [Fri, 30 Nov 2018 10:04:20 +0000 (11:04 +0100)]
Added new default certificate callbacks with extended information.
The extended information provided by VerifyCertificateEx and
VerifyChangedCertificateEx is now exploited by the new functions
client_cli_verify_certificate_ex and client_cli_verify_changed_certificate_ex.
The old callbacks now print out deprecation warnings to inform the
user and developer about this deprecation.
Armin Novak [Fri, 30 Nov 2018 09:36:15 +0000 (10:36 +0100)]
Cleaned up certificate verification code.
Armin Novak [Fri, 30 Nov 2018 09:25:06 +0000 (10:25 +0100)]
Added certificate callbacks with source indications.
Armin Novak [Fri, 30 Nov 2018 08:55:10 +0000 (09:55 +0100)]
Prefer VerifyX509Certificate and fixed const arguments
If VerifyX509Certificate is set use it also when doing internal
certificate management. Added flags to ensure it is possible to
find out which type of connection is being made.
Armin Novak [Mon, 3 Dec 2018 15:15:51 +0000 (16:15 +0100)]
Fixed missing NULL check for thread handle.
Armin Novak [Wed, 28 Nov 2018 15:09:38 +0000 (16:09 +0100)]
Fix #4730: Add git revision, architecture and minimum os support to file properties.
Armin Novak [Wed, 28 Nov 2018 13:44:26 +0000 (14:44 +0100)]
Fix #4999: Increase reference count
Armin Novak [Wed, 28 Nov 2018 12:12:28 +0000 (13:12 +0100)]
Fix callback function return types.
Armin Novak [Wed, 28 Nov 2018 12:12:04 +0000 (13:12 +0100)]
Fix length type, use size_t
Alessandro Muggianu [Thu, 29 Nov 2018 18:42:32 +0000 (18:42 +0000)]
Make "suppress output" setting available on command line
Bernhard Miklautz [Tue, 4 Dec 2018 08:23:14 +0000 (08:23 +0000)]
Merge pull request #5091 from akallabeth/ios_compiles_again
Ios compiles again
Armin Novak [Mon, 3 Dec 2018 16:23:55 +0000 (17:23 +0100)]
Fixed unit tests, use uniqe file names
Armin Novak [Mon, 3 Dec 2018 16:06:43 +0000 (17:06 +0100)]
Updated OpenSSL version for iOS
Armin Novak [Mon, 3 Dec 2018 15:54:56 +0000 (16:54 +0100)]
Set minimum deployment target to 10.0
Martin Fleisz [Mon, 3 Dec 2018 13:45:16 +0000 (14:45 +0100)]
Merge pull request #5082 from akallabeth/win_env_fix
Fix #4909: Do not initialize HOME environment variable as it is no longer used.
David Fort [Thu, 29 Nov 2018 15:24:28 +0000 (16:24 +0100)]
Merge pull request #5080 from akallabeth/scanbuild-ex-warn
Scanbuild ex warn
Armin Novak [Thu, 29 Nov 2018 12:44:21 +0000 (13:44 +0100)]
Fix #4909: Do not initialize HOME environment variable as it is no longer used.
GetKnownPath does not require this environment variable to be
available for windows builds.
David Fort [Thu, 29 Nov 2018 12:22:23 +0000 (13:22 +0100)]
Merge pull request #5081 from akallabeth/kerberos_config_option
Add WITH_GSSAPI config option, defaults to OFF
Armin Novak [Thu, 29 Nov 2018 12:00:22 +0000 (13:00 +0100)]
Add WITH_GSSAPI config option, defaults to OFF
Armin Novak [Thu, 29 Nov 2018 11:14:20 +0000 (12:14 +0100)]
Fixed a memory leak.
Armin Novak [Thu, 29 Nov 2018 10:07:46 +0000 (11:07 +0100)]
Fixed zero sized allocation.
Armin Novak [Thu, 29 Nov 2018 10:06:41 +0000 (11:06 +0100)]
Fixed zero sized allocation.
Armin Novak [Thu, 29 Nov 2018 10:05:13 +0000 (11:05 +0100)]
Fixed zero sized allocation.
Bernhard Miklautz [Thu, 29 Nov 2018 11:10:14 +0000 (11:10 +0000)]
Merge pull request #5070 from akallabeth/gw_fixes_redirection
Fixed buffer reset in fields_present_to_string
Armin Novak [Tue, 23 Oct 2018 09:52:06 +0000 (11:52 +0200)]
Implemented GFX locking and enforce return value checks.
To fix #4825 GFX functions must now aquire a lock before accessing surfaces.
This prevents simultaneous update of internal data by client and gfx threads.
Also enforce return value checks, where not already done.
Armin Novak [Thu, 29 Nov 2018 09:57:46 +0000 (10:57 +0100)]
Fixed uninitialized value.
Bernhard Miklautz [Thu, 29 Nov 2018 09:50:12 +0000 (09:50 +0000)]
Merge pull request #5073 from akallabeth/trust_settings
Fix #4764: Second try, use X509_STORE_CTX_set_purpose
David Fort [Thu, 29 Nov 2018 09:02:28 +0000 (10:02 +0100)]
Merge pull request #5074 from akallabeth/ycbcr_padding_fix
Fixed padding of general_yCbCrToRGB_16s8u_P3AC4R* functions.
David Fort [Wed, 28 Nov 2018 16:46:18 +0000 (17:46 +0100)]
Merge pull request #5057 from akallabeth/order_settings_init_generic
Unified initialization of OrderSupport
Armin Novak [Wed, 28 Nov 2018 08:32:28 +0000 (09:32 +0100)]
Fix #4764: Second try, use X509_STORE_CTX_set_purpose
Armin Novak [Wed, 28 Nov 2018 10:05:45 +0000 (11:05 +0100)]
Fixed padding of general_yCbCrToRGB_16s8u_P3AC4R* functions.
Armin Novak [Mon, 26 Nov 2018 13:11:29 +0000 (14:11 +0100)]
Fixed buffer reset in fields_present_to_string
Bernhard Miklautz [Mon, 26 Nov 2018 13:01:00 +0000 (13:01 +0000)]
Merge pull request #5066 from akallabeth/ssl_verify_fix
Fix #4768: Set SSL verify purpose to ANY
Bernhard Miklautz [Mon, 26 Nov 2018 11:10:59 +0000 (11:10 +0000)]
Merge pull request #5046 from akallabeth/silence_wlog
Do not compile extended debugging by default.
Bernhard Miklautz [Mon, 26 Nov 2018 11:03:42 +0000 (11:03 +0000)]
Merge pull request #5067 from akallabeth/gfx_log_fix
Fixed error log for avc420_decompress failures.
Armin Novak [Mon, 26 Nov 2018 07:12:51 +0000 (08:12 +0100)]
Fix #4768: Set SSL verify purpose to ANY
Should actually be SSL server but since we allowed broken
purpose up until now keep that for the 2.0 series.
Bernhard Miklautz [Mon, 26 Nov 2018 10:57:20 +0000 (10:57 +0000)]
Merge pull request #5065 from akallabeth/tcp_connect_multi_fix
Fixed a possible NULL dereference.
Armin Novak [Mon, 26 Nov 2018 10:33:23 +0000 (11:33 +0100)]
Fixed error log for avc420_decompress failures.
Armin Novak [Fri, 23 Nov 2018 08:16:23 +0000 (09:16 +0100)]
Fix #5061: Initialize output buffer transparent.
MartinHaimberger [Fri, 23 Nov 2018 09:49:00 +0000 (10:49 +0100)]
Merge pull request #5064 from akallabeth/rdg_length_check_fix
Fixed a broken length check in rdg_process_packet