Semun Lee [Tue, 1 Aug 2017 02:46:02 +0000 (11:46 +0900)]
Fix wrong condition for checking shortcut info
Change-Id: I06467d12a59e8f2bdd452744f8a72575fb656d36
Signed-off-by: Semun Lee <semun.lee@samsung.com>
Seungha Son [Tue, 15 Aug 2017 22:45:42 +0000 (07:45 +0900)]
Fix build break
Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: I46179d94809fb053b89467ea676bf3d0e7a502b3
Seungha Son [Tue, 8 Aug 2017 04:50:26 +0000 (13:50 +0900)]
Add OOM exception handler
Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: Ic86db1a8e8e713effe6af78bf1979e382e3c9071
Sangyoon Jang [Mon, 17 Jul 2017 07:25:12 +0000 (16:25 +0900)]
Fix ReadonlyUpdateUninstall
The original package is preloaded(readonly) so we need to switch
readonly mode before update security context.
Change-Id: Iaad59be0850bf68ffb9bde4bbdfed34ba2327494
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
(cherry picked from commit
50b5482126136e6f1155d43e14150e3e1dca4e51)
Sangyoon Jang [Tue, 11 Jul 2017 10:26:03 +0000 (19:26 +0900)]
Invoke StepParsePreload when ReadonlyUpdateUninstall
StepParsePreload should be invoked for setting system attributes
properly.
Change-Id: I9d40710a2a6a056031d77eeca52de7f7e91bba21
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
(cherry picked from commit
5ee35db0967c94419eddb7989311b55640f9ce62)
jongmyeongko [Fri, 14 Jul 2017 12:06:58 +0000 (21:06 +0900)]
Fix the access issue to shared/res of web app
Other applications can't access the contents of ${pkg_path}/res/wgt/shared/res
because of SMACK denial.
So, the all contents of ${pkg_path}/res/wgt/shared/res should be in shared/res
to avoid SMACK error.
Also, we should consider delta update issue.
The issue is the signature validation check failure because of unsigned file.
In ${pkg_path}/shared/res, there can be generated files such as apps icon.
and there can be other application's data of shared/res in case of Hybrid package.
These files are unsigend one.
To fix the issue,
unlink and move back all original contents for ${pkg_path}/res/wgt/shared/res
before delta update.
Submit with :
https://review.tizen.org/gerrit/#/c/139040/
Change-Id: I83718f109fbe4614c41977f4d680e65f007dad86
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
jongmyeongko [Wed, 12 Jul 2017 06:42:29 +0000 (15:42 +0900)]
Skip reading icon in case there is no icon file actually
Change-Id: I653a8ac1d6fa1d496060adfd68ad8b1757814144
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
jongmyeongko [Wed, 24 May 2017 12:35:05 +0000 (21:35 +0900)]
Fix logic of 'update' attribute
Requires and Refer to:
https://review.tizen.org/gerrit/#/c/133657/
Change-Id: I408ec32d9cabd161217e4a462188c27e6366d712
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
(cherry picked from commit
3a9647cc8e8e639dd2dc52ed3e8fd4b1e4979299)
Junghyun Yeon [Mon, 22 May 2017 01:43:28 +0000 (10:43 +0900)]
Add update step of directories
- shared/data directory of package should be created/removed
when updating hybrid pkg
Related changes:
[app-installers] : https://review.tizen.org/gerrit/131076
Change-Id: Ib3f7bd0091f79d42472cc505c5bcf7ad96f69875
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Sangyoon Jang [Wed, 24 May 2017 05:38:17 +0000 (14:38 +0900)]
Fix crash when parsing icon info from wgt archive
Change-Id: Ifa4866a495af0764be72eb4e5d68d016642b931f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
(cherry picked from commit
c2fd87783a4f43f8e11f0bfb5f5144b737cb0e55)
jongmyeongko [Wed, 19 Apr 2017 09:15:56 +0000 (18:15 +0900)]
Fix crash issue when getting the locale was failed
Change-Id: Id4c860204b942a636bbd6f01b00ae99551cbddc7
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
(cherry picked from commit
88fc2091153fda400934a7056617b8bc16e12383)
jongmyeongko [Sat, 8 Apr 2017 06:51:26 +0000 (15:51 +0900)]
Fix Mount Installation Failure
Requires :
https://review.tizen.org/gerrit/#/c/123947/
Change-Id: Icd0342eab4266467288d06cbe88f573e1a16ee63
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
Piotr Dabrowski [Mon, 19 Sep 2016 13:43:16 +0000 (15:43 +0200)]
Reworked sharing of widget's shared/res directory.
./res/wgt/shared/res directory content was moved to ./shared/res
and then ./res/wgt/shared/res was symlinked to ./shared/res
This broke signatures check for delta update.
Now all items (files and directories) under ./res/wgt/shared/res
are symlinked into ./shared/res, and vice versa.
During delta update these symlinks are removed, so that the
signatures check can complete successfully, and later the symlinks
are recreated again.
Added smoke tests for symlinking shared/res contents in Tizen 3.0
Change-Id: I9423d78aba5cb338b14a9f8853754e0fa8980e0c
jongmyeongko [Thu, 2 Mar 2017 14:06:58 +0000 (23:06 +0900)]
Add KillApp step in RW partial update
Change-Id: I3e5f903d11624eb8deb153dac04872edfb5c608b
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
(cherry picked from commit
0f8845ad249a072bb5d34a74bbf39d5388b9d1fc)
jongmyeongko [Thu, 2 Mar 2017 14:02:04 +0000 (23:02 +0900)]
Add signature check step in RW partial request
The certificate info was not stored properly in cert db.
Require :
https://review.tizen.org/gerrit/#/c/117077/
Change-Id: I71f8d0c5704275d8e167ff7303bc73d66b1efa4a
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
Junghyun Yeon [Thu, 16 Feb 2017 04:02:28 +0000 (13:02 +0900)]
Fix smoke test
- Fix reinstall smoke test to work properly
Related changes :
[app-installers] : https://review.tizen.org/gerrit/114699
Change-Id: I682859a7093ca5981aad1b74ced17ff2f09a85bd
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Bartlomiej Kunikowski [Mon, 2 Jan 2017 13:33:54 +0000 (14:33 +0100)]
Fix in StepWgtPatchStorageDirectory
There is one bug in checking if directory is created, and
second one in comment to this step
Change-Id: I02331ed4b40d3be9be4f217eb842a89f8b9bdfcb
(cherry picked from commit
bbed89f23a2d930cf87b1f71c2fc7131e5967131)
Bartlomiej Kunikowski [Tue, 17 Jan 2017 12:35:18 +0000 (13:35 +0100)]
Fix for rollback of some update modes
This patch solves problem with rollback modes of
delta mode and manifest direct update mode for
hybrid packages
Change-Id: I1ece447536fa9ad6dd7a36d54b7340663188bc7c
(cherry picked from commit
6cca2243df10c828153fbd437362bda6c7222fb7)
Sangyoon Jang [Wed, 11 Jan 2017 02:23:31 +0000 (11:23 +0900)]
Fix StepWgtPatchIcons
Set package's icon as same as app's icon.
We don't need icon file named as pkgid.
Change-Id: I11ed3246c7b1db29b29f357491beb4a67ebfb585
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Tue, 10 Jan 2017 05:45:35 +0000 (14:45 +0900)]
Rollback xml keep blanks support after parsing hybrid manifest
Hybrid installer set default blanks text node support off for
generating/merging manifest. However, this may cause unexpected result
at other library which is using libxml2. So hybrid installer should
rollback this support.
This patch fixes smoke test failures.
Change-Id: I89aa9b99a30e5068e93f44415829f94abca0ff40
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Fri, 6 Jan 2017 04:55:10 +0000 (13:55 +0900)]
Make wgt lib support hybrid package
Change-Id: Id0fe7f2ed6a736104f1683547fe80a0010662b6a
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Fri, 6 Jan 2017 04:51:29 +0000 (13:51 +0900)]
Remove tmpdir when failed to getting icon info
Change-Id: I8b26603ac401f3eaae276da8dfe7dc4e4838aca1
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
jongmyeongko [Wed, 4 Jan 2017 12:42:59 +0000 (21:42 +0900)]
Support legacy image for backward-compatibility
Refer to:
https://review.tizen.org/gerrit/#/c/104823/
Change-Id: I2e48c94def90181b6522fd8f3d9508ea636d693e
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
Sangyoon Jang [Wed, 4 Jan 2017 12:01:11 +0000 (21:01 +0900)]
Fix smoke test
Check gid of cache dir is system_share.
Change-Id: I27ed49347fe4e46dd1331da0cd60d47eddda831c
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Wed, 4 Jan 2017 11:50:04 +0000 (20:50 +0900)]
Fix wgt lib to extract manifest and icon only
Extracting whole files can cause memory issue.
Instead of extracting whole files, wgt lib will extract manifest first
and find icon file from manifest, and then extract icon file.
Change-Id: I2b7a5c1039dc94411e68c7bdffb61d139aa43ef9
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Tue, 27 Dec 2016 07:58:24 +0000 (16:58 +0900)]
Revert "Temporary fix for hybrid pkg installation"
This reverts commit
8c6fc81fabd0d348c8ab57af6ac6f7fd376e8cd1.
Conflicts:
src/wgt/step/pkgmgr/step_generate_xml.cc
Now hybrid installer can merge manifest completely.
Submit with:
- https://review.tizen.org/gerrit/107236
- https://review.tizen.org/gerrit/107237
- https://review.tizen.org/gerrit/107238
- https://review.tizen.org/gerrit/107239
Change-Id: Id054359ba9fb3a04cfee67ba1dbd8afd83ca8082
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Tue, 27 Dec 2016 07:48:27 +0000 (16:48 +0900)]
Fix code style
Remove errors/warnings from tools/check-coding-styles.
Change-Id: Idd2a1faca15b8ac48049c20ebfe758a4917f152f
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Tue, 27 Dec 2016 07:26:24 +0000 (16:26 +0900)]
Fix privilege handling on hybrid installation
To handle privileges properly, it should merge privileges first before
StepPrivilegeCompatibility.
Change-Id: I5e40ebb3374939652d89e258a23051b91cb1781a
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Tue, 27 Dec 2016 07:29:09 +0000 (16:29 +0900)]
Remove unused string constant variable
Change-Id: I1d78321f4d144fb2aff76057036b7cb02792b85d
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Junghyun Yeon [Mon, 26 Dec 2016 07:32:44 +0000 (16:32 +0900)]
Remove codes which refers deleted attribute
Related changes:
[pkgmgr-info] : https://review.tizen.org/gerrit/107032
[app-installers] : https://review.tizen.org/gerrit/107033
[tpk-backend] : https://review.tizen.org/gerrit/107034
Change-Id: I54b8508488321a67ef35733a1063496544f31b22
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Sangyoon Jang [Fri, 23 Dec 2016 07:28:28 +0000 (16:28 +0900)]
Adjust step order of hybrid installer
Step for creating symlink should be called after merging manifest.
Change-Id: Ifdf323c5c0424c59cdbc99a0526f771050d5120d
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Fri, 23 Dec 2016 05:28:03 +0000 (14:28 +0900)]
Fix smoketest
Smoketest should test both global/local case.
This patch make smoketest can test global/local test, but test only
global case because of current platform policy.
It should be test local case also later.
Change-Id: Ib9cb9754058a34a6fc18ba845c872ed819cd3050
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Junghyun Yeon [Thu, 22 Dec 2016 07:17:17 +0000 (16:17 +0900)]
Remove cleardata feature
- Cleardata will be handled by pkg_cleardata
so remove features related with it from backend
Related changes:
[pkgmgr-server] : https://review.tizen.org/gerrit/106486
[pkgmgr-tool] : https://review.tizen.org/gerrit/106485
[app-installers] : https://review.tizen.org/gerrit/105691
[tpk-backend] : https://review.tizen.org/gerrit/106603
Change-Id: I5df69fbe6416fae0188156b0af7d9657951ec32b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Sangyoon Jang [Thu, 22 Dec 2016 05:54:25 +0000 (14:54 +0900)]
Fix mount install failure on global installation
Security registration should be done before creating per user storage
directories because StepCreatePerUserStorage calls
security_manager_paths_register() and it needs security context.
Change-Id: I90c846f55c5ba2cdc294c1a762edb9d97cc76b50
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Fri, 16 Dec 2016 09:54:40 +0000 (18:54 +0900)]
Fix generating manifest when install hybrid package
Currently, wgt-backend generate manifest file using manifest_x which is
parsed by manifest parser. This data contains only the parser knows.
However, the manifest file for native packages have many element which
are not parsed manifest parser but parsed by plugin parsers.
So the manifest generated by wgt-backend loses some elements.
This patch will make the manifest have elements as it was before.
StepGenerateXml from hybrid installer will merge original native
manifest into generated widget manifest(config.xml).
Change-Id: Iea0a68c3b695243248469f0794f62f7bec4fa757
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Piotr Dabrowski [Fri, 16 Dec 2016 14:16:37 +0000 (15:16 +0100)]
Create private tmp directory in skel
Submit together:
https://review.tizen.org/gerrit/#/c/105467/
https://review.tizen.org/gerrit/#/c/105468/
Change-Id: I7454b05b3d83bac2939594f0d82e8d22d457789c
Junghyun Yeon [Tue, 13 Dec 2016 06:15:21 +0000 (15:15 +0900)]
Add missed 'break'
Change-Id: Iea19cafbf53d996c1b0123bb9bafd230a105a006
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
jongmyeongko [Fri, 9 Dec 2016 08:21:11 +0000 (17:21 +0900)]
fix missing brace
Change-Id: I1d2d6137481f9a2a53fbfd2823fa5398a2375387
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
jongmyeongko [Sun, 4 Dec 2016 09:26:07 +0000 (18:26 +0900)]
apply new features : partial install/update/uninstall, force-clean
Submit with:
https://review.tizen.org/gerrit/#/c/103359/
https://review.tizen.org/gerrit/#/c/103361/
Change-Id: I63a24f916d1e8b8a379d579962513ba1551904dc
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
jongmyeongko [Thu, 8 Dec 2016 12:42:38 +0000 (21:42 +0900)]
change the name of StepChageOwner to StepChangeOwnershipAndPermission
Change-Id: I6d6dc6bcf83b5be91b1bc4cb50aaf88a3a4e7742
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
Sangyoon Jang [Thu, 8 Dec 2016 06:29:31 +0000 (15:29 +0900)]
Fix package icon path
It should be under at shared/res for access by other applications.
Change-Id: I1cdb835db681a98ea05987a52b9e55b23d5c8f17
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Wed, 7 Dec 2016 06:42:00 +0000 (15:42 +0900)]
Adjust to change of support ambient
Requires:
- https://review.tizen.org/gerrit/102774
Change-Id: I0f64c7eeb825fd82f25940c0829c4725356c2c9b
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Fri, 2 Dec 2016 08:42:37 +0000 (17:42 +0900)]
Fix CMakeLists.txt
To make extendible for adding source & header files.
Change-Id: I54198360f67882b6c644d13f027f155855e57d12
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Tue, 15 Nov 2016 05:30:45 +0000 (14:30 +0900)]
Add new steps for readonly update
Change-Id: Iff1ffcd4cecea510b4a91ab3d0730e9f09c30db5
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Piotr Ganicz [Wed, 30 Nov 2016 12:48:52 +0000 (13:48 +0100)]
Addition of main attribute for widget-application
This commit repairs the issue with generating proper main attribute
for widget-application element in manifest. Only one attribute can
be set to "true" for list of apps (widget-application).
Submit together:
- https://review.tizen.org/gerrit/#/c/101269/
- https://review.tizen.org/gerrit/#/c/101267/
- https://review.tizen.org/gerrit/#/c/101266/
Change-Id: Icdc622d05b0d2b5787db8e099f1db978f130af97
Sangyoon Jang [Thu, 1 Dec 2016 06:44:15 +0000 (15:44 +0900)]
Fix smoke test
Now gid of data, shared/data dir is system_share.
Change-Id: Id69017b75af1f12cb61d6aa2fd24c1d528a43963
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Fri, 2 Dec 2016 08:05:01 +0000 (17:05 +0900)]
Set missing manifest attribute: readonly, preload
Change-Id: I4a9395a7f646dae6f67723c95b7e1d5cb2496e91
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
jongmyeongko [Wed, 30 Nov 2016 16:53:01 +0000 (01:53 +0900)]
change disable_pkg test
Change-Id: Ie821fea7e3697e1f0381b1d76778f7b31fe29c40
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
jongmyeongko [Wed, 30 Nov 2016 15:01:47 +0000 (00:01 +0900)]
fix build error
- this override function will be used.
Change-Id: I7d28e1e8b0dbf98dda4482eb8bbbe62390f50eab
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
Piotr Dabrowski [Mon, 28 Nov 2016 16:06:05 +0000 (17:06 +0100)]
Change order of steps in wgt as in tpk
StepRegisterSecurity
StepRegisterApplication
StepRunParserPlugin
StepUpdateSecurity
StepUpdateApplication
StepRunParserPlugin
Change-Id: I92c30d65c7af2b50c2ae2f32b8343ef522db2249
Bartlomiej Kunikowski [Fri, 18 Nov 2016 10:48:41 +0000 (11:48 +0100)]
Fix for UpdateMode_Rollback_Hybrid and MountUpdateMode_Rollback_Hybrid
There are unneeded step that remove all smack rules. There should
be all smack rules as before an update.
Verify:
- # su - app_fw
- $ /usr/bin/wgt-backend-ut/smoke-test
Submit together:
- https://review.tizen.org/gerrit/#/c/98725/
Requires:
- https://review.tizen.org/gerrit/#/c/97903/
Change-Id: I5a0f4c929c9f90f06f67a68c3a1bcfc4939f9cc8
Bartlomiej Kunikowski [Thu, 20 Oct 2016 08:34:21 +0000 (10:34 +0200)]
Fix for MountUpdateMode_Rollback
Requires:
- https://review.tizen.org/gerrit/#/c/97897/
To verify run wgt-backend smoke test
Change-Id: I08198a4003acd457f2a8282d143a8272df53feb2
Bartlomiej Kunikowski [Mon, 17 Oct 2016 10:53:12 +0000 (12:53 +0200)]
Fix smoke tests for hybrid packages
Change-Id: I0d475b40ad6251184fcbef992e1cf5008c7fe2b6
jongmyeongko [Tue, 22 Nov 2016 07:43:12 +0000 (16:43 +0900)]
apply extended concept of package's attribute.
Requires :
https://review.tizen.org/gerrit/#/c/99039/
Change-Id: I3da722ec30cd00554b9fe9e00b001bb6922a8cbf
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
Sangyoon Jang [Mon, 21 Nov 2016 07:00:25 +0000 (16:00 +0900)]
Implement wgt backend library
This backend library is for getting package information from file.
The functions are called by dlsym from pkgmgr_client api.
(Refer to: https://review.tizen.org/gerrit/73286)
Change-Id: I547fae4bf0a431a28826ef8c4f6e83768c4acc18
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Thu, 17 Nov 2016 10:34:46 +0000 (19:34 +0900)]
Adjust to privilege verification API change
Requires:
- https://review.tizen.org/gerrit/98384
- https://review.tizen.org/gerrit/98161
Change-Id: Idf6d33b3216466f23efbcb0ad2d1c25ea131936a
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
jongmyeong ko [Thu, 17 Nov 2016 14:21:50 +0000 (06:21 -0800)]
Merge "Fix StepCreateStorageDirectores" into tizen_3.0
Piotr Ganicz [Tue, 15 Nov 2016 09:35:47 +0000 (10:35 +0100)]
[Coding style] Wgt step reorder as tpk
This commit reoders step RegisterApplication with RegisterSecurity as
it is done in Tpk installer. It could be done because that steps
do not depend of each other.
Change-Id: Ia30152f749f0b5a360bdabcfad032142e84cdd5f
Piotr Ganicz [Tue, 15 Nov 2016 08:02:01 +0000 (09:02 +0100)]
Fix StepCreateStorageDirectores
This patch provides proper handling for following test case:
1. Crash installation before StepGenerateXML
2. Install again
3. The installation should be successful
Change-Id: Ic55d86d5164ecb1f596f7ddc7d51cf16a0f6268e
Sangyoon Jang [Thu, 17 Nov 2016 10:36:31 +0000 (19:36 +0900)]
Add StepCheckInstallable
Requires:
- https://review.tizen.org/gerrit/98476
Change-Id: I13c733301b6b57f92533a7a451ccb920b1c86635
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Piotr Ganicz [Wed, 16 Nov 2016 15:37:34 +0000 (16:37 +0100)]
Fix manifest preload location
This patch sets manifest location for preload request to TZ_SYS_RO_PACKAGES.
Change-Id: I678e78981fdcb8698d1cda8f1b5eba7bf6173e49
Tomasz Iwanek [Thu, 15 Sep 2016 10:25:48 +0000 (12:25 +0200)]
Fixing rollback
This patch should fix:
1) Situation when backup files are not fully restored when
file that has been backed up wasn't removed yet -> file
is not restored (new flag: FS_MERGE_OVERWRITE)
2) Situation when backup file was not fully copied and we
restore broken copy (new flag: FS_COMMIT_COPY_FILE)
Submit together:
- https://review.tizen.org/gerrit/88235
- https://review.tizen.org/gerrit/88236
Change-Id: I49baa0c194b6247d33f40cc804610eb32aafe490
Tomasz Iwanek [Fri, 30 Sep 2016 08:07:13 +0000 (10:07 +0200)]
Reworking handling privileges for hybrid application
This patch keeps single list of privileges (stored in
manifest_x) and filters privileges when registring
security rules of applications. Following changed:
- generated platform manifest xml contains <privilege>
tags with 'type' atttibute set to 'tpk' or 'wgt',
- in case of absence of attribute, its default value
is 'tpk',
- manifest_x changes privilege type from GList of char*
to GList of privilege_x. Structure named 'privilege_x'
contain parsed privilege type,
- although there is one privilege list, given the fact
that privilege now have type, native and web privileges
should be registered in native or web apps only.
Verification:
- no regression in tpk/wgt smoke tests,
- install hybrid app with native and web privileges
and check generated manifest file for privileges,
- install web app with privileges and check generated
manifest file,
- install web app without privileges and check generated
manifest file -> default privileges should be added.
Submit together:
- https://review.tizen.org/gerrit/#/c/90540/
- https://review.tizen.org/gerrit/#/c/90543/
- https://review.tizen.org/gerrit/#/c/90544/
- https://review.tizen.org/gerrit/#/c/90546/
- https://review.tizen.org/gerrit/#/c/90561/
Change-Id: I4ec7c8714a55917dbda665bf2a1c08ca30ce3f97
Tomasz Iwanek [Fri, 30 Sep 2016 08:48:38 +0000 (10:48 +0200)]
Revert "Fix checking privilege level for hybrid apps"
Following commit will reimplement this bug fix.
This reverts commit
3002913a84371529abcb09bc7f51857bd3a3899a.
Change-Id: I6334d50351fe49daedf543322738b102de2444f5
Sangyoon Jang [Mon, 17 Oct 2016 11:02:15 +0000 (20:02 +0900)]
Temporary fix for hybrid pkg installation
Submit together:
- https://review.tizen.org/gerrit/92583
- https://review.tizen.org/gerrit/92584
- https://review.tizen.org/gerrit/92585
Change-Id: If9ab9d27126568e12efadcaea50988ab57cd4c5f
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Sangyoon Jang [Mon, 17 Oct 2016 11:00:32 +0000 (20:00 +0900)]
Fix step order of hybrid installer
Parser plugins should be run after pakcage registration.
Change-Id: I0635000604e28c28e88a7e3d56b69a972fec533a
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Tomasz Iwanek [Fri, 7 Oct 2016 08:56:10 +0000 (10:56 +0200)]
Patch reinstall/RDS according to SDK behaviour
Commit changes reinstall request argument. Now pkgid
is expected instead of path to directory. What is more,
if package manifest is not in the directory supplied by
reinstall/RDS then it will be copied from install location.
Application installer expects that SDK will put files into:
- local installation:
/home/$USERNAME/apps_rw/tmp/$PKGID/
- global installation:
/opt/apps/tmp/$PKGID/
Requires:
- https://review.tizen.org/gerrit/91412
Submit together:
- https://review.tizen.org/gerrit/91430
- https://review.tizen.org/gerrit/91431
- https://review.tizen.org/gerrit/91432
Verification:
- run smoke tests,
- run reinstall from SDK,
- run RDS from SDK.
Change-Id: I7a5008c6a5d9d28f4181a0be92d42dc9c8e57e28
Sangyoon Jang [Tue, 4 Oct 2016 08:49:40 +0000 (17:49 +0900)]
Fix WgtAppQueryInterface
Don't parse again argv, argc.
They are already parsed by PkgMgrInterface.
Requires:
- https://review.tizen.org/gerrit/90478
Change-Id: I2ab9f8ad291f97070d38617e1fd4cb15bb9e986a
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
Tomasz Iwanek [Mon, 26 Sep 2016 09:12:48 +0000 (11:12 +0200)]
Fix checking privilege level for hybrid apps
There are two facts:
- we need to store all privileges into pkgmgr database,
- we need to check privilege level for native and web
privileges separatelly in case of hybrid application.
Therefore, merging of native and web privilege is delayed till
checking privilege level. Installing of hybrid app will involve
customized step for checking privilege level.
Requires:
- https://review.tizen.org/gerrit/89685
Change-Id: I7bb044e4ddb6de488e959b8433105bc22c82f0c1
Piotr Ganicz [Fri, 30 Sep 2016 09:24:43 +0000 (11:24 +0200)]
Coding style
Change-Id: Ib507c02e3202cd96df63a1fddf8d51fa8cb7f163
Cho Woong Suk [Thu, 29 Sep 2016 06:38:46 +0000 (15:38 +0900)]
return origin string instead of VersionNumber
Change-Id: Iccfd3060bf79266efefb28e1dda002b578150cbe
Tomasz Iwanek [Mon, 26 Sep 2016 12:22:38 +0000 (14:22 +0200)]
Set nodisplay for downloadable_font and tts category apps
These apps aren't supposed to be run.
Change-Id: I332a5dae817d627db764086baf2413878da9fe95
Tomasz Iwanek [Thu, 15 Sep 2016 12:53:42 +0000 (14:53 +0200)]
Check private data files preservation in smoke tests
Change-Id: I1de7c32e4c9fe14f0a781e5d1f328dea62c9a02b
Bartlomiej Kunikowski [Wed, 21 Sep 2016 08:35:32 +0000 (10:35 +0200)]
Add more smoke test for hybrid/wgt package in wgt
Run smoke tests to verify.
If you applied patch
- https://review.tizen.org/gerrit/#/c/88124/
there are:
[ FAILED ] SmokeTest.MountInstallationMode_Hybrid
[ FAILED ] SmokeTest.MountUpdateMode_Hybrid
[ FAILED ] SmokeTest.UpdateMode_Rollback_Hybrid
[ FAILED ] SmokeTest.MountUpdateMode_Rollback_Hybrid
[ FAILED ] SmokeTest.MountInstallationMode_Rollback
[ FAILED ] SmokeTest.MountUpdateMode_Rollback
This will be fixed separately.
Change-Id: I615266eb01f1abfc2861547aa62791f820d2cf65
Bartlomiej Kunikowski [Thu, 15 Sep 2016 14:22:23 +0000 (16:22 +0200)]
Fix smoke test - add missing assertions
Change-Id: I3de08191f7c764d78da743e9e24055f0c4f5bcb3
Tomasz Iwanek [Tue, 13 Sep 2016 12:07:08 +0000 (14:07 +0200)]
Fix ValidatePackageFS in smoke tests
Run smoke tests to verify.
Change-Id: I4018ffd9d94aadc764e9b1fcea066896212b8715
Junghyun Yeon [Tue, 20 Sep 2016 05:05:29 +0000 (14:05 +0900)]
Put metadata of app-widget into application_x
Put metadata of app-widget at parsing time to
Insert it into app metadata db
Change-Id: I877fabfc4f324439344632a0a4909b9fe07a7b81
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
woongsuk cho [Mon, 19 Sep 2016 22:57:56 +0000 (15:57 -0700)]
Merge "Fix for StepParse - additional conditions checking for watch category in manifest" into tizen
Bartlomiej Kunikowski [Mon, 19 Sep 2016 11:03:15 +0000 (13:03 +0200)]
Fix for StepParse - additional conditions checking for watch
category in manifest
Change-Id: I1a1051fc466616df92dd1e5b02e34d4a6e872dce
jongmyeongko [Mon, 19 Sep 2016 07:49:23 +0000 (16:49 +0900)]
remove the profile macro in the spec file. it's not used.
Change-Id: Id3cd1253f824980766f664580f0219bf189873a4
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
Bartlomiej Kunikowski [Tue, 13 Sep 2016 10:08:55 +0000 (12:08 +0200)]
Nodisplay setting handling for webapp and checking privilege level for
sound-mode and nodisplay
Change-Id: I6b218368ad5a747edb9c08c420abbb443286618b
Tomasz Iwanek [Wed, 7 Sep 2016 09:13:12 +0000 (11:13 +0200)]
Fix generation of widget-application for hybrid apps
Removed statement was performing invalid check. In hybrid apps
we can generate widget-application for wgt as well as native app.
If native part of package declared widget-application, installation
fails. Therefore, this check was removed.
Change-Id: Ie1fb73e33daf037fc613abacf967b305635ad5ed
Bartlomiej Kunikowski [Fri, 9 Sep 2016 09:30:43 +0000 (11:30 +0200)]
Fix change owner for recovery mode
Requires:
- https://review.tizen.org/gerrit/#/c/87795/
Change-Id: I9b12839a97a748cc2fdb4e134903e7d869c8a29c
Bartlomiej Kunikowski [Fri, 9 Sep 2016 09:06:45 +0000 (11:06 +0200)]
Add package file ownership checking to smoke tests
All tests passed after making fixes:
- https://review.tizen.org/gerrit/#/c/87795/
- https://review.tizen.org/gerrit/#/c/87797/
Change-Id: Ic25afade3f3ffe4279a0ddf2562ba9c5420abff8
Tomasz Iwanek [Mon, 12 Sep 2016 08:25:28 +0000 (10:25 +0200)]
Buildbreak fix
Change-Id: Id966e9f9b2c75ea572c8c8184afc329dfd134053
Junghyun Yeon [Thu, 8 Sep 2016 07:07:32 +0000 (16:07 +0900)]
add and fix step for fota and direct install
- Add StepWgtPatchIcons at ManifestDirectInstall and Update to work it properly
- Fix StepWgtPatchIcons to overwrite icon even exists
Related changes
[pkgmgr-tool] : https://review.tizen.org/gerrit/#/c/83327/
[app-installers] : https://review.tizen.org/gerrit/#/c/86789/
[tpk-backend] : https://review.tizen.org/gerrit/#/c/86846/
Change-Id: I9a13d6af490832e0a48fd8e837a7bc29aeb60648
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Piotr Ganicz [Thu, 8 Sep 2016 12:33:54 +0000 (14:33 +0200)]
Fix installation User Defined Plugins
Change-Id: I0e71b358bf437a40980881c5fc23ce095bd5012b
Piotr Ganicz [Thu, 8 Sep 2016 08:56:32 +0000 (10:56 +0200)]
Unit test for User Definded Plugin
Change-Id: I3ca99aae0e79320941a1bb2b8ef9ee410ac75738
Piotr Dabrowski [Wed, 7 Sep 2016 12:31:12 +0000 (14:31 +0200)]
Fix installation of icons for hybrid applications
Change-Id: I41ce7308a6e7abb7f55b3fb002639fad580a4c57
Tomasz Iwanek [Thu, 1 Sep 2016 11:54:40 +0000 (13:54 +0200)]
Recovery mode for mount install and mount update
To verify, run new smoke tests.
Recovery mode requires mounting zip package.
Signature files which needs to be read in next
step are within zip package.
Requires:
- https://review.tizen.org/gerrit/86739
Change-Id: I857ecea3dae3836cf9a0af2c11766481a016847e
Tomasz Iwanek [Wed, 31 Aug 2016 09:48:58 +0000 (11:48 +0200)]
Set correct exec label for smoke tests
Otherwise, running from shell gives
"System::Privileged" instead of "System".
To verify run:
$ usermod -s /bin/bash app_fw
$ chsmack -a _ /etc/passwd
$ su - app_fw
$ /usr/bin/wgt-backend-ut/smoke-test
Change-Id: If2f314f77daeb28b4af4cd3568cc3ac52bbd1354
Bartlomiej Kunikowski [Mon, 5 Sep 2016 13:29:49 +0000 (15:29 +0200)]
Fix double parsing of config.xml in delta wgt mode
Fixed by add a optional delay in checking existence of start files
and adding new step
Requires:
- https://review.tizen.org/gerrit/#/c/86941/
Change-Id: I9efed825d5f04af28493a6bd0003e3b9d6efb3c8
Piotr Dabrowski [Thu, 1 Sep 2016 13:37:33 +0000 (15:37 +0200)]
Fixes after cppcheck
> [wgt-backend/src/wgt/step/encryption/step_encrypt_resources.cc:175]: (error) Resource leak: input
> [wgt-backend/src/wgt/step/encryption/step_encrypt_resources.cc:251]: (error) Deallocating a deallocated pointer: output
> [wgt-backend/src/wgt/extension_config_parser.cc:27]: (performance) Variable 'config_xml_' is assigned in constructor body. Consider performing initialization in initialization list.
Change-Id: I4386dd4b5923566cc2e7ce941144496200fe139b
Tomasz Iwanek [Tue, 30 Aug 2016 14:17:57 +0000 (16:17 +0200)]
Smoke test for delta recovery
To verify, run new smoke test.
Requires:
- https://review.tizen.org/gerrit/#/c/86119/
Change-Id: I612a4cf568646787463e05dc874f77af7f5c55e5
JongHeon Choi [Wed, 31 Aug 2016 04:45:30 +0000 (13:45 +0900)]
Revert "Revert "Force uninstall for external storage packages""
This reverts commit
3b44494fae615048b82f7dac6905cc9aa23e2bfb.
Change-Id: I113e8f2ec6a37a630dd052513d7a88dc6712c407
JongHeon Choi [Wed, 31 Aug 2016 04:44:22 +0000 (13:44 +0900)]
Revert "Force uninstall for external storage packages"
This reverts commit
0019e1abf93a2d5b1ed056c63a299f3e34db45de.
Change-Id: Ieafc64859bb0648aed01a21d71836d66ac5ad1a6
JongHeon Choi [Thu, 28 Jul 2016 06:19:06 +0000 (15:19 +0900)]
File encryption method reading whole files into a dynamic stack buffer
Related changes:
[crosswalk-tizen] https://github.com/crosswalk-project/crosswalk-tizen/pull/135
https://review.tizen.org/gerrit/#/c/83459/
Change-Id: I87d41c578e161622035e65e324b3d9590e2c266e
Bartlomiej Kunikowski [Tue, 30 Aug 2016 11:26:04 +0000 (13:26 +0200)]
Force uninstall for external storage packages
Now errors from StepAcquireExternalStorage are ignored in uninstall mode
by using StepOptionalAcquireExternalStorage instead of old step.
Requires:
- https://review.tizen.org/gerrit/#/c/86078/
Change-Id: I07efa35829566b928208b6312180a24f6e1c66a4
Tomasz Iwanek [Wed, 17 Aug 2016 08:06:08 +0000 (10:06 +0200)]
Add StepChangeOwner for HybridInstaller
Complementary changes to: https://review.tizen.org/gerrit/#/c/84185/
To verify, install hybrid package and check that files of installed package
have owner's ownership.
Change-Id: I8a644be5567acd1a6ce800225cb9050043c32f76
Tomasz Iwanek [Tue, 23 Aug 2016 09:51:27 +0000 (11:51 +0200)]
Modify getting icon list
Installer (now) provides xml:lang localization of icon items in
platform manifest. This information is generated from folder
based localization of wgt package.
From now:
- icon list returned by handler contains only valid <icon> tag
related positions, this will prevent parser from modifing
constant data,
- client will need to pass icon list from handler to utility
function (together with base path) to get localized custom
and default icon list that can be used in runtime or for
platform manifest <icon> tag assignment,
- installer generates list of localized icons and for each
available locale icon element in manifest_x is created.
Submit together:
- https://review.tizen.org/gerrit/85076
- https://review.tizen.org/gerrit/85078
Change-Id: I8797bfa57f185d679dd5b6cbea4278658bedd7a2