Philip Withnall [Thu, 30 Dec 2010 17:59:37 +0000 (17:59 +0000)]
Fix some variable names in the inspector signal parsing code
See: https://bugzilla.gnome.org/show_bug.cgi?id=629075#c8
Philip Withnall [Mon, 6 Sep 2010 18:38:21 +0000 (19:38 +0100)]
Bug 629075 — Add folks command line application
Add an interactive command line inspection utility for libfolks.
Closes: bgo#629075.
Travis Reitter [Thu, 30 Dec 2010 17:23:31 +0000 (09:23 -0800)]
Add NEWS entry for bgo#629083 fix
Travis Reitter [Thu, 30 Dec 2010 17:22:24 +0000 (09:22 -0800)]
Add NEWS entry for bgo#638311 fix
Travis Reitter [Wed, 29 Dec 2010 01:21:53 +0000 (17:21 -0800)]
Refer to non-local variables and methods with full name.
The benefit here is to make it easier to tell when variables are local. Methods
are referred to similarly for consistency.
Fixes bgo#629083
Travis Reitter [Wed, 29 Dec 2010 00:58:34 +0000 (16:58 -0800)]
Cut unnecessary casting.
Excessive casting can hide real compiler warnings/errors and is best avoided.
Helps bgo#629083
Travis Reitter [Tue, 28 Dec 2010 17:15:23 +0000 (09:15 -0800)]
Maximize use of 'unowned' keyword.
This is used when (and only when) variables:
1. would avoid a non-trivial copy (eg, a string or array but not an int or
object ref-count increase)
AND
2. will only be assigned unowned values (excessive use of 'unowned' here will be
caught by the compiler)
The net benefit is avoiding unecessary memory allocation/freeing.
Helps bgo#629083
Travis Reitter [Tue, 28 Dec 2010 01:22:21 +0000 (17:22 -0800)]
Maximize use of the 'var' keyword.
This is used whenever a variable:
1. is declared and initialized in the same line
AND
2. would not avoid a copy by using the 'unowned'. In the future, we may be able
to declare variables 'unowned var', in which case this point won't matter. See
bgo#638199.
The net benefit is less noise on variable declaration lines.
Helps bgo#629083
Travis Reitter [Tue, 28 Dec 2010 01:14:45 +0000 (17:14 -0800)]
Ensure private and internal methods begin with a _
Helps bgo#629083
Travis Reitter [Tue, 28 Dec 2010 00:28:38 +0000 (16:28 -0800)]
Ensure private and internal data members begin with a _
Helps bgo#629083
Travis Reitter [Wed, 29 Dec 2010 23:55:44 +0000 (15:55 -0800)]
Write down development policies.
Fixes bgo #638311.
Philip Withnall [Fri, 17 Dec 2010 11:16:04 +0000 (11:16 +0000)]
Bug 637240 — libfolks-telepathy.so exports private symbols
Limit the symbols exported by the libfolks-telepathy.so library to those
starting with “tpf_”. Based on a patch by
Emilio Pozuelo Monfort <pochu27@gmail.com>. Closes: bgo#637240
Philip Withnall [Mon, 13 Dec 2010 16:49:18 +0000 (16:49 +0000)]
Post-release version bump
Philip Withnall [Mon, 13 Dec 2010 16:45:07 +0000 (16:45 +0000)]
Release version 0.3.3
Philip Withnall [Mon, 13 Dec 2010 16:40:29 +0000 (16:40 +0000)]
Add missing files to POTFILES.in and POTFILES.skip
Philip Withnall [Mon, 13 Dec 2010 16:35:59 +0000 (16:35 +0000)]
Remove outdated translation files from EXTRA_DIST
They're no longer copied into the build tree since we no longer call
autopoint. See: bgo#635649
Philip Withnall [Mon, 13 Dec 2010 15:35:38 +0000 (15:35 +0000)]
Ensure each Persona is added to the relinked_personas list at most once
In some cases when relinking the user's Individual when taking Empathy
offline, several of the user's Personas can get into the relinked_personas
list multiple times. This causes an infinite loop of linking and relinking
those Personas. Closes: bgo#637136
Philip Withnall [Sun, 12 Dec 2010 17:52:52 +0000 (17:52 +0000)]
Bug 636714 — Assertion failure on invalid IM address
Handle invalid IM addresses in relationships.ini more gracefully by throwing
an exception from IMable.normalise_im_address() if it detects an invalid
address, rather than aborting due to an assertion failure. Closes: bgo#636714
Philip Withnall [Mon, 13 Dec 2010 15:23:15 +0000 (15:23 +0000)]
Don't trust personas from IRC
Philip Withnall [Sun, 12 Dec 2010 18:32:51 +0000 (18:32 +0000)]
Rename the Favourite interface to Favouritable
Closes: bgo#627397
Philip Withnall [Sun, 12 Dec 2010 18:28:20 +0000 (18:28 +0000)]
Rename the Presence interface to HasPresence
Helps: bgo#627397
Philip Withnall [Sun, 12 Dec 2010 18:24:08 +0000 (18:24 +0000)]
Rename the Avatar interface to HasAvatar
Helps: bgo#627397
Philip Withnall [Sun, 12 Dec 2010 17:44:35 +0000 (17:44 +0000)]
Add recent bug fixes to NEWS file
Philip Withnall [Sun, 12 Dec 2010 17:06:38 +0000 (17:06 +0000)]
Add documented libraries to LDFLAGS in the documentation Makefile.am
gtkdoc-scangobj expects to have the libraries it's linking its scanner program
to present in LDFLAGS. gtk-doc.make normally does this automatically for
normal gtk-doc-enabled projects, but we need to do it manually.
Philip Withnall [Sun, 12 Dec 2010 16:34:01 +0000 (16:34 +0000)]
Add missing documentation for method parameters
Philip Withnall [Sun, 12 Dec 2010 16:29:07 +0000 (16:29 +0000)]
Fix documentation of enum members
The documentation comments for enum members have to be proper valadoc comments
(i.e. starting with /** and ending with */ on separate lines).
Philip Withnall [Sun, 12 Dec 2010 16:18:57 +0000 (16:18 +0000)]
Fix string length calculation in the BackendStore for Vala 0.12
Philip Withnall [Sun, 12 Dec 2010 16:18:01 +0000 (16:18 +0000)]
Remove use of deprecated GLib API in Vala 0.12
Philip Withnall [Sun, 12 Dec 2010 16:15:22 +0000 (16:15 +0000)]
Remove use of Unicode characters in documentation comments
The normal valadoc doclet is fine with them, but the gtkdoc doclet doesn't
like them. See: bgo#637072
Travis Reitter [Mon, 18 Oct 2010 20:00:13 +0000 (13:00 -0700)]
Generate gtk-doc for libfolks and libfolks-telepathy.
Philip Withnall [Sun, 12 Dec 2010 11:09:12 +0000 (11:09 +0000)]
Don't delete in-tree m4 macros when doing maintainer-clean
Philip Withnall [Sun, 12 Dec 2010 11:04:58 +0000 (11:04 +0000)]
Remove libtool m4 macros from the git tree
They're copied into the build tree from the system libtool installation by
libtoolize, and don't belong in git.
Stef Walter [Wed, 1 Dec 2010 20:50:22 +0000 (20:50 +0000)]
Bug 636251 — Fails to add contact
Vala compiles this line of code wrong, and tries to double check
that there is a GValue boxed inside of the GValue.
Closes: bgo#636251
Robert Ancell [Fri, 26 Nov 2010 03:32:39 +0000 (14:32 +1100)]
Bug 635823 — Link telepathy test program to GIO
Closes: bgo#635823
Philip Withnall [Sat, 27 Nov 2010 21:32:41 +0000 (21:32 +0000)]
Bug 635703 – Leak in connection_get_requestable_channel_classes_cb
Tidy up memory handling in the function so that it doesn't leak in odd
conditions. Closes: bgo#635703
Philip Withnall [Sat, 27 Nov 2010 21:17:56 +0000 (21:17 +0000)]
Fix return types and documentation for a tp-lowlevel.c method
folks_tp_lowlevel_connection_get_requestable_channel_classes_finish() had
incorrect return values in assertion failure conditions, and the
documentation said to use the wrong function to free its return value.
Philip Withnall [Sat, 27 Nov 2010 21:08:12 +0000 (21:08 +0000)]
Bug 635649 — autopoint fails to run
Since the changes due to bgo#635134, we should no longer call autopoint in
autogen.sh. Closes: bgo#635649
Philip Withnall [Mon, 22 Nov 2010 22:06:04 +0000 (22:06 +0000)]
Don't use IT_PROG_INTLTOOL and AM_GNU_GETTEXT
They conflict. See bgo#635134.
Philip Withnall [Thu, 18 Nov 2010 21:20:17 +0000 (21:20 +0000)]
Fix leak in tp-lowlevel.c
Closes: bgo#635178
Travis Reitter [Sun, 14 Nov 2010 23:58:42 +0000 (15:58 -0800)]
Release 0.3.2
Travis Reitter [Mon, 15 Nov 2010 00:30:26 +0000 (16:30 -0800)]
Relocate the g-i scanner args in configure for consistency.
Travis Reitter [Mon, 15 Nov 2010 00:29:40 +0000 (16:29 -0800)]
Fix syntax errors for the release version of configure.
Travis Reitter [Sun, 14 Nov 2010 23:28:23 +0000 (15:28 -0800)]
Ensure vapi files have an appropriate age.
Vapigen doesn't update the age of vapi files if they don't change. This means
that make will always generate them during distcheck, implicitly requiring
vapigen.
Helps bgo#633718.
Travis Reitter [Sun, 14 Nov 2010 21:21:56 +0000 (13:21 -0800)]
Cast Individuals to Presence as necessary for the tests.
Philip Withnall [Sat, 13 Nov 2010 14:32:28 +0000 (14:32 +0000)]
Fix notification order in backends
Philip Withnall [Fri, 17 Sep 2010 11:00:19 +0000 (12:00 +0100)]
Remove the exception from Tpf.Persona's constructor
It was not possible for it to ever be thrown (since TpContact.get_identifier()
is guaranteed to always return a valid ID, and having *_new() methods throw
exceptions is never a good idea. (GInitable should be used instead.)
This breaks both the Vala and C APIs.
Helps: bgo#629078
Philip Withnall [Fri, 10 Sep 2010 14:45:30 +0000 (15:45 +0100)]
Hide setter for Persona.linkable_properties
Philip Withnall [Fri, 10 Sep 2010 14:25:31 +0000 (15:25 +0100)]
Remove casting convenience functions in Individual
They're not needed for Vala, and weren't particularly well thought
out (or complete) in C.
Philip Withnall [Fri, 10 Sep 2010 14:20:51 +0000 (15:20 +0100)]
Hide setter for Backend.persona_stores
Philip Withnall [Fri, 10 Sep 2010 14:13:29 +0000 (15:13 +0100)]
Hide setter for Backend.name
Philip Withnall [Fri, 10 Sep 2010 13:57:01 +0000 (14:57 +0100)]
Hide setters for PersonaStore.type_id, .display_name and .id
Philip Withnall [Sat, 13 Nov 2010 12:07:33 +0000 (12:07 +0000)]
Ensure we use string's byte length in both Vala 0.10 and 0.12
string.length gives the byte length in Vala 0.12 and string.size() is
deprecated, however string.length gives the character length in Vala 0.10,
so we need to conditionally change the code for Vala <= 0.10.
Re-closes: bgo#628930
Philip Withnall [Sun, 7 Nov 2010 21:56:42 +0000 (21:56 +0000)]
Consolidate persona link removal code
Philip Withnall [Sun, 7 Nov 2010 21:46:09 +0000 (21:46 +0000)]
Remove links to personas before they're relinked in the aggregator
If one persona is removed from a non-singleton individual (e.g. because they
went offline), the other personas in the individual will be relinked into new
individuals (singleton or not). We previously didn't ensure that the entries
in the link map corresponding to these personas were removed before the
personas were relinked which, under certain circumstances (which I haven't
fully explored), could cause the personas to be relinked to the individual
which had just been removed. This would cause the individual's persona list
to grow exponentially, and generally Bad Things to happen.
I could reproduce this situation by logging into two accounts, both of which
had the other added to their roster. The resulting four personas corresponding
to the two accounts (2 user personas and 2 normal personas) would be linked
to form one user individual. Going offline and then online again would trigger
the bug.
Closes: bgo#633080
Philip Withnall [Sun, 31 Oct 2010 16:26:51 +0000 (16:26 +0000)]
Combine personas_changed() emissions for Individuals replaced due to relinking
This re-fixes bgo#632564 so that the optimisation of grouping emissions of
the personas_changed() signal is preserved. Closes: bgo#632564
Philip Withnall [Sun, 31 Oct 2010 16:25:56 +0000 (16:25 +0000)]
Improve debug output of the aggregator
Add an indication as to whether personas are the user.
Travis Reitter [Thu, 11 Nov 2010 02:26:35 +0000 (18:26 -0800)]
Note the recent build clean-ups in the NEWS.
Travis Reitter [Thu, 11 Nov 2010 02:19:12 +0000 (18:19 -0800)]
Un-break distclean for the general test library
Travis Reitter [Thu, 11 Nov 2010 02:09:46 +0000 (18:09 -0800)]
Un-break distclean for the Telepathy test library
Travis Reitter [Thu, 11 Nov 2010 01:55:11 +0000 (17:55 -0800)]
Un-break distclean for the tests
Travis Reitter [Thu, 11 Nov 2010 01:41:38 +0000 (17:41 -0800)]
Un-break distclean for the Telepathy backend
Travis Reitter [Wed, 10 Nov 2010 23:49:27 +0000 (15:49 -0800)]
Distribute the key-file test library VAPI
Travis Reitter [Wed, 10 Nov 2010 23:11:48 +0000 (15:11 -0800)]
Add the Telepathy test library g-i and Vala files to DISTCLEANFILES
Travis Reitter [Wed, 10 Nov 2010 20:02:53 +0000 (12:02 -0800)]
Add missing general test VAPI distribution.
Travis Reitter [Wed, 10 Nov 2010 19:59:46 +0000 (11:59 -0800)]
Simplify the tp contactlist test lib build
Travis Reitter [Wed, 10 Nov 2010 17:50:54 +0000 (09:50 -0800)]
Simplify the Telepathy backend Makefile.
Travis Reitter [Wed, 10 Nov 2010 16:50:41 +0000 (08:50 -0800)]
Remove deprecated use of string.size()
Travis Reitter [Wed, 10 Nov 2010 03:16:13 +0000 (19:16 -0800)]
Add missing GIO linking options to the general tests.
Travis Reitter [Tue, 9 Nov 2010 07:08:02 +0000 (23:08 -0800)]
Support Vala-free builds (for release tarballs).
Fixes bgo#633718.
Travis Reitter [Tue, 9 Nov 2010 23:38:16 +0000 (15:38 -0800)]
Soften the valadoc requirement, even with --enable-docs.
This is mainly so tarball-based builds don't break if valadoc isn't availble
(but it will be used if it is).
Helps bgo#633718.
Travis Reitter [Tue, 9 Nov 2010 22:56:11 +0000 (14:56 -0800)]
Fix the distribution and cleanfile status of the tp-lowlevel.gir files
Helps bgo#633718.
Travis Reitter [Tue, 9 Nov 2010 22:23:22 +0000 (14:23 -0800)]
Distribute the generated tp-backend vapi files.
Helps bgo#633718.
Travis Reitter [Tue, 9 Nov 2010 19:29:18 +0000 (11:29 -0800)]
Re-arrange some build in the Telepathy tests.
Helps bgo#633718.
Travis Reitter [Tue, 9 Nov 2010 19:02:34 +0000 (11:02 -0800)]
Don't force building the tp-test vapi file in dist.
Helps bgo#633718.
Travis Reitter [Tue, 9 Nov 2010 07:04:55 +0000 (23:04 -0800)]
Depend upon the Telepathy backend stamp files.
This lets us depend upon them for Vala-free builds from release tarballs.
Helps bgo#633718.
Travis Reitter [Mon, 8 Nov 2010 23:58:10 +0000 (15:58 -0800)]
Distribute the backend store test key files.
Travis Reitter [Mon, 8 Nov 2010 23:48:20 +0000 (15:48 -0800)]
Point the tests at the uninstalled backends.
Travis Reitter [Mon, 8 Nov 2010 22:50:11 +0000 (14:50 -0800)]
Load backends from FOLKS_BACKEND_PATH instead of _DIR.
The string is :-delimited and accepts both directories and backend library
files. Eg,
FOLKS_BACKEND_PATH="/path/to/dir:/path/to/backend.so"
This is so we may refer to our known backends directly when running the tests
(and not depend upon them being installed first).
Travis Reitter [Thu, 4 Nov 2010 21:11:46 +0000 (14:11 -0700)]
Distribute the kf-test header.
Travis Reitter [Thu, 4 Nov 2010 21:00:34 +0000 (14:00 -0700)]
Don't distribute a generated po/missing file.
Travis Reitter [Mon, 8 Nov 2010 18:57:23 +0000 (10:57 -0800)]
Don't ever claim to own the backend GLib.Modules.
Travis Reitter [Mon, 8 Nov 2010 16:12:51 +0000 (08:12 -0800)]
Annotate some of the test functions, to appease g-ir.
Mario Blättermann [Sat, 6 Nov 2010 19:36:25 +0000 (20:36 +0100)]
[l10n] Added initial German translation
Travis Reitter [Fri, 5 Nov 2010 00:28:48 +0000 (17:28 -0700)]
Always explicitly iterate through a HashMap's keys, values, or entries.
Travis Reitter [Thu, 4 Nov 2010 21:53:07 +0000 (14:53 -0700)]
Don't try to (invalidly) import an enum.
Philip Withnall [Wed, 20 Oct 2010 17:00:10 +0000 (18:00 +0100)]
Add new internationalisation files to CLEANFILES
Helps: bgo#628883
Philip Withnall [Wed, 20 Oct 2010 16:51:41 +0000 (17:51 +0100)]
Update log handlers in the test suite
Due to string changes in the rest of libfolks, the log handlers in the test
suite need changing to fix the test suite. Helps: bgo#628883
Philip Withnall [Mon, 6 Sep 2010 14:43:42 +0000 (15:43 +0100)]
Mark strings for translation and improve string formatting a little
This marks every potentially-user-visible string in libfolks for translation.
These include error messages, warnings and criticals. This also improves the
formatting and wording of some of the messages, and changes others to make
them more easily translatable. Closes: bgo#628883
Philip Withnall [Mon, 6 Sep 2010 13:32:16 +0000 (14:32 +0100)]
Bug 628883 — Add localisation support
Add gettext/intltool build system support, but don't mark any strings for
translation yet. Helps: bgo#628883
Travis Reitter [Thu, 4 Nov 2010 00:38:13 +0000 (17:38 -0700)]
Treat CONNECTING as a valid state for a TpConnection.
Travis Reitter [Mon, 1 Nov 2010 19:01:40 +0000 (12:01 -0700)]
Add backend state key files for most tests.
Only Folks-core tests are concerned with specifically testing the Backend
enabling/disabling code (which is bulkier than out-of-sight settings files).
Philip Withnall [Thu, 16 Sep 2010 16:46:32 +0000 (17:46 +0100)]
Disable unused backends in the tests.
Helps bgo#629862.
Philip Withnall [Thu, 16 Sep 2010 14:00:04 +0000 (15:00 +0100)]
Add some initial key-file backend tests
Fixes bgo#629862.
Philip Withnall [Thu, 16 Sep 2010 13:29:03 +0000 (14:29 +0100)]
Add a key-file test library
This contains some of the boilerplate code necessary to test the key-file
backend with arbitrary key files.
Helps bgo#629862.
Travis Reitter [Tue, 2 Nov 2010 16:53:29 +0000 (09:53 -0700)]
Make BackendStore.load_backends() unload disabled backends.
This also allows this function to be called multiple times (previously,
subsequent calls were ignored).
Fixes bgo#629081.
Travis Reitter [Tue, 2 Nov 2010 02:08:43 +0000 (19:08 -0700)]
Add a test of backend disabling.
Helps bgo#629081.
Travis Reitter [Fri, 29 Oct 2010 23:49:14 +0000 (16:49 -0700)]
Add initial BackendStore test.
Helps bgo#629081.
Travis Reitter [Tue, 2 Nov 2010 00:48:19 +0000 (17:48 -0700)]
Don't use an extraneous main loop and watchdog for all tests.
Travis Reitter [Sat, 30 Oct 2010 00:27:02 +0000 (17:27 -0700)]
Cut ignored libfolks-test link options.
Travis Reitter [Fri, 29 Oct 2010 23:44:24 +0000 (16:44 -0700)]
Fix the path for the Tp tests D-Bus service dir.