Thomas H. P. Andersen [Tue, 21 Feb 2017 23:14:54 +0000 (00:14 +0100)]
coredump: fix assign in while loop (#5417)
From: #5393
Zbigniew Jędrzejewski-Szmek [Tue, 21 Feb 2017 22:35:01 +0000 (17:35 -0500)]
Merge pull request #5411 from poettering/various-pre-v233-fixes
Various pre v233 fixes.
Lennart Poettering [Tue, 21 Feb 2017 17:11:12 +0000 (18:11 +0100)]
Revert "basic/strv: allow NULLs to be inserted into strv"
This reverts commit
18f71a3c8174774c5386c4aba94d54f3b5c36a84.
According to @keszybz we don't need this anymore, hence drop it:
https://github.com/systemd/systemd/pull/5131/commits/
18f71a3c8174774c5386c4aba94d54f3b5c36a84#r102232368
Lennart Poettering [Tue, 21 Feb 2017 16:57:55 +0000 (17:57 +0100)]
log: never log into foreign fd #2 in PID 1 or its pre-execve() children
Fixes: #5401
Lennart Poettering [Tue, 21 Feb 2017 16:48:59 +0000 (17:48 +0100)]
man: document that ProtectKernelTunables= and ProtectControlGroups= implies MountAPIVFS=
See: #5384
Lennart Poettering [Tue, 21 Feb 2017 16:44:35 +0000 (17:44 +0100)]
bootctl: create loader.conf only if it doesn't exist yet
If the snippet aleady exists, don't do anything, as the file was already
installed then.
(This also reworks the code to create the file atomically)
Fixes: #5396
Lennart Poettering [Tue, 21 Feb 2017 16:13:36 +0000 (17:13 +0100)]
bootctl: rework file copy routines to reuse copy_bytes() from copy.c
Also, make sure to reuse temporary file handling used elsewhere.
Lennart Poettering [Tue, 21 Feb 2017 16:13:28 +0000 (17:13 +0100)]
copy: a plain unlink() works here too
Lennart Poettering [Tue, 21 Feb 2017 15:25:02 +0000 (16:25 +0100)]
sd-netlink: don't give up on netlink on ENOBUFS
If our netlink input buffer overruns the kernel will send us ENOBUFS on
the next recvmsg(). Don't consider this a complete failure resulting in
closing of the netlink socket. Instead, simply continue (after debug
logging).
Of course, ideally we'd have a better strategy for this, and would have
a way to resync if this happens (as well as a scheme for cancelling all
ongoing asynchronous transactions), but for now let's at least not choke
fatally, and simply accept that we lost some messages and continue.
Note that if we lose messages when synchronously waiting for an
operation to complete, we'll still propagate the ENOBUFS up, to make the
individual transaction fail.
See: #5398
(This bug does not properly fix the issue, hence we should leave the bug
open.)
Lennart Poettering [Tue, 21 Feb 2017 15:18:03 +0000 (16:18 +0100)]
dissect: generate friendly error messages for more error conditions
Fixes: #5408
stuart-mclaren [Tue, 21 Feb 2017 20:39:52 +0000 (20:39 +0000)]
Fix check for signal in set (#5416)
IN_SET(SIGCONT, SIGKILL) will always evaluate to false.
The signal needs to be included as the first argument.
Fixup for
26f417d3e8dd2522adfdc4c8fed4c36fa40f48fc.
Lennart Poettering [Tue, 21 Feb 2017 20:00:09 +0000 (21:00 +0100)]
NEWS: document ExecStartPost change in NEWS (#5415)
Follow up for #4843.
Taking @joukewitteveen's suggestion into account:
https://github.com/systemd/systemd/pull/4843#issuecomment-
280306811
Zbigniew Jędrzejewski-Szmek [Tue, 21 Feb 2017 19:47:40 +0000 (14:47 -0500)]
Merge pull request #5412 from AsciiWolf/https-urls-2
More https:// in URLs fixes.
AsciiWolf [Tue, 21 Feb 2017 17:26:23 +0000 (18:26 +0100)]
NEWS, README: use www prefix in freedesktop.org URLs
AsciiWolf [Tue, 21 Feb 2017 17:21:13 +0000 (18:21 +0100)]
catalog: use https:// in URLs
AsciiWolf [Tue, 21 Feb 2017 17:18:24 +0000 (18:18 +0100)]
docs: use https:// in URLs
Zbigniew Jędrzejewski-Szmek [Tue, 21 Feb 2017 16:27:10 +0000 (11:27 -0500)]
Merge pull request #5410 from AsciiWolf/https-urls
Use https:// in URLs when possible.
AsciiWolf [Tue, 21 Feb 2017 15:28:04 +0000 (16:28 +0100)]
man: use https:// in URLs
AsciiWolf [Tue, 21 Feb 2017 15:03:04 +0000 (16:03 +0100)]
NEWS: use https:// in URLs
AsciiWolf [Tue, 21 Feb 2017 14:56:04 +0000 (15:56 +0100)]
README, README.md: use https:// in URLs
AsciiWolf [Tue, 21 Feb 2017 14:44:13 +0000 (15:44 +0100)]
configure.am: use https:// in URLs
Martin Pitt [Tue, 21 Feb 2017 14:41:44 +0000 (15:41 +0100)]
NEWS: fix typos, grammar, and small errors (#5407)
Martin Pitt [Tue, 21 Feb 2017 14:04:02 +0000 (15:04 +0100)]
Merge pull request #5406 from poettering/v233-prep
V233 preparation
Lennart Poettering [Tue, 21 Feb 2017 13:01:09 +0000 (14:01 +0100)]
build-sys: bump package version
Lennart Poettering [Tue, 21 Feb 2017 12:59:12 +0000 (13:59 +0100)]
start putting together a NEWS entry for 233
Lennart Poettering [Tue, 21 Feb 2017 10:17:24 +0000 (11:17 +0100)]
systemctl: suffix cmdline options that take arguments with =
Just to clarify, that these options expect arguments, following our
usual style.
Lennart Poettering [Tue, 21 Feb 2017 10:11:44 +0000 (11:11 +0100)]
Merge pull request #5131 from keszybz/environment-generators
Environment generators
Zbigniew Jędrzejewski-Szmek [Tue, 21 Feb 2017 10:08:35 +0000 (05:08 -0500)]
coredumpctl: print a hint if any coredumps are in flight (#5393)
Fixes #4685.
Lennart Poettering [Tue, 21 Feb 2017 09:49:49 +0000 (10:49 +0100)]
Merge pull request #5390 from keszybz/coverity
Clarifications to make coverity happy
Zbigniew Jędrzejewski-Szmek [Tue, 21 Feb 2017 04:21:26 +0000 (23:21 -0500)]
test-env-util: add more tests for "extended syntax"
This is only the tip of the iceberg. It would be great to test all kinds of nesting, handling
of invalid syntax, etc., but I'm leaving that for later.
Ray Strode [Tue, 9 Aug 2016 14:20:22 +0000 (10:20 -0400)]
basic: support default and alternate values for env expansion
Sometimes it's useful to provide a default value during an environment
expansion, if the environment variable isn't already set.
For instance $XDG_DATA_DIRS is suppose to default to:
/usr/local/share/:/usr/share/
if it's not yet set. That means callers wishing to augment
XDG_DATA_DIRS need to manually add those two values.
This commit changes replace_env to support the following shell
compatible default value syntax:
XDG_DATA_DIRS=/foo:${XDG_DATA_DIRS:-/usr/local/share/:/usr/share}
Likewise, it's useful to provide an alternate value during an
environment expansion, if the environment variable isn't already set.
For instance, $LD_LIBRARY_PATH will inadvertently search the current
working directory if it starts or ends with a colon, so the following
is usually wrong:
LD_LIBRARY_PATH=/foo/lib:${LD_LIBRARY_PATH}
To address that, this changes replace_env to support the following
shell compatible alternate value syntax:
LD_LIBRARY_PATH=/foo/lib${LD_LIBRARY_PATH:+:${LD_LIBRARY_PATH}}
[zj: gate the new syntax under REPLACE_ENV_ALLOW_EXTENDED switch, so
existing callers are not modified.]
Ray Strode [Tue, 9 Aug 2016 14:20:22 +0000 (10:20 -0400)]
basic: add replace_env_n function
It's like replace_env, but lets you pass in a substring.
Zbigniew Jędrzejewski-Szmek [Sat, 18 Feb 2017 16:28:12 +0000 (11:28 -0500)]
build-sys: make environment.d support conditional
We have ./configure switches for various parts of non-essential functionality,
let's add one for this new stuff too. Support for environment generators is
not conditional — if you don't want them, just don't install any.
Zbigniew Jędrzejewski-Szmek [Sat, 18 Feb 2017 03:56:28 +0000 (22:56 -0500)]
Tighten checking for variable validity
In the future we might want to allow additional syntax (for example
"unset VAR". But let's check that the data we're getting does not contain
anything unexpected.
Zbigniew Jędrzejewski-Szmek [Sat, 11 Feb 2017 19:05:10 +0000 (14:05 -0500)]
Allow braceless variables to be expanded
(Only in environment.d files.)
We have only basic compatibility with shell syntax, but specifying variables
without using braces is probably more common, and I think a lot of people would
be surprised if this didn't work.
Zbigniew Jędrzejewski-Szmek [Sat, 11 Feb 2017 18:22:13 +0000 (13:22 -0500)]
basic/env-util: use _cleanup_ in replace_env()
Ray Strode [Fri, 29 Jul 2016 17:52:55 +0000 (13:52 -0400)]
build-sys,man: load /etc/environment and describe the new environment.d syntax
Add support for /etc/environment and document the changes to the user manager
to automatically import environment *.conf files from:
~/.config/environment.d/
/etc/environment.d/
/run/environment.d/
/usr/local/lib/environment.d/
/usr/lib/environment.d/
/etc/environment
Zbigniew Jędrzejewski-Szmek [Sat, 11 Feb 2017 16:32:17 +0000 (11:32 -0500)]
environment-generator: new generator to peruse environment.d
Why the strange name: the prefix is necessary to follow our own advice that
environment generators should have numerical prefixes. I also put -d- in the
name because otherwise the name was very easy to mistake with
systemd.environment-generator. This additional letter clarifies that this
on special generator that supports environment.d files.
Ray Strode [Thu, 4 Aug 2016 16:00:00 +0000 (12:00 -0400)]
basic: add new merge_env_file function
merge_env_file is a new function, that's like load_env_file, but takes a
pre-existing environment as an input argument. New environment entries are
merged. Variable expansion is performed.
Falling back to the process environment is supported (when a flag is set).
Alternatively this could be implemented as passing an additional fallback
environment array, but later on we're adding another flag to allow braceless
expansion, and the two flags can be combined in one arg, so there's less
stuff to pass around.
Ray Strode [Tue, 9 Aug 2016 14:39:15 +0000 (10:39 -0400)]
basic: drop unnecessary strempty() call in replace_env
strempty() converts a NULL value to empty string, so
that it can be passed on to functions that don't support NULL.
replace_env calls strempty before passing its value on to strappend.
strappend supports NULL just fine, though, so this commit drops the
strempty call.
Ray Strode [Wed, 3 Aug 2016 18:35:50 +0000 (14:35 -0400)]
basic: fix strv_env_get_n for unclean arrays
If an environment array has duplicates, strv_env_get_n returns
the results for the first match. This is wrong, because later
entries in the environment are supposed to replace earlier
entries.
Zbigniew Jędrzejewski-Szmek [Mon, 23 Jan 2017 06:11:45 +0000 (01:11 -0500)]
man: add systemd.environment-generator(7) with two examples
v2:
- add example files to EXTRA_DIST
v3:
- rework for the new scheme where nothing is written to disk
v4:
- use separate dirs for system and user env generators
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jan 2017 06:13:47 +0000 (01:13 -0500)]
manager: run environment generators
Environment file generators are a lot like unit file generators, but not
exactly:
1. environment file generators are run for each manager instance, and their
output is (or at least can be) individualized.
The generators themselves are system-wide, the same for all users.
2. environment file generators are run sequentially, in priority order.
Thus, the lifetime of those files is tied to lifecycle of the manager
instance. Because generators are run sequentially, later generators can use or
modify the output of earlier generators.
Each generator is run with no arguments, and the whole state is stored in the
environment variables. The generator can echo a set of variable assignments to
standard output:
VAR_A=something
VAR_B=something else
This output is parsed, and the next and subsequent generators run with those
updated variables in the environment. After the last generator is done, the
environment that the manager itself exports is updated.
Each generator must return 0, otherwise the output is ignored.
The generators in */user-env-generator are for the user session managers,
including root, and the ones in */system-env-generator are for pid1.
Zbigniew Jędrzejewski-Szmek [Sat, 11 Feb 2017 02:49:01 +0000 (21:49 -0500)]
exec-util: implement a set of callbacks to pass variables around
Only tests are added, otherwise the new code is unused.
Zbigniew Jędrzejewski-Szmek [Sat, 18 Feb 2017 21:23:03 +0000 (16:23 -0500)]
basic/env-util: drop _pure_ from static function
Zbigniew Jędrzejewski-Szmek [Sat, 11 Feb 2017 04:08:53 +0000 (23:08 -0500)]
env-util,fileio: immediately replace variables in load_env_file_push()
strv_env_replace was calling env_match(), which in effect allowed multiple
values for the same key to be inserted into the environment block. That's
pointless, because APIs to access variables only return a single value (the
latest entry), so it's better to keep the block clean, i.e. with just a single
entry for each key.
Add a new helper function that simply tests if the part before '=' is equal in
two strings and use that in strv_env_replace.
In load_env_file_push, use strv_env_replace to immediately replace the previous
assignment with a matching name.
Afaict, none of the callers are materially affected by this change, but it
seems like some pointless work was being done, if the same value was set
multiple times. We'd go through parsing and assigning the value for each
entry. With this change, we handle just the last one.
Zbigniew Jędrzejewski-Szmek [Sat, 11 Feb 2017 03:14:03 +0000 (22:14 -0500)]
basic/fileio: add helper function for a set of two common checks
Zbigniew Jędrzejewski-Szmek [Sat, 11 Feb 2017 02:44:21 +0000 (21:44 -0500)]
core/manager: move environment serialization out to basic/env-util.c
This protocol is generally useful, we might just as well reuse it for the
env. generators.
The implementation is changed a bit: instead of making a new strv and freeing
the old one, just mutate the original. This is much faster with larger arrays,
while in fact atomicity is preserved, since we only either insert the new
entry or not, without being in inconsistent state.
v2:
- fix confusion with return value
Zbigniew Jędrzejewski-Szmek [Fri, 10 Feb 2017 20:41:42 +0000 (15:41 -0500)]
core/manager: fix grammar in comment
Zbigniew Jędrzejewski-Szmek [Sun, 22 Jan 2017 20:22:37 +0000 (15:22 -0500)]
basic/exec-util: add support for synchronous (ordered) execution
The output of processes can be gathered, and passed back to the callee.
(This commit just implements the basic functionality and tests.)
After the preparation in previous commits, the change in functionality is
relatively simple. For coding convenience, alarm is prepared *before* any
children are executed, and not before. This shouldn't matter usually, since
just forking of the children should be pretty quick. One could also argue that
this is more correct, because we will also catch the case when (for whatever
reason), forking itself is slow.
Three callback functions and three levels of serialization are used:
- from individual generator processes to the generator forker
- from the forker back to the main process
- deserialization in the main process
v2:
- replace an structure with an indexed array of callbacks
Zbigniew Jędrzejewski-Szmek [Sat, 11 Feb 2017 23:33:16 +0000 (18:33 -0500)]
core/manager: split out creation of serialization fd out to a helper
There is a slight change in behaviour: the user manager for root will create a
temporary file in /run/systemd, not /tmp. I don't think this matters, but
simplifies implementation.
Lucas Werkmeister [Mon, 20 Feb 2017 23:45:35 +0000 (00:45 +0100)]
tree-wide: add man: to manpage references (#5402)
Found with:
git grep '"[^"]*[a-z0-9]([0-9]\+p\?)' src/ | grep -vF man:
pyBlob [Mon, 20 Feb 2017 21:24:45 +0000 (22:24 +0100)]
Syntax for defines that is also unterstood by the GNU C/C++ compilers. (#5397)
Benjamin Robin [Mon, 20 Feb 2017 21:11:34 +0000 (22:11 +0100)]
systemctl: Fix condition in start_special() (#5399)
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 19:17:19 +0000 (14:17 -0500)]
sd-device: replace lstat() + open() with open(O_NOFOLLOW)
Coverity was complaining about TOCTOU (CID #745806). Indeed, it seems better
to open the file and avoid the stat altogether:
- O_NOFOLLOW means we'll get ELOOP, which we can translate to EINVAL as before,
- similarly, open(O_WRONLY) on a directory will fail with EISDIR,
- and finally, it makes no sense to check access mode ourselves: just let
the kernel do it and propagate the error.
v2:
- fix memleak, don't clober input arg
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 18:52:18 +0000 (13:52 -0500)]
shared/pager: abort if we cannot set environment variables
This most likely means oom, it's better to exit than to run less with
incomplete settings.
CID #714383.
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 18:48:59 +0000 (13:48 -0500)]
core/execute: add (void)
CID #778045.
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 18:43:22 +0000 (13:43 -0500)]
logind: check return value from lseek
In practice this doesn't matter much because the read that follows will
likely fail, but we'll get a better error message.
CID #1368233.
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 18:39:08 +0000 (13:39 -0500)]
importd: check setenv return value
CID #1368235.
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 18:36:17 +0000 (13:36 -0500)]
core/killall: add (void)
CID #1368238.
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 18:19:50 +0000 (13:19 -0500)]
firewall-util: add an assert that we're not overwriting a buffer
Check for CID #1368267.
Lennart Poettering [Mon, 20 Feb 2017 15:30:58 +0000 (16:30 +0100)]
Merge pull request #5392 from keszybz/systemctl-edit
systemctl edit & reboot fixlets
Alexander Galanin [Mon, 20 Feb 2017 09:15:58 +0000 (13:15 +0400)]
Include 'vendor class identifier option' into DHCPREQUEST message (#5380)
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 23:53:10 +0000 (18:53 -0500)]
systemctl: give a hint about --force --force when communication with manager fails
The hint is not too explicit, and just refers to the man page, because this
option is slightly dangereous. This was we don't have to discuss the limitation
in the hint itself.
Fixes #4002.
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 22:41:38 +0000 (17:41 -0500)]
systemctl: fix hint with edit --global/--user
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 22:30:53 +0000 (17:30 -0500)]
systemctl: fix editing of units with no fragment
"systemctl --user edit --force --full tmp.mount" would crash, when we'd do
basename(NULL). Fix this by creating a new unit or a new override even if
not path is found.
Tested with:
systemctl --user edit --force --full tmp.mount
systemctl --user edit --force tmp.mount
systemctl --user edit foo@.service
systemctl --user edit foo@bar.service
systemctl --user edit --full foo@.service
systemctl --user edit --full foo@bar.service
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 21:52:09 +0000 (16:52 -0500)]
systemctl: when told to edit an instance, do not edit the template
Fixes #5383.
Lucas Werkmeister [Sun, 19 Feb 2017 17:03:15 +0000 (18:03 +0100)]
systemctl: fix error messages (#5389)
Martin Pitt [Sun, 19 Feb 2017 15:15:06 +0000 (16:15 +0100)]
test: re-drop assumption that /run is a mount point, part 2 (#5386)
Commit
cc3901613 only fixed one place, fix the other one too.
Zbigniew Jędrzejewski-Szmek [Sun, 19 Feb 2017 08:00:42 +0000 (03:00 -0500)]
udev-builtin-net_id: fix warning about discarded "const" attribute (#5385)
Lucas Werkmeister [Sat, 18 Feb 2017 21:36:25 +0000 (22:36 +0100)]
journalctl: add reference to sd-id128(3) to output (#5382)
SD_ID128_MAKE is clearly not a standard C macro, so let’s point the user
to its documentation to let them know which header they need and what
they can then do with MESSAGE_XYZ.
Lucas Werkmeister [Sat, 18 Feb 2017 21:34:28 +0000 (22:34 +0100)]
man: sd-id128: fix journalctl option name (#5381)
--new-id works because it’s an unambiguous prefix, but the full option
name is --new-id128.
Zbigniew Jędrzejewski-Szmek [Sat, 18 Feb 2017 16:54:34 +0000 (11:54 -0500)]
Merge pull request #5369 from poettering/nspawn-resolved
fixes for running nspawn+resolved in combination
Lennart Poettering [Thu, 16 Feb 2017 16:57:30 +0000 (17:57 +0100)]
units: order systemd-nspawn@.service after systemd-resolved.service
This way, the nspawn internal check whether resolved is running will
succeed if it is enabled.
Fixes: #4649
Lennart Poettering [Thu, 16 Feb 2017 16:56:10 +0000 (17:56 +0100)]
nspawn: tweak check whether resolved is around a bit
Let's check D-Bus instead of files in /run to see if resolved is
running. This is a bit nicer as bus names are automatically cleaned up
when resolved dies, which is not the case for files in /run.
See: #4649
Lennart Poettering [Thu, 16 Feb 2017 16:48:48 +0000 (17:48 +0100)]
units: enable resolved bus activation though a symlink in /etc
The change:
-/usr/lib/systemd/system/dbus-org.freedesktop.resolve1.service
+/etc/systemd/system/dbus-org.freedesktop.resolve1.service
If resolved is disabled, without this, talking to the resolved bus API will
activate it regardless whether it is enabled or not, let's fix that.
Martin Pitt [Fri, 17 Feb 2017 20:29:02 +0000 (21:29 +0100)]
test: re-drop assumption that /run is a mount point (#5377)
Commit
436e916ea introduced the assumption into test-stat-util that /run
is a tmpfs mount point. This is not the case in build chroots such as
Fedora's mock or Debian's sbuild. So only assert that /run is a tmpfs
and not a btrfs if /run is actually a mount point. This will then still
be asserted with installed tests.
Adrián López [Fri, 17 Feb 2017 20:27:45 +0000 (21:27 +0100)]
systemctl: show extra args if defined (#5379)
Zbigniew Jędrzejewski-Szmek [Fri, 17 Feb 2017 20:23:52 +0000 (15:23 -0500)]
Merge pull request #5373 from poettering/coredump-timestamp-fixes
various coredump fixes
Zbigniew Jędrzejewski-Szmek [Fri, 17 Feb 2017 20:00:36 +0000 (15:00 -0500)]
Merge pull request #5347 from poettering/local-nta
more resolved fixes
Lennart Poettering [Fri, 17 Feb 2017 18:10:09 +0000 (19:10 +0100)]
missing: add renameat2() definition for 64bit arm (#5378)
Following a similar commit in casync:
https://github.com/systemd/casync/pull/10
Lennart Poettering [Fri, 17 Feb 2017 17:03:04 +0000 (18:03 +0100)]
Merge pull request #5275 from ssahani/fix-dropin-net-section
networkd: fix drop-in conf directory configs overwriting each other
Viktor Mihajlovski [Fri, 17 Feb 2017 15:18:01 +0000 (16:18 +0100)]
udev: fix id_net_name_path for virtio-ccw interfaces (#5357)
The CCW id_net_name_path detection didn't account for virtio
interfaces on the CCW bus. As a result the default interface
names for virtio-ccw interfaces would use the old eth<x>
format instead of enc<busid>.
Since virtio-pci interface naming follows the naming rules
of the parent bus, the names_ccw() logic was changed to apply
the CCW interface naming rules to virtio interfaces as well,
e.g. enc2000 for an interface with a CCW bus id 0.0.2000.
As virtio interfaces are apt to get the otherwise unusual
CCW bus id 0.0.0000, the last '0' is now preserved in this
case.
The virtio subsystem skipping loop has been moved from
names_pci() into a function skip_virtio() that can be reused
for all bus types with virtio network devices.
Since virtio-ccw interfaces use single CCW addresses the ccwgroup
requirement was relaxed and the C definitions were changed
accordingly.
Zbigniew Jędrzejewski-Szmek [Fri, 17 Feb 2017 14:34:25 +0000 (09:34 -0500)]
network: change condition in if testing section presence
section_line and filename should be set together or not at all. Change the
if to test filename, since it's the first of the pair and it seems more natural
to test that.
Zbigniew Jędrzejewski-Szmek [Fri, 17 Feb 2017 14:26:10 +0000 (09:26 -0500)]
networkd: immediately transfer ownership of route->section
The code was not incorrect previously, but I think it's easier to follow the
ownership (and the code is more likely to remain correct when updated later on),
if freeing of NetworkConfigSection* is immediately made the responsibility of
route_free(), so instead of relying on route_free() not freeing ->section
if adding to the network hashmap failed, make this freeing unconditional.
Lennart Poettering [Fri, 17 Feb 2017 12:51:58 +0000 (13:51 +0100)]
Merge pull request #5333 from poettering/machined-copy-files-userns
machined userns fixes
Lennart Poettering [Fri, 17 Feb 2017 12:51:27 +0000 (13:51 +0100)]
Merge pull request #5366 from poettering/default-hostname-fix
fallback hostname fixes
Lennart Poettering [Thu, 16 Feb 2017 13:38:05 +0000 (14:38 +0100)]
man: document that user namespacing complicates file copies
Lennart Poettering [Fri, 17 Feb 2017 10:34:29 +0000 (11:34 +0100)]
coredump: store the full coredump kernel context in xattrs on the coredump file
We didn't include the resource limit field, add it.
Lennart Poettering [Fri, 17 Feb 2017 10:31:07 +0000 (11:31 +0100)]
coredump: when reconstructing original kernel coredump context, chop off trailing zeroes
Our coredump handler operates on a "context" supplied by the kernel via
the core_pattern arguments. When we pass off a coredump for processing
to coredumpd we pass along enough information for this context to be
reconstructed. This information is passed in the usual journal fields,
and that means we extended the 1s granularity timestamp to 1µs
granularity by appending 6 zeroes. We need to chop them off again when
reconstructing the original kernel context.
Fixes: #4779
Lennart Poettering [Fri, 17 Feb 2017 10:18:22 +0000 (11:18 +0100)]
udevd: use signal_to_string() instead of strsignal() at one place
strsignal() sucks, as it tries to generate human readable strings from
something that isn't really human readable by concept. Let's use
signal_to_string() instead, making this more grokkable. Difference is:
SIGINT gets translated → "SIGINT" rather than → "Interrupted".
Lennart Poettering [Fri, 17 Feb 2017 10:10:35 +0000 (11:10 +0100)]
coredump: include signal name in journal metadata
(Note that we only do this for the journal metadata, not for the xattrs,
as the xattrs are only supposed to store the original 1:1 info we
acquired from the kernel.)
Lennart Poettering [Fri, 17 Feb 2017 09:59:21 +0000 (10:59 +0100)]
coredump: fix handling of special crashes
When we encounter a "special" crash we should not continue processing it
the usual way.
Lennart Poettering [Wed, 15 Feb 2017 19:05:27 +0000 (20:05 +0100)]
resolved: try to authenticate SOA on negative replies
For caching negative replies we need the SOA TTL information. Hence,
let's authenticate all auxiliary SOA RRs through DS requests on all
negative requests.
Lennart Poettering [Wed, 15 Feb 2017 18:56:59 +0000 (19:56 +0100)]
resolved: extend various timeouts
Let's increase a number of timeouts as they apparently are too short for
some real-world lookups.
See:
https://github.com/systemd/systemd/issues/4003#issuecomment-
279842616
In particular we change the following timeouts:
1) The first UDP retry we increase 500ms → 750ms. This is a good idea,
since some servers need relatively long responses for trivial lookups,
and giving up our first attempt also has the effect of trying a
different server for the next attempt which has the side effect that
we'll run two down-grade iterations in parallel, on both servers.
Hence, let's give servers a bit more time in the first iteration.
2) Permit 24 retries instead of just 16 per transactions. If we end up
downgrading all the way down to UDP for a lookup we already need 5
iterations for that. If we want permit a couple of lost packages for
each (let's say 4), then we already need 20 iterations.
3) Increase the overall query timeout on the service side to 60s (from
45s), simply because very long and slow DNSSEC + CNAME chains (such as
us.ynuf.alipay.com) hit this boundary too easily. The client side
timeout for the bus method call is increased to 90s, in order to have
room for the dbus reply to go through
Lennart Poettering [Wed, 15 Feb 2017 18:55:34 +0000 (19:55 +0100)]
resolved: initialize all return values on successful exit of dns_cache_lookup()
Following our coding style on success we should initialize all return
parameters of a function. We missed to cases for dns_cache_lookup() (but
covered all others), fix them too.
Lennart Poettering [Wed, 15 Feb 2017 18:54:32 +0000 (19:54 +0100)]
resolved: show rcode in debug output for incoming replies
This is the most important piece of information of replies, hence show
this in the first log message about it.
(Wireshark shows it too in the short summary, hence this definitely
makes sense...)
Lennart Poettering [Wed, 15 Feb 2017 17:53:25 +0000 (18:53 +0100)]
resolved: don't downgrade feature level if we get RCODE on UDP level
Retrying a transaction via TCP is a good approach for mitigating
packet loss. However, it's not a good away way to fix a bad RCODE if we
already downgraded to UDP level for it. Hence, don't do this.
This is a small tweak only, but shortens the time we spend on
downgrading when a specific domain continously returns a bad rcode.
Lennart Poettering [Wed, 15 Feb 2017 17:28:23 +0000 (18:28 +0100)]
resolved: cache SERVFAIL responses for 30s
Some domains (such as us.ynuf.alipay.com) almost appear as if they actively
want to sabotage our DNSSEC work. Specifically, they unconditionally
return SERVFAIL on SOA lookups and always only after a 1s delay (at
least). This is pretty bad for our validation logic, as we use SOA
lookups to distuingish zones from non-terminal names. Moreover, SERVFAIL
is an error that is typically returned if we send requests a server
doesn't grok, and thus is reason for us to downgrade our protocol and
try again. In case of these zones this means we'll accept the SERVFAIL
response only after a full iterative downgrade to our lowest feature
level: TCP. In combination with the 1s delays this has the effect of
making us hit our transaction timeout way to easily.
As first attempt to improve the situation: let's start caching SERVFAIL
responses in our cache, after the full downgrade for a short period of
time.
Conceptually this is exposed as "weird rcode" caching, but for now we
only consider SERVFAIL a "weird rcode" worthy of caching. Later on we
might want to add more.
Lennart Poettering [Wed, 15 Feb 2017 17:24:46 +0000 (18:24 +0100)]
resolved: lengthen timeout for TCP transactions
When we are doing a TCP transaction the kernel will automatically resend
all packets for us, there's no need to do that ourselves. Hence:
increase the timeout for TCP transactions substantially, to give the
kernel enough time to connect to the peer, without interrupting it when
we become impatient.