Myoungwoon Roy, Kim [Wed, 8 Feb 2017 19:09:15 +0000 (11:09 -0800)]
doxygen: fix typos, cacologique statements in API reference doxygen of Ecore_Common
Summary: There are some typos and calogique statements in doxygen of Ecore_Common so I had fixed typos, cacologique statements.
Test Plan: doxygen revision
Reviewers: stefan, cedric, raster, Jaehyun_Cho
Subscribers: conr2d, jpeg
Differential Revision: https://phab.enlightenment.org/D4650
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Wed, 8 Feb 2017 17:30:10 +0000 (12:30 -0500)]
ecore-wl2: Support sending focus for wl_shell
wl_shell does not use a surface state for activation, so we still need
to send the focus in/out for that based on keyboard enter/leave.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 8 Feb 2017 16:51:21 +0000 (11:51 -0500)]
ecore-wl2: Don't send focus in/out events based on keyboard enter/leave
We should not be sending focus events based on keyboard behaviour, but
rather send them according to xdg shell activate status. This makes
our focus behaviour more "standards" compliant.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Derek Foreman [Wed, 8 Feb 2017 15:37:49 +0000 (09:37 -0600)]
Revert "elput - use vpath to get xdg runtime to also be setuid safe"
This reverts commit
24e34e19a1db84cdcb6241207cb99d14ca83c41b.
This broke keyboard input for the enlightenment wayland compositor,
please test elput changes on at least one of the drm backends,
preferably with enlightenment.
The wayland compositor is hard enough to keep stable due to breakage
from core changes only tested on X - but elput's main user is our
wayland compositor, was this tested anywhere?
Derek Foreman [Wed, 8 Feb 2017 15:36:46 +0000 (09:36 -0600)]
Revert "elput: Minor formatting fix"
This reverts commit
95d93cb7208857cc89d79f3ffbbd7ee71ba1936f.
Formatting change on top of a totally untested coverity fix that
breaks input for enlightenment's wayland compositor.
#TeamworkIsDeprecated
Stephen 'Okra' Houston [Wed, 8 Feb 2017 14:54:44 +0000 (08:54 -0600)]
Give Batman it's own edc.
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 13:59:37 +0000 (22:59 +0900)]
when resetting tex_target, set it to -1 so we force a reset
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 13:57:28 +0000 (22:57 +0900)]
evas gl commonnon - context - expand fields to 2 bits for invalid vals
we use invalid values (-1 or 0xff or 0x3 etc. invalid vals to know to reset
some state). expand fields out in size a little bit to allow that to
work again.
Chris Michael [Wed, 8 Feb 2017 13:29:24 +0000 (08:29 -0500)]
elput: Minor formatting fix
NB: No functional changes, just some minor formatting adjustments
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 12:07:21 +0000 (21:07 +0900)]
evas yuv convert - fix unused increments
this removes useless yp1 += and yop2 += as they are SET int he loop.
this fixes 1367510 and 1367511
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 12:04:46 +0000 (21:04 +0900)]
evas mask filter - remove unused increment of msk as its set in-loop
msk is set inside the loop body, so msk += is pointless.
fix CID 1367512
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 11:15:10 +0000 (20:15 +0900)]
eina debug monitor - dont use XDG_RUNTIME_DIR if setuid
avoids possible issues with debug monitor + setuid
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 10:15:19 +0000 (19:15 +0900)]
ecore_con - only use XDG_RUNTIME_DIR if not setuid
this should address possible misuse of this env var in setuid apps.
keep using home and tmp to maintain socket "abi" (the filenames that
are used).
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 10:12:51 +0000 (19:12 +0900)]
evas cserver client - remove dead if 0'd code
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 10:10:44 +0000 (19:10 +0900)]
elput - use vpath to get xdg runtime to also be setuid safe
this fixes CID 1357168 in the case of setuid binaries as vpath handles
setuid cases.
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 09:43:29 +0000 (18:43 +0900)]
evas gl generic - remove dead code else case
plane limits are checked at top of function so no need to check in the
middle again. it's dead code. fixes CID 1362729
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 09:38:42 +0000 (18:38 +0900)]
evas gl generic - comment switch fallthrough as intended
this is intended. document as such.
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 09:11:07 +0000 (18:11 +0900)]
efl vpath - be paranoid about setuid execution and dont use env vars
if setuid, do not trust env vars for any xdg stuff at all.
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 08:57:35 +0000 (17:57 +0900)]
evas callbacks - add comment to note fallthrough is intended
swtich fallthrough oftenis not intended but in this case it is, so
documente it as such.
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 08:51:52 +0000 (17:51 +0900)]
elm config - forbid bakcslash in profile name too
/ already is forbidden but \ might be valid on windows, so forbid it
too.
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 08:50:47 +0000 (17:50 +0900)]
elm config - handle profile name of ".." as its obviously invalid
this forbids .., as a profile name in addition to the existing "stip /
from profile name".
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 08:35:26 +0000 (17:35 +0900)]
eina utils - home and tmp environ - store statitcally and handle setuid
if setuod we dont want to trust HOME environ at all and get it from
passwd file... also we dont want to keep re-getting too... so store
statically as well as tmp.
this also kind of helps CID 1366469
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 07:43:50 +0000 (16:43 +0900)]
edje_cc - fix potential divide by 0 in info output if file size is 0
this will realistically never happen in a sane case... but its
theoretically possible. fixes CID 1366923
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 07:36:57 +0000 (16:36 +0900)]
eet data - fix checking return value of eina_value_pset like elsewhere
eina_value_pset() return is checked pretty much everywhere except
here. this addresses that inconsistency. this fixes CID 1367487
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 07:30:54 +0000 (16:30 +0900)]
evas cache image - remove double unlock of image task locks.
this is indeed a bug and fixes coverity CID 1367492
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 07:20:17 +0000 (16:20 +0900)]
eina share - fix spinlock release if magic check fails on share data
this fixes a potential double spinlock unrelease if magic check fails
on share data. this fixes CID 1367493
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 06:35:19 +0000 (15:35 +0900)]
evas image obj - remove logically dead code
coverity is right - it's logically dead code. fix CID 1367774
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 02:54:45 +0000 (11:54 +0900)]
evas image load - remove unreachable code
it's just printing a warning anyway and coverity CID 1368210 is right
as it says it's unreachable. fix.
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 02:45:09 +0000 (11:45 +0900)]
evas image load - handle null module handle in case
this fixes CID 1368338
Stefan Schmidt [Wed, 8 Feb 2017 11:05:12 +0000 (12:05 +0100)]
build: do not use a absolute system path for service files during distcheck
Our systemd service files are installed into an absolute system path by default
which simply does not work when doing a distcheck. Set the path differently for
the distcheck options.
Amitesh Singh [Wed, 8 Feb 2017 04:23:21 +0000 (09:53 +0530)]
elm code: check return value of elm_layout_theme_set
fixes CID 1366922
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 02:33:42 +0000 (11:33 +0900)]
ecore_con proxy helper - fix null return handling for thread q wait
this fixes CID 1368376
Carsten Haitzler (Rasterman) [Wed, 8 Feb 2017 02:26:26 +0000 (11:26 +0900)]
Revert "evas_async_events: integrated Ecore_Pipe in evas_async_events"
This reverts commit
ea0492e0c6912af704b14e51ea80715e2486ef2d.
this drops software engine rendering to like 5-10fps! or at least
visually about that... not tested enough at all!
Cedric BAIL [Wed, 8 Feb 2017 00:32:44 +0000 (16:32 -0800)]
ecore: add test to make sure that the timer reset during callback work as expected.
Cedric BAIL [Wed, 8 Feb 2017 00:32:22 +0000 (16:32 -0800)]
ecore: reset during timer callback execution doesn't make sense.
@fix
T3222
Carsten Haitzler (Rasterman) [Tue, 7 Feb 2017 13:55:36 +0000 (22:55 +0900)]
evas destructor - take lock arount post render list while freeing
this should fix CID 1369019 though really shouldnt be an issue...
Carsten Haitzler (Rasterman) [Tue, 7 Feb 2017 13:41:07 +0000 (22:41 +0900)]
eina freeq - fix possible seg with NULL freeq and pattern fill logic
this fixes handling of a NULL freeq handle - found by coverity.
fixes CID 1369021
Carsten Haitzler (Rasterman) [Tue, 7 Feb 2017 13:07:53 +0000 (22:07 +0900)]
evas cserve client - fix theoretical size less than 0 issue
theoretically size might be zero but it won't be... but make coverity
happy so it doesn't come back to triage
fix CID 1361430
Carsten Haitzler (Rasterman) [Tue, 7 Feb 2017 12:21:36 +0000 (21:21 +0900)]
evas textblock filter data set - avoid crash on freeing data binding
if balue is NULL the data binding is removed and freed, but we don't
return at that point but instead fall back to using/replacing the
databinding.
this fixes CID 1369022
Carsten Haitzler (Rasterman) [Sun, 5 Feb 2017 04:23:05 +0000 (13:23 +0900)]
ecore thread - up default 3 of thread workers to 4x cpu cures
this ups it from number of cpu cores to 4 times that (so if threads to
blocking i/o the spare cycles can be used up).
Jee-Yong Um [Tue, 7 Feb 2017 23:08:19 +0000 (15:08 -0800)]
edje: fix cached edje modification issue
Summary:
_edje_part_***_set/get (for mouse_events, repeat_events, ignore_flags, mask_flags)
overwrite cached edje value. These behaviors affect all edje object added after
these changes, and result in not intended.
@fix
Reviewers: jpeg, cedric
Subscribers: akanad, woohyun
Differential Revision: https://phab.enlightenment.org/D4362
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jiwon Kim [Tue, 7 Feb 2017 23:06:01 +0000 (15:06 -0800)]
eet: read sould be failed if cipher_key exist but file not ciphered
Summary:
Currentely, if eet_read_cipher()'s cipher_key param is exist but file
not ciphered, function always read and return successful result.
But, this behavior can not check data integrity.
e.g.
1. App create config file using eet with encryption key.
2. Attacker replace config to malicious config (not encryted).
3. App can not notice if eet_read_cipher() read that successfully.
@fix
Test Plan:
$eet -e test.cfg my_config test.src 1
$eet -d test.cfg my_config decode_res.txt my_encrytion_key
(Currentely decode success, but should be failed)
Reviewers: woohyun, raster
Subscribers: id213sin, akanad, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4563
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jiwon Kim [Tue, 7 Feb 2017 23:04:57 +0000 (15:04 -0800)]
elementary: set mirrored mode in a group_add()
Summary:
When a scroller just added and theme not changed,
scrollable interface's 'mirrored' property is always default.
elm_config_mirrored_set(EINA_TRUE) -> elm_scroller_add(),
: No mirrored mode
elm_scroller_add() -> elm_config_mirrored_set(EINA_TRUE),
: Mirrored mode
@fix
Test Plan:
1-1. elementary_test scroller
1-2. Turn on UI-Mirroring
2-1. elementary_test
2-2. Turn on UI-Mirroring
2-3. Click 'scroller' button
(Check scroller test's 'prev page' and 'next page' buttons)
Reviewers: cedric, woohyun, akanad
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4564
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Wonki Kim [Tue, 7 Feb 2017 23:03:45 +0000 (15:03 -0800)]
elm_scroller: keep contents layout rel even if rtl is set
Summary:
Once rtl mode is set, elm_layout reverses its x-axis.
however, scroller uses elm_layout to contain both original content and
proxy image of it when loop mode is set.
In this situation, elm_layout should not reverse its x-axis when It is
used for container of proxy to support loop mode of scroller.
This commit will not apply rtl mode to contents layout (mirrored set)
Test Plan:
* Check that there is a proxy image over right edge of original content.
1. Run elementary_test
2. Open scroller
3. Switch UI_mirrored mode on
4. Test (Control with keyboard / mouse wheel control looks bad on rtl mod)
a. go to the right edge with keyboard
b. get over the edge
Reviewers: woohyun, z-wony, jpeg, cedric
Differential Revision: https://phab.enlightenment.org/D4568
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Minkyu Kang [Tue, 7 Feb 2017 23:00:35 +0000 (15:00 -0800)]
elm_genlist: do not check scroll if show_item is NULL
Summary:
If show_item is NULL then does not need to check scroll.
But, sometimes show_item is NULL but check_scroll is true.
It was wrong and can makes a crash.
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
Reviewers: cedric, Hermet, SanghyeonLee, raster
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4569
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Ivan Furs [Tue, 7 Feb 2017 22:50:32 +0000 (14:50 -0800)]
eina_file: add eina_file_unlink
Test Plan: split D4423 - unlink
Reviewers: raster, vtorri, an.kroitor, jpeg, reutskiy.v.v, NikaWhite, cedric
Reviewed By: cedric
Subscribers: artem.popov, cedric, vtorri, jpeg
Tags: #windows, #efl
Differential Revision: https://phab.enlightenment.org/D4485
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Derek Foreman [Tue, 7 Feb 2017 22:53:09 +0000 (16:53 -0600)]
elput: Fix async input shutdown during init
By only checking if the thread was cancelled *after* sending feedback
to the main thread we ended up claiming all the devices libinput
asked for in a way that never allowed them to be released
(how the hell can a cancelled thread send feedback?)
Jee-Yong Um [Tue, 7 Feb 2017 21:42:45 +0000 (13:42 -0800)]
elm.entry: add configuration for the default value of select_allow
Summary:
Small devices (like smart watch) can disallow entry selection by default.
This patch enables to control this behavior with elementary configuration.
Reviewers: cedric, jpeg
Subscribers: id213sin, woohyun
Differential Revision: https://phab.enlightenment.org/D4615
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Tue, 7 Feb 2017 21:41:34 +0000 (13:41 -0800)]
emile: don't use APIs deprecated in openssl-1.1
Summary:
When openssl-1.1.0 is built with `--api=1.1 disable-deprecated`, use of
deprecated APIs leads to build failures.
X-Gentoo-Bug: 606628
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=606628
Subscribers: cedric, jpeg
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D4616
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Tue, 7 Feb 2017 21:41:20 +0000 (13:41 -0800)]
edje_load: fix mirroring bug with GROUP, BOX, or TABLE part
Summary:
Mirrored stated should be applied to new edje_object
which is created for GROUP, BOX, or TABLE part.
@fix
Reviewers: woohyun, raster, cedric, jpeg, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D4618
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Ivan Furs [Tue, 7 Feb 2017 21:40:48 +0000 (13:40 -0800)]
evas_async_events: integrated Ecore_Pipe in evas_async_events
Summary:
Integrated Ecore_Pipe in evas_async_events
Reviewers: #eflete, raster, jpeg, vtorri, artem.popov, cedric
Reviewed By: cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4622
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 7 Feb 2017 22:17:17 +0000 (14:17 -0800)]
evas: we now need to initialize ecore as it is a dependency.
se.osadchy [Tue, 7 Feb 2017 21:37:11 +0000 (13:37 -0800)]
elm gesture layer: add check for negative input tap start timeout.
Summary:
Add set 0 as start timeout if negative input value.
@fix
Reviewers: cedric, Hermet, raster
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4625
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
YeongJong Lee [Tue, 7 Feb 2017 21:36:40 +0000 (13:36 -0800)]
efl_ui_image: fix wrong define
Reviewers: jypark, jpeg, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D4626
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
YeongJong Lee [Tue, 7 Feb 2017 21:36:16 +0000 (13:36 -0800)]
efl_ui_flip: fix wrong define
Reviewers: jpeg, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D4627
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Minchul Lee [Tue, 7 Feb 2017 21:34:55 +0000 (13:34 -0800)]
gitignore: add eclipse project filename.
Summary: Import a project on Eclipse. These files are created automatically.
Reviewers: raster, cedric, jpeg, Hermet
Differential Revision: https://phab.enlightenment.org/D4637
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Sungtaek Hong [Tue, 7 Feb 2017 21:31:03 +0000 (13:31 -0800)]
elm_panel: set scrollable panel unfocusable when closed.
Summary:
- When scrollable panel is closed by elm_panel_hidden_set(),
elm_panel_toggle() APIs, it shows animation with
scroller bringin effect.
- During this animation, panel is still focusable, and may
stop closing when content gets focused.
- scrollable panel is now set unfocusable when closed by
APIs above, and set focusable when opened after bringin
animation.
Test Plan:
1) Set panel scrollable and opened.
2) Set another object focused and deleted it
when panel is closing.
3) Observe panel is closed.
Reviewers: cedric, jpeg, woohyun
Subscribers: conr2d, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4641
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Sungtaek Hong [Tue, 7 Feb 2017 21:29:57 +0000 (13:29 -0800)]
elm_index: skip level check when only 0 level is active
Summary:
- In mouse move callback, index tries to calculate
current level.
- This is not needed when level 1 is not active.
and blocks index item change.
Test Plan:
1) Run elementary test -> any vertical index.
2) Click on index item and drag to outside of index.
3) Observe index item is now changed as mouse movement.
Reviewers: cedric, Hermet, jpeg, eunue
Reviewed By: cedric
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4643
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Myoungwoon Roy, Kim [Tue, 7 Feb 2017 21:28:47 +0000 (13:28 -0800)]
doxygen: fix typo, cacologique expressions in API reference doxygen.
Summary: Fix typos, cacologique expressions in Ecore API reference doxygen.
Test Plan: doxygen
Reviewers: stefan, cedric, raster, Jaehyun_Cho
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4646
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Mykola Solyanko [Tue, 7 Feb 2017 21:25:44 +0000 (13:25 -0800)]
eldbus: add test suite for eldbus (eldbus_message*)
Summary:
add tests for next API
eldbus_message_iter_get()
eldbus_message_iter_signature_get()
eldbus_message_iter_arguments_get()
eldbus_message_iter_get_and_next()
eldbus_message_error_get()
eldbus_message_method_call_new()
eldbus_message_interface_get()
eldbus_message_member_get()
eldbus_message_path_get()
eldbus_message_sender_get()
eldbus_message_destination_get()
eldbus_message_arguments_get()
eldbus_message_error_get()
eldbus_message_signal_new()
eldbus_message_ref()
eldbus_message_unref()
eldbus_message_to_eina_value()
eldbus_message_iter_basic_get()
eldbus_message_error_get()
eldbus_message_iter_next()
eldbus_message_arguments_vappend()
Reviewers: cedric, raster, myoungwoon, NikaWhite
Subscribers: jpeg, artem.popov
Differential Revision: https://phab.enlightenment.org/D4649
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Tue, 7 Feb 2017 17:00:15 +0000 (12:00 -0500)]
elput: Delete output_name stringshare on error case
This actually should have been part of the previous patch which moved
setting output_name to evdev, but it got missed so add it now. This
ensures we cleanup the output_name stringshare on error.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 7 Feb 2017 16:34:57 +0000 (11:34 -0500)]
elput: Remove dead FIXME note
As device calibration has already been handled via external facing
API, this FIXME note is no longer needed.
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 7 Feb 2017 16:33:25 +0000 (11:33 -0500)]
elput: Set device output name when device is created
Small patch to set the output name of an Elput_Device when the device
gets created. Note, this was already being done inside elput_input,
but this patch moves it to when the device gets created.
NB: Really no functional changes here, just moving a function call.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 7 Feb 2017 15:50:09 +0000 (10:50 -0500)]
elementary: Fix return of elm_win_wl_window_get
This patch fixes an issue where the wrong wayland window would be
returned from elm_win_wl_window_get. When we lookup a window in
Enlightenment, this function would end up returning the parent window
(if existed) when what we want there is the actual window. This patch
puts the function more in line with the X11 equivalent.
Fixes T5142
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Marcel Hollerbach [Fri, 3 Feb 2017 18:23:47 +0000 (19:23 +0100)]
cmake: add ecore_x
Marcel Hollerbach [Fri, 3 Feb 2017 18:22:37 +0000 (19:22 +0100)]
ecore_x: we dont need this version file anymore
it indicated a while back which backend was used, we only have xlib
left.
Amitesh Singh [Tue, 7 Feb 2017 05:13:48 +0000 (10:43 +0530)]
access: fix crash while cleanup
The item is already deleted at this point and its garbage here
which results into crash ultimately.
Also I don't see a point in setting access_obj to NULL here
@fix
Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>
Andy Williams [Mon, 6 Feb 2017 23:39:15 +0000 (23:39 +0000)]
elm_code: syntax fix for preprocessor over multiple lines
Andy Williams [Mon, 6 Feb 2017 23:38:23 +0000 (23:38 +0000)]
elm_code: syntax fix for comments with an escaped blackslash
Cedric BAIL [Mon, 6 Feb 2017 23:35:48 +0000 (15:35 -0800)]
ecore: make sure we always manipulate a valid timer.
Felipe Magno de Almeida [Mon, 20 Jun 2016 21:50:38 +0000 (18:50 -0300)]
efl: add composite model for boolean properties
Add Efl.Model.Composite.Boolean, a model for wrapping another Efl.Model and
adding boolean properties to its children.
Children of the given composite model will have the boolean properties
specified in Efl.Model.Composite.Boolean with the specified default value.
A call to Efl.Model.Property_set can change the property value for a child.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Larry Jr [Tue, 31 Jan 2017 20:17:58 +0000 (18:17 -0200)]
efl: add efl_model and efl_ui_view classes
Efl.Model.Container and Efl.Model.Item to efl/interfaces are used
to create Efl.Model objects with predefined property values.
This is useful to any situation where we want an Efl.Model with
explicit defined property values.
Efl.Ui.View and Efl.Ui.Factory are used to connect Efl.Models with
Widgets, Elm.Layout and Efl.Ui.Image has changed to use news interfaces
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Mon, 6 Feb 2017 22:29:56 +0000 (14:29 -0800)]
ecore: handle initialization of timer correctly.
Cedric BAIL [Mon, 6 Feb 2017 18:46:00 +0000 (10:46 -0800)]
evas: more hardening of evas access map.x
Cedric BAIL [Mon, 6 Feb 2017 18:45:12 +0000 (10:45 -0800)]
evas: harden check on map presence.
Jerome Pinot [Sun, 5 Feb 2017 12:56:18 +0000 (21:56 +0900)]
edje_example: fix compile instruction
Marcel Hollerbach [Sat, 4 Feb 2017 22:41:55 +0000 (23:41 +0100)]
elm_notify: null out allow events when its deleted
otherwise later dismisscalls to that object will lead to spammy error
messages in the console
Chidambar Zinnoury [Sat, 4 Feb 2017 18:12:03 +0000 (19:12 +0100)]
ecore thread: Fix waiting.
Waiting would sometimes return as if the thread finished correctly while it is still running.
This is because we’re waiting for the waiter data to be null… but this is always the case if the user-passed data is null!
@fix
Amitesh Singh [Sat, 4 Feb 2017 07:48:55 +0000 (13:18 +0530)]
edje: unset timer pointer after delete.
Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>
Carsten Haitzler (Rasterman) [Sat, 4 Feb 2017 02:31:55 +0000 (11:31 +0900)]
evas render - drop eo overhead by using ptrs we already have
several calls, specifically evas_object_change_reset,
evas_object_cur_prev, and evas_object_clip_changes_clean that are
called directly or indirectly as part of evas render on at least every
active object if not more, were doing full eo obj lookups when their
calling functions already all had the eo protected data looked up.
tha's silly and just adds overhead we don't need. my test dropped
_eo_obj_pointer_get overhead in perf profiles from 4.48% to 2.65%. see:
4.48% libeo.so.1.18.99 [.] _eo_obj_pointer_get
4.23% libevas.so.1.18.99 [.] evas_render_updates_internal
2.61% libevas.so.1.18.99 [.] evas_render_updates_internal_loop
1.68% libeo.so.1.18.99 [.] efl_data_scope_get
1.57% libc-2.24.so [.] _int_malloc
1.42% libevas.so.1.18.99 [.] evas_object_smart_changed_get
1.09% libevas.so.1.18.99 [.] evas_object_clip_recalc.part.37
1.08% libpthread-2.24.so [.] pthread_getspecific
1.05% libevas.so.1.18.99 [.] efl_canvas_object_class_get
1.01% libevas.so.1.18.99 [.] evas_object_cur_prev
0.99% libeo.so.1.18.99 [.] _efl_object_event_callback_legacy_call
0.87% libevas.so.1.18.99 [.] _evas_render_phase1_object_ctx_render_cache_append
0.82% libpthread-2.24.so [.] pthread_mutex_lock
0.81% libevas.so.1.18.99 [.] _evas_render_phase1_object_process
0.79% libc-2.24.so [.] _int_free
vs now the improved:
4.82% libevas.so.1.18.99 [.] evas_render_updates_internal
3.44% libevas.so.1.18.99 [.] evas_render_updates_internal_loop
2.65% libeo.so.1.18.99 [.] _eo_obj_pointer_get
2.22% libc-2.24.so [.] _int_malloc
1.46% libevas.so.1.18.99 [.] evas_object_smart_changed_get
1.04% libeo.so.1.18.99 [.] _efl_object_event_callback_legacy_call
1.03% libevas.so.1.18.99 [.] _evas_render_phase1_object_ctx_render_cache_append
0.97% libeina.so.1.18.99 [.] eina_chained_mempool_malloc
0.93% libevas.so.1.18.99 [.] evas_object_clip_recalc.part.37
0.92% libpthread-2.24.so [.] pthread_mutex_lock
0.91% libevas.so.1.18.99 [.] _evas_render_phase1_object_process
0.84% libc-2.24.so [.] _int_free
0.84% libevas.so.1.18.99 [.] evas_object_cur_prev
0.83% libeina.so.1.18.99 [.] eina_chained_mempool_free
0.80% libeo.so.1.18.99 [.] efl_data_scope_get
of course other things "increase their percentage" as oe overhead now
dropped, and things seem to move around a bit, but it does make sense
to do this with no downsides i can see as we already are accessing the
protected data ptr in the parent func.
Derek Foreman [Fri, 3 Feb 2017 21:54:48 +0000 (15:54 -0600)]
ecore_evas: use ecore_timer_loop_add for idle timeout update
This shouldn't need "exact" time, so use a loop time based timer
to potentially save a syscall on archs that don't have a vdso.
@optimize
Cedric BAIL [Fri, 3 Feb 2017 19:12:28 +0000 (11:12 -0800)]
ecore: poller could actually be related to the main loop timing.
Reduce call to ecore_time_get which is a syscall to gettimeofday.
Mike Blumenkrantz [Fri, 3 Feb 2017 20:14:01 +0000 (15:14 -0500)]
elput: add event for relative motion
@feature
Andy Williams [Fri, 3 Feb 2017 17:17:05 +0000 (17:17 +0000)]
elm_code: fix bugs in the highlighting of full line comments
@fix
Andy Williams [Fri, 3 Feb 2017 17:16:12 +0000 (17:16 +0000)]
elm_code: Add syntax highlighting for python
Andy Williams [Fri, 3 Feb 2017 17:13:27 +0000 (17:13 +0000)]
elm_code: update syntax symbols for C
Also don't hard code preprocessing parse
Gustavo Sverzut Barbieri [Fri, 3 Feb 2017 14:17:05 +0000 (12:17 -0200)]
cmake: sync EFL_EO_API_SUPPORT definition with autotools.
in autotools we always define that symbol in config.h (thus now done
in common.cmake), while the Efl_Config.h that is generated never have
it, what's left is to enable/disable the legacy and beta APIs.
This fixes building eldbus_suite with cmake.
Gustavo Sverzut Barbieri [Fri, 3 Feb 2017 13:49:38 +0000 (11:49 -0200)]
ifdef RUN_IN_TREE logic.
This logic is only needed for autotools, cmake will replicate the
installation file structure and thus eina_prefix works out of box.
Marcel Hollerbach [Fri, 3 Feb 2017 10:14:45 +0000 (11:14 +0100)]
cmake: add ecore_input
Marcel Hollerbach [Fri, 3 Feb 2017 09:39:23 +0000 (10:39 +0100)]
cmake: add eeze
there is currently a bug in the testsuite which needs to change,
otherwise modules cannot be loaded. The code acutally runs when its
installed and EFL_RUN_IN_TREE is not set.
Marcel Hollerbach [Thu, 2 Feb 2017 23:04:19 +0000 (00:04 +0100)]
eeze: move binaries into subdirectories
in order to move to cmake we are moving every binary into its own
subdirectory.
Carsten Haitzler (Rasterman) [Fri, 3 Feb 2017 05:57:49 +0000 (14:57 +0900)]
ecore_con/efl_net - dedicated threads for network i/o not from the pool
so ecore_con/efl_net were using the standard ecore_thread thread pool
for doing things like dns lookups (that can take multiple minutes
until timeouts) and actual http transactions. similarly they can block
thread workers for long periods or indefinitely thus basically
blocking the whole eocre_thread pool and stopping others from sharing
it. the best solution we have right now is to bypass the thread pool
queue and have dedicated threads for these actions. what we should
have is a dedicated thread pool with each thread taking on N
connections (via select etc.) and the ability to create and destroy
thread pools for specific tasks so you can separate the work out from
other work. but that is basically a redesign of our thread pool infra
so let's do the quick solution here until that day comes.
this partially addresses D4640
a dedicated thread per image load though is going to be a lot nastier...
Carsten Haitzler (Rasterman) [Fri, 3 Feb 2017 05:39:57 +0000 (14:39 +0900)]
edje - fix crash on loading ancient edje files
ancient edje files dont put hash strings in the file dictionary but
instead inline and thus the strings cannot be direct added... silly
ancient files.
this is a horrible ugly workaround this but there isn't really
anything better than trying to detect such files (which dont seem to
have an older version in them i can find?) so detect by pointer
address and mapping the file.
this fixes T5138
@fix
Cedric BAIL [Fri, 3 Feb 2017 00:52:38 +0000 (16:52 -0800)]
ecore: implement new requirement in the test suite.
Cedric BAIL [Fri, 3 Feb 2017 00:52:10 +0000 (16:52 -0800)]
ecore: avoid calling ecore_time_get everytime we create a timer.
This is particularly useful for ecore_timer_loop_add which are not
supposed to trigger any syscall. It does add a new requirement
on the EFL_LOOP_TIME_CLASS to always have an interval defined during
construction.
Stephen 'Okra' Houston [Thu, 2 Feb 2017 21:02:15 +0000 (15:02 -0600)]
Cpumonitor theme - Set an aspect preference other than both so we can properlyl size the gadget.
Gustavo Sverzut Barbieri [Thu, 2 Feb 2017 19:04:44 +0000 (17:04 -0200)]
cmake: add ecore_file.
Gustavo Sverzut Barbieri [Thu, 2 Feb 2017 16:43:40 +0000 (14:43 -0200)]
cmake: add ecore_ipc.
Andy Williams [Thu, 2 Feb 2017 18:47:39 +0000 (18:47 +0000)]
elm_code: Fix empty selection checks
Cedric BAIL [Thu, 2 Feb 2017 18:29:59 +0000 (10:29 -0800)]
evas: simplify waiting logic for image decoding as we do not need lock and cond with Ecore_Thread infra.