platform/upstream/dotnet/runtime.git
13 months ago[release/8.0] [iOS] Fix trimming warnings in HttpClientHandler.AnyMobile (#91877)
github-actions[bot] [Tue, 12 Sep 2023 17:22:35 +0000 (10:22 -0700)]
[release/8.0] [iOS] Fix trimming warnings in HttpClientHandler.AnyMobile (#91877)

* Unconditionally supress trimming warnings when calling InvokeNativeHandlerMethod

* Update HttpClientHandler

---------

Co-authored-by: Simon Rozsival <simon@rozsival.com>
13 months ago[release/8.0] JIT: Fix illegal IR created by GetElement/ToScalar lowering (#91874)
github-actions[bot] [Tue, 12 Sep 2023 16:07:15 +0000 (09:07 -0700)]
[release/8.0] JIT: Fix illegal IR created by GetElement/ToScalar lowering (#91874)

* JIT: Fix illegal IR created by GetElement/ToScalar lowering

These could create TYP_ULONG/TYP_UINT indirs/LCL_FLD nodes, which are
illegal.

Fix #91174

* Add test

* Fix license header in new test

---------

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
13 months agoDon't log warnings for certain RemoveAttributeInstances (#91866)
github-actions[bot] [Tue, 12 Sep 2023 15:56:53 +0000 (08:56 -0700)]
Don't log warnings for certain RemoveAttributeInstances (#91866)

Fixes #88994.

ILLinker attribute XML format has a way to express "only remove these attributes when parameter X has value of Y". We currently generate a warning and don't trim the attribute at all.

The savings from trimming these attributes are going to be miniscule. Even in IL, this is scraping the bottom of the barrel. In Native AOT these attributes are pretty effectively deduplicated across assemblies. We'll likely never need this.

This keeps the existing behavior (don't trim the attribute), but removes the warning.

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
13 months ago[release/8.0] Fix `Item4` is missing in some `ValueTuple`s' `IStructuralEquatable...
github-actions[bot] [Tue, 12 Sep 2023 15:26:55 +0000 (08:26 -0700)]
[release/8.0] Fix `Item4` is missing in some `ValueTuple`s' `IStructuralEquatable.Equals` (#91470)

* Add missing comparisons

* Add unit tests

---------

Co-authored-by: Hamish Arblaster <hamarb123@gmail.com>
13 months agoJIT: ensure AVX512 ternary operands aren't used twice (#91883)
github-actions[bot] [Mon, 11 Sep 2023 23:27:35 +0000 (17:27 -0600)]
JIT: ensure AVX512 ternary operands aren't used twice (#91883)

Don't spill unused zeros early; we might decide to use them later.

Fixes #91796.

Co-authored-by: Andy Ayers <andya@microsoft.com>
13 months ago[release/8.0] Improve perf of ActivatorUtilities.CreateInstance() (#91881)
github-actions[bot] [Mon, 11 Sep 2023 23:24:18 +0000 (17:24 -0600)]
[release/8.0] Improve perf of ActivatorUtilities.CreateInstance() (#91881)

* Improve perf of ActivatorUtilities.CreateInstance()

* Support MetadataUpdateHandler for hot reload

* Support unloadable assembly contexts

* Add tests

* Rename new test classes

* Remove Mono from test; remove cache for NetFramework; remove use of ConstructorInvoker for possible risk of callstack usage

* Misc naming etc; non-functional

* Update some comments

* Simplify use of ConditionalWeakTable.Add

---------

Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
13 months ago[release/8.0] JIT: DNER multiregs with SIMD12 (#91878)
Jakob Botsch Nielsen [Mon, 11 Sep 2023 23:23:50 +0000 (01:23 +0200)]
[release/8.0] JIT: DNER multiregs with SIMD12 (#91878)

* JIT: DNER multiregs with SIMD12s

Locals with SIMD12 fields will never match the ABI when they end up
as multireg returns, so these should always be DNER'd.

Fix #91214

* Fix test build

13 months agoCheck DotNetFinalVersionKind when setting WorkloadVersionSuffix (#91791)
Djuradj Kurepa [Mon, 11 Sep 2023 23:19:43 +0000 (01:19 +0200)]
Check DotNetFinalVersionKind when setting WorkloadVersionSuffix (#91791)

13 months ago[maccatalyst] Make sure MacProxy is included in System.Net.Http (#91599)
github-actions[bot] [Mon, 11 Sep 2023 23:18:32 +0000 (17:18 -0600)]
[maccatalyst] Make sure MacProxy is included in System.Net.Http (#91599)

https://github.com/dotnet/runtime/issues/90258 identified that `HttpClient.DefaultProxy` returned `System.Net.Http.HttpNoProxy` when using MacCatalyst. This is due to a condition in System.Net.Http.csproj not including maccatalyst as a condition and as a result, skipped adding the MacProxy sources.

Way back when, https://github.com/dotnet/runtime/pull/47823 had the condition, but this appears to have changed in https://github.com/dotnet/runtime/pull/48652 when we thought MacCatalyst would inherit settings from iOS. That turned out to not be the case and this check was never added back.

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
13 months ago[release/8.0] Fix Dispose and SendData Race on Http3 Test (#91690)
github-actions[bot] [Mon, 11 Sep 2023 23:17:44 +0000 (17:17 -0600)]
[release/8.0] Fix Dispose and SendData Race on Http3 Test (#91690)

* Fix Dispose and Send Data Race

* Review feedback

---------

Co-authored-by: Ahmet Ibrahim Aksoy (from Dev Box) <aaksoy@microsoft.com>
13 months ago[release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#91501)
dotnet-maestro[bot] [Mon, 11 Sep 2023 23:13:46 +0000 (17:13 -0600)]
[release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#91501)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230901.6

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23451.6

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230902.2

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23452.2

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230902.2

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23452.2

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230902.2

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23452.2

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230907.4

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23457.4

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230908.2

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23458.2

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230908.2

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23458.2

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230908.2

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23431.4 -> To Version 1.0.0-prerelease.23458.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months ago[release/8.0] Add Native AOT Pri0 test leg (#91373)
github-actions[bot] [Mon, 11 Sep 2023 23:09:49 +0000 (17:09 -0600)]
[release/8.0] Add Native AOT Pri0 test leg (#91373)

* Pri0 test leg

* wip

* hm

* Update Comparer_get_Default.csproj

* Revert "wip"

This reverts commit af025c048145685352b70eb76894c6d6d1eca0c5.

* Add failing JIT test to issues.targets

---------

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Andy Gocke <andy@commentout.net>
13 months agoFix implementation of NegotiateAuthentication.Wrap for Kerberos on Windows (#91311)
github-actions[bot] [Mon, 11 Sep 2023 23:09:04 +0000 (17:09 -0600)]
Fix implementation of NegotiateAuthentication.Wrap for Kerberos on Windows (#91311)

Co-authored-by: Filip Navara <navara@emclient.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
13 months ago[release/8.0] Update dependencies from dotnet/emsdk dotnet/hotreload-utils dotnet...
dotnet-maestro[bot] [Mon, 11 Sep 2023 22:39:35 +0000 (16:39 -0600)]
[release/8.0] Update dependencies from dotnet/emsdk dotnet/hotreload-utils dotnet/roslyn-analyzers dotnet/source-build-reference-packages (#91671)

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230905.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230905.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23455.3

* Update dependencies from https://github.com/dotnet/emsdk build 20230906.3

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23455.4 -> To Version 8.0.0-rc.2.23456.3

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230905.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230905.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23455.3

* Update dependencies from https://github.com/dotnet/emsdk build 20230907.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23455.4 -> To Version 8.0.0-rc.2.23457.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230905.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230907.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23425.3 -> To Version 3.11.0-beta1.23457.3

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230907.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23457.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230905.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230908.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23425.3 -> To Version 3.11.0-beta1.23458.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230907.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23457.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230905.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230908.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23425.3 -> To Version 3.11.0-beta1.23458.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230907.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23457.1

* Update dependencies from https://github.com/dotnet/emsdk build 20230910.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23455.4 -> To Version 8.0.0-rc.2.23460.1

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230905.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23428.3 -> To Version 8.0.0-alpha.0.23455.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230908.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23425.3 -> To Version 3.11.0-beta1.23458.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230907.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23457.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
13 months ago[release/8.0] Update dependencies from dotnet/roslyn (#91482)
dotnet-maestro[bot] [Mon, 11 Sep 2023 22:38:49 +0000 (16:38 -0600)]
[release/8.0] Update dependencies from dotnet/roslyn (#91482)

* Update dependencies from https://github.com/dotnet/roslyn build 20230901.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230901.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230901.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23451.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230904.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23454.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230905.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230905.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230905.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230905.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.11

* Update dependencies from https://github.com/dotnet/roslyn build 20230905.12

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23455.12

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.8

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.11

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.11

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.12

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.12

* Update dependencies from https://github.com/dotnet/roslyn build 20230906.13

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23456.13

* Update dependencies from https://github.com/dotnet/roslyn build 20230907.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230907.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230907.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230907.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230907.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230907.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230907.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23457.8

* Update dependencies from https://github.com/dotnet/roslyn build 20230908.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230908.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230908.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230908.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230908.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230908.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230908.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23458.8

* Update dependencies from https://github.com/dotnet/roslyn build 20230909.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230909.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23451.1 -> To Version 4.8.0-3.23459.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoRemove DebugProxy from ClaimsIdentity and ClaimsPrincipal (#91680)
github-actions[bot] [Mon, 11 Sep 2023 19:47:11 +0000 (12:47 -0700)]
Remove DebugProxy from ClaimsIdentity and ClaimsPrincipal (#91680)

Co-authored-by: David Cantú <dacantu@microsoft.com>
13 months ago[release/8.0] Emit less metadata for not-reflection-visible types (#91703)
github-actions[bot] [Mon, 11 Sep 2023 14:47:18 +0000 (07:47 -0700)]
[release/8.0] Emit less metadata for not-reflection-visible types (#91703)

* Emit less metadata for not-reflection-visible types

In .NET 8 we massively regressed the size of an empty WinForms app. A WinForms app now brings in a big chunk of WPF with it. I traced it down to the `ICommand` interface having a WPF `TypeConverter` and `ValueSerializer` attribute on it: https://github.com/dotnet/runtime/blob/04bd438844482c907062583153a43a9e3b37dbb8/src/libraries/System.ObjectModel/src/System/Windows/Input/ICommand.cs#L13-L16.

An empty app will have a call to a method on `ICommand`, but nothing actually implements `ICommand`. Previously this would mean we generate an unconstructed `MethodTable` for `ICommand`, the unconstructed `MethodTable`s get no reflection metadata, and that's the end of the story.

After #85810 however, the reflection stack can no longer reason about `MethodTable`s that don't have reflection metadata, so we need to generate it. This means we end up with the custom attribute and all the reflection dataflow that comes out of it.

But this metadata is not actually visible in trim safe apps (the only place where reflection could see these method tables in trim safe code is if they're used in a type comparison `x == typeof(Foo)` and we were able to optimize the method table to the unconstructed version because of that). So we can generate less of it and still get away with it.

In this PR I'm adding support for skipping generation of custom attribute metadata for such types. The size of an empty WinForms app goes from 50-something MB to 20-something MB. I think we'll be able to further reduce this number to ~7 MB or less because 12 MB of this are embedded resources that look designer related.

* CR feedback

---------

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
13 months ago[release/8.0] JIT: Handle mistyped commas in morph in pre-order too (#91718)
github-actions[bot] [Mon, 11 Sep 2023 14:45:57 +0000 (07:45 -0700)]
[release/8.0] JIT: Handle mistyped commas in morph in pre-order too (#91718)

* JIT: Compensate for mistyped commas in morph pre-order too

Morph has post-order logic to compensate for mistyped commas produced by
impStoreStruct. However, block morphing can optimize unused stores into
INDs; this interacts with the mistyped commas to produce illegal IR
shapes (e.g. `COMMA<simd12>(..., IND<ubyte>(...))`).

The ideal solution is to fix impStoreStruct (#91586 tracks this), but
this change has a more surgical fix for the problem that can be
backported to .NET 8.

Fix #91443

* Fix build

---------

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
13 months ago[release/8.0] JIT: Fix invalid zero-init suppression for untracked variables (#91840)
github-actions[bot] [Mon, 11 Sep 2023 14:44:55 +0000 (07:44 -0700)]
[release/8.0] JIT: Fix invalid zero-init suppression for untracked variables (#91840)

* JIT: Fix invalid zero-init supression for untracked variables

optRemoveRedundantZeroInits has logic to remove unnecessary zero inits
if we can determine that the local will be zeroed in the prolog. In
addition, it also has logic to suppress the prolog zero init if there is
a dominating initialization already. The latter logic was trying to
reason about liveness for untracked locals, which does not make sense.

Fix #91576

* Make EH succ logic less conservative

---------

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
13 months agoJIT: Fix invalid memory barrier removal optimization (#91870)
github-actions[bot] [Mon, 11 Sep 2023 14:42:45 +0000 (07:42 -0700)]
JIT: Fix invalid memory barrier removal optimization (#91870)

The ARM32/ARM64 backends have an optimization where they optimize out
the latter of two subsequent memory barriers if no memory store/load has
been seen between them. This optimization should not be allowed to
remove memory barriers when a call has been seen.

Fix #91732

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
13 months agoSplit the informational version on both SemVer2 separators, not just '-'. (#91760)
github-actions[bot] [Fri, 8 Sep 2023 01:56:38 +0000 (18:56 -0700)]
Split the informational version on both SemVer2 separators, not just '-'. (#91760)

This fixes a build break found when we stabilize the package version (and the only separator in the informational version is '+' before the commit id)

Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
13 months agoAdd Microsoft.Extensions.Options.SourceGeneration To TransitivePackage (#91700)
github-actions[bot] [Thu, 7 Sep 2023 15:18:26 +0000 (08:18 -0700)]
Add Microsoft.Extensions.Options.SourceGeneration To TransitivePackage (#91700)

Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
13 months ago[release/8.0] Add late binding lookup in VB.NET for COM objects (#91433)
github-actions[bot] [Wed, 6 Sep 2023 23:54:27 +0000 (16:54 -0700)]
[release/8.0] Add late binding lookup in VB.NET for COM objects (#91433)

* Add late binding lookup in VB.NET for COM objects

* Review feedback

* Feedback

---------

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
13 months ago[release/8.0] Enable interceptors implicitly in binder gen nupkg when generator is...
github-actions[bot] [Wed, 6 Sep 2023 19:52:57 +0000 (12:52 -0700)]
[release/8.0] Enable interceptors implicitly in binder gen nupkg when generator is enabled (#91559)

* Enable interceptors implicitly in binder gen nupkg when generator is enabled

* Simplify impl & remove unneeded target

---------

Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
13 months agoEnable output compilation validation in binder gen unit tests (#91602)
github-actions[bot] [Wed, 6 Sep 2023 18:42:13 +0000 (11:42 -0700)]
Enable output compilation validation in binder gen unit tests (#91602)

Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
13 months ago[release/8.0] Update dependencies from dotnet/cecil dotnet/arcade dotnet/icu dotnet...
dotnet-maestro[bot] [Wed, 6 Sep 2023 10:31:33 +0000 (12:31 +0200)]
[release/8.0] Update dependencies from dotnet/cecil dotnet/arcade dotnet/icu dotnet/source-build-reference-packages dotnet/emsdk (#91500)

* Update dependencies from https://github.com/dotnet/arcade build 20230901.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23431.2 -> To Version 8.0.0-beta.23451.1

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230901.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23428.2 -> To Version 8.0.0-alpha.1.23451.1

* Update dependencies from https://github.com/dotnet/cecil build 20230904.2

Microsoft.DotNet.Cecil
 From Version 0.11.4-alpha.23428.2 -> To Version 0.11.4-alpha.23454.2

* Update dependencies from https://github.com/dotnet/icu build 20230904.2

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 8.0.0-rc.2.23421.2 -> To Version 8.0.0-rc.2.23454.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230905.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23428.2 -> To Version 8.0.0-alpha.1.23455.1

* Bump Microsoft.Private.Intellisense package version

(cherry picked from commit 94d7ad5232a2a8a0543c29790c2eb91788818599)

* Update dependencies from https://github.com/dotnet/emsdk build 20230905.2

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23431.1 -> To Version 8.0.0-rc.2.23455.2

* Update dependencies from https://github.com/dotnet/emsdk build 20230905.4

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.2.23431.1 -> To Version 8.0.0-rc.2.23455.4

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
13 months ago[Release/8.0] Fix x64 crossbuild on macOS arm64 (#91635)
Jan Vorlicek [Wed, 6 Sep 2023 05:22:00 +0000 (07:22 +0200)]
[Release/8.0] Fix x64 crossbuild on macOS arm64 (#91635)

cpufeatures.h/.c uses TARGET_ ifdefs, but it should use HOST_ ifdefs

13 months ago[release/8.0] Fix usage of load library (#91490)
github-actions[bot] [Tue, 5 Sep 2023 01:00:22 +0000 (18:00 -0700)]
[release/8.0] Fix usage of load library (#91490)

* Use LoadLibraryExW on Windows.

* Use correct flag.

---------

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
13 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 225830...
dotnet bot [Sat, 2 Sep 2023 09:00:22 +0000 (02:00 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2258306 (#91485)

13 months ago[release/8.0] Update dependencies from dotnet/roslyn (#91420)
dotnet-maestro[bot] [Fri, 1 Sep 2023 21:26:37 +0000 (15:26 -0600)]
[release/8.0] Update dependencies from dotnet/roslyn (#91420)

* Update dependencies from https://github.com/dotnet/roslyn build 20230831.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230831.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230831.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230831.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23431.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230901.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-3.23430.6 -> To Version 4.8.0-3.23451.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months ago[release/8.0] Update dependencies from dotnet/emsdk dotnet/arcade (#91423)
dotnet-maestro[bot] [Fri, 1 Sep 2023 21:25:51 +0000 (15:25 -0600)]
[release/8.0] Update dependencies from dotnet/emsdk dotnet/arcade (#91423)

* Update dependencies from https://github.com/dotnet/emsdk build 20230831.1

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rc.1.23415.5 -> To Version 8.0.0-rc.2.23431.1

Dependency coherency updates

runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-arm64.Microsoft.NETCore.Runtime.ObjWriter,runtime.osx-x64.Microsoft.NETCore.Runtime.ObjWriter,runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 16.0.5-alpha.1.23408.1 -> To Version 16.0.5-alpha.1.23423.1 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport

* Update dependencies from https://github.com/dotnet/arcade build 20230831.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23429.1 -> To Version 8.0.0-beta.23431.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Fri, 1 Sep 2023 21:15:06 +0000 (15:15 -0600)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230831.4 (#91462)

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23430.6 -> To Version 1.0.0-prerelease.23431.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoFix LDTOKEN of methods that have modifiers (#91439)
github-actions[bot] [Fri, 1 Sep 2023 18:38:59 +0000 (12:38 -0600)]
Fix LDTOKEN of methods that have modifiers (#91439)

When we started generating custom modifiers into metadata format to support new function pointer APIs in #85504, we should have also added it to native layout format. We currently have a mismatch. This is a low risk bugfix to ignore modifiers on the metadata side. We'll want to do a full fix to actually emit and compare this. Tracked in a .NET 9 bug at #91381.

No regression test because I spent too much time being puzzled at why https://github.com/Handlebars-Net/Handlebars.Net/blob/50614fd844e5360eb10e76154aa74da4d7bf12ce/source/Handlebars/Helpers/IHelperDescriptor.cs#L13 is generated as a custom modifier (`[in] !TOptions& modreq([netstandard]System.Runtime.InteropServices.InAttribute) options`) whereas if I do it, I get `[in] !T& 'value'` with a custom attribute. We'll want to write a proper set of tests with ambiguities for the bug I opened anyway.

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
13 months agoFix runtime dispatch to static virtuals on interface types (#91440)
github-actions[bot] [Fri, 1 Sep 2023 18:34:35 +0000 (12:34 -0600)]
Fix runtime dispatch to static virtuals on interface types (#91440)

We were not generating information about static virtuals on interface types. Information about default interface methods normally goes to the class, but if the T we're dispatching on is an interface, this information wasn't generated. The fix is to put this information into dispatch maps and sealed vtables, same way we do for classes.

The test shows what the problem is - if we change `IBar` to be a class, things would work even before this PR.

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
13 months agoFix arm64/arm32 cross-DAC (#91438)
github-actions[bot] [Fri, 1 Sep 2023 18:33:48 +0000 (12:33 -0600)]
Fix arm64/arm32 cross-DAC (#91438)

The precode code was incorrectly using the HOST_ARM64, HOST_ARM, etc. defines instead
of the TARGET_ ones. This means the cross-DAC was using the wrong architectures
*Precode::Type codes.

Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
13 months ago[release/8.0] [nodejs] Remove experimental wasm arguments from template (#91401)
github-actions[bot] [Fri, 1 Sep 2023 18:31:41 +0000 (12:31 -0600)]
[release/8.0] [nodejs] Remove experimental wasm arguments from template (#91401)

* Remove experimental wasm arguments from template and add them to features.md

* Fix WBT

* Use lowercase host in runtimeconfig.template.json

* Override runtimeconfig only for wasmconsole

---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Marek Safar <marek.safar@gmail.com>
13 months ago[release/8.0] Options Source Gen Fixes (#91432)
github-actions[bot] [Fri, 1 Sep 2023 18:30:15 +0000 (12:30 -0600)]
[release/8.0] Options Source Gen Fixes (#91432)

* Options Source Gen Fixes

* Remove unnecessary interpolated string usage

* Address the feedback

* Remove repeated word in the comment

---------

Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
13 months ago[release/8.0] [Mono] Fix offset calculation for nested struct, when pinvoke is enable...
github-actions[bot] [Fri, 1 Sep 2023 18:24:29 +0000 (12:24 -0600)]
[release/8.0] [Mono] Fix offset calculation for nested struct, when pinvoke is enabled (#91417)

* Fix offset calculation for nested struct

* Add a test for nested struct with pinvoke

* Move and update test with real c++ implementation

* Exclude newly added test from wasm

* Disable interop tests on android and apple devices

---------

Co-authored-by: Fan Yang <yangfan@microsoft.com>
13 months ago[release/8.0] [DependencyInjection] introduce feature switch to disable S.R.E (#91352)
github-actions[bot] [Thu, 31 Aug 2023 22:27:06 +0000 (15:27 -0700)]
[release/8.0] [DependencyInjection] introduce feature switch to disable S.R.E (#91352)

* [DependencyInjection] introduce feature switch to disable S.R.E

When recording a new AOT profile for .NET MAUI apps running on Android,
we noticed that System.Reflection.Emit work was being done on a
background thread. The call seen in `dotnet-trace` output:

    11.32ms microsoft.extensions.dependencyinjection!Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder.GenerateMethodBody(Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite,System.Reflection.Emit.ILGenerator)

.NET Android apps are unique in that there is a JIT,
`RuntimeFeature.IsDynamicCodeCompiled` is true, System.Reflection.Emit
is possible -- S.R.E is however, not great for startup performance.

Starting threads on Android during startup can also be slow, as Android
will commonly put all but a single core to sleep for battery saving
purposes. We try to avoid starting threads on startup for "hello world"
applications on Android.

To solve this for now, introduce a new feature flag:

    Microsoft.Extensions.DependencyInjection.DisableDynamicEngine

Which, we will provide a value in either the Android or .NET MAUI
optional workload via an MSBuild property. To test, I put this in my
app's `.csproj` file:

    <RuntimeHostConfigurationOption Include="Microsoft.Extensions.DependencyInjection.DisableDynamicEngine"
                                    Condition="'$(DisableDynamicEngine)' != ''"
                                    Value="$(DisableDynamicEngine)"
                                    Trim="true" />

Customers *could* opt to change this flag, but we don't think it will
particularly useful. An example of services realized by .NET MAUI at
startup, via some logging added:

    08-25 13:21:55.647 16530 16530 I DOTNET  : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.IMauiInitializeService]
    08-25 13:21:55.664 16530 16530 I DOTNET  : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.IMauiInitializeScopedService]
    08-25 13:21:55.665 16530 16530 I DOTNET  : RealizeService called: Microsoft.Maui.Dispatching.IDispatcher
    08-25 13:21:55.668 16530 16530 I DOTNET  : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.LifecycleEvents.LifecycleEventRegistration]
    08-25 13:21:56.057 16530 16530 I DOTNET  : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.HandlerMauiAppBuilderExtensions+HandlerRegistration]
    08-25 13:21:56.115 16530 16530 I DOTNET  : RealizeService called: Microsoft.Extensions.DependencyInjection.IServiceScopeFactory
    08-25 13:21:56.670 16530 16530 I DOTNET  : RealizeService called: Microsoft.Maui.Controls.HideSoftInputOnTappedChangedManager
    08-25 13:21:56.712 16530 16530 I DOTNET  : RealizeService called: System.Collections.Generic.IEnumerable`1[Microsoft.Maui.Hosting.ImageSourcesMauiAppBuilderExtensions+ImageSourceRegistration]
    08-25 13:21:57.700 16530 16530 I DOTNET  : RealizeService using S.R.E: Microsoft.Maui.Controls.HideSoftInputOnTappedChangedManager

`HideSoftInputOnTappedChangedManager` would be realized once per page,
which would not be a huge payoff to use S.R.E for. So the only way the
S.R.E codepath could be useful on Android would be if the customer is
registering lots of services themselves. They might be better off just
using `new()` in that case?

An example of the startup time Android reports with the new flag on/off:

    DisableDynamicEngine=false
    08-25 14:31:37.462  2090  2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +733ms
    08-25 14:31:39.394  2090  2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +737ms
    08-25 14:31:41.326  2090  2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +730ms
    DisableDynamicEngine=true
    08-25 14:32:20.233  2090  2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +724ms
    08-25 14:32:22.137  2090  2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +727ms
    08-25 14:32:24.042  2090  2330 I ActivityTaskManager: Displayed com.companyname.testmaui/crc643c09abdeec717b83.MainActivity: +716ms

This was a `dotnet new maui` project, using dotnet/maui/main on a Pixel
5 device.

* Update docs/workflow/trimming/feature-switches.md

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
---------

Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
13 months ago[release/8.0] Fix nullable annotation for Validator.TryValidateValue and ValidateValu...
github-actions[bot] [Thu, 31 Aug 2023 22:26:43 +0000 (15:26 -0700)]
[release/8.0] Fix nullable annotation for Validator.TryValidateValue and ValidateValue (#91293)

* Fix nullable annotation for Validator.TryValidateValue and ValidateValue

* Revert Options source generator nullable annotation changes for Validator.TryValidateValue (#91305)

* Fix nullable annotation for Validator.ValidateValue ref source (#91351)

---------

Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
13 months agoUpdate binder gen emitted-interceptor nullability to match framework impl (#91180...
Layomi Akinrinade [Thu, 31 Aug 2023 22:25:40 +0000 (15:25 -0700)]
Update binder gen emitted-interceptor nullability to match framework impl (#91180) (#91359)

13 months agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Thu, 31 Aug 2023 15:53:58 +0000 (08:53 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230830.6 (#91390)

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23429.4 -> To Version 1.0.0-prerelease.23430.6

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoSupport Windows based ECDSA SignedCms (#91247)
github-actions[bot] [Thu, 31 Aug 2023 15:43:11 +0000 (08:43 -0700)]
Support Windows based ECDSA SignedCms (#91247)

Supports SignedCms signatured with an ECDSA key created by the Windows
API or .NET Framework. These signatures store an EC public key OID
rather than a hash specific ECDSA OID used in newer versions of dotnet.

Fixes https://github.com/dotnet/runtime/issues/77377

Co-authored-by: Jordan Borean <jborean93@gmail.com>
13 months ago[release/8.0] Update dependencies from dotnet/roslyn (#91239)
dotnet-maestro[bot] [Thu, 31 Aug 2023 15:42:42 +0000 (08:42 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#91239)

* Update dependencies from https://github.com/dotnet/roslyn build 20230828.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230828.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230828.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230828.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23428.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230828.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230828.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230828.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23428.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23429.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.9

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.10

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.12

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.12

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.13

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.13

* Update dependencies from https://github.com/dotnet/roslyn build 20230829.14

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23429.14

* Update dependencies from https://github.com/dotnet/roslyn build 20230830.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230830.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-2.23430.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230830.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230830.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230830.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230830.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23430.6

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 225643...
dotnet bot [Thu, 31 Aug 2023 08:20:42 +0000 (01:20 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256435 (#91360)

13 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 225625...
dotnet bot [Wed, 30 Aug 2023 21:07:16 +0000 (14:07 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251 (#91347)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2256251

13 months ago[release/8.0] Fix crash when calling AssemblyLoadContext.Unload twice (#91346)
github-actions[bot] [Wed, 30 Aug 2023 21:07:02 +0000 (14:07 -0700)]
[release/8.0] Fix crash when calling AssemblyLoadContext.Unload twice (#91346)

* Fix crash when calling AssemblyLoadContext.Unload twice

The AssemblyLoadContext.InitiateUnload method was not handling multiple
calls correctly. Instead of making the extra calls dummy, it was
calling the native runtime helper again.

This change fixes it by simply ensuring that the runtime helper is
called just once.

* Add regression test

---------

Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
13 months ago[release/8.0] Emit interceptor info correctly when invocation expr is on separate...
github-actions[bot] [Wed, 30 Aug 2023 21:06:02 +0000 (14:06 -0700)]
[release/8.0] Emit interceptor info correctly when invocation expr is on separate line (#91218)

* Emit interceptor info correctly when invocation expr is on separate line

* Add more tests and add helper to udpate baselines

* Add comments to binding gen tests for invocations on new lines (#91237)

* Add comments to binding gen tests for invocations on new lines

* Address feedback & test static method call syntax

* Reorganize and comment the newline/whitespace scenarios

* Reorganize and comment the newline/whitespace scenarios for ConfigurationExtensions

---------

Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
* Update baselines

---------

Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
13 months agoEnsure the relevant containable nodes are handled (#91334)
github-actions[bot] [Wed, 30 Aug 2023 19:48:03 +0000 (12:48 -0700)]
Ensure the relevant containable nodes are handled (#91334)

Co-authored-by: Tanner Gooding <tagoo@outlook.com>
13 months agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Wed, 30 Aug 2023 19:47:43 +0000 (12:47 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230829.4 (#91330)

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23427.2 -> To Version 1.0.0-prerelease.23429.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoUpdate dependencies from https://github.com/dotnet/arcade build 20230829.1 (#91329)
dotnet-maestro[bot] [Wed, 30 Aug 2023 19:43:55 +0000 (12:43 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20230829.1 (#91329)

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23428.2 -> To Version 8.0.0-beta.23429.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23423.1 -> To Version 1.0.0-beta.23426.1 (parent: Microsoft.DotNet.Arcade.Sdk

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months ago[release/8.0] [browser] Update browser template to use Wasm SDK (#91046)
github-actions[bot] [Wed, 30 Aug 2023 19:43:07 +0000 (12:43 -0700)]
[release/8.0] [browser] Update browser template to use Wasm SDK (#91046)

* Use WasmSdk in browser template

* Remove default html-path

* Use wwwroot when looking for main.js in template for replacement

* Temporarily remove WasmRuntimeAssetsLocation from WBT because WasmSDK doesn't support it yet

* Integrate console log forward into DevServer

* Replace UseRouter

* Use next middleware only if it's not console

* CancellationTokenSource on CancelKeyPress

* Address feedback from initial DevServer integration

* Update src/mono/wasm/host/BrowserHost.cs

Co-authored-by: Ankit Jain <radical@gmail.com>
* Remove debugging code

* Fix WBT

* Fix starting outside of project directory

* Support WasmRuntimeAssetsLocation in Wasm SDK

* Revert "Support WasmRuntimeAssetsLocation in Wasm SDK"

* Active issue for WasmRuntimeAssetsLocation

* Feedback

---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
13 months agoFix Http2 MultiConnection test race conditions (#91343)
github-actions[bot] [Wed, 30 Aug 2023 19:40:56 +0000 (12:40 -0700)]
Fix Http2 MultiConnection test race conditions (#91343)

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
13 months ago[release/8.0] [mono][metadata] Replace use of mem manager lock with loader lock ...
github-actions[bot] [Wed, 30 Aug 2023 17:13:55 +0000 (10:13 -0700)]
[release/8.0] [mono][metadata] Replace use of mem manager lock with loader lock (#91327)

* [mono][metadata] Replace use of mem manager lock with loader lock

Hash table operations under the mem manager lock could end up taking the loader lock when performing type comparison, in the case where custom modifiers needed to be loaded. Use the loader lock instead to prevent deadlocks.

* [mono][metadata] Use loader lock during generic class hash table lookup

---------

Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
13 months ago[release/8.0] [browser] Add `EmccMaximumHeapSize` to define maximum memory (#91277)
github-actions[bot] [Tue, 29 Aug 2023 23:40:25 +0000 (16:40 -0700)]
[release/8.0] [browser] Add `EmccMaximumHeapSize` to define maximum memory (#91277)

* EmccMaximumHeapSize to define maximum memory

* Fix typo in comment

* Space in param use

---------

Co-authored-by: Marek Fišera <mara@neptuo.com>
13 months ago[release/8.0] Update dependencies from dotnet/cecil dotnet/arcade dotnet/hotreload...
dotnet-maestro[bot] [Tue, 29 Aug 2023 23:39:26 +0000 (16:39 -0700)]
[release/8.0] Update dependencies from dotnet/cecil dotnet/arcade dotnet/hotreload-utils dotnet/source-build-reference-packages (#91264)

* Update dependencies from https://github.com/dotnet/cecil build 20230828.2

Microsoft.DotNet.Cecil
 From Version 0.11.4-alpha.23421.1 -> To Version 0.11.4-alpha.23428.2

* Update dependencies from https://github.com/dotnet/arcade build 20230828.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23425.2 -> To Version 8.0.0-beta.23428.2

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20230828.3

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23421.1 -> To Version 8.0.0-alpha.0.23428.3

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230828.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23424.1 -> To Version 8.0.0-alpha.1.23428.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
13 months ago[release/8.0] Add boolean field to indicate whether or not the Windows thread pool...
github-actions[bot] [Tue, 29 Aug 2023 23:36:57 +0000 (16:36 -0700)]
[release/8.0] Add boolean field to indicate whether or not the Windows thread pool is being used (#91246)

* Add boolean field to indicate whether or not the Windows thread pool is being used

* Update src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.Windows.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Remove trailing spaces

* Move comment

* Update fields and comments

* Disable CA1823 - unused field

---------

Co-authored-by: unknown <eduardo.velarde@pucp.pe>
Co-authored-by: Eduardo Velarde <32459232+eduardo-vp@users.noreply.github.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
13 months agobackport 90388 to Net8 (#91201)
Pavel Savara [Tue, 29 Aug 2023 23:26:43 +0000 (01:26 +0200)]
backport 90388 to Net8 (#91201)

13 months agoDisable failing test (#91269)
github-actions[bot] [Tue, 29 Aug 2023 23:26:14 +0000 (16:26 -0700)]
Disable failing test (#91269)

Co-authored-by: Fan Yang <yangfan@microsoft.com>
13 months ago[release/8.0] [Mono] Fix unsafe accessor related issue for full AOT (#91270)
github-actions[bot] [Tue, 29 Aug 2023 20:14:33 +0000 (13:14 -0700)]
[release/8.0] [Mono] Fix unsafe accessor related issue for full AOT (#91270)

* Fix unsafe accessor related issue for full aot

* Only skip for WRAPPER_SUBTYPE_UNSAFE_ACCESSOR

---------

Co-authored-by: Fan Yang <yangfan@microsoft.com>
13 months ago[release/8.0] [mono] Extend mono_gsharedvt_constrained_call JIT icall to handle stati...
github-actions[bot] [Tue, 29 Aug 2023 17:34:36 +0000 (10:34 -0700)]
[release/8.0] [mono] Extend mono_gsharedvt_constrained_call JIT icall to handle static virtual methods (#91059)

* Extend mono_gsharedvt_constrained_call JIT icall to handle static virtual methods

* Handle static virtual calls in constrained_gsharedvt_call_setup

* Fix lint

* Add runtime test

* Remove runtime test

---------

Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com>
13 months ago[release/8.0] JIT: Fix various HW intrinsic lowerings for unused values (#91266)
github-actions[bot] [Tue, 29 Aug 2023 17:27:15 +0000 (10:27 -0700)]
[release/8.0] JIT: Fix various HW intrinsic lowerings for unused values (#91266)

* JIT: Fix LowerHWIntrinsicToScalar with unused values

Fix #91173

* Fix more cases

---------

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
13 months ago[release/8.0] Add Retry and Task.Delay to WinHttpHandler AfterReadResponseServerError...
github-actions[bot] [Tue, 29 Aug 2023 17:15:34 +0000 (10:15 -0700)]
[release/8.0] Add Retry and Task.Delay to WinHttpHandler AfterReadResponseServerError_ClientWrite test (#91271)

* Add Task.Delay to give more time for reset frame

* Apply James' solution

---------

Co-authored-by: Ahmet Ibrahim Aksoy (from Dev Box) <aaksoy@microsoft.com>
13 months agoRemove AD0001 NoWarn from Microsoft.Extensions.Logging.Abstractions project (#91236)
github-actions[bot] [Tue, 29 Aug 2023 17:14:40 +0000 (10:14 -0700)]
Remove AD0001 NoWarn from Microsoft.Extensions.Logging.Abstractions project (#91236)

Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
13 months ago[ComInterfaceGenerator] Recommend [In] and [Out] attributes on array parameters ...
Jackson Schuster [Mon, 28 Aug 2023 23:01:52 +0000 (16:01 -0700)]
[ComInterfaceGenerator] Recommend [In] and [Out] attributes on array parameters (#91094) (#91231)

Recommend that methods with array parameters use [In] or [Out] attributes if there are none already, and the parameter is not in, ref, or out.

13 months ago[release/8.0] Update dependencies from dotnet/roslyn-analyzers dotnet/arcade (#91154)
dotnet-maestro[bot] [Mon, 28 Aug 2023 20:54:57 +0000 (14:54 -0600)]
[release/8.0] Update dependencies from dotnet/roslyn-analyzers dotnet/arcade (#91154)

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230825.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23424.2 -> To Version 3.11.0-beta1.23425.3

* Update dependencies from https://github.com/dotnet/arcade build 20230825.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23422.1 -> To Version 8.0.0-beta.23425.2

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23418.1 -> To Version 1.0.0-beta.23423.1 (parent: Microsoft.DotNet.Arcade.Sdk

* Update testPackages.proj

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
13 months agoEnable System.IO.Hashing tests on ios and disable tvos (#91195)
github-actions[bot] [Mon, 28 Aug 2023 18:06:08 +0000 (12:06 -0600)]
Enable System.IO.Hashing tests on ios and disable tvos (#91195)

Co-authored-by: Ivan Povazan <ivan.povazan@gmail.com>
13 months ago[release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#91172)
dotnet-maestro[bot] [Mon, 28 Aug 2023 18:05:35 +0000 (12:05 -0600)]
[release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#91172)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230826.6

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23362.5 -> To Version 1.0.0-prerelease.23426.6

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230827.2

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23362.5 -> To Version 1.0.0-prerelease.23427.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 225316...
dotnet bot [Mon, 28 Aug 2023 16:18:53 +0000 (09:18 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2253168 (#91159)

13 months ago[release/8.0] Update dependencies from dotnet/roslyn (#91148)
dotnet-maestro[bot] [Mon, 28 Aug 2023 16:18:04 +0000 (09:18 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#91148)

* Update dependencies from https://github.com/dotnet/roslyn build 20230825.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23425.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230825.2

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23425.2

* Update dependencies from https://github.com/dotnet/roslyn build 20230825.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23425.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230826.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23426.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months ago[release/8.0] Fix diagnostic creation to ensure including the URI (#91145)
github-actions[bot] [Mon, 28 Aug 2023 16:16:25 +0000 (09:16 -0700)]
[release/8.0] Fix diagnostic creation to ensure including the URI (#91145)

* Fix diagnostic creation to ensure including the URI

* Fix the same issue with the Interop source gen

---------

Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
13 months ago[mono] Handle enum return type when inlining CreateInstance (#91061)
github-actions[bot] [Mon, 28 Aug 2023 16:10:28 +0000 (09:10 -0700)]
[mono] Handle enum return type when inlining CreateInstance (#91061)

Use underlying base type when deciding how to inline a
CreateInstance invocation in mini_emit_inst_for_method.

Fixes https://github.com/dotnet/runtime/issues/90292
(Mono abort causing .NET 8 msbuild regression).

Co-authored-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
13 months agoUse reader/writer lock instead of mutex for RCW cache (#91149)
github-actions[bot] [Sat, 26 Aug 2023 22:23:39 +0000 (15:23 -0700)]
Use reader/writer lock instead of mutex for RCW cache (#91149)

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
13 months agoMerge pull request #91151 from dotnet-maestro-bot/merge/release/8.0-rc1-to-release/8.0
Eric StJohn [Sat, 26 Aug 2023 15:59:34 +0000 (08:59 -0700)]
Merge pull request #91151 from dotnet-maestro-bot/merge/release/8.0-rc1-to-release/8.0

[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'

13 months agoMerge branch 'release/8.0' into merge/release/8.0-rc1-to-release/8.0
Eric StJohn [Sat, 26 Aug 2023 02:43:12 +0000 (19:43 -0700)]
Merge branch 'release/8.0' into merge/release/8.0-rc1-to-release/8.0

13 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 225282...
dotnet bot [Sat, 26 Aug 2023 02:40:24 +0000 (19:40 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2252827 (#91144)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2252827

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2252827

13 months ago[release/8.0] Fix stack_limit handling (#91095)
github-actions[bot] [Sat, 26 Aug 2023 00:16:04 +0000 (17:16 -0700)]
[release/8.0] Fix stack_limit handling (#91095)

* Fix stack_limit handling

There is a problem with computing stack_limit in the presence of
inactive InlinedCallFrame. We were trying to call GetCallSiteSP on that
frame to get the call site SP. But when the inlined call frame is not
active (there is no call to native code in progress), that method
returns random junk.

But even if we checked for an active call before reading the value, it
would not get correct stack limit on x86 windows when there was no
active call with the inlined call frame being the topmost one. That
can happen with hardware exception handling on Windows x86. On other
targets, we always have other explicit frame on top of the explicit
frames stack, but on windows x86, we don't use the FaultingExceptionFrame for
hardware exceptions, so the inactive inlined call frame could be the
topmost one when GC starts to scan stack roots.

Since the stack_limit was introduced to fix a Unix specific problem, I
have fixed that by disabling the stack_limit usage for x86 windows.

Close #86265

* Add back the stack_limit field to keep contract unchanged

* Reflect PR feedback - Minimalize the number of ifdefs

* Reflect PR feedback

---------

Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
13 months ago[release/8.0] Update dependencies from dotnet/roslyn-analyzers dotnet/source-build...
dotnet-maestro[bot] [Sat, 26 Aug 2023 00:15:41 +0000 (17:15 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn-analyzers dotnet/source-build-reference-packages (#91114)

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230824.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23423.2 -> To Version 3.11.0-beta1.23424.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230824.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23421.1 -> To Version 8.0.0-alpha.1.23424.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoJIT: Fix physical promotion creating overlapping local uses (#91088)
github-actions[bot] [Fri, 25 Aug 2023 22:27:03 +0000 (15:27 -0700)]
JIT: Fix physical promotion creating overlapping local uses (#91088)

Physical promotion could in some cases create uses overlapping illegally
with defs when faced with seemingly last uses of structs. This is a
result of a mismatch between our model for liveness and the actual model
of local uses in the backend. In the actual model, the uses of LCL_VARs
occur at the user, which means that it is possible for there to be no
place at which to insert IR between to local uses.

The example looks like the following. Physical promotion would be faced
with a tree like

```
▌  CALL      void   Program:Foo(Program+S,Program+S)
├──▌  LCL_VAR   struct<Program+S, 4> V01 loc0
└──▌  LCL_VAR   struct<Program+S, 4> V01 loc0
```

When V01 was fully promoted, both of these are logically last uses since
all state of V01 is stored in promoted field locals. Because of that we
would make the following transformation:

```
▌  CALL      void   Program:Foo(Program+S,Program+S)
├──▌  LCL_VAR   struct<Program+S, 4> V01 loc0          (last use)
└──▌  COMMA     struct
   ├──▌  STORE_LCL_FLD int    V01 loc0         [+0]
   │  └──▌  LCL_VAR   int    V02 tmp0
   └──▌  LCL_VAR   struct<Program+S, 4> V01 loc0          (last use)
```

This creates an illegally overlapping use and def; additionally, it is
correct only in a world where the store actually would happen between
the two uses. It is also moderately dangerous to mark both of these as
last uses given the implicit byref transformation.

The fix is to avoid marking a struct use as a last use if we see more
struct uses in the same statement.

Fix #91056

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
13 months ago[release/8.0] [browser] fix MSBuild typo (#91127)
github-actions[bot] [Fri, 25 Aug 2023 22:26:42 +0000 (15:26 -0700)]
[release/8.0] [browser] fix MSBuild typo (#91127)

* fix typo

* typo

---------

Co-authored-by: pavelsavara <pavel.savara@gmail.com>
13 months ago[release/8.0] Fix a deadlock in NonGC + Profiler API (#91130)
github-actions[bot] [Fri, 25 Aug 2023 22:25:32 +0000 (15:25 -0700)]
[release/8.0] Fix a deadlock in NonGC + Profiler API (#91130)

* Address Jan's feedback

* Fix Debug build

* Clean up

* Fix debug assert

* Update frozenobjectheap.cpp

* Address feedback

* fix build

* Update src/coreclr/vm/frozenobjectheap.cpp

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Address feedback

* Add gc lock for UpdateFrozenSegment

* Address feedback

* Oops, revert unrelated change

* Use preemptive for the whole method

* PublishFrozenObject has to be called in COOP

* Update src/coreclr/vm/frozenobjectheap.cpp

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Address feedback

* Add asserts

* Address feedback

* fix build

* Address feedback

* Update src/coreclr/vm/frozenobjectheap.cpp

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
---------

Co-authored-by: EgorBo <egorbo@gmail.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
13 months ago[release/8.0] Update dependencies from dotnet/roslyn (#91093)
dotnet-maestro[bot] [Fri, 25 Aug 2023 22:17:09 +0000 (15:17 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#91093)

* Update dependencies from https://github.com/dotnet/roslyn build 20230824.1

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.1

* Update dependencies from https://github.com/dotnet/roslyn build 20230824.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230824.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23423.10 -> To Version 4.8.0-1.23424.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230824.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230824.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.8

* Update dependencies from https://github.com/dotnet/roslyn build 20230824.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230824.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.9

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoUse RuntimeIdentifierGraphPath if available in runtime copy of Microsoft.NET.CrossGen...
github-actions[bot] [Fri, 25 Aug 2023 22:11:09 +0000 (15:11 -0700)]
Use RuntimeIdentifierGraphPath if available in runtime copy of Microsoft.NET.CrossGen.targets (#91090)

Co-authored-by: Elinor Fung <elfung@microsoft.com>
13 months agoJIT: Skip Create(ToScalar(Dot(...))) transformation on mismatched types (#91089)
github-actions[bot] [Fri, 25 Aug 2023 22:10:54 +0000 (15:10 -0700)]
JIT: Skip Create(ToScalar(Dot(...))) transformation on mismatched types (#91089)

Fix #91062

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
13 months ago[release/8.0] Fix calling existing ctor with MethodInvoker; share tests with invokers...
github-actions[bot] [Fri, 25 Aug 2023 22:09:46 +0000 (15:09 -0700)]
[release/8.0] Fix calling existing ctor with MethodInvoker; share tests with invokers (#90968)

* Fix calling existing ctor with MethodInvoker; share tests with invokers

* Remove unnecessary semicolon (non functional)

---------

Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
13 months agoFix JIT_ByRefWriteBarrier unwinding on macOS x64 (#91076)
github-actions[bot] [Thu, 24 Aug 2023 23:24:40 +0000 (16:24 -0700)]
Fix JIT_ByRefWriteBarrier unwinding on macOS x64 (#91076)

Local labels in the JIT_ByRefWriteBarrier were not wrapped in the
LOCAL_LABEL macro. That causes incorrect unwinding in case an
access violation occurs inside of this function. The closest label
before the failure point is considered to be the actual function,
but it obviously doesn't have the right unwind info.

Close #89585

Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
13 months agoSuppress credscan warnings in X.509 test files (#91080)
github-actions[bot] [Thu, 24 Aug 2023 23:14:26 +0000 (16:14 -0700)]
Suppress credscan warnings in X.509 test files (#91080)

Co-authored-by: Levi Broderick <levib@microsoft.com>
13 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 225194...
dotnet bot [Thu, 24 Aug 2023 23:13:15 +0000 (16:13 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2251942 (#91082)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2251732

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2251732

13 months ago[release/8.0] `PEImage` should not permit `m_path` field mutation (#91085)
github-actions[bot] [Thu, 24 Aug 2023 22:36:51 +0000 (15:36 -0700)]
[release/8.0] `PEImage` should not permit `m_path` field mutation (#91085)

* Remove cases where PEImage::m_path was mutated. Create m_pathHash field and remove function. Remove FEATURE_CASE_SENSITIVE_FILESYSTEM.

* Address contract violations

* Remove try/catch and replace with assert

---------

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
13 months agoFix manifest MSI version generation (#91023)
github-actions[bot] [Thu, 24 Aug 2023 16:32:17 +0000 (09:32 -0700)]
Fix manifest MSI version generation (#91023)

Co-authored-by: Jacques Eloff <joeloff@users.noreply.github.com>
13 months ago[release/8.0] Update dependencies from dotnet/roslyn (#91033)
dotnet-maestro[bot] [Thu, 24 Aug 2023 15:44:24 +0000 (08:44 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#91033)

* Update dependencies from https://github.com/dotnet/roslyn build 20230823.3

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23422.14 -> To Version 4.8.0-1.23423.3

* Update dependencies from https://github.com/dotnet/roslyn build 20230823.4

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.4

* Update dependencies from https://github.com/dotnet/roslyn build 20230823.5

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.5

* Update dependencies from https://github.com/dotnet/roslyn build 20230823.6

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.6

* Update dependencies from https://github.com/dotnet/roslyn build 20230823.7

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.7

* Update dependencies from https://github.com/dotnet/roslyn build 20230823.8

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.8

* Update dependencies from https://github.com/dotnet/roslyn build 20230823.9

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.9

* Update dependencies from https://github.com/dotnet/roslyn build 20230823.10

Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
 From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.10

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoUpdate dependencies from https://github.com/dotnet/roslyn-analyzers build 20230823...
dotnet-maestro[bot] [Thu, 24 Aug 2023 15:39:38 +0000 (08:39 -0700)]
Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230823.2 (#91057)

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23421.3 -> To Version 3.11.0-beta1.23423.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
13 months agoLocalized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 225109...
dotnet bot [Wed, 23 Aug 2023 23:05:56 +0000 (16:05 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2251098 (#90996)

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2250829

* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2250829

13 months ago[release/8.0] [mono][interp] Mask all shift amounts (#90991)
github-actions[bot] [Wed, 23 Aug 2023 23:03:49 +0000 (16:03 -0700)]
[release/8.0] [mono][interp] Mask all shift amounts (#90991)

* [tests] Enable tests

* [mono][interp] Mask all shift amounts

---------

Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
13 months agoFix --make-repro-path option (#90989)
github-actions[bot] [Wed, 23 Aug 2023 23:03:15 +0000 (16:03 -0700)]
Fix --make-repro-path option (#90989)

Co-authored-by: Ivan Povazan <ivan.povazan@gmail.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
13 months ago[release/8.0] Support assignment to multiple refs in trim analyzer (#90936)
github-actions[bot] [Wed, 23 Aug 2023 21:53:41 +0000 (14:53 -0700)]
[release/8.0] Support assignment to multiple refs in trim analyzer (#90936)

* Support assignment to multiple refs

* Add support for assigning to arrays

* Fix tests for illink/nativeaot

* Remove ref local test, add issue links

---------

Co-authored-by: Sven Boemer <sbomer@gmail.com>
13 months ago[release/8.0] Fix Type.ContainsGenericParameters for function pointers (#90963)
github-actions[bot] [Wed, 23 Aug 2023 21:44:09 +0000 (14:44 -0700)]
[release/8.0] Fix Type.ContainsGenericParameters for function pointers (#90963)

* Fix Type.ContainsGenericParameters for function pointers

Fixes #84916

* Fix System.Reflection.MetadataLoadContext

* Fix Mono

* Update test

---------

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
13 months ago[release/8.0] Only initialize listeners once (#90932)
github-actions[bot] [Wed, 23 Aug 2023 21:43:00 +0000 (14:43 -0700)]
[release/8.0] Only initialize listeners once (#90932)

* Only initialize listeners once.

* Add test

* Second call

---------

Co-authored-by: Chris R <Tratcher@outlook.com>
13 months agoRemove dbgshim from platform manifest (#90924)
github-actions[bot] [Wed, 23 Aug 2023 21:39:22 +0000 (14:39 -0700)]
Remove dbgshim from platform manifest (#90924)

This package has moved out of band and should never conflict.

Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
Co-authored-by: Tom McDonald <tommcdon@microsoft.com>
13 months agoFix runtime knob names for CallCountThreshold and CallCountingDelayMs (#90841)
github-actions[bot] [Wed, 23 Aug 2023 21:39:03 +0000 (14:39 -0700)]
Fix runtime knob names for CallCountThreshold and CallCountingDelayMs (#90841)

Co-authored-by: EgorBo <egorbo@gmail.com>