platform/upstream/dotnet/runtime.git
8 years agoMerge pull request dotnet/coreclr#6949 from BruceForstall/Fix6940
Bruce Forstall [Sat, 27 Aug 2016 17:50:24 +0000 (10:50 -0700)]
Merge pull request dotnet/coreclr#6949 from BruceForstall/Fix6940

RyuJIT x86: Fix initblk with unrolled loop and constant fill

Commit migrated from https://github.com/dotnet/coreclr/commit/633a65e6e671afdb1379e705cf0ac333bfbcf8b0

8 years agoMerge pull request dotnet/coreclr#6947 from BruceForstall/Fix6097
Bruce Forstall [Sat, 27 Aug 2016 16:15:48 +0000 (09:15 -0700)]
Merge pull request dotnet/coreclr#6947 from BruceForstall/Fix6097

Fix dotnet/coreclr#6097

Commit migrated from https://github.com/dotnet/coreclr/commit/c9068cbaa317111a93e2f4d91770d655dbfddca3

8 years agoMerge pull request dotnet/coreclr#6948 from BruceForstall/Fix4992
Bruce Forstall [Sat, 27 Aug 2016 16:15:28 +0000 (09:15 -0700)]
Merge pull request dotnet/coreclr#6948 from BruceForstall/Fix4992

Fix dotnet/coreclr#4992

Commit migrated from https://github.com/dotnet/coreclr/commit/1e10c6cb6ef2ee5e2629c08166bbdafa7fdf3bbb

8 years agoRyuJIT x86: Fix initblk with unrolled loop and constant fill
Bruce Forstall [Sat, 27 Aug 2016 01:25:42 +0000 (18:25 -0700)]
RyuJIT x86: Fix initblk with unrolled loop and constant fill

The computed fill value was only using the low 8 bytes of the
xmm register; we need it to fill the entire 16 byte register.

Fixes dotnet/coreclr#6940

Commit migrated from https://github.com/dotnet/coreclr/commit/5127eef602e0c0ed5ab7f63a9bc28b81558b2084

8 years agoFix dotnet/coreclr#4992
Bruce Forstall [Sat, 27 Aug 2016 00:12:28 +0000 (17:12 -0700)]
Fix dotnet/coreclr#4992

These tests no longer fail, so re-enable them.

Commit migrated from https://github.com/dotnet/coreclr/commit/264160b2b3d373e9914e1710ce3dc1399193a00b

8 years agoFix dotnet/coreclr#6097
Bruce Forstall [Sat, 27 Aug 2016 00:04:30 +0000 (17:04 -0700)]
Fix dotnet/coreclr#6097

The tests no longer fail (were previously fixed, possibly by LIR work).
Re-enable the related tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/e371f87a5838a96be0bbeb1a23620ccb25fce775

8 years agoAdd missing link to crossgen doc in glossary
Aditya Mandaleeka [Fri, 26 Aug 2016 23:43:01 +0000 (16:43 -0700)]
Add missing link to crossgen doc in glossary

Commit migrated from https://github.com/dotnet/coreclr/commit/baa357de15cefb2763c5f7e851d7d3fe878b2465

8 years agoMerge pull request dotnet/coreclr#6938 from CarolEidt/Fix255263
Carol Eidt [Fri, 26 Aug 2016 22:48:49 +0000 (15:48 -0700)]
Merge pull request dotnet/coreclr#6938 from CarolEidt/Fix255263

Fix DevDiv bug 255263

Commit migrated from https://github.com/dotnet/coreclr/commit/160e8572a2847d02d09cdd7dfc7516880b7f2ee8

8 years agoScript to enable coreclr perf run on Linux.
Smile Wei [Fri, 26 Aug 2016 21:54:47 +0000 (14:54 -0700)]
Script to enable coreclr perf run on Linux.

Commit migrated from https://github.com/dotnet/coreclr/commit/e200846060cb29eabf346764313fd3894a630068

8 years agoMerge pull request dotnet/coreclr#6937 from adiaaida/x86Jobs
Michelle McDaniel [Fri, 26 Aug 2016 21:43:15 +0000 (14:43 -0700)]
Merge pull request dotnet/coreclr#6937 from adiaaida/x86Jobs

Enable stress jobs on x86 ryujit

Commit migrated from https://github.com/dotnet/coreclr/commit/62f8f9071035e91a1a485dee81b3ce5b927bf66b

8 years agoMerge pull request dotnet/coreclr#6919 from mellinoe/new-distro-pkgprojs
Eric Mellino [Fri, 26 Aug 2016 21:26:33 +0000 (14:26 -0700)]
Merge pull request dotnet/coreclr#6919 from mellinoe/new-distro-pkgprojs

Add pkgproj's for openSUSE 42.1 and Ubuntu 16.10

Commit migrated from https://github.com/dotnet/coreclr/commit/66caba84fc2319f9741598a4e36034323f33f4a4

8 years agoEnable stress jobs on x86 ryujit
Michelle McDaniel [Wed, 24 Aug 2016 22:13:51 +0000 (15:13 -0700)]
Enable stress jobs on x86 ryujit

We want to be able to run jitstress, gcstress, etc. jobs on ryujit to
monitor our progress. This change adds additional vars to be written to
the TestEnv script for jitstress jobs.

Commit migrated from https://github.com/dotnet/coreclr/commit/eeeae1d8b56c9e7761571748b4c21cd7424ce297

8 years agoMerge pull request dotnet/coreclr#6908 from swaroop-sridhar/retKind
Swaroop Sridhar [Fri, 26 Aug 2016 20:30:07 +0000 (13:30 -0700)]
Merge pull request dotnet/coreclr#6908 from swaroop-sridhar/retKind

GcInfo: Don't use slim header for methods with struct-returns

Commit migrated from https://github.com/dotnet/coreclr/commit/dc52f8b0dcc47beda786d9bfce5b1caafeca5823

8 years agoFix DevDiv bug 255263
Carol Eidt [Thu, 25 Aug 2016 23:55:22 +0000 (16:55 -0700)]
Fix DevDiv bug 255263

This issue arose because we were not considering punpckldq as
one of the 3-operand AVX instructions (which require us to duplicate
the source register when encoding an SSE 2-operand form).
This bug showed up in managed C++, so the test is in IL.
The test is failing in RyuJIT/x86, so issue dotnet/coreclr#6940 has been opened,
and it is disabled for x86.

Commit migrated from https://github.com/dotnet/coreclr/commit/e9d954bf1c6510c0831efbee7711c84e758fa567

8 years agoMerge pull request dotnet/coreclr#6914 from echesakov/ValueNumberingAssertFix
Egor Chesakov [Fri, 26 Aug 2016 19:48:32 +0000 (12:48 -0700)]
Merge pull request dotnet/coreclr#6914 from echesakov/ValueNumberingAssertFix

Bug fix: fgOptimizeBranch loses bbFlags while duplicating the conditional block

Commit migrated from https://github.com/dotnet/coreclr/commit/2476368ac219b27bccdd71809f51688ca65ea25f

8 years agofgOptimizeBranch loses bbFlags while duplicating the block dotnet/coreclr#6886
Egor Chesakov [Wed, 24 Aug 2016 00:35:10 +0000 (17:35 -0700)]
fgOptimizeBranch loses bbFlags while duplicating the block dotnet/coreclr#6886

1. When `fgOptimizeBranch` procedure duplicates the conditional basic block it does
not copy flags of the `bDest` block to the `bJump` block. For example, if a flag
`BBF_HAS_NEWOBJ` was set in `bDest`, but not in `bJump` when the branch optimization
is done the `bbFlags` of `bJump` will not reflect the fact that we have new object
construction in this block.

2. In `DEBUG` always check if `bbFlags` has `BBF_HAS_NEWOBJ` flag set if at least one
`GT_ALLOCOBJ` canonical node found. This helps to identify situations when compiler loses `BBF_HAS_NEWOBJ` flag.

Commit migrated from https://github.com/dotnet/coreclr/commit/12f327477b6c1e18b6db7d0b2ec3445ef3997c17

8 years agoImplement the IEquatable interfaces on IntPtr and UIntPtr (dotnet/coreclr#6921)
James Ko [Fri, 26 Aug 2016 05:33:49 +0000 (01:33 -0400)]
Implement the IEquatable interfaces on IntPtr and UIntPtr (dotnet/coreclr#6921)

Commit migrated from https://github.com/dotnet/coreclr/commit/74ac12bf9966c5f0f6c58b72bbb99b08727c3d4e

8 years agoMake GetHRForException to return e.HResult on non-Windows platforms (dotnet/coreclr...
Jan Kotas [Fri, 26 Aug 2016 01:14:28 +0000 (18:14 -0700)]
Make GetHRForException to return e.HResult on non-Windows platforms (dotnet/coreclr#6929)

Fixes https://github.com/dotnet/corefx/issues/11144

Commit migrated from https://github.com/dotnet/coreclr/commit/9caa82a7b334836b474a89188f2ffb0def582785

8 years agoMerge pull request dotnet/coreclr#6926 from jashook/arm32_ci_update
Jarret Shook [Thu, 25 Aug 2016 23:22:11 +0000 (16:22 -0700)]
Merge pull request dotnet/coreclr#6926 from jashook/arm32_ci_update

Incremental progress addressing dotnet/coreclr#6676

Commit migrated from https://github.com/dotnet/coreclr/commit/7234a53b0e50c330c8e438c36acced507a83e5e0

8 years agoIncremental progress addressing dotnet/coreclr#6676
jashoo [Thu, 25 Aug 2016 21:54:29 +0000 (14:54 -0700)]
Incremental progress addressing dotnet/coreclr#6676

This change is based upon dotnet/coreclr#6910 by sjsinju to fix the arm emulator
running out of space. It changes uses the /opt folder on the main
system drive to /mnt which has a larger local disk.

Commit migrated from https://github.com/dotnet/coreclr/commit/aab8db1993a975866661c21f74dedef9154789a6

8 years agoAvoid unnecessary indirection in char.ToString (dotnet/coreclr#6903)
James Ko [Thu, 25 Aug 2016 22:01:02 +0000 (18:01 -0400)]
Avoid unnecessary indirection in char.ToString (dotnet/coreclr#6903)

Avoid unnecessary indirection in char.ToString

Commit migrated from https://github.com/dotnet/coreclr/commit/76048c739addb3da99ce12e886ded090753b5579

8 years agoAdd pkgproj's for Ubuntu 16.10
Eric Mellino [Thu, 25 Aug 2016 18:38:35 +0000 (11:38 -0700)]
Add pkgproj's for Ubuntu 16.10

Commit migrated from https://github.com/dotnet/coreclr/commit/140a7daa162b4bacdce53de5ae9593fdcb032981

8 years agoAdd pkgproj's for openSUSE 42.1
Eric Mellino [Thu, 25 Aug 2016 18:34:11 +0000 (11:34 -0700)]
Add pkgproj's for openSUSE 42.1

Commit migrated from https://github.com/dotnet/coreclr/commit/ab0da4ca8353eae536b98aaccdf3b6ff34ccff84

8 years agoMerge pull request dotnet/coreclr#6923 from dotnet/revert-6910-sjsinju_devel
Matt Mitchell [Thu, 25 Aug 2016 21:11:37 +0000 (14:11 -0700)]
Merge pull request dotnet/coreclr#6923 from dotnet/revert-6910-sjsinju_devel

Revert "ARM-CI : Fix ARM Emulator vm runs out of space"

Commit migrated from https://github.com/dotnet/coreclr/commit/18983192247694d52f65036ac3448db692ae09a7

8 years agoRevert "ARM-CI : Fix ARM Emulator vm runs out of space"
Matt Mitchell [Thu, 25 Aug 2016 21:08:59 +0000 (14:08 -0700)]
Revert "ARM-CI : Fix ARM Emulator vm runs out of space"

Commit migrated from https://github.com/dotnet/coreclr/commit/ba2deb3900ea854ec2b9d0c3fe89ad4f2a19a118

8 years agoARM-CI : Fix ARM Emulator vm runs out of space (dotnet/coreclr#6910)
Sujin Kim [Thu, 25 Aug 2016 21:01:27 +0000 (06:01 +0900)]
ARM-CI : Fix ARM Emulator vm runs out of space (dotnet/coreclr#6910)

Now, ARM Emulator failed by out of space on tests (6676)
To resolve, a temp folder in the job's workspace is binded to /tmp. and then 'runtest.sh' would be run by some directories binded from /tmp.

Commit migrated from https://github.com/dotnet/coreclr/commit/a0caf5715c05ee75c694303cf08168e95bc19151

8 years agoImprove perf of Encoding.GetEncoding(int) (dotnet/coreclr#6907)
Justin Van Patten [Thu, 25 Aug 2016 18:54:11 +0000 (11:54 -0700)]
Improve perf of Encoding.GetEncoding(int) (dotnet/coreclr#6907)

`Encoding.GetEncoding(int)` caches encoding instances in a `Hashtable`.
This involves locking and boxing the codepage (potentially multiple
times). For the encodings that are already cached in static fields
(e.g. UTF8, Unicode, ASCII, etc.), this is unnecessary overhead --
these instances do not need to be stored in the `Hashtable` because
they are already stored in static fields.

It turns out the only instance that would be stored in the
`Hashtable` in CoreCLR is UTF32BE. Thus, on CoreCLR, we can remove the
use of the `Hashtable` altogether, and instead store the UTF32BE
instance in a static field. This means the `Hashtable` static field,
lock object, and box allocations go away entirely on CoreCLR.

We now check for the encodings that can be cached in static fields in a
switch statement up-front. On Desktop, it then falls back to doing the
`Hashtable`-based lookup/storage, and only boxes codepage once.

Commit migrated from https://github.com/dotnet/coreclr/commit/24918bf5e4bd94547b994a3a3f8d565e972eeac6

8 years agoPut back Open key signing on the SOS.NETCore assembly. (dotnet/coreclr#6905)
Mike McLaughlin [Thu, 25 Aug 2016 16:47:52 +0000 (09:47 -0700)]
Put back Open key signing on the SOS.NETCore assembly. (dotnet/coreclr#6905)

Fix failure in SOS if System.Reflection.Metadata is missing.

Commit migrated from https://github.com/dotnet/coreclr/commit/4f0fbd0cbb8606055b222300d68ecd2f44ee2ca4

8 years agoMerge pull request dotnet/coreclr#6909 from kouvel/Api
Stephen Toub [Thu, 25 Aug 2016 11:32:21 +0000 (07:32 -0400)]
Merge pull request dotnet/coreclr#6909 from kouvel/Api

Expose constructor with argument for safe handle types instead of con…

Commit migrated from https://github.com/dotnet/coreclr/commit/cba9a2338a8904c12ac4e2e7de8f61001f31b1b5

8 years agoMerge pull request dotnet/coreclr#6898 from benaadams/semaphore-timeout-0
Stephen Toub [Thu, 25 Aug 2016 11:29:39 +0000 (07:29 -0400)]
Merge pull request dotnet/coreclr#6898 from benaadams/semaphore-timeout-0

Semaphoreslim, fail faster for timeout 0

Commit migrated from https://github.com/dotnet/coreclr/commit/8e794b59c0f2823d7668946fc8e683b461f3d795

8 years agoSemaphoreSlim, fail faster for timeout 0
Ben Adams [Wed, 24 Aug 2016 19:02:29 +0000 (20:02 +0100)]
SemaphoreSlim, fail faster for timeout 0

Commit migrated from https://github.com/dotnet/coreclr/commit/21c89ff541d210d4bef04e074c1be962d3104fbc

8 years agoExpose constructor with argument for safe handle types instead of constructor without...
Koundinya Veluri [Thu, 25 Aug 2016 06:37:42 +0000 (23:37 -0700)]
Expose constructor with argument for safe handle types instead of constructor without argument

Commit migrated from https://github.com/dotnet/coreclr/commit/503f879f3093b96372f1b6a9eff0d420cba413c3

8 years agoCleanup/optimize many string.Compare overloads, part 1 (dotnet/coreclr#6603)
James Ko [Thu, 25 Aug 2016 05:10:46 +0000 (01:10 -0400)]
Cleanup/optimize many string.Compare overloads, part 1 (dotnet/coreclr#6603)

Cleanup, optimize some String.Compare overloads

Commit migrated from https://github.com/dotnet/coreclr/commit/d67f034cf37717b94a97b59b86bde49ae4fbb6af

8 years agoRemove idiv from ThreadPoolWorkQueue:Dequeue loop (dotnet/coreclr#6781)
Ben Adams [Thu, 25 Aug 2016 05:08:53 +0000 (06:08 +0100)]
Remove idiv from ThreadPoolWorkQueue:Dequeue loop (dotnet/coreclr#6781)

Commit migrated from https://github.com/dotnet/coreclr/commit/ff315182efd0754428e6b9be2d4031b8e899f82a

8 years agoGcInfo: Don't use slim header for struct-returns
Swaroop Sridhar [Thu, 25 Aug 2016 01:53:42 +0000 (18:53 -0700)]
GcInfo: Don't use slim header for struct-returns

This checkin has two changes:
1) Add a check to ensure that methods with struct-returns are
use the fat header which encodes ReturnKind in 4 bits.
2) Fix a bug in GetReturnKind().

Commit migrated from https://github.com/dotnet/coreclr/commit/a12ba4633d0fea6792fcb73ed363f49e336f3f62

8 years agoMerge pull request dotnet/coreclr#6883 from gkhanna79/WinArm32
Gaurav Khanna [Thu, 25 Aug 2016 00:58:42 +0000 (17:58 -0700)]
Merge pull request dotnet/coreclr#6883 from gkhanna79/WinArm32

Enable Windows Arm32 build

Commit migrated from https://github.com/dotnet/coreclr/commit/9426f7ed702e5b8cbc4ffb0ad89a2ad7a448c56c

8 years agoBetter lazy initialization for Encoding static properties (dotnet/coreclr#6890)
James Ko [Wed, 24 Aug 2016 23:18:39 +0000 (19:18 -0400)]
Better lazy initialization for Encoding static properties (dotnet/coreclr#6890)

Better lazy initialization for Encoding static properties

Commit migrated from https://github.com/dotnet/coreclr/commit/df50db75953d87485563c7542048f4c1aa402ede

8 years agoRemove extra TypeForward from facade to fix ConfiguredTaskAwaiter (dotnet/coreclr...
Jose Perez Rodriguez [Wed, 24 Aug 2016 23:10:23 +0000 (16:10 -0700)]
Remove extra TypeForward from facade to fix ConfiguredTaskAwaiter (dotnet/coreclr#6899)

Commit migrated from https://github.com/dotnet/coreclr/commit/0da00521a99ae13522697d5fd58f9200c753b9a5

8 years agoFix dotnet/coreclr#3554. (dotnet/coreclr#6880)
Pat Gavlin [Wed, 24 Aug 2016 22:50:04 +0000 (15:50 -0700)]
Fix dotnet/coreclr#3554. (dotnet/coreclr#6880)

On x86, `emitter::emitInsBinary` was calling `genProduceReg` on the
`dst` tree if the source was a contained class field load and the
destination was a register. As per the comment on the offending
function, it is the caller's responsibility to call `genProduceReg`
for the destination register, if any. This was causing errors in
GC ref reporting on x86. This issue did not appear on x64 because
AFAICT we very nearly always morph class field loads into loads of
a `CNS_INT` handle (see morph.cpp:6344 in `fgMorphField` for
details).

Commit migrated from https://github.com/dotnet/coreclr/commit/2c38643f91d98a278d8084c2d776d927a4405e16

8 years agoAdd single separator String.Split overloads (dotnet/coreclr#895)
Justin Van Patten [Wed, 24 Aug 2016 22:34:20 +0000 (15:34 -0700)]
Add single separator String.Split overloads (dotnet/coreclr#895)

Commit migrated from https://github.com/dotnet/coreclr/commit/a352d949e5342e13b1ac1f545711d7f5d12bd8ce

8 years agoMerge pull request dotnet/coreclr#6859 from adiaaida/addNMakeOption
Michelle McDaniel [Wed, 24 Aug 2016 22:12:17 +0000 (15:12 -0700)]
Merge pull request dotnet/coreclr#6859 from adiaaida/addNMakeOption

Update build to optionally configure with nmake

Commit migrated from https://github.com/dotnet/coreclr/commit/7784afd1e33855d8672c4e5075783d7817cb6b39

8 years agoUpdate build to optionally configure with nmake
Michelle McDaniel [Fri, 19 Aug 2016 22:35:25 +0000 (15:35 -0700)]
Update build to optionally configure with nmake

For formatting, we want to be able to obtain the compile_commands.json
file so that we do not have to 1) do a full build of coreclr and 2)
generate it ourselves from the build log. This change modifies build.cmd
to take an option "usenmakemakefiles." This option will set
__NMakeMakefiles to 1, which is used by the gen-buildsys-win.bat script.
This option also sets all the same options as configureonly, as we cannot
do a full build using NMake Makefiles, and we only want to use this to
force CMake to generate a compile_commands.json file for the jit
directory, which it can do using NMake Makefiles, but not Visual Studio.
The update to gen-buildsys-win.bat checks the value of __NMakeMakefiles,
and if it is set to 1, it sets the CMake Generator to NMake Makefiles.

Commit migrated from https://github.com/dotnet/coreclr/commit/7d53e9b49c3cb0802f2cd8542c1f54ec6cd38612

8 years agoMerge pull request dotnet/coreclr#6896 from dotnet-bot/from-tfs
Jan Kotas [Wed, 24 Aug 2016 20:15:05 +0000 (13:15 -0700)]
Merge pull request dotnet/coreclr#6896 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/03ff9b0b6b7fc7a037f4d03a904ed5da8a208dbb

8 years agoDisabling test against issue 6553 (dotnet/coreclr#6895)
Jan Kotas [Wed, 24 Aug 2016 20:14:05 +0000 (13:14 -0700)]
Disabling test against issue 6553 (dotnet/coreclr#6895)

Commit migrated from https://github.com/dotnet/coreclr/commit/36cf34141d5266b3bca99b9d3cf683725376e2a8

8 years agoAllow Ubuntu 16.10 to use MSBuild (dotnet/coreclr#6897)
Eric Mellino [Wed, 24 Aug 2016 20:13:06 +0000 (13:13 -0700)]
Allow Ubuntu 16.10 to use MSBuild (dotnet/coreclr#6897)

Commit migrated from https://github.com/dotnet/coreclr/commit/7c6f1b70015d7138bfc5ab3731fb894485e521db

8 years agoHandle multi-reg PUTARG_STK nodes. (dotnet/coreclr#6870)
Pat Gavlin [Wed, 24 Aug 2016 19:58:25 +0000 (12:58 -0700)]
Handle multi-reg PUTARG_STK nodes. (dotnet/coreclr#6870)

* Handle multi-reg PUTARG_STK nodes.

When FEATURE_MULTIREG_ARGS is true, a GT_PUTARG_STK node may have a
GT_LIST as a child if the child was originally a multi-reg argument.
Handle this case in `GenTreeUseEdgeIterator`.

Fixes dotnet/coreclr#6583.

* Update the bug number for some ARM64 failures.

These tests are now failing due to a differnt bug.

Commit migrated from https://github.com/dotnet/coreclr/commit/4071333a89d6c9bf240b8291535fdf7acf708642

8 years agoMerge pull request dotnet/coreclr#6894 from adiaaida/morphingLongCall
Michelle McDaniel [Wed, 24 Aug 2016 19:54:59 +0000 (12:54 -0700)]
Merge pull request dotnet/coreclr#6894 from adiaaida/morphingLongCall

Remove NYI for helper calls with long return types

Commit migrated from https://github.com/dotnet/coreclr/commit/6a119e8e4d6c0aba7897069c1a594c02a881102f

8 years agoSome minor changes.
Gaurav Khanna [Wed, 24 Aug 2016 19:33:27 +0000 (12:33 -0700)]
Some minor changes.

Commit migrated from https://github.com/dotnet/coreclr/commit/6b5695013d972fd1239241a6613865749123e0fa

8 years agoMerge pull request dotnet/coreclr#6887 from BruceForstall/Fix6588a
Bruce Forstall [Wed, 24 Aug 2016 18:01:19 +0000 (11:01 -0700)]
Merge pull request dotnet/coreclr#6887 from BruceForstall/Fix6588a

Fix local var ref counts in IND/STOREIND decomposition

Commit migrated from https://github.com/dotnet/coreclr/commit/de35406913bf2fd02dd692c031194017da5dee92

8 years agoMerge pull request dotnet/coreclr#6866 from tarekgh/GlobalizationPorting1
Tarek Mahmoud Sayed [Wed, 24 Aug 2016 17:54:28 +0000 (10:54 -0700)]
Merge pull request dotnet/coreclr#6866 from tarekgh/GlobalizationPorting1

Enable more code under globalization for netcore

Commit migrated from https://github.com/dotnet/coreclr/commit/37f4a5a473ff0ee43536b8aa12eb25238a85aed4

8 years agoFix full framework build
Jan Kotas [Wed, 24 Aug 2016 17:44:37 +0000 (10:44 -0700)]
Fix full framework build

[tfs-changeset: 1623920]

Commit migrated from https://github.com/dotnet/coreclr/commit/afcff256a27d5f04ce899fb8bbd749137fe23417

8 years agoRemove NYI for helper calls with long return types
Michelle McDaniel [Wed, 24 Aug 2016 15:38:48 +0000 (08:38 -0700)]
Remove NYI for helper calls with long return types

The LIR changes fixed the bug in the decomp and the dumper for morphing
nodes into helper calls with long return types, so this NYI can be
removed.

Commit migrated from https://github.com/dotnet/coreclr/commit/53ad9e12cc0cdd94c54d5ef59edb071d6c4ae3b7

8 years agoMerge pull request dotnet/coreclr#6882 from rahku/arm64tests
Rahul Kumar [Wed, 24 Aug 2016 06:32:05 +0000 (23:32 -0700)]
Merge pull request dotnet/coreclr#6882 from rahku/arm64tests

ARM64: update tests.lst

Commit migrated from https://github.com/dotnet/coreclr/commit/809524536f47fc76b2c1864f13a38166bac9db07

8 years agoInitial commit to build Win32 Arm CoreCLR
Gaurav Khanna [Mon, 22 Aug 2016 16:45:43 +0000 (09:45 -0700)]
Initial commit to build Win32 Arm CoreCLR

Commit migrated from https://github.com/dotnet/coreclr/commit/ad7c799eb9a2ae1e7371c75655d4b244e196b239

8 years agoMerge pull request dotnet/coreclr#6851 from ramarag/unifytestbuild
Rama krishnan Raghupathy [Wed, 24 Aug 2016 05:18:47 +0000 (22:18 -0700)]
Merge pull request dotnet/coreclr#6851 from ramarag/unifytestbuild

Changing The way Coreclr Test Builds

Commit migrated from https://github.com/dotnet/coreclr/commit/d7821eb792915fa64ff6219c7ce4b9abc195ab7e

8 years agoMerge pull request dotnet/coreclr#6885 from BruceForstall/FixLIRComments
Bruce Forstall [Wed, 24 Aug 2016 04:37:42 +0000 (21:37 -0700)]
Merge pull request dotnet/coreclr#6885 from BruceForstall/FixLIRComments

Fix DecomposeStoreInd comments

Commit migrated from https://github.com/dotnet/coreclr/commit/bf5d75d55a16611d1d9b6719ddc8c6a1c835908c

8 years agoMerge pull request dotnet/coreclr#6869 from joperezr/AddingTimeZone
Jose Perez Rodriguez [Wed, 24 Aug 2016 03:59:36 +0000 (20:59 -0700)]
Merge pull request dotnet/coreclr#6869 from joperezr/AddingTimeZone

Adding System.TimeZone

Commit migrated from https://github.com/dotnet/coreclr/commit/6a019ad175ff7e1d963f7e4cbd730b9ba8ac62b3

8 years agoModule.Name: Avoid unnecessary char[] allocation (dotnet/coreclr#6865)
Justin Van Patten [Wed, 24 Aug 2016 03:21:45 +0000 (20:21 -0700)]
Module.Name: Avoid unnecessary char[] allocation (dotnet/coreclr#6865)

Instead of `new string(s.ToCharArray(), i + 1, s.Length - i - 1)`, use
the simpler `string.Substring(i + 1)` to avoid the unnecessary
intermediate char[] allocation.

Commit migrated from https://github.com/dotnet/coreclr/commit/cacf46feb64583d1e774a2a3c9c12da1120effa7

8 years agoDateTimeFormat: Avoid intermediate char[] allocation (dotnet/coreclr#6863)
Justin Van Patten [Wed, 24 Aug 2016 03:16:22 +0000 (20:16 -0700)]
DateTimeFormat: Avoid intermediate char[] allocation (dotnet/coreclr#6863)

An unnecessary intermediate char[] allocation can be avoided by calling
`new string(c, 1)` instead of `new string(new char[] { c })`.

Commit migrated from https://github.com/dotnet/coreclr/commit/d014a8fab82d2ff70185ae6c29d2ae5a4074cc00

8 years agoAllow to use clang 3.9 in build.sh (dotnet/coreclr#6888)
Łukasz Domeradzki [Wed, 24 Aug 2016 02:42:55 +0000 (04:42 +0200)]
Allow to use clang 3.9 in build.sh (dotnet/coreclr#6888)

Can be found e.g. in Debian Sid.

Commit migrated from https://github.com/dotnet/coreclr/commit/bc2bcc0cde64d43019cfab61d4cc7f8cf783173f

8 years ago Infra changes to unify the tests to be built against a common project.json.
Rama Krishnan Raghupathy [Wed, 24 Aug 2016 01:31:26 +0000 (18:31 -0700)]
  Infra changes to unify the  tests to be built against a common project.json.
   1. tests\src\Common\test_dependencies\project.json - To consume corefx and other nuget feeds

   2. tests\src\Common\empty\project.json - To build against the mscorlib facade,to use this just Add
            <ReferenceLocalMscorlib>true</ReferenceLocalMscorlib> to your project

Commit migrated from https://github.com/dotnet/coreclr/commit/71dd695faef9e6d310a2df612cb51462dfeefc98

8 years agoCosmetic changes, removing unnceseary files and entries in project files.
Rama Krishnan Raghupathy [Wed, 24 Aug 2016 01:29:55 +0000 (18:29 -0700)]
Cosmetic changes, removing unnceseary files and entries in project files.
    Unifying the way project referring mscorlib facade builds

Commit migrated from https://github.com/dotnet/coreclr/commit/5537ed53eeedc0176b973787944512ebdd1f4ebc

8 years agoDisable downloading xplat binaries as we no longer need to build these packages in...
dotnet bot [Wed, 24 Aug 2016 00:53:29 +0000 (17:53 -0700)]
Disable downloading xplat binaries as we no longer need to build these packages in razzle. (dotnet/coreclr#6871)

[tfs-changeset: 1623740]

Commit migrated from https://github.com/dotnet/coreclr/commit/ecf77758f8364bfa3ba2494a22da81e1c5b368dc

8 years agoFix local var ref counts in IND/STOREIND decomposition
Bruce Forstall [Wed, 24 Aug 2016 00:38:30 +0000 (17:38 -0700)]
Fix local var ref counts in IND/STOREIND decomposition

When creating new references to a local variable in long decomposition,
the variable reference count must be incremented.

Fixes dotnet/coreclr#6588

Commit migrated from https://github.com/dotnet/coreclr/commit/9fe631c1ae3ce12b05de6fdcc7eba465be8ec2ec

8 years agoFix DecomposeStoreInd comments
Bruce Forstall [Wed, 24 Aug 2016 00:10:31 +0000 (17:10 -0700)]
Fix DecomposeStoreInd comments

Commit migrated from https://github.com/dotnet/coreclr/commit/0d9a44f9f0a11546ebd4d65af490f047b143d595

8 years agoupdate tests.lst
Rahul Kumar [Tue, 23 Aug 2016 23:58:22 +0000 (16:58 -0700)]
update tests.lst

Commit migrated from https://github.com/dotnet/coreclr/commit/ec1e4ebff3a901890c0a3494b567fdbf5d9de37c

8 years agoMoving baseservices tests to use uber project.json
Rama Krishnan Raghupathy [Sat, 20 Aug 2016 02:08:01 +0000 (19:08 -0700)]
Moving baseservices tests to use uber project.json

Commit migrated from https://github.com/dotnet/coreclr/commit/0c9a68a6be96249143970501cbebbb1f289a58ea

8 years agoBulk moving Tests to use uber project.json
Rama Krishnan Raghupathy [Sat, 20 Aug 2016 02:03:28 +0000 (19:03 -0700)]
Bulk moving Tests to use uber project.json

Commit migrated from https://github.com/dotnet/coreclr/commit/513543505aaa43108d3a6fffc85dd0b81f91b23a

8 years agoMoving GC tests to use uber project.json
Rama Krishnan Raghupathy [Sat, 20 Aug 2016 02:01:27 +0000 (19:01 -0700)]
Moving GC tests to use uber project.json

Commit migrated from https://github.com/dotnet/coreclr/commit/3b8c43389488ce1c33c0909b72f3a5092abc4826

8 years agoMerge pull request dotnet/coreclr#6873 from BruceForstall/Fix6180
Bruce Forstall [Tue, 23 Aug 2016 23:15:44 +0000 (16:15 -0700)]
Merge pull request dotnet/coreclr#6873 from BruceForstall/Fix6180

Reenable tests

Commit migrated from https://github.com/dotnet/coreclr/commit/ff9ac8f2be9a0bcc1657efee2b09de435c6baa0f

8 years agoEnable more code under globalization for netcore
Tarek Mahmoud Sayed [Tue, 23 Aug 2016 18:23:19 +0000 (11:23 -0700)]
Enable more code under globalization for netcore
This fix is to enable the code handling LCID for Windows in globalization namespace

Commit migrated from https://github.com/dotnet/coreclr/commit/1153e4cefbee7d59a659344e709a3a223bb6aa87

8 years agoStop maintaining costs in fgSimpleLowering. (dotnet/coreclr#6872)
Pat Gavlin [Tue, 23 Aug 2016 22:41:09 +0000 (15:41 -0700)]
Stop maintaining costs in fgSimpleLowering. (dotnet/coreclr#6872)

This was causing a few asserts on x86.

Commit migrated from https://github.com/dotnet/coreclr/commit/9b46970f46ca055932d8a2815965fff702c37557

8 years agoMerge pull request dotnet/coreclr#6868 from mmitche/disable-node-reuse
Matt Mitchell [Tue, 23 Aug 2016 22:34:40 +0000 (15:34 -0700)]
Merge pull request dotnet/coreclr#6868 from mmitche/disable-node-reuse

Disable node reuse

Commit migrated from https://github.com/dotnet/coreclr/commit/24978b97358d397c264291a46af5bc2d0f290356

8 years agoMerge pull request dotnet/coreclr#6858 from adiaaida/fixBuildsh
Michelle McDaniel [Tue, 23 Aug 2016 21:34:47 +0000 (14:34 -0700)]
Merge pull request dotnet/coreclr#6858 from adiaaida/fixBuildsh

Fix ConfigureOnly option in build.sh

Commit migrated from https://github.com/dotnet/coreclr/commit/aeb33545748b9d727d07ab079a0e92011a5b74d9

8 years agoReenable tests
Bruce Forstall [Tue, 23 Aug 2016 21:22:48 +0000 (14:22 -0700)]
Reenable tests

The tests disabled due to the assert in dotnet/coreclr#6180 no longer fail
(possibly as a side-effect of the LIR backend changes?), so
reenable them.

Commit migrated from https://github.com/dotnet/coreclr/commit/49192f8292ecd1e8e0204d1a4fafe10241f86141

8 years agoDisable node reuse
Matt Mitchell [Tue, 23 Aug 2016 19:03:41 +0000 (12:03 -0700)]
Disable node reuse

Commit migrated from https://github.com/dotnet/coreclr/commit/8d46dc0976d15292f60524fa3fcc6408f868ea1e

8 years agoMerge pull request dotnet/coreclr#6815 from rahku/apicompat
Rahul Kumar [Tue, 23 Aug 2016 20:34:30 +0000 (13:34 -0700)]
Merge pull request dotnet/coreclr#6815 from rahku/apicompat

Expose MulticastDelegate.GetObjectData method

Commit migrated from https://github.com/dotnet/coreclr/commit/43d27e01d18c666f4293947666eb51343a68271a

8 years agoAdd missing .gitmirror file. (dotnet/coreclr#6864)
dotnet bot [Tue, 23 Aug 2016 19:58:41 +0000 (12:58 -0700)]
Add missing .gitmirror file. (dotnet/coreclr#6864)

[tfs-changeset: 1623730]

Commit migrated from https://github.com/dotnet/coreclr/commit/69ac976d48950b618993bc7a5e854eb1145c36e3

8 years agoAdding System.TimeZone
Jose Perez Rodriguez [Tue, 23 Aug 2016 16:31:05 +0000 (09:31 -0700)]
Adding System.TimeZone

Commit migrated from https://github.com/dotnet/coreclr/commit/518057d4429bd8b89898bcb1e7b72ddd3e2ff915

8 years agoFix the ninja build for FC23. (dotnet/coreclr#6861)
Pat Gavlin [Tue, 23 Aug 2016 17:18:54 +0000 (10:18 -0700)]
Fix the ninja build for FC23. (dotnet/coreclr#6861)

Fedora installs ninja under the name `ninja-build` rather than `ninja`.

Commit migrated from https://github.com/dotnet/coreclr/commit/b08d0366674eb086b1d07d14a6b36c0e2c8de203

8 years agoStop maintaining cost estimates in the RyuJIT backend. (dotnet/coreclr#6849)
Pat Gavlin [Tue, 23 Aug 2016 16:36:27 +0000 (09:36 -0700)]
Stop maintaining cost estimates in the RyuJIT backend. (dotnet/coreclr#6849)

* Summarize HIR cost estimates on Compiler.

These cost estimates are made on HIR and are not used by the backend.
Stash them before converting the function to LIR and report them at the
end of compilation.

* Stop maintaining costs in the backend.

The backend does not use the tree cost estimates.

* Remove a bit more cost maintenance.

* Address PR feedback.

Commit migrated from https://github.com/dotnet/coreclr/commit/ab703ce987243e9573e04a05894294621e7046a8

8 years agoMerge pull request dotnet/coreclr#6852 from BruceForstall/Disable4702
Bruce Forstall [Tue, 23 Aug 2016 16:32:42 +0000 (09:32 -0700)]
Merge pull request dotnet/coreclr#6852 from BruceForstall/Disable4702

Conditionally disable C4702 "unreachable code" warnings

Commit migrated from https://github.com/dotnet/coreclr/commit/60ee81121cf4aa7f4b74f1646db6a3989fe061ec

8 years agoFix ConfigureOnly option in build.sh
Michelle McDaniel [Mon, 22 Aug 2016 18:01:41 +0000 (11:01 -0700)]
Fix ConfigureOnly option in build.sh

ConfigureOnly is intended to run the CMake to configure the build, but
nothing else. However, when you passed configureonly to build.sh, it set
__SkipConfigure=1, which made it skip the configure step of the build.
This change fixes that by removing that option from the options set my
configureonly, and adds a check right after configure and right before
running the build to exit if we are only configuring.

Commit migrated from https://github.com/dotnet/coreclr/commit/a69d5a89a1c018f9179c0f02eca1e995cd52cf9b

8 years agoAdding missing members on System Namespace (dotnet/coreclr#6818)
Jose Perez Rodriguez [Tue, 23 Aug 2016 15:40:23 +0000 (08:40 -0700)]
Adding missing members on System Namespace (dotnet/coreclr#6818)

Adding missing members on System Namespace

Commit migrated from https://github.com/dotnet/coreclr/commit/4212e7e0c9388337adc0feb5bc2046ca29681b78

8 years agoMerge pull request dotnet/coreclr#6664 from dagood/update-existing-pr
Davis Goodin [Tue, 23 Aug 2016 15:28:31 +0000 (10:28 -0500)]
Merge pull request dotnet/coreclr#6664 from dagood/update-existing-pr

Use versions repo tooling from BuildTools

Commit migrated from https://github.com/dotnet/coreclr/commit/3bb39a56e3fc96a7bdcc668be745551249e5cd4e

8 years agoMerge pull request dotnet/coreclr#6848 from BruceForstall/FixArm64SuperPmi2
Bruce Forstall [Tue, 23 Aug 2016 04:52:16 +0000 (21:52 -0700)]
Merge pull request dotnet/coreclr#6848 from BruceForstall/FixArm64SuperPmi2

Fix superpmi arm64 build

Commit migrated from https://github.com/dotnet/coreclr/commit/5cc75c3933979b788073ff065d81916680bccf5a

8 years agoMerge pull request dotnet/coreclr#6846 from BruceForstall/FixSuperPmiX86
Bruce Forstall [Tue, 23 Aug 2016 04:44:29 +0000 (21:44 -0700)]
Merge pull request dotnet/coreclr#6846 from BruceForstall/FixSuperPmiX86

Reenable superpmi test for x86

Commit migrated from https://github.com/dotnet/coreclr/commit/1aa8df1fe0f2b05160b24f4cfb246702db94cc49

8 years agoConditionally disable C4702 "unreachable code" warnings
Bruce Forstall [Tue, 23 Aug 2016 00:34:44 +0000 (17:34 -0700)]
Conditionally disable C4702 "unreachable code" warnings

The CLR header file check.h, macro CHECK_MSG_EX, can create unreachable code if the LEAVE_DEBUG_ONLY_CODE
macro is not empty (such as it is defined in contract.h) and the _RESULT macro expands to "return".
Checked-in compilers used by the TFS-based desktop build (e.g., version 18.10.40116.8) started reporting
unreachable code warnings when debugholder.h was changed to no longer #define "return" to something relatively
complex. However, newer compilers, such as Visual Studio 2015, used to build the CLR from the open source
GitHub repo, still do not report this warning. We don't want to disable this warning for the open source build,
which will use a newer compiler. Hence, only disable it for older compilers.

Commit migrated from https://github.com/dotnet/coreclr/commit/c3fa47e14b09cd461f723bdc6306e74f98eede4f

8 years agoFix SOS build break from PR dotnet/coreclr#6838. (dotnet/coreclr#6845)
dotnet bot [Tue, 23 Aug 2016 00:02:16 +0000 (17:02 -0700)]
Fix SOS build break from PR dotnet/coreclr#6838. (dotnet/coreclr#6845)

[tfs-changeset: 1623588]

Commit migrated from https://github.com/dotnet/coreclr/commit/a1ee7b807b78c99979996e924f94bf58dd2116ec

8 years agoMerge pull request dotnet/coreclr#6847 from jhendrixMSFT/master
Joel Hendrix [Mon, 22 Aug 2016 23:25:43 +0000 (16:25 -0700)]
Merge pull request dotnet/coreclr#6847 from jhendrixMSFT/master

Use the "open" key for strong-name signing SOS.NETCore.dll.

Commit migrated from https://github.com/dotnet/coreclr/commit/c136d19291808bc9250005cef203b3edf415d81a

8 years agoAdding the missing string function to model.xml (dotnet/coreclr#6694)
Jonathan Miller [Mon, 22 Aug 2016 23:17:09 +0000 (16:17 -0700)]
Adding the missing string function to model.xml (dotnet/coreclr#6694)

* Adding + stubbing out the missing Globalization functions
* Doing the correct native implementation now...

Commit migrated from https://github.com/dotnet/coreclr/commit/c940bc816db970c4dcb3130f6e1a8f3a51d73328

8 years agoMerge pull request dotnet/coreclr#6850 from mmitche/fix-regex
Matt Mitchell [Mon, 22 Aug 2016 23:16:15 +0000 (16:16 -0700)]
Merge pull request dotnet/coreclr#6850 from mmitche/fix-regex

Fix regex

Commit migrated from https://github.com/dotnet/coreclr/commit/c4ccc5434a72bc534e967b1b4313ff531a84ddfb

8 years agoFix regex
Matt Mitchell [Mon, 22 Aug 2016 23:14:43 +0000 (16:14 -0700)]
Fix regex

Commit migrated from https://github.com/dotnet/coreclr/commit/3ad3ea795991f05ddc821e694b71c6f3c3fa4ed7

8 years agoMerge pull request dotnet/coreclr#6822 from smile21prc/coreclr-perf
smile21prc [Mon, 22 Aug 2016 22:54:07 +0000 (15:54 -0700)]
Merge pull request dotnet/coreclr#6822 from smile21prc/coreclr-perf

Automate enhancement on the perf data collection for JIT CodeQuality benchmarks on Windows.

Commit migrated from https://github.com/dotnet/coreclr/commit/098cb9e831b1e2ab1d66355c28c627cc704bbd08

8 years agoFix superpmi arm64 build
Bruce Forstall [Mon, 22 Aug 2016 22:08:25 +0000 (15:08 -0700)]
Fix superpmi arm64 build

Commit migrated from https://github.com/dotnet/coreclr/commit/f2324b6744f05a051829a2aa65b745bb073d6f98

8 years agoUse the "open" key for strong-name signing SOS.NETCore.dll.
Joel Hendrix [Mon, 22 Aug 2016 21:51:48 +0000 (14:51 -0700)]
Use the "open" key for strong-name signing SOS.NETCore.dll.

Switch to using the OSS strong name instead of the default MSFT one.

Commit migrated from https://github.com/dotnet/coreclr/commit/5339543e0299d40ffbe93b65ced29cd4d4a537ee

8 years agoReenable superpmi test for x86
Bruce Forstall [Mon, 22 Aug 2016 21:10:50 +0000 (14:10 -0700)]
Reenable superpmi test for x86

Replace Roslyn CscBench with Bytemark, since CscBench fails with
an inlining assert (opened as issue dotnet/coreclr#6844) on x86.

Commit migrated from https://github.com/dotnet/coreclr/commit/ced16dbc4b37370ede18b0bad1b5e8d6cc939320

8 years agoRemove fgDebugCheckLinear{Tree,NodeLinks}. (dotnet/coreclr#6842)
Pat Gavlin [Mon, 22 Aug 2016 21:01:31 +0000 (14:01 -0700)]
Remove fgDebugCheckLinear{Tree,NodeLinks}. (dotnet/coreclr#6842)

These functions are not necessary for LIR.

Commit migrated from https://github.com/dotnet/coreclr/commit/caaca713decbaefa91d55973f18600786714448a

8 years agoUse versions repo tooling from BuildTools.
Davis Goodin [Mon, 8 Aug 2016 23:45:59 +0000 (18:45 -0500)]
Use versions repo tooling from BuildTools.

Sets up dependencies.props config. Removes UpdateDependencies powershell script, to be replaced by a call into VersionTools in Maestro automation. Changes UpdatePublishedVersions to pass through to VersionTools for backward compatibility.

Commit migrated from https://github.com/dotnet/coreclr/commit/5a63fd855de5d38d8429b68c50c08b8f00973d22

8 years agoMerge pull request dotnet/coreclr#6840 from hann013/t-hazhan/SuppressIldasmAttribute
Hannah Zhang [Mon, 22 Aug 2016 20:12:48 +0000 (13:12 -0700)]
Merge pull request dotnet/coreclr#6840 from hann013/t-hazhan/SuppressIldasmAttribute

Added SuppressIldasmAttribute

Commit migrated from https://github.com/dotnet/coreclr/commit/784f4d93d43f29cc52d41ec9fae5a96ad68633cb