Lennart Poettering [Wed, 19 Feb 2014 16:50:15 +0000 (17:50 +0100)]
sd-id128: use new dev_urandom() call
Lennart Poettering [Wed, 19 Feb 2014 16:49:50 +0000 (17:49 +0100)]
journal: don't clobber return parameters of sd_journal_get_cutoff_realtime_usec() on failure
Lennart Poettering [Wed, 19 Feb 2014 16:49:00 +0000 (17:49 +0100)]
execute: modernizations
Lennart Poettering [Wed, 19 Feb 2014 16:47:11 +0000 (17:47 +0100)]
make gcc shut up
If -flto is used then gcc will generate a lot more warnings than before,
among them a number of use-without-initialization warnings. Most of them
without are false positives, but let's make them go away, because it
doesn't really matter.
Lennart Poettering [Wed, 19 Feb 2014 16:43:40 +0000 (17:43 +0100)]
NEWS: Mention the new Personality= switch in unit files
Thomas Hindoe Paaboel Andersen [Wed, 19 Feb 2014 16:35:35 +0000 (17:35 +0100)]
busctl: add --no-legend and use in bash completion
Thomas Hindoe Paaboel Andersen [Wed, 19 Feb 2014 16:12:17 +0000 (17:12 +0100)]
busctl: update bash completion
Thomas Hindoe Paaboel Andersen [Wed, 19 Feb 2014 16:02:45 +0000 (17:02 +0100)]
man: busctl typo fix
Tom Gundersen [Wed, 19 Feb 2014 15:40:52 +0000 (16:40 +0100)]
sd-rtnl: test - include missing.h to build on old kernels
Tom Gundersen [Wed, 19 Feb 2014 15:34:34 +0000 (16:34 +0100)]
networkd: dhcp - log when lease is lost
Tom Gundersen [Wed, 19 Feb 2014 14:59:31 +0000 (15:59 +0100)]
networkd: link - only reset transient hostname if it was set by us
Maciej Wereski [Wed, 19 Feb 2014 10:39:01 +0000 (11:39 +0100)]
systemctl: remove erroneous return in runlevel_parse_argv()
Maciej Wereski [Wed, 19 Feb 2014 10:39:00 +0000 (11:39 +0100)]
logind: remove redundant check in manager_new()
Lennart Poettering [Wed, 19 Feb 2014 15:23:30 +0000 (16:23 +0100)]
update TODO
Lennart Poettering [Wed, 19 Feb 2014 15:13:42 +0000 (16:13 +0100)]
label: minor optimizations
Tom Gundersen [Wed, 19 Feb 2014 14:45:54 +0000 (15:45 +0100)]
missing.h: add some IFLA_* constants
These were added to the kernel between 3.5 and 3.9, let's not require such
recent kernels (yet).
David Herrmann [Wed, 19 Feb 2014 12:24:38 +0000 (13:24 +0100)]
event: fix crash on child-source state modifications
Setting a child-source state to anything but SD_EVENT_OFF currently does
nothing. The condition logic is flawed. Move the state update *below* the
test for the previous state.
Fixes a crash if you call:
sd_event_source_set_enabled(source, SD_EVENT_ON);
sd_event_source_unref(source);
on a child-source in its own callback.
Lennart Poettering [Wed, 19 Feb 2014 01:54:00 +0000 (02:54 +0100)]
man: document $MAINPID
Lennart Poettering [Wed, 19 Feb 2014 01:53:08 +0000 (02:53 +0100)]
update TODO
Lennart Poettering [Wed, 19 Feb 2014 01:15:24 +0000 (02:15 +0100)]
core: add Personality= option for units to set the personality for spawned processes
Zbigniew Jędrzejewski-Szmek [Wed, 19 Feb 2014 01:32:09 +0000 (20:32 -0500)]
build-sys: fixups for libsystemd-daemon merge
Kay Sievers [Wed, 19 Feb 2014 01:24:57 +0000 (02:24 +0100)]
build-sys: install headers with --enable-kdbus
Kay Sievers [Tue, 18 Feb 2014 17:50:11 +0000 (18:50 +0100)]
build-sys: merge libsystemd-daemon into libsystemd
Lennart Poettering [Tue, 18 Feb 2014 22:55:41 +0000 (23:55 +0100)]
test: add missing test units
Lennart Poettering [Tue, 18 Feb 2014 22:35:19 +0000 (23:35 +0100)]
nspawn: add new --personality= switch to make it easier to run 32bit containers on a 64bit host
Thomas Hindoe Paaboel Andersen [Tue, 18 Feb 2014 21:20:26 +0000 (22:20 +0100)]
delta: add bash completion
Tom Gundersen [Tue, 18 Feb 2014 21:06:49 +0000 (22:06 +0100)]
net-match: fix Driver= match
It should match on the driver of the parent device.
Tom Gundersen [Tue, 18 Feb 2014 20:42:05 +0000 (21:42 +0100)]
networkd: refactor link_add() :(
Don't set set **ret when returning r < 0, as matching on the errno may easily
give false positives in the future leading to null pointer dereference.
Reported-by: David Herrmann <dh.herrmann@gmail.com>
Lennart Poettering [Tue, 18 Feb 2014 21:27:46 +0000 (22:27 +0100)]
nspawn: x86 is special with its socketcall() semantics, be permissive in the seccomp setup
Lennart Poettering [Tue, 18 Feb 2014 21:14:00 +0000 (22:14 +0100)]
seccomp: add helper call to add all secondary archs to a seccomp filter
And make use of it where appropriate for executing services and for
nspawn.
Dave Reisner [Tue, 18 Feb 2014 19:44:14 +0000 (14:44 -0500)]
nspawn: allow 32-bit chroots from 64-bit hosts
Arch Linux uses nspawn as a container for building packages and needs
to be able to start a 32bit chroot from a 64bit host.
24fb11120756
disrupted this feature when seccomp handling was added.
Lennart Poettering [Tue, 18 Feb 2014 20:23:16 +0000 (21:23 +0100)]
load-modules: properly return a failing error code if some module fails to load
This is the missing part of
b857193b1def5172e3641ca1d5bc9e08ae81aac4.
Thomas Hindoe Paaboel Andersen [Tue, 18 Feb 2014 20:09:06 +0000 (21:09 +0100)]
machinectl: remove unused --no-ask-password
Thomas Hindoe Paaboel Andersen [Tue, 18 Feb 2014 20:09:05 +0000 (21:09 +0100)]
machinectl: add bash completion
Lennart Poettering [Tue, 18 Feb 2014 20:07:13 +0000 (21:07 +0100)]
update TODO
Thomas Hindoe Paaboel Andersen [Tue, 18 Feb 2014 15:39:17 +0000 (16:39 +0100)]
man: machinectl: there is no command 'kill-machine'
Tom Gundersen [Tue, 18 Feb 2014 14:48:30 +0000 (15:48 +0100)]
man: minor fixes to networkd page
Also enforce that we don't allow setting the Broadcast for IPv6 addresses.
Patrik Flykt [Tue, 18 Feb 2014 14:30:09 +0000 (16:30 +0200)]
NEWS: Fix header file name
Cristian Rodríguez [Tue, 18 Feb 2014 13:56:36 +0000 (10:56 -0300)]
fix SECCOMP_CFLAGS usage
SECCOMP_CFLAGS must be in the global CFLAGS as <seccomp.h> is
included in core/execute.h. when seccomp.h is not in the standard
path.(i.e openSUSE has it in /usr/include/pkg/libseccomp/, precisely to
catch this kind of bugs) compiling systemd fails.
Patrik Flykt [Tue, 18 Feb 2014 14:07:40 +0000 (16:07 +0200)]
libsystemd-dhcp: Add a full DHCP address acquisition test case
Upon startup the DHCP library will immediately send a DHCP Discover.
Handle the additional DHCP Discover checking and DHCP Offer sending
in test_addr_acq_recv_discover(). Write a zero UDP checksum, the
received XID and the faked MAC address into place to create a DHCP
message the library can accept.
Follow exactly the same steps when receiving a DHCP Request in
test_addr_acq_recv_request() and send the Ack. Check that the proper
addresses have been found by the DHCP library before exiting the
main loop and finishing the test.
Patrik Flykt [Tue, 18 Feb 2014 14:07:39 +0000 (16:07 +0200)]
libsystemd-dhcp: Factor out test code for DHCP message verification
Add a callback function that will handle the test case specific checking.
Patrik Flykt [Tue, 18 Feb 2014 14:07:38 +0000 (16:07 +0200)]
libsystemd-dhcp: Add capability to print out test steps
Jason St. John [Tue, 18 Feb 2014 05:28:42 +0000 (00:28 -0500)]
NEWS: fix typos and grammar errors
Lennart Poettering [Tue, 18 Feb 2014 12:38:31 +0000 (13:38 +0100)]
NEWS: even more fixes
Tom Gundersen [Mon, 17 Feb 2014 23:10:08 +0000 (00:10 +0100)]
sd-rtnl-message: store reference to the bus in the message
This mimics the sd-bus api, as we may need it in the future.
Daniel Buch [Tue, 18 Feb 2014 07:13:25 +0000 (08:13 +0100)]
NEWS: sd-resolv.h is sd-resolve.h
Jan Engelhardt [Tue, 18 Feb 2014 04:10:48 +0000 (05:10 +0100)]
doc: fix newly-arisen inconsistencies in NEWS
Zbigniew Jędrzejewski-Szmek [Tue, 18 Feb 2014 03:25:37 +0000 (22:25 -0500)]
Remove unused variable and two function stubs
Zbigniew Jędrzejewski-Szmek [Tue, 18 Feb 2014 03:01:28 +0000 (22:01 -0500)]
NEWS: fix a few typos and inconsistencies
- systemd-delta had support for .d for a long time.
- systemd-activate had --environment before --setenv.
Kay Sievers [Tue, 18 Feb 2014 02:19:57 +0000 (03:19 +0100)]
NEWS: more "scary" kdbus incompatibility warning
Jan Engelhardt [Tue, 18 Feb 2014 02:13:08 +0000 (03:13 +0100)]
doc: general refresh of orthography and grammar
Kay Sievers [Tue, 18 Feb 2014 02:06:15 +0000 (03:06 +0100)]
NEWS: fix typos
Jan Engelhardt [Tue, 18 Feb 2014 00:08:57 +0000 (01:08 +0100)]
doc: orthographic corrections
Lennart Poettering [Tue, 18 Feb 2014 02:03:04 +0000 (03:03 +0100)]
NEWS fix
Lennart Poettering [Tue, 18 Feb 2014 01:51:39 +0000 (02:51 +0100)]
prepare NEWS
Lennart Poettering [Mon, 17 Feb 2014 17:28:53 +0000 (18:28 +0100)]
util: generalize code that checks whether PIDs are alive or unwaited for
Jan Engelhardt [Mon, 17 Feb 2014 14:43:36 +0000 (15:43 +0100)]
doc: utilize the DocBook markup for some literals
Jan Engelhardt [Mon, 17 Feb 2014 14:31:28 +0000 (15:31 +0100)]
doc: reword "shared per-thread" wording
Either it is shared across threads, or it is per-thread: decide.
Reading the source code, I see a thread_local identifier, so that's
that. But that does not yet preclude that a program may pass around
the pointer returned from the function among its own threads.
Do a best effort at saying so.
Jan Engelhardt [Sun, 16 Feb 2014 12:55:27 +0000 (13:55 +0100)]
doc: balance C indirections in function prototypes
Shift the asterisks in the documentation's prototypes such that they
are consistent among each other. Use the right side to match source code.
Jan Engelhardt [Mon, 17 Feb 2014 02:58:37 +0000 (03:58 +0100)]
doc: properly use XML entities
Jan Engelhardt [Mon, 17 Feb 2014 01:49:45 +0000 (02:49 +0100)]
doc: choose different words to improve clarity
I suggest the following changes to improve the way the text reads
("flows").
Jan Engelhardt [Mon, 17 Feb 2014 02:37:18 +0000 (03:37 +0100)]
doc: resolve missing/extraneous words or inappropriate forms
Issues fixed:
* missing words required by grammar
* duplicated or extraneous words
* inappropriate forms (e.g. singular/plural), and declinations
* orthographic misspellings
Jan Engelhardt [Mon, 17 Feb 2014 02:37:13 +0000 (03:37 +0100)]
doc: update punctuation
Resolve spotted issues related to missing or extraneous commas, dashes.
Jan Engelhardt [Sun, 16 Feb 2014 13:01:31 +0000 (14:01 +0100)]
doc: detail what "UID" is
Jan Engelhardt [Sun, 16 Feb 2014 12:42:17 +0000 (13:42 +0100)]
doc: quote consistently in autoconf code
AS_HELP_STRING has been observed to expand such that the surround
function complains; play it safe and consistenly quote the example
code throughout.
Jan Engelhardt [Sun, 16 Feb 2014 12:58:18 +0000 (13:58 +0100)]
core: more exact test on the procfs special string "(deleted)"
In other parts of systemd, the code checks for " (deleted)",
but in one instance, it did not (yet). Make it do the same.
Ansgar Burchardt [Mon, 17 Feb 2014 20:34:20 +0000 (21:34 +0100)]
man: fix a typo
Umut Tezduyar Lindskog [Mon, 17 Feb 2014 20:16:53 +0000 (21:16 +0100)]
networkd: act on lease only if there is one
Interface could go down before acquiring a dhcp lease
Jasper St. Pierre [Mon, 17 Feb 2014 21:07:02 +0000 (22:07 +0100)]
Fix gperf syntax
If we put a closing bracket on its own line, gperf will complain about
empty lines. Only occurs if the option in question is disabled. So fix the
m4 macros to work properly in both cases.
Lennart Poettering [Mon, 17 Feb 2014 16:49:09 +0000 (17:49 +0100)]
core: warn when unit files with unsupported options are parsed
Lennart Poettering [Mon, 17 Feb 2014 15:52:52 +0000 (16:52 +0100)]
core: store and expose SELinuxContext field normalized as bool + string
Lennart Poettering [Mon, 17 Feb 2014 15:37:30 +0000 (16:37 +0100)]
Revert "man: systemd.service(5): clarify behavior of SuccessExitStatus"
This reverts commit
29e254f7f093c07a1ec7e845e60203357f585235.
Conflicts:
man/systemd.service.xml
Lennart Poettering [Mon, 17 Feb 2014 15:18:17 +0000 (16:18 +0100)]
main: make gcc shut up
Lennart Poettering [Mon, 17 Feb 2014 15:17:08 +0000 (16:17 +0100)]
core: fixate show_status earlier, so that we actually print the welcome message
Previously, we'd fixed show_state only after printing the welcome
message which had the effect that the welcome message was almost always
suppressed.
Lennart Poettering [Mon, 17 Feb 2014 14:52:32 +0000 (15:52 +0100)]
Update TODO
Lennart Poettering [Mon, 17 Feb 2014 01:06:32 +0000 (02:06 +0100)]
core: find the closest parent slice that has a specfic cgroup controller enabled when enabling/disabling cgroup controllers for units
Lennart Poettering [Mon, 17 Feb 2014 00:58:33 +0000 (01:58 +0100)]
core: fix property changes in transient units
Lennart Poettering [Mon, 17 Feb 2014 00:19:08 +0000 (01:19 +0100)]
unit: slice dependencies should not be subject to DefaultDependencies
Lennart Poettering [Mon, 17 Feb 2014 00:14:14 +0000 (01:14 +0100)]
main: don't set no_new_privs when using SystemCallArchitectures= system-wide
After all, we want to allow userspace to get new privs...
Lennart Poettering [Sun, 16 Feb 2014 21:20:19 +0000 (22:20 +0100)]
nspawn: netns_fd can be removed now
Lennart Poettering [Fri, 14 Feb 2014 18:11:07 +0000 (19:11 +0100)]
core: rework cgroup mask propagation
Previously a cgroup setting down tree would result in cgroup membership
additions being propagated up the tree and to the siblings, however a
unit could never lose cgroup memberships again. With this change we'll
make sure that both cgroup additions and removals propagate properly.
Zbigniew Jędrzejewski-Szmek [Sat, 15 Feb 2014 23:13:46 +0000 (18:13 -0500)]
Pass log config from systemd to systemd-shutdown
If PID 1 debug logging is enabled, it is nice to keep those settings
when switching to systemd-shutdown binary, independently of whether
this was done through /proc/cmdline options, or through runtime
manipulations.
Zbigniew Jędrzejewski-Szmek [Sat, 15 Feb 2014 23:10:36 +0000 (18:10 -0500)]
Some modernizations
Zbigniew Jędrzejewski-Szmek [Sat, 15 Feb 2014 23:08:59 +0000 (18:08 -0500)]
Extract looping over /proc/cmdline into a shared function
In cryptsetup-generator automatic cleanup had to be replaced
with manual cleanup, and the code gets a bit longer. But existing
code had the issue that it returned negative values from main(),
which was wrong, so should be reworked anyway.
Djalal Harouni [Thu, 13 Feb 2014 22:03:23 +0000 (23:03 +0100)]
logind: close race on session state during logins
At login there is a small race window where session_get_state() will
return SESSION_ACTIVE instead of SESSION_OPENING. This must be fixed
since during that time there are calls to session_save() to save
session states and we want to write the correct state.
When we queue the start scope and service jobs, we wait for both of them
to finish before calling and continue processing in:
"session_jobs_reply() => session_send_create_reply()"
to create the session fifo and notify clients.
However, in the match_job_removed() D-Bus signal, we may hit situations
where the scope job has successfully finished and we are still waiting
for the user service job to finish. During that time the
"session->scope_job" will be freed and set to NULL, this makes
session_get_state() return SESSION_ACTIVE before it is really active, it
should return SESSION_OPENING since we are still waiting for the service
job to finish in order to create the session fifo.
To fix this, we also check if the session fifo fd was created, if so then
the session has entered the SESSION_ACTIVE state, if not then it is still
in the SESSION_OPENING state and it is waiting for the scope and service
jobs to finish.
Tom Gundersen [Sun, 16 Feb 2014 22:28:19 +0000 (23:28 +0100)]
sd-dhcp: silently ignore malformed packets
This fixes a regression introduced in
e5002702.
Tom Gundersen [Sun, 16 Feb 2014 20:39:50 +0000 (21:39 +0100)]
sd-rtnl: do not require ifindex to be set for SETLINK messages
The kernel will then look up the ifindex itself based on the name.
This should be used very carefully as it is racey.
[This was a left-over hunk from my previous nspawn patch.]
Thomas Hindoe Paaboel Andersen [Sun, 16 Feb 2014 21:58:24 +0000 (22:58 +0100)]
TODO: remove done item
strv_append was removed in
e3e45d4f82daa5cd85ba40dde9127df900096c0c
Thomas Hindoe Paaboel Andersen [Sun, 16 Feb 2014 21:15:24 +0000 (22:15 +0100)]
nspawn: typo fix in help
Tom Gundersen [Sun, 16 Feb 2014 20:12:47 +0000 (21:12 +0100)]
nspawn: add new --network-bridge= switch
This adds the host side of the veth link to the given bridge.
Also refactor the creation of the veth interfaces a bit to set it up
from the host rather than the container. This simplifies the addition
to the bridge, but otherwise the behavior is unchanged.
Djalal Harouni [Sat, 15 Feb 2014 16:15:33 +0000 (17:15 +0100)]
Add white space between _XZ_FEATURE_ and _SECCOMP_FEATURE_
Simon Peeters [Sun, 16 Feb 2014 02:01:17 +0000 (03:01 +0100)]
bus: fix match_parse for unquoted matches
Yuxuan Shui [Sat, 15 Feb 2014 05:20:55 +0000 (13:20 +0800)]
core: check for return value from get_process_state
Fix for commit
e10c9985bb.
Kay Sievers [Sat, 15 Feb 2014 16:21:49 +0000 (17:21 +0100)]
README: mention libudev's requirement
Tom Gundersen [Fri, 14 Feb 2014 16:23:58 +0000 (17:23 +0100)]
sd-dhcp: network - don't hardcode ports
We want to reuse these functions for the server library too.
Tom Gundersen [Fri, 14 Feb 2014 23:06:09 +0000 (00:06 +0100)]
sd-rtnl: always include linux/rtnetlink.h
Tom Gundersen [Fri, 14 Feb 2014 10:58:41 +0000 (11:58 +0100)]
sd-dhcp: minimum options size is part of the protocol
Tom Gundersen [Thu, 13 Feb 2014 19:56:16 +0000 (20:56 +0100)]
sd-dhcp-client: explicitly handle raw and udp messages
Split the recevie_message callback into _raw and _udp parts and a generic
DHCPMessage handler.
Also always verify the xid/MAC, rather than only for udp messages.
Tom Gundersen [Fri, 14 Feb 2014 21:39:48 +0000 (22:39 +0100)]
sd-rtnl: message_open_container - don't take a 'size' argument
We can always know the size based on the type, so let's do this inside the library.
Tom Gundersen [Fri, 14 Feb 2014 11:15:26 +0000 (12:15 +0100)]
sd-rtnl: link flags - don't allow change = 0
The kernel will happily treat 0x0 as 0xffffffff, but it is for backwards
compatibility only, so let's not perpetuate this.