platform/framework/web/chromium-efl.git
6 years agoReally set URLRequestContextGetter inside CookieManager.
Wojciech Wiśniewski [Mon, 19 Jan 2015 16:44:35 +0000 (17:44 +0100)]
Really set URLRequestContextGetter inside CookieManager.

CookieManager has member pointer into URLRequestContextGetter (request_context_getter_),
but because of the way objects of these classes were created, this pointer was never
properly initialized (it was always set to NULL). This patch makes it initialize properly.
Reviewed by: Daniel Waślicki, Janusz Majnert, Kamil Klimek, Piotr Tworek, SeungSeop Park

Change-Id: I1b55be86288b82d34bc34edc1970c84c0a60af15
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
6 years agoFix user agent getter
Tomasz Czekala [Mon, 2 Feb 2015 08:46:37 +0000 (09:46 +0100)]
Fix user agent getter

User agent getter was returning a pointer to a local variable, that was already
out of scope, when the pointer was returned and the pointed memory was often
overridden, so it wasn't possible to read valid user agent string. This patch
adds local string that holds current user agent, what partly fixes this issue.
After second call of user agent string getter, the string is overridden, so the
previously returned pointer is no longer valid, but fixing that requires
changing the architecture of the EWK API

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10844
Reviewed by: Jaesik Chang, Janusz Majnert, Piotr Tworek

Change-Id: I6eacce32b521254f5171f51e8ac7efb011df004e
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
6 years agoGet rid off "Webkit" locale text domain
Piotr Grad [Tue, 3 Feb 2015 20:47:33 +0000 (21:47 +0100)]
Get rid off "Webkit" locale text domain

[Requirement] WCS TC 1-57
This commit removes need for Webkit domain locale dependency.
Before we were mapping "Webkit" domain to "browser" domain which was redundant.
This was causing translation to not work when text domain for browser changed
it's path.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10689
Reviewed by: Antonio Gomes, Karol Furmaniak

Change-Id: Ic13fa7f92c02e7064931a4b9d55534518a82df7f
Signed-off-by: Piotr Grad <p.grad@samsung.com>
6 years agofixup! [Tizen][WebRTC] Handle video_facing variable on media device enumeration
msu.koo [Tue, 3 Feb 2015 01:01:12 +0000 (10:01 +0900)]
fixup! [Tizen][WebRTC] Handle video_facing variable on media device enumeration

- Removed hard-coded device id, name.
- Fix missmatched device id on WebContentDelegateEfl.
- Set default WebRTC camera to Primary(back) camera.
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: I0093715746caa2a9ffff8f91336b7c28159a9d62
Signed-off-by: msu.koo <msu.koo@samsung.com>
6 years agoRemove forwarding shift key events and fix keycode conversion.
Karol Furmaniak [Fri, 30 Jan 2015 13:48:28 +0000 (14:48 +0100)]
Remove forwarding shift key events and fix keycode conversion.

[Requirement] WCS TC 90

There was unnecessary shift key event forwarding what causes
wrong events dispatching.

Now after press "A" letter, events are:

keydown
keydown
keypress
composition-end
input
keyup
keyup

but it should be:

keydown
keypress
composition-end
input
keyup

This patch fix this.

Added conversion of keycode.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10687
Reviewed by: Antonio Gomes, Piotr Grad

Change-Id: I892c065edc7490ee66425787d59a6596a4adc0d4
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agoImplement "certificate,pem,set" callback.
Dominik Duda [Sat, 31 Jan 2015 12:22:52 +0000 (13:22 +0100)]
Implement "certificate,pem,set" callback.

Original commit:
http://165.213.202.130:8080/#/c/69732/3
Reviewed by: Jaesik Chang, Piotr Grad

Change-Id: I5375ec9be49518080ec0674d267f99a367d7154e
Signed-off-by: Dominik Duda <d.duda@samsung.com>
6 years agoEnable vibration API to be used in mini_browser and efl_webview_app for tizen 2.4
Wojciech Bielawski [Tue, 3 Feb 2015 10:17:27 +0000 (11:17 +0100)]
Enable vibration API to be used in mini_browser and efl_webview_app for tizen 2.4

Haptic API usage was disabled in tizen 2.4. This patch enables existing
implementation to be used in mini_browser and efl_webview_app also for tizen 2.4.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10735
Reviewed by: Antonio Gomes, Gyuyoung Kim, joonhwan kwon

Change-Id: I776e484a95053570260fcd4fabaeeb500a064dd3
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
6 years agoModified utc_gtest_run.sh to run tests one by one.
Mikolaj Czyzewski [Mon, 15 Dec 2014 16:13:26 +0000 (17:13 +0100)]
Modified utc_gtest_run.sh to run tests one by one.

Changed script for running utc tests so it could handle segfaults.
Previously while running multiple tests when one test had ended with a segfault
the rest of them didn't execute. Now all the test are run one by one.

Tests can be run in a four different ways:
-single test
   ./utc_gtest_run.sh -s utc_blink_ewk_view_visibility_set.POS_TEST1
-set of tests
   ./utc_gtest_run.sh -s utc_blink_ewk_view_user_agent*
-tests listed in the file (each test_name/API_function in separate line)
   ./utc_gtest_run.sh -l file
-all tests
   ./utc_gtest_run.sh -a

To generate list of all tests:
   ./utc_gtest_run.sh -g     (to stdout)
   ./utc_gtest_run.sh -g > all_tests.txt
   ./utc_gtest_run.sh -g | grep ewk_view > ewk_view_tests.txt

The test results are generated in /opt/usr/utc_results/unittest-result-{DATE}-{TIME}
To parse the results:
   ./utc_gtest_run.sh -p /opt/usr/utc_results/unittest-result-{DATE}-{TIME}
This creates file unittest-result-{DATE}-{TIME}.txt in current directory.
Reviewed by: Antonio Gomes, Kamil Klimek, Piotr Tworek, SeungSeop Park

Change-Id: Ia399e62e59f6af0b061cc03ed313b793ab990073
Signed-off-by: Mikolaj Czyzewski <m.czyzewski@samsung.com>
6 years agoFix for rest of utc_blink_ewk_error* tests
Lukasz Krok [Thu, 29 Jan 2015 12:23:57 +0000 (13:23 +0100)]
Fix for rest of utc_blink_ewk_error* tests

The utc_blink_ewk_error* tests previous implementation
intention was to cause load error by cancelling resource loading.
As cancelling loading is normal situation, it shouldn't be treated
as error. It was corrected in I8f4e828bfcc63377678e475f44131dbc749b9c7f
change. Because of the change utc_blink_ewk_error_code_get* tests
stopped to pass.
This commit removes resource loading cancellation from tests logic.
Instead of google.com, "page_that_does_not_exist" is now set as url.
Such url usage causes SERVICE_TEMPORARILY_UNAVAILABLE error code.
If device has no network connection, NETWORK_ERROR code is produced.

One test suite - utc_blink_ewk_error_code_get* was already adapted
with a change: I1503f966bd782815760ca6a7fbf129d1e1400102
This patch adapts rest of the tests which have this problem.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10191
Reviewed by: Antonio Gomes, Jaesik Chang, Janusz Majnert, Kamil Klimek

Change-Id: Idda9f18ecd9fbb0ba0b351c6abd65abc7782dad9
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
6 years agoFix unittests for ewk_settings_text_autosizing_font_scale_factor_set_func
Tomasz Czekala [Fri, 30 Jan 2015 09:07:35 +0000 (10:07 +0100)]
Fix unittests for ewk_settings_text_autosizing_font_scale_factor_set_func

ewk_settings_text_autosizing_font_scale_factor_set_func expects the argument to
be a double value, but was provided a boolean, that was converted to double, but
the unittest was treating in wrong way

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9535
Reviewed by: Hyunhak Kim, Piotr Tworek

Change-Id: I1863d0b8b2f4d6a2365e854f78b56ad0f4538754
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
6 years agoUpversion to elementary-1.7.x
Youngsoo Choi [Mon, 2 Feb 2015 01:58:40 +0000 (10:58 +0900)]
Upversion to elementary-1.7.x

[issue]
The elementary API was changed from version 1.7.x.

[resolve]
This patch meets followings.

Tizen v2.2.1 supports following method.
EAPI Eina_Bool elm_drop_target_del(Evas_Object *obj);

Tizen versions later than Tizen v2.2.1 support following method.
EAPI Eina_Bool elm_drop_target_del(
    Evas_Object *obj, Elm_Sel_Format format,
    Elm_Drag_State entercb, void *enterdata,
    Elm_Drag_State leavecb, void *leavedata,
    Elm_Drag_Pos poscb, void *posdata,
    Elm_Drop_Cb dropcb, void *dropdata);
Reviewed by: Antonio Gomes, KC Park

Change-Id: I91680bdf2df2452b832ab152c9cc00c6eaaf37c9
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
6 years agoFix for hang on enabling zero copy
uzair.jaleel [Wed, 4 Feb 2015 06:00:43 +0000 (11:30 +0530)]
Fix for hang on enabling zero copy

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4908
Reviewed by: Prashant Nevase, venu musham

Change-Id: I807ed39f86b9457044ec1b9e864d45a37c563002
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
6 years agoUpdate S_TRUNK_OWNERS of chromium-efl
Jongsoo Yoon [Tue, 3 Feb 2015 05:57:44 +0000 (14:57 +0900)]
Update S_TRUNK_OWNERS of chromium-efl

Update Reviewers.
Modified: S_TRUNK_OWNERS

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10764
Reviewed by: Kamil Klimek, Piotr Grad, Piotr Tworek, Prashant Nevase, jong chul park

Change-Id: Iedf2b14c39326e14bc322d4bd2e9de66f348f3ee
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
6 years agoChange default gbs repo to SPIN's 20150201.1 version for mobile
Youngcheol Kang [Mon, 2 Feb 2015 11:02:20 +0000 (20:02 +0900)]
Change default gbs repo to SPIN's 20150201.1 version for mobile

We will make use of the SPIN's 20150201.1 repo of specific date
for Tizen 2.4 mobile build (arm & i586), instead of the latest repo.
Reviewed by: Antonio Gomes, Piotr Tworek, joonhwan kwon

Change-Id: I22f7a95f81598400b73413b8723c6db54e5d1c18
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
6 years ago[M34-Merge] Adding trace buttons for trace mechanism
amit.kumar8 [Tue, 20 Jan 2015 15:27:17 +0000 (20:57 +0530)]
[M34-Merge] Adding trace buttons for trace mechanism

Adding Trace buttons for taking runtime traces in m40.

Original patch: http://165.213.202.130:8080/#/c/72299/

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10574
Reviewed by: Antonio Gomes, Prashant Nevase

Change-Id: If64012e3340a7e2527f0161da810eb36d25b82c3
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
6 years agoMake pointers into CookieManager thread-safe.
Wojciech Wiśniewski [Tue, 20 Jan 2015 13:17:08 +0000 (14:17 +0100)]
Make pointers into CookieManager thread-safe.

CookieManager class was used mostly through WeakPtr pointers.
These pointers are not thread-safe (they should be dereferenced
and destroyed only in the same thread they were created).
Because CookieManager class is used both from UI and IO browser
threads, it was causing assertion fails in debug builds.

This patch changes WeakPtrs to thread-safe version of scoped_refptrs.
Reviewed by: Daniel Waślicki, Piotr Tworek, SeungSeop Park, arno renevier

Change-Id: I54b7500083e1d54f7cbac223a50f7a9cd5eff95b
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
6 years ago[SPIN] Enable CAPI port for MediaElement
hyungsun.ryu [Thu, 29 Jan 2015 04:00:09 +0000 (13:00 +0900)]
[SPIN] Enable CAPI port for MediaElement

CAPI regarding X11 can be used since Jan 21. Patch enables the CAPI
port for MediaElement again, and adjusts for the header difference
won Tizen 2.4 (player_internal.h)
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: I5c047f72e51e3550168a6942a7f928ac1e9ecaa5
Signed-off-by: hyungsun.ryu <hyungsun.ryu@samsung.com>
6 years ago[M34-Merge] Change the order of parameter in SetWidgetInfo.
Dongjun Kim [Mon, 2 Feb 2015 05:56:55 +0000 (14:56 +0900)]
[M34-Merge] Change the order of parameter in SetWidgetInfo.

The order of parameter was reversed in our latest code.
- parameter from WRT : (widgetHandle, scale, theme, encodedBundle)
- parameter in SetWidgetInfo : (widgetHandle, scale, encodedBundle, theme)
We need to change it for TCT fail in WRT.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9368
Reviewed by: Hyunhak Kim, Janusz Majnert, Piotr Grad, Piotr Tworek

Change-Id: If69b2ab3f2dd16492723456189a5a157adfa289c
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
6 years agofixup! [Tizen][MM][Webrtc] Video Capture Port using CAPI
msu.koo [Wed, 21 Jan 2015 07:30:17 +0000 (16:30 +0900)]
fixup! [Tizen][MM][Webrtc] Video Capture Port using CAPI

This patch is to enable the tizen video capture port on mobile build only.

Together with: I62321a3b0cfba87da4f2acd5ee9e53e80427a4af
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: I55a08af9f9939ec5664815916e408607486544a4
Signed-off-by: msu.koo <msu.koo@samsung.com>
6 years ago[M34-Merge]Add file:// protocol handler specific for WRT.
Wojciech Wiśniewski [Wed, 28 Jan 2015 13:59:57 +0000 (14:59 +0100)]
[M34-Merge]Add file:// protocol handler specific for WRT.

This patch is porting of following patches:
http://165.213.202.130:8080/#/c/70649/ by Zbigniew Kostrzewa
http://165.213.202.130:8080/#/c/70977/ by Marek Ruszczyński
http://165.213.202.130:8080/#/c/71786/ by Piotr Szawdyński
(second and third are fixups of the first)

Original commit message:

This commit extends file:// URI scheme to provide features
specific to WRT.
When Chromium launch originates from WRT then each reference
to a resource via file:// URI scheme results in an IPC message
sent from browser to renderer and back to give a chance to WRT
to modify the URI.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10412
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10405
Reviewed by: Jaesik Chang, Piotr Tworek, SeungSeop Park

Change-Id: Id875fd7b03a231a098f8277c6af5f2031da03861
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
6 years agoFix invalid check in utc_blink_ewk_view_application_name_for_user_agent_set
Tomasz Czekala [Fri, 30 Jan 2015 07:33:51 +0000 (08:33 +0100)]
Fix invalid check in utc_blink_ewk_view_application_name_for_user_agent_set

When we call ewk_view_application_name_for_user_agent_set with application_name
as NULL, we expect to get default application name for user agent

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9327
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Grad, Piotr Tworek, arno renevier

Change-Id: I9c8d4fccf3c55b99940d1413b45513f8d1c40819
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
6 years agoRevert "Add support for focus UI in InputPicker"
Jung-Ick Guack [Mon, 2 Feb 2015 00:05:07 +0000 (09:05 +0900)]
Revert "Add support for focus UI in InputPicker"

This reverts commit 10bccd14b1fa7b03f3933587b0df03813ea5bdd7.

Change-Id: I26ed0f8f965c1ec45b940cb0ca5a111ef00482de
Signed-off-by: Jung-Ick Guack <ji.guack@samsung.com>
6 years agofixup! Provide URL address in NewWindowPolicyDecision object
Piotr Grad [Sat, 31 Jan 2015 14:20:43 +0000 (15:20 +0100)]
fixup! Provide URL address in NewWindowPolicyDecision object

Fix for build break.

Change-Id: I0b0b66b53170f3cf0c9eda86dba01d808c6c1523
Signed-off-by: Piotr Grad <p.grad@samsung.com>
6 years agoProvide URL address in NewWindowPolicyDecision object
Daniel Waślicki [Thu, 29 Jan 2015 15:29:27 +0000 (16:29 +0100)]
Provide URL address in NewWindowPolicyDecision object

During creation of a WebContents asynchronously, we use
specific tizen_webview::PolicyDecision constructor, which does
not set almost any members of this class. After this patch
any client application that uses EWK API will be able to at least
check url, scheme and host of a new WebContents. It allows to
perform proper action regarding permitting or prohibitting new
window.

Together with: I8f6ddbd985526772332b7c35f0e61e2c1a3b950b

Change-Id: I8b75b509e8c922f5a1102dbd4c787b93ad54b88e
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
6 years agoEnable parallel canvas by default.
Suchit Agrawal [Fri, 30 Jan 2015 13:09:15 +0000 (13:09 +0000)]
Enable parallel canvas by default.

Change-Id: Ifd39640888dc209fa7c82e444105ba604d079c8d
Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
6 years agoAdd support for focus UI in InputPicker
Marcin Krakowiak [Fri, 9 Jan 2015 13:30:59 +0000 (14:30 +0100)]
Add support for focus UI in InputPicker

This commit is refactored merge from m34 branch.
Class InputPicker uses now ColorSelector widget from elm for select color.
H/W keyboard can now change values in InputPicker.

Original commit: http://165.213.202.130:8080/#/c/70449/

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9615

Change-Id: I8498e99bd45b4bd06d8f5ecca42a3af750e02625
Signed-off-by: Marcin Krakowiak <m.krakowiak@samsung.com>
6 years agofixup! [SPIN] Hotfix for build with gcc 4.6.3
Sebastian Stolinski [Fri, 30 Jan 2015 12:51:57 +0000 (13:51 +0100)]
fixup! [SPIN] Hotfix for build with gcc 4.6.3

This patch fixes problem with third_party/mesa compilation
when flag _enable_content_shell = 1 and gcc 4.6.3 is used.
Issues with keyword final are resolved.
Mesa repository is not a part of chromium repo
so git patch is prepared.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10841
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek, SeungSeop Park

Change-Id: If54ed4441310c8be6c88a20aabd909d0623ab69e
Signed-off-by: Sebastian Stolinski <s.stolinski@samsung.com>
6 years agoDelay invocation UpdateWebkitPreferences
Daniel Waślicki [Fri, 30 Jan 2015 11:22:23 +0000 (12:22 +0100)]
Delay invocation UpdateWebkitPreferences

In current solution we have dependency loop which causes
segmentation fault. During initialization of EWebView, we
invoke a callback which should create and return new WebContents.
During this creation, in WebContentsViewEfl, EWebView's function
is called which expects that web_contents is already initialized.
It causes segmentation fault. Moreover in EWebView's function we have
to make sure that RenderView is already created. Thus solution to this
issue is to delay invocation of this function by posting task to
browser's UI thread.

Reviewed by: Antonio Gomes, DONGJUN KiM, Piotr Tworek
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10439
Change-Id: Id0cbeafc08fd3bd9770a8d3968812d76e846509d
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
6 years agoRemove unnecessary EwkViewMsg_SelectClosestWord IPC message.
Karol Furmaniak [Fri, 30 Jan 2015 07:10:02 +0000 (08:10 +0100)]
Remove unnecessary EwkViewMsg_SelectClosestWord IPC message.

IPC message EwkViewMsg_SelectClosestWord is not needed. There
is already ViewMsg_SelectClosestWord instead.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek

Change-Id: I309d3a773d7e2dc33134e6a27c4ccabe6d4243dd
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agofixup! Update S_TRUNK_OWNERS of chromium-efl
Jongsoo Yoon [Fri, 30 Jan 2015 08:31:37 +0000 (17:31 +0900)]
fixup! Update S_TRUNK_OWNERS of chromium-efl

Change-Id: I8c25f88b6ab6272dcf00d375b34bf641d8120398
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
6 years ago[Tizen][WebRTC] Handle video_facing variable on media device enumeration
msu.koo [Mon, 26 Jan 2015 09:51:02 +0000 (18:51 +0900)]
[Tizen][WebRTC] Handle video_facing variable on media device enumeration

This fix is required to support "facingMode" on WebRTC Spec.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10756
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: Ic3326686a9605645eed5fb073ce94a3225158be4
Signed-off-by: msu.koo <msu.koo@samsung.com>
6 years agoFix possible memory corruptions in policy decision dispatching logic
Tomasz Czekala [Sun, 25 Jan 2015 11:03:41 +0000 (12:03 +0100)]
Fix possible memory corruptions in policy decision dispatching logic

In some cases suspended policy decisions could be deleted by new policy
decision events. This patch fixes that also providing some feedback for
policy decisions that can't be suspended at all.
This patch is a port of this patch:
http://165.213.202.130:8080/#/c/70024/
by Kamil Klimek

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10629
Reviewed by: Piotr Tworek, arno renevier

Change-Id: I4431c4c8e9ec0deb4f7c76ea494ef47bec6de0d5
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
6 years agofixup! Upgrade EFL version for desktop to 1.9.5.
Jongsoo Yoon [Thu, 29 Jan 2015 07:25:11 +0000 (16:25 +0900)]
fixup! Upgrade EFL version for desktop to 1.9.5.

Since the upgrade to EFL version 1.9.5, some dependency packages
need to be manually installed.

Steps were executed on the build machine.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10823
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: I84798f2d422d4b22e5c288ea0bf83ba25e211096
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
6 years agoDisable zygote if sandboxing is disabled.
hyunjune.kim [Tue, 27 Jan 2015 01:06:25 +0000 (10:06 +0900)]
Disable zygote if sandboxing is disabled.

Original patches:
1) Provide mechanism for disabling zygote process
http://165.213.202.130:8080/#/c/69365/

2) Provide mechanism for disabling sandbox process
http://165.213.202.130:8080/#/c/69549/

3) fixup! Provide mechanism for disabling Sandbox-IPC process.
http://165.213.202.130:8080/#/c/71123/4/

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5385
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: Ibaff8775a21e2eafd93b9c52184e7868452ab183
Signed-off-by: hyunjune.kim <hyunjune.kim@samsung.com>
6 years ago[M34-Merge] Impl for open page in overview mode.
Karol Furmaniak [Thu, 29 Jan 2015 10:37:14 +0000 (11:37 +0100)]
[M34-Merge] Impl for open page in overview mode.

initialize_at_minimum_page_scale flag is set
with ewk_settings_auto_fitting_set value and
its solving all requirements.
This flag is passed to set loadWithOverviewMode field in WebSettings
via ApplyWebPreferences function.

Original patches:
http://165.213.202.130:8080/#/c/70208/
http://165.213.202.130:8080/#/c/70311/

Original author: Marcin Krakowiak <m.krakowiak@samsung.com>

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10660
Reviewed by: Jaesik Chang, Piotr Grad

Change-Id: I7d4bd96ab4cbdd2321e1baa83db36c779c906a40
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years ago[M34-Merge] Add file:// protocol handler specific for WRT.
Piotr An Nguyen [Thu, 22 Jan 2015 14:41:22 +0000 (15:41 +0100)]
[M34-Merge] Add file:// protocol handler specific for WRT.

This commit is a merge of two commits from branch beta/m34_1847.
Some refactoring was done in addition.

Load WRT injected bundle in the file protocol handler to be able to
access WRT's URL parsing. It is not possible to ask the render process to
do the URL parsing as some resource requests are requested via sync
messages from the render process. In such case the render process blocks
and is unable to process the URL parsing request.
Loading WRT's injected bundle in the browser process is potentially
dangerous as it expects to be loaded in the render process.

Original patches:
1) "Add file:// protocol handler specific for WRT." by Zbigniew Kostrzewa
http://165.213.202.130:8080/#/c/70649/

2) "fixup! Add file:// protocol handler specific for WRT" by Marek Ruszczynski
http://165.213.202.130:8080/#/c/70977/

Reviewed by: Daniel Waślicki, Jaesik Chang, Piotr Tworek
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10413
Change-Id: I94d0de04051c5d06ca65b552e3a7bb482d93d7d1
Signed-off-by: Piotr An Nguyen <p.annguyen@samsung.com>
6 years agoUpdate path of chromium-efl locale files to new.
Bartlomiej Gajda [Wed, 28 Jan 2015 12:39:39 +0000 (13:39 +0100)]
Update path of chromium-efl locale files to new.

[Issue] Context menu options were IDS_WEBVIEW.*
[Solution] Change path of dictionaries to new one.
Reviewed by: Jaesik Chang, Piotr Grad

Change-Id: I6a1ecd319ec89297e09616bb54bf6338b85b6030
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
6 years agoNo sound after tap on links
Marcin Strakowski [Wed, 28 Jan 2015 11:22:35 +0000 (12:22 +0100)]
No sound after tap on links

The method "RenderWidgetHostViewEfl::HandleTapLink" used method
"EWebView::AsyncRequestHitTestDataAt" which compute the coordinates,
which earlier were converted.
In summary:
Coordinates were converted twice.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10684
Reviewed by: Jaesik Chang, Piotr Grad

Change-Id: I58260228dc6f867be9c7be7d97986b35cd23a2ca
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
6 years agoEnable the API of setContentSecurityPolicyUsingHeader
Kamil Lysik [Thu, 23 Oct 2014 06:59:59 +0000 (14:59 +0800)]
Enable the API of setContentSecurityPolicyUsingHeader

The API is  to set a content security policy based on a header type.

Merge from M34: http://suprem.sec.samsung.net/gerrit/#/c/964/

Together with: I47676118df40c3c9f0deaf9b1d14db548c02a2cf
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9538
Reviewed by: Antonio Gomes, DONGJUN KiM, Piotr Tworek

Change-Id: I594fef3cdaa93e6040c2059be0e99271511804a4
Signed-off-by: Kamil Lysik <k.lysik@samsung.com>
6 years agofixup! Fix ewk_view_orientation_send API
Karol Furmaniak [Fri, 23 Jan 2015 11:58:57 +0000 (12:58 +0100)]
fixup! Fix ewk_view_orientation_send API

[Problem] After rotation images are not resized to
viewport size.

Added missing value for ViewMsg_Resize_Params.new_size
member.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9369
Reviewed by: Jaesik Chang, Piotr Grad, Piotr Tworek

Change-Id: Ide473dcac27a760a7798ac7e2dcf037cd5cf6a57
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agofixup! Porting of async snapshot functionality for Tizen platform
Karol Furmaniak [Thu, 15 Jan 2015 09:23:18 +0000 (10:23 +0100)]
fixup! Porting of async snapshot functionality for Tizen platform

Added conversion from evas coords to blink coords.
Reviewed by: Jaesik Chang, Piotr Grad

Change-Id: Id6b4be27853523c08ac3e8edbda2ded4544ef4f6
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agofixup! Add library path to run layout_test
Daniel Waślicki [Wed, 28 Jan 2015 09:56:10 +0000 (10:56 +0100)]
fixup! Add library path to run layout_test

Defining functions in shell should be done without
'function' keyword. It caused exception during
launching layout tests.
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I2472e81a91a46099fcee17b5abce870900523583
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
6 years ago[M34-Merge] Add parameter to DynamicPluginStartSession callback
Dongjun Kim [Fri, 23 Jan 2015 09:23:09 +0000 (18:23 +0900)]
[M34-Merge] Add parameter to DynamicPluginStartSession callback

In WRT, DynamicPluginStartSession callback is entry point
to load javascript extensions (device APIs).
When execute DynamicPluginStartSession(),
in WRT, it is importantto know uri of current loading page

because device APIs should not be loaded to external pages
(as per described in WRT-core spec
https://source.tizen.org/sites/default/files/page/tizen-2.3-wrt-core-spec.pdf).

Patch adds an additional parameter "informing" loaded uri in
DynamicPluginStartSession callback.

Original patch:
http://165.213.202.130:8080/#/c/70331/4

BUG : http://107.108.218.239/bugzilla/show_bug.cgi?id=6147
Reviewed by: Antonio Gomes, Janusz Majnert, Min-Soo Koo

Change-Id: Ic06cf7c303cb5b113ab0ef2dc66cd3f8b427f72f
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
6 years agoEWK unittests - fixing scaling in test page to 1.0
Tomasz Czekala [Tue, 27 Jan 2015 16:33:32 +0000 (17:33 +0100)]
EWK unittests - fixing scaling in test page to 1.0

Some hit and context menu tests fail at mobile due to changed scale.
This restores scale to 1.0 in test page by adding meta tag.
This patch is a cherry-pick of this patch:
http://165.213.202.130:8080/#/c/69523/
by Michal Stefanczyk.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9525
Reviewed by: DONGJUN KiM, Janusz Majnert, Piotr Tworek

Change-Id: I5583a7f8b1d9d2858a4d899441e246ffdd476cd8
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
6 years agofixup! Upgrade EFL version for desktop to 1.9.5.
Jongsoo Yoon [Wed, 28 Jan 2015 10:47:07 +0000 (19:47 +0900)]
fixup! Upgrade EFL version for desktop to 1.9.5.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10797
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park

Change-Id: I3c4977eaf6cb090755266b8f645e33cc6d1809c9
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
6 years agoSetting ELM_ENGINE Environment value.
Jongsoo Yoon [Wed, 28 Jan 2015 00:31:52 +0000 (09:31 +0900)]
Setting ELM_ENGINE Environment value.

There is gl engine issue in latest Tizen 2.4 platform binary.
In order to solve this problem, it is needed to set ELM_ENGINE
environment value as gl.
This patch apply this setting in mini_browser code level.
When gl issue is solved in Tizen 2.4 platform,
This patch should be reverted.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10787
Reviewed by: Piotr Tworek, Youngbok Yoon, joonhwan kwon

Change-Id: I5d6695502ff7d7be39e00293be1b236b15ec4314
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
6 years ago[Tizen][WebRTC] Fix control rate of omx encoder
sonal.g1@samsung.com [Wed, 21 Jan 2015 12:26:18 +0000 (17:56 +0530)]
[Tizen][WebRTC] Fix control rate of omx encoder

The control rate of omx encoder has been changed to CBR from VBR. CBR adjusts
the encoding algorithm of encoder dynamically according to the bitrate
specified. In VBR sometimes big frames are produced which are not handled at
receiver end.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10558
Reviewed by: Min-Soo Koo, Venugopal S M

Change-Id: Idd89fce2190fea2dff4b411bab3ba8170cc99b16
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
6 years agofixup! Refactor implementation of ewk_geolocation_permission* API
Wojciech Bielawski [Tue, 27 Jan 2015 09:37:20 +0000 (10:37 +0100)]
fixup! Refactor implementation of ewk_geolocation_permission* API

Due to compiler version downgrade removed non-static member initializer.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9524
Reviewed by: DONGJUN KiM, Filip Piechocki, Janusz Majnert

Change-Id: I60659e99abc5a9872c3f1ae38d911c0647df8da5
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
6 years agoChange default gbs repo to SPIN's latest for mobile
Youngcheol Kang [Wed, 28 Jan 2015 02:29:07 +0000 (11:29 +0900)]
Change default gbs repo to SPIN's latest for mobile

Now we will make use of latest SPIN repo for mobile build (arm & i586),
not snapshot repo of specific date.
Reviewed by: Piotr Grad, Piotr Tworek, SeungSeop Park, joonhwan kwon

Change-Id: Id3e3f49680775b87ee7737b1fd5f09e3be6ed0f7
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
6 years agoAfter rotation inputfield doesn't go to visible area.
Karol Furmaniak [Tue, 13 Jan 2015 11:34:44 +0000 (12:34 +0100)]
After rotation inputfield doesn't go to visible area.

After rotation current view should go to the
focused editable field (if any).
Added scroll to focused editable field on orientation change
event.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9221
Reviewed by: Hyunhak Kim, Piotr Grad, Piotr Tworek, SeungSeop Park

Change-Id: Id432292acc339ffe7e1ddb808af993ce71618449
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years ago[M34-Merge] Localization for URL of media stream
Maciej Skrzypkowski [Mon, 26 Jan 2015 12:35:28 +0000 (13:35 +0100)]
[M34-Merge] Localization for URL of media stream

Media loaded by the HTML media element does not use chromium's
resource loading mechanism, letting the media player load the
URL itself. This causes a problem in WRT as all the URLs need
to be parsed by WRT to make them relative to a widget's root.

This solution adds a WrtUrlParseBase delegate class which is
used to call WrtWidget::ParseURL from within WebMediaPlayerTizen.
The WrtUrlParseBase is used in RenderFrameImpl::createMediaPlayer while
creatting media::WebMediaPlayerTizen object.

Together with: Ie69c6d43b9537e756a744c377176bd4aba7b5d57

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10410
Reviewed by: DONGJUN KiM, Daniel Waślicki, Janusz Majnert, Min-Soo Koo, Piotr Tworek, arno renevier

Change-Id: I9bbdfd25644a1b203ae21b0c4571f051c4ff0b70
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
6 years agoTurning off viewport_meta_non_user_scalable_quirk for wrt widgets
Wojciech Bielawski [Fri, 9 Jan 2015 10:47:43 +0000 (11:47 +0100)]
Turning off viewport_meta_non_user_scalable_quirk for wrt widgets

Additional ewk functions have been added. They are responsible for
turning on/off viewport_meta_non_user_scalable_quirk preference. This
preference has been responsible for improper displaying widgets. Still
in chromium it should be turned on. Previous solution that was not
working in all the cases (located in PageScaleConstraintsSet) was removed.
The function should be called on wrt side.

This is a cherry-pick from: http://165.213.202.130:8080/#/c/72361/

Together with: I9a637bdc8045e39a5612a2ae1888e5434e27b103

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9531
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek

Change-Id: I109ea38f295ea3751cad2294f4eea1e944a54cb0
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
6 years agoChanged mime override callback to be called per context and added user_data
Tomasz Czekala [Tue, 27 Jan 2015 11:58:38 +0000 (12:58 +0100)]
Changed mime override callback to be called per context and added user_data

Whenever a new URLRequest is created, it is delegated via
ResourceThrottleEfl to our PolicyResponseDelegateEfl, where we postpone
the request and are able to check and handle the mime type of the
request on the UI thread. We ask the client if the mime_type should be
changed and if yes, we push the new mime type to MimeOverrideManagerEfl
and resume the URLRequest. Later on a
ResourceDispatcherHostDelegateEfl::ShouldOverrideMimeType call we deploy
the new overridden mime type on IO thread.
Mime override callback was global for the browser and didn't have
user_data, this patch changes it to be per context and adds user_data.
This patch is based on http://165.213.202.130:8080/#/c/72514/

Together with: I1baa8e92c0b2bea44fc0332c3e034f16f4efa428
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9463
Reviewed by: Antonio Gomes, Janusz Majnert, Min-Soo Koo, Piotr Tworek, SeungSeop Park

Change-Id: I3881faaf5fcf4d29c44a120d4723133095042b41
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
6 years agoFix updating repo when switch to existing branch.
Karol Furmaniak [Thu, 22 Jan 2015 08:53:42 +0000 (09:53 +0100)]
Fix updating repo when switch to existing branch.

Calling sync_repos.sh when current branch is not target branch
cause error:
fatal: A branch named 'xxx' already exists.

Changing 'git checkout' option from '-b' to '-B' fix this.
Reviewed by: Jaesik Chang, Piotr Grad, Piotr Tworek, SeungSeop Park

Change-Id: I81b9647bcfbe7dbd6b7ff2e3eb6e9e27557ce64c
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agoTranslation "Select all" for context menu.
Marcin Strakowski [Fri, 16 Jan 2015 14:34:28 +0000 (15:34 +0100)]
Translation "Select all" for context menu.

No translation for text "Select all". Instead string ID actual
name is now shown.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9715
Reviewed by: Jaesik Chang, Piotr Tworek

Change-Id: If37fb27d87bb6ee125f1ae1f3659733d8264c365
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
6 years agoRevert "[SPIN][Temporary] Removed the TTS dependency from EFL port"
ws29.jung [Fri, 23 Jan 2015 10:18:10 +0000 (19:18 +0900)]
Revert "[SPIN][Temporary] Removed the TTS dependency from EFL port"

This reverts commit 4c4c4f461a39b37d4fd46d5e1f9d3e5a7f71a2a8.
TTS build break fixed
Commit #74386 has to be merged before this

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10512

Conflicts:
packaging/chromium-efl.spec
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park

Change-Id: Idc6d836a6dc52836e4d0494e2840d5582423b2d3
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
6 years agoUpgrade EFL version for desktop to 1.9.5.
Piotr Tworek [Mon, 26 Jan 2015 09:55:29 +0000 (10:55 +0100)]
Upgrade EFL version for desktop to 1.9.5.

Right now desktop seems to use the oldest version of EFL of all
platforms chromium-efl currently supports. As a result some functions
which are present on TV or mobile can't be used on desktop. To avoid
introducing extra sets of defines around such functions upgrade desktop
EFL and Elementary to their newest versions from 1.9.x branch.

Due to jhbuild limitations for this patch to make any effect
out.x64/Dependencies directory has to be removed manually. Jhbuild can
only build packages, but it does not support package upgrades.
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park

Change-Id: I2c00a3875d12b4f06abe036bb09fe096a23755ef
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
6 years ago[M34-Merge] 'Load images' settings option fixed.
Piotr Grad [Sun, 25 Jan 2015 12:03:36 +0000 (13:03 +0100)]
[M34-Merge] 'Load images' settings option fixed.

EWK API expects to not show images - not only to not download images.

original commit:
http://165.213.202.130:8080/#/c/69544/
Reviewed by: Hyunhak Kim, Piotr Grad, SeungSeop Park

Change-Id: I216d20a8190bf44812ba4e0fc52185ab5db706ee
Signed-off-by: Piotr Grad <p.grad@samsung.com>
6 years agoUpdate magnifier screen using GetSnapshotAsync.
Karol Furmaniak [Thu, 15 Jan 2015 09:33:09 +0000 (10:33 +0100)]
Update magnifier screen using GetSnapshotAsync.

[Problem] Magnifier screen is blank because
EWebView::GetSnapShotForRect func is not implemented.

[Solution] Added updating magnifier screen using
EWebView::GetSnapshotAsync.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8773
Reviewed by: DONGJUN KiM, Piotr Grad, SeungSeop Park

Change-Id: I37604e2567d136439a5501f0654e8cc58edc66de
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years ago[Tizen][WebRTC] Fix rotation for Video Captured from Camera
sonal.g1@samsung.com [Mon, 19 Jan 2015 15:33:56 +0000 (21:03 +0530)]
[Tizen][WebRTC] Fix rotation for Video Captured from Camera

Handled rotation for captured video. Before this change, video was not getting
rotated when device was rotated. Now device rotation will reflect in video
stream.
Reviewed by: Min-Soo Koo, SeungSeop Park, Venugopal S M

Change-Id: Ic1f81e90e557e15265c911f6dcdbda790771594d
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
6 years agoNo markup data copied
Marcin Strakowski [Fri, 23 Jan 2015 10:19:07 +0000 (11:19 +0100)]
No markup data copied

Added markups handling to clipboard.
As a result images and images mixed with text
are now available at clipboard.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9053
Reviewed by: Piotr Grad, Piotr Tworek, SeungSeop Park

Change-Id: Ib2b1a9300c619466c5ff3e09bd33cd02775f09b8
Signed-off-by: Marcin Strakowski <m.strakowski@samsung.com>
6 years agoTrace Controller for Tizen/blink
amit.kumar8 [Tue, 20 Jan 2015 14:50:14 +0000 (20:20 +0530)]
Trace Controller for Tizen/blink

Adding mechanism for tizen/blink to take traces from already running
application.

m34 patch:

Original Author: prashant.n
Original Patch : http://165.213.202.130:8080/#/c/69076/ and
                 http://165.213.202.130:8080/#/c/69496/

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10571
Reviewed by: Prashant Nevase, venu musham

Change-Id: Ie39fbb1894ebade5ae3e7a1bb1895f567509702e
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
6 years agoRevert "fixup! Porting of async snapshot functionality for Tizen platform"
mohan [Tue, 27 Jan 2015 13:39:00 +0000 (19:09 +0530)]
Revert "fixup! Porting of async snapshot functionality for Tizen platform"

This reverts commit 0e84589d308fd0639af0ed7b846a2963a283aa86.

Change-Id: I64865d81da00c84a3f5ea6857a26427101a87e9c
Signed-off-by: mohan <mohan.reddy@samsung.com>
6 years agoImplement gpu info collector efl (chromium-efl)
amit.kumar8 [Fri, 23 Jan 2015 09:26:10 +0000 (14:56 +0530)]
Implement gpu info collector efl (chromium-efl)

This is gpu_info_collector implementation for efl port.
As in Linux port, we use libpci to get the gpu information
and it does not work for Tizen.
So we need a separate implementation for getting the gpu
information in efl.
The gpu information is needed for disabling multisampling feature
bu adding entry in the gpu_driver_bug_list_json.cc

m34 patch:

Original Commit: e998dd80676ee33bcb5da645580ca24fb7339dc5
Original Author: das.kulajit <das.kulajit@samsung.com>
Reviewed by: Prashant Nevase, venu musham

Change-Id: I715e8a3b7da03d27b8396a799700a71c89d94988
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
6 years agofixup! Porting of async snapshot functionality for Tizen platform
Karol Furmaniak [Thu, 15 Jan 2015 09:23:18 +0000 (10:23 +0100)]
fixup! Porting of async snapshot functionality for Tizen platform

Added conversion from evas coords to blink coords.
Reviewed by: Jaesik Chang, Piotr Grad

Change-Id: I3629abef313147921f1e992e07d00b8ba72a6fa1
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years ago[M34-Merge]Migrate patches to fix ewk_settings_scripts_window_open_set
Tomasz Czekala [Tue, 27 Jan 2015 09:13:16 +0000 (10:13 +0100)]
[M34-Merge]Migrate patches to fix ewk_settings_scripts_window_open_set

This patch is porting following patches:
http://suprem.sec.samsung.net/gerrit/#/c/6759/
http://165.213.202.130:8080/#/c/69930/
by Kamil Klimek

http://165.213.202.130:8080/#/c/70410/
http://165.213.202.130:8080/#/c/70737/
by Piotr Tworek

Together with: I4086107b1ee3e788752ed6d79a39d37784ee4184

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10415
Reviewed by: DONGJUN KiM, Piotr Tworek

Change-Id: Ifebe53719fd411d0fcd40c1058c373bbb35c2749
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
6 years ago[M34-Merge] Fixed text selection related issues
Kamil Klimek [Tue, 22 Jul 2014 12:53:24 +0000 (14:53 +0200)]
[M34-Merge] Fixed text selection related issues

Text selection was not handled as expected in chromium-ewk and
chromium-efl. This commit fixes few issues with text selection
synchronization between render process and browser process

Issue: CBWEBVIEW-161 CBWEBVIEW-220, CBWEBVIEW-504
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9544
Reviewed by: Janusz Majnert, Piotr Tworek

Change-Id: Idf98a5bcd356919c77944e1b244ada9e79e7a25d
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
6 years agoUpdate S_TRUNK_OWNERS of chromium-efl
Jongsoo Yoon [Mon, 26 Jan 2015 13:07:46 +0000 (22:07 +0900)]
Update S_TRUNK_OWNERS of chromium-efl

Update Reviewers list for each Technical Group.
Modified: src/S_TRUNK_OWNERS

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10764

Change-Id: I0f5afc7f31b5fa179c2ec15317514ccff54487ea
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
6 years agoRefactor implementation of ewk_geolocation_permission* API
Wojciech Bielawski [Mon, 26 Jan 2015 08:48:56 +0000 (09:48 +0100)]
Refactor implementation of ewk_geolocation_permission* API

Corrected behaviour of
GeolocationPermissionContextEfl::RequestPermissionOnUIThread. Previously it
wrongly called SendGeolocationPermissionResponse callback even when the API
embeder made a decision in his callback.
Geolocation private implementation refactored to use common
Ewk_Suspendable_Object implementation.
In addition unit test implementation refactor.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9524
Reviewed by: Piotr Tworek, arno renevier

Change-Id: Ib1674d06f3c2f48ddea009c842e30643cdf1c64c
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
6 years agoAdded callback for Autofill Profiles changed.
Michał Obrembski [Tue, 13 Jan 2015 13:19:43 +0000 (14:19 +0100)]
Added callback for Autofill Profiles changed.

This patch introduces new EWK callback Ewk_Context_Form_Autofill_Profile_Changed_Callback
which is called when profiles operation (modify/add/remove) is done in engine.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10077
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park

Change-Id: If9bac21c9a81036513bcbc9e342d93379372e02a
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Signed-off-by: Piotr Grad <p.grad@samsung.com>
6 years agoRemove synchronous image hit test tests
Tomasz Czekala [Fri, 23 Jan 2015 14:28:28 +0000 (15:28 +0100)]
Remove synchronous image hit test tests

Doing synchronous hit test of an image requires copying that SKIA bitmap between
renderer process and browser process and now making that copy causes crashes and
is disabled, so this functionality doesn't work and we're removing that check
because synchronous hit tests are deprecated.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9525
Reviewed by: Janusz Majnert, Piotr Tworek

Change-Id: Ifc96fee18534bfb21f359df0b25305c53ac7f8f1
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
6 years agoNot display mini_browser icon.
Jongsoo Yoon [Mon, 26 Jan 2015 02:26:45 +0000 (11:26 +0900)]
Not display mini_browser icon.

The official test browser for chromium-efl will be changed
to Reference browser from mini_browser.
This patch set the Icon of mini_browser to be not displayed
in order to avoid confusing.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10744
Reviewed by: Piotr Tworek, SeungSeop Park

Change-Id: Id67888132d335e85261483f663bdf2ee5c2aaeee
Signed-off-by: Jongsoo Yoon <join.yoon@samsung.com>
6 years ago[M34-Merge] Add interface for sending appID to WRT
Dongjun Kim [Fri, 23 Jan 2015 11:31:11 +0000 (20:31 +0900)]
[M34-Merge] Add interface for sending appID to WRT

We need to add new function for sending application id to WRT.
It is a requirement from WRT.
So, we add DynamicSetWidgetInfo() for this.

Original patch:
http://165.213.202.130:8080/#/c/70427/7

BUG : http://107.108.218.239/bugzilla/show_bug.cgi?id=6168
Reviewed by: Min-Soo Koo, Piotr Tworek

Change-Id: Ic58c75caf69e2133f3c8ee091a18fed9424cf915
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
6 years agoImplement support for autofill feature.
Michał Obrembski [Mon, 22 Dec 2014 13:27:47 +0000 (14:27 +0100)]
Implement support for autofill feature.

This patch adds all autofill
functionality to the browser, such as Autofill Profiles, Form Password
Generation, Form Password save.

Merged patches:
a60760ca50a4deeaa0b56e4bc093de597ea3740f
Fix for APIs for Form Autofill Profiles.
Author: Jan Zakrzewski <j.zakrzewski@samsung.com>  2014-06-23 13:12:20

http://165.213.202.130:8080/#/c/68885/
fixup! Crash when adding profile
Author: Piotr Grad <p.grad@samsung.com>  2014-08-28 16:11:40

http://165.213.202.130:8080/#/c/69737/
fixup! Fix autofill profiles management
Author: Robert Jadczak <r.jadczak@samsung.com>  2014-09-20 14:35:20
Reviewed by: Piotr Grad, Piotr Tworek, arno renevier

Change-Id: I2de842151904438f3e75ecdb58087b816f2c47a9
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
6 years agoewk_settings_text_autosizing_font_scale_factor_set argument check
Kamil Lysik [Wed, 7 Jan 2015 10:56:24 +0000 (11:56 +0100)]
ewk_settings_text_autosizing_font_scale_factor_set argument check

Since non-positive font scale factor is invalid make sure the function
returns false (indicating error) when the caller is specifying
such value.

Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Signed-off-by: Kamil Lysik <k.lysik@samsung.com>
Change-Id: I7966f825b0e04e3646a1ae939bb004a55454bfd2

6 years agoAdd library path to run layout_test
KangYong Park [Thu, 22 Jan 2015 10:23:13 +0000 (19:23 +0900)]
Add library path to run layout_test

For layout_test, content_shell is used.
And it needs to import some libraries for running content_shell.
This patch adds the path of necessary libraries automatically.
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I0ae20390a3964cce09e6099ceb3319420ea82411
Signed-off-by: KangYong Park <kaka.park@samsung.com>
6 years agoFixed WebInspector inability to early report errors
Kamil Klimek [Thu, 22 Jan 2015 19:22:09 +0000 (20:22 +0100)]
Fixed WebInspector inability to early report errors

This is a little bit hacky implementation of port check, because in some
conditions it may happen that port will be taken between the check and
initialization of WebInspector on proper thread. Unfortunetly sockets
can't be passed between threads. They strictly belong to the thread they
were created.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9549
Reviewed by: Janusz Majnert, Piotr Tworek

Change-Id: Iadac46a3152f96e944a274fb1a9afedc6260f386
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
6 years ago[SPIN] TTS build break fix
ws29.jung [Wed, 21 Jan 2015 11:20:27 +0000 (20:20 +0900)]
[SPIN] TTS build break fix

Build break occured because tts engine was updated from 0.2.39 to 0.2.41,
so some functions argument and return type has been changed.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10512
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: Id013071ed332b0ececf60aa6abde19bdd98fa04f
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
6 years agoFix for utc_blink_ewk_error_code_get* tests
Lukasz Krok [Fri, 23 Jan 2015 09:13:43 +0000 (10:13 +0100)]
Fix for utc_blink_ewk_error_code_get* tests

The utc_blink_ewk_error_code_get* tests previous implementation
intention was to cause load error by cancelling resource loading.
As cancelling loading is normal stituation, it shouldn't be treated
as error. It was corrected in I8f4e828bfcc63377678e475f44131dbc749b9c7f
change. Because of the change utc_blink_ewk_error_code_get* tests
stopped to pass.
This commit removes resource loading cancellation from tests logic.
Instead of google.com, "page_that_does_not_exist" is now set as url.
Such url usage causes SERVICE_TEMPORARILY_UNAVAILABLE error code.
If device has no network connection, NETWORK_ERROR code is produced.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10191
Reviewed by: Janusz Majnert, Piotr Tworek

Change-Id: I1503f966bd782815760ca6a7fbf129d1e1400102
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
6 years agoRefactor EWK APIs controlling initial value of list-style-position CSS property
Kamil Klimek [Thu, 22 Jan 2015 14:04:06 +0000 (15:04 +0100)]
Refactor EWK APIs controlling initial value of list-style-position CSS property

This commit re-enables the ewk_settings_initial_list_style_position_{get|set}
API calls by removing EWK_BRINGUP define guards.

This API is not implemented on engine site. It only toggles a flag
inside WebPreferences.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9533
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot

Change-Id: I5e7e1c825cc1ccac305e10eb05318617c0417e9e
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
6 years agoDo not destroy GLSharedContextEflPrivate instance on exit.
Wojciech Wiśniewski [Tue, 13 Jan 2015 12:48:12 +0000 (13:48 +0100)]
Do not destroy GLSharedContextEflPrivate instance on exit.

Destructor of GLSharedContextEflPrivate instance is firing on content_shell_efl exit time.
This destructor is calling evas_gl_surface_destroy, but EFL at this time is deinitialized already
and calling this function causes segfault.

The solution is simply to not destory GLSharedContextEflPrivate instance (it's static global
object, and we are exiting anyway).
Reviewed by: Daniel Waślicki, Min-Soo Koo, Viatcheslav Ostapenko

Change-Id: I43f9608eafea1c7502ce1219e6c8a8576aa1face
Signed-off-by: Wojciech Wiśniewski <w.wisniewski@samsung.com>
6 years agoThe build break when gcc-link by the libcap fixed.
hyunjune.kim [Fri, 23 Jan 2015 04:52:40 +0000 (13:52 +0900)]
The build break when gcc-link by the libcap fixed.

The build breaks which related to libcap occured in i586 target.
So add a code which is the following
export LDFLAGS="$LDFLAGS -L/lib".

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10518
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I0cc0b35c05bdf61e5bb8e21fabf94a377721a276
Signed-off-by: hyunjune.kim <hyunjune.kim@samsung.com>
6 years agoChanging test page loading type in utc_blink_ewk_view_screenshot_contents_get* tests
Lukasz Krok [Thu, 22 Jan 2015 15:05:38 +0000 (16:05 +0100)]
Changing test page loading type in utc_blink_ewk_view_screenshot_contents_get* tests

Instead of google.com, static html page code will be loaded.
The reason behind this change is that sometimes test failed
because of connection problems, for instance when a script rebooted
device and did not manage to establish internet connection before
executing the test.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10624
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek

Change-Id: Ideca7340cf8a196d98bf8236ee58a49800f7010e
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
6 years agoRemove ffmpeg dependency
hyungsun.ryu [Thu, 22 Jan 2015 11:09:25 +0000 (20:09 +0900)]
Remove ffmpeg dependency

Chromium-efl uses gstreamer instead of ffmpeg.
So we don't need to build ffmepg any more.
- removed ffmpeg in chromium-efl.spec
- added a variable to skip ffmpeg build

Bug : http://107.108.218.239/bugzilla/show_bug.cgi?id=10516
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: I1e5aafab2e3da6e3b13d7636131aefacafa3e81a
Signed-off-by: hyungsun.ryu <hyungsun.ryu@samsung.com>
6 years agoGet rid of C++11 features in EWK tests.
Filip Piechocki [Tue, 20 Jan 2015 16:24:59 +0000 (17:24 +0100)]
Get rid of C++11 features in EWK tests.

Due to the GCC downgrade (4.8 -> 4.6) on Tizen 2.4
repositories ewk_certificate_policy_decision_suspend test
failed to compile because of the C++11 features used which
are not implemented yet in current GCC version.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9518
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I32b9b9995c348b35a7331dd3b665808969870923
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
6 years agoIME stays on screen when pushed search button on IME
Maciej Skrzypkowski [Fri, 19 Dec 2014 15:22:12 +0000 (16:22 +0100)]
IME stays on screen when pushed search button on IME

Fixed hidding keypad after clicking loupe icon when editing text in input field:
<form>
        <input type="search">
</form>
Added setting focus in WebContentsDelegateEfl::DidFinishLoad, removed
setting focus from mini_browser.c.
Deleted setting useKeyPadWithoutUserAction to false from mini browser,
now it's true (as default). It seems that setting this flag to false is no longer
needed and if it's false than hiding keypad after form submit is prevented.

Updated to current sources.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9708
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot

Change-Id: I39bc3b63c00bd3d8d6fda227226c0ddae2923740
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
6 years agofixup! Fix ewk_view_orientation_send API
Lukasz Krok [Mon, 19 Jan 2015 08:42:26 +0000 (09:42 +0100)]
fixup! Fix ewk_view_orientation_send API

During patch review on dev/master some improvements to the fix
were introduced. This patch migrates the improvements to beta.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9541
Reviewed by: Antonio Gomes, Daniel Waślicki, Piotr Tworek

Change-Id: I9b28cb4ede25770b1d98b42702f218b9b1188f7f
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
6 years agoRemove device_scale_factor() from RenderWidgetHostViewEfl
Tomasz Czekala [Wed, 21 Jan 2015 11:38:02 +0000 (12:38 +0100)]
Remove device_scale_factor() from RenderWidgetHostViewEfl

RenderWidgetHostViewEfl shouldn't provide the device scale factor, because
device scale factor is a parameter of the screen and is available when
rwhv is not present and can be read from gfx::Display.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10458
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek

Change-Id: I92b4a64069836c014be33ab3e3cb966f4ff7c7a2
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
6 years agoIME is not shown when clipboard window is visible.
Karol Furmaniak [Mon, 6 Oct 2014 11:05:26 +0000 (13:05 +0200)]
IME is not shown when clipboard window is visible.

[Problem] When clipboard window is visible, there is
no possibility to show IME keyboard. It should be visible
after tap on input field.

[Solution] Added implementation of IsClipboardWindowOpened
method. It depends on ecore_x_e_illume_clipboard_state_get.
With this patch clipboard window is closed, when user tap
on not focused input field.
Also added closing clipboard window when webview is out of
focus.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9716
This is a cherry-pick from: http://165.213.202.130:8080/#/c/70395/
Reviewed by: Piotr Grad, SeungSeop Park, commitbot

Change-Id: I42726064071255579504774345311cd954263244
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agoFix crash related to magnifier
Kamil Klimek [Tue, 20 Jan 2015 13:46:20 +0000 (14:46 +0100)]
Fix crash related to magnifier

In some conditions animator object could outlive magnifier instance. This
lead to a crash caused by accessing freed memory.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10563
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: Icf8026909795dce85df1c2a2abc616f0ad1c0404
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
6 years ago[SPIN][Temporary] Removed the error codes which happened in ffmpeg
Youngcheol Kang [Mon, 19 Jan 2015 10:05:17 +0000 (19:05 +0900)]
[SPIN][Temporary] Removed the error codes which happened in ffmpeg

The build breaks which related to ffmpeg occured in i586.
But ffmpeg has no .git repository. (src/third_party/ffmpeg)
By temporary solution, the patch file will be applied before a build.

This patchset is the temporary patch.
This issue will be fixed by the multimedia team.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10516

Change-Id: Ifc14bfcab58f2adc730a6b0bc7ac5b3acf8f650d
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
6 years agofixup! Upmerge of ME & MSE with in impl/
Piotr Tworek [Fri, 16 Jan 2015 11:59:24 +0000 (12:59 +0100)]
fixup! Upmerge of ME & MSE with in impl/

An example why clang diagnostic output is supperior to gcc:
 warning: 'CONTENT_BROWSER_MEDIA_MEDIA_WEB_CONTENTS_OBSERVER__TIZEN_H_'
 is used as a header guard here, followed by #define of a different macro
 [-Wheader-guard]
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: Ifb3e35fd557b953d929337aa1a4a7686622d49d7
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
6 years agofixup! [SPIN] Removed the libhaptic dependency in the OBS environments
Youngcheol Kang [Wed, 21 Jan 2015 07:22:14 +0000 (16:22 +0900)]
fixup! [SPIN] Removed the libhaptic dependency in the OBS environments

The emulator does not support libhaptic.
Because of this, the libhaptic is only used by the arm target.

Change-Id: Iff247af2bd9c582ea4edb37104d1bd4468379f60
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
6 years ago[SPIN] Removed the libhaptic dependency in the OBS environments
Youngcheol Kang [Mon, 19 Jan 2015 03:46:52 +0000 (12:46 +0900)]
[SPIN] Removed the libhaptic dependency in the OBS environments

The OBS doesn't support the libhaptic package.
The libhaptic is used only in the local environments.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10508

Change-Id: I3311b0c4ee5cfafa8bf0fc40fd5a29af17f8ed10
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
6 years agoRemoved the vpx dependency from chromium-efl.spec
Youngcheol Kang [Mon, 19 Jan 2015 03:35:54 +0000 (12:35 +0900)]
Removed the vpx dependency from chromium-efl.spec

The multimedia used the internal vpx in the chromium
instead of the system vpx.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10506

Change-Id: I27a1de482bf2766025f9b5a8ed0a560c4a73995e
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
6 years agoecore_x_init was not called
Arnaud Renevier [Mon, 1 Dec 2014 19:26:47 +0000 (11:26 -0800)]
ecore_x_init was not called

Currently, HAVE_ECORE_X is never set, and then, ecore_x_init is never
called from within ewk_init. Then, when we call ecore_x_display_get, the
display returned is null. This problem is not visible with
efl_webview_app because ecore_x_init is called indirectly (via a call to
elm_init). But for example, wrt does not call elm_init and triggers the
bug.

The proposed solution is to always consider that we're using ecore_x. It
is currently true for all our platforms.

This patch also fixes a logic error: ecore_imf_shutdown() should be
called whether or not ecore-x is available.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9394
Reviewed by: Antonio Gomes, Piotr Tworek, arno renevier, commitbot

Change-Id: I5a41083f8e3cffe456fb638cd713d27a42d37620
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years ago[SPIN] Added the build script for Tizen Emulator (i586)
Youngcheol Kang [Mon, 19 Jan 2015 02:43:05 +0000 (11:43 +0900)]
[SPIN] Added the build script for Tizen Emulator (i586)

Added the below changes for i586 build
- Added the build_emulator.sh file
- Added the ninja files
- Added the codes for i586 build in the gbs.conf file.
- Added the codes for i586 build in the chromiul-efl.spec file.
- Added the guide for i586 build in the Readme.md file.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10509
Reviewed by: Piotr Tworek, Youngbok Yoon

Change-Id: If032bb14ce214914c196e8ad85f0a80b8ac71788
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
6 years ago[SPIN][Temporary] Removed the error codes which happened in libvpx
Youngcheol Kang [Mon, 19 Jan 2015 10:17:15 +0000 (19:17 +0900)]
[SPIN][Temporary] Removed the error codes which happened in libvpx

The build breaks which related to libvpx occured in i586 target.
But libvpx has no .git repository. (src/third_party/libvpx)
By temporary solution, the patch file will be applied before a build

This patchset is the temporary patch.
This issue will be fixed by the multimedia team.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10517
Reviewed by: Piotr Tworek, SeungSeop Park, Youngbok Yoon

Change-Id: Iebf09882c7cfe4607a3dec83288535eff7517f1c
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
6 years ago[SPIN][Temporary] Removed the TTS dependency from EFL port
Youngcheol Kang [Mon, 19 Jan 2015 05:17:49 +0000 (14:17 +0900)]
[SPIN][Temporary] Removed the TTS dependency from EFL port

Because of the tts upversion, the build breaks were occured in the OBS.

This patchset is the temporary patch.
This issue will be fixed by the multimedia team.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10512
Reviewed by: Piotr Tworek, SeungSeop Park, Youngbok Yoon

Change-Id: I848fd0cbcccaa80e7b7151ec6dcdc9868cc00f13
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
6 years agoRemoved the capi-telephony-network-info dependency from chromium-efl.spec file
Youngcheol Kang [Mon, 19 Jan 2015 03:40:36 +0000 (12:40 +0900)]
Removed the capi-telephony-network-info dependency from chromium-efl.spec file

The capi-telephony-network-info package is not used from EFL port.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10507

Change-Id: I0459d5413ccdbb310bff972b6396e8a25e11c64b
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>