msarett [Mon, 25 Jan 2016 16:54:50 +0000 (08:54 -0800)]
Revert of AVX 2 SrcOver blits: color32, blitmask. (patchset #24 id:450001 of https://codereview.chromium.org/
1532613002/ )
Reason for revert:
Bot failures
Original issue's description:
> AVX 2 SrcOver blits: color32, blitmask.
>
> As a follow up to the SSE 4.1 CL, this should look pretty familiar.
>
> I've made some organizational changes around how we load, store, pack, and unpack data that I think makes things clearer and more orthogonal, and it'll make it easier to try out a pmaddubsw lerp. I have backported these changes to the SSE 4.1 code, and I hope that I can actually get a lot of this code templated for sharing between the two later.
>
> Perf changes (relative to SSE 4.1):
> Xfermode_SrcOver: 1650 -> 1180 (0.71x) // large opaque blit
> Xfermode_SrcOver_aa: 1794 -> 1653 (0.92x) // large opaque + small transparent
> text_16_AA_{FF,BK,WT}: 1.72 -> 1.59 (0.92x) // small opaque blit
> text_16_AA_88: 1.83 -> 1.77 (0.97x) // small transparent blit
>
> This should be a big throughout win, and a small latency win.
> This should all be pixel-exact to the previous SSE 4.1 code.
>
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1532613002
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
5d2117015eb271e09faf4a7ddd89093c9d618a36
TBR=herb@google.com,mtklein@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1632713002
robertphillips [Mon, 25 Jan 2016 16:39:08 +0000 (08:39 -0800)]
Add GM for SkPixelXorXfermode
This is in preparation for adding a gpu implementation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1601743009
Review URL: https://codereview.chromium.org/
1601743009
mtklein [Mon, 25 Jan 2016 16:37:30 +0000 (08:37 -0800)]
AVX 2 SrcOver blits: color32, blitmask.
As a follow up to the SSE 4.1 CL, this should look pretty familiar.
I've made some organizational changes around how we load, store, pack, and unpack data that I think makes things clearer and more orthogonal, and it'll make it easier to try out a pmaddubsw lerp. I have backported these changes to the SSE 4.1 code, and I hope that I can actually get a lot of this code templated for sharing between the two later.
Perf changes (relative to SSE 4.1):
Xfermode_SrcOver: 1650 -> 1180 (0.71x) // large opaque blit
Xfermode_SrcOver_aa: 1794 -> 1653 (0.92x) // large opaque + small transparent
text_16_AA_{FF,BK,WT}: 1.72 -> 1.59 (0.92x) // small opaque blit
text_16_AA_88: 1.83 -> 1.77 (0.97x) // small transparent blit
This should be a big throughout win, and a small latency win.
This should all be pixel-exact to the previous SSE 4.1 code.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1532613002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1532613002
yujieqin [Mon, 25 Jan 2016 16:26:16 +0000 (08:26 -0800)]
Add RAW decoding into Skia.
TBR=reed@google.com
BUG=skia:
(Based on the work from ebrauer in https://codereview.chromium.org/
1459473007)
(Based on the work from adaubert in https://codereview.chromium.org/
1494003003)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1520403003
Committed: https://skia.googlesource.com/skia/+/
6bd8639f8c142eedf543f4e5f3b02d2bf11df308
Review URL: https://codereview.chromium.org/
1520403003
msarett [Mon, 25 Jan 2016 16:20:55 +0000 (08:20 -0800)]
Do not test images with alpha to 565
This should handle the untriaged images in Gold.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1635453002
Review URL: https://codereview.chromium.org/
1635453002
cjacek [Mon, 25 Jan 2016 15:27:36 +0000 (07:27 -0800)]
Fixed compilation on mingw.
Found and tested in mingw Firefox build. There are two problems:
- GCC doesn't support __vectorcall calling convention, so its usage needs to be #ifdefed
- GetProcAddress returns FARPROC type (a function pointer) and GCC requires an explicit cast to void*
Review URL: https://codereview.chromium.org/
1589933002
caryclark [Mon, 25 Jan 2016 14:33:01 +0000 (06:33 -0800)]
remove legacy defines
The defines
SK_SUPPORT_LEGACY_ARCTO
SK_SUPPORT_LEGACY_CONIC_MEASURE
SK_SUPPORT_LEGACY_DASH_MEASURE
SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS
SK_SUPPORT_LEGACY_PATH_MEASURE_TVALUE
have been removed from Chrome. This removes the obsolete code
from Skia as well.
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1627703002
Review URL: https://codereview.chromium.org/
1627703002
fmalita [Mon, 25 Jan 2016 14:29:44 +0000 (06:29 -0800)]
Delete 2 legacy flags
No longer used in Chrome/Android:
SK_SUPPORT_LEGACY_ANISOTROPIC_MIPMAPS
SK_SUPPORT_LEGACY_PRESCALE_SEMANTICS
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1632633002
Review URL: https://codereview.chromium.org/
1632633002
fmalita [Mon, 25 Jan 2016 14:23:54 +0000 (06:23 -0800)]
SK_SUPPORT_LEGACY_DRAWFLTER typo
s/FLTER/FILTER/
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1634573002
Review URL: https://codereview.chromium.org/
1634573002
kkinnunen [Mon, 25 Jan 2016 14:07:26 +0000 (06:07 -0800)]
Avoid updating glPathStencilFunc unless it changes
Avoid updating glPathStencilFunc unless it changes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619623005
Review URL: https://codereview.chromium.org/
1619623005
msarett [Mon, 25 Jan 2016 14:05:19 +0000 (06:05 -0800)]
Revert of Prototype of RAW decoding in Skia. (patchset #32 id:610001 of https://codereview.chromium.org/
1520403003/ )
Reason for revert:
A few build failures on Chrome OS/Android.
Original issue's description:
> Add RAW decoding into Skia.
>
> TBR=reed@google.com
>
> BUG=skia:
>
> (Based on the work from ebrauer in https://codereview.chromium.org/
1459473007)
> (Based on the work from adaubert in https://codereview.chromium.org/
1494003003)
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1520403003
>
> Committed: https://skia.googlesource.com/skia/+/
6bd8639f8c142eedf543f4e5f3b02d2bf11df308
TBR=scroggo@google.com,adaubert@google.com,yujieqin@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1635443002
caryclark [Mon, 25 Jan 2016 13:39:04 +0000 (05:39 -0800)]
fix arcto exception handling
To match SVG behavior,
draw a line when either radius is zero,
or when the end point equals the start point.
Update the GM to include these tests, and
take the scale used to test it on a highres display.
R=fmalita@chromium.org
BUG=skia:4849
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1627423002
Review URL: https://codereview.chromium.org/
1627423002
yujieqin [Mon, 25 Jan 2016 13:29:03 +0000 (05:29 -0800)]
Add RAW decoding into Skia.
TBR=reed@google.com
BUG=skia:
(Based on the work from ebrauer in https://codereview.chromium.org/
1459473007)
(Based on the work from adaubert in https://codereview.chromium.org/
1494003003)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1520403003
Review URL: https://codereview.chromium.org/
1520403003
borenet [Mon, 25 Jan 2016 13:00:13 +0000 (05:00 -0800)]
Whitespace change to test SK_IMAGE_VERSION download
TBR=scroggo
BUG=skia:4558
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1633453003
Review URL: https://codereview.chromium.org/
1633453003
kkinnunen [Mon, 25 Jan 2016 09:44:03 +0000 (01:44 -0800)]
Enable GL_CHROMIUM_bind_uniform_location, command buffer is fixed
Enable GL_CHROMIUM_bind_uniform_location, command buffer implementation
is fixed now.
BUG=skia:4454
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1613763003
Review URL: https://codereview.chromium.org/
1613763003
kkinnunen [Mon, 25 Jan 2016 08:47:23 +0000 (00:47 -0800)]
Do not try to get fragment input locations with CHROMIUM_path_rendering
Do not try to get fragment input locations with CHROMIUM_path_rendering,
it uses the binding mechanism in CHROMIUM_path_rendering
BUG=skia:2992
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618773002
Review URL: https://codereview.chromium.org/
1618773002
kkinnunen [Mon, 25 Jan 2016 08:31:49 +0000 (00:31 -0800)]
Make BGRA8888 renderable on CHROMIUM_framebuffer_mixed_samples
Make BGRA8888 renderable on CHROMIUM_framebuffer_mixed_samples.
BUG=skia:2992
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1615833002
Review URL: https://codereview.chromium.org/
1615833002
mtklein [Mon, 25 Jan 2016 03:49:24 +0000 (19:49 -0800)]
Revert of skstd -> std for unique_ptr (patchset #24 id:460001 of https://codereview.chromium.org/
1436033003/ )
Reason for revert:
Still need an answer for SkAdvancedTypefaceMetrics (at least for Google3 iOS build).
Original issue's description:
> skstd -> std for unique_ptr
>
> TBR=reed@google.com
> No public API changes.
>
> BUG=skia:4564
>
> Committed: https://skia.googlesource.com/skia/+/
755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
>
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
06189155d987db5c7e69015f6ea87c2168d6a065
>
> Committed: https://skia.googlesource.com/skia/+/
70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
>
> Committed: https://skia.googlesource.com/skia/+/
dadfc245cc9a0279ff7b73da3344f2ca5d139907
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1436033003
>
> Committed: https://skia.googlesource.com/skia/+/
ccf1de0d9aa75f29829f1c4c462214b991fd8c9e
TBR=bungeman@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4564
Review URL: https://codereview.chromium.org/
1626873004
mtklein [Mon, 25 Jan 2016 03:18:54 +0000 (19:18 -0800)]
skstd -> std for unique_ptr
TBR=reed@google.com
No public API changes.
BUG=skia:4564
Committed: https://skia.googlesource.com/skia/+/
755c553c17b82bb5de3d9cc8d3b2a866ff9e9e50
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot;client.skia:Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Trybot,Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
Committed: https://skia.googlesource.com/skia/+/
06189155d987db5c7e69015f6ea87c2168d6a065
Committed: https://skia.googlesource.com/skia/+/
70e8dfca4a7f5bce97b8021a6e378c4828b09c8c
Committed: https://skia.googlesource.com/skia/+/
dadfc245cc9a0279ff7b73da3344f2ca5d139907
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1436033003
Review URL: https://codereview.chromium.org/
1436033003
reed [Sun, 24 Jan 2016 19:15:14 +0000 (11:15 -0800)]
add 4f support to colorfiltershader
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1625263002
TBR=
Review URL: https://codereview.chromium.org/
1625263002
reed [Sun, 24 Jan 2016 03:37:56 +0000 (19:37 -0800)]
Revert[2] of expand unitests for color4f
This reverts commit
5f34e8ed82e6cbf29401bda5d423a50a2ab6db74.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1622983002
TBR=
Review URL: https://codereview.chromium.org/
1622983002
reed [Sat, 23 Jan 2016 22:19:06 +0000 (14:19 -0800)]
Revert of expand unitests for color4f (patchset #1 id:1 of https://codereview.chromium.org/
1622893002/ )
Reason for revert:
leaking shadercontext in test
Original issue's description:
> expand unitests for color4f
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1622893002
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
fac684502b6047ffc7dc2e59bd7e5a7cbfa5bf78
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1622923002
bsalomon [Sat, 23 Jan 2016 18:41:40 +0000 (10:41 -0800)]
Don't dirty MIP chain when damage bounds is empty
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618383002
Review URL: https://codereview.chromium.org/
1618383002
reed [Sat, 23 Jan 2016 18:15:39 +0000 (10:15 -0800)]
expand unitests for color4f
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1622893002
TBR=
Review URL: https://codereview.chromium.org/
1622893002
caryclark [Sat, 23 Jan 2016 13:07:04 +0000 (05:07 -0800)]
Add svg path arcto
The arcto() used by SVG in Chrome and Android is ported here, using conics
instead of cubics. The logic is a direct transposition of the WebKit code.
The attached GM includes SVG that draws the same as Skia.
R=reed@google.com
BUG=skia:3959
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1613303002
Review URL: https://codereview.chromium.org/
1613303002
msarett [Fri, 22 Jan 2016 22:46:42 +0000 (14:46 -0800)]
Add getYUV8Planes() API to SkCodec
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1549473003
Review URL: https://codereview.chromium.org/
1549473003
msarett [Fri, 22 Jan 2016 22:12:38 +0000 (14:12 -0800)]
SSSE3 opts for RGB -> RGB(FF) or BGR(FF)
Swizzle Bench Runtime
z620 0.21x
Dell Venue 8 0.26x
RGB PNGs Decode Runtime
z620 0.91x
Dell Venus 8 0.96x
BUG=skia:4767
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618603003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1618603003
lsalzman [Fri, 22 Jan 2016 22:03:02 +0000 (14:03 -0800)]
skip zero-length linear gradient intervals to make new code more consistent with older table-based implementation
BUG=skia:4841
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619413002
Review URL: https://codereview.chromium.org/
1619413002
bsalomon [Fri, 22 Jan 2016 20:54:57 +0000 (12:54 -0800)]
Factor out xcode c/cpp settings into variables to apply to cmake builds.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619243003
Review URL: https://codereview.chromium.org/
1619243003
herb [Fri, 22 Jan 2016 19:58:55 +0000 (11:58 -0800)]
Change name from ScaleToSides to SkScaleToSides.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618283004
Review URL: https://codereview.chromium.org/
1618283004
mtklein [Fri, 22 Jan 2016 19:51:40 +0000 (11:51 -0800)]
Revert of de-proc sk_float_rsqrt (patchset #3 id:40001 of https://codereview.chromium.org/
1616013003/ )
Reason for revert:
This is somehow blocking the Google3 roll in ways neither Ben nor I understand. Precautionary revert... will try again Monday.
Original issue's description:
> de-proc sk_float_rsqrt
>
> This is the first of many little baby steps to have us stop runtime-detecting NEON.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1616013003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
efcc125acd2d71eb077caf6db65fdd6b9eb1dc0d
TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1629503002
fmalita [Fri, 22 Jan 2016 19:45:39 +0000 (11:45 -0800)]
Anisotropic mipmap fixes
1) when selecting a level scale, use max(scaleX, scaleY) instead of
current sqrt(scaleX * scaleY)
2) track and apply non-uniform fixup scales
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617183004
Review URL: https://codereview.chromium.org/
1617183004
joshualitt [Fri, 22 Jan 2016 19:21:43 +0000 (11:21 -0800)]
First rough draft of skiaserve
Please excuse the mess while we iterate
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1621753002
Review URL: https://codereview.chromium.org/
1621753002
joshualitt [Fri, 22 Jan 2016 19:17:46 +0000 (11:17 -0800)]
Update deps to pull microhttpd
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1620813004
Review URL: https://codereview.chromium.org/
1620813004
reed [Fri, 22 Jan 2016 18:35:26 +0000 (10:35 -0800)]
add GM to exercise duplicate color-stops
BUG=skia:4841
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1620423002
TBR=
Review URL: https://codereview.chromium.org/
1620423002
herb [Fri, 22 Jan 2016 18:11:03 +0000 (10:11 -0800)]
Use nextafter instead of nexttoward to avoid using long double calculation.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1621453004
Review URL: https://codereview.chromium.org/
1621453004
msarett [Fri, 22 Jan 2016 17:54:21 +0000 (09:54 -0800)]
Use NEON optimizations for RGB -> RGB(FF) or BGR(FF) in SkSwizzler
Swizzle Bench Runtime Nexus 6P
xxx_xxxa 0.32x
xxx_swaprb_xxxa 0.31x
Swizzle Bench Runtime Nexus 9
xxx_xxxa 1.11x
xxx_swaprb_xxxa 1.14x
(This is a slow down.)
Swizzle Bench Runtime Nexus 5
xxx_xxxa 0.12x
xxx_swaprb 0.12x
RGB PNG Decode Runtime
Nexus 6P 0.94x
Nexus 9 0.98x
I don't know how to explain the fact that the Swizzle Bench was
slower on Nexus 9, but the decode times got faster.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618003002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1618003002
mtklein [Fri, 22 Jan 2016 17:50:20 +0000 (09:50 -0800)]
try removing attribute((aligned(16))
CQ_EXTRA_TRYBOTS=client.skia:Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Trybot
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618873005
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1618873005
ethannicholas [Fri, 22 Jan 2016 17:45:47 +0000 (09:45 -0800)]
Revert of added support for PLS path rendering (patchset #16 id:360001 of https://codereview.chromium.org/
1541903002/ )
Reason for revert:
ASAN failure at src/gpu/GrXferProcessor.cpp:224
Original issue's description:
> added support for PLS path rendering
>
> BUG=skia:3555
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1541903002
>
> Committed: https://skia.googlesource.com/skia/+/
7df3f5e127f8016d17b637cc48a6a4718f1a6822
TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3555
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1626553002
Review URL: https://codereview.chromium.org/
1626553002
benjaminwagner [Fri, 22 Jan 2016 17:45:14 +0000 (09:45 -0800)]
Add SK_SUPPORT_LEGACY_DRAWFILTER guard around calls to SkCanvas::(get|set)DrawFilter.
Fixes Google3 dm build. (Can't enable SK_INTERNAL for Google3 dm without enabling it for all dependents.)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1626543002
Review URL: https://codereview.chromium.org/
1626543002
rmistry [Fri, 22 Jan 2016 16:57:41 +0000 (08:57 -0800)]
Revert of whitespace change to test bugdroid (patchset #1 id:1 of https://codereview.chromium.org/
1625503002/ )
Reason for revert:
one more test
Original issue's description:
> whitespace change to test bugdroid
>
> NOTRY=true
> TBR=
> BUG=skia:4814
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1625503002
>
> Committed: https://skia.googlesource.com/skia/+/
aed5717afddce200b3de88d8dde5252068b131c8
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4814
Review URL: https://codereview.chromium.org/
1626533002
mtklein [Fri, 22 Jan 2016 16:49:26 +0000 (08:49 -0800)]
de-proc sk_float_rsqrt
This is the first of many little baby steps to have us stop runtime-detecting NEON.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1616013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1616013003
rmistry [Fri, 22 Jan 2016 16:49:20 +0000 (08:49 -0800)]
whitespace change to test bugdroid
NOTRY=true
TBR=
BUG=skia:4814
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1625503002
Review URL: https://codereview.chromium.org/
1625503002
herb [Fri, 22 Jan 2016 16:34:35 +0000 (08:34 -0800)]
Fix bounds of checking if a radii are too long for a side.
BUG=skia:4692,skia:4413
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617763003
Review URL: https://codereview.chromium.org/
1617763003
mtklein [Fri, 22 Jan 2016 16:18:14 +0000 (08:18 -0800)]
DM: dump a zero-results .json file right at startup.
This way, if DM runs, the file will be there, even if it crashes before the
first time we'd ordinarily write out the file (currently, any time
the number of tasks remaining to do becomes evenly divisible by 500).
BUG=skia:4839
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1626493002
Review URL: https://codereview.chromium.org/
1626493002
bsalomon [Fri, 22 Jan 2016 16:16:09 +0000 (08:16 -0800)]
Add ability to query read pixels support without a render target.
Add more checks to onGetReadPixelsInfo.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1615023003
Review URL: https://codereview.chromium.org/
1615023003
mtklein [Fri, 22 Jan 2016 15:54:08 +0000 (07:54 -0800)]
SkBSwap32
Seems handy.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619923002
Review URL: https://codereview.chromium.org/
1619923002
mtklein [Fri, 22 Jan 2016 15:42:53 +0000 (07:42 -0800)]
Refactor swizzle names and types.
- Plant a flag to say "pretend all the inputs are RGBA".
This is how libpng thinks.
This is the opposite of what the implementation had been doing,
so I've rearranged everything to reflect the new orientation.
- Rewrite the names to be less mysterious looking. No more Xs.
- Make the src type uniformly const void*, to allow for 888 (RGB) srcs.
This should be performance and pixel neutral. (Please revert if it's not.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1626463002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1626463002
bsalomon [Fri, 22 Jan 2016 15:17:34 +0000 (07:17 -0800)]
Make swizzling in read/write pixel copy code more generic
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617433002
Review URL: https://codereview.chromium.org/
1617433002
scroggo [Fri, 22 Jan 2016 14:58:27 +0000 (06:58 -0800)]
Update libwebp to version 0.5.0
This is the version used by Android.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1601253003
Review URL: https://codereview.chromium.org/
1601253003
robertphillips [Fri, 22 Jan 2016 14:53:57 +0000 (06:53 -0800)]
Revert of Add gpu implementation of OverdrawXfermode (patchset #6 id:100001 of https://codereview.chromium.org/
1607253002/ )
Reason for revert:
Overdraw Xfer mode using new fangled glsl features
Original issue's description:
> Add gpu implementation of OverdrawXfermode
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1607253002
>
> Committed: https://skia.googlesource.com/skia/+/
8bc3cf88bbf5e5d5724356f076931bb70a6117ba
TBR=egdaniel@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/
1626443002
djsollen [Fri, 22 Jan 2016 14:50:25 +0000 (06:50 -0800)]
Revert of Consolidate SK_CRASH and sk_throw into SK_ABORT (patchset #5 id:80001 of https://codereview.chromium.org/
1610823002/ )
Reason for revert:
Chrome is calling SK_CRASH
Original issue's description:
> Consolidate SK_CRASH and sk_throw into SK_ABORT
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1610823002
>
> Committed: https://skia.googlesource.com/skia/+/
4c5cd7d527ed29aabfa72aa47b23a4496eeda357
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1620333002
ethannicholas [Fri, 22 Jan 2016 14:48:46 +0000 (06:48 -0800)]
added support for PLS path rendering
BUG=skia:3555
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1541903002
Review URL: https://codereview.chromium.org/
1541903002
joshualitt [Fri, 22 Jan 2016 14:08:48 +0000 (06:08 -0800)]
Fix GrAtlasTextBlob bounds management
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1605013002
Committed: https://skia.googlesource.com/skia/+/
ae473fdfc3db2d9dd82b05b2568767d6d4038fcd
Review URL: https://codereview.chromium.org/
1605013002
djsollen [Fri, 22 Jan 2016 14:04:55 +0000 (06:04 -0800)]
Consolidate SK_CRASH and sk_throw into SK_ABORT
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1610823002
Review URL: https://codereview.chromium.org/
1610823002
reed [Fri, 22 Jan 2016 09:04:29 +0000 (01:04 -0800)]
Revert[2] of float color components
This reverts commit
2a2bdc698460c38ac9e24ba4abdeefec67bcba37.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1622483002
TBR=
NOTRY=True
Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot seems wicked slow
Review URL: https://codereview.chromium.org/
1622483002
reed [Fri, 22 Jan 2016 08:04:30 +0000 (00:04 -0800)]
Revert of experiment: float color components (patchset #6 id:100001 of https://codereview.chromium.org/
1617813002/ )
Reason for revert:
broke some colormatrix tests
Original issue's description:
> experiment: float color components
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617813002
>
> Committed: https://skia.googlesource.com/skia/+/
353c148d8e8c9031daca34c6f9d6bcc6f08706c7
TBR=fmalita@chromium.org,mtklein@google.com,herb@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1623453002
fmalita [Fri, 22 Jan 2016 02:47:11 +0000 (18:47 -0800)]
Hide SkCanvas::{set,get}DrawFilter
Except for Android, which still makes use of it.
BUG=skia:3587
R=reed@google.com,djsollen@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1618843002
Review URL: https://codereview.chromium.org/
1618843002
reed [Thu, 21 Jan 2016 23:29:10 +0000 (15:29 -0800)]
experiment: float color components
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617813002
Review URL: https://codereview.chromium.org/
1617813002
egdaniel [Thu, 21 Jan 2016 23:21:48 +0000 (15:21 -0800)]
Add setter for GrGLSLShaderVar layout qualifier
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1611423002
Review URL: https://codereview.chromium.org/
1611423002
Ben Wagner [Thu, 21 Jan 2016 22:38:13 +0000 (17:38 -0500)]
Fix CMake build on Mac.
mtklein [Thu, 21 Jan 2016 22:24:10 +0000 (14:24 -0800)]
Stop testing builds with runtime-detected NEON
O frabjous day!
Chrome has switched on requiring NEON globally at head.
Android has always built with NEON as appropriate for each device.
In practice, this switches our Nexus 5 bots from runtime-detected to
building with NEON globally. It also lines a few columns up and makes
equivalent aliases more obviously the same.
We still have Build bots to test we can build on ARMv7 with no NEON. (We even have Build bots to test building ARMv6.)
(It looks like that buildbot_spec.json just hasn't been updated in a while.)
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1612753002
CQ_EXTRA_TRYBOTS=client.skia.android:Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot,Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot
Review URL: https://codereview.chromium.org/
1612753002
bungeman [Thu, 21 Jan 2016 22:17:47 +0000 (14:17 -0800)]
Expose API for gx font variation axes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1590223003
Review URL: https://codereview.chromium.org/
1590223003
halcanary [Thu, 21 Jan 2016 22:15:10 +0000 (14:15 -0800)]
SkValue: SkXfermode
Implement:
template<> SkValue SkToValue<SkXfermode>(const SkXfermode*);
template<> bool SkFromValue<SkXfermode*>(const SkValue&, SkXfermode**);
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1585813004
NOTRY=true
Review URL: https://codereview.chromium.org/
1585813004
egdaniel [Thu, 21 Jan 2016 19:19:52 +0000 (11:19 -0800)]
Add ability to add general layout qualifiers GrGLSLShaderVar
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1610853002
Review URL: https://codereview.chromium.org/
1610853002
msarett [Thu, 21 Jan 2016 17:59:38 +0000 (09:59 -0800)]
Use fActualProc to choose fFastProc or fSlowProc in SkSwizzler
(1) We will now (correctly) choose fFastProc if the client
calls setSampleX(1).
(2) The logic to choose between fFastProc and fSlowProc
is now performed once, rather than every time we call
swizzle().
(3) This will be easier to extend when we add
fFastSampleProcs for different sample sizes.
This comes from Leon's suggestion in:
https://codereview.chromium.org/
1582083005
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1616753003
Review URL: https://codereview.chromium.org/
1616753003
senorblanco [Thu, 21 Jan 2016 17:55:47 +0000 (09:55 -0800)]
Fix bounds computations for SkDisplacementMapEffect with negative scale.
BUG=skia:4835
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1616663003
Review URL: https://codereview.chromium.org/
1616663003
mtklein [Thu, 21 Jan 2016 17:39:35 +0000 (09:39 -0800)]
DM: dump images for task failures too (but not skipped tasks)
This will get us back to uploading things like serialize-8888 mismatches.
BUG=skia:4806
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1614443002
Review URL: https://codereview.chromium.org/
1614443002
scroggo [Thu, 21 Jan 2016 17:32:58 +0000 (09:32 -0800)]
Add version number to images tested in DM
BUG=skia:4558
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619493003
Review URL: https://codereview.chromium.org/
1619493003
mtklein [Thu, 21 Jan 2016 17:25:32 +0000 (09:25 -0800)]
Demo fuzz for Herb
BUG=skia:4692
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1611293002
Review URL: https://codereview.chromium.org/
1611293002
robertphillips [Thu, 21 Jan 2016 17:05:32 +0000 (09:05 -0800)]
Add Lua SkXfermode skp scraping support
This is to answer the question of do any of our skps have SkLerpXfermodes. AFAICT they should not so this is just to verify.
The only controversial part of this is the addition of 'getLuaName' to SkXfermode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1614923002
Review URL: https://codereview.chromium.org/
1614923002
msarett [Thu, 21 Jan 2016 17:05:23 +0000 (09:05 -0800)]
Rename SkCodec_libpng to SkPngCodec
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1613043003
Review URL: https://codereview.chromium.org/
1613043003
bungeman [Thu, 21 Jan 2016 16:18:42 +0000 (08:18 -0800)]
Implement onMatchFamilyStyle for Mac.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1612653002
Review URL: https://codereview.chromium.org/
1612653002
caryclark [Thu, 21 Jan 2016 15:07:02 +0000 (07:07 -0800)]
resolution dependent path measure
When a dash is drawn through a canvas with a scaled up
matrix, path measure needs the pixel resolution through
the matrix to construct the dash with sufficient
resolution.
Pass the resolution through to path measure.
Replicate chrome bug in skia GM.
R=reed@google.com
BUG=530095
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1608353002
Review URL: https://codereview.chromium.org/
1608353002
caryclark [Thu, 21 Jan 2016 14:54:46 +0000 (06:54 -0800)]
fix skp fuzz
R=kjlubick@google.com
BUG=skia:4816
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617033002
Review URL: https://codereview.chromium.org/
1617033002
senorblanco [Thu, 21 Jan 2016 14:49:15 +0000 (06:49 -0800)]
Remove SK_SUPPORT_SRC_BOUNDS_BLOAT_FOR_IMAGEFILTERS (now unused).
BUG=skia:3194
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1616503002
Review URL: https://codereview.chromium.org/
1616503002
reed [Thu, 21 Jan 2016 14:44:18 +0000 (06:44 -0800)]
detect bad/corrupt flattenable factory indices
BUG=skia:4814
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1615883002
Review URL: https://codereview.chromium.org/
1615883002
bsalomon [Thu, 21 Jan 2016 14:44:08 +0000 (06:44 -0800)]
Make colorimagefilter GM not crash when resource path not specified
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1619723002
BUG=skia:
Review URL: https://codereview.chromium.org/
1619723002
mtklein [Thu, 21 Jan 2016 14:13:52 +0000 (06:13 -0800)]
fuzz: list API fuzzing options if -t api and -n matches nothing.
Today we segfault if --name is empty. This fixes that too.
This updates some terms: -t api lets us fuzz an API.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1617713003
Review URL: https://codereview.chromium.org/
1617713003
kjlubick [Thu, 21 Jan 2016 13:03:28 +0000 (05:03 -0800)]
Seperating our fuzzing binary from DM produces a 50x speed increase for decoding images and a 10x speed increase in decoding/rendering Skps.
This also lets us differentiate between the decoding of Skps and the rendering of them, the latter of which may be more interesting for bugs.
BUG=skia:4800
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1591073002
Review URL: https://codereview.chromium.org/
1591073002
reed [Thu, 21 Jan 2016 12:33:07 +0000 (04:33 -0800)]
remove dead code around SK_SUPPORT_LEGACY_TRANSLATEROUNDHACK
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1611183002
TBR=
Review URL: https://codereview.chromium.org/
1611183002
joshualitt [Wed, 20 Jan 2016 21:54:28 +0000 (13:54 -0800)]
Revert of Fix GrAtlasTextBlob bounds management (patchset #8 id:140001 of https://codereview.chromium.org/
1605013002/ )
Reason for revert:
seems to break upright matrix
Original issue's description:
> Fix GrAtlasTextBlob bounds management
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1605013002
>
> Committed: https://skia.googlesource.com/skia/+/
ae473fdfc3db2d9dd82b05b2568767d6d4038fcd
TBR=bsalomon@google.com,jvanverth@google.com,joshualitt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1615473002
mtklein [Wed, 20 Jan 2016 21:35:20 +0000 (13:35 -0800)]
SkValue: improve SkFromValue<T> implementation
Add template<> bool SkFromValue<float>(const SkValue&, float*);
Refactor template<> bool SkFromValue<SkMatrix>(const SkValue&, SkMatrix*);
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1605093003
Review URL: https://codereview.chromium.org/
1605093003
joshualitt [Wed, 20 Jan 2016 21:09:12 +0000 (13:09 -0800)]
Revert to old behavior for swap buffers
New behavior is preserved with 'syncOrSwap' call
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1606883005
Review URL: https://codereview.chromium.org/
1606883005
joshualitt [Wed, 20 Jan 2016 20:35:22 +0000 (12:35 -0800)]
Fix GrAtlasTextBlob bounds management
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1605013002
Review URL: https://codereview.chromium.org/
1605013002
robertphillips [Wed, 20 Jan 2016 20:00:21 +0000 (12:00 -0800)]
Add gpu implementation of OverdrawXfermode
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1607253002
Review URL: https://codereview.chromium.org/
1607253002
mtklein [Wed, 20 Jan 2016 19:55:51 +0000 (11:55 -0800)]
SkNx miplevel building
All sizes approximately twice as fast.
Before:
micros bench
1649.35 mipmap_build_512x512 nonrendering
1824.42 mipmap_build_511x512 nonrendering
2100.66 ? mipmap_build_512x511 nonrendering
2375.94 mipmap_build_511x511 nonrendering
After:
micros bench
730.32 ! mipmap_build_512x512 nonrendering
922.12 mipmap_build_511x512 nonrendering
999.07 mipmap_build_512x511 nonrendering
1342.93 ! mipmap_build_511x511 nonrendering
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1606013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Committed: https://skia.googlesource.com/skia/+/
3bd5aba2a0e165997f683cf3aa306661e71464f6
Review URL: https://codereview.chromium.org/
1606013003
caryclark [Wed, 20 Jan 2016 19:55:11 +0000 (11:55 -0800)]
replace arcto quads with a conic
also, remove code used only for
the quad generation
R=reed@google.com
BUG=578885
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1612543003
Review URL: https://codereview.chromium.org/
1612543003
fmalita [Wed, 20 Jan 2016 19:17:39 +0000 (11:17 -0800)]
Convert CanvasStateTest to the new saveLayer API
The test needs to still work when SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG is
defined but SK_SUPPORT_LEGACY_SAVEFLAGS is not.
R=reed@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1610193002
Review URL: https://codereview.chromium.org/
1610193002
reed [Wed, 20 Jan 2016 19:04:40 +0000 (11:04 -0800)]
change kMedium_SkFilterQuality to never pop if we're scaling
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1605193002
Review URL: https://codereview.chromium.org/
1605193002
joshualitt [Wed, 20 Jan 2016 18:54:58 +0000 (10:54 -0800)]
add wait on fence without flush
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1610183002
Review URL: https://codereview.chromium.org/
1610183002
halcanary [Wed, 20 Jan 2016 18:00:26 +0000 (10:00 -0800)]
SkValue: implementation, unit test
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1604253002
Review URL: https://codereview.chromium.org/
1604253002
mtklein [Wed, 20 Jan 2016 17:53:59 +0000 (09:53 -0800)]
Make nanobench --outResultsFile only work with Release builds.
It is very, very misleading to report performance numbers for Debug builds.
This makes it impossible for us to upload them to perf.skia.org.
BUG=skia:4828
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1606323002
Review URL: https://codereview.chromium.org/
1606323002
fs [Wed, 20 Jan 2016 17:51:07 +0000 (09:51 -0800)]
Add SkPath::isLastContourClosed()
Adds a simple method for checking if the last command/verb in the
current contour is a 'close'.
This will simplify determining "closedness" for blink::Path, and aid
in the implementation of algorithms such as:
https://drafts.fxtf.org/motion-1/#motion-processing (second item in list)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1601103006
Review URL: https://codereview.chromium.org/
1601103006
mtklein [Wed, 20 Jan 2016 16:46:40 +0000 (08:46 -0800)]
teach dump_record to recurse into subpictures
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1606293002
Review URL: https://codereview.chromium.org/
1606293002
mtklein [Wed, 20 Jan 2016 16:33:59 +0000 (08:33 -0800)]
Revert of SkNx miplevel building (patchset #3 id:40001 of https://codereview.chromium.org/
1606013003/ )
Reason for revert:
Paranoid revert to see if it helps skia:4823
Original issue's description:
> SkNx miplevel building
>
> All sizes approximately twice as fast.
>
> Before:
> micros bench
> 1649.35 mipmap_build_512x512 nonrendering
> 1824.42 mipmap_build_511x512 nonrendering
> 2100.66 ? mipmap_build_512x511 nonrendering
> 2375.94 mipmap_build_511x511 nonrendering
>
> After:
> micros bench
> 730.32 ! mipmap_build_512x512 nonrendering
> 922.12 mipmap_build_511x512 nonrendering
> 999.07 mipmap_build_512x511 nonrendering
> 1342.93 ! mipmap_build_511x511 nonrendering
>
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1606013003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
3bd5aba2a0e165997f683cf3aa306661e71464f6
TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1607323002
reed [Wed, 20 Jan 2016 16:12:02 +0000 (08:12 -0800)]
remove fragile assert
The assert basically wants the following to always be true (but it aint)
floor(int + 0.5 + float) == floor(0.5 + float) + int
... where int + 0.5 happens first, and then we add the float.
BUG=skia:4825
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1609873003
Review URL: https://codereview.chromium.org/
1609873003
joshualitt [Wed, 20 Jan 2016 16:07:01 +0000 (08:07 -0800)]
Add ability to wire up sharelist in glcontext creation
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1604993005
Review URL: https://codereview.chromium.org/
1604993005
egdaniel [Wed, 20 Jan 2016 15:53:51 +0000 (07:53 -0800)]
Make GrGLProgramBuilder a local stack variable in CreateProgram
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1604313002
Review URL: https://codereview.chromium.org/
1604313002
caryclark [Wed, 20 Jan 2016 15:46:05 +0000 (07:46 -0800)]
add arc circle gap gm
The circle and arc don't line up because
the circle uses conics and arc uses
quadratics.
TBR=reed@google.com
BUG=578885
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1606263002
Review URL: https://codereview.chromium.org/
1606263002