platform/core/multimedia/mmsvc-core.git
3 years agoChange pidfile path from /tmp to /run 86/250286/2 accepted/tizen/unified/20201228.130128 submit/tizen/20201223.070656
YoungHun Kim [Wed, 23 Dec 2020 06:14:37 +0000 (15:14 +0900)]
Change pidfile path from /tmp to /run

 - The normal location for pidfiles is /run.

Change-Id: I147f8c09bcf6077305bbbd6fbd4e9e93f6380e9f

3 years agoDisable MUSE_USE_RM_READY to avoid deadlock issue 55/249555/4 accepted/tizen/unified/20201216.215918 submit/tizen/20201215.064128
YoungHun Kim [Tue, 15 Dec 2020 02:00:09 +0000 (11:00 +0900)]
Disable MUSE_USE_RM_READY to avoid deadlock issue

 - It is for avoiding the deadlock issue, which is MUSE_USE_RM_READY's _ms_resource_manager_owner_name_changed_cb()
   executing through dbus when dbus error (eg. GDBus.Error:net.stc.iptables.Error.Failed: OPERATION_FAILED) occurs.
   Thread 2 (LWP 2715):
   #0  __lll_lock_wait_private (futex=0xf7567584 <main_arena>) at ./lowlevellock.c:35
   #1  0xf74a0dc0 in __GI___libc_malloc (bytes=bytes@entry=6) at malloc.c:3064
   #2  0xf75d3c64 in g_malloc (n_bytes=6) at ../glib/gmem.c:99
   #3  0xf75fa978 in g_variant_format_string_scan_type (string=string@entry=0xf76e359c "(sss)", limit=limit@entry=0x0, endptr=endptr@entry=0xffdc7e60) at ../glib/gvariant.c:4597
   #4  0xf75faa06 in valid_format_string (format_string=format_string@entry=0xf76e359c "(sss)", single=single@entry=1, value=value@entry=0xf3eb42a0) at ../glib/gvariant.c:4617
   #5  0xf75fb040 in g_variant_get (value=value@entry=0xf3eb42a0, format_string=0xf76e359c "(sss)") at ../glib/gvariant.c:5499
   #6  0xf76ddf4a in _ms_resource_manager_owner_name_changed_cb (con=<optimized out>, sender_name=<optimized out>, object_path=0xf580ec60 "", interface_name=<optimized out>, signal_name=0xe3fef958 "", parameters=0xf3eb42a0, user_data=0x0) at /usr/src/debug/mused-0.3.131/server/src/muse_server_system.c:269
 - Remove unnecessary log

Change-Id: Iaf270a6a9867486f4ff16a5127d4b19e4b61a6af

3 years agoRemove meaningless log that can be printed frequently 72/249372/1 accepted/tizen/unified/20201214.124518 submit/tizen/20201211.050631 submit/tizen_6.0/20201211.050224
YoungHun Kim [Fri, 11 Dec 2020 00:28:21 +0000 (09:28 +0900)]
Remove meaningless log that can be printed frequently

Change-Id: Ib94156237af25edcc5a2e224f459d335f5948f98

4 years agoMerge branch 'tizen' into tizen_6.0 23/247423/1 accepted/tizen/6.0/unified/20201113.014550 submit/tizen_6.0/20201111.054633
YoungHun Kim [Tue, 10 Nov 2020 23:50:19 +0000 (08:50 +0900)]
Merge branch 'tizen' into tizen_6.0

Change-Id: Ie7ef3053526dc04d34a74dc1c32ef8c007ee954d

4 years agoUpdate client log for clear analysis 09/247309/1 accepted/tizen/unified/20201112.124135 submit/tizen/20201111.054717
YoungHun Kim [Mon, 9 Nov 2020 22:56:37 +0000 (07:56 +0900)]
Update client log for clear analysis

Change-Id: I61ad8f5bdf0ea003e24b0058c1476a320ca007da

4 years agoUpdate log to analyze issues not returned at ms_module_dispatch() 98/246998/1 accepted/tizen/6.0/unified/20201111.064831 submit/tizen_6.0/20201110.051721
YoungHun Kim [Thu, 5 Nov 2020 01:08:40 +0000 (10:08 +0900)]
Update log to analyze issues not returned at ms_module_dispatch()

Change-Id: I0feec619b6ce3888ee676ac653b773f5ccced105

4 years agoUpdate log to analyze issues not returned at ms_module_dispatch() 76/246876/1 accepted/tizen/unified/20201106.051629 submit/tizen/20201105.053617
YoungHun Kim [Thu, 5 Nov 2020 01:08:40 +0000 (10:08 +0900)]
Update log to analyze issues not returned at ms_module_dispatch()

Change-Id: I470bb918e164646074fcde7aab9e5972af8c6061

4 years agoUpdate to log in case of STDIN_FILENO 55/246055/2 accepted/tizen/unified/20201027.125323 submit/tizen/20201023.050718
YoungHun Kim [Thu, 22 Oct 2020 22:50:06 +0000 (07:50 +0900)]
Update to log in case of STDIN_FILENO

Change-Id: I527c7c75065a9807a66b6157f6172f87e2ffc0ba

4 years agoChange watchdog timeout based on g_dbus_connection_call_sync() timeout of runtime... 06/245806/4 submit/tizen/20201016.071425
YoungHun Kim [Fri, 16 Oct 2020 05:00:45 +0000 (14:00 +0900)]
Change watchdog timeout based on g_dbus_connection_call_sync() timeout of runtime-info

 - Currently, muse server watchdog is set to no response for 1 minute. If there is
   no response while executing the g_dbus_connection_call_sync() operation set to 2 minutes,
   the process is terminated by deadlock. Therefore, change the muse-server watchdog time to about 2 min 20 sec.
 - Add log at ms_connection_lock/unlock

Change-Id: I61a2082c51b1cf3fc24123318a221f4b67c3a4cb

4 years agoAdd log of _ms_resource_manager_owner_name_changed_cb() to check execution complete 28/245728/1 submit/tizen/20201015.033807
YoungHun Kim [Thu, 15 Oct 2020 01:16:36 +0000 (10:16 +0900)]
Add log of _ms_resource_manager_owner_name_changed_cb() to check execution complete

Change-Id: I05a004b37002b149aba696fda93af6f27cf89b08

4 years agoAdd log to check if runtime_info_get_process_memory_info() returns 65/245665/3 submit/tizen/20201014.053007
YoungHun Kim [Wed, 14 Oct 2020 02:45:30 +0000 (11:45 +0900)]
Add log to check if runtime_info_get_process_memory_info() returns

Change-Id: I90d6736c68bba998debe023871f85bb5cd72d1de

4 years agoExectue malloc_trim() to release free memory from the top of the heap 88/244188/6 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.114614 accepted/tizen/6.0/unified/hotfix/20201103.003528 accepted/tizen/unified/20200918.123705 submit/tizen/20200917.045119 submit/tizen_6.0/20201029.205104 submit/tizen_6.0_hotfix/20201102.192504 submit/tizen_6.0_hotfix/20201103.114804 tizen_6.0.m2_release
YoungHun Kim [Tue, 15 Sep 2020 23:07:30 +0000 (08:07 +0900)]
Exectue malloc_trim() to release free memory from the top of the heap

Change-Id: I0750d569919faadc9675568a80063116acfa8e6f

4 years agoChanged the timeout of watchdog to maximum dispatcher timeout 85/243685/1 accepted/tizen/unified/20200914.131518 submit/tizen/20200909.064106
YoungHun Kim [Wed, 9 Sep 2020 06:31:55 +0000 (15:31 +0900)]
Changed the timeout of watchdog to maximum dispatcher timeout

Change-Id: I46d815cd1562448e2640f3d0a7c247663e445419

4 years agoUpdate service setting value for the restart failure issue 63/242063/3 accepted/tizen/unified/20200831.122534 submit/tizen/20200828.011226
YoungHun Kim [Mon, 24 Aug 2020 02:18:17 +0000 (11:18 +0900)]
Update service setting value for the restart failure issue

 - The issue is of 'start request repeated too quickly' and 'Failed with result 'start-limit-hit'
 - Set StartLimitIntervalSec to 0 to configure infinite loop until restart is succeeded

Change-Id: Idb931208a50dc598926831dd244f09b73140ac8e

4 years agoFix the duplicate state change while muse server terminating 47/241047/1 accepted/tizen/unified/20200825.033157 submit/tizen/20200821.023316
YoungHun Kim [Fri, 14 Aug 2020 05:53:44 +0000 (14:53 +0900)]
Fix the duplicate state change while muse server terminating

Change-Id: I729775aa5278bb9a538a22e09b4ac336128a2b93

4 years agoUpdate the dlog 69/240069/2 accepted/tizen/unified/20200805.122528 submit/tizen/20200804.040848
YoungHun Kim [Mon, 3 Aug 2020 04:53:20 +0000 (13:53 +0900)]
Update the dlog

 - Set log level for ms_init() to warning

Change-Id: I68d24f8841ebf44c7c500200f02b93c031efaae0

4 years agoRemove the unnecessary null check related with g_async_queue 01/239601/2
YoungHun Kim [Tue, 28 Jul 2020 05:28:33 +0000 (14:28 +0900)]
Remove the unnecessary null check related with g_async_queue

Change-Id: I95265493d0a55a63b7d9d459408266f4d0f59bcc

4 years agoRevise the time buffer array size 43/239343/1 accepted/tizen/unified/20200727.132111 submit/tizen/20200724.062205
YoungHun Kim [Fri, 24 Jul 2020 05:28:51 +0000 (14:28 +0900)]
Revise the time buffer array size

Change-Id: I75972a43b18c2322f3b4a834a72037b638bcee51

4 years agoChange fd dump format of a time structure to monotonic system clock at destroy 65/239265/6
YoungHun Kim [Thu, 23 Jul 2020 08:03:30 +0000 (17:03 +0900)]
Change fd dump format of a time structure to monotonic system clock at destroy

 - change log level

Change-Id: I06462498edbdc39342206188677e7a0f3a10859c

4 years agoUse ms_config_get_host_cnt() to fix DEREF_OF_NULL 20/239220/1 accepted/tizen/unified/20200724.124224 submit/tizen/20200723.014452 submit/tizen/20200723.081321
YoungHun Kim [Wed, 22 Jul 2020 23:16:01 +0000 (08:16 +0900)]
Use ms_config_get_host_cnt() to fix DEREF_OF_NULL

Change-Id: I3e977e5f9ff34de2c141887c9c708b2eaba1d70e

4 years agoUse clock_gettime() with CLOCK_MONOTONIC which is not affected by changing system... 67/238867/10 accepted/tizen/unified/20200722.144553 submit/tizen/20200722.020823
YoungHun Kim [Mon, 20 Jul 2020 02:48:06 +0000 (11:48 +0900)]
Use clock_gettime() with CLOCK_MONOTONIC which is not affected by changing system time

 - update muse_core_get_cur_time() and dlog

Change-Id: I3d194faf73d509d9f438f2cb328a61ba1cad821f

4 years agoAdd gio-2.0, mm-common and libtbm to muse-server.pc 77/238377/4 accepted/tizen/unified/20200717.124728 submit/tizen/20200713.225838 submit/tizen/20200716.054500
YoungHun Kim [Mon, 13 Jul 2020 06:45:29 +0000 (15:45 +0900)]
Add gio-2.0, mm-common and libtbm to muse-server.pc

Change-Id: Ic3dd68aa52f6665f28827e0a3aefc885078b7501

4 years agofixup! Remove unnecessary dependency for devel package 51/238351/1 submit/tizen/20200713.054236
YoungHun Kim [Mon, 13 Jul 2020 04:33:26 +0000 (13:33 +0900)]
fixup! Remove unnecessary dependency for devel package

Change-Id: I1b4bd5f0cd3548075462eea3adb5ec3c07516a4f

4 years agofixup! Avoid the module access after destroy 74/238174/2 accepted/tizen/unified/20200713.094448 submit/tizen/20200710.025458
YoungHun Kim [Thu, 9 Jul 2020 05:43:02 +0000 (14:43 +0900)]
fixup! Avoid the module access after destroy

Change-Id: Iad3fbed148a296e6b2e52dd406cfb9e1227662b6

4 years agoChange to terminate using raise() 40/238040/5
YoungHun Kim [Wed, 8 Jul 2020 01:55:12 +0000 (10:55 +0900)]
Change to terminate using raise()

 - Remove the unused ms_kill_thread

Change-Id: I6077607177ca5c14bb0480fd05a0630221e10e6f

4 years agoCheck the return value of gettimeofday() and move function execution procedure at... 40/237940/4 accepted/tizen/unified/20200708.125338 submit/tizen/20200707.102034
YoungHun Kim [Tue, 7 Jul 2020 00:17:20 +0000 (09:17 +0900)]
Check the return value of gettimeofday() and move function execution procedure at connection handler

 - Add connection time log for debugging

Change-Id: Iedfcd2b00816fd7da450869b81f048a463a488a2

4 years agoRemove unnecessary dependency for devel package 38/237938/1
Jeongmo Yang [Tue, 7 Jul 2020 00:16:22 +0000 (09:16 +0900)]
Remove unnecessary dependency for devel package

Change-Id: I30593cc88920ef43ba60d706de66a1cd52e9e41e
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agoRevert "Remove the mm-common dependency" 02/237902/1 accepted/tizen/unified/20200707.140926 submit/tizen/20200706.093735
Jeongmo Yang [Mon, 6 Jul 2020 09:22:15 +0000 (18:22 +0900)]
Revert "Remove the mm-common dependency"

This reverts commit d67c3e8bb75349b26d1a998791bff9c56ae37730.

Change-Id: I9b503e47731a6f952c858f2bd95781882ec4eef2
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agoRemove the mm-common dependency 27/237827/1 submit/tizen/20200706.045441
YoungHun Kim [Mon, 6 Jul 2020 03:09:56 +0000 (12:09 +0900)]
Remove the mm-common dependency

Change-Id: I37f6a184e77c66117af299d5e92d58e6b40aa5b7

4 years agoUpdate the dependency format of cmake as line by line 56/237556/5
YoungHun Kim [Wed, 1 Jul 2020 07:59:07 +0000 (16:59 +0900)]
Update the dependency format of cmake as line by line

 - Add missing gstreamer-base-1.0 at CMakeLists.txt
   explicitly to sync with spec's pkgconfig information

Change-Id: I94378e0a653c0d4af84e6947ab9840316441730f

4 years agoAdd missing gmodule-2.0 at spec file to sync with CMakeLists.txt 55/237555/1
YoungHun Kim [Wed, 1 Jul 2020 07:55:43 +0000 (16:55 +0900)]
Add missing gmodule-2.0 at spec file to sync with CMakeLists.txt

Change-Id: I88047b4e2a1d5eef2fccfd28ac07b74f04ec4ebd

4 years agoAdd missing gio-2.0 dependency to CMakeLists 78/237478/6 accepted/tizen/unified/20200702.141736 submit/tizen/20200701.072508
YoungHun Kim [Tue, 30 Jun 2020 23:47:33 +0000 (08:47 +0900)]
Add missing gio-2.0 dependency to CMakeLists

 - The build error occurred due to the undefined reference to
   'g_bug_get_sync' without this patch.

Change-Id: I35cb94d30e29cc345b83e95b497a4937a129e1a4

4 years agoFix bug to print the idle state properly in every period defined in mused.conf 09/236309/14 accepted/tizen/unified/20200629.143521 submit/tizen/20200624.045121
YoungHun Kim [Tue, 16 Jun 2020 06:45:28 +0000 (15:45 +0900)]
Fix bug to print the idle state properly in every period defined in mused.conf

 - Refresh initial time whenever a client is connected
 - The data type for elapsed time is also changed to unsigned integer to increase its maximum value

Change-Id: I1dfb66666ff130cdda291a710e6b6dff1d39818d

4 years agoUpdate the dlog of percent and dlog level related with msg channel 03/236103/2
YoungHun Kim [Mon, 15 Jun 2020 02:23:40 +0000 (11:23 +0900)]
Update the dlog of percent and dlog level related with msg channel

Change-Id: I51a48440378884a3cf82960ba7aed8e0e30ff637

4 years agoFix ASAN issue : heap-use-after-free 05/235705/3 accepted/tizen/unified/20200610.015637 submit/tizen/20200609.063705
Jeongmo Yang [Tue, 9 Jun 2020 05:16:22 +0000 (14:16 +0900)]
Fix ASAN issue : heap-use-after-free

[ASAN report]
==muse-server==10013==ERROR: AddressSanitizer: heap-use-after-free on address 0xb1baa100 at pc 0xb69cb399 bp 0xbed15dfc sp 0xbed15dec
WRITE of size 4 at 0xb1baa100 thread T0
0 0xb69cb396 in ms_ipc_create_msg_dispatch_worker /usr/src/debug/mused-0.3.110/server/src/muse_server_ipc.c:420
1 xb69d3914 in _ms_connection_handler /usr/src/debug/mused-0.3.110/server/src/muse_server_private.c:312 (discriminator 14)

0xb1baa100 is located 0 bytes inside of 4232-byte region [0xb1baa100,0xb1bab188)
freed by thread T393 (msg) here:
0 0xb6aebee2 in free asan_rtl (discriminator 2)
1 0xb69cac14 in _ms_ipc_module_cleanup /usr/src/debug/mused-0.3.110/server/src/muse_server_ipc.c:110
2 0xb69cac14 in _ms_ipc_dispatch_worker /usr/src/debug/mused-0.3.110/server/src/muse_server_ipc.c:312

Thread T393 (msg) created by T0 here:
0 0xb6aec2ee in calloc asan_rtl (discriminator 2)
1 0xb67fc068 in g_malloc0 /usr/src/debug/glib2-2.62.3/_build/../glib/gmem.c:129
2 0xb69d38a0 in _ms_connection_handler /usr/src/debug/mused-0.3.110/server/src/muse_server_private.c:307 (discriminator 9)

[Version] 0.3.118
[Profile] Common
[Issue Type] Bug fix

Change-Id: I988af4df53cc26f849c65a194bfc83ecbb87620d
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agoDo not execute clean-up right after dispatch_no_instance without destroy dispatch 23/235623/5
YoungHun Kim [Mon, 8 Jun 2020 06:38:50 +0000 (15:38 +0900)]
Do not execute clean-up right after dispatch_no_instance without destroy dispatch

 - Add log of module pointer

Change-Id: I7503b987805cdd6b9fd27add9e19841425b469bd

4 years agoChange thread name 03/235503/1
YoungHun Kim [Fri, 5 Jun 2020 05:53:39 +0000 (14:53 +0900)]
Change thread name

Change-Id: I686120fbe819f62327fc34611c6c2de11d3e95b0

4 years agoCode refactorying 21/235321/7
YoungHun Kim [Wed, 3 Jun 2020 23:50:17 +0000 (08:50 +0900)]
Code refactorying

Change-Id: I08eb8d84e24cd8ed853f473c78ac2789d2fecdf7

4 years agoRevise the cpu usage 72/235272/2
YoungHun Kim [Wed, 3 Jun 2020 08:37:03 +0000 (17:37 +0900)]
Revise the cpu usage

Change-Id: I52a833c55dc758dbfc23ba797e68cce184c24ee5

4 years agoUpdate the diagnostic thread structure 11/235211/8
YoungHun Kim [Wed, 3 Jun 2020 00:00:09 +0000 (09:00 +0900)]
Update the diagnostic thread structure

Change-Id: I223d6e2840d84aa88899045aa7e2d5507a5afbad

4 years agoFix the issue of buffer overflow 86/235186/4
YoungHun Kim [Tue, 2 Jun 2020 11:19:16 +0000 (20:19 +0900)]
Fix the issue of buffer overflow

Change-Id: I4ddd17cebc7afa198740dbee9e7f2ba4ce9905fb

4 years agoUse g_aync_queue instead of epoll for handling of instance connection event 68/234968/13
YoungHun Kim [Mon, 1 Jun 2020 07:04:58 +0000 (16:04 +0900)]
Use g_aync_queue instead of epoll for handling of instance connection event

Change-Id: I3f801559dcc202c68b761a062e04263a73f1c11a

4 years agoSet high priority of g_idle_callback to create ready file 82/234382/2
YoungHun Kim [Tue, 26 May 2020 03:49:37 +0000 (12:49 +0900)]
Set high priority of g_idle_callback to create ready file

Change-Id: Ibf56dfd200c7c10936d70137f0c32538609e6335

4 years agoCheck the value at idle time for debugging the cpu usage issue 63/234163/7 submit/tizen/20200525.224545
YoungHun Kim [Fri, 22 May 2020 08:02:52 +0000 (17:02 +0900)]
Check the value at idle time for debugging the cpu usage issue

Change-Id: I0f7a411585e127952eb635a5127448452a413e40

4 years agoCreate diagnostic thread after executing g_idle_add normally 58/234158/4
YoungHun Kim [Fri, 22 May 2020 07:48:45 +0000 (16:48 +0900)]
Create diagnostic thread after executing g_idle_add normally

Change-Id: Ic1cd606923dc57f042ae06abfe0ae13fcfdc8e4f

4 years agoRemove the unnecessary g_thread_exit call 32/233732/1
YoungHun Kim [Mon, 18 May 2020 23:48:18 +0000 (08:48 +0900)]
Remove the unnecessary g_thread_exit call

 - Remove warning log

Change-Id: I32e4faccc901f877048589aaa48456a4e89b017c

4 years agoSeparate threads to facilitate control of each operation 30/232230/8 submit/tizen/20200507.052130
YoungHun Kim [Wed, 29 Apr 2020 07:10:54 +0000 (16:10 +0900)]
Separate threads to facilitate control of each operation

Change-Id: I3f7aa905fb4693dee3af180a8ab77c686ec06e49

4 years agoPrint the log of the instance information at regular intervals 62/232162/5
YoungHun Kim [Wed, 29 Apr 2020 00:12:29 +0000 (09:12 +0900)]
Print the log of the instance information at regular intervals

Change-Id: Ibaeb74932b5e20ad1cc872a75b6fbfa24a345259

4 years agoAdd the coverage measurement for muse 34/231834/7
YoungHun Kim [Fri, 24 Apr 2020 10:19:36 +0000 (19:19 +0900)]
Add the coverage measurement for muse

Change-Id: Ia8a2594517622e7685d5fcfbb283466f73e97f30

4 years agoChange the variable of extern with static 49/231849/1
YoungHun Kim [Fri, 24 Apr 2020 11:45:01 +0000 (20:45 +0900)]
Change the variable of extern with static

Change-Id: Icbc7f2e3dd946926fd728e4176316837dd1bdaf8

4 years agoUse g_new0 instead of calloc 94/231494/5 accepted/tizen/unified/20200424.141638 submit/tizen/20200423.064248
YoungHun Kim [Wed, 22 Apr 2020 06:59:45 +0000 (15:59 +0900)]
Use g_new0 instead of calloc

Change-Id: I37f4ca0cb09fb52d2f7e960679cd53784736e465

4 years agoUpdate the argc of gst_init_check 87/231487/2
YoungHun Kim [Wed, 22 Apr 2020 06:37:57 +0000 (15:37 +0900)]
Update the argc of gst_init_check

Change-Id: I40322da038e328cdffa660bef3a9c75a6788eac1

4 years agoUse g_malloc0/g_free instead of malloc/free 60/231460/4
YoungHun Kim [Wed, 22 Apr 2020 05:25:53 +0000 (14:25 +0900)]
Use g_malloc0/g_free instead of malloc/free

Change-Id: Ibefc3b87ed4f5cfeb4e97cceb5e7c819420acf09

4 years agoRemove non async-signal-safe function in signal handler 16/231216/7 accepted/tizen/unified/20200423.054618 submit/tizen/20200422.061027
YoungHun Kim [Mon, 20 Apr 2020 07:39:12 +0000 (16:39 +0900)]
Remove non async-signal-safe function in signal handler

Change-Id: Ia092ae0515d4d28e58d248b041a0944c26a0b9df

4 years agoFix the typo 48/231448/1
YoungHun Kim [Wed, 22 Apr 2020 04:41:17 +0000 (13:41 +0900)]
Fix the typo

Change-Id: I13fa4503fa094b8094b4434b7c0c7bbe1d4557ed

4 years agoChange remove with unlink of async-signal-safe function 89/230889/10
YoungHun Kim [Thu, 16 Apr 2020 00:32:18 +0000 (09:32 +0900)]
Change remove with unlink of async-signal-safe function

Change-Id: I9851fccfb38337802ceb59bf96ff32d738a691dc

4 years agoRevise the watchdog period 18/231218/1
YoungHun Kim [Mon, 20 Apr 2020 07:41:50 +0000 (16:41 +0900)]
Revise the watchdog period

Change-Id: I13bf84b3bdb66bfca68ceeba64257d71d411f885

4 years agoUpdate the macro function 02/230702/4 accepted/tizen/unified/20200417.152704 submit/tizen/20200416.230147
YoungHun Kim [Mon, 13 Apr 2020 12:05:18 +0000 (21:05 +0900)]
Update the macro function

Change-Id: I19ef9fc6fc3032b051a802c5eabd2d11e9afae89

4 years agoMerge "Do not check the value of log_enabled which is always false now" into tizen accepted/tizen/unified/20200416.080117 submit/tizen/20200414.085837
YoungHun Kim [Tue, 14 Apr 2020 08:57:58 +0000 (08:57 +0000)]
Merge "Do not check the value of log_enabled which is always false now" into tizen

4 years agoDo not check the value of log_enabled which is always false now 01/230701/4
YoungHun Kim [Mon, 13 Apr 2020 11:51:25 +0000 (20:51 +0900)]
Do not check the value of log_enabled which is always false now

Change-Id: Ibc7a77bdf9de8858a6a59ddee6970b03daa07588

4 years agoMerge "Fix the bug of signal handler" into tizen
YoungHun Kim [Mon, 13 Apr 2020 23:19:27 +0000 (23:19 +0000)]
Merge "Fix the bug of signal handler" into tizen

4 years agoFix the bug of signal handler 90/230690/2
YoungHun Kim [Mon, 13 Apr 2020 11:03:55 +0000 (20:03 +0900)]
Fix the bug of signal handler

Change-Id: I296c472586bd30e01faec2cd4679377bcec995fd

4 years agoAlign with a fixed tab space 89/230689/1
YoungHun Kim [Mon, 13 Apr 2020 11:02:17 +0000 (20:02 +0900)]
Align with a fixed tab space

Change-Id: I8c412596867a764ad3d264f65bf6bebd96404dbd

4 years agoDo not call some debugging implementation of deadlock to reduce executing time 92/229692/3 accepted/tizen/unified/20200406.015151 submit/tizen/20200403.043453
YoungHun Kim [Fri, 3 Apr 2020 00:59:26 +0000 (09:59 +0900)]
Do not call some debugging implementation of deadlock to reduce executing time

Change-Id: I287ab842f2388e49c9da39a04546e50a573b0da9

4 years agoDisable the signal handler of client 86/229686/2
YoungHun Kim [Thu, 2 Apr 2020 23:44:20 +0000 (08:44 +0900)]
Disable the signal handler of client

Change-Id: Ib17a9424edd893f96f757d80cd627d6199354a29

4 years agofixup! Send sigabrt to debug what the server is not ready 62/229362/1 accepted/tizen/unified/20200402.155549 submit/tizen/20200331.061908 submit/tizen/20200401.045159 submit/tizen/20200401.115321
YoungHun Kim [Tue, 31 Mar 2020 09:42:41 +0000 (18:42 +0900)]
fixup! Send sigabrt to debug what the server is not ready

Change-Id: I1064839f86a9f11f86c9fb764cb4304c9b5cc3a3

4 years agoSend sigabrt to debug what the server is not ready 12/229312/1
YoungHun Kim [Tue, 31 Mar 2020 06:08:36 +0000 (15:08 +0900)]
Send sigabrt to debug what the server is not ready

Change-Id: I29b6da8faaa395381094a20ee27faa3357ca7a45

4 years agoRevert "Call shutdown command explicitly to release client resources in signal handler" 07/229307/2
YoungHun Kim [Tue, 31 Mar 2020 05:50:40 +0000 (05:50 +0000)]
Revert "Call shutdown command explicitly to release client resources in signal handler"

This reverts commit ebde40ec0da37da3239506d9812b0d181a9ef83e.

Change-Id: Ie74328f78385b3100bd8e9f18ac74a8ab8c43ca9

4 years agoFix the bug related with muse_server_is_ready() 38/228438/6 accepted/tizen/unified/20200324.101543 submit/tizen/20200323.075436 submit/tizen/20200323.230834
YoungHun Kim [Mon, 23 Mar 2020 05:58:55 +0000 (14:58 +0900)]
Fix the bug related with muse_server_is_ready()

Change-Id: I8b0474bb7cecb5422328dbf56c9de38cc22faafd

4 years agoCall shutdown command explicitly to release client resources in signal handler 42/228142/5 accepted/tizen/unified/20200321.043816 submit/tizen/20200320.024643
YoungHun Kim [Thu, 19 Mar 2020 08:05:13 +0000 (17:05 +0900)]
Call shutdown command explicitly to release client resources in signal handler

Change-Id: I8112fc27468dc15a194755e8f2020d9bc879fd88

4 years agoAdd feature for preloading plugins for GStreamer 66/227066/3 accepted/tizen/unified/20200315.214816 submit/tizen/20200311.020132 submit/tizen/20200311.030158 submit/tizen/20200312.062225
Jeongmo Yang [Mon, 9 Mar 2020 09:40:33 +0000 (18:40 +0900)]
Add feature for preloading plugins for GStreamer

- Currently, we should describe full path of plugins in mused.conf file,
  but, this patch simplifies it like below.

  As-Is:
  gstparam3=--gst-plugin-load=/usr/lib/gstreamer-1.0/libgstcoreelements.so

  To-Be:
  gstpreload=coreelements

[Version] 0.3.103
[Profile] Common
[Issue Type] Update

Change-Id: I4eab3a3e7ce65c19387d66ad773633cc5fb82f8f
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agoReturn FALSE so that source callback is not maintained when an exception occurs 22/227022/1 accepted/tizen/unified/20200309.215640 submit/tizen/20200309.061014 submit/tizen/20200309.070913
YoungHun Kim [Mon, 9 Mar 2020 05:25:26 +0000 (14:25 +0900)]
Return FALSE so that source callback is not maintained when an exception occurs

Change-Id: I5bbd839be999796435db171eac753be974e23801

4 years agoChange to preload module after gst_init call 81/226981/1 submit/tizen/20200309.023200
YoungHun Kim [Sun, 8 Mar 2020 23:09:34 +0000 (08:09 +0900)]
Change to preload module after gst_init call

Change-Id: I2dbecf832745e0e5d15d7efbf820a08aab7b220f

4 years agoUpdate coding rule of muse 00/225300/2 accepted/tizen/unified/20200224.081458 submit/tizen/20200221.062926
YoungHun Kim [Wed, 19 Feb 2020 02:25:52 +0000 (11:25 +0900)]
Update coding rule of muse

 - Set max colume value as 128
 - Set tab space as 4

Change-Id: I569b7f7e69be28c1b7bbdbaeb1af89d274e1f5f6

4 years agoAdd api name information in dispatcher deadlock 99/225299/2
YoungHun Kim [Wed, 19 Feb 2020 02:22:32 +0000 (11:22 +0900)]
Add api name information in dispatcher deadlock

Change-Id: I4e8a0e182369bdd4a42890e0b872b17445ae6afa

4 years agoMaking variables to static 20/223720/2 accepted/tizen/unified/20200204.125748 submit/tizen/20200204.004309
hj kim [Mon, 3 Feb 2020 08:05:05 +0000 (17:05 +0900)]
Making variables to static

Change-Id: I578014b01c3d50502aeca8aceb043d07c5d8c4d8

4 years agoFix SVACE (DEREF_OF_NULL.RET.STAT) issue 92/223592/2 accepted/tizen/unified/20200203.125758 submit/tizen/20200131.071650
YoungHun Kim [Fri, 31 Jan 2020 05:10:49 +0000 (14:10 +0900)]
Fix SVACE (DEREF_OF_NULL.RET.STAT) issue

Change-Id: I1cfb26c4308b296144624dfa5049a5a2e5522053

4 years agoFix build error due to iniparser upgrade 28/221928/3 accepted/tizen/unified/20200114.130752 submit/tizen/20200108.113227 submit/tizen/20200109.104649
YoungHun Kim [Wed, 8 Jan 2020 08:52:01 +0000 (17:52 +0900)]
Fix build error due to iniparser upgrade

Change-Id: I4cb53b2741448854368607f03fc8c32bcd929f8c

4 years agoMerge "Fix build error due to toolchain upgrade (gcc6->gcc9)" into tizen accepted/tizen/unified/20200113.130724 submit/tizen/20200108.010425
YoungHun Kim [Wed, 8 Jan 2020 01:03:47 +0000 (01:03 +0000)]
Merge "Fix build error due to toolchain upgrade (gcc6->gcc9)" into tizen

4 years agoFix build error due to toolchain upgrade (gcc6->gcc9) 45/221745/4
YoungHun Kim [Tue, 7 Jan 2020 08:17:19 +0000 (17:17 +0900)]
Fix build error due to toolchain upgrade (gcc6->gcc9)

 - Werror=format-truncation, -Werror=cast-function-type

Change-Id: Ieaa02eca90e455610bfea45cfb88ec436faefaec

4 years agoChange the return value to avoid g_source_remove at connection handler when muse... 26/221726/1
YoungHun Kim [Tue, 7 Jan 2020 05:15:30 +0000 (14:15 +0900)]
Change the return value to avoid g_source_remove at connection handler when muse server is not ready

Change-Id: Ide6274b8c67bb10d661ba5c609dea3b623c2ffec

4 years agoMerge "Improvement variable initialization" into tizen accepted/tizen/unified/20191204.130708 submit/tizen/20191204.005847
YoungHun Kim [Wed, 4 Dec 2019 00:55:44 +0000 (00:55 +0000)]
Merge "Improvement variable initialization" into tizen

4 years agoFix the bug of debugging information from fd directory 69/218769/3 accepted/tizen/unified/20191128.161826 submit/tizen/20191128.060302
YoungHun Kim [Thu, 28 Nov 2019 04:41:12 +0000 (13:41 +0900)]
Fix the bug of debugging information from fd directory

Change-Id: I087db4ba66f13c7b7736ec359810d973c40535f8

4 years agoPrint the process information in dispatcher deadlock 48/218748/2
YoungHun Kim [Wed, 27 Nov 2019 23:12:31 +0000 (08:12 +0900)]
Print the process information in dispatcher deadlock

Change-Id: Id3cc060b5e74b4cc8dcdb8cd19fcac2630c61750

4 years agoImprovement variable initialization 81/218681/1
INSUN PYO [Wed, 27 Nov 2019 01:46:41 +0000 (10:46 +0900)]
Improvement variable initialization

Change-Id: I6e27d54859c70120297fe4aab9ba78ce16a566d9

4 years agoChange the value of timeout in case gst_init does not return 06/218306/10 accepted/tizen/unified/20191125.135538 submit/tizen/20191122.052207
YoungHun Kim [Thu, 21 Nov 2019 07:16:37 +0000 (16:16 +0900)]
Change the value of timeout in case gst_init does not return

 - Create the server ready file with g_idle_add
 - Update to check the 'remove' return value and add errno for debugging

Change-Id: I1d92c7b28fd502e0d2dafce4754d0acbe251dec9

5 years ago[VD Req] Do not execute mused in standalone mode 01/217801/3 accepted/tizen/unified/20191120.034451 submit/tizen/20191119.081953
YoungHun Kim [Thu, 14 Nov 2019 08:43:25 +0000 (17:43 +0900)]
[VD Req] Do not execute mused in standalone mode

Change-Id: Ic79c5a91fe890b7ec016b1cb760217f4ce289c8a

5 years agoRemove unnecessary workqueue stuff 04/217504/3 accepted/tizen/unified/20191114.042621 submit/tizen/20191113.065131
Seungbae Shin [Tue, 12 Nov 2019 06:54:16 +0000 (15:54 +0900)]
Remove unnecessary workqueue stuff

Change-Id: If13593ab411f744ae203b6fdbb4e7146feaa9747

5 years agoConsider as normal operation when destroy is executed before job function of data... 72/217472/2 accepted/tizen/unified/20191113.010232 submit/tizen/20191112.062523
YoungHun Kim [Mon, 11 Nov 2019 08:25:29 +0000 (17:25 +0900)]
Consider as normal operation when destroy is executed before job function of data is triggered

Change-Id: I59a9766e50cbe426d71814522e286aa5514dc19a

5 years agoDo not create a dispatcher thread when accessing an invalid fd 36/215536/3 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.022527 accepted/tizen/5.5/unified/mobile/hotfix/20201027.090335 accepted/tizen/unified/20191015.012032 submit/tizen/20191014.103159 submit/tizen_5.5/20191031.000004 submit/tizen_5.5_mobile_hotfix/20201026.185104 tizen_5.5.m2_release
YoungHun Kim [Thu, 10 Oct 2019 08:42:16 +0000 (17:42 +0900)]
Do not create a dispatcher thread when accessing an invalid fd

Change-Id: I82df329239bf6a1965ee770865cbca16522c9f2a

5 years agoAdd workqueue job after confirming that the module is valid 32/214432/11 accepted/tizen/unified/20190925.220406 submit/tizen/20190925.015442
YoungHun Kim [Mon, 23 Sep 2019 04:49:21 +0000 (13:49 +0900)]
Add workqueue job after confirming that the module is valid

Change-Id: Iec473889224723e137fe4bb5a347cb386a6177be

5 years agoAvoid the module access after destroy 36/213736/2 accepted/tizen/unified/20190917.034027 submit/tizen/20190911.082511
YoungHun Kim [Wed, 11 Sep 2019 01:44:51 +0000 (10:44 +0900)]
Avoid the module access after destroy

Change-Id: Id6e5779dc8ef38b4625cd0b8c597ea2a733b2cc9

5 years agoAdd the removed data channel creation 37/213537/1 accepted/tizen/unified/20190909.103549 submit/tizen/20190908.233223
YoungHun Kim [Fri, 6 Sep 2019 09:17:55 +0000 (18:17 +0900)]
Add the removed data channel creation

Change-Id: Iedc071d6465b31bf8a438f87eb5234881e0770c2

5 years agoFix crash when create dispatch is failed 93/212993/1 accepted/tizen/unified/20190830.040814 submit/tizen/20190829.112508
Jeongmo Yang [Thu, 29 Aug 2019 06:35:37 +0000 (15:35 +0900)]
Fix crash when create dispatch is failed

- The mutex is unlocked again after unlocked properly.

[Version] 0.3.87
[Profile] Common
[Issue Type] Bug fix

Change-Id: I352fb09b18cebefa07a413c0e2f2817c170454c6
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
5 years agoCreate the diag thread after daemonizing 01/210201/18 accepted/tizen/unified/20190828.011014 submit/tizen/20190827.081232
YoungHun Kim [Wed, 17 Jul 2019 01:14:47 +0000 (10:14 +0900)]
Create the diag thread after daemonizing

 - remove pid file before entering idle at on-demand
 - update gst parameter log
 - update ms_init and ms_run part
 - move ms prefix function of server.c to server_private.c
 - set server ready after daemonizing

Change-Id: I90c4358ee8f9373f896070d2709df237e7ab03e5

5 years agoUpdate the cyclomatic complexity of SAM violation issues 54/212654/11 submit/tizen/20190827.010208
YoungHun Kim [Mon, 26 Aug 2019 01:56:31 +0000 (10:56 +0900)]
Update the cyclomatic complexity of SAM violation issues

Change-Id: Ia9df682ca22f707276d03ec83636e050fd3d7c15

5 years agoUpdate duplicate part to get JSON value 94/212694/5
YoungHun Kim [Mon, 26 Aug 2019 06:26:35 +0000 (15:26 +0900)]
Update duplicate part to get JSON value

Change-Id: I8a9b16944fdf44fbc705407c9d38c7359256eaaf

5 years agoFix the issue of heap-use-after-free 76/211676/3 accepted/tizen/unified/20190820.115033 submit/tizen/20190808.055627 submit/tizen/20190820.015220
YoungHun Kim [Thu, 8 Aug 2019 04:55:59 +0000 (13:55 +0900)]
Fix the issue of heap-use-after-free

 - Use only the more accurate states than muse running
 - Remove muse running

Change-Id: If19b1beae1a2849876ee1acac3b83384e8132999

5 years agoChange the level of log about instance number and idle memory to warning 07/211307/2 accepted/tizen/unified/20190805.042856 submit/tizen/20190802.063806
YoungHun Kim [Thu, 1 Aug 2019 09:01:00 +0000 (18:01 +0900)]
Change the level of log about instance number and idle memory to warning

Change-Id: Ia98a9162e3b5668c9745a2a5623fb580a40b3707

5 years agoModule without data thread does not execute a data socket close 12/210812/8 accepted/tizen/unified/20190730.224236 submit/tizen/20190729.062055
YoungHun Kim [Thu, 25 Jul 2019 04:38:34 +0000 (13:38 +0900)]
Module without data thread does not execute a data socket close

 - update the thread exit

Change-Id: Ieabaab75cf8166d3942694b42147d4259efecef3