platform/upstream/efl.git
5 years agoefl_ui/item_clickable: mark beta again
Mike Blumenkrantz [Thu, 26 Sep 2019 15:05:02 +0000 (17:05 +0200)]
efl_ui/item_clickable: mark beta again

Summary:
this isn't strictly necessary at the moment

Depends on D10197

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10199

5 years agotheme: add spec documentation for all stabilized theme groups in 1.23
Mike Blumenkrantz [Thu, 26 Sep 2019 15:04:04 +0000 (17:04 +0200)]
theme: add spec documentation for all stabilized theme groups in 1.23

Summary:
this is just output from edje-theme-spec tool. it isn't really enough to
be considered full theme documentation, but it's better than nothing

ref T8231
Depends on D10196

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10197

Change-Id: I79bb8f1ad664172b1dd136cfc071f20a66a7467e

5 years agotheme: remove efl_ui_slider "disabled" styles
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:48 +0000 (17:03 +0200)]
theme: remove efl_ui_slider "disabled" styles

Summary:
these should be handled in the regular theme group, no idea why they
existed
Depends on D10195

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10196

Change-Id: Icf3a44ea37afef6804108971c4a117cd08324cba

5 years agotests/check: add port of check widget mouse testing for efl_ui_check
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:43 +0000 (17:03 +0200)]
tests/check: add port of check widget mouse testing for efl_ui_check

Summary:
coverage++
Depends on D10194

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10195

Change-Id: Iac8dddaa348cc08a6cee94090be35b4bc98d91f3

5 years agoefl_ui/layout: improve error message when theme version parsing fails
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:38 +0000 (17:03 +0200)]
efl_ui/layout: improve error message when theme version parsing fails

Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10194

Change-Id: I21f9bb740ff0316866fd5e0060ef8ed287fa2c97

5 years agoefl_ui/layout: fix shadow warning
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:32 +0000 (17:03 +0200)]
efl_ui/layout: fix shadow warning

Summary:
a variable with the same name is declared above
Depends on D10192

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10193

Change-Id: I8d39246bf4276ce4a6880f214b36bae422f7d7f7

5 years agoefl_ui/layout: use better check for determining whether to defer signals
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:28 +0000 (17:03 +0200)]
efl_ui/layout: use better check for determining whether to defer signals

Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10192

Change-Id: Ida519eed1ac99c8ecc7f07e1ba0ce7583d6110d9

5 years agoeolian: better error message for const on strings
Daniel Kolesa [Thu, 26 Sep 2019 15:33:24 +0000 (17:33 +0200)]
eolian: better error message for const on strings

5 years agoecore-x: protect against accidentally "un-managing" the root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:24 +0000 (11:23 -0400)]
ecore-x: protect against accidentally "un-managing" the root window

Summary:
block calls to XSelectInput with the root window if the root window is
currently being "managed" in-process in order to avoid breaking the
running wm
Depends on D10013

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10014

Change-Id: Ic69aa45cdbf6a9cd125edc32f98b28616af8e709

5 years agoecore-x: add internal function for selecting just properties of root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:12 +0000 (11:23 -0400)]
ecore-x: add internal function for selecting just properties of root window

Summary:
this is just a shortcut for watching properties in the case where no wm is
active in the process
Depends on D10012

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10013

Change-Id: I8d88315a36d8b74e6839d9648f6581a3c3a65875

5 years agoecore-x: track whether ecore-x is internally "managing" the root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:01 +0000 (11:23 -0400)]
ecore-x: track whether ecore-x is internally "managing" the root window

Summary:
when ecore_x_window_manage is called, this is probably only for the case of
managing the root window, i.e., running a window manager. store this state
internally so that we can avoid calling additional XSelectInput later and
fucking up the expected eventing

Depends on D9899

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10012

Change-Id: Iedae76203dc28ad3e496eeaf300513ae423552d6

5 years agoecore-evas/x: detect and track wm existence, apply visibility correctly
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:44 +0000 (11:22 -0400)]
ecore-evas/x: detect and track wm existence, apply visibility correctly

Summary:
this attempts to monitor the _NET_SUPPORTING_WM_CHECK atom to verify whether
a wm exists, and bypasses waiting for a configure event from a nonexistent wm
if the screen is not currently managed

fix T7838

Depends on D10014

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, thierry1970, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7838

Differential Revision: https://phab.enlightenment.org/D9900

Change-Id: Ife7e3217461e06ef5f711d5ee57cf8587c56c137

5 years agoecore-x: fix null derefs in window prop code
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:32 +0000 (11:22 -0400)]
ecore-x: fix null derefs in window prop code

Summary:
handle cases where null params could be passed and cause crashes

@fix

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9899

Change-Id: I784f393ee7f93fb5b1c914dfb5d79f23a6999847

5 years agoefl_mono: remove spurious const
Daniel Kolesa [Thu, 26 Sep 2019 15:17:05 +0000 (17:17 +0200)]
efl_mono: remove spurious const

Change-Id: I9a0442d0d9c8c3e0c801b8f8e2baa38052b528e9

5 years agoefl_core : stabilized Efl.Generic_Model
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:06:15 +0000 (11:06 -0400)]
efl_core : stabilized Efl.Generic_Model

Summary:
stabilzed Efl.Generic_Model

depends on D10188

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10189

Change-Id: I34e7eece539fea71057d1d6e77fffeadddb3cb03

5 years agoefl_ui : stablized Efl.Ui.View
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:05:47 +0000 (11:05 -0400)]
efl_ui : stablized Efl.Ui.View

Summary:
Efl.Ui.View is base infrastructure interface of MVVM.

fixes T7578

Reviewers: zmike, cedric, segfaultxavi, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7578

Differential Revision: https://phab.enlightenment.org/D10188

Change-Id: Iccf2d4faf276d0e454eaf6e95b8335c5f4a3ed5c

5 years agoeolian: rename param direction enum and fields for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:56:13 +0000 (16:56 +0200)]
eolian: rename param direction enum and fields for consistency

Change-Id: I7f3e09d39d32b8dcb3c35ba1085756acb6b90b54

5 years agoeolian: loosen the requirements on API (don't return stringshare)
Daniel Kolesa [Thu, 26 Sep 2019 14:41:31 +0000 (16:41 +0200)]
eolian: loosen the requirements on API (don't return stringshare)

5 years agoeolian: rename event_prefix to event_c_prefix for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:39:56 +0000 (16:39 +0200)]
eolian: rename event_prefix to event_c_prefix for consistency

5 years agoeolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section
Daniel Kolesa [Thu, 26 Sep 2019 14:26:10 +0000 (16:26 +0200)]
eolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section

Change-Id: I71ea138db0959c178c5d496fcdb4a93bbeaceba8

5 years agoefl_ui/item_clickable: fix event info for press events
Mike Blumenkrantz [Thu, 26 Sep 2019 14:15:24 +0000 (10:15 -0400)]
efl_ui/item_clickable: fix event info for press events

this is just a button and not the full clickable struct

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10198

5 years agoeolian: stricter checks for const() validity
Daniel Kolesa [Thu, 26 Sep 2019 13:58:17 +0000 (15:58 +0200)]
eolian: stricter checks for const() validity

5 years agoefl_ui_image: fix a wrong return value of legacy API
WooHyun Jung [Thu, 26 Sep 2019 13:00:09 +0000 (09:00 -0400)]
efl_ui_image: fix a wrong return value of legacy API

Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.

Reviewers: zmike, segfaultxavi, bu5hm4n

Reviewed By: zmike, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10186

Change-Id: I036c10c301d223b4cd1cec0c5ae415f5ad2f9ed3

5 years agoedje_legacy: add validation check to return legacy default value
WooHyun Jung [Thu, 26 Sep 2019 12:59:31 +0000 (08:59 -0400)]
edje_legacy: add validation check to return legacy default value

Summary:
When invalid object comes, the return value should be
EINA_FALSE.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10185

Change-Id: Ib2f71f30594bbf02434c6ee4accceb091a65c90d

5 years agoefl_ui_win: add validation check to return legacy default value
WooHyun Jung [Thu, 26 Sep 2019 12:59:28 +0000 (08:59 -0400)]
efl_ui_win: add validation check to return legacy default value

Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10187

Change-Id: Ia7e1f46f9f089afc237557ca64ab857317a20253

5 years agoefl: mark selectable stable
Marcel Hollerbach [Thu, 26 Sep 2019 10:49:20 +0000 (12:49 +0200)]
efl: mark selectable stable

Summary:
fixes T7871
fixes T7852

This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.

Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike

Reviewed By: segfaultxavi

Subscribers: SanghyeonLee, cedric

Tags: #efl

Maniphest Tasks: T7871, T7852

Differential Revision: https://phab.enlightenment.org/D10184

Change-Id: I734b272411e3fc9ebb79d907f171528849219c10

5 years agoatspi: add stop reading command 40/213540/3
Radoslaw Cybulski [Fri, 6 Sep 2019 09:54:20 +0000 (11:54 +0200)]
atspi: add stop reading command

Adds stop reading command over dbus, which cancels all quened readings
(including one in progress if any). Additional passed argument, boolean
flag, when set to false limits cancelling only to discardable readings.

Change-Id: I1ff8571edbaf0513da9d710c9eea16846aba62d4

5 years agoevas_events: fix usage of last mouse 05/214705/2
Hosang Kim [Wed, 25 Sep 2019 09:33:00 +0000 (18:33 +0900)]
evas_events: fix usage of last mouse

Change-Id: Ifa21646cf43f969c347ca7fe4127309f2920ddf4

5 years agobuild: resolve migration build errors submit/tizen/20190926.223052
Jongmin Lee [Thu, 26 Sep 2019 21:57:18 +0000 (06:57 +0900)]
build: resolve migration build errors

Change-Id: I588c4a50424c77b980136c89b31a25d28c452c68

5 years agoefl_ui/item_clickable: mark beta again
Mike Blumenkrantz [Thu, 26 Sep 2019 15:05:02 +0000 (17:05 +0200)]
efl_ui/item_clickable: mark beta again

Summary:
this isn't strictly necessary at the moment

Depends on D10197

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10199

5 years agotheme: add spec documentation for all stabilized theme groups in 1.23
Mike Blumenkrantz [Thu, 26 Sep 2019 15:04:04 +0000 (17:04 +0200)]
theme: add spec documentation for all stabilized theme groups in 1.23

Summary:
this is just output from edje-theme-spec tool. it isn't really enough to
be considered full theme documentation, but it's better than nothing

ref T8231
Depends on D10196

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10197

5 years agotheme: remove efl_ui_slider "disabled" styles
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:48 +0000 (17:03 +0200)]
theme: remove efl_ui_slider "disabled" styles

Summary:
these should be handled in the regular theme group, no idea why they
existed
Depends on D10195

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10196

5 years agotests/check: add port of check widget mouse testing for efl_ui_check
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:43 +0000 (17:03 +0200)]
tests/check: add port of check widget mouse testing for efl_ui_check

Summary:
coverage++
Depends on D10194

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10195

5 years agoefl_ui/layout: improve error message when theme version parsing fails
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:38 +0000 (17:03 +0200)]
efl_ui/layout: improve error message when theme version parsing fails

Summary:
be very explicit here so that users can immediately know how to resolve
the issue
Depends on D10193

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10194

5 years agoefl_ui/layout: fix shadow warning
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:32 +0000 (17:03 +0200)]
efl_ui/layout: fix shadow warning

Summary:
a variable with the same name is declared above
Depends on D10192

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10193

5 years agoefl_ui/layout: use better check for determining whether to defer signals
Mike Blumenkrantz [Thu, 26 Sep 2019 15:03:28 +0000 (17:03 +0200)]
efl_ui/layout: use better check for determining whether to defer signals

Summary:
a layout (not layout_base) should not defer signals. theme groups loaded
by a layout widget can be anything, and are not subject to the versioning
requirements that efl widgets have
Depends on D10055

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10192

5 years agoeolian: better error message for const on strings
Daniel Kolesa [Thu, 26 Sep 2019 15:33:24 +0000 (17:33 +0200)]
eolian: better error message for const on strings

5 years agoecore-x: protect against accidentally "un-managing" the root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:24 +0000 (11:23 -0400)]
ecore-x: protect against accidentally "un-managing" the root window

Summary:
block calls to XSelectInput with the root window if the root window is
currently being "managed" in-process in order to avoid breaking the
running wm
Depends on D10013

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10014

5 years agoecore-x: add internal function for selecting just properties of root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:12 +0000 (11:23 -0400)]
ecore-x: add internal function for selecting just properties of root window

Summary:
this is just a shortcut for watching properties in the case where no wm is
active in the process
Depends on D10012

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10013

5 years agoecore-x: track whether ecore-x is internally "managing" the root window
Mike Blumenkrantz [Thu, 26 Sep 2019 15:23:01 +0000 (11:23 -0400)]
ecore-x: track whether ecore-x is internally "managing" the root window

Summary:
when ecore_x_window_manage is called, this is probably only for the case of
managing the root window, i.e., running a window manager. store this state
internally so that we can avoid calling additional XSelectInput later and
fucking up the expected eventing

Depends on D9899

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10012

5 years agoecore-evas/x: detect and track wm existence, apply visibility correctly
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:44 +0000 (11:22 -0400)]
ecore-evas/x: detect and track wm existence, apply visibility correctly

Summary:
this attempts to monitor the _NET_SUPPORTING_WM_CHECK atom to verify whether
a wm exists, and bypasses waiting for a configure event from a nonexistent wm
if the screen is not currently managed

fix T7838

Depends on D10014

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, thierry1970, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7838

Differential Revision: https://phab.enlightenment.org/D9900

5 years agoecore-x: fix null derefs in window prop code
Mike Blumenkrantz [Thu, 26 Sep 2019 15:22:32 +0000 (11:22 -0400)]
ecore-x: fix null derefs in window prop code

Summary:
handle cases where null params could be passed and cause crashes

@fix

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9899

5 years agoefl_mono: remove spurious const
Daniel Kolesa [Thu, 26 Sep 2019 15:17:05 +0000 (17:17 +0200)]
efl_mono: remove spurious const

5 years agoefl_core : stabilized Efl.Generic_Model
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:06:15 +0000 (11:06 -0400)]
efl_core : stabilized Efl.Generic_Model

Summary:
stabilzed Efl.Generic_Model

depends on D10188

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10189

5 years agoefl_ui : stablized Efl.Ui.View
SangHyeon Jade Lee [Thu, 26 Sep 2019 15:05:47 +0000 (11:05 -0400)]
efl_ui : stablized Efl.Ui.View

Summary:
Efl.Ui.View is base infrastructure interface of MVVM.

fixes T7578

Reviewers: zmike, cedric, segfaultxavi, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7578

Differential Revision: https://phab.enlightenment.org/D10188

5 years agoeolian: rename param direction enum and fields for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:56:13 +0000 (16:56 +0200)]
eolian: rename param direction enum and fields for consistency

5 years agoeolian: loosen the requirements on API (don't return stringshare)
Daniel Kolesa [Thu, 26 Sep 2019 14:41:31 +0000 (16:41 +0200)]
eolian: loosen the requirements on API (don't return stringshare)

5 years agoeolian: rename event_prefix to event_c_prefix for consistency
Daniel Kolesa [Thu, 26 Sep 2019 14:39:56 +0000 (16:39 +0200)]
eolian: rename event_prefix to event_c_prefix for consistency

5 years agoeolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section
Daniel Kolesa [Thu, 26 Sep 2019 14:26:10 +0000 (16:26 +0200)]
eolian: move EOLIAN_TYPE_BUILTIN_HASH into beta section

5 years agoefl_ui/item_clickable: fix event info for press events
Mike Blumenkrantz [Thu, 26 Sep 2019 14:15:24 +0000 (10:15 -0400)]
efl_ui/item_clickable: fix event info for press events

this is just a button and not the full clickable struct

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10198

5 years agoeolian: stricter checks for const() validity
Daniel Kolesa [Thu, 26 Sep 2019 13:58:17 +0000 (15:58 +0200)]
eolian: stricter checks for const() validity

5 years agoefl_ui_image: fix a wrong return value of legacy API
WooHyun Jung [Thu, 26 Sep 2019 13:00:09 +0000 (09:00 -0400)]
efl_ui_image: fix a wrong return value of legacy API

Summary:
elm_image_animated_play_get needs to return opposite
value of animated_PAUSED_get.

Reviewers: zmike, segfaultxavi, bu5hm4n

Reviewed By: zmike, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10186

Change-Id: If8039795398b3681c7329d8103d196d02393612b

5 years agoedje_legacy: add validation check to return legacy default value
WooHyun Jung [Thu, 26 Sep 2019 12:59:31 +0000 (08:59 -0400)]
edje_legacy: add validation check to return legacy default value

Summary:
When invalid object comes, the return value should be
EINA_FALSE.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10185

Change-Id: I3b2434528d68e8570308b25049442d07f4174a86

5 years agoefl_ui_win: add validation check to return legacy default value
WooHyun Jung [Thu, 26 Sep 2019 12:59:28 +0000 (08:59 -0400)]
efl_ui_win: add validation check to return legacy default value

Summary:
elm_win_type_get needs to return ELM_WIN_UNKNOWN when
invalid object comes.

Reviewers: zmike, bu5hm4n, segfaultxavi

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10187

Change-Id: I27ae9dcc4030b26ffc124f11a66c4fc7bf1436e9

5 years agoefl: mark selectable stable
Marcel Hollerbach [Thu, 26 Sep 2019 10:49:20 +0000 (12:49 +0200)]
efl: mark selectable stable

Summary:
fixes T7871
fixes T7852

This also works arround a eolian issue where composites do not mark the
inherited API from the composites as implemented.

Reviewers: SanghyeonLee, cedric, segfaultxavi, zmike

Reviewed By: segfaultxavi

Subscribers: SanghyeonLee, cedric

Tags: #efl

Maniphest Tasks: T7871, T7852

Differential Revision: https://phab.enlightenment.org/D10184

5 years agoefl_ui_*selectable: unify these APIs with the same c_prefix
Marcel Hollerbach [Thu, 26 Sep 2019 09:16:24 +0000 (18:16 +0900)]
efl_ui_*selectable: unify these APIs with the same c_prefix

Summary:
with this commit that api for single and multi selectable shares the
same prefix, which makes sense in c as we do not really differ between
those two types there anyway.

ref T7871

Reviewers: SanghyeonLee, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7871

Differential Revision: https://phab.enlightenment.org/D10183

5 years agoefl_ui : add document comment on efl_ui_item_clickable event data
SangHyeon Jade Lee [Thu, 26 Sep 2019 08:38:37 +0000 (10:38 +0200)]
efl_ui : add document comment on efl_ui_item_clickable event data

Summary: Add document comment on Efl_Ui_Item_Clickable.Clickable_Clicked.

Reviewers: cedric, zmike, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10181

5 years agoelementary: stabilize Efl.Ui.Item_Clickable.
Cedric Bail [Thu, 26 Sep 2019 01:59:29 +0000 (21:59 -0400)]
elementary: stabilize Efl.Ui.Item_Clickable.

Summary: Depends on D10177

Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10173

5 years agoelementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.
Cedric Bail [Thu, 26 Sep 2019 01:59:25 +0000 (21:59 -0400)]
elementary: forward Efl.Input.Clickable event to Efl.Ui.Collection* event.

Summary: Depends on D10176

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10177

5 years agoelementary: temporary workaround include issue that prevent acces to Evas_Eo.h
Cedric Bail [Thu, 26 Sep 2019 01:59:20 +0000 (21:59 -0400)]
elementary: temporary workaround include issue that prevent acces to Evas_Eo.h

Summary: Depends on D10175

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10176

5 years agoelementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable
Cedric Bail [Thu, 26 Sep 2019 01:59:14 +0000 (21:59 -0400)]
elementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable

Summary: Depends on D10171

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8266

Differential Revision: https://phab.enlightenment.org/D10175

5 years agoelementary: stabilize Efl.Ui.Collection_View.
Cedric Bail [Thu, 26 Sep 2019 01:59:09 +0000 (21:59 -0400)]
elementary: stabilize Efl.Ui.Collection_View.

Reviewers: zmike, bu5hm4n, segfaultxavi, lauromoura, SanghyeonLee, felipealmeida

Reviewed By: zmike, SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8261

Differential Revision: https://phab.enlightenment.org/D10171

5 years agoapi: mark Efl.Ui.Image_Zoomable stable
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:38 +0000 (17:56 -0400)]
api: mark Efl.Ui.Image_Zoomable stable

Summary:
ref T7875
Depends on D10125

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7875

Differential Revision: https://phab.enlightenment.org/D10126

5 years agoapi: mark Efl.Gfx.Image_Load_Controller stable
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:33 +0000 (17:56 -0400)]
api: mark Efl.Gfx.Image_Load_Controller stable

Summary:
fix T7876
Depends on D10124

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7876

Differential Revision: https://phab.enlightenment.org/D10125

5 years agoapi: mark efl.gfx.image and related types stable
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:29 +0000 (17:56 -0400)]
api: mark efl.gfx.image and related types stable

Summary:
fix T7875
fix T7926
fix T7927
fix T7926
fix T7929

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl_api

Maniphest Tasks: T7929, T7927, T7926, T7875

Differential Revision: https://phab.enlightenment.org/D10124

5 years agotheme: migrate all efl,anim,activate (and similar) signals to efl,state,animation...
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:17 +0000 (17:56 -0400)]
theme: migrate all efl,anim,activate (and similar) signals to efl,state,animation,activated

Summary:
ref T8231
Depends on D10166

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10167

5 years agotheme: efl,state,anim,stop -> efl,state,animating,stopped
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:11 +0000 (17:56 -0400)]
theme: efl,state,anim,stop -> efl,state,animating,stopped

Summary:
ref T8231
Depends on D10165

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10166

5 years agoapi: efl,state,busy,(start|stop) -> efl,state,busy,(started|stopped)
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:06 +0000 (17:56 -0400)]
api: efl,state,busy,(start|stop) -> efl,state,busy,(started|stopped)

Summary:
ref T8231
Depends on D10163

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10165

5 years agotheme: remove unused scroller group
Mike Blumenkrantz [Wed, 25 Sep 2019 21:56:01 +0000 (17:56 -0400)]
theme: remove unused scroller group

Summary:
this is just copied from legacy but not used for anything

ref T8231
Depends on D10162

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10163

5 years agotheme: use more explicit signal names for C <- theme scrollbar signals
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:55 +0000 (17:55 -0400)]
theme: use more explicit signal names for C <- theme scrollbar signals

Summary:
ref T8231

Depends on D10161

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10162

5 years agotheme: efl,action,clicked -> efl,action,click
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:50 +0000 (17:55 -0400)]
theme: efl,action,clicked -> efl,action,click

Summary:
action signals should infinitives

ref T8231
Depends on D10160

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10161

5 years agotheme: use more explicit signal names for C -> theme scrollbar signals
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:45 +0000 (17:55 -0400)]
theme: use more explicit signal names for C -> theme scrollbar signals

Summary:
ref T8231

Depends on D10159

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10160

5 years agotheme: use 'visible' style signals for spin_button button/entry visibility
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:40 +0000 (17:55 -0400)]
theme: use 'visible' style signals for spin_button button/entry visibility

Summary:
ref T8231
Depends on D10158

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10159

5 years agotheme: efl,state,(content|text),(set|unset) -> efl,(content|text),(set|unset)
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:35 +0000 (17:55 -0400)]
theme: efl,state,(content|text),(set|unset) -> efl,(content|text),(set|unset)

Summary:
this is versioned, so the correct signal will always be emitted for the theme
version that is provided

ref T8231

Depends on D10164

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10158

5 years agoefl_ui/layout: add mechanism for deferring versioned theme signals
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:29 +0000 (17:55 -0400)]
efl_ui/layout: add mechanism for deferring versioned theme signals

Summary:
the theme version isn't available until the theme has been applied, so
we can create an array of all the pending signals and defer them until
such time as we get a theme or destroy the object

this is internal and can be reworked at a later time as needed

ref T8231

Depends on D10157

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10164

5 years agoapi: move eo-based radio and check widgets to use selectable signal names
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:24 +0000 (17:55 -0400)]
api: move eo-based radio and check widgets to use selectable signal names

Summary:
this is a more standardized name

ref T8231

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10157

5 years agotheme: /efl,orient,(horizontal|vertical)/efl,state,(horizontal|vertical)/
Mike Blumenkrantz [Wed, 25 Sep 2019 21:55:19 +0000 (17:55 -0400)]
theme: /efl,orient,(horizontal|vertical)/efl,state,(horizontal|vertical)/

Summary:
these signals aren't actually used by anything, just changing for grep

ref T8231

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10156

5 years agoefl_ui_win: add validation check to return legacy default value 01/214801/2 accepted/tizen/unified/20190927.064519 submit/tizen/20190926.103214
WooHyun Jung [Thu, 26 Sep 2019 10:27:09 +0000 (19:27 +0900)]
efl_ui_win: add validation check to return legacy default value

This should be reverted when https://phab.enlightenment.org/D10187
is updated.

@tizen_fix

Change-Id: I990dab1313aebdfde2a8cc1e9b89d2fff0983863

5 years agoefl_ui_image: fix a wrong return value of legacy API 00/214800/1
WooHyun Jung [Thu, 26 Sep 2019 10:26:08 +0000 (19:26 +0900)]
efl_ui_image: fix a wrong return value of legacy API

This should be reverted when https://phab.enlightenment.org/D10186
is updated.

@tizen_fix

Change-Id: Ifdfbd9685f13ea428661c3644cd708fac2e8ec3d

5 years agoedje_legacy: add validation check to return legacy default value 99/214799/1
WooHyun Jung [Thu, 26 Sep 2019 10:24:24 +0000 (19:24 +0900)]
edje_legacy: add validation check to return legacy default value

This should be reverted when https://phab.enlightenment.org/D10185
is updated

@tizen_fix

Change-Id: I8e42c74420d2cf0ea218ca3ae29d2480663538f1

5 years agoRevert "slider: delete unnecessary tizen only code" 89/214789/1
WooHyun Jung [Thu, 26 Sep 2019 08:11:05 +0000 (17:11 +0900)]
Revert "slider: delete unnecessary tizen only code"

This reverts commit c8633f099a438b1f99ae94d350b3554b0ded218a.

Change-Id: Ib2e87a3ceeec4fec7d164f9b9aed862873fbee66

5 years agobulild: resolve build error caused by te use of efl_player_start/stop API submit/tizen/20190925.214157
Jongmin Lee [Wed, 25 Sep 2019 21:36:28 +0000 (06:36 +0900)]
bulild: resolve build error caused by te use of efl_player_start/stop API

change the use of efl_player_start/stop to efl_player_playing_set

Change-Id: I7ece1dc749716bcd4b4caaa49656e139a07864ce

5 years agoecore: stabilize Efl.Loop_Model
Cedric Bail [Wed, 25 Sep 2019 15:05:38 +0000 (12:05 -0300)]
ecore: stabilize Efl.Loop_Model

Summary:
T8270
Depends on D10138

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7885

Differential Revision: https://phab.enlightenment.org/D10139

5 years agoecore: stabilize Efl.Composite_Model.
Cedric Bail [Wed, 25 Sep 2019 15:03:27 +0000 (12:03 -0300)]
ecore: stabilize Efl.Composite_Model.

Summary: Depends on D10137

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7885

Differential Revision: https://phab.enlightenment.org/D10138

5 years agoelementary: stabilize Efl.Ui.View_Model
Cedric Bail [Wed, 25 Sep 2019 15:02:14 +0000 (12:02 -0300)]
elementary: stabilize Efl.Ui.View_Model

Summary:
T8268
Depends on D10136

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7885

Differential Revision: https://phab.enlightenment.org/D10137

5 years agoefl: stabilize Efl.Model
Cedric Bail [Wed, 25 Sep 2019 15:00:28 +0000 (12:00 -0300)]
efl: stabilize Efl.Model

Summary:
T8267
Depends on D10135

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7885

Differential Revision: https://phab.enlightenment.org/D10136

5 years agoefl: stabilize Efl.Ui.Factory_Bind
Cedric Bail [Wed, 25 Sep 2019 14:59:45 +0000 (11:59 -0300)]
efl: stabilize Efl.Ui.Factory_Bind

Summary:
T8264
Depends on D10134

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7885

Differential Revision: https://phab.enlightenment.org/D10135

5 years agoefl: stabilize Efl.Ui.Property_Bind
Cedric Bail [Wed, 25 Sep 2019 14:56:54 +0000 (11:56 -0300)]
efl: stabilize Efl.Ui.Property_Bind

Summary:
T7579
Depends on D10133

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7885

Differential Revision: https://phab.enlightenment.org/D10134

5 years agoefl: stabilize Efl.Ui.Factory.
Cedric Bail [Wed, 25 Sep 2019 14:55:30 +0000 (11:55 -0300)]
efl: stabilize Efl.Ui.Factory.

Summary:
T8262
Depends on D10132

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7885

Differential Revision: https://phab.enlightenment.org/D10133

5 years agoelementary: stabilize Efl.Ui.Widget_Factory.
Cedric Bail [Wed, 25 Sep 2019 14:45:38 +0000 (11:45 -0300)]
elementary: stabilize Efl.Ui.Widget_Factory.

Summary:
T8271
Depends on D10130

Reviewers: zmike, segfaultxavi, bu5hm4n, SanghyeonLee, lauromoura, felipealmeida

Reviewed By: SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7885

Differential Revision: https://phab.enlightenment.org/D10131

5 years agoelm: Avoid maybe unitialized variable accesses
Lauro Moura [Wed, 25 Sep 2019 20:15:43 +0000 (16:15 -0400)]
elm: Avoid maybe unitialized variable accesses

Reviewers: cedric, bu5hm4n, zmike, felipealmeida

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10170

5 years agoefl: improve error message to be really useful.
Cedric Bail [Wed, 25 Sep 2019 19:50:35 +0000 (15:50 -0400)]
efl: improve error message to be really useful.

Reviewers: zmike, bu5hm4n

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10168

5 years agoRevert "elm: add basics test to create a destroy *every* widget with errors"
Marcel Hollerbach [Wed, 25 Sep 2019 19:46:54 +0000 (21:46 +0200)]
Revert "elm: add basics test to create a destroy *every* widget with errors"

This reverts commit 10cdb070180e0f1e62d5b8e5d5164a19fbc51548.

this does not pass on ci ... o.O

5 years agoefl_ui : change selected_items_get to selected_iterator_new.
SangHyeon Jade Lee [Wed, 25 Sep 2019 10:57:03 +0000 (10:57 +0000)]
efl_ui : change selected_items_get to selected_iterator_new.

multi_selectable_aync already changed name as
selected_iterator_new
so multi_selectable change name also for unity of API.

not sure about we need unselected_items_get in multi_selectable,
so skip to create new api for this time.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10148

5 years agoelm: add basics test to create a destroy *every* widget with errors
Marcel Hollerbach [Mon, 23 Sep 2019 18:43:47 +0000 (20:43 +0200)]
elm: add basics test to create a destroy *every* widget with errors

this simply creates packs, resizes, and destroys every single widget
that we have in legacy elm.

This i made to ensure that there are no mistakes in the construction
chain. Additionally, a second test case checks that creation with none
elm parents is erroring but not failing, this seems weird, but we have
provided that in the past, so we should continue providing this.

Differential Revision: https://phab.enlightenment.org/D10088

5 years agoelementary: properly mark iterator usage in Efl.Ui.Factory.
Cedric Bail [Tue, 24 Sep 2019 23:48:31 +0000 (16:48 -0700)]
elementary: properly mark iterator usage in Efl.Ui.Factory.

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10132

5 years agoelementary: return an error when unimplemented function on Efl.Ui.Widget_Factory.
Cedric Bail [Wed, 25 Sep 2019 16:52:18 +0000 (16:52 +0000)]
elementary: return an error when unimplemented function on Efl.Ui.Widget_Factory.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10130

5 years agoelementary: add support for default property on item being created by Efl.Ui.Widget_F...
Cedric Bail [Wed, 25 Sep 2019 00:13:49 +0000 (17:13 -0700)]
elementary: add support for default property on item being created by Efl.Ui.Widget_Factory.

Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10129

5 years agoefl_ui/image: fix playback_speed timer calcs
Mike Blumenkrantz [Wed, 25 Sep 2019 10:47:49 +0000 (06:47 -0400)]
efl_ui/image: fix playback_speed timer calcs

I accidentally inverted this; the frame timing needs to be divided by
the playback speed to have the correct time here

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10147

5 years agoefl_ui/layout: add explicit error case when theme version > efl version
Mike Blumenkrantz [Wed, 25 Sep 2019 11:30:24 +0000 (07:30 -0400)]
efl_ui/layout: add explicit error case when theme version > efl version

it's important to handle cases where a "future" theme is trying to be used
by "current" efl. this throws a serious error, since it's possible that the
widget may look/act in a way that makes it unusable

ref T8231

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10153