River Riddle [Wed, 2 Feb 2022 18:24:43 +0000 (10:24 -0800)]
[mlir][NFC] Update PDL operations to use `hasVerifier` instead of `verifier`
The verifier field is deprecated, and slated for removal.
Differential Revision: https://reviews.llvm.org/D118828
River Riddle [Wed, 2 Feb 2022 18:24:22 +0000 (10:24 -0800)]
[mlir][NFC] Update GPU/SCF operations to use `hasVerifier` instead of `verifier`
The verifier field is deprecated, and slated for removal.
Differential Revision: https://reviews.llvm.org/D118827
River Riddle [Wed, 2 Feb 2022 18:23:28 +0000 (10:23 -0800)]
[mlir][NFC] Update Affine operations to use `hasVerifier` instead of `verifier`
The verifier field is deprecated, and slated for removal.
Differential Revision: https://reviews.llvm.org/D118826
River Riddle [Wed, 2 Feb 2022 18:22:57 +0000 (10:22 -0800)]
[mlir][NFC] Update OpenACC/OpenMP operations to use `hasVerifier` instead of `verifier`
The verifier field is deprecated, and slated for removal.
Differential Revision: https://reviews.llvm.org/D118825
River Riddle [Wed, 2 Feb 2022 18:18:06 +0000 (10:18 -0800)]
[mlir][NFC] Update MemRef/Tensor operations to use `hasVerifier` instead of `verifier`
The verifier field is deprecated, and slated for removal.
Differential Revision: https://reviews.llvm.org/D118821
River Riddle [Wed, 2 Feb 2022 18:17:02 +0000 (10:17 -0800)]
[mlir][NFC] Update Vector operations to use `hasVerifier` instead of `verifier`
The verifier field is deprecated, and slated for removal.
Differential Revision: https://reviews.llvm.org/D118820
River Riddle [Wed, 2 Feb 2022 18:16:28 +0000 (10:16 -0800)]
[mlir][NFC] Update AMX/LLVM/NVVM/X86 vector operations to use `hasVerifier` instead of `verifier`
The verifier field is deprecated, and slated for removal.
Differential Revision: https://reviews.llvm.org/D118819
River Riddle [Wed, 2 Feb 2022 18:06:30 +0000 (10:06 -0800)]
[mlir][NFC] Update SPIRV operations to use `hasVerifier` instead of `verifier`
The verifier field is deprecated, and slated for removal.
Differential Revision: https://reviews.llvm.org/D118817
River Riddle [Wed, 2 Feb 2022 18:05:01 +0000 (10:05 -0800)]
[mlir][NFC] Update Toy operations to use `hasVerifier` instead of `verifier`
The verifier field is deprecated, and slated for removal.
Differential Revision: https://reviews.llvm.org/D118816
River Riddle [Tue, 1 Feb 2022 23:01:30 +0000 (15:01 -0800)]
[mlir] Refactor how additional verification is specified in ODS
Currently if an operation requires additional verification, it specifies an inline
code block (`let verifier = "blah"`). This is quite problematic for various reasons, e.g.
it requires defining C++ inside of Tablegen which is discouraged when possible, but mainly because
nearly all usages simply forward to a static function `static LogicalResult verify(SomeOp op)`.
This commit adds support for a `hasVerifier` bit field that specifies if an additional verifier
is needed, and when set to `1` declares a `LogicalResult verify()` method for operations to
override. For migration purposes, the existing behavior is untouched. Upstream usages will
be replaced in a followup to keep this patch focused on the hasVerifier implementation.
One main user facing change is that what was one `MyOp::verify` is now `MyOp::verifyInvariants`.
This better matches the name this method is called everywhere else, and also frees up `verify` for
the user defined additional verification. The `verify` function when generated now (for additional
verification) is private to the operation class, which should also help avoid accidental usages after
this switch.
Differential Revision: https://reviews.llvm.org/D118742
Konstantin Varlamov [Wed, 2 Feb 2022 21:32:23 +0000 (13:32 -0800)]
[libc++][ranges][NFC] Small updates to the Ranges status page:
- note that `split_view` has been renamed to `lazy_split_view`.
- fix formatting.
LLVM GN Syncbot [Wed, 2 Feb 2022 21:28:57 +0000 (21:28 +0000)]
[gn build] Port
712b31e2d4dc
Konstantin Varlamov [Wed, 2 Feb 2022 21:27:28 +0000 (13:27 -0800)]
[libc++][ranges] Implement `indirectly_copyable{,_storable}`.
Also refactor tests for `indirectly_movable{,_storable}`.
Differential Revision: https://reviews.llvm.org/D118432
Florian Mayer [Wed, 2 Feb 2022 01:05:37 +0000 (17:05 -0800)]
[NFC] factor isStandardLifetime out of HWASan
this is so we can use it for aarch64 stack tagging.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D118836
Konstantin Varlamov [Wed, 2 Feb 2022 21:14:57 +0000 (13:14 -0800)]
[libc++][ranges][NFC] In the Ranges status, mark move_sentinel as "in progress"
Zahira Ammarguellat [Wed, 2 Feb 2022 19:28:44 +0000 (11:28 -0800)]
The methods visited for a special class must have an identifier.
Peter Klausler [Fri, 28 Jan 2022 23:34:28 +0000 (15:34 -0800)]
[flang] Debugging of ACCESS='STREAM' I/O
Corrects the runtime implementation of I/O on files with
the access mode ACCESS='STREAM'. This is a collection
of edge-case tweaks to ensure that the distinctions between
stream and direct/sequential files, unformatted or formatted,
are respected where appropriate.
Moves NextInField() from io-stmt.h to io-stmt.cpp --
it was getting too big to keep in a header.
Differential Revision: https://reviews.llvm.org/D118834
Jeremy Morse [Wed, 2 Feb 2022 21:00:20 +0000 (21:00 +0000)]
Follow up to
6e03a68b776dc, squelch another leak
This patch is a sticking-paster until D118774 solves the situation with
unique_ptrs. I'm certainly wishing I'd focused on that first X_X.
Konstantin Varlamov [Wed, 2 Feb 2022 20:54:29 +0000 (12:54 -0800)]
[libc++][ranges][NFC] Test new requirements for `basic_string_view` and `span` iterators.
Note that most changes to `strings` and `views.span` from the One Ranges
Proposal are no longer applicable:
- free `begin` and `end` functions taking `basic_string_view` and `span`
were removed by [P1870](http://wg21.link/p1870);
- `span::const_iterator` was removed by [LWG3320](https://cplusplus.github.io/LWG/lwg-defects.html#3320).
Reviewed By: #libc, Quuxplusone, ldionne
Differential Revision: https://reviews.llvm.org/D118687
Konstantin Varlamov [Wed, 2 Feb 2022 20:53:07 +0000 (12:53 -0800)]
[libc++][ranges][NFC] Add contiguous_iterator_tag to the <iterator> synopsis
It was previously implemented by commit [
45d048c20](https://reviews.llvm.org/rG45d048c20440989df2b4e1be1f9343225e7741ab).
Reviewed By: #libc, Quuxplusone, philnik, ldionne
Differential Revision: https://reviews.llvm.org/D118751
Shilei Tian [Wed, 2 Feb 2022 20:38:59 +0000 (15:38 -0500)]
[OMPIRBuilder] Add support for atomic compare
This patch adds the support for `atomic compare` in `OMPIRBuilder`.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D118547
Haowei Wu [Wed, 2 Feb 2022 20:15:58 +0000 (12:15 -0800)]
[libc++] Add UNSUPPORTED for clang-15
This started breaking in the CI because we bumped the Clang version
to 15, which requires adjusting the markup in the test suite.
Differential Revision: https://reviews.llvm.org/D118838
Craig Topper [Wed, 2 Feb 2022 20:15:36 +0000 (12:15 -0800)]
[RISCV] Cleanup some places that assumed VLMaxSentinel and -1 constant mean the same thing. NFCI
VLMaxSentintel happens to be represented as -1 TargetConstant. A user
provided -1 would be an ISD::Constant. We shouldn't assume that they
are the same thing. I'm still not entirely convinced that we should be
treating -1 from the user as VLMAX.
Also fix one place that failed to use XLenVT for the VLMaxSentinel,
using MVT::i64 in code that only executes on RV32.
Siva Chandra Reddy [Wed, 2 Feb 2022 20:18:52 +0000 (20:18 +0000)]
[libc][bazel overlay] Add a target for strncpy.
Alexey Bataev [Wed, 2 Feb 2022 20:05:50 +0000 (12:05 -0800)]
Revert "[SLP]Alternate vectorization for cmp instructions."
This reverts commit
842a2360a84692f2e4c37cc3e652640e6627d004 to fix the
bugs reported by users in https://reviews.llvm.org/D115955#3291538.
Anna Thomas [Wed, 2 Feb 2022 18:49:20 +0000 (13:49 -0500)]
[LoopFuse] Change DT to reference in FusionCandidate struct. NFC
Assertion added in
f50821cff0 confirms that the DT is indeed nonnull.
Change it to a reference instead of a pointer to make this explicit in
FusionCandidate.
Suggested in D118472.
Rashmi Mudduluru [Wed, 2 Feb 2022 02:28:42 +0000 (18:28 -0800)]
[analyzer] Add support for __attribute__((returns_nonnull)).
Differential Revision: https://reviews.llvm.org/D118657
Jeremy Morse [Wed, 2 Feb 2022 19:17:42 +0000 (19:17 +0000)]
[DebugInfo] Re-enable instruction referencing for x86_64
After discussion in D116821 this was turned off in
74db5c8c95e,
14aaaa12366f7 applied to limit the maximum memory consumption in rare
conditions, plus some performance patches.
Andrew Litteken [Wed, 2 Feb 2022 17:12:47 +0000 (11:12 -0600)]
[IRSim] Make sure that commutative intrinsics are treated as function calls without commutativity
Created to fix: https://github.com/llvm/llvm-project/issues/53537
Some intrinsics functions are considered commutative since they are performing operations like addition or multiplication. Some of these have extra parameters to provide extra information that are not part of the operation itself and are not commutative. This makes sure that if an instruction that is an intrinsic takes the non commutative path to handle this case.
Reviewer: paquette
Closes Issue #53537
Differential Revision: https://reviews.llvm.org/D118807
Matt Arsenault [Wed, 2 Feb 2022 17:49:27 +0000 (12:49 -0500)]
CodeGen: Use asm register names in warning message
This was using the ugly tablegenerated register enum names, which are
really hideous for register tuples on AMDGPU. Use the prettier names
which are recognized by the asm parser.
Matt Arsenault [Wed, 2 Feb 2022 16:18:18 +0000 (11:18 -0500)]
AMDGPU: Implement isAsmClobberable
Warn on inline assembly clobbering reserved registers. It should also
warn on at least some reserved register defs, but that isn't happening
right now. If you have a def and re-use of a register we reserve, the
register coalescer will eliminate the intermediate virtual
register. When the reserved reg def is introduced later by the
backend, it will end up clobbering the value the register coalescer
assumed was live through the range.
There is also isInlineAsmReadOnlyReg, although I don't understand what
the distinction really is. It's called in SelectionDAGBuilder, long
before the set of reserved registers is frozen so I'm not sure how
that can possibly work reliably.
Unfortunately this is also using the ugly tablegenerated names for the
registers.
Alex Lorenz [Mon, 20 Dec 2021 20:26:50 +0000 (12:26 -0800)]
[clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token
The lexer can attempt to lex a _Pragma and crash with an out of bounds string access when it's
lexing a _Pragma whose string token is an invalid buffer, e.g. when a module header file from which the macro
expansion for that token was deleted from the file system.
Differential Revision: https://reviews.llvm.org/D116052
Peter Klausler [Mon, 31 Jan 2022 18:07:53 +0000 (10:07 -0800)]
[flang] Silence bogus error on use after IMPORT
When a scope uses an explicit IMPORT statement to import a
symbol from the scope's host, it should not emit a bogus error
message later if that symbol is used in a specification construct.
The code that checks for imports being hidden by local declarations
was not allowing for the presence of host association (or USE)
indirection symbols in the local scope. Fix by using GetUltimate()
before checking for the hidden symbol.
Differential Revision: https://reviews.llvm.org/D118747
Jean Perier [Wed, 2 Feb 2022 18:52:28 +0000 (19:52 +0100)]
[flang] prevent rewrite of CMPLX with dynamically optional Y argument
CMPLX was always rewritten as a complex constructor, but the second operand
of a complex constructor cannot be dynamically absent (i.e., a
disassociated pointer, an unallocated allocatable or an absent OPTIONAL
dummy argument), while the second argument of CMPLX can be dynamically
absent.
To avoid having to generate branches in complex constructor lowering
when Y is a pointer, keep the distinction between CMPLX and a complex
constructor when Y is a pointer, an allocatable, or an OPTIONAL entity.
Differential Revision: https://reviews.llvm.org/D118784
Peter Klausler [Fri, 28 Jan 2022 16:28:00 +0000 (08:28 -0800)]
[flang] Fix: use right symbol for parent component
When constructing the representation for a component reference
to an inherited component, expression semantics make the parent
component references explicit in the DataRef; e.g., base%component
becomes base%parent%grandparent%component if component was
inheritance-associated through two levels. But expression semantics
was inserting references to the symbol table entries for the
intermediate types, not the symbols for the parent components in
the extended types. (We didn't notice the distinction until
recently because both symbols have the same name; this only
affects lowering.) Find and use the right symbols.
Differential Revision: https://reviews.llvm.org/D118746
Arthur O'Dwyer [Tue, 1 Feb 2022 20:24:19 +0000 (15:24 -0500)]
[libc++] [NFC] s/__referenceable/__can_reference/
The Standard name for this exposition-only concept is _can-reference_.
Differential Revision: https://reviews.llvm.org/D118726
Alexey Bataev [Thu, 16 Dec 2021 16:55:52 +0000 (08:55 -0800)]
[SLP]Alternate vectorization for cmp instructions.
Added support for alternate ops vectorization of the cmp instructions.
It allows to vectorize either cmp instructions with same/swapped
predicate but different (swapped) operands kinds or cmp instructions
with different predicates and compatible operands kinds.
Differential Revision: https://reviews.llvm.org/D115955
Michał Górny [Fri, 28 Jan 2022 13:53:20 +0000 (14:53 +0100)]
[lldb] [Commands] Implement "thread siginfo"
Differential Revision: https://reviews.llvm.org/D118473
Masoud Ataei [Wed, 2 Feb 2022 18:29:22 +0000 (10:29 -0800)]
[PowerPC] Fixing buildbod failure ppc64le-lld-multistage-test
Chia-hung Duan [Wed, 2 Feb 2022 17:36:49 +0000 (17:36 +0000)]
[mlir] Support verification order (1/3)
This CL supports adding dependency between traits verifiers and the
dependency will be checked statically.
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D115135
Rainer Orth [Wed, 2 Feb 2022 18:20:02 +0000 (19:20 +0100)]
[clang][Sparc] Fix __builtin_extract_return_addr etc.
While investigating the failures of `symbolize_pc.cpp` and
`symbolize_pc_inline.cpp` on SPARC (both Solaris and Linux), I noticed that
`__builtin_extract_return_addr` is a no-op in `clang` on all targets, while
`gcc` has non-default implementations for arm, mips, s390, and sparc.
This patch provides the SPARC implementation. For background see
`SparcISelLowering.cpp` (`SparcTargetLowering::LowerReturn_32`), the SPARC
psABI p.3-12, `%i7` and p.3-16/17, and SCD 2.4.1, p.3P-10, `%i7` and
p.3P-15.
Tested (after enabling the `sanitizer_common` tests on SPARC) on
`sparcv9-sun-solaris2.11`.
Differential Revision: https://reviews.llvm.org/D91607
Craig Topper [Wed, 2 Feb 2022 15:54:38 +0000 (07:54 -0800)]
[RISCV] Add DAG combines to transform ADD_VL/SUB_VL into widening add/sub.
This adds or reuses ISD opcodes for vadd.wv, vaddu.wv, vadd.vv, vaddu.vv
and a similar set for sub.
I've included support for narrowing scalar splats that have known
sign/zero bits similar to what was done for MUL_VL.
The conversion to vwadd.vv proceeds in two phases. First we'll form
a vwadd.wv by narrowing one of the operands. Then we'll visit the
vwadd.wv to try to narrow the other operand. This turned out to be
simpler than catching all the cases in one step. The forming of of
vwadd.wv can happen for either operand for add, but only the right
hand side for sub since sub isn't commutable.
An interesting quirk is that ADD_VL and VZEXT_VL/VSEXT_VL are formed
during vector op legalization, but VMV_V_X_VL isn't usually formed
until op legalization when BUILD_VECTORS are handled. This leads to
VWADD_W_VL forming in one DAG combine round, and then a later DAG combine
round sees the VMV_V_X_VL and needs to commute the operands to get the
splat in position. This alone necessitated a VWADD_W_VL combine function
which made forming vwadd.vv in two stages an easy choice.
I've left out trying hard to form vwadd.wx instructions for now. It would
only save an extend in the scalar domain which isn't as interesting.
Might need to review the test coverage a bit. Most of the vwadd.wv
instructions are coming from vXi64 tests on rv64. The tests were
copy pasted from the existing multiply tests.
Reviewed By: rogfer01
Differential Revision: https://reviews.llvm.org/D117954
Sam Parker [Wed, 2 Feb 2022 17:21:07 +0000 (17:21 +0000)]
[NFC] TypePromotion tests
Valentin Clement [Wed, 2 Feb 2022 17:44:09 +0000 (18:44 +0100)]
[flang] Switch return to ExtendedValue in AbstractConverter and Bridge
Change the signature of `genExprAddr`, `genExprValue` to return a `fir::ExtendedValue` instead of a simple `mlir::Value`
This patch is a preparation for more lowering to be upstream. It supports D118786 and D118787.
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D118785
Louis Dionne [Wed, 2 Feb 2022 17:43:48 +0000 (12:43 -0500)]
[libc++] UNSUPPORT GDB pretty printers with Clang 15 (which is what main is)
Peter Klausler [Thu, 27 Jan 2022 20:09:07 +0000 (12:09 -0800)]
[flang] Set right "inNamelist" flag
NAMELIST I/O was inconsistent in its choice of which set of I/O modes
to set the "inNamelist" flag. The wrong choice was in the set of modes
that are part of the persistent state of an I/O connection; the right
place is the set of modes that are reinitialized at the beginning of
each I/O statement so that they can be modified by READ/WRITE control
list specifiers and FORMAT control edit descriptors. Fix.
Differential Revision: https://reviews.llvm.org/D118745
Jay Foad [Wed, 2 Feb 2022 11:35:36 +0000 (11:35 +0000)]
[AMDGPU] Use new target MMO flag MONoClobber
This allows us to set the noclobber flag on (the MMO of) a load
instruction instead of on the pointer. This fixes a bug where noclobber
was being applied to all loads from the same pointer, even if some of
them were clobbered.
Differential Revision: https://reviews.llvm.org/D118775
Arthur O'Dwyer [Wed, 2 Feb 2022 17:07:51 +0000 (12:07 -0500)]
[libc++] [test] Fix a couple of copy-paste comments. NFC.
Adrian Prantl [Wed, 2 Feb 2022 17:08:11 +0000 (09:08 -0800)]
Add missing include diagnosed by the modules build.
Simon Pilgrim [Wed, 2 Feb 2022 16:56:06 +0000 (16:56 +0000)]
Remove redundant LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION defines
Now that VS2017 support has been dropped (D114639), the LLVM_HAS_RVALUE_REFERENCE_THIS define is always true and the LLVM_LVALUE_FUNCTION define is always enabled for ref-qualifiers.
This patch proposes we remove the defines and use the qualifiers directly.
Differential Revision: https://reviews.llvm.org/D118609
Alexandros Lamprineas [Tue, 1 Feb 2022 13:44:03 +0000 (13:44 +0000)]
[Function Specialisation] Fix use after free
This is a fix for a use-after-free found by the address sanitizer when
compiling GCC: https://github.com/llvm/llvm-project/issues/52821
The Function Specialization pass may remove instructions, cached
inside the PredicateBase class, which are later being dereferenced
from the SCCPInstVisitor class. To prevent the dangling references
I am lazily deleting the dead instructions after the Solver has run.
Differential Revision: https://reviews.llvm.org/D118591
Alex Lorenz [Wed, 2 Feb 2022 08:19:49 +0000 (00:19 -0800)]
[clang][macho] add clang frontend support for emitting macho files with two build version load commands
This patch extends clang frontend to add metadata that can be used to emit macho files with two build version load commands.
It utilizes "darwin.target_variant.triple" and "darwin.target_variant.SDK Version" metadata names for that.
MachO uses two build version load commands to represent an object file / binary that is targeting both the macOS target,
and the Mac Catalyst target. At runtime, a dynamic library that supports both targets can be loaded from either a native
macOS or a Mac Catalyst app on a macOS system. We want to add support to this to upstream to LLVM to be able to build
compiler-rt for both targets, to finish the complete support for the Mac Catalyst platform, which is right now targetable
by upstream clang, but the compiler-rt bits aren't supported because of the lack of this multiple build version support.
Differential Revision: https://reviews.llvm.org/D115415
Simon Pilgrim [Wed, 2 Feb 2022 16:29:35 +0000 (16:29 +0000)]
TrigramIndex.h - move unnecessary StringRef include down to TrigramIndex.cpp
Arthur O'Dwyer [Wed, 2 Feb 2022 16:19:46 +0000 (11:19 -0500)]
[libc++] Guard bits of
598983d7 against _LIBCPP_HAS_NO_CONCEPTS.
LLVM GN Syncbot [Wed, 2 Feb 2022 16:10:56 +0000 (16:10 +0000)]
[gn build] Port
256d2533322c
Nikita Popov [Wed, 2 Feb 2022 16:07:45 +0000 (17:07 +0100)]
[IRBuilder] Reformat two functions (NFC)
These were using 1-space indentation.
Arthur O'Dwyer [Wed, 2 Feb 2022 01:06:30 +0000 (20:06 -0500)]
[libc++] [NFC] Normalize some `#ifndef _LIBCPP_HAS_NO_CONCEPTS`.
Arthur O'Dwyer [Wed, 2 Feb 2022 00:59:37 +0000 (19:59 -0500)]
[libc++] [NFC] s/_LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_CONCEPTS)/!defined(_LIBCPP_HAS_NO_CONCEPTS)/
Per Discord discussion, we're normalizing on a simple `!defined(_LIBCPP_HAS_NO_CONCEPTS)`
so that we can do a big search-and-replace for `!defined(_LIBCPP_HAS_NO_CONCEPTS)`
back into `_LIBCPP_STD_VER > 17` when we're ready to abandon support for concept-syntax-less
compilers.
Differential Revision: https://reviews.llvm.org/D118748
Jeremy Morse [Wed, 2 Feb 2022 15:54:24 +0000 (15:54 +0000)]
Follow up to
9fd9d56dc6b, avoid a memory leak
Gaps in the basic block number range (from blocks being deleted or folded)
get block-value-tables allocated but never ejected, leading to a memory
leak, currently tripping up the asan buildbots. Fix this up by manually
freeing that memory.
As suggested elsewhere, if these things were owned by a unique_ptr then
cleanup would happen automagically. D118774 should eliminate the need for
this dance.
Florian Hahn [Wed, 2 Feb 2022 15:56:24 +0000 (15:56 +0000)]
[ConstraintElimination] Add tests with signed predicates and GEPs.
Masoud Ataei [Wed, 2 Feb 2022 15:54:19 +0000 (07:54 -0800)]
[PowerPC] Scalar IBM MASS library conversion pass
This patch introduces the conversions from math function calls
to MASS library calls. To resolves calls generated with these conversions, one
need to link libxlopt.a library. This patch is tested on PowerPC Linux and AIX.
Differential: https://reviews.llvm.org/D101759
Reviewer: bmahjour
Louis Dionne [Tue, 1 Feb 2022 21:32:39 +0000 (16:32 -0500)]
[libc++] Add CI without experimental features and don't exclude span from the tests
There is no reason for the parts of std::span that don't depend on ranges
to be disabled when ranges aren't provided. Also, to make sure the
"no-experimental-stuff" configuration is tested, add a CI job for it.
Differential Revision: https://reviews.llvm.org/D118740
Simon Pilgrim [Wed, 2 Feb 2022 15:35:46 +0000 (15:35 +0000)]
[llvm-rc] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointer is dereferenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Wed, 2 Feb 2022 15:32:19 +0000 (15:32 +0000)]
Signposts.h - move unnecessary StringRef include down to Signposts.cpp
Mircea Trofin [Wed, 2 Feb 2022 15:34:51 +0000 (07:34 -0800)]
Mircea Trofin [Tue, 1 Feb 2022 16:21:30 +0000 (08:21 -0800)]
[nfc][regalloc] Make the max inference cutoff configurable
Added a flag to make configurable the number of interferences after
which we 'bail out' and treat a set of intervals as un-evictable. Also
using it on the ML side, as it turns out to be a good control for
compile-time.
With this configurable, we can do a bit of trial and error and see if
bumping it has any effect on heuristic/policy quality.
Differential Revision: https://reviews.llvm.org/D118707
Sylvestre Ledru [Wed, 2 Feb 2022 15:23:23 +0000 (16:23 +0100)]
Also document -arch as -arch is mac specific
Reviewed By: serge-sans-paille
Differential Revision: https://reviews.llvm.org/D60380
Jeremy Morse [Wed, 2 Feb 2022 15:04:14 +0000 (15:04 +0000)]
[DebugInfo][InstrRef] Fix a tombstone-in-DenseMap crash from D117877
This is a follow-up to D117877: variable assignments of DBG_VALUE $noreg,
or DBG_INSTR_REFs where no value can be found, are represented by a
DbgValue object with Kind "Undef", explicitly meaning "there is no value".
In D117877 I added a special-case to some assignment accounting faster,
without considering this scenario. It causes variables to be given the
value ValueIDNum::EmptyValue, which then ends up being a DenseMap key. The
DenseMap asserts, because EmptyValue is the tombstone key.
Fix this by handling the assign-undef scenario in the special case, to
match what happens in the general case: the variable has no value if it's
only ever assigned $noreg / undef.
Differential Revision: https://reviews.llvm.org/D118715
Roman Lebedev [Sun, 23 Jan 2022 17:23:42 +0000 (20:23 +0300)]
[NFC][SimplifyCFG] Merge `FoldTwoEntryPHINode()` into it's only callee
Roman Lebedev [Sun, 23 Jan 2022 16:37:50 +0000 (19:37 +0300)]
[NFC][SimplifyCFG] `FoldTwoEntryPHINode()`: s/BB/MergeBB/
Roman Lebedev [Sun, 23 Jan 2022 14:05:22 +0000 (17:05 +0300)]
[SimplifyCFG] Start redesigning `FoldTwoEntryPHINode()`.
The current `FoldTwoEntryPHINode()` is not quite designed correctly.
It starts from the merge point, and then tries to detect
the 'divergence' point.
Because of that, it is limited to the simple two-predecessor case,
where the PHI completely goes away. but that is rather pessimistic,
and it doesn't make much sense from the costmodel side of things.
For example if there is some other unrelated predecessor of
the merge point, we could split the merge point so that
the then/else blocks first branch to an empty block
and then to the merge point, and then we'd be able to speculate
the then/else code.
But if we'd instead simply start at the divergence point,
and look for the merge point, then we'll just natively support this case.
There's also the fact that `SpeculativelyExecuteBB()` already does
just that, but only if there is a single block to speculate,
and with a much more restrictive cost model.
But that also means we have code duplication.
Now, sadly, while this is as much NFCI as possible,
there is just no way to cleanly migrate to
the proper implementation. The results *are* going to be different
somewhat because of various phase ordering effects and SimplifyCFG
block iteration strategy.
Roman Lebedev [Sun, 23 Jan 2022 13:54:32 +0000 (16:54 +0300)]
[NFC][SimplifyCFG] Autogenerate checklines in a few tests being affected by upcoming change
Arjun P [Wed, 2 Feb 2022 13:32:34 +0000 (19:02 +0530)]
[MLIR][Presburger] Simplify checkExplicitRepresentation
This also gets rid of a clang-tidy warning.
Reviewed By: Groverkss
Differential Revision: https://reviews.llvm.org/D118780
Marek Kurdej [Wed, 2 Feb 2022 14:00:40 +0000 (15:00 +0100)]
[clang-format] Elide unnecessary braces. NFC.
Prashant Kumar [Tue, 1 Feb 2022 20:07:53 +0000 (01:37 +0530)]
[MLIR][Presburger] Use `SmallVector` instead of `std::vector` in `getLocalRepr`
Use `SmallVector` instead of `std::vector` in `getLocalRepr` function.
Also, fix the casing of a variable.
Reviewed By: arjunp
Differential Revision: https://reviews.llvm.org/D118722
Guillaume Chatelet [Wed, 2 Feb 2022 14:15:39 +0000 (15:15 +0100)]
[libc] Populate rtti/eh flags for all targets
Simon Pilgrim [Wed, 2 Feb 2022 13:19:11 +0000 (13:19 +0000)]
[llvm-profgen] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointer is dereferenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Wed, 2 Feb 2022 13:18:10 +0000 (13:18 +0000)]
[llvm-profgen] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointers are dereferenced immediately, so assert the cast is correct instead of returning nullptr
Jeremy Morse [Wed, 2 Feb 2022 13:48:36 +0000 (13:48 +0000)]
[DebugInfo][InstrRef][NFC] Use depth-first scope search for variable locs
This patch aims to reduce max-rss from instruction referencing, by avoiding
keeping variable value information in memory for too long. Instead of
computing all the variable values then emitting them to DBG_VALUE
instructions, this patch tries to stream the information out through a
depth first search:
* Make use of the fact LexicalScopes gives a depth-number to each lexical
scope,
* Produce a map that identifies the last lexical scope to make use of a
block,
* Enumerate each scope in LexicalScopes' DFS order, solving the variable
value problem,
* After each scope is processed, look for any blocks that won't be used by
any other scope, and emit all the variable information to DBG_VALUE
instructions.
Differential Revision: https://reviews.llvm.org/D118460
David Green [Wed, 2 Feb 2022 13:48:16 +0000 (13:48 +0000)]
[AArch64] Genereate CCMP from And CSel
LLVM has a couple of ways of producing ccmp - either from chains in isel
or from a later ifcvt style pass. This adds a simple DAG combine to
capture more cases, converting and(csel(0, 1, cc0), csel(0, 1, cc1))
into a csel(ccmp(.., cc0)), depending on cc1 (a SUBS in this case).
Differential Revision: https://reviews.llvm.org/D118327
Nikita Popov [Wed, 2 Feb 2022 13:38:06 +0000 (14:38 +0100)]
[ArgPromotion] Add test with bitcasts (NFC)
Argument promotion currently doesn't handle these.
Guillaume Chatelet [Wed, 2 Feb 2022 13:35:46 +0000 (13:35 +0000)]
[libc] use llvm_update_compile_flags to populate rtti/exception compilation flags
Marek Kurdej [Wed, 2 Feb 2022 13:27:11 +0000 (14:27 +0100)]
[clang-format] Elide unnecessary braces. NFC.
Marek Kurdej [Wed, 2 Feb 2022 13:19:36 +0000 (14:19 +0100)]
[clang-format] Factor out loop variable. NFC.
* Break on the size of the used variable Content instead of Lines (even though both should have the same size).
Marek Kurdej [Wed, 2 Feb 2022 13:17:57 +0000 (14:17 +0100)]
[clang-format] Simplify use of StringRef::substr(). NFC.
Arjun P [Wed, 2 Feb 2022 13:26:01 +0000 (18:56 +0530)]
[MLIR][Presburger] maybeLocalRepr: rename inEqualityPair -> inequalityPair
Sanjay Patel [Wed, 2 Feb 2022 13:01:23 +0000 (08:01 -0500)]
[x86] invert a vector select IR canonicalization with a binop identity constant
This is an intentionally limited/different form of D90113.
That patch bravely tries to generalize folds where we pull
a binop into the arms of a select:
N0 + (Cond ? 0 : FVal) --> Cond ? N0 : (N0 + FVal)
...but it is not universally profitable.
This is the inverse of IR canonicalization as discussed in
D113442.
We know that this transform is not entirely profitable even
within x86, so we only handle x86 vector fadd/fsub as a 1st
step. The intent is to prevent AVX512 regressions as mentioned
in D113442.
The plan is to port this to DAGCombiner (so it will eventually
look more like D90113) and add more types/cases in pieces with
many more tests to verify that we are seeing improvements.
Differential Revision: https://reviews.llvm.org/D118644
Nathan Sidwell [Tue, 1 Feb 2022 15:49:28 +0000 (07:49 -0800)]
[clang][NFC] Remove unreachable code
NamespaceDecls are NamedDecls, so NSD can never be non-null in the
else branch. Add a comment about this whole ModuleInternal linkage
concept going away when p1815 is implemented.
Reviewed By: bruno
Differential Revision: https://reviews.llvm.org/D118704
Arjun P [Wed, 2 Feb 2022 13:07:13 +0000 (18:37 +0530)]
[MLIR][Presburger] Support isSubsetOf in PresburgerSet and IntegerPolyhedron
Also support isEqual in IntegerPolyhedron.
Reviewed By: Groverkss
Differential Revision: https://reviews.llvm.org/D118778
Pavel Labath [Mon, 31 Jan 2022 14:57:48 +0000 (15:57 +0100)]
[lldb] Convert "LLDB" log channel to the new API
Marek Kurdej [Wed, 2 Feb 2022 13:01:12 +0000 (14:01 +0100)]
[clang-format] Use prefix operator--. NFC.
Marek Kurdej [Wed, 2 Feb 2022 12:59:53 +0000 (13:59 +0100)]
[clang-format] Use llvm::seq instead of std::iota. NFC.
Jeremy Morse [Wed, 2 Feb 2022 12:23:52 +0000 (12:23 +0000)]
[DebugInfo][InstrRef][NFC] Free resources at an earlier stage
This patch releases some memory from InstrRefBasedLDV earlier that it would
otherwise. The underlying problem is:
* We store a big table of "live in values for each block",
* We translate that into DBG_VALUE instructions in each block,
And both exist in memory at the same time, which needlessly doubles that
information. The most of what this patch does is: as we progressively
translate live-in information into DBG_VALUEs, we free the variable-value /
machine-value tracking information as we go, which significantly reduces
peak memory.
While I'm here, also add a clear method to wipe variable assignments that
have been accumulated into VLocTracker objects, and turn a DenseMap into
a SmallDenseMap to avoid an initial allocation.
Differential Revision: https://reviews.llvm.org/D118453
Lancelot SIX [Wed, 2 Feb 2022 12:30:39 +0000 (13:30 +0100)]
[Docs][NFC] Contributing.rst: fix wording
Fix a sentence containing two consecutive 'and'.
Arjun P [Wed, 2 Feb 2022 12:26:30 +0000 (17:56 +0530)]
[MLIR] PresburgerSet::isIntegerEmpty: address clang-tidy warning
Guillaume Chatelet [Wed, 2 Feb 2022 11:20:43 +0000 (11:20 +0000)]
[NFC][libc] Remove unneeded gtest and benchmark configuration
Differential Revision: https://reviews.llvm.org/D118770
Jeremy Morse [Wed, 2 Feb 2022 12:12:32 +0000 (12:12 +0000)]
[DebugInfo][InstrRef][NFC] Cache some PHI resolutions
Install a cache of DBG_INSTR_REF -> ValueIDNum resolutions, for scenarios
where the value has to be reconstructed from several DBG_PHIs. Whenever
this happens, it's because branch folding + tail duplication has messed
with the SSA form of the program, and we have to solve a mini SSA problem
to find the variable value. This is always called twice, so it makes sense
to cache the value.
This gives a ~0.5% geomean compile-time-performance improvement on CTMark.
Differential Revision: https://reviews.llvm.org/D118455
Arjun P [Wed, 2 Feb 2022 11:49:59 +0000 (17:19 +0530)]
[MLIR][AffineAnalysis] Fix typo in comment (NFC)
Arjun P [Wed, 2 Feb 2022 12:09:32 +0000 (17:39 +0530)]
[MLIR] Matrix: support matrix-vector multiplication
This just moves in the implementation from LinearTransform.
Reviewed By: Groverkss, bondhugula
Differential Revision: https://reviews.llvm.org/D118479
Benjamin Kramer [Wed, 2 Feb 2022 12:02:35 +0000 (13:02 +0100)]
Revert "[SLP]Alternate vectorization for cmp instructions."
This reverts commit
83620bd2ad867f706c699d0f2b8be10e43d9f3d7.
It's causing miscompilations, see review comments at
https://reviews.llvm.org/D115955