Michelle McDaniel [Thu, 11 May 2017 19:28:28 +0000 (12:28 -0700)]
Handle ADC in x86 unwindLazyState (#11527)
When we add PGO instrumentation to coreclr, the instrumentation injects
PUSH, MOV, ADD, ADC, POP into the prolog to mark the function entry. This
causes a crash because we do not currently handle ADC instructions in
unwindLazyState. This change adds support for ADC, which uses the normal
DecodeRM code we already have in place.
Jan Kotas [Thu, 11 May 2017 18:45:38 +0000 (11:45 -0700)]
Add back private BadImageFormatException constructor called by the VM (#11523)
Also removed rethrowing of an exception inside AssemblyName.GetAssemblyName that sometimes resulted into two identical exceptions getting nested into each other.
Fixes #11499
Sepideh Khoshnood [Thu, 11 May 2017 18:45:06 +0000 (11:45 -0700)]
Fix AssemblyName version (#11505)
* Fix AssemblyName.FullName
* Use canonicalized version instead of Version.ToString
Noah Falk [Thu, 11 May 2017 03:29:30 +0000 (20:29 -0700)]
Merge pull request #11437 from mjsabby/eventpipetoprofilerapi
Add dynamic method unload event to Profiler API
Swaroop Sridhar [Wed, 10 May 2017 22:25:53 +0000 (15:25 -0700)]
This change has the following improvements to LinkBench
1. Move the testing to the latest version of ILLink package
(for all benchmarks except for Roslyn, which is still on netcoreapp1.1)
2. Support for LinkBench to run individual benchmarks in the suite --
helps local testing.
3. Support for running without clean, cloning, build etc --
for local runs during continuous development.
4. Support to obtain the correct version(s) of DotNet CLI required to run
the benchmarks
5. Get-Crossgen.ps1 is required to crossgen MusicStore binaries (before/after linking).
Since it was recently dropped from JitBench repo, it is added to linkBench as an asset.
6. Add the --perf:runid parameter to generate output file names suitable
to upload the results to BenchView.
Mukul Sabharwal [Thu, 11 May 2017 01:41:13 +0000 (18:41 -0700)]
Remove eventpipe stuff left from prev commit
Mukul Sabharwal [Thu, 11 May 2017 01:39:37 +0000 (18:39 -0700)]
add prebuilt file
Mukul Sabharwal [Thu, 11 May 2017 01:37:58 +0000 (18:37 -0700)]
Remove EventPipeProfiler due to time constraints
Alex Ghiondea [Wed, 10 May 2017 23:45:01 +0000 (16:45 -0700)]
Allow multiple SetData calls on AppDomain (#11496)
* Allow multiple SetData calls on AppDomain
* Remove restriction from GetData and remove now-dead code Locate
* Remove LoaderOptimization check since it is not used on CoreCLR
Brian Robbins [Wed, 10 May 2017 22:11:28 +0000 (15:11 -0700)]
Re-Factor EventSource to Support Writing to EventPipe (#11435)
Re-Factor EventSource to Support Writing to EventPipe.
Brian Sullivan [Wed, 10 May 2017 20:50:19 +0000 (13:50 -0700)]
Merge pull request #11478 from sdmaclea/PR-ARM64-9711
[Arm64] Support GTF_IND_VOLATILE
Jose Perez Rodriguez [Wed, 10 May 2017 20:23:28 +0000 (13:23 -0700)]
Add version.txt to the coreclr transport package (#11497)
* Add version.txt to the coreclr transport package
* PR Feedback
Drew Scoggins [Wed, 10 May 2017 20:07:12 +0000 (13:07 -0700)]
Merge pull request #11448 from DrewScoggins/AddPriority
Launch perf process with high priority
Jonghyun Park [Wed, 10 May 2017 19:32:33 +0000 (12:32 -0700)]
[ARM/Linux] Enable build with FEATURE_DBGIPC=0 (#11254)
* [ARM/Linux] Enable build with FEATURE_DBGIPC=0
* Replace HAVE_ALIGNED_MALLOC with SUPPORT_LOCAL_DEBUGGING
[Arm64] Revise GTF_IND_VOLATILE per comments
Jan Vorlicek [Wed, 10 May 2017 16:32:42 +0000 (18:32 +0200)]
Fix clang version detection in src/pal/tools/gen-buildsys-clang.sh (#11398)
The version detection that was added recently for the purpose of selecting
optimization options for ARM builds was not working properly when the
clang binary doesn't have version in its name. This resulted in syntax
error being reported on OSX and some Linux distros:
/Users/janvorli/git/coreclr/src/pal/tools/gen-buildsys-clang.sh:
line 162: : /usr/bin/clang: syntax error: operand expected (error token is "/usr/bin/clang")
Tarek Mahmoud Sayed [Wed, 10 May 2017 15:38:20 +0000 (08:38 -0700)]
Update the License to MIT for coreclr repo (#11482)
Jonghyun Park [Wed, 10 May 2017 15:10:22 +0000 (08:10 -0700)]
Allow users to enable automatic NI bind fallback via command-line (#11485)
* Add FEATURE_NI_BIND_FALLBACK support
* Fix incorrect variable setup
* Negate the check condition
* Use WIN32 instead of FEATURE_PAL
* Check WIN32 first, and FEATURE_NI_BIND_FALLBACK later
Pat Gavlin [Wed, 10 May 2017 13:56:57 +0000 (06:56 -0700)]
Merge pull request #11484 from pgavlin/DisableLongRunningTests
Disable a few long-running tests.
dotnet bot [Wed, 10 May 2017 05:20:44 +0000 (22:20 -0700)]
Update CoreFx to preview2-25310-01 (#11483)
Pat Gavlin [Wed, 10 May 2017 03:41:05 +0000 (20:41 -0700)]
Disable a few long-running tests.
These tests consistently time out under GC stress or heap verification.
Each disabled test is known to complete successfully given adequate
time.
Mike McLaughlin [Wed, 10 May 2017 02:14:09 +0000 (19:14 -0700)]
Fix lldbplugin to properly build with lldb 3.9. (#11480)
Sergey Andreenko [Tue, 9 May 2017 21:11:24 +0000 (14:11 -0700)]
[x86, R2R] Exclude DevDiv_278523 because it fails in R2R
Look at #11476 for the description.
Joseph Tremoulet [Tue, 9 May 2017 23:36:14 +0000 (19:36 -0400)]
Merge pull request #11465 from JosephTremoulet/StaticHoist
Stop hoisting statics above cctors
Brian Sullivan [Tue, 9 May 2017 23:11:33 +0000 (16:11 -0700)]
Merge pull request #11351 from sdmaclea/PR-ARM64-RRSS-SSRR
[Arm64] Add emitIns_R_R_S_S & emitIns_S_S_R_R
Sergey Andreenko [Tue, 9 May 2017 20:24:37 +0000 (13:24 -0700)]
delete tabs from the exclude list
Joseph Tremoulet [Tue, 9 May 2017 02:30:04 +0000 (22:30 -0400)]
Stop hoisting statics above cctors
Extend the logic in optLoopHoist around `CLS_VAR` nodes to ensure we don't
hoist any tree that contains a `CLS_VAR` for a field with the flag
`CORINFO_FLG_FIELD_INITCLASS` set, unless we also (identify and) hoist the
corresponding static init helper call. The previous logic was
insufficient in that it blocked hoisting of singleton `CLS_VAR` nodes, but
not hoisting of trees that contain `CLS_VAR` nodes as sub-trees.
Add flag `GTF_FLD_INITCLASS`/`GTF_CLS_VAR_INITCLASS` so that optLoopHoist
can recall which fields are paired with static init helper calls, and only
block the hoisting of their trees.
Fixes #10780.
[Arm64] Support GTF_IND_VOLATILE
Addresses #9711 for arm64
Sergey Andreenko [Tue, 9 May 2017 19:07:20 +0000 (12:07 -0700)]
Replace tabs with spaces.
Sergey Andreenko [Tue, 9 May 2017 18:00:08 +0000 (11:00 -0700)]
Return DevDiv_255294 test to the exclude list for x86
Because it causes out of memory exception in crossgen mode.
Koundinya Veluri [Tue, 9 May 2017 20:56:40 +0000 (13:56 -0700)]
Fix static analysis issues (#11466)
Fix static analysis issues
Bruce Forstall [Tue, 9 May 2017 19:05:20 +0000 (12:05 -0700)]
Merge pull request #11406 from sdmaclea/PR-ARM64-ENABLE-FEATURE_TAILCALL_OPT
[Arm64] Enable FEATURE_TAILCALL_OPT
Jan Vorlicek [Tue, 9 May 2017 18:30:59 +0000 (20:30 +0200)]
Stop loading crossgen-ed binaries at preferred address on Unix (#11467)
This change removes attempt to load crossgen-ed binaries at preferred
address on Unix and uses whatever address the mmap returns instead.
Pat Gavlin [Tue, 9 May 2017 18:10:00 +0000 (11:10 -0700)]
Fix issue #11446. (#11455)
This issue was a GC hole that was caused by bad IR produced by
recursivelty promoting a struct with the following form:
```
struct S
{
struct T
{
object o;
};
T t;
}
```
In this case, the recursive promotion logic created a single lclVar to
represent `S.t` and retyped it using the type of `T.o`, but did not
rewrite IR that treated the single lclVar as a struct (e.g. instances of
`lclFld/st.lclFld Vx` where `Vx` referred to the lclVar that represented
`S.t` were not rewritten an `lclVar/st.lclVar Vx`). This IR in
turn confused the incremental liveness used during code generation,
which caused the stack slot holding `o`'s value to die too early.
This change fixes codegen's incremental liveness to handle this case.
dotnet bot [Tue, 9 May 2017 14:32:46 +0000 (07:32 -0700)]
Update CoreClr, CoreFx to preview2-25309-01, preview2-25309-01, respectively (#11427)
Jan Vorlicek [Tue, 9 May 2017 09:03:32 +0000 (11:03 +0200)]
Enable build on old Linux (#11414)
This change enables building coreclr on old Linux distros that
don't have PR_SET_PTRACER and don't have _xstate struct in the
standard sigcontext.h header.
Mukul Sabharwal [Sun, 7 May 2017 10:17:39 +0000 (03:17 -0700)]
Add an event pipe that pipes to the profiler apis
Tarek Mahmoud Sayed [Tue, 9 May 2017 01:03:05 +0000 (18:03 -0700)]
Avoid throwing in the globalization managed callbacks (#11454)
* Avoid throwing in the globalization managed callbacks
* Add Assert
Viktor Hofer [Tue, 9 May 2017 00:41:06 +0000 (17:41 -0700)]
FailFast stderr logging with stacktrace (#11397)
Jarret Shook [Mon, 8 May 2017 23:18:08 +0000 (16:18 -0700)]
Merge pull request #11457 from jashook/arm64_pri1_tests
[Arm64] For arm64 jobs build pri1 tests by default
Pat Gavlin [Mon, 8 May 2017 22:56:54 +0000 (15:56 -0700)]
Merge pull request #11451 from pgavlin/gh11447
Fix issue #11447.
jashook [Mon, 8 May 2017 22:41:12 +0000 (15:41 -0700)]
[Arm64] For arm64 jobs build pri1 tests by default
This relates to coreclr #11423, enabling pri1 tests to
be built.
Alex Ghiondea [Mon, 8 May 2017 22:14:02 +0000 (15:14 -0700)]
Add assembly level attribute on CoreLib (#11449)
Drew Scoggins [Mon, 8 May 2017 18:59:23 +0000 (11:59 -0700)]
Launch perf process with high priority
This change uses the stability prefix flag that was already in
run-xunit-perf to pass flags to set the affinity of the process to a
single processor and to run the process at high priority.
Mike McLaughlin [Mon, 8 May 2017 20:34:41 +0000 (13:34 -0700)]
Add the "createdump" to the linux runtime package. (#11441)
Pat Gavlin [Mon, 8 May 2017 19:17:42 +0000 (12:17 -0700)]
Fix issue #11447.
This issue was caused by the code for PInvoke frame initialization reading
from the stub argument register after it had been trashed by prior
instructions. This change fixes this issue by inserting the PInvoke
frame initialization at the beginning of the scratch block into which it
is inserted rather than at the end.
Note that a more correct fix here would be to represent the stub
argument as a lclVar rather than a physical register; that work is
tracked by #11450.
Koundinya Veluri [Mon, 8 May 2017 19:16:21 +0000 (12:16 -0700)]
Make CoreCLR work properly under PaX's RANDMMAP (#11382)
Make CoreCLR work properly under PaX's RANDMMAP
Issues:
- The ExecutableMemoryAllocator is used to attempt to map native images into a memory range near libcoreclr so that its helper table can use short relative addresses for jumps to libcoreclr
- RANDMMAP typically prevents mmap calls with a specific address from reserving memory at the requested address, so the executable memory allocator fails to reserve any memory. When Server GC is enabled, the large GC heap can exacerbate the issue by taking address space near libcoreclr.
- Native images are loaded far from libcoreclr, and now jump stub space needs to be allocated near the native image, but RANDMMAP typically prevents this too
- NGenReserveForJumpStubs is intended to reserve some memory near mapped native images for jump stubs, but that reservation is done with a separate mmap call in the same way as above and RANDMMAP typically prevents this too
- The JIT needs to allocate memory for code that may need to jump/call to a native image or libcoreclr, which may require jump stubs near the code that cannot be allocated. CodeHeapReserveForJumpStubs reserves space in code heap blocks without using a separate call to mmap, so this works, but without this environment variable by default there is still a good chance of failing.
- See https://github.com/dotnet/coreclr/blob/
56d550d4f8aec2dd40b72a182205d0a2463a1bc9/Documentation/design-docs/jump-stubs.md for more details
Fixes #8480
- It would be ideal to fix all of the above properly, such that there would never be a need to attempt reserving memory within a certain range. Since we're running out of time for 2.0, I figured the following simpler, temporary solution that should cover most of the practical cases, may be appropriate for 2.0.
- Extended ExecutableMemoryAllocator to reserve address space even when it cannot do so near libcoreclr
- Had ClrVirtualAllocWithinRange use the executable memory allocator to reserve memory for jump stubs when the requested range is satisfied
- This covers a maximum of ~2 GB of executable code and should cover most of the practical cases. Once this space is exhausted, under RANDMMAP, native images loaded later will fail, and for jitted code the environment variable above can be used.
Jarret Shook [Mon, 8 May 2017 19:14:18 +0000 (12:14 -0700)]
Merge pull request #11445 from jashook/fix_build_break
Add define for FEATURE_SIMD
Drew Scoggins [Mon, 8 May 2017 18:50:45 +0000 (11:50 -0700)]
Merge pull request #11443 from DrewScoggins/CopyFix
Fix copy error in perf script
Russell C Hadley [Mon, 8 May 2017 18:08:11 +0000 (11:08 -0700)]
Merge pull request #11231 from russellhadley/UpdateEHDoc
Update EH WriteThru doc with review feedback.
Russell Hadley [Wed, 26 Apr 2017 19:24:24 +0000 (12:24 -0700)]
Update doc with review feedback.
Factor in additional exception cases from Andy and fix some wording from
Joe.
jashook [Mon, 8 May 2017 16:30:24 +0000 (09:30 -0700)]
Add define for FEATURE_SIMD
This fixs a build break in the desktop product.
Drew Scoggins [Mon, 8 May 2017 17:19:05 +0000 (10:19 -0700)]
Use profile information to differentiate files
[Arm64] Revise per comments
[Arm64] Add emitIns_R_R_S_S
[Arm64] Add emitIns_S_S_R_R
Sebastian Lauber [Mon, 8 May 2017 16:08:27 +0000 (18:08 +0200)]
Minor typo corrected (#11444)
Drew Scoggins [Mon, 8 May 2017 06:26:42 +0000 (23:26 -0700)]
Change xcopy to copy
Drew Scoggins [Mon, 8 May 2017 05:09:20 +0000 (22:09 -0700)]
Fix copy error in perf script
When I merged the PR that enabled the lean runs I added another call to
our run script. This run script had an assumption that it would only
ever be called once and as such would try and copy two files that had
the same name. This would cause it to prompt to overwrite or not and
fail the run. This change makes each copy unique based on the
collection flags that were used for collection.
Justin Van Patten [Mon, 8 May 2017 03:42:41 +0000 (20:42 -0700)]
Make Debugger class static (#11439)
* Make Debugger class static
It's static in the .NET Standard and .NET Core refs, and in CoreRT's
implementation, so make it static in the CoreCLR implementation as well.
Also, minor cleanup while making changes here.
Brian Robbins [Sat, 6 May 2017 19:36:08 +0000 (12:36 -0700)]
Log Events to EventPipe on Linux (#11433)
* Implement the EventPipe object model for providers and events.
* Plumb Runtime Events into EventPipe (#11145)
Plumb runtime ETW events into the EventPipe.
* Fix bug where all events except for SampleProfiler events were never enabled.
* Plumb EventPipeEventInstance through the EventPipe.
* Implement EventPipeFile and FastSerializer.
* Write event contents to the EventPipeFile.
* Only build EventPipe on Linux.
* Conditionally add a sentinel value marking event end.
* Send SampleProfiler events to the EventPipeFile.
* Fix provider ID printing to JSON file.
* Write the start date/time, timestamp, and clock frequency into the trace file.
* Support unloading of EventPipeProviders.
* Handle failure cases when we can't walk the stack or are shutting down.
* Fix a bug where we pass a null src pointer to memcpy.
Jan Kotas [Sat, 6 May 2017 18:03:27 +0000 (11:03 -0700)]
Delete dead code (#11431)
Jan Kotas [Sat, 6 May 2017 14:18:56 +0000 (07:18 -0700)]
Delete moved file
Jan Kotas [Sat, 6 May 2017 03:48:28 +0000 (20:48 -0700)]
Delete moved files and fix build breaks
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Kotas [Sat, 6 May 2017 03:32:38 +0000 (20:32 -0700)]
Move more files to shared CoreLib partition (#11429)
Justin Van Patten [Fri, 5 May 2017 23:56:49 +0000 (16:56 -0700)]
Remove ArrayList (#11426)
Also cleanup FEATURE_NONGENERIC_COLLECTIONS while on it.
Drew Scoggins [Fri, 5 May 2017 23:44:00 +0000 (08:44 +0900)]
Merge pull request #11428 from DrewScoggins/LeanRuns
Fix typo in perf.groovy
Drew Scoggins [Fri, 5 May 2017 23:07:27 +0000 (16:07 -0700)]
Fix typo in perf.groovy
Had a typo where I was passing deafult instead of default as a flag to
the collection harness. This fixes that.
Steve MacLean [Fri, 5 May 2017 23:16:37 +0000 (19:16 -0400)]
[Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP (#11375)
* [Arm64/Unix] Enable FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP
* [Arm64/Unix] Enable FEATURE_MANUALLY_MANAGED_CARD_BUNDLES
Sean Gillespie [Fri, 5 May 2017 22:57:25 +0000 (15:57 -0700)]
Add a GC Reliability Framework job to the CI (#11280)
* Add GC Reliability Framework CI job
* Three changes:
1) To address offline feedback, update the CI trigger phase document
and the GC testing instructions
2) Set the timeout for GC RF CI jobs to 24 hours, so they don't time
out (they will run for 15 hours by default)
3) Refactor "scenario == 'gc_reliability_framework' to its own method
so that new GC RF scenarios can easily and cleanly be added if
desired in the future
Jarret Shook [Fri, 5 May 2017 21:35:56 +0000 (14:35 -0700)]
Merge pull request #11425 from jashook/build_arm64_tests
Build tests for arm64 runs.
gbalykov [Fri, 5 May 2017 20:07:44 +0000 (23:07 +0300)]
Add compact entry points for ARM (#11109)
jashook [Fri, 5 May 2017 20:06:31 +0000 (13:06 -0700)]
Build tests for arm64 runs.
This has been separated to allow coreclr #11423 to be tested
incrementally in the PR.
dotnet bot [Fri, 5 May 2017 19:54:49 +0000 (12:54 -0700)]
Update CoreClr to preview2-25305-03 (#11421)
Pedro Lamas [Fri, 5 May 2017 19:30:05 +0000 (20:30 +0100)]
Return null from CultureData.GetLocaleInfoEx (#11422)
Jan Kotas [Fri, 5 May 2017 15:47:11 +0000 (08:47 -0700)]
Fix build breaks
Jan Kotas [Fri, 5 May 2017 15:03:16 +0000 (08:03 -0700)]
Switch over to shared Interop.Globalization.cs on Windows (#3528)
- Match CoreCLR refactoring done for invariant culture
- Use actual unsafe types in the interop signatures instead of opaque IntPtr
- Use Unsafe.As to get a pointer to stack allocated structure instead of allocating GCHandles
- Remove use of NativeCallable for enumeration to make the same code work on both CoreRT and CoreCLR. (I have kelp the NativeCallable annotations commented out so that we can switch back to them once C# gets the intrinsics to make it possible.)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Roman Artemev [Fri, 5 May 2017 18:17:42 +0000 (11:17 -0700)]
Merge pull request #11405 from rartemev/issue_10857_addingseq
Fixed memory instruction selection for integer register which contants simd8 type in ELT hook prolog
Santiago Fernandez Madero [Fri, 5 May 2017 18:12:21 +0000 (11:12 -0700)]
Path.GetDirectoryName() throw exception when path is empty or has only white spaces (#11403)
* Throw exception when path is empty or has only white spaces
Tarun Pothulapati [Fri, 5 May 2017 17:49:59 +0000 (17:49 +0000)]
Removed Dictionary<TKey, TValue>.GetValueOrDefault Methods (#11388)
* Removed Dictionary.GetValueOrDefault Methods and the method calls in Rtpe.cs,CustomAttribute.cs
* Replaced the Dictionary.GetValueOrDefault Methods
* Used !s_pca.ContainsKey(caType) instead of s_pca.ContainsKey(caType) == false
Drew Scoggins [Fri, 5 May 2017 17:39:15 +0000 (02:39 +0900)]
Add lean run support to CoreCLR perf (#11347)
In the xunit performance harness we added support for a "lean" run which
only runs the stopwatch to collect duration and none of the ETW
providers are turned on. This adds support in the automation for doing
runs that use this lean feature.
Stephen Toub [Fri, 5 May 2017 16:35:21 +0000 (12:35 -0400)]
Merge pull request #11411 from justinvp/delegate_opequality
Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks
dotnet bot [Fri, 5 May 2017 15:19:07 +0000 (08:19 -0700)]
Update CoreClr, CoreFx to preview2-25305-01, preview2-25305-01, respectively (#11384)
sergey ignatov [Fri, 5 May 2017 15:12:07 +0000 (18:12 +0300)]
Fixed issue #11383 (#11385)
Bruce Forstall [Fri, 5 May 2017 14:24:49 +0000 (07:24 -0700)]
Merge pull request #11361 from mikedn/imp-strlen-except
Add missing GTF_EXCEPT when importing string length intrinsic
Mike McLaughlin [Fri, 5 May 2017 05:48:21 +0000 (22:48 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (#11395) again (#11415)
There was a simple msbuild property.
Issue #11381
Mike Danes [Wed, 3 May 2017 05:35:13 +0000 (08:35 +0300)]
Add missing GTF_EXCEPT when importing string length intrinsic
Jan Kotas [Fri, 5 May 2017 04:12:20 +0000 (21:12 -0700)]
Move UnmanagedMemoryStream and related types to shared CoreLib partition (#11409)
Bruce Forstall [Fri, 5 May 2017 03:55:26 +0000 (20:55 -0700)]
Add new test for COMPlus_TailcallStress=1 bug, currently disabled (#11410)
Add new test for COMPlus_TailcallStress=1 bug, currently disabled
William Godbe [Fri, 5 May 2017 02:54:53 +0000 (19:54 -0700)]
Merge pull request #11401 from wtgodbe/DeleteNis
Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs
Roman Artemev [Thu, 4 May 2017 20:14:15 +0000 (13:14 -0700)]
Fixed memory instruction selector for integer register which contants simd8 type
Karel Zikmund [Thu, 4 May 2017 23:23:21 +0000 (16:23 -0700)]
Update contributing-workflow.md
Bruce Forstall [Thu, 4 May 2017 23:07:26 +0000 (16:07 -0700)]
Refactor arm32/arm64 per-node codegen into functions (#11377)
These new functions can sometimes be shared, as they are identical or
virtually so.
In addition, the driver function genCodeForTreeNode() has been
made common.
wtgodbe [Thu, 4 May 2017 18:57:51 +0000 (11:57 -0700)]
Rename all xxx.ni.dll's to xxx.dll for Helix Crossgen runs
Mike McLaughlin [Thu, 4 May 2017 22:19:57 +0000 (15:19 -0700)]
Fix incorrect metadata on SOS.NETCore.dll (#11395)
Issue #11381
Carol Eidt [Thu, 4 May 2017 22:09:55 +0000 (15:09 -0700)]
Update first-class-structs.md
Carol Eidt [Thu, 4 May 2017 22:07:37 +0000 (15:07 -0700)]
Update first-class-structs.md
Justin Van Patten [Thu, 4 May 2017 22:05:38 +0000 (15:05 -0700)]
Use ReferenceEquals instead of Delegate.op_Equality for sentinel checks
The reference equality check is more efficient than
Delegate.op_Equality.
Ian Hays [Thu, 4 May 2017 22:01:16 +0000 (15:01 -0700)]
Remove UnmanagedMemoryStream overflow checks. (#11376)
* Remove UnmanagedMemoryStream overflow checks.
* Catch negative UMS PositionPointers
* Switch UMS PositionPointer exception order
Jan Kotas [Thu, 4 May 2017 19:37:39 +0000 (12:37 -0700)]
Fix ProjectN build break (dotnet/corert#3517)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>