Sławomir Cygan [Fri, 16 Sep 2022 16:22:14 +0000 (18:22 +0200)]
Fix src stage value in pipeline barrier used to init resolve images
srcStage cannot be 0 it synchronization2 feature is not explicitely
required (enabled) by the test.
Components: Vulkan
VK-GL-CTS Issue: 3949
Change-Id: I66d3b5b55ca3732ede7284a010a68841c0a04275
Affects: dEQP-VK.pipeline.*.multisample.misc.dynamic_rendering.*
Slawomir Cygan [Tue, 22 Nov 2022 16:50:16 +0000 (17:50 +0100)]
Allow 0 creation duration for pipeline libraries without shaders
Affects: dEQP-VK.pipeline.pipeline_library.creation_feedback.graphics_tests.*
VK-GL-CTS Issue: 4130
Components: Vulkan
Change-Id: Iebdeb76d30d4144ccba83c7d3ad4de7f269552c8
Piotr Byszewski [Sun, 18 Dec 2022 16:24:48 +0000 (17:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I473fdbb6258063ddc4b07598519f9212cf4850ef
Piotr Byszewski [Fri, 16 Dec 2022 16:02:14 +0000 (17:02 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I5b755219964c807f381973f14ad15f7806eb44ab
Slawomir Cygan [Mon, 14 Nov 2022 16:28:10 +0000 (17:28 +0100)]
Add randomized constants to shaders in compare_link_times test
Add some randomization to shaders in compare_link_times test
to get reproductible compilation times.
VK-GL-CTS Issue: 4109
Components: Vulkan
Affects:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.timing.compare_link_times
Change-Id: Idbd38d611edc955916b2c756115702cccd16a7d8
ziga-lunarg [Sat, 10 Dec 2022 22:09:31 +0000 (23:09 +0100)]
Fix invalid framebuffer in compressed texture 3D tests
Framebuffer attachments must be created with viewType not equal to
VK_IMAGE_VIEW_TYPE_3D
Components: Vulkan
VK-GL-CTS issue: 4118
Affected tests:
dEQP-VK.texture.compressed_3D.*
Change-Id: I221fcc033266f8c344079f9ee9b1fa70c56d9dd9
ziga-lunarg [Mon, 5 Dec 2022 14:12:06 +0000 (15:12 +0100)]
Fix stencil op in depth bounds tests
If stencil attachment is in a read only layout and stencil test is
enabled, the stencil ops in VkPipelineDepthStencilStateCreateInfo must
be VK_STENCIL_OP_KEEP
Components: Vulkan
VK-GL-CTS issue: 4155
Affected tests:
dEQP-VK.dynamic_state.*.ds_state.depth_bounds_2*
Change-Id: Ifeb2ddca71e5cbd60afebd8d8b6dd77b5e7f2e9b
Friedrich Vock [Mon, 5 Dec 2022 08:13:06 +0000 (09:13 +0100)]
Fix result image format in RT pipeline flags test
Tests were using an rgba32i format (VK_FORMAT_R32G32B32A32_SINT) but
declaring it in the shader as r32i.
Affects:
dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*
Components: Vulkan
VK-GL-CTS issue: 4151
VK-GL-CTS public issue: 365
Change-Id: Ia9dbd97544fce8a29a4fe7270fc617981648032f
Charlie Turner [Wed, 23 Nov 2022 21:35:05 +0000 (21:35 +0000)]
Adds missing multisample state structs.
When compiling a fragment shader pipeline library, the fragment shader
state is defined by, among other state, the
VkPipelineMultisampleStateCreateInfo if sample shading is enabled.
In the affected tests, a fragment shader module was being compiled
which accessed builtins decorated with SampleId. This in turn enabled
sample shading, and in such cases, the
VkPipelineMultisampleStateCreateInfo is potentially required by
drivers for their internal logic. For this reason the spec mandates
the struct's inclusion in the fragment shader state when sample
shading is enabled.
Unfortunately it's not simple to change the GraphicsPipelineWrapper to
avoid this erroneous configuration, since in general it would require
parsing the SPIR-V to check if the fragment shader is accessing any
input builtins with the problematic decorations.
Instead a validation run was done over
dEQP-VK.pipeline.pipeline_library.* to ensure there aren't other
callsites falling into this trap, and no other cases were found.
Components: Vulkan
Affects:
dEQP-VK.pipeline.pipeline_library.multisample.*
VK-GL-CTS issue: 3975
Change-Id: I33a6b391af800eb6c23d846b70a4aac2387a74e3
Piotr Byszewski [Fri, 16 Dec 2022 14:13:57 +0000 (15:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I2d8979c34c4b9a18509e5c00ba123fa2a7520451
Andrew Fobel [Mon, 5 Dec 2022 21:16:01 +0000 (16:16 -0500)]
Fix VK_KHR_global_priority tests
Use enabledExtensions to properly enable VK_EXT_global_priority_query
along with passing the globalPriorityQueryFeatures struct.
Components: Vulkan
VK-GL-CTS issue: 4157
Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*
Change-Id: Ib024f187f835914bbcb94e42a40d60a32fed0f99
Piers Daniell [Mon, 5 Dec 2022 22:01:43 +0000 (15:01 -0700)]
Work around deArraySizeHelper deficiency with multi-dimension arrays
This fixes a compilation issue with some compilers with deArraySizeHelper
and implicitly sized multi-dimensional arrays.
Affects:
Compilation only.
Components: Framework, Vulkan
VK-GL-CTS issue: 4158
Change-Id: Ie200647f34096b54544aff7f8d82b1eefabbd586
Piotr Byszewski [Fri, 16 Dec 2022 12:35:27 +0000 (13:35 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Id3cf5e258bce8b7aec13bc44abdada774159136b
Piotr Byszewski [Fri, 16 Dec 2022 11:15:18 +0000 (12:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ifdc6f7c08ccb5f65d44e406a7dc6ea6866102ad5
Piotr Byszewski [Fri, 16 Dec 2022 08:42:48 +0000 (09:42 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ib14adccc08aa0dd8767e6dea0199e021885d292d
ziga-lunarg [Sat, 19 Nov 2022 13:02:59 +0000 (14:02 +0100)]
Fix errors in sparse resources tests
VK_EXT_shader_image_atomic_int64 extension must be enabled on the device
if used
Feature structs from non-enabled extensions must not be passed to
VkDeviceCreateInfo pNext
Checks if image formats are supported are missing
Components: Vulkan
VK-GL-CTS issue: 4122
Affected tests:
dEQP-VK.sparse_resources.shader_intrinsics.*
Change-Id: I4fcac8eae1d53826d5ef5f8a7dcc04bfe95f7360
ziga-lunarg [Fri, 18 Nov 2022 18:49:35 +0000 (19:49 +0100)]
Fix subpass dependency dstStageMask in shader_fragment_mask tests
Stage VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUT_BIT must be included if
access mask is VK_ACCESS_COLOR_ATTACHMENT_READ_BIT
Components: Vulkan
VK-GL-CTS issue: 4120
Affected tests:
dEQP-VK.pipeline.*.shader_fragment_mask.*
Change-Id: Iea2a62ff5781c50ad39d707a8eb0f1f4ce344f48
Yun Shu [Mon, 5 Dec 2022 08:20:43 +0000 (16:20 +0800)]
Set correct pipeline barrier between clear image and trace ray
The image is cleared with fixed value, then used as write destination
in ray tracing shaders. The pipeline barrier set for the image is
incorrect between clear command and trace ray command.
Affects:
dEQP-VK.ray_tracing_pipeline.large_shader_set.*
Components: Vulkan
VK-GL-CTS issue: 4137
Change-Id: I41dd55d51ea995c4c878e053f6d617b2e38ba5b1
Amber [Mon, 21 Nov 2022 10:54:07 +0000 (11:54 +0100)]
Add check for the return value of vkGetPhysicalDeviceImageFormatProperties2
Also do not attempt to create images for depth/stencil usage using color formats.
Components: Vulkan
VK-GL-CTS issue: 4125
Affected tests:
dEQP-VK.api.external.memory.dma_buf.suballocated.image.info
Change-Id: If1f41b967d03f1b862c85277d6fe30b20ab1a110
Slawomir Cygan [Tue, 22 Nov 2022 16:37:51 +0000 (17:37 +0100)]
Remove clearing of pipeline creation feedbacks while veryfying them
This re-enables verification of pipeline creation feedbacks by not
zeroing them out just before verification.
VK-GL-CTS Issue: 4129
Affects: dEQP-VK.pipeline.pipeline_library.creation_feedback.graphics_tests.*
Components: Vulkan
Change-Id: I37010973db235f993b85e9ac3c2645ae5b2db79e
Matthew Netsch [Thu, 8 Dec 2022 21:12:41 +0000 (21:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: Ieafa2f3085c673bd861f1e4ddff26897a16b43d9
Matthew Netsch [Thu, 8 Dec 2022 20:28:58 +0000 (20:28 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ie018c65908482fac3de9a6030d79029e2429d734
Hyunjun Ko [Tue, 29 Nov 2022 05:09:41 +0000 (14:09 +0900)]
Fix to get supported depth format instead of using VK_FORMAT_D32_SFLOAT
always.
Affets:
dEQP-VK.pipeline.pipeline_library.graphics_library.*
VK-GL-CTS Issue: 4142
Components: Vulkan
Change-Id: Ia8cb48061acd4813aecabb050c775a27ce1b4926
Matthew Netsch [Thu, 8 Dec 2022 19:57:31 +0000 (19:57 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I193ea9253a0d2d405e25d951ba1564f5ad805f3b
Matthew Netsch [Thu, 8 Dec 2022 18:58:13 +0000 (18:58 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Icc350abe29e7c1545a65d99884a281cd63239fc4
Matthew Netsch [Thu, 8 Dec 2022 18:30:33 +0000 (18:30 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ibfc5624676bae49d9630978494cdfdc660a0fba4
Matthew Netsch [Thu, 8 Dec 2022 18:01:39 +0000 (18:01 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: If5512ea90e2442bc7304502d78cc3b1333f53479
ziga-lunarg [Sun, 4 Dec 2022 20:48:26 +0000 (21:48 +0100)]
Write gl_PointSize in depth tests
Some depth tests use VK_PRIMITIVE_TOPOLOGY_POINT_LIST but the shaders
don't write the point size
Components: Vulkan
VK-GL-CTS issue: 4153
Affected tests:
dEQP-VK.pipeline.*.depth.*
Change-Id: Idaa9ea65f7c43ca02d7780d1825d4558b712a133
ziga-lunarg [Mon, 5 Dec 2022 15:34:50 +0000 (16:34 +0100)]
Add check if format is supported in external memory host tests
Format properties for format used for color attachment must contain
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT
Components: Vulkan
VK-GL-CTS issue: 4156
Affected tests:
dEQP-VK.memory.external_memory_host.bind_image_memory_and_render.*
Change-Id: Ib0346cbc849b94a5af67e5645cc057ca392f9b2f
ziga-lunarg [Fri, 18 Nov 2022 18:11:56 +0000 (19:11 +0100)]
Fix invalid framebuffer in compressed texture 3D tests
Framebuffer attachments must be created with viewType not equal to
VK_IMAGE_VIEW_TYPE_3D
Components: Vulkan
VK-GL-CTS issue: 4118
Affected tests:
dEQP-VK.texture.compressed_3D.*
Change-Id: I9ae036d02daa3579567bf514c70bf623a0bc9aa9
ziga-lunarg [Sat, 19 Nov 2022 19:06:44 +0000 (20:06 +0100)]
Fix flushing memory range in memory model shared tests
Each size of pMemRanges in vkFlushMappedMemoryRanges must be either a
multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or equal to the
size of memory
Components: Vulkan
VK-GL-CTS issue: 4123
Affected tests:
dEQP-VK.memory_model.shared.*
Change-Id: I0f3ea96736aa73eb92c7809c04297923d84e348c
ziga-lunarg [Sun, 13 Nov 2022 15:41:10 +0000 (16:41 +0100)]
Fix errors in dynamic rendering suballocation tests
attachmentCount in vkCmdClearAttachments must be greater than 0
depth aspect must only be cleared if depth attachment is set
stencil aspect must only be clear if stencil attachment is set
Components: Vulkan
VK-GL-CTS issue: 4102
Affected tests:
dEQP-VK.dynamic_rendering.*.suballocation.*
Change-Id: Id7cc51794883863aa9add62adee55ef30c0f6a28
Marc Alcala Prieto [Fri, 18 Nov 2022 15:24:34 +0000 (16:24 +0100)]
Fixes for VK_EXT_image_compression_control swapchain tests
Ensure VK_KHR_get_surface_capabilities2 is requested when creating
Vulkan instances for the swapchain tests. This is required by
functions:
- vkGetPhysicalDeviceSurfaceCapabilities2KHR
- vkGetPhysicalDeviceSurfaceFormats2KHR
Enable imageCompressionControlSwapchain when creating devices for the
swapchain tests.
Properly set compressionControlPlaneCount depending on compression
flags.
Components: Vulkan
VK-GL-CTS issue: 4105
Affects:
dEQP-VK.api.image_compression_control.swapchain.*
Change-Id: I6b1ac25724ac605b91824e784a018f3e4fd717b7
Matthew Netsch [Thu, 1 Dec 2022 22:00:51 +0000 (22:00 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I4d3f1c8018aa246031409d52a6aa6716a95a67c7
Marc Alcala Prieto [Fri, 18 Nov 2022 15:10:41 +0000 (16:10 +0100)]
Fixes for VK_EXT_image_compression_control tests
Fix the validation logic to check planes depending on format, not
compressionControlPlaneCount.
Properly set compressionControlPlaneCount and
pFixedRateFlags depending on compression flags.
Components: Vulkan
VK-GL-CTS issue: 4105
Affects:
dEQP-VK.api.image_compression_control.*
Change-Id: I492febb4163867ee722cd49e75cc8646aa8376f5
Matthew Netsch [Thu, 1 Dec 2022 20:14:56 +0000 (20:14 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ibbddec7b6ff3801fef7d359eb08935808a7cfe65
Slawomir Cygan [Thu, 10 Nov 2022 16:12:05 +0000 (17:12 +0100)]
Use pipeline layout alongside with fragment shader stage
In pipeline libraries, pipeline layout is requried if fragment
shader is present in the pipeline.
Affects: dEQP-VK.pipeline.pipeline_library.graphics_library.misc.bind_null_descriptor_set.*
VK-GL-CTS Issue: 4096
Components: Vulkan
Change-Id: Ia70b0f18f497e2e9102e7748c87ea5e5092098bc
ziga-lunarg [Sat, 12 Nov 2022 00:13:43 +0000 (01:13 +0100)]
Fix color blend state color attachments in depth tests
The number of color attachment in pColorBLendState must match the number
of color attachment in the subpass when creating the pipeline
Components: Vulkan
VK-GL-CTS issue: 4058
Affected tests:
dEQP-VK.pipeline.*.depth.*
Change-Id: Ibce5ff044c0804218d56d452eea7973c4c3a2990
Matthew Netsch [Thu, 1 Dec 2022 18:29:04 +0000 (18:29 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I699095999ad69b1ce79e50c3db6a06410005bdb5
Matthew Netsch [Thu, 1 Dec 2022 17:33:11 +0000 (17:33 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Iacdc3192254c41c569dbad94d8025b936f93cc25
Matthew Netsch [Thu, 1 Dec 2022 17:05:02 +0000 (17:05 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I7a7605b2dffeaedac543e32d97f13f552d6ab68f
ziga-lunarg [Fri, 4 Nov 2022 22:56:17 +0000 (23:56 +0100)]
Re-add texture filtering tests with rgba10x6 format
These tests were removed when only the check for
formatRgba10x6WithoutYCbCrSampler feature was missing
Components: Vulkan
VK-GL-CTS issue: 3646
New tests:
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_linear
Change-Id: Ida3cb9f1abd95f57908b9540c65605cbb1b40fa3
Matthew Netsch [Thu, 1 Dec 2022 16:37:27 +0000 (16:37 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I36f8b8142517f82d581ee2bc365a97ff37a63dc8
Hyunjun Ko [Wed, 23 Nov 2022 08:46:24 +0000 (17:46 +0900)]
Fix invalid usage of descriptorCount for inline uniform
blocks.
Affects:
dEQP-VK.binding_model.descriptorset_random.*.iublimit*
VK-GL-CTS Issue: 4115
Components: Vulkan
Change-Id: I649d86b859ca642b47c1fda4aa915e1d6616c898
Gary Sweet [Thu, 24 Nov 2022 09:16:09 +0000 (09:16 +0000)]
Fix for 16 to 8-bit storage spirv_assembly tests
The output buffer was being made smaller than it was required to
hold all the results. Robust buffer accesss prevented the writes
from trampling memory after the buffer, but could mean that the
data in the valid part of the buffer was incorrectly written instead.
This change makes the output buffer large enough to prevent the
out-of-bounds writes.
Components: Vulkan
VK-GL-CTS issue: 4126
Affected tests:
dEQP-VK.spirv_assembly.instruction.graphics.8bit_storage.storagebuffer_int_16_to_8.*
Change-Id: I59145be8012f7a31037ee3fee4d7ac96a198bc00
Mike Byrne [Wed, 19 Oct 2022 11:16:55 +0000 (12:16 +0100)]
Fix barriers in dynamic rendering fragment density tests
Added additional barrier to ensure work on subsampled image is
complete before copy to output image.
Manual cherry-pick from vulkan-cts-1.3.1
Affects: dEQP-VK.dynamic_rendering.primary_cmd_buff.fragment_density_map*
dEQP-VK.dynamic_rendering.complete_secondary_cmd_buff.fragment_density_map*
dEQP-VK.dynamic_rendering.partial_secondary_cmd_buff.fragment_density_map*
Components: Vulkan
VK-GL-CTS Issue: 3796
Change-Id: I8d2276f6517cea7cd173a8f9b3bd7d40cebf3e6d
Mohd Faisal [Thu, 3 Nov 2022 13:41:42 +0000 (13:41 +0000)]
Fix to use the correct vulkan device
Wrong device used to create secondary command buffer with
command pool created with different vulkan device.
Affected tests:
dEQP-VK.dynamic_rendering.complete_secondary_cmd_buff.
fragment_density_map.*
Components: Vulkan
VK-GL-CTS issue: 4084
Change-Id: I878a3d43eb48cf033379da92d06c212f7a70ec29
Matthew Netsch [Thu, 17 Nov 2022 22:26:17 +0000 (22:26 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I3aae4026dd68350cf7f4e402e94f315498dfe4d8
Matthew Netsch [Wed, 16 Nov 2022 21:01:09 +0000 (13:01 -0800)]
Fixes barycentric test float64 support check
Barycentric tests were not checking shaderFloat64 check
Components: Vulkan
VK-GL-CTS Issue: 4112
Affects:
dEQP-VK.fragment_shading_barycentric.*double*
Change-Id: Ie31ab9998e6bd9a8f551d4906f7cbda7417ea94b
Matthew Netsch [Thu, 17 Nov 2022 20:32:24 +0000 (20:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ib92b3d3b2282186df729d4694083ccaec6e3c525
Lionel Landwerlin [Sun, 16 Oct 2022 23:09:01 +0000 (01:09 +0200)]
Fix color blend state color attachments in depth tests
The number of color attachments in pColorBlendState must match the
number of color attachments in the subpass when creating the pipeline
Components: Vulkan
VK-GL-CTS issue: 4058
Affected tests:
dEQP-VK.pipeline.*.depth.*
dEQP-VK.pipeline.*.stencil.*
Change-Id: Id2c911dc88c4169a9c800b4a1ff7d505bec91234
Matthew Netsch [Thu, 17 Nov 2022 18:32:21 +0000 (18:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I2550c13c4df05f75c68a39aef76c1b9a032cfb94
James Fitzpatrick [Mon, 14 Nov 2022 09:51:50 +0000 (09:51 +0000)]
Enable VK_*_global_priority before using it
A number of tests were testing functionality from
VK_EXT_global_priority and VK_KHR_global_priority without first
enabling the extension.
Affects: dEQP-VK.api.device_init.create_device_global_priority*
Components: vulkan
VK-GL-CTS issue: 4107
Change-Id: Ib6fc36a8602f544b945fad2f5bfec3c2f8bcd72c
Matthew Netsch [Thu, 17 Nov 2022 18:07:49 +0000 (18:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I7cc1f00c66d75b85505ee76301f437ba878e5683
Matthew Netsch [Thu, 17 Nov 2022 17:39:42 +0000 (17:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ifffbd3aecc8e2d066ed988ed8fc5af4210aa88da
ziga-lunarg [Fri, 4 Nov 2022 20:22:22 +0000 (21:22 +0100)]
Add missing check for rgba10x6 features
Feature formatRgba10x6WithoutYCbCrSampler must be supported if image is
created with format VK_FORMAT_R10x6G10X6B10X6A10X6_UNORM_4PACK16 and
level count is greater than 1
Components: Vulkan
VK-GL-CTS issue: 3992
Affected tests:
dEQP-VK.pipeline.image_view.view_type.*.format.*
Change-Id: I63f7d2083ea85d9f6232540d72178bd8172b13d5
Matthew Netsch [Thu, 17 Nov 2022 17:12:03 +0000 (17:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I571894bfd5fc1ab88a09272d7452522bce76165d
Christopher Hambacher [Fri, 11 Nov 2022 20:17:58 +0000 (14:17 -0600)]
Fix failed memory map check for reconvergence tests
Tests are checking for ResourceError, when a failed memory map will return TestError.
Components: Vulkan
VK-GL-CTS issue: 4100
Affected tests:
dEQP-VK.reconvergence.*
Change-Id: I61fcc9f29fe19ff592b74986ac39a7e3958f06e8
Ricardo Garcia [Tue, 15 Nov 2022 15:07:16 +0000 (16:07 +0100)]
Limit number of concurrent query pools
The max concurrency tests use a heuristic to try to estimate a safe
number of objects of different types that the implementation would be
able to create, with an upper limit of 16384 objects.
However, in some implementations the creation of these objects have
external limitations that make the safe value hard to guess by only
looking at system and device memory usage. For example, the kernel
driver may impose further limits on the total number of certain objects.
This is reflected in the current tests with some lower hardcoded limits
for some types of objects, like instances, devices, synchronization
primitives and pipeline caches.
This commit halves the limit of concurrent query pools being tested to a
value that doesn't trigger any issue in the Mesa RPi drivers.
Affects:
dEQP-VK.api.object_management.max_concurrent.query_pool
VK-GL-CTS issue: 4106
Components: Vulkan
Change-Id: If88c6aa1ecd3d9c18892b38cb55907a82eee6cf8
Graeme Leese [Mon, 31 Oct 2022 16:26:41 +0000 (16:26 +0000)]
Fix reference value in YCbCr storage image tests
This was just wrong.
Components: Vulkan
VK-GL-CTS issue: 4079
Affects: dEQP-VK.ycbcr.storage_image_write.*
Change-Id: Ib149247c58cf56ef49879954960ed8a65451c10e
Matthew Netsch [Fri, 11 Nov 2022 17:21:54 +0000 (09:21 -0800)]
Update known conformance version for 1.3.4.1
Components: Vulkan, Framework
Affects:
dEQP-VK.api.driver_properties.conformance_version
Change-Id: Ibc081172636f077194b4aa5521a1490309428338
ziga-lunarg [Fri, 14 Oct 2022 21:56:22 +0000 (23:56 +0200)]
Fix calling vkCmdClearAttachments with attachmentCount 0
attachmentCount in vkCmdClearAttachment must be greater than 0
Components: Vulkan
VK-GL-CTS issue: 4041
Affected tests:
dEQP-VK.dynamic_rendering.primary_cmd_buff.suballocation.unused_clear_attachments.*
Change-Id: I86a8fc834863581e05a05ebb17c558a803a05c14
Ella Stanforth [Fri, 23 Sep 2022 13:35:47 +0000 (13:35 +0000)]
Fix premature unmap of output buffer in dEQP-VK.ycbcr.storage_image_write.*
Components: Vulkan
VK-GL-CTS issue: 4068
Affects:
dEQP-VK.ycbcr.storage_image_write.*
Change-Id: I7ee2da0802ee16b14f00776cbb4e750935223900
Austin Shafer [Thu, 3 Nov 2022 20:10:06 +0000 (13:10 -0700)]
getExportImportCompatibleModifiers: Test If Formats Support Blitting
In the dEQP-VK.drm_format_modifiers.export_import* tests the
getExportImportCompatibleModifiers function verifies that the DRM
format modifiers and their corresponding VkFormats support transfer
operations, but these tests also perform blitting on images
created/imported with modifiers. This causes test failures in scenarios
where a modifier doesn't support blitting, such as
`DRM_FORMAT_MOD_LINEAR` on Nvidia hardware.
This change adds the VK_FORMAT_FEATURE_BLIT_*_BIT flags to
getExportImportCompatibleModifiers, properly limiting the modifiers
tested to ones that have reported the proper features.
VK-GL-CTS issue: 4086
Affects:
dEQP-VK.drm_format_modifiers.export_import*
Change-Id: If7adcaff730b150a0aa9afedb43737380a23fe55
Matthew Netsch [Fri, 11 Nov 2022 15:58:21 +0000 (15:58 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: I5380a0c1ee46d052c86131d54fce2835cff9b9fc
Matthew Netsch [Wed, 17 Aug 2022 19:35:23 +0000 (19:35 +0000)]
Reintroduce tests for acceleration structure size query
VK-GL-CTS Issue: 3836
Components: Vulkan
Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.*.*.*.structure_size
Change-Id: Ie6d5bb49ef25f8066c83606d8307ebadb195f1a9
Matthew Netsch [Thu, 10 Nov 2022 22:07:01 +0000 (22:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: If6c415f4dddeb997b23aba4075f9608b2c99ddb8
ziga-lunarg [Sun, 16 Oct 2022 23:09:01 +0000 (01:09 +0200)]
Fix color blend state color attachments in depth tests
The number of color attachments in pColorBlendState must match the
number of color attachments in the subpass when creating the pipeline
Components: Vulkan
VK-GL-CTS issue: 4058
Affected tests:
dEQP-VK.pipeline.*.depth.*
Change-Id: I1b566bd4aec80873631fe1edbb2ced47441c877a
ziga-lunarg [Sun, 16 Oct 2022 22:08:53 +0000 (00:08 +0200)]
Add missing image memory barrier in ray tracing pipeline tests
Image layout transition from VK_IMAGE_LAYOUT_UNDEFINED to
VK_IMAGE_LAYOUT_GENERAL is missing
Components: Vulkan
VK-GL-CTS issue: 4056
Affected test:
dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*
Change-Id: I6c969985061b1c3e165148da24f899d5a7607e2a
Sławomir Cygan [Fri, 14 Oct 2022 10:55:48 +0000 (12:55 +0200)]
Fix compressed texture tests always returning Pass
The test, if supported, was always returning Pass
disregarding the texture comparison result.
Affects: dEQP-VK.texture.compressed.*
VK-GL-CTS Issue: 4040
Components: Vulkan
Authored-by: Dorian R Apanel <dorian.r.apanel@intel.com>
Change-Id: I1da7204d248af3f6122f3acbe412980a86f6a403
Matthew Netsch [Thu, 10 Nov 2022 19:32:44 +0000 (19:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Ide448246c50fedae41f37859022c20fffa764a1c
ziga-lunarg [Sun, 16 Oct 2022 17:34:09 +0000 (19:34 +0200)]
Enable minLod feature when used
The tests use VkImageViewMinLoadCreateInfoEXT::minLod, but do not enable
the minLod feature
Components: Vulkan
VK-GL-CTS issue: 4052
Affected tests:
dEQP-VK.texture.mipmap.3d.image_view_min_lod.min_lod.*
Change-Id: I2bf99e7543d3ebb799d50ac5f644cc2e12d535e2
Matthew Netsch [Thu, 10 Nov 2022 19:08:10 +0000 (19:08 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I1e2379907371708b4f3fb556938acb39f3f2f5bc
ziga-lunarg [Fri, 14 Oct 2022 21:03:32 +0000 (23:03 +0200)]
Fix wrong format in unused clear attachment tests
VkPipelineRenderingCreateInfo::depthAttachmentFormat must be a format
that includes a depth aspect or VK_FORMAT_UNDEFINED
VkPipelineRenderingCreateInfo::stencilAttachmentFormat must be a format
that includes a stencil aspect or VK_FORMAT_UNDEFINED
Components: Vulkan
VK-GL-CTS issue: 4041
Affected tests: dEQP-VK.dynamic_rendering.*.unused_clear_attachments.*
Change-Id: I8b003dd2a831e9205f6f91ea00c3ddf2541b512a
Matthew Netsch [Thu, 10 Nov 2022 18:39:54 +0000 (18:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I9f9902ca38ce71e194a12f5aacff73afaaa37972
Ricardo Garcia [Fri, 21 Oct 2022 14:19:52 +0000 (16:19 +0200)]
Add missing checks for geometry shader support
Affects:
dEQP-VK.multiview.*geometry*
dEQP-VK.subgroups.*geometry*
dEQP-VK.fragment_shading_rate.*.gs*
VK-GL-CTS issue: 4064
Components: Vulkan
Change-Id: I64a3b6d7adc8da7671817710c4a4882db2c27035
ziga-lunarg [Sat, 15 Oct 2022 00:03:25 +0000 (02:03 +0200)]
Add missing read without format bit check in robustness tests
If buffer view is being read as storage texel buffer with image format
of OpTypeImage being Unknown then the view's buffer features must
contain VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT
Components: Vulkan
VK-GL-CTS issue: 4047
Affected tests:
dEQP-VK.robustness.robustness2.bind.*
Change-Id: I46e5482fbfea3a945b133dbca0e020159049516f
ziga-lunarg [Fri, 14 Oct 2022 23:24:43 +0000 (01:24 +0200)]
Fix stencilAttachmentFormat in inverted depth ranges tests
If format is not VK_FORMAT_UNDEFINED in
VKPipelineRenderingCreateInfo::stencilAttachmentFormat then it must be a
format that includes a stencil aspect
Components: Vulkan
VK-GL-CTS issue: 4046
Affected tests:
dEQP-VK.draw.dynamic_rendering.inverted_depth_ranges.*
Change-Id: Ia0dcb1989b8ace78632d26dd0a1e3c1101f5f547
Matthew Netsch [Thu, 10 Nov 2022 18:12:22 +0000 (18:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I46781852d8da0c1c3d65c9435cf93cd05ce1781b
ziga-lunarg [Sun, 16 Oct 2022 22:42:52 +0000 (00:42 +0200)]
Fix viewport width in FSR with multiviewport tests
Tests with extent 1x1 create viewport with width equal to 0.0f
Components: Vulkan
VK-GL-CTS issue: 4057
Affected tests:
dEQP-VK.fragment_shading_rate.*
Change-Id: I99a050348de83d1790320bd5d6d711722dd1fbaf
ziga-lunarg [Sat, 15 Oct 2022 19:51:22 +0000 (21:51 +0200)]
Fix image barrier oldLayout in timeline semaphore tests
Image layout in image barrier must be updated after first transition
Components: Vulkan
VK-GL-CTS issue: 4049
Affected tests:
dEQP-VK.synchronization.timeline_semaphore.one_to_n.*
Change-Id: I7fde2342007a3ec9c2562375fd634539e186acdc
ziga-lunarg [Sun, 16 Oct 2022 19:45:02 +0000 (21:45 +0200)]
Fix barrier in ray tracing pipeline build tests
If access mask is VK_ACCEDSS_ACCELERATION_STRUCTURE_WRITE_BIT_KHR then
stage must be VK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHR
Components: Vulkan
VK-GL-CTS issue: 4053
Affected tests:
dEQP-VK.ray_tracing_pipeline.build.*
Change-Id: I0a8080881f944319aae2417e5f9fe3297b933dd7
ziga-lunarg [Sun, 16 Oct 2022 01:50:25 +0000 (03:50 +0200)]
Fix pMutableDescriptorTypeLists in mutable descriptor tests
pMutableDescriptorTypeLists between srcBinding and dstBinding must match
exactly for copying descriptor sets
Components: Vulkan
VK-GL-CTS issue: 4051
Affected tests:
dEQP-VK.binding_model.mutable_descriptor.*
Change-Id: I64445e84ccd4872789a3db8b15e005d36c08d8a4
Hyunjun Ko [Fri, 21 Oct 2022 00:27:05 +0000 (09:27 +0900)]
Fix to reset dynamicDenstiyMap after dynamic subsampled tets done.
Affects:
dEQP-VK.*.fragment_density_map.*.static_nonsubsampled*
dEQP-VK.*.fragment_density_map.*.deferred_nonsubsampled*
VK-GL-CTS Issue: 4062
Components: Vulkan
Change-Id: Ib347bd6e4734b2928ccacfa17dd01dfc134301bb
ziga-lunarg [Fri, 14 Oct 2022 22:53:12 +0000 (00:53 +0200)]
Fix flush memory range in ssbo corner case tests
The size in VKMappedMemoryRange used in vkFlushMappedMemoryRanges must
either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or
offset + size must be equal to the size of memory
Components: Vulkan
VK-GL-CTS issue: 4044
Affected tests:
dEQP-VK.ssbo.corner_case.*
Change-Id: I9ea2ee1e055b55ec39988a6ec0539cd3219937f4
ziga-lunarg [Fri, 14 Oct 2022 23:11:59 +0000 (01:11 +0200)]
Fix flush memory range in robustness vertex access tests
The size in VkMappedMemoryRange used in vkFlushMappedMemoryRanges must
either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or
offset + size must be equal to the size of memory
Components: Vulkan
VK-GL-CTS issue: 4045
Affected tests:
dEQP-VK.robustness.vertex_access.r32_sint.draw.*
Change-Id: I3d0944b6c6808dc66de0c9dc25f6c4e99578a1cf
ziga-lunarg [Sat, 15 Oct 2022 22:05:50 +0000 (00:05 +0200)]
Add shader image atomic int64 extension if used when creating device
Add VK_EXT_shader_image_atomic_int64 extension and enabled the features
when creating the device in sparse resources tests if the extension
is used
Components: Vulkan
VK-GL-CTS issue: 4050
Affected tests:
dEQP-VK.sparse_resources.*
Change-Id: If3de1d1e30a57db076802e2933392081c7c3069c
ziga-lunarg [Fri, 14 Oct 2022 22:30:38 +0000 (00:30 +0200)]
Fix attachment description in explicit vertex parameter tests
If initialLayout is VK_IMAGE_LAYOUT_UNDEFINED then loadOp must not be
VK_ATTACHMENT_LOAD_OP_LOAD
Components: Vulkan
VK-GL-CTS issue: 4043
Affected tests:
dEQP-VK.draw.explicit_vertex_parameter.*
Change-Id: I94cd72967798d424081f13033d1afbb3e11d993b
Marcin Kańtoch [Thu, 13 Oct 2022 14:11:14 +0000 (16:11 +0200)]
PGQ tests overwrite gl_Position output from vs
dEQP-VK.transform_feedback.primitives_generated_query.* tests after the change
https://gerrit.khronos.org/c/vk-gl-cts/+/9450
overwrite the gl_Position output from vertex shader.
This is incorrect and causes failures.
Removed the gl_Position = vec4(1.0f); line from vs.
Affects:
dEQP-VK.transform_feedback.primitives_generated_query.*
Components: Vulkan
VK-GL-CTS issue: 4039
Change-Id: Ib48d3f5d22a0ce41d9c4a52ebf3d8666f1b08c0e
Matthew Netsch [Fri, 28 Oct 2022 20:12:44 +0000 (20:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4
Change-Id: Id9f7f82a7a889bc2c668afa13d65883e506634f8
ziga-lunarg [Tue, 11 Oct 2022 15:38:01 +0000 (17:38 +0200)]
Add missing flag in ray tracing with queries tests
Command buffer is reused but it is allocated from a command pool that
did not have VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT flag
Components: Vulkan
VK-GL-CTS issue: 4033
Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.*
Change-Id: I68888c2a08647e9d77122e5888aba8f66d849f11
Matthew Netsch [Thu, 27 Oct 2022 19:04:07 +0000 (19:04 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Iaf15595051e9e11e259a92c75d74f45881131dd7
Iván Briano [Tue, 18 Oct 2022 21:50:40 +0000 (14:50 -0700)]
Fix using NULL for the default color blend state
Since graphics pipeline libraries was merged, we need to explicitly ask
for NULL to mean the default state when creating a pipeline.
Components: Vulkan
VK-GL-CTS issue: 4061
Affected tests:
dEQP-VK.pipeline.*stencil.*
Change-Id: If09ad15322cbc7e39ba4ae9c4cf9825ff131cd46
ziga-lunarg [Tue, 11 Oct 2022 22:12:04 +0000 (00:12 +0200)]
Fix independent_pipeline_layout_sets tests
These bugs are already fixed in the main branch, but not in others
Invalid pipeline stages are used in pipeline barriers and wrong vertex
binding and description counts
Components: Vulkan
VK-GL-CTS issue: 4035
Affected tests:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.independent_pipeline_layout_sets.*
Change-Id: I4c68ac57bd616cdbc2147d725d5b6ea1d6874d90
Matthew Netsch [Thu, 27 Oct 2022 18:31:37 +0000 (18:31 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I175ea10a0a7a64890834267adfc74ec62fee48d3
ziga-lunarg [Wed, 21 Sep 2022 01:38:41 +0000 (03:38 +0200)]
Fix VK_KHR_global_priority tests
Support for priorities must be queries and if a priority is used but not
reported by VkQueueFamilyGlobalPriorityPropertiesKHR the driver must
fail with VK_ERROR_INITIALIZATION_FAILED
Components: Vulkan
VK-GL-CTS issue: 3898
Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*
Change-Id: I5570006758e73522968a2399a2a4294588b2dde5
Matthew Netsch [Thu, 27 Oct 2022 18:07:00 +0000 (18:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I96317661558490598f309c45bc9a6d040b937d13
Matthew Netsch [Thu, 27 Oct 2022 17:38:34 +0000 (17:38 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I4b3c2c0c9e8185a634b8917faa9b67cd97469fe7
Matthew Netsch [Thu, 27 Oct 2022 17:10:48 +0000 (17:10 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I398ca9776ea24153af3f5cc4bd4db4812333d76a
ziga-lunarg [Mon, 10 Oct 2022 22:39:37 +0000 (00:39 +0200)]
Fix loadOp in imageless framebuffer test
If initial layout in attachment descriptions is
VK_IMAGE_LAYOUT_UNDEFINED, then the load op must not be
VK_ATTACHMENT_LOAD_OP_LOAD
Components: Vulkan
VK-GL-CTS issue: 4030
Affected tests:
dEQP-VK.imageless_framebuffer.*
Change-Id: I5e7f3f5e440dd380a05cf82127af4bea2538fdd2