Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I9f1e4eba89eb77636a4b58312efa86ada45b0945

Update drivers ids

From last version of Vulkan-Docs.

Components: Framework
VK-GL-CTS issue: 3173

Change-Id: I39aeb4f16d3bf19291a5a266595b215681ef2c83
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I6f96b469518264e53fdd142f445187f8eb091c6d

Relax get_frame_timestamps

To prevent power side effect from legacy platform. We tend to relax the
deqp criteria from 3 vsyncs to 4 vsyncs. And verify timestamp 6 frames
ago.

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/db1f80ba923b9e89177562203c21192f8e7340c3
https://android-review.googlesource.com/c/platform/external/deqp/+/918914
Submitted on behalf of a third-party: barry.ko@mediatek.com

Component: EGL

Affected tests:
dEQP-EGL.functional.get_frame_timestamps.*

BUG: 123203074
Change-Id: I214b410d2ab8f0d6d4b3f9d6752c1c1d756cc28f

Make renderdoc build-time integration optional

In some environments (Android Q CTS), renderdoc headers will not be
available.

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/7e79367bd8fa1430c0ea161a36f62d7b8edc6803

Components: Vulkan, Framework

Bug: b/123431604

Change-Id: I7d4e36074e4f89a81f55dde83a217920653ad173

Merges vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I1cbb115f9efbb2df6de81b0b133723b15e367427

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I6873657c378b02b383da36905a31886806519459

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I67159d811b780fc975c41a18043c177bceba6da7

Fix zx_handle_t typedef

Change from signed to unsigned 32-bit integer to match zircon/types.h.

Components: Framework, Vulkan

VK-GL-CTS issue: 3214

Change-Id: Ic887e90adc1583cfcd1518e21831d330e0f89b17

Fix tessellation SPIR-V tests use of Restrict

Their usage of Restrict violates the SPIR-V spec which requires that it
only got on variables, not types or struct members.

Affected tests:
dEQP-VK.tessellation.*

Components: Vulkan
VK-GL-CTS issue: 2975

Change-Id: Ifbde1b493bf56d1ee6454a4ab54e98bcd05f839b

Allowing spirv1.4 shaders compilation

Components: Vulkan

VK-GL-CTS Issue: 2560

Affects: dEQP-VK.spirv_assembly.instruction.spirv1p4.*

Change-Id: Icbfe3ad623da98968eee401d08df5ed6b3b2db1e
(cherry picked from commit c96d524d079fdada26b3548effd1539174415be6)

Fix VkClearRect sizes for vkCmdClearAttachment()

The test was doing out-of-bounds clears of attachments.

Components: Vulkan
VK-GL-CTS issue: 3174

Affected tests:

   dEQP-VK.dynamic_rendering.*

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Change-Id: I6cbf82efdea824cc07aeaddf814368da5b8b5848

SpirV 1.6: Test Nontemporal image operand

This change extends existing tests to cover cases where
new Nontempporal image operand is used with:
OpImageFetch, OpImageRead,
OpImageSampleExplicitLod,OpImageWrite,
OpImageSparseSampleExplicitLod, OpImageSparseFetch,
OpImageSparseRead and OpimageSparseGather.

VK-GL-CTS issue: 3127

Components: Vulkan

Affects:
dEQP-VK.spirv_assembly.instruction.compute.image_sampler.*
dEQP-VK.sparse_resources.shader_intrinsics.*
dEQP-VK.image.extend_operands_spirv1p4.*
dEQP-VK.image.nontemporal_operand.*

Change-Id: I1ba06b7e61e5d2512f9e61cfa14c96f45e1cedb0

Partial revert of CL 8054: Fix invalid layout transitions in some dynamic rendering tests

This image barrier change was wrong. I thought this was a duplicate
barrier for the color attachment image, but it was actually
one for the depth/stencil attachment image.

Affects:

dEQP-VK.multiview.dynamic_rendering.depth.*
dEQP-VK.multiview.dynamic_rendering.stencil.*

Components: Vulkan

VK-GL-CTS issue: 3164

Change-Id: Id65e226eaec2c158289d684a0a997d8a929a5f45

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Icb78e9ab972d7942276a0f12b6bcb55ceb2878c7

Add check for shaderImageGatherExtended

There were validation errors in the tests when running them
through devsim layer and vulkan 1.0 spec minimum profile:

"VUID-RuntimeSpirv-OpImage-06376(ERROR / SPEC): msgNum: 70978435 -
Validation Error: [ VUID-RuntimeSpirv-OpImage-06376 ] Object 0: handle
= 0x66d3840, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x43b0b83 |
vkCreateShaderModule(): Shader uses OpImageGather with offset (-8)
less than VkPhysicalDeviceLimits::minTexelGatherOffset (0). The Vulkan
spec states: If an OpImage*Gather operation has an image operand of
Offset, ConstOffset, or ConstOffsets the offset value must be greater
than or equal to minTexelGatherOffset"

Components: Vulkan
VK-GL-CTS issue: 3186

Affects:

   dEQP-VK.glsl.texture_gather.offset.*

Change-Id: I1c58d751a86dbe7a1a285a32daae19955b5b4582
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Fix missing self-subpass dependency

Self-subpass dependency required for read-after-write operation, in test
cases where the attachment is written using load-op-load at the start
of subpass and then the values are read inside the fragment shader.

Affects:

dEQP-
VK.renderpass.suballocation.subpass_dependencies.separate_channels.*
dEQP-
VK.renderpass2.suballocation.subpass_dependencies.separate_channels.*

Components: Vulkan

VK-GL-CTS issue: 3216

Change-Id: I6c72b81dccfb7526ec4607b255ff4872b13c4d22

Fix workgroup_memory_explicit_layout tests SPIR-V validation errors

Components: Vulkan
VK-GL-CTS issue: 3195

Affects:

   dEQP-VK.compute.workgroup_memory_explicit_layout.*

Change-Id: I2ac798965d9a3518bc45cfe52e43f34facf4ccf4
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Verify line-stipple both with and without carry-over

The Vulkan spec specifies that carrying over the fractional parts of a
line is optional. Let's test both with and without, so we accept either.

Components: Vulkan, Framework

Public Issue: 280

Affected Tests: dEQP-VK.rasterization.primitives.static_stipple.*
dEQP-VK.rasterization.primitives_multisample_4_bit.*

Change-Id: Iaae3397ebfa1db7fbccefd479bd98c1ad8471ff8

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I02d8c267d85372b375fcdcb1df69f2c6dc97796c

Add memoryBarrier before buffer map verify

OpenGL ES 3.2 Specification Section 7.11.2:

Shader Memory Access Synchronization ...

"Explicit syncronization is required to ensure the effects of buffer and
texture data stores performed by shaders will be visible to subsequent
operations using the same objects..."

Many of the ES3.1 compute tests lack a memory barrier before mapping and
verifiying buffer contents.  This can lead to flaky test failures when
the buffer has not been completely written to by the dispatchCompute
command. Specifically, chromeos and it's android arc++ has seen
consistent, yet flaky failures in es31fSynchronizationTests.inter_invocation.

It is unclear why this test should fail when similar tests, which also
lack explicit synchronization, do not.

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/30c710319864b9e952daaaaf098df20845c2f70d
https://android-review.googlesource.com/c/platform/external/deqp/+/854112

TEST=chromeos caroline-arcnext (skylake)
Affects: dEQP-GLES31.functional.synchronization.*
Components: AOSP
Google Bug: b/85161472

Change-Id: I5093e7e206996e7c13c8c3615ee01ebbadc42f58
Signed-off-by: Joe M. Kniss <djmk@google.com>

Update Android test lists and Android files

Update Android test lists and other files to match AOSP
android12-tests-dev. Some tests are excluded from Android test lists and
some are moved between different Android test lists, but the tests
themselves do not change.

Components: AOSP
Change-Id: I28fdab5eb0b3fa75604f525a34fe843091836e75

Update Android test lists and Android files

Update Android test lists and other files to match AOSP
android12-tests-dev. Some tests are excluded from Android test lists and
some are moved between different Android test lists, but the tests
themselves do not change.

Components: AOSP
Change-Id: I28fdab5eb0b3fa75604f525a34fe843091836e75

EXT_multisampled_render_to_texture test

Detects a bug where ReadPixels fails on multisampled textures.
See http://crbug.com/890002

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/accf1be52e32153c757cd84864607ee9c47dfe9a
https://android-review.googlesource.com/c/platform/external/deqp/+/796566
Submitted on behalf of a third-party: jdarpinian@chromium.org

Components: OpenGL

New test:
dEQP-GLES2.functional.multisampled_render_to_texture.readpixels

Bug: chromium:890002
Change-Id: I6e5e5d1fa3aa15daee69271339962a0b3ffc1927

Increase tolearance for dithering tests

For small dimension render targets, gradient tests
require more tolerance, as variance in adjacent pixels
will be more compared to bigger render targets.

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/8dc015fa12e41a380b81c1b8fcc63a04bf34311a
https://android-review.googlesource.com/c/platform/external/deqp/+/971506
Submitted on behalf of a third-party: quic_spvasu@quicinc.com

Components: OpenGL

Affected tests:
dEQP-GLES3.functional.dither.*

Bug: 132146940
Change-Id: Ie48e119d164acf5763aa7956c3ff91da20ff9f38

Add watchdog touches to descriptor_pool test

On some low-end devices, this test would hit the dEQP watchdog. Add some
watchdog touches to avoid this.

Cherry pick.

Original commit:
123de98482b779ca242f9498701508b12e9a5f01
https://gerrit.khronos.org/c/vk-gl-cts/+/3197

Affected tests:
dEQP-VK.api.descriptor_pool.*

Google Bug: b/116847904
Component: Vulkan
Signed-off-by: Pierre Couillaud <pierre@broadcom.com>
VK-GL-CTS Issue: 1464

Change-Id: I18181aa274ab1dc191b5f0acbb58b41465b5cdad

Check fragment shader stores in frag shader side effect tests

Fragment shader side effect tests were using storage buffer store
operations in fragment shaders without checking support for the
fragmentStoresAndAtomics feature.

In addition, the tests were verifying the implementation supported the
color attachment and transfer features for the VK_FORMAT_R8G8B8A8_UNORM
format, but they are mandatory by the spec. The checks can be safely
removed.

Affected tests:
dEQP-VK.rasterization.frag_side_effects.*

Components: Vulkan
VK-GL-CTS issue: 3208

Change-Id: I5d28b18dd6aedbbfb1ea3ce4b40b3ba82737c27b

Use the correct view type in no_position tests

Multilayer no_position tests were creating image views with multiple
layers and the VK_IMAGE_VIEW_TYPE_2D type. When the number of layers is
greater than one, the type should be VK_IMAGE_VIEW_TYPE_2D_ARRAY.

Affected tests:
dEQP-VK.pipeline.no_position.*

Components: Vulkan
VK-GL-CTS issue: 3200

Change-Id: I9d24062c4f1ac80f12ac5dd1fe0e454ffade2f32

Check fragment shader stores in robustness tests

Some robustness tests were using fragment shader stores without checking
for the fragmentStoresAndAtomics feature.

Affected tests:
dEQP-VK.robustness.*.frag

Components: Vulkan
VK-GL-CTS issue: 3209

Change-Id: I8032bd19f7de4f2d87d642542c2b7aaec20965b8

Check cube array support in robustness tests

Some robustness tests were using VK_IMAGE_VIEW_TYPE_CUBE_ARRAY image
views without checking support for the imageCubeArray feature.

Affected tests:
dEQP-VK.robustness.*cube_array*

Components: Vulkan
VK-GL-CTS issue: 3210

Change-Id: Iafd363a6423251413a1093e15ae94aa50850af32

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I64019cfcae5bcedae55f3e343bc94f51b62aa877

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I0abe7100c16a273d62463b916957255150d344d0

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: Ib23f14c29d67945839ab3763968963d7dcc91464

Fix validation errors with unnormalized coordinates samplers

Components: Vulkan
VK-GL-CTS issue: 3190

Affects:

   dEQP-VK.pipeline.sampler.*unnormalized*

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Change-Id: I1dde344fe39289b945a434eab7276dc58deab881

Fix descriptor indexing test dependency

The UBO and SSBO non-uniform indexing tests use runtimeDescriptorArray,
so this needs to be included in the checkSupport condition.

Components: Vulkan
Affects: dEQP-VK.ubo.*
         dEQP-VK.ssbo.*

Change-Id: I54edb2d06135a8d1d549a42ac97014dabc80c9dd

Check resource limits properly

The tests were not checking the resource limits per stage when
creating the shaders, which could create potential issues on
some drivers. Specially the random generated tests.

Affected tests:

   dEQP-VK.ssbo.layout.*

Components: Vulkan
VK-GL-CTS issue: 2953

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Change-Id: I7509dce38b849a0dd26f9e47d7f74e637930d897

Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3

Change-Id: Id485bc8ae929179e7786039966a233dd6fa57cdc

Move anisotropic filtering support check to a function

Support check for anisotropic filtering was done inside of iterate.
This change moves that check inside of a function for consistency
and performance.

Affects:

dEQP-VK.texture.filtering_anisotropy.*

Components: Vulkan

VK-GL-CTS issue: 3068

Change-Id: I3a1c0a1acff96b6f6b291bb53d3d9dc0bd122c17
(cherry picked from commit 522f4ba64beee8828030320591d20faa027a8e0a)

Fix extended_dynamic_state2 tests

Before this change alias assignment was only done for
promoted extensions. With this change search for aliases
is done for all extensions listed in extensions_data.txt.

This mainly fixes issue with tests for partially promoted
VK_EXT_extended_dynamic_state2. Three entrypoints that
were not promoted to vk1.3 must still use EXT when
vk1.2 implementation is tested.

This change also removes one duplicate from extensions_data.txt.

Components: Vulkan, Framework

VK-GL-CTS Issue: 3159

Affects: dEQP-VK.pipeline.extended_dynamic_state.*

Change-Id: I552764b3559a6f78d84a2f764f0cc5250c52f0ed

Fix incorrect shader output format

For test variants that write to a stencil buffer, the final attachment
will be R8_UINT. For these tests ensure the fragment shader is
outputing to this attachment as a uint.

Affects: dEQP-VK.synchronization2.none_stage.*

Components: Vulkan

VK-GL-CTS issue: 3177

Change-Id: Ia7e185c8c8486c8b0e76e11038e0a5108770f21f

Increase tolerance for matrix precision tests

On hardware with a RTZ rounding mode the tolerance required in these
tests was too low and valid implementations of the functions would
fail the tests.

Increase the tolerance allowed to allow RTZ hardware to pass these
tests.

Affects:
dEQP-VK.glsl.builtin.precision*.determinant.*
dEQP-VK.glsl.builtin.precision*.inverse.*

Components: Vulkan

VK-GL-CTS issue: 3182

Change-Id: I83845aec8faa01aec0820852219b6b8c4326da4e

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Icd84bfefac281e224692dd83c2ac6dff87f9f43c

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I2eaed7035330ecb962466f205b3d3dd80a311d4b

Fix missing barrier in FSR pixel consistency tests

The PixelConsistency tests of Fragment Shading Rate did not have a
pipeline barrier between the calls to vkCmdClearColorImage for the
render targets and the subsequent renderpass. This caused a race between
the two.

This commit adds the missing pipeline barriers.
In addition, it converts the preImageBarrier from two calls to
vkCmdPipelineBarrier with a single barrier to a single call with two
barriers.

Components: Vulkan

Affects: dEQP-VK.fragment_shading_rate.pixel_consistency.*

VK-GL-CTS Issue: 3158

Change-Id: I14b5de4fb02593b0a384b0f36892543ee2c57222

Do not enable anisotropic filter in exact sampling tests

The anisotropic filter may introduce some extra imprecision in some
implementations. This change also makes these tests have the same
behavior in all implementations.

Affected tests:
dEQP-VK.pipeline.sampler.exact_sampling.*

Components: Vulkan
VK-GL-CTS issue: 3152

Change-Id: I0b4e1ad2c46210568176c5bd5504678edb3dbc73

Reduce resolution of some graphicsfuzz tests

These tests have a lot of shader computation, which may exceed a 30
second watchdog time limit. Reducing the resolution should allow them to
complete quickly on low-end devices.

Affects:

dEQP-VK.graphicsfuzz.nested-for-loops-switch-fallthrough
dEQP-VK.graphicsfuzz.spv-access-chains
dEQP-VK.graphicsfuzz.spv-copy-object
dEQP-VK.graphicsfuzz.spv-dead-break-and-unroll
dEQP-VK.graphicsfuzz.spv-stable-maze-flatten-copy-composite

Components: Vulkan

Change-Id: I4ca78ae1beafb3d892d437568f10cc816ae79df2

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I1d4bf5c3a9cbd2f7d8e5bdce8645065661be1e9c

Fix incorrect computation of pointer size

CTS always fills the array of pointers with a stride of 64-bits.
So, for 32-bits applications, each two 32-bits has one valid pointer
to instance of bottom-level acceleration structure.

To correct this the pointer size should be calculated as
sizeof(VkDeviceOrHostAddressConstKHR::hostAddress) for host built
top-level acceleration structure and
sizeof(VkDeviceOrHostAddressConstKHR::deviceAddress) for device built
top-level acceleration structure.

VK-GL-CTS issue: 3084
Components: Vulkan

Affects:
dEQP-VK.ray*instances_aop*

Change-Id: I8c412a5a5d2ce3f1f687795768d6d83ad4913892

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I911747cbf1726e161c457fa6ae666148ff0b36c7

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I6994a2ac890d752906a8f6464a9cb7819e22a55f

Fix crashes on depth stencil resolve tests with separate layouts

Mesa drivers were crashing in depth stencil resolve tests when
used with separate layouts.

The issue was that if layout only specifies the layout of the
depth aspect of the attachment, the layout of the stencil aspect
is specified by the stencilLayout member of a
VkAttachmentReferenceStencilLayout structure included in the
pNext chain. We were not setting it.

Affected tests:

   dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts*

Components: Vulkan
VK-GL-CTS issue: 3157

Change-Id: I72f8fdba88717ab0442501911fb26a7469da65d8
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

dEQP-VK.subgroups.*ray_tracing* missing extension check

Components: Vulkan
VK-GL-CTS issue: 3003

Affected:

dEQP-VK.subgroups.*ray_tracing*

Change-Id: I25719d00c6d0180c03726d73497727754f9539d2
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
(cherry picked from commit a63763167972c24e5a2167cb78dc009eb161a6d4)

Update dynamic rendering tests to separate formats

Depth and stencil formats were split in VK_KHR_dynamic_rendering.

VK-GL-CTS issue: 3161

Components: Vulkan

Affects:
dEQP-VK.draw_with_dynamic_rendering.*
dEQP-VK.multiview.dynamic_rendering.*
dEQP-VK.fragment_shading_rate_with_dynamic_rendering.*
dEQP-VK.renderpass_with_dynamic_rendering.*
dEQP-VK.dynamic_rendering.*

Change-Id: Id28ccb278ad6cc52b733d31076343874762d8c39

Fix stencil data unpacking in dEQP-VK.fragment_operations test

The test copies only one aspect (depth or stencil, not both) of the image
to the buffer, so host unpacking code should not use combinded DS format
 - instead S8_UIN format should be used in stencil tests.

The problem occurs in stencil tests, on implementations not supporing
S8_UINT format, where D+S format is used.

Components: Vulkan

VK-GL-CTS Issue: 3160

Affects: dEQP-VK.fragment_operations.*stencil

Change-Id: I27b69c02ebf08fa19f512cdd786ebe596d91cfeb

Fix invalid layout transitions in some dynamic rendering tests

Some of the dynamic rendering tests do an image layout transition
from uninitialized when the image is already in use. This can lead
to corruption of the image content.

This CL removes an unnecessary barrier from the
dEQP-VK.multiview.dynamic_rendering.readback* tests and fixes
a barrier with the dEQP-VK.multiview.dynamic_rendering.depth.*
and dEQP-VK.multiview.dynamic_rendering.stencil.* tests.

Affects:

dEQP-VK.multiview.dynamic_rendering.depth.*
dEQP-VK.multiview.dynamic_rendering.stencil.*
dEQP-VK.multiview.dynamic_rendering.readback*

Components: Vulkan

VK-GL-CTS issue: 3164

Change-Id: Ib0847839528909337001d32bbde59c7e979ec9e9

Do not chain dynamic render pass inheritance info in dEQP-VK.renderpass

This fixes the tests that do not use, enable or require dynamic rendering
to not chain the VkCommandBufferInheritanceRenderingInfoKHR structure,
which is only for inheritinh the dynamic renderpasses.

Affects: dEQP-VK.renderpass*

VK-GL-CTS Issue: 3165

Components: Vulkan

Change-Id: Idb8fed2bcd6a6bf664cf5516a664b8beaa94484a

Wrong format in load_store_op_none test.

One of the load_store_op_none tests is currently using the incorrect
VK_FORMAT_R8G8B8A8_UNORM format for the color attachments.
It should be using VK_FORMAT_R8G8B8A8_UINT instead.

VK-GL-CTS issue: 3154
Components: Vulkan

Affected tests:
dEQP-VK.renderpass_with_dynamic_rendering.suballocation.load_store_op_none.color_load_op_none_store_op_none_resolve

Change-Id: I7dd8b4da05fef58d91a8913ac49912ba683f033d

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Icd53be0bdc32472d88bd464dffb0ee3a8ab3677e

Fix rectangular line tests

When we're testing against rectangular lines, we need to generate the
rectangular line geometry as well, otherwise we'll test against
parallelogram lines instead.

Components: Vulkan, Framework

Public issue: 274

Affected Tests: dEQP-VK.rasterization.primitives.*.rectangular_line_*

Change-Id: I514646e94d2faf1e996950fd6b3a738797f84ff0

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I015e15ff85941f0a8756bd4b13e93fcd9161d62e

Fix dEQP-VK.glsl.opaque_type_indexing.ssbo*_compute validation error

Tests were not checking maxPerStageDescriptorStorageBuffers limits
in the compute shaders, which use more (6) than the minimum limit
set by the spec for that (4).

Components: Vulkan
VK-GL-CTS issue: 3137

Affected tests:

 dEQP-VK.glsl.opaque_type_indexing.ssbo*_compute

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Change-Id: I016fb5024d637e36869ae7e3f78467c91d0e8817

Fix dEQP-VK.image.extended_usage_bit.texture_* validation errors

Shader requires fragmentStoresAndAtomics but there wasn't any support
check for this physical device feature.

Components: Vulkan

VK-GL-CTS Issue: 3144

Affects:
dEQP-VK.image.extended_usage_bit.texture_read.*
dEQP-VK.image.extended_usage_bit.texture_write.*

Change-Id: I87f69256501519fe524159f02eb14ee6ac0e0092

Check depth bias clamp feature when needed

The inverted depth range tests were using the depth bias clamp feature
with a nonzero depth bias clamp value without checking if the feature
was available in the device.

Affected tests:
dEQP-VK.draw.inverted_depth_ranges.*

Components: Vulkan
VK-GL-CTS issue: 3128

Change-Id: I471235a0da38eb4c244e87e0d5851b8cb810f990

Add barrier between the atomic-compare-exchanges

Each of the second atomic-compare-exchange instructions relies on fact
that all the invocations have executed the first atomic-compare-exchange
instruction.  So insert a workgroup barrier between the two.

Affects:
dEQP-VK.spirv_assembly.instruction.spirv1p4.entrypoint.comp_workgroup_entry_point

Components: Vulkan

VK-GL-CTS issue: 3120

Change-Id: I95f897ceebcea8fdd5d6bda885a701be20d07ab1

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I16fde981fb8a0d98d4ed0522cb69a429a68545d0

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I133af15a49b220d94c26f9db70e7830fbe167b72

Allow the use of the standard types

Removes the script that enforces the use of
the de-wrappers instead of the standard types.

VK-GL-CTS issue: 2963

Components: Framework

Change-Id: I5e2ff38a2b2cbc63a3c756a1e0260833ecd9381e
(cherry picked from commit ce1ae17c4785a8a57214a16fac46e28832956fa9)

Fix dEQP-VK.image.mutable.*srgb* validation errors

The tests were not checking that the image format was
supported before creating the image.

Components: Vulkan
VK-GL-CTS issue: 3143

Affected tests:

   dEQP-VK.image.mutable.*

Change-Id: Ia42ccc815456ac09c4ffd44c63a0c65db8a9f1ec
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Fix Vulkan 1.3 required features

vulkanMemoryModelAvailabilityVisibilityChains feature is now
optional in Vulkan 1.3

VK-GL-CTS issue: 3116

Components: Vulkan

Affects:
dEQP-VK.api.info.vulkan1p3.feature_extensions_consistency

Change-Id: If9d6e32f96c7053bdc0908ba361c1603498ae0df

Allow 1.3.0.0 as a valid conformance version

Components: Vulkan
VK-GL-CTS issue: 3146
Affects: dEQP-VK.api.driver_properties.conformance_version

Change-Id: Ic77a90e47f9d649ebb5b3a3344876bcbc54835b9

Fix warning introduced by 1.3 changes

Fixes the following warning in vktApiFeatureInfo.cpp, checkSupportFeatureBitInfluence was replaced by a generic function (checkApiVersionSupport<1,2>) in the changes to add 1.3 support.

.../external/vulkancts/modules/vulkan/api/vktApiFeatureInfo.cpp:1536:6: error: unused function 'checkSupportFeatureBitInfluence' [-Werror,-Wunused-function]
void checkSupportFeatureBitInfluence (Context& context)
     ^
1 error generated.

Components: Vulkan

VK-GL-CTS issue: 3132

Change-Id: Ia1996263f5a95730a50098c747c9f425c7e8a239

Fix early fragment tests validation errors

There are several issues in the tests which were found by running them
with turnip driver with sysmem mode and the validation layers enabled:

- There was a sync issue. The culprit was
srcAccessMask=VK_ACCESS_SHADER_WRITE_BIT in one image memory barrier
since per spec for the store op "For attachments with a depth/stencil
format, this uses the access type
VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT.". So the correct
synchronization should have src access mask
VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT.

- In the same image memory buffer, the image layout was wrong when
testing stencil images.

- There were validation errors related to wrong image layout settings.

VK-GL-CTS issue: 3083
Components: Vulkan

Affects:

   dEQP-VK.fragment_operations.early_fragment.*

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Change-Id: If819abd6ccbe23460c4b20b46afeeaf98c7a2953

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I369a1aefe1c5d8f263aaff18917aa153c0b80e03

Limit storage buffer sizes in reconvergence tests

Return a not supported error if the storage buffer size is greater
than maxStorageBufferRange gpu limits.

Components: Vulkan

VK-GL-CTS Issue: 3114

Affected tests: dEQP-VK.reconvergence.*

Change-Id: Iecfbe0138b7d70420a353c2176110b843a49b091

Fix wrong VkAccessFlag when copying color image to buffer

Components: Vulkan
VK-GL-CTS issue: 3083

Affected tests:

   dEQP-VK.fragment_operations.early_fragment.*

Change-Id: Idb809fdd9efad586166b3d94c2a305e8c234274f
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Ibbd5912f0843ba22ee8402ee4a96aaf6ed53b303

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: Iac3e8ce0a318caed752aeb933994227278d9582f

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: Ifc19ab1fcdcfa681d0fef9b3c5e3448d12813fdf

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: Iab8e5c27a9f07ca0459c97bc8d72cd93b8ce675a

Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3

Change-Id: Icdbb121ec7a828457ff9df34efe018fbf845e3f9

Accept NaN as valid pass value in shader precision atan2 tests

Spec mentions that implementation may assume arguments are not
Inf if the entrypoint is not declared with SignedZeroInfNanPreserve
and can perform optimizations.

Components: Vulkan

VK-GL-CTS Issue: 3073

Affected tests:
dEQP-VK.spirv_assembly.instruction.compute.float16.*.atan2
dEQP-VK.spirv_assembly.instruction.graphics.float16.*.atan2*
dEQP-VK.glsl.builtin.precision.atan2.*

Change-Id: I6e1fbc14a5654422cf88e1453fae0774bfce0bb6

Vulkan 1.3 SPIR-V 1.6 framework

Components: Vulkan, Framework

Affects:
dEQP-VK.*

Change-Id: I275ed504144eaf5553e81767425cf7f5c53f757f

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I76cb05654f5fb575ce141f8c81d54e2192d53451

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I0e58f89d8cfdfaaa400f700ea87882cb281f080f

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I2d3ee8a323e62c13c9f3e5ff499ff3614c802b29

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I521f0b1f6f4c3a86e8612239ce2134be76e5d16a

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: Ic1ab6043f9d70b8491192137c6d8c2fc12f2112d

Merge "Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.3.0" into vulkan-cts-1.3.0

Added extra test case for load/store op none

Added a case that covers resolving a multisampled unsigned
integer color buffer using load and store op none.

VK-GL-CTS Issue: 2971

New tests:

dEQP-VK.renderpass*.suballocation.load_store_op_none.color_load_op_none_store_op_none_resolve

Components: Vulkan
Change-Id: Iab7f7340009d98283d9afb5683fe3bba273de110
(cherry picked from commit 48c886f0ef7dfbd839d9abcfd59911d0914e1188)

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Iffb51fe31abacfb802ee4e6fa924e6734afc6424

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I7bd0d85348a194cda0ec5922fa93a2cb5dd02e19

Test Vulkan 1.3 required features/properties

VK-GL-CTS issue: 3116

Components: Vulkan

Affects:
dEQP-VK.api.info.vulkan1p*

Change-Id: I9ef39e2331adfadb92e15991f5eabc001261ff64

Extend multidraw test with dynamic rendering and geom & tess

This combination was came up from a merge conflict, it was not tested before and was disabled.

Affects: dEQP-VK.draw_with_dynamic_rendering.multi_draw*

Components: Vulkan

Change-Id: I89582190df1af41a0c2537eb15a4ddc4764838dc

dEQP-VK.renderpass*.load_store_op_none.* tests depth-stencil format support check

In this test case, depth stencil format is set to VK_FORMAT_D24_UNORM_S8_UINT by default without checking if it is supported or not. If this format is not supported, then the test case crashes without even giving "Not Supported" result.

In this update I defined a set of depth stencil formats, and added a separate test case for each depth_stencil format. If the depth_stencil format is not supported, "Not Supported" is returned.

Affects: dEQP-VK.renderpass*.load_store_op_none.*

Components: Vulkan
VK-GL-CTS issue: 3049

Change-Id: Ifea5d0955a8325ecbed7f27296da4120e473d463
(cherry picked from commit 79c44fc79b7d17b8c70d2469e113c764011c51c6)

Ensure the vertex shader matches the vertex input definition

When doing the "reversed" variants of the extended dynamic
state tests, the vertex input attribute and binding information
was reversed, but the vertex shaders were not. The meant that
in some tests the vertex shader may try to fetch from unbound
or undefined vertex attributes or vertex attribute data.

This commit fixes the issue by swapping vertex shaders for the
affected variants.

Affects:
dEQP-VK.pipeline.extended_dynamic_state.*

Components: Vulkan
VK-GL-CTS issue: 3111

Change-Id: I7d9abbe7dab0b44127f6b194ee5da79755f7658c
Co-authored-by: Ricardo Garcia <rgarcia@igalia.com>

Fix AHB external memory test mip levels

AHB external memory tests were testing mipmaps using a
queried maximum number of supported mipmap levels, but
at the same time using an image size of 64x64.
The number of mip levels need to match the number for a
full mip chain, in this case 7. Now a correct number of
mip levels is used, which also gets rid of a validation
error.

VK-GL-CTS Issue: 3112

Affects:

dEQP-VK.api.external.memory.android_hardware_buffer.image_formats.*

Components: Vulkan
Change-Id: I1c6d09f93c06ac1c52cea283fd86359ccde01e4f

Update glslang, SPIR-V Tools, headers to 1.6

Switched to internal Khronos repo until 1.6 is released.

Components: Framework
Change-Id: Idf3ea328a2ce03b5f12eb4c44fc1ba2e53ee396f

Add support for Vulkan 1.3

Adds following extensions to core:
VK_KHR_copy_commands2
VK_KHR_dynamic_rendering
VK_KHR_format_feature_flags2
VK_KHR_maintenance4
VK_KHR_shader_integer_dot_product
VK_KHR_shader_non_semantic_info
VK_KHR_shader_terminate_invocation
VK_KHR_synchronization2
VK_KHR_zero_initialize_workgroup_memory
VK_EXT_4444_formats
VK_EXT_extended_dynamic_state
VK_EXT_extended_dynamic_state2
VK_EXT_image_robustness
VK_EXT_inline_uniform_block
VK_EXT_pipeline_creation_cache_control
VK_EXT_pipeline_creation_feedback
VK_EXT_private_data
VK_EXT_shader_demote_to_helper_invocation
VK_EXT_subgroup_size_control
VK_EXT_texel_buffer_alignment
VK_EXT_texture_compression_astc_hdr
VK_EXT_tooling_info
VK_EXT_ycbcr_2plane_444_formats

Components: Vulkan, Framework

Affects:
dEQP-VK.*

Change-Id: I18db39638deecae321bca89ddeade459e1f1ac31

Add image query tests for VK_KHR_maintenance4

These new tests perform the same queries as the original
vkGet*MemoryRequirements, using the objects createInfo instead. We then
compare the results against the original results.

We also query the memory requirements of a smaller buffer or image and
make sure the returned size requirements are not larger for the smaller
resource.

Components: Vulkan, Framework

New Tests: dEQP-VK.memory.requirements.create_info*

Change-Id: I2b751883911d18c3265b25f9d42920bb7e44bdf7

maintenance4: Add requirements matching tests

New test does few things:
* creates a bunch of VkBuffer and VkImage objects with the same
  create infos and makes sure their alignments all match
* makes sure that memory requirements returned by
  vkGetBufferCreateInfoMemoryRequirementsKHR are identical to those
  that would be returned by vkGetBufferMemoryRequirements2 if it were
  called with a VkBuffer created with the same VkBufferCreateInfo
  values
* similarly, vkGetImageCreateInfoMemoryRequirementsKHR will report
  the same memory requirements as vkGetImageMemoryRequirements2
  would if called with a VkImage created with the supplied
  VkImageCreateInfo
* makes sure that size memory requiremen for VkImage is not greater
  than that of another VkImage created with a greater or equal extent
  dimension specified in VkImageCreateInfo when all other creation
  parameters are identical
* makes sure that size memory requiremen for VkBuffer is not greater
  than that of another VkBuffer created with a greater or size
  specified in VkImageCreateInfo when all other creation parameters
  are identical

Components: Vulkan

VK-GL-CTS issue: 2996

Affets:
dEQP-VK.api.invariance.memory_requirements_matching

Change-Id: Ide74041ee82440af68458f684e2eae622f31cedf