James Henderson [Wed, 19 Feb 2020 14:03:02 +0000 (14:03 +0000)]
[NFC][DebugInfo] Refactor address advancing operations to share code
This change is a preparatory change for subsequent commits.
Reviewed by: probinson
Differential Revision: https://reviews.llvm.org/D75188
Pavel Labath [Thu, 5 Mar 2020 13:42:03 +0000 (14:42 +0100)]
[lldb] Reduce duplication in the Disassembler class
Summary:
The class has two pairs of functions whose functionalities differ in
only how one specifies how much he wants to disasseble. One limits the
process by the size of the input memory region. The other based on the
total amount of instructions disassembled. They also differ in various
features (like error reporting) that were only added to one of the
versions.
There are various ways in which this could be addressed. This patch
does it by introducing a helper struct called "Limit", which is
effectively a pair specifying the value that you want to limit, and the
actual limit itself.
Reviewers: JDevlieghere
Subscribers: sdardis, jrtc27, atanasyan, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D75730
Alex Cameron [Mon, 9 Mar 2020 11:58:12 +0000 (11:58 +0000)]
[XRay] Sanitize DOT labels in graph output
Summary:
Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=39701
This patch is to convert certain characters to their XML escape sequences when generating labels for a DOT graph.
I had trouble reproducing the exact issue described on the tracker. I ran `llvm-xray graph` on a log from a test program that included function templates but wasn't able to get the `dot` tool to complain about the `<` and `>` characters. The documentation also suggests that the escape sequences should only be necessary when using HTML string labels which XRay doesn't use (`label=<...>` as opposed to `label="..."`). Perhaps newer versions of Graphviz silently handle this in the case of quoted-string labels.
In any case, the generated labels still look correct after this patch and should also fix the reporter's issue.
I was a bit unsure how to add a test for this since the existing tests seem to only care about `func-id` rather than giving an actual name. If you could give me a hint on the best way to go about this, that'd be much appreciated!
Reviewers: dberris
Reviewed By: dberris
Subscribers: lebedev.ri, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69461
evgeny [Mon, 9 Mar 2020 11:05:15 +0000 (14:05 +0300)]
[WPD] Provide a way to prevent functions from being devirtualized
Differential revision: https://reviews.llvm.org/D75617
Djordje Todorovic [Mon, 9 Mar 2020 10:02:35 +0000 (11:02 +0100)]
[CallSiteInfo] Enable the call site info only for -g + optimizations
Emit call site info only in the case of '-g' + 'O>0' level.
Differential Revision: https://reviews.llvm.org/D75175
Gabor Marton [Mon, 9 Mar 2020 10:58:20 +0000 (11:58 +0100)]
[analyzer] Skip analysis of inherited ctor as top-level function
Summary:
This fixes a regression introduced in https://reviews.llvm.org/D74735
Reviewers: NoQ, Szelethus
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75678
Balázs Kéri [Mon, 9 Mar 2020 10:01:48 +0000 (11:01 +0100)]
[ASTImporter] Added visibility check for variable templates.
Summary:
ASTImporter makes now difference between variable templates
with same name in different translation units if not visible
outside.
Reviewers: a.sidorin, shafik, a_sidorin
Reviewed By: a_sidorin
Subscribers: dkrupp, Szelethus, gamesh411, teemperor, martong, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75732
Sjoerd Meijer [Mon, 9 Mar 2020 10:37:28 +0000 (10:37 +0000)]
Revert "Recommit "[Driver] Default to -fno-common for all targets""
This reverts commit
2c36c23f3476baf3b9283ea387c579419a70b112.
Still problems in the test-suite, which I really thought I had fixed...
Sven van Haastregt [Mon, 9 Mar 2020 10:26:11 +0000 (10:26 +0000)]
[OpenCL] Fix 'any' and 'all' builtins
These should only be defined for signed integer types according to
OpenCL v2.0 s6.12.6.
KAWASHIMA Takahiro [Tue, 3 Mar 2020 12:52:27 +0000 (21:52 +0900)]
[AArch64] Add support for Fujitsu A64FX
A64FX is an Armv8.2-A CPU used in FUJITSU Supercomputer
PRIMEHPC FX1000, PRIMEHPC FX700, and supercomputer Fugaku.
https://www.fujitsu.com/global/products/computing/servers/supercomputer/specifications/
Differential Revision: https://reviews.llvm.org/D75594
Sjoerd Meijer [Mon, 9 Mar 2020 10:07:37 +0000 (10:07 +0000)]
Recommit "[Driver] Default to -fno-common for all targets"
This includes fixes for:
- test-suite: some benchmarks need to be compiled with -fcommon, see D75557.
- compiler-rt: one test needed -fcommon, and another a change, see D75520.
Balázs Kéri [Mon, 9 Mar 2020 09:15:31 +0000 (10:15 +0100)]
[Analyzer][StreamChecker] Check for opened stream before operations.
Summary:
According to documentations, after an `fclose` call any other stream
operations cause undefined behaviour, regardless if the close failed
or not.
This change adds the check for the opened state before all other
(applicable) operations.
Reviewers: Szelethus
Reviewed By: Szelethus
Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, gamesh411, Charusso, martong, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75614
Clement Courbet [Tue, 3 Mar 2020 12:17:21 +0000 (13:17 +0100)]
[ExpandMemCmp] Properly constant-fold all compares.
Summary:
This gets rid of duplicated code and diverging behaviour w.r.t.
constants.
Fixes PR45086.
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75519
Nathan James [Mon, 9 Mar 2020 08:12:52 +0000 (08:12 +0000)]
Fix build failure from rG223a43ee8d89
Clement Courbet [Tue, 3 Mar 2020 12:17:21 +0000 (13:17 +0100)]
[ExpandMemCmp] Properly constant-fold all compares.
Summary:
This gets rid of duplicated code and diverging behaviour w.r.t.
constants.
Fixes PR45086.
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75519
Muhammad Omair Javaid [Mon, 9 Mar 2020 07:52:08 +0000 (12:52 +0500)]
[lldb/test] Remove skip arm/aarch64 decorator from instruction counting tests
This patch removes skipIf decorator from instruction counting tests.
We now use inline intruction in testing inferior to make sure that
number of instructions stays fixed. This was tested on aarch64 linux.
Nathan James [Mon, 9 Mar 2020 00:48:51 +0000 (00:48 +0000)]
[clang-tidy] [NFC] Remove unnecessary matchers
Reviewers: aaron.ballman, alexfh, gribozavr2
Reviewed By: aaron.ballman
Subscribers: wuzish, nemanjai, xazax.hun, kbarton, cfe-commits
Tags: #clang, #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D75803
Alex Brachet [Mon, 9 Mar 2020 07:10:59 +0000 (03:10 -0400)]
add extern "C" to __errno_location's definition if in __cplusplus file
Hideto Ueno [Mon, 9 Mar 2020 05:19:32 +0000 (14:19 +0900)]
[Attributor] Deduction based on path exploration
This patch introduces the propagation of known information based on path exploration.
For example,
```
int u(int c, int *p){
if(c) {
return *p;
} else {
return *p + 1;
}
}
```
An argument `p` is dereferenced whatever c's value is.
For an instruction `CtxI`, we accumulate branch instructions in the must-be-executed-context of `CtxI` and then, we take the conjunction of the successors' known state.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D65593
Uday Bondhugula [Mon, 9 Mar 2020 04:27:26 +0000 (04:27 +0000)]
[MLIR] NFC: modernize affine loop fusion test cases
- update test case for readability, avoid unnecessary matches
Signed-off-by: Uday Bondhugula <uday@polymagelabs.com>
Differential Revision: https://reviews.llvm.org/D75823
Uday Bondhugula [Mon, 9 Mar 2020 04:21:40 +0000 (04:21 +0000)]
[MLIR][Affine] NFC: add convenience method for affine data copy for a loop body
add convenience method for affine data copy generation for a loop body
Signed-off-by: Uday Bondhugula <uday@polymagelabs.com>
Differential Revision: https://reviews.llvm.org/D75822
Craig Topper [Sun, 8 Mar 2020 22:54:05 +0000 (15:54 -0700)]
[X86] Remove isel patterns that matched vXi16 X86VBroadcast with i8->i16 aextload input.
This was selecting VBROADCASTW which turned the 8-bit load into
a 16-bit load if it happened to be 2 byte aligned.
I have a plan to fix the regression with a follow up patch
which I'll post shortly.
Nathan James [Sat, 7 Mar 2020 09:51:43 +0000 (09:51 +0000)]
[ASTMatchers] adds isComparisonOperator to BinaryOperator and CXXOperatorCallExpr
Reviewers: aaron.ballman, gribozavr2
Reviewed By: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75800
Michael Liao [Sun, 8 Mar 2020 16:59:21 +0000 (12:59 -0400)]
Fix GCC warnings. NFC.
David Green [Sun, 8 Mar 2020 13:01:18 +0000 (13:01 +0000)]
[ARM] MVE VMULL tests. NFC
Sanjay Patel [Sun, 8 Mar 2020 13:57:55 +0000 (09:57 -0400)]
[VectorCombine] fold extract-extract-op with different extraction indexes
opcode (extelt V0, Ext0), (ext V1, Ext1) --> extelt (opcode (splat V0, Ext0), V1), Ext1
The first part of this patch generalizes the cost calculation to accept
different extraction indexes. The second part creates a shuffle+extract
before feeding into the existing code to create a vector op+extract.
The patch conservatively uses "TargetTransformInfo::SK_PermuteSingleSrc"
rather than "TargetTransformInfo::SK_Broadcast" (splat specifically
from element 0) because we do not have a more general "SK_Splat"
currently. That does not affect any of the current regression tests,
but we might be able to find some cost model target specialization where
that comes into play.
I suspect that we can expose some missing x86 horizontal op codegen with
this transform, so I'm speculatively adding a debug flag to disable the
binop variant of this transform to allow easier testing.
The test changes show that we're sensitive to cost model diffs (as we
should be), so that means that patches like D74976
should have better coverage.
Differential Revision: https://reviews.llvm.org/D75689
Sanjay Patel [Sun, 8 Mar 2020 13:33:07 +0000 (09:33 -0400)]
[VectorCombine] add tests for wider vectors; NFC
Kang Zhang [Sun, 8 Mar 2020 11:58:53 +0000 (11:58 +0000)]
[NFC][PowerPC] Order the MTSTR/MFSPR InstAlias definetion by SPR
Summary:
This NFC patch is only modify the position of MTSTR/MFSPR InstAlias
definition. So it will be easy to read.
LLVM GN Syncbot [Sun, 8 Mar 2020 11:50:36 +0000 (11:50 +0000)]
[gn build] Port
57c964aaa76
Tyker [Sun, 8 Mar 2020 11:19:29 +0000 (12:19 +0100)]
[AssumeBundles] Move to IR so it can be used by Analysis
Summary:
Assume bundles need to be usable by Analysis and Transforms/Utils isn't.
so this commit moves utilities to deal with asusme bundles to IR.
Reviewers: jdoerfert
Reviewed By: jdoerfert
Subscribers: mgorny, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75618
Tyker [Sat, 7 Mar 2020 17:00:05 +0000 (18:00 +0100)]
[AssumeBundles] Add API to query a bundles from a use
Summary: Finding what information is know about a value from a use is generally useful and can be done quickly.
Reviewers: jdoerfert
Reviewed By: jdoerfert
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75616
Craig Topper [Sun, 8 Mar 2020 08:15:26 +0000 (00:15 -0800)]
[X86] Add DAG combine to turn (vzext_movl (vbroadcast_load)) -> vzext_load.
If we're zeroing the other elements then we don't need the broadcast.
Kang Zhang [Sun, 8 Mar 2020 06:32:12 +0000 (06:32 +0000)]
Revert "[NFC][PowerPC] Remove the repeated definition for some InstAlias of mtspr/mfspr"
This reverts commit
46126a30f268a54dc68a40ca07556cf8aca5edbc.
Some test cases failed.
Kang Zhang [Sun, 8 Mar 2020 06:02:55 +0000 (06:02 +0000)]
[NFC][PowerPC] Remove the repeated definition for some InstAlias of mtspr/mfspr
Summary:
Below InstAlias have been redeclaration, this patch is to remove them.
mtdec/mfdec mtsdr1/mfsdr1 mtsrr0/mfsrr0 mtsrr1/mfsrr1
Yaxun (Sam) Liu [Sun, 8 Mar 2020 05:38:30 +0000 (00:38 -0500)]
Fix lldb build failure due to clang mangler change
Yaxun (Sam) Liu [Thu, 5 Mar 2020 17:02:13 +0000 (12:02 -0500)]
[NFC] Let mangler accept GlobalDecl
Differential Revision: https://reviews.llvm.org/D75700
Alex Brachet [Sun, 8 Mar 2020 03:56:03 +0000 (22:56 -0500)]
[libc] [NFC] Use matchers in tests
Summary:
Use `EXPECT_THAT` where possible in tests NFC intended.
Added a `void *` template instantiation of `StreamWrapper::operator<<`
Reviewers: sivachandra, PaulkaToast
Reviewed By: sivachandra
Subscribers: MaskRay, tschuett, libc-commits
Differential Revision: https://reviews.llvm.org/D75717
Nathan Chancellor [Sun, 8 Mar 2020 00:37:44 +0000 (16:37 -0800)]
[Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast
GCC does not warn on casts from pointers to enumerators, while clang
currently does: https://godbolt.org/z/3DFDVG
This causes a bunch of extra warnings in the Linux kernel, where
certain structs contain a void pointer to avoid using a gigantic
union for all of the various types of driver data, such as
versions.
Add a diagnostic that allows certain projects like the kernel to
disable the warning just for enums, which allows those projects to
keep full compatibility with GCC but keeps the intention of treating
casts to integers and enumerators the same by default so that other
projects have the opportunity to catch issues not noticed before (or
follow suite and disable the warning).
Link: https://github.com/ClangBuiltLinux/linux/issues/887
Reviewed By: rjmccall
Differential Revision: https://reviews.llvm.org/D75758
Craig Topper [Sun, 8 Mar 2020 00:14:26 +0000 (16:14 -0800)]
[X86] Add DAG combine to replace vXi64 vzext_movl+scalar_to_vector with vYi32 vzext_movl+scalar_to_vector if the upper 32 bits of the scalar are zero.
We can just use a 32-bit copy and zero in the SSE domain when we
zero the upper bits.
Remove an isel pattern that becomes dead with this.
Craig Topper [Sat, 7 Mar 2020 22:39:53 +0000 (14:39 -0800)]
[X86] Add DAG combines to enable removing of movddup/vbroadcast + simple_load isel patterns.
Craig Topper [Sat, 7 Mar 2020 19:33:10 +0000 (11:33 -0800)]
[X86] Add a DAG combine to turn vbroadcast(vzload X) -> vbroadcast_load
Remove now unneeded isel patterns.
Argyrios Kyrtzidis [Sat, 7 Mar 2020 23:04:23 +0000 (15:04 -0800)]
[Index/USRGeneration] Make sure that ObjC properties in categories also get namescoped properly for USR generation
If the property is in a category that has module names from external_declaration property, make sure they are included in the USR.
rdar://
59897320
kpdev [Sat, 7 Mar 2020 07:30:42 +0000 (10:30 +0300)]
[NFC][Test commit] Remove redundant point in docs
Rafael Ávila de Espíndola [Sat, 7 Mar 2020 18:52:51 +0000 (10:52 -0800)]
[Sema] Initialize IsSurrogate
This fixes https://bugs.llvm.org/show_bug.cgi?id=45096
Differential Revision: https://reviews.llvm.org/D75701
Ruyman [Fri, 26 Jul 2019 15:21:01 +0000 (16:21 +0100)]
[SYCL] Driver option to select SYCL version
Summary:
User can select the version of SYCL the compiler will
use via the flag -sycl-std, similar to -cl-std.
The flag defines the LangOpts.SYCLVersion option to the
version of SYCL. The default value is undefined.
If driver is building SYCL code, flag is set to the default SYCL
version (1.2.1)
The preprocessor uses this variable to define CL_SYCL_LANGUAGE_VERSION macro,
which should be defined according to SYCL 1.2.1 standard.
Only valid value at this point for the flag is 1.2.1.
Co-Authored-By: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co>
Signed-off-by: Ruyman Reyes <ruyman@codeplay.com>
Subscribers: ebevhan, Anastasia, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72857
Craig Topper [Sat, 7 Mar 2020 06:29:34 +0000 (22:29 -0800)]
[X86] Use MVT instead of EVT in a couple shuffle lowering functions.
Mehdi Amini [Sat, 7 Mar 2020 17:43:10 +0000 (17:43 +0000)]
Fix MLIR clang-tidy: when tweaking it does not inherit from the parent
It is almost identical to the top-level .clang-tidy, except that
{Member,Parameter,Variable}Case use camelBack.
Michał Górny [Sat, 7 Mar 2020 17:35:22 +0000 (18:35 +0100)]
[lldb] Un-XFAIL two tests on NetBSD
Nikita Popov [Sat, 7 Mar 2020 11:18:05 +0000 (12:18 +0100)]
[InstCombine] Fix known bits handling in SimplifyDemandedUseBits
Fixes a regression from D75801. SimplifyDemandedUseBits() is also
supposed to compute the known bits (of the demanded subset) of the
instruction. For unknown instructions it does so by directly calling
computeKnownBits(). For known instructions it will compute known
bits itself. However, for instructions where only some cases are
handled directly (e.g. a constant shift amount) the known bits
invocation for the unhandled case is sometimes missing. This patch
adds the missing calls and thus removes the main discrepancy with
ExpensiveCombines mode.
Differential Revision: https://reviews.llvm.org/D75804
Matt Arsenault [Wed, 6 Nov 2019 18:26:43 +0000 (10:26 -0800)]
Assume ieee behavior without denormal-fp-math attribute
Nikita Popov [Sat, 7 Mar 2020 16:18:39 +0000 (17:18 +0100)]
[InstCombine] Regenerate test checks; NFC
Nikita Popov [Sat, 7 Mar 2020 15:25:33 +0000 (16:25 +0100)]
[InstSimplify] Add tests for "returned" attribute; NFC
Nikita Popov [Sat, 7 Mar 2020 11:59:16 +0000 (12:59 +0100)]
[InstCombine] Add additional known bits folding tests; NFC
Nikita Popov [Sat, 7 Mar 2020 09:56:29 +0000 (10:56 +0100)]
[InstCombine] Highlight tests using expensive combines; NFC
Sanjay Patel [Sat, 7 Mar 2020 15:20:38 +0000 (10:20 -0500)]
[InstCombine] regenerate complete test checks; NFC
Sanjay Patel [Sat, 7 Mar 2020 15:00:31 +0000 (10:00 -0500)]
[InstCombine] add test for gep (select),... (PR45084); NFC
Sourabh Singh Tomar [Sat, 7 Mar 2020 12:20:07 +0000 (17:50 +0530)]
[DebugInfo]: Added DWARFv5 macro header flags and corresponding helper
functions.
Stefanos Baziotis [Sat, 7 Mar 2020 10:38:44 +0000 (12:38 +0200)]
[Attributor] Fold terminators before changing instructions to unreachable
It is possible that an instruction to be changed to unreachable is
in the same block with a terminator that can be constant-folded.
In this case, as of now, the instruction will be changed to
unreachable before the terminator is folded. But, then the
whole BB becomes invalidated and so when we go ahead to fold
the terminator, we trap.
Change the order of these two.
Differential Revision: https://reviews.llvm.org/D75780
River Riddle [Sat, 7 Mar 2020 07:01:49 +0000 (23:01 -0800)]
[mlir] Change EffectKind in unsigned for bitfield to avoid miscompile in
MSVC
MSVC has problems if the type of the bitfield is different, leading to
invalid code generation.
Mason Remy [Sat, 7 Mar 2020 06:42:38 +0000 (22:42 -0800)]
[mlir][nfc] Fix building mlir_c_runner_utils for Windows
Summary:
On Windows, building `mlir_c_runner_utils` doesn't properly export
symbols, thus resulting in an implib not being created, which causes
an error when consuming LLVM from external projects.
Differential Revision: https://reviews.llvm.org/D75769
Uday Bondhugula [Sat, 7 Mar 2020 06:36:28 +0000 (22:36 -0800)]
[mlir][NFC] remove stray decl of toAffineExpr, rename for readability
Summary:
- remove stray toAffineExpr decl in affine analysis (name duplicate of
mlir::toAffineExpr)
- rename mlir::toAffineExpr for better readability
- related NFC changes
Signed-off-by: Uday Bondhugula <uday@polymagelabs.com>
Differential Revision: https://reviews.llvm.org/D75694
Amara Emerson [Thu, 5 Mar 2020 19:57:45 +0000 (11:57 -0800)]
Revert "Revert "[GlobalISel][Localizer] Enable intra-block localization of already-local uses.""
This reverts commit
5583c2f2fba5be1df60f00cbc34a5098b5a49909.
The lldb bot failure was a test that was fragile and sensitive to irrelevant
changes in instruction ordering. Re-committing this as the test should have
been skipped for AArch64 now.
Differential Revision: https://reviews.llvm.org/D75555
Hal Finkel [Sat, 7 Mar 2020 04:55:46 +0000 (04:55 +0000)]
Add the CodeReview Documentation to GettingInvolved TOC
Hal Finkel [Thu, 26 Dec 2019 21:56:26 +0000 (21:56 +0000)]
High-Level Code-Review Documentation Update
This is an update to the documentation of our community code-review process.
Based on the RFC: High-Level Code-Review Documentation Update
(http://lists.llvm.org/pipermail/llvm-dev/2019-November/136808.html).
In this patch, I've pulled out the documentation into a separate file, and
broken it into a number of subsections. This is, of course, just one further
step in better documenting our community processes. I expect we'll continue to
improve this over time. Thank you to everyone who provided feedback!
Differential Revision: https://reviews.llvm.org/D71916
River Riddle [Sat, 7 Mar 2020 03:18:13 +0000 (19:18 -0800)]
[mlir] Explicitly qualify Effect to avoid MSVC build failure
MSVC qualifies the Effect reference contextually depending on where the
template is instantiated, leading to compiler failures if there is a
different Effect class defined.
Nico Weber [Sat, 7 Mar 2020 02:55:45 +0000 (21:55 -0500)]
[gn build] copy compiler-rt headers to clang include dir on all platforms
Raphael Isemann [Sat, 7 Mar 2020 02:42:20 +0000 (18:42 -0800)]
[lldb][NFC] Make TestStats.py not an inline test
There is still the bug that empty lines seem to skip any following expressions
and it makes it harder to commend between all the comments. Let's make this
a normal test instead which is just slightly more verbose but can be properly
formatted.
Raphael Isemann [Sat, 7 Mar 2020 02:27:46 +0000 (18:27 -0800)]
[lldb][NFC] Refactor our option generation out of EvaluateExpression
Greg Clayton [Fri, 6 Mar 2020 22:59:41 +0000 (14:59 -0800)]
Fix a copy and paste error that would cause a crash.
Summary: The wrong variable was being checked for an error, which mean a llvm::Error went unchecked and crashes dsymutil. Discovered this when trying to feed an ELF file to "dsymutil --update" and running into the crash.
Reviewers: aprantl, JDevlieghere
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75777
Petr Hosek [Sat, 7 Mar 2020 01:33:56 +0000 (17:33 -0800)]
[clang-doc] Improving Markdown Output
This change has two components. The moves the generated file
for a namespace to the directory named after the namespace in
a file named 'index.<format>'. This greatly improves the browsing
experience since the index page is shown by default for a directory.
The second improves the markdown output by adding the links to the
referenced pages for children objects and the link back to the source
code.
Patch By: Clayton
Differential Revision: https://reviews.llvm.org/D72954
Raphael Isemann [Sat, 7 Mar 2020 01:24:56 +0000 (17:24 -0800)]
[lldb] Never compile the debugserver with Clang module flags
Summary:
Compiling ObjC++ with Clang modules is usually not working well and compiling
the small debugserver with modules is not worth the trouble.
Reviewers: JDevlieghere
Reviewed By: JDevlieghere
Subscribers: mgorny, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74891
Raphael Isemann [Sat, 7 Mar 2020 01:07:23 +0000 (17:07 -0800)]
[lldb][cmake] Move remove_module_flags macro to AddLLDB.cmake
Summary: This is currently hidden in the Host CMakeLists but we should also use this macro in other parts of LLDB where we have ObjC++ sources (see D74891)
Reviewers: JDevlieghere
Reviewed By: JDevlieghere
Subscribers: mgorny, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D75164
Raphael Isemann [Fri, 6 Mar 2020 23:49:23 +0000 (15:49 -0800)]
tab completion for process signal
Summary: Provide a list of Unix signals for the tap completion for command "process signal".
Reviewers: teemperor
Subscribers: labath, jingham, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D75418
Akira Hatanaka [Tue, 11 Feb 2020 21:09:18 +0000 (13:09 -0800)]
[CodeGen][ObjC] Extend lifetime of ObjC pointers passed to calls to
__builtin_os_log_format
This is needed to keep all the objects, including temporaries returned
by function calls, written to the buffer alive until os_log_pack_send is
called.
rdar://problem/
60105410
Stephen Neuendorffer [Fri, 6 Mar 2020 19:26:56 +0000 (11:26 -0800)]
[MLIR] Add document about creating a dialect.
Goal is also to document best naming practices from here:
https://llvm.discourse.group/t/rfc-canonical-file-paths-to-dialects/621
Differential Revision: https://reviews.llvm.org/D75762
Raphael Isemann [Fri, 6 Mar 2020 19:21:54 +0000 (11:21 -0800)]
[lldb][NFC] Refactor TestSafeFuncCalls.py
Summary:
This patch inlines all the single-line functions that we only use once in the test
and replaces the assertTrue with an assertEquals to improve the error message
when this test fails.
Reviewers: JDevlieghere
Reviewed By: JDevlieghere
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D75497
Stephen Neuendorffer [Fri, 6 Mar 2020 23:10:14 +0000 (15:10 -0800)]
[MLIR] Add missing DEPENDS line for MLIRSPIRV
This line was inadvertantly left off, which results in missing dependencies
and a potentially broken build
Andrew Monshizadeh [Fri, 6 Mar 2020 22:16:19 +0000 (14:16 -0800)]
Extend TimeTrace to LLVM's new pass manager
With the addition of the LLD time tracing it made sense to include coverage
for LLVM's various passes. Doing so ensures that ThinLTO is also covered
with a time trace.
Before:
{
F11333974}
After:
{
F11333928}
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D74516
Andrew Monshizadeh [Fri, 6 Mar 2020 22:16:17 +0000 (14:16 -0800)]
Refactor TimeProfiler write methods (NFC)
Added a write method for TimeTrace that takes two strings representing
file names. The first is any file name that may have been provided by the
user via `time-trace-file` flag, and the second is a fallback that should
be configured by the caller. This method makes it cleaner to write the
trace output because there is no longer a need to check file names at the
caller and simplifies future TimeTrace usages.
Reviewed By: modocache
Differential Revision: https://reviews.llvm.org/D74514
Thomas Lively [Fri, 6 Mar 2020 21:00:16 +0000 (13:00 -0800)]
[WebAssembly] Add SIMD integer min/max builtins
Summary:
Although SIMD integer min/max operations can be expressed using the ?:
operator in C++, that operator is disallowed for vectors in C. As a
workaround, this change introduces new WebAssembly-specific builtin
functions that lower to the desired vector icmp/select sequences.
Reviewers: aheejin, dschuff, kripken
Subscribers: sbc100, jgravelle-google, sunfish, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75770
River Riddle [Fri, 6 Mar 2020 21:55:36 +0000 (13:55 -0800)]
[mlir][SideEffects] Enable specifying side effects directly on the arguments/results of an operation.
Summary:
New classes are added to ODS to enable specifying additional information on the arguments and results of an operation. These classes, `Arg` and `Res` allow for adding a description and a set of 'decorators' along with the constraint. This enables specifying the side effects of an operation directly on the arguments and results themselves.
Example:
```
def LoadOp : Std_Op<"load"> {
let arguments = (ins Arg<AnyMemRef, "the MemRef to load from",
[MemRead]>:$memref,
Variadic<Index>:$indices);
}
```
Differential Revision: https://reviews.llvm.org/D74440
River Riddle [Fri, 6 Mar 2020 21:53:16 +0000 (13:53 -0800)]
[mlir][SideEffects] Define a set of interfaces and traits for defining side effects
This revision introduces the infrastructure for defining side-effects and attaching them to operations. This infrastructure allows for defining different types of side effects, that don't interact with each other, but use the same internal mechanisms. At the base of this is an interface that allows operations to specify the different effect instances that are exhibited by a specific operation instance. An effect instance is comprised of the following:
* Effect: The specific effect being applied.
For memory related effects this may be reading from memory, storing to memory, etc.
* Value: A specific value, either operand/result/region argument, the effect pertains to.
* Resource: This is a global entity that represents the domain within which the effect is being applied.
MLIR serves many different abstractions, which cover many different domains. Simple effects are may have very different context, for example writing to an in-memory buffer vs a database. This revision defines uses this infrastructure to define a set of initial MemoryEffects. The are effects that generally correspond to memory of some kind; Allocate, Free, Read, Write.
This set of memory effects will be used in follow revisions to generalize various parts of the compiler, and make others more powerful(e.g. DCE).
This infrastructure was originally proposed here:
https://groups.google.com/a/tensorflow.org/g/mlir/c/v2mNl4vFCUM
Differential Revision: https://reviews.llvm.org/D74439
Fangrui Song [Fri, 6 Mar 2020 20:53:24 +0000 (12:53 -0800)]
[ELF][test] Improve MEMORY tests
Shivam Gupta [Fri, 6 Mar 2020 21:52:22 +0000 (16:52 -0500)]
Correct the Bjarne Stroustrup's C++ Page link
Summary: Bjarne Stroustrup's C++ Page link pointing to wrong AT&T page.
Reviewers: jyknight, sanjoy, silvas, hubert.reinterpretcast
Reviewed By: hubert.reinterpretcast
Subscribers: hubert.reinterpretcast, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75709
Michael Spencer [Fri, 6 Mar 2020 01:56:13 +0000 (17:56 -0800)]
[clang][Headers] Use __has_builtin instead of _MSC_VER.
arm_acle.h relied on `_MSC_VER` to determine if a given function was
already defined as a builtin. This was incorrect because
`-fms-extensions` enables these builtins, but is not responsible for
defining `_MSC_VER` on any target. The next closest thing is
`_MSC_EXTENSIONS`, which is only defined on Windows targets, but even
this is suboptimal. What this conditional is actually trying to
determine is if the given functions are defined as builtins, so just
check that directly.
I also attempted to do this for `__nop`, but in that case intrin.h,
which is only includable if `_MSC_VER` is defined, has its own
definition. So in that case `_MSC_VER` is correct.
Differential Revision: https://reviews.llvm.org/D75719
rdar://
60102353
Fangrui Song [Fri, 6 Mar 2020 21:35:39 +0000 (13:35 -0800)]
[gold][test] Fix tests after D75713 and D74749
Reid Kleckner [Thu, 5 Mar 2020 23:37:21 +0000 (15:37 -0800)]
Avoid emitting unreachable SP adjustments after `throw`
In
172eee9c, we tried to avoid these by modelling the callee as
internally resetting the stack pointer.
However, for the majority of functions with reserved stack frames, this
would lead LLVM to emit extra SP adjustments to undo the callee's
internal adjustment. This lead us to fix the problem further on down the
pipeline in eliminateCallFramePseudoInstr. In
5b79e603d3b7a2994, I added
use a heuristic to try to detect when the adjustment would be
unreachable.
This heuristic is imperfect, and when exception handling is involved, it
fails to fire. The new test is an example of this. Simply throwing an
exception with an active cleanup emits dead SP adjustments after the
throw. Not only are they dead, but if they were executed, they would be
incorrect, so they are confusing.
This change essentially reverts
172eee9c and makes the
5b79e603d3b7a2994
heuristic responsible for preventing unreachable stack adjustments. This
means we may emit unreachable stack adjustments for functions using EH
with unreserved call frames, but that is not very many these days. Back
in 2016 when this change was added, we were focused on 32-bit, which we
observed to have fewer reserved frames.
Fixes PR45064
Reviewed By: hans
Differential Revision: https://reviews.llvm.org/D75712
Anna Thomas [Fri, 6 Mar 2020 16:07:11 +0000 (11:07 -0500)]
[RS4GC] Handle uses of extractelement for conversion from vector to scalar base
As mentioned in the comments, extractelement is special
since we actually want a scalar base for that element we extracted from
the vector (i.e. not a vector base).
This same logic should apply to uses of the extractelement such as phis
and selects which have the same BDV as the extractelement.
Howeber, for these uses we conservatively mark the BDV state as
conflict, since setting the EE's new base BDV does not always dominate
these uses.
Added testcase showcases the problem where the BDV identification chokes
on the incorrect cast from vector to scalar for the phi use of
extractelement.
Tests-Run: make check, internal fuzzer testing
Reviewers: reames, skatkov, dantrushin
Reviewed-By: dantrushin
Differential Revision: https://reviews.llvm.org/D75704
Sterling Augustine [Thu, 5 Mar 2020 19:50:51 +0000 (11:50 -0800)]
Split findUnwindSectionsByPhdr into target-specific functions.
Summary:
This further cleans up the control flow and makes it easier to
optimize and replace portions in a subsequent patch.
This should be NFC, but given the amount of #ifdeffing here,
it may not be. So will watch the buildbots closely.
Also, as this is purely moving existing code around, I plan to
ignore the lint errors.
Reviewers: compnerd, miyuki, mstorsjo
Subscribers: libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D75705
Benjamin Barenblat [Fri, 6 Mar 2020 21:20:48 +0000 (13:20 -0800)]
[lld][test] Make tests pass when the test directory matches `bar`
Reviewed By: jhenderson, MaskRay
Differential Revision: https://reviews.llvm.org/D72360
Stephen Neuendorffer [Thu, 27 Feb 2020 22:53:12 +0000 (14:53 -0800)]
[MLIR] Fixes for BUILD_SHARED_LIBS=on
Differential Revision: https://reviews.llvm.org/D75308
Valentin Churavy [Sun, 9 Feb 2020 03:27:54 +0000 (19:27 -0800)]
[MLIR] Add support for libMLIR.so
Putting this up mainly for discussion on
how this should be done. I am interested in MLIR from
the Julia side and we currently have a strong preference
to dynamically linking against the LLVM shared library,
and would like to have a MLIR shared library.
This patch adds a new cmake function add_mlir_library()
which accumulates a list of targets to be compiled into
libMLIR.so. Note that not all libraries make sense to
be compiled into libMLIR.so. In particular, we want
to avoid libraries which primarily exist to support
certain tools (such as mlir-opt and mlir-cpu-runner).
Note that the resulting libMLIR.so depends on LLVM, but
does not contain any LLVM components. As a result, it
is necessary to link with libLLVM.so to avoid linkage
errors. So, libMLIR.so requires LLVM_BUILD_LLVM_DYLIB=on
FYI, Currently it appears that LLVM_LINK_LLVM_DYLIB is broken
because mlir-tblgen is linked against libLLVM.so and
and independent LLVM components.
Previous version of this patch broke depencies on TableGen
targets. This appears to be because it compiled all
libraries to OBJECT libraries (probably because cmake
is generating different target names). Avoiding object
libraries results in correct dependencies.
(updated by Stephen Neuendorffer)
Differential Revision: https://reviews.llvm.org/D73130
Stephen Neuendorffer [Thu, 20 Feb 2020 18:48:51 +0000 (10:48 -0800)]
[MLIR] Move from add_dependencies() to DEPENDS
add_llvm_library and add_llvm_executable may need to create new targets with
appropriate dependencies. As a result, it is not sufficient in some
configurations (namely LLVM_BUILD_LLVM_DYLIB=on) to only call
add_dependencies(). Instead, the explicit TableGen dependencies must
be passed to add_llvm_library() or add_llvm_executable() using the DEPENDS
keyword.
Differential Revision: https://reviews.llvm.org/D74930
Richard Smith [Fri, 6 Mar 2020 21:22:10 +0000 (13:22 -0800)]
PR45124: Don't leave behind pending cleanups when declaring implicit
deduction guides.
Previously if an implicit deduction guide had a default argument with a
cleanup, we'd leave the 'pending cleanup' flag set after declaring the
implicit guide. But it turns out that there's no reason to even
substitute into the default argument when declaring an implicit
deduction guide: we only need to record that the default argument
exists, not what it is, since we never actually form a call to a
deduction guide.
Matt Arsenault [Thu, 5 Mar 2020 14:13:09 +0000 (09:13 -0500)]
Reapply "clang: Treat ieee mode as the default for denormal-fp-math"
This reverts commit
737394c490444e968a6f640b99a6614567ca7f28.
The fp-model test was failing on platforms that enable denormal flushing
based on -ffast-math. This needs to reset to IEEE, not the default in
these cases.
Change-Id: Ibbad32f66d0d0b89b9c1173a3a96fb1a570ddd89
Adrian Prantl [Fri, 6 Mar 2020 19:13:04 +0000 (11:13 -0800)]
Fix test broken by simulator triple changes.
Raphael Isemann [Fri, 6 Mar 2020 19:19:06 +0000 (11:19 -0800)]
[lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts
Summary:
Otherwise this code won't run on the Release+Asserts builds we have on the CI.
Fixes rdar://problem/
59867885 (partly)
Reviewers: aprantl
Reviewed By: aprantl
Subscribers: JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D75493
Gongyu Deng [Fri, 6 Mar 2020 18:10:24 +0000 (10:10 -0800)]
[lldb] Update the current execution context at the beginning of tab completions
Summary: Fix a bug that tab completions won't synchronous the current execution context. ( Thanks for Jim's explanation! )
Reviewers: teemperor, labath, jingham
Reviewed By: jingham
Subscribers: jingham, labath
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D75597
Roman Lebedev [Fri, 6 Mar 2020 18:39:07 +0000 (21:39 +0300)]
[InstComine] Forego of one-use check in `(X - (X & Y)) --> (X & ~Y)` if Y is a constant
Summary:
This is potentially more friendly for further optimizations,
analysies, e.g.: https://godbolt.org/z/G24anE
This resolves phase-ordering bug that was introduced
in D75145 for https://godbolt.org/z/2gBwF2
https://godbolt.org/z/XvgSua
Reviewers: spatel, nikic, dmgreen, xbolva00
Reviewed By: nikic, xbolva00
Subscribers: hiraditya, zzheng, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D75757
Alexey Lapshin [Thu, 27 Feb 2020 17:38:42 +0000 (20:38 +0300)]
LLD already has a mechanism for caching creation of DWARCContext:
llvm::call_once(initDwarfLine, [this]() { initializeDwarf(); });
Though it is not used in all places.
I need that patch for implementing "Remove obsolete debug info" feature
(D74169). But this caching mechanism is useful by itself, and I think it
would be good to use it without connection to "Remove obsolete debug info"
feature. So this patch changes inplace creation of DWARFContext with
its cached version.
Depends on D74308
Reviewed By: ruiu
Differential Revision: https://reviews.llvm.org/D74773