platform/upstream/dotnet/runtime.git
6 years agoFix whitespace
jbhensley [Wed, 12 Sep 2018 20:05:08 +0000 (13:05 -0700)]
Fix whitespace

Commit migrated from https://github.com/dotnet/corefx/commit/a64edcab4735be20171206366ebeb878db0aac10

6 years agoAdded test to emit EOS in the middle of an otherwise valid sequence.
jbhensley [Tue, 11 Sep 2018 00:21:11 +0000 (17:21 -0700)]
Added test to emit EOS in the middle of an otherwise valid sequence.

Commit migrated from https://github.com/dotnet/corefx/commit/673c537c39f69df985e1f42a3861d57bd431764d

6 years agoSupport hexBinary type (dotnet/corefx#32141)
Jiayi Yu [Mon, 10 Sep 2018 23:06:40 +0000 (16:06 -0700)]
Support hexBinary type (dotnet/corefx#32141)

*Port a few functions from full framework to support read/write hexbinary type and add tests

Commit migrated from https://github.com/dotnet/corefx/commit/8d65bd36a6d3d3cfdf1aa32cbb8c45cce25d9c95

6 years agoRemove last usages of DerSequenceReader/DerEncoder/AsnSerializer
Filip Navara [Mon, 10 Sep 2018 21:42:56 +0000 (23:42 +0200)]
Remove last usages of DerSequenceReader/DerEncoder/AsnSerializer

* Convert remainder of S.S.C.X509Certificates to use ASNXML/AsnReader/AsnWriter instead of DerSequenceReader/DerEncoder.

* Convert X509ExtensionAsn to code generator. Remove last usages of ASN serializer from code base.

* Remove DerEncoder, DerSequenceReader and related tests.

Commit migrated from https://github.com/dotnet/corefx/commit/4630572a4af4326f2d8bf983a5dc346d25c5238b

6 years agoMerge pull request dotnet/corefx#32146 from geoffkizer/ntauthfix
Geoff Kizer [Mon, 10 Sep 2018 21:37:05 +0000 (14:37 -0700)]
Merge pull request dotnet/corefx#32146 from geoffkizer/ntauthfix

fix nt auth handling when we receive a 401 after auth completes

Commit migrated from https://github.com/dotnet/corefx/commit/2c8be59ed4405dbdd91777f79763cb2f1384729e

6 years agoUpdate Reflection ownership
Karel Zikmund [Mon, 10 Sep 2018 20:35:34 +0000 (13:35 -0700)]
Update Reflection ownership

Commit migrated from https://github.com/dotnet/corefx/commit/042981c23df0d55fb7b837450a2679353984d92f

6 years agoAdd document for servicing libraries (dotnet/corefx#32168)
William Godbe [Mon, 10 Sep 2018 18:03:30 +0000 (11:03 -0700)]
Add document for servicing libraries (dotnet/corefx#32168)

* Add document for servicing libraries

* Address feedback

* Fix typo

Commit migrated from https://github.com/dotnet/corefx/commit/906033ace5eaf28eb671bcdd2ce3f262595a9a85

6 years agoUpdate CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26910...
dotnet-maestro-bot [Mon, 10 Sep 2018 17:38:24 +0000 (10:38 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26910-04, preview1-26910-04, preview1-26910-01, beta-26910-00, beta-26910-00, respectively (dotnet/corefx#32191)

Commit migrated from https://github.com/dotnet/corefx/commit/2c16175aaa2bcd5e1144ea8a25e094e092fa4479

6 years agoRemove the known issue for macOS
Paulo Janotti [Sat, 8 Sep 2018 18:26:00 +0000 (11:26 -0700)]
Remove the known issue for macOS

As expected the issue on macOS was fixed by removing the usage of coverlet.tracker.dll in coverlet.msbuild 2.3.0

Commit migrated from https://github.com/dotnet/corefx/commit/52121c8d0376dcb0f69570e793b6d40232ccabf9

6 years agoUpdate CoreClr, CoreFx, CoreSetup to preview1-26908-04, preview1-26908-04, preview1...
dotnet-maestro-bot [Sat, 8 Sep 2018 15:31:29 +0000 (08:31 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview1-26908-04, preview1-26908-04, preview1-26908-01, respectively (dotnet/corefx#32183)

Commit migrated from https://github.com/dotnet/corefx/commit/12b8c4173212e087eeb6e0e07400fc070801aa68

6 years agoMerge pull request dotnet/corefx#31824 from ViktorHofer/portableRemove
Wes Haggard [Sat, 8 Sep 2018 03:23:54 +0000 (20:23 -0700)]
Merge pull request dotnet/corefx#31824 from ViktorHofer/portableRemove

Remove portable- targetgroups

Commit migrated from https://github.com/dotnet/corefx/commit/ad2723fbd98b76fcb52637fa3a213b1a40429d44

6 years agoGet coverlet perf gains and remove copy of tracker (dotnet/corefx#32172)
Paulo Janotti [Sat, 8 Sep 2018 03:02:01 +0000 (20:02 -0700)]
Get coverlet perf gains and remove copy of tracker (dotnet/corefx#32172)

Commit migrated from https://github.com/dotnet/corefx/commit/6912105856e9da37b298a14b469ffb871326860b

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup to preview1-03208-01, preview1-26908...
dotnet-maestro-bot [Sat, 8 Sep 2018 02:49:42 +0000 (19:49 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup to preview1-03208-01, preview1-26908-01, preview1-26908-01, preview1-26907-05, respectively (dotnet/corefx#32173)

Commit migrated from https://github.com/dotnet/corefx/commit/7e0cbf1f27d8420a3f89f7a293de145f1cd26cd2

6 years agoMerge pull request dotnet/corefx#32177 from weshaggard/UpdateSDK
Wes Haggard [Sat, 8 Sep 2018 02:35:08 +0000 (19:35 -0700)]
Merge pull request dotnet/corefx#32177 from weshaggard/UpdateSDK

Update to released SDK

Commit migrated from https://github.com/dotnet/corefx/commit/8971f384e0c9bb967386a3a9e64b97fb886ab3d2

6 years agoMerge pull request dotnet/corefx#32148 from weshaggard/HarvestNSRefs
Wes Haggard [Sat, 8 Sep 2018 01:21:48 +0000 (18:21 -0700)]
Merge pull request dotnet/corefx#32148 from weshaggard/HarvestNSRefs

Harvest the netstandard2.0 refs for the crypto libraries

Commit migrated from https://github.com/dotnet/corefx/commit/e62249f4e10c35a0cffe13044929c030bd1d590a

6 years agoUpdate to released SDK
Wes Haggard [Sat, 8 Sep 2018 01:15:25 +0000 (18:15 -0700)]
Update to released SDK

As part of this we need to disable a roslyn analyzer to workaround
https://github.com/dotnet/roslyn-analyzers/issues/1804.

Commit migrated from https://github.com/dotnet/corefx/commit/4865c849d582e24478f08a224aa1f915bfcfbcde

6 years agoclient side ALPN for OSX (dotnet/corefx#31905)
Tomas Weinfurt [Fri, 7 Sep 2018 23:18:14 +0000 (16:18 -0700)]
client side ALPN for OSX (dotnet/corefx#31905)

* ALPN client side for OSX

* rework code to use new API introduced in 10.13.4 + feedback from review

* reviews feedback round 2

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/219ea1bea0f12660398a75160b1d68c2885696fd

6 years agoAdd Public API Marshal.GetEndComSlot and Marshal.IsTypeVisibleFromCom (dotnet/corefx...
Luqun Lou [Fri, 7 Sep 2018 23:01:25 +0000 (16:01 -0700)]
Add Public API Marshal.GetEndComSlot and Marshal.IsTypeVisibleFromCom (dotnet/corefx#31815)

Commit migrated from https://github.com/dotnet/corefx/commit/0ae9863e1db8da810a34a28951e1d4f45f316fce

6 years agominimal support for serial port on Linux. part 2. (dotnet/corefx#30903)
Tomas Weinfurt [Fri, 7 Sep 2018 22:40:47 +0000 (15:40 -0700)]
minimal support for serial port on Linux. part 2. (dotnet/corefx#30903)

* minimal support for serial port on Linux

* feedback from review

* rename SerialStream -> SerialStream.Windows

* some fixes and improvements

Commit migrated from https://github.com/dotnet/corefx/commit/ed4e3eafae1f454011732cadf734060c8e262c59

6 years agoMerge pull request dotnet/corefx#32137 from weshaggard/FixBuildingProjectRefsInVS
Wes Haggard [Fri, 7 Sep 2018 21:36:05 +0000 (14:36 -0700)]
Merge pull request dotnet/corefx#32137 from weshaggard/FixBuildingProjectRefsInVS

Fix building project references in VS

Commit migrated from https://github.com/dotnet/corefx/commit/161433fc8eb87c0706d18a2f25af5441c7cea696

6 years agoAvoid unnecessary Oid lookups in AsnReader
Filip Navara [Fri, 7 Sep 2018 21:21:26 +0000 (23:21 +0200)]
Avoid unnecessary Oid lookups in AsnReader

* Use `new Oid(value, null)` in AsnReader to let FriendlyName be populated on demand and remove the skipFriendlyName parameter from ReadObjectIdentifier.
* Remove the AsnSerializer support for PopulateFriendlyName(=false) as there's no option anymore.

Commit migrated from https://github.com/dotnet/corefx/commit/a0bfefddf0fba1244fefb58ae79cf56a1f853629

6 years agoHarvest the netstandard2.0 refs for the crypto libraries
Wes Haggard [Thu, 6 Sep 2018 22:25:16 +0000 (15:25 -0700)]
Harvest the netstandard2.0 refs for the crypto libraries

The crypto libaries currently have a frozen API surface for
netstandard2.0 because they are either inbox or harvesting
older platforms that support that API surface. Given that we
should simply harvest the NS references to avoid them from adding
apis they don't support everywhere.

System.Security.Cryptography.Xml depends on System.Security.Cryptography.Pkcs
for netstandard build so we need to restore it to the targeting pack.

Commit migrated from https://github.com/dotnet/corefx/commit/c4d179a9cb721973ebe1d11f2d253f606ef4b4d5

6 years agoFixing up the UTF8Formatter and some tests to properly handle -0.0
Tanner Gooding [Fri, 7 Sep 2018 15:36:41 +0000 (08:36 -0700)]
Fixing up the UTF8Formatter and some tests to properly handle -0.0

Commit migrated from https://github.com/dotnet/corefx/commit/e328f2b8bb3d7f69c921d8e422ace26b7fd9182a

6 years agoUpdate CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26907...
dotnet-maestro-bot [Fri, 7 Sep 2018 13:54:28 +0000 (06:54 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26907-04, preview1-26907-04, preview1-26907-01, beta-26907-00, beta-26907-00, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/9fca37a2cbeb0eb7da54f24dfa07a7af9e2af418

6 years agoDisable failing IO PathFeatures tests on netfx
Viktor Hofer [Fri, 7 Sep 2018 19:08:02 +0000 (21:08 +0200)]
Disable failing IO PathFeatures tests on netfx

Commit migrated from https://github.com/dotnet/corefx/commit/99aa6e69c24a39d6b7588bc0ce29207267e92afc

6 years agoFix apartment tests for netfx due to differnet file extension
Viktor Hofer [Fri, 7 Sep 2018 18:00:55 +0000 (20:00 +0200)]
Fix apartment tests for netfx due to differnet file extension

Commit migrated from https://github.com/dotnet/corefx/commit/317ddd17e185af36888d487a4cda935470e2186b

6 years agoUpdate XUnitExtensions
Viktor Hofer [Fri, 7 Sep 2018 15:30:11 +0000 (17:30 +0200)]
Update XUnitExtensions

Commit migrated from https://github.com/dotnet/corefx/commit/f553bbc1642c7ddf1d4015964d1302bb9af8fddf

6 years agoConvert [DSA/RSA/Ecc]SecurityTransforms and X509SignatureGenerators to new ASN.1...
Filip Navara [Fri, 7 Sep 2018 17:59:36 +0000 (19:59 +0200)]
Convert [DSA/RSA/Ecc]SecurityTransforms and X509SignatureGenerators to new ASN.1 APIs

This changes a lot of types designed for AsnSerializer to use the AsnXml code generator, and moves a number of those types from S.S.C.Algorithms to Common because the SecurityTransforms types are dual-compiled.

The workflow is similar to:

* Change all of the SecurityTransforms types to use the new types added during the key import/export feature.
* Change those types to use AsnXml generated code instead of AsnSerializer
* Move the types to Common source to fix S.S.C.X509Certificates build breaks
* Now that the types are already included in S.S.C.X509Certificates, make X509SignatureGenerator types use them, too.

Commit migrated from https://github.com/dotnet/corefx/commit/a0cfc0492df974ebb2b9293e4d5640e1c1505263

6 years agoFix incorrect IEEE conversion buffer size for ECDsaCmsSignature.
Alfred Rossi [Fri, 7 Sep 2018 15:18:30 +0000 (11:18 -0400)]
Fix incorrect IEEE conversion buffer size for ECDsaCmsSignature.

For EC curves with a keysize which is not a multiple of 8 the calculation under-allocated.

The most likely culprit is secp521r1.

Commit migrated from https://github.com/dotnet/corefx/commit/775c9f1415be3403864fe2804a9c5e16074d2d68

6 years agoMerge pull request dotnet/corefx#32043 from geoffkizer/huffmantests
Geoff Kizer [Fri, 7 Sep 2018 03:54:06 +0000 (20:54 -0700)]
Merge pull request dotnet/corefx#32043 from geoffkizer/huffmantests

Fix Huffman decoding issue and add Huffman decoding tests

Commit migrated from https://github.com/dotnet/corefx/commit/1b89c108d90f197a477ac8b79a4b8e35ac59b44d

6 years agoUpdate CoreClr, CoreFx, CoreSetup to preview1-26907-01, preview1-26907-01, preview1...
dotnet-maestro-bot [Fri, 7 Sep 2018 03:32:29 +0000 (20:32 -0700)]
Update CoreClr, CoreFx, CoreSetup to preview1-26907-01, preview1-26907-01, preview1-26906-05, respectively (dotnet/corefx#32149)

Commit migrated from https://github.com/dotnet/corefx/commit/032cc324f9f3c6d6fee7ca01e7aa8e3a4969deb9

6 years agoMissed renamed file for coverage runs (dotnet/corefx#32151)
Paulo Janotti [Fri, 7 Sep 2018 03:03:02 +0000 (20:03 -0700)]
Missed renamed file for coverage runs (dotnet/corefx#32151)

Commit migrated from https://github.com/dotnet/corefx/commit/5d561e3bcf84551a9544007400af2fda803e405e

6 years agoAdd perf tests to System.IO (dotnet/corefx#31552)
Jeremy Kuhne [Fri, 7 Sep 2018 01:11:06 +0000 (18:11 -0700)]
Add perf tests to System.IO (dotnet/corefx#31552)

* Add perf tests to System.IO

Add tests for measuring format writes for StreamWriter.

* Add a test validating dispatching of format calls when overridden.

Commit migrated from https://github.com/dotnet/corefx/commit/1e1f421c8e57cbd317800e0a10287488bb05c808

6 years agoFix extract out of directory (dotnet/corefx#32127)
Jeremy Kuhne [Fri, 7 Sep 2018 00:35:52 +0000 (17:35 -0700)]
Fix extract out of directory (dotnet/corefx#32127)

* Fix extract out of directory

Without ensuring a trailing directory separator you cannot compare paths for nesting.  `/Foo/Bar` does not contain `/Foo/Barber`, but does contain `/Foo/Bar/Bell`. This adds the separator and tests.

* Skip new test on NetFX

Commit migrated from https://github.com/dotnet/corefx/commit/a0fcd23ace1c8d692988cd0da4391cf7bf5e0ce6

6 years agofix typos
Geoff Kizer [Thu, 6 Sep 2018 23:37:24 +0000 (16:37 -0700)]
fix typos

Commit migrated from https://github.com/dotnet/corefx/commit/8e8a58be46c3c86452f5552ab861e59aef34db98

6 years agoMerge pull request dotnet/corefx#32128 from dotnet-maestro-bot/master-UpdateDependencies
spshant [Thu, 6 Sep 2018 22:15:10 +0000 (15:15 -0700)]
Merge pull request dotnet/corefx#32128 from dotnet-maestro-bot/master-UpdateDependencies

Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26906-06, preview1-26906-01, preview1-26906-02, beta-26906-00, beta-26906-00, respectively (master)

Commit migrated from https://github.com/dotnet/corefx/commit/d349e8d12df38d2e77bbbf59659f1b07e56cf9dd

6 years agofix issue
Geoff Kizer [Thu, 6 Sep 2018 22:07:15 +0000 (15:07 -0700)]
fix issue

Commit migrated from https://github.com/dotnet/corefx/commit/4225461e4ef5ad802e491a4ffc2e231ea604e8cc

6 years agofix tests to use Span
Geoff Kizer [Thu, 6 Sep 2018 22:01:53 +0000 (15:01 -0700)]
fix tests to use Span

Commit migrated from https://github.com/dotnet/corefx/commit/c77e291abc15e646d5223c4dc84f547f9858f923

6 years agouse Span
Geoff Kizer [Thu, 6 Sep 2018 21:29:41 +0000 (14:29 -0700)]
use Span

Commit migrated from https://github.com/dotnet/corefx/commit/1a852933092cce0e6f8be6c34457b1c509965ce9

6 years agofix Huffman decoding issue and add Huffman decoding tests
Geoff Kizer [Fri, 31 Aug 2018 05:50:18 +0000 (22:50 -0700)]
fix Huffman decoding issue and add Huffman decoding tests

Commit migrated from https://github.com/dotnet/corefx/commit/e5388b2fd7f9ab29800426f843b0c026b49ba7e4

6 years agofix ntlm auth: don't drain when we receive a 401 after auth completes
Geoff Kizer [Thu, 6 Sep 2018 20:54:19 +0000 (13:54 -0700)]
fix ntlm auth: don't drain when we receive a 401 after auth completes

Commit migrated from https://github.com/dotnet/corefx/commit/09f7b70e0eb3361847f4e13a8ee14aa3b1609a1f

6 years agoRename CarryLessMultiply to CarrylessMultiply
Fei Peng [Tue, 4 Sep 2018 22:56:42 +0000 (15:56 -0700)]
Rename CarryLessMultiply to CarrylessMultiply

Commit migrated from https://github.com/dotnet/corefx/commit/749d932b928ab2125cf2b98473a1bf4cde31ccd0

6 years agoMake System.ValueTuple full facade assembly
Viktor Hofer [Thu, 23 Aug 2018 22:46:31 +0000 (00:46 +0200)]
Make System.ValueTuple full facade assembly

Commit migrated from https://github.com/dotnet/corefx/commit/12ea7a38de4319a1c4d697981cd4aaf5af1ca00b

6 years agoFix building project references in VS
Wes Haggard [Thu, 6 Sep 2018 17:21:09 +0000 (10:21 -0700)]
Fix building project references in VS

For corefx project builds we rely on passing the configuration
property to project references so the correct configuration can
be selected. However when building in VS it clears that property
for some reason. To fix this we are going to explicitly set
ShouldUnsetParentConfigurationAndPlatform=false for our projects
when we annotate them to prevent them from being unset.

Commit migrated from https://github.com/dotnet/corefx/commit/ad08052b1626557bb5f901014163378cfbff20df

6 years agoRemove portable- targetgroups
Viktor Hofer [Fri, 17 Aug 2018 14:20:21 +0000 (16:20 +0200)]
Remove portable- targetgroups

Commit migrated from https://github.com/dotnet/corefx/commit/98ac84426d99fdf61dcea78dfe8663c666095822

6 years agoUpdate CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26906...
dotnet-maestro-bot [Thu, 6 Sep 2018 13:02:29 +0000 (06:02 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26906-06, preview1-26906-01, preview1-26906-02, beta-26906-00, beta-26906-00, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/587b3ecb52c261e0f27b711f303f25a7c93adf11

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Wed, 5 Sep 2018 17:37:34 +0000 (10:37 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03205-01, preview1-26905-04, preview1-26905-03, preview1-26905-03, beta-26905-00, beta-26905-00, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/219a6c71c80ba8b5b06a2a767121a49930f38cd7

6 years agoUpdate TCFullEndElement.cs (dotnet/corefx#32107)
Krzysztof Wicher [Wed, 5 Sep 2018 21:07:59 +0000 (14:07 -0700)]
Update TCFullEndElement.cs (dotnet/corefx#32107)

Commit migrated from https://github.com/dotnet/corefx/commit/f78adfa78f388972e5d64a68187dd540c219f2f6

6 years agoMerge pull request dotnet/corefx#31856 from jnm2/document_stateless_struct_breaking_c...
Wes Haggard [Wed, 5 Sep 2018 21:04:47 +0000 (14:04 -0700)]
Merge pull request dotnet/corefx#31856 from jnm2/document_stateless_struct_breaking_change_rule

Document breaking change rule for stateless structs

Commit migrated from https://github.com/dotnet/corefx/commit/b1c02c9558c9c2d4b667f372a3f48d8b6a9c2421

6 years agoDocument breaking change rule for stateless structs
jnm2 [Tue, 21 Aug 2018 00:49:36 +0000 (20:49 -0400)]
Document breaking change rule for stateless structs

Commit migrated from https://github.com/dotnet/corefx/commit/7444297ba077452d87bbbc5a4e5aab38069e2a54

6 years agoEnabling some skipped math and mathf tests
Tanner Gooding [Sun, 26 Aug 2018 02:04:10 +0000 (19:04 -0700)]
Enabling some skipped math and mathf tests

Commit migrated from https://github.com/dotnet/corefx/commit/5d7f2469f4ef37e6bc6846f85d9ea55570002c8f

6 years agoConvert GeneralNameAsn to ASNXML generation
Filip Navara [Wed, 5 Sep 2018 14:27:22 +0000 (16:27 +0200)]
Convert GeneralNameAsn to ASNXML generation

This changes the GeneralNameAsn type and all of its field types to ASNXML generated code, fixing the lack of tags on EdiPartyNameAsn in the process.

It also replaces the manual reading of GeneralName in AppleAsnFormatter, reducing the use of the legacy DerSequenceReader type.

Commit migrated from https://github.com/dotnet/corefx/commit/3e817a4dbed0776dff7f91723906e95237892c0e

6 years agoMake flaky serialport test OuterLoop (dotnet/corefx#32104)
Dan Moseley [Wed, 5 Sep 2018 02:44:42 +0000 (19:44 -0700)]
Make flaky serialport test OuterLoop (dotnet/corefx#32104)

Commit migrated from https://github.com/dotnet/corefx/commit/4a3202082dfa74cd0c47dec1c0d2a8ab44d5fa2c

6 years agoAdd System.Diagnostics.PerformanceData namespace (dotnet/corefx#31474)
Marco Rossignoli [Tue, 4 Sep 2018 22:35:41 +0000 (00:35 +0200)]
Add System.Diagnostics.PerformanceData namespace (dotnet/corefx#31474)

* move System.Diagnostics.PerformanceData from netfx

* updates

* use type aliases, fix style, cleanup

* remove CAS attributes

* nit: extralines

* Add tests

* update tests

* update tests

* update tests,use type aliases, cleanup

* address PR feedback

* address some of PR feedback

* address some  of PR feedback

* address some of PR feedback

* address PR feedback

* added retry/dispose

* update tests

* try to run new test in isolated process

* revert changes to other tests, add retry on new test

* fix netfx test fail, add comments

Commit migrated from https://github.com/dotnet/corefx/commit/610e9c82ed930e7473e478ecb96e000a32ff7908

6 years agoFix ServiceController name population perf (dotnet/corefx#32072)
Dan Moseley [Tue, 4 Sep 2018 22:21:28 +0000 (15:21 -0700)]
Fix ServiceController name population perf (dotnet/corefx#32072)

* Fix ServiceController name population perf

* Split tests

* Remove dead field

* Remove new use of DangerousGetHandle

* SafeHandle all the things!

* VSB dotnet/corefx#1

* VSB dotnet/corefx#2

* Fix GLE

* Initialize machineName in ctor

* Test for empty name ex

* Null names

* Inadvertent edit

* Unix build

* Move interop into class

* Reverse SafeHandle for HAllocGlobal

* Fix tests

* Disable test for NETFX

* CR feedback

* Pattern matching on VSB

* Direct call

* typo

Commit migrated from https://github.com/dotnet/corefx/commit/76c8587e935fb501d57b10de44826e1f99b69236

6 years agoAdd hybrid support for OpenSSL 1.0 and 1.1
Jeremy Barton [Tue, 4 Sep 2018 19:53:06 +0000 (12:53 -0700)]
Add hybrid support for OpenSSL 1.0 and 1.1

This changes the functional code to use OpenSSL 1.1 API in the places where the API changed. "apibridge" provides equivalent methods for the OpenSSL 1.0 environment.

The following configurations have been tested:

* Non-portable against OpenSSL 1.0
* Non-portable against OpenSSL 1.1
* Portable, built against OpenSSL 1.0 and run against OpenSSL 1.0
* Portable, built against OpenSSL 1.0 and run against OpenSSL 1.1
* Portable, built against OpenSSL 1.1 and run against OpenSSL 1.0
* Portable, built against OpenSSL 1.1 and run against OpenSSL 1.1

In opensslshim, the PER_FUNCTION_BLOCK macro style has been broken up into a named purposes:

* REQUIRED_FUNCTION(fn)
  * API that we use unconditionally, regardless of version
  * Formerly PER_FUNCTION_BLOCK(fn, true)
* NEW_REQUIRED_FUNCTION(fn)
  * API that we use unconditionally in paths that only exist against OpenSSL 1.1, is not probed for when the runtime is 1.0
* LIGHTUP_FUNCTION(fn)
  * API that might not exist, must be probed with API_EXISTS checks before being utilized
  * Formerly PER_FUNCTION_BLOCK(fn, false)
* FALLBACK_FUNCTION(fn)
  * API that is required on OpenSSL 1.1, and when not found will bind to a method named local_#fn in the shim library
* RENAMED_FUNCTION(fn,oldfn)
  * Handles a rename with no signature change from oldfn to newfn, binds appropriately based on the runtime library.
* LEGACY_FUNCTION(fn)
  * API that we use unconditionally in paths that only exist against OpenSSL 1.0, is not probed for when the runtime is 1.1.

Two new #defines are available, but ideally need no further usage:

* NEED_OPENSSL_1_0
  * Defined when building portable, or on non-portable when the headers are OpenSSL 1.0
* NEED_OPENSSL_1_1
  * Defined when building portable, or on non-portable when the headers are OpenSSL 1.1

Commit migrated from https://github.com/dotnet/corefx/commit/901ff58aee521984e8791f9f7d51fabfd31f910e

6 years agoUpdate CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26904...
dotnet-maestro-bot [Tue, 4 Sep 2018 15:14:52 +0000 (08:14 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26904-01, preview1-26904-01, preview1-26903-03, beta-26904-00, beta-26904-00, respectively (dotnet/corefx#32074)

Commit migrated from https://github.com/dotnet/corefx/commit/35fed5e0ddb8225bd9bcb1de330ca675227a3a7b

6 years agoFix interop signature of DsaSign to not claim ReadOnly behavior
Filip Navara [Tue, 4 Sep 2018 04:42:47 +0000 (06:42 +0200)]
Fix interop signature of DsaSign to not claim ReadOnly behavior

Commit migrated from https://github.com/dotnet/corefx/commit/816056b2a835f5c68f3b2bfaa81bd4bb5ba0932a

6 years agoConvert S.S.C.Pkcs to ASN code generator.
Filip Navara [Tue, 4 Sep 2018 04:41:17 +0000 (06:41 +0200)]
Convert S.S.C.Pkcs to ASN code generator.

Commit migrated from https://github.com/dotnet/corefx/commit/6e6d9c39866b987bfbf8b660c69038c84afb7423

6 years agoOld Linux kernels might not support SO_REUSEPORT (dotnet/corefx#31187)
Egor Bogatov [Tue, 4 Sep 2018 03:20:18 +0000 (06:20 +0300)]
Old Linux kernels might not support SO_REUSEPORT (dotnet/corefx#31187)

* throw not supported if SO_REUSEPORT is not defined

* Ignore Reuse flag if SO_REUSEPORT is not supported

* remove redundant return Error_SUCCESS;

* move #ifdef SO_REUSEPORT up a bit

* improve #if-else-endif readability

Commit migrated from https://github.com/dotnet/corefx/commit/3c9eb8460600d5a04bfa90bc9a777408c6ff61c3

6 years agoMerge pull request dotnet/corefx#31240 from bbowyersmyth/VB_Collection
Dan Moseley [Mon, 3 Sep 2018 02:52:00 +0000 (19:52 -0700)]
Merge pull request dotnet/corefx#31240 from bbowyersmyth/VB_Collection

Port and test VB Collection

Commit migrated from https://github.com/dotnet/corefx/commit/2dde65cc733a1b7f4560a7246b2b959710f5b784

6 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to...
dotnet-maestro-bot [Sun, 2 Sep 2018 04:59:29 +0000 (21:59 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03131-07, preview1-26902-01, preview1-26902-01, preview1-26901-05, beta-26831-00, beta-26831-00, respectively (dotnet/corefx#32071)

Commit migrated from https://github.com/dotnet/corefx/commit/75668a6bb7a3b90853a1a0e5a636c43baddf6872

6 years agoUpdate BuildTools, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1...
dotnet-maestro-bot [Sun, 2 Sep 2018 01:09:05 +0000 (18:09 -0700)]
Update BuildTools, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03130-04, preview1-26830-04, preview1-26830-01, beta-26830-00, beta-26830-00, respectively (dotnet/corefx#31994)

Remove things that were added to BuildTools

Some support was added in https://github.com/dotnet/buildtools/pull/2151
so we need to remove them from corefx repo targets now.

Commit migrated from https://github.com/dotnet/corefx/commit/24153497a70093e381e1b59e14613ee508e6f67a

6 years agoFixing incorrect project configurations
Jose Perez Rodriguez [Thu, 30 Aug 2018 20:36:41 +0000 (13:36 -0700)]
Fixing incorrect project configurations

Commit migrated from https://github.com/dotnet/corefx/commit/f6787466fed02bc21c4e0b453e3664bd1d9e75b8

6 years agoFix build break caused by conflicting changes
Jan Kotas [Sat, 1 Sep 2018 16:47:13 +0000 (09:47 -0700)]
Fix build break caused by conflicting changes

Ifdef use of Reflection.Emit for netstandard build of System.Runtime.InteropServices tests. I choose to ifdef it out instead of
refactoring into small files since this change is temporary. These ifdefs should be removed once Reflection.Emit is added to netstandard2.1.

Commit migrated from https://github.com/dotnet/corefx/commit/83cc1fe1dd028261bfed42b634bdab51e651c050

6 years agoFinally fix Api Catalog drop (dotnet/corefx#32061)
Santiago Fernandez Madero [Fri, 31 Aug 2018 22:20:29 +0000 (15:20 -0700)]
Finally fix Api Catalog drop (dotnet/corefx#32061)

Commit migrated from https://github.com/dotnet/corefx/commit/b08e6f13daf464f8a41e0a6e1afa9dc1ca616856

6 years agoOptimize RemoveAt() method in OrderedDictionary class (dotnet/corefx#32044)
Ilya [Fri, 31 Aug 2018 20:57:19 +0000 (01:57 +0500)]
Optimize RemoveAt() method in OrderedDictionary class (dotnet/corefx#32044)

Commit migrated from https://github.com/dotnet/corefx/commit/243e24c32fd587f046b23b9770fb811c962aaeed

6 years agoDisable test that appears to be causing a hang in System.Net.Http tests. (dotnet...
Max Kerr [Fri, 31 Aug 2018 19:12:14 +0000 (12:12 -0700)]
Disable test that appears to be causing a hang in System.Net.Http tests. (dotnet/corefx#32048)

Commit migrated from https://github.com/dotnet/corefx/commit/01d396a97a5c07dd78c0da7fac80f6b4cf23cb40

6 years agoErase temporary copies of plaintext during de/padding operations
Jeremy Barton [Fri, 31 Aug 2018 05:20:57 +0000 (22:20 -0700)]
Erase temporary copies of plaintext during de/padding operations

When symmetric block padding is added, or removed, the
UniversalCryptoDecryptor and UniversalCryptoEncryptor classes make a
temporary buffer to hold the padded result (for encryption this is the input to
the cryptographic transform, for decryption it is the output before calling
DepadBlock).

While these buffers are usually marked as unused by the GC in short order, and
overwritten by new objects in short order, some applications are more sensitive
to having plaintext residuals in memory; and we should clear these out before
abandoning them to the garbage collector.

Commit migrated from https://github.com/dotnet/corefx/commit/bb54ed5540d19a1595443bab0233e3c985da9dad

6 years agoMerge pull request dotnet/corefx#32001 from iSazonov/fix-ordereddictionary
Dan Moseley [Thu, 30 Aug 2018 22:58:17 +0000 (15:58 -0700)]
Merge pull request dotnet/corefx#32001 from iSazonov/fix-ordereddictionary

Exclude extra allocations in OrderedDictionary

Commit migrated from https://github.com/dotnet/corefx/commit/92cc2668f6413853a403155bfd79c37a7f0d75b6

6 years agoEnhance existing Marshal tests (dotnet/corefx#31196)
Hugh Bellamy [Thu, 30 Aug 2018 21:11:41 +0000 (22:11 +0100)]
Enhance existing Marshal tests (dotnet/corefx#31196)

Commit migrated from https://github.com/dotnet/corefx/commit/f024dd1d54aa29354e8840c5ead72f4fbd8cf1de

6 years agoUpdate compat pack dependency on System.IO.Pipes.AccessControl (dotnet/corefx#32035)
Santiago Fernandez Madero [Thu, 30 Aug 2018 20:53:03 +0000 (13:53 -0700)]
Update compat pack dependency on System.IO.Pipes.AccessControl (dotnet/corefx#32035)

Commit migrated from https://github.com/dotnet/corefx/commit/e4a2cc08954407a6359032641e72e6c53124bba7

6 years agoAdding netstandard configuration for System.Runtime.Tests (dotnet/corefx#32032)
Jose Perez Rodriguez [Thu, 30 Aug 2018 18:43:53 +0000 (11:43 -0700)]
Adding netstandard configuration for System.Runtime.Tests (dotnet/corefx#32032)

Commit migrated from https://github.com/dotnet/corefx/commit/f252ef6d695176143aa46b855db5553fb6e44921

6 years agoAdding the ability to build a NETStandard test suite (dotnet/corefx#31850)
Jose Perez Rodriguez [Thu, 30 Aug 2018 17:36:32 +0000 (10:36 -0700)]
Adding the ability to build a NETStandard test suite (dotnet/corefx#31850)

* Adding the ability to build a NETStandard test suite

* Adding the netstandard vertical of the tests as a separate command to the allConfigurations leg

* Fixing System.IO.Pipelines.Tests that was broken for the netstandard configuration

Commit migrated from https://github.com/dotnet/corefx/commit/0c5594864387aef6d9f6c8842f8a9e476ef39cc3

6 years agoRename xunit config for System.Globalization.Calendars (dotnet/corefx#32020)
Viktor Hofer [Thu, 30 Aug 2018 17:03:41 +0000 (19:03 +0200)]
Rename xunit config for System.Globalization.Calendars (dotnet/corefx#32020)

Commit migrated from https://github.com/dotnet/corefx/commit/68b76c30eafb3647c11e3f766a2645b130ca1448

6 years agoUpdate compat pack validation to reference asp 3.0.0 package (dotnet/corefx#32031)
Santiago Fernandez Madero [Thu, 30 Aug 2018 16:33:04 +0000 (09:33 -0700)]
Update compat pack validation to reference asp 3.0.0 package (dotnet/corefx#32031)

Commit migrated from https://github.com/dotnet/corefx/commit/97a43d132bd235cb72edfdcb5fa680fbcf5891cb

6 years agoEnsure that TrySetECDHNamedCurve is always called, enabling ECDHE ciphersuites
Jeremy Barton [Thu, 30 Aug 2018 07:48:13 +0000 (00:48 -0700)]
Ensure that TrySetECDHNamedCurve is always called, enabling ECDHE ciphersuites

Moves the call to TrySetECDHNamedCurve above the early abort when the server default protocols are selected.

This ensures that when SslStream is used as a TLS server that the ECDHE ciphersuites are available for "Perfect Forward Secrecy".

By using an SslStream-based TLS server and the openssl s_client utility as a client, verified that the ciphersuite went from ECDH-ECDSA-AES256-GCM-SHA384 to ECDHE-ECDSA-AES256-GCM-SHA384 (and AES256-GCM-SHA384 to ECDHE-RSA-AES256-GCM-SHA384 for RSA).

Commit migrated from https://github.com/dotnet/corefx/commit/18720f9b286770a08f59e866e4da220d3aadaf29

6 years agoAddress feedback 1
iSazonov [Thu, 30 Aug 2018 04:57:05 +0000 (09:57 +0500)]
Address feedback 1

Commit migrated from https://github.com/dotnet/corefx/commit/5670a43510957592b2d84fd9273d87471b8950d2

6 years agoRemove [Flags] from RegistryKeyPermissionCheck (dotnet/corefx#31998)
Egor Bogatov [Thu, 30 Aug 2018 00:44:39 +0000 (03:44 +0300)]
Remove [Flags] from RegistryKeyPermissionCheck (dotnet/corefx#31998)

Commit migrated from https://github.com/dotnet/corefx/commit/c904bd123b209ad5b42f48f3a4ef33616b387734

6 years agoMerge pull request dotnet/corefx#32014 from weshaggard/moveto30
Wes Haggard [Thu, 30 Aug 2018 00:33:25 +0000 (17:33 -0700)]
Merge pull request dotnet/corefx#32014 from weshaggard/moveto30

Remap netcoreapp to netcoreapp3.0

Commit migrated from https://github.com/dotnet/corefx/commit/9a050ff1fe72bb8b757af1ed9d48c379f35cfcfb

6 years agoUpdate System.Io.Pipes.AccessControl.Tests to only target what we build
Wes Haggard [Wed, 29 Aug 2018 21:20:34 +0000 (14:20 -0700)]
Update System.Io.Pipes.AccessControl.Tests to only target what we build

We only build netcoreapp and uap for this library now so only test
those configurations.

Commit migrated from https://github.com/dotnet/corefx/commit/b12f8558e5e80f7d1e45182ace5bac226906c954

6 years agoFix merge conflict with missing define for netcoreapp2.1
Wes Haggard [Wed, 29 Aug 2018 19:07:34 +0000 (12:07 -0700)]
Fix merge conflict with missing define for netcoreapp2.1

After the recent merge of moving the defines we need to continue
to define netcoreapp in the System.Data.SqlClient project even for
the netcoreapp2.1 build configuration.

Commit migrated from https://github.com/dotnet/corefx/commit/5da5fd3628253da1d2578ab5c6a437202ac76254

6 years agoAdd unloadable AssemblyLoadContext API and tests (dotnet/corefx#32002)
Jan Vorlicek [Wed, 29 Aug 2018 17:58:24 +0000 (19:58 +0200)]
Add unloadable AssemblyLoadContext API and tests (dotnet/corefx#32002)

* Add unloadable AssemblyLoadContext API and tests

The change is based on dotnet/corefx#14763, but I had to change many things due to
the fact that the project.json files are not used anymore and due to the
slighly different semantics of the Unloading event, which now fires when
the unloading is about to start and doesn't indicate the unload is
almost done as before.

Additional changes:
* Tests for all remaining unsupported features:
  * delegate marshalling for types in collectible assemblies
  * FixedAddressValueTypeAttribute
  * COM interop
* Removed checked in binary System.Runtime.Loader.Test.Assembly.dll,
modified the msbuild projects to build it at the build time instead.
* Added the new APIs to ApiCompatBaseline

Commit migrated from https://github.com/dotnet/corefx/commit/cfb501e9b73fd472a9bc5dcc38ba72f7f4183a38

6 years agoUpdate the configurations properties in projects
Wes Haggard [Wed, 29 Aug 2018 16:45:04 +0000 (09:45 -0700)]
Update the configurations properties in projects

Commit migrated from https://github.com/dotnet/corefx/commit/fea86686c620242ce7e1911418f2fba7c4d52d4d

6 years agoAdd netcoreapp2.1 placeholder configuration to System.Threading.Tasks.Extensions
Wes Haggard [Wed, 29 Aug 2018 00:41:58 +0000 (17:41 -0700)]
Add netcoreapp2.1 placeholder configuration to System.Threading.Tasks.Extensions

This placeholder prevents the netstandard ref from being bin-placed into
the ref/netcoreapp2.1 folder which causes issues because types were moved
down to system.runtime in 2.1.

Commit migrated from https://github.com/dotnet/corefx/commit/0c68c2fe46363690dd8c680fa29f0b72adf8a1c1

6 years agoAdd netcoreapp2.1 build for System.Threading.Channels
Wes Haggard [Tue, 28 Aug 2018 22:46:38 +0000 (15:46 -0700)]
Add netcoreapp2.1 build for System.Threading.Channels

Commit migrated from https://github.com/dotnet/corefx/commit/a903f8612640ad81535078f9e5ebda1c79e403b9

6 years agoAdd netcoreapp2.1 build for System.Net.WebSockets.WebSocketProtocol
Wes Haggard [Tue, 28 Aug 2018 22:27:08 +0000 (15:27 -0700)]
Add netcoreapp2.1 build for System.Net.WebSockets.WebSocketProtocol

Commit migrated from https://github.com/dotnet/corefx/commit/0cb09ad87ce1e685700430d8065a6285af7ad1ae

6 years agoRemove package for System.IO.Pipes.AccessControl
Wes Haggard [Tue, 28 Aug 2018 22:22:39 +0000 (15:22 -0700)]
Remove package for System.IO.Pipes.AccessControl

We no longer need to ship an updated version of this package
so remove it as well as all but the netcoreapp and uap build
configurations. The API surface is frozen because it is inbox on
uap so we cannot do anything beyond service the package which can
happen in the servicing branches. If we need to make a larger change
to this library we can always bring back the package and harvest
all the older assets.

Commit migrated from https://github.com/dotnet/corefx/commit/4e76a6c02552422ce07967f4249acad3b71b80ef

6 years agoAdd netcoreapp2.1 build for System.IO.Pipelines
Wes Haggard [Tue, 28 Aug 2018 16:55:17 +0000 (09:55 -0700)]
Add netcoreapp2.1 build for System.IO.Pipelines

Commit migrated from https://github.com/dotnet/corefx/commit/c4819047d93419d3e230e483c117ae7302dd6f34

6 years agoAdd netcoreapp2.1 build for System.Data.SqlClient
Wes Haggard [Tue, 28 Aug 2018 16:51:38 +0000 (09:51 -0700)]
Add netcoreapp2.1 build for System.Data.SqlClient

Commit migrated from https://github.com/dotnet/corefx/commit/9784d6aadef8e5b19ba192444b767c0f93652ff7

6 years agoAdd netcoreapp2.1 build for System.ServiceModel.Syndication
Wes Haggard [Tue, 28 Aug 2018 16:47:57 +0000 (09:47 -0700)]
Add netcoreapp2.1 build for System.ServiceModel.Syndication

Commit migrated from https://github.com/dotnet/corefx/commit/0b71879a3aa8816de9c2ec575dcebb09995752f7

6 years agoAdd netcoreapp2.1 targeting support
Wes Haggard [Tue, 28 Aug 2018 16:41:55 +0000 (09:41 -0700)]
Add netcoreapp2.1 targeting support

Commit migrated from https://github.com/dotnet/corefx/commit/afafb2acfb41219d140d57f1cc0ce4bd4094c305

6 years agoHarvest 2.1 assets for Crypto libraries
Wes Haggard [Tue, 28 Aug 2018 01:23:50 +0000 (18:23 -0700)]
Harvest 2.1 assets for Crypto libraries

Commit migrated from https://github.com/dotnet/corefx/commit/eef0bf30fd83e22811260d0d975f3a59b4507420

6 years agoSet NETCoreAppMaximumVersion to 3.0 so we can build with older sdk
Wes Haggard [Tue, 28 Aug 2018 01:02:15 +0000 (18:02 -0700)]
Set NETCoreAppMaximumVersion to 3.0 so we can build with older sdk

Need to set NETCoreAppMaximumVersion to 3.0 when building a 3.0
project with the 2.x sdk.

Commit migrated from https://github.com/dotnet/corefx/commit/fcf67edf540033046715bb6079996c6345a6be3f

6 years agoMove new packages to 3.0 as supported versions
Wes Haggard [Tue, 21 Aug 2018 17:42:42 +0000 (10:42 -0700)]
Move new packages to 3.0 as supported versions

Commit migrated from https://github.com/dotnet/corefx/commit/b45f4c09123b15a36b1f5633204e5f2c5ab583d6

6 years agoRemap netcoreapp to netcoreapp3.0
Wes Haggard [Tue, 21 Aug 2018 16:38:18 +0000 (09:38 -0700)]
Remap netcoreapp to netcoreapp3.0

Commit migrated from https://github.com/dotnet/corefx/commit/fa4bf93546185f7bc0f7b5c3d499f785f5a4212f

6 years agoMerge pull request dotnet/corefx#31993 from weshaggard/harvest21
Wes Haggard [Wed, 29 Aug 2018 16:32:29 +0000 (09:32 -0700)]
Merge pull request dotnet/corefx#31993 from weshaggard/harvest21

Update the stable packages and harvested package versions.

Commit migrated from https://github.com/dotnet/corefx/commit/b89a1f8c4b2bb018bb428b1323b79fddf3d72c6d

6 years agoMove uap, uapaot, netfx, netcoreapp and netcoreapp20 constant definitions to top...
Filip Navara [Wed, 29 Aug 2018 15:49:33 +0000 (17:49 +0200)]
Move uap, uapaot, netfx, netcoreapp and netcoreapp20 constant definitions to top-level build file. (dotnet/corefx#31470)

* Move uap, uapaot, netfx and netcoreapp constant definitions to top-level build file.

* Trying to fix compilation of PerformanceCounterLib for netcoreapp2.0 targets.

* Change netcoreapp definition to mean the current version only.

* Fix conflict in System.Private.DataContractSerialization.csproj.

* Revert change in src/shims/manual/Directory.Build.props.

* Fix condition in test.

* Bring back TargetsNetCoreApp, it was lost during rebases.

* Move definition of netstandard to top-level build file. Remove more netcoreapp/uap definitions from individual files.

* Fix vbproj compatibility.

* Address PR review and unify the definitions to use TargetGroup directly.

* Add back one "netstandard" definition.

Commit migrated from https://github.com/dotnet/corefx/commit/ac994544e749eac3e85b60bf0012ae2f85ae0e49

6 years agoMerge pull request dotnet/corefx#31991 from mikem8361/fixrace
Mike McLaughlin [Wed, 29 Aug 2018 04:45:13 +0000 (21:45 -0700)]
Merge pull request dotnet/corefx#31991 from mikem8361/fixrace

Fix race in the StackTraceSymbols.CoreCLR.cs metadata provider cache.

Commit migrated from https://github.com/dotnet/corefx/commit/cf7c16a2aa71fe6a576579fc159513f46a65d643

6 years agoReplace properties with methods EnsureObjectsTable() and EnsureObjectsArray()
iSazonov [Wed, 29 Aug 2018 04:27:14 +0000 (09:27 +0500)]
Replace properties with methods EnsureObjectsTable() and EnsureObjectsArray()

Commit migrated from https://github.com/dotnet/corefx/commit/551ba9e70c3e5ace47c8ccb36a0815cfc074fb3a