platform/upstream/libSkiaSharp.git
12 years agoDisable WritePixelsTest on Android
borenet@google.com [Thu, 12 Jul 2012 19:48:42 +0000 (19:48 +0000)]
Disable WritePixelsTest on Android

This fails on Xoom.  Re-enable when #634 is fixed.
Review URL: https://codereview.appspot.com/6354099

git-svn-id: http://skia.googlecode.com/svn/trunk@4584 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoshape ops work in progress
caryclark@google.com [Thu, 12 Jul 2012 19:29:45 +0000 (19:29 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@4583 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded a benchmark for measuring picture unflattening time.
keyar@chromium.org [Thu, 12 Jul 2012 19:19:55 +0000 (19:19 +0000)]
Added a benchmark for measuring picture unflattening time.

Review URL: https://codereview.appspot.com/6354097

git-svn-id: http://skia.googlecode.com/svn/trunk@4582 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorename NO_ERROR to kNoError, because Windows defines a NO_ERROR macro elsewhere
epoger@google.com [Thu, 12 Jul 2012 18:37:55 +0000 (18:37 +0000)]
rename NO_ERROR to kNoError, because Windows defines a NO_ERROR macro elsewhere

TBR=rmistry
Review URL: https://codereview.appspot.com/6355100

git-svn-id: http://skia.googlecode.com/svn/trunk@4581 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoskdiff: add --failonmismatches and --listfilename options, plus cleanup
epoger@google.com [Thu, 12 Jul 2012 18:16:02 +0000 (18:16 +0000)]
skdiff: add --failonmismatches and --listfilename options, plus cleanup

These changes are needed in order to switch the buildbots from using "gm -r" to "skdiff" to compare gm results, and should be generally good for humans too.
Review URL: https://codereview.appspot.com/6392054

git-svn-id: http://skia.googlecode.com/svn/trunk@4579 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoCleanup restore offsets at end of SkPicture recording
junov@chromium.org [Thu, 12 Jul 2012 17:47:34 +0000 (17:47 +0000)]
Cleanup restore offsets at end of SkPicture recording

Review URL: http://codereview.appspot.com/6355099/
TEST=skia unit test CanvasTest, test step TwoClipOps
BUG=https://code.google.com/p/chromium/issues/detail?id=133432

git-svn-id: http://skia.googlecode.com/svn/trunk@4577 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoIntroduces new SingleTextureEffect base class for GrCustomStage objects.
tomhudson@google.com [Thu, 12 Jul 2012 17:23:52 +0000 (17:23 +0000)]
Introduces new SingleTextureEffect base class for GrCustomStage objects.
This class tracks the texture that the object uses. A future commit will get rid of the
GrTexture pointer currenty stored in the GrDrawState, allowing us to have CustomStages
*without* textures.

Requires gyp change on next roll.

http://codereview.appspot.com/6306097/

git-svn-id: http://skia.googlecode.com/svn/trunk@4576 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRefactor how precision is handled with GrGLShaderVar
bsalomon@google.com [Thu, 12 Jul 2012 16:40:03 +0000 (16:40 +0000)]
Refactor how precision is handled with GrGLShaderVar

Review URL: http://codereview.appspot.com/6392049/

git-svn-id: http://skia.googlecode.com/svn/trunk@4575 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorebaseline macpro for convexpaths (test was changed)
reed@google.com [Thu, 12 Jul 2012 15:59:09 +0000 (15:59 +0000)]
rebaseline macpro for convexpaths (test was changed)

git-svn-id: http://skia.googlecode.com/svn/trunk@4574 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded annotation for gm's -wp flag
chudy@google.com [Thu, 12 Jul 2012 15:42:37 +0000 (15:42 +0000)]
Added annotation for gm's -wp flag

Review URL: https://codereview.appspot.com/6345098

git-svn-id: http://skia.googlecode.com/svn/trunk@4573 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agocheck a hashtable before using a bsearch
reed@google.com [Thu, 12 Jul 2012 15:27:54 +0000 (15:27 +0000)]
check a hashtable before using a bsearch
Review URL: https://codereview.appspot.com/6345097

git-svn-id: http://skia.googlecode.com/svn/trunk@4572 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixing bad assertion test that was trippin-up debug buildbots
junov@chromium.org [Thu, 12 Jul 2012 14:44:52 +0000 (14:44 +0000)]
Fixing bad assertion test that was trippin-up debug buildbots

TBR=http://codereview.appspot.com/6344109

git-svn-id: http://skia.googlecode.com/svn/trunk@4569 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix the lighting filters unit test and re-enable it.
senorblanco@chromium.org [Thu, 12 Jul 2012 14:39:07 +0000 (14:39 +0000)]
Fix the lighting filters unit test and re-enable it.

Review URL:  http://codereview.appspot.com/6355098/

git-svn-id: http://skia.googlecode.com/svn/trunk@4568 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoBug Fix: Delete redraws correctly when redraw command execution is paused
chudy@google.com [Thu, 12 Jul 2012 14:38:49 +0000 (14:38 +0000)]
Bug Fix: Delete redraws correctly when redraw command execution is paused

Review URL: https://codereview.appspot.com/6392053

git-svn-id: http://skia.googlecode.com/svn/trunk@4567 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSkHitBox added.
chudy@google.com [Thu, 12 Jul 2012 14:31:25 +0000 (14:31 +0000)]
SkHitBox added.

SkHitBox is a class that determines which draw command is associated with the pixel located at x,y. By calculating a single point instead of the entire bitmap at once there is no visible performance slowdown.

Review URL: https://codereview.appspot.com/6350098

git-svn-id: http://skia.googlecode.com/svn/trunk@4565 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSeperated Space for displaying breakpoint and deletion icons
chudy@google.com [Thu, 12 Jul 2012 14:15:54 +0000 (14:15 +0000)]
Seperated Space for displaying breakpoint and deletion icons

Review URL: https://codereview.appspot.com/6356094

git-svn-id: http://skia.googlecode.com/svn/trunk@4563 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixing type mask computation in SkMatrix to make it faster and make it so that matric...
junov@chromium.org [Thu, 12 Jul 2012 14:01:32 +0000 (14:01 +0000)]
Fixing type mask computation in SkMatrix to make it faster and make it so that matrices have the same type masks as their inverses.
This patch also add bench tests that call invert() followed by mapRect() on various types of matrices.  Performance of these tests was greatly affected by typemask computation

Review URL: http://codereview.appspot.com/6380043/
BUG=https://code.google.com/p/chromium/issues/detail?id=135259

git-svn-id: http://skia.googlecode.com/svn/trunk@4562 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAltered complexclip GM to test out saveLayer w/ a bound and clipping
robertphillips@google.com [Thu, 12 Jul 2012 13:48:46 +0000 (13:48 +0000)]
Altered complexclip GM to test out saveLayer w/ a bound and clipping

http://codereview.appspot.com/6344108/

git-svn-id: http://skia.googlecode.com/svn/trunk@4561 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoshape ops work in progress
caryclark@google.com [Thu, 12 Jul 2012 12:52:50 +0000 (12:52 +0000)]
shape ops work in progress

M    Intersection/Simplify.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@4560 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoThe correct fix for the lighting filters on Windows: set the GL calling
senorblanco@chromium.org [Thu, 12 Jul 2012 00:34:39 +0000 (00:34 +0000)]
The correct fix for the lighting filters on Windows:  set the GL calling
convention for all targets, not just gpu, since effects now makes GL calls too.

Build fix; unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@4559 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded GrContext::AutoClipStack to encapsulate setting\resetting of clip stack
robertphillips@google.com [Wed, 11 Jul 2012 20:57:46 +0000 (20:57 +0000)]
Added GrContext::AutoClipStack to encapsulate setting\resetting of clip stack

http://codereview.appspot.com/6343097/

git-svn-id: http://skia.googlecode.com/svn/trunk@4558 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix lighting filters on Windows, and re-enable the GPU path.
senorblanco@chromium.org [Wed, 11 Jul 2012 20:49:26 +0000 (20:49 +0000)]
Fix lighting filters on Windows, and re-enable the GPU path.

Review URL:  http://codereview.appspot.com/6354094/

git-svn-id: http://skia.googlecode.com/svn/trunk@4557 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoidea: add annotation to SkPaint
reed@google.com [Wed, 11 Jul 2012 19:57:55 +0000 (19:57 +0000)]
idea: add annotation to SkPaint
Review URL: https://codereview.appspot.com/6355050

git-svn-id: http://skia.googlecode.com/svn/trunk@4555 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix linux warnings
bsalomon@google.com [Wed, 11 Jul 2012 19:45:22 +0000 (19:45 +0000)]
Fix linux warnings
Review URL: http://codereview.appspot.com/6354093/

git-svn-id: http://skia.googlecode.com/svn/trunk@4554 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix dumb copy/paste bug that breaks GLProgramTest on debug builds with GS support.
bsalomon@google.com [Wed, 11 Jul 2012 19:35:52 +0000 (19:35 +0000)]
Fix dumb copy/paste bug that breaks GLProgramTest on debug builds with GS support.

git-svn-id: http://skia.googlecode.com/svn/trunk@4553 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd default: to switch statement, to avoid warning/error for unhandled cases.
reed@google.com [Wed, 11 Jul 2012 18:56:10 +0000 (18:56 +0000)]
add default: to switch statement, to avoid warning/error for unhandled cases.

git-svn-id: http://skia.googlecode.com/svn/trunk@4552 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoremove debugging printfs
reed@google.com [Wed, 11 Jul 2012 18:55:23 +0000 (18:55 +0000)]
remove debugging printfs

git-svn-id: http://skia.googlecode.com/svn/trunk@4551 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMinor refactoring to make GrAutoMatrix a nested sub-class of GrContext
robertphillips@google.com [Wed, 11 Jul 2012 18:53:23 +0000 (18:53 +0000)]
Minor refactoring to make GrAutoMatrix a nested sub-class of GrContext

http://codereview.appspot.com/6356092/

git-svn-id: http://skia.googlecode.com/svn/trunk@4549 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd flatten/unflatten to SkDataSet
reed@google.com [Wed, 11 Jul 2012 18:48:37 +0000 (18:48 +0000)]
add flatten/unflatten to SkDataSet
Review URL: https://codereview.appspot.com/6374057

git-svn-id: http://skia.googlecode.com/svn/trunk@4548 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoDisable GPU path for lighting filters, due to Windows weirdness. Unreviewed.
senorblanco@chromium.org [Wed, 11 Jul 2012 18:47:11 +0000 (18:47 +0000)]
Disable GPU path for lighting filters, due to Windows weirdness.  Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@4547 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed merge error in r4545
robertphillips@google.com [Wed, 11 Jul 2012 18:25:24 +0000 (18:25 +0000)]
Fixed merge error in r4545

git-svn-id: http://skia.googlecode.com/svn/trunk@4546 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoForced GrClip to always have conservative bounds
robertphillips@google.com [Wed, 11 Jul 2012 18:20:35 +0000 (18:20 +0000)]
Forced GrClip to always have conservative bounds

http://codereview.appspot.com/6353089/

git-svn-id: http://skia.googlecode.com/svn/trunk@4545 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMake GrGLShaderBuilder produce the shader strings
bsalomon@google.com [Wed, 11 Jul 2012 18:11:27 +0000 (18:11 +0000)]
Make GrGLShaderBuilder produce the shader strings

Review URL: http://codereview.appspot.com/6356089/

git-svn-id: http://skia.googlecode.com/svn/trunk@4544 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoshape ops work in progress
caryclark@google.com [Wed, 11 Jul 2012 17:52:32 +0000 (17:52 +0000)]
shape ops work in progress

M    Intersection/SimplifyRect4x4_Test.cpp
M    Intersection/Simplify.cpp
M    Intersection/SimplifyFindNext_Test.cpp
M    Intersection/SimplifyNew_Test.cpp
M    Intersection/op.htm

git-svn-id: http://skia.googlecode.com/svn/trunk@4543 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd SkDataSet class, so SkAnnotation can be more immutable-like
reed@google.com [Wed, 11 Jul 2012 17:24:49 +0000 (17:24 +0000)]
add SkDataSet class, so SkAnnotation can be more immutable-like
Review URL: https://codereview.appspot.com/6354091

git-svn-id: http://skia.googlecode.com/svn/trunk@4542 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoDisable lighting filter unit test temporarily; unreviewed.
senorblanco@chromium.org [Wed, 11 Jul 2012 17:10:26 +0000 (17:10 +0000)]
Disable lighting filter unit test temporarily; unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@4541 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMac GLSL fixes; unreviewed.
senorblanco@chromium.org [Wed, 11 Jul 2012 16:44:49 +0000 (16:44 +0000)]
Mac GLSL fixes; unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@4539 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMore build fixes; unreviewed.
senorblanco@chromium.org [Wed, 11 Jul 2012 16:35:00 +0000 (16:35 +0000)]
More build fixes; unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@4537 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMac build fix; unreviewed.
senorblanco@chromium.org [Wed, 11 Jul 2012 16:25:37 +0000 (16:25 +0000)]
Mac build fix; unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@4536 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoThis patch implements the diffuse and specular lighting filters in Ganesh.
senorblanco@chromium.org [Wed, 11 Jul 2012 16:01:22 +0000 (16:01 +0000)]
This patch implements the diffuse and specular lighting filters in Ganesh.
There are three light types for each:  distant, point and spot, whose code
generation lives in a GrGLLight class hierarchy.  This similar to the CPU
implementation, where each light type provides a function to compute the vector
from the surface plane to the light (surfaceToLight) and to compute the light
colour (emitLightColour).  Instead of templated member functions, as in the CPU
implementation, these are virtual functions to emit the light-specific GLSL
code.

All of the code for the GPU path lives in the same file as that for the CPU
path, SkLightingImageFilter.cpp.  In order to provide Ganesh a hook to access
it, SkImageFilter now has a asNewCustomStage() virtual, which allows an image
filter to return a GrCustomStage representing that filter.

Note that this patch does not handle the border conditions correctly (the
[top|bottom][Left|Right]Normal() functions in the CPU implementation).  That
will come in a future patch.

Review URL: http://codereview.appspot.com/6345081/

git-svn-id: http://skia.googlecode.com/svn/trunk@4535 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoVariableVisibility -> ShaderType
bsalomon@google.com [Wed, 11 Jul 2012 15:03:31 +0000 (15:03 +0000)]
VariableVisibility -> ShaderType

Review URL: http://codereview.appspot.com/6344103/

git-svn-id: http://skia.googlecode.com/svn/trunk@4534 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix assumption that enabled stage implies texture is present
bsalomon@google.com [Wed, 11 Jul 2012 14:56:33 +0000 (14:56 +0000)]
Fix assumption that enabled stage implies texture is present
Review URL: http://codereview.appspot.com/6353087/

git-svn-id: http://skia.googlecode.com/svn/trunk@4532 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoChange TextContext handling of stages and draw targets; this allows us to
tomhudson@google.com [Wed, 11 Jul 2012 14:41:19 +0000 (14:41 +0000)]
Change TextContext handling of stages and draw targets; this allows us to
assert in GrContext::setPaint() that all stages are disabled every time
the paint is set.

Watch for possible performance implications.

http://codereview.appspot.com/6347043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4531 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agowhitespace change to trigger Skia buildbots after master update/restart
epoger@google.com [Wed, 11 Jul 2012 13:47:04 +0000 (13:47 +0000)]
whitespace change to trigger Skia buildbots after master update/restart

git-svn-id: http://skia.googlecode.com/svn/trunk@4530 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRevert SkNO_RETURN_HINT fix in favor of a simpler fix
bsalomon@google.com [Wed, 11 Jul 2012 13:30:08 +0000 (13:30 +0000)]
Revert SkNO_RETURN_HINT fix in favor of a simpler fix

git-svn-id: http://skia.googlecode.com/svn/trunk@4529 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix SkNO_RETURN_HINT warnings on mac/clang
bsalomon@google.com [Wed, 11 Jul 2012 12:52:04 +0000 (12:52 +0000)]
Fix SkNO_RETURN_HINT warnings on mac/clang

Review URL: http://codereview.appspot.com/6392048/

git-svn-id: http://skia.googlecode.com/svn/trunk@4528 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoCommit baselines for convexpaths GM.
bsalomon@google.com [Wed, 11 Jul 2012 12:45:23 +0000 (12:45 +0000)]
Commit baselines for convexpaths GM.

git-svn-id: http://skia.googlecode.com/svn/trunk@4527 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd SkPath::contains(x, y)
mike@reedtribe.org [Wed, 11 Jul 2012 01:51:33 +0000 (01:51 +0000)]
add SkPath::contains(x, y)

git-svn-id: http://skia.googlecode.com/svn/trunk@4526 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRebaseline due to r4518.
bsalomon@google.com [Tue, 10 Jul 2012 21:56:41 +0000 (21:56 +0000)]
Rebaseline due to r4518.

git-svn-id: http://skia.googlecode.com/svn/trunk@4525 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMove animated view headers to correct directory.
bungeman@google.com [Tue, 10 Jul 2012 21:54:31 +0000 (21:54 +0000)]
Move animated view headers to correct directory.

git-svn-id: http://skia.googlecode.com/svn/trunk@4524 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoReplace all instances of 'clear' with 'pop's in conical gradient pdf impl, looks...
rileya@google.com [Tue, 10 Jul 2012 20:41:38 +0000 (20:41 +0000)]
Replace all instances of 'clear' with 'pop's in conical gradient pdf impl, looks like the pdf spec doesn't support Postscript's 'clear' stack operator. Should fix some warnings on mac buildbots.

git-svn-id: http://skia.googlecode.com/svn/trunk@4521 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded pdf implementation of conical gradient.
rileya@google.com [Tue, 10 Jul 2012 20:05:23 +0000 (20:05 +0000)]
Added pdf implementation of conical gradient.
Also fixed an erroneous comment in the gpu implementation.
Review URL: https://codereview.appspot.com/6351076

git-svn-id: http://skia.googlecode.com/svn/trunk@4520 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoEach benchmark that needs a bitmap will now make its own.
keyar@chromium.org [Tue, 10 Jul 2012 19:53:59 +0000 (19:53 +0000)]
Each benchmark that needs a bitmap will now make its own.

Before, the bitmaps were created and then passed to the benchmark. However, some benchmarks in the future will not require bitmaps. This will remove the necessity of passing around an extraneous bitmap to those tests.

Review URL: https://codereview.appspot.com/6356081

git-svn-id: http://skia.googlecode.com/svn/trunk@4519 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoPreserve convex control point polygon in cubic->quadratic approximation
bsalomon@google.com [Tue, 10 Jul 2012 19:53:34 +0000 (19:53 +0000)]
Preserve convex control point polygon in cubic->quadratic approximation

GM test modified, will require rebaselining.

Review URL: http://codereview.appspot.com/6355088/

git-svn-id: http://skia.googlecode.com/svn/trunk@4518 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoChange SkFlatData to have a sentinel value, allowing the Compare function to
reed@google.com [Tue, 10 Jul 2012 19:38:01 +0000 (19:38 +0000)]
Change SkFlatData to have a sentinel value, allowing the Compare function to
not need a loop-end-test.
Review URL: https://codereview.appspot.com/6355086

git-svn-id: http://skia.googlecode.com/svn/trunk@4517 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agobench_pictures can now take percentages for tiling width and height.Review URL: https...
keyar@chromium.org [Tue, 10 Jul 2012 18:30:18 +0000 (18:30 +0000)]
bench_pictures can now take percentages for tiling width and height.Review URL: https://codereview.appspot.com/6354074

Review URL: https://codereview.appspot.com/6354074

git-svn-id: http://skia.googlecode.com/svn/trunk@4516 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoHandle convex paths with degeneracies in cheap direction computation
bsalomon@google.com [Tue, 10 Jul 2012 18:28:12 +0000 (18:28 +0000)]
Handle convex paths with degeneracies in cheap direction computation
Review URL: http://codereview.appspot.com/6349085/

git-svn-id: http://skia.googlecode.com/svn/trunk@4515 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRemove GrStringBuilder
bsalomon@google.com [Tue, 10 Jul 2012 17:51:07 +0000 (17:51 +0000)]
Remove GrStringBuilder

Review URL: http://codereview.appspot.com/6343093/

git-svn-id: http://skia.googlecode.com/svn/trunk@4514 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agor4511 with handling for the Mac-specific CAN_IMAGE_PDF path
robertphillips@google.com [Tue, 10 Jul 2012 17:50:00 +0000 (17:50 +0000)]
r4511 with handling for the Mac-specific CAN_IMAGE_PDF path

git-svn-id: http://skia.googlecode.com/svn/trunk@4513 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix to get r4511 compiling in Debug
robertphillips@google.com [Tue, 10 Jul 2012 17:41:27 +0000 (17:41 +0000)]
Fix to get r4511 compiling in Debug

git-svn-id: http://skia.googlecode.com/svn/trunk@4512 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed Windows compiler complaints
robertphillips@google.com [Tue, 10 Jul 2012 17:30:58 +0000 (17:30 +0000)]
Fixed Windows compiler complaints

http://codereview.appspot.com/6392044

git-svn-id: http://skia.googlecode.com/svn/trunk@4511 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMore carefully disable stages in Ganesh to avoid textures or effects
tomhudson@google.com [Tue, 10 Jul 2012 17:21:48 +0000 (17:21 +0000)]
More carefully disable stages in Ganesh to avoid textures or effects
leaking between draw calls.

http://codereview.appspot.com/6353083/

git-svn-id: http://skia.googlecode.com/svn/trunk@4510 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoDon't call glTexSubImage2D w/ indexed texture format on desktop GL
bsalomon@google.com [Tue, 10 Jul 2012 17:21:02 +0000 (17:21 +0000)]
Don't call glTexSubImage2D w/ indexed texture format on desktop GL

Review URL: http://codereview.appspot.com/6374048/

git-svn-id: http://skia.googlecode.com/svn/trunk@4509 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix variants in bench graphs.
bungeman@google.com [Tue, 10 Jul 2012 15:31:52 +0000 (15:31 +0000)]
Fix variants in bench graphs.

git-svn-id: http://skia.googlecode.com/svn/trunk@4508 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agobench_pictures will now output the number of tiles for a tiled benchmark.
keyar@chromium.org [Tue, 10 Jul 2012 15:13:21 +0000 (15:13 +0000)]
bench_pictures will now output the number of tiles for a tiled benchmark.

Review URL: https://codereview.appspot.com/6387044

git-svn-id: http://skia.googlecode.com/svn/trunk@4507 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRemove redundant vlayout masks and wasted vlayout bits
bsalomon@google.com [Tue, 10 Jul 2012 15:06:59 +0000 (15:06 +0000)]
Remove redundant vlayout masks and wasted vlayout bits

Review URL: http://codereview.appspot.com/6345080/

git-svn-id: http://skia.googlecode.com/svn/trunk@4506 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoBug Fix: Pause drawing execution feature works due to fixed typo
chudy@google.com [Tue, 10 Jul 2012 14:36:14 +0000 (14:36 +0000)]
Bug Fix: Pause drawing execution feature works due to fixed typo

Review URL: https://codereview.appspot.com/6349086

git-svn-id: http://skia.googlecode.com/svn/trunk@4505 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoBug Fix: Current command mask now dynamically changes based on bounds of window.
chudy@google.com [Tue, 10 Jul 2012 14:14:50 +0000 (14:14 +0000)]
Bug Fix: Current command mask now dynamically changes based on bounds of window.

Review URL: https://codereview.appspot.com/6384044

git-svn-id: http://skia.googlecode.com/svn/trunk@4504 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agobug fix: take the fAllocSize into account when we perform the compare, otherwise
reed@google.com [Tue, 10 Jul 2012 13:29:52 +0000 (13:29 +0000)]
bug fix: take the fAllocSize into account when we perform the compare, otherwise
we can read past the end of one of the flatdatas if we're unlucky.

git-svn-id: http://skia.googlecode.com/svn/trunk@4503 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMade everything in SkDebuggerGUI live on the stack
chudy@google.com [Tue, 10 Jul 2012 13:19:25 +0000 (13:19 +0000)]
Made everything in SkDebuggerGUI live on the stack

Review URL: https://codereview.appspot.com/6389043

git-svn-id: http://skia.googlecode.com/svn/trunk@4502 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agochange unique_paint_dictionary to change the paint randomly, instead of just
reed@google.com [Tue, 10 Jul 2012 13:17:45 +0000 (13:17 +0000)]
change unique_paint_dictionary to change the paint randomly, instead of just
incrementing a value, to avoid accidental best/worst case behavior on our
insertion sort.

git-svn-id: http://skia.googlecode.com/svn/trunk@4501 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded GM baseline images for new gradient tests.
rileya@google.com [Mon, 9 Jul 2012 21:20:57 +0000 (21:20 +0000)]
Added GM baseline images for new gradient tests.

git-svn-id: http://skia.googlecode.com/svn/trunk@4498 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoskdiff now has the option to not print out the directories it is using.
keyar@chromium.org [Mon, 9 Jul 2012 21:01:50 +0000 (21:01 +0000)]
skdiff now has the option to not print out the directories it is using.

Further, test_pictures.py will call skdiff with this option.

Review URL: https://codereview.appspot.com/6347066

git-svn-id: http://skia.googlecode.com/svn/trunk@4497 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdding sanity checks on restore offsets in SkPicturePlayback::draw
junov@chromium.org [Mon, 9 Jul 2012 20:53:37 +0000 (20:53 +0000)]
Adding sanity checks on restore offsets in SkPicturePlayback::draw

Review URL: http://codereview.appspot.com/6382044/
BUG=http://code.google.com/p/chromium/issues/detail?id=133432

git-svn-id: http://skia.googlecode.com/svn/trunk@4496 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years ago* Adding arguments to specify the working directory and whether the script should...
rmistry@google.com [Mon, 9 Jul 2012 20:53:03 +0000 (20:53 +0000)]
* Adding arguments to specify the working directory and whether the script should try to commit at the end.
* Redirecting doxygen output to a last_run_output.txt file.
* Maintaining backwards compatibility.

Context-
This CL is a preparatory CL for the housekeeping slave. The slave will use this script to update Doxygen docs. The script will not be used to commit and instead the slave will call AddMergeIntoSvn to commit.
Review URL: https://codereview.appspot.com/6348076

git-svn-id: http://skia.googlecode.com/svn/trunk@4495 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded stubs for zoom info panel.
chudy@google.com [Mon, 9 Jul 2012 20:26:53 +0000 (20:26 +0000)]
Added stubs for zoom info panel.

Review URL: https://codereview.appspot.com/6350071

git-svn-id: http://skia.googlecode.com/svn/trunk@4493 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd placement new macros to SkPostConfig, call SkNEW* from Ganesh.
tomhudson@google.com [Mon, 9 Jul 2012 20:17:56 +0000 (20:17 +0000)]
Add placement new macros to SkPostConfig, call SkNEW* from Ganesh.

TODO: unify with the placement new implementation in SkTemplatesPriv.h,
once various issues there are overcome. reed@ should be taking the lead
there.

http://codereview.appspot.com/6384043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4492 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoTiles that extend beyond the picture are now clipped.
keyar@chromium.org [Mon, 9 Jul 2012 19:51:05 +0000 (19:51 +0000)]
Tiles that extend beyond the picture are now clipped.

Review URL: https://codereview.appspot.com/6352078

git-svn-id: http://skia.googlecode.com/svn/trunk@4491 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded a sgpipe benchmark.
keyar@chromium.org [Mon, 9 Jul 2012 19:37:40 +0000 (19:37 +0000)]
Added a sgpipe benchmark.

Review URL: https://codereview.appspot.com/6349070

git-svn-id: http://skia.googlecode.com/svn/trunk@4490 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix misnamed function in explanatory comment.
tomhudson@google.com [Mon, 9 Jul 2012 19:07:41 +0000 (19:07 +0000)]
Fix misnamed function in explanatory comment.

http://codereview.appspot.com/6387043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4489 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAllow specific files and multiple inputs for picture testing tools.
keyar@chromium.org [Mon, 9 Jul 2012 18:44:51 +0000 (18:44 +0000)]
Allow specific files and multiple inputs for picture testing tools.

Changed the render_pictures, bench_pictures and test_pictures.py so that multiple inputs can be given. Furthermore, specific files can also be specified.

Unit tests have also been added for picture_utils.cpp.

Committed http://code.google.com/p/skia/source/detail?r=4486

Review URL: https://codereview.appspot.com/6345054

git-svn-id: http://skia.googlecode.com/svn/trunk@4488 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAllow specific files and multiple inputs for picture testing tools.
keyar@chromium.org [Mon, 9 Jul 2012 18:32:08 +0000 (18:32 +0000)]
Allow specific files and multiple inputs for picture testing tools.

Changed the render_pictures, bench_pictures and test_pictures.py so that multiple inputs can be given. Furthermore, specific files can also be specified.

Unit tests have also been added for picture_utils.cpp.

Review URL: https://codereview.appspot.com/6345054

git-svn-id: http://skia.googlecode.com/svn/trunk@4486 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd an SK_PRINTF_LIKE macro, which declares a function to have printf-like
senorblanco@chromium.org [Mon, 9 Jul 2012 18:22:08 +0000 (18:22 +0000)]
Add an SK_PRINTF_LIKE macro, which declares a function to have printf-like
semantics, allowing gcc and clang to check the format string against the
arguments.  Enable its use on SkString (printf, appendf, and prependf).  Also
define an SK_SIZE_T_SPECIFIER macro so there's a cross-platform way of
printing a size_t.

Review URL:  http://codereview.appspot.com/6375043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4485 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix definition of isEqual() for two gradient effect custom stages.
tomhudson@google.com [Mon, 9 Jul 2012 18:21:28 +0000 (18:21 +0000)]
Fix definition of isEqual() for two gradient effect custom stages.
Expand comments defining isEqual() to better distinguish equality from
equivalence, which is more significant in Ganesh shader cache management.

http://codereview.appspot.com/6379043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4484 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix SkBlendLCD16_SSE2 for non ARGB platforms.
bungeman@google.com [Mon, 9 Jul 2012 17:44:57 +0000 (17:44 +0000)]
Fix SkBlendLCD16_SSE2 for non ARGB platforms.
http://codereview.appspot.com/6356062/

git-svn-id: http://skia.googlecode.com/svn/trunk@4481 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorestore 4478 w/ fixed assert (no long need 8-byte alignment)
reed@google.com [Mon, 9 Jul 2012 17:44:44 +0000 (17:44 +0000)]
restore 4478 w/ fixed assert (no long need 8-byte alignment)

git-svn-id: http://skia.googlecode.com/svn/trunk@4480 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorevert 4478
reed@google.com [Mon, 9 Jul 2012 17:40:48 +0000 (17:40 +0000)]
revert 4478

git-svn-id: http://skia.googlecode.com/svn/trunk@4479 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoswitch callers to SkChecksum::Compute (no 32/64 preference)
reed@google.com [Mon, 9 Jul 2012 17:05:51 +0000 (17:05 +0000)]
switch callers to SkChecksum::Compute (no 32/64 preference)
Review URL: https://codereview.appspot.com/6377043

git-svn-id: http://skia.googlecode.com/svn/trunk@4478 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoremove until PDF understands conical gradients.
reed@google.com [Mon, 9 Jul 2012 16:45:49 +0000 (16:45 +0000)]
remove until PDF understands conical gradients.

git-svn-id: http://skia.googlecode.com/svn/trunk@4477 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd image to macpro
reed@google.com [Mon, 9 Jul 2012 16:42:00 +0000 (16:42 +0000)]
add image to macpro

git-svn-id: http://skia.googlecode.com/svn/trunk@4476 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agonew and updated images for gradients on MacPro
reed@google.com [Mon, 9 Jul 2012 16:40:32 +0000 (16:40 +0000)]
new and updated images for gradients on MacPro

git-svn-id: http://skia.googlecode.com/svn/trunk@4475 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoLeft over cleanup from r4416 (fix for lingering AA clip mask bug)
robertphillips@google.com [Mon, 9 Jul 2012 16:32:28 +0000 (16:32 +0000)]
Left over cleanup from r4416 (fix for lingering AA clip mask bug)

http://codereview.appspot.com/6356058/

git-svn-id: http://skia.googlecode.com/svn/trunk@4474 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoIn SkGPipe, set a limit on the amount of flattenables cached.
scroggo@google.com [Mon, 9 Jul 2012 16:05:53 +0000 (16:05 +0000)]
In SkGPipe, set a limit on the amount of flattenables cached.

Also fix a type in gmmain.

Review URL: https://codereview.appspot.com/6351061

git-svn-id: http://skia.googlecode.com/svn/trunk@4473 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRefactoring code in SkPictureRecord that touches fRestoreOffsetStack
junov@chromium.org [Mon, 9 Jul 2012 16:03:55 +0000 (16:03 +0000)]
Refactoring code in SkPictureRecord that touches fRestoreOffsetStack

Review URL: http://codereview.appspot.com/6350059/
BUG=http://code.google.com/p/chromium/issues/detail?id=133432

git-svn-id: http://skia.googlecode.com/svn/trunk@4472 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoDelete pdf gradient image.
rileya@google.com [Mon, 9 Jul 2012 15:46:29 +0000 (15:46 +0000)]
Delete pdf gradient image.

git-svn-id: http://skia.googlecode.com/svn/trunk@4471 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRebaseline gradients.
rileya@google.com [Mon, 9 Jul 2012 15:45:04 +0000 (15:45 +0000)]
Rebaseline gradients.

git-svn-id: http://skia.googlecode.com/svn/trunk@4470 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded conical gradient to gm gradients test, and added two variants of that test...
rileya@google.com [Mon, 9 Jul 2012 14:42:16 +0000 (14:42 +0000)]
Added conical gradient to gm gradients test, and added two variants of that test, one with perspective applied to the local matrices of the gradients and the other with perspective applied to the overall view matrix.

Will require GM rebaselining.
Review URL: https://codereview.appspot.com/6344091

git-svn-id: http://skia.googlecode.com/svn/trunk@4468 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix bug in calling NV DeletePaths
bsalomon@google.com [Mon, 9 Jul 2012 14:30:26 +0000 (14:30 +0000)]
Fix bug in calling NV DeletePaths

Review URL: http://codereview.appspot.com/6345078/

git-svn-id: http://skia.googlecode.com/svn/trunk@4467 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMinor cleanup in lighting image filters: Made the light color a member of the
senorblanco@chromium.org [Mon, 9 Jul 2012 14:29:51 +0000 (14:29 +0000)]
Minor cleanup in lighting image filters:  Made the light color a member of the
light, rather than the filter, so computation is localized.  Changed a couple
of non-const refs in the image filter creation API const refs.  Changed "const
SkColor&" to "SkColor", since it's just a uint32_t anyway.

Review URL:  http://codereview.appspot.com/6352071/

git-svn-id: http://skia.googlecode.com/svn/trunk@4466 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd gm baseline images for Xoom.
borenet@google.com [Mon, 9 Jul 2012 13:51:32 +0000 (13:51 +0000)]
Add gm baseline images for Xoom.

Note that these are only what could be matched against the Nexus S images or
the Linux images.  Since neither set is complete, this set is also incomplete.
Review URL: https://codereview.appspot.com/6350070

git-svn-id: http://skia.googlecode.com/svn/trunk@4465 2bbb7eff-a529-9590-31e7-b0007b416f81