Chris Michael [Mon, 2 Nov 2015 14:27:56 +0000 (09:27 -0500)]
evas-gl-drm: Fix issue of gl_drm engine not working
Summary: With linux kernels >= 4.2.x, the gl_drm engine was not
functional. This is due to the egl config returning an improper config
which did not match the expected pixel format. This commit fixes that
issue and gl_drm evas engine works again. Should fix ticket T2807
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 2 Nov 2015 14:25:40 +0000 (09:25 -0500)]
ecore-evas-drm: Use GBM_FORMAT_XRGB8888 when creating new canvas
Summary: With linux kernels >= 4.2.x, we need to use
GBM_FORMAT_XRGB8888 when creating a new canvas else we end up with a
format mismatch when trying to add the framebuffer
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Jean-Philippe Andre [Mon, 2 Nov 2015 07:03:48 +0000 (16:03 +0900)]
Evas: Remove dead code (cached surfaces)
While cached surfaces is a topic we're discussing recently,
this code is dead right now, and we will have to redesign the
buffer caching better to handle proxies, maps, smart objects, etc...
Jean-Philippe Andre [Mon, 2 Nov 2015 06:08:05 +0000 (15:08 +0900)]
tests: Fix build warning
Jean-Philippe Andre [Mon, 2 Nov 2015 03:23:00 +0000 (12:23 +0900)]
Evas render: Fix 'no_render' when object is proxy source
When the no_render flag was set on a proxy source, the object would
not be visible, but it would also not render inside the proxy surface,
which completely beats the purpose of this flag. This patch makes
the objects render inside a proxy surface.
Jean-Philippe Andre [Thu, 29 Oct 2015 13:14:08 +0000 (22:14 +0900)]
ecore_evas_convert: Improve cmdline help a bit
Jaehyun Cho [Mon, 2 Nov 2015 01:19:39 +0000 (10:19 +0900)]
ecore_file: Fix ecore_file_file_get function on Windows.
On Windows, both backslash and slash can be used as file path
separators. Therefore, it is fixed to consider backslash as a file path
separator as well on Windows.
@fix
Carsten Haitzler (Rasterman) [Mon, 2 Nov 2015 01:11:53 +0000 (10:11 +0900)]
efreet - fix efreetd to not exit on $home being in extra app dirs
if a client added $home in the efreet extra desktops dirs, then
efreetd would detect and nuke cache, exit, causing a restart cycle
forever. this makes efreet simply ignore the errant dir so it can keep
working.
@fix
Carsten Haitzler (Rasterman) [Sat, 31 Oct 2015 02:35:19 +0000 (11:35 +0900)]
ecore imf - fix modules that are x11 based to only load in x11 and in wl
use env vars to determine module init for ecore-imf so you don't have
things like e locking up trying to init scim when running in wl mode.
do the same for ibus and xim modules too. do the inverse for wayland
imf module but here add also the check for ELM_DISPLAY that wasn't
there (like it is now in the other modules) so it is only initted on
wayland.
@fix
Vivek Ellur [Sat, 31 Oct 2015 01:37:17 +0000 (02:37 +0100)]
ecore: add test case for idler enterer function
Summary:
Added test case for ecore_idle_enterer_before_add function
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3253
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Sat, 31 Oct 2015 01:36:14 +0000 (02:36 +0100)]
evas: removing redundant if case in gl_cocoa backend.
Summary:
According to my understanding of this function, this check of im_old is
redundant, as im_old will never be NULL. For im_old to be NULL, image should be
NULL. But that is checked at line 637. im is assigned image and im is checked for NULL. At line 654 im_old is assigned image and it is not modified till line 673. So this check would always return true and enter if case and would never
enter else case. So removing the redundant code.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3233
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Fri, 30 Oct 2015 06:20:31 +0000 (07:20 +0100)]
evas: handling realloc failure in gl_generic.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3236
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Fri, 30 Oct 2015 06:19:06 +0000 (07:19 +0100)]
evas: removing redundant assignment in gl_drm.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3235
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Fri, 30 Oct 2015 06:18:08 +0000 (07:18 +0100)]
evas: removing redundant assigment in gl_common.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3234
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Fri, 30 Oct 2015 06:15:09 +0000 (07:15 +0100)]
eet: removing useless assignment variables.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3231
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Fri, 30 Oct 2015 05:53:36 +0000 (06:53 +0100)]
evas: removing redundant check in gl_x11 backend.
Summary:
Checking for NULL is redundant here, because if cfgs was NULL, then at
line 760 it would fail.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3238
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Fri, 30 Oct 2015 05:39:15 +0000 (06:39 +0100)]
ector: fix null pointer dereference issue
Summary:
Fix Coverity CID1293003
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3220
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Fri, 30 Oct 2015 03:06:25 +0000 (04:06 +0100)]
eina_hash: add test cases for eina_hash_add/del by hash functions
Summary:
Added test cases for eina_hash_add_by_hash/del_by_hash functions
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3245
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Fri, 30 Oct 2015 03:00:33 +0000 (04:00 +0100)]
eina_quaternion: add test case for rotation function
Summary:
Added test case for eina_quaternion_rotate function
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3246
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Fri, 30 Oct 2015 02:59:21 +0000 (03:59 +0100)]
eina_quaternion: add test cases for quaternion rotation functions
Summary:
Added test cases for eina_quaternion_f16p16_rotate and
eina_quaternion_f16p16_rotation_matrix3_get functions
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3247
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Fri, 30 Oct 2015 02:57:06 +0000 (03:57 +0100)]
eina_quaternion: correct the API name in header file
Summary:
This is not an ABI break as we never did provide the broken name symbol, just a typo
in the header that wasn't detected until now.
@fix
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3248
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Fri, 30 Oct 2015 20:00:32 +0000 (16:00 -0400)]
ecore-drm: Add some debug printing for driver details
Summary: In efforts to debug some non-working drm issues for people,
it would be helpful to know what drivers and versions they are using.
This commit just adds some debug printing for that information
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 30 Oct 2015 19:12:41 +0000 (15:12 -0400)]
ecore-evas-wl: Ignore step size when maximizing
Summary; This fixes an issue where maximizing efl/elm apps in Weston
and in Enlightenment would cause extra space to be left around the
window.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 30 Oct 2015 18:49:01 +0000 (14:49 -0400)]
evas-gl-drm: Resize gbm surface when canvas size changes
Summary: When we are told to resize the canvas, we should also be
resizing the gbm_surface. This should fix the issue of wl_drm module
in E not working when the canvas gets resized (WFM now)
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 30 Oct 2015 18:47:20 +0000 (14:47 -0400)]
evas-gl-drm: Move definition of Render_Engine out to header
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Fri, 30 Oct 2015 13:08:41 +0000 (09:08 -0400)]
ecore-drm: Don't exit tty setup if tty is already in graphics mode
Summary: If we go to setup a tty and it is already in graphics mode,
then there is no need to exit with a failed setup here. Instead, we
can actually continue to setup the tty.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 21 Oct 2015 13:09:18 +0000 (09:09 -0400)]
ecore-evas-wayland: Fix formatting
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Amitesh Singh [Fri, 30 Oct 2015 08:14:04 +0000 (13:44 +0530)]
evas box: don't allow duplicate child append
Add check for duplicate child addition and return null.
Jean-Philippe Andre [Thu, 29 Oct 2015 12:13:00 +0000 (21:13 +0900)]
Evas: Disable TGV save debugging and fix error log
Disable time stats & quality check
Remove an invalid error message (was logged in case of success)
Jean-Philippe Andre [Thu, 29 Oct 2015 12:05:03 +0000 (21:05 +0900)]
Eet: Another ETC decoding fix
@fix
Jean-Philippe Andre [Thu, 29 Oct 2015 06:30:16 +0000 (15:30 +0900)]
Eet: fix decoding of embedded ETC images
Typos, lack of NULL check, excessive sizeof(type) not matching
the object type, no border set, etc... This all lead to a crash
and then no render (with an error message and then without...).
This also simplifies the implicit loading of ETC1 as ETC2 when
supported by the driver.
@fix
Jean-Philippe Andre [Thu, 29 Oct 2015 07:38:54 +0000 (16:38 +0900)]
Evas: Fix error message on stride_get with ETC & S3TC
Jean-Philippe Andre [Thu, 29 Oct 2015 07:12:09 +0000 (16:12 +0900)]
Emile: Allow load of ETC images if region = whole image
@fix
Shinwoo Kim [Thu, 29 Oct 2015 04:45:07 +0000 (13:45 +0900)]
[eldbus] assign NULL to fd_handler, after deletion.
Summary: [eldbus] assign NULL to fd_handler, after deletion.
Test Plan: N/A
Reviewers: raster, cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3243
Chidambar Zinnoury [Wed, 28 Oct 2015 16:17:54 +0000 (17:17 +0100)]
ecore fb: Use a default tslib device when none is specified through the environment variable TSLIB_TSDEVICE.
It seems that tslib’s applications has been using /dev/input/event0 as default device for more than a decade. Let’s use the same one.
Chidambar Zinnoury [Wed, 28 Oct 2015 16:14:59 +0000 (17:14 +0100)]
Revert “ecore fb: Change default tslib device.”
This reverts commit
d1f863b2727d35728705e223b91ae2ee53442985.
My test script was wrong, thus the test for this commit being a pass while it shouldn’t.
Moral: don’t code when you crave some sleep.
Carsten Haitzler (Rasterman) [Wed, 28 Oct 2015 07:39:28 +0000 (16:39 +0900)]
efl - make drm vsync handle broken drm irq timestamps
i found that intel drm device gives BROKEN timestamps vs system clock
- it is off by about 0.3 to 0.4ms - this means the vsync event is in
the future vs when we actually wake up and do processing - this leads
to bizare timelines and likely odd event and animation handling.
fix this by detecting it and figuring out an average delay and
offsetting events by that in future, but until then, use "now" when
the drm thread wakes up as the timestamp.
@fix
Cedric BAIL [Wed, 28 Oct 2015 05:45:10 +0000 (06:45 +0100)]
eina: correctly prepare path before sanitizing it.
Cedric BAIL [Wed, 28 Oct 2015 05:38:14 +0000 (06:38 +0100)]
Revert "Eina: Fix
58b194e0ad56fe83cce3946a5deb0045ee0cbce2"
This reverts commit
22b45f220c994f5b6e6ee2620ad8a5ab1e0528c2.
eina_file_cleanup always does an eina_tmpstr_del. This is now capable of doing
double or even triple free in some case.
Vincent Torri [Mon, 26 Oct 2015 11:40:49 +0000 (12:40 +0100)]
Eina: Fix
58b194e0ad56fe83cce3946a5deb0045ee0cbce2
Fixes the windows build as it has a matching implementation for eina_file_cleanup.
Fixes T2804
Chidambar Zinnoury [Tue, 27 Oct 2015 16:02:11 +0000 (17:02 +0100)]
ecore fb: Change default tslib device.
It seems that tslib has been using /dev/input/event0 as default device for more than a decade. Let’s align.
Mike Blumenkrantz [Mon, 26 Oct 2015 17:51:14 +0000 (13:51 -0400)]
evas gl: init evgl during eng_gl_get_pixels_pre()
when the first render is an image without a native surface,
evgl_init() will not be called before this point, resulting in an abort()
Stefan Schmidt [Mon, 26 Oct 2015 08:04:22 +0000 (09:04 +0100)]
ecore_wayland: fix build for ivi-shell.
During a rework this bit got missed and made the build fail if ivi-shell was
enabled. Thanks a lot to aerodynamik for bringing this to our attention and
even pointed out the fix.
Fixes T2798
Stefan Schmidt [Mon, 26 Oct 2015 02:21:46 +0000 (03:21 +0100)]
release: Update NEWS and bump version for 1.16.0-beta3 release
Stefan Schmidt [Mon, 26 Oct 2015 02:18:18 +0000 (03:18 +0100)]
po: update po files
Vincent Torri [Thu, 22 Oct 2015 20:54:18 +0000 (22:54 +0200)]
ecore_audio: do not compile elua file if ecore_audio is disabled
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Carsten Haitzler (Rasterman) [Sun, 25 Oct 2015 02:23:04 +0000 (11:23 +0900)]
eo - make null object silent if eo id is off
with eo id indirection on, a nul object is silently ignored as anok
error case (like free(NULL)). but if you turne eoid off in build its
all complaints to here and the black stump. fix this by making the eo
id "off" path match eo id on by making null objects silent.
@fix
Carsten Haitzler (Rasterman) [Sat, 24 Oct 2015 03:23:53 +0000 (12:23 +0900)]
eo - move cache lookup into the hot path if as it only is valid there
minor speedup ... really minor - but correct.
Carsten Haitzler (Rasterman) [Sat, 24 Oct 2015 03:23:38 +0000 (12:23 +0900)]
eo header - remove 2 errant spaces to clean formatting
Carsten Haitzler (Rasterman) [Fri, 23 Oct 2015 02:02:56 +0000 (11:02 +0900)]
evas gl - rect draws didnt obey cutout max like font and img - fix
this fixes cutout handling consistency for gl common
Cedric BAIL [Fri, 23 Oct 2015 19:34:53 +0000 (12:34 -0700)]
efreet: make sure that we use the right directory and ef for the cache.
Cedric BAIL [Fri, 23 Oct 2015 19:32:02 +0000 (12:32 -0700)]
eina: make sure to cleanup the right string.
Jean-Philippe Andre [Fri, 23 Oct 2015 07:29:40 +0000 (16:29 +0900)]
Evas render: Fix rendering of snapshot objects
I added a quick check that the clip was not 0x0 but forgot
to check that we actually use the clip info.
Fixes T2792
Cedric BAIL [Thu, 22 Oct 2015 23:57:24 +0000 (16:57 -0700)]
efl: fix path parsing to actually check the value returned by strtol.
CID1328665
Cedric BAIL [Thu, 22 Oct 2015 23:56:39 +0000 (16:56 -0700)]
emile: fix typos catched by coverity.
CID1328666
Shinwoo Kim [Thu, 22 Oct 2015 19:28:51 +0000 (12:28 -0700)]
ecore: use recursive lock for _ecore_glib_select
Summary: Fix a deadlock caused by recursive call of _ecore_glib_select.
Test Plan:
Delete elm_image on the glib callback(ref: g_source_set_callback).
The _elm_image_evas_object_smart_del calls ecore_thread_wait.
Reviewers: raster, jpeg, woohyun, jaehwan, Hermet, seoz, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3202
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Thu, 22 Oct 2015 19:25:37 +0000 (12:25 -0700)]
eet: handling memory leak on realloc fail.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3208
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Thu, 22 Oct 2015 19:23:00 +0000 (12:23 -0700)]
eina_quaternion: add test cases for interpolation functions.
Summary:
Added test cases for quaternion_lerp, quaternion_slerp and quaternion_nlerp
functions
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3209
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Thu, 22 Oct 2015 19:19:01 +0000 (12:19 -0700)]
emile: handling memory leak on realloc.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3210
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Thu, 22 Oct 2015 19:17:17 +0000 (12:17 -0700)]
eina: add test cases for f16p16 quaternion interpolation functions
Summary:
Added test cases for f16p16 lerp, slerp and nlerp functions
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3216
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vivek Ellur [Thu, 22 Oct 2015 19:15:30 +0000 (12:15 -0700)]
evil: fix memory leak issue in evil module
Summary:
@Fix
Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3217
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Thu, 22 Oct 2015 18:29:36 +0000 (11:29 -0700)]
emile: prevent segv when rotation is asked and there is no opts provided.
Thanks Vivek for pointing the problem.
@fix
Carsten Haitzler (Rasterman) [Thu, 22 Oct 2015 10:19:50 +0000 (19:19 +0900)]
efl tests - ecore fb - disable as it basically is more pain than gain
this means make check is more useful to people.
Carsten Haitzler (Rasterman) [Thu, 22 Oct 2015 06:12:26 +0000 (15:12 +0900)]
evas - software render async - fix async render to actually be all async
so the evas thread renderer didnt START rendering until evas FINISHEd
walking all objects generating a render queue. this means all the cpu
time spend generating commands couldn't allow a parallel thread
actually go and DO the rendering.
this flushes the render thread every render command thus waking up the
render thread to work in parallel to the mainloop generating commands.
this actually means int he traces i see the render thread finished byt
he time evas_render completes thus brinign forward the frame display
by quite a bit.
thanks to evlog for pointing this out.
@fix
Jihoon Kim [Thu, 22 Oct 2015 05:23:43 +0000 (14:23 +0900)]
Ecore evas: Correct function name in magic failure of ecore_evas_rotation_with_resize_set ()
Jaehwan Kim [Thu, 22 Oct 2015 00:36:35 +0000 (09:36 +0900)]
Revert "edje: add edje signal emit about swallow, text"
This reverts commit
b1fa1c5aadc71881cb1e4e264d680ea5efa79a69.
This feature will be commited to the next version.
Carsten Haitzler (Rasterman) [Thu, 22 Oct 2015 00:35:11 +0000 (09:35 +0900)]
efl eo - pass test suite function overrides again after adding cache
removing the klass member meant removing hooks and keeping cache small
but that meant not using it. this meand if the object is not an obj...
i removed the:
call->obj = _eo_class_id_get(call->klass);
line - seemed harmless/pointless. apparently not. so put it back but
use the klass there in local vars and not in call as it's not there
(and not needed).
fix.
Srivardhan Hebbar [Wed, 21 Oct 2015 21:01:38 +0000 (14:01 -0700)]
ecore_x: remove useless assignment.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3206
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Wed, 21 Oct 2015 20:50:17 +0000 (13:50 -0700)]
eet: handling memory leak on realloc fail.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3207
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Wed, 21 Oct 2015 20:35:17 +0000 (13:35 -0700)]
evas: handling memory leak on realloc failure.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3212
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Wed, 21 Oct 2015 18:11:39 +0000 (11:11 -0700)]
efl: fix copy & paste typo while parsing SVG elliptical arc command.
@fix
CID 1328426
Mike Blumenkrantz [Wed, 21 Oct 2015 18:06:47 +0000 (14:06 -0400)]
ee-wayland: remove attempt to optimize canvas resizing
in the case of operations which change framespace, rejecting resizes
at this point will cause the canvas to fail at resizing and result in a
partially-rendered canvas; the real canvas geometry must be calculated by
running the entire function in order to determine whether the resize is valid
fixes toggling borderless state of windows
Vitor Sousa [Wed, 21 Oct 2015 17:14:22 +0000 (18:14 +0100)]
eolian: Test recognition of struct types used in methods
Summary:
Add code to unit test to check if Eolian correctly recognize a struct
name as a struct type when it is used in a method.
Add new method to struct.eo to create this test.
Update struct_ref.c accordingly.
Reviewers: tasn, q66
Differential Revision: https://phab.enlightenment.org/D3213
Carsten Haitzler (Rasterman) [Wed, 21 Oct 2015 13:27:06 +0000 (22:27 +0900)]
eo - oops remove warning cpp i accidentally put in!
Carsten Haitzler (Rasterman) [Wed, 21 Oct 2015 13:23:18 +0000 (22:23 +0900)]
eo resolv cache - remove params passed to resolv func for efficiency
we pass both the callcache and the op id - both are static and filled
in at runtime, so merge them into the same struct. this should lead to
better alignment/padding with the offset array and the next slot and
op fields, probably saving about 4-8 bytes of rame per method with no
downsides. also pass in only cache ptr, not both cache ptr and opid -
less passing of stuff around and should be better.
Jaehwan Kim [Wed, 21 Oct 2015 12:51:54 +0000 (21:51 +0900)]
edje: add edje signal emit about swallow, text
Add the edje signal "swallow", "unswallow", "text,set", "text,unset".
In edc file, the part name take a role of source.
If the layout should be changed when any object is swallowed or any
text is set, use this signal.
@feature
Stefan Schmidt [Wed, 21 Oct 2015 12:32:44 +0000 (14:32 +0200)]
ephysics: add missing break in switch to avoid override variable with other cases
Due to the missing break we would fall into the next case here which might lead
to variables overridden with wrong values.
CID: 1261441, 1261440, 1261438
Stefan Schmidt [Wed, 21 Oct 2015 12:23:08 +0000 (14:23 +0200)]
emile: remove dead code
This seems to come from some intention to fetch dh from openssl somewhow but
it was never implemented. fh always stays 0 since its init and thus we can
remove the code it guards.
CID: 1288930
Carsten Haitzler (Rasterman) [Wed, 21 Oct 2015 12:01:59 +0000 (21:01 +0900)]
eo - shut clang up because otherwise i have to argue with peolpe
so. clang is wrong. end of story. it complains that i should add
braces to:
static Eo_Call_Cache ___callcache = { 0 };
WRONG. that is correct c99. 100%. you can add more {}'s and init every
field separately like {{0},{0},{0}} etc. or make it 1 or any value -
it doesn't matter... clang complains. clang is wrong. plain and
simple. this warning should just never exist. it is pointless.
but... peolpe won't shut up about clang warnings until i "fool" clang
into being silent by assuming the default 0 value of static storage.
this silences clang
Carsten Haitzler (Rasterman) [Wed, 21 Oct 2015 11:06:23 +0000 (20:06 +0900)]
efl - eo - massively improve eo cal resolv and data scope get with cache
BEWARE! this breaks eo ABI. _eo_call_resolve and _eo_data_scope_get
are 2 of the biggest cpu users in eo. they easily consume like 10-15%
cpu between them on tests that drive a lot of api - like simply
scrolling a genlist around. this is a lot of overhead for efl. this
fixes that to make them far leaner. In fact this got an overall 10%
cpu usage drop and that includes all of the actual rendering, and code
work, so this would drop the eo overhead of these functions incredibly
low. using this much cpu just on doing call marshalling is a bug and
thus - this is a fix, but ... with an abi break to boot. more abi
breaks may happen before release to try and get them all in this
release so we don't have to do them again later.
note i actually tested 4, 3, 2, and 1 cache slots, and 1 was the
fastest. 2 was very close behind and then it got worse. all were
better than with no cache though.
benchmark test method:
export ELM_ENGINE=gl
export ELM_TEST_AUTOBOUNCE=1
while [ 1 ]; do sync; sync; sync; time elementary_test -to genlist;
sleep 1; done
take the 2nd to the 8th results (7 runs) and total up system and user
time. copmpare this to the same without the cache. with the cache cpu
time used is 90.3% of the cpu time used without - thus a win. at least
in my tests.
@fix
Carsten Haitzler (Rasterman) [Wed, 21 Oct 2015 11:01:26 +0000 (20:01 +0900)]
efl - edje - fix edje calc to avoid eo calls when object doesnt change
in many cases edje dumbly calls eo_do() or evas_object_xxxx on objects
to set up their porperties when the part never uses that thing at al -
eg filters. the obnject never had filters and will not have them n3ext
- why always set filter to null every time? skip when not needed for
speedups.
so this fixes over-zealous calling whihc adds overhead that is not
needed causing battery drain and cpu usage, heat creation etc. etc.
@fix
Subhransu Mohanty [Fri, 28 Aug 2015 01:12:44 +0000 (10:12 +0900)]
efl/gfx: fix svg path parsing logic.
1. according to svg path specification, path string may or may not contain ',' as the separator
with current parsing logic we were expecting a ',' after each segment.
2. relative cubic bezier parsing was wrong as we were not adding the current value to all 4 points.
3. refactored the parse_pair, parse_six and parse_quad to use same helper function
path1: "M7.279,2h35.442C45.637,2,48,4.359,48,7.271v35.455C48,45.639,45.637,48,42.723,48H7.279C4.362,47.997,2,45.639,2,42.727V7.271C2,4.359,4.362,2,7.279,2z"
path2: "M-2.073-7h36.147C36.796-7,39-4.793,39-2.073v36.146C39,36.796,36.796,39,34.074,39H-2.073C-4.793,39-7,36.796-7,34.072V-2.073C-7-4.793-4.793-7-2.073-7z"
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Mike Blumenkrantz [Tue, 20 Oct 2015 21:51:22 +0000 (17:51 -0400)]
ecore-wayland: plug some trivial leaks
Srivardhan Hebbar [Tue, 20 Oct 2015 19:27:01 +0000 (12:27 -0700)]
ector: handling memory leak on error.
Summary:
Memory leak was caused by using the USE macro. So move the macro before
doing any allocation.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3183
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Tue, 20 Oct 2015 19:24:49 +0000 (12:24 -0700)]
ecore_x: removing useless assignment variable.
Summary:
Assigning to NULL has no effect in the function calling this. So changed it to void.
Some compiler complain about this kind of construct. It is better to use the (void)
construct for silencing unused parameter with different kind of configure option.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3180
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subodh Kumar [Tue, 20 Oct 2015 18:51:17 +0000 (11:51 -0700)]
evas: fix memory leak.
Summary:
Fix memory leak
Delimiter string is being saved using
eina_stringshare_replace without any del or free
when object is deleted.
@fix
Test Plan: NA
Reviewers: cedric, tasn, herdsman
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3201
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Mike Blumenkrantz [Tue, 20 Oct 2015 20:41:28 +0000 (16:41 -0400)]
ee-wayland: use frame callbacks exclusively to determine render timing
when running in a wayland compositor, the ideal mode of operation is to
only prepare/send frames when the compositor has finished with the previous
frame
to achieve this, manual rendering can be toggled upon creating and completing
a frame callback, ensuring that a canvas never has multiple pending buffers at
any given time
fix T2784
Chidambar Zinnoury [Tue, 20 Oct 2015 16:58:18 +0000 (18:58 +0200)]
ecore fb: Unbreak ecore_evas_fb.
The ecore_evas_fb module uses ecore_fb_ts_* functions which are only available to EFL internals and not for the general API.
However, EAPI not being defined in ecore_fb_private.h made the symbols not being exported at all, which in return made execution-time linking not finding them and thus failing.
Chidambar Zinnoury [Tue, 20 Oct 2015 16:56:47 +0000 (18:56 +0200)]
ecore fb: We shall look for the Ecore_Fb.h header only where needed.
Carsten Haitzler (Rasterman) [Tue, 20 Oct 2015 09:07:21 +0000 (18:07 +0900)]
edje - fix some horrible misleading indenting in edje calc.
just whitespace fixups
Vincent Torri [Tue, 29 Sep 2015 21:37:46 +0000 (23:37 +0200)]
efreet: use eina_file_mkstemp() for portability and fix a bug on Windows
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 27 Sep 2015 08:25:33 +0000 (10:25 +0200)]
ecore_exe: terminate threads also in destructor
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Mike Blumenkrantz [Mon, 19 Oct 2015 20:20:45 +0000 (16:20 -0400)]
ecore-wayland: only do deferred shell surface creation when a surface exists
Mike Blumenkrantz [Mon, 19 Oct 2015 20:13:50 +0000 (16:13 -0400)]
ecore-wayland: defer shell surface creation for windows if shell is not bound
in the case where a surface is created before the compositor binds its shell(s),
a shell surface would never be created
fixes case where internal windows would not create frames in enlightenment
@fix
Subodh Kumar [Mon, 19 Oct 2015 18:34:38 +0000 (11:34 -0700)]
evas textblock: fix memory leak
Summary:
Fix memory leak
Delimiter string is being saved using
eina_stringshare_replace without any del or free
when object is deleted.
@fix
Test Plan: N/A
Reviewers: tasn, herdsman
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3175
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Mon, 19 Oct 2015 18:24:49 +0000 (11:24 -0700)]
ecore_x: removing useless assignment.
Summary:
The assigned value has no effect outside the function. So removing it.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3181
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Mon, 19 Oct 2015 18:21:22 +0000 (11:21 -0700)]
ecore_x: handling realloc failure.
Summary:
If realloc fails, lst would be NULL. So handling it.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3182
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Mon, 19 Oct 2015 18:17:22 +0000 (11:17 -0700)]
ector: removing useless assignement.
Summary:
Null assignment has no effect in the caller function. So removed it.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3184
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Shilpa Singh [Mon, 19 Oct 2015 18:12:23 +0000 (11:12 -0700)]
edje: comparision with non-scaled min values issue fix.
Summary:
In a different scaling environment, wrong comparison of min values causes resize issue as original size is compared instead of scaled size.
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
Signed-off-by: Subodh Kumar <s7158.kumar@samsung.com>
@fix
Test Plan:
Create a layout with some min size and swallow a resizable layout inside the layout.
the parent layout will not expand even when the height has crossed its min size.
Reviewers: cedric, tasn, raster
Subscribers: subodh6129
Differential Revision: https://phab.enlightenment.org/D3185
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Mon, 19 Oct 2015 18:08:13 +0000 (11:08 -0700)]
edje: fix memory leak on realloc.
Summary: Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3186
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>