platform/upstream/efl.git
4 years agocsharp: Hiding p-invokes.
Bruno da Silva Belo [Wed, 20 Nov 2019 21:37:48 +0000 (18:37 -0300)]
csharp: Hiding p-invokes.

Summary: ref T8406

Reviewers: lauromoura, felipealmeida, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8406

Differential Revision: https://phab.enlightenment.org/D10651

4 years agocsharp: CA1307 Add CultureInfo to generated code.
Lauro Moura [Wed, 20 Nov 2019 21:34:08 +0000 (18:34 -0300)]
csharp: CA1307 Add CultureInfo to generated code.

Summary:
For the struct fields with strings when implementing `GetHashCode`.

Ref T8405

Reviewers: brunobelo, felipealmeida, YOhoho

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8405

Differential Revision: https://phab.enlightenment.org/D10696

4 years agocsharp: Specifying StringComparison.
Bruno da Silva Belo [Wed, 20 Nov 2019 19:57:14 +0000 (16:57 -0300)]
csharp: Specifying StringComparison.

Summary: ref T8405

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8405

Differential Revision: https://phab.enlightenment.org/D10650

4 years agotooling: add configuration file for lgtm.com service
Stefan Schmidt [Wed, 20 Nov 2019 08:57:05 +0000 (09:57 +0100)]
tooling: add configuration file for lgtm.com service

It seems they run this on many Github projects automatically now:
https://lgtm.com/projects/g/Enlightenment/efl

From my playing around it had 970 "recommendations" to fix our FIXME
tags. Filtering out this noise by using this config file to exclude the
query.

It also seems to pick up the python scripts as Python2 and has wrong
reporting due to this as well.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10699

4 years agoecore_input_evas: fix ouble use of include guard define
Stefan Schmidt [Wed, 20 Nov 2019 08:08:54 +0000 (09:08 +0100)]
ecore_input_evas: fix ouble use of include guard define

We used the ecore_input define here in ecore_evas_input. Use a unique
name for this file.

Reported-By: https://lgtm.com/projects/g/Enlightenment/efl/
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10698

4 years agoeo: there is no need to count callbacks here
Marcel Hollerbach [Sun, 17 Nov 2019 11:09:23 +0000 (12:09 +0100)]
eo: there is no need to count callbacks here

we are going to add this description anyways, no need to count here
again. I think this is not really making anything really faster, its
more keeping things consistance.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10689

4 years agoremove efl_canvas_animation_player
Marcel Hollerbach [Thu, 14 Nov 2019 11:54:31 +0000 (12:54 +0100)]
remove efl_canvas_animation_player

this now all migrated to Efl.Canvas.Object.Animation

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10667

4 years agoevas: migrate the vg json example
Marcel Hollerbach [Mon, 18 Nov 2019 02:44:15 +0000 (11:44 +0900)]
evas: migrate the vg json example

Summary:
i was not able to run the example before this commit, nor after this
commit. However, i had to migrate this, as i want to remove the player
object.
Depends on D10637

Reviewers: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10666

4 years agoefl_ui_spotlight_manager stack: move away from player object
Marcel Hollerbach [Sun, 10 Nov 2019 19:00:50 +0000 (20:00 +0100)]
efl_ui_spotlight_manager stack: move away from player object

with this commit we move from using the player object to using the mixin
that was introduced a few commits before. The new mixin is way easier to
use here, we safe a lot of code, we also only need 1 object instead of
4. (And overall, everything just gets sooooo much more easier).

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10637

4 years agoelementary: move away from normal player to the new animation mixin
Marcel Hollerbach [Sun, 10 Nov 2019 18:10:02 +0000 (19:10 +0100)]
elementary: move away from normal player to the new animation mixin

the mixin can handle the same things as the player. Additionally, the
usage of the mixin simplifies the animation usage alot.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10636

4 years agointroduce efl_canvas_object_animation
Marcel Hollerbach [Thu, 7 Nov 2019 10:24:21 +0000 (11:24 +0100)]
introduce efl_canvas_object_animation

this brings the animation to the canvas object. All the controls of the
animation now do now require a player object anymore, you can just use
the API that is directly on the Efl.Canvas.Object object.

wip animation player replacement

Differential Revision: https://phab.enlightenment.org/D10615

4 years agoUnify "animated" flags
Xavi Artigas [Mon, 11 Nov 2019 16:38:08 +0000 (16:38 +0000)]
Unify "animated" flags

There exist several flags to indicate whether an object should be animated, with inconsistent names:
Efl.Canvas.Layout.animation: bool indicating if Edje animations should be played
Efl.Ui.Spotlight_Manager.animation_enabled: bool indicating if page transitions should be animated
Efl.Canvas.Animation_Player.animation: Efl.Canvas.Animation object

This commit unifies all of them: "animated" is now a flag, and "animation" is an object.

Note: Animation_Player is in the process of being replaced by an "animation" property in the
Efl.Canvas.Object, hence the need for non-clashing animation flags.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10645

4 years agovector container: don't copy composite target duplicatedly.
Hermet Park [Wed, 20 Nov 2019 05:09:00 +0000 (14:09 +0900)]
vector container: don't copy composite target duplicatedly.

Container copied composite target in prior to duplicate children,

the composite target is one of the children, it should skip to handle it again.

Change-Id: Ib54413c53e8baf1d004efbd47c13232c809c13ea

4 years agocsharp: Fix CA1815 for generated structs and aliases
Lauro Moura [Tue, 19 Nov 2019 04:48:01 +0000 (01:48 -0300)]
csharp: Fix CA1815 for generated structs and aliases

Summary: Adds IEquatable<T> and friends.

Reviewers: felipealmeida, YOhoho, brunobelo

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, segfaultxavi, #committers

Tags: #efl

Maniphest Tasks: T8418

Differential Revision: https://phab.enlightenment.org/D10694

4 years agoefl_ui_scrollable: add new event for destination information. 83/218183/9
Hosang Kim [Wed, 20 Nov 2019 06:32:09 +0000 (15:32 +0900)]
efl_ui_scrollable: add new event for destination information.

Scroll manager send a signal to widget when destination of scroll is
finalized.

Change-Id: Icfaebcdd5ad281f967cddb72efca75d149c9432a

4 years agovg_common_json: Apply image's alpha color 61/218161/1
JunsuChoi [Mon, 14 Oct 2019 08:40:14 +0000 (17:40 +0900)]
vg_common_json: Apply image's alpha color

Summary:
This patch needs latest rlottie that contain below commit.
https://github.com/Samsung/rlottie/commit/c3ab82ec2c207cfba2df6eb51d80dd532c93a710

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10368

Change-Id: Idfe3c6c476e0f5b23a82a8872f0aa4f5d6d1128b

4 years agovector container: don't copy composite target duplicatedly. 58/218158/1
Hermet Park [Wed, 20 Nov 2019 05:09:00 +0000 (14:09 +0900)]
vector container: don't copy composite target duplicatedly.

Container copied composite target in prior to duplicate children,

the composite target is one of the children, it should skip to handle it again.

Change-Id: I9a3074ca858f7827ab7d8315ed4446370952a8f0

4 years agoevas font: Enhance brightness. 87/218087/2
Hermet Park [Tue, 19 Nov 2019 08:22:18 +0000 (17:22 +0900)]
evas font: Enhance brightness.

For the clear font visuals, we're adjusting the brightness by a trial-error.
This adjust seems improving the font quality for wearable devices.

Change-Id: I9c10d82f3481ac139779610ffbcd4bb0b6fe0de9

4 years agoecore-wl2: Add API to find a window by given surface accepted/tizen/unified/20191120.034538 submit/tizen/20191119.214155
Christopher Michael [Tue, 19 Nov 2019 14:37:11 +0000 (09:37 -0500)]
ecore-wl2: Add API to find a window by given surface

This patch adds a convenience function to find a window by a given
wl_surface.

@feature

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_type functions
Christopher Michael [Tue, 19 Nov 2019 14:31:46 +0000 (09:31 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_type functions

ref T8016

4 years agoecore-wl2: Add API to return window type
Christopher Michael [Tue, 19 Nov 2019 14:28:27 +0000 (09:28 -0500)]
ecore-wl2: Add API to return window type

Small patch whichs adds a new API to return the type of a given window

@feature

4 years agoecore-wl2: Add API to return the compositor object from a given display
Christopher Michael [Tue, 19 Nov 2019 14:23:18 +0000 (09:23 -0500)]
ecore-wl2: Add API to return the compositor object from a given display

This patch adds a convenience function to get the wl_compositor object
from a given display

@feature

4 years agoecore-wl2: Add API to find a connected display given a name
Christopher Michael [Tue, 19 Nov 2019 14:16:31 +0000 (09:16 -0500)]
ecore-wl2: Add API to find a connected display given a name

This patch adds a convenience function to find a connected display
given a name

@feature

4 years agoecore-wl2: Add API to find a window by surface
Christopher Michael [Tue, 19 Nov 2019 14:01:53 +0000 (09:01 -0500)]
ecore-wl2: Add API to find a window by surface

This patch adds a convenience API that can be used to find a window
based on wl_surface.

@feature

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_geometry functions
Christopher Michael [Tue, 19 Nov 2019 13:37:29 +0000 (08:37 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_geometry functions

ref T8016

4 years agodocs: Copy all images to output folder
Xavi Artigas [Mon, 18 Nov 2019 14:20:38 +0000 (15:20 +0100)]
docs: Copy all images to output folder

Summary:
Doxygen only copies to the output folder ("html") images included through
the \image tag. However, we have several images included using \htmlonly
blocks with <img> tags inside, which also need copying.
Old makefiles included code to manually copy all pngs, and this patch does
the same for meson.
I apologize for needing an external script just to run "cp -rf", it looks
like meson does not allow wildcards passed to "cp".
Files not in the output folder won't be included in the tarball and won't
be distributed.

Test Plan:
Generated documentation now includes images for pages like:
`group__Eina__List__Group.html#details`

Reviewers: bu5hm4n, lauromoura

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers, myoungwoon

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10690

4 years agoslider: fix behavior of slider when mirrored
Bowon Ryu [Tue, 19 Nov 2019 05:04:05 +0000 (14:04 +0900)]
slider: fix behavior of slider when mirrored

Summary:
The vertical slider(!horizontal) should not be inverted when mirrored.
This patch fixes and cleans up this.

Test Plan:
elementary_test -to slider
elementary_test -to efl.ui.slider

UI-Mirroring on/off and observe vertical slides.

Reviewers: woohyun, cedric, bu5hm4n

Reviewed By: woohyun

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10693

4 years agocsharp: Add IEquatable on classes.
Lauro Moura [Thu, 14 Nov 2019 19:27:14 +0000 (16:27 -0300)]
csharp: Add IEquatable on classes.

Summary: ref T8418

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8418

Differential Revision: https://phab.enlightenment.org/D10647

4 years agoevas vector: removed useless calls.
Hermet Park [Tue, 19 Nov 2019 04:22:50 +0000 (13:22 +0900)]
evas vector: removed useless calls.

It turns out ector engine doesn't use any color mixing with gradients fill.
Removed unnecessarities unless we can find a way to use them in the future.

4 years agovector svg: apply fill-opacity to graidents fill objects.
Hermet Park [Tue, 19 Nov 2019 04:18:42 +0000 (13:18 +0900)]
vector svg: apply fill-opacity to graidents fill objects.

If node has a fill-opacity attirbute it must propagtes it to
its fill objects.

Previous our implementation missed this behavior.

@fix

Change-Id: I098cc964efbb2705d5bebc2ed3333040d03ba89b

4 years agoecore_timer: add NULL checking for timer data. 05/218105/3
Hosang Kim [Tue, 19 Nov 2019 10:14:13 +0000 (19:14 +0900)]
ecore_timer: add NULL checking for timer data.

Change-Id: If19962540f49a8e1c82f3544792adfa3480d7ffe

4 years agoefl_ui_win: Enabled auto_norender_withdrawn. 95/218095/2
Woochanlee [Tue, 19 Nov 2019 09:16:37 +0000 (18:16 +0900)]
efl_ui_win: Enabled auto_norender_withdrawn.

Upstream wayland doesn't have iconify_changed callback.
But tizen supports it own extension library.

@tizen_feature

Change-Id: Id6c75dd781c68aa7783330ffe4462192173bd1b3

4 years agovector svg: apply fill-opacity to graidents fill objects. 41/218041/1
Hermet Park [Tue, 19 Nov 2019 04:18:42 +0000 (13:18 +0900)]
vector svg: apply fill-opacity to graidents fill objects.

If node has a fill-opacity attirbute it must propagtes it to
its fill objects.

Previous our implementation missed this behavior.

@fix

Change-Id: I84105b162c845565bb182c83e84e5623eaa8925c

4 years agoRevert "Revert "vg_common_svg: Support opacity attribute of <g> element"" 40/218040/1
Hermet Park [Tue, 19 Nov 2019 04:32:17 +0000 (13:32 +0900)]
Revert "Revert "vg_common_svg: Support opacity attribute of <g> element""

This reverts commit 8a03085d6b97943a720397231de87d58e9d46e44.

Revert again after Tizen 5.5 M2 Public release.

Change-Id: I9e632e8848f95e3d423f13a2473fdd442cdc3454

4 years agoslider: fix value error from step submit/tizen/20191118.220200
Bowon Ryu [Mon, 18 Nov 2019 12:25:26 +0000 (21:25 +0900)]
slider: fix value error from step

Summary:
When the slider moves using step,
_drag_value_fetch(), _val_fetch() calculates a value from position of edje_part.
Then the calculated value is updated.
However, this causes a slight error.

This patch updates value ​​first when moving with steps.

* Test Example

```
Evas_Object *sl = elm_slider_add(bx);
elm_slider_min_max_set(sl, -5, 5);
elm_slider_value_set(sl, 0.0);
elm_slider_step_set(sl, 0.1);
evas_object_size_hint_align_set(sl, EVAS_HINT_FILL, EVAS_HINT_FILL);
evas_object_size_hint_weight_set(sl, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_smart_callback_add(sl, "changed", _change_cb, NULL);
```
```
void
_change_cb(void *data, Evas_Object *obj, void *event_info EINA_UNUSED)
{
   double val = elm_slider_value_get(obj);

   if (val == -5.0) printf("val[%f] == -5.0 \n", val);
   if (val == -4.0) printf("val[%f] == -4.0 \n", val);
   if (val == -3.0) printf("val[%f] == -3.0 \n", val);
   if (val == -2.0) printf("val[%f] == -2.0 \n", val);
   if (val == -1.0) printf("val[%f] == -1.0 \n", val);
   if (val == 0.0) printf("val[%f] == 0.0 \n", val);
   if (val == 1.0) printf("val[%f] == 1.0 \n", val);
   if (val == 2.0) printf("val[%f] == 2.0 \n", val);
   if (val == 3.0) printf("val[%f] == 3.0 \n", val);
   if (val == 4.0) printf("val[%f] == 4.0 \n", val);
   if (val == 5.0) printf("val[%f] == 5.0 \n", val);
}
```

If you move the slider using step in this test,
You can see that some logs are not visible. (Some values ​​are incorrect)

Test Plan:
elementary_test -to slider
elementary_test -to efl.ui.slider

Reviewers: woohyun, cedric, bu5hm4n

Reviewed By: woohyun, bu5hm4n

Subscribers: bu5hm4n, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10662

4 years agodocs: Typos in ninja doc screen output
Xavi Artigas [Mon, 18 Nov 2019 11:30:22 +0000 (12:30 +0100)]
docs: Typos in ninja doc screen output

4 years agodoxygen: Prevent auto-linking of invalid links
Xavi Artigas [Mon, 18 Nov 2019 10:57:30 +0000 (11:57 +0100)]
doxygen: Prevent auto-linking of invalid links

Anything starting with http://, ftp:// or file:// is automatically
converted into a link by doxygen. However, we have a few instances
where we do not want this. Fortunately, doxygen allows using % to
forbid specific words from being linked.

4 years agoeldbus: only free the data when the future is resolved or rejected.
Cedric BAIL [Fri, 15 Nov 2019 17:39:38 +0000 (09:39 -0800)]
eldbus: only free the data when the future is resolved or rejected.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10684

4 years agoevas image cache: drop cache properly,
Hermet Park [Mon, 18 Nov 2019 02:49:52 +0000 (11:49 +0900)]
evas image cache: drop cache properly,

the default reference is 1,
thus we should drop it unless if it's more than 1,

4 years agoevas vg: improve caching methods for better precise behaviors.
Hermet Park [Mon, 18 Nov 2019 02:48:40 +0000 (11:48 +0900)]
evas vg: improve caching methods for better precise behaviors.

Previously, json file data won't be shared between instances.
Now, objects can share the json data if they use the same file resource.

4 years agoRevert "evas: migrate the vg json example"
Hermet Park [Mon, 18 Nov 2019 03:57:18 +0000 (12:57 +0900)]
Revert "evas: migrate the vg json example"

This reverts commit a1f1cd6dd67de8eac0e302d47ce2aebf44aead16.

Eeek, this shouldn't be pushed yet.

4 years agoevas: migrate the vg json example
Marcel Hollerbach [Mon, 18 Nov 2019 02:44:15 +0000 (11:44 +0900)]
evas: migrate the vg json example

Summary:
i was not able to run the example before this commit, nor after this
commit. However, i had to migrate this, as i want to remove the player
object.
Depends on D10637

Reviewers: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10666

4 years agoeo: do not over compute the hash when propagating events. submit/tizen/20191117.211230
Cedric BAIL [Thu, 14 Nov 2019 00:01:55 +0000 (16:01 -0800)]
eo: do not over compute the hash when propagating events.

This should slightly improve speed in theory. In practice, I have not seen
a benchmark which would budge by 5%, so I am not sure it improve speed that
much.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10660

4 years agoeo: no need to oversize type.
Cedric BAIL [Wed, 13 Nov 2019 23:02:51 +0000 (15:02 -0800)]
eo: no need to oversize type.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10659

4 years agoeo: refactor shortcut for EFL_EVENT_DESTRUCT event.
Cedric BAIL [Wed, 13 Nov 2019 23:01:00 +0000 (15:01 -0800)]
eo: refactor shortcut for EFL_EVENT_DESTRUCT event.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10658

4 years agoci/travis: remove no longer needed travis keywords
Stefan Schmidt [Thu, 14 Nov 2019 09:48:32 +0000 (10:48 +0100)]
ci/travis: remove no longer needed travis keywords

Highlighted by the new build config validation feature we can see that
sudo is no longer needed and on_cancel is not a valid keyowrk for IRC
notifications.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10665

4 years agoci/travis: Enable the new build config validation beta feature
Stefan Schmidt [Thu, 14 Nov 2019 09:44:33 +0000 (10:44 +0100)]
ci/travis: Enable the new build config validation beta feature

This feature wil enable the validation of our config files (only
.travis.yml in our case) and give out warnings and errors on problematic
parts in the "View Config" tab on the Travis UI.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10664

4 years agoci: cleanup the check for old meson versions
Stefan Schmidt [Fri, 15 Nov 2019 08:24:48 +0000 (09:24 +0100)]
ci: cleanup the check for old meson versions

We install the newest version via pip on our CI docker images. No longer
need to check for this.

Differential Revision: https://phab.enlightenment.org/D10681

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
4 years agoci: remove logic for doing coverity builds only on Saturday
Stefan Schmidt [Fri, 15 Nov 2019 08:05:16 +0000 (09:05 +0100)]
ci: remove logic for doing coverity builds only on Saturday

We had this disabled for the release and I think having it run every
nice is quite nice to give fast feedback on Coverity issues.

Differential Revision: https://phab.enlightenment.org/D10680

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
4 years agoThe header was filled with the standard template, now it's filled with correct infos
maxerba [Sat, 16 Nov 2019 17:11:27 +0000 (18:11 +0100)]
The header was filled with the standard template, now it's filled with correct infos

4 years agoedje - box - calc min size correctly at start ...
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 14:22:48 +0000 (14:22 +0000)]
edje - box - calc min size correctly at start ...

this fixes a logic hole where no chosen desc has been applied yet to a
box and thus it has no start layout thus no way to calc a min size.
this breaks min size calcs you do when setting up and object. this
fixes that by forcing the chosen desk on a min size calc so there is
one.

@fix

4 years agoecore-x - add some xi2 api's for fiddling with device properties
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 13:00:21 +0000 (13:00 +0000)]
ecore-x - add some xi2 api's for fiddling with device properties

add some infra to be able to get and set device properties (as well
as know if devices changed to we can refersh a gui or re-apply saved
settings etc.). it doesn't do everything but... it adds enough to
build on in e.

4 years agoefreet - consider ctime changes as changes too
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 12:58:34 +0000 (12:58 +0000)]
efreet - consider ctime changes as changes too

some distros do odd things with source desktop files and set their
mtime timestamps to 0... thus we can't tell that there is a change.
thier ctimes do change, so consider the newer of either of these as
the modification time to not miss updates

@fix

4 years agostrings - be cleaere we are initialising buffers not appending
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 12:57:14 +0000 (12:57 +0000)]
strings - be cleaere we are initialising buffers not appending

also should silence possible code checkers.

4 years agoelm theme - ensure hotspot is visible so it is calculated
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 12:56:17 +0000 (12:56 +0000)]
elm theme - ensure hotspot is visible so it is calculated

new changes to avoid calcs on invisible parts means the hotspot doesnt
recalc thus doesnt move thus... is wrong. make it visible in the theme
to ensure it is.

4 years agoadd .uuid files to ignore
Carsten Haitzler (Rasterman) [Sat, 16 Nov 2019 13:00:12 +0000 (13:00 +0000)]
add .uuid files to ignore

4 years agoEina_Matrix : Use math header for cosf and sinf of rotate function.
JunsuChoi [Fri, 8 Nov 2019 06:33:50 +0000 (06:33 +0000)]
Eina_Matrix : Use math header for cosf and sinf of rotate function.

The local cos and sin functions differ from
the math header cos and sin functions by result values
The 4th decimal place is different.
Computing large numbers can cause errors.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10467

4 years agogl_drm: remove dead return statement
Stefan Schmidt [Fri, 15 Nov 2019 16:56:56 +0000 (11:56 -0500)]
gl_drm: remove dead return statement

Summary:
This return can never be reached in this function.

CID: 1402607
Depends on D10682

Reviewers: raster, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10683

4 years agoexamples: efl_exe: fix out of bounds write
Stefan Schmidt [Fri, 15 Nov 2019 16:55:47 +0000 (11:55 -0500)]
examples: efl_exe: fix out of bounds write

Summary:
Buf is 4096 in size and rw_slice.len also evaluates to 4096. Write at
the last byte and not over bound instead.

CID: 1403895

Reviewers: raster, bu5hm4n, devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10682

4 years agoeolian: fix memory leak when using error objects
Daniel Kolesa [Fri, 15 Nov 2019 12:36:30 +0000 (13:36 +0100)]
eolian: fix memory leak when using error objects

4 years agoefreet: fix typo
Boris Faure [Fri, 15 Nov 2019 11:54:55 +0000 (12:54 +0100)]
efreet: fix typo

Summary: efreet: fix typo

Test Plan: None

Reviewers: cedric, raster, lauromoura, devilhorns, marcelhollerbach, segfaultxavi, zmike, vtorri

Reviewed By: segfaultxavi, vtorri

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10676

4 years agocsharp: FunctionPtr wrappers are not IDisposable
Lauro Moura [Fri, 15 Nov 2019 03:09:29 +0000 (00:09 -0300)]
csharp: FunctionPtr wrappers are not IDisposable

Summary:
They don't actually store unmanaged memory and we already rely on the GC
to free them (not calling Dispose() directly through the managedCb
closure, so we don't need IDisposable.

Just making sure we release the Function Pointer data in the main loop
as the GC runs in a different thread.

Ref T8423

Depends on D10672

Reviewers: brunobelo, felipealmeida, YOhoho

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8423

Differential Revision: https://phab.enlightenment.org/D10673

4 years agocsharp: Silence CA2000 in tests
Lauro Moura [Fri, 15 Nov 2019 03:08:38 +0000 (00:08 -0300)]
csharp: Silence CA2000 in tests

Summary:
These objects are expected to leave scope while alive.

Ref T8423

Depends on D10671

Reviewers: brunobelo, felipealmeida, YOhoho

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8423

Differential Revision: https://phab.enlightenment.org/D10672

4 years agocsharp: Suppress CA2000 in native wrappers.
Lauro Moura [Fri, 15 Nov 2019 03:07:11 +0000 (00:07 -0300)]
csharp: Suppress CA2000 in native wrappers.

Summary:
These methods may instantiate `IDisposable` classes like `Array`,
`Iterator` to pass to user-overriden C# methods. As we can't
guarantee the user stored the object or not, we can't call Dispose
directly on them.

Ref T8423

Depends on D10670

Reviewers: brunobelo, felipealmeida, YOhoho

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8423

Differential Revision: https://phab.enlightenment.org/D10671

4 years agocsharp: More CA2000 fixes
Lauro Moura [Fri, 15 Nov 2019 03:06:29 +0000 (00:06 -0300)]
csharp: More CA2000 fixes

Summary:
For eldbus.Proxy.Send, as the native function takes ownership of the
message, we Ref it so it can still be used afterwards.

Ref T8423

Reviewers: brunobelo, felipealmeida, YOhoho

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8423

Differential Revision: https://phab.enlightenment.org/D10670

4 years agoEdje : textblock_styles strncmp improvement
abdulleh Ghujeh [Fri, 15 Nov 2019 01:14:03 +0000 (10:14 +0900)]
Edje : textblock_styles strncmp improvement

Summary: Improve string comparison

Reviewers: cedric, ali.alzyod, woohyun, bu5hm4n

Reviewed By: woohyun

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10635

4 years agoRevert "efl_ui/layout: selectively inhibit theme,changed event" 79/217879/1 submit/tizen/20191117.211045
JunsuChoi [Fri, 15 Nov 2019 06:56:04 +0000 (15:56 +0900)]
Revert "efl_ui/layout: selectively inhibit theme,changed event"

This reverts commit 6ed8c7653e87da4f81da5a21c3b942e9fa0f828e.

This patch is under discussion whether or not to revert from open source.
@tizen_only
@tizen_fix

Change-Id: Icfe948cfee17242e6f433656268f33b00625613e

4 years agoedje: Remove warnings accepted/tizen/unified/20191115.084010 submit/tizen/20191114.210213
Lauro Moura [Thu, 14 Nov 2019 18:39:24 +0000 (18:39 +0000)]
edje: Remove warnings

Missing declaration from another file and removing unused variable.

After D10605

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10674

4 years agocsharp: Disposing IDisposable objects.
Bruno da Silva Belo [Thu, 14 Nov 2019 17:26:16 +0000 (14:26 -0300)]
csharp: Disposing IDisposable objects.

Summary: ref T8423

Reviewers: lauromoura, felipealmeida, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8423

Differential Revision: https://phab.enlightenment.org/D10644

4 years agoedje_calc: Exception handling if no calculation is required.
Woochanlee [Thu, 14 Nov 2019 05:16:18 +0000 (05:16 +0000)]
edje_calc: Exception handling if no calculation is required.

If there is no object swllowed, do not run part_calc on it.
This swallow will be calculated if there is an associated part, otherwise it will not need to be calculated.

When the app is launched, a lot of edje calculation logic is executed.
Most of the edje size is missing, so the calculation result is meaningless.
Added code to prevent this.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10605

4 years agoecore-drm2: Fix issue of shifting 1 by more than 32bits
Chris Michael [Thu, 14 Nov 2019 17:21:40 +0000 (12:21 -0500)]
ecore-drm2: Fix issue of shifting 1 by more than 32bits

Based on 9ca573f40f1065cc717c0c5aabb787671bab852b, this patch fixes
potential undefined behaviour on 64 bit systems.

@fix

4 years agoeo: fix UB in the eo event code (edje_cc hangs etc.)
Daniel Kolesa [Thu, 14 Nov 2019 03:02:09 +0000 (04:02 +0100)]
eo: fix UB in the eo event code (edje_cc hangs etc.)

Today I started experiencing mysterious hanging of edje_cc
during build. "The French are at it again" I thought, and
after spending a while bisecting, I found the culprit.
It's 7f53d9158395504151e1ff3dcae715a799d913a8.

So, what is happening in here?

The idea here was fundamentally sound; compute a special
hash value for event descriptors, taking range between 0
and 63 (on 64-bit systems) and 0 and 31 (on 32-bit systems),
then use a mask sized 32-bit or 64-bit (depending on your
system) and check early if to bail out from callback_call,
saving some resources. So far so good.

The problem is in the way the mask is handled. We're applying
the hash as the shift value like, `x |= (1 << hash)`. On 32-bit
systems this is okay, but on 64-bit systems, C's dumb silent
coercion rules kick in, since the left side of the expression
is 1, a literal with type signed int; that means our shifting
range is limited to 31 and what we get is... undefined behavior.

This is obviously not what we want, so take a 1ULL value as a
base. The previous thing seemingly worked on x86_64 (nobody
reported any issues) and interestingly it worked for me too
for a while (on ppc64le), but undefined behavior can be
unpredictable, so...

This shouldn't need a commit message as long as this, but I'm
making it proportional to the amount of time I wasted on this.

4 years agoefl_canvas_vg_node: Prevent access to NULL object for remove warning
JunsuChoi [Thu, 14 Nov 2019 02:25:52 +0000 (11:25 +0900)]
efl_canvas_vg_node: Prevent access to NULL object for remove warning

Summary:
For remove this warning
WRN<3378>:eo ../src/lib/eo/eo.c:644 _efl_object_call_resolve() NULL passed to function efl_invalidated_get().

Test Plan: elementary_test -> animation_view

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10627

4 years agorevert "elm/genlist: remove calc jobs" 16/217816/1
SangHyeon Jade Lee [Thu, 14 Nov 2019 10:55:06 +0000 (19:55 +0900)]
revert "elm/genlist: remove calc jobs"

This reverts commit 576292fc111b4e6ef9d7e4322ceabfa625088bb5.

Change-Id: I68b6f4ef0bc228a94919cf56efa019e8b371f842

4 years agoRevert "elm/genlist: defer recalc when applying a name filter" 15/217815/1
SangHyeon Jade Lee [Thu, 14 Nov 2019 10:51:25 +0000 (19:51 +0900)]
Revert "elm/genlist: defer recalc when applying a name filter"

This reverts commit 706e4b279f2da6bdeee28d4ee390b08a58ba0161.

Change-Id: I1e5019e7764cbb0cbc25e82baed89761070d80fd

4 years ago[Genlist] Optimization for genlist clear 33/217033/3
Godly T.Alias [Mon, 4 Nov 2019 14:47:41 +0000 (20:17 +0530)]
[Genlist] Optimization for genlist clear

Avoid block calculations and cache operations during genlist clear

Change-Id: I16a35d166a71d9f4b57aa49b62758f65e3d66ced
Signed-off-by: Godly T.Alias <godly.talias@samsung.com>
4 years agoefl: improve Efl.BooleanModel test by checking the child del case. accepted/tizen/unified/20191114.123448 submit/tizen/20191113.212830
Cedric BAIL [Fri, 8 Nov 2019 20:14:15 +0000 (12:14 -0800)]
efl: improve Efl.BooleanModel test by checking the child del case.

This has detected the bug that previous commit fix.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10634

4 years agoefl: remove useless printf from Efl Container Model tests.
Cedric BAIL [Fri, 8 Nov 2019 20:13:53 +0000 (12:13 -0800)]
efl: remove useless printf from Efl Container Model tests.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10633

4 years agoecore: correctly apply the offset on the upper part of the boolean mask for Efl.Boole...
Cedric BAIL [Fri, 8 Nov 2019 20:12:30 +0000 (12:12 -0800)]
ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel.

The upper mask is the one that should actually move as the gap is between the lower and
the upper mask when removing an element from the array.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10632

4 years agoecore: remove the composited children from the source of an Efl.CompositeModel.
Cedric BAIL [Fri, 8 Nov 2019 20:10:50 +0000 (12:10 -0800)]
ecore: remove the composited children from the source of an Efl.CompositeModel.

The composite model was erroneously giving the reference to a children composited model
instead of the origianl children which made it impossible for the composited model
to delete the right child.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10631

4 years agoelementary: fix initialization order and memory leak when setting model on Efl.Ui...
Cedric BAIL [Fri, 8 Nov 2019 00:17:06 +0000 (16:17 -0800)]
elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView.

This patch use volatile model to make sure that a model is properly cleaned once it is not
used anymore.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10625

4 years agoelementary: fix recursive case during model fetch in Efl.Ui.CollectionView.
Cedric BAIL [Fri, 8 Nov 2019 00:14:44 +0000 (16:14 -0800)]
elementary: fix recursive case during model fetch in Efl.Ui.CollectionView.

Figuring out why model fetch was sometime not working recursively allow to
reduce the amount of request that need to be made. In this case, notifying
the position manager or lack of notification was triggering a case where the
item would not show up (Joice of nested asynchronous behavior).

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10624

4 years agoecore: properly handle children destruction in Efl.BooleanModel.
Cedric BAIL [Fri, 8 Nov 2019 00:08:30 +0000 (16:08 -0800)]
ecore: properly handle children destruction in Efl.BooleanModel.

The children removal event is happening on the parent model, so access
values directly.

T8358

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10623

4 years agocsharp: Some missing conversions
Lauro Moura [Wed, 13 Nov 2019 13:05:27 +0000 (10:05 -0300)]
csharp: Some missing conversions

Summary:
Ref T8430

Depends on D10616

Reviewers: brunobelo, segfaultxavi, felipealmeida, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8430

Differential Revision: https://phab.enlightenment.org/D10652

4 years agocsharp: Add conversion methods for generated types
Lauro Moura [Wed, 13 Nov 2019 13:05:19 +0000 (10:05 -0300)]
csharp: Add conversion methods for generated types

Summary:
This also adds a helper method to convert from a value type name to the
reference type name. (e.g. int to Int32).

Ref T8430

Reviewers: felipealmeida, brunobelo, YOhoho

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8430

Differential Revision: https://phab.enlightenment.org/D10653

4 years agoeolian_mono: change OnXXXEvent access modifier from public to protected virtual
Yeongjong Lee [Wed, 13 Nov 2019 06:58:39 +0000 (03:58 -0300)]
eolian_mono: change OnXXXEvent access modifier from public to protected virtual

Summary:
OnXXXEvent is event invocation wrapper method to allow derived classes to
override the event invocation behavior.

Test Plan: meson with `-Dbindings=mono,cxx`

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10655

4 years agowl_egl : Prevent access to NULL pointer
JunsuChoi [Wed, 13 Nov 2019 04:40:44 +0000 (13:40 +0900)]
wl_egl : Prevent access to NULL pointer

Summary: The pointer s can be null.

Test Plan: N/A

Reviewers: Jaehyun_Cho, raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10654

Change-Id: I83a92eb98c0010d48e354c92f3c6f6cbc0b3e7c7

4 years agocsharp: Add To and From methods for implicit conversion.
Bruno da Silva Belo [Tue, 12 Nov 2019 20:07:48 +0000 (17:07 -0300)]
csharp: Add To and From methods for implicit conversion.

Summary: ref T8430

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8430

Differential Revision: https://phab.enlightenment.org/D10616

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_wm_rotation_supported
Christopher Michael [Tue, 12 Nov 2019 15:09:54 +0000 (10:09 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_wm_rotation_supported
functions

ref T8016

4 years agotests/ecore_wl2: Modify ecore_wl2_window_rotation test
Christopher Michael [Tue, 12 Nov 2019 14:55:41 +0000 (09:55 -0500)]
tests/ecore_wl2: Modify ecore_wl2_window_rotation test

Small patch to modify ecore_wl2_window_rotation test to support
ecore_wl2_window_rotation_set function

ref T8016

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_rotation_app functions
Christopher Michael [Tue, 12 Nov 2019 14:53:09 +0000 (09:53 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_rotation_app functions

ref T8016

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_preferred_rotation
Christopher Michael [Tue, 12 Nov 2019 14:50:12 +0000 (09:50 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_preferred_rotation
functions

ref T8016

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_maximized functions
Christopher Michael [Tue, 12 Nov 2019 14:47:36 +0000 (09:47 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_maximized functions

ref T8016

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_fullscreen functions
Christopher Michael [Tue, 12 Nov 2019 14:44:39 +0000 (09:44 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_fullscreen functions

ref T8016

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_focus_skip_get/set
Christopher Michael [Tue, 12 Nov 2019 14:41:29 +0000 (09:41 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_focus_skip_get/set
functions

ref T8016

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_floating_mode_get/set
Christopher Michael [Tue, 12 Nov 2019 14:39:15 +0000 (09:39 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_floating_mode_get/set
functions

ref T8016

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_alpha_get/set functions
Christopher Michael [Tue, 12 Nov 2019 14:35:50 +0000 (09:35 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_alpha_get/set functions

ref T8016

4 years agotests/ecore_wl2: Add test for ecore_wl2_display_compositor_version_get
Christopher Michael [Tue, 12 Nov 2019 14:22:09 +0000 (09:22 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_display_compositor_version_get

ref T8016

4 years agoefl_ui_relative_container: rename relative_layout
Yeongjong Lee [Tue, 12 Nov 2019 12:46:20 +0000 (13:46 +0100)]
efl_ui_relative_container: rename relative_layout

Summary:
Also,
Rename parameter name `target` to `base`.
Rename parameter name `relative` to `relative_position`.

ref T8380

Depends On D10639

Test Plan: ninja test

Reviewers: woohyun, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8380

Differential Revision: https://phab.enlightenment.org/D10640

4 years agoeolian_mono: avoid keyword as a variable name
Yeongjong Lee [Tue, 12 Nov 2019 13:14:03 +0000 (10:14 -0300)]
eolian_mono: avoid keyword as a variable name

Summary:
```
        private static void relation_left_get(System.IntPtr obj, System.IntPtr pd, Efl.Gfx.IEntity child, out Efl.Gfx.IEntity kw_base, out Efl.Gfx.Align relative_position)
        {
            Eina.Log.Debug("function efl_ui_relative_container_relation_left_get was called");
            var ws = Efl.Eo.Globals.GetWrapperSupervisor(obj);
            if (ws != null)
            {
                base = default(Efl.Gfx.IEntity);relative_position = default(Efl.Gfx.Align);
```
Parameter name is replaced with `kw_base` but `base` is not changed in assignment expression (`base = default(Efl.Gfx.IEntity...`).
This patch will fix following compiler error.
```
src/bindings/mono/efl_ui_relative_container.eo.cs(544,21): error CS1525: Unexpected symbol `=', expecting `.' or `['
```

Test Plan: ninja with D10640

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10639