SangHyeon Jade Lee [Thu, 14 Nov 2019 10:55:06 +0000 (19:55 +0900)]
revert "elm/genlist: remove calc jobs"
This reverts commit
576292fc111b4e6ef9d7e4322ceabfa625088bb5.
Change-Id: I68b6f4ef0bc228a94919cf56efa019e8b371f842
SangHyeon Jade Lee [Thu, 14 Nov 2019 10:51:25 +0000 (19:51 +0900)]
Revert "elm/genlist: defer recalc when applying a name filter"
This reverts commit
706e4b279f2da6bdeee28d4ee390b08a58ba0161.
Change-Id: I1e5019e7764cbb0cbc25e82baed89761070d80fd
Godly T.Alias [Mon, 4 Nov 2019 14:47:41 +0000 (20:17 +0530)]
[Genlist] Optimization for genlist clear
Avoid block calculations and cache operations during genlist clear
Change-Id: I16a35d166a71d9f4b57aa49b62758f65e3d66ced
Signed-off-by: Godly T.Alias <godly.talias@samsung.com>
Cedric BAIL [Fri, 8 Nov 2019 20:14:15 +0000 (12:14 -0800)]
efl: improve Efl.BooleanModel test by checking the child del case.
This has detected the bug that previous commit fix.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10634
Cedric BAIL [Fri, 8 Nov 2019 20:13:53 +0000 (12:13 -0800)]
efl: remove useless printf from Efl Container Model tests.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10633
Cedric BAIL [Fri, 8 Nov 2019 20:12:30 +0000 (12:12 -0800)]
ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel.
The upper mask is the one that should actually move as the gap is between the lower and
the upper mask when removing an element from the array.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10632
Cedric BAIL [Fri, 8 Nov 2019 20:10:50 +0000 (12:10 -0800)]
ecore: remove the composited children from the source of an Efl.CompositeModel.
The composite model was erroneously giving the reference to a children composited model
instead of the origianl children which made it impossible for the composited model
to delete the right child.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10631
Cedric BAIL [Fri, 8 Nov 2019 00:17:06 +0000 (16:17 -0800)]
elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView.
This patch use volatile model to make sure that a model is properly cleaned once it is not
used anymore.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10625
Cedric BAIL [Fri, 8 Nov 2019 00:14:44 +0000 (16:14 -0800)]
elementary: fix recursive case during model fetch in Efl.Ui.CollectionView.
Figuring out why model fetch was sometime not working recursively allow to
reduce the amount of request that need to be made. In this case, notifying
the position manager or lack of notification was triggering a case where the
item would not show up (Joice of nested asynchronous behavior).
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10624
Cedric BAIL [Fri, 8 Nov 2019 00:08:30 +0000 (16:08 -0800)]
ecore: properly handle children destruction in Efl.BooleanModel.
The children removal event is happening on the parent model, so access
values directly.
T8358
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10623
Lauro Moura [Wed, 13 Nov 2019 13:05:27 +0000 (10:05 -0300)]
csharp: Some missing conversions
Summary:
Ref T8430
Depends on D10616
Reviewers: brunobelo, segfaultxavi, felipealmeida, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8430
Differential Revision: https://phab.enlightenment.org/D10652
Lauro Moura [Wed, 13 Nov 2019 13:05:19 +0000 (10:05 -0300)]
csharp: Add conversion methods for generated types
Summary:
This also adds a helper method to convert from a value type name to the
reference type name. (e.g. int to Int32).
Ref T8430
Reviewers: felipealmeida, brunobelo, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8430
Differential Revision: https://phab.enlightenment.org/D10653
Yeongjong Lee [Wed, 13 Nov 2019 06:58:39 +0000 (03:58 -0300)]
eolian_mono: change OnXXXEvent access modifier from public to protected virtual
Summary:
OnXXXEvent is event invocation wrapper method to allow derived classes to
override the event invocation behavior.
Test Plan: meson with `-Dbindings=mono,cxx`
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10655
JunsuChoi [Wed, 13 Nov 2019 04:40:44 +0000 (13:40 +0900)]
wl_egl : Prevent access to NULL pointer
Summary: The pointer s can be null.
Test Plan: N/A
Reviewers: Jaehyun_Cho, raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10654
Change-Id: I83a92eb98c0010d48e354c92f3c6f6cbc0b3e7c7
Bruno da Silva Belo [Tue, 12 Nov 2019 20:07:48 +0000 (17:07 -0300)]
csharp: Add To and From methods for implicit conversion.
Summary: ref T8430
Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8430
Differential Revision: https://phab.enlightenment.org/D10616
Christopher Michael [Tue, 12 Nov 2019 15:09:54 +0000 (10:09 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_wm_rotation_supported
functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:55:41 +0000 (09:55 -0500)]
tests/ecore_wl2: Modify ecore_wl2_window_rotation test
Small patch to modify ecore_wl2_window_rotation test to support
ecore_wl2_window_rotation_set function
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:53:09 +0000 (09:53 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_rotation_app functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:50:12 +0000 (09:50 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_preferred_rotation
functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:47:36 +0000 (09:47 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_maximized functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:44:39 +0000 (09:44 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_fullscreen functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:41:29 +0000 (09:41 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_focus_skip_get/set
functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:39:15 +0000 (09:39 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_floating_mode_get/set
functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:35:50 +0000 (09:35 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_alpha_get/set functions
ref T8016
Christopher Michael [Tue, 12 Nov 2019 14:22:09 +0000 (09:22 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_display_compositor_version_get
ref T8016
Yeongjong Lee [Tue, 12 Nov 2019 12:46:20 +0000 (13:46 +0100)]
efl_ui_relative_container: rename relative_layout
Summary:
Also,
Rename parameter name `target` to `base`.
Rename parameter name `relative` to `relative_position`.
ref T8380
Depends On D10639
Test Plan: ninja test
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8380
Differential Revision: https://phab.enlightenment.org/D10640
Yeongjong Lee [Tue, 12 Nov 2019 13:14:03 +0000 (10:14 -0300)]
eolian_mono: avoid keyword as a variable name
Summary:
```
private static void relation_left_get(System.IntPtr obj, System.IntPtr pd, Efl.Gfx.IEntity child, out Efl.Gfx.IEntity kw_base, out Efl.Gfx.Align relative_position)
{
Eina.Log.Debug("function efl_ui_relative_container_relation_left_get was called");
var ws = Efl.Eo.Globals.GetWrapperSupervisor(obj);
if (ws != null)
{
base = default(Efl.Gfx.IEntity);relative_position = default(Efl.Gfx.Align);
```
Parameter name is replaced with `kw_base` but `base` is not changed in assignment expression (`base = default(Efl.Gfx.IEntity...`).
This patch will fix following compiler error.
```
src/bindings/mono/efl_ui_relative_container.eo.cs(544,21): error CS1525: Unexpected symbol `=', expecting `.' or `['
```
Test Plan: ninja with D10640
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10639
Yeongjong Lee [Mon, 11 Nov 2019 14:33:03 +0000 (11:33 -0300)]
mono: reduce duplicated event code
Summary: Introduction GetInternalEventCallback function to reduce duplicated event code.
Test Plan: ninja test
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10638
Lauro Moura [Mon, 21 Oct 2019 14:08:58 +0000 (11:08 -0300)]
dotnet: Generate doc and check for warnings
Reviewers: segfaultxavi, brunobelo, felipealmeida
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers, woohyun
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10630
Xavi Artigas [Tue, 12 Nov 2019 12:00:23 +0000 (13:00 +0100)]
Efl.Ui.Scroll_Manager: Fix indentation
JunsuChoi [Tue, 12 Nov 2019 07:23:33 +0000 (16:23 +0900)]
evas_device: Fix typo in evas_device_pop
Summary: Fix wrong null check
Test Plan: N/A
Reviewers: cedric, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10648
Change-Id: Ifd052087c960b81129c1f6db0cc85bc56d05e758
JunsuChoi [Tue, 12 Nov 2019 05:30:25 +0000 (14:30 +0900)]
Efl.Ui.Animation_View: Implement sector playing feature
Summary:
play_sector method is API for playing section.
If the animation object has section information, user can play the section.
Get the start and end section name and get the frame of each section.
And set and play the min and max frames of the current animation object.
Depends on D10506
Test Plan:
For example. Animation objects have "first","second" and "third" sectors.
And sector "second" has duration information.
User can use it like this:
efl_ui_animation_view_play_sector(anim_view, "first", "second");
efl_ui_animation_view_play_sector(anim_view, "second", NULL);
efl_ui_animation_view_play_sector(anim_view, "first", NULL); // first sector ~ end frame of animation object.
efl_ui_animation_view_play_sector(anim_view, "second", "third");
efl_ui_animation_view_play_sector(anim_view, "second", "wrong name");
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10507
JunsuChoi [Tue, 12 Nov 2019 05:30:10 +0000 (14:30 +0900)]
Efl.Gfx.Frame_Controller: Add sector property
Summary:
These APIs to get and set frames for a specific section for playing section.
Depends on D10505
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10506
JunsuChoi [Tue, 12 Nov 2019 05:29:50 +0000 (14:29 +0900)]
evas_cache_vg : Implements sector_get/set internal APIs
Summary:
These APIs to get and set frames for a specific section in vg animation.
get API looks for a sector by name in the markerlist of VG_File_Data.
Then return start and end frames.
Depends on D10504
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10505
JunsuChoi [Tue, 12 Nov 2019 05:28:44 +0000 (14:28 +0900)]
vg_loader: Get markers information form json data.
Summary: If json data has marker information, it is stored in vg file data.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10504
Shinwoo Kim [Tue, 12 Nov 2019 01:07:54 +0000 (10:07 +0900)]
evas_filter: remove shader compile error
Summary:
When grayscale fillter works there is a compile error:
implicit cast from "float" to "vec3"
Test Plan:
1. Create filter_example with following .
efl_gfx_filter_program_set(image, "grayscale ()", "grayscale");
2. Run.
ELM_ACCEL=gl ./filter_example
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10595
JunsuChoi [Wed, 13 Nov 2019 04:40:44 +0000 (13:40 +0900)]
wl_egl : Prevent access to NULL pointer
Summary: The pointer s can be null.
Test Plan: N/A
Reviewers: Jaehyun_Cho, raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10654
Change-Id: I2db21b24180bb9a29811617f9996e7f5bdf36196
Bowon Ryu [Tue, 12 Nov 2019 07:43:53 +0000 (16:43 +0900)]
evas_object_textblock: fix coverity warning.
This less-than-zero comparison of an unsigned value is never true.
Change-Id: I4d0845d9e0f0f61200013c76307deeaabb8a5f52
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Tue, 12 Nov 2019 07:35:22 +0000 (16:35 +0900)]
evas_object_textblock: fix svace warning
Change-Id: I2c2712ea5533d8d947933f1c6c779d855f41e18d
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Jaehyun Cho [Fri, 1 Nov 2019 08:14:30 +0000 (17:14 +0900)]
elm_index: implement elm_widget_item_signal_emit
elm_index implements elm_widget_item_signal_emit to support
elm_object_item_signal_emit.
@tizen_feature
Change-Id: I59ae651c2ffe8ae795da7789bec1533b938bc483
JunsuChoi [Tue, 12 Nov 2019 07:23:33 +0000 (16:23 +0900)]
evas_device: Fix typo in evas_device_pop
Summary: Fix wrong null check
Test Plan: N/A
Reviewers: cedric, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10648
Change-Id: I51c3f152c1ac4f49a0ed1787a656e350415c647e
Bowon Ryu [Tue, 12 Nov 2019 03:26:06 +0000 (12:26 +0900)]
Revert "Revert "evas_textblock: content fit feature""
@tizen_feature
This reverts commit
7bd419a6a0a52d90a56bdfb1a193fa8bbe7361f8.
Change-Id: I5c19e99acf4f83a8dc895c4cf2e56ba0de6cf955
Stefan Schmidt [Mon, 11 Nov 2019 08:58:18 +0000 (09:58 +0100)]
ci: fix ccache segfault during setup on CI in release-ready build
Hopefully this is the last place we need to apply this. It has been
bugging the cron daily CI builds a while now.
Differential Revision: https://phab.enlightenment.org/D10643
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Marcel Hollerbach [Thu, 7 Nov 2019 22:00:36 +0000 (23:00 +0100)]
elm: apply the same fix we needed in entry to other scrollable widgets
this here is the same effect as in my previous commit:
When re retheme a object, we need to reset the signals, otherwise there
would be wrongly displayed scrollbars.
This fixes wrong scrollbars in enlightenment.
Differential Revision: https://phab.enlightenment.org/D10628
Marcel Hollerbach [Mon, 11 Nov 2019 09:14:42 +0000 (10:14 +0100)]
efl_canvas_animation: correctly handle double signness
Summary:
start_delay and duration both have to be > 0.0 otherwise there should be
an error. This also adds the neccessary checks, to ensure that.
For now this is only added to the normal evas test suite, maybe we eed
to refactor these efl_* API tests into theire own test suite. However,
not for now.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10617
Jongmin Lee [Mon, 11 Nov 2019 06:16:02 +0000 (15:16 +0900)]
Revert "ecore-wl2: Move ecore_wl2_surface_create function to be internal"
This reverts commit
624e4bdce82bd26124ef2b78c3125be4cce52901.
Change-Id: I070f804e72fbedd422b1c74e5c8b2985958f2001
Jongmin Lee [Mon, 11 Nov 2019 05:01:35 +0000 (14:01 +0900)]
build:resolve migration build error
Change-Id: I8288c25adc596afa5a4802072601db0440a07337
Wonki Kim [Mon, 11 Nov 2019 02:23:31 +0000 (11:23 +0900)]
Revert "evas_textblock: content fit feature"
This reverts commit
94cacec55471055e69193f03646f5deb823c4319.
Jongmin Lee [Mon, 11 Nov 2019 00:30:43 +0000 (09:30 +0900)]
build: resolve migration build error
Change-Id: Iff129b325858fe6c646374d1b3c7606c17e54849
Bruno da Silva Belo [Fri, 8 Nov 2019 02:33:09 +0000 (23:33 -0300)]
csharp: Localization strings with CultureInfo.
Summary: ref T8404
Reviewers: lauromoura, felipealmeida, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8404
Differential Revision: https://phab.enlightenment.org/D10608
Lauro Moura [Fri, 8 Nov 2019 01:46:15 +0000 (22:46 -0300)]
csharp: Fix running headless tests in dotnet
Summary:
CoreCLR, the runtime of dotnet, has some issues regarding storing
environment variables (see dotnet/coreclr issue #15812), keeping them in
a local cache instead of flushing to the native `setenv`.
This commit replaces the usage of
`System.Environment.SetEnvironmentVariable` with a `setenv` wrapper.
Test Plan: Run without DISPLAY set and with dotnet.
Reviewers: felipealmeida, brunobelo, segfaultxavi, YOhoho
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10619
Marcel Hollerbach [Thu, 7 Nov 2019 20:45:02 +0000 (21:45 +0100)]
elm_entry: fix wrong displayed scrollbars
the scrolbars have been displayed wrongly before. Reason for this is
that the theme displays the bars per default, the code however works
with hidden by default. This was worked arround before with the fact
that we are explicitly hiding the vbar/hbar before.
The reason this previous code was not working proberly is that entry
decided to retheme a object that was already set to the interface
scrollable object. Which means, it was not detected by the code. With
the newly introduced reset function you can tell the interface, that you
have changed the group, signals will be emitted accordingly.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10622
Cedric BAIL [Thu, 7 Nov 2019 19:53:15 +0000 (11:53 -0800)]
elementary: watch event on the model Efl.Ui.CollectionView use directly.
Efl.Model can be nested and Efl.Ui.CollectionView use this ability. Listening
on the nested model instead of the nester model can lead to event being triggered
that shouldn't. Better listen on the top model.
Differential Revision: https://phab.enlightenment.org/D10621
Cedric BAIL [Thu, 7 Nov 2019 18:58:04 +0000 (10:58 -0800)]
eo: make sure to return the right value for efl_event_callback_call.
EINA_FALSE is to be returned only if one of the callback did call
efl_event_callback_stop not if their was no callback called.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10620
Cedric BAIL [Wed, 6 Nov 2019 23:09:14 +0000 (15:09 -0800)]
elementary: properly handle in flight request in Efl.Ui.CollectionView.
This fix adding item not always showing up in the CollectionView right away.
The main issue comes down to the fact we can not chain a new request when one
is already resolved partially. The code now make sure to properly do this.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10614
Cedric BAIL [Wed, 6 Nov 2019 23:06:17 +0000 (15:06 -0800)]
elementary: cleanup Eina_Future properly by relying on efl_future_then proper lifecycle.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10613
Lauro Moura [Thu, 7 Nov 2019 20:59:40 +0000 (17:59 -0300)]
csharp: Make GetPart public.
Summary:
`efl_part_get` is protected in C due to the presence of `efl_part`,
which does automatic refcount management in single method calls.
The C# binding has no limitation on this as it already handles the
lifetime for all objects.
Fixes T8462
Reviewers: brunobelo, segfaultxavi, SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8462
Differential Revision: https://phab.enlightenment.org/D10594
Bruno da Silva Belo [Thu, 7 Nov 2019 18:52:31 +0000 (19:52 +0100)]
csharp: Removing a never used class.
Summary: ref T8417
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8417
Differential Revision: https://phab.enlightenment.org/D10611
Taehyub Kim [Thu, 7 Nov 2019 04:38:47 +0000 (13:38 +0900)]
efl_ui_alert_popup: add title part in parts block
Summary: add title part in parts block
Reviewers: Jaehyun_Cho, woohyun, zmike, segfaultxavi
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10596
Lauro Moura [Thu, 7 Nov 2019 02:47:50 +0000 (23:47 -0300)]
csharp: Fix test build dependency
Summary: Make dotnet target also depend on the manual test files.
Test Plan: Modify one of the manual files and run the tests again. The test target should be rebuilt.
Reviewers: bu5hm4n, segfaultxavi, brunobelo, felipealmeida
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10609
Lauro Moura [Thu, 7 Nov 2019 02:47:39 +0000 (23:47 -0300)]
efl: Make stable single-valued getters consistent.
Summary:
Instead of a getter with an explicit return type, change it to be a
single-valued property.
The eolian C generator takes care of making this single value the actual
return value of the C function.
This also makes these properties able to be reflected on.
The stack properties returns just a pointer and not a new ref, so no
@move needed.
Beta properties will be handled in a future commit.
Depends on D10601
Reviewers: segfaultxavi, bu5hm4n, q66, cedric
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers, brunobelo, felipealmeida
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10602
Bruno da Silva Belo [Thu, 7 Nov 2019 02:34:18 +0000 (23:34 -0300)]
csharp:comma have whitespace after and none before
Reviewers: felipealmeida, lauromoura, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10575
Woochanlee [Wed, 6 Nov 2019 07:13:03 +0000 (07:13 +0000)]
edje_calc: UNLIKELY changed to LIKELY.
It should takes true almost all times when it checks.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10606
Cedric BAIL [Fri, 1 Nov 2019 15:03:00 +0000 (08:03 -0700)]
elementary: fix end of fast scroll not showing up during Efl.Ui.CollectionView scroll.
efl_ui_position_manager_entity_entities_ready is expecting the end offset and not the
length of how many items have been updated. Sending the correct number fixes the problem.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10590
Xavi Artigas [Tue, 5 Nov 2019 19:26:14 +0000 (20:26 +0100)]
Efl.Interpolator*: More sensible API names and docs
Summary:
OK, so, ALL interpolator parameters were called "factor" and the docs
literally said "First factor, Second factor, ..."
After diving into the actual implementation, proper names (and types) for the
parameters were found and proper docs written.
I am afraid I could not make any sense of the Divisor interpolator code. Those
docs still need writing.
Test Plan: Everything still builds and passes tests. No functional changes.
Reviewers: zmike, cedric, bu5hm4n, Jaehyun_Cho
Reviewed By: bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10603
Lauro Moura [Tue, 5 Nov 2019 20:59:01 +0000 (17:59 -0300)]
csharp: Revamp dotnet support
Summary:
Instead of building with a patched meson version, make use of custom
targets and generated csproj files so we can used upstream meson
normally.
This avoids digging into "non official" dotnet stuff like calling
the CSC.dll directly that the patched meson tried to do.
To enable, run meson with `-Ddotnet=true`.
Regarding source file dependencies, Meson has a limitation[1]
about generated artifacts being placed in subdirectories.
In order to correctly track these generated artifacts for dotnet, we
generated them in the same folder as the csproj file through
`dotnet build -o`.
Instead of installing the dll like we do for mono, a nupkg is generated
and installed in the same folder as the dll would be
(<prefix>/lib/x86_64-linux-gnu/efl-mono-1)
To avoid messing around with Nupkg caches, we reference the source
project for the library directly instead of the nupkg when building the
test suite.
[1] https://github.com/mesonbuild/meson/issues/2320
Fixes T8168
Reviewers: bu5hm4n, woohyun, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, brunobelo, felipealmeida, segfaultxavi
Tags: #efl, #do_not_merge
Maniphest Tasks: T8168
Differential Revision: https://phab.enlightenment.org/D9717
Xavi Artigas [Wed, 30 Oct 2019 17:47:07 +0000 (18:47 +0100)]
docs: Add caveat details to Efl.Canvas.Animation
Summary:
Regarding object properties not matching actual rendered values when animations
are running.
Depends on D10560
Reviewers: bu5hm4n, cedric, zmike, Jaehyun_Cho
Reviewed By: bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10566
Lauro Moura [Tue, 5 Nov 2019 14:59:46 +0000 (11:59 -0300)]
eolian: Imply @no_unused if @move in return.
Summary:
This makes sure the user is warned if it ignores a return value that
could potentially be a memory leak.
This also makes possible to use `value {}` blocks with `@move` instead
of value-less properties with `@no_unused`.
Also removed the `@move` from canvas_text_async_layout as it is ignored
in the only place it is used.
Reviewers: q66
Reviewed By: q66
Subscribers: #reviewers, #committers, bu5hm4n, felipealmeida, cedric, segfaultxavi
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10601
Xavi Artigas [Tue, 5 Nov 2019 10:48:40 +0000 (11:48 +0100)]
docs: Efl.Gfx.View
Stefan Schmidt [Tue, 5 Nov 2019 14:53:24 +0000 (15:53 +0100)]
travis: update Ubuntu image to the 19.10 release
We keep the 18.04 LTS until a new LTS comes along.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10600
Stefan Schmidt [Tue, 5 Nov 2019 14:26:36 +0000 (15:26 +0100)]
ci: work around ccache segafult during setup
This is the same fix we applied for the macOS. Somehow ccache segfaults
during the init. This only shows on the Ubuntu 19.10 update.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10599
Stefan Schmidt [Wed, 30 Oct 2019 08:40:46 +0000 (09:40 +0100)]
travis/ci: update Fedora CI images to 31
Also disable the gstreamer 0.10 module since this version is no longer
shipped with Fedora 31.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10597
Stefan Schmidt [Mon, 4 Nov 2019 14:52:29 +0000 (15:52 +0100)]
tests/spec: allow for a longer timeout of the spec suite for dist build
During our ninja dist builds on the CI we run into timeouts for the spec
test suite taking longer than the default 30s. We can't pass any
multiplier into the ninja dist command as we are doing on the other unit
test runs.
Allow th default value for this suite to also cover the CI case. It does
no harm on sutuations where it finishes faster.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10593
Christopher Michael [Tue, 5 Nov 2019 14:44:53 +0000 (09:44 -0500)]
tests/ecore-wl2: Remove surface test
This test is not necessary anymore as the ecore_wl2_surface function
it was testing is now an internal function
ref T8016
Christopher Michael [Tue, 5 Nov 2019 14:30:48 +0000 (09:30 -0500)]
evas-wayland-common: Move boolean fields to bottom of structure
Christopher Michael [Tue, 5 Nov 2019 14:29:06 +0000 (09:29 -0500)]
evas-wayland-common: Fix variable type
The 'resizing' variable here does not need to be an 'int' as it's
either true or false, so change to be Eina_Bool.
Christopher Michael [Tue, 5 Nov 2019 14:26:49 +0000 (09:26 -0500)]
evas-wayland-common: Add include for ecore_wl2 internal functions
Christopher Michael [Tue, 5 Nov 2019 14:22:43 +0000 (09:22 -0500)]
ecore-wl2: Move ecore_wl2_surface_alpha_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:22:21 +0000 (09:22 -0500)]
ecore-wl2: Move ecore_wl2_surface_window_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:22:01 +0000 (09:22 -0500)]
ecore-wl2: Move ecore_wl2_surface_manager_del function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:21:29 +0000 (09:21 -0500)]
ecore-wl2: Move ecore_wl2_surface_manager_add function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:21:06 +0000 (09:21 -0500)]
ecore-wl2: Move ecore_wl2_surface_buffer_create function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:20:42 +0000 (09:20 -0500)]
ecore-wl2: Move ecore_wl2_window_surface_flush function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:20:22 +0000 (09:20 -0500)]
ecore-wl2: Move ecore_wl2_surface_flush function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:20:02 +0000 (09:20 -0500)]
ecore-wl2: Move ecore_wl2_surface_post function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:19:41 +0000 (09:19 -0500)]
ecore-wl2: Move ecore_wl2_surface_assign function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:19:21 +0000 (09:19 -0500)]
ecore-wl2: Move ecore_wl2_surface_data_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:19:00 +0000 (09:19 -0500)]
ecore-wl2: Move ecore_wl2_surface_reconfigure function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:18:26 +0000 (09:18 -0500)]
ecore-wl2: Move ecore_wl2_surface_destroy function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:17:40 +0000 (09:17 -0500)]
ecore-wl2: Move ecore_wl2_surface_create function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:17:02 +0000 (09:17 -0500)]
ecore-wl2: Move ecore_wl2_buffer_age_inc function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:16:31 +0000 (09:16 -0500)]
ecore-wl2: Move ecore_wl2_buffer_age_set function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:16:11 +0000 (09:16 -0500)]
ecore-wl2: Move ecore_wl2_buffer_age_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:15:48 +0000 (09:15 -0500)]
ecore-wl2: Move ecore_wl2_buffer_busy_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:15:28 +0000 (09:15 -0500)]
ecore-wl2: Move ecore_wl2_buffer_busy_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:15:08 +0000 (09:15 -0500)]
ecore-wl2: Move ecore_wl2_buffer_destroy function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:14:48 +0000 (09:14 -0500)]
ecore-wl2: Move ecore_wl2_buffer_unlock function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:14:16 +0000 (09:14 -0500)]
ecore-wl2: Move ecore_wl2_buffer_lock function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:13:46 +0000 (09:13 -0500)]
ecore-wl2: Move ecore_wl2_buffer_discard function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:13:06 +0000 (09:13 -0500)]
ecore-wl2: Move ecore_wl2_buffer_unmap function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013