Rich Trott [Wed, 9 Mar 2016 23:26:34 +0000 (15:26 -0800)]
console: check that stderr is writable
`Console` constructor checks that `stdout.write()` is a function but
does not do an equivalent check for `stderr.write()`. If `stderr` is not
specified in the constructor, then `stderr` is set to be `stdout`.
However, if `stderr` is specified, but `stderr.write()` is not a
function, then an exception is not thrown until `console.error()` is
called.
This change adds the same check for 'stderr' in the constructor that is
there for `stdout`. If `stderr` fails the check, then a `TypeError` is
thrown.
Took the opportunity to copyedit the `console` doc a little too.
PR-URL: https://github.com/nodejs/node/pull/5635
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Ben Noordhuis [Tue, 8 Mar 2016 22:21:50 +0000 (23:21 +0100)]
deps: remove unused openssl files
Refs: https://github.com/nodejs/node/issues/5615
PR-URL: https://github.com/nodejs/node/pull/5619
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
Santiago Gimeno [Tue, 8 Mar 2016 23:59:59 +0000 (00:59 +0100)]
test: improve test-npm-install
Make npm install a dependency that is defined as a relative path, so it
avoids any network interaction.
PR-URL: https://github.com/nodejs/node/pull/5613
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Myles Borins [Tue, 9 Feb 2016 18:32:32 +0000 (10:32 -0800)]
test: add test-npm-install to parallel tests suite
Currently we are not testing that `npm install` works.
This is a very naive / basic test that shells out to `npm install`
in an empty `tempDir`. While this test will not be able to check
that `npm install` is 100% working, it should catch certain edge
cases that break it.
PR-URL: https://github.com/nodejs/node/pull/5166
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Santiago Gimeno [Wed, 2 Mar 2016 20:59:17 +0000 (21:59 +0100)]
test: repl tab completion test
It checks that `eval` is called with `.scope` as an input string.
PR-URL: https://github.com/nodejs/node/pull/5534
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Bill Automata [Tue, 1 Mar 2016 17:26:32 +0000 (09:26 -0800)]
doc: update crypto docs to use good defaults
[Diffie-Hellman](https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation)
keys are composed of a `generator` a `prime` a `secret_key`
and the `public_key` resulting from the math operation:
```
(generator ^ secret_key) mod prime = public_key
```
Diffie-Hellman keypairs will compute a matching shared secret
if and only if the generator and prime match for both
recipients. The generator is usually **2** and the prime is
what is called a [Safe Prime](https://en.wikipedia.org/wiki/Safe_prime).
Usually this matching is accomplished by using
[standard published groups](http://tools.ietf.org/html/rfc3526).
We expose access those groups with the `crypto.getDiffieHellman`
function.
`createDiffieHellman` is trickier to use. The original example
had the user creating 11 bit keys, and creating random groups of
generators and primes. 11 bit keys are very very small, can be
cracked by a single person on a single sheet of paper. A
byproduct of using such small keys were that it was a high
likelihood that two calls of `createDiffieHellman(11)` would
result in using the same 11 bit safe prime.
The original example code would fail when the safe primes generated
at 11 bit lengths did not match for alice and bob.
If you want to use your own generated safe `prime` then the proper
use of `createDiffieHellman` is to pass the `prime` and `generator`
to the recipient's constructor, so that when they compute the shared
secret their `prime` and `generator` match, which is fundamental to
the algorithm.
PR-URL: https://github.com/nodejs/node/pull/5505
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Brian White [Tue, 1 Mar 2016 02:03:14 +0000 (21:03 -0500)]
doc: fix crypto update() signatures
PR-URL: https://github.com/nodejs/node/pull/5500
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Vladimir Kurchatkin [Sun, 28 Feb 2016 16:44:39 +0000 (19:44 +0300)]
net: make `isIPv4` and `isIPv6` more efficient
`isIPv4` and `isIPv6` are implemented on top of `isIP`, which in turn
checks the sting for being both IPv4 and IPv6, which can be inefficient
in some scenarios. This commit makes them use `uv_inet_pton` directly
instead.
PR-URL: https://github.com/nodejs/node/pull/5478
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Prince J Wesley [Wed, 24 Feb 2016 18:56:41 +0000 (00:26 +0530)]
repl: fix stack trace column number in strict mode
On strict mode, "'use strict'; void 0; " is added as prefix
in order to prevent "use strict" as the result value
for let/const statements. It causes wrong column number in
stack trace.
PR-URL: https://github.com/nodejs/node/pull/5416
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Jackson Tian [Fri, 19 Feb 2016 03:01:11 +0000 (11:01 +0800)]
lib: simplify code with String.prototype.repeat()
use String.prototype.repeat() to simplify code, less code,
more semantically.
PR-URL: https://github.com/nodejs/node/pull/5359
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Jackson Tian [Mon, 15 Feb 2016 04:53:17 +0000 (12:53 +0800)]
lib: reduce usage of `self = this`
Remove unnecessary `self = this`.
PR-URL: https://github.com/nodejs/node/pull/5231
Reviewed-By: James M Snell <jasnell@gmail.com>
Benjamin Gruenbaum [Sun, 14 Feb 2016 15:27:17 +0000 (17:27 +0200)]
net: remove unused `var self = this` from old code
Removed an unused `var self = this` that is no longer required.
PR-URL: https://github.com/nodejs/node/pull/5224
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Santiago Gimeno [Sun, 7 Feb 2016 09:20:50 +0000 (10:20 +0100)]
test: remove timer from test-http-1.0
It's possible that the `end` event is emitted after the timeout fires
causing the test to fail. Just remove the timer. If for some reason the
`end` would never fire, the test will fail with a timeout.
PR-URL: https://github.com/nodejs/node/pull/5129
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Nathan Woltman [Sun, 20 Dec 2015 07:01:34 +0000 (02:01 -0500)]
lib: copy arguments object instead of leaking it
Instead of leaking the arguments object by passing it as an
argument to a function, copy it's contents to a new array,
then pass the array. This allows V8 to optimize the function
that contains this code, improving performance.
PR-URL: https://github.com/nodejs/node/pull/4361
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Jeremiah Senkpiel [Mon, 29 Feb 2016 21:49:30 +0000 (16:49 -0500)]
doc: reformat & improve node.1 manual page
Uses better troff formatting.
Removes v8 options from the man page.
Also edits `node -h` in node.cc slightly.
PR-URL: #5497
Reviewed-By: James Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
topal [Wed, 23 Mar 2016 19:53:18 +0000 (22:53 +0300)]
doc: updated fs #5862 removed irrelevant data in fs.markdown
fs.readFile, fs.writeFile and fs.appendFile doc changes
pulled back from master included details not relevant to
v4.
PR-URL: https://github.com/nodejs/node/pull/5877
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Myles Borins [Tue, 22 Mar 2016 22:53:18 +0000 (15:53 -0700)]
Working on v4.4.2
PR-URL: https://github.com/nodejs/node/pull/5835
Myles Borins [Mon, 21 Mar 2016 20:28:46 +0000 (13:28 -0700)]
2016-03-22, Version v4.4.1 'Argon' (LTS)
This LTS release comes with 113 commits, 56 of which are doc related,
18 of which are build / tooling related, 16 of which are test related
and 7 which are benchmark related.
Notable Changes:
* build:
- Updated Logos for the OSX + Windows installers
- (Rod Vagg) https://github.com/nodejs/node/pull/5401
- (Robert Jefe Lindstaedt) https://github.com/nodejs/node/pull/5531
- New option to select your VS Version in the Windows installer
- (julien.waechter) https://github.com/nodejs/node/pull/4645
- Support Visual C++ Build Tools 2015
- (João Reis) https://github.com/nodejs/node/pull/5627
* tools:
- Gyp now works on OSX without XCode
- (Shigeki Ohtsu) https://github.com/nodejs/node/pull/1325
Andrea Giammarchi [Fri, 18 Mar 2016 12:22:22 +0000 (12:22 +0000)]
doc: fix typo in synchronous randomBytes example
The string template was closed after `${buf.length}`
causing a syntax error within the example.
PR-URL: https://github.com/nodejs/node/pull/5781
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Shigeki Ohtsu [Sun, 6 Mar 2016 22:48:44 +0000 (07:48 +0900)]
deps: update openssl config
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in
opensslconf.h
Fixes: https://github.com/nodejs/LTS/issues/85
PR-URL: https://github.com/nodejs/node/pull/5630
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Johan Bergström [Wed, 9 Mar 2016 00:21:27 +0000 (11:21 +1100)]
build: don't install github templates
Avoid putting github templates in the source tarballs.
PR-URL: https://github.com/nodejs/node/pull/5612
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Jarrett Widman [Fri, 19 Feb 2016 17:24:32 +0000 (11:24 -0600)]
doc: topic blocking vs non-blocking
The need for an overview of blocking vs non-blocking was
identified in the docs WG Q1 roadmap. As there are several
topics also pending creation, this one tries to hit the correct
level of detail based on completion of the others. One
which is referenced is
https://github.com/nodejs/node/pull/4936/files and URLs
within this PR need to change based on where that will land
on the node website.
PR-URL: https://github.com/nodejs/node/pull/5326
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Kári Tristan Helgason [Mon, 15 Feb 2016 22:55:35 +0000 (22:55 +0000)]
test: eval a strict function
PR-URL: https://github.com/nodejs/node/pull/5250
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Shigeki Ohtsu [Tue, 10 Feb 2015 00:27:52 +0000 (09:27 +0900)]
tools: fix gyp to work on MacOSX without XCode
This issue has already submitted to the upstream in
https://code.google.com/p/gyp/issues/detail?id=477
Use this commit until the upstream is to be fixed.
PR-URL: https://github.com/iojs/io.js/pull/1325
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Imran Iqbal [Mon, 19 Oct 2015 19:57:06 +0000 (15:57 -0400)]
tools: update gyp to b3cef02
Includes two patches for AIX. Adds support for both 32-bit and 64-bit
files[0] and uses -RPf for cp instead of -af (which is unsupported)[1]
[0] https://codereview.chromium.org/
1319663007
[1] https://codereview.chromium.org/
1368133002
PR-URL: https://github.com/nodejs/node/pull/3487
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
cjihrig [Wed, 2 Mar 2016 17:41:46 +0000 (12:41 -0500)]
test: bug repro for vm function redefinition
This commit adds a failing test case for the vm module.
Currently, if runInContext() defines a function, and a later call
to runInContext() redefines the same function, the original
function is not overwritten.
Refs: https://github.com/nodejs/node/issues/548
Backport-URL: https://github.com/nodejs/node/pull/5785
PR-URL: https://github.com/nodejs/node/pull/5528
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
cjihrig [Wed, 2 Mar 2016 17:12:47 +0000 (12:12 -0500)]
tools: support testing known issues
This commit adds a known_issues directory to the test directory
for scripts that reproduce known bugs. Since these scripts are
expected to fail, it also adds a --expect-fail flag to test.py
which reports tests as successful when they fail.
Refs: https://github.com/nodejs/testing/issues/18
Backport-URL: https://github.com/nodejs/node/pull/5785
PR-URL: https://github.com/nodejs/node/pull/5528
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Conflicts:
tools/test.py
Rich Trott [Thu, 17 Mar 2016 23:57:27 +0000 (16:57 -0700)]
tools: enable linting for benchmarks
PR-URL: https://github.com/nodejs/node/pull/5773
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Rich Trott [Thu, 17 Mar 2016 23:55:46 +0000 (16:55 -0700)]
benchmark: fix linting issues
PR-URL: https://github.com/nodejs/node/pull/5773
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Rich Trott [Sat, 20 Feb 2016 01:03:16 +0000 (17:03 -0800)]
benchmark: use strict mode
Apply strict mode to benchmark code.
PR-URL: https://github.com/nodejs/node/pull/5773
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Rich Trott [Sun, 28 Feb 2016 05:56:18 +0000 (21:56 -0800)]
benchmark: refactor to eliminate redeclared vars
In order to comply with linting rules used in the rest of the code base,
eliminate redeclared variables. A conservative approach is used so as to
avoid unintentional performance issues (for example, as might be seen in
some situations when using `let` instead of `var`).
PR-URL: https://github.com/nodejs/node/pull/5773
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Rich Trott [Thu, 25 Feb 2016 06:30:10 +0000 (22:30 -0800)]
tools,benchmark: increase lint compliance
In the hopes of soon having the benchmark code linted, this change
groups all the likely non-controversial lint-compliance changes such as
indentation, semi-colon usage, and single-vs.-double quotation marks.
Other lint rules may have subtle performance implications in the V8
currently shipped with Node.js. Those changes will require more careful
review and will be in a separate change.
PR-URL: https://github.com/nodejs/node/pull/5773
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Rich Trott [Wed, 2 Mar 2016 21:38:23 +0000 (13:38 -0800)]
benchmark: fix lint errors
PR-URL: https://github.com/nodejs/node/pull/5773
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Rich Trott [Fri, 11 Mar 2016 23:57:43 +0000 (15:57 -0800)]
doc: fix invalid path doc comments
The format of certain code comments in the `path` documentation results
in the code blocks being invalid. I also find it confusing at least as
formatted on the website. This change is intended to improve those
comments.
PR-URL: https://github.com/nodejs/node/pull/5797
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Jeremiah Senkpiel [Wed, 9 Mar 2016 16:43:53 +0000 (11:43 -0500)]
doc: update release tweet template
PR-URL: https://github.com/nodejs/node/pull/5628
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Benjamin Gruenbaum [Sun, 13 Mar 2016 08:32:01 +0000 (10:32 +0200)]
doc: fix typo in child_process docs
Fixes a typo in the child process docs.
Fixes: https://github.com/nodejs/nodejs.org/issues/573
PR-URL: https://github.com/nodejs/node/pull/5681
Reviewed-By: thefourtheye <thechargingvolcano@gmail.com>
Wyatt Preul [Fri, 11 Mar 2016 21:03:25 +0000 (15:03 -0600)]
collaborator_guide: clarify commit message rules
Italicize the full URL being required in metadata.
PR-URL: https://github.com/nodejs/node/pull/5661
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James Snell <jasnell@gmail.com>
Claudio Rodriguez [Sun, 13 Mar 2016 06:57:03 +0000 (03:57 -0300)]
doc: update fansworld-claudio username on README
Updating collaborator username: fansworld-claudio
changed to claudiorodriguez
PR-URL: https://github.com/nodejs/node/pull/5680
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Rod Vagg [Wed, 24 Feb 2016 02:51:50 +0000 (13:51 +1100)]
build: update Node.js logo on OSX installer
PR-URL: https://github.com/nodejs/node/pull/5401
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: kahwee
Reviewed-By: fhemberger
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Felix Böhm [Wed, 16 Mar 2016 10:27:32 +0000 (11:27 +0100)]
doc: fix return value of write methods
Fixes: https:github.com/nodejs/node/issues/5682
PR-URL: https://github.com/nodejs/node/pull/5736
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Mithun Patel [Tue, 15 Mar 2016 16:12:41 +0000 (11:12 -0500)]
doc: Add note about use of JSON.stringify()
process.send and child.send use JSON.stringify to serialize
the message.
Fixes: https://github.com/nodejs/node/issues/5453
PR-URL: https://github.com/nodejs/node/pull/5723
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Mithun Patel [Tue, 15 Mar 2016 15:11:26 +0000 (10:11 -0500)]
docs: fix man pages link if tok type is code
Do not call the linkManPages if the tok type is code
Fixes: https://github.com/nodejs/node/issues/5686
PR-URL: https://github.com/nodejs/node/pull/5721
Reviewed-By: James M Snell <jasnell@gmail.com>
Ben Noordhuis [Wed, 2 Mar 2016 13:04:42 +0000 (14:04 +0100)]
tls: fix assert in context._external accessor
* Restrict the receiver to instances of the FunctionTemplate.
* Use `args.This()` instead of `args.Holder()`.
Fixes: https://github.com/nodejs/node/issues/3682
PR-URL: https://github.com/nodejs/node/pull/5521
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Rich Trott [Sun, 13 Mar 2016 20:40:25 +0000 (13:40 -0700)]
doc: explain path.format() algorithm
PR-URL: https://github.com/nodejs/node/pull/5688
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: https://github.com/nodejs/node/issues/2305
Kirill Fomichev [Sun, 13 Mar 2016 16:16:15 +0000 (19:16 +0300)]
doc: clarify type of first argument in zlib
The current documentation for Convenience Methods specifies that
the first argument can be either
`string or buffer`, `string` or `raw Buffer`.
This commit replaces all these instances with `Buffer or string`.
PR-URL: https://github.com/nodejs/node/pull/5685
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Daijiro Wachi [Sun, 13 Mar 2016 21:37:54 +0000 (22:37 +0100)]
doc: fix typo in api/addons
PR-URL: https://github.com/nodejs/node/pull/5678
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Stefano Vozza [Sat, 12 Mar 2016 18:10:31 +0000 (18:10 +0000)]
doc: remove non-standard use of hyphens
Identifies the non-idiomatic usages of the '-' character
and either removes them or replaces them with colons.
Fixes: https://github.com/nodejs/node/issues/5672
R-URL: https://github.com/nodejs/node/pull/5677
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Claudio Rodriguez [Fri, 11 Mar 2016 21:50:47 +0000 (18:50 -0300)]
doc: add fansworld-claudio to collaborators
PR-URL: https://github.com/nodejs/node/pull/5668
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Glen Keane [Fri, 11 Mar 2016 21:51:59 +0000 (21:51 +0000)]
doc: add thekemkid to collaborators
PR-URL: https://github.com/nodejs/node/pull/5667
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Andreas Madsen [Fri, 11 Mar 2016 21:49:09 +0000 (22:49 +0100)]
doc: add AndreasMadsen to collaborators
PR-URL: https://github.com/nodejs/node/pull/5666
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Glen Keane <glenkeane.94@gmail.com>
Jeremy Whitlock [Fri, 11 Mar 2016 21:48:48 +0000 (14:48 -0700)]
doc: add whitlockjc to collaborators
PR-URL: https://github.com/nodejs/node/pull/5665
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Benjamin Gruenbaum [Fri, 11 Mar 2016 21:46:24 +0000 (23:46 +0200)]
doc: add benjamingr to collaborator list
Add benjamingr to collaborator list.
Related https://github.com/nodejs/node/issues/5064
PR-URL: https://github.com/nodejs/node/pull/5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Phillip Johnsen [Fri, 11 Mar 2016 21:46:26 +0000 (22:46 +0100)]
doc: add phillipj to collaborators
PR-URL: https://github.com/nodejs/node/pull/5663
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Matt Loring [Fri, 11 Mar 2016 21:36:21 +0000 (13:36 -0800)]
doc: add mattloring to collaborators
PR-URL: https://github.com/nodejs/node/pull/5662
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Robert C Jensen [Fri, 11 Mar 2016 02:33:40 +0000 (21:33 -0500)]
doc: include typo in 'unhandledRejection' example
Reintroduces an intentional typo in a process doc example.
Fixes: https://github.com/nodejs/node/issues/5644
PR-URL: https://github.com/nodejs/node/pull/5654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Steve Mao [Thu, 10 Mar 2016 10:40:19 +0000 (21:40 +1100)]
doc: fix markdown links
Fixes: https://github.com/nodejs/node/issues/5322
PR-URL: https://github.com/nodejs/node/pull/5641
Reviewed-By: Robert Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Johan Bergström [Wed, 9 Mar 2016 23:41:52 +0000 (10:41 +1100)]
doc: move build instructions to a new document
This makes README.md easier to consume and likely less
confusing for people that get it as part of a binary download.
PR-URL: https://github.com/nodejs/node/pull/5634
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Myles Borins [Wed, 9 Mar 2016 18:05:24 +0000 (10:05 -0800)]
docs: update link to iojs+release ci job
We recently sandboxed the release CI jobs to their own Jenkins instance
This commit updates the links found in `doc/releases.md` to point
people in the right direction.
PR-URL: https://github.com/nodejs/node/pull/5632
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
axvm [Wed, 9 Mar 2016 11:09:24 +0000 (14:09 +0300)]
doc: fix dns.resolveCname description typo
PR-URL: https://github.com/nodejs/node/pull/5622
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sakthipriyan Vairamani [Sun, 6 Mar 2016 14:05:42 +0000 (19:35 +0530)]
tools: reduce verbosity of cpplint
Every time `make test` is run, the cpplint prints the file it
successfully linted. None of the other linters in the project does
that. This patch simply removes the "Done processing" message from the
cpplint.
PR-URL: https://github.com/nodejs/node/pull/5578
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Michaël Zasso [Fri, 4 Mar 2016 08:53:31 +0000 (09:53 +0100)]
doc: fix typo in fs.symlink
PR-URL: https://github.com/nodejs/node/pull/5560
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Michael Barrett [Thu, 3 Mar 2016 23:01:01 +0000 (23:01 +0000)]
doc: document directories in test directory
PR-URL: https://github.com/nodejs/node/pull/5557
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Stefan Budeanu [Thu, 3 Mar 2016 21:38:24 +0000 (16:38 -0500)]
build: correctly detect clang version
Use the "Apple LLVM" version number since the banner has changed in
newer versions of Mac OS X, resulting in the obsolete assembler path
being used to compile OpenSSL.
PR-URL: https://github.com/nodejs/node/pull/5553
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Rich Trott [Thu, 3 Mar 2016 21:45:08 +0000 (13:45 -0800)]
tools: enable no-self-assign ESLint rule
Enabled no-self-assign rule in ESLint.
This required one change in a benchmark file. Changed a loop (that is
outside of the benchmark itself, so performance is not critical) from a
for loop that repeats a string to use String.prototype.repeat() instead.
While at it, took the opportunity to const-ify the benchmark file.
Also moved the "Strict" section in the .eslintrc to match where it is in
the ESLint documentation. Updated the link for Strict rules to point to
the ESLint website rather than the GitHub-hosted code.
PR-URL: https://github.com/nodejs/node/pull/5552
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
silverwind [Thu, 3 Mar 2016 17:50:30 +0000 (18:50 +0100)]
doc: update link green to match homepage
Also fixed a minor color issue with :focus on the title.
PR-URL: https://github.com/nodejs/node/pull/5548
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Wyatt Preul [Thu, 3 Mar 2016 16:10:46 +0000 (10:10 -0600)]
test: check memoryUsage properties The properties on memoryUsage were not checked before, this commit checks them.
PR-URL: #5546
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Rich Trott [Wed, 2 Mar 2016 20:48:53 +0000 (12:48 -0800)]
test: remove broken debugger scenarios
`test-debug-break-on-uncaught` was hanging on the domain and parse error
scenarios. These tests are not run in CI and may have been broken
for a very long time.
Refs: https://github.com/nodejs/node/issues/3156
Refs: https://github.com/nodejs/node/commit/
c16963b9
PR-URL: https://github.com/nodejs/node/pull/5532
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Robert Jefe Lindstaedt [Wed, 2 Mar 2016 19:42:42 +0000 (20:42 +0100)]
build: update Node.js logo on Win installer
also change stripe color to RGB 68 136 62
PR-URL: https://github.com/nodejs/node/pull/5531
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
firedfox [Wed, 2 Mar 2016 03:55:53 +0000 (11:55 +0800)]
build: remove --quiet from eslint invocation
All eslint rules are configured to report as errors. Remove useless
--quiet flag from eslint invocation in Makefile and vcbuild.bat.
PR-URL: https://github.com/nodejs/node/pull/5519
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Rich Trott [Tue, 1 Mar 2016 21:27:19 +0000 (13:27 -0800)]
tools: enable no-extra-parens in ESLint
Enable `no-extra-parens`. This rule restricts the use of parentheses to
only where they are necessary. It is set to be restricted to report only
function expressions.
PR-URL: https://github.com/nodejs/node/pull/5512
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Kári Tristan Helgason [Sun, 28 Feb 2016 21:28:17 +0000 (21:28 +0000)]
doc: add clarification on birthtime in fs stat
Clarifies the possibility of birthtime in the fs stat
object being greater than atime or mtime when not available
in the filesystem (see issue for further info).
Fixes: https://github.com/nodejs/node/issues/2222
PR-URL: https://github.com/nodejs/node/pull/5479
Reviewed-By: James M Snell <jasnell@gmail.com>
Evan Lucas [Sun, 28 Feb 2016 12:23:20 +0000 (06:23 -0600)]
doc: fix typo in child_process documentation
TSCP should be TCP
PR-URL: https://github.com/nodejs/node/pull/5474
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ronkorving [Sun, 28 Feb 2016 07:46:23 +0000 (16:46 +0900)]
doc: update NAN urls in ROADMAP.md and doc/releases.md
PR-URL: https://github.com/nodejs/node/pull/5472
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Rich Trott [Sun, 28 Feb 2016 06:18:22 +0000 (22:18 -0800)]
test: apply Linux workaround to Linux only
Do not try Ubuntu/SUSE/Debian-specific hostnames for IPv6 localhost
unless we are on Linux.
Fixes: https://github.com/nodejs/node/issues/4546
PR-URL: https://github.com/nodejs/node/pull/5471
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Rich Trott [Sun, 28 Feb 2016 00:02:29 +0000 (16:02 -0800)]
test: increase timeout for test-tls-fast-writing
Increase timeout for test from 500ms to 1000ms so busy slow machines
don't produce false positives.
Fixes: https://github.com/nodejs/node/issues/4964
PR-URL: https://github.com/nodejs/node/pull/5466
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Rich Trott [Fri, 26 Feb 2016 22:20:43 +0000 (14:20 -0800)]
doc: add Testing WG
Add the proposed Testing WG. WORKING_GROUPS.md indicates that opening
a pull request to that file is the way to request that a charter be
ratified by the TC. So, that's what this is.
The charter document is currently:
https://github.com/nodejs/testing/blob/master/Charter.md
PR-URL: https://github.com/nodejs/node/pull/5461
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Brian White [Fri, 26 Feb 2016 21:56:41 +0000 (16:56 -0500)]
doc: fix crypto function indentation level
PR-URL: https://github.com/nodejs/node/pull/5460
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Rich Trott [Fri, 26 Feb 2016 17:29:19 +0000 (09:29 -0800)]
test: retry on known SmartOS bug
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.
`test-http-regr-gh-2928` is one such test.
Fixes: https://github.com/nodejs/node/issues/5445
Refs: https://github.com/nodejs/node/pull/3941
PR-URL: https://github.com/nodejs/node/pull/5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Rich Trott [Fri, 26 Feb 2016 00:26:39 +0000 (16:26 -0800)]
benchmark: add benchmark for buf.compare()
There is a benchmark for the class method `Buffer.compare()` but not for
the instance method `buf.compare()`. This adds that benchmark.
I used this to confirm a performance regression in an implementation I
was considering. While the implementation was a bust, it does seem like
the benchmark is worthwhile.
The benchmark is nearly identical to the existing `Buffer.compare()`
benchmark except, of course, that it calls `buf.compare()` instead.
PR-URL: https://github.com/nodejs/node/pull/5441
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Santiago Gimeno [Wed, 24 Feb 2016 22:47:47 +0000 (23:47 +0100)]
test: fix flaky child-process-fork-regr-gh-2847
The test is still failing sometimes because when trying to establish the
second connection, the server is already closed. Bring back the code
that handled this case and was removed in the last refactoring of the
test. Also ignore the errors that might happen when sending the second
handle to the worker because it may already have exited.
PR-URL: https://github.com/nodejs/node/pull/5422
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fedor Indutny [Tue, 23 Feb 2016 20:53:45 +0000 (15:53 -0500)]
crypto: PBKDF2 works with `int` not `ssize_t`
Change types of all PBKDF2 params to `int` as they are `int` in `evp.h`.
Check that `raw_keylen` fits into `int` before passing it to OpenSSL.
Fix: #5396
PR-URL: https://github.com/nodejs/node/pull/5397
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
nettofarah [Tue, 23 Feb 2016 07:47:22 +0000 (23:47 -0800)]
url: group slashed protocols by protocol name
Reorder slashed protocols so they are grouped by protocol name. This is
done so it doesn't look like we're duplicating protocol names at the
bottom of the list.
PR-URL: https://github.com/nodejs/node/pull/5380
Reviewed-By: Evan Lucas <evanlucas@me.com>
Rich Trott [Tue, 23 Feb 2016 06:14:32 +0000 (22:14 -0800)]
test: fix test-timers.reliability on OS X
Fixes: https://github.com/nodejs/node/issues/4404
PR-URL: https://github.com/nodejs/node/pull/5379
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Rich Trott [Mon, 22 Feb 2016 22:24:38 +0000 (14:24 -0800)]
tools: apply custom buffer lint rule to /lib only
The lint rule is there to avoid a circular-dependency issue that only
applies to `/lib`. In preparation for linting `/benchmark`, apply that
rule to `/lib` only to avoid churn in `/benchmark`.
Refs: https://github.com/nodejs/node/issues/3983#issuecomment-
158956113
PR-URL: https://github.com/nodejs/node/pull/5371
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Alexander Makarenko [Fri, 19 Feb 2016 13:54:37 +0000 (16:54 +0300)]
doc: fix links in tls, cluster docs
Fix missing links described in #5322.
PR-URL: https://github.com/nodejs/node/pull/5364
Reviewed-By: Roman Reiss <me@silverwind.io>
Evan Lucas [Mon, 22 Feb 2016 07:28:55 +0000 (01:28 -0600)]
doc: fix relative links in net docs
They were not being processed as relative links.
PR-URL: https://github.com/nodejs/node/pull/5358
Reviewed-By: Roman Reiss <me@silverwind.io>
Rich Trott [Mon, 22 Feb 2016 05:19:32 +0000 (21:19 -0800)]
tools: enable additional lint rules
Enable additional likely-uncontroversial lint rules:
* `comma-dangle` set to prohibit dangling commas on objects and arrays
that are defined on a single line. Multi-line definitions can use or
omit a trailing comma.
* `no-unused-labels` Prohibits defining a label that is not used.
* `no-path-concat` Prohibits string-concatenation using i`__dirname` and
`__filename`. Use `path.join()`, `path.resolve()`, or template strings
instead.
* `no-new-symbol` disallow use of `new` operator with `Symbol` object.
Violating this rule would result in a `TypeError` at runtime.`
PR-URL: https://github.com/nodejs/node/pull/5357
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Jeremiah Senkpiel [Sun, 21 Feb 2016 16:05:55 +0000 (11:05 -0500)]
test: increase timeouts on some unref timers tests
Fix: https://github.com/nodejs/node/issues/5351
Refs: https://github.com/nodejs/node/pull/4561
PR-URL: https://github.com/nodejs/node/pull/5352
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Trevor Norris [Wed, 2 Mar 2016 22:23:55 +0000 (15:23 -0700)]
test: prevent flakey test on pi2
Looping rapidly and making new connections causes problems on pi2.
Instead create a new connection when an old connection has already been
made. Running a stress test of 600 times and they all passed.
Fixes: https://github.com/nodejs/node/issues/5302
PR-URL: https://github.com/nodejs/node/pull/5537
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Rich Trott [Sun, 21 Feb 2016 03:30:21 +0000 (19:30 -0800)]
test: mitigate flaky test-http-agent
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.
Fixes: https://github.com/nodejs/node/issues/5184
PR-URL: https://github.com/nodejs/node/pull/5346
Reviewed-By: James M Snell <jasnell@gmail.com>
Rich Trott [Fri, 26 Feb 2016 21:28:25 +0000 (13:28 -0800)]
test: remove flaky designation from fixed tests
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.
Refs: https://github.com/nodejs/node/issues/2510
Refs: https://github.com/nodejs/node/issues/2660
PR-URL: https://github.com/nodejs/node/pull/5459
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Santiago Gimeno [Sat, 20 Feb 2016 16:36:35 +0000 (17:36 +0100)]
test: refactor test-dgram-udp4
This test was sometimes timing out in `OS X`. Remove the timeout and
clean up the code.
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/5339
Rich Trott [Fri, 19 Feb 2016 07:01:06 +0000 (23:01 -0800)]
tools: add Node.js-specific ESLint rules
Add these rules:
* no-restricted-modules: See
http://eslint.org/docs/rules/no-restricted-modules. It has been
configured to prohibit the use of the deprecated `sys` and `_linklist`
modules.
* no-new-require: See http://eslint.org/docs/rules/no-new-require
* no-mixed-requires: http://eslint.org/docs/rules/no-mixed-requires
PR-URL: https://github.com/nodejs/node/pull/5320
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Rich Trott [Fri, 19 Feb 2016 07:12:51 +0000 (23:12 -0800)]
debugger: remove unneeded callback check
In `lib/_debugger.js`, remove check for `cb` in line 571 as it is
guaranteed to be truthy due to line 521.
PR-URL: https://github.com/nodejs/node/pull/5319
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Marc Cuva [Thu, 18 Feb 2016 19:12:56 +0000 (11:12 -0800)]
doc: fix typo in pbkdf2Sync code sample
Function name in code sample had the wrong capitalization.
PR-URL: https://github.com/nodejs/node/pull/5306
Reviewed-By: Roman Reiss <me@silverwind.io>
Rafael Cepeda [Thu, 18 Feb 2016 17:56:05 +0000 (11:56 -0600)]
doc: add missing property in cluster example
`Cluster.setupMaster(options)` Options object was missing an `args`
property on the example.
PR-URL: https://github.com/nodejs/node/pull/5305
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Jackson Tian [Thu, 18 Feb 2016 09:15:28 +0000 (17:15 +0800)]
doc: improve httpVersionMajor / httpVersionMajor
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.
PR-URL: https://github.com/nodejs/node/pull/5296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Michael Dawson [Wed, 17 Feb 2016 22:18:00 +0000 (17:18 -0500)]
deps: cherry-pick 2e4da65 from v8's 4.8 upstream
Float v8 patch, which has been committed to v8 master and
backported to 4.8 and 4.9 in google repos, onto 4.8 v8 in
deps to resolve https://github.com/nodejs/node/issues/5089
Original title/commit from google repos for 4.8 is:
PPC: [turbofan] Support for CPU models lacking isel.
https://github.com/v8/v8/commit/
2e4da65332753a4fed679be81634b7685616b1fd
PR-URL: https://github.com/nodejs/node/pull/5293
Fixes: https://github.com/nodejs/node/issues/5089
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
James M Snell [Wed, 17 Feb 2016 19:10:46 +0000 (11:10 -0800)]
doc: improve unhandledException doc copy
Rework the doc a bit to tighten it up, including removing the
use of `you`
Fix some line wrapping issues.
PR-URL: https://github.com/nodejs/node/pull/5287
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
...
Chinedu Francis Nwafili [Wed, 17 Feb 2016 13:11:53 +0000 (08:11 -0500)]
doc: fix buf.readInt16LE output
Previous example didn't account for the 1 byte offset
PR-URL: https://github.com/nodejs/node/pull/5282
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>