summary |
shortlog | log |
commit |
commitdiff |
tree
first ⋅ prev ⋅ next
hj kim [Tue, 26 May 2020 06:35:37 +0000 (15:35 +0900)]
Version up
Change-Id: I8c054dadf932acfaa4347d972f36bf85c55f2792
hj kim [Mon, 1 Jun 2020 07:01:11 +0000 (16:01 +0900)]
Fix Wrong return values
1. return METADATA_EDITOR_ERROR_INVALID_PARAMETER
if there is no tag when get or remove picture. because it means, picture index is wrong.
2. return METADATA_EDITOR_ERROR_NONE
if there is no tag when get metadata.
Change-Id: I831005c8b1116c421d03b7618b6503192bff3af2
hj kim [Mon, 1 Jun 2020 06:36:28 +0000 (15:36 +0900)]
Check file validity before using it
Change-Id: Id39a29a9a7042af3bb2e23c3cd10edad4d022ff0
hj kim [Fri, 29 May 2020 05:14:32 +0000 (14:14 +0900)]
Check dynamic_cast result before using it
Change-Id: I6b32ee6ce5e9202194dfe47add16a493ee442fa3
hj kim [Tue, 26 May 2020 08:02:40 +0000 (17:02 +0900)]
Unify Getting and Setting metadata related code for MP3 and Wav
MP3 and Wav could have metadata in ID3tag. but Wav only can save metadata in ID3v2.
Change-Id: I4da4d7cec1a94222d2bcf11f3d688e8c4a32ff79
hj kim [Tue, 26 May 2020 08:22:51 +0000 (17:22 +0900)]
Unify Code for getting ID3tag to __ID3_getTwixFrameByName()
Change-Id: I3dde3b8339f68e74ae5e69ca204497b3e0d6ac88
hj kim [Mon, 25 May 2020 08:57:11 +0000 (17:57 +0900)]
Improve __ID3_setTwixFrameByName() API
Change-Id: Ib82b0d175e528718ec89e840f546937c1bd3a55a
hj kim [Tue, 26 May 2020 07:34:27 +0000 (16:34 +0900)]
Add macros for debugging and add debug logs
Change-Id: I5dcd0b80f26b57d4a297898a413be863daf8062f
hj kim [Mon, 25 May 2020 07:35:15 +0000 (16:35 +0900)]
Revise the internal function name __ID3_setFrameByName() to __ID3v2_setFrameByName()
because __ID3_setFrameByName() is used only for ID3v2 tag.
Change-Id: I4bf870b5cdd1d9713101d594f7ff126e2ce03878
hj kim [Mon, 25 May 2020 07:16:35 +0000 (16:16 +0900)]
Bug fix of getting number of picture in tag
if there is no tag, number should be "0".
Change-Id: I6b048dac7ad51a1eba273de62593c0851fcbcf70
hj kim [Mon, 25 May 2020 06:54:10 +0000 (15:54 +0900)]
Modify input parameter
Use proper MP4:Tag instead of metadata_editor structure when get and set metadata.
Change-Id: I2c255991ce19f65606580507c4aa188e9b119f22
hj kim [Mon, 25 May 2020 06:24:08 +0000 (15:24 +0900)]
Remove unnecessary parameter
Change-Id: Ie1d7fc71dbb4fee4b49e0c0b0e0ac0043aa00f1e
hj kim [Thu, 21 May 2020 04:01:32 +0000 (13:01 +0900)]
Bug fix of MP4 metadata when using auto keyword
Change-Id: I9aac227c38061475c2ed07e15c073682428239f4
hj kim [Wed, 20 May 2020 09:45:16 +0000 (18:45 +0900)]
check NULL before getting metadata
toString() returns "", when String is NULL
Change-Id: I8a8b1da78a4747725bdf6bc8a59e6b2277bd084e
hj kim [Wed, 20 May 2020 08:00:33 +0000 (17:00 +0900)]
Fix invalid return of metadata_editor_append_picture() and adds debug logs.
metadata_editor_set_path() can return METADATA_EDITOR_ERROR_NOT_SUPPORTED for not supported file,
but other APIs should return METADATA_EDITOR_ERROR_INVALID_PARAMETER
Change-Id: I13abc82156a0c0b98867ac9078563bc18198cbea
hj kim [Wed, 20 May 2020 07:55:11 +0000 (16:55 +0900)]
Update API description
Change-Id: I2758c2d122fdc3c0f271c8bce1e1bd47ab5f6b22
jiyong.min [Thu, 14 May 2020 04:17:12 +0000 (13:17 +0900)]
Use auto keyword
Change-Id: Ieb7eb0f9e9fc80e5b37aae469a17d5822317450a
hj kim [Wed, 13 May 2020 07:16:40 +0000 (16:16 +0900)]
Improve __metadata_editor_get_picture_info() and User proper type for picture
Change-Id: Id81a6f64b2361d7c97b5fe95f02271b5e16af115
jiyong.min [Tue, 12 May 2020 23:34:34 +0000 (08:34 +0900)]
Use namespace TagLib
Change-Id: I2bcd614a3aabe1c10766934658d10b0ea8936fa4
hj kim [Tue, 12 May 2020 11:16:09 +0000 (20:16 +0900)]
Apply tizen coding rule
Change-Id: Ib5238374d93a580bc9b7cd9cf4d8df5b3a1afc5c
hj kim [Wed, 13 May 2020 06:01:22 +0000 (15:01 +0900)]
Bug fix of String Convert
String::toCString(true) convert code to UTF8. and String::toCString(false) convert to Latin.
We need UTF8 so "true" should be set to toCString().
Change-Id: Iae6071f4288e90de2068e026d3774e08ecda4518
hj kim [Wed, 13 May 2020 05:25:43 +0000 (14:25 +0900)]
Bug fix and improve __ID3_getTwixFrameByName()
It's not an error situation even though there is no tag to find
String::toCString(true) convert code to UTF8. and String::toCString(false) convert to Latin.
We need UTF8 so "true" should be set to toCString().
Change-Id: Ifa7d94946bf5e6eee89cb87545a4b924db9be16d
hj kim [Tue, 12 May 2020 10:10:59 +0000 (19:10 +0900)]
Use auto keyword
Change-Id: I9d87e1c47f93554cf79867044f01260a7546e682
hj kim [Mon, 11 May 2020 06:57:33 +0000 (15:57 +0900)]
Bug fix of getting number of pictures. it should return '0' if there is no picture.
Change-Id: Ia43d59c27ccc176edba963f31f0940fba7ffb6b7
hj kim [Fri, 8 May 2020 06:28:47 +0000 (15:28 +0900)]
Improve metadata_editor_remove_picture() API
Change-Id: Ib957753653b501d8c6b543a7e789b523db199e7a
hj kim [Thu, 7 May 2020 09:38:27 +0000 (18:38 +0900)]
Improve metadata_editor_append_picture() API
Change-Id: I030ebb2539b49eb9a1748cd9e529dd967432d45f
hj kim [Thu, 7 May 2020 08:27:48 +0000 (17:27 +0900)]
Use defines for mime
Change-Id: I5de8de8a0f6325dab8850bd25c8ac99be79c56e9
hj kim [Thu, 7 May 2020 08:15:03 +0000 (17:15 +0900)]
Use auto keyword and remove METADATA_EDITOR_ERROR_OUT_OF_MEMORY for "new" keyword
Change-Id: I595c96bade904e724dc1674fcae7a5f6ac15c459
hj kim [Wed, 6 May 2020 09:05:19 +0000 (18:05 +0900)]
Improve metadata_editor_get_picture() API
Change-Id: I05d3d5e1d8713efa6bd286b73f1489e25df7ca35
hj kim [Wed, 6 May 2020 07:47:24 +0000 (16:47 +0900)]
Improve metadata_editor_create() and Bug fix of metadata_editor_destroy()
filetype can be METADATA_EDITOR_FORMAT_NOTYPE if user only create handle with metadata_editor_create() without setting path.
Change-Id: Ie4d3784da64274d1b5ba127073356f492c761b16
hj kim [Wed, 6 May 2020 07:42:22 +0000 (16:42 +0900)]
Apply tizen coding rule
Change-Id: I101a499fc99fea4ba36946e9327d9eebba22a4d2
hj kim [Wed, 6 May 2020 08:17:40 +0000 (17:17 +0900)]
Improve metadata_editor_update_metadata() API
Change-Id: I524618dd0f78bdd05e902d437419c87136925e6e
hj kim [Tue, 28 Apr 2020 08:50:25 +0000 (17:50 +0900)]
Improve __metadata_editor_get_picture_type() API
Change-Id: Ib3fb371c5fd914ca94051f8151bcf4ec035bdff3
hj kim [Tue, 28 Apr 2020 23:32:53 +0000 (08:32 +0900)]
remove 'isReadOnly'. readOnly() of File can replace it
Change-Id: I467df758aa84a3cbf47aaefcc27ac79f5370be0a
hj kim [Tue, 28 Apr 2020 23:25:38 +0000 (08:25 +0900)]
Remove 'isOpen'. 'file' in metadata_editor_s can replace it
Change-Id: I027aa484b8173ab26a3e38a4b1986f4d04bc8cca
hj kim [Thu, 23 Apr 2020 08:38:44 +0000 (17:38 +0900)]
Improve metadata_editor_set_path() API
Change-Id: I969f3da6669f7c9c62db44af9be9321f97581a67
hj kim [Thu, 23 Apr 2020 09:38:37 +0000 (18:38 +0900)]
Improve metadata_editor_get_picture() API
Change-Id: Ib88f27133bd411181698150036737cfb52f37808
hj kim [Mon, 16 Sep 2019 02:22:35 +0000 (11:22 +0900)]
Update code for checking input parameter
Change-Id: I86146cc21aabea5c48b9dc26cac0bbb6ce49338d
hj kim [Tue, 27 Aug 2019 02:01:07 +0000 (11:01 +0900)]
Update code to reduce Cyclomatic Complexity and DC
Change-Id: I2d9ea5df5687c41329981c77df0aa6be0c0592c5
Minje Ahn [Tue, 2 Jul 2019 01:45:02 +0000 (10:45 +0900)]
Remove check for gcov
Change-Id: I99fcdd951a0afc327f39606167262e563c20c28c
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 2 Jul 2019 00:27:44 +0000 (09:27 +0900)]
Fix build error
Change-Id: I7e5f0b6e080785c32c2dda1bf440ced048aaab3e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Mon, 1 Jul 2019 23:29:04 +0000 (08:29 +0900)]
Add for line coverage
Change-Id: Ief38a15eb8a0d5ce606b11fc9e5c22353ff2aaa1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
jiyong.min [Thu, 31 Jan 2019 23:08:42 +0000 (08:08 +0900)]
Change the value for checking fread() to the number of items
Change-Id: I95149c62b7be1b73990830bb0ffa7f10404e16de
jiyong.min [Tue, 29 Jan 2019 00:28:04 +0000 (09:28 +0900)]
Add to check the return of fread()
- If an error occurs, the return value is a short item count.
Change-Id: I3acb7494ff53f56243ae239b6c1371eb5537478f
jiyong.min [Thu, 10 Jan 2019 04:24:30 +0000 (13:24 +0900)]
Fix the log position to avoid errno change.
Change-Id: Ia7d81de1f5fa4aa766e3d700497d2cadc314456e
hj kim [Wed, 31 Oct 2018 06:09:54 +0000 (15:09 +0900)]
Fix wrong PC_REQUIRED
Change-Id: I7314748e4903320bdaa95a15f730223647fd4e15
SeokHoon Lee [Fri, 14 Sep 2018 07:13:56 +0000 (16:13 +0900)]
Add gcov environment
Signed-off-by: SeokHoon Lee <andy.shlee@samsung.com>
Change-Id: Ie6879f3d2a8baef1b61e7f53e6acf2030b4ffaf5
hj kim [Thu, 21 Jun 2018 05:04:07 +0000 (14:04 +0900)]
Just update api description
Change-Id: If122aba54eec100152d2625d008398102a324a5e
hj kim [Fri, 23 Mar 2018 00:29:37 +0000 (09:29 +0900)]
Fix Coverity issues
Change-Id: I71fb5886972dae84270b701d35eca0176175fb86
Minje Ahn [Mon, 5 Mar 2018 05:10:07 +0000 (14:10 +0900)]
Fix typo
Change-Id: If06f721dc2c9e13f04cd8e4944b43b72d193d6df
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Mon, 12 Feb 2018 02:31:48 +0000 (11:31 +0900)]
Fix typo
Change-Id: I309224042e23271c4ce2142b7f5ec5135219fde5
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
hj kim [Thu, 25 Jan 2018 00:19:30 +0000 (09:19 +0900)]
Fix Doxygen mistakes
Change-Id: I2e89f110ab047dd34e1c1ecbd6e6b6b7cb853fad
hj kim [Wed, 24 Jan 2018 05:17:03 +0000 (14:17 +0900)]
Fix Doxygen mistakes
Change-Id: I5338485c225160dc101280459f4dbb01a631c0b1
Minje Ahn [Fri, 29 Sep 2017 03:06:35 +0000 (12:06 +0900)]
Reinforce coverage
Change-Id: I387ff9ec8c67a0cfc8ec787a81d42a80b33a4168
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Jiyong Min [Tue, 12 Sep 2017 04:59:33 +0000 (04:59 +0000)]
Merge "Apply tizen coding rule" into tizen
Jiyong Min [Tue, 12 Sep 2017 04:25:08 +0000 (13:25 +0900)]
Apply tizen coding rule
Change-Id: I808f35cc9231b7fe41b16f3c46d1cee1a6a48148
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
Haejeong Kim [Wed, 6 Sep 2017 01:22:41 +0000 (10:22 +0900)]
Remove \n in dlog msg
Change-Id: Ibef41d8fe675c1e9feac348eb6dafbe9b34acc44
Minje Ahn [Tue, 25 Jul 2017 01:43:21 +0000 (10:43 +0900)]
Fix svace defects
Change-Id: I8777be6887041dfcb3d31fc4640a1af8fa6b5590
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Haejeong Kim [Wed, 19 Jul 2017 05:30:57 +0000 (14:30 +0900)]
Just update debugging msg
Change-Id: I8390c2bcdb7e1be1980c4bac727d5df83b6d8aba
Haejeong Kim [Fri, 16 Jun 2017 02:40:23 +0000 (11:40 +0900)]
[RQ170613-00147] fix invalid format argument types for dlog
Change-Id: Ibd62b71f5308218acb3e97c6d69d942a46b8f09d
Haejeong Kim [Thu, 23 Mar 2017 05:44:02 +0000 (14:44 +0900)]
Use license macro in spec file
Change-Id: I4a6f0c03cb4bd4a1701dbacf369495f0b0f9f361
Jiyong Min [Mon, 9 Jan 2017 00:29:48 +0000 (09:29 +0900)]
fix build error
(build fails because of undefined C++11 user-defined literals)
Change-Id: If4d3caa4fd73e7881304cd33f68b536addf92549
Signed-off-by: jiyong.min <jiyong.min@samsung.com>
Minje Ahn [Fri, 23 Sep 2016 01:28:17 +0000 (10:28 +0900)]
Fix native api reference warning
Change-Id: I712c7e25e48cb0142b15f15df79c7d45e8dcf79d
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Mon, 18 Apr 2016 06:37:57 +0000 (15:37 +0900)]
Apply tizen coding rule
Change-Id: Ibdea7c535d077fe248c24505621f10ea88be2d70
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 13 Apr 2016 23:38:29 +0000 (08:38 +0900)]
Apply tizen coding rule
Change-Id: Ia165a1d0fb745012cce961c712077af831a2d9bc
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Fri, 1 Apr 2016 00:59:50 +0000 (09:59 +0900)]
Apply coding rule
Change-Id: I9235d4dcff529f0f0deacdcb399cf45b4edb9f24
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 22 Mar 2016 05:14:51 +0000 (14:14 +0900)]
Update API version description
Change-Id: I867b863095d44467ed5f0412d33d4a49a299c11a
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Wed, 2 Mar 2016 08:43:12 +0000 (17:43 +0900)]
Fix error type
Change-Id: Ifd294812f6143d9b27d82f8ca2f29148c16f164b
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Haejeong Kim [Tue, 26 Jan 2016 06:24:31 +0000 (15:24 +0900)]
Apply tizen coding rule
Change-Id: Ib0db311b7d228881df5b6ba684df155065c33b64
Minje Ahn [Fri, 15 Jan 2016 06:12:48 +0000 (15:12 +0900)]
Update document
Change-Id: I9c5f3aa395a554c9199eaadbb688c69dff1336b7
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Tue, 29 Dec 2015 01:35:55 +0000 (10:35 +0900)]
Update package group
Change-Id: I4469ea7dcf5d14109547581b2783d3da1acf4b5f
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Haejeong, Kim [Fri, 6 Nov 2015 07:12:48 +0000 (16:12 +0900)]
Just apply tizen coding rule
Change-Id: I469ef23ec07d003f65c96a98a285037084778e97
Minje Ahn [Fri, 6 Nov 2015 06:35:34 +0000 (15:35 +0900)]
Change file checker stat to open
Change-Id: I66b87e6c0d46e1a282c4b2cca0653c9f13c7f2ac
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Haejeong, Kim [Thu, 29 Oct 2015 05:35:50 +0000 (14:35 +0900)]
Apply tizen coding rule
Change-Id: I1f0c16794c0f8874a81d60d48b7641de64abbeef
Minje Ahn [Fri, 4 Sep 2015 07:15:08 +0000 (16:15 +0900)]
Fix prevent issue
Change-Id: I010da7f6b0149ed1e0155dda741d128294505edf
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
ji.yong.seo [Thu, 11 Jun 2015 01:46:15 +0000 (10:46 +0900)]
update code by Tizen coding convention
Change-Id: I2387a7611ea4eea9aba7b8cdcc9cbfccea899410
Minje Ahn [Fri, 5 Jun 2015 09:54:56 +0000 (18:54 +0900)]
Modify build error.
Change-Id: I0f3704d014e5f583574292b03eeadbf6fb9b6758
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
Minje Ahn [Thu, 4 Jun 2015 06:35:34 +0000 (15:35 +0900)]
Initialize package.
Change-Id: I43c4bd62fcdb33616e4ccd2b7c04fc8ee81af992
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
KyungMi Lee [Thu, 4 Jun 2015 04:22:01 +0000 (21:22 -0700)]
Initial empty repository
projects / platform / core / api / metadata-editor.git / log