jashoo [Wed, 29 Jun 2016 17:32:41 +0000 (10:32 -0700)]
Disable tests that timeout under gcstress
After increasing the timeout time for gcstress, these tests continue to fail
due to timeouts. To get the gcstress legs green and keep them within a manageable
amount of time they will be disabled.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b624185b05169aac2b6e60ab0e4b01e4e82e9d86
Jarret Shook [Wed, 22 Jun 2016 23:49:49 +0000 (16:49 -0700)]
Merge pull request dotnet/coreclr#5933 from prajwal-aithal/devel/arm-ci-script-fix
ARM-CI: Use CI cross build script in emulator
Commit migrated from https://github.com/dotnet/coreclr/commit/
bf325ae4ab002048b5049c3dc4cc4598a79e535c
Prajwal A N [Wed, 22 Jun 2016 23:21:54 +0000 (08:21 +0900)]
ARM-CI: Use CI cross build script in emulator
Previous PRs added the build commands to the groovy script.
But this did not work for various reasons.
The current patch makes the CI system execute the bash script
that does the cross build. The bash script is already supplied with the emulator
Signed-off-by: Prajwal A N <an.prajwal@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
56fa3e782cb00a1be54ffe8250be009584090018
Bruce Forstall [Wed, 22 Jun 2016 23:15:41 +0000 (16:15 -0700)]
Merge pull request dotnet/coreclr#5929 from BruceForstall/CleanUpPinvokeLowering
Clean up PInvoke lowering
Commit migrated from https://github.com/dotnet/coreclr/commit/
0c7f5b415c2106a5c261c9b918bbd6e736b01ebc
Bruce Forstall [Wed, 22 Jun 2016 21:37:31 +0000 (14:37 -0700)]
Clean up PInvoke lowering
Mostly, add lots of comments.
Commit migrated from https://github.com/dotnet/coreclr/commit/
898080b8fc4bd814b3ccb5ce96b1121ad55d0c4c
Kyungwoo Lee [Wed, 22 Jun 2016 20:43:29 +0000 (13:43 -0700)]
Merge pull request dotnet/coreclr#5926 from kyulee1/cmpxchg
ARM64: Skip CompareExchangeTClass Test
Commit migrated from https://github.com/dotnet/coreclr/commit/
f521e7099273e2764e5d5c81a3a1c1dea6f8676d
Bruce Forstall [Wed, 22 Jun 2016 20:41:25 +0000 (13:41 -0700)]
Merge pull request dotnet/coreclr#5915 from BruceForstall/FgMorphArgsCleanup
Clean up fgMorphArgs
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d3623d1b6dca035999e68c2183e21bbae5d8be7
Rahul Kumar [Wed, 22 Jun 2016 20:35:13 +0000 (13:35 -0700)]
Merge pull request dotnet/coreclr#5891 from rahku/arm64retbuf
Arm64:return buffer arg should be passed in x8
Commit migrated from https://github.com/dotnet/coreclr/commit/
702b73a71b67992bad105c482f5641dfb84893e1
Carol Eidt [Wed, 22 Jun 2016 20:09:55 +0000 (13:09 -0700)]
Merge pull request dotnet/coreclr#5389 from parjong/fix/issue_5357
Run fgMorphCopyBlock for newly inserted assignment
Commit migrated from https://github.com/dotnet/coreclr/commit/
063faa3cd5505ef2168ad9571921588d616d6925
Carol Eidt [Wed, 22 Jun 2016 20:02:32 +0000 (13:02 -0700)]
Merge pull request dotnet/coreclr#5871 from mikedn/modopt
Improve div/mod by const power of 2
Commit migrated from https://github.com/dotnet/coreclr/commit/
3dfe85f3573c12f07495483930beff5a6dbf5e3b
Aditya Mandaleeka [Wed, 22 Jun 2016 19:49:30 +0000 (12:49 -0700)]
Merge pull request dotnet/coreclr#5925 from RussKeldorph/j32_issues
Fix syntax error in x86_jit32_issues.targets
Commit migrated from https://github.com/dotnet/coreclr/commit/
8c090bcf954b8ee382f42e8e1767bf99433f2088
Pat Gavlin [Wed, 22 Jun 2016 18:27:09 +0000 (11:27 -0700)]
Merge pull request dotnet/coreclr#5904 from pgavlin/WalkTreePostExecutionOrder
Obey GTF_REVERSE_OPS in fgWalkTreePost.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8ae408fde25abe91219003dd02c70a6f78cc6fc2
Kyungwoo Lee [Wed, 22 Jun 2016 18:19:24 +0000 (11:19 -0700)]
ARM64: Skip CompareExchangeTClass Test
This test seems to fail often in CI. Disable it for now.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d11bc58e1aec026301cbd1c30f0feb25cf24d66f
Sejong Oh [Wed, 22 Jun 2016 18:12:38 +0000 (11:12 -0700)]
Merge pull request dotnet/coreclr#5905 from sejongoh/group_jitstress_jobs
Move all JIT stress jobs into a sub directory on CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
f93114dceffe68d24f7c3be34c54665bd340281b
Russ Keldorph [Wed, 22 Jun 2016 18:09:12 +0000 (11:09 -0700)]
Fix syntax error in x86_jit32_issues.targets
Commit migrated from https://github.com/dotnet/coreclr/commit/
374d74b7b8ec5364d67263404f30147714e321e3
William Godbe [Wed, 22 Jun 2016 17:46:46 +0000 (10:46 -0700)]
Merge pull request dotnet/coreclr#5924 from wtgodbe/groovalicious
Run all tests under server GC during code coverage job
Commit migrated from https://github.com/dotnet/coreclr/commit/
137ec1f61882062ef9ebfcdf83fdcaccf2db1a69
wtgodbe [Wed, 22 Jun 2016 17:43:55 +0000 (10:43 -0700)]
Run all tests under server GC
Commit migrated from https://github.com/dotnet/coreclr/commit/
f877851fb6a5da8c45a88a282dad67c018ccd4d0
John Chen [Wed, 22 Jun 2016 17:43:23 +0000 (10:43 -0700)]
Merge pull request dotnet/coreclr#5921 from JohnChen0/master
Disable a test case till issue dotnet/coreclr#5501 is fixed
Commit migrated from https://github.com/dotnet/coreclr/commit/
9edcc2aba269a8b91aec3f93fa95b6139a62af87
Evgeny Pavlov [Wed, 22 Jun 2016 16:56:51 +0000 (20:56 +0400)]
[SOS] [Linux] Fix incorrect symbol loading from portable pdb (dotnet/coreclr#5896)
* Fix incorrect symbol loading from portable pdb
* Change return value to S_OK
Commit migrated from https://github.com/dotnet/coreclr/commit/
c95923e1ff48b767cedac760d43be6db89b8bcbe
Mike McLaughlin [Wed, 22 Jun 2016 16:55:33 +0000 (09:55 -0700)]
Generate symbols packages for Windows CoreCLR binaries. (dotnet/coreclr#5902)
* Generate symbols packages for Windows CoreCLR binaries.
Issue dotnet/coreclr#5832.
* Add dll/exe back to symbol package.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f7c5984143a181b8be0cf9268d0bd40925789e9b
John Chen [Wed, 22 Jun 2016 16:12:44 +0000 (09:12 -0700)]
Disable a test case till issue dotnet/coreclr#5501 is fixed
Commit migrated from https://github.com/dotnet/coreclr/commit/
c9258739d99be31c50da632a4c4b1f75bd1ffbce
Mike Danes [Mon, 9 May 2016 22:01:12 +0000 (01:01 +0300)]
Optimize integer div/mod by const power of 2 in lowering
Optimizing GT_DIV/GT_UDIV/GT_MOD/GT_UMOD by power of 2 in codegen is problematic because the xarch DIV instruction has special register requirements. By the time codegen decides to perform the optimization the rax and rdx registers have been already allocated by LSRA even though they're not always needed (as it happens in the case of unsigned division where CDQ isn't used).
Since the JIT can't represent a CDQ instruction in its IR an arithmetic shift (GT_RSH) has been instead to extract the dividend sign. xarch's SAR is larger than CDQ but it has the advantage that it doesn't require specific registers. Also, arithmetic shifts are available on architectures other than xarch.
Example: method "static int foo(int x) => x / 8;" is now compiled to
mov eax, ecx
mov edx, eax
sar edx, 31
and edx, 7
add edx, eax
mov eax, edx
sar eax, 3
instead of
mov eax, ecx
cdq
and edx, 7
add eax, edx
sar eax, 3
As a side-effect of this change the optimization now also works when the divisor is too large to be contained. Previously this wasn't possible because the divisor constant needed to be modified during codegen but the constant was already loaded into a register.
Example: method "static ulong foo(ulong x) => x /
4294967296;" is now compiled to
mov rax, rcx
shr rax, 32
whereas before a DIV instruction was used.
This change also fixes an issue in fgShouldUseMagicNumberDivide. The optimization that is done in lower can handle negative power of 2 divisors but fgShouldUseMagicNumberDivide handled those cases because it didn't check the absolute value of the divisor.
Example: method "static int foo(int x) => return x / -2;" is now compiled to
mov eax, ecx
mov edx, eax
shr edx, 31
add edx, eax
sar edx, 1
mov eax, edx
neg eax
instead of
mov eax, 0x7FFFFFFF
imul edx:eax, ecx
mov eax, edx
sub eax, ecx
mov edx, eax
shr edx, 31
add eax, edx
Commit migrated from https://github.com/dotnet/coreclr/commit/
babfca85887cc455ece64766c4614d494a3419b8
Mike Danes [Sat, 14 Nov 2015 08:46:20 +0000 (10:46 +0200)]
Add tests for integer div/mod by const
Commit migrated from https://github.com/dotnet/coreclr/commit/
4286b4006c3c671d9d9cc1b6979498275b526775
Bruce Forstall [Wed, 22 Jun 2016 06:25:52 +0000 (23:25 -0700)]
Clean up fgMorphArgs
Simplify a lot of the coding, especially related to non-standard arg and SysV struct arg handling.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7952dcf4e5ebe4b93377f192b806da815fa4d7da
chunseoklee [Wed, 22 Jun 2016 15:12:58 +0000 (00:12 +0900)]
fix build break on ARM caused by f1889 (dotnet/coreclr#5914)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5783a073e46b355f2829d4c9a9c0f76dba7d8086
Gaurav Khanna [Wed, 22 Jun 2016 13:58:08 +0000 (06:58 -0700)]
Merge pull request dotnet/coreclr#5913 from dotnet-bot/UpdateDependencies20160622051611
Updating External dependencies to beta-24222-00
Commit migrated from https://github.com/dotnet/coreclr/commit/
f5353c2f40da092910b44ee86672a9d274231f9f
Jan Vorlicek [Wed, 22 Jun 2016 12:26:17 +0000 (14:26 +0200)]
Cleanup hardware exception handling (dotnet/coreclr#5916)
Currently, we were checking for the exception address being in a marked jit
helper and unwinding to the caller context if it was there at two places.
Once in the HandleHardwareException to get context for the faulting exception
frame and once in DispatchManagedException to get the first managed frame.
This change modifies the code in HandleHardwareException to update the context
record in the exception itself so that we can leave out the same change in
the DispatchManagedException.
I have also added updating of the exception address in the exception record
so that the exception address is set to be in the managed caller of the helper.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3651e5f3da9f72cde9b50078023430839fee7037
dotnet-bot [Wed, 22 Jun 2016 05:16:11 +0000 (05:16 +0000)]
Updating External dependencies to beta-24222-00
Commit migrated from https://github.com/dotnet/coreclr/commit/
86f8e7a2b6de3487fcab8b28c30c15ca1fb0f167
Brian Sullivan [Wed, 22 Jun 2016 04:12:32 +0000 (21:12 -0700)]
Merge pull request dotnet/coreclr#5908 from briansull/Fix-Remorph-Call
Fix for Remorph of a call with nonstandard args
Commit migrated from https://github.com/dotnet/coreclr/commit/
a9bb89bdec89f5a81c47586491db86f8f3cbfdce
Brian Sullivan [Wed, 22 Jun 2016 04:11:15 +0000 (21:11 -0700)]
Merge pull request dotnet/coreclr#5909 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
b5f996c1482c56414a9e59ab1dd761bf2824c214
Brian Sullivan [Tue, 21 Jun 2016 23:19:11 +0000 (16:19 -0700)]
Fix for Remorph of a call with nonstandard args
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1889a7cb46c29577316ed43606eedabfeb7c461
Fadi Hanna [Tue, 21 Jun 2016 23:34:40 +0000 (16:34 -0700)]
Fixing build break on x86 and arm.
[tfs-changeset: 1614031]
Commit migrated from https://github.com/dotnet/coreclr/commit/
00bfc20f5960bd3788e3a348d22ac91dea26ecf1
Aditya Mandaleeka [Tue, 21 Jun 2016 23:06:05 +0000 (16:06 -0700)]
Merge pull request dotnet/coreclr#3097 from vors/docx
Convert SOSAndICorDebug.docx to SOSAndICorDebug.md
Commit migrated from https://github.com/dotnet/coreclr/commit/
1f07b477c2bcc9136eee1aa5112fd8e5e5ccc341
Jarret Shook [Tue, 21 Jun 2016 22:49:33 +0000 (15:49 -0700)]
Merge pull request dotnet/coreclr#5900 from jashook/gc_stress_incompat
Set b14364 as gcstress incompat
Commit migrated from https://github.com/dotnet/coreclr/commit/
a97bb98811c4318c487a1e880417f62a6ccead75
Jarret Shook [Tue, 21 Jun 2016 22:49:18 +0000 (15:49 -0700)]
Merge pull request dotnet/coreclr#5898 from jashook/gcstress_timeout_update
Up the default timeout for GCStress
Commit migrated from https://github.com/dotnet/coreclr/commit/
7eb838388ea99a38ca3edcd8fe6a71802cb36d7e
Aditya Mandaleeka [Tue, 21 Jun 2016 22:40:25 +0000 (15:40 -0700)]
Merge pull request dotnet/coreclr#5907 from Maoni0/stress_txt
updated stress run description
Commit migrated from https://github.com/dotnet/coreclr/commit/
56bfb01ac50ae7411eb94215200ea8d1230b1997
Maoni0 [Tue, 21 Jun 2016 22:36:05 +0000 (15:36 -0700)]
added a note about the reason why we ignore failures from tests in the stress run infrastructure
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce86b743aefa7decd5490a9f8a86b95dbe23a9d9
Sejong Oh [Tue, 21 Jun 2016 21:31:06 +0000 (14:31 -0700)]
Move all JIT stress jobs into a sub directory on CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
361d469b1c3ff9d913f17c1d01da50c16de0ba09
William Godbe [Tue, 21 Jun 2016 21:25:49 +0000 (14:25 -0700)]
Merge pull request dotnet/coreclr#5903 from wtgodbe/groovester
Archive entire obj directory in coverage jobs
Commit migrated from https://github.com/dotnet/coreclr/commit/
c278c028111aba47c23c2f3c7ba5e0f152f21faf
wtgodbe [Tue, 21 Jun 2016 21:21:45 +0000 (14:21 -0700)]
Archive entire obj directory
Commit migrated from https://github.com/dotnet/coreclr/commit/
3136907d29eec4c289e190263a966c7f68d2fbf7
Maoni Stephens [Tue, 21 Jun 2016 20:56:01 +0000 (13:56 -0700)]
Merge pull request dotnet/coreclr#5894 from Maoni0/seg_table
We need to have seg_mapping_table aligned on its natural alignement
Commit migrated from https://github.com/dotnet/coreclr/commit/
751dcd675ab685386f981d8ec1a2df6b004c19a2
Gaurav Khanna [Tue, 21 Jun 2016 20:22:03 +0000 (13:22 -0700)]
Merge pull request dotnet/coreclr#5899 from dotnet-bot/UpdateDependencies20160621051655
Updating External dependencies to beta-24221-00
Commit migrated from https://github.com/dotnet/coreclr/commit/
70271b3b0a082f8c373aa82d82727df93d8a8d2d
Sejong Oh [Tue, 21 Jun 2016 20:06:29 +0000 (13:06 -0700)]
Merge pull request dotnet/coreclr#5892 from sejongoh/group_jitstress_jobs
Initial changes to move JIT stress jobs into jitstress directory on CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
d0ff00f870784d04fb6aaa9cc55478cfd03416e4
Rahul Kumar [Mon, 20 Jun 2016 22:33:19 +0000 (15:33 -0700)]
Arm64:return buffer arg should be passed in x8
Commit migrated from https://github.com/dotnet/coreclr/commit/
ce39651fb42e68883a14f498c0bbc39dd5230d88
Fadi Hanna [Tue, 21 Jun 2016 18:51:05 +0000 (11:51 -0700)]
Generic dictionary minor performance improvement and simplification for R2R (dotnet/coreclr#5690)
A set of refactoring changes to slighly improve the performance of generic dictionary access on R2R images, and simplifying the codebase:
1) Removing dependency on CEEInfo::ComputeRuntimeLookupForSharedGenericTokenStatic (and deleting the API).
2) Stop parsing the generic type/method signatures when generating the R2R dictionary lookup assembly stub.
3) Avoid re-encoding the generic type/method signatures in a new in-memory blob using a SigBuilder (signatures used directly from the R2R image)
4) Moved the parsing/loading of type/method signatures to Dictionary::PopulateEntry()
5) Dictionary index and slot number are now encoded in the generated assembly stub instead of the signature (stub takes a pointer to a data blob, which contains the signature, the dictionary index and slot, and the module pointer)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b9f5ae88cc49836c8d31f07db7800707165cdb06
Brian Sullivan [Tue, 21 Jun 2016 18:45:15 +0000 (11:45 -0700)]
Merge pull request dotnet/coreclr#5895 from briansull/UnboxingStub-Fix
Fix for generic unboxing stub with x8 return buffer argument
Commit migrated from https://github.com/dotnet/coreclr/commit/
fb79613c44df5ad80831dba1460ffb14dd6497a3
Carol Eidt [Tue, 21 Jun 2016 18:10:47 +0000 (11:10 -0700)]
Merge pull request dotnet/coreclr#5813 from mikedn/no-setflags
Remove useless gtSetFlags calls
Commit migrated from https://github.com/dotnet/coreclr/commit/
0d462da2173627b454dbe74f33828e0698cd963b
Pat Gavlin [Tue, 21 Jun 2016 17:58:43 +0000 (10:58 -0700)]
Obey GTF_REVERSE_OPS in fgWalkTreePost.
This particular sort of tree walk should correspond to the
tree execution order.
Commit migrated from https://github.com/dotnet/coreclr/commit/
95ff08611169aba2988903c74dcc524acd8b4e90
Brian Robbins [Tue, 21 Jun 2016 17:42:10 +0000 (10:42 -0700)]
Merge pull request dotnet/coreclr#5885 from brianrob/docker_perf
Update Linux Tracing Instructions for Docker Containers
Commit migrated from https://github.com/dotnet/coreclr/commit/
51f010f8f219810282391a9e0dd08188bafd5a93
jashoo [Tue, 21 Jun 2016 17:30:13 +0000 (10:30 -0700)]
Set b14364 as gcstress incompat
This test is set to be excluded to in interal testing under gc stress.
Add that information here as well.
Commit migrated from https://github.com/dotnet/coreclr/commit/
7f886f09c34751958886537bc24ca5c10f773d34
dotnet-bot [Tue, 21 Jun 2016 17:16:55 +0000 (17:16 +0000)]
Updating External dependencies to beta-24221-00
Commit migrated from https://github.com/dotnet/coreclr/commit/
e5386e701ef0216d4a781391db1a4f6430664ef3
jashoo [Tue, 21 Jun 2016 16:35:02 +0000 (09:35 -0700)]
Up the default timeout for GCStress
Commit migrated from https://github.com/dotnet/coreclr/commit/
151e16c65c982032858c9d72a72aedda25b9e5d3
Gaurav Khanna [Tue, 21 Jun 2016 15:46:09 +0000 (08:46 -0700)]
Merge pull request dotnet/coreclr#5887 from gkhanna79/Fix5883
Update Prerelease version to Beta and increment patch version.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a576c83b0401fcfcc9e47e5cd3dcbe4c13871f58
Brian Sullivan [Tue, 21 Jun 2016 01:29:11 +0000 (18:29 -0700)]
Fix for generic unboxing stub with x8 return buffer argument
When we have nonstandard args we have to handle them before
we setup to expect the return buffer arg.
Added additional JitDump information about the call and its return type in impImportCall.
All of the ARM64 EXPECTED_PASS tests will now pass when hasFixedRerBufReg is enabled.
Additional changes are needed for the IL_STUB_PInvoke to get the Interop tests to pass
But these tests are currentlt alreay in the EXPECTED_FAIL catagory.
Commit migrated from https://github.com/dotnet/coreclr/commit/
3ddcd852cd36b350bcbb97ff0b6667e318e41e58
Gaurav Khanna [Mon, 20 Jun 2016 20:56:09 +0000 (13:56 -0700)]
Update Prerelease version to Beta and increment patch version.
Commit migrated from https://github.com/dotnet/coreclr/commit/
af7598e06f0df2a2df4894bbdfb5eb36b9dabb0d
Rahul Kumar [Tue, 21 Jun 2016 01:52:22 +0000 (18:52 -0700)]
Merge pull request dotnet/coreclr#5893 from rahku/test
Enable building only native test components
Commit migrated from https://github.com/dotnet/coreclr/commit/
cb0bb4e65ee1d2af116e3fb4e2dca116ae56fc03
Aditya Mandaleeka [Tue, 21 Jun 2016 01:26:16 +0000 (18:26 -0700)]
Merge pull request dotnet/coreclr#4983 from benaadams/patch-2
Add slack channel
Commit migrated from https://github.com/dotnet/coreclr/commit/
370e4143dfec911790c0e06a15156ddf5c91f310
Aditya Mandaleeka [Tue, 21 Jun 2016 01:18:06 +0000 (18:18 -0700)]
Merge pull request dotnet/coreclr#3074 from Dmitry-Me/useElseIfForExclusive
Use else-if for mutually exclusive conditions
Commit migrated from https://github.com/dotnet/coreclr/commit/
1973f0f500e33ca237f1587dfea71073bb9a997e
Maoni0 [Wed, 15 Jun 2016 20:37:35 +0000 (13:37 -0700)]
We need to have seg_mapping_table aligned on its natural alignement (ptr size). When it's not aligned,
aside from the perf problem, we also have a functional problem when an address that's not on a heap
segment is passed - we could read an intermediate value which would cause an AV. If the address is
on a heap segment it means we are guaranteed to read a ptr size atomically. This only affects functions
like IsHeapPointer which can be run when EE is not suspended.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6a4e02a4ded34e385b7249ed5972b49ad97f354a
Rahul Kumar [Tue, 21 Jun 2016 00:01:34 +0000 (17:01 -0700)]
Enable building only native test components
Commit migrated from https://github.com/dotnet/coreclr/commit/
ffac9c48557b58dc8e6369de92c66d6e97525afe
William Godbe [Mon, 20 Jun 2016 23:47:12 +0000 (16:47 -0700)]
Merge pull request dotnet/coreclr#5889 from wtgodbe/Loader
Fix race condition in Loader regression 523654 test
Commit migrated from https://github.com/dotnet/coreclr/commit/
f6ad954733e4c8f0bbb342bc3412747663905cb2
Aditya Mandaleeka [Mon, 20 Jun 2016 23:38:49 +0000 (16:38 -0700)]
Merge pull request dotnet/coreclr#5879 from mattwarren/patch-1
Added links to CoreCLR issues, small formatting fix
Commit migrated from https://github.com/dotnet/coreclr/commit/
cd469732bc763516dbde160ef5859afcc058cc65
Aditya Mandaleeka [Mon, 20 Jun 2016 23:35:14 +0000 (16:35 -0700)]
Merge pull request dotnet/coreclr#5888 from adityamandaleeka/generate_core_dumps_runtest
Set coredump_filter to include shared library code in CI core dumps
Commit migrated from https://github.com/dotnet/coreclr/commit/
742df17fff977695cd36337169b16af0057ad723
Sejong Oh [Mon, 20 Jun 2016 22:42:22 +0000 (15:42 -0700)]
Initial changes to group JIT stress jobs into a sub directory on CI
Add jitstress2_jitstressregs1 scenario first and then will add others
after testing.
Commit migrated from https://github.com/dotnet/coreclr/commit/
972af956a0670c40eb4135be3de3d6041fe950fd
wtgodbe [Mon, 20 Jun 2016 22:21:44 +0000 (15:21 -0700)]
Fix race condition in Loader regression 523654 test
Commit migrated from https://github.com/dotnet/coreclr/commit/
27e1cdfe3fc50b5e9250ea5b4c7deec793b5f6b0
Sean Gillespie [Mon, 20 Jun 2016 21:56:29 +0000 (14:56 -0700)]
Merge pull request dotnet/coreclr#5886 from swgillespie/longgc-netci
Switch to double-quotes for interpolated string in netci.groovy
Commit migrated from https://github.com/dotnet/coreclr/commit/
cbddfc0dfd42077a23def2118636fe5061c6093a
Aditya Mandaleeka [Mon, 20 Jun 2016 21:29:37 +0000 (14:29 -0700)]
Set coredump_filter to include shared library code.
Commit migrated from https://github.com/dotnet/coreclr/commit/
e42ea2920222716e9751f78fa72b3256f85d8d4e
Brian Robbins [Fri, 17 Jun 2016 23:04:10 +0000 (16:04 -0700)]
Update Linux tracing instructions for Docker containers.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f5f41ae0baa783fae5c63a85f2bb53758ae55632
Sean Gillespie [Mon, 20 Jun 2016 20:11:18 +0000 (13:11 -0700)]
Switch to double-quotes for interpolated string
Commit migrated from https://github.com/dotnet/coreclr/commit/
dedf88fadb44e046cc570e76c5c78fac70681e21
Stephen Toub [Mon, 20 Jun 2016 19:34:27 +0000 (15:34 -0400)]
Merge pull request dotnet/coreclr#5882 from stephentoub/fix_ev_bytearray
Fix EventSource deserializing of byte[]s
Commit migrated from https://github.com/dotnet/coreclr/commit/
f5a854bd323e5e327ec1a011dc494d2abb1e7721
Pat Gavlin [Mon, 20 Jun 2016 17:25:07 +0000 (10:25 -0700)]
Merge pull request dotnet/coreclr#5875 from pgavlin/JitStdoutVbuf
Disable buffering on jitstdout.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ee680783778ed0abb186ae41a8c861d5cdcadccd
Stephen Toub [Mon, 20 Jun 2016 17:05:18 +0000 (13:05 -0400)]
Fix EventSource deserializing of byte[]s
It's incorrectly repeating the first element for all elements.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4a3ab6816124ef63e371bd9e7f80e05709f7a761
Gaurav Khanna [Mon, 20 Jun 2016 15:35:28 +0000 (08:35 -0700)]
Merge pull request dotnet/coreclr#5876 from dotnet-bot/UpdateDependencies20160620061718
Updating External dependencies to rc4-24220-00
Commit migrated from https://github.com/dotnet/coreclr/commit/
79ae4d44b7dc71f098ab97e712f8af7c493e720f
Matt Warren [Mon, 20 Jun 2016 10:29:55 +0000 (11:29 +0100)]
Added links to CoreCLR issues, small formatting fix
Commit migrated from https://github.com/dotnet/coreclr/commit/
60de14e7ebb4f42d358e84ec192d64f0266cb39f
Jan Vorlicek [Mon, 20 Jun 2016 09:57:00 +0000 (11:57 +0200)]
Fix GC background thread start in OOM (dotnet/coreclr#5840)
This change fixes a problem that happened when the `gc_heap::create_bgc_thread`
calls SetupUnstartedThread and it fails to allocate a Thread object and throws.
The GC doesn't expect that and so when the stack is unwound, the `gc_heap::gc_started`
stays set. Now we try to allocate memory for the Throwable for the exception, so we go
to GC heap and since there is not enough space, we end up calling
`gc_heap::try_allocate_more_space`, which calls `gc_heap::wait_for_gc_done`.
And that’s the end of it, since the `gc_started` is still set and we wait forever.
The fix is to catch exception from the SetupUnstartedThread. I have also fixed couple of
places where this method was being called and the exception was not expected.
As an additional cleanup, I have moved the thread creation in GC to the GCToEEInterface.
Commit migrated from https://github.com/dotnet/coreclr/commit/
878cd5d88fc38fe0131455c84a6793c562238f70
dotnet-bot [Mon, 20 Jun 2016 06:17:18 +0000 (06:17 +0000)]
Updating External dependencies to rc4-24220-00
Commit migrated from https://github.com/dotnet/coreclr/commit/
600b46bd294b81b41dfa5d275938098975ca622e
Pat Gavlin [Mon, 20 Jun 2016 04:42:09 +0000 (21:42 -0700)]
Disable buffering on jitstdout.
This avoid the need to call fflush() throughout the code.
Commit migrated from https://github.com/dotnet/coreclr/commit/
bc3533fb742458bd6939f7f878bf8f477cbac791
Sejong Oh [Mon, 20 Jun 2016 02:01:55 +0000 (19:01 -0700)]
Merge pull request dotnet/coreclr#5380 from sejongoh/x86_decompose_storeind
Decomposing 64-bit storeind instruction to 32-bit storeind instructions
Commit migrated from https://github.com/dotnet/coreclr/commit/
b464dc317d49b84cf2e3a2e4f65813c23ea51a41
Sejong Oh [Wed, 25 May 2016 01:11:52 +0000 (18:11 -0700)]
Decomposing 64-bit storeind instruction to 32-bit storeind instructions
Commit migrated from https://github.com/dotnet/coreclr/commit/
780400f1e579621f0a0d2347f8393498012b1549
Mike McLaughlin [Sun, 19 Jun 2016 22:24:49 +0000 (15:24 -0700)]
Fix source/line info in unhandled exceptions (dotnet/coreclr#5874)
* Fix no source/line info for unhandled exceptions.
Issue dotnet/coreclr#5828.
* Remove comment.
Commit migrated from https://github.com/dotnet/coreclr/commit/
4144d4cb720399fb9fe0a8a03bffac07ba8fb065
Peter Jas [Sun, 19 Jun 2016 18:37:06 +0000 (21:37 +0300)]
Remove the corner cases from sscanf test (dotnet/coreclr#5873)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5546991296f5e407cf6797a914092cf8317b0ec0
Jan Kotas [Sun, 19 Jun 2016 16:40:48 +0000 (09:40 -0700)]
Update GC from CoreRT (dotnet/coreclr#5859)
https://github.com/dotnet/corert/tree/master/src/Native/gc dotnet/coreclr@
53276850bc2e7e531908434b2d062fcff3e1d58d
Commit migrated from https://github.com/dotnet/coreclr/commit/
734f9814f534b324a9268804371cf9da9245ec78
Jan Kotas [Sat, 18 Jun 2016 04:03:23 +0000 (21:03 -0700)]
Merge pull request dotnet/coreclr#5858 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
0e5f844e008b3a9ea537a0dfcb84f51f8b79e60b
Kyungwoo Lee [Sat, 18 Jun 2016 03:46:05 +0000 (20:46 -0700)]
Merge pull request dotnet/coreclr#5865 from kyulee1/fixgcstruct
ARM64: Fix GC hole for Multi-Reg Struct
Commit migrated from https://github.com/dotnet/coreclr/commit/
22788578877f3a4741f4448eb06ae14687870e03
Aditya Mandaleeka [Sat, 18 Jun 2016 02:38:35 +0000 (19:38 -0700)]
Merge pull request dotnet/coreclr#5863 from adityamandaleeka/generate_core_dumps_runtest
Add option to runtest.sh to enable limited dump generation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
84948692baac873d9f7407c6ca2863a900c04a0e
Andy Ayers [Sat, 18 Jun 2016 01:45:25 +0000 (18:45 -0700)]
Merge pull request dotnet/coreclr#5868 from AndyAyersMS/BooleansRule
JIT: standardize on bool for return type of GenTree OperIs methods
Commit migrated from https://github.com/dotnet/coreclr/commit/
e787b60ab7fbe8ab62f1986145b7aec6104fd4c2
Aditya Mandaleeka [Sat, 18 Jun 2016 01:30:06 +0000 (18:30 -0700)]
Merge pull request dotnet/coreclr#5862 from adityamandaleeka/remove_dead_code
Remove some dead code in notifyexternals
Commit migrated from https://github.com/dotnet/coreclr/commit/
1e513085692a1d5208efc002e2dead5bb895fb3b
Brian Sullivan [Fri, 17 Jun 2016 23:27:25 +0000 (16:27 -0700)]
Merge pull request dotnet/coreclr#5831 from briansull/fix-5759
Fix for issue 5795
Commit migrated from https://github.com/dotnet/coreclr/commit/
13675a3c6df31caad2db8e634d9ba7fac26e896d
Andy Ayers [Fri, 17 Jun 2016 22:31:32 +0000 (15:31 -0700)]
JIT: standardize on bool for return type of GenTree OperIs methods
We had a mixture of bool and int return types. Standardize on bool.
Otherwise callers must match the mixed typing to avoid the fatal
C4800 warning on windows.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b1988c8d4029b20d68b8e6102e7d863385595c51
Aditya Mandaleeka [Fri, 17 Jun 2016 19:42:27 +0000 (12:42 -0700)]
Remove dead code in notifyexternals
Commit migrated from https://github.com/dotnet/coreclr/commit/
839e5aba21fea49c7b046ec14205d200de4ab55d
Aditya Mandaleeka [Fri, 17 Jun 2016 22:13:19 +0000 (15:13 -0700)]
Enable core dump generation in CI test jobs
Commit migrated from https://github.com/dotnet/coreclr/commit/
1ad32ce9c82b0e5c1594ecec88423803045cc824
Kyungwoo Lee [Fri, 17 Jun 2016 21:27:36 +0000 (14:27 -0700)]
ARM64: Fix GC hole for Multi-Reg Struct
Fixes https://github.com/dotnet/coreclr/issues/5817
When we pass struct in multi-reg, we dropped the GC info on creating
instruction.
The fix is that for GT_LCL_FLD, we enforce non-float type size while
holding the gc type.
Validate with small cutdown. And also confirmed that the gc range is
reasonable in System.Reflection.RuntimeParameterInfo.GetParameters.
Commit migrated from https://github.com/dotnet/coreclr/commit/
9a153fb228a59017a632549bc6501b60838b9177
Russ Keldorph [Fri, 17 Jun 2016 22:02:55 +0000 (15:02 -0700)]
Merge pull request dotnet/coreclr#5836 from RussKeldorph/nogcsosx
Disable GCStress=C periodic triggers for OSX
Commit migrated from https://github.com/dotnet/coreclr/commit/
ee3ad560653dc74e2a98642b2bdf4115f9d208f1
Andy Ayers [Fri, 17 Jun 2016 21:42:02 +0000 (14:42 -0700)]
Merge pull request dotnet/coreclr#5856 from AndyAyersMS/ConstantObservations
JIT: Cleanup code in and around fgFindJumpTargets
Commit migrated from https://github.com/dotnet/coreclr/commit/
42d3f36d802b902c54288d75526908c4f8050026
Aditya Mandaleeka [Fri, 17 Jun 2016 20:49:53 +0000 (13:49 -0700)]
Add option to runtest.sh to enable limited dump generation.
Commit migrated from https://github.com/dotnet/coreclr/commit/
b202782ae96981535e9194bd42a2ff5c6ba8fd78
Brian Sullivan [Thu, 16 Jun 2016 17:06:55 +0000 (10:06 -0700)]
Fix for issue 5795
We incorrectly pass the ret buf arg in x9 instead of x8
It is required that we call SortArgs and EvalArgsToTemps whenever we have any register arguments
We were not doing that when we only had a retBufArg argument in x8.
Fix for UNIX_AMD64 structs
Commit migrated from https://github.com/dotnet/coreclr/commit/
0809be00850fec3eca9a968d36750fc44d69e2f3
Jan Kotas [Fri, 17 Jun 2016 17:43:24 +0000 (10:43 -0700)]
Merge pull request dotnet/coreclr#5854 from dotnet-bot/from-tfs
Merge changes from TFS
Commit migrated from https://github.com/dotnet/coreclr/commit/
b387b6eb6f4e1ddf4c20aece8d1508d011915c4c
Andy Ayers [Thu, 16 Jun 2016 22:33:48 +0000 (15:33 -0700)]
JIT: Cleanup code in and around fgFindJumpTargets
Reorder code to remove gotos. Extract two large chunks of logic as
subroutines. Add braces and update comments. Bring `fgStack` class up
to current Jit coding conventions. Reunite some orphaned comments for
fgFindJumpTargets.
No behavior change expected. No diffs seen via jit-diff tool. No diffs
seen in desktop testing.
Commit migrated from https://github.com/dotnet/coreclr/commit/
06f902ab0614e76efb978249e62e4273f555431f
Sean Gillespie [Fri, 17 Jun 2016 16:55:33 +0000 (09:55 -0700)]
Merge pull request dotnet/coreclr#5839 from swgillespie/gc-batch-fix
Fix GC test batch script skip conditions that were behaving unexpectedly
Commit migrated from https://github.com/dotnet/coreclr/commit/
61c639ba82beea7483b20d1adad352ffddfe23f5
Jan Kotas [Fri, 17 Jun 2016 15:17:25 +0000 (08:17 -0700)]
Fix full framework build break
[tfs-changeset: 1613359]
Commit migrated from https://github.com/dotnet/coreclr/commit/
8f606f32391ee12babe38a91b3501cc31019f94b