scroggo@google.com [Tue, 19 Mar 2013 17:38:50 +0000 (17:38 +0000)]
Revert "Make gm use SkFlags."
Fix the build.
This reverts commit
6f1fe2aee39308fc56854b062be244a904c209e7.
Review URL: https://codereview.chromium.org/
12709005
git-svn-id: http://skia.googlecode.com/svn/trunk@8236
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 19 Mar 2013 17:28:10 +0000 (17:28 +0000)]
Make gm use SkFlags.
Make flag parser its own project. It is still in the tools folder,
but can now be used by other projects.
Some changes to behavior in order to work with SkFlags:
enable-missing-warning and disable-missing-warning have become
enableMissingWarning and noenableMissingWarning.
exclude-config is now excludeConfig
--config now can only be listed once, but all configs listed
after it will be included (same with excludeConfig and match).
In addition, writeJsonSummary has been changed to
writeJsonSummaryPath for consistency with other path flags.
Provide an option to SkFlags to provide a short name, and use
it for the flags which have short names.
--tileGridReplayScales now takes space separated arguments,
like other inputs.
BUG=https://code.google.com/p/skia/issues/detail?id=1094
Review URL: https://codereview.chromium.org/
12632015
git-svn-id: http://skia.googlecode.com/svn/trunk@8235
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 19 Mar 2013 17:19:05 +0000 (17:19 +0000)]
resubmit https://code.google.com/p/skia/source/detail?r=7883 (in the meantime we added capability to collect minidump and callstack if buildbot fails with heap coruption in windows. a few minor conflicts have been resolved)
Review URL: https://codereview.chromium.org/
12840004
git-svn-id: http://skia.googlecode.com/svn/trunk@8233
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 19 Mar 2013 16:43:40 +0000 (16:43 +0000)]
Revert changes to GM MSAA configs, hopefully fixes linux bot gm failures.
git-svn-id: http://skia.googlecode.com/svn/trunk@8232
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 19 Mar 2013 16:06:52 +0000 (16:06 +0000)]
remove SkFontHost::CreateScalerContext
Review URL: https://codereview.chromium.org/
12593013
git-svn-id: http://skia.googlecode.com/svn/trunk@8228
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 19 Mar 2013 15:19:41 +0000 (15:19 +0000)]
fix angle gmmain build
git-svn-id: http://skia.googlecode.com/svn/trunk@8226
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 19 Mar 2013 15:07:30 +0000 (15:07 +0000)]
Fix for displacement mapping
Fixed the skia displacement map effect to match the WebKit displacement map fix.
Review URL: https://codereview.chromium.org/
12787007
git-svn-id: http://skia.googlecode.com/svn/trunk@8225
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 19 Mar 2013 14:50:41 +0000 (14:50 +0000)]
fix double->float warnings
git-svn-id: http://skia.googlecode.com/svn/trunk@8224
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 19 Mar 2013 14:44:54 +0000 (14:44 +0000)]
Add SkTypeface* parameter to SkScalerContext (and its callers)
Use SkTypeface to create scalercontext instead of SkFontHost
Review URL: https://codereview.chromium.org/
12706010
git-svn-id: http://skia.googlecode.com/svn/trunk@8223
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 19 Mar 2013 14:35:41 +0000 (14:35 +0000)]
Fix build break in gmmain.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@8222
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 19 Mar 2013 14:28:36 +0000 (14:28 +0000)]
Add config msaa4 to gm (not run by default) and make MSAA configs not run unless
sample count is <= the max.
Review URL: https://codereview.chromium.org/
12554012
git-svn-id: http://skia.googlecode.com/svn/trunk@8221
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 19 Mar 2013 14:20:22 +0000 (14:20 +0000)]
More performance rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8220
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 19 Mar 2013 14:16:31 +0000 (14:16 +0000)]
Add a macro for querying the byte order of SkPMColor.
R=reed@google.com
Author: bsalomon@google.com
Reviewed By: reed@google.com,epoger@google.com
Review URL: https://chromiumcodereview.appspot.com/
12771010
git-svn-id: http://skia.googlecode.com/svn/trunk@8219
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 19 Mar 2013 14:11:15 +0000 (14:11 +0000)]
Adding rects-specific GM
https://codereview.chromium.org/
12934003/
git-svn-id: http://skia.googlecode.com/svn/trunk@8218
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 19 Mar 2013 13:58:55 +0000 (13:58 +0000)]
Add MSAA configs to bench.
Review URL: https://codereview.chromium.org/
12607013
git-svn-id: http://skia.googlecode.com/svn/trunk@8217
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 19 Mar 2013 13:34:55 +0000 (13:34 +0000)]
use SkStream::NewFromFile()
git-svn-id: http://skia.googlecode.com/svn/trunk@8216
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 19 Mar 2013 12:29:06 +0000 (12:29 +0000)]
Remove SkMMapStream.h from core.gypi
git-svn-id: http://skia.googlecode.com/svn/trunk@8214
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 19 Mar 2013 07:15:10 +0000 (07:15 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8211
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Tue, 19 Mar 2013 02:18:33 +0000 (02:18 +0000)]
use SkStream::NewFromFile()
git-svn-id: http://skia.googlecode.com/svn/trunk@8210
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Tue, 19 Mar 2013 02:12:50 +0000 (02:12 +0000)]
update coding style
git-svn-id: http://skia.googlecode.com/svn/trunk@8209
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 18 Mar 2013 21:37:39 +0000 (21:37 +0000)]
Improvements/additions to SkImageCache/SkLazyPixelRef.
SkPurgeableImageCache:
New image cache that uses virtual memory to store the pixels. Combines
features of SkAshmemImageCache (which has been removed) with SkPurgeableMemoryBlock, which has android and Mac versions.
SkImageCache:
Modified the API. pinCache now returns a status out parameter which
states whether the pinned memory retained the old data. This allows
allocAndPinCache to only be used for allocations.
Add a new debug only interface to purge unpinned data.
Updates to documentation, clarifying behavior.
Changed CachedStatus to MemoryStatus
SkLruImageCache:
Implement the new function purgeAllUnpinnedCaches and change implementation
of pinCache for the new behavior.
SkLazyPixelRef:
Rewrite onLockPixels to account for the new behavior of pinCache.
BitmapFactoryTest:
Test the new SkPurgeableImageCache.
Write tests which directly test the SkImageCaches.
Create a larger bitmap, since some of the SkImageCaches are designed
to handle large bitmaps.
bench_ and render_pictures:
Consolidate lazy_decode_bitmap into one function.
Allow using a flag to specify using the purgeable image cache.
Clean up some #includes.
Review URL: https://codereview.chromium.org/
12433020
git-svn-id: http://skia.googlecode.com/svn/trunk@8207
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 18 Mar 2013 21:08:46 +0000 (21:08 +0000)]
reland 8200 w/ fix for android (use fullpath instead of path)
Review URL: https://codereview.chromium.org/
12921003
git-svn-id: http://skia.googlecode.com/svn/trunk@8206
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 18 Mar 2013 20:53:49 +0000 (20:53 +0000)]
revert 8204 -- what is happening???
git-svn-id: http://skia.googlecode.com/svn/trunk@8205
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 18 Mar 2013 20:49:28 +0000 (20:49 +0000)]
reland 8200 w/ fix for android (need fullpath instead of path)
git-svn-id: http://skia.googlecode.com/svn/trunk@8204
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 18 Mar 2013 19:55:57 +0000 (19:55 +0000)]
Do not use SkTDS32Array when building for 64 bit.
This class is used for pointers, which won't work on 64 bit.
Fixes SampleApp on Mac debug 64 bit.
BUG=https://code.google.com/p/skia/issues/detail?id=1169
Review URL: https://codereview.chromium.org/
12919014
git-svn-id: http://skia.googlecode.com/svn/trunk@8203
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 18 Mar 2013 19:32:58 +0000 (19:32 +0000)]
revert 8200 to figure out android break
git-svn-id: http://skia.googlecode.com/svn/trunk@8201
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 18 Mar 2013 19:08:46 +0000 (19:08 +0000)]
move SK_MMAP_SUPPORT into SkPreConfig, so we can know about its availability
throughout the code.
Add SkData::NewFromMMap() help factory.
Refactor (now gone) SkMMapStream into SkStream::NewFromFile() factory
Review URL: https://codereview.chromium.org/
12919013
git-svn-id: http://skia.googlecode.com/svn/trunk@8200
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 18 Mar 2013 18:18:26 +0000 (18:18 +0000)]
Use "svn cat" in tools/submit_try
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
12726006
git-svn-id: http://skia.googlecode.com/svn/trunk@8197
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 18 Mar 2013 17:57:18 +0000 (17:57 +0000)]
More Mac 10.8 performance rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8195
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 18 Mar 2013 17:53:38 +0000 (17:53 +0000)]
Added toString to SkMaskFilter-derived classes
https://codereview.appspot.com/
7889043/
git-svn-id: http://skia.googlecode.com/svn/trunk@8194
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 18 Mar 2013 15:40:44 +0000 (15:40 +0000)]
Whitespace change to trigger rebuilds
git-svn-id: http://skia.googlecode.com/svn/trunk@8191
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 18 Mar 2013 14:37:16 +0000 (14:37 +0000)]
Another Mac 10.8 performance rebaseline
git-svn-id: http://skia.googlecode.com/svn/trunk@8190
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 18 Mar 2013 12:12:37 +0000 (12:12 +0000)]
Perfrormance rebaseline for Mac 10.8
git-svn-id: http://skia.googlecode.com/svn/trunk@8188
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Mon, 18 Mar 2013 07:01:03 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8186
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 17 Mar 2013 22:34:56 +0000 (22:34 +0000)]
Yet another performance trigger rebaseline
git-svn-id: http://skia.googlecode.com/svn/trunk@8185
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 17 Mar 2013 20:58:08 +0000 (20:58 +0000)]
More performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@8184
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 17 Mar 2013 18:50:05 +0000 (18:50 +0000)]
Rebaseline some more performance triggers (Mac 10.8 & Ubuntu)
git-svn-id: http://skia.googlecode.com/svn/trunk@8183
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 17 Mar 2013 18:46:16 +0000 (18:46 +0000)]
Add translate & scale optimizations
https://codereview.appspot.com/
7571045/
git-svn-id: http://skia.googlecode.com/svn/trunk@8182
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 17 Mar 2013 18:33:46 +0000 (18:33 +0000)]
Making SkDrawCommand more robust
https://codereview.appspot.com/
7486052/
git-svn-id: http://skia.googlecode.com/svn/trunk@8181
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 17 Mar 2013 16:51:44 +0000 (16:51 +0000)]
Rebaselining Nexus7 performance triggers after r8171
git-svn-id: http://skia.googlecode.com/svn/trunk@8180
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 17 Mar 2013 16:32:12 +0000 (16:32 +0000)]
Rebaseline Ubuntu, Windows and Mac 10.8 performance triggers after r8171
git-svn-id: http://skia.googlecode.com/svn/trunk@8179
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sun, 17 Mar 2013 15:40:59 +0000 (15:40 +0000)]
Fix android build
https://codereview.chromium.org/
12896002/
git-svn-id: http://skia.googlecode.com/svn/trunk@8178
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 16 Mar 2013 07:01:18 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8177
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 15 Mar 2013 18:08:09 +0000 (18:08 +0000)]
Create a platform-dependent object for accessing purgeable memory.
Siphoned off from https://codereview.chromium.org/
12433020/
Create a Skia class which can provide purgeable memory in a platform-
dependent way. Include an implementation for Ashmem and Mac/iOS.
Review URL: https://codereview.chromium.org/
12645006
git-svn-id: http://skia.googlecode.com/svn/trunk@8176
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 15 Mar 2013 16:49:34 +0000 (16:49 +0000)]
Patch to fix NULL ptr dereference in 8171 on Linux
TBR=junov@google.com
git-svn-id: http://skia.googlecode.com/svn/trunk@8175
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 15 Mar 2013 15:42:15 +0000 (15:42 +0000)]
Run non-rendering benches in their own config.
Currently benches that set fIsRendering = false are run as part of the first config run. This is problematic for several reasons.
1) Which config they are run as depends on the --config options passed to bench. If I run bench --config GPU --config 8888 then they will be run in the GPU config and not the 8888 config.
2) Their presence makes bench take longer to run when testing rendering changes or comparing one rendering config to another (e.g. GPU v 8888). This is especially true on Android.
3) When comparing runs of a single config across multiple bench runs (typically with code changes) it isn't obvious from the output which benchs to ignore because they say are listed under as being part of the config.
This CL adds NONRENDERING as a config (open to name suggestions). Non-rendering tests are run in and only in the NONRENDERING config.
Will this screw up our bench bots/scripts/graphs? If so I think we should change them since running non-rendering tests separately makes a lot more sense than the current madness.
Review URL: https://codereview.chromium.org/
12475012
git-svn-id: http://skia.googlecode.com/svn/trunk@8174
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 15 Mar 2013 15:29:02 +0000 (15:29 +0000)]
In gm, install drawFilter for pipe and tiledPipe.
Fixes bugs in drawing un-antialiased text in gm.
Review URL: https://codereview.chromium.org/
12812016
git-svn-id: http://skia.googlecode.com/svn/trunk@8173
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 15 Mar 2013 15:06:03 +0000 (15:06 +0000)]
Fixing SkPicture command pattern optimizations to make them work correctly with bounding box hierarchies
BUG=https://code.google.com/p/chromium/issues/detail?id=180645
TEST=render_pictures -r <skp_dir> --validate --bbh <grid|rtree> --mode tile 256 256
Author: junov@chromium.org
Reviewed By: robertphillips@google.com
Review URL: https://chromiumcodereview.appspot.com/
12817011
git-svn-id: http://skia.googlecode.com/svn/trunk@8171
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Fri, 15 Mar 2013 13:37:39 +0000 (13:37 +0000)]
SKP files have been reverted to old version. Whitespace change to trigger rebuilds.
git-svn-id: http://skia.googlecode.com/svn/trunk@8170
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 15 Mar 2013 12:43:53 +0000 (12:43 +0000)]
Update performance triggers for new skps (also remove all _multi_* triggers)
git-svn-id: http://skia.googlecode.com/svn/trunk@8169
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 15 Mar 2013 07:05:19 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8168
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Fri, 15 Mar 2013 03:15:40 +0000 (03:15 +0000)]
draft for fontmgr
git-svn-id: http://skia.googlecode.com/svn/trunk@8167
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Thu, 14 Mar 2013 18:28:10 +0000 (18:28 +0000)]
All skp files in Google Storage have been updated (AddDashboardAnnotation)
git-svn-id: http://skia.googlecode.com/svn/trunk@8164
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 14 Mar 2013 17:56:58 +0000 (17:56 +0000)]
Add purge all caches to our ashmem wrapper.
THIS IS COMPLETELY UNTESTED
Author: djsollen@google.com
Reviewed By: scroggo@google.com
Review URL: https://chromiumcodereview.appspot.com/
12450016
git-svn-id: http://skia.googlecode.com/svn/trunk@8163
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Thu, 14 Mar 2013 17:24:16 +0000 (17:24 +0000)]
Work around stack overflow
Review URL: https://codereview.appspot.com/
7561043
git-svn-id: http://skia.googlecode.com/svn/trunk@8162
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 14 Mar 2013 16:24:30 +0000 (16:24 +0000)]
shape ops work in progress
cubic tests pass
git-svn-id: http://skia.googlecode.com/svn/trunk@8161
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 14 Mar 2013 15:25:45 +0000 (15:25 +0000)]
fix (bool) warning with SkToBool
git-svn-id: http://skia.googlecode.com/svn/trunk@8160
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 14 Mar 2013 15:19:23 +0000 (15:19 +0000)]
add (dummy) SkFontHost::GetFileName (to fix build, will soon be deprecated)
git-svn-id: http://skia.googlecode.com/svn/trunk@8159
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 14 Mar 2013 15:18:08 +0000 (15:18 +0000)]
fix window's build errors
Author: djsollen@google.com
Reviewed By: bsalomon@google.com,borenet@google.com,reed@google.com
Review URL: https://chromiumcodereview.appspot.com/
12668007
git-svn-id: http://skia.googlecode.com/svn/trunk@8158
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 14 Mar 2013 15:09:40 +0000 (15:09 +0000)]
make OpenStream and GetFileName public ... for now, until we fix FreeType backend.
git-svn-id: http://skia.googlecode.com/svn/trunk@8157
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 14 Mar 2013 15:04:57 +0000 (15:04 +0000)]
move most of SkFontHost to private (preceeding making it all private)
In this change, have to accomodate PDF wanting to call openStream and advancedMetrics
Review URL: https://codereview.chromium.org/
12739006
git-svn-id: http://skia.googlecode.com/svn/trunk@8156
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 14 Mar 2013 14:42:18 +0000 (14:42 +0000)]
Upstream Android modifications to the image encoders/decoders.
This CL does not update the libjpeg as that change is large enough
to warrant its own CL.
Author: djsollen@google.com
Reviewed By: reed@google.com,robertphillips@google.com,scroggo@google.com
Review URL: https://chromiumcodereview.appspot.com/
12604006
git-svn-id: http://skia.googlecode.com/svn/trunk@8155
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 14 Mar 2013 14:41:55 +0000 (14:41 +0000)]
Add libwebp to svn:externals
git-svn-id: http://skia.googlecode.com/svn/trunk@8154
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 14 Mar 2013 13:58:40 +0000 (13:58 +0000)]
Update Android Release build to use -O3.
Author: djsollen@google.com
Reviewed By: borenet@google.com
Review URL: https://chromiumcodereview.appspot.com/
12784006
git-svn-id: http://skia.googlecode.com/svn/trunk@8153
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 14 Mar 2013 12:41:30 +0000 (12:41 +0000)]
Adjust Win7 performance trigger for outliers
git-svn-id: http://skia.googlecode.com/svn/trunk@8149
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 14 Mar 2013 12:04:10 +0000 (12:04 +0000)]
Whitespace change to trigger builds after master restart
git-svn-id: http://skia.googlecode.com/svn/trunk@8148
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 14 Mar 2013 07:02:51 +0000 (07:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8143
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 13 Mar 2013 21:47:56 +0000 (21:47 +0000)]
Fix uninitialized memory access
https://codereview.appspot.com/
7657044/
git-svn-id: http://skia.googlecode.com/svn/trunk@8142
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 13 Mar 2013 21:28:44 +0000 (21:28 +0000)]
have reset() return its argument as a convenience
git-svn-id: http://skia.googlecode.com/svn/trunk@8141
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 13 Mar 2013 21:05:14 +0000 (21:05 +0000)]
Increase bits for effect attribute key.
We can have an attribute index value up to 7, but only allow 2 bits for each
index in GrGLEffect::GenAttribKey. This change gives them 3 bits (and fixes an
assert when running tests in debug).
Review URL: https://codereview.chromium.org/
12431018/
git-svn-id: http://skia.googlecode.com/svn/trunk@8140
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 13 Mar 2013 20:41:48 +0000 (20:41 +0000)]
shape ops -- fix errors
git-svn-id: http://skia.googlecode.com/svn/trunk@8138
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 13 Mar 2013 20:29:41 +0000 (20:29 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@8137
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Wed, 13 Mar 2013 20:01:51 +0000 (20:01 +0000)]
[PDF] Always set the symbolic Flag for Fonts.
This should fix Chrome bug 124572
Review URL: https://codereview.appspot.com/
7631045
git-svn-id: http://skia.googlecode.com/svn/trunk@8136
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 13 Mar 2013 19:03:26 +0000 (19:03 +0000)]
Build fix: accessing uninitialized class member (not)
TBR=sugoi
git-svn-id: http://skia.googlecode.com/svn/trunk@8135
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Wed, 13 Mar 2013 18:31:03 +0000 (18:31 +0000)]
Cut data point upload batch size to 25.
Some bots have lower speed sending http data out, and this will make it less likely to timeout.
Did not try 50 because once we switch to using Chrome dashboard app, extra work needs to be done for each data point which will take longer. Since appengine has the fixed 30s timeout policy, there's not too much we can do unless we convince Chrome to switch to other solutions.
Current Skia data on our app instance: https://skiadash.appspot.com/report
Review URL: https://codereview.chromium.org/
12703008
git-svn-id: http://skia.googlecode.com/svn/trunk@8133
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 13 Mar 2013 17:27:16 +0000 (17:27 +0000)]
Modifying the behavior of render_pictures --validate to test the effect of bbh.
The new behavior consists in using the same renderer, with bbh disabled, as a reference
renderer when the current renderer has a bbh.
Review URL: https://codereview.chromium.org/
12801002
git-svn-id: http://skia.googlecode.com/svn/trunk@8132
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 13 Mar 2013 15:31:11 +0000 (15:31 +0000)]
Use stream usage for dynamic vertex data.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
12799005
git-svn-id: http://skia.googlecode.com/svn/trunk@8129
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 13 Mar 2013 15:25:30 +0000 (15:25 +0000)]
Update bench_expectations & add triggers for N7, Mac 10.8 and Ubuntu
git-svn-id: http://skia.googlecode.com/svn/trunk@8128
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 13 Mar 2013 14:58:41 +0000 (14:58 +0000)]
comment out debugging printfs
git-svn-id: http://skia.googlecode.com/svn/trunk@8127
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 13 Mar 2013 14:18:40 +0000 (14:18 +0000)]
gm: write all messages to stdout/stderr with "GM:" preamble to distinguish from various debug messages coming from elsewhere
Review URL: https://codereview.chromium.org/
12691009
git-svn-id: http://skia.googlecode.com/svn/trunk@8126
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 13 Mar 2013 13:38:30 +0000 (13:38 +0000)]
Remove extraneous paren.
Review URL: https://codereview.chromium.org/
12750004
git-svn-id: http://skia.googlecode.com/svn/trunk@8125
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 13 Mar 2013 12:48:26 +0000 (12:48 +0000)]
refactor android defines to implicitly assume NDK compliance unless it is explicitly marked as being specific to the android framework.
Author: djsollen@google.com
Reviewed By: reed@google.com,borenet@google.com
Review URL: https://chromiumcodereview.appspot.com/
12739007
git-svn-id: http://skia.googlecode.com/svn/trunk@8124
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 13 Mar 2013 11:49:15 +0000 (11:49 +0000)]
Whitespace change to test commit-queue
Author: rmistry@google.com
Reviewed By: borenet@google.com,epoger@google.com
Review URL: https://chromiumcodereview.appspot.com/
12826004
git-svn-id: http://skia.googlecode.com/svn/trunk@8123
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 13 Mar 2013 07:01:04 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8120
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 12 Mar 2013 19:56:49 +0000 (19:56 +0000)]
Fixing crash in render_pictures when failing to create referenceBitmap for --validate
Review URL: https://codereview.chromium.org/
12800002
git-svn-id: http://skia.googlecode.com/svn/trunk@8119
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 12 Mar 2013 19:53:16 +0000 (19:53 +0000)]
Update flag to reflect actual meaning.
Review URL: https://codereview.chromium.org/
12754004
git-svn-id: http://skia.googlecode.com/svn/trunk@8118
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 12 Mar 2013 19:20:22 +0000 (19:20 +0000)]
Disable all multi_*_threads triggers (see issue 1160)
git-svn-id: http://skia.googlecode.com/svn/trunk@8117
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 12 Mar 2013 17:53:53 +0000 (17:53 +0000)]
Fixed unitialized memory access bug in r8106
git-svn-id: http://skia.googlecode.com/svn/trunk@8115
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 12 Mar 2013 17:27:10 +0000 (17:27 +0000)]
Fix GDI device context leak.
https://codereview.appspot.com/
7682044/
git-svn-id: http://skia.googlecode.com/svn/trunk@8113
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 12 Mar 2013 17:16:07 +0000 (17:16 +0000)]
Make graph output optional in bench_graphs_svg
Enables https://codereview.chromium.org/
12785002/
Review URL: https://codereview.chromium.org/
12543019
git-svn-id: http://skia.googlecode.com/svn/trunk@8112
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 12 Mar 2013 16:05:14 +0000 (16:05 +0000)]
Fixed compiler error/warning
git-svn-id: http://skia.googlecode.com/svn/trunk@8110
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Tue, 12 Mar 2013 16:00:54 +0000 (16:00 +0000)]
Add GL program cache tracking.
This may help us track down cases when we change how program keys are generated
and we get invalid misses.
git-svn-id: http://skia.googlecode.com/svn/trunk@8109
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 12 Mar 2013 15:55:47 +0000 (15:55 +0000)]
fix warning: use size_t when comparing to SK_ARRAY_COUNT
git-svn-id: http://skia.googlecode.com/svn/trunk@8108
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 12 Mar 2013 15:41:18 +0000 (15:41 +0000)]
add (temp) SkFontLCDConfig class to hold LCD getters/setters. This will allow
us to make SkFontHost.h private (once webkit switches to the SkFontLCDConfig api)
Stage 2 is to either move this code into chrome/webkit, or change the callers to
perform their own globals management.
Review URL: https://codereview.chromium.org/
12623011
git-svn-id: http://skia.googlecode.com/svn/trunk@8107
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 12 Mar 2013 15:39:44 +0000 (15:39 +0000)]
Refactor PictureRecord optimization & added saveLayer/save/clipR/DBM*/restore/restore optimization
https://codereview.appspot.com/
7485043/
git-svn-id: http://skia.googlecode.com/svn/trunk@8106
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 12 Mar 2013 15:33:40 +0000 (15:33 +0000)]
Fix debugger build errors/warnings
https://codereview.appspot.com/
7729045/
git-svn-id: http://skia.googlecode.com/svn/trunk@8105
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 12 Mar 2013 14:58:49 +0000 (14:58 +0000)]
Whitespace change to test commit-queue reviewers list
(SkipBuildbotRuns)
Author: rmistry@google.com
Reviewed By: borenet@google.com,epoger@google.com
Review URL: https://chromiumcodereview.appspot.com/
12570006
git-svn-id: http://skia.googlecode.com/svn/trunk@8104
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 12 Mar 2013 14:36:57 +0000 (14:36 +0000)]
Removed unused parameters
I removed unused parameters wherever it was trivial to do so.
Review URL: https://codereview.chromium.org/
12772003
git-svn-id: http://skia.googlecode.com/svn/trunk@8103
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 12 Mar 2013 13:13:07 +0000 (13:13 +0000)]
"Fix" case when bicubic filtering warps premultiplied color
https://codereview.appspot.com/
7447048/
git-svn-id: http://skia.googlecode.com/svn/trunk@8096
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 12 Mar 2013 13:07:40 +0000 (13:07 +0000)]
NaCl Debugger: Implement overview and filters, cleanup
(SkipBuildbotRuns) since no bots build the debugger.
Review URL: https://codereview.chromium.org/
12449006
git-svn-id: http://skia.googlecode.com/svn/trunk@8095
2bbb7eff-a529-9590-31e7-
b0007b416f81